From nobody Tue Feb 10 21:00:25 2026 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03BB62236FF for ; Fri, 25 Apr 2025 21:09:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615383; cv=none; b=fLCDCPZXwyIFVWNPYD5dQFs5+i9h638+/tS9uShInK7MzhoydizO6ZYskLTRFkQJ/CyBVjkCNiin1HMXMEyEGszyRJpn5qV0L/zrW5cc6Px6zLKfUknA/JXQq1f99RpdXwb3utrjAgplZ/Io/kvYPJyXz9nq6XeHS7Xf5F9XI+E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615383; c=relaxed/simple; bh=NLK9rHWGxHgHc450e6JA3Kx5J3+N1Fpz21XOi57G4v0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d5XJf/ga95bSyRhPhCRGPkKKAPfeBo6BAkOBPgiss7yP3PXRTw/RBLmlHiGG1FwMX84Dq6zKSIjKKCxG4xV/EHLKt+44HUZ94Wpt5cwpiDtOx9Xf3qku9SzhSqWLyeAtmeWWInl5Psk/4L1ImWzzSsuEg9oE2h7zYhMhjKm3CCs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=qiOjvBV3; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="qiOjvBV3" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-72c7336ed99so750546a34.0 for ; Fri, 25 Apr 2025 14:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745615380; x=1746220180; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B2koMhN4hR5KSSnBsIlIFgfxzAiKDp/j1dG+oyh3qTA=; b=qiOjvBV3Jq3l0J78a7B5QTmd0v5vcv/cOPQDFJaeW6/7HP+rtVagnHpaucX5Km130O q2CUSpTppullb9rqe9RvaT4BaLJ21nd5roiP4ddSwXoQAysjxeJa+YgN0YC75prGgpd0 z79UAfW0K5g7zsrYQ5gFFohR9NF2Mw0GYKQcuq92zoSAh+Bp1C7v4vBWrn8yFAIYQwth nZcr7ZPGuomrfVLv/BOpW72R9xusjaNgpTIIYgE5YonEayZJiC4DdcjUV+3dAVqbSWqG 1Pwmp0ZFwDv6TIDU+Jq90D6cSypohfalKWNmSDad5n0J6LXcUEeMom/F1BBnOX8185IS Xduw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745615380; x=1746220180; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B2koMhN4hR5KSSnBsIlIFgfxzAiKDp/j1dG+oyh3qTA=; b=DDkd5aiGoxGeoaj7Kz49cYjJcMyfnjp93j+ZxjQPdXLJZRgfJn5+oc7CMW2mp6gwmF xMAPaYVizj2AAOXxvDUG6ZzXDyfzLl1S6hA5A9KqutzxL9S6YPK2EnZCbI0frZOtrw6/ 4yNE3tg5C31OhfdNZTv6urqKlzeCmITxTB7VX6/gZhkvBzC0KcPNRgGFPt7V8LQQZQTm RhnGLT7RM1QWDfL2nCv9nASp439IbacM77qXwEhE9YJcfpmlw/r2wid7BD8UYnnHNk+y qlIwI5E16HaT7lUZEGHyBEVcWTBHimWgAmWSNZacFLYyJqKsq6Nx/KGx1sS5bIZwnrvx UHuA== X-Forwarded-Encrypted: i=1; AJvYcCW/EqrKyu8MhuekMhFe5w7xpHyEl4OEPakAZ1RiO2wAAq9Ckae2FzR1MwgOXw0+w8kWbsERqYQjejLtsKk=@vger.kernel.org X-Gm-Message-State: AOJu0YwbzsoZkr5wFVKLxaG9jqdK7veMJT+Gk3iY/i+b3LKhLCivqNMo BFAZfSKId2ZxQSgvtRt3MngscdZukGrcEBEbQwcurys1SpkDOddBnIrTBLnFo3s= X-Gm-Gg: ASbGncsKg05poEl+WP4Z1TKm5MsTh2oNsp0HZkQp0HAD/j5gPLVf59I0AKH4m1Mcpxi 8RFq/azvmeGmJ84nBfXaJUI93F3+DMNgkWlAhvMoayYZAFfmfsqqaUJ6UA13OI6m45p9qDtvZYZ pMfzAyOwRfzi+4F/5nyuzQNnl+aoSfy5L72uulmmyigRRcsen2eJPHvJuR2NJC879wZd/qkTKmB 0aGlnfyjaZTNVNDwmepAXVOeeMjdc0SxC5lY7Wcghr5X+crTxs8Ir1H/v4W79+9uEsun9ETm1g5 Q1qxwzG/K55Bg1/dZ79q85FG1atMlRcb7KAKljaDTALO X-Google-Smtp-Source: AGHT+IGKc5OoUlGqAMHb8DxpInuVuqSVZZrq1V/GWDAa8RVUKrWc/HhQWHVIWR6LgXFCY+EudsWgsg== X-Received: by 2002:a05:6830:6103:b0:727:423c:95d5 with SMTP id 46e09a7af769-7306507d10cmr827931a34.3.1745615380147; Fri, 25 Apr 2025 14:09:40 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:96a3:e28:3f6:dbac]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7304f188052sm847673a34.8.2025.04.25.14.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 14:09:39 -0700 (PDT) From: David Lechner Date: Fri, 25 Apr 2025 16:08:44 -0500 Subject: [PATCH v3 2/6] iio: adc: ad4695: use u16 for buffer elements Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-2-f12df1bff248@baylibre.com> References: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> In-Reply-To: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2149; i=dlechner@baylibre.com; h=from:subject:message-id; bh=NLK9rHWGxHgHc450e6JA3Kx5J3+N1Fpz21XOi57G4v0=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoC/ntGikd68zhc3eGez4DLRFRcNXynKp9dhqTH axf3aMkGNaJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAv57QAKCRDCzCAB/wGP wAgDB/0auzgk1L/frm29yKaf4b3PEH/of/+PWSRx7XnDdBIbgId0dZU5fPeSrZtK//pb6MguHyN pTTAJcteQG4JB7+lSY0FCltwzuC5VL5jILT78ZTc1OQSZOLlXMv5G/33kUicVLCye+/ZcIXb2Rf THjJLuO79tWICuwLYeVk2U0crzcotqLF7rh2Fu//4nJSwLA2M/fdrYuiM4qEDJlOoefh8JF7yzn XtNeHkRbFNpzbav0+yO0YJaZcvWqhlO38PygEOGYZx2PqrEf1nCTf0H1GcUW12Q5d2k3VtsuIWJ nmljWyL2JcplY+E4L/eTEtrhLk28n0o4NXRxjJBaGpjmBBOr X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Change the type of the buffer elements to u16 since we currently only support 16-bit word size. The code was originally written to also allow for 32-bit word size when oversampling is enabled, but so far, oversampling is only implemented when using SPI offload and therefore doesn't use this buffer. AD4695_MAX_CHANNEL_SIZE macro is dropped since it no longer adds any value. AD4695_MAX_CHANNELS + 2 is changed to AD4695_MAX_CHANNELS + 1 because previously we were overallocating. AD4695_MAX_CHANNELS is the number of of voltage channels and + 1 is for the temperature channel. Signed-off-by: David Lechner --- drivers/iio/adc/ad4695.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad4695.c b/drivers/iio/adc/ad4695.c index 68c6625db0d75f4cade7cb029e94191118dbcaa0..0c633d43e480d5404074e9fa35f= 1d330b448f0a2 100644 --- a/drivers/iio/adc/ad4695.c +++ b/drivers/iio/adc/ad4695.c @@ -106,8 +106,6 @@ =20 /* Max number of voltage input channels. */ #define AD4695_MAX_CHANNELS 16 -/* Max size of 1 raw sample in bytes. */ -#define AD4695_MAX_CHANNEL_SIZE 2 =20 enum ad4695_in_pair { AD4695_IN_PAIR_REFGND, @@ -162,8 +160,8 @@ struct ad4695_state { struct spi_transfer buf_read_xfer[AD4695_MAX_CHANNELS * 2 + 3]; struct spi_message buf_read_msg; /* Raw conversion data received. */ - u8 buf[ALIGN((AD4695_MAX_CHANNELS + 2) * AD4695_MAX_CHANNEL_SIZE, - sizeof(s64)) + sizeof(s64)] __aligned(IIO_DMA_MINALIGN); + u16 buf[ALIGN((AD4695_MAX_CHANNELS + 1) * sizeof(u16), + sizeof(s64)) + sizeof(s64)] __aligned(IIO_DMA_MINALIGN); u16 raw_data; /* Commands to send for single conversion. */ u16 cnv_cmd; @@ -660,9 +658,8 @@ static int ad4695_buffer_preenable(struct iio_dev *indi= o_dev) iio_for_each_active_channel(indio_dev, bit) { xfer =3D &st->buf_read_xfer[num_xfer]; xfer->bits_per_word =3D 16; - xfer->rx_buf =3D &st->buf[rx_buf_offset]; + xfer->rx_buf =3D &st->buf[rx_buf_offset++]; xfer->len =3D 2; - rx_buf_offset +=3D xfer->len; =20 if (bit =3D=3D temp_chan_bit) { temp_en =3D 1; --=20 2.43.0