From nobody Mon Feb 9 22:56:01 2026 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EC951B414B for ; Fri, 25 Apr 2025 21:09:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615382; cv=none; b=dmM3oN1thNPsWDbrstsndMj0rXCWFJUnGJ45e+GUr9Trb9QGwYQ1MqENPbNBRm+Hpyjeane5eTgDSBkd7cRK5Ys6I+VGtiYdRzKMyJhxDguYUOAHNhkD3NbqSr6xYQXzP+Gv/qdvbTvOAcfyLkqcw8pGc2NFXZUSYpVzqZoBfqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615382; c=relaxed/simple; bh=S9yyrbbGceERU79hEYcii6LVQfguSKjlkyu5n+UlTsA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sLRPXTtDHuRlvrJwX0NgDVhZi3Oj/K7v+vpFeqhN7acimPkTi7LGnRqrFluq7NU3wa9WPOPc/uFeEo7MHla7g3RJnjLdrXNUccbmgbjuiAFVQC4SEFt0E9lNn8RNgmrOoaub+hKvHOxhc/rK1/2ePBYHEDBRmvSg37pUqjnl8CY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=GAnSa7F5; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="GAnSa7F5" Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-2c769da02b0so2274960fac.3 for ; Fri, 25 Apr 2025 14:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745615379; x=1746220179; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BY1aWIkNQr9/WlVdM/imYDbUDJ4FCN12j5sBaq8Ups4=; b=GAnSa7F5xF9OG+cfKIBYF6rZ8E0vWFuGHxyOO9QzT6D8FFe/l8KR9MvD6EdVYViFIZ 9GzjKYcDugPK9IPo7VIz1IO3AnAkOSjUfGfm+h/YpaIFcjHsGzp518RxAEXCzpT055eh 2q8aTe1Sl8vbCBh8kE6KsjE/AgGcA8NcAdm9HgLHT/8pCHEiudD5BInzkfZmbM2y+U76 vi2mSKf21N00vg5SFOn5u2VBtoLLzYLtuz99y5w/ZXIsy+QGu9UDCQ2GNoXVxJ9fWeyi nFVkcFX+XL6EARhp22GczlH+1y48lvjItRGZmlbhEQPGkA9D69Af5BHX8CbNmFYGMUr2 rCzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745615379; x=1746220179; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BY1aWIkNQr9/WlVdM/imYDbUDJ4FCN12j5sBaq8Ups4=; b=wWRKGlNo/kPs0R4ka2I/HPE/ubnBhgXzDH9extDD+k7fAnM+JF2C4YXUUuXCkMXVXK CYA3e66MDbYzPXxOi4nRvJG/ihudwksi1P6N1PgbyEiqu++zSI/ELqSENGnDsW7K7gQd nT4JjB78GlgopBuXBycKFY/+UIfIlwxkSTWOf6DQtuL2bXc+RwuWzI7EPmvoDRrrPzEM iFUZqYPRHS21O7r5ggix5Nkr0saUmYW/W/JDGqOWp2otxxMylFKn9ToHBy2SyJdXrD4x cta9TDwGbCiqWAB35f6s074Ic/u1YSz+qvtugZNgx/xkFJltYNrnOo61JTQX1u2ld5TX mCiw== X-Forwarded-Encrypted: i=1; AJvYcCU2t9NnWiPA/kJFRrlSHAffHty9JaU6lHlu9tlqjPy3lumPh5RW1kOucUbM3HrRzkv1035bSWUo6IGdFTo=@vger.kernel.org X-Gm-Message-State: AOJu0YwrwStxdWUAF1Y5iAJTwmIr+jnkbOXDjEbYZj2bCw8yQ/GNtSwl /ayfBIanmzmDI8DSDIc6aaEwEQDH0USX5FExexGpQxbf99FeqHxjsOm532Luzes= X-Gm-Gg: ASbGncvomAJ80f6+J34EaJcNWbvIM9UCCfMzeOv4IrokpihCiS/P/2R2IntzL9Bviii gPtNoBfdL9/aVJ2jgBIk19H0458ZBcAaiBSpnPGbagz+FhRo+d+uTejsbIAenAqlPdpVUgktktq 46deF4pihilb5+e9VSVLRkrDdpmQ0PLPq4/WgF7YDIiEy8cg/k4p+CAZNdZAME5oTQH19GziFsy Qb7bD3S0J6kSlE9qIWeGQPneVb60fmXlaTi9xXaMDSrr+S/CzXR2quPih9qO6hEDkXpWFO5zpyo UqYhQieR7ZWf2/ajPDGoLpLRvtL6lJKEnA/IdafIuqI1C213Cxq1iEc= X-Google-Smtp-Source: AGHT+IHgoMZkBfZXhz5aqoIzlRTV+NaG/N/wVFvnLQMLS1D8aZCmMXkvEWmf1mqpeRfkisZn7+z95Q== X-Received: by 2002:a05:6871:792:b0:29e:4ba5:4ddc with SMTP id 586e51a60fabf-2d99db25561mr2208324fac.24.1745615379304; Fri, 25 Apr 2025 14:09:39 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:96a3:e28:3f6:dbac]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7304f188052sm847673a34.8.2025.04.25.14.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 14:09:38 -0700 (PDT) From: David Lechner Date: Fri, 25 Apr 2025 16:08:43 -0500 Subject: [PATCH v3 1/6] iio: introduce IIO_DECLARE_BUFFER_WITH_TS macros Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-1-f12df1bff248@baylibre.com> References: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> In-Reply-To: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3719; i=dlechner@baylibre.com; h=from:subject:message-id; bh=S9yyrbbGceERU79hEYcii6LVQfguSKjlkyu5n+UlTsA=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoC/nm4JmFy6kPkiyqKsDPXMzKl5mRSVcD8MkmU knBSH8PgtKJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAv55gAKCRDCzCAB/wGP wJSvB/9gSprhYoKqm17uZXVZ6jJRFmsaX8jyoqQBaLCQeqXZdb0j74O/nlC316k+qfISf3o34yh /ZAovdK45qS71p3Y20kH3CqNKHpCUgnttFXhEdWcgNjsFcFr/UMUQw/M5T7sQTpYgxl/8sD88KJ f4tZd53Vyn5wkQq2ELL4SUF4oVvta5WyOAK5S7/tCmuGLWyJqC1j9ihqeiifuzZRZf+ypJPu4oD GxQdYZxyVLx+fmM0y832hdBwp/gcd4J4TH6K3ll5OlYcCJvk7n8SPI0Hjl3egeYyk196dIcMKzf B6ZjyRXK7+EJ+iq2t/OBgh4tZOCC5h/5hli4azVUGDAMwFoA X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Add new macros to help with the common case of declaring a buffer that is safe to use with iio_push_to_buffers_with_ts(). This is not trivial to do correctly because of the alignment requirements of the timestamp. This will make it easier for both authors and reviewers. To avoid double __align() attributes in cases where we also need DMA alignment, add a 2nd variant IIO_DECLARE_DMA_BUFFER_WITH_TS(). Signed-off-by: David Lechner --- v3 changes: * Use leading double-underscore for "private" macro to match "private" functions that do the same. * Use static_assert() from linux/build_bug.h instead of _Static_assert() * Fix incorrectly using sizeof(IIO_DMA_MINALIGN). * Add check that count argument is constant. (Note, I didn't include a message in this static assert because it already gives a reasonable message.) /home/david/work/bl/linux/drivers/iio/accel/sca3300.c:482:51: error: expres= sion in static assertion is not constant 482 | IIO_DECLARE_BUFFER_WITH_TS(s16, channels, val); | ^~~ v2 changes: * Add 2nd macro for DMA alignment --- include/linux/iio/iio.h | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h index 638cf2420fbd85cf2924d09d061df601d1d4bb2a..1115b219271b76792539931edc4= 04a67549bd8b1 100644 --- a/include/linux/iio/iio.h +++ b/include/linux/iio/iio.h @@ -7,6 +7,8 @@ #ifndef _INDUSTRIAL_IO_H_ #define _INDUSTRIAL_IO_H_ =20 +#include +#include #include #include #include @@ -777,6 +779,42 @@ static inline void *iio_device_get_drvdata(const struc= t iio_dev *indio_dev) * them safe for use with non-coherent DMA. */ #define IIO_DMA_MINALIGN ARCH_DMA_MINALIGN + +#define __IIO_DECLARE_BUFFER_WITH_TS(type, name, count) \ + static_assert(count); \ + type name[ALIGN((count), sizeof(s64) / sizeof(type)) + sizeof(s64) / size= of(type)] + +/** + * IIO_DECLARE_BUFFER_WITH_TS() - Declare a buffer with timestamp + * @type: element type of the buffer + * @name: identifier name of the buffer + * @count: number of elements in the buffer + * + * Declares a buffer that is safe to use with iio_push_to_buffer_with_ts()= . In + * addition to allocating enough space for @count elements of @type, it al= so + * allocates space for a s64 timestamp at the end of the buffer and ensures + * proper alignment of the timestamp. + */ +#define IIO_DECLARE_BUFFER_WITH_TS(type, name, count) \ + __IIO_DECLARE_BUFFER_WITH_TS(type, name, count) __aligned(sizeof(s64)) + +/** + * IIO_DECLARE_DMA_BUFFER_WITH_TS() - Declare a DMA-aligned buffer with ti= mestamp + * @type: element type of the buffer + * @name: identifier name of the buffer + * @count: number of elements in the buffer + * + * Same as IIO_DECLARE_BUFFER_WITH_TS(), but is uses __aligned(IIO_DMA_MIN= ALIGN) + * to ensure that the buffer doesn't share cachelines with anything that c= omes + * before it in a struct. This should not be used for stack-allocated buff= ers + * as stack memory cannot generally be used for DMA. + */ +#define IIO_DECLARE_DMA_BUFFER_WITH_TS(type, name, count) \ + __IIO_DECLARE_BUFFER_WITH_TS(type, name, count) __aligned(IIO_DMA_MINALIG= N) + +static_assert(IIO_DMA_MINALIGN % sizeof(s64) =3D=3D 0, + "macros above assume that IIO_DMA_MINALIGN also ensures s64 timestamp ali= gnment"); + struct iio_dev *iio_device_alloc(struct device *parent, int sizeof_priv); =20 /* The information at the returned address is guaranteed to be cacheline a= ligned */ --=20 2.43.0 From nobody Mon Feb 9 22:56:01 2026 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03BB62236FF for ; Fri, 25 Apr 2025 21:09:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615383; cv=none; b=fLCDCPZXwyIFVWNPYD5dQFs5+i9h638+/tS9uShInK7MzhoydizO6ZYskLTRFkQJ/CyBVjkCNiin1HMXMEyEGszyRJpn5qV0L/zrW5cc6Px6zLKfUknA/JXQq1f99RpdXwb3utrjAgplZ/Io/kvYPJyXz9nq6XeHS7Xf5F9XI+E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615383; c=relaxed/simple; bh=NLK9rHWGxHgHc450e6JA3Kx5J3+N1Fpz21XOi57G4v0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d5XJf/ga95bSyRhPhCRGPkKKAPfeBo6BAkOBPgiss7yP3PXRTw/RBLmlHiGG1FwMX84Dq6zKSIjKKCxG4xV/EHLKt+44HUZ94Wpt5cwpiDtOx9Xf3qku9SzhSqWLyeAtmeWWInl5Psk/4L1ImWzzSsuEg9oE2h7zYhMhjKm3CCs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=qiOjvBV3; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="qiOjvBV3" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-72c7336ed99so750546a34.0 for ; Fri, 25 Apr 2025 14:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745615380; x=1746220180; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B2koMhN4hR5KSSnBsIlIFgfxzAiKDp/j1dG+oyh3qTA=; b=qiOjvBV3Jq3l0J78a7B5QTmd0v5vcv/cOPQDFJaeW6/7HP+rtVagnHpaucX5Km130O q2CUSpTppullb9rqe9RvaT4BaLJ21nd5roiP4ddSwXoQAysjxeJa+YgN0YC75prGgpd0 z79UAfW0K5g7zsrYQ5gFFohR9NF2Mw0GYKQcuq92zoSAh+Bp1C7v4vBWrn8yFAIYQwth nZcr7ZPGuomrfVLv/BOpW72R9xusjaNgpTIIYgE5YonEayZJiC4DdcjUV+3dAVqbSWqG 1Pwmp0ZFwDv6TIDU+Jq90D6cSypohfalKWNmSDad5n0J6LXcUEeMom/F1BBnOX8185IS Xduw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745615380; x=1746220180; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B2koMhN4hR5KSSnBsIlIFgfxzAiKDp/j1dG+oyh3qTA=; b=DDkd5aiGoxGeoaj7Kz49cYjJcMyfnjp93j+ZxjQPdXLJZRgfJn5+oc7CMW2mp6gwmF xMAPaYVizj2AAOXxvDUG6ZzXDyfzLl1S6hA5A9KqutzxL9S6YPK2EnZCbI0frZOtrw6/ 4yNE3tg5C31OhfdNZTv6urqKlzeCmITxTB7VX6/gZhkvBzC0KcPNRgGFPt7V8LQQZQTm RhnGLT7RM1QWDfL2nCv9nASp439IbacM77qXwEhE9YJcfpmlw/r2wid7BD8UYnnHNk+y qlIwI5E16HaT7lUZEGHyBEVcWTBHimWgAmWSNZacFLYyJqKsq6Nx/KGx1sS5bIZwnrvx UHuA== X-Forwarded-Encrypted: i=1; AJvYcCW/EqrKyu8MhuekMhFe5w7xpHyEl4OEPakAZ1RiO2wAAq9Ckae2FzR1MwgOXw0+w8kWbsERqYQjejLtsKk=@vger.kernel.org X-Gm-Message-State: AOJu0YwbzsoZkr5wFVKLxaG9jqdK7veMJT+Gk3iY/i+b3LKhLCivqNMo BFAZfSKId2ZxQSgvtRt3MngscdZukGrcEBEbQwcurys1SpkDOddBnIrTBLnFo3s= X-Gm-Gg: ASbGncsKg05poEl+WP4Z1TKm5MsTh2oNsp0HZkQp0HAD/j5gPLVf59I0AKH4m1Mcpxi 8RFq/azvmeGmJ84nBfXaJUI93F3+DMNgkWlAhvMoayYZAFfmfsqqaUJ6UA13OI6m45p9qDtvZYZ pMfzAyOwRfzi+4F/5nyuzQNnl+aoSfy5L72uulmmyigRRcsen2eJPHvJuR2NJC879wZd/qkTKmB 0aGlnfyjaZTNVNDwmepAXVOeeMjdc0SxC5lY7Wcghr5X+crTxs8Ir1H/v4W79+9uEsun9ETm1g5 Q1qxwzG/K55Bg1/dZ79q85FG1atMlRcb7KAKljaDTALO X-Google-Smtp-Source: AGHT+IGKc5OoUlGqAMHb8DxpInuVuqSVZZrq1V/GWDAa8RVUKrWc/HhQWHVIWR6LgXFCY+EudsWgsg== X-Received: by 2002:a05:6830:6103:b0:727:423c:95d5 with SMTP id 46e09a7af769-7306507d10cmr827931a34.3.1745615380147; Fri, 25 Apr 2025 14:09:40 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:96a3:e28:3f6:dbac]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7304f188052sm847673a34.8.2025.04.25.14.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 14:09:39 -0700 (PDT) From: David Lechner Date: Fri, 25 Apr 2025 16:08:44 -0500 Subject: [PATCH v3 2/6] iio: adc: ad4695: use u16 for buffer elements Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-2-f12df1bff248@baylibre.com> References: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> In-Reply-To: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2149; i=dlechner@baylibre.com; h=from:subject:message-id; bh=NLK9rHWGxHgHc450e6JA3Kx5J3+N1Fpz21XOi57G4v0=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoC/ntGikd68zhc3eGez4DLRFRcNXynKp9dhqTH axf3aMkGNaJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAv57QAKCRDCzCAB/wGP wAgDB/0auzgk1L/frm29yKaf4b3PEH/of/+PWSRx7XnDdBIbgId0dZU5fPeSrZtK//pb6MguHyN pTTAJcteQG4JB7+lSY0FCltwzuC5VL5jILT78ZTc1OQSZOLlXMv5G/33kUicVLCye+/ZcIXb2Rf THjJLuO79tWICuwLYeVk2U0crzcotqLF7rh2Fu//4nJSwLA2M/fdrYuiM4qEDJlOoefh8JF7yzn XtNeHkRbFNpzbav0+yO0YJaZcvWqhlO38PygEOGYZx2PqrEf1nCTf0H1GcUW12Q5d2k3VtsuIWJ nmljWyL2JcplY+E4L/eTEtrhLk28n0o4NXRxjJBaGpjmBBOr X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Change the type of the buffer elements to u16 since we currently only support 16-bit word size. The code was originally written to also allow for 32-bit word size when oversampling is enabled, but so far, oversampling is only implemented when using SPI offload and therefore doesn't use this buffer. AD4695_MAX_CHANNEL_SIZE macro is dropped since it no longer adds any value. AD4695_MAX_CHANNELS + 2 is changed to AD4695_MAX_CHANNELS + 1 because previously we were overallocating. AD4695_MAX_CHANNELS is the number of of voltage channels and + 1 is for the temperature channel. Signed-off-by: David Lechner --- drivers/iio/adc/ad4695.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad4695.c b/drivers/iio/adc/ad4695.c index 68c6625db0d75f4cade7cb029e94191118dbcaa0..0c633d43e480d5404074e9fa35f= 1d330b448f0a2 100644 --- a/drivers/iio/adc/ad4695.c +++ b/drivers/iio/adc/ad4695.c @@ -106,8 +106,6 @@ =20 /* Max number of voltage input channels. */ #define AD4695_MAX_CHANNELS 16 -/* Max size of 1 raw sample in bytes. */ -#define AD4695_MAX_CHANNEL_SIZE 2 =20 enum ad4695_in_pair { AD4695_IN_PAIR_REFGND, @@ -162,8 +160,8 @@ struct ad4695_state { struct spi_transfer buf_read_xfer[AD4695_MAX_CHANNELS * 2 + 3]; struct spi_message buf_read_msg; /* Raw conversion data received. */ - u8 buf[ALIGN((AD4695_MAX_CHANNELS + 2) * AD4695_MAX_CHANNEL_SIZE, - sizeof(s64)) + sizeof(s64)] __aligned(IIO_DMA_MINALIGN); + u16 buf[ALIGN((AD4695_MAX_CHANNELS + 1) * sizeof(u16), + sizeof(s64)) + sizeof(s64)] __aligned(IIO_DMA_MINALIGN); u16 raw_data; /* Commands to send for single conversion. */ u16 cnv_cmd; @@ -660,9 +658,8 @@ static int ad4695_buffer_preenable(struct iio_dev *indi= o_dev) iio_for_each_active_channel(indio_dev, bit) { xfer =3D &st->buf_read_xfer[num_xfer]; xfer->bits_per_word =3D 16; - xfer->rx_buf =3D &st->buf[rx_buf_offset]; + xfer->rx_buf =3D &st->buf[rx_buf_offset++]; xfer->len =3D 2; - rx_buf_offset +=3D xfer->len; =20 if (bit =3D=3D temp_chan_bit) { temp_en =3D 1; --=20 2.43.0 From nobody Mon Feb 9 22:56:01 2026 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3B77221DAA for ; Fri, 25 Apr 2025 21:09:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615383; cv=none; b=d61ZIUF9L7KVcIx886zC0iS7jwovkTYvirOskOBsciApd4c5JcfcQJO1atFniO1vSLvbMlDKmARjbpB8NecZeI+fdzsVxUb2NjcUgUojXwozfcCuJSAJ5a5VOSnbYf70mFpRGhWnawF8SGYhm0LJfU08GT7aIa6Ev7o+0TgcoyU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615383; c=relaxed/simple; bh=J4aWhg+jCqZDPjq8gAC6cdfS6rEoLENhaBlAy0BO4RQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r3o88WVQJYP3jYZxQCV7n/fhO2Yo+3CLoMBNcptk5ob8MsZr+TMmrs/y7Wz8CUBG6dIfp3qemPDkKthSr0jZ1BPaqZUfL+f6C4QYDndwN4bOS4xnDPFQ0sNX9qpu1n8ZGXm3IUxKMiJcy/Sw6PjZpnOYGhFbDe0l15jlb7MkORM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=bu4fwo37; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="bu4fwo37" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-72bd5f25ea6so774771a34.1 for ; Fri, 25 Apr 2025 14:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745615381; x=1746220181; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rTje6aj5o1aqilClKP/XjHDRm21nPtMuz4RymFa7ygU=; b=bu4fwo378sJunVsKlzrGzCsleLID3A46KCck6gxLWoXDsCwQZkMS8P9YSo+MRVkFAe cOVOjrFQCppBr28iUFVlV84WrFf+cJYXplBIcEVgUWymsTMTwWy3qT5OD9wioVH2P2GM v2vQ3YkUPCHr9U9nYfJXFwBJAxXc0K4DxSxizNvPyT0liKZKFLfNaHUtllztQhE6Bntj /kLFk33nUQ1Ur6WNeo2BaegeBf9EiiKxugkQcIvGpCo4Qv/dBLM68BPZJef6krrtJPcX LPRp1RzETKGZD30k1BS3AX8Zb8Mf73uVpUpZ9JlYe201SEvZWdLmjDGhA1al71opzqH8 a7Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745615381; x=1746220181; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rTje6aj5o1aqilClKP/XjHDRm21nPtMuz4RymFa7ygU=; b=BmmRZQa1DmlvO+JCP71bhv5dCIeXdE+waoh5mCtu9ki8YkSXSBKxhvi2VnNrSitGAd YGN2yMObdLh9hlvh/CcVfp7wudN3tfXp5S6HPjxhBbfmJextHmovZ4WQDNkSSLLebQCT dHgskxuTHK9WAbo3otj+aD+eF89d4BBxORIP+Kqa8PzsRXVzantA55ArxIvG96ShH+y1 ZfnMvOE0zB4VbwBw4aZWP47kxsFc6f/TFla22WDCuKjINrQMBeRFCfMHdG3ygpnj8n+T ciQvL4uKRYmJco6hAxDDX1p2po1bR6xlCbvPc1HZ/nBSBX5f/MhjwXLllOGsh7g8WRCj pHNg== X-Forwarded-Encrypted: i=1; AJvYcCUqzgYZwi4X/byciwGbfsEBFGqhZ+0anBSYLse3jvwagoQUo30C3xdf8vPR3e+5OkbLt/vYHmV9Yw8RckM=@vger.kernel.org X-Gm-Message-State: AOJu0YxZgZK4rbSy8t6c3ctG/abMTXFRn6H5ZYpHxlfEnj5x03JqJ65e p8IdrcOP8R2ZA04Ya45oaNzZJwmPSi/MP0GNlnZ2iEU+deOejDUm/ZN53E5O12E= X-Gm-Gg: ASbGnctLUdqjsELIrzEZkS6hrO6bLw/xLWqPwd2/XR5v0gj0lJl67HtEvAsBgs7ucmO bgCSYzBjFWHaFchi1SHNffC7zedNxpfsu2Tpci7ADt3bUVSI1zw2EdCMc3kt1yHJSWobTwtRMkW x01+oBSChdcE8JWgUoDqDjNwyd3wBfri3z2FxE2/8mzd9Tgi7rrnw/dIi6X8GpLFRkkWg4EswuO KBi7wHYqQr+CvyHDwq3UWZGZxAO9maxZO5sv+T+SQIT8eQNRnf62D2ua8AxHoiplc0vGIW1KegR L8rsElAGSqDqRHma+B262FPerd2MRMIHOpDCF4bHpA9Z X-Google-Smtp-Source: AGHT+IEcQjGHfz0Vi3BvNBX48+ecmEcPhmsk9/MYoCP6D6pdFOSfKrM1FruQndnBcm94B+h/H2rZ2g== X-Received: by 2002:a05:6830:6c16:b0:72c:3289:ab9e with SMTP id 46e09a7af769-7306528fbbamr856930a34.27.1745615380993; Fri, 25 Apr 2025 14:09:40 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:96a3:e28:3f6:dbac]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7304f188052sm847673a34.8.2025.04.25.14.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 14:09:40 -0700 (PDT) From: David Lechner Date: Fri, 25 Apr 2025 16:08:45 -0500 Subject: [PATCH v3 3/6] iio: adc: ad4695: use IIO_DECLARE_DMA_BUFFER_WITH_TS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-3-f12df1bff248@baylibre.com> References: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> In-Reply-To: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1021; i=dlechner@baylibre.com; h=from:subject:message-id; bh=J4aWhg+jCqZDPjq8gAC6cdfS6rEoLENhaBlAy0BO4RQ=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoC/n0uazZp0mcIAzLz3ELaYXnTAaEE8b6z76v5 3lgVH0/dBSJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAv59AAKCRDCzCAB/wGP wE0UB/wO2o0M3Ij2ucEK4asG4o5GLQvawEfQD4eAcTlSfGKy0hEFnUV2QpnV3Dirc1dIuIPdPfE 3/JAM7GHw/EnVXqb1DGA7rO7sRns+9orKw98lIt2llIRHyzUrxlbqMxdI7Ujxm3w99YhuStdHh3 DOkCSYK9azmC6DfAIcC04TxnvXBa/Bq9RjfXy5LDvFTBNOcf9W52RI9sLIlO49GmBpFlCcN9o8H Mncbxr/fGo0L+38XEIcYXHUOCnx/MJozw0Wg+hLA8HOhm9r5JlJFln2hfBI9cJ3qwNp0tSJdW57 0hTAqvyhB/HJX42GIhLlbj/8qnhuv4PcrCZ0t4oaZCsdAUTV X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use IIO_DECLARE_DMA_BUFFER_WITH_TS() to declare the buffer that gets used with iio_push_to_buffers_with_ts(). This makes the code a bit easier to read and understand. Signed-off-by: David Lechner --- drivers/iio/adc/ad4695.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad4695.c b/drivers/iio/adc/ad4695.c index 0c633d43e480d5404074e9fa35f1d330b448f0a2..992abf6c63b51dee222caf624e1= 72455fb9b9900 100644 --- a/drivers/iio/adc/ad4695.c +++ b/drivers/iio/adc/ad4695.c @@ -160,8 +160,7 @@ struct ad4695_state { struct spi_transfer buf_read_xfer[AD4695_MAX_CHANNELS * 2 + 3]; struct spi_message buf_read_msg; /* Raw conversion data received. */ - u16 buf[ALIGN((AD4695_MAX_CHANNELS + 1) * sizeof(u16), - sizeof(s64)) + sizeof(s64)] __aligned(IIO_DMA_MINALIGN); + IIO_DECLARE_DMA_BUFFER_WITH_TS(u16, buf, AD4695_MAX_CHANNELS + 1); u16 raw_data; /* Commands to send for single conversion. */ u16 cnv_cmd; --=20 2.43.0 From nobody Mon Feb 9 22:56:01 2026 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5B1B2248B5 for ; Fri, 25 Apr 2025 21:09:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615384; cv=none; b=MQS7Pmy5Xi1VphgJTZgH0nlyc23lhkjell1W7BHDBzayn4aQuC+wbsG7tBfrvbV4ZaUpSh2ZAgyNMpi+WcbD1fpFsxk7r4s3m69UW3HoWQ2C/ni7oNFoqSWVuK/AzPENj4sz1VwcPZ+AdxY6DuFab2UpkAsAS5dgrOBRHh9F+4w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615384; c=relaxed/simple; bh=Vr9wDkA3SNoSLT9FCnDYkBa0JumGawTzg2ZkCcTYUYM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XkoNZJnf3AUPzvwNDbHJR3LMcnTFHlaL0TB/bdsUtmFk/ajZ+p5RdHCgpy/kM2WsGQSvDibNVWdam20NF785nwVhMby1n3xZrm5+xpSoyqxG22BT/gqf1u9SGKDlRkV80pQcSCsQ2n+qafbJ6Ne5x9H2m/Pn64OZs8SYMNmf/v4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Dr7Y/nJR; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Dr7Y/nJR" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-72c3b863b8eso2147732a34.2 for ; Fri, 25 Apr 2025 14:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745615382; x=1746220182; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uIY1UYaU1fvtHky+5YvUDY5xMfkarvlEBEV1oBc96LA=; b=Dr7Y/nJR8i1ldlUICIw+SVcx7th21GceAbUditOvLJHtiz/twT0F4myhZM4uyOgtbB IoEDrIu4chAhNSV1dGNz/4etW4mnxbMC2fMvSLn8zdHmwi0YuY9KQ0V+frPs9yoK4QmH xRRTirwdAr+n6tOnE8Xmr3jsP2bKOCDV5hIwAFdMkyYhg3xNDP85htorh+qSo4AgJcu5 urEL8dtS/F9XVQG8p6zPeTPViVinjigNqi2SpfqLf/DMV46rZj/EUv4pumOPt2YU5Btj SPIdI7qzn02+Negxbc5aFJcu6RJ6/D7yjgrMq3Tz+x+yX6Roun/n9tlVNQ2OsBs8L/nK /7xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745615382; x=1746220182; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uIY1UYaU1fvtHky+5YvUDY5xMfkarvlEBEV1oBc96LA=; b=Cwlumf7Py+9HWWEm0lkK63Y0tBD+dw/dLQIn5yHjFHO0RBE90h9Rf1zQ3yoLlFkm9I xj8/0q4p4FpOluY91lh7+JnZQT8eRh55vM68B9s39TPNKWw2W+JX89W9lINwFYkM34iO 2Nmd+MS4CW8SWo9j1skpHyHliCNgKIyVgkTcLsDqTPAG+ZfSy4tfBU1AbfmQCKLgGZ0d fCYOfQbWmfChf6ssLhm0I3vA5AtBrJ5lQCdrXolVygyQyW3OA7/aJt6LLV2MSmBba4lE /J72BhMCrgRbNmxYU9sWHmAQ3vOrzsYu3TZh1nEz7LhmF28czZT/tOXdWjAVrhVUY2LG mxjw== X-Forwarded-Encrypted: i=1; AJvYcCWUACvAdSH5MEgTAP6tAwnYz6l9e2mRX5kwJSFJKvXO6CNR4AIgOlW3hQFwh5YmNNUO/tdK+3Jd/mZhwIk=@vger.kernel.org X-Gm-Message-State: AOJu0YzJ75/JgoKwf2I1bdSOKRCV57yQvoGWCDLC5QcOZ8QDl2R2mTCO iM5p9iP4gyQMKXq17q/09vBrINpZLCtNG3pTFmyTp/29ozSkOttLsQXgWaIg8/w= X-Gm-Gg: ASbGncuEx3LJKLZelSwxVgiNlKHviAEYEj+MOxTWVRKuaSbwMXPLaQ6yaoN2p9F4kro n1dLdlxb82qE1BItLMoBbLCL123FLWw+UTEcN4E2F/ijGxWXTD/jiHnl5CYs/IdB9CXfaRmpnum AGHJtFDuoYZMA+MU6lXeCAG+bEb88Jg3xQrjQxu05nIaL8M98KQaJ9ozlkNoWTb5MVqAJwrCv+u Us9jzz6p1DLbJXsEca+IfyczPNJo99Rmbo16yYCdRf4Ab59F8AeR/ZcUZX6eALnXsDuZn/oUOBS 7uDVnqa/i7CWi090dWeIrHqYeBQWVnkweNAVovtz/eJ5 X-Google-Smtp-Source: AGHT+IFwss8X+LYquqRQKkNZMlIU9cSEM6k0mCA5Laa6xLd+BG1valjceigoU4pMW6TLwZRzhyDhZA== X-Received: by 2002:a05:6830:3903:b0:72b:7d52:85b with SMTP id 46e09a7af769-7305c8c5f3bmr2177788a34.16.1745615381827; Fri, 25 Apr 2025 14:09:41 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:96a3:e28:3f6:dbac]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7304f188052sm847673a34.8.2025.04.25.14.09.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 14:09:41 -0700 (PDT) From: David Lechner Date: Fri, 25 Apr 2025 16:08:46 -0500 Subject: [PATCH v3 4/6] iio: adc: ad7380: use IIO_DECLARE_DMA_BUFFER_WITH_TS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-4-f12df1bff248@baylibre.com> References: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> In-Reply-To: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1253; i=dlechner@baylibre.com; h=from:subject:message-id; bh=Vr9wDkA3SNoSLT9FCnDYkBa0JumGawTzg2ZkCcTYUYM=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoC/n7nD6/HmRUEekDdufnRBs06xB+EFaZcg9cW 13ajpadrTqJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAv5+wAKCRDCzCAB/wGP wGnMCAChmYyO/9wpFZGWSnd3q7aKAUh84O17VLdiX8nlnneXQRtE/XeKj3zCS3AC46VHYMEJIUG fmoVgWPPhlUvxtkOVVkjmYcNQlDXlumos56vpQ+W5cO/6ZwpuMeIlvTWa+02VyjECcwByliHBVk tzTCme1/iQJyUbYMafDFiMw+2xlofm37ALqOL8P4E7Ri5fHnYLcWkZ7+FMJZ+vdWwxl5udW9JVh py3CvafsBETqRBUyG8V/olwIXDZpyPcqV4MjVjqPNbnEygm8/gmk421rwh353l1oBd5YNo1svyL 2OQF/zEycb4m9UL/L5UPiJWX85ICOf3+5MWsIgOvgDI2c7mC X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use IIO_DECLARE_DMA_BUFFER_WITH_TS() to declare the buffer that gets used with iio_push_to_buffers_with_ts(). This makes the code a bit easier to read and understand. Signed-off-by: David Lechner --- As discussed in v1, this one stays u8 because it is used with both 16 and 32-bit word sizes. v3 changes: * Use IIO_DECLARE_DMA_BUFFER_WITH_TS() and drop __align() v2 changes: * None (but I messed up and there was supposed to be a change). --- drivers/iio/adc/ad7380.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c index f93e6c67766aa89b18c1a7dec02ae8912f65261c..ed5e43c8c84cfcc9c4ce1866659= a05787c1d6f5e 100644 --- a/drivers/iio/adc/ad7380.c +++ b/drivers/iio/adc/ad7380.c @@ -909,8 +909,7 @@ struct ad7380_state { * Make the buffer large enough for MAX_NUM_CHANNELS 32-bit samples and * one 64-bit aligned 64-bit timestamp. */ - u8 scan_data[ALIGN(MAX_NUM_CHANNELS * sizeof(u32), sizeof(s64)) - + sizeof(s64)] __aligned(IIO_DMA_MINALIGN); + IIO_DECLARE_DMA_BUFFER_WITH_TS(u8, scan_data, MAX_NUM_CHANNELS * sizeof(u= 32)); /* buffers for reading/writing registers */ u16 tx; u16 rx; --=20 2.43.0 From nobody Mon Feb 9 22:56:01 2026 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BEAC224B0F for ; Fri, 25 Apr 2025 21:09:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615385; cv=none; b=J/8WqvFgvLT96iWmRucLHT2TU1t0H30yyJ7m6bKhiZ9thnAA1jbGbmUzSoTqXoYUXdccIrKFt1ZgCNVd3oFO3Ae+7hmiW8QRdIdVnVM4b9MVj/r8E6dyeAqpNshv/wjyuQTzta/UhnwpSyE69GDgjBJha53zE1VlMB6dotfhMpk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615385; c=relaxed/simple; bh=htzNMPXlRVfXDBCUzoC72qPIY7Dbustt/aeF0u587HA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ciVWi9c+rv4+H7+tY4SEjmZtwrJXKiV9X+xF7OVdgKz1JBur85mm/Q6lvWPsZNZRG5uqFIdJ7Z+WrAKcacyQib/8M1dN+02jCrUp0gGNM+1ooFMSqzRVTk3EutaFmDv33d7FiA9M/KoyRUVA2RMGVK6MnyfyjWZcXMKM1rjA2D4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=XNa6+8rB; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="XNa6+8rB" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-72bd5f25ea6so774780a34.1 for ; Fri, 25 Apr 2025 14:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745615382; x=1746220182; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ml14j4CWVwjgejgx5bGL2isKAmgSSnndW82GfrPbAUk=; b=XNa6+8rBulJNNrKeacA3uBndgqIlUPFmwRxTDYW58fUqOddRTsI1vm94mVvffDn9PI 9bm6D8XbTltR5Xr72+ob+CHzb+zlxeF4Gin9nIFfU9VPBd8/YEq/rTj2fs7nwVRnpauz ghD6/8JAlqStkJePGeLX6L3l9ADL2P6v4uArMkIUx81HqoBHcKBYh/gmerLtlI//TGxn m9o/v5dbWvdVnOsx7i46Eii3JBCjph1iHyn+zcyBh/CB/E7Vk5s7Dtp2HzVuhASi8rOa bNwk9MOUodklIC78EH5lRLLdGZbI/RLRtdn4TnhvR6GBZ8a3vPgnlEweB/o/8dSqA31m eOAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745615382; x=1746220182; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ml14j4CWVwjgejgx5bGL2isKAmgSSnndW82GfrPbAUk=; b=OfWJjuAuNHexLCkT5QRDySFVTGGoz1zZanO+1RBEj5qHsBdGARM3mQDCh8/y+Jfpzc /HGzgsUyRBLsuuMXVHtLM3PF1SscfzK1uZgf/HPO6E5SXw4H/2DvA4qimoOV7NSNn+XW vyI2+wJHR+f5ff7ODLlkTK/VGx/+1BttIptejVh7yrgGRwzvEke1i87a/wwjqWq/DGAY Of2iAFRx0SszInv6A2puInQ01dcwhHf+DSSOmYDyJM1CF65r7yvCEcQ3cxe7ujDT0kFK nBWCN+5+YxycX0S9VY0gMH+sX6zVvfr2sSUx7n+zgmqfUh25Dq3V2BYyu7taae1vB7+r 7CMQ== X-Forwarded-Encrypted: i=1; AJvYcCVZFOhBiYbR7aIIbRYUKl7PrgjCfyR50bdKY50FIRmF1qRrs7xxnNsC2b+70taEmsaaHMzwLQ7kKRcyJ3M=@vger.kernel.org X-Gm-Message-State: AOJu0Yzp4XapNScGDFUBLmnEleksumSD0Vf601KtdYsGMg4phHVzqit5 RY3WeSkkhikqjK3HoCYuQ5oo1ElDLfxTyQEG2ziG9MkJyEkBKWvlzERlZx8UIZM= X-Gm-Gg: ASbGncu1hwJ4RYFRNc+u+qG4+qNWRcud1WdAodIvMyB1r2VTepkBXQuW1tybdBmB87M jr/JOdyc6NWKMHnHN+UQpl0nhxxOSBBwiWfyerwUjOQfZGiH3XyfCSG36RWwBwq/giE784WM7Xl yAxlVy5YXmVcxRg632OZ7Pl5HNNLoqmYhODL3PYoH3eVS5dk413eBDz2TvjWdYl9inzrMHPR8I0 1Fc4UbSqm0X2R2wjtM3P6wIQQlXICYb+QiNh/fJ2FwUKI8MjVq37/IPeIaH72Q415k0YPqyOu+7 cB8geT66xOtYQHbw3uUe+VzAZ3TOdouhYFvJZuOOTHcG X-Google-Smtp-Source: AGHT+IHLgQHGW0PActt52m77uug4cyBdR0f29K9AKJZKuS1/OMf1wtoVjtXc0QZ+kbE0ZSOMbu7xqw== X-Received: by 2002:a05:6830:6c16:b0:72c:3289:ab9e with SMTP id 46e09a7af769-7306528fbbamr857002a34.27.1745615382663; Fri, 25 Apr 2025 14:09:42 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:96a3:e28:3f6:dbac]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7304f188052sm847673a34.8.2025.04.25.14.09.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 14:09:42 -0700 (PDT) From: David Lechner Date: Fri, 25 Apr 2025 16:08:47 -0500 Subject: [PATCH v3 5/6] iio: accel: sca3300: use IIO_DECLARE_BUFFER_WITH_TS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-5-f12df1bff248@baylibre.com> References: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> In-Reply-To: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2980; i=dlechner@baylibre.com; h=from:subject:message-id; bh=htzNMPXlRVfXDBCUzoC72qPIY7Dbustt/aeF0u587HA=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoC/oC99c7vmgahKavaaqiaEwFgXFazfdsIHWhn /S6WuWWb5yJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAv6AgAKCRDCzCAB/wGP wBmKB/4lJcLjJW0z//7l87DZoFSQnUkGM1DBpTGiF647U0XkqoDbOqJ49+vuOFHBVBnpQtn6F+K I4UkBG8x6x4TFqWHY7jHgHI80t9kBAvmB9fE17HEu5jgdmydpfe0RAHxNsQP4OW/NNf0rg3DJOb +/NpEmjvyUNUQXjp68euE+DXBg159TtrzYwvJyxHZMh4X8HGoh8PRiuzbmflcShlZdS96i9SSL5 bMiOhQE9+hy1LTX+O8bh0oRdjVzK/Wst21kN/sEW4SwfEZGNrhJyqisqJN0dXjJLg0HFpMRFBA0 T1VPuE5WvvVTNli/8uj7ck+N48jC754QNaLmK8ELHvPBVBlS X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use IIO_DECLARE_BUFFER_WITH_TS() to declare the buffer that gets used with iio_push_to_buffers_with_ts(). This makes the code a bit easier to read and understand. Signed-off-by: David Lechner --- This is an alternative to [1]. Also, this serves as a test to see if we can get a rule of thumb to decide how much is too much to put on the stack vs. needing to put the buffer in a static struct. SCA3300_SCAN_MAX is 7, so this add a bit over 64 bytes to the stack, make the stack now roughly double what it was before. [1]: https://lore.kernel.org/linux-iio/20250418-iio-prefer-aligned_s64-time= stamp-v1-1-4c6080710516@baylibre.com/ --- drivers/iio/accel/sca3300.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/iio/accel/sca3300.c b/drivers/iio/accel/sca3300.c index 1132bbaba75bcca525fac2f3e19f63546380fd4f..67416a406e2f43e4e4172104109= 04d44c93111d2 100644 --- a/drivers/iio/accel/sca3300.c +++ b/drivers/iio/accel/sca3300.c @@ -58,15 +58,6 @@ enum sca3300_scan_indexes { SCA3300_SCAN_MAX }; =20 -/* - * Buffer size max case: - * Three accel channels, two bytes per channel. - * Temperature channel, two bytes. - * Three incli channels, two bytes per channel. - * Timestamp channel, eight bytes. - */ -#define SCA3300_MAX_BUFFER_SIZE (ALIGN(sizeof(s16) * SCA3300_SCAN_MAX, siz= eof(s64)) + sizeof(s64)) - #define SCA3300_ACCEL_CHANNEL(index, reg, axis) { \ .type =3D IIO_ACCEL, \ .address =3D reg, \ @@ -193,9 +184,6 @@ struct sca3300_chip_info { * @spi: SPI device structure * @lock: Data buffer lock * @chip: Sensor chip specific information - * @buffer: Triggered buffer: - * -SCA3300: 4 channel 16-bit data + 64-bit timestamp - * -SCL3300: 7 channel 16-bit data + 64-bit timestamp * @txbuf: Transmit buffer * @rxbuf: Receive buffer */ @@ -203,7 +191,6 @@ struct sca3300_data { struct spi_device *spi; struct mutex lock; const struct sca3300_chip_info *chip; - u8 buffer[SCA3300_MAX_BUFFER_SIZE] __aligned(sizeof(s64)); u8 txbuf[4] __aligned(IIO_DMA_MINALIGN); u8 rxbuf[4]; }; @@ -492,7 +479,7 @@ static irqreturn_t sca3300_trigger_handler(int irq, voi= d *p) struct iio_dev *indio_dev =3D pf->indio_dev; struct sca3300_data *data =3D iio_priv(indio_dev); int bit, ret, val, i =3D 0; - s16 *channels =3D (s16 *)data->buffer; + IIO_DECLARE_BUFFER_WITH_TS(s16, channels, SCA3300_SCAN_MAX); =20 iio_for_each_active_channel(indio_dev, bit) { ret =3D sca3300_read_reg(data, indio_dev->channels[bit].address, &val); @@ -505,8 +492,7 @@ static irqreturn_t sca3300_trigger_handler(int irq, voi= d *p) channels[i++] =3D val; } =20 - iio_push_to_buffers_with_ts(indio_dev, data->buffer, - sizeof(data->buffer), + iio_push_to_buffers_with_ts(indio_dev, channels, sizeof(channels), iio_get_time_ns(indio_dev)); out: iio_trigger_notify_done(indio_dev->trig); --=20 2.43.0 From nobody Mon Feb 9 22:56:01 2026 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BEAD225760 for ; Fri, 25 Apr 2025 21:09:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615386; cv=none; b=pfLRk5yWiLqGaXQpBVeJNoDv5/Qd9RtKmm5dFYbr9MSGuGFa7ZmBrs3LxRpM+WeB+9o50IuuTh8duyzgZ6UgdH+sWn9EDFFuNUAiTnkRc1ZKeI0r4S0bPHkpLRkbzR3O0KInFztxED52RLxWpF6ifhfFIGsNAZTEtdOEv1+WJPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745615386; c=relaxed/simple; bh=0ZROZIYuD1zVkkOa3PNcABnV8cSDGoSdT6l8Emh427M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EZxxzVqV98MFkx07fkF+JR9qr11hOxr+d4Bdgs0rUzlCXLG/Z2obnty1li8HjqrxadtLLDgW6Zl7ZGLx+20bGtXQCwFnTQFPe/jlxNn5TFSiCKUi0tc4RVwDSgDe6iXVS46lunzIGasA8i0acGFGzwlO1mQ8M0yR0QoaDX5ofXc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=vKXB2QmR; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="vKXB2QmR" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-7306482f958so271481a34.0 for ; Fri, 25 Apr 2025 14:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745615383; x=1746220183; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eLGFE4jWdVqehv02FfXRMamFv946mVo/oPig2GMtSpQ=; b=vKXB2QmRYtA9c9Z/Wn4w8X8PRbsEtCUGIBr3C7SbYjLnRs/GwOcqzm06E3srZh7gsK Mgd+jAgoD+alYBFHAnHtqRo9ZJCZyHFhyQg6hfuYlchH8otJ9prZ3NRaJlN64qhgXEf1 78U6UNYnULRggx/jsQwggk2yCrmPg9f9kH8bTV2DFkBHB6dxkUNvLA9jv6eIx/xnx7Ib dNjfYTTkGGp57H2ZJGsNcdDQPaXUqEhgDLeq2H54Rpe+zNq7XhFqbODom0ewwPHD6AVF BXqKqOG/1Xze/g3M9HtaFwUY62CR1+tf1/bwTNFCvbXafi76BvfQznjC0rnjwGKDK1yF 1+mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745615383; x=1746220183; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eLGFE4jWdVqehv02FfXRMamFv946mVo/oPig2GMtSpQ=; b=oOHqGFvFQawNvQmU4WDr41H2/sLv15KuM/YXq9w3/CB58ksL0HcgGxxK4dF+2qdB7G FxKg+32b/9DZBT6XvnX8tMRvKs38OZWSTZxcE2KthgVfcwDfHe7UxzCd6dY4H7tEdRmQ g7RePbnAQauG3T26wjkLrWCBYrpUAiu4jpOZWR/70o52QSzTCerN3UBtSFKcPyDyRsre xUmx+b6fRoqsU20C40CcimW/JcR2G1CRlfDpDTkt9ydpBhWqMjHnsjqKa+aX+QwL0nOu KO1zTZ3RALkzmsgo9WWvrYVhoorkcYkWAx1/n/1XZymQV3sxmIroltANgElrD3FKPr+h 35Qg== X-Forwarded-Encrypted: i=1; AJvYcCU1Uq/NW/BGiqyibcgiEJAGJINdlkBmYanvVcQ0mlTSJLtvpBisnAuTFgHnYyzPempp4R/YjKu7HjlbmoY=@vger.kernel.org X-Gm-Message-State: AOJu0YzaPTLZ+SJot1J/V2FerAyMsJLUUMFrVLwdtsDtt+ObuBb2e/KI hKsnzaC0CkLRS7IhjskEL2ZaUtv7kw1LaLh5tdldWF32ZvjcvJZL9StFfxVmxdQ= X-Gm-Gg: ASbGncstyUxCmqzS/uKc+2RdBMRa7dTx5Ym/dnSkVbtvKRq2JElg1pEsmOgUuQL2/2V 0a18pPI57SC+ub0OZ6lB55/zKWKlcGJI0n9Zk+fFP5E6KLN/KjcBMIlyL8mJLY2MEs0WtlPelSe edNuxlK6S6GywSRYGRc+cWMCHOOZaETmXZdoFk9yldYbwPV5m/1KHpx9Y0ghXUMcG1YzMIwR8VB O4ONk037Ks2OdSojY/VlAcw2VO1sGnVjNvqIJouNpCG+xtV9VeLQIOo2OjavZ2So33kg9R+DYUV kQe+HUg+6/Bpl5+DBKqFaFnNAa2gkKfrrUtrqJZ+KcACBWhnALcPzdY= X-Google-Smtp-Source: AGHT+IHuXyKh5ZN8gTfHG9qpfrVJEoH9N4Qd7+y62hF7SPBuooeBppTq0ItxP6Q1b31VLKNINSFoXg== X-Received: by 2002:a05:6830:7008:b0:727:3f3e:53bb with SMTP id 46e09a7af769-730652484d4mr866727a34.24.1745615383552; Fri, 25 Apr 2025 14:09:43 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:96a3:e28:3f6:dbac]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7304f188052sm847673a34.8.2025.04.25.14.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 14:09:43 -0700 (PDT) From: David Lechner Date: Fri, 25 Apr 2025 16:08:48 -0500 Subject: [PATCH v3 6/6] iio: adc: at91-sama5d2: use IIO_DECLARE_BUFFER_WITH_TS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-6-f12df1bff248@baylibre.com> References: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> In-Reply-To: <20250425-iio-introduce-iio_declare_buffer_with_ts-v3-0-f12df1bff248@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1676; i=dlechner@baylibre.com; h=from:subject:message-id; bh=0ZROZIYuD1zVkkOa3PNcABnV8cSDGoSdT6l8Emh427M=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoC/oJEty80tyPXVTdFqZGvPX6xqzXo1bpiUv2M CaUL8XvOzOJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAv6CQAKCRDCzCAB/wGP wBvoB/0UnRiw0riUGqhqh/XDIPZR7uCez6zobleSUHhagNRfN8sY4l8bawJc5MlIgLLbl8FhYhd 9/eqeGougvJ/jGQ7YqbmoGTbqoYdi2YQLw4l6W2w+G3nkS66Xg8/LGPSpILZy6RAk97URQr1IhJ g6nc4HSEde06PLI7VFJIn96AQxa6ztR5vh8M9P8G/WK2rCC1xQjGyei2MpR7S5YAm/W1O7k/c2/ Iiczy+BYuiFS1g/LIhku9hvc6zrrbuiXZGQPUi7BDWz4SQijbCiH0Fi3R5SmAPY2a2o0hle7l/w ov1SL+pzWf/yX2jcoRIE9yleZxsrAm8YkUcevoy0zlrcxau4 X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use IIO_DECLARE_BUFFER_WITH_TS() to declare the buffer that gets used with iio_push_to_buffers_with_ts(). This makes the code a bit easier to read and understand. Signed-off-by: David Lechner --- This is an alternative to [1]. [1]: https://lore.kernel.org/linux-iio/20250418-iio-prefer-aligned_s64-time= stamp-v1-2-4c6080710516@baylibre.com/ --- drivers/iio/adc/at91-sama5d2_adc.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama= 5d2_adc.c index 414610afcb2c4128a63cf76767803c32cb01ac5e..4ebaeb41aa4568e2461506471af= 0540af9d1a041 100644 --- a/drivers/iio/adc/at91-sama5d2_adc.c +++ b/drivers/iio/adc/at91-sama5d2_adc.c @@ -586,15 +586,6 @@ struct at91_adc_temp { u16 saved_oversampling; }; =20 -/* - * Buffer size requirements: - * No channels * bytes_per_channel(2) + timestamp bytes (8) - * Divided by 2 because we need half words. - * We assume 32 channels for now, has to be increased if needed. - * Nobody minds a buffer being too big. - */ -#define AT91_BUFFER_MAX_HWORDS ((32 * 2 + 8) / 2) - struct at91_adc_state { void __iomem *base; int irq; @@ -616,8 +607,8 @@ struct at91_adc_state { struct at91_adc_temp temp_st; struct iio_dev *indio_dev; struct device *dev; - /* Ensure naturally aligned timestamp */ - u16 buffer[AT91_BUFFER_MAX_HWORDS] __aligned(8); + /* We assume 32 channels for now, has to be increased if needed.*/ + IIO_DECLARE_BUFFER_WITH_TS(u16, buffer, 32); /* * lock to prevent concurrent 'single conversion' requests through * sysfs. --=20 2.43.0