From nobody Sat Feb 7 05:00:02 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6DC623AE95 for ; Fri, 25 Apr 2025 09:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571670; cv=none; b=iiVkJyzLkvD3HvasERBqVghQhEK59kB/yyeTLrkIvh5Uk6iOJOw81CRnIm4wxVP52Gu7qscCh1lacnAmRGXbU867HqrcbtR5Hm/9VYze5x68S1Zv8zEFJrlEDYRSePKFu4XP1efytC+is+BOohLQ2fvwvqOLxexjIBgcbXR42sk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571670; c=relaxed/simple; bh=Lg7SIXa0ie0LybxnwabcVg+h7GXu/NKorvK1sVySxcg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cnfqamFcdjSDSLyhV/ZMd73S0uz6YOhgWczgjNkLrFiBEQ7hwrPPXhGG8FIVmkM0BPPZtpzm27XidcD2NepmBvwGyDwmID0SZ8kIGtY8JrYCIFK8We8E9UzzsLOJW0rYoabk64X87PVIm9dvvRPgexF1bWElzcux0sM1+OAvdvk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=ZZK9c1k2; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="ZZK9c1k2" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-39c1efc457bso1398647f8f.2 for ; Fri, 25 Apr 2025 02:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571667; x=1746176467; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZB90erWf+Gm+Y0GtLErqGxR/pE5/v4Z/PlOKc5IF8Kc=; b=ZZK9c1k2GpIRHpaiYjHGfTkfd1bluAxmhM0YKsfWg6lFA7aG1w2lznLj5CSIpLodCY A0K0dvRJ8L4X70n0V/+YrMw3nN4Af9OZnvVRECkuQLEX5KSjtfl+Omu9pcxM2OPZ039S /upDGy8jEQeuMqXT4WSxeH+ofguqk8T8/Tf0wIfUda3Lh+6+xJoEnoCP6Ksta6gP47We JjtAQBwY6ByTyxtVAguQ6Tz349UAT3QwpsyQEyZKk1nkbgtDmMOk0HxkUS7KLE9NCyGK u72uJb4cmvWeaTWI3qUzlDG1uIFPGF+BnICzPykMQL+VhmruGFXyEfKBOfo/BXDeIIbL SrUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571667; x=1746176467; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZB90erWf+Gm+Y0GtLErqGxR/pE5/v4Z/PlOKc5IF8Kc=; b=hadYKkIl1kBTdwhmZYcEV2mRFWLDMM0u+1TRROwWrFRIrPk7gy3Uv1NyzWmIfpjBy7 3msodjpX5HNyP6gbBhF7KQoJDJiJW0F7Omrp1NWsU/jCmQkSK3ZV57uONRbAr5NW0TsW JyRySjvham0lbUGx9ZUBHdobwCZ6VVlEQsHajAl+ydDYoPrxQGISpCixac0P+z1nWa0H a7L8F4uT6GkuN4lT8f6i2zWWdeKSiNF0lWBlUChdgeEcWRgMWOZM6oKfLMp7EjDvAgxZ cocLYCdjs3swzzj+f6Ri171TDIXM15X7yPRiwYEn1m/vyKJQaowrfkDfTN4QD3U5XCAB YYww== X-Forwarded-Encrypted: i=1; AJvYcCUUgQc1DqV4YxO+3Rv7UdB3ohVkaYFFTyHDLIOWgP+EL/q2dcL6C1az7RTFYHMfLoswFaJVIlV2hqZsoho=@vger.kernel.org X-Gm-Message-State: AOJu0Yys78ceENL9e5oHQAslL062HDEMJ1Xcnuscskh2OT3lkclOCyXu /28AHLhUBKAoExB8uEBGHUYNh/F9XGEFUn4Sc4idBpokFmxWlXZTRaousMQKXsU= X-Gm-Gg: ASbGncsC9xL3LVvXK3EixRUaYwgjquzq9Mm8wRWAhr00W2/MmqbtffyqXuhiSofESbJ 96qlEkWmG4Ne09NqcxjIcgddxdi1frPZECGrHqx+3a2RaqS5oX7L7DW1Lg7wBgcJKbGI2tLJiTL LRogSPwWDsea87gC/5xO0a0lBhc76iLgyDFZbx1v+jxKNxDS6SIdLJ7CjIRKEwXKA5eWG894MJ9 Ebinyy6AnDuNTSGgYEYIaeFy/jeha/YYThTlohCkssuwvStEnxTUEmn+Dv6d62GiLaBHLoEeMu+ 9P+PXa+kP4WhUKZOKrBLwuo9LnGmrY/QtA== X-Google-Smtp-Source: AGHT+IF0m8rX5UMES4nVD0erCZ4KstVSP6VZhmeff7Jfr6OuosoVYyYD4igGlIuV4D5i2BVa1x4EkQ== X-Received: by 2002:a05:6000:1a88:b0:39c:1257:c96c with SMTP id ffacd0b85a97d-3a074faf4b3mr1205781f8f.56.1745571666825; Fri, 25 Apr 2025 02:01:06 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:06 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:00:57 +0200 Subject: [PATCH 1/5] pinctrl: mediatek: airoha: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-1-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2370; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=uaHOfJ94TFx8k9XlThx6lSkpYsN9+1e6SW0WrRZmuoc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09Pjw/np8UeS1ttDZIlSftl0HIaXAVQAcTl+ qHDg6ttNnqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPTwAKCRARpy6gFHHX chLhD/429DgRXwmTcgjG7Djz7jHNaXG0YDQCs3in+FxM1KrmgZ7nENGsnYdogEPNSvdYBfsUhwf JSQNi2Z47oZ0and5Yvmmv3FnmvnBUpbtPa4O++YpL8TVUq7teVZIBYCPkxG6uWpbX339RqRVb4Z Eu9FEoXAE5JRDGSRUmJDfaRHGeGq4apiYTNBsQpo9cnQN5L4m9pDIlRoM7+e2tYyrEzG6/v8egd OSP1y6+t9WuoDPeH25a1e9Ta1ehj2ViYsD9E4pQE7gM7EPm0OsJqxT007wmerUBuqvCq4rTncQ2 0EQP7ORGcUfUsLT5R/cBcIYlUFbhziuNBpeBaKginbJoYLu8wfb+ospruKX203GPKzCFPtSSRQj 9TyWwf1wV+kQYa/OkcDoCC9ScRxvDE6V7FTE4KzW54hNfzl46gZK8JoJKj1+7yQQgjVnY4AqENs Pt5WUaDQWxdfQotValBICHCN1jMnaWl4dDMso+xs72ErbEvVrbB5xIWWPoFuBGdazfWDfMDjyaI teZVW4YCDH9O2N30eJRp9/ON2MYaliiSvfVZDr6YcXTCzcmsLIIgKqrvexUxntmwoYebcguTINs SGM+230tfxLUtpfvpwqrxYPrpsv28wSCb1BlDuLaLdh+bHvGajSdqgZlxAAN8qwALpRkoR4o/K8 rSv4Yz4yX+so0eQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Acked-by: Lorenzo Bianconi --- drivers/pinctrl/mediatek/pinctrl-airoha.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/me= diatek/pinctrl-airoha.c index 5d84a778683d..b97b28ebb37a 100644 --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c @@ -2247,15 +2247,16 @@ static int airoha_convert_pin_to_reg_offset(struct = pinctrl_dev *pctrl_dev, } =20 /* gpio callbacks */ -static void airoha_gpio_set(struct gpio_chip *chip, unsigned int gpio, - int value) +static int airoha_gpio_set(struct gpio_chip *chip, unsigned int gpio, + int value) { struct airoha_pinctrl *pinctrl =3D gpiochip_get_data(chip); u32 offset =3D gpio % AIROHA_PIN_BANK_SIZE; u8 index =3D gpio / AIROHA_PIN_BANK_SIZE; =20 - regmap_update_bits(pinctrl->regmap, pinctrl->gpiochip.data[index], - BIT(offset), value ? BIT(offset) : 0); + return regmap_update_bits(pinctrl->regmap, + pinctrl->gpiochip.data[index], + BIT(offset), value ? BIT(offset) : 0); } =20 static int airoha_gpio_get(struct gpio_chip *chip, unsigned int gpio) @@ -2280,9 +2281,7 @@ static int airoha_gpio_direction_output(struct gpio_c= hip *chip, if (err) return err; =20 - airoha_gpio_set(chip, gpio, value); - - return 0; + return airoha_gpio_set(chip, gpio, value); } =20 /* irq callbacks */ @@ -2419,7 +2418,7 @@ static int airoha_pinctrl_add_gpiochip(struct airoha_= pinctrl *pinctrl, gc->free =3D gpiochip_generic_free; gc->direction_input =3D pinctrl_gpio_direction_input; gc->direction_output =3D airoha_gpio_direction_output; - gc->set =3D airoha_gpio_set; + gc->set_rv =3D airoha_gpio_set; gc->get =3D airoha_gpio_get; gc->base =3D -1; gc->ngpio =3D AIROHA_NUM_PINS; @@ -2715,9 +2714,7 @@ static int airoha_pinconf_set_pin_value(struct pinctr= l_dev *pctrl_dev, if (pin < 0) return pin; =20 - airoha_gpio_set(&pinctrl->gpiochip.chip, pin, value); - - return 0; + return airoha_gpio_set(&pinctrl->gpiochip.chip, pin, value); } =20 static int airoha_pinconf_set(struct pinctrl_dev *pctrl_dev, --=20 2.45.2 From nobody Sat Feb 7 05:00:02 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7E7123BCF5 for ; Fri, 25 Apr 2025 09:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571671; cv=none; b=Pi5GK/cVjfJweJ8G8GXN/W7xtLkdjJa7A+fg5+7omf0Cj4kC8uPvhXjtkRNIGF1mmnn7HtLMhG21lBPoupvrb4lYxSESwx988tzxvWmP0zoYMAttlAHCKK6cCXHtU1kvjqJ3e8CvPfhQspAjxiRIoqQ6lsZouR4Q5OcltlVO0jI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571671; c=relaxed/simple; bh=phhWviKKhhzzjzPDil2DbjlngOzuC2xCXBD1aK0WBVg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tminzOoUMIL56s23GOnA15EA4Wdrq0Y5Wq4NRgv/qGRu3kS3lxU6ngTGNSKkTWBAPL24RQ0Pyk82hLoYm84HBfhjX+sTMObRbRGcIQUO2Xy981ZD3WWi+lYFVFubgJF4mcy2C2VrrxsfmtDSfMNo8I7q7JYQe4vBmwzWf/VOEnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=EYnj0Hxi; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="EYnj0Hxi" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-39c266c1389so1369160f8f.1 for ; Fri, 25 Apr 2025 02:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571668; x=1746176468; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aG92M+ThGG8rcCnZb6WUafkA585r/LuxT+alwijT/5c=; b=EYnj0Hxi6pW4zADwpWaOo3NtQwbi0vT+6Hk+dxRI21HdXhQrg+F2r/uAcsJWHRbrYK pW2OOIgmEZs0gktiK94MCgPEOLud5BwOTeoBdCLQqlekerFZCzSI+9A9JG96uqtQoaiS e4SYx9dg25qQjdKXQhqLtRlWA5iQxdRqLe0uBU0l9JNU2GU04elS0OCVSEFD4JPFJRuO brTs5DQzxozWyP5xoPAK2y8uaIDXXM/hlvIAR9OPPc0QkTOxlmwp03bWeP8FSq3hzS+K ATYpHlNyt7wNzUiYibGon8VZ00bEM7cswU1WbqD1QtIq9bDWgNcgeYcZX5/KO03IE1Hy DmAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571668; x=1746176468; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aG92M+ThGG8rcCnZb6WUafkA585r/LuxT+alwijT/5c=; b=l7aDfAHbEqin9C83MZeHH4n4Bib3GAU/Ed6FMdlaSAb6hkNhHgcVs246WfkLIEit9s 7THVLMDn9AyDdvCGt2HKRWa1MF1nIUXERyACpAVUYqxt05IPj7aRu/ZhLxIEQfkBdCyu hJAkuqxtfg+PS3TCsqr+HYLxpAykIh20cIhmB+65hW7v38am0H7/Y3qnLNEaLBVK5Om8 I1gR2hNSu6a8AbpbOWWYcAYLhTgWk6FMBrZ0Msu5LDG2W/38dIu/wXO4/0yXEff/eRFW 9aYH0KItoHiVPjRCLYzjh9YYojawbpzdVUrh5TjottruCDa0jUwrVRxHo3dpybVB8keL +wag== X-Forwarded-Encrypted: i=1; AJvYcCXgIaMhIZQiampemDyLIbhatApK/YoiesIXOWhQyQWMehInwzvb2HZayiNfIs45iFOfwWBO3Me/YKjEukg=@vger.kernel.org X-Gm-Message-State: AOJu0YxGFZED6Y5nTbQDmw0HIOgXEFtxODKMLx4ueWRHWpu8nNgg5rFM JdJuKtaIc31DW7Q399Bx/2O/YUFomkckkhh/uCkS1zy0oZhQ+KZXCW73RAIZJwg= X-Gm-Gg: ASbGncuQoEockdn/rKg2P/vJC0ut0LwReAvZe0zNFH2G3BOtxtEam9EV6mnfhrrZ9kS iXG9BbH24//a0MHGndc/vQ1XjKFcFLeTKFXxmZksq5i9gn9r3+Uz2dOx/V6JzmFNwSH+Oiky86F SGoZO/mjH67TK2q+EZN44fEfXVy+fFqsonj3arXdY9UdGZu6nPjU+Jv2ircFRc/4FEegZIpSvML PoVl+sffEDBL6gjSHmnmCuDf8IEn3IgAS4QTSWfmfTZRCcSeQF2U86j2y0CoYZlLAI6hMA/ac/K VO16wgDJUbN7RACmDLjfBwlUMBkbvAJZFA== X-Google-Smtp-Source: AGHT+IFW7oHQT2iQkXG5/oplsgKCVuoYvLPqlkf0fWIPHa0BO2c6LkQgBuCA2L7Ixcx9kcJza03b8Q== X-Received: by 2002:a05:6000:1ac6:b0:38f:483f:8319 with SMTP id ffacd0b85a97d-3a074f4853cmr1080551f8f.51.1745571667902; Fri, 25 Apr 2025 02:01:07 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:07 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:00:58 +0200 Subject: [PATCH 2/5] pinctrl: mediatek: paris: don't double-check the GPIO number Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-2-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2274; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nUKaoN4taOpveP3nc3OVuJSxVohaZIGpFohuQJLAScE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09P1im4kKMb6U7RG39p9G/VrnbdkYWFGjboY 3bmo1dLQC6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPTwAKCRARpy6gFHHX crgtD/9is3Kf21qiXzq1VSscbgtqKAJ8hb/XCsd0cS2PtTKxYDWP1SnTIL4KX7ofzZY6+UNXOZp dy+D4aO7WNZsFR0/IHIeqWBWEk3rmMlSGkbfrIVDhpWvtIo6opyCQxql8Q5LViq0LRe6JEPRdoC Lor1QT7DRjA92oRtQppJ2/eJZFWLujiVsYYPLfXICUinmpUOHk2wHZ7Juzozwht7N/RM8hDQi5w Tq5I9jApIX7HuFwuRuILD7KrOPs3yAIkxg5EIl9t/8uEheTZAUl8gjFrt2oXh1d8QjiG6UIsnQ0 FCxUF6W7Qt3yoXvJB7BVE+lfhs5yJuhuQiBz7jSQOmUCnEpPC+rnlE6PEgqlrlB4S3UfQMyfxXu TkZGAWz6/V/ricSCTfoPbWxtHT/fmyIr/PoIil6NMgsEtw2lsTQZclPoBCEjv8FSHBZaLlZp21M QjWftw1cUSxo+sR0S6FDFFCo3EdAN3zIgltKS6I3KlaRXzygoM+OsakxjcXFba51INkzT5w7nD9 EsU0E0Z17ILt6kloAzswTHoIJKQM1NeKw/qUNa1zMq4sLMkRIadcAf8J8lFYGsqLQt+KrRyjmQN 85NWWLYzuxDF0gYe0/Ci8Zos6oglGyM6ff6HvFfXZwh0zf1/igURjsYJ8qyXym9CZlTm2F6YJGx sWnd0wD08yn563g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski GPIO core already makes sure we don't pass invalid GPIO numbers down to the driver callbacks. Remove needless checks from the driver. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-paris.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/med= iatek/pinctrl-paris.c index 87e958d827bf..852ce0ac7ff9 100644 --- a/drivers/pinctrl/mediatek/pinctrl-paris.c +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c @@ -840,9 +840,6 @@ static int mtk_gpio_get_direction(struct gpio_chip *chi= p, unsigned int gpio) const struct mtk_pin_desc *desc; int value, err; =20 - if (gpio >=3D hw->soc->npins) - return -EINVAL; - /* * "Virtual" GPIOs are always and only used for interrupts * Since they are only used for interrupts, they are always inputs @@ -868,9 +865,6 @@ static int mtk_gpio_get(struct gpio_chip *chip, unsigne= d int gpio) const struct mtk_pin_desc *desc; int value, err; =20 - if (gpio >=3D hw->soc->npins) - return -EINVAL; - desc =3D (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; =20 err =3D mtk_hw_get_value(hw, desc, PINCTRL_PIN_REG_DI, &value); @@ -885,9 +879,6 @@ static void mtk_gpio_set(struct gpio_chip *chip, unsign= ed int gpio, int value) struct mtk_pinctrl *hw =3D gpiochip_get_data(chip); const struct mtk_pin_desc *desc; =20 - if (gpio >=3D hw->soc->npins) - return; - desc =3D (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; =20 mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); @@ -895,22 +886,12 @@ static void mtk_gpio_set(struct gpio_chip *chip, unsi= gned int gpio, int value) =20 static int mtk_gpio_direction_input(struct gpio_chip *chip, unsigned int g= pio) { - struct mtk_pinctrl *hw =3D gpiochip_get_data(chip); - - if (gpio >=3D hw->soc->npins) - return -EINVAL; - return pinctrl_gpio_direction_input(chip, gpio); } =20 static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned int = gpio, int value) { - struct mtk_pinctrl *hw =3D gpiochip_get_data(chip); - - if (gpio >=3D hw->soc->npins) - return -EINVAL; - mtk_gpio_set(chip, gpio, value); =20 return pinctrl_gpio_direction_output(chip, gpio); --=20 2.45.2 From nobody Sat Feb 7 05:00:02 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6384723F417 for ; Fri, 25 Apr 2025 09:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571673; cv=none; b=jQ+NTyD5yw85BTCBXSEEAhkym36I6npBbDmz236yAgifjIlQlfk7SbOpsulBo6GkA8AFYO6iCNsEbph8ewXCVzpWNHR7Lnsw0kLNx3L/aXc0YqfgyT8yFxVx6WnRgkqfRcdVdpibBcs+lsPVYl4c3bs228oaF9gg1UrXxKhYcWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571673; c=relaxed/simple; bh=hZpJKZ+GQSZQ/UbnOT9RImA04jIADFnimUHfJV9B/o8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=e9eZSi3OLmfyFXhR2oT1JEbOHTIty6aF9QaEgPuMsGd7r76R6f+0edNaG0x/tN/WAQdT2s5JuL+jr1+c//44CdqAbAc0K1WCxcVlIYyTZSCUxAK9f6W3NHCz2lFIwjogFmrSWHtUJNaBNl4eN+A6MR8M1105SoVe5aXH7qC16KE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=bYLXZY9C; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="bYLXZY9C" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-39c0dfad22aso1458001f8f.2 for ; Fri, 25 Apr 2025 02:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571670; x=1746176470; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=r8UXZTozvJzjGLspnxEWNqMkDpoXY67SelwpGY/ZF58=; b=bYLXZY9CuiVXj8Us5c1WRqxgD5GTi/OOkqRyuI+EldJ5ZIjP8tNz22AgNlr3Xd0Mi8 +Rc/KEcVzziz0cekDdVFOybWwfcui27vF5Jtikl404bZlGO63VMyCw+AQ/H+75Z99w+0 nQjqTqDK9IO9DquYZ/N09LxsDm505MdS0M8PoFoVIrbL28gujszBapWqrULRclflApVj 3zkqiRV1BafuVTAYD7FUqpv7Z9d7+2k77Pds6sYnLCzFHl4PDmErKlcXS6Qj8Ugxi4IL Y0VxtpgvkT85PfuRGpXiOQ1ay9QHMrHhtzUBIJsnX4S6ogMFL/6+Gc9p7LkRPnIl0SAB YiYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571670; x=1746176470; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r8UXZTozvJzjGLspnxEWNqMkDpoXY67SelwpGY/ZF58=; b=VUveKdWP1aA0c9AAEh6yUSlOYm03SbYt58Fu/eP4xGnsALHxuG4XmC+CY0L0SbXRiW cB5I1Sy8gD0Z4NuDuC0G3UrZCbXbDXcYTYkgqll8o5rYUIZfyV8WWJPjsJkt2Lo2D8TI 8hVjUZnsiHwvleRmjeUu8oR2KmKkiiKB98VJOAlATWNhplOJ/OEyPEYQqgfeewxzvt3s GNuE2JKbPIz+Y28c/LvelYgMPRYeZCAA+uBe8pfX4N2BCfQYjDFlh7N4eWXwlhg6C5dF wHxx2OWCIQsZgTcMysC99XlYetPfRE9jfxtRUoBTTOQkArtSkeqcfsDGACncVQuCQRTc /nFg== X-Forwarded-Encrypted: i=1; AJvYcCX31Xn1OEwp+oYQeRfADt2ESwo5lOns6XKiuYe2PkaUOLmWt/VqpeT9nGmuH7VGY97kEXht2PeZAYHTFZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzpbrIIedaoGfN754MnVc+XEt/ahXIybidXAo6IqA41ZGk7nhM6 F/EzkdIj/2cmy8RMlqkWsLq/qpdKYhXW0LVvnlj4XnCmrQssUtlAyOo857dCfM0= X-Gm-Gg: ASbGnctfyZ6vfjwaYvY0Mo4TN0RnYTZAN2bWgMszlRKyubhr2wJbnbLK+9urmmZrmjb PZGhm/hGPR5RJotNMDz7IrgIxhiusPUojelocvFoN1Gpcug2+mx2wuC/zKmrcQIauHVcQdY64HU oKpvygbdumQOZ4J9yghLhx+LdSmYUxO7fXf6OEyhfoGMyghv4ThO0C1/W8pePQlZ3VW9aoz8svE xim7zT2v0D4tYTHmdmjFLSrgVPSUARq2eAoHh6URQHZO1YxafwwyyoQPG3qhATzfixoMMDICzPc vNWGMIZTKBVperWH34cSsagt4ta7p1DLiA== X-Google-Smtp-Source: AGHT+IFckeNXXJag89Vd0W7MAUKrj0/boKLVXA4/ZToJROXBMZJpIxWvphXkHztSufJCbS1p52tVAQ== X-Received: by 2002:a5d:5985:0:b0:39f:ed8:d6c2 with SMTP id ffacd0b85a97d-3a074e102fdmr1039852f8f.4.1745571669412; Fri, 25 Apr 2025 02:01:09 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:08 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:00:59 +0200 Subject: [PATCH 3/5] pinctrl: mediatek: paris: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-3-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2008; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=+GvjQy682fLtJAVRTMRFy+x8ClXiXcJ5yyuJiL29z1g=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09QDlA6V2iktjKbxY3hklKfAJlA4oT2QZrGX wXC06aDqWGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPUAAKCRARpy6gFHHX crgBEACWxWgAT8cG/mDkoN2QVfPEWbfVWtvWFRQXv54q2Iw67Mow6zOgHOghjKXpL3F5MmAovsN Emfn+onAMvQI68zegwOSkt/BV8B29JP7kvYn09WEGSYg54V3sn6V+gzho2WzN8WwpHFitzxdeL6 Qx75OBSlRSQvM+Rg1YOIAUNDCafWhbA7KAotx2YJeIM4T5h62okSwaTplWDAP41WFDFywwRjVl9 JWhc1fGWSZTNrBtbeVHe6xKZSSt2qBQhoVl2Uz8o9q73DJ9+O3SyHomy3YVbvwRKj8aUWohlijR gTwN+ZQx3IFj6xoEwrdToBSusDzy5MU8LcOU0qoT8Q1BpWnmY9hHxECr/NFdbSrgKZRQhVqR6Py 4vImpttpgKXrFDj0vYJdQ49exEqOj16V32VGbfcZOHEzXrfDn3kMlVS0NPDYG2pTmPYuCFjQ84E 9PrGPAeGq3KesqBih6WbmwMKCV99lt2ob3xvDv2odYaXvG5O6t0SXtxGr1JAdpZg+X+d/SAZuLm pQnTg6IlkT0SZDoyNLTglOknViI/mBGdUzsBxWXmEHR5Agu+A49WHMihKIIWUrHlTjO6biMlilg kRA4CWZLI4Sl9xJA7CRIYu8fuqexaPEA6/o4taqQurhZlhFor6vIh5fXZePJsdudZx5Xj4k5wHF pyKFfkhYSs1PzCw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-paris.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/med= iatek/pinctrl-paris.c index 852ce0ac7ff9..89ef4e530fcc 100644 --- a/drivers/pinctrl/mediatek/pinctrl-paris.c +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c @@ -874,14 +874,14 @@ static int mtk_gpio_get(struct gpio_chip *chip, unsig= ned int gpio) return !!value; } =20 -static void mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int va= lue) +static int mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int val= ue) { struct mtk_pinctrl *hw =3D gpiochip_get_data(chip); const struct mtk_pin_desc *desc; =20 desc =3D (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; =20 - mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); + return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); } =20 static int mtk_gpio_direction_input(struct gpio_chip *chip, unsigned int g= pio) @@ -892,7 +892,11 @@ static int mtk_gpio_direction_input(struct gpio_chip *= chip, unsigned int gpio) static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned int = gpio, int value) { - mtk_gpio_set(chip, gpio, value); + int ret; + + ret =3D mtk_gpio_set(chip, gpio, value); + if (ret) + return ret; =20 return pinctrl_gpio_direction_output(chip, gpio); } @@ -945,7 +949,7 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw) chip->direction_input =3D mtk_gpio_direction_input; chip->direction_output =3D mtk_gpio_direction_output; chip->get =3D mtk_gpio_get; - chip->set =3D mtk_gpio_set; + chip->set_rv =3D mtk_gpio_set; chip->to_irq =3D mtk_gpio_to_irq; chip->set_config =3D mtk_gpio_set_config; chip->base =3D -1; --=20 2.45.2 From nobody Sat Feb 7 05:00:02 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62494248894 for ; Fri, 25 Apr 2025 09:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571674; cv=none; b=Ct4ZSFfaKdzZRJuE0TT9YB/qPFwbUNCRy/xxAjsQBmJ2GYmubnyaAtAPMIg3AOH68fSxk8hQ82XoB7z7S85tUqGCBdcw1TOd6AOAd4n2AFgBr7WLFuue8eoy364VHOrebZlM5Z5mZCWSwR4t6zmfFxRaNw3h1JQjdDDGTrF2MNs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571674; c=relaxed/simple; bh=uN2bLV37uQ7yhWkU01vCeS3PVLdk4JLJCesbUjcmI9E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=F6hxvW0SvnXokCNDTgEOMVTcnzSEdMXFrVz6WXPYHDpqAbQyjIyGp7C0gH7LaOi+zE0i5VDmqUBmd4dve+B1FLEmWjydQNnHkoeTfucX/SXi7A9tMbb6PdobMXe/DzGAKPX+AJ1ZGR2hwlCnMDZOALhEE1jJGx52Wi3O/okuvDM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=u09wwlHn; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="u09wwlHn" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-39129fc51f8so1551153f8f.0 for ; Fri, 25 Apr 2025 02:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571671; x=1746176471; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vZCsMbe0k2wJLLxto/ZgvqQ6R0v/kHbZTO0AQGYG2lM=; b=u09wwlHnfHMNDB14IRJ3ySkdwNEEpoDiW6DiNs/OFKl1XTlirIgsEA4C5n6UA4BmNH L90RVQd0ut6IwEE5RZPcuoKThp+L3z+lNpO2hHnWlkX9a3ysGwRnr2AK88VbRQmLdZIv 3ED26TSwXN573dFOS9+k+OMnBsskkMO0qahAUdVYyQ/dAEHqm81ft7mjEp8Qdmro0Ogm umSRSffROk3OBzhpyeS5mnZW127/awecrIxgujmsk4gM6a4r8F3RxA4dYrT6X7Ba8ScO FSNHZgq7t2Rt8mD8yTkp0DSvKpEbF+W81EjnRoQDAHw9Yv/9UKMJwLf4OQmRfN1y7tSl +b2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571671; x=1746176471; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vZCsMbe0k2wJLLxto/ZgvqQ6R0v/kHbZTO0AQGYG2lM=; b=WjfhxZbLF1I5faLnCFXTa9O9zhRfOOPYcPGoA7UyAknrVqVtmKOYHaMXXRHdc5bDK/ 5CthYe+9g9NIBHuIl6qaxNRO1tsgVZ0YSZbCT3fqvmVDKSakHFPNAPUgpFWN6X8MZX6o ZORklqcARFmEfqIHMZRVAJdgT5bDHiHX3c7716NEgM4Ops4ePJDLKLtgBFlrPGCvE0h/ Dt/2TJFyP9+aIJ7uoqiLZH0AQdpJQg58DWVQeEwrubK3Bk+zdHtdtWKKA7MgoFXZhkK/ latuNV5eyDYnkiEBqqEA21bOmmyGM4Kl2m6p7ghCDtbSPowTZ7OZJZmWkWDaugAFgNrb f5Kw== X-Forwarded-Encrypted: i=1; AJvYcCVnAqKS4LxH3C1tepXSBhFDAvQ/wzz18zZ3tJNyzzbvBfrf9kXpKAz7kiHTtDxnTX4g6KgXM6Ggl2+gqLE=@vger.kernel.org X-Gm-Message-State: AOJu0YxbtNGmp1XmQFy+FQIO9wDqUmDoutxvpfJKYWZA5WFNsCa0E4gH 3J+/RP9BWE4EHuQG/eMBmz2CR1AODqHAZn3r8lOgKI0mw7B65eT0Kz3kHXi/B0c= X-Gm-Gg: ASbGncvP0ArPmhfQm93X8OQtuLmeI1PG/8oijIwkBPb7KalB4Ls79b7OudB/wGp9QSx h5110IcbDZFIqrBeYZGiyXbsBa1Arw5ulFbTujBYN1zZVGXsSSq/0rQmgFrk+t7v/vmg18UedKg v0EnQ5/irdlclKDcnTX1acSBbMAiabVKSbAcDWh8HLSydsvpO6Q6jFXLxcjHI1UA4nDgTn5lOKl k3EK+MIifGT4O8dUZIKuodCPI6kTTlRN1QAiiaiGUCI1mkyhy1MkBggY4a6LmksC1qnMS+VOGD1 AIsGXZM0uH1hOITc8UAqJuQFnySD3EHoRg== X-Google-Smtp-Source: AGHT+IGjMuaC5BmBdOAnNw7BlPBWn5JH7qcxJo02GNuwlEcPgWwbqMJDn55V+Su/wdq4y957SwZGFg== X-Received: by 2002:a05:6000:4282:b0:39c:1efb:ee8a with SMTP id ffacd0b85a97d-3a074f39870mr1172764f8f.38.1745571670663; Fri, 25 Apr 2025 02:01:10 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:09 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:01:00 +0200 Subject: [PATCH 4/5] pinctrl: mediatek: moore: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-4-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1973; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=K7gLMO3ecqvlBUfWOX7ZuqqYALbBQMdAQOJ0o+WSEZA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09Qz3rBKY7vXoDHlL6r3flVEWoOZY6T/FJWf h5JONq15geJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPUAAKCRARpy6gFHHX cisXD/9P57W0/UnC7KoUOw8VjozyNtjJ1rN06vVzNxprMdmp9PDpNlGb0vTLsahD+4NFVA3Q1BL p1W7I+viQtlMMu9GaPYfJgGOurfA8HdjHskblOFIVaifefVYzwy2jSyIPjndcW+rdrur5zeAwkl 2zepHYZVYpZK45EtIf+V/938Oo0Sfmprv9Jio66HVvXGnuznGrUD4gS7j1tXl1/KdBqqIks4J7K IZwYIGhxQCVmj55ubdey7G1qgtAqasXlnOmq9xRmLGU3IIqENBgY9EV9KwrH+voXt3ICY6gqxy5 ecCqIeMwR2gTvsucRyqxVP3ZfLDYlzvJG77PA5K+BBEorzi/oTKKRomwKzJl/s/iWZb4zX97gER t2Zzm2q4K5EzXkWxGUzYdSPep/j22uNtt+kTIzw6PK0XYmS5NPOcvVC8rmjW1NGTOGndaoMkDHY 6MGmD/rpGacA17KSYUf+2PPtddEV5m0SDFIR41604HfByN99tInJvAKoH7Kn9s39Mc0stpq/RdX tCJiiYx/RWCcSM5ECjAiBzfR0o3lAyuS7+JcM7IAzc+W1rRG7ZJM6VQyOw95oe3Iupn4SLvv6yR Yw2WuWfIJnLiAzyPLUNqqXVE3CeyFs8pJuou+r91bJDnhIWJo7Ukqz9HMV6keK0XO6MUEid9Dec y24dE/UdR6r4niw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-moore.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-moore.c b/drivers/pinctrl/med= iatek/pinctrl-moore.c index aad4891223d3..827d0f191031 100644 --- a/drivers/pinctrl/mediatek/pinctrl-moore.c +++ b/drivers/pinctrl/mediatek/pinctrl-moore.c @@ -496,24 +496,26 @@ static int mtk_gpio_get(struct gpio_chip *chip, unsig= ned int gpio) return !!value; } =20 -static void mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int va= lue) +static int mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int val= ue) { struct mtk_pinctrl *hw =3D gpiochip_get_data(chip); const struct mtk_pin_desc *desc; =20 desc =3D (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; - if (!desc->name) { - dev_err(hw->dev, "Failed to set gpio %d\n", gpio); - return; - } + if (!desc->name) + return -ENOTSUPP; =20 - mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); + return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); } =20 static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned int = gpio, int value) { - mtk_gpio_set(chip, gpio, value); + int ret; + + ret =3D mtk_gpio_set(chip, gpio, value); + if (ret) + return ret; =20 return pinctrl_gpio_direction_output(chip, gpio); } @@ -567,7 +569,7 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw) chip->direction_input =3D pinctrl_gpio_direction_input; chip->direction_output =3D mtk_gpio_direction_output; chip->get =3D mtk_gpio_get; - chip->set =3D mtk_gpio_set; + chip->set_rv =3D mtk_gpio_set; chip->to_irq =3D mtk_gpio_to_irq; chip->set_config =3D mtk_gpio_set_config; chip->base =3D -1; --=20 2.45.2 From nobody Sat Feb 7 05:00:02 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0568024C095 for ; Fri, 25 Apr 2025 09:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571676; cv=none; b=C3XTxbDGgB3A2VA0e6pXHVW2woT+pdubXsbXhfgwK+Kzg7nPdkuB3Iu7hrI4JqcaqSPig81rRLwq7gwkxrRP71HNAFvwltWRy++TRPmC9Nhyq10Qg8zIzvZZfK+yiShVJgwJytghfClflcayN+N9CgJ1N2Lm+TnHMpUwacXPqo0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571676; c=relaxed/simple; bh=jbtD4lxoo1Rym8zGIQhQtZtmYwoyyWZdSONqwD+LmXY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=txLc/x8mL3GXmgFm4ryihedC8DKHM8KPCgT3oGVxv4RF/w74a79Cd3TMz3SxA+ZcV7xFrRij5JPQ0k587pXG52ChQvbDqkTBn76IjDCCLD/CvmhVp4fmOMQW3PKxC0tASgLZTgFE/hp5m6ocOdvExY+b6TAI9EAWRoe+3p+YFaw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=H0lBOLMg; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="H0lBOLMg" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-39c13fa05ebso1286267f8f.0 for ; Fri, 25 Apr 2025 02:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571672; x=1746176472; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bSvrLQBfLq+B4ut1ceVEmi9/bo2rmWrizkJ6hXk1M/s=; b=H0lBOLMgy6mEpMCFeYJOt4AYsHm0+x5PW3AxnlmDOHAoEtnxziU02zBEN8dLJmFdy0 1z9E/BcVUqKsVmQOcaSTPkGdKhtnv7QMdPurpIAZ+OWnzZCRHaNmYuMWr5KjGZc+IAVR jyKqQO+AG39VmHx269jdEtCyIZbIhxCxrT35guldMi0/8nTyb7KOJFutI1ZikvZ1JfjR i4ynuU3F02m62MBmZeRuoL2nuqVtfPsjBZI21qzQbwxqgbXkOHIrE11lQAcLQgjTFGS7 FnTH1Y939hW03Cyx1PFL4oyMikGDtsLKGFo28lhB5hcPc4baVLkCP4FP5S8W9iV/B0CC 9/1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571672; x=1746176472; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bSvrLQBfLq+B4ut1ceVEmi9/bo2rmWrizkJ6hXk1M/s=; b=GrwUFrKNZ8ujPBnc4qDBMBR9IZAu/9rhBTzwFDBTPTfXvCwYCBjGF7uIuVqFcSL0r4 V8XjasuhS8+R8uVQ97ZpH8l9DGwDQOv2Blif2mBDhC3TGRbwSE0lRQmK53MEMv/v1kZ7 rrgv558xtGJDwMWBYYSm21+cIABawC1jv07d1ACGIay9u9YwTX9ZFWvT6fgrus+IfVnq LiOAlNge9BlBl/+a6/JL2yGKIbKoyjrzS8cUuyM+ImuCsl5J1bABvD2n3wd/xAA7sG8j ingNQo2L0/WQxX93UI6UM6z8GIFzgolBejsZam2SJeuKSKwFq7P0TphylfiTASGJY0my BSPg== X-Forwarded-Encrypted: i=1; AJvYcCW0tDkmkXc/YcnJ3Wu7TonvHYJzxjVvZhirKta2q7JiJq8VlMuA79fogg+Y/9LMRrHwH1SrbL35ZOHkZVI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8P3B+q/h/5sXflYGiPxtJsflcbW85vK28BRXNL9YAGZr1JhmA 6gCLZ3VRc9EubcXj9CSIHRUFJZk8fLACiTW9UcOjscwFmlyyo7ws7TPHwcJXuiE= X-Gm-Gg: ASbGncslJsjuNkBciXY9JH4E59xxUPf1FIkGn5TDxgdHJri5BoCZd6afG4p4gYAmvZk L/jcbu7sjpAc+mxX5oIwiZdo027nkMoK2iOUEXfd8nakVoRRDccG7BOnccar+5poFRf1SJWaxP9 8ssGS0c7jlJegRBgfOgzR29/EIrIbwLQ7W3wg7yewy+qk82y4KanMhxtE220vfSLnjoVZ6BpiK8 oOfx2YuK0EiZ1jcsTNbJRjcOiqsAziG8TPNIGZADRoiCUgyV75kFY6AjCgHckoF/qtdLGOsH1cd j16/pNNIOFn7HQuTamrdvqwgnj1QiM1avw== X-Google-Smtp-Source: AGHT+IESAKBg/vUZr7+HdyTu7Zt6c8/2gvrqKe9AqCVjAbPvKvH7CRuaevUBHKKYT49ezlwSd/p7oQ== X-Received: by 2002:a05:6000:290b:b0:39e:cbd2:9211 with SMTP id ffacd0b85a97d-3a074faf2f4mr1109587f8f.55.1745571672261; Fri, 25 Apr 2025 02:01:12 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:11 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:01:01 +0200 Subject: [PATCH 5/5] pinctrl: mediatek: common: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-5-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1986; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=DhR5Cx+h0tuPThTQMfkVBP7GDMglNgqo3TCYghOZtTc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09Q1qfvXLmie8Ad0KxRLSMtwSzORIC9DHLME ux5GcRSG1uJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPUAAKCRARpy6gFHHX cin/D/wN4TReNcVZdJpBQ3ij4ORtqXCjpIzT8TejLJmPbAW7VRLBI73Sot2lYEh6ivMjaPGV+Ez ff8t2p6qHWL0XyeySWLjPm6Sa+nVqRjbyFGUOty8iQicWy3VgU0h6OZYaOlbXE3HSchUFE7AuvP l/20EdnceslbHDVHXe3uDbsWvxyZn5zCj0Kq78XggHgGsprpI2qVyAFDUBbwaWh+1+myh7YJx/X yJvdjTBEdvqoMiqeuJaYhx/t/paIekWXTGSEKqVdHPp1hzb6KRCrycp6u6jzsZvnNsrMKcXHxb8 9/3Gc6GRcWE7CxSmBqB9B0mJTdhSHRZa3YIRQTpeMxWjxGa30VQ7vMJvHygVdwcFOueRtPlcXZz gU7YuuI7Ug885r7Xoodq798CBFf2KN6mjY699nAmfRjbxVv+FxH1WyP0WBmENEtDQ8VHxfPJbgP WWvfpj0aKZTuEMTvbguqYDv8tC6fjQApPkWtivimKfsAvwjsxNqFKKgcWTlaNMCai5ye1+WNLlF o2XVBinR1y8178arKTT0Sa1lWO97DQwu63sYqqlePtrT+KmXA6ixprYXzYR5iBLI0RZGMNF10bP T1xXXdlDIe8hx3XfKDVXoo/cUL60hAqfNjdG3/Z8zF7bbaR3dzsYYEOsDCOqiO/bRA3AGSM9R8D Y/dstQRT5IQGDZA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctr= l/mediatek/pinctrl-mtk-common.c index 8596f3541265..de7bebb9a6cd 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -86,7 +86,7 @@ static int mtk_pmx_gpio_set_direction(struct pinctrl_dev = *pctldev, return 0; } =20 -static void mtk_gpio_set(struct gpio_chip *chip, unsigned offset, int valu= e) +static int mtk_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { unsigned int reg_addr; unsigned int bit; @@ -100,7 +100,7 @@ static void mtk_gpio_set(struct gpio_chip *chip, unsign= ed offset, int value) else reg_addr =3D CLR_ADDR(reg_addr, pctl); =20 - regmap_write(mtk_get_regmap(pctl, offset), reg_addr, bit); + return regmap_write(mtk_get_regmap(pctl, offset), reg_addr, bit); } =20 static int mtk_pconf_set_ies_smt(struct mtk_pinctrl *pctl, unsigned pin, @@ -809,7 +809,12 @@ static const struct pinmux_ops mtk_pmx_ops =3D { static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned offset, int value) { - mtk_gpio_set(chip, offset, value); + int ret; + + ret =3D mtk_gpio_set(chip, offset, value); + if (ret) + return ret; + return pinctrl_gpio_direction_output(chip, offset); } =20 @@ -893,7 +898,7 @@ static const struct gpio_chip mtk_gpio_chip =3D { .direction_input =3D pinctrl_gpio_direction_input, .direction_output =3D mtk_gpio_direction_output, .get =3D mtk_gpio_get, - .set =3D mtk_gpio_set, + .set_rv =3D mtk_gpio_set, .to_irq =3D mtk_gpio_to_irq, .set_config =3D mtk_gpio_set_config, }; --=20 2.45.2