From nobody Tue Feb 10 13:18:08 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F45923C8AE for ; Fri, 25 Apr 2025 09:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745572127; cv=none; b=OFSNNPQnJh1hBNLlvbyXOuVGuoNIsHguGM04PjKFFTzGe4S4Ry2gzwVki3jNgJriU57JoMjCXIS9pe59JQEavxXZ82Q7ShBH43cCQa4Csrha2phKBOoNaCPVJhUcHwXJfVpNjyuD86fm+aHFnayCWhaKs/xGvug9m/tCPXXKsYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745572127; c=relaxed/simple; bh=pTrO24s8MBFrLrxR0rAOPN04paVQyMBRmX9Uiybwymg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fom7QFKvpvDhWz1RDRin2DRf43ctuLNs3wX4wSzXQ8HXT7udByLJNMVJM7EbPJ3zL4/jMVSqO7Am+Tp9GFOHyNmgbxQUJdELTUCPEtcdfrIKm4+VWux39JZG620u42BbvfKJx4hQT/DUTGwLMX8QtLpqELqiii4KfphfYVJtEyQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=dX7yLZpx; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="dX7yLZpx" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-39c1ef4ae3aso1283733f8f.1 for ; Fri, 25 Apr 2025 02:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745572123; x=1746176923; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dlGoB/HUZg4yDoY5L3zieLRRojeVT0zMfmIc8y47oNU=; b=dX7yLZpx/Ke+a1SCtrfOm/tvDE03LnSYSxKZG+qjihgkIVvBoDtzkwlYgsVDY5ysgv mqVrKoTJCGfXBCPUI/kewTHpXWgyFnWPxPWXiOL0SQuGeXufJiAMXEhmVzMwTJ5othoj YR7nd1LC8Cr97hSvLIfIy0JI6HZ4R4JBIa0/mxl8E0Uox/1a7vCvAVUQErSagrFxWbOG e+oNV5KbdCw7FkMLcptjWNjumWbTMLUYKnaqqQvi6ylbEtW/QhZMQxmnQTqGvPgJoHZI oZPjctg47ljpj6qkqlumHx52qcNstSy6L9SmU3HI756f/z62y+YTHjOqBNXACVUP4ZRM hIuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745572123; x=1746176923; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dlGoB/HUZg4yDoY5L3zieLRRojeVT0zMfmIc8y47oNU=; b=mc75FaTfhrlU2xMM9ucpFHIYaMOES70J3mSDVG9QYHjBfG/AQxYvZCv8XEo40YFD2h 366N0AvbjOtw6MSYn9sSE2EoHSj83CjlwW596QTXyk64dgklUlOejwe3VdnnemV1hmkY sUcxE9oWy/AMvbt8GIty7lSrd59g2EL5Q0C0DRtYa8q8+kFAHx7d67o0FaQOQ2tADEkq PdCY66nMeN5yXtkblDO6Xciqw5A3o8sv0nI1Yt3PMDi95hBR4n8P3OA38JHZCY3va/lh UVKwALwfooCt3ng4mr06a/NMtGN2/BQFkQ8JsmnWftl+7gS4OCM6HapHrDQiLPzzXBhO RR0Q== X-Forwarded-Encrypted: i=1; AJvYcCVWeZoEP67r3EHEfyOIJayAfZb2TlwKfOOjiePD91ItslTiGiYI88VsrNSv9EmvcAOJwTp0kRFuXLtvx3I=@vger.kernel.org X-Gm-Message-State: AOJu0YyCo8N/JhJ/FN2EUHfooAk78+1YmIugb9EBEVpWEtbyhz3hQHT+ FdN1oLCIdOWDnIBGooAFR5dRgz/cP6nivHVQIwJMCMR5e48SLdFxzOLfue8eU7VGXY0W2DjpGmP RzBU= X-Gm-Gg: ASbGncs6S6nSTvo36nsvOCfojniX4C0gOrTyGz/sCnboLlw+Nov5w07DJwvlUNEWD0l d8FaNXBNPD6QBnMqZiOLmVD8kr2pLLjlmjxJdbMjltMLK1NFx9XgNprSVLbD0Nmz0XbN+F1+iGA XtE8vvpKE5f6CSRAmhx7uTW+HomIR+unenPQSu9mh9pzKmGGEy9FU0hMVdqVjoeXWlqzJwU4ZSZ 73y+luU8v+f3ixJiTin72zQvvpxyRtbLm321v+kL8LwWKZxabqHSWiPBnt+GVPWrzVliMRFLT1S TooBpJWJSgDIFYHMk5kL1brPJi66KsbT5g== X-Google-Smtp-Source: AGHT+IG+vaC7MmgQ1lY8Xs/s97F/M6Om983foVEu9vVfhXq+DCq1sUbfXts/z/dMaAJgf6ogHaPHXQ== X-Received: by 2002:a05:6000:4285:b0:38d:e0a9:7e5e with SMTP id ffacd0b85a97d-3a06d641ee8mr5322988f8f.6.1745572122724; Fri, 25 Apr 2025 02:08:42 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e5c9cdsm1688909f8f.87.2025.04.25.02.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:08:40 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:08:31 +0200 Subject: [PATCH 3/3] pinctrl: bcm2835: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-3-6b8883d79b66@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-0-6b8883d79b66@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-0-6b8883d79b66@linaro.org> To: Ray Jui , Scott Branden , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1810; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=aKxxveH0C+uR174fNORC/elug/yziUniASTqQNWz9nc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC1EPXzEnCILbRcigkhvMXKkn4wcX8TtqvQacB KB7TBd1QxiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtRDwAKCRARpy6gFHHX cmUiD/9yZv6dvT2Wc+LvJ58hLcbjZISnPBDhqi6UcP6kX2qjRFckiM8hGhHOQymPP4CMm0Io3FB 3vhD5qFTWMyUqVB20hNF8fzxFSAF7z1w2CZ78upNY4Ty8iYKY6iXlZkTb4/I2vkUQElKJc/FKuz ll539+UounWRewqOlHwUdLlhdIg/p3K6dVzXwe7zVGhLh4xnvbHm8w0mOjziSgYepKhgDfG2h/e kECtA453bSJM8Krn7c8+9i/W7S50XLMt+8Q/uK5eerfg2Ix595UQNVT8wwygug0q0ex9i2nJPxS kLljtjYkeCbEzhpHvXPszQKP8S3ACP7Upcx60XQ32TFPKnlOnt34eNH5XnLRbhgMA44mfrVToIF b4bfmC1mhk9vjJmDe95jXH94+nOr5C/u8C17k5eoxpGwd/dzJISDfRBBfNPJou45LONB2eNPoBw 07rSsnepk1PHd2FzBRPi2yebyN6YD7VmyRqSU6uDB/GyaCM+V/6Fdkj+6YzN5qezh314hAUT3Hg Ua7v8riePOMzxWiQIJGaMQmNjAC6gHILJn+73Fe4sEXX756CFMp9EyAIYp5KffDuBwm2uP9ktkg xTJ9J0vBSw5fxWyfFhVBhP2ijqhpM/l94+zEJuw11XNTxhheJTSyayQWYB0i8TW7Dd34VOtqoFE HAHE0Qmyq/keRLw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pi= nctrl-bcm2835.c index eaeec096bc9a..826827800474 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -356,11 +356,14 @@ static int bcm2835_gpio_get_direction(struct gpio_chi= p *chip, unsigned int offse return GPIO_LINE_DIRECTION_IN; } =20 -static void bcm2835_gpio_set(struct gpio_chip *chip, unsigned offset, int = value) +static int bcm2835_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct bcm2835_pinctrl *pc =3D gpiochip_get_data(chip); =20 bcm2835_gpio_set_bit(pc, value ? GPSET0 : GPCLR0, offset); + + return 0; } =20 static int bcm2835_gpio_direction_output(struct gpio_chip *chip, @@ -394,7 +397,7 @@ static const struct gpio_chip bcm2835_gpio_chip =3D { .direction_output =3D bcm2835_gpio_direction_output, .get_direction =3D bcm2835_gpio_get_direction, .get =3D bcm2835_gpio_get, - .set =3D bcm2835_gpio_set, + .set_rv =3D bcm2835_gpio_set, .set_config =3D gpiochip_generic_config, .base =3D -1, .ngpio =3D BCM2835_NUM_GPIOS, @@ -411,7 +414,7 @@ static const struct gpio_chip bcm2711_gpio_chip =3D { .direction_output =3D bcm2835_gpio_direction_output, .get_direction =3D bcm2835_gpio_get_direction, .get =3D bcm2835_gpio_get, - .set =3D bcm2835_gpio_set, + .set_rv =3D bcm2835_gpio_set, .set_config =3D gpiochip_generic_config, .base =3D -1, .ngpio =3D BCM2711_NUM_GPIOS, --=20 2.45.2