From nobody Mon Feb 9 09:10:58 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC22F238176 for ; Fri, 25 Apr 2025 09:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745572121; cv=none; b=K9RDiJumrhT8eAI74eqD++vyXkKt8GSJf2FIEIJxcLQqaMmRBruxVBUB2KYj4VaZL7nD4GxLNhgVqtO128qTdvTGIiTNoLsqqZGarKR/4V2/Dpzrx0MH75G/GbTxpiURamE3T8VSVA1dgAsrIqA6hXKr06A1Vc/Gq72iQ5fB1Ms= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745572121; c=relaxed/simple; bh=7S2gc7URb0PsBGnyXfc3DFJmPNy7b/D4W8R2OlvjVzQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YMPW/ntImdK7RHh70BE6PhQnLnRvD9NUcVKKgRUUUwUIe4qCtXwIitM34ebsuLlR5VSlf1wtgSVdQOTvc97SNO2Nza4656HiAS/fqwnMyjfYO5S1AAmbGs1H/k5kaWUxr/NtktZOHxR2w+8XVg7TMy1y981vUa0IDC8rPZ2VFGU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=bleeBNnS; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="bleeBNnS" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-39149bccb69so1766025f8f.2 for ; Fri, 25 Apr 2025 02:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745572117; x=1746176917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0YD/g74cE2O1wy020/OZZAa+Y4T4rc7dR9EtJbvV3wU=; b=bleeBNnSBR2zpbd/GXqXLkA8MjBbnecuVfbJsdF7sqfjetP4QKZhGsqPkXLpMYE7RK EQELdh7ryuoMcwXvq952f2uGBH6Pb3RU7I8I2fVov2oYzzgdPrTLDzaYWuZ6QvJs4VOJ KhOtWvuwTlSBchPMC+mZ383Np88Nz48Rxr6+ocrp313A4wgVUVKcAUj/BCjXHrdwxZ0O 0ZY66EvksaWLK84MzkXAd0lOu7JqjLvLpHuZpa0Y0XFLFwtXv5maRcxe78NRghdhxmvh ffLRPsqIU5gT8PmFG/2DhhrZ+e+OXcKexKt8UMOimlLYqBanrwzvY8CDafVezxCw/zRy 9XiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745572117; x=1746176917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0YD/g74cE2O1wy020/OZZAa+Y4T4rc7dR9EtJbvV3wU=; b=i09HVgCcNvPlJettNH/Jeyy3pYZ7jZSNqwycwrEWM0LoXDEjUx4wg7oQxURxdfvb4+ AaFHa3ZjnQRndzBAV0V7ewDZMXMrFqRj6e9xTGgnBhM7jXqhkCEQrLh7tlgcOUL8pzsr MxjRuLKZDXhpUzraHfE5XBQM1PrwPOP6QSHASmZp+8yVLJKiYpB3MH7yhv4aotLM9FBr TklcMu2zFIu8GX+MomzItBsL+fPbbLBbEaR73FqfAfboCm/vejNHCNxCL1ezbjra1yJT nro0FRYkRwGgojSEbJx67o8fmyQZSp8FNvPUhxGUwC+22HvrR0gZMX2ilJYt0tNjiNPU +JvQ== X-Forwarded-Encrypted: i=1; AJvYcCWrr0giCLHi/Yk3ooHhEPyyV/UAVxfC24V1wXGKPEtSrfWb8JSo6wWCWW26IhqzXTwpCtr69DhY7J2y1Ok=@vger.kernel.org X-Gm-Message-State: AOJu0Ywk16j9AhyA7Fv+RRxC1f0xvJBBdXF/osidCeLpiqCD7PnfVBi+ d1TGK2cnSElVqNO5VUhiBVwoSotcAZQkjgMerrbDBpu110D427FSmRv3UJGmYyrvW3pTrjKlodf 7iFE= X-Gm-Gg: ASbGnctEMu+jKRRH15ClmSVn5K+uvwL1Q4yLjutXJQpMpm40jlCwyN4A/IhtQNYrYi7 62pQwl6Mpl79gk3tZUlw3eciPI5khIapXB9zGe9ZorqJgdEOXWmq4fwUCYtYNDj7UAO1AOyAzqR G/kZDKXCxnb0jQ8BgP5BvH0KDl5rDlu3KivBsClc+PDSC9F5vnYnW2A3RdqpE67fERrL51JVNf2 K7SnfE68wmyKGMdRaxUFbiThLZsdzFfQh6hCLxUPnEVrfApZA8ryavDBA2gGGwvea3pVk9+MZwy ok3VIR2R/bFqdaYsESwNRk0PMBb2NaT+9w== X-Google-Smtp-Source: AGHT+IHCuNyR95UNYI/0izXIj1LRfHaEgDOIQ/KPvSJKLbV9AkvjEqEphDC9iCD0AWLDlHAVDkvOOw== X-Received: by 2002:a5d:64eb:0:b0:390:fbdd:994d with SMTP id ffacd0b85a97d-3a074e37904mr1224414f8f.27.1745572117165; Fri, 25 Apr 2025 02:08:37 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e5c9cdsm1688909f8f.87.2025.04.25.02.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:08:34 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:08:29 +0200 Subject: [PATCH 1/3] pinctrl: bcm: nsp-gpio: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-1-6b8883d79b66@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-0-6b8883d79b66@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-0-6b8883d79b66@linaro.org> To: Ray Jui , Scott Branden , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1564; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=N7w6ShEtcDx0natQtD0HEUwZNrRzhk1g4hjaD5jLcAg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC1EPQG7Og0taBdL06rmp2Qd0XqgRcsFeRFXYf fe9a9gFLc2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtRDwAKCRARpy6gFHHX clLhD/9631+iD3Op/0JhcmhzNPwc36GbPSCVaPf9M9MHPdntWvM1bDIAYa23+LE1y7HKaCnoA2C vqCHsaNy2PZUwRuPg7M6COErn7z7+BXKuGLRHmQoabLd366zB8+maN2WdoAZfUOjpPEBrDvuv9D ckhVkzuRNCuVd0LbqoXhFKtJZngA0GRjBXgbN/bBF0+ewM3B/zFdkBZgizZwaATSNjFzs+8WhKa ahubiibF7/JrllxjeyvJHhvwRbk0itwqtmCT5XRLMvTnZZIidHv3EAF1rdpVcD8sLq2+IM1/sj2 9aBJteBDYzOLrxAN67IU9ZOHHmWhwdoOHR/85ADJeF8eyrhtZdOwcmenqwoF4u7KfSndhhaRauA Jl20Z1Jvf97+mOJMMV9T+tcVaWNYe9fuK3HUgZatheNov9YjPrdalfdLhEzcsDlv3vnYJNWgws3 wr98ZphmsUhsXhTK2PdTDPp4kNJnj1jAo/xxd/8wEubhn6rP/vVKvE2YKjLPbgCnsaO2KYqvMNy Ee+3d6aWvp9dq5Q+XNLbrroMe/U22i37w5um5akrVDwUmnwMdJQ6JvVG2ql9sKmBo7zIgjZDv9H UeQ8p2ve7Q+VDL8EdifOCZ/+MzdlHrDHQivPB50M7JsPuQA2b2gPsmcyKG9j/rHlO13W7+MKKmZ COdKenIJr/yyboA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/p= inctrl-nsp-gpio.c index a96be8f244e0..b08f8480ddc6 100644 --- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c @@ -310,7 +310,7 @@ static int nsp_gpio_get_direction(struct gpio_chip *gc,= unsigned gpio) return !val; } =20 -static void nsp_gpio_set(struct gpio_chip *gc, unsigned gpio, int val) +static int nsp_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) { struct nsp_gpio *chip =3D gpiochip_get_data(gc); unsigned long flags; @@ -320,6 +320,8 @@ static void nsp_gpio_set(struct gpio_chip *gc, unsigned= gpio, int val) raw_spin_unlock_irqrestore(&chip->lock, flags); =20 dev_dbg(chip->dev, "gpio:%u set, value:%d\n", gpio, val); + + return 0; } =20 static int nsp_gpio_get(struct gpio_chip *gc, unsigned gpio) @@ -654,7 +656,7 @@ static int nsp_gpio_probe(struct platform_device *pdev) gc->direction_input =3D nsp_gpio_direction_input; gc->direction_output =3D nsp_gpio_direction_output; gc->get_direction =3D nsp_gpio_get_direction; - gc->set =3D nsp_gpio_set; + gc->set_rv =3D nsp_gpio_set; gc->get =3D nsp_gpio_get; =20 /* optional GPIO interrupt support */ --=20 2.45.2 From nobody Mon Feb 9 09:10:58 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DBBA23A99D for ; Fri, 25 Apr 2025 09:08:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745572124; cv=none; b=q/9Fwp0Yoa9NpUUxSZjgN9rjBEMAc6h0549geQ3FDqDI1mQUmpgx/JOsVQo4guvFJI9In9IaczkvzZFJ2d/PnJ41KAqCXko94wxyn+UkkfdTtHqzr+UQbjwuV3LABhRTgIQOGB/kQjJz9lG2fARHkUg/xMkYcs/lNDxXUT99vro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745572124; c=relaxed/simple; bh=EulgghYY9EmhroqWoYb5VtIek8zQSwFJqay015WfuEY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OFaDrtAWtM3pEN5QC9ssXdzOe1yFUp7MBO3/tD7F5hP9o5qmU5ff/Etg9VVH1zYtxGNJLbKn3zUcOr4DSkoG8bFGeQzmBipwGakpL2+foUO4OjJC7kv+8wi/Fo6jYvewetgTAvLvMSZl7LcL4+pVRhWlOH1f1bvh/GZk1QB8TEM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=zsK6zUoz; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="zsK6zUoz" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-39c0e0bc733so1796017f8f.1 for ; Fri, 25 Apr 2025 02:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745572120; x=1746176920; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=i+v5BXhhKCYYQq4gpYTRiJk77N1zu/YeJY08X8KspxQ=; b=zsK6zUozVmJ9/TzYyWWuW3pE+QnJogQLOwddHjZAHMMMH5+Hq8o1OgolIDnGci6x02 8QDCgKXcHt4F5pZyQtNVmTHVUKW0aXLwfdJwnVq93f7pD1fVJvZyiMz/oLv6BgT05icK /Jq0KTdg3yk7cMvO/gQ7yiSinWinym3cCOo02K5TE8xPGI44tTf7RXdqcgc0Jg8BIZli V3ju4YLzlO7j6keGVZj41xhRKA+6SPDbqkBBERJt2WYxxEiLZGaoA9DRxBCBo7eYrC0a obntM/IoH0nBO4ggIvJFTcdSQfzsriwjqwrmfKH0OWu+Gg0iBNoVazZioaMTJMtG4CPK GUkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745572120; x=1746176920; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i+v5BXhhKCYYQq4gpYTRiJk77N1zu/YeJY08X8KspxQ=; b=ojhM1tveQV/W48lWwT9JDoWUiJ2iC+5zc4fS6f/MnIiV16G37ixM10v2IcYG/ZXTZy 7uImW1G+5DZOBWpAgz2nMrSAJ4jNeZzhd3hqO+gb6C+tkrPkGqxBe0WEdU5mbXN2EApq X6LzvMbYSgYVqh+4BfD7DIGXQvGFIirJxAP72cEhWHaJbhL2j3IWqmrCZjvHrCvLCk+c elZXXvHfOBCydtMyxVM+Fssc1SU1TkCpiUa5Th6Hnynnvk7XPLuuoBHeZLSoLMRgbp4+ Iy+qLY71v7vSeYBidPS5TOEEqse+VUZuks03rMR2jcVHtyUoEhzc6W/CkKJ7OPLjw+fp xKVQ== X-Forwarded-Encrypted: i=1; AJvYcCUYlUHFVxxbcz9Ble19L7DqvuL4/MYHOJHqBFuzQDIKfMsFL3vZU87pI4BNLwJ67RaymRLw2cyS4waK4XA=@vger.kernel.org X-Gm-Message-State: AOJu0YwU9YRvXEWOGYN2aUCn2HvOWEJUTQAzauV83Ta1pvsmvWIUGhNv iA/HU0jYqrMM813v5oDu8ZKx6IaO196BAu0oe0jydtx/852o2vwGbK7gDiD3f//OUqzAPb8E+wE JGIs= X-Gm-Gg: ASbGncuakKaV3a74Jp+LMzcunUoBj1dWW9S8AKM6Sq36jJlagY0Kd40dV4JHX3uXoHS 7YMOl9ccPU9UEZVdVXMWOeEhjqpIaYAbAxUBimhH4ylx6Aljla4az3iULPj6ijHQqrLvr8+7T8E 7A8p/wlo4FqgbNpv+av9vTVAuG1F/XMDkjPDyDBRHMf0si52bZcPrgA6FsvMwMXUA0Oron1nGw0 WPoaD9jdbMbzs6PVr/QhnGbT0dQ3oXDo5E92sPrcjkIRhwRf9jDU/R1gDvHzUrBQIoMC/hEfi71 /dzF7FDMExhT9V2Kzoy7bmkwimSrXn80XA== X-Google-Smtp-Source: AGHT+IGN/vWTOOdJRbfqbsJsmvKshGEv6l4OK38T6XOXQRPgrvaijj8/T19lKBfroHc+Nolpyh8Jqw== X-Received: by 2002:a05:6000:258a:b0:391:2c67:798f with SMTP id ffacd0b85a97d-3a074f154f4mr940261f8f.41.1745572119738; Fri, 25 Apr 2025 02:08:39 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e5c9cdsm1688909f8f.87.2025.04.25.02.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:08:37 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:08:30 +0200 Subject: [PATCH 2/3] pinctrl: bcm: iproc-gpio: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-2-6b8883d79b66@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-0-6b8883d79b66@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-0-6b8883d79b66@linaro.org> To: Ray Jui , Scott Branden , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1648; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=AXQvvsX8aRsrH6IPjREq5g+zCKjZWUt9eQLSBi8qPzM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC1EPM33kYpK05MSkPsmYPi2ni2pXZtF3jM//c +NOmi85KW6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtRDwAKCRARpy6gFHHX cumND/9NDhDagbohLKHaVpqHCjYGMLprtLl0fswvDQm6vOrfMCMczKAQ2yKRl7wy5ssQj5ExYFe iiVWum+9hVvTsheYOoQLoLDOjffUKPtRs9ottEeT7W6B6aZkqLgvgEPKEtHz33pDMuV7Vl8LPBy +Tl++w9ixP4DS+7Pgf4Fb+DnkSHy54Jb471i+LP/buYQCS6/WaR/a7xY9t+dSvlJiF7aMogsWs0 8UIS7KUOTGNac1pMUj1vjNMbbazqmx+yi/LUGMuF9FaUTo95pxr/ngMR7h6P2l/ECYWoqxx4HeO InOzcRHBGE3WSpGP+5Q2nedWWs2+J7hNaQZPDgPSwMPcmnofz6CIkOonLbAg1MQsqUU0flDVYER cZlwX7FIMeJFNWN5SbyAsdz3z7rtBBdO/0u7GHxvTyKWVZCd7cIsTgiCqQPdE2HwexPtMMRux89 /QTTBhM0/BB5vXgdwxJTfF8FahYkc03S08Ew3ICCKoXjMsVZ5xrN+JOdnkacZLCMcJ1ftqpBwLJ jnb4yRvayiA+5ErzzEwSDs+3zgAGe/AAWkB8Uz/hjvTELKCMVeT/4vwIBgJWUPQgTHdHgwF1lci +FJVQIkoPiUp9l17NDejpnFAFqgHqY7LXJ8VA0Pvpo1JYmdQdLWOQbTmsdU4uoCXKV299Nn9a6f GRikUNE+adMm9qA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm= /pinctrl-iproc-gpio.c index c9a3d3aa8c10..1d08b8d4cdd7 100644 --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c @@ -390,7 +390,7 @@ static int iproc_gpio_get_direction(struct gpio_chip *g= c, unsigned int gpio) return GPIO_LINE_DIRECTION_IN; } =20 -static void iproc_gpio_set(struct gpio_chip *gc, unsigned gpio, int val) +static int iproc_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) { struct iproc_gpio *chip =3D gpiochip_get_data(gc); unsigned long flags; @@ -400,6 +400,8 @@ static void iproc_gpio_set(struct gpio_chip *gc, unsign= ed gpio, int val) raw_spin_unlock_irqrestore(&chip->lock, flags); =20 dev_dbg(chip->dev, "gpio:%u set, value:%d\n", gpio, val); + + return 0; } =20 static int iproc_gpio_get(struct gpio_chip *gc, unsigned gpio) @@ -863,7 +865,7 @@ static int iproc_gpio_probe(struct platform_device *pde= v) gc->direction_input =3D iproc_gpio_direction_input; gc->direction_output =3D iproc_gpio_direction_output; gc->get_direction =3D iproc_gpio_get_direction; - gc->set =3D iproc_gpio_set; + gc->set_rv =3D iproc_gpio_set; gc->get =3D iproc_gpio_get; =20 chip->pinmux_is_supported =3D of_property_read_bool(dev->of_node, --=20 2.45.2 From nobody Mon Feb 9 09:10:58 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F45923C8AE for ; Fri, 25 Apr 2025 09:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745572127; cv=none; b=OFSNNPQnJh1hBNLlvbyXOuVGuoNIsHguGM04PjKFFTzGe4S4Ry2gzwVki3jNgJriU57JoMjCXIS9pe59JQEavxXZ82Q7ShBH43cCQa4Csrha2phKBOoNaCPVJhUcHwXJfVpNjyuD86fm+aHFnayCWhaKs/xGvug9m/tCPXXKsYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745572127; c=relaxed/simple; bh=pTrO24s8MBFrLrxR0rAOPN04paVQyMBRmX9Uiybwymg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fom7QFKvpvDhWz1RDRin2DRf43ctuLNs3wX4wSzXQ8HXT7udByLJNMVJM7EbPJ3zL4/jMVSqO7Am+Tp9GFOHyNmgbxQUJdELTUCPEtcdfrIKm4+VWux39JZG620u42BbvfKJx4hQT/DUTGwLMX8QtLpqELqiii4KfphfYVJtEyQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=dX7yLZpx; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="dX7yLZpx" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-39c1ef4ae3aso1283733f8f.1 for ; Fri, 25 Apr 2025 02:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745572123; x=1746176923; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dlGoB/HUZg4yDoY5L3zieLRRojeVT0zMfmIc8y47oNU=; b=dX7yLZpx/Ke+a1SCtrfOm/tvDE03LnSYSxKZG+qjihgkIVvBoDtzkwlYgsVDY5ysgv mqVrKoTJCGfXBCPUI/kewTHpXWgyFnWPxPWXiOL0SQuGeXufJiAMXEhmVzMwTJ5othoj YR7nd1LC8Cr97hSvLIfIy0JI6HZ4R4JBIa0/mxl8E0Uox/1a7vCvAVUQErSagrFxWbOG e+oNV5KbdCw7FkMLcptjWNjumWbTMLUYKnaqqQvi6ylbEtW/QhZMQxmnQTqGvPgJoHZI oZPjctg47ljpj6qkqlumHx52qcNstSy6L9SmU3HI756f/z62y+YTHjOqBNXACVUP4ZRM hIuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745572123; x=1746176923; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dlGoB/HUZg4yDoY5L3zieLRRojeVT0zMfmIc8y47oNU=; b=mc75FaTfhrlU2xMM9ucpFHIYaMOES70J3mSDVG9QYHjBfG/AQxYvZCv8XEo40YFD2h 366N0AvbjOtw6MSYn9sSE2EoHSj83CjlwW596QTXyk64dgklUlOejwe3VdnnemV1hmkY sUcxE9oWy/AMvbt8GIty7lSrd59g2EL5Q0C0DRtYa8q8+kFAHx7d67o0FaQOQ2tADEkq PdCY66nMeN5yXtkblDO6Xciqw5A3o8sv0nI1Yt3PMDi95hBR4n8P3OA38JHZCY3va/lh UVKwALwfooCt3ng4mr06a/NMtGN2/BQFkQ8JsmnWftl+7gS4OCM6HapHrDQiLPzzXBhO RR0Q== X-Forwarded-Encrypted: i=1; AJvYcCVWeZoEP67r3EHEfyOIJayAfZb2TlwKfOOjiePD91ItslTiGiYI88VsrNSv9EmvcAOJwTp0kRFuXLtvx3I=@vger.kernel.org X-Gm-Message-State: AOJu0YyCo8N/JhJ/FN2EUHfooAk78+1YmIugb9EBEVpWEtbyhz3hQHT+ FdN1oLCIdOWDnIBGooAFR5dRgz/cP6nivHVQIwJMCMR5e48SLdFxzOLfue8eU7VGXY0W2DjpGmP RzBU= X-Gm-Gg: ASbGncs6S6nSTvo36nsvOCfojniX4C0gOrTyGz/sCnboLlw+Nov5w07DJwvlUNEWD0l d8FaNXBNPD6QBnMqZiOLmVD8kr2pLLjlmjxJdbMjltMLK1NFx9XgNprSVLbD0Nmz0XbN+F1+iGA XtE8vvpKE5f6CSRAmhx7uTW+HomIR+unenPQSu9mh9pzKmGGEy9FU0hMVdqVjoeXWlqzJwU4ZSZ 73y+luU8v+f3ixJiTin72zQvvpxyRtbLm321v+kL8LwWKZxabqHSWiPBnt+GVPWrzVliMRFLT1S TooBpJWJSgDIFYHMk5kL1brPJi66KsbT5g== X-Google-Smtp-Source: AGHT+IG+vaC7MmgQ1lY8Xs/s97F/M6Om983foVEu9vVfhXq+DCq1sUbfXts/z/dMaAJgf6ogHaPHXQ== X-Received: by 2002:a05:6000:4285:b0:38d:e0a9:7e5e with SMTP id ffacd0b85a97d-3a06d641ee8mr5322988f8f.6.1745572122724; Fri, 25 Apr 2025 02:08:42 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e5c9cdsm1688909f8f.87.2025.04.25.02.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:08:40 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:08:31 +0200 Subject: [PATCH 3/3] pinctrl: bcm2835: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-3-6b8883d79b66@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-0-6b8883d79b66@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-bcm-v1-0-6b8883d79b66@linaro.org> To: Ray Jui , Scott Branden , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1810; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=aKxxveH0C+uR174fNORC/elug/yziUniASTqQNWz9nc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC1EPXzEnCILbRcigkhvMXKkn4wcX8TtqvQacB KB7TBd1QxiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtRDwAKCRARpy6gFHHX cmUiD/9yZv6dvT2Wc+LvJ58hLcbjZISnPBDhqi6UcP6kX2qjRFckiM8hGhHOQymPP4CMm0Io3FB 3vhD5qFTWMyUqVB20hNF8fzxFSAF7z1w2CZ78upNY4Ty8iYKY6iXlZkTb4/I2vkUQElKJc/FKuz ll539+UounWRewqOlHwUdLlhdIg/p3K6dVzXwe7zVGhLh4xnvbHm8w0mOjziSgYepKhgDfG2h/e kECtA453bSJM8Krn7c8+9i/W7S50XLMt+8Q/uK5eerfg2Ix595UQNVT8wwygug0q0ex9i2nJPxS kLljtjYkeCbEzhpHvXPszQKP8S3ACP7Upcx60XQ32TFPKnlOnt34eNH5XnLRbhgMA44mfrVToIF b4bfmC1mhk9vjJmDe95jXH94+nOr5C/u8C17k5eoxpGwd/dzJISDfRBBfNPJou45LONB2eNPoBw 07rSsnepk1PHd2FzBRPi2yebyN6YD7VmyRqSU6uDB/GyaCM+V/6Fdkj+6YzN5qezh314hAUT3Hg Ua7v8riePOMzxWiQIJGaMQmNjAC6gHILJn+73Fe4sEXX756CFMp9EyAIYp5KffDuBwm2uP9ktkg xTJ9J0vBSw5fxWyfFhVBhP2ijqhpM/l94+zEJuw11XNTxhheJTSyayQWYB0i8TW7Dd34VOtqoFE HAHE0Qmyq/keRLw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pi= nctrl-bcm2835.c index eaeec096bc9a..826827800474 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -356,11 +356,14 @@ static int bcm2835_gpio_get_direction(struct gpio_chi= p *chip, unsigned int offse return GPIO_LINE_DIRECTION_IN; } =20 -static void bcm2835_gpio_set(struct gpio_chip *chip, unsigned offset, int = value) +static int bcm2835_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct bcm2835_pinctrl *pc =3D gpiochip_get_data(chip); =20 bcm2835_gpio_set_bit(pc, value ? GPSET0 : GPCLR0, offset); + + return 0; } =20 static int bcm2835_gpio_direction_output(struct gpio_chip *chip, @@ -394,7 +397,7 @@ static const struct gpio_chip bcm2835_gpio_chip =3D { .direction_output =3D bcm2835_gpio_direction_output, .get_direction =3D bcm2835_gpio_get_direction, .get =3D bcm2835_gpio_get, - .set =3D bcm2835_gpio_set, + .set_rv =3D bcm2835_gpio_set, .set_config =3D gpiochip_generic_config, .base =3D -1, .ngpio =3D BCM2835_NUM_GPIOS, @@ -411,7 +414,7 @@ static const struct gpio_chip bcm2711_gpio_chip =3D { .direction_output =3D bcm2835_gpio_direction_output, .get_direction =3D bcm2835_gpio_get_direction, .get =3D bcm2835_gpio_get, - .set =3D bcm2835_gpio_set, + .set_rv =3D bcm2835_gpio_set, .set_config =3D gpiochip_generic_config, .base =3D -1, .ngpio =3D BCM2711_NUM_GPIOS, --=20 2.45.2