From nobody Mon Feb 9 23:00:56 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75E7223D28A; Thu, 24 Apr 2025 11:33:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745494401; cv=none; b=lje2tSgG/vZhLM0M5ApxK6miyPj+SgxrWYZNsTnEthNEuHtrd/FWb9QQiyZj5Bt0x4cuDXAhkrTMiIFTemgXTOuNX5jXPM6GwB+znFIkymbfLUVDHJ8aaYMHboGJkFVuVcYhC9jAxrdCgznosnBlIYqpHeTqOg+oFDH4xk5bdUI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745494401; c=relaxed/simple; bh=6ZBXP0GYyCkd0luXCqFg4jCrTNhXWBtGxaBl8USBHHo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h/niaHWMi1d+v6d6N+ykozwjKQOPC7E+XpQ5Pk/p0ky7qigpfTPrwz1+lKtR2tpd+yICX05rrQ0Ee3O/Ib1Kb6ZiZ7pqxvEPaquRcib+7EAGDVvvCiEf7il+iQiEjvhUVNBbdf3Elsp99gZHAuOVd9w4Rs/BvRQ76k+egmDRN3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Z17sv9HX; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Z17sv9HX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745494399; x=1777030399; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6ZBXP0GYyCkd0luXCqFg4jCrTNhXWBtGxaBl8USBHHo=; b=Z17sv9HXIXmyPv1X0vXcrMm4Wq//RoDysl0fqfN0xxnyGk3ltiTPxwd+ e4H7ptNQtACmhxXz5HmpyJWwTh/shJBvmjMZfhX5RTWAvyxhk/uC5zmAQ Ts6RAXJubV7fzbJqIlMY6okfopETGelAoqClN3j7EfgvWMC2l52ZBILt1 oEqxSJmHGY1UN0G2VelGg1zC8sor6HHRVc65df0/ECdTDeILk7SNUqyKj 7RrAwAaxQIwtPsCMqQFKweSiNOgiYIS0h3r28kR/a56bfvH3hlg6F87Ix fZdBsYun6bp4BWk3XmBD0hqjZm3UJSeMqKwJZnfUgIS7cyzkU+xyDDV9/ Q==; X-CSE-ConnectionGUID: ctmITn4ES6u6Hblx/3nbhw== X-CSE-MsgGUID: 6rVBPcIsTE2zaAToaNGSTw== X-IronPort-AV: E=McAfee;i="6700,10204,11412"; a="57771298" X-IronPort-AV: E=Sophos;i="6.15,235,1739865600"; d="scan'208";a="57771298" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2025 04:33:18 -0700 X-CSE-ConnectionGUID: a1RqEz27ROe7oEJXxiZmcw== X-CSE-MsgGUID: IZGgwQmyThWmxbHmUEl3cQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,235,1739865600"; d="scan'208";a="137389475" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by fmviesa005.fm.intel.com with ESMTP; 24 Apr 2025 04:33:09 -0700 Received: from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146]) by irvmail002.ir.intel.com (Postfix) with ESMTP id 8AB3D33EA5; Thu, 24 Apr 2025 12:33:06 +0100 (IST) From: Larysa Zaremba To: intel-wired-lan@lists.osuosl.org, Tony Nguyen Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Przemek Kitszel , Jiri Pirko , Tatyana Nikolova , Andrew Lunn , Alexander Lobakin , Michael Ellerman , Maciej Fijalkowski , Lee Trager , Madhavan Srinivasan , Larysa Zaremba , Sridhar Samudrala , Jacob Keller , Michal Swiatkowski , Mateusz Polchlopek , Ahmed Zaki , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Karlsson, Magnus" , Emil Tantilov , Madhu Chittim , Josh Hay , Milena Olech , pavan.kumar.linga@intel.com, "Singhai, Anjali" , Michal Kubiak Subject: [PATCH iwl-next v2 10/14] idpf: print a debug message and bail in case of non-event ctlq message Date: Thu, 24 Apr 2025 13:32:33 +0200 Message-ID: <20250424113241.10061-11-larysa.zaremba@intel.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250424113241.10061-1-larysa.zaremba@intel.com> References: <20250424113241.10061-1-larysa.zaremba@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Unlike previous internal idpf ctlq implementation, libie calls the default message handler for all received messages that do not have a matching xn transaction, not only for VIRTCHNL2_OP_EVENT. This leads to many error messages printing garbage, because the parsing expected a valid event message, but got e.g. a delayed response for a timed-out transaction. The information about timed-out transactions and otherwise unhandleable messages can still be valuable for developers, so print the information with dynamic debug and exit the function, so the following functions can parse valid events in peace. Reviewed-by: Michal Kubiak Signed-off-by: Larysa Zaremba --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/= ethernet/intel/idpf/idpf_virtchnl.c index 6bc7068b613a..231b51ee6de7 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -82,6 +82,13 @@ void idpf_recv_event_msg(struct libie_ctlq_ctx *ctx, u32 event; =20 adapter =3D container_of(ctx, struct idpf_adapter, ctlq_ctx); + if (ctlq_msg->chnl_opcode !=3D VIRTCHNL2_OP_EVENT) { + dev_dbg(&adapter->pdev->dev, + "Unhandled message with opcode %u from CP\n", + ctlq_msg->chnl_opcode); + goto free_rx_buf; + } + if (payload_size < sizeof(*v2e)) { dev_err_ratelimited(&adapter->pdev->dev, "Failed to receive valid payloa= d for event msg (op %d len %d)\n", ctlq_msg->chnl_opcode, --=20 2.47.0