From nobody Mon Feb 9 04:03:50 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B6DD84FAD for ; Thu, 24 Apr 2025 02:22:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745461334; cv=pass; b=aceAiHX+loOp4aF1DM60ngfs6aaoWw9V1wuMTn32FKrWwRqbiIVIe9v4fkddjkgOdNfYzVk752QUo5NF/hfXcLg/2H+9EpUjLlaZI1MUwOCRWhmFDsm+TcA+EgyEN4n38aa3hE//yq/3m2REuVmugWIPqfY5VG3pP6wK4YpOZNs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745461334; c=relaxed/simple; bh=NruXWNPuyGUPjhXkaPelHY7hF3ehpVSQIfAjRjmVlgE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PDphXxmjGLZILtVWItZt7ZDUbEI/jmYT/KS57OmsI9vr+2FFcGONRwKP7NL/sP+lPMA9LKs0oYUXq18QY1gL2LOTu+kFQKez8cGFwnn8uXDd5m46ofoJ2ReVPobDBfbZCWqo61GWR+rK3EXLlHKi9IP93wflJU0i5iMaSj44hJg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=Q9gXzDlZ; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="Q9gXzDlZ" ARC-Seal: i=1; a=rsa-sha256; t=1745461315; cv=none; d=zohomail.com; s=zohoarc; b=LOAGuQ3z24pLe/roGTdfJWBgqf42GXUqz7VsaThx3NwDRA9IxzjAgcVQhe5p3fFekXTeojlR3ukrYk0kjV+dOlV+DiS3kayWR8xFdH13U4oJCNwP/4BogZLu32oFIAGMV8n64QQO7zKQVjVwj5LnDBmVEH6KqtJAmfre0V9sO0E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745461315; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=g9IobpGuuvB/dgl6xQ8rhNJU5JH9HoZYQPiz/QDc+LA=; b=cdagPpIXGw5qVXOXDTAiCpbpDaYr0knSRqmO5yH4PGKq2Ac26gpImW5C7c2ybjIwIOyC8hwUo6yh8dANFOWTM7JThT438NMfyC1ES1bw6vwRnm31HrjxQB/QzJkyNKREb1badcmKMcPqSsYUY86V68o6hbg/mGq0MYN+UZu9LBU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1745461314; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=g9IobpGuuvB/dgl6xQ8rhNJU5JH9HoZYQPiz/QDc+LA=; b=Q9gXzDlZhwTttdwjnMzadNb0PTAgPn9IP7SM8Du/4ZXe89g7L9+bj3hQM6TBcLhr vAoYheYLIDptm/bZaLkzqC/i0WFz3XZZpEpwmx7qgqFW82RlDZhuXJUNRhbaDa62r2/ KNemk3nraNjAAOWkd0Xjc7PLlnHhu35HvZV1uh+A= Received: by mx.zohomail.com with SMTPS id 17454613129331021.9890690851771; Wed, 23 Apr 2025 19:21:52 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH 1/3] drm/panfrost: Add BO labelling to Panfrost Date: Thu, 24 Apr 2025 03:21:30 +0100 Message-ID: <20250424022138.709303-2-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250424022138.709303-1-adrian.larumbe@collabora.com> References: <20250424022138.709303-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Unlike in Panthor, from where this change is based on, there is no need to support tagging of BO's other than UM-exposed ones, so all strings can be freed with kfree(). This commit is done in preparation of a following one that will allow UM to set BO labels through a new ioctl(). Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_gem.c | 19 +++++++++++++++++++ drivers/gpu/drm/panfrost/panfrost_gem.h | 16 ++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.c b/drivers/gpu/drm/panf= rost/panfrost_gem.c index 963f04ba2de6..a7a29974d8b1 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem.c +++ b/drivers/gpu/drm/panfrost/panfrost_gem.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright 2019 Linaro, Ltd, Rob Herring */ =20 +#include #include #include #include @@ -35,6 +36,9 @@ static void panfrost_gem_free_object(struct drm_gem_objec= t *obj) */ WARN_ON_ONCE(!list_empty(&bo->mappings.list)); =20 + kfree(bo->label.str); + mutex_destroy(&bo->label.lock); + if (bo->sgts) { int i; int n_sgt =3D bo->base.base.size / SZ_2M; @@ -260,6 +264,7 @@ struct drm_gem_object *panfrost_gem_create_object(struc= t drm_device *dev, size_t mutex_init(&obj->mappings.lock); obj->base.base.funcs =3D &panfrost_gem_funcs; obj->base.map_wc =3D !pfdev->coherent; + mutex_init(&obj->label.lock); =20 return &obj->base.base; } @@ -302,3 +307,17 @@ panfrost_gem_prime_import_sg_table(struct drm_device *= dev, =20 return obj; } + +void +panfrost_gem_set_label(struct drm_gem_object *obj, const char *label) +{ + struct panfrost_gem_object *bo =3D to_panfrost_bo(obj); + const char *old_label; + + scoped_guard(mutex, &bo->label.lock) { + old_label =3D bo->label.str; + bo->label.str =3D label; + } + + kfree(old_label); +} diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.h b/drivers/gpu/drm/panf= rost/panfrost_gem.h index 7516b7ecf7fe..c0be2934f229 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem.h +++ b/drivers/gpu/drm/panfrost/panfrost_gem.h @@ -41,6 +41,20 @@ struct panfrost_gem_object { */ size_t heap_rss_size; =20 + /** + * @label: BO tagging fields. The label can be assigned within the + * driver itself or through a specific IOCTL. + */ + struct { + /** + * @label.str: Pointer to NULL-terminated string, + */ + const char *str; + + /** @lock.str: Protects access to the @label.str field. */ + struct mutex lock; + } label; + bool noexec :1; bool is_heap :1; }; @@ -89,4 +103,6 @@ void panfrost_gem_teardown_mappings_locked(struct panfro= st_gem_object *bo); int panfrost_gem_shrinker_init(struct drm_device *dev); void panfrost_gem_shrinker_cleanup(struct drm_device *dev); =20 +void panfrost_gem_set_label(struct drm_gem_object *obj, const char *label); + #endif /* __PANFROST_GEM_H__ */ --=20 2.48.1