From nobody Fri Dec 19 07:28:11 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 348C9214A8D; Thu, 24 Apr 2025 08:40:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745484041; cv=none; b=lUPdqv+YMNdfjdGmCC2IwmMr+ntTr5e+i8XRmQvLgAs3RIUy5hqJiTb00gdIKY3Nn5u8Kti3MB6vzHOxa7Jt/gLEhtXHGLPZQvR8yq2WgocHNlDFOrOgh6J68KfYu8FoQyp7nrDcOkcKVM9KTByVSeKgyhjeqTQNwgdZ+wP36pg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745484041; c=relaxed/simple; bh=ugQ0tZbuUVl+tPGqAtdti5tfLPe5fA3E0Vgs3DqrikU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A09LlAC6m7WYVtAuTaqDZkICd5Oakpo3C4I660f00wGkOHnuxx6wLDXkBlhZP9PxNxy+gfK31/gg3CaeOQEAJBKF09A/yoaxpOPpEiHCjTDmeixtdsGOcC8LdK4BYI6bz4Ti2lfce+3kCI9swiahBpDlsNPEQJaTQ0WqXYiorOs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=fZYjIxnS; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="fZYjIxnS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1745484037; bh=ugQ0tZbuUVl+tPGqAtdti5tfLPe5fA3E0Vgs3DqrikU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fZYjIxnS47q+VH6NYF04apROnIEhJhkS9k0VgkbabkklKQ4ufvlZ45j1AEZf+gnlt NYnN3Nhli3jPUuo50W41Nb+drlKFFC4phPEGvcmfDCwgq0k88a0Rt0V7OQaR90ENP4 HjsRJAPOuy1cgmFjd9qkZ26UieC8Q0y+O7E8N1dwx5NOPwEjQkkC4TfoKy3sWwTCLq Ny17PXQT7Pd9tnuZnpe0os+RTiDi0IOlDFYWuuriPV1zIJD2hIr17eutNPy3f1JD1q SoPAWY+j/Uh912f2twKS79PcW2vDA3ivUEFxnOVpzMiNrOWdiHdgkX6L2KxvAQ3suK PH6Thld8ONPlg== Received: from yukiji.home (amontpellier-657-1-116-247.w83-113.abo.wanadoo.fr [83.113.51.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laeyraud) by bali.collaboradmins.com (Postfix) with ESMTPSA id 1BE3317E3610; Thu, 24 Apr 2025 10:40:36 +0200 (CEST) From: Louis-Alexis Eyraud Date: Thu, 24 Apr 2025 10:38:49 +0200 Subject: [PATCH net v2 2/2] net: ethernet: mtk-star-emac: rearm interrupts in rx_poll only when advised Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-mtk_star_emac-fix-spinlock-recursion-issue-v2-2-f3fde2e529d8@collabora.com> References: <20250424-mtk_star_emac-fix-spinlock-recursion-issue-v2-0-f3fde2e529d8@collabora.com> In-Reply-To: <20250424-mtk_star_emac-fix-spinlock-recursion-issue-v2-0-f3fde2e529d8@collabora.com> To: Felix Fietkau , Sean Wang , Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Biao Huang , Yinghua Pan , Bartosz Golaszewski Cc: kernel@collabora.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Louis-Alexis Eyraud X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745484033; l=1378; i=louisalexis.eyraud@collabora.com; s=20250113; h=from:subject:message-id; bh=ugQ0tZbuUVl+tPGqAtdti5tfLPe5fA3E0Vgs3DqrikU=; b=2+hlGTGLX4IvBZ7LMo2FNCbo3oFL2H2kxu7qLhPFrDccvEuTJxAjMod/qdQ3c3A5HlMBD2F4u GHsPaXAAj0vCNg+4VSDcGo0Mk6xifVU44tFqSzxp3vXitubG5ipHv6p X-Developer-Key: i=louisalexis.eyraud@collabora.com; a=ed25519; pk=CHFBDB2Kqh4EHc6JIqFn69GhxJJAzc0Zr4e8QxtumuM= In mtk_star_rx_poll function, on event processing completion, the mtk_star_emac driver calls napi_complete_done but ignores its return code and enable RX DMA interrupts inconditionally. This return code gives the info if a device should avoid rearming its interrupts or not, so fix this behaviour by taking it into account. Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver") Signed-off-by: Louis-Alexis Eyraud Acked-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/mtk_star_emac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/et= hernet/mediatek/mtk_star_emac.c index 23115881d8e892a622b34b593cf38e2c8bed4082..b175119a6a7da517f20267fde7b= 2005d6c0bbadd 100644 --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c @@ -1348,8 +1348,7 @@ static int mtk_star_rx_poll(struct napi_struct *napi,= int budget) priv =3D container_of(napi, struct mtk_star_priv, rx_napi); =20 work_done =3D mtk_star_rx(priv, budget); - if (work_done < budget) { - napi_complete_done(napi, work_done); + if (work_done < budget && napi_complete_done(napi, work_done)) { spin_lock_irqsave(&priv->lock, flags); mtk_star_enable_dma_irq(priv, true, false); spin_unlock_irqrestore(&priv->lock, flags); --=20 2.49.0