From nobody Fri Dec 19 06:31:29 2025 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA17214A76 for ; Thu, 24 Apr 2025 08:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483752; cv=none; b=YFk+KfKRK9JX5eeJbnSBtJe7/gl5ZhShefaJ6FTSO1c7J1nud3Uz+pWUIUvvV0m/M34EtZWu4YmMwAo38880nIxLVnP39W6T6FICXqUcHRwEtV2JJR3cOMM9VAQnO3RWOC3mY3LJeuLox1whZ63LEE+CANpDYZVQgQATBTTkdss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483752; c=relaxed/simple; bh=XHXxaJjw+L2SDuyGGQioHVSFb0imiEXoavVU0ev3U3o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uJd41/TzF0SfG6HzDVZPmxlmWMUA0Ft8djEkV2bgGR2DhKKEY2N4o7uCbiyOXRO1eqMd4eCPpf5fx3S2niXtcI6oA55UbwRwIbR4yyMzE/Nyn76Xqv4GRmXu/1p1aaUPc6jgKLOTiE9C7nqC9L03Q1Nq8bDzLnocdXC97JcEVT0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=USNKkTdd; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="USNKkTdd" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-39ee57c0b8cso695390f8f.0 for ; Thu, 24 Apr 2025 01:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483749; x=1746088549; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e1nhd4aLppAWi4+bVzlCUpCnUz+WYC5fdznaksvHJEk=; b=USNKkTddu2E5yQZkja4nzsO/GHs1Ae9FBAS1QddzHG1W1XXbSTyAfeg9nGToFQ5uzm elqnGOueYQxEfJQ+Ml86CGK/BJsOwsunT7CVL0aCpKiNhjk93oDqC2A4kPM2JI8WH9/x f7EVYA328Lhl9FSMJM6RIj9AeYNWEnQMkWSBSapztFcgWnggCJ9Pf9eUwJYEVlHGL5HW KkchQULv/f1TG7XG+ZDkCZanTvDNWuF4AoUvoTjKjIgr2A1j/EkO/aJm2BA9n213+/gU YeEfvHv+tla1QkCbQpLXfZRkiL8J6g4hjyK/lTR2SslM0+8SSTTw+jo2oOauPtTZhddJ cJ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483749; x=1746088549; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e1nhd4aLppAWi4+bVzlCUpCnUz+WYC5fdznaksvHJEk=; b=d0ErmkzbkDNjlNZdgmtvytnE3qTShM2f3YwkoVFxUU4A1W7Tk9vnpJ2fIrFUqC8y// HrYt0HYXuV/HAANvf0HUcYcARtdKLHK1k+bAqrhZFxtxLfk5cWYVSdYfrNsWTenJT3yk Hp6FZjMF9t2llTBTPKlXrx0CYEOQkPxie0NbxnXTudoJQD65TAwfdid6TKbJ+3SIm3Zm rFLoxI19824YN4Zz0Wiro+MEEGa3aFcEuObkQ4MjpETTblkhthXS0iTIhiwjAmHFBGei Njtbh4DUeOc0DK9SYRi//22DnaD86kEKIS6vPY/9OR8ViidHFtQdT7/j9wzZ2W6+xAkx t3Tw== X-Forwarded-Encrypted: i=1; AJvYcCWyTvxgpCusq3Ay2EZCjUOJ3OKa6ZaPBzNlAgxmk6ZZf914Yz4OaDb6bz1WdIj/4g/A7upgduvmHshG2NI=@vger.kernel.org X-Gm-Message-State: AOJu0YwuqxXP2G4dcuHdqQvu0CfmSNhiBqpmAT/V3yNOXCSQy61KnSvG VJGSiPcUc5XCqlO8obTerJ67ejinGqIXj6PSn9TQpO2Qh4z7oYpuJE78N1PRHoc= X-Gm-Gg: ASbGncvwWx0kv93a0WqP5VDG0EnzXdTcd7jR+c8hsFfP/7jl+Btx7EDIFpygWk8dBn/ kDnHlhpJJUMrFEJEmUnFqgtPLST/FGIhUWg7gwogBoyq2uYj1c+oT5gW0WWsAbvnzxA4VJxatJH IPjQGHYV3cVn96mT1Dp6Ggrdv6rl6yHkqI0NqkSdqw0Dj9tBYrKht6CX/flK5RDJnROE10DhQg+ fnOtZWj5L23imdZKJHl+jgrV1L7vEzFo/v4Vk9hAqLfMoz/0+fNoUYo8Ew1tffhkQT6h10OvHqx dV79JVdI/THUPWOB2AI2vs1kHJzH7k2GJQ== X-Google-Smtp-Source: AGHT+IFrT2ryKEI3Ak4fYWyfabnfpp9zOPWj4dcFDB84T+QE4vp8znh03ePvPXvInmYkhFQ+6kA3Rg== X-Received: by 2002:a5d:64a4:0:b0:39c:12f2:2f86 with SMTP id ffacd0b85a97d-3a06cf4ebe9mr1139766f8f.8.1745483748680; Thu, 24 Apr 2025 01:35:48 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:48 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:27 +0200 Subject: [PATCH 04/12] pinctrl: owl: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-4-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1877; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ksmfNK84GDabb7cwbZBiry3j0gjxGVa4nXCuGXvLQ78=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffbDmQjLh72fMV3yjWxABGClwjTKpZiO6lYE y+xV5eR9zyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn32wAKCRARpy6gFHHX ck42D/9i5222ivEDPuYJfJramTA21Dz/Si68PgQJKw8MP+/dYK04nS1HRUrhy2s/f5d8l3IQEyk SUw/nOJGPKcElQSgK5wfrcMdUf7QTLJdRhNCw8QSOsu8zgxG8mnO+kDL73zSCj6UrZYmSzbhsQr pLOonJY5NYn594guZmHYpKLwBRDzKanJB7jvdjlw0gfszSTVxk/hzhG8hUUCM/bfQZHPvJyefFV FQWRoGvs+4NzTr9vn6xCSUlbAFUGj2Hw/cBz3FfnpjjVnJobvJq6q524MdE7u0OO8X036gIDGan xzcN7fRgoRrCbXwXa+LdihYAqRJf6pbYHO06I8Vwr5qdHcoqzVxfF9LmTzJNsfRDxxLrCM6cT1b FntYtKNgMc1nEQbTRPPydtniG4qQtDZFcqj4J987kdEUq13zTzmnlHQwWOdxPYYR9VZ2THuI9Ko MI8jq3GiGSDkzR4kaJE3UKV+F5xJUGt3WHBDLWuJdOXqyQhfPQCIia6p964VATg0i0vjN5SlAY0 Qc9XtlyHZLnVy4JPaB5SFmuulMcufAUongkqc0xwxfysH14nptwQOJE3fGE8gSpOgw/sMxJA59O 47YrddaVzPY6+L7+huekZiruLx/0uoSG7JOMh5rxj8TEAQoIYDan1o14/46KQbYbsl45o04l1dT liTVfyVG+QGKJ9w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Acked-by: Manivannan Sadhasivam --- drivers/pinctrl/actions/pinctrl-owl.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/action= s/pinctrl-owl.c index d49b77dcfcff..86f3d5c69e36 100644 --- a/drivers/pinctrl/actions/pinctrl-owl.c +++ b/drivers/pinctrl/actions/pinctrl-owl.c @@ -598,7 +598,7 @@ static int owl_gpio_get(struct gpio_chip *chip, unsigne= d int offset) return !!(val & BIT(offset)); } =20 -static void owl_gpio_set(struct gpio_chip *chip, unsigned int offset, int = value) +static int owl_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { struct owl_pinctrl *pctrl =3D gpiochip_get_data(chip); const struct owl_gpio_port *port; @@ -607,13 +607,15 @@ static void owl_gpio_set(struct gpio_chip *chip, unsi= gned int offset, int value) =20 port =3D owl_gpio_get_port(pctrl, &offset); if (WARN_ON(port =3D=3D NULL)) - return; + return -ENODEV; =20 gpio_base =3D pctrl->base + port->offset; =20 raw_spin_lock_irqsave(&pctrl->lock, flags); owl_gpio_update_reg(gpio_base + port->dat, offset, value); raw_spin_unlock_irqrestore(&pctrl->lock, flags); + + return 0; } =20 static int owl_gpio_direction_input(struct gpio_chip *chip, unsigned int o= ffset) @@ -960,7 +962,7 @@ int owl_pinctrl_probe(struct platform_device *pdev, pctrl->chip.direction_input =3D owl_gpio_direction_input; pctrl->chip.direction_output =3D owl_gpio_direction_output; pctrl->chip.get =3D owl_gpio_get; - pctrl->chip.set =3D owl_gpio_set; + pctrl->chip.set_rv =3D owl_gpio_set; pctrl->chip.request =3D owl_gpio_request; pctrl->chip.free =3D owl_gpio_free; =20 --=20 2.45.2