From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0CC420E70F for ; Thu, 24 Apr 2025 08:35:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483749; cv=none; b=HRNIPauotmptMtEnBuE076W9rdSF5wXYIg4CAwlGHR1lEaHgjo6DnTH32EWNZfRHnrKfp7pGIwne3gjMMHhXT6w0dy7ckSIIBjhh8XvUBEVa40vPshdXtzeFVs3mZWWVinj2WJlqGp8HEdckG8AUP7qHod8BKl1jIk0c36JLjpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483749; c=relaxed/simple; bh=x2MqwhQHM5FA2wESk7cvU4VBhmYapBXwzXcbGWaXamw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cyFja7YWoRX4xqMlnBsCse2D7wXAxK+x0h3eMpIOh3LQ4qNJ0pVzoRX2ucsS/47KJ1Vhsru8D1mAkhl9OtZ26hs/4IzB4g/OagQi/9+59S9tXlF09IggIEg+LJ9+2xahrkJjp9a+C/whu6B9o+Nc6PSqAP8QuhRrZgS2qComC8o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Jm55AMoc; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Jm55AMoc" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43cfe574976so4568645e9.1 for ; Thu, 24 Apr 2025 01:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483745; x=1746088545; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Y/KXYtsmkb+G7CfllxPwkWPMcOpxgtUmoLcYzM1m4O0=; b=Jm55AMocmFAhDiZHL/ihnsWvhlodvQvh6SMchSHXaB5YJEBU/xwFTCcDfw9bFyWt6Z fBdmE19tRSGH0v3pqpcL9nKWKf3lOn+g/37nQWg4/c4+mogoVn9Td+qc/zmybDfzVU1H 1O98x9YwcxeC3DI/lGb5GbaLOdRp4P7X/Oo+3SE63m5E7O+s7xZ0LXS18s0rZb0aYTWG n2BDyR4hURQFsZ+I8w8wjuwtpRUCwpo4jPLxQrBWsI/7uli7xWEhc/tD2oM2JhSIca5M YuqBpfCALWTP1wmHVU57g7JxMhORs0QU8BoYffJ4sL/lCWcDjnJ//yL8ggzV/F4srSDN lRcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483745; x=1746088545; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y/KXYtsmkb+G7CfllxPwkWPMcOpxgtUmoLcYzM1m4O0=; b=Zsbgxr1kKyNGK9i2kszrA91OJzu29Py3gzxMWFI7SOGhA5QEPCNytWq3Hf/si6RXVn 6USaw9kEPeFqHiZsehNSuEVs3EcfXlslil7S7xj6+Gge4JFzZnx/kN3Ksi6I45r8LvYB 14XgaTRsMPu9KGbBLeHNFrTj2M57xsQ5ZB8lKxw0rcopoKMoSId3cyLB4knW30/wZHCN 20dUCytScpvLblrsLmR+rYD/N4AnJ0nW0ua4pMWUgL7GFH5SczaLRHM90fIND8vGsSw9 FUV+c1f7gthRBC8YwTpfBJLSlVWhyytL/Xx9xlRH+/7kkSwo6ufMq+rDzzhvpNxYAHA1 1QxQ== X-Forwarded-Encrypted: i=1; AJvYcCV2nPODq9oOVRF+9K6H9yuVn1mrippT2cgEhEZrF/QbwskhTXnXqyjPpDpfoqTcGA52Q4MIQCQessuyi/E=@vger.kernel.org X-Gm-Message-State: AOJu0Yxq5Qtoir33w58lqm+CBuO9M/FjR++Gz2Fls18mCswSQvUEJGwG 4zMUiNmIEvXIPlv6lqNNIRhAsHS32nH+QYjou0v+FoYmB67f2/fgajfIbTwKuoQ= X-Gm-Gg: ASbGnctUx8TGuD2TcPpysfAiAVQ9X6ZjyQUv4h8cZtaJT18V2V+T+vJOvx89zxp7ipz rh+as0qsj6Sco1jwAFgTHhqHljKb6TlIjzqCC5R782sqd/efKHseAvBVncVj4ATtQAXTHUi7Asv NiI9H8+cIJYyBi7aAqmAnaBflFh3seGSMRaLwCmxWy5/sWOg7qC3/7iCjzqM2zck5fGKcLwW8z6 USkXlS60vDcaUQrFeLJYfZBtAa8Nu6wOQt68wzFxBui+403P3cfwVZE1F6qFJEyFT+wZv/16872 V5GUyBPjljOAvV2xGPZRzSRS6aYEKt+G1A== X-Google-Smtp-Source: AGHT+IFDVvKbqbQCc57anrhr3bH0NS/6VL2EdsqMYXAYy4mnb5bctdCFuHC/meZO5Slm/+f4y8xO+Q== X-Received: by 2002:a5d:6dac:0:b0:394:d0c3:da5e with SMTP id ffacd0b85a97d-3a06cfa827cmr1289003f8f.47.1745483744837; Thu, 24 Apr 2025 01:35:44 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:44 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:24 +0200 Subject: [PATCH 01/12] pinctrl: amd: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-1-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1680; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=NXF8n4jsfSDUE1BwCGs8Wk+0RRESis4p2gxPAXy7zJ8=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffaXhDusyvG2co2zg72Y3EMPUiJTRQhwls9L A4IcRn6OQuJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn32gAKCRARpy6gFHHX cuVND/9nSgA0+zQ9BeJQXZoMGuPOSsTcd5ft47Rz+PFTWcCHc4gR74Yyz1JYlyFirhQukhrZAI9 ayiFXnxz+DRmalcR1GNyRp4UmxjfYI1wfEW3L8y5MnQcO1xGJbk18AH+8RIGEJK5bRuv4fHUVrQ hV5ZOjao4hJlEt7td9YYxtgh4dx3OQtkph4SzY4kYggtKJNyiEdBhUt3yKo5X4vJsScfQFScAeZ 9tBfdkSdQ7PY44zhvoxhHgelLEHGgOf7F4cXgDFND3fCFTV0jF9HvcFlkuW61NnQMA4hhPQSpes MUwQAS6ZnOwGhcqGhL/dWY0wHaDY/ywabZ2WxmMvLXd0rkXASERgtzoNx1/nzEm4XUa281iA9i+ NeYK2GMkjsvHx5mn3iDvcOm56nmHsYYA+B3+lORaYVlfkBGZi7KWn9k6AMFlrRiGjlDI/DsTXMk L7kUkgUM2YFu/OzEVuRGfn6PsJaNRMPRd3j2oXyPU2Cy9/FdtR9PYoDUPawCqcNCW3PMrdBK3az aDqqARtQvzIv83kZ+SO2+LaxV71ruxStTfiG0t21+jh44hTZ8WLJ6Ouy7Nl0j2EGifuRrliEQRT YuPhpehkhllAQkPp0iKlVgp1BZIXa6TuItEJTbieLsPUNSHwLC6xaIXRprIiBc8Zg1V6/wlbzte W6EmpFQxkbAr0NA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-amd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index 1d7fdcdec4c8..9ab3a7fc3bdd 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -101,7 +101,8 @@ static int amd_gpio_get_value(struct gpio_chip *gc, uns= igned offset) return !!(pin_reg & BIT(PIN_STS_OFF)); } =20 -static void amd_gpio_set_value(struct gpio_chip *gc, unsigned offset, int = value) +static int amd_gpio_set_value(struct gpio_chip *gc, unsigned int offset, + int value) { u32 pin_reg; unsigned long flags; @@ -115,6 +116,8 @@ static void amd_gpio_set_value(struct gpio_chip *gc, un= signed offset, int value) pin_reg &=3D ~BIT(OUTPUT_VALUE_OFF); writel(pin_reg, gpio_dev->base + offset * 4); raw_spin_unlock_irqrestore(&gpio_dev->lock, flags); + + return 0; } =20 static int amd_gpio_set_debounce(struct amd_gpio *gpio_dev, unsigned int o= ffset, @@ -1128,7 +1131,7 @@ static int amd_gpio_probe(struct platform_device *pde= v) gpio_dev->gc.direction_input =3D amd_gpio_direction_input; gpio_dev->gc.direction_output =3D amd_gpio_direction_output; gpio_dev->gc.get =3D amd_gpio_get_value; - gpio_dev->gc.set =3D amd_gpio_set_value; + gpio_dev->gc.set_rv =3D amd_gpio_set_value; gpio_dev->gc.set_config =3D amd_gpio_set_config; gpio_dev->gc.dbg_show =3D amd_gpio_dbg_show; =20 --=20 2.45.2 From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F391E211472 for ; Thu, 24 Apr 2025 08:35:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483750; cv=none; b=koHvwwfxO574WQEro08XlVKt3t8ol3VK1n0gJnVEWO8ZY9gH6efCV9muAOluXdrLfoAaarrJZfyLzf2BFSidcb+F5i2HdmhuPXG0Nqdv9EsNwVMJLUKA4mv9iG1qUNV/IbRyMDKu/EBKZsHRdJ1Ti4zYUg/aNdtNfWJc4IUeanc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483750; c=relaxed/simple; bh=ovjQNuF7R1QswkZHk1xWWMofsRGkvHDmqTWp1n+FvO8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Jbmz+3trwrOo1UkevfaWm95EsCab+MnbTxD6SHoz3RFgliCsNMcHpdRpG9EIAyDkmFPd46wJXa5ojr59Wa2/hIu2B+gYXQ3eYcurFRRtsGHqQz/6dxGDPKimf0rErotnEzu6pHAjrNF0IhIssQ77+DG/65zJG7vaCfVEfJJ37g8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=v9mj6HaX; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="v9mj6HaX" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-39129fc51f8so557327f8f.0 for ; Thu, 24 Apr 2025 01:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483746; x=1746088546; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=n7xB0NSx1H7vCCe+l6ESBPVP9pl7qaey136eLZ31dwo=; b=v9mj6HaX1XqjG3QpNjwVMjQ5Bwln8IoQEz71KdhSysh0OeFDXmWpTXrOhmVBH1L/ag I3ksDwHu7WmPuzzmN7xJLMKeFgIShKzyzlJo921MVt4H3hcH7R5R0F2OKXbLOUsqIuhP jDzvbKvSqKKetglBD9/5VuHEJ70e0g1Hwka68Ej3FhvYsN6rB+0wQXKb9NbVonKyvj2R 8q//+pxSII3cKA9GOWub4lDfIsUKf2Cr9zRHMt8DlyG3DMSdYvozLHl6lIkPkbO8YOUV iguU1CzMYvHr0fV+tKa/5uCG7fSB9wL/8yaMGxnRpJ2KcFkweS8kzYk7zSsMLjVMoLPd cz2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483746; x=1746088546; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n7xB0NSx1H7vCCe+l6ESBPVP9pl7qaey136eLZ31dwo=; b=WpVOoT92OADrn2VU8U2kIeuHB6deRMZSYz34LDywNxPoDvP62DtmKTZeB0wBq0u4QC HXwr02EAhOHQCdFjG4AlLWL4sw6Cwi29Sy3X+Tgy+wV4ZRv6rqxaWTALkh/89tw0M8YZ dgIFrtdXXJUT2B2uHMxgZBbuRO8uu8yKmaZLUVKZSrNsA/EzHgm22NT1Z8Vso726qfv/ pUZXxExYed/Oo/8eCQxOJedaZREKjG9TPbCjPWS8jPkhQvRgDEbwXHAb3XK1nz1O6uwR xU1s3EDRcJvze6EQOvkhhLS3RgU8Znzw0OTvZ9L6yfUutqVoFTAkKOO0JwUFfIhQ2Dut VrpA== X-Forwarded-Encrypted: i=1; AJvYcCXpWVFcFCNmL5My8IZMkFIuSE62y1252m1M+KvBY3TRSpVA6hAWx7cdeRXSUtyVIs7oTHLjAdXl0f8Scd0=@vger.kernel.org X-Gm-Message-State: AOJu0YwfoGqkjrEyLSeyUufdnjgMU7yh0kSyK4wA8VWsiVK4xXRa/gY8 gWbFf+UoNfdKx4nLuocJwR52jq34q6D38TCybS5WXsaUt2RSbYa66gbSt7e1FEA= X-Gm-Gg: ASbGncugXb0q0DbymljjitqbFOLMuuj1FkQ42BAs5f1SGa4jI6lWqk6qVsb/fFIBD0a k00fURGc/MZuIn2x9ezHeIaQNrKJmnfqzycSFbPrLo4KQMbt2Oh2xwlMBBG618ek7Z76jOjydl3 aiUkF4/3JucrBuHDanwA21ait+8d5MfFeh1aAafEcazG1kwhC/cvdkiZnIGV3W6I83hBIihzkwV jHc3yuQ7A172+aMo7iPn8FvmLEubNLRYrZXurU26NsiSdZ7+gl9MGsKws7ayDMFkkoCPkga2KpC tdmZQBEF6d+K0xUM6g9gODuD8IBKVeTBzKE+tfKOeKE1 X-Google-Smtp-Source: AGHT+IFSD6M5XIauG5i+d/G86hFhT7OFRGq6PzYxSsoMAu4S54uAZ/T5Wwmoogoet09ubvq4IMvYRA== X-Received: by 2002:a05:6000:40d9:b0:39c:1257:ccb0 with SMTP id ffacd0b85a97d-3a06cfc5660mr1453719f8f.59.1745483746115; Thu, 24 Apr 2025 01:35:46 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:45 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:25 +0200 Subject: [PATCH 02/12] pinctrl: axp209: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-2-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2498; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=MgZVjd8Gr19iJhQk6NvM15O47jgqGqaBw/RcQkb1G5I=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffbYYgK3T3LpUSxYaTlg1RQUUtOaeq8+GZ/u B4TY1aYiK6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn32wAKCRARpy6gFHHX cvwwD/40PM8MvPIIjKYdoBuWnigqXm5J9mOEAwo0IpSBLk+1NrZtxCDfCUtfG8qnkKxEdr1VqG4 6mrNRSEHCZifkUpZsd9j1/qqvkSUckanWm+w39DVs4zsSka65n9Bs7dnA1+SGrLrp+/n9+P9MtA lM34+iNO1T+9KusL6PqVvKAu6DGfaqw0bjecp2sfpta2zPtHwxq5lXFxGkHaVkPW3j242bQVJMo OxU8NDepqb+WL0fZbMQ5rqRKhws/pmHzh0pc5fdiELlPOWlqNBOETuyxmgi82zYE16/chG6xgPg 216JJsncREoy4zCWFVBbrBbv9L02v3bDLnPh1zhIKESQaoINtG8bkwtev6qRPVd+uStU/2JCH1h f/3D4RxLWdmhByFfRbHoUjmxn3VBuJUSKbeUzyaGHvZVssXog9TpvfZNQRiD8Nkuywe92KjurAL x4uNTJbbQg2fqiGNI/E4uyxLmL6I36TMhM4sdLblDwJOg+3+tre10Bw+4Q4tLTdpFA8bKBEGGIy Dt7XbALdrhuOWIk+0uCG26vCYBKMQ1+0mx1U0lFdEYq41NBloLCpS8vfdFqZJHUAvS1fmmQxdhM YEp5REgnyY8mU7MnN+hxKUIp8gS/se+notLxKNO4OGMY/MQYx0CS6yrgP/3P85WACR2SXZyoMLs 4yNJiAOsNG12c6A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Chen-Yu Tsai --- drivers/pinctrl/pinctrl-axp209.c | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/pinctrl/pinctrl-axp209.c b/drivers/pinctrl/pinctrl-axp= 209.c index 2b4805e74eed..28ff846d263a 100644 --- a/drivers/pinctrl/pinctrl-axp209.c +++ b/drivers/pinctrl/pinctrl-axp209.c @@ -192,34 +192,31 @@ static int axp20x_gpio_get_direction(struct gpio_chip= *chip, static int axp20x_gpio_output(struct gpio_chip *chip, unsigned int offset, int value) { - chip->set(chip, offset, value); - - return 0; + return chip->set_rv(chip, offset, value); } =20 -static void axp20x_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int axp20x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct axp20x_pctl *pctl =3D gpiochip_get_data(chip); int reg; =20 /* AXP209 has GPIO3 status sharing the settings register */ if (offset =3D=3D 3) { - regmap_update_bits(pctl->regmap, AXP20X_GPIO3_CTRL, - AXP20X_GPIO3_FUNCTIONS, - value ? AXP20X_GPIO3_FUNCTION_OUT_HIGH : - AXP20X_GPIO3_FUNCTION_OUT_LOW); - return; + return regmap_update_bits(pctl->regmap, AXP20X_GPIO3_CTRL, + AXP20X_GPIO3_FUNCTIONS, + value ? + AXP20X_GPIO3_FUNCTION_OUT_HIGH : + AXP20X_GPIO3_FUNCTION_OUT_LOW); } =20 reg =3D axp20x_gpio_get_reg(offset); if (reg < 0) - return; + return reg; =20 - regmap_update_bits(pctl->regmap, reg, - AXP20X_GPIO_FUNCTIONS, - value ? AXP20X_GPIO_FUNCTION_OUT_HIGH : - AXP20X_GPIO_FUNCTION_OUT_LOW); + return regmap_update_bits(pctl->regmap, reg, AXP20X_GPIO_FUNCTIONS, + value ? AXP20X_GPIO_FUNCTION_OUT_HIGH : + AXP20X_GPIO_FUNCTION_OUT_LOW); } =20 static int axp20x_pmx_set(struct pinctrl_dev *pctldev, unsigned int offset, @@ -468,7 +465,7 @@ static int axp20x_pctl_probe(struct platform_device *pd= ev) pctl->chip.owner =3D THIS_MODULE; pctl->chip.get =3D axp20x_gpio_get; pctl->chip.get_direction =3D axp20x_gpio_get_direction; - pctl->chip.set =3D axp20x_gpio_set; + pctl->chip.set_rv =3D axp20x_gpio_set; pctl->chip.direction_input =3D pinctrl_gpio_direction_input; pctl->chip.direction_output =3D axp20x_gpio_output; =20 --=20 2.45.2 From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB8832144B6 for ; Thu, 24 Apr 2025 08:35:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483751; cv=none; b=NoskE0U6Lg/LcI2zVH8Jn7/h+1d2lszc3N/sxLGTwxNXmtcgUUkbB7SmSOq8bXTc2V9uBAZmEL9jutzDO4pN/PyrHzZdpmXa9n2K4Q8/ouutOM0j31pcX0KW3/QfkH6E+xO7SuV5ja8odN600PBA0RULfP8Ml9+ThhdxVCFlH2E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483751; c=relaxed/simple; bh=tO3WEMa9YHzhEuRk8ZszwXNZM7RYI+ALMf6JfpftQRc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WHOfp3bDJfUadMYrF8s2StPjlHcdgPwA/JgSN85fftRTB3zQfDKJDAxllAjwK1Q82OtQc9MK3xyQ1rcZ/Rj5QHk6ATD6urwBQs55DPA3HDcdbEBW95IaJAhhzeezmGjuVcyriNhDYOGlpMc9d6Gs9BgLxClJZj7/Dt0nFnLtR34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=kKaznmsO; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="kKaznmsO" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-39c1efc457bso475310f8f.2 for ; Thu, 24 Apr 2025 01:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483747; x=1746088547; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5mBwNaS+N09jQ7vb9rTgiq0CfSJO3DJXgU4YGfNreNo=; b=kKaznmsOjj5NNNn6qXsmhmwKCsoCKpKnAMmwPixSQgPiNJwKQlr0/lQOogsw2Y1p1r mWZaRljtjjskj7NZBz3XYwRXN/fuqyo5qvrBRrQUueJNxmbUJ7D0Vqz2Cyarb5eG2L55 0Yn8D6aNb4vVUGbrFrFYMLMtlEYLt64EZu87G1ugdhxccxDJR/vvc6s3LceUEvD3+pjG U2/0lT2VfWY1ZezTZcETf7HMr9tJU0pkD0FLmW7W/IBYHr6nT63CHZVTrphiA28TaBbg YzBQR9wSe9rfwlDPwvMVYSDvhYX8vOBbk/eSpZPeJZrFnsrTrsJXRqqi6jmWbXZEVPX4 wOfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483747; x=1746088547; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5mBwNaS+N09jQ7vb9rTgiq0CfSJO3DJXgU4YGfNreNo=; b=NP0Skd8Ogsdibv+lonJbDEuOyPxINcABQ5Zn60rhjRQ9FnflmFr/hjAxyoeFwCJaoX s3HI5X4NxFbjSfotUc7fzgGkCXxQUIbfGv7w+5QGQC73ABB4kQ1WHtp9DlxZzcIuFgOG niGA4lYW7nfnOm9zvgsbS/uJ+9vMNaznrZkMMbn2OSsJZ1W/NdTwPbw1uEJwzgK6sINh rtFyl06z46YCZxXb0NmOOGG7xuSrtryrR1Ae/SA77dNkDLP0ML8t+J2E+0HKPgKPlMxz Jl5zTBr528MQCXPbm8yNzVV1LIqRNliUIXF00PS+UNbn/n3mtebKZUf0+OE+gQI9VGU2 YNsA== X-Forwarded-Encrypted: i=1; AJvYcCW2FMS/R9470qhdVd8jzmcyFCFnHZlazJiXU+3wFjVnJaNx48VIWzz/YP3FssY2n/JCwWybHRsYWwbNxbo=@vger.kernel.org X-Gm-Message-State: AOJu0YyKyMhytigrBddiVB5oaS9WslXGRCDscA2xwZlGcN3LaBfidiXb NlPDhBMMqqdSSy5CFcqDVN1W4RR+GSN1potmAGq6YCjTouAuyXTFTo6fgiNrCu8= X-Gm-Gg: ASbGncscoXQcKy3lR10QLFM+DWg9JDmCrfdiZmIenWrN1L/lBo8RBZSuZG3fd3i7Bbm S+1Ia1etan4YWXOtWfF12K70gclKo+BMPdvvbZviaMgqAcVrJOMcxIIpwfqvXA6MfryZFuzk/Q4 pWcQB++sdGmsEzxnYnTCecTAam3/CWxddz8uK15jaIJ1rO3mPJofPemTmE25y0FyvyCwmEmuTFw Ti5MBXQIc8F8IwK9JFCMiYaKWBbefUFxuyqwJhS3+hd32fIZZY6yjT7dR1cNhnDH7ZQOx1scSJu kirHV3klsq0N4+NLXeFfhA2B15ylqwVyWA== X-Google-Smtp-Source: AGHT+IFa84choTa1mcCVuQGvjjgEmdRH9HlvyIG+7lrhNevStMTJlm/OytKRYpi+e4zX9vxoz/GHOQ== X-Received: by 2002:a05:6000:40de:b0:391:9b2:f48d with SMTP id ffacd0b85a97d-3a06cf62a28mr1355792f8f.33.1745483747375; Thu, 24 Apr 2025 01:35:47 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:47 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:26 +0200 Subject: [PATCH 03/12] pinctrl: stmfx: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-3-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2157; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=goHZgmT9yJTYnSgX1qwQQpFML/4BhFXlFKBeDD9aKZQ=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffbdnAxPhaJKaJSps/EzFiEC45gufsQ1Alt4 qq09XNXIk+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn32wAKCRARpy6gFHHX cpC1EACk2t+HP6KYD9aJArx7fiGflDxgI1WbKJ6Fu14huQEvp7PuA5rPYehuFCH1Gk1QDZiNYCb hIqrsmivpsIMWt+466di/ih3PbJOoGk4rjDVWe2Qf0sqY2SSyk0oYMixfztP1SI70MxCaZAZCLG n7XU0j057krrx++3YTvqGY/wnGgasSZa+2xJrVPjtXCUskF7RzNG9UwabQwmLqR8bDl5s4OhV3F 3tRo+1yN0XGFQ8j6AaSdu6FNQb6oINHNc51H1E7lINc6F8spGhgrPT5nm19hEt9+dv1AbIdyz30 ttnBRghwa8jedtnbv7JtAgxm+xLqAUP1sRY9LmzRwIyiLPRA4stunNuD6uwOACJ+/vpVNT+h4C9 kyZR3CgLau/uY40HKqBG8k83ViWJUOjusAidOeRoRBpxFSIXmMS9lP5jvdCW4mAmJoriymxiqrw a2APMc8TgoRAfpGJrXESk3Aj7DtBi2C0zeGD3qy9AVg65EJGerWP4D3+k37dDmU0qg/mw/ko3hh UTJ5C5+MiWj3lpqSlJrjKy2i+M0aq/dhVoeVdOG14BHS5bxsGyvl4D9LXYKos209SoLTEAWYVNR uYrXEShrPRGrtwapj/uZelp+xH24b9FTbitop+uLfFc4Si5GX8BfmJMnx7Wa24U0daHwd82lz8D KvP3120WxRcM19A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Amelie Delaunay --- drivers/pinctrl/pinctrl-stmfx.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmf= x.c index aae01120dc52..f4fdcaa043e6 100644 --- a/drivers/pinctrl/pinctrl-stmfx.c +++ b/drivers/pinctrl/pinctrl-stmfx.c @@ -115,14 +115,14 @@ static int stmfx_gpio_get(struct gpio_chip *gc, unsig= ned int offset) return ret ? ret : !!(value & mask); } =20 -static void stmfx_gpio_set(struct gpio_chip *gc, unsigned int offset, int = value) +static int stmfx_gpio_set(struct gpio_chip *gc, unsigned int offset, int v= alue) { struct stmfx_pinctrl *pctl =3D gpiochip_get_data(gc); u32 reg =3D value ? STMFX_REG_GPO_SET : STMFX_REG_GPO_CLR; u32 mask =3D get_mask(offset); =20 - regmap_write_bits(pctl->stmfx->map, reg + get_reg(offset), - mask, mask); + return regmap_write_bits(pctl->stmfx->map, reg + get_reg(offset), + mask, mask); } =20 static int stmfx_gpio_get_direction(struct gpio_chip *gc, unsigned int off= set) @@ -161,8 +161,11 @@ static int stmfx_gpio_direction_output(struct gpio_chi= p *gc, struct stmfx_pinctrl *pctl =3D gpiochip_get_data(gc); u32 reg =3D STMFX_REG_GPIO_DIR + get_reg(offset); u32 mask =3D get_mask(offset); + int ret; =20 - stmfx_gpio_set(gc, offset, value); + ret =3D stmfx_gpio_set(gc, offset, value); + if (ret) + return ret; =20 return regmap_write_bits(pctl->stmfx->map, reg, mask, mask); } @@ -694,7 +697,7 @@ static int stmfx_pinctrl_probe(struct platform_device *= pdev) pctl->gpio_chip.direction_input =3D stmfx_gpio_direction_input; pctl->gpio_chip.direction_output =3D stmfx_gpio_direction_output; pctl->gpio_chip.get =3D stmfx_gpio_get; - pctl->gpio_chip.set =3D stmfx_gpio_set; + pctl->gpio_chip.set_rv =3D stmfx_gpio_set; pctl->gpio_chip.set_config =3D gpiochip_generic_config; pctl->gpio_chip.base =3D -1; pctl->gpio_chip.ngpio =3D pctl->pctl_desc.npins; --=20 2.45.2 From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA17214A76 for ; Thu, 24 Apr 2025 08:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483752; cv=none; b=YFk+KfKRK9JX5eeJbnSBtJe7/gl5ZhShefaJ6FTSO1c7J1nud3Uz+pWUIUvvV0m/M34EtZWu4YmMwAo38880nIxLVnP39W6T6FICXqUcHRwEtV2JJR3cOMM9VAQnO3RWOC3mY3LJeuLox1whZ63LEE+CANpDYZVQgQATBTTkdss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483752; c=relaxed/simple; bh=XHXxaJjw+L2SDuyGGQioHVSFb0imiEXoavVU0ev3U3o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uJd41/TzF0SfG6HzDVZPmxlmWMUA0Ft8djEkV2bgGR2DhKKEY2N4o7uCbiyOXRO1eqMd4eCPpf5fx3S2niXtcI6oA55UbwRwIbR4yyMzE/Nyn76Xqv4GRmXu/1p1aaUPc6jgKLOTiE9C7nqC9L03Q1Nq8bDzLnocdXC97JcEVT0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=USNKkTdd; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="USNKkTdd" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-39ee57c0b8cso695390f8f.0 for ; Thu, 24 Apr 2025 01:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483749; x=1746088549; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e1nhd4aLppAWi4+bVzlCUpCnUz+WYC5fdznaksvHJEk=; b=USNKkTddu2E5yQZkja4nzsO/GHs1Ae9FBAS1QddzHG1W1XXbSTyAfeg9nGToFQ5uzm elqnGOueYQxEfJQ+Ml86CGK/BJsOwsunT7CVL0aCpKiNhjk93oDqC2A4kPM2JI8WH9/x f7EVYA328Lhl9FSMJM6RIj9AeYNWEnQMkWSBSapztFcgWnggCJ9Pf9eUwJYEVlHGL5HW KkchQULv/f1TG7XG+ZDkCZanTvDNWuF4AoUvoTjKjIgr2A1j/EkO/aJm2BA9n213+/gU YeEfvHv+tla1QkCbQpLXfZRkiL8J6g4hjyK/lTR2SslM0+8SSTTw+jo2oOauPtTZhddJ cJ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483749; x=1746088549; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e1nhd4aLppAWi4+bVzlCUpCnUz+WYC5fdznaksvHJEk=; b=d0ErmkzbkDNjlNZdgmtvytnE3qTShM2f3YwkoVFxUU4A1W7Tk9vnpJ2fIrFUqC8y// HrYt0HYXuV/HAANvf0HUcYcARtdKLHK1k+bAqrhZFxtxLfk5cWYVSdYfrNsWTenJT3yk Hp6FZjMF9t2llTBTPKlXrx0CYEOQkPxie0NbxnXTudoJQD65TAwfdid6TKbJ+3SIm3Zm rFLoxI19824YN4Zz0Wiro+MEEGa3aFcEuObkQ4MjpETTblkhthXS0iTIhiwjAmHFBGei Njtbh4DUeOc0DK9SYRi//22DnaD86kEKIS6vPY/9OR8ViidHFtQdT7/j9wzZ2W6+xAkx t3Tw== X-Forwarded-Encrypted: i=1; AJvYcCWyTvxgpCusq3Ay2EZCjUOJ3OKa6ZaPBzNlAgxmk6ZZf914Yz4OaDb6bz1WdIj/4g/A7upgduvmHshG2NI=@vger.kernel.org X-Gm-Message-State: AOJu0YwuqxXP2G4dcuHdqQvu0CfmSNhiBqpmAT/V3yNOXCSQy61KnSvG VJGSiPcUc5XCqlO8obTerJ67ejinGqIXj6PSn9TQpO2Qh4z7oYpuJE78N1PRHoc= X-Gm-Gg: ASbGncvwWx0kv93a0WqP5VDG0EnzXdTcd7jR+c8hsFfP/7jl+Btx7EDIFpygWk8dBn/ kDnHlhpJJUMrFEJEmUnFqgtPLST/FGIhUWg7gwogBoyq2uYj1c+oT5gW0WWsAbvnzxA4VJxatJH IPjQGHYV3cVn96mT1Dp6Ggrdv6rl6yHkqI0NqkSdqw0Dj9tBYrKht6CX/flK5RDJnROE10DhQg+ fnOtZWj5L23imdZKJHl+jgrV1L7vEzFo/v4Vk9hAqLfMoz/0+fNoUYo8Ew1tffhkQT6h10OvHqx dV79JVdI/THUPWOB2AI2vs1kHJzH7k2GJQ== X-Google-Smtp-Source: AGHT+IFrT2ryKEI3Ak4fYWyfabnfpp9zOPWj4dcFDB84T+QE4vp8znh03ePvPXvInmYkhFQ+6kA3Rg== X-Received: by 2002:a5d:64a4:0:b0:39c:12f2:2f86 with SMTP id ffacd0b85a97d-3a06cf4ebe9mr1139766f8f.8.1745483748680; Thu, 24 Apr 2025 01:35:48 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:48 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:27 +0200 Subject: [PATCH 04/12] pinctrl: owl: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-4-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1877; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ksmfNK84GDabb7cwbZBiry3j0gjxGVa4nXCuGXvLQ78=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffbDmQjLh72fMV3yjWxABGClwjTKpZiO6lYE y+xV5eR9zyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn32wAKCRARpy6gFHHX ck42D/9i5222ivEDPuYJfJramTA21Dz/Si68PgQJKw8MP+/dYK04nS1HRUrhy2s/f5d8l3IQEyk SUw/nOJGPKcElQSgK5wfrcMdUf7QTLJdRhNCw8QSOsu8zgxG8mnO+kDL73zSCj6UrZYmSzbhsQr pLOonJY5NYn594guZmHYpKLwBRDzKanJB7jvdjlw0gfszSTVxk/hzhG8hUUCM/bfQZHPvJyefFV FQWRoGvs+4NzTr9vn6xCSUlbAFUGj2Hw/cBz3FfnpjjVnJobvJq6q524MdE7u0OO8X036gIDGan xzcN7fRgoRrCbXwXa+LdihYAqRJf6pbYHO06I8Vwr5qdHcoqzVxfF9LmTzJNsfRDxxLrCM6cT1b FntYtKNgMc1nEQbTRPPydtniG4qQtDZFcqj4J987kdEUq13zTzmnlHQwWOdxPYYR9VZ2THuI9Ko MI8jq3GiGSDkzR4kaJE3UKV+F5xJUGt3WHBDLWuJdOXqyQhfPQCIia6p964VATg0i0vjN5SlAY0 Qc9XtlyHZLnVy4JPaB5SFmuulMcufAUongkqc0xwxfysH14nptwQOJE3fGE8gSpOgw/sMxJA59O 47YrddaVzPY6+L7+huekZiruLx/0uoSG7JOMh5rxj8TEAQoIYDan1o14/46KQbYbsl45o04l1dT liTVfyVG+QGKJ9w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Acked-by: Manivannan Sadhasivam --- drivers/pinctrl/actions/pinctrl-owl.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/action= s/pinctrl-owl.c index d49b77dcfcff..86f3d5c69e36 100644 --- a/drivers/pinctrl/actions/pinctrl-owl.c +++ b/drivers/pinctrl/actions/pinctrl-owl.c @@ -598,7 +598,7 @@ static int owl_gpio_get(struct gpio_chip *chip, unsigne= d int offset) return !!(val & BIT(offset)); } =20 -static void owl_gpio_set(struct gpio_chip *chip, unsigned int offset, int = value) +static int owl_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { struct owl_pinctrl *pctrl =3D gpiochip_get_data(chip); const struct owl_gpio_port *port; @@ -607,13 +607,15 @@ static void owl_gpio_set(struct gpio_chip *chip, unsi= gned int offset, int value) =20 port =3D owl_gpio_get_port(pctrl, &offset); if (WARN_ON(port =3D=3D NULL)) - return; + return -ENODEV; =20 gpio_base =3D pctrl->base + port->offset; =20 raw_spin_lock_irqsave(&pctrl->lock, flags); owl_gpio_update_reg(gpio_base + port->dat, offset, value); raw_spin_unlock_irqrestore(&pctrl->lock, flags); + + return 0; } =20 static int owl_gpio_direction_input(struct gpio_chip *chip, unsigned int o= ffset) @@ -960,7 +962,7 @@ int owl_pinctrl_probe(struct platform_device *pdev, pctrl->chip.direction_input =3D owl_gpio_direction_input; pctrl->chip.direction_output =3D owl_gpio_direction_output; pctrl->chip.get =3D owl_gpio_get; - pctrl->chip.set =3D owl_gpio_set; + pctrl->chip.set_rv =3D owl_gpio_set; pctrl->chip.request =3D owl_gpio_request; pctrl->chip.free =3D owl_gpio_free; =20 --=20 2.45.2 From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B618B21858A for ; Thu, 24 Apr 2025 08:35:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483753; cv=none; b=c4sY2rbI7N9yRIysCKMb4DESkikz+QpEujih+150vwbs7esP0x3QKWAvtxn3jEkUaRQfRxPC2LdjBePP235L5wtO6D99Rm/2LyT8EmCTbRHi0qt0mgNbgnLtVK3/iGGzJ60pBywOWuiDt68wwbNVlYvLcwno/AfnLPBpBzkxh6g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483753; c=relaxed/simple; bh=sKYWu6jHhbSmv6vkxRQlHne3ddHKLG4IMVxzbEesy6c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PHJnIODOjjf6sxBykNZnZtuR0ndlNQHV9Dx9246JIXW3Zy/rfvQUN6zzPfeijXUkusx5n7K/sUDd/amjwdHDfzNCxIAP3pUzAKDKD7IkmVL6HOS3qsxwZ6YAXliWakr0Qvu9pzb3M4eigc0/6pJED8urr6FRJAsc/BSRWVGHL2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=DFV0cnZe; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="DFV0cnZe" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-39bf44be22fso507486f8f.0 for ; Thu, 24 Apr 2025 01:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483750; x=1746088550; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IcE3wUuPhjxXCt0ZMpAZ5x8qSYr01DaOTal5Jl8GTWc=; b=DFV0cnZeOPM5Air9yBYbe0la9AG2VRFcTDkQOHR13p2RaOIG4MNiXFYt4WbiYFLwGQ lVZ4jRRxm4OGgGqnEID0JvsXk8YlUQis1OzPUkFqMBRSptreUNHItOAsVRJBoLCfE9aR YP73XCz5KreDeqOGGDhNzjztiXQ492qwycHGiDjZtHH68pkaXnVMd4GARfOFDyVz7SCY tQWQxDuf2nEbX+4DC9ZJSGJY36wi0/oArJN5ou3AIr8VCfSV1truArrsbszF4w+lvpk0 ch7BjO4UNRv782HoeOJDKKdecrpVY2X9He1esy4FLIeveV0+J6sbFU7wbM2QcaAcHy5M KEgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483750; x=1746088550; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IcE3wUuPhjxXCt0ZMpAZ5x8qSYr01DaOTal5Jl8GTWc=; b=KfdkAYQOUGBy7kztBPBtoN0h9j5aZPJNRCvC3hnVzANn/uEydfi4RWiq66L+/I6rlD +Yl98lACF6l5oiKv08B7sfaR+mLgmjMh3vqyew057ME+ILab6wZBfCSg0iknl55Dhw5B KE1tWl7xV6wqNwH5PRRc8uj6PcT6udfGkQOkyHbPQZejHv60IjSRC70/ivCEAy52L+kX 86AW7lB7ki2DFssEc4D8UUXmZVtAbJCaOmrZOVF/FAKTeaB/fbrbr40/ZoOxNaDcySXA qiapyIbirfPbASy36oERgfQ4fXpSZ2IVQ/hf2a+eNrdGCAWOHoCkfWa127NlcXDLG0uC 4P0Q== X-Forwarded-Encrypted: i=1; AJvYcCXrJp41dwkJSQ14dLEHbhcOkga9KsPwfDmURALc8TuqmelmAv8K8Bv6PumsATTJgrE8hgWhams9Gzous+Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyMmlrZ6lr5iCUfRUOvCpE1xPF7Ha0ipn98PG9meA150kpxa4Nz 0ps1bLGfj/KtCIHus04wYXDVMBEyQ+wYxzfMJHETDKsaj1D7OuWa8DO0aoatxmw= X-Gm-Gg: ASbGncufrkaGVzPw24XLPdO2N8eoUZ8dwP+1/P0Hn4IZbjMQ3LQg0yFX2ItOicBsvjm n9KM+t5PxgViI8koJxI8vom4wauoz2Y09GYYdW3Wy3AJkUWSVXsdr16M8wMuzXYw6AhEMRroWzk wNgk1NNcIwuK+j4nMC+8a/4yNLz4Zp3/sDC17/fTM9S8MyQ5zIbhqSAZMczAjOiirRMwL/95F0V Go/NT7WyQrexJqqyCFsIf+haQ73gjXnnmVjDhabxjiwPhhsY/kW5Db7wMPbMKSFLILOMB0rrVVB sNxBBSSxBxpuYDumr/kFE7I4ilbgV33KOw== X-Google-Smtp-Source: AGHT+IEsWzX9QhjOfL10bahhvABCZZd6/bNw9ibC716v4NWqAwsMmmJhcU6LjMO+0JhmAyeRMjtJnw== X-Received: by 2002:a5d:64c7:0:b0:391:4389:f36a with SMTP id ffacd0b85a97d-3a06cfaf773mr1144784f8f.48.1745483749924; Thu, 24 Apr 2025 01:35:49 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:49 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:28 +0200 Subject: [PATCH 05/12] pinctrl: stm32: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-5-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1473; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=AUxJDyiCjGLivQstc+QVCLPEZx1XbvG4rMuoF9PwOpA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffbJ94gWt6uen8xm8HSBtLyBXeG+3LKxm5Ag 6RCSTsSwR6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn32wAKCRARpy6gFHHX csj9D/0UiFkS9Foeto0KsdJ24lw9fG4urXmVGhvgv6seCM1EF6eDkw6PCKi4GBqQSeq1yabajRg DJXMHRA2AfiRzQqGNnP+t0bEm8pKAY8qKJDpI9ThBQQldJkCol2eNZiexSOlIp+HB5u70AcZKJG qzk+58HlR9pOEUN4kaRpkfYa6HeEQH9adnDnZuTt0IzDBPPWb3fefH6xfO79VUAhbX17E3ibf8w Zh+ugo2z+8aopq+4jxhsFaY/KgyoW4cURWjpX1D4fFt9WO2EJvHFAZ94pCGsBCDNkKFZDq2PKfl VeM1bBsgYFnn4dOFhLSMUbzeN/aEnRIePjyQpJXjmW3l383Ii6unpjfYe5r8UGQ2agPamvsXk79 XL+90Ned6wgRaRoItB6reFmzOlTkFWVuhDpYtFw76WlTHXdRyuRcHIeWW5GTCbR6T2rwtazHM86 hTAJY0qL5kAqiwBym23NK2AyHgfDiQo6fLLXkD0L0lDFqeViTNAC6a6ijPeWzs+O6wwM7z9CZCq jjCiefFTzSCKU9C2IN3eaizpunc2bYNq4i3MgnxktLJTsxHsi/WGrNlEZxasOkPIOphKYHzXYsx n6S2A6WN7t2UBoUeNEArpG8J57u8CB6stqeMrr95xzc0vVgiX+Jxvez4AOXCcBDYLfmDSXTsOwB ehvgs5t3m2Tkw1w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Antonio Borneo --- drivers/pinctrl/stm32/pinctrl-stm32.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/= pinctrl-stm32.c index cc0b4d1d7cff..ba49d48c3a1d 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c @@ -228,11 +228,14 @@ static int stm32_gpio_get(struct gpio_chip *chip, uns= igned offset) return !!(readl_relaxed(bank->base + STM32_GPIO_IDR) & BIT(offset)); } =20 -static void stm32_gpio_set(struct gpio_chip *chip, unsigned offset, int va= lue) +static int stm32_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct stm32_gpio_bank *bank =3D gpiochip_get_data(chip); =20 __stm32_gpio_set(bank, offset, value); + + return 0; } =20 static int stm32_gpio_direction_output(struct gpio_chip *chip, @@ -308,7 +311,7 @@ static const struct gpio_chip stm32_gpio_template =3D { .request =3D stm32_gpio_request, .free =3D pinctrl_gpio_free, .get =3D stm32_gpio_get, - .set =3D stm32_gpio_set, + .set_rv =3D stm32_gpio_set, .direction_input =3D pinctrl_gpio_direction_input, .direction_output =3D stm32_gpio_direction_output, .to_irq =3D stm32_gpio_to_irq, --=20 2.45.2 From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68C4222068F for ; Thu, 24 Apr 2025 08:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483756; cv=none; b=G4PuN65xuT9bLWYBNYw0VoxoXmStTKNEv90qUdkaGV+BmTXKA+Xv8nMIHv+SSJLMqjxTnD6lHID0TH46J3zo1zPxOi7rUCTghdrm2sFjPCoyU6JZbkNpA2Lu//jjFVMGA8i8BdMKgnm7Q3zt7w3wwtsUOQsBCrbJBtIR0voIRA8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483756; c=relaxed/simple; bh=gr4j3Jwm5V4eo0S2WRVkEBQvxzFKQLytZ1nLPQ/vxUc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sbQS5jw95nOCcvIdDDVmMdgsu3ghbRY7paM2by/Pqyr72znHSarxjkf4s50Rxh/8GZpi/kMax2mTFk/npbVPMBDjTcklCVXlRtEvnNimS/FNKh3k4ggXcZsRvleJLxR65V8RyX1Batl6DayB2QrqOfmB8wiYRdUSP/m6/MSfKV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=b8smx0Vh; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="b8smx0Vh" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-39c0dfba946so489517f8f.3 for ; Thu, 24 Apr 2025 01:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483751; x=1746088551; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JgPwII0oaN/xr9K9Qpbpi6zJX/PK55qb5SnnE9vGitI=; b=b8smx0Vh8aB50Wlo7uCvrFV88cy8pSA6Egakgx5xu8SxDYv5qAegPACeHJYY4lsFWo pu5SrwB500HESSjviStShC8IHVm6DRyyZ5YC+9vZoYObYQmg5HdL4V7v9emyAY1J/dZK NQTnDknKRP0jjpyOt7xKfiZ3/SsrLrxsdhD17/6xh7SVfLfyFwWZ4UVNJq5Aw4G+zxi2 FimJfZsQLNNA2nwZSp//5dl47LNc5E7XlGhK4kMiiJ6LCDj/krQ8LoBIe/2cQQDbGMdN K6MXSEUL/CuPkVGFyTCzq3Nhphh7tkBmwnIuVotB3N4zLwzq4JWghYb7JFRn8eZpzPbP oi1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483751; x=1746088551; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JgPwII0oaN/xr9K9Qpbpi6zJX/PK55qb5SnnE9vGitI=; b=mBSThvMRvbspckBoRnexqlqkWip8jRW0SvQ7qfHsXUqimrHRg+v7ihwqz6XowMfTVV NDBPCWDedI8DaslxK9ZpR26tl8nmghMKNOlMmAcFfmd/Fj2RVFwwYDBtq5ri9RTjmjNy vQF6KdQwvmUDN/JmGQjaVjpdv0tx9DOXdNPZ5ADdkx4T4RditwTw2PJ6K7Zq0l9wYpIO EuXxlexohsRdKi5F0aLqyIUckvSI8NXB39aAUIOeJoeCpIJrtFj6wz8eInnkNY0KHm7e fvILnB5mZROlY+QAWbti3aLhYKEgHHXraWg6ZT6PQdNxWj8iTwepp0rnm9yW9uQIk1Z6 ctJA== X-Forwarded-Encrypted: i=1; AJvYcCWlIsB2KlqxBm1vElKYRVwgrbYq4yUtooLIegv2hM2EBWVdGEmYXnQm8sTXI40INDK4Cl+OP/dmEpZqYAo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzhs8LLlkeR1yotY72u2FL6wVrcRKfrm7fFhbAAnTxTuIY3zK3s SMN/eQVl4f2RwymGzI5P/tVTGlqUU9UmV8y9we2ObFTQL2ZJuLRATTIBds56bVQ= X-Gm-Gg: ASbGncvIfOsyzH2r41pXQdSqobdo4niSdkxdJq/anaZn7sAQv+79HOO81P6EpJYZmVx xv362LTyc+q0M16tDsTqcm5W15zI7eoivckwAldOWqzpr9y/aQSxEZFujTXSwqB2qGq7nuq9oOA aLKk6/q1oroeyLrItRA+Sie4Kz4cdvbvMKxszr1Gu31j0WFQpYl5VnBBQL8ekRTR6O+aWkkIYbw jbg5bse76PgvUsN0rErp+oeIcS3BHrKQE9p84+Wj8/2ycEbMH+VGlf6LxET2lPA4tptSn5r1nRq kxtnfn0HkkFtrpY2VB3BsOSXXmYo3a+jHQ== X-Google-Smtp-Source: AGHT+IEVNUQ6vip2brhi39nvtk6MkVQTh+2bIVjwhO/bWPyTJvPXnQpR+hxBTWqkmpl4+az5f4M2GQ== X-Received: by 2002:a05:6000:18a2:b0:391:4ca:490 with SMTP id ffacd0b85a97d-3a06cf61b5bmr1267744f8f.29.1745483751476; Thu, 24 Apr 2025 01:35:51 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:50 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:29 +0200 Subject: [PATCH 06/12] pinctrl: ingenic: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-6-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1459; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=EpaHLTvHgujEi7qKfzUhgTml3Oo3ftuzcWIJ8X5naTs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffcqRFqMqwDfrINHgXeUxjJc+Heti6mMqltZ WXN9WyQbmWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn33AAKCRARpy6gFHHX cofZEAC+M87Cf+K0esqTbzfza67g3hY5z0YJwPkX2vXvmZuWICpN8P5imK8RtM9vESiUtCN0ybB hTNiizbnx9EY0sYuvoh714dAmY5WntJSjg+lKkHxYaFY6O+kKPcQks2ESZNLsGfxCIwbDjx8UE4 dnA7N2MMnPS8EHdw7onAjS5gytn0XfnCyma6MvFGEEirp8OC/7UTcsEttr5kLpIOt4qze7JZETn c2Yla5eOk3uSZp0IWQDbBkMnxMJvqSA4uUuiD32PERh/cGH6Oi9u9nkcYojNbnhFVUnNgxAow3j GIWL6FS33qlbPsXXexga1/6/bHbdKgDL3kcsbJfT7ROdq+AhtedMoKE3uUnu6SID+u7yy1aIrMV u1VfeW00/l2wDrmsXSb99WtG8SonrP0w5jQe/uKxq/lUdKqkdDL/K048p/84bM/K2FaTXS5PqMa LQYoovAMpXR7KiqLnNlvPkXUcMQbmXmJ9w7sfdj0tIrsds/fklzsW00FLM20w/UWRnBoPwkgcsU s5fKhyEWdbM8MraopZYWx0OkbqIL05w24OOAcEymloFAxHQMBJEDkM9JKO0iPMkeECvZ79w/syz fjW9mwYO4qG30U3wUD9519EqOnbGP4olbfbcmmkC7HSPkHjZzbmWs+VYwUqCBTxWMAUIsCaLlbk hX+zipAXZL6tN2A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Acked-by: Paul Cercueil --- drivers/pinctrl/pinctrl-ingenic.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-in= genic.c index a9e48eac15f6..3c660471ec69 100644 --- a/drivers/pinctrl/pinctrl-ingenic.c +++ b/drivers/pinctrl/pinctrl-ingenic.c @@ -3800,12 +3800,14 @@ static void ingenic_gpio_irq_handler(struct irq_des= c *desc) chained_irq_exit(irq_chip, desc); } =20 -static void ingenic_gpio_set(struct gpio_chip *gc, - unsigned int offset, int value) +static int ingenic_gpio_set(struct gpio_chip *gc, unsigned int offset, + int value) { struct ingenic_gpio_chip *jzgc =3D gpiochip_get_data(gc); =20 ingenic_gpio_set_value(jzgc, offset, value); + + return 0; } =20 static int ingenic_gpio_get(struct gpio_chip *gc, unsigned int offset) @@ -4449,7 +4451,7 @@ static int __init ingenic_gpio_probe(struct ingenic_p= inctrl *jzpc, jzgc->gc.fwnode =3D fwnode; jzgc->gc.owner =3D THIS_MODULE; =20 - jzgc->gc.set =3D ingenic_gpio_set; + jzgc->gc.set_rv =3D ingenic_gpio_set; jzgc->gc.get =3D ingenic_gpio_get; jzgc->gc.direction_input =3D pinctrl_gpio_direction_input; jzgc->gc.direction_output =3D ingenic_gpio_direction_output; --=20 2.45.2 From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6591422128B for ; Thu, 24 Apr 2025 08:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483756; cv=none; b=HybSjUaI6IEOwsYiQ+2pGqKiTtlEJuRmzvTxPeGAUcWKhJR0x4uX9V3OXMHi+NHE8LfQ7rZTkRXy+JaQ4TYO/ze6/pRJ4QVlj9Nal3RniAv3PawlHW3kUCxt4berpVjCGZWd9pg31vS1OGQHLzHcfcNO5FJorePkJQl0cTEGg/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483756; c=relaxed/simple; bh=Vc8/dFLnJclUSR5DvqNgincJOCQZ249gAvpGo88KgB8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AfVf+zFn2kppqXaz8GtWlQmqC8uzwFv0ErLCjaK2lSv+GWK5wpMcsoqU8WzuNXYeUxojOtDO3drMFYQMCrEUdvPzRQCppxmpE880nECEUI2ZFURUQUckXyqNJ3bQ8/FivYB3/jWq4xVPv62kOhFkPpi9ryndGq095Qnvdz8IObw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=G+qkZ69r; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="G+qkZ69r" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-39ac56756f6so674191f8f.2 for ; Thu, 24 Apr 2025 01:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483753; x=1746088553; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wTRtn3gXVVNnhZ5kHemU1jqDeTpH6rPs+6+7Y5/K7TE=; b=G+qkZ69rNjZL+qiG0Jm6yawRqwoXVRyfxTeTyTxmHU3wXAuGz11E+Lbtpbwe0Skcsh 11bvwFfxF9dGFZ00u5l/ke3Jd+E5w6ki5/WUBAegQo8jmqSIdYD7AZJp8PfdkXPxcPA9 lIGq82a7fYhXYiTUuK9nbrZhuh6apLTgrmep4ELWLMuIoEVTqZa2kYhRZOAWkAsyRLPJ PQ+uEu3zRkAd1YjVc++e7dx5RTfpZuhtXBItVaLf6BrWXRS8xhYm1pyIBetvBBhVTMPJ 8unUJmeHx4AnqZK7jqSF7Z8cGJkI3bLNSNayMNAk2uz1lHUoxVXcRrjchrf/EfuJcesY FYMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483753; x=1746088553; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wTRtn3gXVVNnhZ5kHemU1jqDeTpH6rPs+6+7Y5/K7TE=; b=LPbV/XzZ0tPpAnip2d+Brw6pLt3I9bld5aKPaqhJKJiYdtAXgXVVC0FDzsxqQpMFsR Oe5U4KJOMVFK28+pIsJep4yC3X6Yqib3KZLx3kqDjYj+U7UN89JOBQMXb0FV3cTv72l4 ioEFAM1p7/lRTRPpXjPGXEfiBabp7gS4+Y7W8mgsCccBELKg9WTx8q6t19KkeVYv0lxg 9fyCEF52L+E04tHJ4BPtvLZ+RoCJGKn1jZMVYyrrVqJ8pFstiGN22PdNTMcg3+En8LU+ 1WG/pSq7/8EFSiqxUQe0Az4povHApTuSrdIT56WlaBqGbC6zXoY+3G/QcLq0bBea1NTo R0BA== X-Forwarded-Encrypted: i=1; AJvYcCVSnCO8n2u2SWEvkATpaTsh7TY9iDZtyulsmA/1kynAwMbl1J/BIXUC9A8JJhpX9OtheBqGi+oqB6kA5aI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9Yljvyh8FwPCzKMNJ2OumDfMCuskK5Y7a9nUalx922LmzTyXR maG2hZ/hQ66TVVXnNsWQ7k+Ix6AjMa5+udzrb1zFB7a6R0vU5/+od91TWTnOiAQ= X-Gm-Gg: ASbGncscicSxynfMqcJCTWWCWOFpNksqzwWAMlvfzm+J2rMmnTuJkApvvZUByGNz5Ac X21i4xhaxIwrPaKj8r5ZKEs1CLBq+cQ2hwNWgMTqn3pAniFxV4cabT7f2dARxn4EbGpRUfImEM9 cVAQL3jNWfKffPmM/z+uGkBQF5ujs0Jkg1QVJASdPTnMH8do5YIKvzRfU6jsr6TQrALPJOulG21 uk+961Y1B2rqrrzFGqO0tdmegP+l6AYMESmDVPC1sqJEjZnA5GJb2NMOVAkh6SJJHgJ1KFrKXBD 1aWxqEUiRK0WkyMV1uKxBs9a1xpYLPPQFg== X-Google-Smtp-Source: AGHT+IG3o1AaNixTqoPOuTrDe4rgeHySd5Wl85X8/9jI990OIrHcrjGyGtt6SlYJ5x6wKjhdeetSOw== X-Received: by 2002:a5d:6da2:0:b0:39e:cbde:8889 with SMTP id ffacd0b85a97d-3a06cf4b8b1mr1481072f8f.6.1745483752816; Thu, 24 Apr 2025 01:35:52 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:52 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:30 +0200 Subject: [PATCH 07/12] pinctrl: microchip-sgpio: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-7-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1639; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=hcMZFoYnI5hp40Tp/W2N8GmsL+thERqAp1Vv3XxYVkU=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffcYmgESeviEGOC5kHsGWpr6OnT8URHaFb3d S3spkaFecqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn33AAKCRARpy6gFHHX clPXD/9J5MN41zDFuquWy4Q6I9uR28p6IAtPRR7LXz/y6HhRCZs0LiWF/a9Sp531rqlTtvTqIVW /jA+xhxcVsKGb1W9fkqBRjICm2Ro/34KgxGJHlAGa5wi4Vq91hNc35+VMd6FGA4b0ebusHqdncD hYR8+ONdpy7mHPSADm8ug9QuRpbU9ky8cTjhHh8jeqte3aiuHmSqbSmIhpOBSYhR4dfGErwJNLO jEiuhnPpjfz3zljaEzY1fOlKYEFP8/pAPybaVYYoKJr3wgwTbBA15A7YuZfbP8rFhh2/KZWMQQ+ uXhHsAZ1AQC5oK6kC8WXp32lW4yifh/SOlhzrWpfYxWuYChMUvtajzoVHFm1z1BrEJSdzbk8vRN p9cyMn5hIFnEjKLIeO7uPhGHDoO6TF17grr7KtAZmGXyBIn8YjGxOneARfBuAAeQLSJZd0UZwLJ cZCsOL20W4CWvm9QEpN/1pqEeDhmKbfeLcLzp6L+7rXYY7svai881XdGofNDKcPcNeb1V/duhU2 80cdHROxrw73r++hg/wNu/mmN2vphTUl8itNAfqGeeX2O2xYuR4sOjiSQdDl630ZSkaX+yNSj45 jbMZ31t07JG4dRdHKbDYchFFKBRNmcdFGW3pLEvQbRONExRLMzgRerFYuekH06n73jTmA7sOosx cr77n7M0nryK/Gw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pi= nctrl-microchip-sgpio.c index a60db93b61b1..88c2f14cfc6b 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -555,10 +555,10 @@ static int microchip_sgpio_get_direction(struct gpio_= chip *gc, unsigned int gpio return bank->is_input ? GPIO_LINE_DIRECTION_IN : GPIO_LINE_DIRECTION_OUT; } =20 -static void microchip_sgpio_set_value(struct gpio_chip *gc, - unsigned int gpio, int value) +static int microchip_sgpio_set_value(struct gpio_chip *gc, unsigned int gp= io, + int value) { - microchip_sgpio_direction_output(gc, gpio, value); + return microchip_sgpio_direction_output(gc, gpio, value); } =20 static int microchip_sgpio_get_value(struct gpio_chip *gc, unsigned int gp= io) @@ -858,7 +858,7 @@ static int microchip_sgpio_register_bank(struct device = *dev, gc->direction_input =3D microchip_sgpio_direction_input; gc->direction_output =3D microchip_sgpio_direction_output; gc->get =3D microchip_sgpio_get_value; - gc->set =3D microchip_sgpio_set_value; + gc->set_rv =3D microchip_sgpio_set_value; gc->request =3D gpiochip_generic_request; gc->free =3D gpiochip_generic_free; gc->of_xlate =3D microchip_sgpio_of_xlate; --=20 2.45.2 From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19580221723 for ; Thu, 24 Apr 2025 08:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483758; cv=none; b=SLKIloJiZvcTzOITIKqtE9kT35yhoODfvKRAYYJw3aEQnE7XnhLw1jMUnaq/yHB3CJ2IRLLrVN0arfKOwPP9WzLcaPSZbzixViZ/UH1kec0+0m3QqyMrHhNwAr9ShMo1CayOqa2q4Te5nnqvj8ug0wfB4k1iIiUcsicMxvvOY4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483758; c=relaxed/simple; bh=QkWXtrkIRF3vsuquILKlcbHOs7CG+TDFU7mwGH8Ipb0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h8VBanbpxj4d+/ZiRFKXq+0mZad6a+j7zuJaUy1BxsR9YhfuM8OzpiFYWdR5cAInDZU1p2qd/1eePoFppr+CSyFUQyrPJEqM26dzLqwDTfeuCx0dkjwohxTn38Ar8kJvmu+w4qS4YkTB2QUq53+f9OPGZ+ogXL+5RN3zsbemrmg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=ghzw1tHi; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="ghzw1tHi" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-39c1efc4577so370141f8f.0 for ; Thu, 24 Apr 2025 01:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483754; x=1746088554; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=guVd0XqaIuuYiAcIyv3ohr2gNgxdcQXQ26FZ1XVufmo=; b=ghzw1tHiBNhusg92wetSynKH6g+ZVMDVTcChfPqwjJUOXoQhD2t3WrUyEsRRkh5lDX jNlZV8CXWwRklq7LI3Y7CRPS9E0W8TvUrmrAWAMOhdehjvmArZ+B4idhrebdv2n8H4vh DSNGDrAnbWpwoe/2NJsuSfu307TAh/o80zkplaayoaRYJ0c/bz5lsguZCSieOnVN0AC+ HNO4fW+11eIB7Tm4ld7evBuylGt8O3OiJEu8bUiS3Utj9GPM3ppa8jfXxLXDGfE2oH7Q HruIbsbL7KFEUp1SKVfaAcpvv4ihqF6JsYG233J6yZNdUkMnfdZieqhA0Ug+OHE2FUpR /Shw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483754; x=1746088554; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=guVd0XqaIuuYiAcIyv3ohr2gNgxdcQXQ26FZ1XVufmo=; b=b1r6gVlsD+aRsf8iSGYuCN9GpwYg6NGqjV6g8xkhjrfuSVhJ8cRTFDytcVbo1L8Tsk WUWQqDsG3eK2N2THBuZqB/Jga2Z6baoviFx574ZA0MKL87RXgdoH8+jTnn5LRFaD1Elg tPrtCMf0q0yU28IQulXmggXPL7Ct6yYczNB9doWFKkan+upmLflBCYC12091elYliYuL wMzw8nvHTfK+zjDmI/0gJT4Ht/PsvBbKhHa3KAN3uhfeSY9GgkmHemBR1gSw0eQ4X2hc 2Alf1LsVQ3EQKlXcJL0Tp9qQZPDSxQ4qGPTEQYf/qR0qqtpanlObDxRu/uZFN6/sI/T9 Lf6Q== X-Forwarded-Encrypted: i=1; AJvYcCWuInwFUw099NMgIlJ6S0KvzuJYHIXxAsUiPcBHgP92TNk3QV8xRmgv3VXAR2KNM+jbaoqjK41QS3iQjxI=@vger.kernel.org X-Gm-Message-State: AOJu0YyhHGakD0iwT3KX533cJ2QMAuD0GPzEr9KHXuQIs/3QUkbCN6ql xYCRGyYctVvZai5+1Qksv3A85tux8rkHNELb1iuyYJYPjWWxx8wqouORs56pSSs= X-Gm-Gg: ASbGncsEIoQg4AyJQ/9oa3fLPYCwut7hV7VQZLkM0ndt3W0PKfEcnQpni6grxXmFloh /HAp0CqUwwGMziB7vG2Kg+8lCRha6dXwuGtMPlBVjOnKCqbvpTETq8h+lg5VpLfmfGOlGJjntWW ozHiUWtygbEzo032YcmBcL3c63wDuPoFUmARz3lV8QLrCpMrPnJlwyTFy2H+M8blZfqIA62LwyC 0COlM5LAuOnf7/Gqa5gYmjDAdKIn05kEuWAS7xz3+CQz1uiu81RyntTX1TuwnnV5gniWZTg8IM0 Zcsxz1V3vBb4hgL4RzqCnI8DiSGF+ox+1w== X-Google-Smtp-Source: AGHT+IEn/oPv6UnLEvwrRXLxLEBd1A5hnHHfX68c3JV4/tT6U0jLedpQliXkYdl8P+72/kekunTQ+w== X-Received: by 2002:a05:6000:420b:b0:391:4873:7940 with SMTP id ffacd0b85a97d-3a06cfb22c3mr1086182f8f.54.1745483754307; Thu, 24 Apr 2025 01:35:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:53 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:31 +0200 Subject: [PATCH 08/12] pinctrl: at91: allow building the module with COMPILE_TEST=y Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-8-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=750; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=JQiHyqG15e1DMj51Mblko1MsHmKlA0nIqnk0NLfFft0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffc0yLOnkqqTE6zwxGGFb4MyEZpSfBDn7daV BRxeEOL8NKJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn33AAKCRARpy6gFHHX cnfxD/9hl8UZC729fpc39Q9MO+KK6OGwDTHMkxkX0abTk0tnDXvkYVW96eyNIRbMSvdgtxxYhQz DRC/3UA5i8zPRD/OwTjEIOsmy2MrIk7jIxOc5WSE9YQ8X7Y9Tm/SL7gxlxkKDhfXIfKk4kfIe1E XSwI6rjWj8PbPffzAMsQ27Kvm5wKlmT0jM3leNBQzqu94uViOHB830IfkAsXtoo2s4NWWmp3Xke aVgPWgFaZAwaXQnb6e/3UPwpp6qeMaofylNzH4HBO5YvWqtaL4kzYcSztcH4dRWVKwhXPaUQ6wj XddUuH4De8auEqWbcs37eMJhLmIPaj1lwGXEuYAAqPMc0aZBFF2k6QtC46GyCGx+TQywYIXaCak 6Kd2qc8b8NJWREV/UnAq5r95k8EQhYr/GHDpFT2ZlikKn1JAVeDz2zPws30y9RhcvMgC7rHXhEc +ZDp3lgSoP0biUU8jtIZdCycINhWD2S9VGI+RRfDLkBZi4mm3DdvH0C2Cn7X6WGdo4rvJuqMwnr pHhDbirfJ5xluN72zegSt7BJLSKyLgRDejg/nElrexqqLGINLNl3P1RVsaVavFjwrw8K27FlZN8 6927UtJgVUgH0EySgq1Dkch7+90ScwITtvN98N452XpCGrslt3WrHTz63//GtPkErNETJABYuBz mMIajgtwXO69Q7g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Extend the build coverage by allowing to build the module with COMPILE_TEST enabled. We can do this as the driver doesn't depend on any architecture-specific bits. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 464cc9aca157..db84d80b7e7d 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -103,8 +103,7 @@ config PINCTRL_AS3722 =20 config PINCTRL_AT91 bool "AT91 pinctrl driver" - depends on OF - depends on ARCH_AT91 + depends on (OF && ARCH_AT91) || COMPILE_TEST select PINMUX select PINCONF select GPIOLIB --=20 2.45.2 From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75B61221FA8 for ; Thu, 24 Apr 2025 08:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483759; cv=none; b=Qg3qtp0F4wytkPdI8Z5TsK6lsA/QHI1aZZsYmGuKomKM7ic52VVSkYzixqKDIYuJWx6f7OmszeZHavfheF2G6fctC2lVS9GxT8k2n6QqsQDR8f898Vc6DNnsCzD5h2KItlujsGEBTN2QAn5kC/BTGhCoMvUQvmkdloqCSW885w8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483759; c=relaxed/simple; bh=sps6rFyEZor3eSy0kaZUAB/4WNPHFKflZMDwh7ZA41k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=syoRARD0nh7qB8RutrEV+sNXBEl7nYeJvPN8Y9QMe4rAeqv+EV98jFhoA4fJ2c5ylJcewT4Iks6TWCxIcUY/6wlImgOIKtlkO5vqTmZ3bGqK7+vgreYM6keX+KIBiZOysK9yuf50lalcQJsarWxiXcYNIV6eBcYMEAE4RPPmUZ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=wyG2foMz; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="wyG2foMz" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-39ee57c0b8cso695520f8f.0 for ; Thu, 24 Apr 2025 01:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483756; x=1746088556; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rNkYr76mp1i7nVgGetDvEHtsIWDovRPdxkWR1fDzPxI=; b=wyG2foMzVNQlcNKu1gPoWSe8a/AFjO/m/3iGe/tHILXN6BJTc/7S6pp7VYqYFuz5/U vMDqGVXkDILY552OhMmHYGGmRBtJoRIndpY0glZWrkgJ7NFDSa41eVWYPD1aIh7QwesI kgmGzg3jeRZkt7NFFX2f0p5Qk0Jcb6jQ8Bn/1LoHrXWhP4boVFuBMyEDsDeK33c9aqLR +updUjclhI6J5Hve7iBlK0VK1KGNWtLekw67t9P6JczHIw5M6ZYDC2vga0EIqD0NMVP0 ozubp8O7AYaz2xfAD7XJtFD1Y/5f53B+tHz2EtA8BxC14brLiKlQGowvex8AFOafwmvk gJ6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483756; x=1746088556; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rNkYr76mp1i7nVgGetDvEHtsIWDovRPdxkWR1fDzPxI=; b=dADC96zG0Ld+9l6U8HcZRm6jgvRxlvXElRnwxN92XQCN9sYxXuDWMRx+BLpPr9ERn6 a5xK8+cgmscbHTA2KD7XbDEIL7YmNXced9k+RR9j+s9CJnvdZzTETIMxmI/954H2IeZx qG+RA8LBsBezg1a8SD2gxlDn44NruUH/tH7beNBCLFIKeeAe7mMfDBXlnSbgBUbei1t1 cZ+UzkwpxXuTyigMj8HaP9UwDorWd5qXyY3t4CB+F1ZACFT+50FvFuBGlUU10Vcp/1Zp TIgZTHY8sk7BuXdE2mee/8WZtX4KQsRir1TY1M5CQrl7Io+tZOWU2Rn6T+r5I4sWcTRr SmPA== X-Forwarded-Encrypted: i=1; AJvYcCX5Kr+EirvMjhYGFbYwNeH5Cwq9ej1Jq4bHkrZXeESvnNPHEbidx5DjlMltRnn5OlA42yewDbkRIDwgkRI=@vger.kernel.org X-Gm-Message-State: AOJu0YzHmavDdSY/bUwjueZFdP8NPr6RCUfyCwlMAeNHsTDC1MaKOvfR vR0XMNcwCrDoINLRzP29fchp8Ff1x9X1jPmM6/TYb5YkbiU2Jt0JDjZW1uKymy8= X-Gm-Gg: ASbGncslZAqFml+sS5169ikBf27xEKKLSk8kZDcqLmKWlBeQZXZ1xxt+U+XCahu/oyp 65Xc0t6YdXu8shnyK5wPdHMq19tbQm2gJxtP6mL/gb8h8PXLeKG4LoOTwH5Hlmiyhy/HVxKRhMV 4ehweMgiATsTjAgbV4+YtcSPYXm5q1AoC8elJ5kwE08v4lmCN2BynScqfvHYvwqsGYceePBNT3e 8cy67J3JghoWecW8rswEkTKVo4sRsV2KeLf2DoBHnWhglVFTPcm5taXAXtPQb7CWeEHcsxXsgty ITMwf7ntHBpOhw4RYfKCoYz/YOmB+XhsoA== X-Google-Smtp-Source: AGHT+IFjK2Ih7IwrcWu/Ekc2IScPqnu8LdiHaMHhLUAVC8NOSxem7de6NFgjnyJadaWki95xHXhVmg== X-Received: by 2002:a05:6000:2285:b0:39c:dfa:d33e with SMTP id ffacd0b85a97d-3a06cf5ee26mr1184882f8f.23.1745483755990; Thu, 24 Apr 2025 01:35:55 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:55 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:32 +0200 Subject: [PATCH 09/12] pinctrl: at91: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-9-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2126; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=hJTZiBYt8YR30cOIobq85K3/2m9qesklwxGOmsQ9g+A=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffcCq0GrDNjVi0FNEZfifP8+NRGD6rfnJWXk coBh3BYPZCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn33AAKCRARpy6gFHHX cmMXEACVIhPoysgXs4nu5CJDcrzmVOtI63aayA+4b79fBXpL+qGUHubLG3YzFMEjUXjHl85dd/6 u+PbGSG++Td2UJwMOeToy/iU6XJeoDV9NcAv9A3+d8dEVceRGEzF/IV67jKmO1bygPVhxBTQQEi /zIZgPpE7lzaIM1OzDuiGntQ3w2gaNwTRpcs9IxS0hLmB692VjKRLywPkO4KAQ6q9XxoVl9VPXS 6y9mHl3q73az6GnjjF/r1u9yfRMQGn6acO+aj5/Bvsi1Bw7qDow48UrYbXAEUc9uH8oeP0+uX9z tuMTPyg5d+3k7jv63X5OIb5daBS48MeRE6FPFo3VU7Xl+eeLSfRwF9frrll/O3vYGMOiqVLocU0 AS+osCwUO7rZZ7QRq1GH3ALDM31j8aTOK2l4xXsXTYNZVUiiM4MOZR64Hyi4u7SYtPAN/RogT2u x8zcKpoXblnjfai77whaSsOXUmhkgQHJGCar4waLDSd7mIXtWlcj+ap1RzNka8B/uQtm/egMuOg PaPJQ7PYn/o98sUu7aCCG/LPHFkfjRDXXUjBLyjUit4Z1Dlc2FMLjn6CzlxwUbfR5TWF5eMkMlm Zq6DNWbNlbcPod4oxNbS/msyHUx8ZwDdf90kf1rF3IVNBsDxS2dnokrMcEc6lm/VrqVYt4ACLHc FUM8aDQrmoClWRg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-at91.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c index 93ab277d9943..442dd8c80b65 100644 --- a/drivers/pinctrl/pinctrl-at91.c +++ b/drivers/pinctrl/pinctrl-at91.c @@ -1449,18 +1449,19 @@ static int at91_gpio_get(struct gpio_chip *chip, un= signed offset) return (pdsr & mask) !=3D 0; } =20 -static void at91_gpio_set(struct gpio_chip *chip, unsigned offset, - int val) +static int at91_gpio_set(struct gpio_chip *chip, unsigned int offset, int = val) { struct at91_gpio_chip *at91_gpio =3D gpiochip_get_data(chip); void __iomem *pio =3D at91_gpio->regbase; unsigned mask =3D 1 << offset; =20 writel_relaxed(mask, pio + (val ? PIO_SODR : PIO_CODR)); + + return 0; } =20 -static void at91_gpio_set_multiple(struct gpio_chip *chip, - unsigned long *mask, unsigned long *bits) +static int at91_gpio_set_multiple(struct gpio_chip *chip, + unsigned long *mask, unsigned long *bits) { struct at91_gpio_chip *at91_gpio =3D gpiochip_get_data(chip); void __iomem *pio =3D at91_gpio->regbase; @@ -1472,6 +1473,8 @@ static void at91_gpio_set_multiple(struct gpio_chip *= chip, =20 writel_relaxed(set_mask, pio + PIO_SODR); writel_relaxed(clear_mask, pio + PIO_CODR); + + return 0; } =20 static int at91_gpio_direction_output(struct gpio_chip *chip, unsigned off= set, @@ -1798,8 +1801,8 @@ static const struct gpio_chip at91_gpio_template =3D { .direction_input =3D at91_gpio_direction_input, .get =3D at91_gpio_get, .direction_output =3D at91_gpio_direction_output, - .set =3D at91_gpio_set, - .set_multiple =3D at91_gpio_set_multiple, + .set_rv =3D at91_gpio_set, + .set_multiple_rv =3D at91_gpio_set_multiple, .dbg_show =3D at91_gpio_dbg_show, .can_sleep =3D false, .ngpio =3D MAX_NB_GPIO_PER_BANK, --=20 2.45.2 From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62577222561 for ; Thu, 24 Apr 2025 08:35:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483761; cv=none; b=e7TJlWY0WxwBN51QPQZv+/8Bww5zhN1vw81WpJ/ZlkrrFskVz/VaBXssozuOMSTzajodoiaA8CXJpM+dSGVKVtKMI761aA5Q+VyZEz2mqO4W8COtenipwoipptbNag38htxnJxIgRoDNeC4mrrUcr5lu+z4My55GxTjHv5XXHbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483761; c=relaxed/simple; bh=SYc3DfZ394FHD/QXwKPPaydZv03IewUBNtQa05U07Ho=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZpaDW9BPZSTJpW/ZXJmfkQghmbnLTLtKJgq5Cannddu70F5W3/NEb2zJijao13GBupFmdS7TUTQj86BM/nZ9k+TbC3QeyAXYkQ4STpfGZQ5ScHX1I3wXjC8/8IBIYvw7nwHvhL5pL2HK99RhYtVnKPtAQGW/lnBpH5eA7SwWGWk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=02DpnRNC; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="02DpnRNC" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43cf628cb14so14023475e9.1 for ; Thu, 24 Apr 2025 01:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483757; x=1746088557; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XaHaIgMkQszg4+Vg0zXH3vzF1A/P6OHY+YrBjGQv360=; b=02DpnRNCtokDaGA3vwAJeAcroshE5A7LW3mWC6XHuDt4WWoZ3rvTYCXqLQQnfiijwo 1fSEaLQ1Op4cndvc5j9VGqWprYy3v4tIj6P557SePZOPZxus35fp7sZXYgNAeTH4YARM nEZ0HWTz/Ahw02dcVfXxf5j37ThQK1u3tM18xyxOakE/Q/WMrY7Pwf7dSnTBMc5pdqeM Yim/UVcDzUHI2BvE766QapYl2vRuciSx4a/K/70xurILUlI6GVCHd1nQLqoe0zNQMQKe +GEMNnG4bM+GQg7/0LUIogJc7jUg5af2d5XC6QygOgJ46E+XsaRJMJl0d3U0JiKLOsod l1yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483757; x=1746088557; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XaHaIgMkQszg4+Vg0zXH3vzF1A/P6OHY+YrBjGQv360=; b=IyXeundo18kojYvZET4PLoDKkuH4gkYz2bjIYder9vfReSClEzRPrTfX2mtBREOeNt tXVaxff4V+eCmgNPjPgTbjG6jmRlB8kvzZ7w+PI1A6mLo2pdX9ycTzjvcz3lDpv1kBqU shlb8vN4uKeGMUAReu5dDZ0K7mj4XXiTOMGLilA+8yBb60K7L/7e4doci7tlra0jEQnK p8iuz8wMG2FMckkDXDgSGhaFrrjEMtIFnzEzPHi0m3yu/NXAgpCZz4iuAVIZqU5sAvRv +pTJK66XW5gBBTurlB5VeZKn6NI09LQkK9dbkSdGEYVHRnO1W/S5S2iTIFgkYJoD6t+h Hizw== X-Forwarded-Encrypted: i=1; AJvYcCWAcPpwzGpvvck37Bo0HRJ63w5gYyP8LEZ6+cTO0K/W9/elNtT4jekB+kBWfHnxUfn/wVV/ZrOivtTAobs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3133XZ+gbuZ2LThlWuSEZemp7YP0z437csKBxz8xq/u8r47lq 2U65sgKSQIxPOUa+TC+cahsstfdd7FvaJROTQ4AhRF5J/qZt5VNQQEuDCtrGUGw= X-Gm-Gg: ASbGncvVq7Lk/+U+JTYuiQWcCePo0KlQHHxJpauOfCT/qBDNUy8rVfj372LUwN+iJHL yInDEIGC1f6qegZ5eolEc7ZNelREOh26QGaqhTLXifGge2WIbSq6tK9PwlBbLHoHVzkpQOz2BXh LLfhIIxxMTgg+aEC5I4D9Qzs0bpSzHG45SahM7TjlMOy+LwjOo34Fd6kx6eHHTToDtRker2Ye0g B6925ulSyyLDIVaoar/ACsWWBrt2kJiysBO3RXWaYUbMM+zUlGeVeExbew3z2UhsBHTNJUTlyD8 ci8LxcHAfb29wC4Jdr/a8W34fJrHhAm4dA== X-Google-Smtp-Source: AGHT+IENaOXvdDwYvVzyNmm1O+wEFBO9qUA8eUmPoY2h2uvx0EEvGioW8nnYHrKcqYKrpStPrZphsQ== X-Received: by 2002:a5d:5f45:0:b0:391:b93:c971 with SMTP id ffacd0b85a97d-3a06d6ccbf1mr1169019f8f.20.1745483757511; Thu, 24 Apr 2025 01:35:57 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:57 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:33 +0200 Subject: [PATCH 10/12] pinctrl: armada-37xx: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-10-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2277; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=W0QsCqlj8k41jahpfTRdRwpb75wjwAEccTgd/iB3NSg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffdShQB6dZ7am+8Zlg1v1xnScSWHPJ4AYGjK IuNEJ72zDqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn33QAKCRARpy6gFHHX cuhZEADgECrorArfyzL2QuJa6yQe9bYHLOnsa/SLqp+XLhf+MogYfB88ZBg52BGEy/260WhH3Ar TlDxqbNf7xbsDCEMp1QlhFb4S9VgmBKrttwkTGhgoD+3LRdby7tIt4OwKO0GaTXYE3EygwT/Iq4 hrU6Se3dlBrraDvvMiQVItwNzzCJ5SvOHi8lE1jFQth6AVN9W6GZd7je8AWawFv9Wg+i96C71/A LL6g8qzLyWM1U7sLiXvQrnWtJb8cpWGNMce6jMz26KrCpwkGpSbuzMq3e2dUk1tv1p+UY0MPwi/ vfA73gllbSX9IPwu2Av/fHUnl4unuBzzo0wEISM+lyZ8KnlWAqlrdIlHQErUpPBID7F5cyZvpih 1BvJFjIXMf9xEMQTYWcV4ACfgEUhp6bG2VvvMX4L2/j/ZocIsseaEAYNaPIG+I0ZtApOV5Ne6+U 5E3cMbN5dXT7ekyY/sIH2McA4ysuJK0KPhIYnYQTPu3McsIx5MqljY49PQMhiw+qVV+O4EfYUat IOA3xFTiPvKuoi5huSr1QFG7EpE85vSMix6o50VA4BcT/jlgxeoo7ufpgZmYtUTnM8aPSLgVucZ ReV5VoN8II+I+BwyBlmEBfbL8iiEwXA0A/4funmEKDVAplmX/KfHafRvfXnO/2PdS7n7YpqLW0L IeczklCyXpDVPJg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/= mvebu/pinctrl-armada-37xx.c index 335744ac8310..18419920c33d 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -424,15 +424,12 @@ static int armada_37xx_gpio_direction_output(struct g= pio_chip *chip, mask =3D BIT(offset); =20 ret =3D regmap_update_bits(info->regmap, reg, mask, mask); - if (ret) return ret; =20 reg =3D OUTPUT_VAL; val =3D value ? mask : 0; - regmap_update_bits(info->regmap, reg, mask, val); - - return 0; + return regmap_update_bits(info->regmap, reg, mask, val); } =20 static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offse= t) @@ -449,8 +446,8 @@ static int armada_37xx_gpio_get(struct gpio_chip *chip,= unsigned int offset) return (val & mask) !=3D 0; } =20 -static void armada_37xx_gpio_set(struct gpio_chip *chip, unsigned int offs= et, - int value) +static int armada_37xx_gpio_set(struct gpio_chip *chip, unsigned int offse= t, + int value) { struct armada_37xx_pinctrl *info =3D gpiochip_get_data(chip); unsigned int reg =3D OUTPUT_VAL; @@ -460,7 +457,7 @@ static void armada_37xx_gpio_set(struct gpio_chip *chip= , unsigned int offset, mask =3D BIT(offset); val =3D value ? mask : 0; =20 - regmap_update_bits(info->regmap, reg, mask, val); + return regmap_update_bits(info->regmap, reg, mask, val); } =20 static int armada_37xx_pmx_gpio_set_direction(struct pinctrl_dev *pctldev, @@ -513,7 +510,7 @@ static const struct pinmux_ops armada_37xx_pmx_ops =3D { static const struct gpio_chip armada_37xx_gpiolib_chip =3D { .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, - .set =3D armada_37xx_gpio_set, + .set_rv =3D armada_37xx_gpio_set, .get =3D armada_37xx_gpio_get, .get_direction =3D armada_37xx_gpio_get_direction, .direction_input =3D armada_37xx_gpio_direction_input, --=20 2.45.2 From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E22C1224890 for ; Thu, 24 Apr 2025 08:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483762; cv=none; b=DPVut5ShG2ipGiX+HEA0TvhG3SA3nUwgqnaphbhPyUCZvPcTNSO4JrWzQg65QPSrJun/w8wUkLqr2cCM7Ltxa2hzlpHhZM4sGli5OfIzfCpZR64Il1HiAK8NxoXrFJ1H02yeCOh4EK6ni6RRohVbKIdRecL5YZedkpz5n+iPmh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483762; c=relaxed/simple; bh=VLiNYPnPf502Mh3wMIxXO3OQ2e/aTVoKkQARy+JefUw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IVvcRof8uReRK8WoELdHdCQAFfZvut6wlHiMyY6Zof2L/00lh24m6WRXxHu9s7usQ7ZrpH7cDYGGXjWWj2h3qaIgxZCWMVdAopqFM4wBQRcF7PGisJxWxv2YiGcD/o99qdGVPdJsq19a8N6N4uK/mGTLBHcvczsA7+TI6burGyQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=JgXxCCpD; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="JgXxCCpD" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-39c0dfba946so489654f8f.3 for ; Thu, 24 Apr 2025 01:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483759; x=1746088559; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=U3C7VrvxYzsauY2O9fqA6TSLZH9busDLcB5oYAodWvc=; b=JgXxCCpDK1593dpUv4wto1J/Ut4IQ8l8j8FYG2UkBARrTwwRKEiGzp7Qu0w4Fw1bti M/bYNbIbEYRRBWPOaD2UXBT8tw68wN5RRWH05Yw3ZPp3aYSDAOtIv7r4WvsSAKi44P9U s9xlev/j4ZXVAQCtswme8lyD9NAsWO68tfDCgo6wDCjdcJUlkArM4KR46gPE1WR8I/zK Oxb4dftYrAkhG4YTZIKCkF99tw79yYMPS3Mrk6Xs63GLg5qFNYD+cn8Unn3iLf/HE2Q0 f+zW0e9rS+mWJZlq05xmrbXWP3HfX2zFwZ0/clpTaF1tBOCngUNtlF4oCE17VcRyj3Ml gFww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483759; x=1746088559; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U3C7VrvxYzsauY2O9fqA6TSLZH9busDLcB5oYAodWvc=; b=H9Eu7VCP8sB+PldgcrhdG/yFX2ZYgDR9AcmJI+h8UVcGn8EvCTa4RhIl+DMDzRNgLe WSPxqbMtz2dkCl8t8S8wuXImLApZX7/y5QwjH6wlnFXUfJebABszjTCRwSvY9fn1HgMU K7o2V6SOPKkKDQKk2NmNyHcfSrMSyIhACdGv1HYUKCOIFvA5il+3yVGj0+2tu5Wy3jWU mNcR9hCBDd54zYUb3I3MGiqba04w4twL+vhaunPFhZyNmirFD3T2EviUS2Ak/w/RfP6D +xv8MUxouyB6FdI5VUfoFeOIaAisTybNq863Mv6SJMoxfefpbFIxdfyNLZWBMz4YDnwJ TIrQ== X-Forwarded-Encrypted: i=1; AJvYcCUdVlgaqKLZt4BbUIvps/CMmXYxa6IPIWh2Dg4bQ88OsLzL5yX9FvECqyMxaXaw2zGNeMDhIA/70DyAdoA=@vger.kernel.org X-Gm-Message-State: AOJu0YyLWU6QG8E+ChPyz6gCkpe2dBtg4EG9VBzP+PJctAB3cl4g8vSB qZ0rLw34fuIM3GCceoO5JlHZWnMgHkEaBQloJDqoaoqcsCFdisdLjzFcBlRxeZs= X-Gm-Gg: ASbGncsS8c4qZRsBBWwhTLfz7/LPN2cPQrVOgWdlNfRCvDrVDADS2L1e2Yt88RZuial zNHQ+rWHzOsuXoD9XLyEeWnvk2yka3pQZIgg8Io96B8X3DjWQ+GlRk/kgfjfFAw521EFk2h+yZV jtq6HFJShvscjmvJ6KiU4IvxLe43Obp+Ydth/D3Vy0dQW/YxA34FnPVThiDimywCp23ztBYfhp4 4Axy02xVAYC3z/29YwiBLg562JX/s7xrwioOYxF5lod0Fgb2DO56Iwsgy7nC2ZODYxB9rpDNwqY +ydaeyh3+M1eQF/Dta1lyx46hykwSNUr8A== X-Google-Smtp-Source: AGHT+IEnnIBOjrZ99O5uQPy0Nc6YKo1kNCkEEx0ebNFaJGjHPfyJDtyy3I1rgWZXM1I3Le9gFxfXaA== X-Received: by 2002:a5d:59ae:0:b0:39b:ede7:8906 with SMTP id ffacd0b85a97d-3a06cf54e7bmr1122286f8f.19.1745483758888; Thu, 24 Apr 2025 01:35:58 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:58 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:34 +0200 Subject: [PATCH 11/12] pinctrl: pistachio: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-11-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1513; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=/7hnqabmKbj9zc0e1PTeiq5UZq78y4tKE7Nf1Bs7XAU=; b=owEBbAKT/ZANAwAKARGnLqAUcddyAcsmYgBoCffdEPoUC5vhPYaWj6u0rywJUatNB6kvhR99k aCkmHZ28xGJAjIEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn33QAKCRARpy6gFHHX csr2D/iydanG4wHydJL1ZFZQ+tndFEOwZ6yd6A+ss+6d7RDHHcSVTn0kZW2keFJAbpl36Zn65RZ hnsLpH6KbrmYpJRjL/LHcH/7NbHdwMYuVrZ5UoSGGFXD8Z774KxtDYhszhTtIPa50J+L9zJR8x5 ar4cVfcl/WBSjqaJMBSkhChbwVJX7m/QYAnSa2Fgq3UzHXvWQrmH8YUrcnShqCqKxohVhrCyJaY 8i+qQ3jFFfITwn5dO+lIDMRRSLpoSUvhLA1PnI8JDwRTqurh6h4B9n3YuVxjHSL2kH7HEqVxX4E v22xIaAACCrutV1aCSxkP4YZeKsycSdiLdlqsh/tzA+2Ksbf/jILWTgafuZlhOtG48dr0Q/tyG9 eJ4q20yXNigAl5+nHVnCDoqiZddjxg5Ab6nev7k2iN10EbC2iw05dPmmkIqGfGD8KL+ynn92Rnk rz0YmhHxmeEDJnGSnV/FYYSSx+5e9VoVdHw3wmJD0kHAiKeDp2nJaCcbipsdEqgN1C5Bdf4B4JT t0XXOiT46X02l1L3OVAp5FKWB+rZDJPmYZeT2P17R13iyZoavCXR4INacZ+6v8l7ijAg4YoX4Rv 47sjTr6naGAOt0WWJUf5tdguvd8w8oeFAM4/VScXq3yIge14kHXoBfwJfJl9r6/XPuZIeR2g++w SBm4jRS72OnZx X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-pistachio.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-= pistachio.c index 8c50e0091b32..e7bf60960961 100644 --- a/drivers/pinctrl/pinctrl-pistachio.c +++ b/drivers/pinctrl/pinctrl-pistachio.c @@ -1186,12 +1186,14 @@ static int pistachio_gpio_get(struct gpio_chip *chi= p, unsigned offset) return !!(gpio_readl(bank, reg) & BIT(offset)); } =20 -static void pistachio_gpio_set(struct gpio_chip *chip, unsigned offset, - int value) +static int pistachio_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct pistachio_gpio_bank *bank =3D gpiochip_get_data(chip); =20 gpio_mask_writel(bank, GPIO_OUTPUT, offset, !!value); + + return 0; } =20 static int pistachio_gpio_direction_input(struct gpio_chip *chip, @@ -1326,7 +1328,7 @@ static void pistachio_gpio_irq_handler(struct irq_des= c *desc) .direction_input =3D pistachio_gpio_direction_input, \ .direction_output =3D pistachio_gpio_direction_output, \ .get =3D pistachio_gpio_get, \ - .set =3D pistachio_gpio_set, \ + .set_rv =3D pistachio_gpio_set, \ .base =3D _pin_base, \ .ngpio =3D _npins, \ }, \ --=20 2.45.2 From nobody Mon Feb 9 14:43:50 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12FA42253BD for ; Thu, 24 Apr 2025 08:36:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483763; cv=none; b=JZOc8InIgH0ivoCXw0ICI362yUFnxvnHXOYjtCsvkWxX3tsITSu8YIzQqWl7ebaszo9asuMjrylKSq5XBQ+NS6B0EAO4mYK9T0JhHNTMpfbgc6ZztuICiP84cXGkNjq0NozyylyOSQ2Y1FQIZzX3AfLrxcnNkpLcYAtzYA/VW6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483763; c=relaxed/simple; bh=iJgBNsG6lNFWVLQiSa+DhOTeGMwUTZl4FTd44fGqDV0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IrWJRfk5giEhv4H3VVAPfIFYzFnAr+KG++cZJksgEj51efs/SienKYrpjX2IkwIjGctuh2YU3WFc78e+Bc9Kx22MZR4Nqp4+LUFdUt6Hxc7/ZXtXDH2ITyxuijSConZiIGznv9nAwbqiSoCVmeMB7eyUtVIjivq9g+Ys4b+ykz0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=RPtK9kC4; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="RPtK9kC4" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43ce70f9afbso6255125e9.0 for ; Thu, 24 Apr 2025 01:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745483760; x=1746088560; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wyD1ibYwZZNQjABTauO+kWeZmIcgNLsOAbjC6l1tSrA=; b=RPtK9kC4LjSXD1qQFOsA0rKWaD0QeJc64AIgG33BrCZCJmOAxZ52LrclzBfUqrrXtm mA9trdleq54MLvugQI59/uqHVrgHOnDwAJB26qU9VCLDSSbCyD9+SgMwVaH9UsRUK/uo u9H6AfGBahjDSZXIrVd0/owWqf8hLb5BwAHxEM8IAcbtNqx09s8NXM4/H2+uJomieZeV GcsN1KnhTxxjys9o1NYmtY26rvOd5IXOFSANNydM2cHpUWt+WUAVVbtA3u8CwGg1yRLg J6eLDLijB25QuitRErqmqkrM9HuU/ANu4Fvv40MMTU9yCUAEYgih6eSxdpcwdkPlgpNB Hu9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745483760; x=1746088560; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wyD1ibYwZZNQjABTauO+kWeZmIcgNLsOAbjC6l1tSrA=; b=N3AbU84TvgbLewY38+vLKdbksCQYUnbHFE3MVZecoJa4/lUdrF7DbQnizzqrh25Noy SG9nGf7aDoL5VBoxO91Vgjgv7YhV4p4qTR+jc9V0g08dHe0vs9KNV9O38ZPyCb2Gv/Cb TGfNMVhVUfuqwKjYTg1u2g7g4es+y9D/OhsRVmrDWEwdP4Jsr70HHBxtCkYeU/TJHGlC BUUHF96D9XzDA1pFUs7PTNQ2UxROdKDg1iBpFGwjCKGCS32nJQ4S3p/im8eYMZNEZckv +XyL6/oBWyop33DicuGQ9sHVxxPIVVWf04Vs6StFCITCtJWYVM/ijC6NJymDllL5EM/j apeA== X-Forwarded-Encrypted: i=1; AJvYcCVZjOzegnfzJO4jVlDPC2Fm7+K5JTfBojdTQw8vw+xnYrQOJ0951jdGUQY6w9kshLAexvQVU8phPu1oOFc=@vger.kernel.org X-Gm-Message-State: AOJu0YxPP1WQ+1PDsJdnsilgvSNV4YP5FU+xwdSFwtZK/OSN6r1i9qf0 qn1/fXtQfbJaWW6k2Jed8evupODAKniAwo34VR7ZbAAAQz2Z847j2jOQbQn9aJQ= X-Gm-Gg: ASbGncsiq1mPJZXzf0e4I3SQXsFIR0txpBPR9bmtxcCjef68yYxWD1Be/FMwEeA4bKM HcVDd2IE4g/wWxRtbEPgvXPK/EqWUnXuwL52MbS472H+7BspQYMD7TAs1fWo0zK8zpquAejOFI0 n/J+sWKfKzWyTcDFgeQWkWqQogilLkHlhcSS9SRoroNaMC9HEAf3a0A7UQvdo8//vqfHOMJ4r8y k6FTIwDVdp+TEa5pDfscuA7BcPFUxymgTmePi6VhK/SL2hoAM1v/ts+104evn85Buvxo8qyR36/ 0HhUAnqp6Q3Syu+9nhbmeeV1NzhSAhWFQkrG1Y9PpR0J X-Google-Smtp-Source: AGHT+IH6QOMYk+VJrhRN0zGGVgIfy1D2k+1MN8UGZUw2MzoHJ3Lm78KvUsSoh9H7JaBXZAa1kpHpxw== X-Received: by 2002:a05:600c:1d02:b0:43c:fbbf:7bf1 with SMTP id 5b1f17b1804b1-4409bdb032cmr18240795e9.30.1745483760212; Thu, 24 Apr 2025 01:36:00 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6266:7750:57ce:7cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54ee11sm1295376f8f.97.2025.04.24.01.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 01:35:59 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 24 Apr 2025 10:35:35 +0200 Subject: [PATCH 12/12] pinctrl: samsung: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-gpiochip-set-rv-pinctrl-part2-v1-12-504f91120b99@linaro.org> References: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> In-Reply-To: <20250424-gpiochip-set-rv-pinctrl-part2-v1-0-504f91120b99@linaro.org> To: Basavaraj Natikar , Shyam Sundar S K , Linus Walleij , Bartosz Golaszewski , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Paul Cercueil , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1963; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=eG2KW5x0cqyXDN96Y9D3KPo3rE0JJ5CGRPpl+iXxy5M=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCffdVG5Ygxdkgp3G4S/J2z4z5Tlan+vD7V30h TZ7h0V/5sqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAn33QAKCRARpy6gFHHX cjrUD/4wlY3EyRbxHX7pcMIAP/3DRyfsZNReCKH3ZrZK01gpg0foFUc8R9H0I7tpjEjSAcAY76v HT6Cav5kSBB36HXaJHFnbS5jDeLX1My/AARxYsg4hUeZMPsEdhdyug5NLPV4v9U5qGYyscWQJyQ IwWtL5S1/tZAIxzE73GS7fBnvaLvxdKHbO+ihsBKDN+CICZsABKHeqmX8HC/mpf/Pn3VZDLdxw/ v370ttF11vBuDqxQFqucfxlUgG44NsRTH7slXcpLFqsmYFiyQ+60Kr8qtR4uG0wjgcD84YTAWTA jnMOBMJyWoX60aJoqOu+7ntHGuUA7AfUId1TflJw4qGZZhayvH7YZWSFpZChBh+R4GzP2lrJnH1 /l3WSICXjyuCbO00KEg0M/ETEdHzDfqcXsC++m0uUp+XVVbx+NvevmZ076l6BhVpake9w8udGP+ Y6lwhiWZ8sd+/nec1W16T+R/feEwjS3Uv+zzSP+uImKmEA6Rt/EFeZ0kppvf1XgXTXagAHYRfnq AX4Z1SXHpFfCHXYrPNMxv8w2uM1/eIljOwRAW3Xye5WYWe5bWWR/tmOB8O64R331D1+UTdeTv/x ZuaGKlVB7ySPckXnPWzWBP1UHZQiR7DAHXC2juTTX1w+v4NAGx137CcqLE/rrfEgbdhjBoA9iFy +HWM7daAr7IScLg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/samsung/pinctrl-samsung.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/sa= msung/pinctrl-samsung.c index ef557217e173..fe1ac82b9d79 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -570,15 +570,18 @@ static void samsung_gpio_set_value(struct gpio_chip *= gc, } =20 /* gpiolib gpio_set callback function */ -static void samsung_gpio_set(struct gpio_chip *gc, unsigned offset, int va= lue) +static int samsung_gpio_set(struct gpio_chip *gc, unsigned int offset, + int value) { struct samsung_pin_bank *bank =3D gpiochip_get_data(gc); struct samsung_pinctrl_drv_data *drvdata =3D bank->drvdata; unsigned long flags; + int ret; =20 - if (clk_enable(drvdata->pclk)) { + ret =3D clk_enable(drvdata->pclk); + if (ret) { dev_err(drvdata->dev, "failed to enable clock\n"); - return; + return ret; } =20 raw_spin_lock_irqsave(&bank->slock, flags); @@ -586,6 +589,8 @@ static void samsung_gpio_set(struct gpio_chip *gc, unsi= gned offset, int value) raw_spin_unlock_irqrestore(&bank->slock, flags); =20 clk_disable(drvdata->pclk); + + return 0; } =20 /* gpiolib gpio_get callback function */ @@ -1062,7 +1067,7 @@ static int samsung_gpio_set_config(struct gpio_chip *= gc, unsigned int offset, static const struct gpio_chip samsung_gpiolib_chip =3D { .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, - .set =3D samsung_gpio_set, + .set_rv =3D samsung_gpio_set, .get =3D samsung_gpio_get, .direction_input =3D samsung_gpio_direction_input, .direction_output =3D samsung_gpio_direction_output, --=20 2.45.2