From nobody Sun Feb 8 13:39:14 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 291EC5680; Fri, 25 Apr 2025 00:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745540102; cv=none; b=c8zpNkYpGOImfgA9kDByZPchWJtdo/xd1HEnvoLLQ5h3wANdetinLybR1V1WAaq/yfuvYG7wJ0oFDDB/vWn2DPF0Iwk3Dbd3TOz9+lo49rfhXpE5vfiD8IpVtEOsiM8Hp26heZrN5w9wBCaDClS5rFHaXwtQj3bPq3cOlEw+qgE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745540102; c=relaxed/simple; bh=LEH6DT/wn5jGkvB8nHGjnflhDNjglzGJsnEsmmfeOWc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Hc7SvcEVMuuTeY8f1bWZjV0rFfCNOSyGkh+4aROi26ELWkHW9oiWjGMQ4z9ZvvDn6rKh7tDtofvoTjLUjn0SDMXWt37DbNBLVAEVI1GNiM+Fr2rTtL/ZEUfWnAYrfFthKOo6gL2bXOGql3P6IW5CMPjHs/bOVATEuDz4GynxS2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SfXuIGvJ; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SfXuIGvJ" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2241053582dso25636175ad.1; Thu, 24 Apr 2025 17:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745540100; x=1746144900; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8MoUJYDZ/SRmAVUICYgMxGdg0xy9MgQEIECVATWiFcY=; b=SfXuIGvJ6Cp9sLWr5jMMKRvHkwij7E9Xphs7Ppp8ChYyVYOlB374rNmN4c6LvaAN/i 4WVbCNvM728QrNNqZ7nbI/oxjp5xxPFauV2WxbMsC5XbfhXV50TKv7db9rt5Ww6C9dEg K6nNkPkBTRcXHkG5IUWVp7Ba3IE+CvGSGLKFHzymjlEJDMteFr5sJhcWiosJPWGAkMk3 seE17dnNi17hikNoLM31RUzd9QXPYihkJfSk7ANghIWwwgEonkbqkFjd03yl/drBiqH9 KPYPB/fvOqGS++333iQWQN3j7UT702dagEPPpi/i9Yy3kBUaTtOTYYEGC2/FQ4Gumsp0 1iLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745540100; x=1746144900; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8MoUJYDZ/SRmAVUICYgMxGdg0xy9MgQEIECVATWiFcY=; b=wIe3lcwpAWN/N0n6u3QgXK3KzkOAw4czcwSwCoXdaCPmp+SsQNcPvC8as6lXyDOiId rP+Cc4o1p4oS4+ggxv8XuV3mi6h05CpsG/QTbDNs4sfN7TE3Whdu82xe8sJAVgvEbslt 3joO/zdMZEXe4BiMUNg6fBcZQcKYoqv/ed2kT/ZiVd4XerQ4zPTtmMWo17Xy1GpNZTXu Uszz7EIpgKf+e1y9dk+W+0Jdpc47zuJ0UwblWNXj8B0x+bxrtemz0nrG+uUHlmqoCPow CK+JVaOsg9B3QWHW1WknJGNn6KI1kGGAHftzk4nm6120h2jJonAym9WbyajoZGYc8Qu2 LH0A== X-Forwarded-Encrypted: i=1; AJvYcCVAAO7raU7klbNKsIu99AR/Kpw9m2AwEUUs+utxV9Tr48KipHzuig/ngr0PDGbavsGFwto0hl6iRcaiav4=@vger.kernel.org X-Gm-Message-State: AOJu0YzA+UB8H9dJtFiNcSb9rggsUxWWxKq+EuhZn5NaX8WaJFp2YUue xHmxk2ap38YzFIY9Q0Y53SIeFF/XgKZp3UIeGilBkRQNXqoMGH4gCVNNCpGQ X-Gm-Gg: ASbGnctm3EmmkDfzbLYtpePG0tMsiGpBGsNxBxNZXKYBFWpjEBNQitLrrlDZdUIzD/D 8XYSey+4jxeh1hXlG3lSKAtsgXtiCNMS0WyUmLBx6XkJuMATsnp0OYmlCs3LHANwJM/5w0ry6PJ luDsGWGdPGvfbDZS3VsXxNc7BN3FCvbmNlfC7f2i0Awip/kHL2kR3ajdk2oNp5PSWXw7V4bfFPF WN7Ef6yOT0/np9Z6YRuiS1oueL8dsevXYp8d4qFpybQ/dxoCtegPbyrSp+ZccAH97ZhEys/Pg9n SqFEw+JvkI76ZPClUdQQ7QKOEoTlYZKzMj4ADgpji/R9lcXRs94= X-Google-Smtp-Source: AGHT+IGi2/pFYaOAnRZ0D8zuO91uDzurcutU9R2dI6c0ESHw/lSvH7oOdqOqMZE6PT0lOu9u2MjARw== X-Received: by 2002:a17:902:d501:b0:224:5a8:ba29 with SMTP id d9443c01a7336-22dbf6409eemr4109745ad.43.1745540100170; Thu, 24 Apr 2025 17:15:00 -0700 (PDT) Received: from [192.168.0.110] ([189.101.161.220]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4dbdf7bsm20035165ad.87.2025.04.24.17.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 17:14:59 -0700 (PDT) From: Gustavo Silva Date: Thu, 24 Apr 2025 21:14:50 -0300 Subject: [PATCH 1/3] iio: imu: bmi270: add channel for step counter Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-bmi270-events-v1-1-a6c722673e5f@gmail.com> References: <20250424-bmi270-events-v1-0-a6c722673e5f@gmail.com> In-Reply-To: <20250424-bmi270-events-v1-0-a6c722673e5f@gmail.com> To: Alex Lanzano , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Gustavo Silva X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745540093; l=5828; i=gustavograzs@gmail.com; s=20250111; h=from:subject:message-id; bh=LEH6DT/wn5jGkvB8nHGjnflhDNjglzGJsnEsmmfeOWc=; b=CjzvHNUITCNkbk4YCp6BapasmezvRl49dB64oh8Z303EAK3Lxp+qITpK6VTWYWRFRYcNC6lIM 4hcVY/M0oBxBoKL63ciltPI+/KAn5e0pY92sCvvYX1YP1Wg6iXUzShS X-Developer-Key: i=gustavograzs@gmail.com; a=ed25519; pk=g2TFXpo1jMCOCN+rzVoM9NDFNfSMOgVyY0rlyvk4RTM= Add a channel for enabling/disabling the step counter, reading the number of steps and resetting the counter. Signed-off-by: Gustavo Silva Reviewed-by: Andy Shevchenko --- drivers/iio/imu/bmi270/bmi270_core.c | 127 +++++++++++++++++++++++++++++++= ++++ 1 file changed, 127 insertions(+) diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/= bmi270_core.c index a86be5af5ccb1f010f2282ee31c47f284c1bcc86..f09d8dead9df63df5ae8550cf47= 3b5573374955b 100644 --- a/drivers/iio/imu/bmi270/bmi270_core.c +++ b/drivers/iio/imu/bmi270/bmi270_core.c @@ -31,6 +31,8 @@ #define BMI270_INT_STATUS_1_REG 0x1d #define BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK GENMASK(7, 6) =20 +#define BMI270_SC_OUT_0_REG 0x1e + #define BMI270_INTERNAL_STATUS_REG 0x21 #define BMI270_INTERNAL_STATUS_MSG_MSK GENMASK(3, 0) #define BMI270_INTERNAL_STATUS_MSG_INIT_OK 0x01 @@ -39,6 +41,8 @@ =20 #define BMI270_TEMPERATURE_0_REG 0x22 =20 +#define BMI270_FEAT_PAGE_REG 0x2f + #define BMI270_ACC_CONF_REG 0x40 #define BMI270_ACC_CONF_ODR_MSK GENMASK(3, 0) #define BMI270_ACC_CONF_ODR_100HZ 0x08 @@ -90,6 +94,9 @@ #define BMI270_PWR_CTRL_ACCEL_EN_MSK BIT(2) #define BMI270_PWR_CTRL_TEMP_EN_MSK BIT(3) =20 +#define BMI270_STEP_SC26_RST_CNT_MSK BIT(10) +#define BMI270_STEP_SC26_EN_CNT_MSK BIT(12) + /* See datasheet section 4.6.14, Temperature Sensor */ #define BMI270_TEMP_OFFSET 11776 #define BMI270_TEMP_SCALE 1953125 @@ -111,6 +118,7 @@ struct bmi270_data { struct iio_trigger *trig; /* Protect device's private data from concurrent access */ struct mutex mutex; + int steps_enabled; =20 /* * Where IIO_DMA_MINALIGN may be larger than 8 bytes, align to @@ -282,6 +290,99 @@ static const struct bmi270_odr_item bmi270_odr_table[= ] =3D { }, }; =20 +enum bmi270_feature_reg_id { + BMI270_SC_26_REG, +}; + +struct bmi270_feature_reg { + u8 page; + u8 addr; +}; + +static const struct bmi270_feature_reg bmi270_feature_regs[] =3D { + [BMI270_SC_26_REG] =3D { + .page =3D 6, + .addr =3D 0x32, + }, +}; + +static int bmi270_write_feature_reg(struct bmi270_data *data, + enum bmi270_feature_reg_id id, + u16 val) +{ + const struct bmi270_feature_reg *reg =3D &bmi270_feature_regs[id]; + int ret; + + ret =3D regmap_write(data->regmap, BMI270_FEAT_PAGE_REG, reg->page); + if (ret) + return ret; + + return regmap_bulk_write(data->regmap, reg->addr, &val, sizeof(val)); +} + +static int bmi270_read_feature_reg(struct bmi270_data *data, + enum bmi270_feature_reg_id id, + u16 *val) +{ + const struct bmi270_feature_reg *reg =3D &bmi270_feature_regs[id]; + int ret; + + ret =3D regmap_write(data->regmap, BMI270_FEAT_PAGE_REG, reg->page); + if (ret) + return ret; + + return regmap_bulk_read(data->regmap, reg->addr, val, sizeof(*val)); +} + +static int bmi270_update_feature_reg(struct bmi270_data *data, + enum bmi270_feature_reg_id id, + u16 mask, u16 val) +{ + u16 reg_val; + int ret; + + ret =3D bmi270_read_feature_reg(data, id, ®_val); + if (ret) + return ret; + + set_mask_bits(®_val, mask, val); + + return bmi270_write_feature_reg(data, id, reg_val); +} + +static int bmi270_enable_steps(struct bmi270_data *data, int val) +{ + int ret; + + guard(mutex)(&data->mutex); + if (data->steps_enabled =3D=3D val) + return 0; + + ret =3D bmi270_update_feature_reg(data, BMI270_SC_26_REG, + BMI270_STEP_SC26_EN_CNT_MSK, + FIELD_PREP(BMI270_STEP_SC26_EN_CNT_MSK, + val ? 1 : 0)); + if (ret) + return ret; + + data->steps_enabled =3D val; + return 0; +} + +static int bmi270_read_steps(struct bmi270_data *data, int *val) +{ + __le16 steps_count; + int ret; + + ret =3D regmap_bulk_read(data->regmap, BMI270_SC_OUT_0_REG, &steps_count, + sizeof(steps_count)); + if (ret) + return ret; + + *val =3D sign_extend32(le16_to_cpu(steps_count), 15); + return IIO_VAL_INT; +} + static int bmi270_set_scale(struct bmi270_data *data, int chan_type, int u= scale) { int i; @@ -551,6 +652,8 @@ static int bmi270_read_raw(struct iio_dev *indio_dev, struct bmi270_data *data =3D iio_priv(indio_dev); =20 switch (mask) { + case IIO_CHAN_INFO_PROCESSED: + return bmi270_read_steps(data, val); case IIO_CHAN_INFO_RAW: if (!iio_device_claim_direct(indio_dev)) return -EBUSY; @@ -571,6 +674,10 @@ static int bmi270_read_raw(struct iio_dev *indio_dev, case IIO_CHAN_INFO_SAMP_FREQ: ret =3D bmi270_get_odr(data, chan->type, val, val2); return ret ? ret : IIO_VAL_INT_PLUS_MICRO; + case IIO_CHAN_INFO_ENABLE: + scoped_guard(mutex, &data->mutex) + *val =3D data->steps_enabled; + return IIO_VAL_INT; default: return -EINVAL; } @@ -596,6 +703,20 @@ static int bmi270_write_raw(struct iio_dev *indio_dev, ret =3D bmi270_set_odr(data, chan->type, val, val2); iio_device_release_direct(indio_dev); return ret; + case IIO_CHAN_INFO_ENABLE: + return bmi270_enable_steps(data, val); + case IIO_CHAN_INFO_PROCESSED: { + guard(mutex)(&data->mutex); + + if (val || !data->steps_enabled) + return -EINVAL; + + /* Clear step counter value */ + return bmi270_update_feature_reg(data, BMI270_SC_26_REG, + BMI270_STEP_SC26_RST_CNT_MSK, + FIELD_PREP(BMI270_STEP_SC26_RST_CNT_MSK, + 1)); + } default: return -EINVAL; } @@ -698,6 +819,12 @@ static const struct iio_chan_spec bmi270_channels[] = =3D { BIT(IIO_CHAN_INFO_OFFSET), .scan_index =3D -1, /* No buffer support */ }, + { + .type =3D IIO_STEPS, + .info_mask_separate =3D BIT(IIO_CHAN_INFO_ENABLE) | + BIT(IIO_CHAN_INFO_PROCESSED), + .scan_index =3D -1, /* No buffer support */ + }, IIO_CHAN_SOFT_TIMESTAMP(BMI270_SCAN_TIMESTAMP), }; =20 --=20 2.49.0 From nobody Sun Feb 8 13:39:14 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDC1CB65C; Fri, 25 Apr 2025 00:15:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745540106; cv=none; b=MkWtjvSxL+DSHwsbhIbQpfx0ugoCh+8ckuyDaiXfJKuWrBKBhY/FPgDgwzG8Onq9OmnoNPmp0G3cDQ7FuxvPAyXAM/Ks1RKCa0GnPt+xkxjXlf6AHFkJpTrBGJd0PBR2RxOvLDgIR3zsN5qbOeVecmL8rXsvvgXfOS2Fiy8bnS4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745540106; c=relaxed/simple; bh=zHH6jhOfgXoH9vf4rnFKZjdOnv/FXwzNXAMAqeGii5o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kXYj1+bGaTtDPhSe+c6G3ZC2Mw3YntIrd8sjVGDfWUzRGAlCpKnP6Dxrb10v5U/ezcdyC4rYnx0mQC0VwCb/AnE6xP0+BYS6I0jMGXgSNgESzGyhnQXmw+jk811ZDm7FYlQNoBTsEVEPSCJkZm1ksKJ5CII3xO68X3O7XMhLcdM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ajTuK8AF; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ajTuK8AF" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-227d6b530d8so18945915ad.3; Thu, 24 Apr 2025 17:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745540104; x=1746144904; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B+M33bLI0wVVdIT1YDu2HCDwy5r+huY0WGj/fLwU04A=; b=ajTuK8AF9go7Eog76crSNSTpuQRI+zCy6uPVDa+xJ214aLxBoq1ptU+cWaKmccxONW RFdGf0SzprNSH3de+vZ/uCRqG4BO7gp2fIVXVewJv3ksJpEc2n/fqlKHN/AahEZJatd0 tg6tLGl344fcL04eDuNG0126gHRVqxSHZy7jeY7uhE3yTytgrbqUzSLblLSsNxhSomgy /zHEBu7C5uEoDIG84kiFCJZkFJYISD1SfeVs+I6JydzKuZGo0VQ/Vz+r8p023wU9Iavq TMv7W5hW6mCv9CcF7WulT1+7nrq1WV53XUr1CF0GJomXkVs1m4QiX1KAzfYG1u3JkU37 smDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745540104; x=1746144904; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B+M33bLI0wVVdIT1YDu2HCDwy5r+huY0WGj/fLwU04A=; b=Wn6DLAhM5eRGXAFamHWZYKnAziSUdnm5rZmjXfkXmeYYrZDuR+JxqptVAqF1f1suUH MmNcN9M7fvW0Ej24cZ3GhN3rjRAmKRUsNpkkIfBIIMs3tFDyFvOLOpXVdUq4hJZB24A0 u/BSBYr60hcT6dbP6BgZTr5dypc7daXX2thwdEzEpCxrz9PhilyW1a/8KlEzOA5cZs3f Ke8rG3sRbmDA2lTjrv6B9JAgoOmFzLAjynaz3UlOJdl966oo2tND3dqptnLDcD6xGNjM B1s7t62MrtvnmmjEK4AOmnvFxrQfh0j+l9qEj09NDJ1gzGBVkuCEyVGn5bSXs409U4PH QoMw== X-Forwarded-Encrypted: i=1; AJvYcCUc3yWblOpGfFgA2ITpVE5nS+8vzBOlWHmuFv+HF5mMiuy2nC74XV+jnKnA/LVte1Rsm+PnJPuXxnfvNQI=@vger.kernel.org X-Gm-Message-State: AOJu0YxCwZ4YTs24GFDi9UXgB769LbNu5opiKqJwbW31GDBsBxlCr9kX rNQo1JFeY4fLyUHcEKRM85/3+LLDvYntqxBJ4JGjhRwjUaiqzIoerb6gQ5qY X-Gm-Gg: ASbGncu1Ax0Z0gKIp05GNT7RiqwV81drF/IePJIOTiqQNOWsPEV/jdrQlmZujXXck9K qYh9Cu8x101DK32LzURbnwYWFAQN4p575Y+6Ax7mbxgmk2vt9M/NyHZpm+A2a9woxUKaExLTqt8 Lg/7gGwH31iAUrPq4io7ssIXIrmERPP79824KTadfhOsFOyaRC/3UTIIHNHrwtNISqGbp1D0/x6 ERR8eIpHRTXMGV+qsk+r8MreN0H73niHmfu+IHJeFppDoEb/1PQcL6a9FRrTfHcTH/SgbpGcDh2 LCut3yZ5Z8cuzfmxX79qB0hOy02PrcxWhWlil1Cq1QunXAI4z5CfoUskne5OeA== X-Google-Smtp-Source: AGHT+IEIXbq1jy/bwqfBna81oPZg0yRJzTUqsUFjc9MRssA+2uMsgJkyJW3XlKOkkLc0krU5mvQWoA== X-Received: by 2002:a17:903:40c8:b0:224:1579:5e8e with SMTP id d9443c01a7336-22dbf5d9efemr4231775ad.1.1745540103918; Thu, 24 Apr 2025 17:15:03 -0700 (PDT) Received: from [192.168.0.110] ([189.101.161.220]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4dbdf7bsm20035165ad.87.2025.04.24.17.15.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 17:15:03 -0700 (PDT) From: Gustavo Silva Date: Thu, 24 Apr 2025 21:14:51 -0300 Subject: [PATCH 2/3] iio: imu: bmi270: add step counter watermark event Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-bmi270-events-v1-2-a6c722673e5f@gmail.com> References: <20250424-bmi270-events-v1-0-a6c722673e5f@gmail.com> In-Reply-To: <20250424-bmi270-events-v1-0-a6c722673e5f@gmail.com> To: Alex Lanzano , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Gustavo Silva X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745540093; l=7473; i=gustavograzs@gmail.com; s=20250111; h=from:subject:message-id; bh=zHH6jhOfgXoH9vf4rnFKZjdOnv/FXwzNXAMAqeGii5o=; b=a3YmsM5H2UC0rETt39v+8TfSZUx+t6oqJldVV6girXONCFCl6AY+U0EZnNKp+xR5NEuWn/BfO rm4Z1wrYq/lCKs+xjQ3JPwV5mPZxv4UEDMwPPONeMWjYpMoV0Gl8JQX X-Developer-Key: i=gustavograzs@gmail.com; a=ed25519; pk=g2TFXpo1jMCOCN+rzVoM9NDFNfSMOgVyY0rlyvk4RTM= Add support for generating events when the step counter reaches the configurable watermark. Signed-off-by: Gustavo Silva Reviewed-by: Andy Shevchenko --- drivers/iio/imu/bmi270/bmi270_core.c | 168 +++++++++++++++++++++++++++++++= +++- 1 file changed, 165 insertions(+), 3 deletions(-) diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/= bmi270_core.c index f09d8dead9df63df5ae8550cf473b5573374955b..07a24ed9a4edabeafd98a746ba0= 9469f9e41c38a 100644 --- a/drivers/iio/imu/bmi270/bmi270_core.c +++ b/drivers/iio/imu/bmi270/bmi270_core.c @@ -8,6 +8,7 @@ #include #include =20 +#include #include #include #include @@ -28,6 +29,9 @@ #define BMI270_ACCEL_X_REG 0x0c #define BMI270_ANG_VEL_X_REG 0x12 =20 +#define BMI270_INT_STATUS_0_REG 0x1c +#define BMI270_INT_STATUS_0_STEP_CNT_MSK BIT(1) + #define BMI270_INT_STATUS_1_REG 0x1d #define BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK GENMASK(7, 6) =20 @@ -74,6 +78,10 @@ #define BMI270_INT_LATCH_REG 0x55 #define BMI270_INT_LATCH_REG_MSK BIT(0) =20 +#define BMI270_INT1_MAP_FEAT_REG 0x56 +#define BMI270_INT2_MAP_FEAT_REG 0x57 +#define BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK BIT(1) + #define BMI270_INT_MAP_DATA_REG 0x58 #define BMI270_INT_MAP_DATA_DRDY_INT1_MSK BIT(2) #define BMI270_INT_MAP_DATA_DRDY_INT2_MSK BIT(6) @@ -94,6 +102,7 @@ #define BMI270_PWR_CTRL_ACCEL_EN_MSK BIT(2) #define BMI270_PWR_CTRL_TEMP_EN_MSK BIT(3) =20 +#define BMI270_STEP_SC26_WTRMRK_MSK GENMASK(9, 0) #define BMI270_STEP_SC26_RST_CNT_MSK BIT(10) #define BMI270_STEP_SC26_EN_CNT_MSK BIT(12) =20 @@ -119,6 +128,7 @@ struct bmi270_data { /* Protect device's private data from concurrent access */ struct mutex mutex; int steps_enabled; + unsigned int feature_events; =20 /* * Where IIO_DMA_MINALIGN may be larger than 8 bytes, align to @@ -383,6 +393,42 @@ static int bmi270_read_steps(struct bmi270_data *data,= int *val) return IIO_VAL_INT; } =20 +static int bmi270_int_map_reg(enum bmi270_irq_pin pin) +{ + switch (pin) { + case BMI270_IRQ_INT1: + return BMI270_INT1_MAP_FEAT_REG; + case BMI270_IRQ_INT2: + return BMI270_INT2_MAP_FEAT_REG; + default: + return -EINVAL; + } +} + +static int bmi270_step_wtrmrk_en(struct bmi270_data *data, bool state) +{ + int ret, reg, field_value; + + guard(mutex)(&data->mutex); + if (!data->steps_enabled) + return -EINVAL; + + reg =3D bmi270_int_map_reg(data->irq_pin); + if (reg < 0) + return -EINVAL; + + field_value =3D FIELD_PREP(BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK, state= ); + ret =3D regmap_update_bits(data->regmap, reg, + BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK, + field_value); + if (ret) + return ret; + + set_mask_bits(&data->feature_events, + BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK, field_value); + return 0; +} + static int bmi270_set_scale(struct bmi270_data *data, int chan_type, int u= scale) { int i; @@ -539,19 +585,32 @@ static irqreturn_t bmi270_irq_thread_handler(int irq,= void *private) { struct iio_dev *indio_dev =3D private; struct bmi270_data *data =3D iio_priv(indio_dev); - unsigned int status; + unsigned int status0, status1; + s64 timestamp =3D iio_get_time_ns(indio_dev); int ret; =20 scoped_guard(mutex, &data->mutex) { + ret =3D regmap_read(data->regmap, BMI270_INT_STATUS_0_REG, + &status0); + if (ret) + return IRQ_NONE; + ret =3D regmap_read(data->regmap, BMI270_INT_STATUS_1_REG, - &status); + &status1); if (ret) return IRQ_NONE; } =20 - if (FIELD_GET(BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK, status)) + if (FIELD_GET(BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK, status1)) iio_trigger_poll_nested(data->trig); =20 + if (FIELD_GET(BMI270_INT_STATUS_0_STEP_CNT_MSK, status0)) + iio_push_event(indio_dev, IIO_MOD_EVENT_CODE(IIO_STEPS, 0, + IIO_NO_MOD, + IIO_EV_TYPE_CHANGE, + IIO_EV_DIR_NONE), + timestamp); + return IRQ_HANDLED; } =20 @@ -761,10 +820,111 @@ static int bmi270_read_avail(struct iio_dev *indio_d= ev, } } =20 +static int bmi270_write_event_config(struct iio_dev *indio_dev, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, bool state) +{ + struct bmi270_data *data =3D iio_priv(indio_dev); + + switch (type) { + case IIO_EV_TYPE_CHANGE: + return bmi270_step_wtrmrk_en(data, state); + default: + return -EINVAL; + } + + return 0; +} + +static int bmi270_read_event_config(struct iio_dev *indio_dev, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir) +{ + struct bmi270_data *data =3D iio_priv(indio_dev); + + guard(mutex)(&data->mutex); + + switch (chan->type) { + case IIO_STEPS: + return FIELD_GET(BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK, + data->feature_events) ? 1 : 0; + default: + return -EINVAL; + } +} + +static int bmi270_write_event_value(struct iio_dev *indio_dev, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, + enum iio_event_info info, + int val, int val2) +{ + struct bmi270_data *data =3D iio_priv(indio_dev); + unsigned int raw; + + guard(mutex)(&data->mutex); + + switch (type) { + case IIO_EV_TYPE_CHANGE: + if (!in_range(val, 0, 20461)) + return -EINVAL; + + raw =3D val / 20; + return bmi270_update_feature_reg(data, BMI270_SC_26_REG, + BMI270_STEP_SC26_WTRMRK_MSK, + FIELD_PREP(BMI270_STEP_SC26_WTRMRK_MSK, + raw)); + default: + return -EINVAL; + } +} + +static int bmi270_read_event_value(struct iio_dev *indio_dev, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, + enum iio_event_info info, + int *val, int *val2) +{ + struct bmi270_data *data =3D iio_priv(indio_dev); + unsigned int raw; + u16 reg_val; + int ret; + + guard(mutex)(&data->mutex); + + switch (type) { + case IIO_EV_TYPE_CHANGE: + ret =3D bmi270_read_feature_reg(data, BMI270_SC_26_REG, ®_val); + if (ret) + return ret; + + raw =3D FIELD_GET(BMI270_STEP_SC26_WTRMRK_MSK, reg_val); + *val =3D raw * 20; + return IIO_VAL_INT; + default: + return -EINVAL; + } +} + +static const struct iio_event_spec bmi270_step_wtrmrk_event =3D { + .type =3D IIO_EV_TYPE_CHANGE, + .dir =3D IIO_EV_DIR_NONE, + .mask_shared_by_type =3D BIT(IIO_EV_INFO_ENABLE) | + BIT(IIO_EV_INFO_VALUE), +}; + static const struct iio_info bmi270_info =3D { .read_raw =3D bmi270_read_raw, .write_raw =3D bmi270_write_raw, .read_avail =3D bmi270_read_avail, + .write_event_config =3D bmi270_write_event_config, + .read_event_config =3D bmi270_read_event_config, + .write_event_value =3D bmi270_write_event_value, + .read_event_value =3D bmi270_read_event_value, }; =20 #define BMI270_ACCEL_CHANNEL(_axis) { \ @@ -824,6 +984,8 @@ static const struct iio_chan_spec bmi270_channels[] =3D= { .info_mask_separate =3D BIT(IIO_CHAN_INFO_ENABLE) | BIT(IIO_CHAN_INFO_PROCESSED), .scan_index =3D -1, /* No buffer support */ + .event_spec =3D &bmi270_step_wtrmrk_event, + .num_event_specs =3D 1, }, IIO_CHAN_SOFT_TIMESTAMP(BMI270_SCAN_TIMESTAMP), }; --=20 2.49.0 From nobody Sun Feb 8 13:39:14 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95BEC1BC3F; Fri, 25 Apr 2025 00:15:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745540110; cv=none; b=q5pkZktjU+BdXUOH+2NgqvC/a1cGlqGbszG2I68Bsd5xDml2trSjJKAP7uysAZZKdZxnjXWqkKa45/+Jjd+bCztNohCVeut4eAUAI00aYMhsOEcimKXZ+R54WspDlze8CK6prAFNpBiTOHCps1/hTtXC/WEkxa4mjmcq2Auu+3M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745540110; c=relaxed/simple; bh=GxkfZBL3+JBHmybeeBC04odAus0uhAxbhMV3diS2clc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kJqPFKzFHO8RMnkKGX84ErPKsp4qK0EgD3p8400BrcoaQKbA/0VL9Utd8a8JS/ILdAv4qUFWzPcDUgURNG+86uJ9z+jv9SQCaI1vPYGefKPw4RZQF4P8z3h3Uk0m22RLtpDmGSZrRVSOiGnnrUNe/jMQKXImzx5uY6m3DhCVvQI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hDnnLBn1; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hDnnLBn1" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-22401f4d35aso20529305ad.2; Thu, 24 Apr 2025 17:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745540107; x=1746144907; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DXViPwzj2FZuhGbILH1kWVaUulYxZzoaNpxLwhfR7U0=; b=hDnnLBn1nU5sXA34ovV7v+hM8yIu60HDL6/JzHG5yHxb0uvSaadPrXRHj6WP7n2m0E 84uGW9ZCsEaJVigj8NTXZkKQ4sWaTCrueTap8NrEtjWzuCd6aHCtZ9C0o+Uomu+Awl8J JuSG+IISU8myp5FrQObXPhjq6pWvYWM8mK6YSd0bSmu7nSkyT5jsQaX1GVebtuoop2Cb ElHIDa5a2R0EoNuT95pixClamjbs8FFmnWvU8qc8sTtNWoFqOi9LvwV3amta+74mYxmq X/JwkWEv+jeqO/IpOYsv1JrLzWBr5UEJgI1bdR5Ajo2cEMnN2LeO+8Dm2nvn9nW1XnnM 0qiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745540107; x=1746144907; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DXViPwzj2FZuhGbILH1kWVaUulYxZzoaNpxLwhfR7U0=; b=BAexamzMjjNqA9L6oGnXRWQ5FuUOpy0XPMudI+H21y8hOtznpPndcfyluOi4vdflc7 jgXJjv1FHAM3A9qVLrg0yubwBm0zgR2gtI50noxqLtqbB6y++puUgKfqushbsnY4k4rD VtDjpk5xKqSkh+KlRoqp6GTqAf6e8WB8sdLy7qRT/oq1RxYmgwunvMdPgjx4h3hI6QKS 4h06i/H/rG0v9Gk9ifcp1w9lU4E8XXboR6WHo1FZYUed+mj+fRQXxPX2lpQRO2SWBQoS sEZxlf6De7AFOHmHXx8d2uCF5DTlXmaU9QycKmCITq1G1myXtB5D/f9zMihk0OygiwcR luPg== X-Forwarded-Encrypted: i=1; AJvYcCWiiA0BXXCCT9pflM9PPAdmOfve3T4jT+o3RSyujBrvcGkqHeoS4U3iPj/ZVdZnxaL7dtJo5o0/rT/LKKo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxykms+aU5u91oye49lBlKUnZog4xz0kjnEKEhXqMKts7eHooMN rKtnWeOOJ5369r+NWO+ucNf+o0k0480GsKaAXMjuNs8hG6x3X+2JjJzC5DnK X-Gm-Gg: ASbGncsSmpns4EAafpZnPkvRuyElQuAi413kX3dmHMxGGMvLaqRgtxOhMiSTqBWG9GZ yYPOhyz08Ey3x2caUmNL38m9lzLfmj5wVag1cjZeCOZsXmR9JMv1G1+QHqivtP8A7LI/DV1wkuG mqAAklwyc28kF9yDXd835kNQs95q1BmRV3wEpipA5Fncf/lXucysKcKWGEamQ/zTgG+dxMCy9oU njrnY7BrXMAST0/NsNfD7ZX5Gzffu6OEa8e+BEvvYVp4+GSKKPV4NnI77jAkQJwUCgjDwftxtfk iBJGXW/5AD7l/Gd2g5gel51j2hWIPD1k4WjVDdrVFt3zbtfGD4w= X-Google-Smtp-Source: AGHT+IFOWv3z5EMfUZ9Whk2a4a0qzwE35lPoBasP6pmakoNOZKI5yFrPcoDp4ZSxhlkEX2iZ8k2w9w== X-Received: by 2002:a17:902:f691:b0:22c:35c5:e30e with SMTP id d9443c01a7336-22dbf5e9defmr3973665ad.13.1745540107479; Thu, 24 Apr 2025 17:15:07 -0700 (PDT) Received: from [192.168.0.110] ([189.101.161.220]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4dbdf7bsm20035165ad.87.2025.04.24.17.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 17:15:07 -0700 (PDT) From: Gustavo Silva Date: Thu, 24 Apr 2025 21:14:52 -0300 Subject: [PATCH 3/3] iio: imu: bmi270: add support for motion events Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250424-bmi270-events-v1-3-a6c722673e5f@gmail.com> References: <20250424-bmi270-events-v1-0-a6c722673e5f@gmail.com> In-Reply-To: <20250424-bmi270-events-v1-0-a6c722673e5f@gmail.com> To: Alex Lanzano , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Gustavo Silva X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745540093; l=11166; i=gustavograzs@gmail.com; s=20250111; h=from:subject:message-id; bh=GxkfZBL3+JBHmybeeBC04odAus0uhAxbhMV3diS2clc=; b=ZU/NwnOWvj//PHgf4Q3otjqoUqQSm+YI1HbVKcIZ13l5JIG+j6nYLntOw4rzDf7eEG9dIZeU8 mV8E9sg9QFiCqh/T4r41yOCcvLLg+WVqg2GEgOjq943uh000pTeq80g X-Developer-Key: i=gustavograzs@gmail.com; a=ed25519; pk=g2TFXpo1jMCOCN+rzVoM9NDFNfSMOgVyY0rlyvk4RTM= Add support for any-motion/no-motion events based on acceleration slope on each axis. Threshold and duration can be configured from userspace. Signed-off-by: Gustavo Silva --- drivers/iio/imu/bmi270/bmi270_core.c | 230 +++++++++++++++++++++++++++++++= +++- 1 file changed, 229 insertions(+), 1 deletion(-) diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/= bmi270_core.c index 07a24ed9a4edabeafd98a746ba09469f9e41c38a..57734f9cf5906aa77b7a14dfba7= 93559a817c1e7 100644 --- a/drivers/iio/imu/bmi270/bmi270_core.c +++ b/drivers/iio/imu/bmi270/bmi270_core.c @@ -31,6 +31,8 @@ =20 #define BMI270_INT_STATUS_0_REG 0x1c #define BMI270_INT_STATUS_0_STEP_CNT_MSK BIT(1) +#define BMI270_INT_STATUS_0_NOMOTION_MSK BIT(5) +#define BMI270_INT_STATUS_0_MOTION_MSK BIT(6) =20 #define BMI270_INT_STATUS_1_REG 0x1d #define BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK GENMASK(7, 6) @@ -81,6 +83,8 @@ #define BMI270_INT1_MAP_FEAT_REG 0x56 #define BMI270_INT2_MAP_FEAT_REG 0x57 #define BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK BIT(1) +#define BMI270_INT_MAP_FEAT_NOMOTION_MSK BIT(5) +#define BMI270_INT_MAP_FEAT_ANYMOTION_MSK BIT(6) =20 #define BMI270_INT_MAP_DATA_REG 0x58 #define BMI270_INT_MAP_DATA_DRDY_INT1_MSK BIT(2) @@ -106,10 +110,25 @@ #define BMI270_STEP_SC26_RST_CNT_MSK BIT(10) #define BMI270_STEP_SC26_EN_CNT_MSK BIT(12) =20 +#define BMI270_FEAT_MOTION_DURATION_MSK GENMASK(12, 0) +#define BMI270_FEAT_MOTION_XYZ_MSK GENMASK(15, 13) +#define BMI270_FEAT_MOTION_THRESHOLD_MSK GENMASK(10, 0) +#define BMI270_FEAT_MOTION_OUT_CONF_MSK GENMASK(14, 11) +#define BMI270_FEAT_MOTION_ENABLE_MSK BIT(15) + +#define BMI270_MOTION_XYZ_MSK GENMASK(2, 0) + +#define BMI270_MOTION_THRES_SCALE GENMASK(10, 0) +#define BMI270_MOTION_DURAT_SCALE 50 + /* See datasheet section 4.6.14, Temperature Sensor */ #define BMI270_TEMP_OFFSET 11776 #define BMI270_TEMP_SCALE 1953125 =20 +#define BMI270_INT_MICRO_TO_RAW(val, val2, scale) ((val) * (scale) + \ + ((val2) * (scale)) / MEGA) +#define BMI270_RAW_TO_MICRO(raw, scale) ((((raw) % (scale)) * MEGA) / scal= e) + #define BMI260_INIT_DATA_FILE "bmi260-init-data.fw" #define BMI270_INIT_DATA_FILE "bmi270-init-data.fw" =20 @@ -301,6 +320,13 @@ static const struct bmi270_odr_item bmi270_odr_table[= ] =3D { }; =20 enum bmi270_feature_reg_id { + /* Page 1 registers */ + BMI270_ANYMO1_REG, + BMI270_ANYMO2_REG, + /* Page 2 registers */ + BMI270_NOMO1_REG, + BMI270_NOMO2_REG, + /* Page 6 registers */ BMI270_SC_26_REG, }; =20 @@ -310,6 +336,22 @@ struct bmi270_feature_reg { }; =20 static const struct bmi270_feature_reg bmi270_feature_regs[] =3D { + [BMI270_ANYMO1_REG] =3D { + .page =3D 1, + .addr =3D 0x3c, + }, + [BMI270_ANYMO2_REG] =3D { + .page =3D 1, + .addr =3D 0x3e, + }, + [BMI270_NOMO1_REG] =3D { + .page =3D 2, + .addr =3D 0x30, + }, + [BMI270_NOMO2_REG] =3D { + .page =3D 2, + .addr =3D 0x32, + }, [BMI270_SC_26_REG] =3D { .page =3D 6, .addr =3D 0x32, @@ -426,6 +468,72 @@ static int bmi270_step_wtrmrk_en(struct bmi270_data *d= ata, bool state) =20 set_mask_bits(&data->feature_events, BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK, field_value); + + return 0; +} + +static int bmi270_motion_config_reg(enum iio_event_direction dir) +{ + switch (dir) { + case IIO_EV_DIR_RISING: + return BMI270_ANYMO1_REG; + case IIO_EV_DIR_FALLING: + return BMI270_NOMO1_REG; + default: + return -EINVAL; + } +} + +static int bmi270_motion_event_en(struct bmi270_data *data, + enum iio_event_direction dir, bool state) +{ + int ret, config1, config2, irq_reg; + int irq_msk, irq_field_val; + + irq_reg =3D bmi270_int_map_reg(data->irq_pin); + if (irq_reg < 0) + return -EINVAL; + + switch (dir) { + case IIO_EV_DIR_RISING: + config1 =3D BMI270_ANYMO1_REG; + config2 =3D BMI270_ANYMO2_REG; + irq_msk =3D BMI270_INT_MAP_FEAT_ANYMOTION_MSK; + irq_field_val =3D FIELD_PREP(BMI270_INT_MAP_FEAT_ANYMOTION_MSK, + state); + break; + case IIO_EV_DIR_FALLING: + config1 =3D BMI270_NOMO1_REG; + config2 =3D BMI270_NOMO2_REG; + irq_msk =3D BMI270_INT_MAP_FEAT_NOMOTION_MSK; + irq_field_val =3D FIELD_PREP(BMI270_INT_MAP_FEAT_NOMOTION_MSK, + state); + break; + default: + return -EINVAL; + } + + guard(mutex)(&data->mutex); + ret =3D bmi270_update_feature_reg(data, config1, + BMI270_FEAT_MOTION_XYZ_MSK, + FIELD_PREP(BMI270_FEAT_MOTION_XYZ_MSK, + state ? BMI270_MOTION_XYZ_MSK : 0)); + if (ret) + return ret; + + ret =3D bmi270_update_feature_reg(data, config2, + BMI270_FEAT_MOTION_ENABLE_MSK, + FIELD_PREP(BMI270_FEAT_MOTION_ENABLE_MSK, + state)); + if (ret) + return ret; + + ret =3D regmap_update_bits(data->regmap, irq_reg, irq_msk, irq_field_val); + if (ret) + return ret; + + set_mask_bits(&data->feature_events, irq_msk, irq_field_val); + return 0; } =20 @@ -604,6 +712,20 @@ static irqreturn_t bmi270_irq_thread_handler(int irq, = void *private) if (FIELD_GET(BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK, status1)) iio_trigger_poll_nested(data->trig); =20 + if (FIELD_GET(BMI270_INT_STATUS_0_MOTION_MSK, status0)) + iio_push_event(indio_dev, IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, + IIO_MOD_X_OR_Y_OR_Z, + IIO_EV_TYPE_MAG, + IIO_EV_DIR_RISING), + timestamp); + + if (FIELD_GET(BMI270_INT_STATUS_0_NOMOTION_MSK, status0)) + iio_push_event(indio_dev, IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, + IIO_MOD_X_OR_Y_OR_Z, + IIO_EV_TYPE_MAG, + IIO_EV_DIR_FALLING), + timestamp); + if (FIELD_GET(BMI270_INT_STATUS_0_STEP_CNT_MSK, status0)) iio_push_event(indio_dev, IIO_MOD_EVENT_CODE(IIO_STEPS, 0, IIO_NO_MOD, @@ -820,6 +942,20 @@ static int bmi270_read_avail(struct iio_dev *indio_dev, } } =20 +static IIO_CONST_ATTR(in_accel_mag_value_available, "[0.0 0.00049 1.0]"); + +static IIO_CONST_ATTR(in_accel_mag_period_available, "[0.0 0.02 162.0]"); + +static struct attribute *bmi270_event_attributes[] =3D { + &iio_const_attr_in_accel_mag_value_available.dev_attr.attr, + &iio_const_attr_in_accel_mag_period_available.dev_attr.attr, + NULL +}; + +static const struct attribute_group bmi270_event_attribute_group =3D { + .attrs =3D bmi270_event_attributes, +}; + static int bmi270_write_event_config(struct iio_dev *indio_dev, const struct iio_chan_spec *chan, enum iio_event_type type, @@ -828,6 +964,8 @@ static int bmi270_write_event_config(struct iio_dev *in= dio_dev, struct bmi270_data *data =3D iio_priv(indio_dev); =20 switch (type) { + case IIO_EV_TYPE_MAG: + return bmi270_motion_event_en(data, dir, state); case IIO_EV_TYPE_CHANGE: return bmi270_step_wtrmrk_en(data, state); default: @@ -847,6 +985,17 @@ static int bmi270_read_event_config(struct iio_dev *in= dio_dev, guard(mutex)(&data->mutex); =20 switch (chan->type) { + case IIO_ACCEL: + switch (dir) { + case IIO_EV_DIR_RISING: + return FIELD_GET(BMI270_INT_MAP_FEAT_ANYMOTION_MSK, + data->feature_events) ? 1 : 0; + case IIO_EV_DIR_FALLING: + return FIELD_GET(BMI270_INT_MAP_FEAT_NOMOTION_MSK, + data->feature_events) ? 1 : 0; + default: + return -EINVAL; + } case IIO_STEPS: return FIELD_GET(BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK, data->feature_events) ? 1 : 0; @@ -864,10 +1013,42 @@ static int bmi270_write_event_value(struct iio_dev *= indio_dev, { struct bmi270_data *data =3D iio_priv(indio_dev); unsigned int raw; + int reg; =20 guard(mutex)(&data->mutex); =20 switch (type) { + case IIO_EV_TYPE_MAG: + reg =3D bmi270_motion_config_reg(dir); + if (reg < 0) + return -EINVAL; + + switch (info) { + case IIO_EV_INFO_VALUE: + if (!in_range(val, 0, 1)) + return -EINVAL; + + raw =3D BMI270_INT_MICRO_TO_RAW(val, val2, + BMI270_MOTION_THRES_SCALE); + + return bmi270_update_feature_reg(data, reg, + BMI270_FEAT_MOTION_THRESHOLD_MSK, + FIELD_PREP(BMI270_FEAT_MOTION_THRESHOLD_MSK, + raw)); + case IIO_EV_INFO_PERIOD: + if (!in_range(val, 0, 163)) + return -EINVAL; + + raw =3D BMI270_INT_MICRO_TO_RAW(val, val2, + BMI270_MOTION_DURAT_SCALE); + + return bmi270_update_feature_reg(data, reg, + BMI270_FEAT_MOTION_DURATION_MSK, + FIELD_PREP(BMI270_FEAT_MOTION_DURATION_MSK, + raw)); + default: + return -EINVAL; + } case IIO_EV_TYPE_CHANGE: if (!in_range(val, 0, 20461)) return -EINVAL; @@ -891,12 +1072,39 @@ static int bmi270_read_event_value(struct iio_dev *i= ndio_dev, { struct bmi270_data *data =3D iio_priv(indio_dev); unsigned int raw; + int ret, reg; u16 reg_val; - int ret; =20 guard(mutex)(&data->mutex); =20 switch (type) { + case IIO_EV_TYPE_MAG: + reg =3D bmi270_motion_config_reg(dir); + if (reg < 0) + return -EINVAL; + + switch (info) { + case IIO_EV_INFO_VALUE: + ret =3D bmi270_read_feature_reg(data, reg, ®_val); + if (ret) + return ret; + + raw =3D FIELD_GET(BMI270_FEAT_MOTION_THRESHOLD_MSK, reg_val); + *val =3D raw / BMI270_MOTION_THRES_SCALE; + *val2 =3D BMI270_RAW_TO_MICRO(raw, BMI270_MOTION_THRES_SCALE); + return IIO_VAL_INT_PLUS_MICRO; + case IIO_EV_INFO_PERIOD: + ret =3D bmi270_read_feature_reg(data, reg, ®_val); + if (ret) + return ret; + + raw =3D FIELD_GET(BMI270_FEAT_MOTION_DURATION_MSK, reg_val); + *val =3D raw / BMI270_MOTION_DURAT_SCALE; + *val2 =3D BMI270_RAW_TO_MICRO(raw, BMI270_MOTION_DURAT_SCALE); + return IIO_VAL_INT_PLUS_MICRO; + default: + return -EINVAL; + } case IIO_EV_TYPE_CHANGE: ret =3D bmi270_read_feature_reg(data, BMI270_SC_26_REG, ®_val); if (ret) @@ -917,6 +1125,23 @@ static const struct iio_event_spec bmi270_step_wtrmrk= _event =3D { BIT(IIO_EV_INFO_VALUE), }; =20 +static const struct iio_event_spec bmi270_accel_event[] =3D { + { + .type =3D IIO_EV_TYPE_MAG, + .dir =3D IIO_EV_DIR_FALLING, + .mask_shared_by_type =3D BIT(IIO_EV_INFO_VALUE) | + BIT(IIO_EV_INFO_PERIOD) | + BIT(IIO_EV_INFO_ENABLE), + }, + { + .type =3D IIO_EV_TYPE_MAG, + .dir =3D IIO_EV_DIR_RISING, + .mask_shared_by_type =3D BIT(IIO_EV_INFO_VALUE) | + BIT(IIO_EV_INFO_PERIOD) | + BIT(IIO_EV_INFO_ENABLE), + }, +}; + static const struct iio_info bmi270_info =3D { .read_raw =3D bmi270_read_raw, .write_raw =3D bmi270_write_raw, @@ -925,6 +1150,7 @@ static const struct iio_info bmi270_info =3D { .read_event_config =3D bmi270_read_event_config, .write_event_value =3D bmi270_write_event_value, .read_event_value =3D bmi270_read_event_value, + .event_attrs =3D &bmi270_event_attribute_group, }; =20 #define BMI270_ACCEL_CHANNEL(_axis) { \ @@ -944,6 +1170,8 @@ static const struct iio_info bmi270_info =3D { .storagebits =3D 16, \ .endianness =3D IIO_LE, \ }, \ + .event_spec =3D bmi270_accel_event, \ + .num_event_specs =3D ARRAY_SIZE(bmi270_accel_event), \ } =20 #define BMI270_ANG_VEL_CHANNEL(_axis) { \ --=20 2.49.0