From nobody Fri Dec 19 18:45:01 2025 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BF941E9915 for ; Wed, 23 Apr 2025 08:53:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398403; cv=none; b=B1g7xNOeIZkVThHfRkGM4vdrBirgYyvOyzdOSp3Ofv9vbHVzcIN2rSFe7UaFGoHbd4jBGdJ+/v9BCaidBYOpvMH+BUHO8JwLtFbuZbYuQxHGk+D2KzxSeYsPcTci3o8yyF7Ky05isJY0BhLPfJIOr2UUMT4jFUnMXvQzP8TeyJs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398403; c=relaxed/simple; bh=plbpc31rVrOD0KMkWiMy9DSCysG2bPp4EWpOgbNVk+g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=O7ZrPRB5Uqkfd/Cs0WDe3jChrEXvP4Vc6UkM+f6LV3OfUUks8auEj9I3XIT+5YglkIkDp/rTUawxMVqBi1GFisLin1bszcqHyiG68CFduCQ0hkJ/W4fvMa6LDMW99Ww9chL3pBELHa6sUfxM+6FN0TNnns1sMbXRdEdaGiF3gLw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=ewCvSt2H; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="ewCvSt2H" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-30155bbbed9so4672669a91.1 for ; Wed, 23 Apr 2025 01:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745398401; x=1746003201; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l3iCEA8tjYiThU7Rin4dKsTFv6XsSOzMIb0/FuGpw2E=; b=ewCvSt2HvDIyS5lDVc6vzN9u34M+s2cPVvmhImjb67c1Qs8YQneLmsIe2P7QI+W7k/ Dtt+LoSJtn8u2CZAn9rDzt1/d1SH3kwUz2EmNjsLrv0fKLSe1uQtnjcvOKBsaAT9qJD5 pgoEKq/yYaBBSQc8WxgAZl4Lt1XJakJ1ZT8SLxI2/K14Lg1B2VkqSrTLrm048wvSI2m3 1VnXOaUDRjg7mnaAsZMoFLrEz7iQpAnCZ+k/8igg7iwgoX9pIMtFK6Jy4Mx5T1lvmr2n SwyCMH84po+WVX+k4p8Z0DTQcRvkj3byQxFqp15rugz2UYpsy5bk1IuCqn0qMTWvzTsE xcng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398401; x=1746003201; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l3iCEA8tjYiThU7Rin4dKsTFv6XsSOzMIb0/FuGpw2E=; b=HxNZOJEUnCOqfv4gRaydazc1FoJKH45EtJllzJP3T+SOuuq7+eSU6HpTKY8RYDcVeg UyODJl768ZzCp3HdrXalbO9p6icXbOivFV7FP+nCCRhpU1oDmH6Zk/ArUjOpC91Fr11c Bhfn0RdlKl291vEfCGLgEEjpQ/TFuT4EmDccWXLd3SO/6gIlvxWOidDw3c5Tu4Gc/qW4 FCuhKiJeei93Zc9gu7B4Dt355njQcLqB71Znw5eSSIHv/GCLzQp+F9PBe4TRY+TBC+DW DWU/8DRnqK60sxLozHN4hQVPt/7OHBWnsNJjCYQopD5BizjwUJ+SoaI6JLTfL7lpYuCE GlNQ== X-Forwarded-Encrypted: i=1; AJvYcCUJIVNYDoqTlmbzyqPDFbkE9GSB0jEk9CSoDGbY5tzimx6o8rCLjEdCf/V3SqfgQnYG/MlpCvWtC00M5to=@vger.kernel.org X-Gm-Message-State: AOJu0Yyui0lJzQdmm825tIm7hLwdrIXg8FHTaEo8bZusQbmvCyzcLpuO rmwzNP4jgkt0HV3bq4a3NE1urw+EeFOdz4BbpbMnP64A7FpmBQMsezouIdRpA70= X-Gm-Gg: ASbGncvR5hrK9nxjVgImdKYmBD7BBg7tB0KQ0+32vFVGKt304SSe5kTixCycQTRdLDe NMjDP4NGsp5qJbrjR1TIJTOgMijt4UsLuLaR94/U6UR7VMayZ5/0M2TZ7tuzHRuYSpNVjOxKMka CK1w5yFDMNHxevMRspU28ogOARtESmo2irhluaviEJBTAKhv2x1wBDxAFqafju/JeuMT0elksao UvKfyS9c348K9RxyyaOd46itGYBb7NLkyApLHptky2uVozuL6WgxDmLhgujR+FYXcEHmlOTmyWy xgGcMhp2eXYyKmD9OjQ+yNAeu/ZVADylLu5PvloQvOGYAL0V6WPw4eIcQEonsvF5UiiPX93Hdov n0w== X-Google-Smtp-Source: AGHT+IHEKV/m10IrzT141uXdAo2R7TQilKbWToWRUKyb71DvBqH66dHmnRA2NqFUmClDybjkDOEreA== X-Received: by 2002:a17:90b:1cc5:b0:2fe:85f0:e115 with SMTP id 98e67ed59e1d1-3087bb9f463mr21064712a91.26.1745398400742; Wed, 23 Apr 2025 01:53:20 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309dfa5f880sm1047611a91.38.2025.04.23.01.53.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:53:20 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Conor Dooley , Vincent Chen Subject: [PATCH v13 1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties Date: Wed, 23 Apr 2025 17:04:42 +0800 Message-Id: <20250423090446.294846-2-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250423090446.294846-1-nylon.chen@sifive.com> References: <20250423090446.294846-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This removes the active-low properties of the PWM-controlled LEDs in the HiFive Unmatched device tree. The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematic= s-v3.pdf[1]. Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f= 8698_hifive-unleashed-a00-schematics-1.pdf [0] Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f= 4192_hifive-unmatched-schematics-v3.pdf [1] Acked-by: Conor Dooley Reviewed-by: Conor Dooley Signed-off-by: Vincent Chen Signed-off-by: Nylon Chen --- arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 12 ++++-------- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++-------- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/ris= cv/boot/dts/sifive/hifive-unleashed-a00.dts index 900a50526d77..06731b8c7bc3 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts @@ -49,32 +49,28 @@ led-controller { compatible =3D "pwm-leds"; =20 led-d1 { - pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 0 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d1"; }; =20 led-d2 { - pwms =3D <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 1 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d2"; }; =20 led-d3 { - pwms =3D <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 2 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d3"; }; =20 led-d4 { - pwms =3D <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 3 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d4"; diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/ris= cv/boot/dts/sifive/hifive-unmatched-a00.dts index 72b87b08ab44..03ce2cee4e97 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -51,8 +51,7 @@ led-controller-1 { compatible =3D "pwm-leds"; =20 led-d12 { - pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 0 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d12"; @@ -68,20 +67,17 @@ multi-led { label =3D "d2"; =20 led-red { - pwms =3D <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 2 7812500 0>; color =3D ; }; =20 led-green { - pwms =3D <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 1 7812500 0>; color =3D ; }; =20 led-blue { - pwms =3D <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 3 7812500 0>; color =3D ; }; }; --=20 2.34.1 From nobody Fri Dec 19 18:45:01 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B890E1F4E34 for ; Wed, 23 Apr 2025 08:53:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398407; cv=none; b=E63aC/PjQw90SgHWCmgirsjs0dJLw2KD+Je71Ypavg3MaBS2omIAXGREb0bpRR1zt8YFHZvFTxPenV3wZAhC0FV1+LCDwOzBy9ZPFmZlrAVrXNVZJHzVBxTSaoAIeSwVUy98T+TcKTaPq8I13PYHFr0/A6aAJs/gTfh55pATiKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398407; c=relaxed/simple; bh=AhRbnxt00FmE/WhEN1u8zVz8q5gXEKLj1JYmMYck0AA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RO3XXGyOWpezxR+Lnuaq8U/HPfqbS8jLUUsb7AEmeT5vawbhK01TAmEnlhLW4ZKqMbZzHvNVya09UD5p/xBz1jLtafIZCrbmhCADfXLL6KmCo168AXxIlwr5JYIlG11gBQdJquqJ/Rl227tVVTrm/hsc5rK79bTVeFG/7MMWK2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=Cu9kjWIG; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="Cu9kjWIG" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-22409077c06so86188105ad.1 for ; Wed, 23 Apr 2025 01:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745398405; x=1746003205; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dTYlTOXj1U7VnsAmcUnx1eYdk5rL5ZGZ7LNT8Q6B11E=; b=Cu9kjWIG8znuKzo0gtx2TMdcxVbb6b/Goxq2MzVzzPpa2kkowbuxhJCVcjQa5pKEZT 58EXQw5d4HtUQiJO/MATgbx8yfCM4QgzUerZ5LHflaki4bEBEiUjVKXytPoJpBJrcqps XzxSc9Bez1kYOQg/LtL1B+DM7Qts3CLsd89vff713nLLFmFBZX2425L0t8BmHrK71wZJ NH8yrqLTmBSH6lbk4S+EZLa6gXQqDAlZ3M/Jo/yGEO11zxp230mjdFrkHipHRXvBt3mN LTKcPAuYRvlNOvGNZiapAfQQwqPI+E9zDPlO7W2hdYE1xK9MWkiHXH5EFlmfk8NAqQu7 ytCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398405; x=1746003205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dTYlTOXj1U7VnsAmcUnx1eYdk5rL5ZGZ7LNT8Q6B11E=; b=cZLDkfo/qtBnoia3Osb4u2yls+XH1RBM/mkttJ8qUUn9NLw5xgTRcZg+fE4k8u25or KXeeRZpYAVDtJ90YdcM7or0W1eGh3lXcntS5Va0MSodl4EuApxZXirFvzhNQYXkTjVE5 JqtrVEKCluBFA0b94gFzuoJbjxzknBxV2w1DQsSP5Z5wS3/x7MUJByTs4jSoHXUCk3Zj HEiH6awCJtu2psXx8StqFEwHbOMJfauvV/y82FbGmp+Mzl+w07CpSds+Uvt+QWyqyXwi pxRhvz4rPAxk6ofRPs0EEWOI5I9ydtiZ4QnPyu4XSghGe7er2U4nDpcUl5EEKGSns2Hm suzw== X-Forwarded-Encrypted: i=1; AJvYcCVuvxRRv0zB7SNiEim9+WE9B3w09LoInJkO/ClxARwPUp60Yfbt//24QMmK8l3csgjkK29Wnc2wnO0l88A=@vger.kernel.org X-Gm-Message-State: AOJu0YyCl7DVltGjrcjW4hBZsehSKda3MYy2Wd6OQl9vgijcuFYcbNGR UDYIz+6pDUPhoG6re1pKIOzotk1JJcnjCK7cgX1aAw8R6fXQaRd/EToZp4QMpyQ= X-Gm-Gg: ASbGnctyBhfEeZk28hPObJzwtdwZPDqK45mdmFHG89ZUhEYte4Kzq9ViTfK8yMn20VP tH/Fv/o7uFS2YvyHTzWD/YlVj8f5lvLa7vQSlsc7M3b14sMrDKruhzl0yb1o7BeO7KfsRmCKAwi 3fG4Mt3vwBAOaECYc24Wi+JoLDk1FisqfjqwTcC0eEH9b45gRRkqKkO8u7L9KSKk1MsAhqmmbMU F+Ubc3ad0xdLUoB/tW0dJ2oP+MYOA04Zp+8n3hJWxBq7vPsZr5L6bY7guAkGjLoRFR6RPmfKkkU eqidObW/SwUOwwBW7ecOggyAY1XU7AowDbHyvf23FZ99wYXj9b0/TVX7nPCQafo1UVxiT3VBdlk bwQoDFA87syZ7 X-Google-Smtp-Source: AGHT+IHsne6SwuPfQCy1RW0kcEWQ/ZXryn74BlHfS0I+6JQfEYDqbMrgCVn3H2qm22jhwAVayF6+Dg== X-Received: by 2002:a17:90b:568b:b0:2fe:a545:4c85 with SMTP id 98e67ed59e1d1-3087bbbfca6mr26166817a91.27.1745398404883; Wed, 23 Apr 2025 01:53:24 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309dfa5f880sm1047611a91.38.2025.04.23.01.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:53:24 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Zong Li , Vincent Chen Subject: [PATCH v13 2/5] pwm: sifive: change the PWM algorithm Date: Wed, 23 Apr 2025 17:04:43 +0800 Message-Id: <20250423090446.294846-3-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250423090446.294846-1-nylon.chen@sifive.com> References: <20250423090446.294846-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The `frac` variable represents the pulse inactive time, and the result of this algorithm is the pulse active time. Therefore, we must reverse the = result. The reference is SiFive FU740-C000 Manual[0] Link: https://sifive.cdn.prismic.io/sifive/1a82e600-1f93-4f41-b2d8-86ed8b16= acba_fu740-c000-manual-v1p6.pdf [0] Co-developed-by: Zong Li Signed-off-by: Zong Li Co-developed-by: Vincent Chen Signed-off-by: Vincent Chen Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index d5b647e6be78..bb9146267bc5 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -110,9 +110,10 @@ static int pwm_sifive_get_state(struct pwm_chip *chip,= struct pwm_device *pwm, struct pwm_state *state) { struct pwm_sifive_ddata *ddata =3D pwm_sifive_chip_to_ddata(chip); - u32 duty, val; + u32 duty, val, inactive; =20 - duty =3D readl(ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + inactive =3D readl(ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + duty =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - inactive; =20 state->enabled =3D duty > 0; =20 @@ -123,7 +124,7 @@ static int pwm_sifive_get_state(struct pwm_chip *chip, = struct pwm_device *pwm, state->period =3D ddata->real_period; state->duty_cycle =3D (u64)duty * ddata->real_period >> PWM_SIFIVE_CMPWIDTH; - state->polarity =3D PWM_POLARITY_INVERSED; + state->polarity =3D PWM_POLARITY_NORMAL; =20 return 0; } @@ -137,9 +138,9 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, unsigned long long num; bool enabled; int ret =3D 0; - u32 frac; + u32 frac, inactive; =20 - if (state->polarity !=3D PWM_POLARITY_INVERSED) + if (state->polarity !=3D PWM_POLARITY_NORMAL) return -EINVAL; =20 cur_state =3D pwm->state; @@ -157,8 +158,9 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, */ num =3D (u64)duty_cycle * (1U << PWM_SIFIVE_CMPWIDTH); frac =3D DIV64_U64_ROUND_CLOSEST(num, state->period); - /* The hardware cannot generate a 100% duty cycle */ + /* The hardware cannot generate a 0% duty cycle */ frac =3D min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); + inactive =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; =20 mutex_lock(&ddata->lock); if (state->period !=3D ddata->approx_period) { @@ -190,7 +192,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, } } =20 - writel(frac, ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + writel(inactive, ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); =20 if (!state->enabled) clk_disable(ddata->clk); --=20 2.34.1 From nobody Fri Dec 19 18:45:01 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BF2C21638D for ; Wed, 23 Apr 2025 08:53:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398411; cv=none; b=JkOBBd39HEY5ROuwMFPDOPMcaDcVnzH3RC1lW6zMEPSupuXPFJgWaiIHQ9bmQkA+y8GXj13FWgE37/4TGNqvHGjix1xW4FLi0b+FJIaVya0DK94G30MiXK6GpUL4iGHwp6p9QcercTn1czFR4arl24hvbkniaEPK74rn+Ed49Gg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398411; c=relaxed/simple; bh=glrL9frKUynd0eooWslKXIli7Wwl1Of8mWNqeP69AkU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GKAkmUKsxma2YJhr16rsu+2FxOLNfbu76EgwvBm9aAxAEltmP0hAHXsasc32o85I/5CqzT5xyKd26aV221l/1QXgfaNdy+FtpAE4x+gRDzCyr9A5iwBNsgAMV6dSILKan3YnA7dvYWY0/GyumcoDQun1ucziwieentpLsfYhLAY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=Je3+X2RF; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="Je3+X2RF" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2241053582dso85701775ad.1 for ; Wed, 23 Apr 2025 01:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745398409; x=1746003209; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Cqj4QIom4PNiBzVEbYX0WUBXZ7DUraiDzK4MrzGYzY=; b=Je3+X2RFbmoetOeWaMTvz91B0bPTc1ji5n+8tY4MLRPm4zjuyj3+SUpMGZMszWvGrm BhaW6Npt3zDL0FoQkUqh3edl5tQ1CMuLx6YE9MrTyjFIfLC0teAd57ozhSPvKQKdjzlb lePqj8nbtySvaok/kAaE/jwKjmjP1+X975uR5So71dwRi/w8OGof6zrkcwG+9n8RFnWz 4gtMSRCXG1Hg5LvU6AWo1EF6x43YxFhggtPHGnz9NCdHY3ag9kDI0av5S17vBfcVSitf j2vigeY14qTkdw9eydn2u/74VdQRdj6UAogRg2N6TTtkKb71nnbSi4Kj07VCi1OlkY7L AzxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398409; x=1746003209; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Cqj4QIom4PNiBzVEbYX0WUBXZ7DUraiDzK4MrzGYzY=; b=QGKlsXsqOmM88BT0Co1fpka9fH1NqFhmLaSq4oqslmraZSh0lNKs65/zAhIm2b9+2j YAm385EdO9CkcBmr41jRITpS2H8RmdueL1ZRp0uBvQs3E4fsplgvTgbJXwY3xLnWNNIb lxrgGxdAMN0QNx2z50NcOappsWgFyIimS3RTN5Inr0CzL9VfriVgiuDb4s4MhVLsvguY ztX+z6usgFeONb0DOercWZlTFrJSP4ZZPtTU0nUPkTH4JE3g2KEqq4GrJBPYrkY5UBCZ Dd7eM8IJ/NwdspT3ijpsjfnBulrripahrPE74g1pieEGiJTsZq8uNkIDdQ00sDOyK86U H9hg== X-Forwarded-Encrypted: i=1; AJvYcCXT2K9ILd23VsGzw9DWEVs0eMjE6zGMARHCDfMBdPmnDnMu5IQ91SIfXztoJeuyXHzm3CdjYzVFMh3nijI=@vger.kernel.org X-Gm-Message-State: AOJu0YwIo+DVfi5jgjeg82ZkRzOgpnUWZda7ZDbpR2+xsGcbBsoKjzQL wyPBYmxYzustirx41xgeWvcL/hG/bsVbCzejVMyrxB8y7E2ZSPuU9z+N/S6RFks= X-Gm-Gg: ASbGncsC7QLTKKrWgLm9zG5xk8JMtER7e2DQemU1TIYFVTUkXv7XkIfS84FZTyCMJFD GT1J6updrhjj6Zwhue3EYGWIhv/34frqwCp0D3gLxfFqIgIwTCXG12ZsVhi10q/FgpwrnUi4xdN NabIKIAjN99c4qwIOpyERnOFpxgpdJtOPOapENcYYlIwCns664yR5vpv6w/Y/3DocH5zihG99vK 3v++KI/5ehmPBcJxzoVIHn6FG3ZUedU4zbdvzWtthFLG2aR8unex/P1lHz/MYmAHM1IMNEV6fwO IbM1hsnY76IvXdw9i/fBoL40m2OQWEsZuXkQm8AZKWqQJVjx4/sXn3EVMX8z8MzaBaScVPpBAPO GKtRtnwpSKcBX X-Google-Smtp-Source: AGHT+IEAalrda38aOkj4B5+H1noGQ2OTP7JrL0DoyWnhW03mGn+cIvqfLp/tgOSUaOiNbvMPyvUE2Q== X-Received: by 2002:a17:90b:380f:b0:2ee:9d49:3ae6 with SMTP id 98e67ed59e1d1-3087bb5336cmr28685643a91.10.1745398408957; Wed, 23 Apr 2025 01:53:28 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309dfa5f880sm1047611a91.38.2025.04.23.01.53.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:53:28 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Zong Li Subject: [PATCH v13 3/5] pwm: sifive: Fix the error in the idempotent test within the pwm_apply_state_debug function Date: Wed, 23 Apr 2025 17:04:44 +0800 Message-Id: <20250423090446.294846-4-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250423090446.294846-1-nylon.chen@sifive.com> References: <20250423090446.294846-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Round the result to the nearest whole number. This ensures that real_period is always a reasonable integer that is not lower than the actual value. e.g. $ echo 110 > /sys/devices/platform/led-controller-1/leds/d12/brightness $ .apply is not idempotent (ena=3D1 pol=3D0 1739692/4032985) -> (ena=3D1 po= l=3D0 1739630/4032985) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index bb9146267bc5..6259f8500f71 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -101,7 +101,7 @@ static void pwm_sifive_update_clock(struct pwm_sifive_d= data *ddata, =20 /* As scale <=3D 15 the shift operation cannot overflow. */ num =3D (unsigned long long)NSEC_PER_SEC << (PWM_SIFIVE_CMPWIDTH + scale); - ddata->real_period =3D div64_ul(num, rate); + ddata->real_period =3D DIV_ROUND_UP_ULL(num, rate); dev_dbg(ddata->parent, "New real_period =3D %u ns\n", ddata->real_period); } --=20 2.34.1 From nobody Fri Dec 19 18:45:01 2025 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 690B121FF56 for ; Wed, 23 Apr 2025 08:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398414; cv=none; b=CtoEaH4RkHn4oXhD0xzMrFaIS6PhQJVo/7kAfZ/hPpwVmKTkb7saAzlx8tQF6zCENE3pMyIjwfL2J6PSzSJKTvehqBrf2+PuNlr1KsyFafhHYp6HZhAOgGVdlQDPAHvz/Aj1+TbmDTuSHimJbpz4heXIIG09iZ/x5pRiqSzFrZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398414; c=relaxed/simple; bh=3r/5Z/FYNGrd9yVol3oPvJOMUrAGXQMWCQuwPGjhyIU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hmKFid2JV/Vn/UAUtHn/ZickhxedpVx7XTgz9XanDiiavE8n64vD1gk5YjoeIQjlZDSApzegsCe/eySADTDe0Fo3yQwaWyZ0DHxO9O6qBLsU4xlfrkEvG4LKsYxsDFLcYtOe7wwxN3y6NfhpWycx2tV3HPlE26anRn8oCh017JA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=l/BFXzFY; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="l/BFXzFY" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-b03bc416962so4445499a12.0 for ; Wed, 23 Apr 2025 01:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745398413; x=1746003213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0ySeC6yawUczfsda0tPZSNQIrOLUHwdCmyF43sMLfrQ=; b=l/BFXzFYywi7/G3t8cBtRni0/CZA3hGD2bySF7QiOGUGb8+zYoKc8/stk3r9riNFnw /LNkxvkRxvALiGOkjeBJouN8eKjJaa3XXhgBLNaKENBZbwKMaLvfj46B8WiPJdDCNpsz gzgccTtbDOEluw5csuUwAy1CZWdwinYbcX+u4fvOB3vstMYyHKuUMwUvFk+Ph9qg03W8 mhsPHSpA1Rwb5biWDsz0dbBSr/ITkkzI8yTlb2l8Gb17m+tHEu/5IEPc1mdS4+yIlemU CvV7qEUV9kD3CXBBNMNSEsZrJ6alWM+vdTlb8LVgQReLU0E7etLhgSypQNXkVQg3NPix wg9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398413; x=1746003213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ySeC6yawUczfsda0tPZSNQIrOLUHwdCmyF43sMLfrQ=; b=EKSSyaA1m0wcYFZXEo4xW6o+AvAmp6fHwXog+8eMpLNLfjE/cQ4pSxSgX0QTOLr8Es A4fdBxTnyrTYhts+pMSi9cALh0a2n76so34iy3Q8WcEEbPQCGZX9JyfHc9xpILK9HMl4 V+FcL76MbxDex6Td0nU//kXw1Wezlph2tJMsYmmhCAV/FhTavzfKkvmLOAMtJ6zBXMNf c413P31y8743hqUKCOUcLSPUsnKhb2O9+TPKXmrUZmuo0dnfV9AgTKjjh2xFiXb9gTzc bv6rnw44ZmcApP8BEzy4knLGnaISntkck8y+zZyEuQZKsUKePB5DzqDMpQppL6gV623B 5sxw== X-Forwarded-Encrypted: i=1; AJvYcCWEPoeFr0LhStf9tU7Ba8hEG0Hc2XxXfrplMIf4GOFUmXSDgUetXQKkjSeWaEqGWpt0zBUeUqWWMsd25j0=@vger.kernel.org X-Gm-Message-State: AOJu0YxlDYGOI29+0mZO1ECkOdJcvt4kk2zk/IDKxoH/Z6uk9uzs9lR6 QHJKLBHCuzVnL7toKRwZ8tIiUxy+waaf2ycIKiM3i3oflOczHKJB4lea7NpjtQA= X-Gm-Gg: ASbGncuI1WzneaLAGZUovUtst2YlcL2nZha8ducLnsih2Y+l6MHnbLwizyTGwaBfnuO bD0HXDI/GF7F3GL9PDBa8tOtruFdN/hVR50ETgCryWsyuNAOsuNi4myQe6yoOYbrvvLR3H5UdyU q3sx4sAJnkcspZuppT1rPspE+ncPQ/tyvWkfL1Esm1y7tEsrjRmnh7/+EQDWzsiEX/+3KNaS10L EYtrcw7XO6qWz9OQ4L/TkRSh1RnW5wVFlqRxHkq6NnXLQEwxuPlYiXDIjqzfHOPSk9yXnvaPYjI CEvalNLeAszBITR8No1hbWN/at6bSwPpt7hFUUSRQmd3ZTaXl0E94DuwyqJNwxNCzV0PQrF/MHE h6g== X-Google-Smtp-Source: AGHT+IGCdyRrXA3gFk3nBMhtBGH9c8nvuEZ3lZ6EALzxbQyXUOgptExJPWtu72AQ/7Ux8Uo93heJog== X-Received: by 2002:a17:90b:380b:b0:2f6:d266:f45e with SMTP id 98e67ed59e1d1-3087bb3e794mr27325433a91.2.1745398412701; Wed, 23 Apr 2025 01:53:32 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309dfa5f880sm1047611a91.38.2025.04.23.01.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:53:32 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Zong Li Subject: [PATCH v13 4/5] pwm: sifive: Fix rounding issues in apply and get_state functions Date: Wed, 23 Apr 2025 17:04:45 +0800 Message-Id: <20250423090446.294846-5-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250423090446.294846-1-nylon.chen@sifive.com> References: <20250423090446.294846-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix PWM apply and get_state rounding to ensure consistency between setting and reading values This fixes the reported errors: pwm-sifive 10021000.pwm: .apply is supposed to round down duty_cycle (requested: 360/504000, applied: 361/504124) pwm-sifive 10021000.pwm: .apply is supposed to round down period (requested: 504000, applied: 504124) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index 6259f8500f71..4cf3e715fd84 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -122,8 +122,8 @@ static int pwm_sifive_get_state(struct pwm_chip *chip, = struct pwm_device *pwm, state->enabled =3D false; =20 state->period =3D ddata->real_period; - state->duty_cycle =3D - (u64)duty * ddata->real_period >> PWM_SIFIVE_CMPWIDTH; + state->duty_cycle =3D DIV_ROUND_UP_ULL((u64)duty * ddata->real_period, + (1U << PWM_SIFIVE_CMPWIDTH)); state->polarity =3D PWM_POLARITY_NORMAL; =20 return 0; @@ -157,7 +157,8 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, * consecutively */ num =3D (u64)duty_cycle * (1U << PWM_SIFIVE_CMPWIDTH); - frac =3D DIV64_U64_ROUND_CLOSEST(num, state->period); + frac =3D num; + do_div(frac, state->period); /* The hardware cannot generate a 0% duty cycle */ frac =3D min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); inactive =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; --=20 2.34.1 From nobody Fri Dec 19 18:45:01 2025 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06EDA1EEA4E for ; Wed, 23 Apr 2025 08:53:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398419; cv=none; b=A9qzaQ253F6ooaPBCkKIxvqnIYmCVyfNQTegiybqNTIMf2AADuCHS+0OkqV+ORgkjyrswWjJZn00Y/AHPyKZBxUIDX0w1pGr4ti5dO8fLTHaTa4ndNJtm6wf8wdBnGG4+lc0uwYxqlpfH/0HiTpobrVE5VQsDBEecoOmXe2qoro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398419; c=relaxed/simple; bh=hUNBaFmuryLSiqonZBkXEQtsg15gF7AsUoqNj03E6vE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dYu/pOHRWeO2xYNvqFIvw0d49/SmXpNORhIVLMEIbZ3ngmvR0904e8kWK1S5Ip6+lmlvVs995I3LXsomfKiPhPXeAzTwOB630+jY3fnulvmKjlyTO8MmRzLC7ee9FS6kTiinwHJ9yE6/UPaCdCHy8Z4aV4/I0C/V2Dkrw2vaK4Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=JQ6dxKwv; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="JQ6dxKwv" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-739525d4e12so5231274b3a.3 for ; Wed, 23 Apr 2025 01:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745398417; x=1746003217; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LngBqhidQc5hV1qBfQLiTbBvW0cuTKWWOhZLN1xZqc8=; b=JQ6dxKwvOwkmyAiLmgHwQFoMfPAnPLetBUM1FV/32jWM7AEqN5hfxuptGmUpzw/Hqb uLKcelV36tXW51+sA8QPfqbyB9wwHi2b+8ZYQHT6EiDfL2qCaRv2FBtTpD9fa2whAKiR 4h0g2djK4S0IpMk+tElEdp5N/7u1fFS7FW47qWdcUHv3AYSKyxhbYjqNB6rfktSpZ2fO EAI+Ig3e2CG2pLHRyvMQLQXIn1NTmnrIa/vv0WbktmW7aMEUtl9zDEdizdSFE/uMGaem aVkrqCDy5o4jKJcy1Cy/ATvGIFyUm9cWyhMITXpnCoVlArqQW8jXw1EplAYCx3CzSuGL 1krA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398417; x=1746003217; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LngBqhidQc5hV1qBfQLiTbBvW0cuTKWWOhZLN1xZqc8=; b=uPaxae/ttjpaJRA/ubM1UlhSbT9qXN37zH3krOVbtUoAnzltTi3ZEOAUnVfW094hNl gA2bGZ+HfYmwsfyV1a9d9lf9SJlD0HysPmmi4GTfTIASKBLXi64eooxj1CzKtu4/Zu4M zD75PdfQNmGWI8/8IkUDfXryt6F4AbZFNyDOwBaoMIg/gwBYxex8AVndJL+uhMhwVs3Y F4kn06/v2wkTYdKwn+erjjkBgOR4UPw0eezlVwSh5RzXP08EzvMfjbFeZIJcrB4TnQAH 49Dbwh5sMC2rRCl+x1iQFAsgVW5es/B2OxduUeoI6/i8AiYcdeW66Q02+Opxi40C4BpY wygA== X-Forwarded-Encrypted: i=1; AJvYcCUNwToQONq95yS6h1V/GPLP6iV+FRKuNq5Pf2tHusnvPDao4kMQQUUu3amWqT/O1QZzJbFT7w7rQADtCno=@vger.kernel.org X-Gm-Message-State: AOJu0YzPvdBHQj10Ns3a9gexdKS+cjO27/9CUaF3rAvNKtSasx6F/LLp FcxDRp+RmbDWsJyDvya7wUGuuJF+h3NIi+Ljy0heUKBY5BFtZHalA4UVOlOZ660= X-Gm-Gg: ASbGncsPtlwWm57K3i2zLBxIiRccZtP2GxDgBGzri/yCekaE/J35mSkQPnP5PIHYTzB AVE5JuCL20feMUaHT0E+6cngfUXhywjskVpFVhPofsUtNxbEHBKJ7F57eNUYFW7RCvnnVBmuURK BtfUPs2gdQrasuOo+vMCkPz2H061t/DOKfmSVeQf4onFE1hiotKG8zJc36/uDk5FhNlLjcw6/Gz 9W2d79HJfoeiZuXKlWpVjH64mJSs71HTfuG8pGxFkUIFBN2NmrZFIRtE4dVGoeDUqyZd9q9jbfE 0Uk8w96tQtspBRL3J/nZR3euQkn3CzTqbyPFTus3Mk8FIxINqQXbydIaIBT/JhlELb2rE0n40BI oNg== X-Google-Smtp-Source: AGHT+IH4EncUbMMGGTtovqXpM8KAlC3PBKqbv9V/w3rD+eU+bA8Nfqf+e+yTH9MYeA3b8C72khucXg== X-Received: by 2002:a17:90b:51d1:b0:2ff:6788:cc67 with SMTP id 98e67ed59e1d1-3087bbbb5damr22248851a91.34.1745398417053; Wed, 23 Apr 2025 01:53:37 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309dfa5f880sm1047611a91.38.2025.04.23.01.53.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:53:36 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Zong Li Subject: [PATCH v13 5/5] pwm: sifive: clarify inverted compare logic in comments Date: Wed, 23 Apr 2025 17:04:46 +0800 Message-Id: <20250423090446.294846-6-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250423090446.294846-1-nylon.chen@sifive.com> References: <20250423090446.294846-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The reference manual says "pwms >=3D pwmcmpX -> HIGH", but in Figure 29 pwm= cmpXcenter is forced to 0 via an XOR, so hardware actually outputs HIGH when pwms < pw= mcmpX. Thus pwmcmp holds the off-period count, and the driver must invert it to expose a normal active-high interface. Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index 4cf3e715fd84..84a7f79589df 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -4,11 +4,28 @@ * For SiFive's PWM IP block documentation please refer Chapter 14 of * Reference Manual : https://static.dev.sifive.com/FU540-C000-v1.0.pdf * + * PWM output inversion: According to the SiFive Reference manual + * the output of each comparator is high whenever the value of pwms is + * greater than or equal to the corresponding pwmcmpX[Reference Manual]. + * + * Figure 29 in the same manual shows that the pwmcmpXcenter bit is + * hard-tied to 0 (XNOR), which effectively inverts the comparison so that + * the output goes HIGH when `pwms < pwmcmpX`. + * + * In other words, each pwmcmp register actually defines the **inactive** + * (low) period of the pulse, not the active time exactly opposite to what + * the documentation text implies. + * + * To compensate, this driver always **inverts** the duty value when readi= ng + * or writing pwmcmp registers , so that users interact with a conventional + * **active-high** PWM interface. + * + * * Limitations: * - When changing both duty cycle and period, we cannot prevent in * software that the output might produce a period with mixed * settings (new period length and old duty cycle). - * - The hardware cannot generate a 100% duty cycle. + * - The hardware cannot generate a 0% duty cycle. * - The hardware generates only inverted output. */ #include @@ -113,6 +130,10 @@ static int pwm_sifive_get_state(struct pwm_chip *chip,= struct pwm_device *pwm, u32 duty, val, inactive; =20 inactive =3D readl(ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + /* + * PWM hardware uses 'inactive' counts in pwmcmp, so invert to get actual= duty. + * Here, 'inactive' is the low time and we compute duty as max_count - in= active. + */ duty =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - inactive; =20 state->enabled =3D duty > 0; @@ -161,6 +182,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, do_div(frac, state->period); /* The hardware cannot generate a 0% duty cycle */ frac =3D min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); + /* pwmcmp register must be loaded with the inactive(invert the duty) */ inactive =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; =20 mutex_lock(&ddata->lock); --=20 2.34.1