From nobody Fri Dec 19 07:48:01 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC774199FD0 for ; Wed, 23 Apr 2025 13:22:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745414528; cv=none; b=RKCiyVvJG0zAxhotXIqhN9QAv+uecScQy5HWFMIEY4D9nKEy131vKkomd4LnSyfUJ1pvuu+b3rDQiToQGtGFqqv2Nl7HbTrMzI+HqveYtrNCqsFqtigYna0n+i//+f+0EIzGF0MQNBQCOOBBmKyvOKdQGvnyjgUjkSfrdb/XE14= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745414528; c=relaxed/simple; bh=gsPh10Lo83G0mW4lltW0uPRenCo3upye1tmBE7bC6JA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q73RmQdBE6d6i/qf94eJOyu1kYzSfJsT7cYhxxMII/12HCxnwVsZqAu12KstRYdnTJ2nzH88LKkXnTm3pkoC2SVSmhRDP7j8Zpuc57lFGLtGKbZ5FNQslvHUiBqHPhXtNd97Kv3QJ7BwxUA1HuFNI/NSCdaWfzPRnm1fY6l5iUs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KBkq7K2r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KBkq7K2r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FB1CC4CEEB; Wed, 23 Apr 2025 13:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745414528; bh=gsPh10Lo83G0mW4lltW0uPRenCo3upye1tmBE7bC6JA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=KBkq7K2rJyvuL1jt09PIBYGy/54y7ZYnlI8v0sWY6YoNX4PvG5i+FLS60XdMel982 4i8bTYX8ZwvsiUtwNHJhNiJOHnDzjgNKPBnljDkaEGZaZ15aaP1+rn2/KULnAZ6GJJ o9lu5+ORRvistqyq6TIjk+9xKfFW6ZaDe190lCP6DMIu9zDtc9FI0oZ8ulix5AYUKH aQClkQtSOaLrWOB41a9bGttDT6EAjm2uqWwCJcL9iDMOzk65oEgTc//cENk8Ucqcxg VXDE8qbnkjJlS6rY1JF7731mhiH79sWJHqcnMozRFFuWtijkKaOEpVXhglNjKQqGMV Rsl9C3fR171nA== From: Daniel Wagner Date: Wed, 23 Apr 2025 15:21:49 +0200 Subject: [PATCH v5 06/14] nvmet-fcloop: add missing fcloop_callback_host_done Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-nvmet-fcloop-v5-6-3d7f968728a5@kernel.org> References: <20250423-nvmet-fcloop-v5-0-3d7f968728a5@kernel.org> In-Reply-To: <20250423-nvmet-fcloop-v5-0-3d7f968728a5@kernel.org> To: James Smart , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: Hannes Reinecke , Keith Busch , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Wagner X-Mailer: b4 0.14.2 Add the missing fcloop_call_host_done calls so that the caller frees resources when something goes wrong. Signed-off-by: Daniel Wagner --- drivers/nvme/target/fcloop.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c index b54467b285181d6909c6592eb166cf4fe6fbe54c..0c0117e03adc81c643e90a7e783= 2ff087a4c2fd7 100644 --- a/drivers/nvme/target/fcloop.c +++ b/drivers/nvme/target/fcloop.c @@ -966,9 +966,10 @@ fcloop_fcp_abort(struct nvme_fc_local_port *localport, } spin_unlock(&inireq->inilock); =20 - if (!tfcp_req) + if (!tfcp_req) { /* abort has already been called */ - return; + goto out_host_done; + } =20 /* break initiator/target relationship for io */ spin_lock_irqsave(&tfcp_req->reqlock, flags); @@ -983,7 +984,7 @@ fcloop_fcp_abort(struct nvme_fc_local_port *localport, default: spin_unlock_irqrestore(&tfcp_req->reqlock, flags); WARN_ON(1); - return; + goto out_host_done; } spin_unlock_irqrestore(&tfcp_req->reqlock, flags); =20 @@ -997,6 +998,11 @@ fcloop_fcp_abort(struct nvme_fc_local_port *localport, */ fcloop_tfcp_req_put(tfcp_req); } + + return; + +out_host_done: + fcloop_call_host_done(fcpreq, tfcp_req, -ECANCELED); } =20 static void --=20 2.49.0