From nobody Thu Dec 18 23:03:38 2025 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B3DD280CE6; Wed, 23 Apr 2025 14:47:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745419638; cv=none; b=UhCdEANp0hL1bTGkXQMWk7hIIpH9W8Ga8XNUuaZ1KYoe7hlrqsaQcKsUxKnEHh6nXLUdhi4yTlW6NyjaNe+H0BQVVywrR2+RLqAMTl84HyquOURGsVf6mvfRyt2heLjufD7u1ffJP+Km1sFL9ou0Sa07mN3L9tSstN3dA5sHApw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745419638; c=relaxed/simple; bh=m2DiDOnxwo7P6r/Y2g3QKf2ugQ/iTUOqEpyk4isYXD4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HeE6ZiLoeDrXf1LwmdQ9hM3tBCDTrmcnU/Nwl4pr2gipOM2TeWtUu8msF9NPfvfYoB2Hz2zs4au95IUKHAWufW1LX4b8W1bmv4jOl3GWR/9z+p9gWn+4rji1hjXu4BlyUcP1GJuLP1GDM0e1bxzpOuOeOxuUs7YbXK1JTU3qYrE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZRsK6etV; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZRsK6etV" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-549967c72bcso6848368e87.3; Wed, 23 Apr 2025 07:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745419634; x=1746024434; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Bzzj3T3cP+6gwpi0+nfotNm30mzZZCWntfumX+NdTyY=; b=ZRsK6etVnQ8/1TuyOVMC2acHVTnMbp1QVtDBHWBpZKt8ITkERNxZLzFYBnyBTWuZxz N1qLnbsWDQ1uEF347QR1WQiHp3QbHCv+T+K55Lxyj3EhuCv40mGNZdZho39jTXVtYtju 9o0yYnPvg2gwbOHPwiTZCymPbYFC3BTn+XzM+VygUtdYhypi4E5o2ABQndIz2ydxqghJ qu1NOCxQSonAsFWBtRKQ2f1XWFGclh0WY6ibmp6yzhbG8Qabq8rYHJleHTPuWtaPuoW9 nduqdoiVBmg7HRi3R3XOYFc/U7OwBhdhcK+si9ZJf8zZX2i+lSqrP4iRkNBOHLz2VdET Oizg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745419634; x=1746024434; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bzzj3T3cP+6gwpi0+nfotNm30mzZZCWntfumX+NdTyY=; b=PHpFV0BFDTYjVfmtaqZnfBudWhmep8CQ2UGozyG4t1atNdZuia7CfRVJS9Nn4v40yw p26R0qr+jtlLT+v7rQ/Mhd9aFfTBLk3GwWOf/Yh931jDdpz1durdR3b91xcL2ACuEWNa q3bZAfsiaH//hmuzRZvPQCSFtsA45wBmQNDP6yZsbVtUiT4p1JVopjRIhoiSOGe1ZgeN GINOy2sCzqb18PjNX5MAyvAaFNwDbs8O5d6CLPOG8oBG1VqEhD2sU/Ud26NYcVLQneWh dU36gcpFUjeVc4z9Blobb+G7iYCC5TSigM/v3NzUZFvLyPzGhe666TGHZ4swBHVBbf8L 5YEg== X-Forwarded-Encrypted: i=1; AJvYcCV2ZowZtBxO6SokPtCcRSTq6fjzAWYcfFSwZZnG+t24hFD+2n2sFzLF/LIeCJnrQImnSHHGZGWUetZAVQEI@vger.kernel.org, AJvYcCWEyNISg+Q7m+tzq1FZSIfcjo7AjpbHfhl/kJCwoaTbi6HAhY4ccRISGcsTYjtb6rTo2c2URjRdDQrY@vger.kernel.org, AJvYcCWyePspmFe2HO+gZfrcpYPzGuOcJFAF4hzupDsXNJpLB3fQ8lSXHREqIAV+YIL4sbs3iDRx6wHAn+6Q@vger.kernel.org X-Gm-Message-State: AOJu0Yye5RV86/kvt71Aag6XRgxWQf+SAcD4hy4pRlTUv5zQBKg4h/Dm vCkP69prCQCWse8sT0UWOlpOulMAcq48ChQbHrADhtRSg6I44bgaiq+4mpX90Xs= X-Gm-Gg: ASbGncvAj0bV0xKiv03Y+NmA8ZhsSdeuefmOinn9+cM7rlzLZw3zUpiolwQnruz5+pj bfy3L6k1UpqoMQiV9W47I25bHZM79GUghZbISIQ8+9LiKKxyDVu3VyVzCy/LWMaS3U93uW45ikE 12Z3gJTrg/7WIiFJV/3imgo02xQeqMVVKnAl/WeFFqL5ixbO8o+wkMT51bbBWvUTdBF2+Gc3my6 wRcJJmtEiGEXHsEctSDO1Jc8TAFuh8JVR7iZvt+oYnwusbiUmqQPmBqnM54dng2s1YWtAp9HmMF jwCdomnqhle0hsGKW20UWkS1qv7KRWCgy23QIjjuraZaqoztHHNDdrZIS+pxupbWBUw2WOJfqhl PnuChTn2R X-Google-Smtp-Source: AGHT+IGcXCDXeLXJPEW1koiq4CtmxFU6hVAFkjl67TZ+C9VF7n0TCGjERyPLqMgN7iba2Hs6LYkIMQ== X-Received: by 2002:a05:6512:4020:b0:54c:a49:d3de with SMTP id 2adb3069b0e04-54d6e61ba8amr6160594e87.10.1745419634058; Wed, 23 Apr 2025 07:47:14 -0700 (PDT) Received: from [192.168.1.11] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54d6e5f61afsm1598498e87.246.2025.04.23.07.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 07:47:12 -0700 (PDT) From: Marcus Folkesson Date: Wed, 23 Apr 2025 16:46:49 +0200 Subject: [PATCH 1/3] iio: adc: mcp3911: fix device dependent mappings for conversion result registers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-mcp3911-fixes-v1-1-5bd0b68ec481@gmail.com> References: <20250423-mcp3911-fixes-v1-0-5bd0b68ec481@gmail.com> In-Reply-To: <20250423-mcp3911-fixes-v1-0-5bd0b68ec481@gmail.com> To: Kent Gustavsson , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Kent Gustavsson , devicetree@vger.kernel.org, Marcus Folkesson , Lukas Rauber X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5186; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=m2DiDOnxwo7P6r/Y2g3QKf2ugQ/iTUOqEpyk4isYXD4=; b=kA0DAAgBiIBOb1ldUjIByyZiAGgI/V+hDU8d/oMRPjuYOPlaFQqGaK8ltId7Qp3Fpcf23fuDL okCMwQAAQgAHRYhBAVRoui2bLVNZMEsZYiATm9ZXVIyBQJoCP1fAAoJEIiATm9ZXVIyAmkQAN2s vgoReL7rIBZs0xcpWv/PLKMlJSod6vKxlq8Zw3vuPsvziO0awuxT6sySNZvGg6hU9fvjfWg+9wS RfNRMy9K/EsSV36PzKK5w4c/7y4hQoqaT2PpmL8ivtzbjKwPdRaJtJZ8lFzg4k+PjyeD9qJA+a/ 7G2ipevP0I/PNGxy1V3mk8/J5Llyt3n14L7olPymkmB7DAKm5t6h5VcGP8vTFY7/hWSsBPoQGMC NT8fzxFAV/m1L1cj90UacFMkCDEVG8gU4LWdfc5x/TwelPGztWNtDrgjPwJQ/LpXSaErr1ReaDl /YJL01ChcejuKrYjR+5px5p6wzXv3EaxTZWmUebrtsMD66yGoCgYCXpNhW5/LTW/RtiLT/8fdV2 Q7BCCKCkrd/HZfH9WOggfqUFs6UsmiMnfh5gbYaXTT5VBuB4gm51sW9hDktFyAHPn8RJKJM+Dul nsuh3bu5kKf+i7cuyRJacEv1/0+QrkfjS/6Hbgqnx3YVTZqU8M+0zjyngf9w4TFdNc9EGlTgKDG bSCPLZnuJwEcpcXs00ZY1G0Z9Xft0kPRlkfbU8G7pFBjgb/aslacu6VPKq2+vKpmZU77wlig4kq oH0LJy/cqGsoGkdJXKmJU+Vn8q4583jgSp6x8g+8jJtJTf53pkn3BhBiA35Ridu2t1s9/aZ59j/ lLCS0 X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 The conversion result registers differs between devices. Make sure the mapping is correct by using a device dependent .get_raw() callback function. Fixes: 732ad34260d3 ("iio: adc: mcp3911: add support for the whole MCP39xx = family") Co-developed-by: Lukas Rauber Signed-off-by: Lukas Rauber Signed-off-by: Marcus Folkesson --- drivers/iio/adc/mcp3911.c | 37 +++++++++++++++++++++++++++++++++---- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/mcp3911.c b/drivers/iio/adc/mcp3911.c index 6748b44d568db68120172a950bbfffb6adc7cfa3..b72ed4928da88664a00dc143ebf= 218cb4a7be421 100644 --- a/drivers/iio/adc/mcp3911.c +++ b/drivers/iio/adc/mcp3911.c @@ -79,6 +79,8 @@ #define MCP3910_CONFIG1_CLKEXT BIT(6) #define MCP3910_CONFIG1_VREFEXT BIT(7) =20 +#define MCP3910_CHANNEL(ch) (MCP3911_REG_CHANNEL0 + (ch)) + #define MCP3910_REG_OFFCAL_CH0 0x0f #define MCP3910_OFFCAL(ch) (MCP3910_REG_OFFCAL_CH0 + (ch) * 6) =20 @@ -110,6 +112,7 @@ struct mcp3911_chip_info { int (*get_offset)(struct mcp3911 *adc, int channel, int *val); int (*set_offset)(struct mcp3911 *adc, int channel, int val); int (*set_scale)(struct mcp3911 *adc, int channel, u32 val); + int (*get_raw)(struct mcp3911 *adc, int channel, int *val); }; =20 struct mcp3911 { @@ -170,6 +173,18 @@ static int mcp3911_update(struct mcp3911 *adc, u8 reg,= u32 mask, u32 val, u8 len return mcp3911_write(adc, reg, val, len); } =20 +static int mcp3911_read_s24(struct mcp3911 *const adc, u8 const reg, s32 *= const val) +{ + u32 uval; + int const ret =3D mcp3911_read(adc, reg, &uval, 3); + + if (ret) + return ret; + + *val =3D sign_extend32(uval, 23); + return ret; +} + static int mcp3910_enable_offset(struct mcp3911 *adc, bool enable) { unsigned int mask =3D MCP3910_CONFIG0_EN_OFFCAL; @@ -194,6 +209,11 @@ static int mcp3910_set_offset(struct mcp3911 *adc, int= channel, int val) return adc->chip->enable_offset(adc, 1); } =20 +static int mcp3910_get_raw(struct mcp3911 *adc, int channel, s32 *val) +{ + return mcp3911_read_s24(adc, MCP3910_CHANNEL(channel), val); +} + static int mcp3911_enable_offset(struct mcp3911 *adc, bool enable) { unsigned int mask =3D MCP3911_STATUSCOM_EN_OFFCAL; @@ -218,6 +238,11 @@ static int mcp3911_set_offset(struct mcp3911 *adc, int= channel, int val) return adc->chip->enable_offset(adc, 1); } =20 +static int mcp3911_get_raw(struct mcp3911 *adc, int channel, s32 *val) +{ + return mcp3911_read_s24(adc, MCP3911_CHANNEL(channel), val); +} + static int mcp3910_get_osr(struct mcp3911 *adc, u32 *val) { int ret; @@ -321,12 +346,9 @@ static int mcp3911_read_raw(struct iio_dev *indio_dev, guard(mutex)(&adc->lock); switch (mask) { case IIO_CHAN_INFO_RAW: - ret =3D mcp3911_read(adc, - MCP3911_CHANNEL(channel->channel), val, 3); + ret =3D adc->chip->get_raw(adc, channel->channel, val); if (ret) return ret; - - *val =3D sign_extend32(*val, 23); return IIO_VAL_INT; case IIO_CHAN_INFO_OFFSET: ret =3D adc->chip->get_offset(adc, channel->channel, val); @@ -799,6 +821,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, [MCP3911] =3D { .channels =3D mcp3911_channels, @@ -810,6 +833,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3911_get_offset, .set_offset =3D mcp3911_set_offset, .set_scale =3D mcp3911_set_scale, + .get_raw =3D mcp3911_get_raw, }, [MCP3912] =3D { .channels =3D mcp3912_channels, @@ -821,6 +845,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, [MCP3913] =3D { .channels =3D mcp3913_channels, @@ -832,6 +857,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, [MCP3914] =3D { .channels =3D mcp3914_channels, @@ -843,6 +869,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, [MCP3918] =3D { .channels =3D mcp3918_channels, @@ -854,6 +881,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, [MCP3919] =3D { .channels =3D mcp3919_channels, @@ -865,6 +893,7 @@ static const struct mcp3911_chip_info mcp3911_chip_info= [] =3D { .get_offset =3D mcp3910_get_offset, .set_offset =3D mcp3910_set_offset, .set_scale =3D mcp3910_set_scale, + .get_raw =3D mcp3910_get_raw, }, }; static const struct of_device_id mcp3911_dt_ids[] =3D { --=20 2.49.0 From nobody Thu Dec 18 23:03:38 2025 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F066B28152D; Wed, 23 Apr 2025 14:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745419640; cv=none; b=aX6Ur4ycx82SKmwgVvqk5KByYVT+iR5ZjE0C35Y4jj/1f9rN3L9tCL6gEjjhARkY6/J5WiOyb8kAKs/rSDQVICxRUWlxUWcLEyofJF2A8vFg2aGNuXuo9OKkOKf8uAw/5yZlvmY9Ged3O4aSAfzjSuQL78msohETLIg9d6sroRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745419640; c=relaxed/simple; bh=o9rko7Mal2eB/MUZ2Oa01bIuz8dWUsyCQuiKuHvbZLk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Xbmhb8+wffPFQxMP4iuAF9j6iE0gbY++fHm+qS5WczcC6HH0ySee9Qm8qn8JeGNtjT0T2SH24VKz1AhNXgAvuzd78hUQlvIR1tnKI/LWCTCoVbH6aiKCiyIeFG2oA8fXb4vrxzz+kQFCOhaLeCOu/Q8zVzmZ6jxsFkofYTZFbOg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mbS6h6Gu; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mbS6h6Gu" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-54c090fc7adso6986498e87.2; Wed, 23 Apr 2025 07:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745419635; x=1746024435; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7FTG6YAFpavOo57Q/QlOcqWA0covw0d5GqnQeh6CN/o=; b=mbS6h6GuNAp9XYXZxUAZtrnq+YEifywmPuhuLfMUuGI5JRhR7h2W58V9DyzOCU9ycz 3TSYn6L6CX2f3gSF7AnRZ0BSK8gqh5MWsZo26wrFRhwOUypknHzBZVV/t5HUx++z6EzT cVw5+e9QwIfM/IsMp5UP9m8aSU75V0qYznBjo4dVWGMpXxAG5cXNcBz3YGWaJ7s83LNl 7MZUGVt9BfNc/QBVZT1lhh7kZoRCm13uMMhZ1TZehuPyUK2PHaTREVBzE6lJc4oWDNX5 46ZrLWLIdBxhqxifdbkmV24aL+0J2nJOGkDnwnzqpli3CQjPbmkYK93l/9UVQjaUBKit qHCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745419635; x=1746024435; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7FTG6YAFpavOo57Q/QlOcqWA0covw0d5GqnQeh6CN/o=; b=tuwmmynO/Bd6//5xNGHuBB5K4Z5ymizuqDhN/ziez97blmNRlDVJhdEVaAYvS43g6Z L4DT96ZazYSM4PPkooTzgKh4nbzQJfrI/S9dLST7NwHPBQ0XSMa0ELwbjCS4hcbg42ua uHcblWdeI43RX8zVhx3A17TOd8R0zKU2ruAdAhDj52xt9YeWVcTr3EvDC2QWx/AHGw4v XbNNdyLIi4U5oQofhwbcd0B0/KHmS3FOU422NAf8l1KC2pyKJ/Att16xtOORIfT1HX5+ R6TxIOEtJPlClKDbhQB97Qgdg3K4OdHE2MgHqAWNIZB9F38pVVHixOJqlPpDXUaMCU8r VZ2A== X-Forwarded-Encrypted: i=1; AJvYcCV7S/aF1iIHQKfz8OmaPWmj9iy/CmzGY9McTHqNGA1FFaNHhgnPiuqnqVL/mGIISV/qonFlh2z2AVHpi936@vger.kernel.org, AJvYcCWPzj8SeXyEoek8rF0qBFMlq/ojvYoEPuGXuxABtulfBvK9HoapcjeO+lfd4fV25OstNBVG7dk8ysxm@vger.kernel.org, AJvYcCXc672/1uq/xHhof2G1amWe3AerRhGU09LkdWt8b2RQBmSH4ye7yesOaF8HJZOKWpvbwqMmDZFBOY0F@vger.kernel.org X-Gm-Message-State: AOJu0Yy5u78q4cHtXcd9hF7q5rbanOXPPulod05SQHrC8Xoh7NSn5GZq XqdbR/CIgc/sQMQ0/aPo7yYWh8Dx206n4RSIgUivqSTe/A0reQH29XkpWBUAqDI= X-Gm-Gg: ASbGncumgrU0ju9WixL7k0K/CxZnipbLhcSVUuDavky/SI0PXJi720hlbKJdt879/Zb tbMFG2dsalFGWDdxO5QYJfyfcObyn5TDasPY7o3PLmGOOkFc7m3kx2TsaNiSewk38cSBq4t+Xry xPUnHL7GQjiCDmM0+L+hn2g7/yiqfQYITwIU43R9sajg9rq0rvHx3qO3iZH+mxEjRARqJyO/KGP L4zjV/H9FR1S8h+EswHsYolh9uT0aWQObQlbXpy7DcQYWw4oFeSqFWuDD/9sP7JMRekAFkZad2c 3uTdQEfuyGiPt67o/1bIICqfm6zyBvZmyeIUYTiVzaSbJX2p2jIvJv/yUB2yDJtayCIwgb6vVcD l0JZJmpkZ X-Google-Smtp-Source: AGHT+IE2NCMhEfdxOrjrUQAK2PsxdjD4mqbJKZnA9JUQXHmxAM8QeFCCnSVnA2orwNV43NAcTBXVnQ== X-Received: by 2002:a05:6512:39c5:b0:54a:cbfb:b647 with SMTP id 2adb3069b0e04-54d6e6589fdmr5586411e87.37.1745419635280; Wed, 23 Apr 2025 07:47:15 -0700 (PDT) Received: from [192.168.1.11] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54d6e5f61afsm1598498e87.246.2025.04.23.07.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 07:47:14 -0700 (PDT) From: Marcus Folkesson Date: Wed, 23 Apr 2025 16:46:50 +0200 Subject: [PATCH 2/3] dt-bindings: iio: adc: mcp3911: add reset-gpios Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-mcp3911-fixes-v1-2-5bd0b68ec481@gmail.com> References: <20250423-mcp3911-fixes-v1-0-5bd0b68ec481@gmail.com> In-Reply-To: <20250423-mcp3911-fixes-v1-0-5bd0b68ec481@gmail.com> To: Kent Gustavsson , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Kent Gustavsson , devicetree@vger.kernel.org, Marcus Folkesson , Lukas Rauber X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1540; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=o9rko7Mal2eB/MUZ2Oa01bIuz8dWUsyCQuiKuHvbZLk=; b=owEBbQKS/ZANAwAIAYiATm9ZXVIyAcsmYgBoCP1kmxG8US86m/wfiOJ3qltfdRuJQ7UZElVgt ClakrfeORmJAjMEAAEIAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCaAj9ZAAKCRCIgE5vWV1S Mr4HEADe8ii7BsXgwiIETI93I7o/gmfkAlpGw1/94KnFe5JcE2k/Ss9dgjub69jqP/3o/WAzFwf s8IhXNKOGc7VekzaZNMPfAGdIfn/2WMEiRZp3qe8yD2KLDuSzpiMxAghDVlIZ4KYFnWR5rdY+0Z wgi+G3O1sTCr3en7/RbpFKl8uWZWVgSTsTJA98u0T/ENpvjjBFtHBg931ZtZ+8gnl5oSPPk9OXi mfmJeosghexPIu0nXS7XGO9h6RALfM3kfXp8IGUMyWgBlglNtzIdu0kD6Aiq1UyrPOOjOLLbpyk Ws8jNtCGmIoDCidID1DC+CkFlVIR/AaOlY7N81JPiONMH3clDJjDZDHrPOEZ7JKneX0RTLGhjHN o7RJXzs9KFaohVdwTASfwkjfJFCAfuHIFwGHqh7a/ddIplTRIWbskJ7/1Blp5K033UiTNA2j8VZ P/TENLKxUuoYrNuFGfQBJgNkaUblN84EOlzELfAPJzJE55BZTZTIBHRDTHdcuxI9JZqZWrbI3P1 xD3rt6Ymi11uUi3EX/4kI5sJWLhkRR3XH8O2THCA115c0sfE6Y1xDj8TwdTCEPXv3yNJn4RqwGT Al5AKVZLViA3TI+RIQdNwQl5LKPR/yQ+PP2n9hgagvYbjjYEEwWDAx/gmHpANqay0hmvdxYHAfJ wUwyYXJUu4+yDhA== X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 The MCP391X family provides an active low reset signal that is still not described in the bindings. Add reset-gpios to the bindings and the example. Co-developed-by: Lukas Rauber Signed-off-by: Lukas Rauber Signed-off-by: Marcus Folkesson Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.ya= ml b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml index 06951ec5f5da381a9bb942d0ac7416128eebd3bc..3a69ec60edb915ae16312b94fdd= d32f5c87f37a7 100644 --- a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml +++ b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml @@ -32,6 +32,9 @@ properties: spi-max-frequency: maximum: 20000000 =20 + reset-gpios: + maxItems: 1 + clocks: description: | Phandle and clock identifier for external sampling clock. @@ -71,6 +74,7 @@ unevaluatedProperties: false =20 examples: - | + #include spi { #address-cells =3D <1>; #size-cells =3D <0>; @@ -80,6 +84,7 @@ examples: reg =3D <0>; interrupt-parent =3D <&gpio5>; interrupts =3D <15 2>; + reset-gpios =3D <&gpio1 10 GPIO_ACTIVE_LOW>; spi-max-frequency =3D <20000000>; microchip,device-addr =3D <0>; vref-supply =3D <&vref_reg>; --=20 2.49.0 From nobody Thu Dec 18 23:03:38 2025 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2709C2820DD; Wed, 23 Apr 2025 14:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745419642; cv=none; b=HMWrijEO8bliZ5x5RPu9K4zhsttRfLddXVfRsiyVC2oIej5ho9V5URRC801Oj2RyeBYgNhLH98eYMuxOtlJcyXhXR8C7cbXHOttH6kiedh9mj4gXUzyxShG6+8CcrQPps493fDeILNub6oB/rE4Sm4f3psUQZDbJpulOEweFUJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745419642; c=relaxed/simple; bh=UpDIKY3pJjsg0tL/o3e50SZvQnX44SMqdMbYkaQ+iwM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CoGLJ5F7BR4OHoJNTXarVQjvDPSYKQYAGc53q7PiMUgTpnRNe0JbVLPaBQgVfWra9r2Q6qUThqXNC9/snsbqvpW3KYJwU37RJwQpI/jVLXnK9k2xwhcaN6kvmXBTVwxu7Vj5/7ZWu5EamW/czz8FZ12Nlp3Vz7ebRC15qDaVyYw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dr2Y/Dpn; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dr2Y/Dpn" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-54e6788d07eso1155647e87.1; Wed, 23 Apr 2025 07:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745419637; x=1746024437; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=v/4KyKt81RB7ipxIrYqCX2EK4rEQVNxxzLPICBaL9Jc=; b=dr2Y/DpnqJXKvghs8DfqasBsMChgRyo+nKj3bS5qSI+SFf0grhwNVuJX5z3/5jKSnc NLCyvUOtQtaaO4j3jXmykXHfaGUdVWQSMmizbkJnghqM8XO4DvK6hpyJ+7cuVgbr9E7J UsuPaA5teNAckHLgYeSL7loW5HK8B2aqmBjs+r/3K4joJNVxGwk09Ec1luok9dbp5nzb C8kHtf63oy5zlr4v6NL8Rg/l6BFkN4P6OGyz5ZGLnSKZxaDI31pSHUF/SaWMhB2TXD0Y pEu7kteKLPxZHiunOFPoNY84GYo9TdUatdZNIwhmSgMP5dsW3nFIpJ9pxSIxVa59eNMc OFdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745419637; x=1746024437; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v/4KyKt81RB7ipxIrYqCX2EK4rEQVNxxzLPICBaL9Jc=; b=CoOGyDAXERNA1+KaFToIOQGjATEct8YNaKlS/SyUELsiLNB9pAevhW8gFzYvo0G21W u04g3DV6gC8U2nzWGnia+uNf7O2wYwk+UbXXPEfW5V/7vIxgn/scTnY7XYdMdnDXBu+J Wvm64tjmMJuyVuCjJAEJyLbdVSR9F5wyWwAvS9S+0iLG5QtbV59hDKonaah6bmtTKtmB 7NNCcjYfjXgI6KSBTksvrRtZJTjM+SdtUZWsgZQIt31eqhzxhxa75fE71uq3wPtmioKg +yPj68c5wj8oKSztQiZOS/S/HmS49LGuQfYFeLvubfhTpAD98KZBYD+Pu4aFvJ7LXPHU 9KAw== X-Forwarded-Encrypted: i=1; AJvYcCUheimo8ZVJYJR/5hRkmyr3Bm5sudILwwsdewcLB17zrzpo47TAkbO3Sn+y1RG76wEDePMGlBmpqQDISz+R@vger.kernel.org, AJvYcCVnEdCW5JnEKnL52kiHk5UMuokfpoKSquwZS3ClE3MCxVmAzK6oenKaZS/cIDsfScgxqREF7luW4rmJ@vger.kernel.org, AJvYcCXMdKdreQ++6Axqp0RrJBnMS3ECuTCKZZrdgKdQfWl3K7EUEHMzdRqJdIiUiVw6LE+bTXAQHyioL0jf@vger.kernel.org X-Gm-Message-State: AOJu0YwEsi2q/A64bCWU7Gd5Sil4DF9a8s5HGf5F2lN8YrZMZFP/V8r1 CtrREt3qkuwkFr/2UKcQNyfgU/qnX8BuRh+9mV58rY4Qk23pzcDydalJWUGcPGA= X-Gm-Gg: ASbGnctI8fbbpmtnHamDjpo9TXaM1e7eGHNsqRTavbYnENGJMgZ+p79ehn8vOBjINeE Na6L2T231svgHb87EXVOzH8o6t8a08Y6dW8cPZgkJycdeGcsLfpqFv+bbRgjvB8BRohVZ6v62mA AVsup9AOgVE92CuSTA5HWoR9B1iRXzOzxFHB7TqV1VaSdvAk3thCCMkVJDAKGd4yTCyz3ElY6d8 JCEje0GJQT71cDkhTpsl+d9UZyOhEMTFt+ed3RJDC2ta1AiJjAcrzIr/7pHdW1xpwMNsxN/1W+4 Q02QW6KLFoAg8D8WT1YbREpOR08c5lWfAw8mqRjIrWiFlN616+Tuk0dQ11Qjtb8WiaOknWpLhe2 as+LUkSRq X-Google-Smtp-Source: AGHT+IHnDzj73iLzEb58SlUWFmg6xf1a/E/lQ+kOp35/ROokHGBXj6Iy7ifS1ZLJcyWBdltcQwOuag== X-Received: by 2002:a05:6512:b88:b0:549:7c5f:d961 with SMTP id 2adb3069b0e04-54e76ae206cmr910207e87.17.1745419636769; Wed, 23 Apr 2025 07:47:16 -0700 (PDT) Received: from [192.168.1.11] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54d6e5f61afsm1598498e87.246.2025.04.23.07.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 07:47:15 -0700 (PDT) From: Marcus Folkesson Date: Wed, 23 Apr 2025 16:46:51 +0200 Subject: [PATCH 3/3] iio: adc: mcp3911: add reset management Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-mcp3911-fixes-v1-3-5bd0b68ec481@gmail.com> References: <20250423-mcp3911-fixes-v1-0-5bd0b68ec481@gmail.com> In-Reply-To: <20250423-mcp3911-fixes-v1-0-5bd0b68ec481@gmail.com> To: Kent Gustavsson , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Kent Gustavsson , devicetree@vger.kernel.org, Marcus Folkesson , Lukas Rauber X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1869; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=UpDIKY3pJjsg0tL/o3e50SZvQnX44SMqdMbYkaQ+iwM=; b=owEBbQKS/ZANAwAIAYiATm9ZXVIyAcsmYgBoCP1pLQMzyHv0fQVeyz2yQ8hdUUwCDYdyMnaFh aaInEzSlpyJAjMEAAEIAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCaAj9aQAKCRCIgE5vWV1S MkhnD/9hyCNEiqQYXS+q6i3QjhSGxp/gQmtES0AwjvABp16rlTWw3jA8r8Ma9EpvWQM+MH5WdEu w4fZOcuiGSo650MoleCgESLJ9BUm6ukFBJiKM25+EmeMLpApJc+ZzKj9bgVUJQU2bISblVLi+3I Aw9nPGtUsrN0VCLgG/GvjXu++Bffkd7qU+lnetnHOOrDwlSGz31CGAmyCBkLrfGdDCLTmcBXPkb /QchArToogdXt/QmMUnZTGbrvemF9B6d8ivsoA11S69902lWFq830XrLCdMMwAQC2CXbhfJcBvh LeSAJmpx2SnfMALK7sfC/Ozpyz+5Amg0xvd0piEz2d6vOy+9FzD5PniNMC/783Ygq6XABHrAbSx obImB54pdCMDfAjC2sq30HjZmHjjCTaz0kHNK1ifjETjpML/NlGBmBN5uMN+ng/8ncrwBldX0WS B9iR1vzUFyYV33LCoQasYWiR9wZrl1friyugjNDCgRRv9zBcTxUUVeo7OX90ufBH34CSZNF8vjg 9+jSeuKhKMfxC1BkzxDXP0HpqNV7UplyAJ24UAG2+NNW33F06aPtCyEmhkLMYOKST/niso3DtAY gs7Mq1ddPqnHqQUxXjpRu7pD+/gvZ96/Y5ZHtzaAus571zkIa8MUVsS8cxKnWygqVCK7C++8V3Q tT0yx/nz3W5XoVw== X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 Add support for optional HW reset. If specified, a reset will be asserted during driver probe. Co-developed-by: Lukas Rauber Signed-off-by: Lukas Rauber Signed-off-by: Marcus Folkesson --- drivers/iio/adc/mcp3911.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/iio/adc/mcp3911.c b/drivers/iio/adc/mcp3911.c index b72ed4928da88664a00dc143ebf218cb4a7be421..4c04ce1b3982d84286355ee427a= 92aa55ff2fc51 100644 --- a/drivers/iio/adc/mcp3911.c +++ b/drivers/iio/adc/mcp3911.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -706,6 +707,7 @@ static const struct iio_trigger_ops mcp3911_trigger_ops= =3D { static int mcp3911_probe(struct spi_device *spi) { struct device *dev =3D &spi->dev; + struct gpio_desc *gpio_reset; struct iio_dev *indio_dev; struct mcp3911 *adc; bool external_vref; @@ -750,6 +752,21 @@ static int mcp3911_probe(struct spi_device *spi) } dev_dbg(dev, "use device address %i\n", adc->dev_addr); =20 + gpio_reset =3D devm_gpiod_get_optional(&spi->dev, "reset", GPIOD_OUT_HIGH= ); + if (IS_ERR(gpio_reset)) + return dev_err_probe(dev, PTR_ERR(gpio_reset), + "Cannot get reset GPIO\n"); + + if (gpio_reset) { + gpiod_set_value_cansleep(gpio_reset, 0); + dev_dbg(dev, "gpio reset de-asserted.\n"); + + /* Settling time after Hard Reset Mode (determined experimentally): + * 330 micro-seconds are too few; 470 micro-seconds are sufficient. + * Just in case, we add some safety factor... */ + fsleep(680); + } + ret =3D adc->chip->config(adc, external_vref); if (ret) return ret; --=20 2.49.0