From nobody Fri Dec 19 06:31:09 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A7862741CC for ; Wed, 23 Apr 2025 07:54:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394845; cv=none; b=W0d0VxG0zaZCOG/N4dazcZhqT2nSLLU7ulfQ+f3z4KrnHY7pfz0CBXFNLTMPImkfASZ6hZBxVP4jB6g8YpkEUbB3sYpkMeEnFwV7LmjOJgpY70Y8s+GfEfft7jlFHO8ygvTs7Q7A5XHGI7WS1Bi618QXZcpJIA71e+WPEhRcK3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394845; c=relaxed/simple; bh=sCy5NeyycV32ZFT/SmRZqkdiozOKWMJ6jALzEvjVFEU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pQPfLBb16kXt2ld+atTcC15lwe7T7YrUOIh6VQox5eYp80+cPvl21Wv+MeLoyG7lvaO3CePpWE6AI+meQnWELb5m+g9ef1WfSE9LBZ7Nodx7TlrWyASQWnVqHeuayPMm205d6VD13Um2VEaE+gZwmBcY9VJQOzXkt4vRfXLiRiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=vBU9ilyS; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="vBU9ilyS" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cfecdd8b2so42951945e9.2 for ; Wed, 23 Apr 2025 00:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745394842; x=1745999642; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3Yu2B6Dfdj7hXwrKNPHrcuBuguJrhn9KHB4prAy73JA=; b=vBU9ilySXIUPoTG3iQbj/PbG9CD5+lKsJyTj1w9PWLdgoT9t4o+6eiyq3NG33yacTr ouUgMxmLxPArsotpZyWyO5nXLRFGeP2JrbgRpQ1VOqnxyc9BrkHTAPI1kv4cvlVq4+g6 DtSmNU+oGTtpJEeRdhyhzWgrLc9V7eSIsJ1wNhoHceQ2yBe4ugo0GcT0rhQqGs9H3YCL +QyUmlQa85be51mKmXJsoJsva4IWn+qsGU2n0KSAll4p1PMW4Oo66x9gp3sUYOUUYoUb 1YxUSyhx3J/QVDd9Yp7KhK00kHhhjzjwhcj2EL8CTG2S7c86XvfgxfIr7K+fMgQyuOp+ nXUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745394842; x=1745999642; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Yu2B6Dfdj7hXwrKNPHrcuBuguJrhn9KHB4prAy73JA=; b=qYt8le0AHmCiVbkNAraie6asIksK58N4BLzYUd3q4pA9ean3eHqcWuvwm85sznUvpJ g+3wEx8T9I8lRiHbgeNcv5ifOL8wuNQqRvq76vdWVmB7KMltNN6JLvHKB81gZKUtnYAo u/zFdzG9EuWXGg391lf8pMBQaS74nxpxfyJZ3myO1VkYnm7NtJC0RAH1qrz/xIvXOG6a cGsot6tr1Wi1RrCORHRDjOZgkQk3ScLY0doQYNxYGN1dYUTSmiiZzWN1pt2Uji8J2ruv kz27BT1osjBTO+bbDGnwUyvaGN/qSRuEcMxTe6h27txTaC0GQeNcsxYUkI6AKXzO22kx UYGw== X-Forwarded-Encrypted: i=1; AJvYcCWP9v/GzqocvoLJNOe7TM69KXK9xiSyfKerqlxa2rmtDRRZxhrUpRfFtzNRvFin2MphHejBIVfAatBFr5c=@vger.kernel.org X-Gm-Message-State: AOJu0YxGlK9C5ITYzwKjRsDS9ugXuAFPFzlgjPgIba/tHfaWN7wu+gY7 wrqpuqIZc8o+H4E0d6oDxgnVrQOZ1I2vYo+EyZiZbjrRvzPW1oOtJTkKxgrDyps= X-Gm-Gg: ASbGncvK+3eHCm7vt5AyhLx3JtFMoGrj0FYK7ltPd/NlCg49xwUloXVsVogAiFltCK0 belXWYY3bUvc7mygO2ifcLlqToqlsv7dIU3MUCEol6nMrYrBZORkr3HBfTgBuXOB5jEMYSomiM3 ZqBYSgRwZj7CBIt0OKBB3LfM24exAc1XPsONtER2ekATF2YSlzHm6wFyQ0xFJQhoxORs7RSBH3G OvHL2T8I/0ZKtUdmhmq7NGpkdTKwmS1CCx6VVU7fnLW+gEhleg/9tsIGA1EvpqTo61O4ohhkJ7o RZV2bbtQE3tyB3Q4PUMW12O5g09quvU2tw== X-Google-Smtp-Source: AGHT+IHatYCxnScGlxG87IK46dtvJduo0XuMEsaC1y7/BEaXRE/DSRM5w5YythQpUe474HkAYKao6w== X-Received: by 2002:a05:6000:1ac9:b0:390:dfa1:3448 with SMTP id ffacd0b85a97d-39efbacfc53mr15450031f8f.43.1745394841674; Wed, 23 Apr 2025 00:54:01 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4330d8sm18266655f8f.33.2025.04.23.00.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 00:54:01 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 09:53:50 +0200 Subject: [PATCH 1/4] leds: lgm-sso: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-gpiochip-set-rv-leds-v1-1-2f42d8fbb525@linaro.org> References: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> To: Lee Jones , Pavel Machek , Linus Walleij , Bartosz Golaszewski , Riku Voipio Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1615; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=K5A9vi+sTXjh4YAzZucX9KK05Nsn0WvlpjHF6gNLFV8=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCJyX/mB8z42UH7vVXi4u6OPF6UZICjwIQ3yLE HkQSNpBofyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAiclwAKCRARpy6gFHHX clLhEADKTRSWatjKVRUHVfZtcveYdXevLl6ot2u8ju67n79RYjtXSYoJZNSoUhLJysJx3uc98K/ Gz5Hk1uqM0IkpMDd+5wSXvadxG3pGF212nev9ze70d1fdfkTbgydPWhVYrFkmOvPumcFjOXAYpE 3jUiTpUV8mRCmlD6xUP/uXke9Zx++M+vO9m935xjeqZJ4/Y31u05FDd0C/P3FVAEjwQIQvg6i/9 V+6TxINRtHoLqnTc89xJnnS1BlljM+LAH/bvlNJfQZ6y5psArwBf5FUFv64xqPIDWS90hLy6TT6 G6LY7McaSa6o66JvL+qudztr/kEAiDEaBY/nVLzPD+p7gs2dXlzPcHaDNU0yKIhFwd2P9BN7H/J 5HiA5m+29RGUax0cP/BuX3xvwjQ1MXP7KPEQgd842OHvqFsVFDcqgoDP2Yc0iLJPnOdnw6z37bC aJig3cuBo3YNjCLcGZAHoEWBLb2lFn9otAgEMe5/ASUTnkg5hmHGFrCZsgqG8BVc9t8WmMtaaRi J1LOobI6UMC1kZC830TwHAKa5TjiB9I4B1sfKyAxbMr9mIR8JuLs1ZkoXmO9XsLRKFYC6/WuEKY hZ2m5B2oc1EutgqSbKRZBtYYQg3VX5swPxGuYFunNTZih4eqG5/thwyeQjG1QE9m6TSqgLi9iFk E/mUMgkgAUeQrUQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/leds/blink/leds-lgm-sso.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lg= m-sso.c index effaaaf302b5..c9027f9c4bb7 100644 --- a/drivers/leds/blink/leds-lgm-sso.c +++ b/drivers/leds/blink/leds-lgm-sso.c @@ -450,7 +450,7 @@ static int sso_gpio_get(struct gpio_chip *chip, unsigne= d int offset) return !!(reg_val & BIT(offset)); } =20 -static void sso_gpio_set(struct gpio_chip *chip, unsigned int offset, int = value) +static int sso_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { struct sso_led_priv *priv =3D gpiochip_get_data(chip); =20 @@ -458,6 +458,8 @@ static void sso_gpio_set(struct gpio_chip *chip, unsign= ed int offset, int value) if (!priv->gpio.freq) regmap_update_bits(priv->mmap, SSO_CON0, SSO_CON0_SWU, SSO_CON0_SWU); + + return 0; } =20 static int sso_gpio_gc_init(struct device *dev, struct sso_led_priv *priv) @@ -469,7 +471,7 @@ static int sso_gpio_gc_init(struct device *dev, struct = sso_led_priv *priv) gc->get_direction =3D sso_gpio_get_dir; gc->direction_output =3D sso_gpio_dir_out; gc->get =3D sso_gpio_get; - gc->set =3D sso_gpio_set; + gc->set_rv =3D sso_gpio_set; =20 gc->label =3D "lgm-sso"; gc->base =3D -1; --=20 2.45.2 From nobody Fri Dec 19 06:31:09 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B77D2749E4 for ; Wed, 23 Apr 2025 07:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394847; cv=none; b=sclg7+qhIbBK3W15MA3XRnEi4a1KwWfstpefWofrskPYeG6qQIPXhqzIMHTKX7sDuI78/yp3RQdmzQEdwBSTTxwotrT27uh0p4km6J17sxJHHtY4SsXyBbPgmNxxlFrbriCWAVlTioqFitFt19RrbODnUd/rO9O59q0ukoANMRc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394847; c=relaxed/simple; bh=3Ii8s2p/qcdFuMe8SVAPXc/efpCSMFMl0mlUoTEBswI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OXDiAquAptD36g0Hjn8W9fI1Em2j9l6wFW98CFxNaRBeZ+iJQUjxviv2e/b3IEnLfdPbbQIUC108z3OkuOILVFmwcQ3ZGubC9VyNEqZdrJ0kGu11hvLDB22vlvQ6UjbJkoRQhbAR7g/lv+q60m2/DLTITjbwUxNXDNCsDd0BMNs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=mTnVEntE; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="mTnVEntE" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-440685d6afcso57049715e9.0 for ; Wed, 23 Apr 2025 00:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745394843; x=1745999643; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G50tHg+9cPiXzkRpuZie2LXfSMz7hYXUT5tobf0KFow=; b=mTnVEntEoLLNgtvVkc66Fo6QuA+P2oveflOhOrsm6JJfGRsB/k13MRHT5Znez7slnk ACvS9M0+fLtcWr0Fn78Ia1poKdOxzyYXQCueOTorKmwwPOHfAb6CQ6UQOg2xFtdAErf/ EvhNdKgbtORqh79UqpI/v1uFKvHTDpGhu1ixfM+tDY/qj61+LjTjfJT8vH5LWRVm2I2Y doqncjQdpYtlPFKcK25u35mSLlO9JfZyFg1+CN92JAROARI53POnmONnAzW/fo2E9VK1 XsazlD7SHJn0GgmcjB5rE6CPshbC4p4mOxWChuVL4MDwZvoJPEf33uE00yrcEwQvzWK5 n33A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745394843; x=1745999643; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G50tHg+9cPiXzkRpuZie2LXfSMz7hYXUT5tobf0KFow=; b=mK34DKM8BkjCdVwOfCahBqJktFqmXbzNwEcOqmHzWsooggtPwPBR2SQQlLoUyLLfBK GNBTgThGH2Xu+gr0gpVR28s6IOGT5EmR0SPrRUCC6cmZzZ4EF0fk7tyOOfIkeSN4+aWI GQnP9ech46/bM3yRu/B1pd6Cxg3zRQ3xSv+gn/cRgTJl1pQnxzzF5TxfD/g67gnQ+qH5 0JN9+lF6CYtE22oO1M3yC5Kr5pnzdEG4thU2avKyrwQSB0gRDxIMXMHsusjcQeybuuz5 15f3RZCnM1o7nrdG9C/LZijOqnlf6/wip/xwh4A91EhN3tgLlgFh15qaFS8a5Ddh19up C1Gw== X-Forwarded-Encrypted: i=1; AJvYcCXX8vH54nwqhZaHepdpxrxsJzPRZ1ssosrmWTeAZdfg1JgJPZZ8H6M37TA7oEYbPZ385cCePhoKMMcqAX0=@vger.kernel.org X-Gm-Message-State: AOJu0YyNHH7oXBMKbgYTPBD4JwR4We6COuLIePZJRVg2o7y7OvxeGk31 yL35KHQUEQ5BjLOWkisIiaKHdzSahUWGAyQDMLv5GmcUzqqGWa2rkbjMSBjblpo= X-Gm-Gg: ASbGncu2VpVaciiLkU84cEy6e48t6Ntm6we0MAxEIfeOrPbIGq1EULfLsGQksc42WD/ g3lH3PMiRNEKfwc5splFl0AIwNfnSuL6BCRJECY4M5B9BAGBhN3tO7tLpT7HnXOtyBFXi6VceiL lDKy+o5G3EnYOMhg1CiOtJuWfO4lO7dBss9bKzSGifvYSYqnyS29KxEneXa7QoBlFvhjv/rg1mF wKwV0TbpYkkxEBbflsjIjF0q871IwghARujDBmY2Z9j/PrsYv1BFJsjsBIz4By2KWmMsCbZsblZ 8INJSgnuozzWY2OEGawGy4g/7/UVXO8Krv4jgwACzd+7 X-Google-Smtp-Source: AGHT+IGvXTJ6ZnfxoE28QibdMukAk1jobBJ6uY3/oOh8NYBRChEhWLE8jpG+gXPQsyB16QsY+BFf1g== X-Received: by 2002:a05:600c:a088:b0:43c:ec28:d31b with SMTP id 5b1f17b1804b1-4406ab9767bmr210592445e9.10.1745394843119; Wed, 23 Apr 2025 00:54:03 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4330d8sm18266655f8f.33.2025.04.23.00.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 00:54:02 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 09:53:51 +0200 Subject: [PATCH 2/4] leds: pca955x: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-gpiochip-set-rv-leds-v1-2-2f42d8fbb525@linaro.org> References: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> To: Lee Jones , Pavel Machek , Linus Walleij , Bartosz Golaszewski , Riku Voipio Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1542; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=l2zdj6xneEh/Gk26Dc0eMWJRRxQPVwCJnsn65X8LVNg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCJyX/ngp3PcuZDqy3Ua2tfkLyx1/xsgD8bsIE joXG4dBiPOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAiclwAKCRARpy6gFHHX coIND/0UvM9H0Fn75mnFJ4Ib5MXYYwVT9suj73IBJKfYp7aqXXoxUcpByilyJ0agYWNMRhsobGO s/oI89fln0XTsleS8uMc8pXvuoTi0KcatR3NeGiCGlZBev0oNvaMVkn9ZLEF4EJw0fMtBxYMn3k Z6BST6/1+6uX9OyKUdDUzZNMyCRztmf8yWk/vdoKTLEUxzW88ppyl3vAu/ZYFr2QBuB1ynJLv5i eA0FcaWCTC8RmOKE+v4q5r0n0sdAC6aIBLOuQ/gqn22wDqVZMGXDPtKwryaS3urFcGTtAcsfC2N 2FmLLkH4/mYSliEIiY7RW+U5AsxItOtl1iba3SI81o2Ym73rUsTCVfX14CpuhRSZksGkAW1kwBI 6Ihdv6hXi7/EBQAb98xTY5EzPvDm8mqLSTJE466nlZ7+CJImoq0nuQpLVcL6uGOjdjlNOLJFhM3 sMg1EoAFfFiJyiF77za1Mh+7wZOKV1poPoWdjQ6IfXZNMXzxlZLRiHoXDYvU3OP+U67D9w1NZWj 0awPnKFtkMeQdnCAxADE0KoplYdX8M62s3MajaeD2Hl73UAqaXVgN6BiEYuL3qEKO0V7oDa2Hcm 7IFwc/x9HWBiVQYNodydT3su07qbOXk4eoK68fqNS2TLGQ+JEQ6Lu+o+ZOTJcWaVSnO2exudDds VN9GzjLQ1pCJcIw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/leds/leds-pca955x.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c index 24a40a1cdb15..42fe056b1c74 100644 --- a/drivers/leds/leds-pca955x.c +++ b/drivers/leds/leds-pca955x.c @@ -495,10 +495,10 @@ static int pca955x_set_value(struct gpio_chip *gc, un= signed int offset, return pca955x_led_set(&led->led_cdev, PCA955X_GPIO_LOW); } =20 -static void pca955x_gpio_set_value(struct gpio_chip *gc, unsigned int offs= et, - int val) +static int pca955x_gpio_set_value(struct gpio_chip *gc, unsigned int offse= t, + int val) { - pca955x_set_value(gc, offset, val); + return pca955x_set_value(gc, offset, val); } =20 static int pca955x_gpio_get_value(struct gpio_chip *gc, unsigned int offse= t) @@ -737,7 +737,7 @@ static int pca955x_probe(struct i2c_client *client) pca955x->gpio.label =3D "gpio-pca955x"; pca955x->gpio.direction_input =3D pca955x_gpio_direction_input; pca955x->gpio.direction_output =3D pca955x_gpio_direction_output; - pca955x->gpio.set =3D pca955x_gpio_set_value; + pca955x->gpio.set_rv =3D pca955x_gpio_set_value; pca955x->gpio.get =3D pca955x_gpio_get_value; pca955x->gpio.request =3D pca955x_gpio_request_pin; pca955x->gpio.free =3D pca955x_gpio_free_pin; --=20 2.45.2 From nobody Fri Dec 19 06:31:09 2025 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6113274FE0 for ; Wed, 23 Apr 2025 07:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394848; cv=none; b=n4tOnlHvZp+42JKpq4iGSSVM7RUi3IrHPW9p1nngyypDcCxn95GD6EZT/HDf/bbeKMoZA7RIiqNGwK7NZQfaXGVofVGvyHQVKz4NFkgRCNe+4lYWjl72mSOY/pCurNOFxSrbn9V2DCJviXl0F4k75Y+BrfdzR0kagHQwUPDCxp8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394848; c=relaxed/simple; bh=zxOjYTiJyy84RQtnZPalRY61UtBT2cLl+d5QqitJRy0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PYtrt+uxJgRjIuagfoVTg7QN/RrBKPz47CK5uCXcLMhAQCcmolZJ4PxYzXTWcEp8AYHHrFxHefIdP7JUoVaDp229kIB0bx7KB2n0mbGurkpNwyhLsxsVD/kISic73xwuLoOcIcb6xcHhyNaHHUb+QY9jSQyEMJiNH51gaKYsjEE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=sD1EDxSL; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="sD1EDxSL" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-39ee623fe64so5276372f8f.1 for ; Wed, 23 Apr 2025 00:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745394844; x=1745999644; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=awmpLsPRHTvySKAhJ2vpQU4oTjj4fckiHhE0P3e8Csw=; b=sD1EDxSLOBZMDiLk/qGgOMmAw1fNF7boSwGBkMJXDAtrD3ZP/qQ8gH9x/79R/7AN6q zWa1fLzuGZoV//mf8oxsOGL3Ui94T+1VCBTXjX7B66VqNTZvj5rBo0IAbQWdAkVjkZdm ZL3uzMYvoXbDH6YBr1s4UVPHiczQdccRY1r7/gGjC+gUXxxgRRLSwEUjPVDeVPJm8Sgq WZ48aPsh2uG6gb8KoZnI/VpkA/Cvdm0bWazt7ijzaoCYwsLxgK8GP1qniH5QpgVGV/vi hSf9NfY850pqB808P03DlEnDvx6tMJxB4hzoijudLXpOnSGQVQLTW6CRUpJZxMRGDsMA SREw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745394844; x=1745999644; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=awmpLsPRHTvySKAhJ2vpQU4oTjj4fckiHhE0P3e8Csw=; b=OIZmLp+uPT6gF2GwzkWj6OAQUtB1DlQkb/wLymBlTCVEQkYsRRm1egAxxlzNQureua In0Swwwa+Vehpc5uoYqc3rfdSormcM3tRxQUUrQMfVeb9AyJ5JLZJbK5Xg70OYWvB0PH 9/bnfB6iit6bkM8jyrVqo5QIyPfThYXshoA9gDti52ph9K4FHmEvguGE7XCX2Jn4d2vR mYMpwTcink+AT1ei+7GaBxoQj5nxLBOHQorVXsADTpcgOZYyACgW9z/yOog/W+BNXk9k U+vPkEHvivWaDchtZa2ACzeiz7GYsGa9RauRWj033+oUjAUdr/jyPNWRDLrui5evDV5q uomQ== X-Forwarded-Encrypted: i=1; AJvYcCUSdMitxH8yCN7zZ8qsietA33avKTgUnXUHTKu2nuNXUK2g01SKRh7968fyXex3xoEI9rE5k4KOrsMZZgM=@vger.kernel.org X-Gm-Message-State: AOJu0YyKgCBJxph/zsxPwDQy6tSeb5+YNlB6fc5+x/CLXCA68uGqJDgM 9FtZ2khb/AR4c2ScgxuHXSJejPUIzOTZsDO4QycOh+oDbjo+qHQgESO64vAq+WrYAmNZs8NJH4S ha0g= X-Gm-Gg: ASbGncvowLmzImjh1pxtc76EjzfLKhX6YTONW5rFkliWT1bltfXWZf2b/cruA31Brll ortsBTc+jdha2wT+C5Wi9cNVCY9Iyf0VJ6b4y9OjVOTz+/FQnK2Hk9x2bnjzTQzuw8TJYpUAAma 1w/HeSGTODaTcHKoH2x1ImGpdFKjmz5BMJFHLeE20K9Y7OnZNC3NnURD1tQOCBe/XYWUQ2nLS8e RyQWZm3JnR5/O7W4afzRyS+5hhWiAjQO4a+vB85iGJp+Qk5EiyaIg3WeZz7afeaz0kA3RNIn1Cz 7UTZu/w6Yme0Bj4+0Jg3rp1nqT58ls0EeQ== X-Google-Smtp-Source: AGHT+IHpJiw5FVvm/29U2iCX1LZCw0i/Nbm/maOexa2urIHeoGl97Wey43Yj0psGVkkZuo14ySAJXA== X-Received: by 2002:a5d:5849:0:b0:39a:c80b:8283 with SMTP id ffacd0b85a97d-39efba5b647mr15739927f8f.31.1745394844088; Wed, 23 Apr 2025 00:54:04 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4330d8sm18266655f8f.33.2025.04.23.00.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 00:54:03 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 09:53:52 +0200 Subject: [PATCH 3/4] leds: pca9532: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-gpiochip-set-rv-leds-v1-3-2f42d8fbb525@linaro.org> References: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> To: Lee Jones , Pavel Machek , Linus Walleij , Bartosz Golaszewski , Riku Voipio Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2010; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Q4N59dzS+Vuc+KWJbtCOPhsNB+gdq0KgGsw4pEhqZY0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCJyXc4I884o6/Xyc/tB3w4hoVI2mzM6RHhnTy h8HDxNzCriJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAiclwAKCRARpy6gFHHX cmdJEACil87EJKYf+Q8ROqUg1EIZAdyX1ELY8HGoJKDg50NwtPybyVb9CryftIWOX/JNRLrITVb aGTfPVIOTPwNPha9yMuXqYqQpTXhaAJctQmIdudIfaTcYHXSeYtKixn37VA0h8hXaoZ8NVtaGuF clbey04B1txEdgOZgXv9Y/XcGdA78fAQoVitn7PG5Lg59qc4qtFElYep0bVF6QVMXn+WmmIvrJH j5xYt0FJGJ8cUUjNw/fhOOXV/XuYdPMpoILT9vA02uwgATbfjx/h7IjB22xsUXXBWcZCiWDDqJD iAJqABycco25U5TSpkJJYUommbclinDkjx4Gf41yIKblHRIf1z7Raxy2UwNlmHGj2wPqySedLHa /Or+31/FeHIvds4F7AK9v2ZJ0/yRfeAqC0Ev0vuSNHKlsMiKXy6KgAAQPDFO1BMZsyXwvDQpB7b TQUCNdO3xF7C690ep9kQNJ8mWpLovYUlMgKVD6+L6M3TmUt3vac26UQP26+H1wt4YDBigXPNp8d TrfFRNTyuWZUbffroo1Z3kolwGlIXnGldSOYKwdPRoxakHKI/pMc6R/W0l76EG13XpD7XEjs/su zUNSqmIDVG20uzcIMAQhIIr8mLeHDpsNS0hodQE9VXhaU4UGI5LSbpkC9Lh+XSBxc2/opu5CkJ9 F7+HOsImPhA2FDQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/leds/leds-pca9532.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index 1b47acf54720..7d4c071a6cd0 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -318,7 +318,8 @@ static int pca9532_gpio_request_pin(struct gpio_chip *g= c, unsigned offset) return -EBUSY; } =20 -static void pca9532_gpio_set_value(struct gpio_chip *gc, unsigned offset, = int val) +static int pca9532_gpio_set_value(struct gpio_chip *gc, unsigned int offse= t, + int val) { struct pca9532_data *data =3D gpiochip_get_data(gc); struct pca9532_led *led =3D &data->leds[offset]; @@ -329,6 +330,8 @@ static void pca9532_gpio_set_value(struct gpio_chip *gc= , unsigned offset, int va led->state =3D PCA9532_OFF; =20 pca9532_setled(led); + + return 0; } =20 static int pca9532_gpio_get_value(struct gpio_chip *gc, unsigned offset) @@ -351,9 +354,7 @@ static int pca9532_gpio_direction_input(struct gpio_chi= p *gc, unsigned offset) =20 static int pca9532_gpio_direction_output(struct gpio_chip *gc, unsigned of= fset, int val) { - pca9532_gpio_set_value(gc, offset, val); - - return 0; + return pca9532_gpio_set_value(gc, offset, val); } #endif /* CONFIG_LEDS_PCA9532_GPIO */ =20 @@ -472,7 +473,7 @@ static int pca9532_configure(struct i2c_client *client, data->gpio.label =3D "gpio-pca9532"; data->gpio.direction_input =3D pca9532_gpio_direction_input; data->gpio.direction_output =3D pca9532_gpio_direction_output; - data->gpio.set =3D pca9532_gpio_set_value; + data->gpio.set_rv =3D pca9532_gpio_set_value; data->gpio.get =3D pca9532_gpio_get_value; data->gpio.request =3D pca9532_gpio_request_pin; data->gpio.can_sleep =3D 1; --=20 2.45.2 From nobody Fri Dec 19 06:31:09 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE974275843 for ; Wed, 23 Apr 2025 07:54:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394849; cv=none; b=ceEdohks9mshf4gG/MpCHkhihszfNDI/SfMny4O9LVaQO/TXjDaQrri6rMmvhzBbb8aJ/EPBE4OKxvlsm8NXXp4enqOIzVYPJ+jgdocWCFwgCUW+lI74BeDUY6OlHL7N8wmCIvORlM/OP+xjCdvtbWSWKQDFeCZX+J2B7KJZQS4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394849; c=relaxed/simple; bh=VqGDq+aiJzH+1k4/p5pVXAekbmppDm03yyolVhT8cKU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K4QVKr0uwPGPP7CFaj2tYOKFiCePr7pWu9/Nx+bXxwqoXy3bfdPQGrsJxaHWNU/1ZXksYk7Xf7lHydObhgrFB8yf9P6skTTjr6dilRPkfKZ3UY1Py98vOt+hjTCW89gSlDdG8OR8cGpVlliCzSwCQjQX2LKtvUIb1HWQY5/n/mI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=yJ+9L7cy; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="yJ+9L7cy" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43ce71582e9so48437155e9.1 for ; Wed, 23 Apr 2025 00:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745394845; x=1745999645; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GTFfJZb1P5uU8ezKo9spOiDP3fTS97bBPzPp1VNuiFE=; b=yJ+9L7cy5xIO1QVUjmi9YeiPTmQ7PuD63tm5UuRxkJBYFgRZN0FSYTHOVGN9FFFMFW CgtGeE2PoYmae2C7F1v+wqFFfoT6XF0nGtH2vgbVqbhlAJJEZDpoN81O9Ac/xfbOVe8T QVPcMFWvaU9TuWiuM3gugil2F5FYaxupnwGn38DJ4nbooyukMN+dDn+OcjEZqn66HTrK Ms9/ggo2XVvJwtw+Awx8smTUnzESrhIP6kak81WLJP/AyTM9arr/itEdk+hlIVskcDn6 Qf7F/xN0TBjh6KdjZb0wit3WzBYtGLUXFh2f+jh85WRox2z6j+ZmdvnFRR8efh8pXjCS GVZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745394845; x=1745999645; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GTFfJZb1P5uU8ezKo9spOiDP3fTS97bBPzPp1VNuiFE=; b=LDVzsL7bp8BEV8sMFGbo2ZCiYIi5A+Hbyzg3IIAsWf8s+ynfUPqzbu8e5Mh0MyUmlD mS8EMGBsEWzJgd1p9xfwfZM0uJwdmF/koFd4y6Us7drUfX4yXL41UfSR39uMWkwQCAkr GjCA5+5xMrkR/joo2EP0c6godwesqfV/KWX2c8LbtcLu5+qUqKPmOO73/f+lgkQn4qXn FIqr/TtH/j8VfSQSSh23TsJe7OiVrwpdvEydc5iPf0rqG1B9EoeSvGP43GaAOITGOwXJ pxWZAfW3cn7ntTVIOIK+66GXOawK5A/PDaGq6zh7ZsS7G6NlMBCxiWr/VoSCGRV60Wh8 31vQ== X-Forwarded-Encrypted: i=1; AJvYcCXJVAzLVtBbB8dA+ou7bVKAAP4bJyj0SIUzF7gXXzGockfNKCxsqmTWh/cpmo2EjFaVwSQoTHLSyUCMH2o=@vger.kernel.org X-Gm-Message-State: AOJu0YxA2CfFD1IENjDbFOMZzfA+5jTUWYz257Px2B7k7WFYL888D2W6 Cqo+8EA/fwrss/3h8vqtpEvG/uPEE/HDelUbOqFhcl+bcKE/qSvdj7I/60zJbj4= X-Gm-Gg: ASbGnctiWAi/DfteHpgMbkkEn2N1xW1qdNYVeRi15WXIhZRArWSZCmjo9aK7VbupfDk pAWGEIo8pMoUFMhep1fX6x5iqpSD2+pXNEWwUDmzYQvwjdlyQKeRscMWDRBJFgyC6yQW7B+IHc3 Jb/6UekLJqBHQzG/Vc/XlxamLycxP2KLxZSrui0aC1Tp+bqDlzrRmuCyT8N9fJTXzrLaQ6O11Ei YGW4pWHE+bFahsAI+lfAKomBkt6hsLeOckQKRfziV16+NURfLfQ2/gpCwBCQTgE1AhQQYt0QTeA 2uxOGcDCN/lv0/pOsDA+k0ioNpmsk2zo9IjpJSbxuRhk X-Google-Smtp-Source: AGHT+IGTjzRevoWNUsBJdpmO0+4XcLcpnz8hcwqfrYaEOvZnTxWcAwwm6v+Zm7rMHLQ3zUTTTB4kuA== X-Received: by 2002:a05:600c:1548:b0:43d:300f:fa3d with SMTP id 5b1f17b1804b1-4406ab7f661mr150504825e9.5.1745394845053; Wed, 23 Apr 2025 00:54:05 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4330d8sm18266655f8f.33.2025.04.23.00.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 00:54:04 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 09:53:53 +0200 Subject: [PATCH 4/4] leds: tca6507: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-gpiochip-set-rv-leds-v1-4-2f42d8fbb525@linaro.org> References: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> To: Lee Jones , Pavel Machek , Linus Walleij , Bartosz Golaszewski , Riku Voipio Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1758; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=j50twcusbXfbWf3YimG8kilK3UrQntg92BiiLpapoiE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCJyXXWKiAH3snFZHuRbLDBqkRUlZiVNabT/vi W2Az4GKo/aJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAiclwAKCRARpy6gFHHX csOmD/4z8pV0ShS8Bn+cluVeSrGpphqnovNsAHA6+L3NqKstpdKCMPStq21vJwK4g0mxS0hWlcS W/xwr4ddv3T9CvuZwJXyS7Qsh0WGkIrfEB6jWJn8zwbVmsNCnhvq+2geTenkaVPKnom/4ctM5j4 JgsfG9W9EsKZmGRPe0IlnNhYGnrgwwKhPfh0FEzyqylBMBT3LDWTQ80EfwgIUjP2RsJz8laoB50 ddVugrvsnNWDihdOrIbIo+zST06DfSO5zbXNSywQ/eAZ+/PLO4SpYiNOQRkbpwQkQ+9EzIcCOFn cXVbzHvISKu+pMczH2P959jlGJTH8z/bWQoQI8jQRqfHQSG1ty/je2WdbzcwPEhxmvIQMptJw8j cphEyFKe6MMttqhABUYsYNSBFfHYdZMDtGEfth03zput/5fK950xdoMp3rIdIUtPoLfbTeNv6GO hQfx7dRubXy1YAi/UYOKd5DXqD/NjH94DTTiI1jmVAClq6lQrdBg0jEvJYCSe+x1Dtulx2A7DMy XoRGElSeAKl6Xl0dphxCCmFmCdeqggex2mMrB2WtNCC8dvRYFOPV9mGqU3ScI5IliD6RvVjisvh SbVb4siNzfRdTGn/30tY7d5lK031ZpAZm55H710vzt14UeGyNepkLazvm3OW+IpHgdMCcJ4VT6X svAfxJVCje8xDhg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/leds/leds-tca6507.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c index acbd8169723c..89c165c8ee9c 100644 --- a/drivers/leds/leds-tca6507.c +++ b/drivers/leds/leds-tca6507.c @@ -588,8 +588,8 @@ static int tca6507_blink_set(struct led_classdev *led_c= dev, } =20 #ifdef CONFIG_GPIOLIB -static void tca6507_gpio_set_value(struct gpio_chip *gc, - unsigned offset, int val) +static int tca6507_gpio_set_value(struct gpio_chip *gc, unsigned int offse= t, + int val) { struct tca6507_chip *tca =3D gpiochip_get_data(gc); unsigned long flags; @@ -604,13 +604,14 @@ static void tca6507_gpio_set_value(struct gpio_chip *= gc, spin_unlock_irqrestore(&tca->lock, flags); if (tca->reg_set) schedule_work(&tca->work); + + return 0; } =20 static int tca6507_gpio_direction_output(struct gpio_chip *gc, unsigned offset, int val) { - tca6507_gpio_set_value(gc, offset, val); - return 0; + return tca6507_gpio_set_value(gc, offset, val); } =20 static int tca6507_probe_gpios(struct device *dev, @@ -636,7 +637,7 @@ static int tca6507_probe_gpios(struct device *dev, tca->gpio.base =3D -1; tca->gpio.owner =3D THIS_MODULE; tca->gpio.direction_output =3D tca6507_gpio_direction_output; - tca->gpio.set =3D tca6507_gpio_set_value; + tca->gpio.set_rv =3D tca6507_gpio_set_value; tca->gpio.parent =3D dev; err =3D devm_gpiochip_add_data(dev, &tca->gpio, tca); if (err) { --=20 2.45.2