From nobody Fri Dec 19 06:25:09 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 463381EDA36 for ; Wed, 23 Apr 2025 08:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398553; cv=none; b=tYG+981iIIdzPBpSQPViGjhOVYZIr1w4FUJ5HjbfFsLf0+v+BtfSGFcqAK2UHgr5cHCJVwfUjw77F/nBB1F+LOcjO3jiqpy7wUDDZsTD6+nZ/fNMMvS9LAdRkwTmYvnWTx/p0UxOzHukPf8SBfYCEc7WdNYtaQCK5TO7w9ytTaM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398553; c=relaxed/simple; bh=oSqHYPefJTh0bLFCxZFI8OnstoUZFH7q/TAZpQkyL5w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Tlhx426gN1sEQoNYq6dHilVy3Rq6CMq3BPaeXZ/asvSXMHIU2NVes0LwzwPU3RJmYh0fPRwm5zRdFi+k4MMmts5bMb+ZMBeSxMnOG1s/Lb/FDKDsMEwGsIQznozlq1cmheiqa2gVwrRymYlGl7C+X5GwNJwF7O1KJLrR5yki0fo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=qZZzQQbv; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="qZZzQQbv" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so69602495e9.2 for ; Wed, 23 Apr 2025 01:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745398549; x=1746003349; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TLH1JzvSTREU0y50Cn9mOsy4ychR1nU69CWKH2jYQrU=; b=qZZzQQbvH9DE2piWzb/ms1wcmd6v13mbyQbUhqxkj9wuvGNBI48Dw9XhbVTCNCfyor ug2kSvPxN847qVGnGyaXscavNuy8fBT5/EZUrh8KNaDJb8hkevfQTnHgwTDYe2i97bzJ scj1j3A9BvQShn5JoD8oYe1LADpZurK1aOia4Z7KjCPbyy1T3X9w0aB+L6cjLYYc00vU b7WoUOlYfissbXb+3l+PwjvBAitTmEFDzF1bwxz480gSLy1myhYzkmd4FwUwVloPWBEg kw3Q09cDANy1ZTP4Xd9uFOfxc0GDDlmm8B1UVn6FuYRLjEPhjPuXmUV05kPGEX8KG284 8b5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398549; x=1746003349; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TLH1JzvSTREU0y50Cn9mOsy4ychR1nU69CWKH2jYQrU=; b=Shf7iWRVgrG8FaRGd20C11FQ3R8KpUSkTQzXhDFnIxsGwiPRKiejcWsQQMdUnhA9KV Z0Ux0MUMSGPUaFu/E7P71fW2kyUtO/edQ5ouBJiAPg30zoF46YBqFbG/RTEgqb9dCa0H yzF9Fuyb1qV9+Wh9uDZ9e8tW9Cpf9bAfBUrHia7A+Td14DZRzWqNTXuIZd8wXuTIK8pj O5s/01Jikn3g2AisEqYP60Vo0774RQmOHyhOxSEoYb8t2W50ZzcRry75M6XtzyoMeJyJ tcIVeCFFeB2P1lmQqIfNo39gZDnmpla83i/eW3v+sIry8wx+dz/tg0zh6QUpoHhs5aQg h0Mw== X-Forwarded-Encrypted: i=1; AJvYcCWVvfS0D+HePzS4M6FVbOCDVdx9JgGbIGle70+UN4R5YK3pk8TCIRBaca27RqdzsMAS7jD9cQ68xdbVPHY=@vger.kernel.org X-Gm-Message-State: AOJu0YxioMBmqCnApX+HoNVV89bk04h6CMmmfO127dII5HZR5d8doz+j Ik/w/nQ80odEnMQ2gU/7Q3VjXmN+CDv7OpoLBSBNVBRJjtEwMIWypBlGwiI0Ycn/9aL99Rj/9zC Evt0= X-Gm-Gg: ASbGnctJ5oIPFzaTFdnmBOpu6Dgg1as3WxEMht+CdDrn2WmrfAVQIfg3k18kbh1x3/D hiP9+z+RXtK4997myUkmNAMXvFb6blnVhnyyk9i2UIXWNTII3zbItkp1OxAits3s9xjoj5Mkt5C rDY5cwut002Fud3AmNovRJvpmvwETgL+ldJw1H2qYZVvK980Qdns8qmk/gsfQ0veNhO7AmpUj3J vhf5jCli/BTRqpA33P6gu97bmRbjSn2+Dsmw8tdpaxS83u1CsYcc1y62Gsa1UXNXJZLxHZoQiG4 jyNxrz77LmWvwWoqV5DB52vFNduZD1GkVg== X-Google-Smtp-Source: AGHT+IH8W/feylzZF2EABZ3eDPTmlhzOnWG2w8VOJAxIzHJN0weLObZAJJfvcrFUvwlJ8eUSbPfqkg== X-Received: by 2002:a05:600c:4e16:b0:43c:fa0e:471a with SMTP id 5b1f17b1804b1-4406ab67e6fmr156643165e9.5.1745398548675; Wed, 23 Apr 2025 01:55:48 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44092d3654dsm17731685e9.28.2025.04.23.01.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:55:48 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 10:55:39 +0200 Subject: [PATCH 1/6] hid: cp2112: destroy mutex on driver detach Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-gpiochip-set-rv-hid-v1-1-2e6762b582f6@linaro.org> References: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> To: Jiri Kosina , Benjamin Tissoires , Linus Walleij , Bartosz Golaszewski , Rishi Gupta Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1030; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Klkz4iiObkBAesFhi0HB9u9IdBbnHegphVVUCmw+Oqs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCKsRD2kA3kI6m5k7SF2QDveYPM6LDKcaZSt/k Z0NCj7PN3yJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAirEQAKCRARpy6gFHHX csdBD/9dlawSVU79eVpqYmkVBPVCu7CJdNudzdR7AhtPo7+7ib8nN/WUj+5btoGFgD1zXgAjykc LnSBlPzImUk/2kr81kNbcRTGqQzD9ixUfAfOR6zCLWuyAout9cxOaJy7J62bysIrOGK81SCvcLw VLay9I4A4muuJOn1n46WIFXPBhD9n/31FpPQVlKwFVV+NjytYA6toDLfhG69iKQax0cviPfuvXJ DzzeOdQpZyiU1TEumfCqdq5F8O8nVOPv3y9Ggfjkvvv73F4rQb6Ib+NbJnXoLBUlM1/tkC21nu1 FHMvHkirhRcaJBHKJ0o+afxYfpaqDQzZ1mCTjso7qyREzh9V+TFlcuDN/8NPqtgnsDPUlFJfXn1 vFyF4uYvVDfTlCDryXGjgqzE/iuoIS7WTHXBaAnJEuMk4v3WT2FoSERFt2aePQtgTe1gtcwnKFA NrwjqKJIJvNjnPWTvxtcRLxDy8wfcqs5F6fHHEKeyRdcSdNxuhWaFZ2mJkpIYAdEtuLwwHH+RI8 axl5OJ5hBfwJraP58lPtJVxG5rpMXMiHBbhARaVqpR+Qo62ozgjSDI+Ne1vEAlfJFZ/Wb26zlcv oRic6rvN5xIdGVW54vE5xHOeovhxTe2CkWIE8t1/ETnLh9b4Qvgfh4loopwmBdVssiKMzga5XRh aq1RaoH1l023BKg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Use the devres variant of mutex_init() in order to free resources allocated with mutex debugging enabled. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/hid/hid-cp2112.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index f4c8d981aa0a..a001b9acd2d4 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include #include @@ -1205,7 +1206,11 @@ static int cp2112_probe(struct hid_device *hdev, con= st struct hid_device_id *id) if (!dev->in_out_buffer) return -ENOMEM; =20 - mutex_init(&dev->lock); + ret =3D devm_mutex_init(&hdev->dev, &dev->lock); + if (ret) { + hid_err(hdev, "mutex init failed\n"); + return ret; + } =20 ret =3D hid_parse(hdev); if (ret) { --=20 2.45.2 From nobody Fri Dec 19 06:25:09 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13E1D21FF53 for ; Wed, 23 Apr 2025 08:55:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398553; cv=none; b=PRdSqGkxgRf1MxRHI/uZLIonsbHcwF3z56SNFlcclZqUWDHjLQon5zWfK8WxWzwleH51n0Wo67dtOTRvv0i9B7/r2FwtV22gaAsm5aux1aFQSSONbWcWpuXeAN9OYNX8uQdNQ9mQ5vy9bIOBMVQNJSsAc7V8nQp+E859lecwQf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398553; c=relaxed/simple; bh=f4rrBUhgOpzh+3JNJavQZupBM4prajM1lFEhWvBf/dg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Nj87c6mSi5U0T9Kn6/Lyv31apEB4h6/N8SzJd3nVk5G4eBVsEVZZOqRGJg57DlN5KZyx745WJDh4pB4tmQ4qUiK+STlnAU9z12GwrTuEDdp9Vz1vQnrF+Ey97DVU+kkgy8V/oglwdap1t5UcGsp02TCVeHHwWOaW7nIHtNTDEl4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Ddu0I8dn; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Ddu0I8dn" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43cf257158fso39844045e9.2 for ; Wed, 23 Apr 2025 01:55:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745398550; x=1746003350; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4T58djad3er5CX2/ar9SOlYcvYjsbC23ijgjbnHoCio=; b=Ddu0I8dnEEUsPiWP4S6nIT1/WKgOapc0FxG4EVNJbl34/rNY9phUFsQxZc+GmKekhz iwdOiPpwUicpJDC8CBgpFHSTy4e8CgD1tuhHImUYnuZRfA5SNuIW4EFZ5yw7GUv6lbLU ySsXYEsDoky2rrdixkJdACw1b0ER7CV/rjpCldoJt9DqOnzpAuQFIw7qAp0DDmDnlQZd 5QdhEYLSla5vp3tzGKapcQScRiwsNN0QEHhukOJG3Z+nGimaNcRYmmUEx6+ggmDRA4ZU LDMllrrW5e36pPwJlcb1N/q/opLKBpxrZRJGzuhRVzqtkmUvoQ6dySwANtCVQHYE6zU8 xciA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398550; x=1746003350; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4T58djad3er5CX2/ar9SOlYcvYjsbC23ijgjbnHoCio=; b=XOOO360xUPvHXhqSi5ije9XwQQBx3VIIrEjmv6KJ46/yJk7xstRUXyYdf/T8qxMBUW 1FoOi7D+tFIMHmfjU8KVnq01Q+zQxuVNECd59Osx4YcD20gsWnjm6TsloLsZfYH6shxp oew0ksmkclRTG8eiJqm6/PcF29ejhy8oPIp5dHEx8lxo0mZP9mlf2GdQgLm9rvuO92yt ayUoshN2CVf1E3QenL7BVfKvSfFdNUV3DOabtyeflJ3qyhXe4cYNU1p6VWhN9g5TMuSW Pr9ReoCUt4VkTIx4HTcP4J2pdCh7XxtIUpJe8ACYJxZMB2clOTOE0HRbWdeg3PwNRHn3 5Ytw== X-Forwarded-Encrypted: i=1; AJvYcCXtNmAeJxYdhmQ54V9QGuJ0CFR500Ebh0VZ4j64aHwTtg8m0rVUNsims+VOD+LbxjA4s+mbd4aXUHSDlG0=@vger.kernel.org X-Gm-Message-State: AOJu0YwoNyG4qrlxQ0LmRNRh2X7IRobFGGNGvNHNbZ+lZ3omixMyPtXI gDzg9UiYBFKu7Gp5KRL72FuSPf0BjRhni42scWk/CxNzpukfUHHf/LFQHaKYsvbjX88cH3NQSES r4fM= X-Gm-Gg: ASbGncuY4ddS1X1d5PILxhQNyPx+QLM1UkUykEpQAUvf6hN5S5ieV3jdyrqCdIc9VZW yqUBdTRavRP5/iajpbpbyxHiT2nzoVNHunjT09lxWepaBoR9SJhI3VEKjasNc7zPu9RV872cNVE hyaIFILHQS4T5rAILdtVXnasfKffXffPPMQELZ5hzwCu+1tnHKvrmNo6ipm4XnMYjcd+svDsm3W rdp9tPb591w+4kVhidt4qWQVLpeRXEeC8nPuo1P5zO34E8InwJzXHahJWc0N0515hY6B8DXAhUl ocBluCejAyKOwR7ls8RarlQ6cuNHUDxDS0defNUlA/Mx X-Google-Smtp-Source: AGHT+IF/Wfdl1Qet5R9XddWiu7o4ixM4STVgqh7+MB0HBGcE1HZ2xR6oPyuHIcNqh3yLZhRhP8ed7A== X-Received: by 2002:a05:600c:54ea:b0:43d:649:4e50 with SMTP id 5b1f17b1804b1-44071595935mr109726675e9.13.1745398550153; Wed, 23 Apr 2025 01:55:50 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44092d3654dsm17731685e9.28.2025.04.23.01.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:55:49 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 10:55:40 +0200 Subject: [PATCH 2/6] hid: cp2112: hold the lock for the entire direction_output() call Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-gpiochip-set-rv-hid-v1-2-2e6762b582f6@linaro.org> References: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> To: Jiri Kosina , Benjamin Tissoires , Linus Walleij , Bartosz Golaszewski , Rishi Gupta Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2374; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zPoDCiOhyCgx1msLMUahYgfSgpd80S2g0PWtxRTsrIE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCKsRU+49zvvyqzGeZcgBld9BLOfQq2/dLbC3y 2+6Mrd00UyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAirEQAKCRARpy6gFHHX ci3AD/43IoK7gttMN3PmI+yZb/IlQkEI6XN8ZywPHTt0PMLtMTdXsQkjdJBzt3HXbf5NXD+eKEO 3yiU8gMCoD/rqIzJDXI0B4ymD0oEHwGeBESbLxKap0uG/eWUfOlXqc94d0+aHkm16QRv5yKBCbe YS8EyYrVz/59Mc0ks4AeUe8LFvGEM5bfIW0k8eijRcEFo/SZYK9rUi5VVCL4NjseuNyWy7f+rIi 2SZyLWw0Iv/a6zV2V/v+mGDheG5YdrNMXbY0TFL7Dcj8f0PRs0jU6pGJEPtPqzAvu/WsKsV+Zms vjudmut4pu9im8FS3KSAiNg576WBU+F+HWZnv3NRRe5XBPVXIQpCAEitvRamvlYukv4CPt0mQYG DoNowICkVaIes4g/+9QtzGMGPgKqpAttht3O2DQI6DZx+cJ0f0P5geh8O+kavOKhhiOirhnol4q 2X98FwSEAzv5wS03AQyjHrEmCXj7ixiJtBMv9NoAMBb17ioHVUW09/MASvZ9fpb7IrCOfS0iZRj dUWgLl7dpHhAPhX/1hqx/OjnEnf9Z3NfcEwciWY1lsHK9JG92i22supc3+Nfp9ZksS09CBm/gau 5mgie0LSYS204glpj7kGSXI+TBZD30lLs2jLQg1xHIHW2a/3xjcRWcLG7BEPuDAZh5f8i4WM0nX IveqQJE+6cPNVLQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski We currently take the lock, set direction to output, release it, reacquire it and set the desired value. That doesn't look correct. Introduce a helper function that sets the value without taking the lock and use it where applicable in order to combine the critical sections. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/hid/hid-cp2112.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index a001b9acd2d4..408c865efdd4 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -17,6 +17,7 @@ */ =20 #include +#include #include #include #include @@ -218,15 +219,13 @@ static int cp2112_gpio_direction_input(struct gpio_ch= ip *chip, unsigned offset) return ret; } =20 -static void cp2112_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static void cp2112_gpio_set_unlocked(struct cp2112_device *dev, + unsigned int offset, int value) { - struct cp2112_device *dev =3D gpiochip_get_data(chip); struct hid_device *hdev =3D dev->hdev; u8 *buf =3D dev->in_out_buffer; int ret; =20 - mutex_lock(&dev->lock); - buf[0] =3D CP2112_GPIO_SET; buf[1] =3D value ? CP2112_GPIO_ALL_GPIO_MASK : 0; buf[2] =3D BIT(offset); @@ -236,8 +235,16 @@ static void cp2112_gpio_set(struct gpio_chip *chip, un= signed offset, int value) HID_REQ_SET_REPORT); if (ret < 0) hid_err(hdev, "error setting GPIO values: %d\n", ret); +} =20 - mutex_unlock(&dev->lock); +static void cp2112_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) +{ + struct cp2112_device *dev =3D gpiochip_get_data(chip); + + guard(mutex)(&dev->lock); + + return cp2112_gpio_set_unlocked(dev, offset, value); } =20 static int cp2112_gpio_get_all(struct gpio_chip *chip) @@ -306,13 +313,13 @@ static int cp2112_gpio_direction_output(struct gpio_c= hip *chip, goto fail; } =20 - mutex_unlock(&dev->lock); - /* * Set gpio value when output direction is already set, * as specified in AN495, Rev. 0.2, cpt. 4.4 */ - cp2112_gpio_set(chip, offset, value); + cp2112_gpio_set_unlocked(dev, offset, value); + + mutex_unlock(&dev->lock); =20 return 0; =20 --=20 2.45.2 From nobody Fri Dec 19 06:25:09 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30A151F09B1 for ; Wed, 23 Apr 2025 08:55:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398555; cv=none; b=GAo4pfRaycThGYafmhMJ5Wqna3ARKdYaPF+RCpyF7ht8V5cTy5wknRTkNABLROcfi3/PcETdMWjphOuByQX6g2vQ06YEkKXkHrDEfUmPXq71hrWnlEPfkXrFeIwDaPNgC1V+dLtSfbKiQ5/zCyHBPdfkvNjBx2tVyqCzeFlghGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398555; c=relaxed/simple; bh=ZKUX3nw4FZjC+N4ScPc3tAK+DbEUS/qVAgsD0lmzRTs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DHfukMgIrz/o5ARxnxpC0MN1taf5YRtYc627OYsqpCQ4mIgqJ7ON7LIKpWSkF1ujdYxsMcrPfEZDBSWEud9KRBzzpGkAhQ97CY0RV1rqjhlkfUd2D6cYN7YNSRMGg2Ikz8meAsHSSwF/RZZ9glWJcN4Suqjq12jBymUiFsQ0C1A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=dv1FAvLg; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="dv1FAvLg" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-39141ffa9fcso3558563f8f.0 for ; Wed, 23 Apr 2025 01:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745398551; x=1746003351; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CRQAzpylpQHW7wjn2Yy3ejHzxEGc6mOpxfcsgicq3lM=; b=dv1FAvLgh64bifJihDkavG07VIWBZztaKHR9k0KD43kwz9NsRLgB0BnkMd/1EZ6+r8 9Z19Jaa3Sgne1LRofVtRCfdDTmp7JzQgHETqZGQuA1DxVq+sv0uA9GxX3dBVoftK5LmX tIBSAd8f6AAW6ax6FFDZAddF+6ZTaDcfKYk5iOyZvyO8yPrHfXFqYk9YZlkewJvxRt8z 1WskaHeL/ndJFwU+oaYozajb2G/ijcaQs1yczVvcAQsidB8xA4/y3SHC+9NKkp/Glv/E sADTWIeApObbedvid+iWPFc0C6ZvbbX7URc8fV8p8On4j3wb4YkvO5J71aY8pJz+ewwL bPUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398551; x=1746003351; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CRQAzpylpQHW7wjn2Yy3ejHzxEGc6mOpxfcsgicq3lM=; b=Onwu2HxRpwEEFotuwDmPDlDR8mijvV5Q1IhudIgQWFthGyi0y3xYOlbxnNAVhYrBT3 9K1k0rVCdcY01kBT4rqcVpP6lrSfKp47+EhNYk29ScytlGFIFyKxhiR3X8x2NksImuSg TFXod9dCw3ruMP9UoKe6UFFeiK5OKpQHi0jOBKNKo68kQLHN7Nz+rW2b4dn5MmGv0cOO VU/gp4duoOHagD3ttutuGG1z0A7j2cGDvawQqqgQWeNM8nPlFIle1QKHTXUbmmJbmHMn 4Ah7mpYYTpVU2B1CYEW0Yeg8hJ6NaNxEcSJL1/uEJqMacLFrEeEhYoMo1eNeLAqojdlD v1ng== X-Forwarded-Encrypted: i=1; AJvYcCV2iEwT6a3dS/rjYm++OQSXg3/ufbWzFC57B5ipJ9KSb3iFy0nQV29eGJkPyCDL66PehLSPNiRVbDHUk5E=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7CIrg3ogJMJI7EouMIwKzmr/r5Jj+u9+JGvp3HQvqWuUBCpiz yFF3YfdeEmFj87uzUwnA65zjcjHjtryGIM6hNkxCa5UDa3bdHdfEGQPS+ZXocPoOTlnCxONamg3 iass= X-Gm-Gg: ASbGnctYiMaoQjMAKlH4ieKE5Hs2hXhZpF1x9RbsI3F2Wt+y1WFtEklq04Qi3JBv1HI O5DceT0ZURWgPC1zWjqd1GQL137ePkzytR1Jn3q20j+mmKTAQS1OUKPTo2aiLV4wB8YURVsVwvA 1TjXH0tJYLmAlpqs2tb4c1nA5GrZl675M7KgsTdrn+1AKISfQz04rrCNi1A6IC8u0OOfjWwGH+E DresNu4jbIZfXTXSGZklYPPQKLDsDbvxacuMwceNxjt9ZCQdlCkYWnfjBm8TPtvkJA9dv/HmTdJ zXpGd1cLV0oyHxpJFhluSWaIOGBJnV26tw== X-Google-Smtp-Source: AGHT+IGoalfCd15VUlEeIzWF5CGPrSIg5URCnSt8BcRGLzzqD0ZxgfBLXu3CW9QMof7F6AmBeY3yKA== X-Received: by 2002:a05:6000:402b:b0:39c:30c9:815 with SMTP id ffacd0b85a97d-39efba3ce3fmr15132392f8f.21.1745398551044; Wed, 23 Apr 2025 01:55:51 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44092d3654dsm17731685e9.28.2025.04.23.01.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:55:50 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 10:55:41 +0200 Subject: [PATCH 3/6] hid: cp2112: use lock guards Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-gpiochip-set-rv-hid-v1-3-2e6762b582f6@linaro.org> References: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> To: Jiri Kosina , Benjamin Tissoires , Linus Walleij , Bartosz Golaszewski , Rishi Gupta Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3540; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=svsbVswSqZ1RUCT08RBk/vS5nyg6Pd3lS1RPThjb7W0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCKsR/N6zMcg8Ye3ytrtXSvWWOiIfYJxg3rywi bYzY8OzIAmJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAirEQAKCRARpy6gFHHX clA7EACHfVIi2x1uS7Sngv3quCHbq8sy/bhDCfJkvn5O2G9DSvTAsQWYPME8KVA+XFAUmoliGdH FQid4I21DsUd4ML9rZW9yCsSu6hHsvB6d+IBLfqA0qRK60DnmGEuOngBHvVpTL6cB8pbKLrWyG3 Dnkzm4zDPOYbujo7/Eu07KKj3ljHFbWv4qaZFLFb/nqTvCVV1ThvClRN/GDd3nFTs8qKseyI8db QRK8GojnAa4XDThabDJWSHnUMXqHldZJ+jzM0HklJwtL0f57KUoxtmlhSzLKRd73zq9LfYf6648 THljU/jjKvb+QrKT9dWK9mbxqquTasNMDoKnrrpbZ2cutMllgxUCOvaXPfAupyo+McYi5L+4qL3 PAFOpy7RGn8LQgRby5YR8uXRVTl9r693dJgF0w0XowEtoOn3p81aLegOY1pmtgskv3Jg6+22Hle w1wiYqup+vXF+WhVbghNI1tFIqA7OLqiY/UD8SVpfUpGMJidHURMIDDmnuwKRWxKKv1mn+B6r+B tfrlDto/G9Ha4x8Kw2Uk0ZDjdenPGTDYrF0XE6KLuEyKwnxrjRKE0Ey4Skwdk0B0iRUO2Co7ot0 oMWZLYwjZowvcIPxF/HpUL9uh7bEXMmezh38sRzrbu716LflsPRnZHsL/kJUF9Zm2VY6XmI7kG3 GviItMic5e6OG5A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Simplify the code by using the lock guards from linux/cleanup.h throughout the driver. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/hid/hid-cp2112.c | 38 +++++++++++--------------------------- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index 408c865efdd4..92dd891b7b59 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -187,7 +187,7 @@ static int cp2112_gpio_direction_input(struct gpio_chip= *chip, unsigned offset) u8 *buf =3D dev->in_out_buffer; int ret; =20 - mutex_lock(&dev->lock); + guard(mutex)(&dev->lock); =20 ret =3D hid_hw_raw_request(hdev, CP2112_GPIO_CONFIG, buf, CP2112_GPIO_CONFIG_LENGTH, HID_FEATURE_REPORT, @@ -196,7 +196,7 @@ static int cp2112_gpio_direction_input(struct gpio_chip= *chip, unsigned offset) hid_err(hdev, "error requesting GPIO config: %d\n", ret); if (ret >=3D 0) ret =3D -EIO; - goto exit; + return ret; } =20 buf[1] &=3D ~BIT(offset); @@ -209,14 +209,10 @@ static int cp2112_gpio_direction_input(struct gpio_ch= ip *chip, unsigned offset) hid_err(hdev, "error setting GPIO config: %d\n", ret); if (ret >=3D 0) ret =3D -EIO; - goto exit; + return ret; } =20 - ret =3D 0; - -exit: - mutex_unlock(&dev->lock); - return ret; + return 0; } =20 static void cp2112_gpio_set_unlocked(struct cp2112_device *dev, @@ -244,7 +240,7 @@ static void cp2112_gpio_set(struct gpio_chip *chip, uns= igned int offset, =20 guard(mutex)(&dev->lock); =20 - return cp2112_gpio_set_unlocked(dev, offset, value); + cp2112_gpio_set_unlocked(dev, offset, value); } =20 static int cp2112_gpio_get_all(struct gpio_chip *chip) @@ -254,23 +250,17 @@ static int cp2112_gpio_get_all(struct gpio_chip *chip) u8 *buf =3D dev->in_out_buffer; int ret; =20 - mutex_lock(&dev->lock); + guard(mutex)(&dev->lock); =20 ret =3D hid_hw_raw_request(hdev, CP2112_GPIO_GET, buf, CP2112_GPIO_GET_LENGTH, HID_FEATURE_REPORT, HID_REQ_GET_REPORT); if (ret !=3D CP2112_GPIO_GET_LENGTH) { hid_err(hdev, "error requesting GPIO values: %d\n", ret); - ret =3D ret < 0 ? ret : -EIO; - goto exit; + return ret < 0 ? ret : -EIO; } =20 - ret =3D buf[1]; - -exit: - mutex_unlock(&dev->lock); - - return ret; + return buf[1]; } =20 static int cp2112_gpio_get(struct gpio_chip *chip, unsigned int offset) @@ -292,14 +282,14 @@ static int cp2112_gpio_direction_output(struct gpio_c= hip *chip, u8 *buf =3D dev->in_out_buffer; int ret; =20 - mutex_lock(&dev->lock); + guard(mutex)(&dev->lock); =20 ret =3D hid_hw_raw_request(hdev, CP2112_GPIO_CONFIG, buf, CP2112_GPIO_CONFIG_LENGTH, HID_FEATURE_REPORT, HID_REQ_GET_REPORT); if (ret !=3D CP2112_GPIO_CONFIG_LENGTH) { hid_err(hdev, "error requesting GPIO config: %d\n", ret); - goto fail; + return ret < 0 ? ret : -EIO; } =20 buf[1] |=3D 1 << offset; @@ -310,7 +300,7 @@ static int cp2112_gpio_direction_output(struct gpio_chi= p *chip, HID_REQ_SET_REPORT); if (ret < 0) { hid_err(hdev, "error setting GPIO config: %d\n", ret); - goto fail; + return ret; } =20 /* @@ -319,13 +309,7 @@ static int cp2112_gpio_direction_output(struct gpio_ch= ip *chip, */ cp2112_gpio_set_unlocked(dev, offset, value); =20 - mutex_unlock(&dev->lock); - return 0; - -fail: - mutex_unlock(&dev->lock); - return ret < 0 ? ret : -EIO; } =20 static int cp2112_hid_get(struct hid_device *hdev, unsigned char report_nu= mber, --=20 2.45.2 From nobody Fri Dec 19 06:25:09 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 423A721FF4C for ; Wed, 23 Apr 2025 08:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398556; cv=none; b=IcGKuP9R9P3o11ULBm1GSS7PMdNIKbAOxbTqNia3eb0ZoYjDh46KIh5aiiwAFNs9No5hp/Vrxnt+BpG6Hi2qRgQTglBoW/CvTaXe8XTXfAk/0IjslCoBG/ngBToDzkPsC1BRs5bkUK6PBDFyvbA6TKxLMQT0wH+tYF87lYfYnnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398556; c=relaxed/simple; bh=78erSKRClsMeZtwbiQK/eYXqLE0Qi/RfkYG5lQRg06g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J7Qs9FqlPNYTVrm1gNXewrBURPc/tLjd67KSlC3/mbdK5kVIS390eVXz6TJdzxmx12KzUCnyUw0VBUqdNTuPkRL7Yr6ghjY0GdC98ylWZ/1qAoR7BoB+Jj3Ut0rmBoyT6VWeys4RxYQQqPFIFJviybLyr65QGcu+lWeSHKZGteM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=JeTIT23d; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="JeTIT23d" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cfa7e7f54so5087285e9.1 for ; Wed, 23 Apr 2025 01:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745398552; x=1746003352; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xU+q6B+KeVc9Dotp3+HXW8/M81FKVZlxFGFb0G5Bpbg=; b=JeTIT23dk7LAG2SWSF6CwlCSARH6KAk7Cf6JJHcGQN383WsvbCa8Nfn6F3qgYc4sSJ YZAeFOerEfqoDMaePDdsSMhOOcEVYFae4VU2V4IoX0i7q9NXp74rJIRIsgQvgsycsm+o +aMPAus02h25P5RJmBqxerrrTwREelDdfNb7HWiHSls0yx0qdRgsuu6TrJYiSBCIBmu4 COzblGKAmUcyvuN0FHvsKp7gYf2JUFzpll2R42iERYc99stuYQJ9IzJ+k2BqBWOmEUS2 rjjQ7ouZh11YLoklx1zkGoolGTTSjo0cHZdgiNEtNlSl6GKgADA1USevhsaOhg7SG4XF LHgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398552; x=1746003352; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xU+q6B+KeVc9Dotp3+HXW8/M81FKVZlxFGFb0G5Bpbg=; b=tcjKAsGBD0NX64GBWfZDTB2zZJjzBwPHG7i6P+a3xbxRLJ5z3pCluC7gkiCnkVk9W4 fQn+6T1w7GtPbfc+RvIa3ROIOryT3z0MM9A7Ihm5ODRIrrtVXIhCPDh6dj/0a97R0Gn/ 0CS4vXvbaPx0N50xf5ejqaKLqkL2mP0f/qASLkM5/+AsJOOpgzwmDIDwSFeSi7A8pBoO Jf7P7yDl4oTgibzMnHZq1mN2AcfeU5/QTcBfvgTQd+ZBi2D1maDyhLMrO0lKhOQbsKtB /IVwkcKYxTqipIHN2Wp6y7wP0j5kiIH4t+jHGOHvlsrGGB4F3UwG4ugbrm0lOIJNRf9g WFng== X-Forwarded-Encrypted: i=1; AJvYcCUEzP5fWmsFt6lO2EeKx424peig2mwNm7+uFE8/7bjoLZB2tIYO2KK0anW3uw07pIQ1ZcHMOOn1AHm0epE=@vger.kernel.org X-Gm-Message-State: AOJu0YzNcQp2dAhJ3WSmcNe6jhKHyXsYt0Yy3D15+P6KA73gjZwhdIHs j6UatE68CODDjm3OHIlgLaM+ulN3VZdoyMeksLp3nGtrZcUALc84XNePNnmJKOcFJ/3CClxF7Th ahyQ= X-Gm-Gg: ASbGncsYEzmAaYjMGaDPOAK7yYc/1WXWa2d942kCO//hHC5M0F0P9DMw93kbgineiHc lIqfRAu0Ua0SyIAVbqx4+A6N+02yXAlHi8FN1VJh/DAWHBhuWpxXwFuxfF7oxViMiCGwUucZegR kafsBpLb19YoEjZIJfDZxoSbasAdOns8ZkjfSGwf8Ip0mJahJv4hCteLPqWIOUw2V3u5F9j9Lk2 cp+RCmfxBVvhJCOzfO1ws16Jyq8IrEnFhikJYQ/K4g+hene63rIyVme6DyqaBqXE172dEqeal94 LheFjIpVqG+ooBH231Z5FrsUzfbgfTzllA== X-Google-Smtp-Source: AGHT+IFsnUHyXLc/V2ofKcW5mQzbrMR2fSz2s4gn5/R5CVyacBF7IB9KCUsiHcaRQw+s8v12JkDS4g== X-Received: by 2002:a05:600c:1d1f:b0:43b:bfa7:c7d with SMTP id 5b1f17b1804b1-44091eaec9cmr18708095e9.2.1745398552009; Wed, 23 Apr 2025 01:55:52 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44092d3654dsm17731685e9.28.2025.04.23.01.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:55:51 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 10:55:42 +0200 Subject: [PATCH 4/6] hid: cp2112: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-gpiochip-set-rv-hid-v1-4-2e6762b582f6@linaro.org> References: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> To: Jiri Kosina , Benjamin Tissoires , Linus Walleij , Bartosz Golaszewski , Rishi Gupta Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2030; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=3m9eD5np0PCYm6CXzEmoZHY1+lpcLzL/5hTmqHLPJkM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCKsSzMLGtDZLUYWUDyAUa7jdtk9GnBimJcQX2 SoTdL2SZ1aJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAirEgAKCRARpy6gFHHX cgzCEACfhjBYKX9WaY4Rj6j6dY6Nsm8jaTIw+76AGZPtpSCeseU5lPyTyVk0kfxUseBanQoYcsy AJC2ReKiFWZ8x93TDQCuXc0HPRpsJxSwH58DQZmdSpeWtYl36D40pjvVdlaUKJPEGh3M81IY53y W7qPcBz+CaA5O3p8ijVymEwJxGcVD9Q5YzGouWP/rQnIJYavqitbMr/C6D11wOvpbkcCr76KKvT LOFuNGZ9qvyg/7GpRGoDw/nPyndmQOLAZFqk2LWwM6IITlvVRrCx/w0wFk89EqrbfVbUaPdg1bn PiQ7G4shFXnhl2te1Ts5uSr8mFglwLYo9HuUbFHPelb4YxR9w9Y/o/NET046Br47Ejn7dbtH/0p XEylhaW2+63qWgabCRvfC4LKks4CH/W2gx1svepYJawFK/YJWdxJYuClSrWGCvxqWuV27CjDncD 3pfif/fk6my5n0ECt+XOhz6FCENCaHRHwp+OxEdOt/Jr19MKGn/Z+d6DdU5Po9KIvdTtxz96kwL WCuyuLyXkDvxs6LinqpRNdlMT495MVXKhtk5FlCz5yVm7t6R+69y8MJEo6HL9djCLhUWmq6renD i6iTn5Byw618DT5kDY57X1Cz5FA+I5u6CLVjKjWu8FMcc/8+SlH4Sb+MgpTQrkxwn+gG1U+6sY9 TfYmnorS8l3zKfg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/hid/hid-cp2112.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index 92dd891b7b59..234fa82eab07 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -215,8 +215,8 @@ static int cp2112_gpio_direction_input(struct gpio_chip= *chip, unsigned offset) return 0; } =20 -static void cp2112_gpio_set_unlocked(struct cp2112_device *dev, - unsigned int offset, int value) +static int cp2112_gpio_set_unlocked(struct cp2112_device *dev, + unsigned int offset, int value) { struct hid_device *hdev =3D dev->hdev; u8 *buf =3D dev->in_out_buffer; @@ -231,16 +231,18 @@ static void cp2112_gpio_set_unlocked(struct cp2112_de= vice *dev, HID_REQ_SET_REPORT); if (ret < 0) hid_err(hdev, "error setting GPIO values: %d\n", ret); + + return ret; } =20 -static void cp2112_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int cp2112_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct cp2112_device *dev =3D gpiochip_get_data(chip); =20 guard(mutex)(&dev->lock); =20 - cp2112_gpio_set_unlocked(dev, offset, value); + return cp2112_gpio_set_unlocked(dev, offset, value); } =20 static int cp2112_gpio_get_all(struct gpio_chip *chip) @@ -1286,7 +1288,7 @@ static int cp2112_probe(struct hid_device *hdev, cons= t struct hid_device_id *id) dev->gc.label =3D "cp2112_gpio"; dev->gc.direction_input =3D cp2112_gpio_direction_input; dev->gc.direction_output =3D cp2112_gpio_direction_output; - dev->gc.set =3D cp2112_gpio_set; + dev->gc.set_rv =3D cp2112_gpio_set; dev->gc.get =3D cp2112_gpio_get; dev->gc.base =3D -1; dev->gc.ngpio =3D CP2112_GPIO_MAX_GPIO; --=20 2.45.2 From nobody Fri Dec 19 06:25:09 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12138223DEB for ; Wed, 23 Apr 2025 08:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398556; cv=none; b=lDSS6vYK6vJdExOO3WRMN2P2weZH3vNLhxHcB+Q1Z0nI3y2QBV/WBvHKu6dkrU4X5Jpy4hbA2++cdyceHOj9nEgAB5TcjHMzpHgZlNPVcnnvbVB3pdp7YGqH2A/QTknuje/PlcWegdW48aBgHElOq08y+R4LNg4j8FjrYuBdDzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398556; c=relaxed/simple; bh=IpkDgplwnpCnmf4TZWsszBJ6O9YeA9J/UngYhMFFKwI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dm+gmO0ieT7C7UAgZ9WBVKc50v/Rosx8BzZqkIm2rxcgFKQGiH6o5gmE6doxvLLA7Rh1W+6GSrWzZYq3mMwAH7j4Kn3P0Vm9vJ/1rDXKvHtdT8Yo7HAxAIn+m0wteUUMe5jBSXGbqK/eJ919rIzGaIRkmN8jocWQ+1s5VQ7oAg8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=qcSGcrQM; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="qcSGcrQM" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43cf628cb14so5268405e9.1 for ; Wed, 23 Apr 2025 01:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745398553; x=1746003353; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xujYyKOLUtbIFtoGOYN4dvZkp51sWP9BMyF/9rfhfB0=; b=qcSGcrQMh18Mx4145cYMqd/1snbM1UEDoTxljRxypOApiN6oRkkYR8EKt3Fg6R5pQi x700h6xa9MqJEzajCr5sRD/Lg909wr6kJrcZU96P2LCdC9beWjVu6hOFlOifoFEGn1uf /kVR6p0U5RXenA8B3Ve/w8/Sk/MYRloYBGP/vJMxApaL+QunNX9/4DvX3LFDhlahCdZC /jvsbcYi1owsOYAImEaieReHWqFNiwd1K2x0HPUHFyHRCkoayEd2bvxOTG4PCw6uULvD 6tavErs+ziV3IjYHQV1zWs8sFss8hBw5lTyAF9uloKsO+JQE/Vk4R+Uc0+0tC+we01AK FL7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398553; x=1746003353; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xujYyKOLUtbIFtoGOYN4dvZkp51sWP9BMyF/9rfhfB0=; b=Kc85mUqueLXkZh6Ig18Q8pliGe/epkaLt1RV8mh79gCMsGeLkPZspjAH+WIzPdgVSf /x8fB6Vt2z/ZplsLh1gKaPDzZ40rKZtzWSa1tAixPKyeyVV4PDr+AvjkqdWEI3z/QdcJ ps4FOKqwnrh9OVKXm9XQmtz6gpvvlBYSrJqiIKqmdhpKQdsYW4EpM1PjI4ikBgP9UAs8 qAKy90tlSf/nOIaFqpMo25zdTM4vDpabddTXIAg52BI485iEeBvjlyPIEA02eZaKx0Oa JUPCT0Nx36cqStZUYYCS8F5kAsb1yRag5B7KDjVbMlt2lJWUrf5gYaopwsC9r5rfcw6V 13Mw== X-Forwarded-Encrypted: i=1; AJvYcCWcPtpvnmuGqeOUAHFP0b3p0L5H7B7RZMzSDP88Kskd/+AEoApw7+38Vf9sOHcwPM6dgo5xZezRMtvgtdk=@vger.kernel.org X-Gm-Message-State: AOJu0YyKQ/dM4xn2ZliRq+v2dNtfT2oPl2Vv7o6nu0r55WJOchm+NYOS TV0RdyyTvzOPLLLtWBGXXh7hy2jBore1fIH0h15sGAN+fJzh7JiduUn1wPeDX+/HlcbDHMbQfmm U1vI= X-Gm-Gg: ASbGncuABRKR4OUlqY8SAMWp2kWRbfNeI8aYGUPx6pjVwl22/lKaOpkf2pxAy50CNTm bd3HjhaEgC5rdyz82MRfRk6qZi4tJNOCfBrsCkZPmxe9/7EMnMxESPD2zH/qkg2iKS1sBUOtkPq tX9AlpQOmBf8pBwDsZ4Q7QTvDqRgQZDHSwB4xEiBMYibAyw+9AXa4LKdf38oj+X9BwkG3+nrLbd ZhL3Jg8K+4Rf5W00QVGfWOJd2aM3uW8hd2gTc9cxSd1qB4bZ2QL879PRNZOe8mKREBWiasCOmS4 E6pJG+FHjTN5pF17lvZxuZ4lCuNIuDtAv1N6RnKsCWuF X-Google-Smtp-Source: AGHT+IH5O0o2mxC9oUy2yMKuDfMRopZF/pet7Y3HVnOv2ue1C+p/vz/hM7WvcmmLgF5cF1LDMRJLzA== X-Received: by 2002:a05:600c:3b23:b0:43d:186d:a4bf with SMTP id 5b1f17b1804b1-44091d2e039mr12818225e9.0.1745398552941; Wed, 23 Apr 2025 01:55:52 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44092d3654dsm17731685e9.28.2025.04.23.01.55.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:55:52 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 10:55:43 +0200 Subject: [PATCH 5/6] hid: mcp2200: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-gpiochip-set-rv-hid-v1-5-2e6762b582f6@linaro.org> References: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> To: Jiri Kosina , Benjamin Tissoires , Linus Walleij , Bartosz Golaszewski , Rishi Gupta Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2393; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Xe8t0cpiuXJK24uNCrjJrCuXqwBBlo0SGHtnD96+ABQ=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCKsS6nROAKUfKKPoUE9uts+jWoWMp4vrsAXyn W4jFsTpftGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAirEgAKCRARpy6gFHHX ckaeEACGpatmiJ9qt1T6hsGmMRqs2sFqWxlzRfU+OQx9iR4FdQC32TPbMOtJJRAuxCFMk0H7+0E AhxxwbdSJ0NlDOwGDXWV5Q3hESoDwQT1O2BkWq+X2PS7ZTL2DPQlvrMAswo0ELOahpCI82k29Ck KhfhUftY2CaInq2Gq+fBlQjltAFKAx5otmFMoBQTJs7bMKfJrhXUn4okq3/UuSlgxKM4GLsh8vD f+GXt37rNtuKUh/lQajSBsFAZbDMRGFM7LKZITTB0UvNsD2A5vpi79R/Qnxcoq0gEHALMFzE3nv NqSOsTDaD9aEM5V0aEvXTntCgXf8vr72Qskq9HlxFwwbzHTSMFTy1RyksLsbzEeTs4Kq5+Hrtkr sW+kSabg60nzvxTccwAg285BW60P0x7A6XTja0lWLx9nLf6vPVqlgyAy9wXwtc56qPIMTzLvPtv Eua936FnGDq6DY9/JAkTkYbNXRMZuI0p1/oMVOxdyzM2qtRxRJy7qARGA7PA9FsCbJ/fyp2wUii fwCIzA9KQ1RsdXHom4hBMTvA/CxSb5SEMss3nrfP9XvjNLpoz+j6oxYYY/bQMV7bFiNH2LOeJwW xuE63LhVXASlR8thZZyawKE+qcA29IyschYh7EW3aE2V06r1M5vqggDuMBN+XYTujbNE80JNDNR awhhR5u+RCPd83Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/hid/hid-mcp2200.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/hid/hid-mcp2200.c b/drivers/hid/hid-mcp2200.c index bf57f7f6caa0..e6ea0a2140eb 100644 --- a/drivers/hid/hid-mcp2200.c +++ b/drivers/hid/hid-mcp2200.c @@ -127,8 +127,8 @@ static int mcp_cmd_read_all(struct mcp2200 *mcp) return mcp->status; } =20 -static void mcp_set_multiple(struct gpio_chip *gc, unsigned long *mask, - unsigned long *bits) +static int mcp_set_multiple(struct gpio_chip *gc, unsigned long *mask, + unsigned long *bits) { struct mcp2200 *mcp =3D gpiochip_get_data(gc); u8 value; @@ -150,16 +150,20 @@ static void mcp_set_multiple(struct gpio_chip *gc, un= signed long *mask, =20 if (status =3D=3D sizeof(struct mcp_set_clear_outputs)) mcp->gpio_val =3D value; + else + status =3D -EIO; =20 mutex_unlock(&mcp->lock); + + return status; } =20 -static void mcp_set(struct gpio_chip *gc, unsigned int gpio_nr, int value) +static int mcp_set(struct gpio_chip *gc, unsigned int gpio_nr, int value) { unsigned long mask =3D 1 << gpio_nr; unsigned long bmap_value =3D value << gpio_nr; =20 - mcp_set_multiple(gc, &mask, &bmap_value); + return mcp_set_multiple(gc, &mask, &bmap_value); } =20 static int mcp_get_multiple(struct gpio_chip *gc, unsigned long *mask, @@ -263,9 +267,10 @@ static int mcp_direction_output(struct gpio_chip *gc, = unsigned int gpio_nr, bmap_value =3D value << gpio_nr; =20 ret =3D mcp_set_direction(gc, gpio_nr, MCP2200_DIR_OUT); - if (!ret) - mcp_set_multiple(gc, &mask, &bmap_value); - return ret; + if (ret) + return ret; + + return mcp_set_multiple(gc, &mask, &bmap_value); } =20 static const struct gpio_chip template_chip =3D { @@ -274,8 +279,8 @@ static const struct gpio_chip template_chip =3D { .get_direction =3D mcp_get_direction, .direction_input =3D mcp_direction_input, .direction_output =3D mcp_direction_output, - .set =3D mcp_set, - .set_multiple =3D mcp_set_multiple, + .set_rv =3D mcp_set, + .set_multiple_rv =3D mcp_set_multiple, .get =3D mcp_get, .get_multiple =3D mcp_get_multiple, .base =3D -1, --=20 2.45.2 From nobody Fri Dec 19 06:25:09 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 126511EFFAB for ; Wed, 23 Apr 2025 08:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398557; cv=none; b=FR0B9hCFyEuiGKEcdeN6Ptk/ds6l53RJSeux7GNMUL8pHNcstEFc26Sd1gT6ruBx5c6yP9y7CeS803pqpdKNbEJaIaTMkxPWxCRA5+y7gkcicVvq4CvK++WaUeeOOr7vcL7givWikBPZevIvIBLPmmc82PIFYPK26+wRrdyNoI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398557; c=relaxed/simple; bh=Gu/0qJDe/6CF3S+aMzTZR6rxmUbFtqhRKTSk7r76mcM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ubFdiU1e0SmPxVx4CQ7flAZlcKRP9TQ+T3IOwYDSjFi4/0cDEeBDynqPpT+ZG46IQofoGJ8VWYb4i4X3Bds+MfVuZLh/zTXj9ECvJj8AxYMHBjPgHtuwQbVVcf0DYMl70GxXJpv6sx8dzlx6Wm6oVV3ZdjFHlcCKdm7EuDL8Lco= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=N3Zzl0XY; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="N3Zzl0XY" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43ed8d32a95so53286595e9.3 for ; Wed, 23 Apr 2025 01:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745398554; x=1746003354; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ccxqgGOTjGbrDoOEv7tkVOvhfhH/R12HzGiWH67Hg20=; b=N3Zzl0XYCwA5c2V0LHjxQP6WwN2xX1k73W1bQ/XhiLp5mRgeyuIlPg1ZYHkvV2aCUA vNyVsaSDDzlsX97p+WFi8xm2WADcxg8H5UHkD7qI8DIJ/+Vm2X/m+DVcply9Nxq5XUne bDJtFEZl5FGMNhQanD6c0pdV6gsGY9xN27LnnKAhzui+W5gBIA9HjIcKIdnGPt6uqK0o F121ZpmaX6XPAjhWwwxTGJsTApAwyFRYCaL2+w9z7MYm7rBByyX+d+t0ztTOQdMQ4jI8 Zu7aDWXGZJyJ7woTjlrh/K6W4PnmuUZQepCiD4luK0K9nZZ4sPz/Tgxw9OfMyu1uo9GL UXCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398554; x=1746003354; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ccxqgGOTjGbrDoOEv7tkVOvhfhH/R12HzGiWH67Hg20=; b=gyYWuphVmrv/vFKMP6C/8pHRcTm46SDVCvTF6meEDO/HaHON+55no55H4y0IVbsGrQ lqD6ZQ6NGQp5hpq6cATu9o0rDo1HJxkTUKfTpmRRE5l3BwZE++P3s4Wn2Fh6Dme8SALt 4Ja8rUCr0/DCitnDgEG5pkRbMjtDHu2JWmWvnkVD4aOHSMg01zWBrAgp/uFfCUNE48lB IhMmLRLMmDj7FWOl6dAtVwKf40dzKseb1pnnQvZqm1m9tDFY6PnKoNGb4QojQbXVg+Wo V6QdRCJIQAu33jo3B3Jn7eqVoUh+h+TmLmq4hSM5sGvBju7iaH+3bH1FP4ISYA1sO5o1 KceQ== X-Forwarded-Encrypted: i=1; AJvYcCU2a9CxEK/uAN+gmrr73dUpnIt2sf9zyjsWrUKKs8OO05SQkvMaAfeuW+qc4VddOkwXDc6rirVT4FKXFJA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+fjTfoTZXYwcbnoZAwxUIxwbdgs8DYpLwAFVEedvSutU3JqeW ScHNeptP7Vbel6bOLe4QSFDSnjCPIKDunR2wYMDyCTuzcqFJ2uKj2RhIPCtMfDO6Iq7Az4yMce0 v6UE= X-Gm-Gg: ASbGnctR9nBAehxK7CWBH7cLDqU2VYlNZk2E0QQCiRpyc/R9FMaOU+TQSQVSW+NkpcW AGyICS6fG93CovXc40rknSNnvhGGjfCKTHkyaw3ClKe4Zxe3tDT/fKejWYI0bcy0/6rxs9eIFCk 7gaL8Ock+R+4vVC13wnpfRd+vG71D38NpQRI7bXd/10VhOiQ1k+WkBOkgh9zYHRpX3Lea2fIUTP VYykc/ZaVYeIQmCpZp9tw87MfnOhJNIfV+gy4FjK9TfnbslgHjtvjQCct05NmscM2l3EDPDbtal TCRqWeDbSXFUXGPDKb9hncKiDhopjfruvQ== X-Google-Smtp-Source: AGHT+IGYt9KIPNXopceY/Wz7BYzncJa/dJtRXyS3DNCe3z15St7GRiEUgi4k0Frpx7QsgvxF1rBmfA== X-Received: by 2002:a05:600c:4f81:b0:43c:fa24:8721 with SMTP id 5b1f17b1804b1-4406ababec6mr187469325e9.17.1745398553910; Wed, 23 Apr 2025 01:55:53 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44092d3654dsm17731685e9.28.2025.04.23.01.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:55:53 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 10:55:44 +0200 Subject: [PATCH 6/6] hid: mcp2221: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250423-gpiochip-set-rv-hid-v1-6-2e6762b582f6@linaro.org> References: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-hid-v1-0-2e6762b582f6@linaro.org> To: Jiri Kosina , Benjamin Tissoires , Linus Walleij , Bartosz Golaszewski , Rishi Gupta Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1645; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=MEE5NFlP4KmtuHYj7k9R+CBXmokE3edPEZ0O5ma2pfA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCKsSH/VXonHZEwN/oJAifE3FFvtTpHXFAVsbR csNJghfdFKJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAirEgAKCRARpy6gFHHX ckNNEACGFETGqtGc03ttguBEngNRxDLdl4o8bT8wLRRMmsuoZ7GwjeYdR7gJzGUuauyvr25iefQ WIJtXrAVJRGdo3ywRWDoAoBkcIhBzKODekM+lLb+TfrxGNihZhZc+poRmZP5NFXpbEUNbG/7rLH o+d6KjzKpZh5ScEUwdxphZbuy/OQCcKiIqsxL+Aw32s5oCgFmY4rbuy33ayIW0sfiOTu+r5wTHX ud079wGcIS3vwNbu3mSi+86C9yc8OJHpk/3D5aHB9QuR8apzjwfliXcCIPAcdsUctVF3OvhbIYq XIpGPy3Gj8AYcg5dvQJRPCLnCS2RHjKBbCp+Iy7tnzwletOS653KSQgAd2GNZn1sQ3RYxPlRjjC ARpIH0Xhg5iqg6NCcMfVMrheL1rtNIZdYE5X42rtaIKNRkFTK2ieKSvQ5uVZDCnsjhdtmyiM1Iv WZAZQ8s3HJ7mG6nSwOxPce8mQdpuPYPCiAo0kIsQ4a1e0GRwFUdv7eZQq69eVZ6sWE+ZaddPBA5 NBbV04I/8p2uMrWzHVYb3o1TLsOE3lXREZcQJr0GLIoIxf1Dp/JEfq+BpQ0iTBgmApdrGX8qn7M VKWBDRmRvogkCjJx5HfdhzECCJfcL0HQoo1IF+b4pJFVv0uR9Bgao/miwdPHi2hRs8e6E/W4IX5 H7aKMrZNAetOhtA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/hid/hid-mcp2221.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c index 0f93c22a479f..6c0ac14f11a6 100644 --- a/drivers/hid/hid-mcp2221.c +++ b/drivers/hid/hid-mcp2221.c @@ -624,10 +624,10 @@ static int mcp_gpio_get(struct gpio_chip *gc, return ret; } =20 -static void mcp_gpio_set(struct gpio_chip *gc, - unsigned int offset, int value) +static int mcp_gpio_set(struct gpio_chip *gc, unsigned int offset, int val= ue) { struct mcp2221 *mcp =3D gpiochip_get_data(gc); + int ret; =20 memset(mcp->txbuf, 0, 18); mcp->txbuf[0] =3D MCP2221_GPIO_SET; @@ -638,8 +638,10 @@ static void mcp_gpio_set(struct gpio_chip *gc, mcp->txbuf[mcp->gp_idx] =3D !!value; =20 mutex_lock(&mcp->lock); - mcp_send_data_req_status(mcp, mcp->txbuf, 18); + ret =3D mcp_send_data_req_status(mcp, mcp->txbuf, 18); mutex_unlock(&mcp->lock); + + return ret; } =20 static int mcp_gpio_dir_set(struct mcp2221 *mcp, @@ -1206,7 +1208,7 @@ static int mcp2221_probe(struct hid_device *hdev, mcp->gc->direction_input =3D mcp_gpio_direction_input; mcp->gc->direction_output =3D mcp_gpio_direction_output; mcp->gc->get_direction =3D mcp_gpio_get_direction; - mcp->gc->set =3D mcp_gpio_set; + mcp->gc->set_rv =3D mcp_gpio_set; mcp->gc->get =3D mcp_gpio_get; mcp->gc->ngpio =3D MCP_NGPIO; mcp->gc->base =3D -1; --=20 2.45.2