From nobody Sat Feb 7 22:34:15 2026 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED49514C5B0 for ; Tue, 22 Apr 2025 17:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745344320; cv=none; b=q4F6nYB7SLRpl0B57aY4Z0pSV7cwiWYpcf8a7P8VuOUa5rzNnnlgqDJD6FZZEihH3cAnNCmC7CRXP0vr3YSNZYyx7JLE+UzJsUsrgx+46uHHbRsurYCOlVw/73XITx/gsHKdJJdxkwhicL8A9Pw+A8CRErsCFCnFR2QDo37iWC4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745344320; c=relaxed/simple; bh=glzgGwBa0z73tkF70TipUoFYetOf3XZBdMqwFj57g9Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=seHXQL0lm1S5Vir4c+0km7l3NSXoE292rIAeDXNSFW3BDw7nBGG9i3/QBVZv0bd8hCIe/3Au1xaPMF6M+IypGVeOM7pnYGah5dPcIvCBLItPnnAUHZ1WFlTkUGNoZnFYdNcjCnrdWVItBXWuYMK8glBjVROWWc8q1VzmZn1rLyU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ZnlGoChg; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ZnlGoChg" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745344304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0ydwoQy174fnIeX8b6mxNKv5PHl9MRDMKnEHAr6lH5I=; b=ZnlGoChgOKsekZ5OPX+iz12I89TUzKtNKzNF+PfevamI3YE1aZIidlZwqd1RxZf3qkrPbo Xu/zcKZ/+WgNrYlWGUkU1DTEABYsYPXqUAJFzupWPBq9NqMCfI/1mDgocwnl0tLNylXPWA rY9X0GnmDacUcnFUq34NJV2uDawZnhQ= From: Thorsten Blum To: Vishal Bhakta , Broadcom internal kernel review list , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Thorsten Blum , Christophe JAILLET , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH] scsi: vmw_pvscsi: Use str_enabled_disabled() helper in pvscsi_probe() Date: Tue, 22 Apr 2025 19:51:29 +0200 Message-ID: <20250422175129.27810-1-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Remove hard-coded strings by using the str_enabled_disabled() helper function. Use pr_debug() instead of printk(KERN_DEBUG) to silence a checkpatch warning. Suggested-by: Christophe JAILLET Signed-off-by: Thorsten Blum --- drivers/scsi/vmw_pvscsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c index 32242d86cf5b..4927c6a33bd8 100644 --- a/drivers/scsi/vmw_pvscsi.c +++ b/drivers/scsi/vmw_pvscsi.c @@ -25,6 +25,7 @@ #include #include #include +#include =20 #include #include @@ -1508,8 +1509,8 @@ static int pvscsi_probe(struct pci_dev *pdev, const s= truct pci_device_id *id) goto out_reset_adapter; =20 adapter->use_req_threshold =3D pvscsi_setup_req_threshold(adapter, true); - printk(KERN_DEBUG "vmw_pvscsi: driver-based request coalescing %sabled\n", - adapter->use_req_threshold ? "en" : "dis"); + pr_debug("vmw_pvscsi: driver-based request coalescing %s\n", + str_enabled_disabled(adapter->use_req_threshold)); =20 if (adapter->dev->msix_enabled || adapter->dev->msi_enabled) { printk(KERN_INFO "vmw_pvscsi: using MSI%s\n", --=20 2.49.0