From nobody Mon Feb 9 13:57:43 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2007E25B687 for ; Tue, 22 Apr 2025 08:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745311343; cv=none; b=KkUBESdOISl4rVX/70ZCWVhQYJNTmEoMtWcfM6wICS0xpEscf6HK3TbSc57K3ioq85McGD5eQNH9ZlGG3tjbvMxqFUtl7McaZNrdKHx3EvzJtkSlEFm7NXhfU5QPksVhcH/ockDk1kD1GRkV7LbiXLiuQllktpD4nx/hbN/P+cI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745311343; c=relaxed/simple; bh=EzCnckv9uZo2HPeOYfcjt07O4220J44jVkWlG4oW530=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WFoMAyk4cWQ8/Xjqj72T0aqpsQQGoJf136n3qjTF+jgoLcqIvak8BUPrKc2BEc/oCJ79swIytcPizR3LnCleOhR8Y189xOXR8Uk8EMNzA86qGsUoxFdtx50GpB0i+jhEJTsMClwYMh2sZRlDKcADN0vlwMua+3BA0bOpBoLWnCg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=ZEdL+XXW; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="ZEdL+XXW" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-739b3fe7ce8so3957542b3a.0 for ; Tue, 22 Apr 2025 01:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745311341; x=1745916141; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+kd2q5FNIM78jM5HghPwsl1jyBcissy+tuMihRdmdhE=; b=ZEdL+XXWc38j0cl9qTgvCLaSKSqUXODHil5RYbnuk9uvEwoUrsCxQRWKk+Mz68x2xA Pljt/qutYYTRFWepTlcNhfc5DVDYa2qnNkeWGxiKcUS5hNzLGLfGgNId4JrrKKbxytJ8 bnZlgaDFlaW/Um/alnFdGBORJgeBrPs+B8hy+Jhf1e5pt8Nn10uqd1jo6LBlaik5gke1 ddjF3ELqVGnQnsK40aV5Z4qJY3UP7DGKbZTTcsfZGh02LvIvjNfu/nJh3IZ9l1ocGimI f/ubtfKYOEzZme1QGi5dxYyRLZco4ULfPsj158Nn0glAEzgFIHH7Gb1pSQmg3Wa2cWwV eOwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745311341; x=1745916141; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+kd2q5FNIM78jM5HghPwsl1jyBcissy+tuMihRdmdhE=; b=Qo3h97bsOjDTgMUNuZaialab8bcwFBV/zdGLGZM6Oynw7tu5ueGxzf4IbVn1NPSlW4 ixINQDCNWqlzo71pde1vymrRFDUNnmf4hHStqoubg3+jygMPPvX+Rn/AIuRoVJFAVwCj dhJ6DKoOPcTpX/UzYc+WZeQnGTb8+QYDOmlYIcuswLsJVOsEUPnIHj8G2BpWZpTisdK8 vc5XiHDn3BgTIzSRu6Ma53xPTzi69FUfwNUnsUxFZn6ZwqDaMYqYn+9oqdZnf9m0fdOp /AGqkw2vt/bBIxHn6U4/BmkQUd/xsUSoIfzo/HPBP7OJ9uuiyORRyKJUfwUcJhg5ocn+ rh9g== X-Forwarded-Encrypted: i=1; AJvYcCVLm7rnVrUfCVr/1XI63PAVJ0/5/auid5PtQDFGwPa0eS0vSylHtpsi8yqea50ShZxPWJRdYDbz5rx/DJA=@vger.kernel.org X-Gm-Message-State: AOJu0YzQ4zPVA/ytvZUSWphk8elbo4dyP1noHWHxkGMEANInF5CI/wh/ ba3Bjh+tYp14RcDwk1sC/W4COJm5OElPu8XVtL6SCp2tLw+pcAxze0JEkJ/jePk= X-Gm-Gg: ASbGncvjDhpL7us/qGvLl83KMJ2p79uBwN8dfOdZwshmWuq7HXaSQkPeUTVIfBpArJA fo3DxCY0gAg6e4O4YhbDnEr/Pgnw1v6Qc5YNF6rl4qgMuK88TR9VN6vm6yKSE0ercD0YVS5lfWM XV0KrKLvxYVCnfYp6vhnEYXTb+LsiCgNMIc+qqPql1WTjL8z5j41CPPQX0aBWBnsQj+7Z4Fmy5t HzpnU7vaU9+ScgV6CrJQjTAmCu2v2wgf+1PIEahaPjEPcsNVoD2d/8hKcZH6VDFWuScXelznC3g mViDAAtOqp0DRL2+NH5SQ0rMzoHYHIqql3DRaFqkeWCFsGHNIxVN9Z4vOkVyUqNJb21H+dYQlrw 5CA== X-Google-Smtp-Source: AGHT+IFXZZ39jj72YYhr/K/5oJ3Ngnd4eF5Q61F34OsaTVnM0ysvTXVv8micdw2peLTPVFWC++GWNQ== X-Received: by 2002:a05:6a20:9f07:b0:1ee:e96a:d9ed with SMTP id adf61e73a8af0-203cbc251cbmr24313065637.7.1745311341488; Tue, 22 Apr 2025 01:42:21 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73dbf90d7f7sm8038343b3a.82.2025.04.22.01.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 01:42:21 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Zong Li Subject: [PATCH v12 4/5] pwm: sifive: Fix rounding issues in apply and get_state functions Date: Tue, 22 Apr 2025 16:53:11 +0800 Message-Id: <20250422085312.812877-5-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250422085312.812877-1-nylon.chen@sifive.com> References: <20250422085312.812877-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix PWM apply and get_state rounding to ensure consistency between setting and reading values This fixes the reported errors: pwm-sifive 10021000.pwm: .apply is supposed to round down duty_cycle (requested: 360/504000, applied: 361/504124) pwm-sifive 10021000.pwm: .apply is supposed to round down period (requested: 504000, applied: 504124) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index 6259f8500f71..065d6d2b84bc 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -122,8 +122,8 @@ static int pwm_sifive_get_state(struct pwm_chip *chip, = struct pwm_device *pwm, state->enabled =3D false; =20 state->period =3D ddata->real_period; - state->duty_cycle =3D - (u64)duty * ddata->real_period >> PWM_SIFIVE_CMPWIDTH; + state->duty_cycle =3D DIV_ROUND_UP_ULL((u64)duty * ddata->real_period, + (1U << PWM_SIFIVE_CMPWIDTH)); state->polarity =3D PWM_POLARITY_NORMAL; =20 return 0; @@ -157,7 +157,8 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, * consecutively */ num =3D (u64)duty_cycle * (1U << PWM_SIFIVE_CMPWIDTH); - frac =3D DIV64_U64_ROUND_CLOSEST(num, state->period); + frac =3D num; + do_div(frac, state->period; /* The hardware cannot generate a 0% duty cycle */ frac =3D min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); inactive =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; --=20 2.34.1