From nobody Mon Feb 9 21:23:15 2026 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42F4A22F752 for ; Tue, 22 Apr 2025 22:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359728; cv=none; b=Id04Dried2P98Xh4hcL04klWOBIA3qXEcHSCnEbPX8JEgCEO+zLlHDhodCE8bnCdEJZj28e7ONbq0wnXfrvk0a3Rcg4yNGTXWwJ1PeTpcIaj4BQB1hh+DvGzj3TXlRSmqlESyyZJD/ycR5Xf0OsXABlobw6WAg+R9OK/APTNV+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359728; c=relaxed/simple; bh=nCzR1/emrbeUL84tCt3IiYuUEVzi1rCzDn2Z6fqJM44=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CGEKb6tqvcaueDBFnVrtw6TavFYvRkgp/rAlM0dSgu5mhuKk+XzRwVPPuWC4ebOxY3SPuxZEIglwVBs9aXtWwMKF0bPKoR+EzCopxtyAClD4P+szU1tNzcW9zw5Ra335W1tKt/SSJHdnIuW3nzUYJFrXDYJ3CoqZbPlDUGTha+0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=KCOBwBNr; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="KCOBwBNr" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-72c7336ed99so1692199a34.0 for ; Tue, 22 Apr 2025 15:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745359725; x=1745964525; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=H9K2B+Xay9TH+WRl+WF3lyeO5h1JwZugbslpoI+5AHg=; b=KCOBwBNrhb0MyQfMFQaroSKXqmrCq+7KR7e67Fg9b7h3ph4XEkTyLilnMXDKB12jzu c+5yLHSD1Qh2v+FnPYuirb6mfyXrv6nKA2Rj9dt5kZGZV+ji3VSiEYuQGjrm/hP5604D v8KP/SrDiQvcvnyp5hSDVtJ1Qgg/ziT7jpC+GuKfwzpIBwwS2eqcFU0kMkiGoWPA8p+E LmUXkxB929ik+wzcNDMmR1R+OI0orgEkKlULjjDHi0bsPtNnZ/3UVgPDo6FzlVoXU9ye eguOj0RT+dLEnnx+Vt8imU1HX6KqoYOwttlKBspNAOwEQkumWKTa7JWnUI0ctyPaDYjc 297g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745359725; x=1745964525; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H9K2B+Xay9TH+WRl+WF3lyeO5h1JwZugbslpoI+5AHg=; b=mEE3sN7mOY5yS29GmuhvPhvR+wmvu98te5y12LBhz99B+GdQU5h9KNNKvrPcYUWj2t qmxIuDXWnqVK7SQTzKz0dmiECKtqPfXIg+tT4o9XFLFtKTsvNGWyCHxb0/28YeJlddZY rvJ8YHqBY951DxAD6KBoA8kpetKkI3dxnfCbaN0yJla14TN3uCRZY8RRnLNEr0uExNeh wgZOOOmAF7EoFR8sAzR1+GlqxpeqjDOvq/ZEIG6ycP9BpKzwqMwa8Cz4BWnaJ0MToSKW y7e1NQfSuooYlL3ciwxf07Fe4oyRo4OFXFljN5RCKTaVfXrwfU8t2TRC79rpXQddiLbJ PBEA== X-Forwarded-Encrypted: i=1; AJvYcCX7faKcWdsRcoP1KN/56UZgFIXxKlcM8G/Sh3ayzVxWssMyXwPwKsf2ovfdfe/9uYYGWwy5SXzD4NugDoM=@vger.kernel.org X-Gm-Message-State: AOJu0YwxoqiCksGsKd3YTEkoMRCVgUR/p3ofXSVybSU0q8DEF1Rm3N7P TXdrlSGg9a9advXFWW01migvVl+/1lRlwIEp8LX6YI0yFFMQL+sjogMPzVWybjw= X-Gm-Gg: ASbGncuSQRdWWHW/jQh4yzMkKJCAnPxk6rNVoVXtfvCanZlzrx3x8joQtAFTgjUMiqK jNFGWpN1Z84ZVb+Bfo+b4mj3YfwJKS2+dbhBdgWTUm71uEPhRqRD3A5NLuf0TneRBMGBOcWlVNb Z7Dhhg4KHQelTOb1elLroXnv9DJ4cvLqsUTSYrM2+QHnqSsoS6L2SGthPi3LOHZqktR089xERny qENvydrYg2Wh6DH6qXJwNigRrv76NL8+CQST3ekE/WpTdp9yIT9DmGMDVD2sMHVv7sguAb+jMJv sqy4jZXN2lXMiHbmu4CkNjJ4DdKCFbbWcFd4OTmf0hwt+ec= X-Google-Smtp-Source: AGHT+IH9UlcMwP6SptMTSFVihJ/iz9gBXiP46PQmSgYR0lDL6OqVr1KITJanla834aaysMRXitqaWQ== X-Received: by 2002:a05:6830:3813:b0:730:da:1165 with SMTP id 46e09a7af769-7300632c65dmr13414959a34.21.1745359725278; Tue, 22 Apr 2025 15:08:45 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:c8d1:e0ed:ce8b:96a3]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-730048848dfsm2265938a34.52.2025.04.22.15.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 15:08:43 -0700 (PDT) From: David Lechner Date: Tue, 22 Apr 2025 17:07:46 -0500 Subject: [PATCH v2 1/6] iio: introduce IIO_DECLARE_BUFFER_WITH_TS macros Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-1-3fd36475c706@baylibre.com> References: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> In-Reply-To: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2962; i=dlechner@baylibre.com; h=from:subject:message-id; bh=nCzR1/emrbeUL84tCt3IiYuUEVzi1rCzDn2Z6fqJM44=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoCBM9pXsoFeECQODQSXKUf+R+nqAiwzg2R14di eSX7AycMvuJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAgTPQAKCRDCzCAB/wGP wDU/CACaaPDIIK7yQ4QaByRNrsGGx3mAq/LvHL9GakyNv998abhnWQTZ0Ue2ye4vTXEsv/ERja0 vlcjBv6HxuJ/mPV8MzNx6Rah+WZIAe0rcTIuBx4J7i+Mso7eGGVDp/LjMLePye3PYnumWKpavRy Yk0p1RqkgEIhIqTi+GggQYvsJVZ6h5ngl02BhN02xRtAKV46VjQci66m0EaYvmApDuqg0UPNjcZ M96Ap1ZaJxoNNvdMht3X9sIr5zcqG31wGiAQDSdCcdJTM4HYBVdPFlkIcpCGmnytcviPQmjjsxC /8f8RJrpl5Ip4TJfX7L/LddlhzV8vamiGUCUTqizsRvrrldk X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Add new macros to help with the common case of declaring a buffer that is safe to use with iio_push_to_buffers_with_ts(). This is not trivial to do correctly because of the alignment requirements of the timestamp. This will make it easier for both authors and reviewers. To avoid double __align() attributes in cases where we also need DMA alignment, add a 2nd variant IIO_DECLARE_DMA_BUFFER_WITH_TS. Signed-off-by: David Lechner --- include/linux/iio/iio.h | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h index 638cf2420fbd85cf2924d09d061df601d1d4bb2a..4dd811e3530e228a6fadbd80cfb= 2f5068c3d6a9a 100644 --- a/include/linux/iio/iio.h +++ b/include/linux/iio/iio.h @@ -7,6 +7,7 @@ #ifndef _INDUSTRIAL_IO_H_ #define _INDUSTRIAL_IO_H_ =20 +#include #include #include #include @@ -777,6 +778,41 @@ static inline void *iio_device_get_drvdata(const struc= t iio_dev *indio_dev) * them safe for use with non-coherent DMA. */ #define IIO_DMA_MINALIGN ARCH_DMA_MINALIGN + +#define _IIO_DECLARE_BUFFER_WITH_TS(type, name, count) \ + type name[ALIGN((count), sizeof(s64) / sizeof(type)) + sizeof(s64) / size= of(type)] + +/** + * IIO_DECLARE_BUFFER_WITH_TS() - Declare a buffer with timestamp + * @type: element type of the buffer + * @name: identifier name of the buffer + * @count: number of elements in the buffer + * + * Declares a buffer that is safe to use with iio_push_to_buffer_with_ts()= . In + * addition to allocating enough space for @count elements of @type, it al= so + * allocates space for a s64 timestamp at the end of the buffer and ensures + * proper alignment of the timestamp. + */ +#define IIO_DECLARE_BUFFER_WITH_TS(type, name, count) \ + _IIO_DECLARE_BUFFER_WITH_TS(type, name, count) __aligned(sizeof(s64)) + +/** + * IIO_DECLARE_DMA_BUFFER_WITH_TS() - Declare a DMA-aligned buffer with ti= mestamp + * @type: element type of the buffer + * @name: identifier name of the buffer + * @count: number of elements in the buffer + * + * Same as IIO_DECLARE_BUFFER_WITH_TS(), but is uses __aligned(IIO_DMA_MIN= ALIGN) + * to ensure that the buffer doesn't share cachelines with anything that c= omes + * before it in a struct. This should not be used for stack-allocated buff= ers + * as stack memory cannot generally be used for DMA. + */ +#define IIO_DECLARE_DMA_BUFFER_WITH_TS(type, name, count) \ + _IIO_DECLARE_BUFFER_WITH_TS(type, name, count) __aligned(IIO_DMA_MINALIGN) + +_Static_assert(sizeof(IIO_DMA_MINALIGN) % sizeof(s64) =3D=3D 0, + "macros above assume that IIO_DMA_MINALIGN also ensures s64 timestamp ali= gnment"); + struct iio_dev *iio_device_alloc(struct device *parent, int sizeof_priv); =20 /* The information at the returned address is guaranteed to be cacheline a= ligned */ --=20 2.43.0 From nobody Mon Feb 9 21:23:15 2026 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DBE326C3AB for ; Tue, 22 Apr 2025 22:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359728; cv=none; b=N0IFWomsUInPdr5jPXFliQYeTG7zpAJ+HFX3ZCaaAk2uTh8nEwm9HNAah1wRhpvoWJ9zmP7sZ7GTiaUe0LeT/malX5DV4hUyxkjx/80XWL1d7FpUesm6Bg9Y+O2nXHs7sXgWc+OdTsas2H9CaOJIuccY2eEVO4u/Jk0f4xDY3iU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359728; c=relaxed/simple; bh=NLK9rHWGxHgHc450e6JA3Kx5J3+N1Fpz21XOi57G4v0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Owulq52ZuaQrRxudwkdPE2TsonWAv1ooll4vMlPE9wNtkyRLikfKcTPsJTqAUaD1rpwZsSKXeQJNwVgNkm+TKzOc43ePnxrX53BN79TJvzpcD4IcP2WL1EpPjMqeQeisQrWccooGQwZzuv1MPZlP04sf7hhD/KyP8cemvWK4iwo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=e/O7UYqD; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="e/O7UYqD" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-72ec58e45baso3526993a34.2 for ; Tue, 22 Apr 2025 15:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745359726; x=1745964526; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B2koMhN4hR5KSSnBsIlIFgfxzAiKDp/j1dG+oyh3qTA=; b=e/O7UYqDUkRefYvToUKT446kzKBO9A0WUHnPgj/zYSgLmQ4sT5e7hPEoYoXrCkGgBb cQRdFAwflvGs9qoj6LKPYQoEsmhJnaML7cMVJMHNmOnj/owTcHzyqL0az1NekvDSdD53 J1uT4r55gwwmOIeGpIfs6tw631RrlzkXdq9vaKtPFOxYYxcQABdMu67o94kKikEk3+Ny e3O/lOmvmi4h7DexBFJJPFQkeXQTVjTrO67wTkbm/Sl5p+NKUvGvYabITMukWhiGUB+6 6vwZuHkW5lDZvribfw34G5EE/IAMar0BILG9BOsIg+SsHcrzqSuCRVxoVMyzJkLFGY6w Izuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745359726; x=1745964526; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B2koMhN4hR5KSSnBsIlIFgfxzAiKDp/j1dG+oyh3qTA=; b=BKU+ac/c5BpVNSWaCRXVAJDmzZo6Mj4SVEt8cHkgt6n0Nk66wgsRsa6Fop9PU3k6K5 8d1Gc+OuYYvId/1d4OVRRny/bwm7C6bd6jK9g5ljA4oFzyJfOidF8ImC2CpLzFKg4qko zylaNMpp0iRW26pRhgxBsZwV0k4Jpcu+eOHot3UfR2auIawoBboz3tH6jaqqJw5asFZE V+YhPc/9NX40juJaYtbF+4N70npvFaMyU9kkwtrdZy3DeAzSv16+avCEVYfvb2qPh9WN +x4pp6u19+JNZ6lIVMn/NgGM8QjftfiyCxttled8Lx6MYg/rUGiRAT9luFFKoaOHSkyL AwpQ== X-Forwarded-Encrypted: i=1; AJvYcCVOL4ncoAjRr0lRpEGwuyrD9ZMqgoOCFiw+Gf/FEJsPdmWofbKWqbyh080Sn/VV3lM00OnBZaAquN2q9Kw=@vger.kernel.org X-Gm-Message-State: AOJu0YxC2UbhWVuCZmpZ5lTUrt/pvXpj2KADCaE7GgICkTVvR/KHUHfF kYikIjetg9eBue9lBFzK60v+NP0iHadvthMd/Llc4qHU+h7PMJA3EyS2LM5WFes= X-Gm-Gg: ASbGncuEER6/I/j33iEDaj/SAz8GWfE+tfHabbLwD1P0QJrhz+zBPtzn5ShozYBhPDJ uf/gZYdXPv4YYFHtIKfbpEwhFfGs3E45zuXI3/9mMqxovIqTZugLy75UdppAH0fVW7wpwVzfjDA AE6cZ6B/MU0SO5GE2tT+fCWD+0k0/08bgeLwyp+OHRfQ2Mb5ZjGG414t+IgLs0PVv+wUXEgVJj+ HGfHhXt04Xj6Q4DbU43AZIG0oFTV/vWyA+zdKikN0c7wx0gz4GrlS7jWsKVmkKmqSodeQp5qe8Y gHYkPnQGpC+TapXa/+iO6jo3sCQhvz2aPFFRjqBC1YX6aW4= X-Google-Smtp-Source: AGHT+IGFNJO8mza9AqNofho5qSYBgvNp+Om7GG3O2Gt9GY/65S+lLd+LZcwXnwmwWqXB1V0j4m9iVw== X-Received: by 2002:a05:6830:d89:b0:72b:f997:19c4 with SMTP id 46e09a7af769-7300633746bmr10719999a34.26.1745359726102; Tue, 22 Apr 2025 15:08:46 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:c8d1:e0ed:ce8b:96a3]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-730048848dfsm2265938a34.52.2025.04.22.15.08.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 15:08:45 -0700 (PDT) From: David Lechner Date: Tue, 22 Apr 2025 17:07:47 -0500 Subject: [PATCH v2 2/6] iio: adc: ad4695: use u16 for buffer elements Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-2-3fd36475c706@baylibre.com> References: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> In-Reply-To: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2149; i=dlechner@baylibre.com; h=from:subject:message-id; bh=NLK9rHWGxHgHc450e6JA3Kx5J3+N1Fpz21XOi57G4v0=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoCBNEF8NBH0RqMMLTfdFHjCNvkxbyizvXzbZOT 2HLvY2UrbKJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAgTRAAKCRDCzCAB/wGP wNwyB/9rs4fiIS3OMnMGfruRlEWMmXyGhafV1CQnLWK3hgPBA4IaLbeHMxHscn+SRfkt3I9izF8 Q8UWmSNooqT9zexYI/fpo7YhisDh9lWY91+Ru9+btIYsKwdZ7kI/4NpprLyDDqaKFr7AqtqjnAz fRhs7v0HUAi+Kq8sxshNAPdN5DcjIfOZ2szwGmrhNZl/b7x7Cse+4Y4TNXucPW2SPhYF7SKl1n/ xBRPIVI+pDMV6g++uaysZeJ3AwhAQ+ZLI1YUL9U+jp2I5sx01IUB+XuF8Kl6WEq/rXhiFJ2CN/c 7fjUlT4VnU7YwQrTrN7oOxOA/VPZfoMIoRPGRuzDsIUhOdJ5 X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Change the type of the buffer elements to u16 since we currently only support 16-bit word size. The code was originally written to also allow for 32-bit word size when oversampling is enabled, but so far, oversampling is only implemented when using SPI offload and therefore doesn't use this buffer. AD4695_MAX_CHANNEL_SIZE macro is dropped since it no longer adds any value. AD4695_MAX_CHANNELS + 2 is changed to AD4695_MAX_CHANNELS + 1 because previously we were overallocating. AD4695_MAX_CHANNELS is the number of of voltage channels and + 1 is for the temperature channel. Signed-off-by: David Lechner --- drivers/iio/adc/ad4695.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad4695.c b/drivers/iio/adc/ad4695.c index 68c6625db0d75f4cade7cb029e94191118dbcaa0..0c633d43e480d5404074e9fa35f= 1d330b448f0a2 100644 --- a/drivers/iio/adc/ad4695.c +++ b/drivers/iio/adc/ad4695.c @@ -106,8 +106,6 @@ =20 /* Max number of voltage input channels. */ #define AD4695_MAX_CHANNELS 16 -/* Max size of 1 raw sample in bytes. */ -#define AD4695_MAX_CHANNEL_SIZE 2 =20 enum ad4695_in_pair { AD4695_IN_PAIR_REFGND, @@ -162,8 +160,8 @@ struct ad4695_state { struct spi_transfer buf_read_xfer[AD4695_MAX_CHANNELS * 2 + 3]; struct spi_message buf_read_msg; /* Raw conversion data received. */ - u8 buf[ALIGN((AD4695_MAX_CHANNELS + 2) * AD4695_MAX_CHANNEL_SIZE, - sizeof(s64)) + sizeof(s64)] __aligned(IIO_DMA_MINALIGN); + u16 buf[ALIGN((AD4695_MAX_CHANNELS + 1) * sizeof(u16), + sizeof(s64)) + sizeof(s64)] __aligned(IIO_DMA_MINALIGN); u16 raw_data; /* Commands to send for single conversion. */ u16 cnv_cmd; @@ -660,9 +658,8 @@ static int ad4695_buffer_preenable(struct iio_dev *indi= o_dev) iio_for_each_active_channel(indio_dev, bit) { xfer =3D &st->buf_read_xfer[num_xfer]; xfer->bits_per_word =3D 16; - xfer->rx_buf =3D &st->buf[rx_buf_offset]; + xfer->rx_buf =3D &st->buf[rx_buf_offset++]; xfer->len =3D 2; - rx_buf_offset +=3D xfer->len; =20 if (bit =3D=3D temp_chan_bit) { temp_en =3D 1; --=20 2.43.0 From nobody Mon Feb 9 21:23:15 2026 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB69B2C109B for ; Tue, 22 Apr 2025 22:08:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359730; cv=none; b=EavTIfyQJf8bjKmgMuBPdX+LGdFBCrCvQx528xDEj02gf9fdvm0VTqkfq5E7BxRDsvH3SZqaxeJCni9zSHAKUhJ+56tQ6fXXo64IvJannmH0Omix+ohGOMIzrsG+h4iGU/oIVeynIhcwavRrbJP9smI44TqEBA4hTb9D9QSR2Yg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359730; c=relaxed/simple; bh=NrHDY/s0Q8dzJXv6IKAEg8Tm8DyekgOKnNJSWC3747I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BBS0ABBJlC5mrqmeuw4cvF+dwsEWhwPj/El5XRi0OwJFlcoCLoKi2AoIl32UN+Fgkfc94TkRUqqfPEk4VQvhUreQikkB/knUPDALleBzUKuT1yXrKOz25C7JG7y9SzHD78zky4L5wX5CzOT68aJotWyO4tbxOyDLuEEabosftVM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=SCUn4hoZ; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="SCUn4hoZ" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7301c227512so1906648a34.2 for ; Tue, 22 Apr 2025 15:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745359728; x=1745964528; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MyqEc2A1DVG0wlj0as96NOrenir8mMhhJ0tJFCy/DAk=; b=SCUn4hoZYb5wL0VdOlglKIksz30UAw6s2ASfYZ+TS1CAbxPCYrD1XV+++lHxbhPuAi uxzlr2dwy3JrorR4zMrBjhh44YL8LJ79Vi3OJ2+IopP24O+L3Q/lyhAwINkmscVf/zHf vQvIvd4PsFuQwJfAOdZgTEHX1vXGlhKhi7UegL9pIBIfkEbt3OuTCxGHzeCpwCG/R1dm cA1/K23e2UWCqAOohKQ7sP2nAYdXuMms6BJgdW/YZELkrTRQwvtGMmQ2yjV02/hMdUNf 1s4p2azTHryEqBNE/t/DD9seusdQuhx/+Zl/f9mGR4uMR0aEVmGSICSSJXrUkxBhUwmq uJ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745359728; x=1745964528; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MyqEc2A1DVG0wlj0as96NOrenir8mMhhJ0tJFCy/DAk=; b=HAgDYhtjovUdQSJ5PBkF+VyIXh/9/OQ+q6XFG/z9vSTkQgXpICoshtcrxgNbGrlYeK xAnfouDurMP2KLTNBnxPDX+jHiWxChxMva9mS1Jm/n96h2k5oU0IZY6ifZYTtu0oi854 E1j48p/Obad5oK+ofGUMs7wzykMYbvw+ZoBc1g7pqR88nFdgh0ZczJUoKSOSCGj1bs7x POO4yk2N7lpStpDDL1YZBkJ0xuBKKVF29F9et/S6QXSiLVUFUSdk2B8P3frAsvivJAyQ YM6Fk+C2tppj8CBm29A9hnCKtho7GyPpTQR3dcEafw/wcJarhGcRgZAbBIGe7C2OpPCk sMGA== X-Forwarded-Encrypted: i=1; AJvYcCW/BL8TKXROE0WxCYyhVnbPx9kamuf3kx0IFOKChQfFcrAkdnN0qYvk5mNZU9jOo9ufm8yRDj14sLyTiJw=@vger.kernel.org X-Gm-Message-State: AOJu0YzvixLY80LLvInQyejJCe402chfinJ+kjGUmQVFO7hUH+82tSgQ E4Lm96VmCL1ILqXxTNXAgR1vF09z0GN9TQ6T/0oz20srU+SFIJAg0qHsEltEozY= X-Gm-Gg: ASbGncujqduRaKta5uEpVACs2qHWRoTWaqb6eeXYcTzB9fFlCAXGCCpABxbUJe71QQG NvOhwCnLQfEIBeCKRmk0NSZomkgTSGAGdbsaClAltRNRyuYD749GDtd5jmQ5xJbrkJ87sqOBMBq hngqc47lK+l0FA5CCV6Ykpqa0GaozP+cdPunSBGl2eUEOWohbowNWNxJogY4kwKVnPtCnbaVna9 DLHHMoEGYgvgzITqRS3i0yaabFXb5sc8zPMQ1Xad2q5JC+RiAxnBlmemx37OalzVr8fZYeVKeGR pGuc9e2JQL/CBFC+yFTBS2pM1P8By4m0FCLDfkN19clhkuw= X-Google-Smtp-Source: AGHT+IEwuSSEoXlMTOYuepjnaQFx4CQHYKXQ+tl+tvq0S6my8j7uhxkWwjCkcKQdGsBjFpysXR3rjg== X-Received: by 2002:a05:6830:3693:b0:72b:9316:d596 with SMTP id 46e09a7af769-730061f15a7mr10959124a34.3.1745359727937; Tue, 22 Apr 2025 15:08:47 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:c8d1:e0ed:ce8b:96a3]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-730048848dfsm2265938a34.52.2025.04.22.15.08.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 15:08:46 -0700 (PDT) From: David Lechner Date: Tue, 22 Apr 2025 17:07:48 -0500 Subject: [PATCH v2 3/6] iio: adc: ad4695: use IIO_DECLARE_BUFFER_WITH_TS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-3-3fd36475c706@baylibre.com> References: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> In-Reply-To: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1015; i=dlechner@baylibre.com; h=from:subject:message-id; bh=NrHDY/s0Q8dzJXv6IKAEg8Tm8DyekgOKnNJSWC3747I=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoCBNL77G6l8A6/bF//fY7ZeTEg8wbGvyZFhMTD 6IADhTu2bqJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAgTSwAKCRDCzCAB/wGP wH2AB/976GCXJlNczBYNpuoqzA3QSldjyAoLBUjnc98rGro5CMS2LYb45sJ2n0Imtc0rqRArxHL w6jcfJEO4D9RR5471sgm56n3vimrEmNiNoJX5Go0VLqd24YLaCCIzi5LfAw+2bIQvGpqIs9OMz8 y/F14BplhIVtRU25Ncgcfmnwa+ZIo52uWrQFI88i3mSkHVKvLktfZz1VlUgWrcavbCNCf9Rt1jo f7U2Ca8mfA7CF2AEgiz9OCIc0XzDEH5SiKpp5T5tPCByU7j71MzT7C8nBRSubav6SCqRIWisv1O LCl2DRu4gvDq3NuXQandle0Z6LC8R0WdvHNaXPvlbITyoWz3 X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use IIO_DECLARE_BUFFER_WITH_TS to declare the buffer that gets used with iio_push_to_buffers_with_ts(). This makes the code a bit easier to read and understand. Signed-off-by: David Lechner --- drivers/iio/adc/ad4695.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad4695.c b/drivers/iio/adc/ad4695.c index 0c633d43e480d5404074e9fa35f1d330b448f0a2..992abf6c63b51dee222caf624e1= 72455fb9b9900 100644 --- a/drivers/iio/adc/ad4695.c +++ b/drivers/iio/adc/ad4695.c @@ -160,8 +160,7 @@ struct ad4695_state { struct spi_transfer buf_read_xfer[AD4695_MAX_CHANNELS * 2 + 3]; struct spi_message buf_read_msg; /* Raw conversion data received. */ - u16 buf[ALIGN((AD4695_MAX_CHANNELS + 1) * sizeof(u16), - sizeof(s64)) + sizeof(s64)] __aligned(IIO_DMA_MINALIGN); + IIO_DECLARE_DMA_BUFFER_WITH_TS(u16, buf, AD4695_MAX_CHANNELS + 1); u16 raw_data; /* Commands to send for single conversion. */ u16 cnv_cmd; --=20 2.43.0 From nobody Mon Feb 9 21:23:15 2026 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFA5A2C1E06 for ; Tue, 22 Apr 2025 22:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359731; cv=none; b=hyCI68dJQ5gPVtyWJEMi5B+khSupZ+58eenOSn91JXkU4PdkmMhSr/Okt65N7SN0jSq5skaj3wszYwCnartZtlU7M5E8kMeu03GyeozZaqUUgng2sHHOdTK8k0hgMZ782kOtDn5UuKxY8ZgoUrxcHmGBpzPfrfqXc7dgnsKRCLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359731; c=relaxed/simple; bh=KW72H2rhOsjzvWAD/gfaompbIwAhtAiVxmdxvtY6glI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h2kAyxwDIb1x09lQhFwORkIWPVUyqLT9qpsnZLcs+I3XvPavCM0K0+o3fs7ACQCSNrgUZdpNMK+rl2qfuIooKvzQ97eojEMyXKqEbYVSTi6ctme1UTpTBwUXeO95Gd/sn9QEhYPFg6iyrmF9f6NA+JkmQWwLJ6VtgaKozq5TQzc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=AjFjSY4P; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="AjFjSY4P" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-72c13802133so1540946a34.3 for ; Tue, 22 Apr 2025 15:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745359729; x=1745964529; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GV/JKg4cCCUHZO4DcegT8p+GY8kK4vHWejOXinE1p04=; b=AjFjSY4PGLnBV7NZOg+7xZYOcx6JpcZBie9jymRQ0BcnKD3imFNG+hiJQUvNgZ5PYA OkLSjJN7Sm4SnLt2YhRkOwPdsdFyQxaoY8F0NsvXVkyi8ZSc4SGuwuNV6qhMZsNGLrV3 cFELAM7+dLfSosdCkDfP7GB92yqjg2rMDkFWYQPGC3s4h2Iyv2vVWmVWVYi+8W+QQMA/ VPYU069bf/hiJtnUlfZCvbl8cuyOmHYFZCf+l6cede8xGQTP4ipdFUc2X3Hh2hpLr2F+ HZiGdh1rOd5PPM681siZd24MjgIYGGkUmZmNz2HbomLzM1cL6egd8jBpXV3kehcOz6Tf DgrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745359729; x=1745964529; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GV/JKg4cCCUHZO4DcegT8p+GY8kK4vHWejOXinE1p04=; b=hwxDoWLKll6/CJ8eVZykxvyZQkYC3EUUqyzcHZFuVYJZIiS8eV5ZkcLPW5zs9gToug f6KKu2OPGCGcOLSrqfqWl28EfZ9gn5G2s6N3umFvitDIZ5lbB1LHtoZD/PopI/uOC3w8 g9wTG+SddqBfnVvpObYUCI7VYOsCfoygKnb5p0GVqfopDb2hj4VzuGRxQIM23445HGk/ sGjpImg59vyVfgq55iTeDd6uOrsUsrdrllta138zRRBRWQXg/BdbuA1mxWwfyUvk99nz bgALKmslVsasO+MoQWDM26l9ybO3gkkMirOosPgUSXM1eoK8/fgbQjsnaG+qt5/ZMQTy oacA== X-Forwarded-Encrypted: i=1; AJvYcCU8nysg8chmZ1RkCOiySXZhPBp8uyR0/hTklXrV7mODcjeQaOMY0PGSxnYMbtRN3CoL5PAwsP3D9ujPtHc=@vger.kernel.org X-Gm-Message-State: AOJu0YwntGi9//SFLK0ViQTEp5EODt6Ox7xb1unJ+0RuPEizUzODxJQ7 qRvdLqQcE1y9ymjmFKLzyJcQ1UWUtNU7m/rHHGeGq+QMLu+p09yZk8bBk6toLBo= X-Gm-Gg: ASbGncugRqEdA4Zpvph1CoUGsLFF0/layJLur6bnDMZ/Pss1suSVlDhXwau9BPVrNQ4 kJRXp0rudUtKyDfbXsds2f3kkazzP0mCZ2PfW38KLfEJr9dd2Q8M2ID5Y2IhsyiVSwuBuvmNpNW GSioAKPAXyQegXVc7fXjsa3zc2NNr10bAHs+lTURgiYu8zibFlNc36Yz7XN/TJ5eKy/napaJyZU 1ZhWmZV3p2C0Sk+ARAfchkKiEB8zBiV55v4z4FjLTA+rDKZ90Lyeu2W5jshF9xozVn6duYZT6yb uzQHMnZwJSWjo2jO5xTIL817sfBAJuWrEujM+Xb/6J/3oco= X-Google-Smtp-Source: AGHT+IE7FZA50BnSF8oJmn4vSYvHiYeflUDA8NfUYzI4hEr4A9R06F1OXjWW8PDV78GuxROjjrL/nQ== X-Received: by 2002:a05:6830:6606:b0:72b:9de0:891 with SMTP id 46e09a7af769-73006222b11mr11700069a34.13.1745359728753; Tue, 22 Apr 2025 15:08:48 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:c8d1:e0ed:ce8b:96a3]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-730048848dfsm2265938a34.52.2025.04.22.15.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 15:08:48 -0700 (PDT) From: David Lechner Date: Tue, 22 Apr 2025 17:07:49 -0500 Subject: [PATCH v2 4/6] iio: adc: ad7380: use IIO_DECLARE_BUFFER_WITH_TS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-4-3fd36475c706@baylibre.com> References: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> In-Reply-To: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1123; i=dlechner@baylibre.com; h=from:subject:message-id; bh=KW72H2rhOsjzvWAD/gfaompbIwAhtAiVxmdxvtY6glI=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoCBNUYLKuoL2l8v5qYxFzyitlCg/RLQk56/h0w bWbsz80RzqJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAgTVAAKCRDCzCAB/wGP wOFTB/9YeOb2rt8UjFsVZfIlZEmMagVgNxYObu4fQAmL0GyrRub+pif2Ln/S81nDJAOw8uvfdYl JH4+CkLnoCMaiuj5bsrR2T3kVhyAuD0L2zqmYyZLMvrHBnkBUzn6c6+6MxfiqzDxMegf312U0UC I0QHm7GNU7Q1HqSxBojySMCGlzL9vQi1FtuZ3nw3q86r3fP05Tw9Ycgj6mG8tJKirKk5O5on141 YD5UgkTJuyRaXIY7lVs7VtewokCoo4aJv97l6WeDdyDiwU3iinkFo1hl26Ozjx2Z55qh85CZxAZ Z24lYaIyx1Gy8mL2VGG0INwPKSuHd25sZraxcL2r30GDs1X4 X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use IIO_DECLARE_BUFFER_WITH_TS to declare the buffer that gets used with iio_push_to_buffers_with_ts(). This makes the code a bit easier to read and understand. Signed-off-by: David Lechner --- As discussed in v1, this one stays u8 because it is used with both 16 and 32-bit word sizes. --- drivers/iio/adc/ad7380.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c index f93e6c67766aa89b18c1a7dec02ae8912f65261c..f89b195c644024151c14977fd43= e279a67439fb1 100644 --- a/drivers/iio/adc/ad7380.c +++ b/drivers/iio/adc/ad7380.c @@ -909,8 +909,8 @@ struct ad7380_state { * Make the buffer large enough for MAX_NUM_CHANNELS 32-bit samples and * one 64-bit aligned 64-bit timestamp. */ - u8 scan_data[ALIGN(MAX_NUM_CHANNELS * sizeof(u32), sizeof(s64)) - + sizeof(s64)] __aligned(IIO_DMA_MINALIGN); + IIO_DECLARE_BUFFER_WITH_TS(u8, scan_data, MAX_NUM_CHANNELS * sizeof(u32)) + __aligned(IIO_DMA_MINALIGN); /* buffers for reading/writing registers */ u16 tx; u16 rx; --=20 2.43.0 From nobody Mon Feb 9 21:23:15 2026 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91BC02C256D for ; Tue, 22 Apr 2025 22:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359732; cv=none; b=RhTqlE8C143BhbR+l3oMyq2gele9o/fb9LHgv7quU88M0s66z2Dp8VbZlNMXLASYsaPUl9zQR7K5BnotFyDattfqJQ7yR9H6prY+FX552mPBrW6dD5f3EynTUpJ2MboamPFnjFKYIZa2yxCtI8y0rM0JFrfjLJ/lTajaOo6WSGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359732; c=relaxed/simple; bh=COjNIZhPuNt4S3954Fn2UL7GTZFMh/VIXCBpDzwE6Cs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZQm3epvBLWwduiftZTBuTeKwyhGf2/vt3RPkb3LJ3f6H0obmivYS5v2/ppwVYPgyGnFHefb4xHi00795dhqv4vsWQ4bCS9az4XUlslubZsLnaHfuqhHWqQq6Lc/WEiPtMgBLftXfYSplP7w7duMP9Y3TgLwnb1ra0Nhy91CTDqM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ufPjDR1+; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ufPjDR1+" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7303d9d5edeso271004a34.1 for ; Tue, 22 Apr 2025 15:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745359729; x=1745964529; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OxcllqlAxGqsvqgkY1jmnRBvrU6YNyliNCeWX4COibA=; b=ufPjDR1+ob53cWSzxml8+PuOWXQTC1OdmUiarUrYbaz46nW/M56/aL5CNN8WuXFD8s NB1aRvARtZnrRWelW9CmYxKVtNvncVaJsF8KzyE2Sjm0vOWObBMOVnn7x9U4+u8rkSef KXiIlj9SC659NZh4NWS8R6QoMN2A4FV5JxzqpmRnZwpcjBGn5Qv28ggpBGi0WGz3IPbF PLi80uteuyN+JF3GYfEquYFphJbfV5Gai1ZedMNcWCe06bZeyFa54BUUfsrZQZk+oUwN L52wrsjqew7wfVX/LtnvslgIWsMf717lQPrF6HhZBmHtybD3Hbw7tj4Et6xqBuSC9SH2 Lk2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745359729; x=1745964529; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OxcllqlAxGqsvqgkY1jmnRBvrU6YNyliNCeWX4COibA=; b=fK22OE4dBGP7uJ0SCan/3kO2yGuhZ1SEE0mq3KGM248n0dURJFsx9zP6ikEaZI64bu ar33XK4m3unkRrvbVxTf7duHBL7KPOvB0Hv5nWSFygOuJUCbaT2aCBBkj1NLKMMnXhi3 haaoVHxmlpfeQ/OV3unJA67m+YoSgb/hKERKMoTrr8ZCX2X83rxw39KPs76uYiPln+RE q6FJbFak0osWAJpmHmsp82O3M0nJ3JAKV5K8N5euvVB4LjYokpIA6JoxE/+su0nnE+iq qwqAWaf9HfRZ+oKOKIhttQ15VoecBRsf/xB0yR3pUkGPaoh+8aTfevRTuoLM2NmZavRK Nkfg== X-Forwarded-Encrypted: i=1; AJvYcCXjqv0PRV3URo3fDMUvjBb46Kjb4aipAkGs15c3Oo0Y3ngK9UGIPYWGkBXyYNAw7csYNLMg5d0sFTpic1A=@vger.kernel.org X-Gm-Message-State: AOJu0YxesV1MIXOvrok6j7m32sbVp7qiaZzo0lGfEccPV9mjHbYmv1Q3 DHeuzdsNiu5LMpuA+IxzX+vSdbCoJ5D91lP8ZwXytFXib9msMeE/LrflyLZkvbU= X-Gm-Gg: ASbGnctCLH9h8IjrJHVZvNhZpugPxdhBay4WARlWmy2QA1DoD5sIMk89lgBOPo3cMAx k8hYZQJP88KDei2fxjTi+Ne0slqJzXVb2ryl4dM2B+v3PFnUsgqGzLecIF/KVuEacNdUzzJo1vh Y5cTCeezNTHdQAkfUobD9PaOT/C24MABLx8cNoxM9n6jtO8+YoevaZQrt6yQGCBE0YUOeRnJpOO mvoDctzt8O5efoROYQ6kzE2EB8i3zcLkqu9URj+pXQJSlroeBufPgYGk5lR5YgYhSp9uL46IP0g n3fgO0VRVYkNxV7+6YP1huKO47tMEObBZjkdN0395IyeIgA= X-Google-Smtp-Source: AGHT+IEHQ1xlklPGq2GZ44BS1JT8PZ0bjGyLk9c5dWYPUyG84Suj7pcBUnv1TneF5QAxVGuSMQf2Hg== X-Received: by 2002:a05:6830:264b:b0:72b:9993:118e with SMTP id 46e09a7af769-730062f8177mr11792393a34.22.1745359729568; Tue, 22 Apr 2025 15:08:49 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:c8d1:e0ed:ce8b:96a3]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-730048848dfsm2265938a34.52.2025.04.22.15.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 15:08:49 -0700 (PDT) From: David Lechner Date: Tue, 22 Apr 2025 17:07:50 -0500 Subject: [PATCH v2 5/6] iio: accel: sca3300: use IIO_DECLARE_BUFFER_WITH_TS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-5-3fd36475c706@baylibre.com> References: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> In-Reply-To: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2978; i=dlechner@baylibre.com; h=from:subject:message-id; bh=COjNIZhPuNt4S3954Fn2UL7GTZFMh/VIXCBpDzwE6Cs=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoCBNbRITiIrOuOBiNd6+w5vU0Q+H8NcTHgrQrU wLSWJRb19CJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAgTWwAKCRDCzCAB/wGP wBTnB/9W3nNh7c5a7hXZRRRgX27QxylG6YYb6ppn7Xw65rFs9kwK77c2XZJ0mvMb2GtkwdRJTi/ gl3MYrnC4UO8Fa0QYFI86FvSwrL/Csc0KUdtxnoLwen4TidL0q/LrDC5juRb6mA15H4PxMU/7tV exHDy6eWEe4Mcr0HAkaWXpjKFp+uPdkC4fo+O+Z8mgP/68Yh5bRqYXoI7J/w/apXcV288ZzZjqv Rn9UvvZhMoS3u5jPkZKIoGhf2P8H3oPLCsresOruS7yjQ90ZC+hgnfSN7PTSd8X2QS/ldSmhabx 4oGYoytUtH0tST5kio2IoJVgt8p121obveXOAH7573ErgxVp X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use IIO_DECLARE_BUFFER_WITH_TS to declare the buffer that gets used with iio_push_to_buffers_with_ts(). This makes the code a bit easier to read and understand. Signed-off-by: David Lechner --- This is an alternative to [1]. Also, this serves as a test to see if we can get a rule of thumb to decide how much is too much to put on the stack vs. needing to put the buffer in a static struct. SCA3300_SCAN_MAX is 7, so this add a bit over 64 bytes to the stack, make the stack now roughly double what it was before. [1]: https://lore.kernel.org/linux-iio/20250418-iio-prefer-aligned_s64-time= stamp-v1-1-4c6080710516@baylibre.com/ --- drivers/iio/accel/sca3300.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/iio/accel/sca3300.c b/drivers/iio/accel/sca3300.c index 1132bbaba75bcca525fac2f3e19f63546380fd4f..67416a406e2f43e4e4172104109= 04d44c93111d2 100644 --- a/drivers/iio/accel/sca3300.c +++ b/drivers/iio/accel/sca3300.c @@ -58,15 +58,6 @@ enum sca3300_scan_indexes { SCA3300_SCAN_MAX }; =20 -/* - * Buffer size max case: - * Three accel channels, two bytes per channel. - * Temperature channel, two bytes. - * Three incli channels, two bytes per channel. - * Timestamp channel, eight bytes. - */ -#define SCA3300_MAX_BUFFER_SIZE (ALIGN(sizeof(s16) * SCA3300_SCAN_MAX, siz= eof(s64)) + sizeof(s64)) - #define SCA3300_ACCEL_CHANNEL(index, reg, axis) { \ .type =3D IIO_ACCEL, \ .address =3D reg, \ @@ -193,9 +184,6 @@ struct sca3300_chip_info { * @spi: SPI device structure * @lock: Data buffer lock * @chip: Sensor chip specific information - * @buffer: Triggered buffer: - * -SCA3300: 4 channel 16-bit data + 64-bit timestamp - * -SCL3300: 7 channel 16-bit data + 64-bit timestamp * @txbuf: Transmit buffer * @rxbuf: Receive buffer */ @@ -203,7 +191,6 @@ struct sca3300_data { struct spi_device *spi; struct mutex lock; const struct sca3300_chip_info *chip; - u8 buffer[SCA3300_MAX_BUFFER_SIZE] __aligned(sizeof(s64)); u8 txbuf[4] __aligned(IIO_DMA_MINALIGN); u8 rxbuf[4]; }; @@ -492,7 +479,7 @@ static irqreturn_t sca3300_trigger_handler(int irq, voi= d *p) struct iio_dev *indio_dev =3D pf->indio_dev; struct sca3300_data *data =3D iio_priv(indio_dev); int bit, ret, val, i =3D 0; - s16 *channels =3D (s16 *)data->buffer; + IIO_DECLARE_BUFFER_WITH_TS(s16, channels, SCA3300_SCAN_MAX); =20 iio_for_each_active_channel(indio_dev, bit) { ret =3D sca3300_read_reg(data, indio_dev->channels[bit].address, &val); @@ -505,8 +492,7 @@ static irqreturn_t sca3300_trigger_handler(int irq, voi= d *p) channels[i++] =3D val; } =20 - iio_push_to_buffers_with_ts(indio_dev, data->buffer, - sizeof(data->buffer), + iio_push_to_buffers_with_ts(indio_dev, channels, sizeof(channels), iio_get_time_ns(indio_dev)); out: iio_trigger_notify_done(indio_dev->trig); --=20 2.43.0 From nobody Mon Feb 9 21:23:15 2026 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6970B2C2ADE for ; Tue, 22 Apr 2025 22:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359733; cv=none; b=soDtfYKKkiRxLjATYVm5H8YhAyUO51VKRFdWFVaFohqR/rJaiq+IaEw07oLuEss9YUkLcUxkXTZmQoWM87XFsq7oTU2RDfOZjFM8H3aL+PP23Yol3Jedv9uK9XB5S9d4ERTUGnE1X0b3XYxN+4VjQUBWya2gM149xipmE7H0HaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745359733; c=relaxed/simple; bh=bNzghGrt115+ZKNUZFU+xQJSBPkqwVs5iV+9xGBsm0g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=F0KxyNA5NqnepBOOf0JufLt1iDacd89XbhgCTwpujyk4/mxGKpf+dFpfnRjdgL3MKdVgmYnvCoVxzXdntWgvAYpo16vVRne4OKz4ZmL4EHYVq9ZiRSlrA8Auc9M4xLw5NXc92eAbhKeBj9PRl1qI8W+UEBTLfMoh2Qy7vFFhufY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=wwP0vpVX; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="wwP0vpVX" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-72c09f8369cso1821209a34.3 for ; Tue, 22 Apr 2025 15:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1745359730; x=1745964530; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OcAjMtDsEwOO8O58Cs5cDx4aKARQOhUbmH4snH5r6Ms=; b=wwP0vpVXveZpmTzOqMCFvr2+JpZPkCrlyyBPngKI7UH1rQ3ONsXMczrsodi5+qk/oN YgL8aDq27iBcdk5Vm6va03r0k1viRip3K7PNbySL8DwVNhAj7nIFLvx6eHWRTCN5/dse K5QFJMRNv/P64JpCI3Z04l4DTy5WnU7wH8afVcPJX5pF3Wu1uCXGjuE12cP+mnsyFyMZ oR7LXtggDdU7ns7ACc2xOPLODQBhWMxUiYVnLbxHnHaSEMm4EkmqoczwKxdLi4c1tHyL bBdJvo6kR1xKPnsJb400nUD/5UeLRPOJn1FZBdxHcndiNJHiAIoT+5J2ql1uuZndc/Ld S34A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745359730; x=1745964530; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OcAjMtDsEwOO8O58Cs5cDx4aKARQOhUbmH4snH5r6Ms=; b=XHLUQVR74esTXWgg4NtbLLjISAdq7aVxOXbvDMi+xbdMOS5RYYz/bdXE3SJbpeukt6 xiRZabu/mKX/Xv7BdKiATVGfTw/6qxi5T8xty0JBaTZpY6OiR/vC6ZNfDOMFm9k+EERZ xQJFrwiY9+fZOkSpoSBRYyVI/bizB8c89JUXYZrELOfMbU5/mlOvEUcY4Lc2GIGhgIKl wgsru9qDG0wP8jAjino1brVhrf/4EpeDYSDbHB9l5SL8E4UTvZ9h5x8zx6PLkAm8Yu8y w33VySqqI48E90H5fmtqOi35nh21qUd71GYx8OgeCCGRL5uoOm9tBcTD0P6MrnURfwP8 68Ug== X-Forwarded-Encrypted: i=1; AJvYcCUwDPp9mtXrUCqpLLGyZ8EmL+POnqgAO2vFyqE8sYEqWSXk/AvUqWArVOVohWeN+JidGbuBnFJu2E4xemQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzk1N+V5P7mzimos7gcISBfDJ3PREkgZEXk+gMpFFrXAy8nSe8/ YPggWla7hmJ2mqThem4ONNAbpWbZyaVnT2MAFOTaofnotmIaBkZzo0cT6WTkzaQ= X-Gm-Gg: ASbGncsJg7J33j7uDjxMaLemNa6CgxcifGA+X4MXuzrRPrLQgBx/qaI6xuvskOSNFNI DTcTgcQ2abn+if3H9cs6X+zQTt7XNpVvtEfz+0BMQkaEXl4DjUUR4OLMWL1eU2BPcxR+Mt/zY7Y 2tSVFn8lRnfq4C+ckKijHZjb1obLxdPSSWqLMEvu04/pBCM9U0BcBP+j8dhh2Ly/ENqLRRZT/Jp rq58KSUS1bBflJfGo+omObKPZTZwDTO0q5S3s9UweVzUeFpsD5pibpXxU88X+rI2g2gUBx85Bs6 USIOKG+taxDgbvttMG7iVYLe9rzo2AK+60es0jjLHpmcoE4= X-Google-Smtp-Source: AGHT+IHzzwKW3y0fInhdjWSpsuJ5JmWctR16v6GWhHHGSelSclI2sxPnML9dTnb8TnnyDMSSFW1wDQ== X-Received: by 2002:a05:6830:61cb:b0:72a:1dfc:c981 with SMTP id 46e09a7af769-730063304edmr11661860a34.25.1745359730406; Tue, 22 Apr 2025 15:08:50 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:c8d1:e0ed:ce8b:96a3]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-730048848dfsm2265938a34.52.2025.04.22.15.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 15:08:50 -0700 (PDT) From: David Lechner Date: Tue, 22 Apr 2025 17:07:51 -0500 Subject: [PATCH v2 6/6] iio: adc: at91-sama5d2: use IIO_DECLARE_BUFFER_WITH_TS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-6-3fd36475c706@baylibre.com> References: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> In-Reply-To: <20250422-iio-introduce-iio_declare_buffer_with_ts-v2-0-3fd36475c706@baylibre.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1674; i=dlechner@baylibre.com; h=from:subject:message-id; bh=bNzghGrt115+ZKNUZFU+xQJSBPkqwVs5iV+9xGBsm0g=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoCBNjAzzt1sRYLcJPXzefhzYxHcbR4XNJFDKvZ JN6D57NVvyJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaAgTYwAKCRDCzCAB/wGP wFKfB/45NebbapbIP3t4eBe7IDDKz2IX0X7vuL1EOiu0sCj5YLzAqoCos3aGbC3nAYBmnTV/9hu cGfDIiEMSXlDgH7ASvPN7SFQ/ANjGO2xc896/FcMxGq/kyx3dOp33a9ienXD+mFjne9N1/PXWIg oO+XPo6f+HtvNvjb/uyALdwB822D7BpmRJ2i765kt5mysIPkY5yd1SBIXUu4sT9gLI9lMfV+oIo MqxuocA4UYA0VEMFVRssN3TAOhlHC5i+k06k7VuE04rpLH+kqyuHDcLJvBuDJnsLBOsic2D2h+q 5Kbts705K+v72L/z4sznTI1YwjSMGRe0UILK+jAPLEOzrS4u X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use IIO_DECLARE_BUFFER_WITH_TS to declare the buffer that gets used with iio_push_to_buffers_with_ts(). This makes the code a bit easier to read and understand. Signed-off-by: David Lechner --- This is an alternative to [1]. [1]: https://lore.kernel.org/linux-iio/20250418-iio-prefer-aligned_s64-time= stamp-v1-2-4c6080710516@baylibre.com/ --- drivers/iio/adc/at91-sama5d2_adc.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama= 5d2_adc.c index 414610afcb2c4128a63cf76767803c32cb01ac5e..4ebaeb41aa4568e2461506471af= 0540af9d1a041 100644 --- a/drivers/iio/adc/at91-sama5d2_adc.c +++ b/drivers/iio/adc/at91-sama5d2_adc.c @@ -586,15 +586,6 @@ struct at91_adc_temp { u16 saved_oversampling; }; =20 -/* - * Buffer size requirements: - * No channels * bytes_per_channel(2) + timestamp bytes (8) - * Divided by 2 because we need half words. - * We assume 32 channels for now, has to be increased if needed. - * Nobody minds a buffer being too big. - */ -#define AT91_BUFFER_MAX_HWORDS ((32 * 2 + 8) / 2) - struct at91_adc_state { void __iomem *base; int irq; @@ -616,8 +607,8 @@ struct at91_adc_state { struct at91_adc_temp temp_st; struct iio_dev *indio_dev; struct device *dev; - /* Ensure naturally aligned timestamp */ - u16 buffer[AT91_BUFFER_MAX_HWORDS] __aligned(8); + /* We assume 32 channels for now, has to be increased if needed.*/ + IIO_DECLARE_BUFFER_WITH_TS(u16, buffer, 32); /* * lock to prevent concurrent 'single conversion' requests through * sysfs. --=20 2.43.0