From nobody Sun Feb 8 21:49:09 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6008E261388 for ; Mon, 21 Apr 2025 10:13:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230390; cv=none; b=Brpn1/iYT8kKoikDzYF1apVAxfqDnXEg2VReom81vTEeSZFq2wz8pL8atttwW8YLkXbsE2ncLp+Cc030IzIGF24+OSdNf4kLGzLTwWVXRRxXYWNiGqVMK13UbmXQOO6qbAzqUxdvZtxXqkY2+lWK4XY6splra9JctHmpQt4cLXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230390; c=relaxed/simple; bh=/aJIi6jFMkCKzafBM/nNKdpS5PB1CaOQsX/+a6oYEE8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XuyvTIY5zcLZbsl6tS1cALY6UHFvZpus8aTs/aQA9VJxZBqCR4QuM0iDUYNDmvW6lCGvdhPHk/QexChkYs0qe2XIvLUdD2iC0qwayjo4y18ouB0pR5P1F6QM9/a6I9uJdO8tioiiM8v0SI7Df4oEVVOr2N0NKRyzWwxnu1h6DSg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nrNsPetc; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nrNsPetc" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-223fd89d036so46038015ad.1 for ; Mon, 21 Apr 2025 03:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1745230389; x=1745835189; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5gUKhgL8xbYN2S+4GVogDZp2nilBSVWla8H/MwRjdFI=; b=nrNsPetc1P6pjHcKQE6jVWfeBbcIqd2YzbVeDnQeRiGGcXGGyA6hazixZY/aMsSHNr U7x1TwQN4c10LhBHIKBE4R4G5JLOMatYkOO8OVxxBjMBqGFWi3s5ephs9/IfU3pZCCAn hrzmRlYIlXVK8xFRILuMDhgsBAW7j0FFsagGQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745230389; x=1745835189; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5gUKhgL8xbYN2S+4GVogDZp2nilBSVWla8H/MwRjdFI=; b=nZAhZ3v9lHMxteUG/DvUSKdqPq/MoXqT6Wi34qtGFUDhAJEhMMB/23p+rtbWXtWDo8 5RZ31uacc7WQe1aSgMrU2b6eJRKUTkC08+jLP50XO6y8o62pSTP6tsbM4xhRwoCUvFC5 XFlNkFr3v0F8RqibqGEUuS+KybpHuBtLvl352dy4+VR71aEMS7YSwIJD1DSOkoPHJ7Qa rCjLABE44elqkhn9lJX6yW2PU4yBGYqYv+D4fyhB/94V5jjN3m6LWaMlptMYGee9b0EE gXWOqlfAiQ8i5QpjHk+IlLp5+tJ6rFQeZSQupp81HHEVDG2UDZkq0jbyGwXy6yfpMODB GyYA== X-Forwarded-Encrypted: i=1; AJvYcCWszNEZ8xx5exEqPw4HJqn85Nr0DPSNqOfdRnhqa/YVuyAKH0t/mc77qt5CJB49y73yO3bc1HftEzDMCJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YzjU9TQwV5X7IQ2UE4l003weto+GnbGhXJp3kvjYzLCUb1NUH3j nojbrIZdx6zsCISA6/U86ndOgaj5jClCUInjAj9Oe2VW1JhoAWhlP9fQ1pbClw== X-Gm-Gg: ASbGncszw04sBrvz3Jj6enrQ/3R5omxl4qXr5VpJjqRUBy68xSU3inz8Z5M6iwZv+1d oyuxIQDlI8UDGRm9MvyfxOdFMey2ZT1ObbliHS1z2nLbRTfZEf2n3CQIHcyCTdlXAnoc/Bnp5Ah Ekvt1S6AiVy0e2ACw7coC7Xn2sDknYKAQ7yseA+cD3yevxQ2klDpD5eQw2A/glk7GTHbxIGOkCg wGKV/8iBuOx9hVTPV0ck6emg2O9oNS9pq+2zmv1rMDy/UKLKgTNFcsBb7zSpzt2XoGN9JcI/Em5 bWsasnN0waNRBXMPAebwsBYhmwMeft3XvqO5c7K1iYLi1V+m/RxfwlYbFPc= X-Google-Smtp-Source: AGHT+IEkr0EFkCj5J6CNLSHPTa49yKoitttF/R1BiDswDnBiG+hklRUae4FmkHmy3Ilt86P50nrk5g== X-Received: by 2002:a17:902:f78c:b0:215:9bc2:42ec with SMTP id d9443c01a7336-22c5361fcedmr148300365ad.47.1745230388644; Mon, 21 Apr 2025 03:13:08 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:7633:f42a:d31d:3f9c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22d78db8b04sm38985205ad.238.2025.04.21.03.13.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 03:13:08 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, linux-input@vger.kernel.org, Douglas Anderson Subject: [PATCH v2 1/8] dt-bindings: HID: i2c-hid: elan: Introduce Elan eKTH8D18 Date: Mon, 21 Apr 2025 18:12:39 +0800 Message-ID: <20250421101248.426929-2-wenst@chromium.org> X-Mailer: git-send-email 2.49.0.805.g082f7c87e0-goog In-Reply-To: <20250421101248.426929-1-wenst@chromium.org> References: <20250421101248.426929-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Elan eKTH8D18 touchscreen controller is an I2C HID device with a longer boot-up time. Power sequence timing wise it is compatible with the eKTH6A12NAY, with a power-on delay of at least 5ms, 20ms out-of-reset for I2C ack response, and 150ms out-of-reset for I2C HID enumeration, both shorter than what the eKTH6A12NAY requires. Enumeration and subsequent operation follows the I2C HID standard. Add a compatible string for it with the ekth6a12nay one as a fallback. No enum was used as it is rare to actually add new entries. These chips are commonly completely backward compatible, and unless the power sequencing delays change, there is no real effort being made to keep track of new parts, which come out constantly. Also drop the constraints on the I2C address since it's not really part of the binding. Signed-off-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Douglas Anderson Reviewed-by: Rob Herring (Arm) --- Changes since v1: - Reworded commit message - Dropped the enum for the new compatible string entry - Dropped constraint on I2C address completely --- .../devicetree/bindings/input/elan,ekth6915.yaml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/D= ocumentation/devicetree/bindings/input/elan,ekth6915.yaml index cb3e1801b0d3..0840e4ab28b7 100644 --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml @@ -4,14 +4,14 @@ $id: http://devicetree.org/schemas/input/elan,ekth6915.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# =20 -title: Elan eKTH6915 touchscreen controller +title: Elan I2C-HID touchscreen controllers =20 maintainers: - Douglas Anderson =20 description: - Supports the Elan eKTH6915 touchscreen controller. - This touchscreen controller uses the i2c-hid protocol with a reset GPIO. + Supports the Elan eKTH6915 and other I2C-HID touchscreen controllers. + These touchscreen controller use the i2c-hid protocol with a reset GPIO. =20 allOf: - $ref: /schemas/input/touchscreen/touchscreen.yaml# @@ -23,12 +23,14 @@ properties: - enum: - elan,ekth5015m - const: elan,ekth6915 + - items: + - const: elan,ekth8d18 + - const: elan,ekth6a12nay - enum: - elan,ekth6915 - elan,ekth6a12nay =20 - reg: - const: 0x10 + reg: true =20 interrupts: maxItems: 1 --=20 2.49.0.805.g082f7c87e0-goog From nobody Sun Feb 8 21:49:09 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AB491362 for ; Mon, 21 Apr 2025 10:13:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230394; cv=none; b=Ympoif72b0lvhg6AWs2tLOXTIB5yAINKTFDXvnMc3R9gnUZ5+lN8ElK6lKm7rj0TBMz9vQd3oHqZu0arB2ojFD9xvSm7ABsd6FmiTvofurOmcyVrAMwjwhU6SShLaFbLjVedO+8IgGxk+FE02cJzVH+g4Uie4Smko2494K0+o6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230394; c=relaxed/simple; bh=FR04IaMx5M3reYvC9Ul0vGkqy5dkFbswq922BLXpjDc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YmPY9zF28x+IGbW7VT06ahiyOHh9dSdlIoI5BjDQRbu/uSXst0t3Kfta+rKPDObhsjZt6L2st3gPQqI38GAg1XYDMRuRvOkcIqZayW/bYILiworqy2rtv/tEVnAbLCSeh3BUz4AIblsEPUn1jlfbn5zVsXrEewkcqkqg35Ui+lA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=EI7lMEoC; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="EI7lMEoC" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-224341bbc1dso34970185ad.3 for ; Mon, 21 Apr 2025 03:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1745230392; x=1745835192; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sTVdf/HTR/Pq03sjtrVZQf/ywmAoP72Oaa16LKk/YT0=; b=EI7lMEoC4eos4V7Mtya/yyQHK8GjlXRZkOM9WyEVG1h2dOGy9uNgh/SVB1j3fTtP0N iRm4W1dQfuhufPcv7QpNFmJBAyS5dAa6aALvoW5EKWgD3gfA9Rhjprgw7G8ecUSnsrRX AverPwptbkKKCMF5Yo9Mr5JR03gIlGw/PdtUo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745230392; x=1745835192; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sTVdf/HTR/Pq03sjtrVZQf/ywmAoP72Oaa16LKk/YT0=; b=l9bPDRV7aGVDl2kak/AfubU0Efu/NSltv3C7GQMkc2j5oLKlojk0TtY4K+NvRsX1i0 uafB5hpPqu/pq6rP1gi57pwQou1xjPJb7Gk3V+nFmB/NWYkbWPeQJcws9eR/xQm3NmRx pFu9TT25rZYVYdmNRH/2L5tacqYbp2Xz3JKtEwCuIavx2GL3l/9g8JcKLKpFbakDMkxY /zGhBrzhm/PMmnVxSWdmlrPggPo2iLq2DsXHBPepQWwmf5FiY6DkDjqPYAiYf81C1xOl AUK9Xxc2cXM/As4QcYXJIZBLlLpt+Ryup13gKRqiIhIn13lNNmqBDksW2Ua562TB6Kiu y7iA== X-Forwarded-Encrypted: i=1; AJvYcCXVrAD4f0aCzPNRqIHIQR30+pprfiquQmsIrmV9hDHgYxuqBmS4VjnzxOb9rsaqeAdob8fC9CRrDAg4+9U=@vger.kernel.org X-Gm-Message-State: AOJu0YySKXKByd1YP1Zq9q+Yslo5WeVi9fQmzWbdu9rtvTigWcYP4lzT VGlC7XzGFM0F3LgcAPlOTQsIRlnGKBBAxjBvH5PKi+dCfONK2Ba0zH2D9fEg7Q== X-Gm-Gg: ASbGncuXVcEyYqaZvWID8ICUNcpwIG1T1ct+3SCnC3nWqrGTKiXllEaTtl/aO1xfZLZ EDhNvDDlQsmHAKuRx3GBAKBUDI7uwEHGuY3fVUg1o8ZO7L8w/0AOU6KxFgW0Mbb6Q0YIErbpKFU Ga61W1E4OGWdTW6gwDK8svLhqDhHgyWmxczegHhWNooTnis/4seLRdpWmQvjwIQmV9mh7L9N0z+ 5QjhvAeQmB7p2Udx3fH8e3gKWMuBPsnvTU+7cM2DycY32eMfy7TUZw9864ZMMKeLXnimINV+ohg HKedJ13mGs/jI12UsUORl1m7WlPFxuizBmlKmqKpVaYx34QD82ryUvGok1Q= X-Google-Smtp-Source: AGHT+IEzP8P3BuI4W7WctpJECwx8nzR8w2GBK/ppnOU1J4/hN4o5Y1Q6ZPLjik3RIkoMMrSDGxWajA== X-Received: by 2002:a17:903:19eb:b0:223:5e56:a1ce with SMTP id d9443c01a7336-22c536063e3mr184062165ad.32.1745230391767; Mon, 21 Apr 2025 03:13:11 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:7633:f42a:d31d:3f9c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22d78db8b04sm38985205ad.238.2025.04.21.03.13.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 03:13:11 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, linux-input@vger.kernel.org, Douglas Anderson Subject: [PATCH v2 2/8] dt-bindings: arm: mediatek: Merge MT8186 Voltorb entries Date: Mon, 21 Apr 2025 18:12:40 +0800 Message-ID: <20250421101248.426929-3-wenst@chromium.org> X-Mailer: git-send-email 2.49.0.805.g082f7c87e0-goog In-Reply-To: <20250421101248.426929-1-wenst@chromium.org> References: <20250421101248.426929-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are only two different SKUs of Voltorb, and the only difference between them is whether a touchscreen is present or not. This can be detected by a simple I2C transfer to the address, instead of having separate compatible strings and device trees. Drop the SKU-specific compatible strings and just keep the generic "google,voltorb" one. Signed-off-by: Chen-Yu Tsai Acked-by: Rob Herring (Arm) Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Benson Leung --- Changes since v1: - Added Rob's ack --- Documentation/devicetree/bindings/arm/mediatek.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Document= ation/devicetree/bindings/arm/mediatek.yaml index 108ae5e0185d..49ddc504c160 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -339,9 +339,6 @@ properties: - const: mediatek,mt8186 - description: Google Voltorb (Acer Chromebook 311 C723/C732T) items: - - enum: - - google,voltorb-sku589824 - - google,voltorb-sku589825 - const: google,voltorb - const: mediatek,mt8186 - items: --=20 2.49.0.805.g082f7c87e0-goog From nobody Sun Feb 8 21:49:09 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 787FF2627E9 for ; Mon, 21 Apr 2025 10:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230397; cv=none; b=o4ULzH+9XtoZFyj6mjfU93OMHQTxD7wKVGKy6u4qY+OXfACVnZL846JYrRMz18ZymikqJqIK7p2fFibp7vMoQu6uNV2dvjEeufoz8AXRAXaehEmWiq6CAQD+WZFlaHM3NrUJTq2ChHA50vpVUx/ufYPdjMWBCJkjdm1zsESV2mU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230397; c=relaxed/simple; bh=34zm+yxWUtR/Lbc2SeD4Q2rTlj6zy2/A2wbsfBG4WVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qdh98ezaikMRyyvlkmsPdF28hFsKC5EHqOhgn5EtB8FLrXy0ApbQVZpjhGGxTwmhIQ8vO7YVxIL7Q2j9O4d55z+2edtGQJDQO1n0OuLF3xmhpQOjJAHO4kWRlP5VxB+pvTe20PYHfNE5WhVND4IepQUmg82PPMcjBcN+2zkb2qI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=P7wHBAdW; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="P7wHBAdW" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-223fd89d036so46038875ad.1 for ; Mon, 21 Apr 2025 03:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1745230395; x=1745835195; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4d0RlzVUiZ/GjheYPmzU3+xaXB4NRkzjoXsemgEHtik=; b=P7wHBAdWO1tsY4cly0bqVuhDJ36LA1IrNEPqKwfouHhpFonk1iv4xJEdC+d5gQ3bp7 5oI+pzdpdXwrgLJsgKFRATSxVbAbBEjjZi9r0B6YasUvVAfNliKGGzwQHkzg7HpqUm8b ilLjtMdWwFEi3LjjGf49JbAjU4pt3XhdjW+l8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745230395; x=1745835195; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4d0RlzVUiZ/GjheYPmzU3+xaXB4NRkzjoXsemgEHtik=; b=SkVjaabbvgW1qWQl30C/qB5ZvLgG+OxW4WfdXspsQ8INpJwOG+COMaCyIkqtCY3QCl wpReDA1lbA1nuXdQJxeyXW7ypLlKBMoZ6HK/lEr3+ruSX5RB3WwwAV9CcyPGncCSyneV Ms3qtEGywf6ciV1XqFq3Vg+Vzq3C1X3cOo/qV8znRpNjQUlTC2KcDNaJJ2u0WZzLqu5F 5ok6azap0LXi+CH93n42UxjoPMjKnNUpEC0yDc8Hy5Z+heOQgNkAueW4s8uoLPSDJQiI dayOdBHaDOpbvP+JceaSzMC/GMgrT/ni3+U4Y09BBGdRm9WlktJeotZcEZH82WEMcWBx JfKA== X-Forwarded-Encrypted: i=1; AJvYcCXH4SL69N6nz1NGPS2bw2QRw+LRf/qlzqV+Fivj3TWLFgIkMUj31EKkmGefiEg1bibaDabGuRgiEGb6lBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzRQCXThmvQfKPylP86B6irRksXe6ChguCHrNqbV/mxmogjrzdt e2CWv5soI0oblqGK+vfjt6II8o9P2V8GSqS5k5gicW1cbZwuIkajyXHSAD553A== X-Gm-Gg: ASbGncuFbRfRkmQ8QFpR71trAZHIqe7doYVw8IYSJTIy5tyEfj7+INHgIiwIiQmiil+ dyN0vdvcAXrbSAb3B9r/D03XWrCIqaNrLh8aAsXYQxTwLyCD8UmM3MjKWNrtgYBUvzPq80ngstN nn4Yc4r5eQCterj7VOmbY+oOiE6OibsxdKiT1T5u8vH5r7vTzZYrgg+8d/O2bC7buLCJfQdFo8X 1ShhsSchv+YhCLfTZgxEIoIM0ZcxMvRr++rO5HzAkdTD5jIOet7gA9d7FepVHWS+RlgIBbqwDy0 g8LfD+AUxbJiyxq9R6EnQ558c/4VkSSHpAozPH7e8JsO9eFW/Kr4+iNFFSM= X-Google-Smtp-Source: AGHT+IF+AnZFOOLJPlbiAxkDb/YuGPI7JP89xIJch2irCDOD6BFYAkiFyfLLQWgKCePZd7wiHYd+Wg== X-Received: by 2002:a17:903:3c6b:b0:227:eb61:34b8 with SMTP id d9443c01a7336-22c535a7eecmr173618945ad.25.1745230394801; Mon, 21 Apr 2025 03:13:14 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:7633:f42a:d31d:3f9c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22d78db8b04sm38985205ad.238.2025.04.21.03.13.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 03:13:14 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, linux-input@vger.kernel.org, Douglas Anderson Subject: [PATCH v2 3/8] dt-bindings: arm: mediatek: Add MT8186 Squirtle Chromebooks Date: Mon, 21 Apr 2025 18:12:41 +0800 Message-ID: <20250421101248.426929-4-wenst@chromium.org> X-Mailer: git-send-email 2.49.0.805.g082f7c87e0-goog In-Reply-To: <20250421101248.426929-1-wenst@chromium.org> References: <20250421101248.426929-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add an entry for the MT8186 based Squirtle Chromebooks, also known as the Acer Chromebook Spin 311 (R724T). The device is a 2-in-1 convertible. Signed-off-by: Chen-Yu Tsai Acked-by: Rob Herring (Arm) Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Benson Leung --- Changes since v1: - Added Rob's ack --- Documentation/devicetree/bindings/arm/mediatek.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Document= ation/devicetree/bindings/arm/mediatek.yaml index 49ddc504c160..f0b4ccd81c4d 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -291,6 +291,10 @@ properties: - const: google,steelix-sku196608 - const: google,steelix - const: mediatek,mt8186 + - description: Google Squirtle (Acer Chromebook Spin 311 (R724T) + items: + - const: google,squirtle + - const: mediatek,mt8186 - description: Google Starmie (ASUS Chromebook Enterprise CM30 (CM30= 01)) items: - const: google,starmie-sku0 --=20 2.49.0.805.g082f7c87e0-goog From nobody Sun Feb 8 21:49:09 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C71BF263892 for ; Mon, 21 Apr 2025 10:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230401; cv=none; b=DOy77r+9JXa0Q8J/p/dusRedhBTtrePMHUMF8tJYJE2sHljvUdXP/TlKySOrcz5m3/qMhQIXX1tZFPj21jgbXZgIe9zNGEi5LjpOCBbWIKUDqwbz25/KexhIooxblVqcojjuhIIPXoayRfhUJaq+jTaD81sBfl2ydaqqp6+mUQE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230401; c=relaxed/simple; bh=5XUtMoDRCkTRdh5mvmKCDd+dNP+k6uqdEMLM9UzaAPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WEzf9SmkpBsYV4ncCKkOpdgpGZNBkc8kvVfw3V/p+pu5+zOLwvsLJPJykX3gX57LVFikAHpY7I0e24RFPRFlldUS+LTAjE3frt0Xk+lznnzTCAXw2Xr1O+OYoB0qAVllAdO16OXqfvSM/jsyTUBDwZyCci3UO9zYya2d3TtvnC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=K2sbUXtb; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="K2sbUXtb" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-223f4c06e9fso32316535ad.1 for ; Mon, 21 Apr 2025 03:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1745230398; x=1745835198; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QpytMjpN9gDZuQ/F9dqqmXXp6n+OWf7Vs6AgeBOpoF8=; b=K2sbUXtbUh1cRDl8NZDmLiX91RIqGJNb+Bq0jP7fQ3XlCd2dz6GAD3K8SYRI7HnCAI qyIGyQAN/diBee4zge3BCcrEP4dGKX1lEDMfK6o45WsHdVC4pSQHumL0HQbM36JI9Q7f Bs0jK2ycNfd3MmEgVJu47QhZJorFX61S66Qvw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745230398; x=1745835198; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QpytMjpN9gDZuQ/F9dqqmXXp6n+OWf7Vs6AgeBOpoF8=; b=PlM+n2h0BqQhllyfvbj1o3SFyDvvGWuvYaPKue46q9mTVyGIfCV35LqbVT2R0QXvi4 6NH/xparxs92YPi2idiWPL469YRPvUH/4hQDqqvk3/XA4BoG9yZCtLBwAQFXj2CH5uPv /ulHPK2aAu1jR9BDp2f5JZzaTCGnjkaq6htmNZ43qjBdjQKHZBFo3/OAeeMJBU0Xd6E6 YVP75ZIq5Cm09X4Ay+7v1pJsf3gqAMm2ohiCuS0tdCGoBIHi8SYj19/upw9i9icQvhRT RunIym5GLGHEuRMPC0Lwk4piazobaBRhphWLq5kQLe8ZfTup9WsHFwaFPgv+6BfgVR77 eO4g== X-Forwarded-Encrypted: i=1; AJvYcCUYvVhReXyrYhIpqtDwD9etJFugAtXu465SL++mq4BhG/HmqsTtlniQ7EOwXnyhQPuhj3lE/qJCBD7xf8Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyQrktxkWtIhmRNLywnj8ClkSKQ5gq1S/pm5X3Km8HNM7APeKi4 k2oVxtt+TfYpF2omSH4AZ8Xk7cGtDcOR4KJGD6Pa5pfw7tKePdKBb6eCqHpFYA== X-Gm-Gg: ASbGncvVhxs/44xYWSNB3Zs5P8vo7iCOYfulIRoZ9sBp3Aqodkl1JhWOmj6zaYJYmY/ xLbco+tUzhc6LvKh57vpO0jp9wyMcrqihH4MPhtQ0Y49tIVocrqJyoslyMo3MLXzhZhe3N7+6sj p/TnGfNsd0ZPwcn3pCFmrbFCoQknoRhou/joJGHJtJ/MmHQ/oCnbTlyF0i+mdRsjxO3EPi6yYMF 7hbPTyjrSrJzvcJ7xrQqoWzqP7CZrspvvlqQxaRLwIDT9ceES5lYwMDdQIk2Eb65DR6kX8S+27q s2ivD4NIIWhKWFSMMFWiMw9Pik56KDMTQsC77FNGt3dXTbnQ56iC6i8c5CBwlpZ0k1jU0g== X-Google-Smtp-Source: AGHT+IF6rGXrSzCpvaNGhX4xciML4WX1Qp+Xf99qU1svwwhGPd2mOXprUmL/S+UqQYoWzSfytulsaw== X-Received: by 2002:a17:902:f644:b0:224:7a4:b31 with SMTP id d9443c01a7336-22c53e38f33mr139591965ad.6.1745230398086; Mon, 21 Apr 2025 03:13:18 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:7633:f42a:d31d:3f9c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22d78db8b04sm38985205ad.238.2025.04.21.03.13.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 03:13:17 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, linux-input@vger.kernel.org, Douglas Anderson , stable+noautosel@kernel.org Subject: [PATCH v2 4/8] arm64: dts: mediatek: mt8186-steelix: Mark second source components for probing Date: Mon, 21 Apr 2025 18:12:42 +0800 Message-ID: <20250421101248.426929-5-wenst@chromium.org> X-Mailer: git-send-email 2.49.0.805.g082f7c87e0-goog In-Reply-To: <20250421101248.426929-1-wenst@chromium.org> References: <20250421101248.426929-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Steelix design has two possible trackpad component sources. Currently they are all marked as available, along with having workarounds for shared pinctrl muxing and GPIOs. Instead, mark them all as "fail-needs-probe" and have the implementation try to probe which one is present. Also remove the shared resource workaround by moving the pinctrl entry for the trackpad interrupt line back into the individual trackpad nodes. Cc: # Needs accompanying new driver to work Signed-off-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- .../boot/dts/mediatek/mt8186-corsola-steelix.dtsi | 7 +++++++ .../mediatek/mt8186-corsola-tentacool-sku327683.dts | 2 ++ .../mediatek/mt8186-corsola-tentacruel-sku262148.dts | 2 ++ arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 10 ++++------ 4 files changed, 15 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi b/arc= h/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi index e74e886a00cb..822a177e7c19 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi @@ -123,8 +123,11 @@ trackpad@2c { reg =3D <0x2c>; hid-descr-addr =3D <0x20>; interrupts-extended =3D <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&trackpad_pin>; vdd-supply =3D <&pp3300_s3>; wakeup-source; + status =3D "fail-needs-probe"; }; }; =20 @@ -197,3 +200,7 @@ pins-vreg-en { }; }; }; + +&trackpad { + status =3D "fail-needs-probe"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku32768= 3.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts index c3ae6f9616c8..4dbf2cb73a81 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts @@ -17,6 +17,8 @@ trackpad@15 { compatible =3D "hid-over-i2c"; reg =3D <0x15>; interrupts-extended =3D <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&trackpad_pin>; hid-descr-addr =3D <0x0001>; vdd-supply =3D <&pp3300_s3>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku2621= 48.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.d= ts index 447b57b12b41..ee5bc2cd9e9f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.dts +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.dts @@ -19,6 +19,8 @@ trackpad@15 { compatible =3D "hid-over-i2c"; reg =3D <0x15>; interrupts-extended =3D <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&trackpad_pin>; hid-descr-addr =3D <0x0001>; vdd-supply =3D <&pp3300_s3>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/= boot/dts/mediatek/mt8186-corsola.dtsi index cebb134331fb..918f17385ba5 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi @@ -390,19 +390,17 @@ &i2c1 { =20 &i2c2 { pinctrl-names =3D "default"; - /* - * Trackpad pin put here to work around second source components - * sharing the pinmux in steelix designs. - */ - pinctrl-0 =3D <&i2c2_pins>, <&trackpad_pin>; + pinctrl-0 =3D <&i2c2_pins>; clock-frequency =3D <400000>; i2c-scl-internal-delay-ns =3D <10000>; status =3D "okay"; =20 - trackpad@15 { + trackpad: trackpad@15 { compatible =3D "elan,ekth3000"; reg =3D <0x15>; interrupts-extended =3D <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&trackpad_pin>; vcc-supply =3D <&pp3300_s3>; wakeup-source; }; --=20 2.49.0.805.g082f7c87e0-goog From nobody Sun Feb 8 21:49:09 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F03602638B4 for ; Mon, 21 Apr 2025 10:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230403; cv=none; b=RfNv0Xee1gQhEL07itUWSpqO99omxKLFRvq2ff0xwCTbeJFAsHpeMh3+jhUvN2zz1qSJDiqddkTQJE7SQMlBjbDVCpPoVvpiTjqu/or982vBVai1A4nronZoe35dWDq/tVZ2pyUUwTTgw/KKA281fTFI5ArF0w2FONRdVZOtfDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230403; c=relaxed/simple; bh=sy8ThRyRgU7oedwZh2khgThNY5WH15EZl03oVLUYUIA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RmhhXUcxkZQnLWMEKSS/MoPlvZWxYWiBhhhYYe/l+IGWpemA7/8onHgg3X131hLyLgHnENGowYkToBIcHaOYuT3ICzbpHVoDtU8L2ECBAGKHLORS/Qt+nx4U5RTwyxmgfPZqe6HINfNTK85GlNog0nSWUMwfHFWPZ93UREx0tzk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=PvMscab+; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PvMscab+" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-308702998fbso3445222a91.1 for ; Mon, 21 Apr 2025 03:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1745230401; x=1745835201; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rok2Mg43bnfRB9cqUAfce4PsDdZdAouW+RpiAparFCo=; b=PvMscab+f/DdGlLJV6Ty2Gp1BVUtvDMJSxM1BFQkpaZRq2K7gf56rj2xE7+yhd4c0E 3ITfuRNmnQeU1fVEHm/27tz7lyqLXmrI7hg78TdtVX8vhdkwGIODD5nIB0DxFFIOebLY WJiNvj7Uh609dX1cwfg9Xl7GE7BzPARmry/SI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745230401; x=1745835201; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rok2Mg43bnfRB9cqUAfce4PsDdZdAouW+RpiAparFCo=; b=rTpEMseMyHPQ6KLlIbO95QOMvPq7EmP1WC7xjHMIwyzjxvXPC1tllNFUg8toARP5L1 yV1C5GELFj2cWhnM+OITOP6fE+o6s8Rb0dml3aROmMjShzK6FL5p5S33As79y7+Q3Atc 8rIM5VI2o5VCDeNdeD5hQeAwM6oiX2qVgMDyykEvX+UU2D34WW8N1/vGKg2v2R2l7CxR m9Exh+5LOXKvoGiKJf+TdHcM/zUv6pVC5ue+didIyublZJvwZtqqMJjMaxE9+3dg/pLw lGxzuxhrnTebyFsXBBJnfmNOP6MgeyhqIXGR+l/WuKg5/DUp4xezGtIL2e6cL/EVSovQ 0h3w== X-Forwarded-Encrypted: i=1; AJvYcCVX95VsvPw8CQjT5Vhm4bScM1uxwFLm2E2dufyNyeUBwXjPdc5pGH1RN8HAmrAfVUgy/yCyMDKWryMptf0=@vger.kernel.org X-Gm-Message-State: AOJu0YyN9zdCAwFKpeVdCf8YLU8w9lwxrGn0brtDZH892zQ8sIa3fGMw 99bmYJxczYdVP9hFq1KKNA4UHu99EYAftCtTnpnOq9iWYdQWxVQgjMjjKHiGrw== X-Gm-Gg: ASbGncseWXownnF4fFgjztS8/XZiOSNEz5NDyuL40PF2kaRoOJtaPOr1grQO6yu+TTv nq/yKGiCSebAZZ8Av/sphXqQZWTKkfBBl6brc1lS6bioGKISFPxBAo4Oxe3NI5wnpHM6QGplm3z jpMvCrDrV/Oy5noF+rXQ+UQGvQ04n1HmO6hY5r8j3xof3WGkUIBzVtqD1cDOEHCsJVHEFao78TB O+lagmvPlUVcYO3WRxTTPVIDoiSRO6BEjtXsx9+/gmVVTxaGLgezMqu0WrDJZnSw7IujAaAKBX6 T0R5TAL5AgOst9eJJRkNdq8SXjIj88vh5OBEVQEee+3VxypQAe4f85YRgc8= X-Google-Smtp-Source: AGHT+IHzGqLnsYoPPrUzas9aFIuhG2tfwpqW1sujdJRkCyGS/gKycIu8sZyY4IdNUXVMBMKhKzW5aQ== X-Received: by 2002:a17:90b:4ad0:b0:2fe:a742:51b0 with SMTP id 98e67ed59e1d1-3087bcc8fcbmr14175251a91.31.1745230401151; Mon, 21 Apr 2025 03:13:21 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:7633:f42a:d31d:3f9c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22d78db8b04sm38985205ad.238.2025.04.21.03.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 03:13:20 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, linux-input@vger.kernel.org, Douglas Anderson Subject: [PATCH v2 5/8] arm64: dts: mediatek: mt8186: Merge Voltorb device trees Date: Mon, 21 Apr 2025 18:12:43 +0800 Message-ID: <20250421101248.426929-6-wenst@chromium.org> X-Mailer: git-send-email 2.49.0.805.g082f7c87e0-goog In-Reply-To: <20250421101248.426929-1-wenst@chromium.org> References: <20250421101248.426929-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are only two different SKUs of Voltorb, and the only difference between them is whether a touchscreen is present or not. This can be detected by a simple I2C transfer to the address, instead of having separate device trees. Merge the two device trees together and simplify the compatible string list. The dtsi is still kept separate since there is an incoming device that shares the same design, but with slightly difference components. Signed-off-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/Makefile | 3 +-- .../mediatek/mt8186-corsola-voltorb-sku589824.dts | 13 ------------- ...orb-sku589825.dts =3D> mt8186-corsola-voltorb.dts} | 5 ++--- 3 files changed, 3 insertions(+), 18 deletions(-) delete mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku= 589824.dts rename arch/arm64/boot/dts/mediatek/{mt8186-corsola-voltorb-sku589825.dts = =3D> mt8186-corsola-voltorb.dts} (76%) diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/me= diatek/Makefile index 58484e830063..ff67931e7821 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -73,8 +73,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-tentacool= -sku327681.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-tentacool-sku327683.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-tentacruel-sku262144.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-tentacruel-sku262148.dtb -dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-voltorb-sku589824.dtb -dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-voltorb-sku589825.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-voltorb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8188-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8188-geralt-ciri-sku0.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589824.= dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589824.dts deleted file mode 100644 index d16834eec87a..000000000000 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589824.dts +++ /dev/null @@ -1,13 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0 OR MIT) -/* - * Copyright 2022 Google LLC - */ - -/dts-v1/; -#include "mt8186-corsola-voltorb.dtsi" - -/ { - model =3D "Google Voltorb sku589824 board"; - compatible =3D "google,voltorb-sku589824", "google,voltorb", - "mediatek,mt8186"; -}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589825.= dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb.dts similarity index 76% rename from arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589825.d= ts rename to arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb.dts index 45e57f7706cc..cc805408a8b7 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589825.dts +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb.dts @@ -7,9 +7,8 @@ #include "mt8186-corsola-voltorb.dtsi" =20 / { - model =3D "Google Voltorb sku589825 board"; - compatible =3D "google,voltorb-sku589825", "google,voltorb", - "mediatek,mt8186"; + model =3D "Google Voltorb board"; + compatible =3D "google,voltorb", "mediatek,mt8186"; }; =20 &i2c1 { --=20 2.49.0.805.g082f7c87e0-goog From nobody Sun Feb 8 21:49:09 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F421B263F25 for ; Mon, 21 Apr 2025 10:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230406; cv=none; b=Lw2S1dZsd4h0ytWqFMFcAgILJWAsrLVuZjo+UzOU7KLmUgBP+BvtJn3Uv17yoT2bOSsIkRTGYnWA0O0Sr3t0ZrcuA/JPxm+y1gHzG/jk3EJUu/SOemb1qT7XD0Bb6JDRsKYIb970O/v+8GABNf39PFwALPa1FjL4vhKrwgMAZnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230406; c=relaxed/simple; bh=E6JFtxDZbzhj1oi4qP6ZpzahkFOgUu69fyYc5siUtFc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sNQ7Uy3F4JN2EySm8AZT2X49ifqRkPkde1p+gwhW+s9jwhDfLnxCQC9P/MhTuCNNyGEli/MGoiu1yI+5HwhDKcRpxJjsVHKDeL5DaF8U6bQFbF0QO/Ly4COhp1Bt0EHMuonvSuOmuL/dPvABu5lsHD/R7ljpkiJ3vFHW09yke5M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=TvL+E+3O; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TvL+E+3O" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-af9925bbeb7so2505359a12.3 for ; Mon, 21 Apr 2025 03:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1745230404; x=1745835204; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fI4INpVmKKLQ+GnUwLC8BM3GpY4ldbDIRRh2dXHIFMs=; b=TvL+E+3Of8NkfZWN+O7K1OgiD8A8+3A0LE/73JBDvW6jALz66CEdqUZR66ciNdHG2X yAA6r/C/KcazTvuptucquJfp+7rk5ksHPj8bxPSUywUIBQcxW5EMsMN8lB5QM0r5myIE p8A0KpILzL9j6BYbfGKNQxLkMZ2cO+cJeS7zA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745230404; x=1745835204; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fI4INpVmKKLQ+GnUwLC8BM3GpY4ldbDIRRh2dXHIFMs=; b=ArFka6O5x7Fepme0N4z4Mh/8+1N8Ast+gR9GASm0LtGhsazp2NhYAaNDT06ZAGMNcR DRLGHe8y2qbtGEM+MX0ldkeEzVljj/ZHkpl64I/QsaTkQsTJIi/ife7ewZQVxmakARzn h8eK6Jgj8JL+lopVOLUeTJ6wgfbPwOAgxnsqFM5cPU0EGn80PWDydH33Tyl8f2e3oCzb Zen8WGlin327pYu/w1HTOGhiEcqkXuwnqO2rFraWNjJB666pGC9wd/GdV9ClfZKcYJaE c00pCnqieI8U1BYTeGWXfBqfbZx0ngZInnI5C/yCXQJesHsVYp7MWoLAEVsWOHcvIVm/ 6uAQ== X-Forwarded-Encrypted: i=1; AJvYcCXKK/1v+zfAkCQ/UJYLPeubUDA8/u+gc0JbiZaWcJmjLDdU0siaVYj958LK3dmKwrk3Ug8agdml02IbuuY=@vger.kernel.org X-Gm-Message-State: AOJu0YwsVGDWXyQvZV5QhuinKcczDigJpPYsu8xUsrSnK712Iy6ZJuQS FSm0KWctP08fOyUcCatdRGGv4z8mT05BtIE4T2L19iBuz1ECndN/hZ9pWYDfRg== X-Gm-Gg: ASbGnctBqAga+qZ//i703uVTwosVT05tqOcyQFUuz25eZvYRWG1nWPBxlcGd9Z3pQoR N7/tXn6yBCS3tQPtigEr5pdI/fEOiOOQbK1tN69Xmpos79v2StQiEqDnF9JcA8eQ1zeJbb5Rf5T eJBwsq71X2kqkIqGtNcXLGn5Gay6BqKZaHIRq4032io2uKyygLSpL8ae2amoaWVohwdrjfi0yRr tzvb3bMgt8+83hP4kWbcruWmExCgYxPgleedQWPBEvyrwaxqJ+YSM3NPmx/TPE61yJ2BOsDFt+X Mgb2oESBYnDBl7haITe0GHh0tcagVuhrk8gHi2qLJ9IB/lGmQhc95SSU1+c= X-Google-Smtp-Source: AGHT+IGEkbtC/fVUVtuk0XcjS/PS+i1YOa/LJMDWAqNFAJ0mD3J0gKfEIcrJJeHWHk1BOZIZJkjZmQ== X-Received: by 2002:a17:902:d48f:b0:227:ac2a:1dcf with SMTP id d9443c01a7336-22c535bf828mr153722745ad.23.1745230404197; Mon, 21 Apr 2025 03:13:24 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:7633:f42a:d31d:3f9c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22d78db8b04sm38985205ad.238.2025.04.21.03.13.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 03:13:23 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, linux-input@vger.kernel.org, Douglas Anderson Subject: [PATCH v2 6/8] arm64: dts: mediatek: mt8186: Add Squirtle Chromebooks Date: Mon, 21 Apr 2025 18:12:44 +0800 Message-ID: <20250421101248.426929-7-wenst@chromium.org> X-Mailer: git-send-email 2.49.0.805.g082f7c87e0-goog In-Reply-To: <20250421101248.426929-1-wenst@chromium.org> References: <20250421101248.426929-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a device tree for the MT8186 based Squirtle Chromebooks, also known as the Acer Chromebook Spin 311 (R724T). The device is a 2-in-1 convertible. Signed-off-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/Makefile | 1 + .../dts/mediatek/mt8186-corsola-squirtle.dts | 107 ++++++++++++++++++ .../dts/mediatek/mt8186-corsola-steelix.dtsi | 2 +- 3 files changed, 109 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/me= diatek/Makefile index ff67931e7821..77ce29608170 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -65,6 +65,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-magneton-= sku393216.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-magneton-sku393217.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-magneton-sku393218.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-rusty-sku196608.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-squirtle.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-starmie-sku0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-starmie-sku1.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-steelix-sku131072.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts b/arc= h/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts new file mode 100644 index 000000000000..f721ad4e5c97 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts @@ -0,0 +1,107 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2024 Google LLC + */ + +/dts-v1/; +#include "mt8186-corsola-voltorb.dtsi" + +/ { + model =3D "Google squirtle board"; + compatible =3D "google,squirtle", "mediatek,mt8186"; + chassis-type =3D "convertible"; +}; + +&i2c1 { + touchscreen@10 { + compatible =3D "elan,ekth6915"; + reg =3D <0x10>; + interrupts-extended =3D <&pio 12 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&touchscreen_pins>; + reset-gpios =3D <&pio 60 GPIO_ACTIVE_LOW>; + vcc33-supply =3D <&pp3300_s3>; + status =3D "fail-needs-probe"; + }; + + touchscreen@16 { + compatible =3D "elan,ekth8d18", "elan,ekth6a12nay"; + reg =3D <0x16>; + interrupts-extended =3D <&pio 12 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&touchscreen_pins>; + reset-gpios =3D <&pio 60 GPIO_ACTIVE_LOW>; + vcc33-supply =3D <&pp3300_s3>; + status =3D "fail-needs-probe"; + }; +}; + +&i2c2 { + trackpad@68 { + compatible =3D "hid-over-i2c"; + reg =3D <0x68>; + hid-descr-addr =3D <0x20>; + interrupts-extended =3D <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&trackpad_pin>; + vdd-supply =3D <&pp3300_s3>; + wakeup-source; + status =3D "fail-needs-probe"; + }; +}; + +&i2c5 { + clock-frequency =3D <400000>; + + /delete-node/ codec@1a; + + rt5650: codec@1a { + compatible =3D "realtek,rt5650"; + reg =3D <0x1a>; + interrupts-extended =3D <&pio 17 IRQ_TYPE_EDGE_BOTH>; + avdd-supply =3D <&mt6366_vio18_reg>; + cpvdd-supply =3D <&mt6366_vio18_reg>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&speaker_codec_pins_default>; + cbj-sleeve-gpios =3D <&pio 150 GPIO_ACTIVE_HIGH>; + #sound-dai-cells =3D <0>; + realtek,dmic1-data-pin =3D <2>; + realtek,jd-mode =3D <2>; + }; +}; + +&sound { + compatible =3D "mediatek,mt8186-mt6366-rt5650-sound"; + model =3D "mt8186_rt5650"; + + audio-routing =3D + "Headphone", "HPOL", + "Headphone", "HPOR", + "HDMI1", "TX"; + + hs-playback-dai-link { + codec { + sound-dai =3D <&rt5650>; + }; + }; + + hs-capture-dai-link { + codec { + sound-dai =3D <&rt5650>; + }; + }; + + spk-hdmi-playback-dai-link { + codec { + sound-dai =3D <&it6505dptx>; + }; + }; +}; + +&speaker_codec { + status =3D "disabled"; +}; + +&trackpad_steelix { + status =3D "disabled"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi b/arc= h/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi index 822a177e7c19..8a196dc9a96b 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi @@ -118,7 +118,7 @@ &i2c2 { i2c-scl-internal-delay-ns =3D <22000>; =20 /* second source component */ - trackpad@2c { + trackpad_steelix: trackpad@2c { compatible =3D "hid-over-i2c"; reg =3D <0x2c>; hid-descr-addr =3D <0x20>; --=20 2.49.0.805.g082f7c87e0-goog From nobody Sun Feb 8 21:49:09 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15DF8261581 for ; Mon, 21 Apr 2025 10:13:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230409; cv=none; b=QSQ5zE5FpTvFfIsaxOne/IaAc2DUuJT4fV4OtKswMUsS/ZImuvtUzB+fiKM3VgILpRKQPLvB+qauJ0mgZZ5y8qJGf0kV8rRONBtguGYJhfqKlspdV44oGhADEQk/X7HlNNwKkI+jNa19UC5PT9rPGvJSGl62I7iz1fkDThhuDuw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230409; c=relaxed/simple; bh=qF7jWnTilMBS2qcmpMwmTaRPTIW0Gr0c/UFCDNrCywY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GWcfEMvYZ7i1aeH6awjFM/sSfVu/n5g9yAzmDb2/HuuegBpjGu/L42MFOfiVvB4FQYW1FErAv1cfg7fS0qlfroqSGaog24weD8xLw2daF2JzejZmNgmWYc9wg4GnXDToXq97jTcr3vh3tyFy5S6CzTp0pTQ8jBwiPEq7VKFUbTY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=GsxUWMiF; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GsxUWMiF" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-224019ad9edso54596035ad.1 for ; Mon, 21 Apr 2025 03:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1745230407; x=1745835207; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RcjHyP3cBWKaEk01AYLfxR/iTiJMn9iHLwLqY1LLLpk=; b=GsxUWMiFK0oWYAKsRY0F5+gFDuXQv06/pFo9Cdam+ZNfTR2Cq6J2m+YtHsFvqVBJtP QBA5FCVFI7PaXPzbST3fzJ1n5s3mbscuTQsYkhurNXrS6AAfij6h5H2uZSO6gygWcAR+ brHiEX5yebvHgBhNlHtnMs3BAo0aYQoLycePU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745230407; x=1745835207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RcjHyP3cBWKaEk01AYLfxR/iTiJMn9iHLwLqY1LLLpk=; b=AiKoqQ4Fyv8KIcQktjB3aRcbA2KiqlP5+PCXS6ZgabhH6/1kDkJIv9Ojy+EzB4/8Vw wxP/ZSqunvipKrNiP9S86UQFU243rBEVNz5vto9z90+q+fcifJ9GUzvcUdapJy0j90U1 FKw2maRwg5Axz03riuLK8no6CeqA+stpSPQdNvya57zbF7Lj1+8GfCXfqaMKVMf0zsXP ACcltiLNa9Mgxsuq8IWpKF+ZAHc1YlC0FGQcwzYUgbMnf8S7ZIbSslaUcNvXqV+Urw3D qExuCWuYXk4krm/XQiivsrxLy0ReKBNbmbzqhEhqmjTMWgjuQhvOf6VNhgKpd0e2r+uT yj5Q== X-Forwarded-Encrypted: i=1; AJvYcCWmZ+wZZW8ruRJc91Ds61UzCVg0/3kP6qRPUa2nRIs/ETu4dPRjb+tfLlqMtzCPU+bf4GlTWQe3QqXR/0g=@vger.kernel.org X-Gm-Message-State: AOJu0YyXkWR8Dp2lH3Apqgp26bw/IsNUC8QVLbDADKNLAfklVUoOU8Jg 5rI+vT65WLa1m+LPfv257tIZxljCcH6b6ENeOyBDIKTe8CA8YmYRSlrnOtkmDw== X-Gm-Gg: ASbGncs+eBxMkDu+0e27OV6qIjz9zPcf9T4h7a/HEieK01GQK6KZnkfDnLtN87NG2zD NzB0v99dutIBvebTXurgF92SJ5nDGeXBDkAOXPIXaKXv88y7pZn8KmINwD624j8J+MtZ01ehrCF xYWBLD0YOg75NpEtL6yyFH+rG+vewjqFzemoUh+KkIqMQ6JwQeIoz9W4+uupDt+iWt9XLBOr/aP 2sLQAc+Zm22sjoWunWDQUAsTEmhNGbielCUi9X5Wqdji9BhrDEXZf/8xFbsvXRxGtXO8YJEdBAc Bo0ByRhGRKEHR6gdiqced2sZgh+zvAi0oHGhg7thlnGdZJDOQZFGHUxWJ1it7lRh4z1dOg== X-Google-Smtp-Source: AGHT+IHuFSunYBioxk4Fk/97b/EXhuCRKPWNocxu/A5uMoJPd3zI4mtSEWbcD0F9jrilaVzVx5rPjA== X-Received: by 2002:a17:903:41c7:b0:220:faa2:c911 with SMTP id d9443c01a7336-22c535a4b39mr151608295ad.14.1745230407602; Mon, 21 Apr 2025 03:13:27 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:7633:f42a:d31d:3f9c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22d78db8b04sm38985205ad.238.2025.04.21.03.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 03:13:26 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, linux-input@vger.kernel.org, Douglas Anderson Subject: [PATCH v2 7/8] platform/chrome: of_hw_prober: Support trackpad probing on Corsola family Date: Mon, 21 Apr 2025 18:12:45 +0800 Message-ID: <20250421101248.426929-8-wenst@chromium.org> X-Mailer: git-send-email 2.49.0.805.g082f7c87e0-goog In-Reply-To: <20250421101248.426929-1-wenst@chromium.org> References: <20250421101248.426929-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Various MT8186 Corsola Chromebooks (squirtle, steelix and voltorb families) have second source trackpads that need to be probed. The power supply for these are always on and their reset/enable lines are not exposed. Add them to the probing list. Signed-off-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Benson Leung --- Changes since v1: - Rebased and resolved conflicts with "spherion" trackpad prober --- drivers/platform/chrome/chromeos_of_hw_prober.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/platform/chrome/chromeos_of_hw_prober.c b/drivers/plat= form/chrome/chromeos_of_hw_prober.c index 019578bc7ad0..10dbaede0541 100644 --- a/drivers/platform/chrome/chromeos_of_hw_prober.c +++ b/drivers/platform/chrome/chromeos_of_hw_prober.c @@ -57,6 +57,7 @@ static int chromeos_i2c_component_prober(struct device *d= ev, const void *_data) } =20 DEFINE_CHROMEOS_I2C_PROBE_DATA_DUMB_BY_TYPE(touchscreen); +DEFINE_CHROMEOS_I2C_PROBE_DATA_DUMB_BY_TYPE(trackpad); =20 DEFINE_CHROMEOS_I2C_PROBE_CFG_SIMPLE_BY_TYPE(trackpad); =20 @@ -88,6 +89,18 @@ static const struct hw_prober_entry hw_prober_platforms[= ] =3D { .compatible =3D "google,spherion", .prober =3D chromeos_i2c_component_prober, .data =3D &chromeos_i2c_probe_hana_trackpad, + }, { + .compatible =3D "google,squirtle", + .prober =3D chromeos_i2c_component_prober, + .data =3D &chromeos_i2c_probe_dumb_trackpad, + }, { + .compatible =3D "google,steelix", + .prober =3D chromeos_i2c_component_prober, + .data =3D &chromeos_i2c_probe_dumb_trackpad, + }, { + .compatible =3D "google,voltorb", + .prober =3D chromeos_i2c_component_prober, + .data =3D &chromeos_i2c_probe_dumb_trackpad, }, }; =20 --=20 2.49.0.805.g082f7c87e0-goog From nobody Sun Feb 8 21:49:09 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 759F32641DB for ; Mon, 21 Apr 2025 10:13:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230414; cv=none; b=HrQVCDAxjMzqk1DbsNqYO/4iWOMkV+7cSKiYC4o30O6tMfMD2Z3KO1eOce6gVf+/k24C8xTWJ9B2l/0aNyWTPh1dLbpQGFGbXE0CKzKOx6mZ1cuQHTUhbiywp/2WNTmmcSU54M/TYiggHMCjF0uSz0E/dhqltoaImv7jZQfoYf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745230414; c=relaxed/simple; bh=Pz2EbCAhTSbi3s1n0uikdRPmeNKPOIEQOu+qX+8XfSU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jymL/5AXZAI4rjjMxImDqPs0xGR8gCgpKCk96H1G9kNQOExWdaayx47f957E3dt8qmDxyRsE0/zzQtDGjZ9tKq7oGmAiSR/yWLwxv/vgkZ4a5/G/eRGdRl/cH+GpcKKRxPWH6/b0t03V5HIUxjcjfMOjrqAp3bVPb0VExn7mw+I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Uq0J0tNU; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Uq0J0tNU" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2240b4de12bso55715545ad.2 for ; Mon, 21 Apr 2025 03:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1745230411; x=1745835211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JlRUONHPgdRG0yBjPS5/nMKjk95rCFAaXubE+yQQ9K0=; b=Uq0J0tNUMXMRSwnV4897lUxgzT3P0xngZoRg/eWiM6OnZ0DGA0zliAwCai/oDgOAIe T6j8+aLgluv1ZTjs5xLZRez6n26sss2fjxgy3zjrIGBZvhFjwODQGlnVWJTSYttyPXeu CMTwETZAL9HW4AO7MBzI00Ohf/8Z43r4yqC2I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745230411; x=1745835211; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JlRUONHPgdRG0yBjPS5/nMKjk95rCFAaXubE+yQQ9K0=; b=DuM23RqX4IMd14rZzpGhzzIkTeEWpj71s+rSliBkPZ/Yv6/Nb6MYV2AR5Nl8yV5SyR aEPyckNWgAfLfeqjLVwvYcsnhtul5wfx5MZ4h9dIQmFyqNjvnKhPpGkKRzOJXgxExoCN pf9CFG/3EdZmk/2PlSzgKxtoVWBpkIXmos46b0O7Ari1eoGJ7rl9VlfrbdbJYcAMMi3l jR7CvZxPNTA0FZOlmeaCdbTf5PojDbLc0aivevG/uSjBnoE5AUrhSGHQm88du2n8qdKB 5GaJ31FibuP5V5oGBoy4ReB3Ng3iBNQwaqA2k3SUfDwGZXiYFLv2J5TCFwR74r0PwC5r f2KA== X-Forwarded-Encrypted: i=1; AJvYcCX2CVBHHYFp6Kt9kBgzvaEYvnMlFa4JQemoGbi0ZkK4tf6lAWQCfNIfSyrgxUcyh8SNiK2VRROcMcMM/+Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yztr+6r84PovxuLmyigrOz55FLQDkK0DXmWZ1GB//VCbTCyaFWm 1SBVEZzt3bk6F0rc+qJFbGMnVsz4/8IW1t2/MmSG+u/xPbwyLHjzvMieXT+kIg== X-Gm-Gg: ASbGnct1TdJDZ/AP2R4OLuqC90MbgNfCpdTfsnItScpB3zUzYUnUkXS1aWxtTQlhLy8 aqbvnQL0Pe1CDOCC+WFT7YhDMuyNOa+OBX7mqFlCUDGe7ND/IoCaEY8tOJ66QeG7tZCWeNn6WWE ODI1YnGunTUNtdnVh9alm2HG8KJygMludrqzi7tvQ3XHzjT2TnGom9oDB4CrysX80+5zb9aL+jD Jydq3RTjl5w895CZE2egZ+HLyQOqbwB5HsqrOypfWb69l4YQn/6Jn/YOIIYPvxsWgkgjyk0fr98 9d6ciR4Gnrsw/YAeYwPDx77lMaAbpnn4Th/OTEASYX6yVIiNQv1EZ8EFMUQ= X-Google-Smtp-Source: AGHT+IGaSj2NjUkLJYtvrXbaniU4ZUkVXBRJQywqY5KHy1I4U9ywfY/tOoiirvNsMeMMe1Zel8Bsug== X-Received: by 2002:a17:902:ce86:b0:220:c143:90a0 with SMTP id d9443c01a7336-22c535a7254mr159468475ad.24.1745230410702; Mon, 21 Apr 2025 03:13:30 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:7633:f42a:d31d:3f9c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22d78db8b04sm38985205ad.238.2025.04.21.03.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 03:13:30 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, linux-input@vger.kernel.org, Douglas Anderson Subject: [PATCH v2 8/8] platform/chrome: of_hw_prober: Support touchscreen probing on Squirtle Date: Mon, 21 Apr 2025 18:12:46 +0800 Message-ID: <20250421101248.426929-9-wenst@chromium.org> X-Mailer: git-send-email 2.49.0.805.g082f7c87e0-goog In-Reply-To: <20250421101248.426929-1-wenst@chromium.org> References: <20250421101248.426929-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The MT8186 Squirtle Chromebook is built with one of two possible touchscreens. Let the prober probe for them. Signed-off-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Benson Leung --- drivers/platform/chrome/chromeos_of_hw_prober.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/platform/chrome/chromeos_of_hw_prober.c b/drivers/plat= form/chrome/chromeos_of_hw_prober.c index 10dbaede0541..f3cd612e5584 100644 --- a/drivers/platform/chrome/chromeos_of_hw_prober.c +++ b/drivers/platform/chrome/chromeos_of_hw_prober.c @@ -59,6 +59,7 @@ static int chromeos_i2c_component_prober(struct device *d= ev, const void *_data) DEFINE_CHROMEOS_I2C_PROBE_DATA_DUMB_BY_TYPE(touchscreen); DEFINE_CHROMEOS_I2C_PROBE_DATA_DUMB_BY_TYPE(trackpad); =20 +DEFINE_CHROMEOS_I2C_PROBE_CFG_SIMPLE_BY_TYPE(touchscreen); DEFINE_CHROMEOS_I2C_PROBE_CFG_SIMPLE_BY_TYPE(trackpad); =20 static const struct chromeos_i2c_probe_data chromeos_i2c_probe_hana_trackp= ad =3D { @@ -76,6 +77,17 @@ static const struct chromeos_i2c_probe_data chromeos_i2c= _probe_hana_trackpad =3D { }, }; =20 +static const struct chromeos_i2c_probe_data chromeos_i2c_probe_squirtle_to= uchscreen =3D { + .cfg =3D &chromeos_i2c_probe_simple_touchscreen_cfg, + .opts =3D &(const struct i2c_of_probe_simple_opts) { + .res_node_compatible =3D "elan,ekth6a12nay", + .supply_name =3D "vcc33", + .gpio_name =3D "reset", + .post_power_on_delay_ms =3D 10, + .post_gpio_config_delay_ms =3D 300, + }, +}; + static const struct hw_prober_entry hw_prober_platforms[] =3D { { .compatible =3D "google,hana", @@ -93,6 +105,10 @@ static const struct hw_prober_entry hw_prober_platforms= [] =3D { .compatible =3D "google,squirtle", .prober =3D chromeos_i2c_component_prober, .data =3D &chromeos_i2c_probe_dumb_trackpad, + }, { + .compatible =3D "google,squirtle", + .prober =3D chromeos_i2c_component_prober, + .data =3D &chromeos_i2c_probe_squirtle_touchscreen, }, { .compatible =3D "google,steelix", .prober =3D chromeos_i2c_component_prober, --=20 2.49.0.805.g082f7c87e0-goog