From nobody Mon Feb 9 15:45:25 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 018CF25A2BF for ; Mon, 21 Apr 2025 09:44:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228646; cv=none; b=XJyfTPz4D7zqxC+lpU0adYeWOiSmkoPcjfTCwPVStoyI0zJls6P3oGUNjSWdIF5Px1qHcLPqZ2YO3Kj+AUftuOsGeRuu8F7YLfNfAKwG2YIc3fnoHIUrZY0BgOYutr37cc2IBWt5n/Q2bs3BK09eXJESRSMDKTuK48D3epUE17s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228646; c=relaxed/simple; bh=AhRbnxt00FmE/WhEN1u8zVz8q5gXEKLj1JYmMYck0AA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CAmQvY8PyPP0VCyeRJQ6TJZLKopppoGNlb/sfAXwNJ/WSees8TLW/334ug7FBfWQDMyDfyupBCb92iikN2d6caKW2UeVoabcRW13+9fg3tsPAdKGdqMz+OPbWLb7r8K+OL2K4g90BK3N0REMHi0SRQLrOG2AB1zAuA2qsVb5ZHs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=YGA4WY6K; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="YGA4WY6K" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2295d78b45cso61229635ad.0 for ; Mon, 21 Apr 2025 02:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745228644; x=1745833444; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dTYlTOXj1U7VnsAmcUnx1eYdk5rL5ZGZ7LNT8Q6B11E=; b=YGA4WY6KQSctBDXQ42DOC/hbszCtaDYiSjYik0hKWJoyHP/aLVQxyrG+eHxsvTq6tm /3fU76TKg+R6WR5i8PVo0Tx+nxx+MCQwEdEESqzDo472JqyVkhdhp5fjFajZuGtG5XRo rsVABhKZpUSCRgOxHy/Fb6AHG99AOw2yyh1YAu42Xn5HgB+0/YndFty4EVvEoIC+JHcF 0N3uWT/RkhS4IGGCbrswvpcF0dSPzzzHa69o3VnXahBDroOoDL2Li25LxveAJpUsQ3iO 0oojZJfzeolI0k16DITY5pRcQ1PvPFlMTx4XtU0AD/sonxAlDv6V7wPPs2/UdP7D2DXV w6OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745228644; x=1745833444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dTYlTOXj1U7VnsAmcUnx1eYdk5rL5ZGZ7LNT8Q6B11E=; b=GAYl+GYULTUUmMuQcwVc7+PXc4wyVv0+UdrvnLaKfma8I4lQWBgtpIxDKPGnSE45u0 enN7AjJdhmg53rsGL7WdTU2DghJXoYnd2W9Abt3M89zG6bMt3XgdmOgJeHGNqSOcgFMM Pdy1THR0lvCcYrPGAbkFni5GFWJo7dKmBq059YEDyFQuF2elvdZZpczjIHkap5ebUP7q +hKnhs3GSJMa3hOssRMKakazijE99vRpVs6RuWq1/u8zsSdBtiyIXQxMn813m+lAMOq+ fGPePkJN1e+65JYzrR/zZVzmMzrl46lTn6iiljhr/5RCMswkQh8Ymkw/BHATwEiutavv GGmg== X-Forwarded-Encrypted: i=1; AJvYcCUN5743AJAISbmknfjKLwezzS6ZZg19HIFt8pmEwh0NmZfSBLqsKUDSq+9irRE1NmHQdXOemOhbsKx8hE4=@vger.kernel.org X-Gm-Message-State: AOJu0YylUTBtkS+PVE2BmNeNCwLVAivyIDqJEQSfFzm6qJTySyWsShYp +cAMXsnCO64rpmj83J255yZjTPBhvrH0pff+36TT1v9rBzfm5GQx3TcVthx9jCE= X-Gm-Gg: ASbGnctPgc6cZhwE/rjNsLt1rQYjGBaoc+0E4OLp/Mvi9HZN0D1eiqYTMjMky5Q1iiQ DwPMp+h6smk3RqaiD3VarXly5DK01/842PxyiUYo2jREYR4Hs5HhHEvtMrc0tB8GwIN+xDFWufD LOaqQdydraWrSCphiTsdsfZeAUPZ/sLdr/qHpB0xqJMTZ27kOh5iQ8FH4Ac6ucJc/QdcrnlCZTf phYr0AUM1dSgZuNAd8RnyEHw/IavOPUwrYRCvPxBq++rmZFKBg7ZPDCVBFIpITbYfOsOUo2400r 8c1Kbe5omokiaimCDjTFTf5LdPQ9afBvNhashulDqmjhMkU5f8sqsn0ZI4Jzd9aW8o/SMmA0ohe ctQ== X-Google-Smtp-Source: AGHT+IHEYpGr2ZvIBvvKW7ZFaNUJwrpR7XQJq5VPcYBgX/Wl0N6AKjMZmEmIW83x6cviTTPcE+wOYA== X-Received: by 2002:a17:902:f541:b0:21f:c67:a68a with SMTP id d9443c01a7336-22c535acbeemr153720645ad.31.1745228644193; Mon, 21 Apr 2025 02:44:04 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73dbfaacf32sm6371965b3a.142.2025.04.21.02.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 02:44:03 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Zong Li , Vincent Chen Subject: [PATCH v11 2/5] pwm: sifive: change the PWM algorithm Date: Mon, 21 Apr 2025 17:55:18 +0800 Message-Id: <20250421095521.1500427-3-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250421095521.1500427-1-nylon.chen@sifive.com> References: <20250421095521.1500427-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The `frac` variable represents the pulse inactive time, and the result of this algorithm is the pulse active time. Therefore, we must reverse the = result. The reference is SiFive FU740-C000 Manual[0] Link: https://sifive.cdn.prismic.io/sifive/1a82e600-1f93-4f41-b2d8-86ed8b16= acba_fu740-c000-manual-v1p6.pdf [0] Co-developed-by: Zong Li Signed-off-by: Zong Li Co-developed-by: Vincent Chen Signed-off-by: Vincent Chen Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index d5b647e6be78..bb9146267bc5 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -110,9 +110,10 @@ static int pwm_sifive_get_state(struct pwm_chip *chip,= struct pwm_device *pwm, struct pwm_state *state) { struct pwm_sifive_ddata *ddata =3D pwm_sifive_chip_to_ddata(chip); - u32 duty, val; + u32 duty, val, inactive; =20 - duty =3D readl(ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + inactive =3D readl(ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + duty =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - inactive; =20 state->enabled =3D duty > 0; =20 @@ -123,7 +124,7 @@ static int pwm_sifive_get_state(struct pwm_chip *chip, = struct pwm_device *pwm, state->period =3D ddata->real_period; state->duty_cycle =3D (u64)duty * ddata->real_period >> PWM_SIFIVE_CMPWIDTH; - state->polarity =3D PWM_POLARITY_INVERSED; + state->polarity =3D PWM_POLARITY_NORMAL; =20 return 0; } @@ -137,9 +138,9 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, unsigned long long num; bool enabled; int ret =3D 0; - u32 frac; + u32 frac, inactive; =20 - if (state->polarity !=3D PWM_POLARITY_INVERSED) + if (state->polarity !=3D PWM_POLARITY_NORMAL) return -EINVAL; =20 cur_state =3D pwm->state; @@ -157,8 +158,9 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, */ num =3D (u64)duty_cycle * (1U << PWM_SIFIVE_CMPWIDTH); frac =3D DIV64_U64_ROUND_CLOSEST(num, state->period); - /* The hardware cannot generate a 100% duty cycle */ + /* The hardware cannot generate a 0% duty cycle */ frac =3D min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); + inactive =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; =20 mutex_lock(&ddata->lock); if (state->period !=3D ddata->approx_period) { @@ -190,7 +192,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, } } =20 - writel(frac, ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + writel(inactive, ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); =20 if (!state->enabled) clk_disable(ddata->clk); --=20 2.34.1