From nobody Sun Feb 8 17:04:46 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C384C259CB3 for ; Mon, 21 Apr 2025 09:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228642; cv=none; b=Mm8/trjaLchMk4+Hqq5VXzyDLPi4WETojSbm/O+vr132kw75mDy4m6zYPnlrUthVNCIYQGcoOqrL5ldKvFkxRgS/Je4pCvxroLxgsshCraS6jFJlyQ9R8M391r4b6295bkWhtpSnbFxgS1zvqDQ/MizV3sdgZGr/XmatzDUDPpk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228642; c=relaxed/simple; bh=plbpc31rVrOD0KMkWiMy9DSCysG2bPp4EWpOgbNVk+g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bTa7xOW9NqSdQFys3IS//EPynNBWKUqxPNj40qyvwnJMRFBGeK4ZF4Xsp3yB0NPY1OQ0TAjU1UYKmtN5uQUuX82cHJ9Rsb7TBMlSEPQHQInnpbuk9o+5zHu3k64A8PW8u4YjWgPEDLopjfvG5cdvfPghHNSITv/xUijzrjlBxfg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=QpTS3Jx0; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="QpTS3Jx0" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-736b350a22cso3029791b3a.1 for ; Mon, 21 Apr 2025 02:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745228640; x=1745833440; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l3iCEA8tjYiThU7Rin4dKsTFv6XsSOzMIb0/FuGpw2E=; b=QpTS3Jx0AQQtvw0bUms0dxP5nQxsRQKGIU9irI+BeDdQvsuv0t8ePG+62pwA2v0iAd mbJKOWdFkzNHw2akVdROo0XNxCvINnTEXP29aXJUsnP6yE5Jnd4bcitmOAq2/HXBgNph Jkfx7kWsvfvIM+CnyUSzST/EOiwSo+pKvIEkco7OWadpiEEI0p/86DbTUCNeg4LldiX/ 3WHTZVBx1Am6tfA3iVpyuO+QctECz3cv+SfwnMl4/li4YliPvWX43ZkXcLEkiAX+rdd4 u9FK2AfCwN6I0q51QMJbPEbplwmDiUN/d+mxOs0heCuXC7B1Gh6awcFHv6N2WiKhVAUP 6kBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745228640; x=1745833440; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l3iCEA8tjYiThU7Rin4dKsTFv6XsSOzMIb0/FuGpw2E=; b=TQ65cwYaT2Z/12ChpTOx+TbL9zrUGy1wFCy/WA70O+Wc2YV/UKna7CgjrGHfeHVPMm LxqpOxP65e0BqA9WCmqP8k32IZHCNu6Hrw11iFxjX966Uw2GDWOtGBvpyZh1xqXNUyh8 CIhWjByoP7gE+5YSd8XvXSPLiWJpW15p6hJStL4N0Ydk+WDkk02cwTGGBsk4CQLqu0Sj fvaEooYQhkMWM73tcXKVUnZO9PS4/J8xVOWlILYqOrVG6XHxWe07eU8rxgTF0QZDQdeA w+plXXbm1SugYDYMlFS5MurRZw0MP/Ve9KXrU/V8v+i7IEQyRKtvvzmLre83CuJkcxwg I/gQ== X-Forwarded-Encrypted: i=1; AJvYcCUnwHhcg1P7b0rOrcnmZBpm5velqEma7k9qfMWkeswLDnkHxVsonCU7C91+FodeGVKIAzUIYeA062LXbnY=@vger.kernel.org X-Gm-Message-State: AOJu0YzAlcCiZOn9fyiTQfMeW2U41NISgqBo9AfJa5obljJQHguW4LZy sZtTXBGlKCSUnkzzONJZ3XxnVFhL/Zm2ACym7TpQZC+2JUDEz12W69wqLmxM5QQ= X-Gm-Gg: ASbGnctdFtFSaWcDsxxQMcEpLg3OxfVaw6+eJSp4JXPdqpqZN2KoYW4h7dW+zrfd8Kf huacySGfbQNvG/90owj4aUD6Tx3yGydAjFDstUo1qrZL+iMjs5bw9bYAutda9A8IBVrRtKNYMZu VAhmintspnRzCb08vswW+Rw5Oc4B4KLcY2dQ8inUxzEPi4ni8996jVFZkpnG8VUGsSMog/aBt8k BF20t6I//iNAojVxBF7bcvA8ewycTyFpzQC2fUapS1jxXEYv64TkFrhxVX3KHLbGzLypIsg+DGH bd+4eMpaOn5l+YZ6osd8RW6N2or3Xj2MD1d3B+1YtwyaN1v+Jl6Q85o6Woi9UOHJ2ZlokPPVp3d pvvComz8VtNtW X-Google-Smtp-Source: AGHT+IGhAPqW9k+zFC8QWowxPP2G8A2KzR14N1unikrdNvLboUqrU7XV7viGFBw04x6asP4GUxLZ8g== X-Received: by 2002:a05:6a20:158c:b0:1ee:c8e7:203c with SMTP id adf61e73a8af0-203cbc74cdbmr17237282637.24.1745228640076; Mon, 21 Apr 2025 02:44:00 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73dbfaacf32sm6371965b3a.142.2025.04.21.02.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 02:43:59 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Conor Dooley , Vincent Chen Subject: [PATCH v11 1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties Date: Mon, 21 Apr 2025 17:55:17 +0800 Message-Id: <20250421095521.1500427-2-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250421095521.1500427-1-nylon.chen@sifive.com> References: <20250421095521.1500427-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This removes the active-low properties of the PWM-controlled LEDs in the HiFive Unmatched device tree. The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematic= s-v3.pdf[1]. Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f= 8698_hifive-unleashed-a00-schematics-1.pdf [0] Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f= 4192_hifive-unmatched-schematics-v3.pdf [1] Acked-by: Conor Dooley Reviewed-by: Conor Dooley Signed-off-by: Vincent Chen Signed-off-by: Nylon Chen --- arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 12 ++++-------- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++-------- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/ris= cv/boot/dts/sifive/hifive-unleashed-a00.dts index 900a50526d77..06731b8c7bc3 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts @@ -49,32 +49,28 @@ led-controller { compatible =3D "pwm-leds"; =20 led-d1 { - pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 0 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d1"; }; =20 led-d2 { - pwms =3D <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 1 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d2"; }; =20 led-d3 { - pwms =3D <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 2 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d3"; }; =20 led-d4 { - pwms =3D <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 3 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d4"; diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/ris= cv/boot/dts/sifive/hifive-unmatched-a00.dts index 72b87b08ab44..03ce2cee4e97 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -51,8 +51,7 @@ led-controller-1 { compatible =3D "pwm-leds"; =20 led-d12 { - pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 0 7812500 0>; color =3D ; max-brightness =3D <255>; label =3D "d12"; @@ -68,20 +67,17 @@ multi-led { label =3D "d2"; =20 led-red { - pwms =3D <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 2 7812500 0>; color =3D ; }; =20 led-green { - pwms =3D <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 1 7812500 0>; color =3D ; }; =20 led-blue { - pwms =3D <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms =3D <&pwm0 3 7812500 0>; color =3D ; }; }; --=20 2.34.1 From nobody Sun Feb 8 17:04:46 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 018CF25A2BF for ; Mon, 21 Apr 2025 09:44:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228646; cv=none; b=XJyfTPz4D7zqxC+lpU0adYeWOiSmkoPcjfTCwPVStoyI0zJls6P3oGUNjSWdIF5Px1qHcLPqZ2YO3Kj+AUftuOsGeRuu8F7YLfNfAKwG2YIc3fnoHIUrZY0BgOYutr37cc2IBWt5n/Q2bs3BK09eXJESRSMDKTuK48D3epUE17s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228646; c=relaxed/simple; bh=AhRbnxt00FmE/WhEN1u8zVz8q5gXEKLj1JYmMYck0AA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CAmQvY8PyPP0VCyeRJQ6TJZLKopppoGNlb/sfAXwNJ/WSees8TLW/334ug7FBfWQDMyDfyupBCb92iikN2d6caKW2UeVoabcRW13+9fg3tsPAdKGdqMz+OPbWLb7r8K+OL2K4g90BK3N0REMHi0SRQLrOG2AB1zAuA2qsVb5ZHs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=YGA4WY6K; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="YGA4WY6K" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2295d78b45cso61229635ad.0 for ; Mon, 21 Apr 2025 02:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745228644; x=1745833444; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dTYlTOXj1U7VnsAmcUnx1eYdk5rL5ZGZ7LNT8Q6B11E=; b=YGA4WY6KQSctBDXQ42DOC/hbszCtaDYiSjYik0hKWJoyHP/aLVQxyrG+eHxsvTq6tm /3fU76TKg+R6WR5i8PVo0Tx+nxx+MCQwEdEESqzDo472JqyVkhdhp5fjFajZuGtG5XRo rsVABhKZpUSCRgOxHy/Fb6AHG99AOw2yyh1YAu42Xn5HgB+0/YndFty4EVvEoIC+JHcF 0N3uWT/RkhS4IGGCbrswvpcF0dSPzzzHa69o3VnXahBDroOoDL2Li25LxveAJpUsQ3iO 0oojZJfzeolI0k16DITY5pRcQ1PvPFlMTx4XtU0AD/sonxAlDv6V7wPPs2/UdP7D2DXV w6OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745228644; x=1745833444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dTYlTOXj1U7VnsAmcUnx1eYdk5rL5ZGZ7LNT8Q6B11E=; b=GAYl+GYULTUUmMuQcwVc7+PXc4wyVv0+UdrvnLaKfma8I4lQWBgtpIxDKPGnSE45u0 enN7AjJdhmg53rsGL7WdTU2DghJXoYnd2W9Abt3M89zG6bMt3XgdmOgJeHGNqSOcgFMM Pdy1THR0lvCcYrPGAbkFni5GFWJo7dKmBq059YEDyFQuF2elvdZZpczjIHkap5ebUP7q +hKnhs3GSJMa3hOssRMKakazijE99vRpVs6RuWq1/u8zsSdBtiyIXQxMn813m+lAMOq+ fGPePkJN1e+65JYzrR/zZVzmMzrl46lTn6iiljhr/5RCMswkQh8Ymkw/BHATwEiutavv GGmg== X-Forwarded-Encrypted: i=1; AJvYcCUN5743AJAISbmknfjKLwezzS6ZZg19HIFt8pmEwh0NmZfSBLqsKUDSq+9irRE1NmHQdXOemOhbsKx8hE4=@vger.kernel.org X-Gm-Message-State: AOJu0YylUTBtkS+PVE2BmNeNCwLVAivyIDqJEQSfFzm6qJTySyWsShYp +cAMXsnCO64rpmj83J255yZjTPBhvrH0pff+36TT1v9rBzfm5GQx3TcVthx9jCE= X-Gm-Gg: ASbGnctPgc6cZhwE/rjNsLt1rQYjGBaoc+0E4OLp/Mvi9HZN0D1eiqYTMjMky5Q1iiQ DwPMp+h6smk3RqaiD3VarXly5DK01/842PxyiUYo2jREYR4Hs5HhHEvtMrc0tB8GwIN+xDFWufD LOaqQdydraWrSCphiTsdsfZeAUPZ/sLdr/qHpB0xqJMTZ27kOh5iQ8FH4Ac6ucJc/QdcrnlCZTf phYr0AUM1dSgZuNAd8RnyEHw/IavOPUwrYRCvPxBq++rmZFKBg7ZPDCVBFIpITbYfOsOUo2400r 8c1Kbe5omokiaimCDjTFTf5LdPQ9afBvNhashulDqmjhMkU5f8sqsn0ZI4Jzd9aW8o/SMmA0ohe ctQ== X-Google-Smtp-Source: AGHT+IHEYpGr2ZvIBvvKW7ZFaNUJwrpR7XQJq5VPcYBgX/Wl0N6AKjMZmEmIW83x6cviTTPcE+wOYA== X-Received: by 2002:a17:902:f541:b0:21f:c67:a68a with SMTP id d9443c01a7336-22c535acbeemr153720645ad.31.1745228644193; Mon, 21 Apr 2025 02:44:04 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73dbfaacf32sm6371965b3a.142.2025.04.21.02.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 02:44:03 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Zong Li , Vincent Chen Subject: [PATCH v11 2/5] pwm: sifive: change the PWM algorithm Date: Mon, 21 Apr 2025 17:55:18 +0800 Message-Id: <20250421095521.1500427-3-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250421095521.1500427-1-nylon.chen@sifive.com> References: <20250421095521.1500427-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The `frac` variable represents the pulse inactive time, and the result of this algorithm is the pulse active time. Therefore, we must reverse the = result. The reference is SiFive FU740-C000 Manual[0] Link: https://sifive.cdn.prismic.io/sifive/1a82e600-1f93-4f41-b2d8-86ed8b16= acba_fu740-c000-manual-v1p6.pdf [0] Co-developed-by: Zong Li Signed-off-by: Zong Li Co-developed-by: Vincent Chen Signed-off-by: Vincent Chen Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index d5b647e6be78..bb9146267bc5 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -110,9 +110,10 @@ static int pwm_sifive_get_state(struct pwm_chip *chip,= struct pwm_device *pwm, struct pwm_state *state) { struct pwm_sifive_ddata *ddata =3D pwm_sifive_chip_to_ddata(chip); - u32 duty, val; + u32 duty, val, inactive; =20 - duty =3D readl(ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + inactive =3D readl(ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + duty =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - inactive; =20 state->enabled =3D duty > 0; =20 @@ -123,7 +124,7 @@ static int pwm_sifive_get_state(struct pwm_chip *chip, = struct pwm_device *pwm, state->period =3D ddata->real_period; state->duty_cycle =3D (u64)duty * ddata->real_period >> PWM_SIFIVE_CMPWIDTH; - state->polarity =3D PWM_POLARITY_INVERSED; + state->polarity =3D PWM_POLARITY_NORMAL; =20 return 0; } @@ -137,9 +138,9 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, unsigned long long num; bool enabled; int ret =3D 0; - u32 frac; + u32 frac, inactive; =20 - if (state->polarity !=3D PWM_POLARITY_INVERSED) + if (state->polarity !=3D PWM_POLARITY_NORMAL) return -EINVAL; =20 cur_state =3D pwm->state; @@ -157,8 +158,9 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, */ num =3D (u64)duty_cycle * (1U << PWM_SIFIVE_CMPWIDTH); frac =3D DIV64_U64_ROUND_CLOSEST(num, state->period); - /* The hardware cannot generate a 100% duty cycle */ + /* The hardware cannot generate a 0% duty cycle */ frac =3D min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); + inactive =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; =20 mutex_lock(&ddata->lock); if (state->period !=3D ddata->approx_period) { @@ -190,7 +192,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, } } =20 - writel(frac, ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + writel(inactive, ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); =20 if (!state->enabled) clk_disable(ddata->clk); --=20 2.34.1 From nobody Sun Feb 8 17:04:46 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A299C25A322 for ; Mon, 21 Apr 2025 09:44:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228650; cv=none; b=qq1hnwx8cO0iYpkHyJZHY46XYyzhLNFWZoCb0zCV+RAsbhFfVewBiRvCoJragygdKX5IbnLSZ6yfZJO0oNfy+A4FGfthItILFjZ/AYQt/RKyoDyNNmzWbIaKAuUvITUq/uvBM9ISTEkAoGFK7p62GzdOq52I3F15giNJqGHQUCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228650; c=relaxed/simple; bh=glrL9frKUynd0eooWslKXIli7Wwl1Of8mWNqeP69AkU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=j+tiiqLDTIijO6UM2to2ymvRGWdJ/qunaJgB8sLi4Eu7qA8HMXwdwRZplz43CcVQ6SjESJYfttTOYiES1c8doblSLIA7uboNzAz5TSPxmthKoBphlBJyehihksUe7oJ9yyJvUP4YPNRWqcwyKZnRDeDGZvG1jslfqb4/zhQO/fQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=BKVBjIQi; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="BKVBjIQi" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-224100e9a5cso43910285ad.2 for ; Mon, 21 Apr 2025 02:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745228648; x=1745833448; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Cqj4QIom4PNiBzVEbYX0WUBXZ7DUraiDzK4MrzGYzY=; b=BKVBjIQiismrP4d2X2knFvFA7hR9TLKSswE4YKaV8x3OUYCKNg/M4cXzFmAatrHKzZ d12z90rCPVpLmA3KWN/j/s4a/MoWuCQWw4wulweJX9TDH0T8PVpRptbvyn3pUED/PXnJ 1uEGkGUbyCv497+45A3L/It70ZpyYAymLvNojtg7h61xwuV3ACJBV04RRLSRyoefSJ/B OiWUHVPQn+Gq+cNeWze3UARklgsxjF5zc2XR6w91kCZZ+hMFcs1gjwnDrqwTHIIhK0Ue Oez15cqJTdjBU/mC21vRolYdVLVb/xsQWO/qpk993vGx+5XXjzj76+g5sjWAAvKPatzm 93UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745228648; x=1745833448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Cqj4QIom4PNiBzVEbYX0WUBXZ7DUraiDzK4MrzGYzY=; b=fFYON9PEp6jRiCA3dhdGu4ooGnja5gt6Hl936vmI/uucA+TDC2Reio3x5Lftd5kkop EmupAiKNp7KqR04ml1oE7yu8FZNkMqELMC6uDiHlng80RRi3Hq+dclsZFzHbtATJ+u3x 8KyT+OCCkhXUVlzbNIGjCvOVG80SpDQ8IqYY2wPNRgw6SBkwftV1u/dsxkgORyPQpUvX YxUwbR1vcxWvThVcgy4wXjohbuL4ugwLs849+TTtJv7AVvIipI8pWrYe2HOne6438r7Z M1K7lDeQi4vDNKqTyScygGL7yIgRu3jBWlWElqH0BqR1hFW7y6C+avvLzSmeoOyeulX0 fviA== X-Forwarded-Encrypted: i=1; AJvYcCV7UUj+HsTFRCciGObisry5MArJt76x93fiq2P9XvplMpwadmwzuVTlI5lPXQ82eFZYm4lXpdQfminxm+Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxHxh7+/kg+uNAl27vWWyNdvOOudgpg+r/6degMdoQhvr458t2/ elhSUfJBDMCtuQbaDzsL7VDfMc021CDN8G5VZXhfKJyyMCcDwgu/E3Rx8lZsMww= X-Gm-Gg: ASbGnctWdKrXz6kI9pCkiXUC+Xaq12+Sx4tOcdTMCTxlEuEOBnUciGhqeitZCxhVA7Y G7I/ExpdxPnXV/0BfjXw87OsiLfZheCCxVGcGbMl3AcdVv3k740tqoWueuN1vOtiYpmwtv4umpi mOy0ubLbCtYgJ12Jxgs8e5BhoRh8zSn6+HM+IxRQZo72HTduLWC47pLdGEDsh42LAiu6ymyCgC3 YO9Y+qgR2aW9XmFfIFrdtrPIIl1K+eq66aRFPeCcr/bgaTTFlqqmtGknZNKFBoPAY7tIovMx+Nc AtRU4uWpBLCSZw9FANL8EBxAUOcZ80dmwqjY4mRgbA7qoN85cfEIcRthPtUpC8Y3h6puwsCW2hY 9kg== X-Google-Smtp-Source: AGHT+IH9vCtDb7HvKpxpcy9CbAe2VrwR7fXTtTGN3OzMwQYcW6ogAY3TNTBrPavfoyTFcga48z7v2A== X-Received: by 2002:a17:902:e88f:b0:220:e9f5:4b7c with SMTP id d9443c01a7336-22c53581248mr166754085ad.17.1745228647812; Mon, 21 Apr 2025 02:44:07 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73dbfaacf32sm6371965b3a.142.2025.04.21.02.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 02:44:07 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Zong Li Subject: [PATCH v11 3/5] pwm: sifive: Fix the error in the idempotent test within the pwm_apply_state_debug function Date: Mon, 21 Apr 2025 17:55:19 +0800 Message-Id: <20250421095521.1500427-4-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250421095521.1500427-1-nylon.chen@sifive.com> References: <20250421095521.1500427-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Round the result to the nearest whole number. This ensures that real_period is always a reasonable integer that is not lower than the actual value. e.g. $ echo 110 > /sys/devices/platform/led-controller-1/leds/d12/brightness $ .apply is not idempotent (ena=3D1 pol=3D0 1739692/4032985) -> (ena=3D1 po= l=3D0 1739630/4032985) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index bb9146267bc5..6259f8500f71 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -101,7 +101,7 @@ static void pwm_sifive_update_clock(struct pwm_sifive_d= data *ddata, =20 /* As scale <=3D 15 the shift operation cannot overflow. */ num =3D (unsigned long long)NSEC_PER_SEC << (PWM_SIFIVE_CMPWIDTH + scale); - ddata->real_period =3D div64_ul(num, rate); + ddata->real_period =3D DIV_ROUND_UP_ULL(num, rate); dev_dbg(ddata->parent, "New real_period =3D %u ns\n", ddata->real_period); } --=20 2.34.1 From nobody Sun Feb 8 17:04:46 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8721125A35E for ; Mon, 21 Apr 2025 09:44:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228654; cv=none; b=KI3+Udp5du6KJ6WJkJBIYtG2qS/ecKDrSlePws7FATgX9IU+9v7WHGSlfgXsvt5pg5jombBQOdJgoRqvuLFwscQlSR5ttijkVaItpV7aahOjCp3/Kvzwjlun40ai5vwhMDSBmOejEnXPrIZm/l8xGioPEMyNlLfmv30edQx/ygY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228654; c=relaxed/simple; bh=HTZHrX+QD3w1gIgaVzbbMlu+aTdm2k5g1RRT3+WvqSI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X9u4Dk2GkauXC5d3c4/5yR6QQLNqLvHaxjYn0Qg/AgBgAxBFDP2ZDZ3ZEbnlsMNPm59MZ2mSOX15fZiUWy/I4MzGcL82aDO28K/SDu89EG7LT4Xf8V1Rj8RH2VzX7uClaHTJwFoqXqzUB8PlW98dtebVh606FqFo7IagmYq3prs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=EJ4zcCi/; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="EJ4zcCi/" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-736c1cf75e4so3418130b3a.2 for ; Mon, 21 Apr 2025 02:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745228651; x=1745833451; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Um8ly0YURJhIZsPOAVFkm7bN0ZzL1kP1o400anZrFdg=; b=EJ4zcCi//X7Ayhw1v3BBrs2xC2RExi9KrekolRcnhJQSQhZySbiZCayZX4EbiVqegC iFPYJvU93JsLVQBc7AcQ+ipB3Tzhf12p9HshL9SPwiZPIP051f4yDmP3tk11Fprjjcfv 9v+/v4koqNoH0BrnbI8ovkJEjuTLwIG8YFOQh2sYiQTVunZ/Po1JNxJQiuX/VkqYw/ZP gYmWhJO3OAzzjM3O1xiGvstc2ZG1dgSyxiPPwWEY5ouomDRBJSEQ3ABQQeEMBTGxwstZ SBYibUf58MKAL2RchK8ZptNV8N9KYsmRYAfXBZoLpP/ZdTfTHh9sFMy4qvtGTlc5sJ9f 8ObQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745228651; x=1745833451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Um8ly0YURJhIZsPOAVFkm7bN0ZzL1kP1o400anZrFdg=; b=CdGhfZEiq/ALIbph0LBOvK4yNbG+2qA8c5x8sWT8VKfEpYPRLx3RCrlzzpKI4Dyj9U AjQvw7vnwzxjnktdPjkjpkYXfodyGWG7y4MKFnHC2e3js+LrNP6bKN8SokTH1farkIht hELn8PYb8VkXA19zY3PQq9SwNAGWUv3p2BmRUHo8NLRITV++GQZmgZ/31CKLQEzsD0AX pNz2F5CHbJUsoJFl1ool3NNBWDGl0739tmFC07cqBFa7JIJHA4ga2V3K90zJzUowCSnc zq+1WR8+h0zl/Pga/qTKVr99hNU6zB9nX+RV7QvmcOrqvgdUQ1YKtagcB5qV16SrSDuq 92uw== X-Forwarded-Encrypted: i=1; AJvYcCXCnQ4Ns7qGBp+MMnftcJv4nflqa0cnA1oqfGCi/+DVtgJ8tJ4Th2q+rjzt2Z32jXgf351H+yT0VB4l3a8=@vger.kernel.org X-Gm-Message-State: AOJu0YzFly3pMgdzdYdRDffMtpIAeyr6Tq+ERfOHwbdEJ0QXQ6UbnZlJ rX+qprhxv49rLlMVBVJ3/rj8pPw1+fbmGUxIhiIJt3pArqEC3Rt/xQ+h5H6q4t4= X-Gm-Gg: ASbGncufemiOLh6QHLv8FnepolADD35BlIYYVfwMMwib8DvQ3HS0D5rL/WAlG4BUF4m dh5cwKcfAW9+2HjjBC5XWmOgmP1Gz8VU4YpoOR9fevmm4jXyf4FNnnhV6mNHE0Zf2+fz+SqkqjN fqHPTPNQZgqkh0OsS0dsDh3t5AzJNY76JNpH7yG6kaDrneRlrvIVaAnLkoDMQgGZJqHWgqL25Mr JIsSkjW++QMKv/2U0IZ2gL+OjVtN28SHFOjsHpnjKMy7Za3oU+Sel6+5vbj86+ifg3HwEFh4bcl wOBaw9+FyHsi/+4d7dFcbpmA/je/TNnxBinwqCossdFXozey+vNuhNvt4GhHOdtt6xdMbVFCmCK ySQ== X-Google-Smtp-Source: AGHT+IGhB4JLMo8xKvJ4+oFdsJWwteHF/WDSaTr6oGU66k5hwiWHHJcvohJuF1VquOrooltC9l1OFg== X-Received: by 2002:a05:6a21:9203:b0:1f5:86c6:5747 with SMTP id adf61e73a8af0-203cbd153c5mr21074579637.32.1745228651586; Mon, 21 Apr 2025 02:44:11 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73dbfaacf32sm6371965b3a.142.2025.04.21.02.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 02:44:11 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Zong Li Subject: [PATCH v11 4/5] pwm: sifive: Fix rounding issues in apply and get_state functions Date: Mon, 21 Apr 2025 17:55:20 +0800 Message-Id: <20250421095521.1500427-5-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250421095521.1500427-1-nylon.chen@sifive.com> References: <20250421095521.1500427-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix PWM apply and get_state rounding to ensure consistency between setting and reading values This fixes the reported errors: pwm-sifive 10021000.pwm: .apply is supposed to round down duty_cycle (requested: 360/504000, applied: 361/504124) pwm-sifive 10021000.pwm: .apply is supposed to round down period (requested: 504000, applied: 504124) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index 6259f8500f71..1404c383461d 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -122,8 +122,8 @@ static int pwm_sifive_get_state(struct pwm_chip *chip, = struct pwm_device *pwm, state->enabled =3D false; =20 state->period =3D ddata->real_period; - state->duty_cycle =3D - (u64)duty * ddata->real_period >> PWM_SIFIVE_CMPWIDTH; + state->duty_cycle =3D DIV_ROUND_UP_ULL((u64)duty * ddata->real_period, + (1U << PWM_SIFIVE_CMPWIDTH)); state->polarity =3D PWM_POLARITY_NORMAL; =20 return 0; @@ -157,7 +157,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, * consecutively */ num =3D (u64)duty_cycle * (1U << PWM_SIFIVE_CMPWIDTH); - frac =3D DIV64_U64_ROUND_CLOSEST(num, state->period); + frac =3D num / state->period; /* The hardware cannot generate a 0% duty cycle */ frac =3D min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); inactive =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; --=20 2.34.1 From nobody Sun Feb 8 17:04:46 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6F0D258CC0 for ; Mon, 21 Apr 2025 09:44:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228701; cv=none; b=J3By5AOVUTlx9YGCTzySmxDlxO+ae7eMxOFHkPcU41aFflEHWIwmABL7RDh+Q6QPg2hhYYHab0Ga2wfVaCPZReXRISEjZzSgBEZ39woa++lLdglT6UicNWvO2oCpjz15vF9gNLzx+pRUuyCl3aK+m+cu0ojpPwfzdXS5RkE0qMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745228701; c=relaxed/simple; bh=r5RfvvulzxFSJLlZqt290Ox/VLbLHPLFtE3S4Q/eFF0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=c8Mc3MGQazVcPkszWqrneGdEHsUWvFk+lDAbFMOsW68ILgH0rpI4t7rgFN6rgQXtu9lpCqRAt1UupgWIwlOl5DwigIGPWXrNlfIHx9u7Xzu6pYyWRO/tgRfY1UGjDiLpC1x3cynW89Xtz5CNsr/YVIX44hCIxD1ICcWJWyKANCc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=l8Fz2Uem; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="l8Fz2Uem" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-736a7e126c7so3051204b3a.3 for ; Mon, 21 Apr 2025 02:44:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745228699; x=1745833499; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9oomD+rheO8hWgzZWTPQh42T2jzzNJl6ps7gCFAZrzo=; b=l8Fz2UemKb7dUbfYNQ+ZTpPaIaUs9C2xO5cB9NibsuXq67vDKcrB6OeKm24UC6UwRA nxQ9m94jOhcrmKXSNxpcor9+WWdTfNMVt5tMl7MHnTOpl0A+qhCLsVbkhz24Rv5tVEOf z/ZieyfbBai8UEVspMuxuyIWfFintRcvRvc/b6AypV2WdGS3hqaaHFQLECPcJsmEoq/q ynjfp9EpEvZ9jOapztEBiPcPe/VbfpbVOMzM4tUnUHAyBCp96vLBRGT+SOYq7caN7ngx TRYfFHZdRPn0XDZx908ioRKucFwUpwGFhONAy2zQme4hdlKbpxqrRZfsftUTUvm8P6X4 3/XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745228699; x=1745833499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9oomD+rheO8hWgzZWTPQh42T2jzzNJl6ps7gCFAZrzo=; b=aFlglEd0GCkbF4nFHpx5nwO+LEvaaGvLc7aPWw5s9KDxQrK34Dr/XYPxYXuZibVUz7 Hbzzfuurk6mz66HgYzZnpa3hzxEAw4GeCUQ7RqIhwR44RQVNG4ffN6+CsOs7OXgynsMc WlvI3DVO1QrXRMXNR21GFLnvXAk3S+423UJPIsjDcqwkK9WpR1IbFjWyZwyBcjopRxpg OvnLkl9sjZpYQeQbEuqPnr7NLWG88eRzI9YfX+4XeagxDlfwohZGOQPizamkHxz0RJws eEWUH6T6EbMHeUdpB2g5Z0xgyIS4CRew8/X5hYkVgMvxLc/J10Uvskg+jq3mV9RBdajq 4VWw== X-Forwarded-Encrypted: i=1; AJvYcCV+4i8S0xktJMAAxj/EIzbeSB2uqKP0sJidMVrEEJuyKS1EWeiAOl28uC35pZC6g3hE67MI/nfFeub45/Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yyup6erkSLvCGinACTXAajJkomF1qARSd3uHNhaJkTyFV77TkXh imDvwe0o4nAWkbz/2DQ0IqgczBNqWAOe6RIvRVdeSsgBMnrThuSYwtQPI1I3ZKo= X-Gm-Gg: ASbGncsqTVZ+Ly/GMk7ZPf1GxM/BgnIhkVZJVzS9A32aa49g0S/jaTvtdeYLGV6TEOD YscbhAJqbGkSC2RzjIQuHCHIVKGm3NS7vFjTb2wg/1wDlPxBiripftmTvIyx4NzSZasBjW4rtuS hacRbX15g7zJRFIj+dGVGF2ZPG809CTldE2PxGVekDNJ0n/ADHw5tBj/157eYVDs79pt/tKL93M zS4+i0fiQX9xI6OI7kFwYh5Kuis07mCyLLbgBBUafo5AArHPqdMqtcdewywcDhqX0XXi3Fa+8zl 2akP/u0cPImZ8ixqWCjsU+5M6jKacREru+n6wZg/uqYXu0Ys6N61p8FQ288By5tRG35re/e1J0L iJw== X-Google-Smtp-Source: AGHT+IG3700mpvecN8OGtblvyO5T1EjDBNVZFMQ7/RSZwGoTrQaT76dyL6hRUY7pUUMOaUwerM2e1g== X-Received: by 2002:a05:6a00:80d:b0:736:6ecd:8e34 with SMTP id d2e1a72fcca58-73dc1582843mr12640767b3a.18.1745228699199; Mon, 21 Apr 2025 02:44:59 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73dbfaacf32sm6371965b3a.142.2025.04.21.02.44.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 02:44:58 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Zong Li Subject: [PATCH v11 5/5] pwm: sifive: clarify inverted compare logic in comments Date: Mon, 21 Apr 2025 17:55:21 +0800 Message-Id: <20250421095521.1500427-6-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250421095521.1500427-1-nylon.chen@sifive.com> References: <20250421095521.1500427-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The FU740=E2=80=91C000 manual says =E2=80=9Cpwms =E2=89=A5 pwmcmpX -> HIGH= =E2=80=9D, but in Figure=C2=A029 pwmcmpXcenter is forced to=C2=A00 via an XOR, so hardware actually outputs HIGH when pwms= < pwmcmpX. Thus pwmcmp holds the off=E2=80=91period count, and the driver must invert = it to expose a normal active=E2=80=91high interface. Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index 1404c383461d..fd1660e16a4c 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -4,11 +4,28 @@ * For SiFive's PWM IP block documentation please refer Chapter 14 of * Reference Manual : https://static.dev.sifive.com/FU540-C000-v1.0.pdf * + * PWM output inversion: According to the SiFive Reference manual + * the output of each comparator is high whenever the value of pwms is + * greater than or equal to the corresponding pwmcmpX[Reference Manual]. + * + * Figure=C2=A029 in the same manual shows that the pwmcmpXcenter bit is + * hard=E2=80=91tied to 0 (XNOR), which effectively inverts the comparison= so that + * the output goes HIGH when `pwms < pwmcmpX`. + * + * In other words, each pwmcmp register actually defines the **inactive** + * (low) period of the pulse, not the active time exactly opposite to what + * the documentation text implies. + * + * To compensate, this driver always **inverts** the duty value when readi= ng + * or writing pwmcmp registers , so that users interact with a conventional + * **active=E2=80=91high** PWM interface. + * + * * Limitations: * - When changing both duty cycle and period, we cannot prevent in * software that the output might produce a period with mixed * settings (new period length and old duty cycle). - * - The hardware cannot generate a 100% duty cycle. + * - The hardware cannot generate a 0% duty cycle. * - The hardware generates only inverted output. */ #include @@ -113,6 +130,8 @@ static int pwm_sifive_get_state(struct pwm_chip *chip, = struct pwm_device *pwm, u32 duty, val, inactive; =20 inactive =3D readl(ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + /* PWM hardware uses 'inactive' counts in pwmcmp, so invert to get actual= duty. + * Here, 'inactive' is the low time and we compute duty as max_count - in= active. */ duty =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - inactive; =20 state->enabled =3D duty > 0; @@ -160,6 +179,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, frac =3D num / state->period; /* The hardware cannot generate a 0% duty cycle */ frac =3D min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); + /* pwmcmp register must be loaded with the inactive - time count (invert = the duty) */ inactive =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; =20 mutex_lock(&ddata->lock); --=20 2.34.1