From nobody Fri Dec 19 16:05:49 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67AB61F0E49; Mon, 21 Apr 2025 20:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745268575; cv=none; b=ibhH9EbNI7EAcfUXPVtLv2TupWyGl8Mfv+ipl+RU0eDzPUyozUvhGYbM5PHjHPCYaKYUQa6uHgLJBS+fl9m2b4T575FJqYuehBYYbncwSmU+ftkBrCSco3eRUbv2CyXzcqoi2S64D0KZ4/uI6It+LlMEfR78RGI+OdLvK4ojAa8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745268575; c=relaxed/simple; bh=XxnyUlhOLmgJSyUzXhTEsswDEQueWFydV1G3E4gpjvk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YTr36j4acl5TMr0UML75Rm6lkrpgUOHtI93+X/l8hx+KyK93i3SlmJ4TkV723baGINuMKrcDZwLtt3NaA71YFCjfRTGs1GUtUfoJQhmuRwEeHpL/OuHjRWqUygFz8FvvAfVK0iFJizqWSu+eQ4D8QBapBTIidKlJgDD6bdKUHnA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=RK4LqL/N; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="RK4LqL/N" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1745268570; bh=XxnyUlhOLmgJSyUzXhTEsswDEQueWFydV1G3E4gpjvk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=RK4LqL/NA3r/DD3HMf9ARqzI2tJN36zWf5IKjYlWz7ZG5pB/H/smnyLrV1N+PduEg BfxWgb+mxsAwgEFL2RWjurcpHjuFREOjOqYqAquOWPNSmueSiCXwRJhxziDwbYaOzF dAJO+BNzU3w2CBX5XgJoRfmuEuJrKYJO/7sHMn5qwaUVznxdoBiJKyDC3QIZjFx5EP MWo9K0ZlOG2NPmWUWSmQDrrboJFT5xzjHrsB5EsAGEg9vjv/If6D1m084ms/X+kgiW 0/EmPOvp4t6n9hBcwOGLgYFVQxUB7qC66EaX0juajfOmpvQjDxqhjRacAZQOv31GBM y6V1Pqfv9I49g== Received: from [192.168.1.63] (unknown [70.107.117.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by bali.collaboradmins.com (Postfix) with ESMTPSA id 96AF217E078A; Mon, 21 Apr 2025 22:49:27 +0200 (CEST) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Mon, 21 Apr 2025 16:49:04 -0400 Subject: [PATCH v2 1/5] dt-bindings: remoteproc: mediatek: Add missing minItems for 8192/8195 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250421-scp-dual-core-mt8390-v2-1-c84117a959a9@collabora.com> References: <20250421-scp-dual-core-mt8390-v2-0-c84117a959a9@collabora.com> In-Reply-To: <20250421-scp-dual-core-mt8390-v2-0-c84117a959a9@collabora.com> To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Tinghan Shen , Olivia Wen Cc: kernel@collabora.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= X-Mailer: b4 0.14.2 Both MT8192 and MT8195 have an L1TCM memory, so it should be described in reg, and therefore reg's minItems should be 3, as is already implicit by reg-names being three entries long. However minItems is currently unset for mt8192/mt8195, resulting in it being equal to 2, from the base schema. Fix reg minItems for MT8192 and MT8195 by setting it to 3. Fixes: 6b55b1e2fd7f ("dt-bindings: remoteproc: mediatek: Support MT8195 dua= l-core SCP") Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Do= cumentation/devicetree/bindings/remoteproc/mtk,scp.yaml index adc6b3f36fde49eb3fa7ed3f08b0fa9e7f331162..ee33c233e44f3d51f0851b35697= a24208c87f68a 100644 --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml @@ -185,6 +185,7 @@ allOf: then: properties: reg: + minItems: 3 maxItems: 3 reg-names: items: --=20 2.49.0 From nobody Fri Dec 19 16:05:49 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1C8F1F130C; Mon, 21 Apr 2025 20:49:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745268577; cv=none; b=cTGGCv4vVcqMWm0JGpblzP8LNmRUE81kmguRp8aH/5unUqmmnURh4X53W0RbBQ36VJUdL84uie5ZlE99g7u7tHpeUt4uj4sOew2tJ12lfqHxe+MugAN44lXNTd5H/uZ6xgBNf1Rf5qizrGr1g9DkY77WNYKQtA4eluh9WOi4CaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745268577; c=relaxed/simple; bh=1wIDWPEibG09Jj0SDTOitc8WPtvsWbMRGzVMJKc/3OQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zy7OE5SFZE0+ylCU/LZPJ+tdiwPh7O9h/k0kZOiRUOqlMa1aFuARk74NHJNRgSeH3C9tg4FG4ME/MqKppYB4VxPca3aCXGPK47/9iafLX6vwCXXiTUli9udlV9pxNemovoAglLLlYY4eq3jGZ/zYRPmSjjHXpSNNjIYqY3MTp6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=M6y2QRed; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="M6y2QRed" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1745268573; bh=1wIDWPEibG09Jj0SDTOitc8WPtvsWbMRGzVMJKc/3OQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=M6y2QRed+ZGlksJm+Purl5Bs7WbVSSBr91Kkv6uVY6KTuX0UhtyQEZdXQ5uh2cjbR 6h1t3d0C3jz18vXmy3mgcVRY9NfIkt3fUzzXqPSNxFx6J9l2mXnInj751O39YzyK3E JAUM3s4sDSMxMvasDo2AajPNUC09CXuQrAFk6Zqgk+A9mYXxBY6ZuyC6nYvJQxYBV2 l05vPUZUS/FYQpy3ysUpPKYlxyRpKA9EpauP116VbjKLXc6ABKZOGh6KcuPdZ9cL3w 8XILwUuABJXYrS/6FtRbbsEKwkdZtS2rOUBUlyObGophE4ewyR9dTyCSdEGmGXNp1b npJz8Sc/9F4Gw== Received: from [192.168.1.63] (unknown [70.107.117.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by bali.collaboradmins.com (Postfix) with ESMTPSA id B5A1D17E09B5; Mon, 21 Apr 2025 22:49:30 +0200 (CEST) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Mon, 21 Apr 2025 16:49:05 -0400 Subject: [PATCH v2 2/5] dt-bindings: remoteproc: mediatek: Remove l1tcm for dual-core MT8188 SCP Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250421-scp-dual-core-mt8390-v2-2-c84117a959a9@collabora.com> References: <20250421-scp-dual-core-mt8390-v2-0-c84117a959a9@collabora.com> In-Reply-To: <20250421-scp-dual-core-mt8390-v2-0-c84117a959a9@collabora.com> To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Tinghan Shen , Olivia Wen Cc: kernel@collabora.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= X-Mailer: b4 0.14.2 The SCP present on MT8188 does not have an L1TCM memory region, but the binding incorrectly requires one for the dual-core description of the MT8188 SCP. Remove that requirement. Also update the minimum number of reg and reg-names to 1, since as this is a multi-core SCP with no L1TCM memory, only the CFG memory region is present in the parent node. Fixes: 91e0d560b9fd ("dt-bindings: remoteproc: mediatek: Support MT8188 dua= l-core SCP") Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Krzysztof Kozlowski Signed-off-by: N=C3=ADcolas F. R. A. Prado --- .../devicetree/bindings/remoteproc/mtk,scp.yaml | 19 +++++++++++++++= +--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Do= cumentation/devicetree/bindings/remoteproc/mtk,scp.yaml index ee33c233e44f3d51f0851b35697a24208c87f68a..04348cfcb0424dc78ff1ddd7766= 5285a052925e9 100644 --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml @@ -28,11 +28,11 @@ properties: description: Should contain the address ranges for memory regions SRAM, CFG, and, on some platforms, L1TCM. - minItems: 2 + minItems: 1 maxItems: 3 =20 reg-names: - minItems: 2 + minItems: 1 maxItems: 3 =20 clocks: @@ -171,6 +171,7 @@ allOf: then: properties: reg: + minItems: 2 maxItems: 2 reg-names: items: @@ -196,16 +197,28 @@ allOf: properties: compatible: enum: - - mediatek,mt8188-scp-dual - mediatek,mt8195-scp-dual then: properties: reg: + minItems: 2 maxItems: 2 reg-names: items: - const: cfg - const: l1tcm + - if: + properties: + compatible: + enum: + - mediatek,mt8188-scp-dual + then: + properties: + reg: + maxItems: 1 + reg-names: + items: + - const: cfg =20 additionalProperties: false =20 --=20 2.49.0 From nobody Fri Dec 19 16:05:49 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C14B41F180E; Mon, 21 Apr 2025 20:49:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745268580; cv=none; b=mOuakmRjlcFoh6muAYUkMSh7omX0NTvX8QHGJIEgRAo6YyIN1kwqOekYKxFZXfa+qdAZaP4NVoKXkYmFn1r5BM3tPftEF6tu8oZdDAyJLktOYP+lGBkvqW+zHZ4HEr4hP3oFZ8cvZN/STZPu0CwZleU7qI0HdUarH5huM+okUeo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745268580; c=relaxed/simple; bh=tApRshAmb0IYmM2jaD30rYtdVz+5r1FcnHKRAmrj+d8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RT1EtOflJkKkRQ70oC0LobT++93WVa/o2ghTfBbd11vIV0ApRxFC+OODBkdGNBj8qp+8sl7LfhG7h39aEelR2xDXkSS/By7JwTT11uYO0lE6jcv8P68yQBI0i0SuPhvPcIm+5dhiHjXLlzE85AQG93LF/uQnuBoMQK/K1UGORvc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=VZNVnHPN; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="VZNVnHPN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1745268577; bh=tApRshAmb0IYmM2jaD30rYtdVz+5r1FcnHKRAmrj+d8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=VZNVnHPNYmte6L9Udo7AsosNFHhX+JQKq5HCOfOgEsiIOTovxNRQ+ALMssLwxEisN zRN40sVQQ75iZ5oF2jo+6WU3TcaO2XsYquca7goIXauDU7HiEat+Gd0tZ1MVzXXyHU xQ8QvZSrb5MXTXGRzs1Jlt/6KeAV0wXSYfiZPBm4zWODqDlei78d5rBPrCqHv+gU0Z i/u7zm1lrWogaf6036ZTuEyUIsRNP+IKQO9mCgSxqKWH2MC83mGpAaTeU4YzqH8GAy naF7vBNuDnqIQ1hm4ZdmlHly9QgwQbGgyuq9qyuiKqspk4ZIgJSan0G1Y4KgjhskLL FNeg4ZFMinH2g== Received: from [192.168.1.63] (unknown [70.107.117.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by bali.collaboradmins.com (Postfix) with ESMTPSA id 379B117E0F93; Mon, 21 Apr 2025 22:49:34 +0200 (CEST) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Mon, 21 Apr 2025 16:49:06 -0400 Subject: [PATCH v2 3/5] dt-bindings: remoteproc: mediatek: Drop redundant maxItems for mt8192/95 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250421-scp-dual-core-mt8390-v2-3-c84117a959a9@collabora.com> References: <20250421-scp-dual-core-mt8390-v2-0-c84117a959a9@collabora.com> In-Reply-To: <20250421-scp-dual-core-mt8390-v2-0-c84117a959a9@collabora.com> To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Tinghan Shen , Olivia Wen Cc: kernel@collabora.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= X-Mailer: b4 0.14.2 reg's maxItems is already defined as 3 in the base schema. Remove the redundant assignment in the if branch for mt8192/mt8195. Suggested-by: Krzysztof Kozlowski Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: Rob Herring (Arm) --- Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Do= cumentation/devicetree/bindings/remoteproc/mtk,scp.yaml index 04348cfcb0424dc78ff1ddd77665285a052925e9..82c7edd5a2fbb8610315881a403= 3a3a43198162e 100644 --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml @@ -187,7 +187,6 @@ allOf: properties: reg: minItems: 3 - maxItems: 3 reg-names: items: - const: sram --=20 2.49.0 From nobody Fri Dec 19 16:05:49 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE8361F2C52; Mon, 21 Apr 2025 20:49:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745268584; cv=none; b=rUlIiOEY2MNfudVxCNL2LU+OC+cMZhpEQFMXCaeY25fhYwHbNmCpZKjXK2Q+f2gTGvBz/9JmC1WsPZimyduzjFoKWNV5M1UcmRLL9n1yuniRfXpcOByNdO6FNPP1y576T4bD6u9PLJZEbeRucHcO7RMoZm8f6IOCQSlaXSTF8MY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745268584; c=relaxed/simple; bh=XoQUQxGE6uHWaZmNzk5WR9FZhr6qAFxBSajgJSMZoE4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Pdhqros5ZsekOvyQOsiPhLEHwZ7GsWKhAUZMr9CgkxFyy1iw1xuEOxFURPbjy+qiO66d7yLg6vzYZpegKg0tmER2dnDPByfHvxQQQmlxjhTI/LuV/p/1oOdNHLLlPqbJHVThSYC74Z4aTrKCR8H+wVY3j/cQEqqe/g9DT09O8lI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=HxWjf78P; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="HxWjf78P" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1745268580; bh=XoQUQxGE6uHWaZmNzk5WR9FZhr6qAFxBSajgJSMZoE4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=HxWjf78PjjiVmEOvm13fUyTVtPKTsZaNqnrMCSp9S1hYSnxoaN4qq5+7xjT5JDC/V agMMvkJDhM6BpphxK8pLX2VpuPPfM9SkEPuSGHxloYWdaQnIZk4HIdQcpZ5hNU/1wF +xERTtxcIMJ2aQod06Iqpb49xIoSXjvZaeZYlLzzUxK3P94fwgAUz6vezfya/yFzuS cBp+LnUBFamDla6DYjdUxaak/xJ1VKbWXmQVqQh1qagDdbDi1NlxZ2xHJS+NUbvovC NWbuzRM35Q5/e/2WQPSslw0b7JEy47BG+1n9X03/mjR7pski3OgfYfOo0tUvFbfdPn oQN41H8glZc0w== Received: from [192.168.1.63] (unknown [70.107.117.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by bali.collaboradmins.com (Postfix) with ESMTPSA id 4F9B817E00FC; Mon, 21 Apr 2025 22:49:37 +0200 (CEST) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Mon, 21 Apr 2025 16:49:07 -0400 Subject: [PATCH v2 4/5] arm64: dts: mediatek: mt8188: Describe SCP as a cluster with two cores Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250421-scp-dual-core-mt8390-v2-4-c84117a959a9@collabora.com> References: <20250421-scp-dual-core-mt8390-v2-0-c84117a959a9@collabora.com> In-Reply-To: <20250421-scp-dual-core-mt8390-v2-0-c84117a959a9@collabora.com> To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Tinghan Shen , Olivia Wen Cc: kernel@collabora.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= , Jason Chen X-Mailer: b4 0.14.2 The SCP is currently described in the Devicetree as a single-core processor, but really it is a cluster with two cores. Describe the full cluster but enable only core0 on the current mt8188 platforms since that's the only one usable with the upstream firmware. Co-developed-by: Tinghan Shen Signed-off-by: Tinghan Shen Co-developed-by: Jason Chen Signed-off-by: Jason Chen Signed-off-by: N=C3=ADcolas F. R. A. Prado --- arch/arm64/boot/dts/mediatek/mt8188-evb.dts | 6 +++- arch/arm64/boot/dts/mediatek/mt8188.dtsi | 36 ++++++++++++++++--= ---- .../boot/dts/mediatek/mt8390-genio-common.dtsi | 6 +++- 3 files changed, 37 insertions(+), 11 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8188-evb.dts b/arch/arm64/boot/= dts/mediatek/mt8188-evb.dts index f89835ac36f36f86e2054ae0c332172be97b049a..f4c207d65b877e1eefaa2654044= 6c3c06369ca21 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188-evb.dts +++ b/arch/arm64/boot/dts/mediatek/mt8188-evb.dts @@ -331,7 +331,11 @@ &pmic { interrupts-extended =3D <&pio 222 IRQ_TYPE_LEVEL_HIGH>; }; =20 -&scp { +&scp_cluster { + status =3D "okay"; +}; + +&scp_c0 { memory-region =3D <&scp_mem_reserved>; status =3D "okay"; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts= /mediatek/mt8188.dtsi index 0cfedb837b005d06b31008c687590e4c47727fc7..296090fbaf4953db8075f720735= 09b731dc41e51 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi @@ -1382,12 +1382,30 @@ gce1: mailbox@10330000 { clocks =3D <&infracfg_ao CLK_INFRA_AO_GCE2>; }; =20 - scp: scp@10500000 { - compatible =3D "mediatek,mt8188-scp"; - reg =3D <0 0x10500000 0 0x100000>, - <0 0x10720000 0 0xe0000>; - reg-names =3D "sram", "cfg"; - interrupts =3D ; + scp_cluster: scp@10720000 { + compatible =3D "mediatek,mt8188-scp-dual"; + reg =3D <0 0x10720000 0 0xe0000>; + reg-names =3D "cfg"; + #address-cells =3D <1>; + #size-cells =3D <1>; + ranges =3D <0 0 0x10500000 0x100000>; + status =3D "disabled"; + + scp_c0: scp@0 { + compatible =3D "mediatek,scp-core"; + reg =3D <0x0 0xd0000>; + reg-names =3D "sram"; + interrupts =3D ; + status =3D "disabled"; + }; + + scp_c1: scp@d0000 { + compatible =3D "mediatek,scp-core"; + reg =3D <0xd0000 0x2f000>; + reg-names =3D "sram"; + interrupts =3D ; + status =3D "disabled"; + }; }; =20 afe: audio-controller@10b10000 { @@ -2249,7 +2267,7 @@ dma-controller@14001000 { mediatek,gce-client-reg =3D <&gce1 SUBSYS_1400XXXX 0x1000 0x1000>; mediatek,gce-events =3D , ; - mediatek,scp =3D <&scp>; + mediatek,scp =3D <&scp_c0>; }; =20 display@14002000 { @@ -2704,7 +2722,7 @@ video_decoder: video-decoder@18000000 { iommus =3D <&vpp_iommu M4U_PORT_L23_HW_VDEC_UFO_ENC_EXT>; #address-cells =3D <2>; #size-cells =3D <2>; - mediatek,scp =3D <&scp>; + mediatek,scp =3D <&scp_c0>; =20 video-codec@10000 { compatible =3D "mediatek,mtk-vcodec-lat"; @@ -2828,7 +2846,7 @@ video_encoder: video-encoder@1a020000 { <&vdo_iommu M4U_PORT_L19_VENC_SUB_W_LUMA>, <&vdo_iommu M4U_PORT_L19_VENC_SUB_R_LUMA>; power-domains =3D <&spm MT8188_POWER_DOMAIN_VENC>; - mediatek,scp =3D <&scp>; + mediatek,scp =3D <&scp_c0>; }; =20 jpeg_encoder: jpeg-encoder@1a030000 { diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi b/arch/a= rm64/boot/dts/mediatek/mt8390-genio-common.dtsi index e9d57f44475b00f19983a968ae113deb4d86bf12..805a4bccff33e3ac1a16c5fb2cf= 13914c8e97746 100644 --- a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi @@ -1055,7 +1055,11 @@ power-key { }; }; =20 -&scp { +&scp_cluster { + status =3D "okay"; +}; + +&scp_c0 { memory-region =3D <&scp_mem>; status =3D "okay"; }; --=20 2.49.0 From nobody Fri Dec 19 16:05:49 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 268A11F180E; Mon, 21 Apr 2025 20:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745268585; cv=none; b=lbZF/Ah62irN/mv1wO4DhXzO62UslhBI2b6n8BWrMOev3SksJFgNBoa36Kl201++ZOCh3FdJdb0atDJ2kc4mCQgKkQFpB9K+LE0ZI3lJ1iciY4AJFctFyC0LoazV8g7PPYhko28uuXQW7EPPpkNAnEVyYlSpTrqBg33NDeubd9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745268585; c=relaxed/simple; bh=ZXE55CQ6tKXOBWcsEApxFOCcB9MJRav1Ft8naFxiU5w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aN3n+E8HHGUvH7wo+az38zUEVh81SckMXN67mXgC9Vub7UiZ5YFutzSHMRQqTyHjsqSvo6z9fnpZZ416F+wqdhQI2kiFmP5mLvJcixfN0XOVaTQNNNXtGkQDs/kPnMiQY2Ji9melIxrI/ZGW1AiSFBegiNHR1nNOzmjjZXJBRPw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=fjcvlpaS; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="fjcvlpaS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1745268582; bh=ZXE55CQ6tKXOBWcsEApxFOCcB9MJRav1Ft8naFxiU5w=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fjcvlpaSsWhC9Q9A1lQLzwCPUsP0oOrjVUMOS50F+K6HAD46EqWL6yxYA+CDZazyK hp1vUGfyFgmAFKtfoF3zgcXHfREJ+fP5T//ZXfq1T9NJsyGrDheGWw4ylyFcPIfNuj SBsuYkfbo3kewPFzn6Pj51YL78LcfAJH8MxEy7YBEpAg3S3C+9hNDSLRQw0mUSSSnt N6yCieGcmYXkdXDrP0pWWLXKQVjVO7LnNIdxMCO0R+swW/ITf80jjzkSokq/lpB2ew wq6V5xtygHkcxhdXXCqyDSfnJWcGVpIXY9vEUAUxu7WuNXgIDx3N+/DWb1X1ru2rCY X+z895908TfOA== Received: from [192.168.1.63] (unknown [70.107.117.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by bali.collaboradmins.com (Postfix) with ESMTPSA id 4ABC717E078A; Mon, 21 Apr 2025 22:49:40 +0200 (CEST) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Mon, 21 Apr 2025 16:49:08 -0400 Subject: [PATCH v2 5/5] arm64: dts: mediatek: mt8390-genio-common: Add firmware-name for scp0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250421-scp-dual-core-mt8390-v2-5-c84117a959a9@collabora.com> References: <20250421-scp-dual-core-mt8390-v2-0-c84117a959a9@collabora.com> In-Reply-To: <20250421-scp-dual-core-mt8390-v2-0-c84117a959a9@collabora.com> To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Tinghan Shen , Olivia Wen Cc: kernel@collabora.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= X-Mailer: b4 0.14.2 Add the firmware-name property for SCP core0 so the firmware can be loaded from its canonical location in the linux-firmware repository. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: N=C3=ADcolas F. R. A. Prado --- arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi b/arch/a= rm64/boot/dts/mediatek/mt8390-genio-common.dtsi index 805a4bccff33e3ac1a16c5fb2cf13914c8e97746..698054ed5d6d4f7b947db6ab533= 5d3b202bb84d9 100644 --- a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi @@ -1060,6 +1060,7 @@ &scp_cluster { }; =20 &scp_c0 { + firmware-name =3D "mediatek/mt8188/scp.img"; memory-region =3D <&scp_mem>; status =3D "okay"; }; --=20 2.49.0