From nobody Sun Feb 8 18:29:27 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5465020D505; Sun, 20 Apr 2025 18:28:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745173692; cv=none; b=rVgASNfZog+bvBYOfitP8IUonuO8TKNhbJW2gqKAYvtaZBIQG7imNqwEQhgeqmqKBGsaphYNkasHOQxYB39amrJ9g6AXXTKwIWaX4nW3V/ge1/QWhyWMgyr+wrT66Y2ivv3adCpUOrIsYJbs5uJacwxRB7aeIwKkJHneTMoFhak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745173692; c=relaxed/simple; bh=mQihOWv8xBALIX3TAcEWzTiJaGpGPS1iJr+MBXyPdQY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EZrfNRnvFz9L4oImeHweBWi9WoLBetxG+NyZCPWvGcmKn3P+jiF8pbz3CFRnGwGLzsTHmybituv7HWeSsfhQRv2Htx/RVRua6QzLmpsK7hrcOCmrXJ7jyTngoVKosSPQyGmiIG8cod82jBvJU4sE15aMWIcAdm/cZOPVW3kZwkU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ggtKY2Fe; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ggtKY2Fe" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-af590aea813so4111359a12.0; Sun, 20 Apr 2025 11:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745173690; x=1745778490; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KcRYApCGgcFr/cRT0jz04VlStr9b3Rm85w3Cx/6Dhlg=; b=ggtKY2FeuPjU1H6BL5Au4kV4c0owTuHDWTeGvDUc+iP2/fBEvw12eCBEGOsNVwhwi6 /GU36jj0rGTxYDQGZBG1vMkpFIbEww9mNqeA7HIE6lvO+MTATkY5xZa5vCG55KkRAWGj v4M8byEzTW8DOgwGTC3HQ0HrwhyKSCvJVLP0s5o6XPXAk8V5NaLweNVomuW4Hxy3JSwn aMDsPVjrvX5M9TxOqCzjgbIqgnnBSER08lpkqk12frnbpyCd3rsnAv4vVEEAgXsUgAz+ JsDHcpzhFF7cA6Gi81+2sK7SGzu9rMos2OfcNYcd+W+inhmvGy7vty6c40zLmNjIDW6Y 1qoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745173690; x=1745778490; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KcRYApCGgcFr/cRT0jz04VlStr9b3Rm85w3Cx/6Dhlg=; b=LWbXTlhPYnkkaTFT5LAO88clHgX/kT/aBGUpYZ3yKM8e19CT01wbrXhcc2ww9lrPSb 7sTN0stA4ynP6h02uXGXv5yo0ROJDvGVrDffjEMjtaOVx7wgicCJ3vcS4Pa2zKmsYwjF Vdpk1eoTsDs7GAbrgdarAsbDiuSdS7iGzC0W3WsEXsyaj+RrBiVvRVxI4aa2iguoR++L JKlN2tGNd1VFUIWvTOqOw+pH5cAI167bQOYdPrl6YC1vex23HkrppAOZSiNWm/EzvvFr 26C0kPoCzPcW2w6F0SDT2o7G1G8xLR0DCo4HN0vRvjmp/5XVP1w3xMH4v1cL2D0vvqQR XK5A== X-Forwarded-Encrypted: i=1; AJvYcCWErmHCdvzLU9L/nWjjZHvYb4SUhymTkXc8VqlePDDrGD9ZE9He4p4DjNGv8bt2yCsNkxUKB8I=@vger.kernel.org X-Gm-Message-State: AOJu0YzTLDsc/wszcqMA3tuJFAqiARuak4f5YUw01loYDW+OMfOEBpR4 4nZjsVeldjgVCIJub6pVfKl7jcy3zOnpG2WoKcQuaXMVnFULepoDyoQujstMQwI= X-Gm-Gg: ASbGncuNIn0CGz/VZVK7fkuZI1a6wMC4Iod1GniBN0qxyR9BUdxU++jSsCwbMNnBHw3 uKJVqCy6R5/eo/oqhGEVIZyVu0UN4VJCCG/Vgb5J5cgMXffszTltm6C77S7KG8Ibb25MRCorAXP UUeakMN90Vx/5A8PkOC/2RS2LugivuF79A+YDdFl78pts7UjOQr0z2x6LrRBrtY1n/w+5+KUwx8 Nar3jhw9cWvUP0JTqQ2vOlgNZPgJ7Mrgujrl6MWNwI9DZICpWhP9o50PY+c5+kFJt+KayWzqx1e jH5ol6I8bxwQL/t8/zqO7sQoVCL3BeN4plLGSt9cGvJwIMKzGgz1tkNzwwgT X-Google-Smtp-Source: AGHT+IHEfDcqBZ/8UilBBzQgUsdzafTEEbbClYsk/pbpMpKTMLTox4/6oBGYGwVVX0alm/Mr6jcB7g== X-Received: by 2002:a17:902:cf10:b0:215:58be:334e with SMTP id d9443c01a7336-22c53e3b25fmr130214735ad.10.1745173690529; Sun, 20 Apr 2025 11:28:10 -0700 (PDT) Received: from [192.168.0.6] ([2804:14c:490:1191:f66d:1f0e:c11e:5e8b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c50eceb74sm50550055ad.166.2025.04.20.11.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Apr 2025 11:28:10 -0700 (PDT) From: =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= Date: Sun, 20 Apr 2025 15:28:01 -0300 Subject: [PATCH 1/2] regulator: max20086: Fix MAX200086 chip id Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250420-fix-max20086-v1-1-8cc9ee0d5a08@gmail.com> References: <20250420-fix-max20086-v1-0-8cc9ee0d5a08@gmail.com> In-Reply-To: <20250420-fix-max20086-v1-0-8cc9ee0d5a08@gmail.com> To: Laurent Pinchart , Liam Girdwood , Mark Brown , Watson Chow Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , stable@vger.kernel.org X-Mailer: b4 0.14.2 From MAX20086-MAX20089 datasheet, the id for a MAX20086 is 0x30 and not 0x40. With the current code, the driver will fail on probe when the driver tries to identify the chip id from a MAX20086 device over I2C. Cc: stable@vger.kernel.org Fixes: bfff546aae50 ("regulator: Add MAX20086-MAX20089 driver") Signed-off-by: Jo=C3=A3o Paulo Gon=C3=A7alves --- drivers/regulator/max20086-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/max20086-regulator.c b/drivers/regulator/max= 20086-regulator.c index 59eb23d467ec058d3647d1bfb01831738bcd256c..f8081e54815d5045368a4379132= 8b3327cf0b75f 100644 --- a/drivers/regulator/max20086-regulator.c +++ b/drivers/regulator/max20086-regulator.c @@ -28,7 +28,7 @@ #define MAX20086_REG_ADC4 0x09 =20 /* DEVICE IDs */ -#define MAX20086_DEVICE_ID_MAX20086 0x40 +#define MAX20086_DEVICE_ID_MAX20086 0x30 #define MAX20086_DEVICE_ID_MAX20087 0x20 #define MAX20086_DEVICE_ID_MAX20088 0x10 #define MAX20086_DEVICE_ID_MAX20089 0x00 --=20 2.43.0 From nobody Sun Feb 8 18:29:27 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB3BC20E03C; Sun, 20 Apr 2025 18:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745173695; cv=none; b=VTVjaLy8pYgxnnyy32xdlHBxj1YgGGZFIRmj3n4/puRWAGHmDjPchPKXwmedGpxxJXMtHcFkeC0Tdln45MICwxhLf/YC8yR9WQ3e30SzvyqzvDGZmfrwF6lQsYclxXjY27gylaOWse+a7lZ7NCXDYW65zNlxwzLdQ8i3CEgLR9o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745173695; c=relaxed/simple; bh=ug2YuZtVHOS3Xo1DjEh8+JMIxUeK0tUbdFYLjy0kIL8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h200xBwUQxJfvKzvQf1pNuTJi+Dys5FYV5LbuhXGbe1Kbva83ktpkV1pJFTPDeBHiAleoYUQckggGmnAv9bGoaujhOuq0bEIsC3vIU05lQvOnVYkmok0Ua1YyKzPiS9UZkyfGTc/NSUOeVMXmpMqoCfTdYKhZ2+lApuWvrYJ0Ok= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EKND5f/W; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EKND5f/W" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2255003f4c6so37915425ad.0; Sun, 20 Apr 2025 11:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745173693; x=1745778493; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1vw6hOxHYdtqSUI3BN1G6zdypvE2XuTrlurxFwJGouU=; b=EKND5f/W0xCE/fH1xb2vmBMpbNTuntIYFT0pRaouYTH34Cv2efbIuw/L/2TpaQh7rN /DZwYTJk1Ti82Bd1fyBySSxVx6mS/p63uAf7oGbByekcNqfl69GlxZirNVwjvbZ663wl Y5osz6byGUr1Hzi0leeBtO64w02RzRY/nWdp/T34go1MV2HlZtfhoQpsPjPsZMRaoUaZ KjmSkQiy3+UC4eaxqxePXWh3zo7VjHTUhtRMLr6OJPu+21EJKpFpUn0E+p3KJcaLfRQ7 53Vtno97v+2fdJhqN6YX7TrJ9udL2mvHFjTeOgL7fLPGQZ96a1Lcf5pD/X+9LhsQwXJy Km0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745173693; x=1745778493; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1vw6hOxHYdtqSUI3BN1G6zdypvE2XuTrlurxFwJGouU=; b=g714E7DAc0YCkdybagsFqMmVCwhrUdNpAjs/x+/c/OCJb2R5gXuvYmhLExd5ufCeXw shbbHhukREK0Hsg8189rDvGcyltVHhgBweJp5r33ry24b7xKVqoOJp+/0md5s+GaePl6 U3lji70vAZMWdQNHFOZHCgBjsaTM5HB0WXIRL/IjQSEWZMT8jTZ/5ByZeafL5sIq6440 fhk04N0SHCxwdw7bmWFBv/cLn1wFXnAlTiEphBlBlr2OswCuUii4yuCL9D6V8B/bBd2N XQ+7QPUh3rPoJe7Vq7nhnW2rwMc6clNGjiZ95v80Av7WaA8JWIbeqWxQxa84rk90JHYr VQ7g== X-Forwarded-Encrypted: i=1; AJvYcCWqiuQET78w7T8/xOrKFSPfg+Yx/eAoazMQ4SWg9KxvCS10kzquZ9WT+4gVy0nh3C4znst0OA4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj4NQR1ObfSmkoyW+ke/vnmlpAMvvEOekgS09Fb+3umLMcq6Yi aoLX6i0CVHPJfCIdxmKyotB+W/IghhENPHwCqzNXDW+cFpR+WGmx X-Gm-Gg: ASbGnctPkRjyZ/auq7bkT1md+lOcoTtZENMMcBAmhR4abroNEb4Yl2EEz6FA56ayBij sHPRdCTSkxs5EUg7msvPbkaN6VM9AoGVa1x7cJGDm4EEJTi1yfKgaVOG13c6WDujO3xTnF+JSg/ rVdOVZwlsSGlwQHrKXdljr9H+5QZk6ViovRqPLbSkwMkQmKTzrRjRjhHtfyMGpDluse9YBLBtpN a8kq+t1oNYB7WmMZVFBkfXU2bsEGmQY5qBN2G8Jsg5QS+Wl0PoVrBqXNC8KYqUMG1NxQUrp7UYa s/rDwKG1s50+RRQ53dJtokii1VZ74iugf9rdBoo6YoGCP5Fnjyg5iP8Y4lkc X-Google-Smtp-Source: AGHT+IGUg2c3Mz6Yc7mPrOWXwSZoN6ipM008iz3KPw09s6bE/es1fzMAZXM3AIfBjlauEtjKJ1/Vmg== X-Received: by 2002:a17:903:32cd:b0:223:4537:65b1 with SMTP id d9443c01a7336-22c5360c196mr137860105ad.36.1745173693196; Sun, 20 Apr 2025 11:28:13 -0700 (PDT) Received: from [192.168.0.6] ([2804:14c:490:1191:f66d:1f0e:c11e:5e8b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c50eceb74sm50550055ad.166.2025.04.20.11.28.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Apr 2025 11:28:12 -0700 (PDT) From: =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= Date: Sun, 20 Apr 2025 15:28:02 -0300 Subject: [PATCH 2/2] regulator: max20086: Change enable gpio to optional Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250420-fix-max20086-v1-2-8cc9ee0d5a08@gmail.com> References: <20250420-fix-max20086-v1-0-8cc9ee0d5a08@gmail.com> In-Reply-To: <20250420-fix-max20086-v1-0-8cc9ee0d5a08@gmail.com> To: Laurent Pinchart , Liam Girdwood , Mark Brown , Watson Chow Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , stable@vger.kernel.org X-Mailer: b4 0.14.2 The enable pin can be configured as always enabled by the hardware. Make the enable gpio request optional so the driver doesn't fail to probe when `enable-gpios` property is not present in the device tree. Cc: stable@vger.kernel.org Fixes: bfff546aae50 ("regulator: Add MAX20086-MAX20089 driver") Signed-off-by: Jo=C3=A3o Paulo Gon=C3=A7alves --- drivers/regulator/max20086-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/max20086-regulator.c b/drivers/regulator/max= 20086-regulator.c index f8081e54815d5045368a43791328b3327cf0b75f..62e9119f446c7a22be9947fa4aa= fa0c0401d9f12 100644 --- a/drivers/regulator/max20086-regulator.c +++ b/drivers/regulator/max20086-regulator.c @@ -259,7 +259,7 @@ static int max20086_i2c_probe(struct i2c_client *i2c) * shutdown. */ flags =3D boot_on ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW; - chip->ena_gpiod =3D devm_gpiod_get(chip->dev, "enable", flags); + chip->ena_gpiod =3D devm_gpiod_get_optional(chip->dev, "enable", flags); if (IS_ERR(chip->ena_gpiod)) { ret =3D PTR_ERR(chip->ena_gpiod); dev_err(chip->dev, "Failed to get enable GPIO: %d\n", ret); --=20 2.43.0