From nobody Mon Dec 15 21:19:55 2025 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 473B4189906; Sat, 19 Apr 2025 19:03:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745089393; cv=none; b=N8PkQZoeNJIi6DxVytXdek7ZnhsmujghqD+iJBWIhx1p2ai98hx0RB0ACb6NvNh8WJYaw0pvaMpOC7QiJi4dFgZo2fHY2I7T9o1xWz/98S863eQPURMb4suAKisQXsWPlgSRzvxCZ1mWnKOeGlIXDZZTqmV1hx15xJx1BYjMYvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745089393; c=relaxed/simple; bh=katT5kliIICOtirlQwBv+OMm4d5Rm0kDRuwNNkCHKW0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=CB3ETyUL1yJHIyD2VlXmkFsPnzZ2lrdMwRo6VVgJbbgqS7UdIhMoSQt35/fxSofi5uL84C1Z5IyS1liW37295WlAMpJNATPvGcF6450iP4CIyhN0OlaLaSZAkepCWyMdItVCVJW8CLBxjYHt7hVW3MtjwkYHHm6YTRY+cokBJRA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WCzjuVim; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WCzjuVim" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5f4ca707e31so4142854a12.2; Sat, 19 Apr 2025 12:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745089389; x=1745694189; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=7Mf0LPoDiGeCgyBur/YV8BMdSw27MvkR9reXhITuAkk=; b=WCzjuVim9+7+5UEIT8UcUyN+1Mk0iH5gGmIcrgFAeShGcmp55DbE6sl30Wy9jXgCOX 8XWLW0DOKKYXdhY9CozfKjRqhQ4Ln+QR42ABp59JuZe74gAkTSOEzeT8xkKD/E3lpRSg BaTTm48U6xoBLqn4bUSP2wKx1LHltx++7i0EVT0WD3wZROtn59WxmUBAHBLpH+CejTMx vALMWwphAexyxdFGBtVPMKyEMaHPxRDRD6wfJk8WIwkEp4IXMkVj/kKNEps7md/rmztA Pe2NyT/4JxDdV49T9mkysBIG7o2gvJCZT3fNB1OZWe8G7yRGAf6lVm7iPP5Q99V9ForR +dXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745089389; x=1745694189; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7Mf0LPoDiGeCgyBur/YV8BMdSw27MvkR9reXhITuAkk=; b=b7qpbPa5V9mgk6OE9DlP0FZVUzojBP16ttiU2fUrL5t0ZMQ7//6oTSlUhuqXzYSblL 1xWJhoAjx1mzgDntsjFy5EU8jNKsfx2yiv4SYGx66bnNc1vEyN8Z7D3jpSufIElaEu3l DkATYXJ8pqMDuJHbPnsB1pO74olaeELqbrUMWN++sG8lFZs+/ooQb5yUI6lNKPmUa3jS 2pD3Nh8thJVXT9W+/FzJxiSOsEDtYO8T6xOlPeVV9Wb/VN4qYrUVKyOwnFGtDNU5q8Av f5JImwNmPYNseZ2CKyoEQsD27djZHBe+o5Jb/FjoUmMOP7ddpn1RmeaN/eDcWvqPdE/l ozCA== X-Forwarded-Encrypted: i=1; AJvYcCVSxlUY+MLZxkiaCN4SJvjUn9aAIuvDeAFzRu4zdI76p1lU8gXbn9WfF5EVAd5FzH1k2kSzxiwJ3x4=@vger.kernel.org, AJvYcCXWjspsetGCv8F2waboS3uyHFPxLmB8QGWbK9NQE/Vd/+4/n6uEHwKCYHgQBf7HjyVrBTIINjx7YWLORr8W@vger.kernel.org X-Gm-Message-State: AOJu0Yx7NKGxNOqJTgG6NMpJ6QNkYXHINFTCeM6NtILG1pLP6KNTbTSA XajgQvCkFM3YsAxcYEJu2g+tgTX9OEQqEGsyZP7BQFK1xlJGcZvW X-Gm-Gg: ASbGncsfIppm+sryLktAnrdzuPjmA9AduCkk0WQwaiAuq4aFSI3Otr1+oiaXYXB/hCJ FumX4mIc8ob0mPfy4JU5dlla3gWmlXdq+lXB9k0awiOc+qNh2B7SVnv2DXx+egsr9i9CJTKzo4H fdq6O9ZC5wu0W6ZJFTVDa/eHgvY+LXx2vkWCGxy4Uc9ctkhBhER4Ulc+Hli6dVhvXV3IsLXaNIs Q7Ranv/xLuAulmwYVoKqZ5aD9ZXfXeA2FadQEBKFlmtiy0eqRgvfBq8WDIZ1rNerAgzfgNAB9Qk GnffTbYqdwO7RdGbRzfSORBF5nui8ywEHhQGGYk= X-Google-Smtp-Source: AGHT+IEZHSgrEtSGG0Xy5gzRL08GrAJxgK/wVoBJGacUsXUbeg3cnjQIaCs8LtfLeti77li3r6ZF4w== X-Received: by 2002:a05:6402:4409:b0:5f0:a6bd:78d3 with SMTP id 4fb4d7f45d1cf-5f628625467mr4748327a12.34.1745089389089; Sat, 19 Apr 2025 12:03:09 -0700 (PDT) Received: from [127.0.1.1] ([46.53.242.22]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5f62554b300sm2478510a12.6.2025.04.19.12.03.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Apr 2025 12:03:07 -0700 (PDT) From: Dzmitry Sankouski Date: Sat, 19 Apr 2025 22:03:03 +0300 Subject: [PATCH v5] hwmon: (max77705) add initial support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250419-initial-support-for-max77705-sensors-v5-1-4504a9b48ba1@gmail.com> X-B4-Tracking: v=1; b=H4sIAGbzA2gC/43PQW7DIBAF0KtErEs1DGCsrnqPqgsMQ4IUGwccK 1XkuxcnC7dZefln8f6fOyuUIxX2cbizTHMsMQ016LcDcyc7HIlHXzNDQA0CJY9DnKI983Idx5Q nHlLmvb0ZY0DzQkNJuXDrQRiwTpDTrFJjphBvj5qv72fOdLnWtmk7nmKZUv55TJnFen22Iup9r bPggmNHjWpMg20Hn8fexvO7Sz1bC2bcUAlqJ4oV1a1HBOOMxO4VlRuqYO9SWVHSoVHBOQ+gX1H 1BxW4E1Xr+6RcwKa10v97f1mWXx+ZwpHsAQAA To: Jean Delvare , Guenter Roeck , Jonathan Corbet , Chanwoo Choi , Krzysztof Kozlowski Cc: linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Dzmitry Sankouski X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745089387; l=11894; i=dsankouski@gmail.com; s=20240619; h=from:subject:message-id; bh=katT5kliIICOtirlQwBv+OMm4d5Rm0kDRuwNNkCHKW0=; b=KIMm4vLyFQ6cfLr5FoU7wjLOY0T10QwnQ2TeA9scMWFYUfAqJM1LErsZVV4k3hDPVcM7eOsuh FSAZMV8BDHVCKC88oSNjL5A0+4lgVYWx5wQU/Pe+UQrZN40Rx/W6LZk X-Developer-Key: i=dsankouski@gmail.com; a=ed25519; pk=YJcXFcN1EWrzBYuiE2yi5Mn6WLn6L1H71J+f7X8fMag= Add support for max77705 hwmon. Includes charger input, system bus, and vbyp measurements. Signed-off-by: Dzmitry Sankouski --- Maxim MAX77705 is a Companion Power Management and Type-C interface IC. It includes charger and fuel gauge blocks, and is capable of measuring charger input current, system bus volatage and current, and bypass voltage. Add support for mentioned measurements. --- Changes in v5: - fix compile warning - review fixes - Link to v4: https://lore.kernel.org/r/20250412-initial-support-for-max777= 05-sensors-v4-1-2e4cf268a3d0@gmail.com Changes in v4: - Fix review comments. - Link to v3: https://lore.kernel.org/r/20250405-initial-support-for-max777= 05-sensors-v3-1-e5f64fccd005@gmail.com Changes in v3: - Fix review comments. - Fix v2 changed message. - Link to v2: https://lore.kernel.org/r/20250304-initial-support-for-max777= 05-sensors-v2-1-58d2207c732b@gmail.com Changes in v2: - Fix review comments. - Link to v1: https://lore.kernel.org/r/20250225-initial-support-for-max777= 05-sensors-v1-1-2be6467628b0@gmail.com --- Changes in v5: - remove now unneeded max77705_hwmon_readable_table - remove channel num check in max77705_is_visible, since there's only 2 channels - make is_signed bool - remove is_signed: pass is_signed as true/false Changes in v4: - documentation: "=3D=3D=3D" line is as long as the text - simplify the dependency to depends on MFD_MAX77705 - cleanup headers - sign_extend current measurements - add 'is_signed' parameter to max77705_read_and_convert function - replace ARRAY_SIZE(voltage_channel_desc) to 2 - remove last blank line Changes in v3: - change resolution type to u32 - pass regmap from parent - rebase on latest linux-next, containg max77705 driver Changes in v2: - sort headers alphabetically - swap curr channel info, to align indeces with channel_desc struct - reword coverletter - fix checkpatch --strict warnings - remove struct max77705_hwmon, use regmap directly - move register validation logic to is_visible function - move common register reading and converting logic to separate function - remove unnessesary {} in if statement - s/i2c->dev/pdev->dev in dev_err_probe --- Documentation/hwmon/index.rst | 1 + Documentation/hwmon/max77705.rst | 39 ++++++++++++++++++++++++++++++++++ MAINTAINERS | 7 ++++++ drivers/hwmon/Kconfig | 9 ++++++++ drivers/hwmon/Makefile | 1 + drivers/hwmon/max77705-hwmon.c | 229 +++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++ 6 files changed, 286 insertions(+) diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst index f0ddf6222c44..764c1c91ed70 100644 --- a/Documentation/hwmon/index.rst +++ b/Documentation/hwmon/index.rst @@ -161,6 +161,7 @@ Hardware Monitoring Kernel Drivers max6639 max6650 max6697 + max77705 max8688 mc13783-adc mc34vr500 diff --git a/Documentation/hwmon/max77705.rst b/Documentation/hwmon/max7770= 5.rst new file mode 100644 index 000000000000..4a7680a340e1 --- /dev/null +++ b/Documentation/hwmon/max77705.rst @@ -0,0 +1,39 @@ +.. SPDX-License-Identifier: GPL-2.0 + +Kernel driver max77705 +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +Supported chips: + + * Maxim Integrated MAX77705 + + Prefix: 'max77705' + + Addresses scanned: none + + Datasheet: Not available + +Authors: + - Dzmitry Sankouski + +Description +----------- + +The MAX77705 PMIC provides current and voltage measurements besides fuelga= uge: +- chip input current +- system bus current and voltage +- VBYP voltage + +Sysfs Attributes +---------------- + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D +in1_label "vbyp" +in1_input Measured chip vbyp voltage +in2_label "vsys" +in2_input Measured chip system bus voltage +curr1_label "iin" +curr1_input Measured chip input current. +curr2_label "isys" +curr2_input Measured chip system bus current. +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D diff --git a/MAINTAINERS b/MAINTAINERS index 78467ad7a8fe..2e1e5233a011 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18369,6 +18369,13 @@ S: Maintained F: Documentation/hwmon/pc87427.rst F: drivers/hwmon/pc87427.c =20 +MAX77705 HARDWARE MONITORING DRIVER +M: Dzmitry Sankouski +L: linux-hwmon@vger.kernel.org +S: Maintained +F: Documentation/hwmon/max77705.rst +F: drivers/hwmon/max77705-hwmon.c + PCA9532 LED DRIVER M: Riku Voipio S: Maintained diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index f91f713b0105..7109f252dab4 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -1308,6 +1308,15 @@ config SENSORS_MAX31790 This driver can also be built as a module. If so, the module will be called max31790. =20 +config SENSORS_MAX77705 + tristate "MAX77705 current and voltage sensor" + depends on MFD_MAX77705 + help + If you say yes here you get support for MAX77705 sensors connected with= I2C. + + This driver can also be built as a module. If so, the module + will be called max77705-hwmon. + config SENSORS_MC34VR500 tristate "NXP MC34VR500 hardware monitoring driver" depends on I2C diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile index 766c652ef22b..22ceebf10299 100644 --- a/drivers/hwmon/Makefile +++ b/drivers/hwmon/Makefile @@ -161,6 +161,7 @@ obj-$(CONFIG_SENSORS_MAX6650) +=3D max6650.o obj-$(CONFIG_SENSORS_MAX6697) +=3D max6697.o obj-$(CONFIG_SENSORS_MAX31790) +=3D max31790.o obj-$(CONFIG_MAX31827) +=3D max31827.o +obj-$(CONFIG_SENSORS_MAX77705) +=3D max77705-hwmon.o obj-$(CONFIG_SENSORS_MC13783_ADC)+=3D mc13783-adc.o obj-$(CONFIG_SENSORS_MC34VR500) +=3D mc34vr500.o obj-$(CONFIG_SENSORS_MCP3021) +=3D mcp3021.o diff --git a/drivers/hwmon/max77705-hwmon.c b/drivers/hwmon/max77705-hwmon.c new file mode 100644 index 000000000000..17fc0764b01b --- /dev/null +++ b/drivers/hwmon/max77705-hwmon.c @@ -0,0 +1,229 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * MAX77705 voltage and current hwmon driver. + * + * Copyright (C) 2025 Dzmitry Sankouski + */ + +#include +#include +#include +#include +#include +#include +#include + +struct channel_desc { + u8 reg; + u8 avg_reg; + const char *const label; + // register resolution. nano Volts for voltage, nano Amperes for current + u32 resolution; +}; + +static const struct channel_desc current_channel_desc[] =3D { + { + .reg =3D IIN_REG, + .label =3D "IIN_REG", + .resolution =3D 125000 + }, + { + .reg =3D ISYS_REG, + .avg_reg =3D AVGISYS_REG, + .label =3D "ISYS_REG", + .resolution =3D 312500 + } +}; + +static const struct channel_desc voltage_channel_desc[] =3D { + { + .reg =3D VBYP_REG, + .label =3D "VBYP_REG", + .resolution =3D 427246 + }, + { + .reg =3D VSYS_REG, + .label =3D "VSYS_REG", + .resolution =3D 156250 + } +}; + +static const struct regmap_range max77705_hwmon_readable_ranges[] =3D { + regmap_reg_range(AVGISYS_REG, AVGISYS_REG + 1), + regmap_reg_range(IIN_REG, IIN_REG + 1), + regmap_reg_range(ISYS_REG, ISYS_REG + 1), + regmap_reg_range(VBYP_REG, VBYP_REG + 1), + regmap_reg_range(VSYS_REG, VSYS_REG + 1), +}; + +static int max77705_read_and_convert(struct regmap *regmap, u8 reg, u32 re= s, + bool is_signed, long *val) +{ + int ret; + u32 regval; + + ret =3D regmap_read(regmap, reg, ®val); + if (ret < 0) + return ret; + + if (is_signed) + *val =3D mult_frac((long)sign_extend32(regval, 15), res, 1000000); + else + *val =3D mult_frac((long)regval, res, 1000000); + + return 0; +} + +static umode_t max77705_is_visible(const void *data, + enum hwmon_sensor_types type, + u32 attr, int channel) +{ + switch (type) { + case hwmon_in: + switch (attr) { + case hwmon_in_input: + case hwmon_in_label: + return 0444; + default: + break; + } + break; + case hwmon_curr: + switch (attr) { + case hwmon_curr_input: + case hwmon_in_label: + return 0444; + case hwmon_curr_average: + if (current_channel_desc[channel].avg_reg) + return 0444; + break; + default: + break; + } + break; + default: + break; + } + return 0; +} + +static int max77705_read_string(struct device *dev, enum hwmon_sensor_type= s type, u32 attr, + int channel, const char **buf) +{ + switch (type) { + case hwmon_curr: + switch (attr) { + case hwmon_in_label: + *buf =3D current_channel_desc[channel].label; + return 0; + default: + return -EOPNOTSUPP; + } + + case hwmon_in: + switch (attr) { + case hwmon_in_label: + *buf =3D voltage_channel_desc[channel].label; + return 0; + default: + return -EOPNOTSUPP; + } + default: + return -EOPNOTSUPP; + } +} + +static int max77705_read(struct device *dev, enum hwmon_sensor_types type, + u32 attr, int channel, long *val) +{ + struct regmap *regmap =3D dev_get_drvdata(dev); + u8 reg; + u32 res; + + switch (type) { + case hwmon_curr: + switch (attr) { + case hwmon_curr_input: + reg =3D current_channel_desc[channel].reg; + res =3D current_channel_desc[channel].resolution; + + return max77705_read_and_convert(regmap, reg, res, true, val); + case hwmon_curr_average: + reg =3D current_channel_desc[channel].avg_reg; + res =3D current_channel_desc[channel].resolution; + + return max77705_read_and_convert(regmap, reg, res, true, val); + default: + return -EOPNOTSUPP; + } + + case hwmon_in: + switch (attr) { + case hwmon_in_input: + reg =3D voltage_channel_desc[channel].reg; + res =3D voltage_channel_desc[channel].resolution; + + return max77705_read_and_convert(regmap, reg, res, false, val); + default: + return -EOPNOTSUPP; + } + default: + return -EOPNOTSUPP; + } + + return 0; +} + +static const struct hwmon_ops max77705_hwmon_ops =3D { + .is_visible =3D max77705_is_visible, + .read =3D max77705_read, + .read_string =3D max77705_read_string, +}; + +static const struct hwmon_channel_info *max77705_info[] =3D { + HWMON_CHANNEL_INFO(in, + HWMON_I_INPUT | HWMON_I_LABEL, + HWMON_I_INPUT | HWMON_I_LABEL + ), + HWMON_CHANNEL_INFO(curr, + HWMON_C_INPUT | HWMON_C_LABEL, + HWMON_C_INPUT | HWMON_C_AVERAGE | HWMON_C_LABEL + ), + NULL +}; + +static const struct hwmon_chip_info max77705_chip_info =3D { + .ops =3D &max77705_hwmon_ops, + .info =3D max77705_info, +}; + +static int max77705_hwmon_probe(struct platform_device *pdev) +{ + struct device *hwmon_dev; + struct regmap *regmap; + + regmap =3D dev_get_regmap(pdev->dev.parent, NULL); + if (!regmap) + return -ENODEV; + + hwmon_dev =3D devm_hwmon_device_register_with_info(&pdev->dev, "max77705"= , regmap, + &max77705_chip_info, NULL); + if (IS_ERR(hwmon_dev)) + return dev_err_probe(&pdev->dev, PTR_ERR(hwmon_dev), + "Unable to register hwmon device\n"); + + return 0; +}; + +static struct platform_driver max77705_hwmon_driver =3D { + .driver =3D { + .name =3D "max77705-hwmon", + }, + .probe =3D max77705_hwmon_probe, +}; + +module_platform_driver(max77705_hwmon_driver); + +MODULE_AUTHOR("Dzmitry Sankouski "); +MODULE_DESCRIPTION("MAX77705 monitor driver"); +MODULE_LICENSE("GPL"); --- base-commit: a4cda136f021ad44b8b52286aafd613030a6db5f change-id: 20250123-initial-support-for-max77705-sensors-ad0170ac1ec5 Best regards, --=20 Dzmitry Sankouski