From nobody Sun Dec 14 12:08:21 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13C8D218E99 for ; Fri, 18 Apr 2025 17:34:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997698; cv=none; b=QfpM6Btf+MaHumvbLU50NPXpNEmmziFwPCcG143YTP79ZCmp4FrupaSOxPK1Z2tKXYqUKZMFHxEbt7d8vX81j/L/xafA3QR4/gKSC9kHhNs+9HaBOnb2/PXc2N6PMqI8kbFpFHqA22jBTemWyh2t5+VGxrToSQlI8ACAovgdJFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997698; c=relaxed/simple; bh=ne10/qVG/Z9dVxxIfZAEEkiO2+1PiOiZ0CHlV/sFviQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OFEf9ZRoGB3G7j/DqfQ5g19WKGFxHxUE6rksWjeeZWHKdvkl4d7J1s8zpeo2af9j6amNiD69mWlkeGt0I53BTBuLY+6VwmPpCPCjny1vlCJBtVdfNP3aVuvNk8DXJxl9pkSXMZhDi9ftEW2re7KO5028T6gprRUcgw1k2DYcHXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fEYVFm8L; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fEYVFm8L" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-39c266c1389so1427814f8f.1 for ; Fri, 18 Apr 2025 10:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744997695; x=1745602495; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jH4AbpkU43gIjXkLIyvvHStxjo8ZlrUkUdGQZryYFo4=; b=fEYVFm8LWsjaCtfA0AID5wPUQOZJBZxCSdVGxUkivcnuB93DWdeAwQFGgF1K4KOFgq YMWch39fNFLT+6v0OtKyHSbHQcLNlU1JGOzCtqCOBObFvkhh9llDa4bEjohRIXichlNF FbO4q/QEyzslQIVNlcOgq9DCOIRm5haZafpWlRL33prPQC3jFao9wfNnkrEqKE9K9m1k nryZkqPj/WgZRhjeuIXBmgB97l3Cbdl8pMPl2cYC65vZgL3ABXrrej3bJeocukUdf0r2 fieSSTZ5NthHtmh46yO/gv4IEdpgbJ3vNe8IWIHwqq7LKqj92+AgHUAoc+CVvRErJea6 4FGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744997695; x=1745602495; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jH4AbpkU43gIjXkLIyvvHStxjo8ZlrUkUdGQZryYFo4=; b=ZL1kIK3fhsvY0o0ByLlCJ1tie6Ou4gWpEx+psXpTDmDcEO2jG5LDbMiVjxZATbj+Ar 0b6VoMxRH9+pGKSnE//SgN2klos9TXBqXp5PmjnLu5fNDpqa7HkLelMcIUpBYBmRM6Z2 XLQ3I1Ub37oBUuqWfuo1JDDX8bcof48nFCoq+GL1eVp+uLVXC0ZTm7rAdOdhX6rjGgzF nMpauJGgiLn6X7AxQcAl+qYftnHSQAunf7Dup4LVggn/gPJ5U9Q+N8SU7gzHYaFiu3IP m+2un0zquKwAmAs/vr/2s8Gt2ctUdUHF08EpCAegEfszjM7pIYrThVC9q8pZwXCf7Hly WuEw== X-Forwarded-Encrypted: i=1; AJvYcCWZISi4emE8RJ6PbW3Mh1+VNOg7+/dE5/yvBMC2ctnHNuow3pXHrY0nQyo84ZR3jPgAe1UacRmZN1F2Kgw=@vger.kernel.org X-Gm-Message-State: AOJu0YxTpC88ogClhS/HDVucZod3dEjS2qM06RYUgVRvE8C3ZZki8seH SCNgBQH6GrdazLC9sm1k5WDXEATz7HD+8LjBNjLOKag6PjP7m/WZ X-Gm-Gg: ASbGncuqcgURljk4Ma0DLkUAqV89V9qxBeGXuscesTLozq/JLh8ofvbWU4EnCgVVcpJ 2UvbdGmccUzffYW2BZOlsEzKHalu6PBdrl+MwKdZ/Z11mVnqxasA9OuHMsloaVy70tpUGrVzVPZ AvdHrUsHKaOi1lfzv3dkWE87hRQKPyYA3eQheAYoX7IeZyaUYbaHBJAvdeSEg66JQ47Ze+gZZUi pSJK3aG2rC9hEvSCoc57MmB2P6VEB2kYEqFdHfc+4ORSynJnmfq3h2IsPSd59cVCcf0ziAKsUU4 i5EXegePmT+QO5kClKk2Ri2SRovV2LIchdDTN/6thEKkz1DDUv5LpKnerwQnBchbHLZRS3dUZOA s X-Google-Smtp-Source: AGHT+IFWsUvUtyMLZ3LB2ut72tqx28ZgElhVa3rTsibeeD19gUL6aJHQ82dILW9NhfhpOYx7hKvcPw== X-Received: by 2002:a5d:648c:0:b0:39e:cbca:7156 with SMTP id ffacd0b85a97d-39efba2ab70mr3007336f8f.1.1744997695212; Fri, 18 Apr 2025 10:34:55 -0700 (PDT) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4332f8sm3287320f8f.40.2025.04.18.10.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 10:34:54 -0700 (PDT) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: marcello.carla@gmx.com, Dave Penkler Subject: [PATCH 1/8] staging: gpib: Fix request_system_control in gpio Date: Fri, 18 Apr 2025 19:34:27 +0200 Message-ID: <20250418173434.2892-2-dpenkler@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418173434.2892-1-dpenkler@gmail.com> References: <20250418173434.2892-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The implementation of the bb_request_system_control function confused setting controller-in-charge with becoming system-controller. Remove setting controller-in-charge and add initialization of the control lines for the system-controller role. Fixes: 4cd654f84769 ("staging: gpib: Add gpio bitbang GPIB driver") Tested-by: Dave Penkler Signed-off-by: Dave Penkler --- drivers/staging/gpib/gpio/gpib_bitbang.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index 9670522fe36e..29aab72c1f0f 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -889,9 +889,13 @@ static int bb_request_system_control(struct gpib_board= *board, int request_contr if (!request_control) return -EINVAL; =20 - set_bit(CIC_NUM, &board->status); - // drive DAV & EOI false, enable NRFD & NDAC irqs - SET_DIR_WRITE(board->private_data); + gpiod_direction_output(REN, 1); /* user space must enable REN if needed */ + gpiod_direction_output(IFC, 1); /* user space must toggle IFC if needed */ + if (sn7516x) + gpiod_direction_output(DC, 0); /* enable ATN as output on SN75161/2 */ + + gpiod_direction_input(SRQ); + return 0; } =20 --=20 2.49.0 From nobody Sun Dec 14 12:08:21 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A0CD21A92F for ; Fri, 18 Apr 2025 17:34:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997700; cv=none; b=RGvTlisDEQg/KPuIFZPh7pMtUtorw4tMpuCEuHThpwQex+Wi04t4yenpe4SSWRAfb2881V1ydRsRNAJFJ6NI/sY0hT4Nnafqc/2L6PPUO3lgs+5FUXzUDvFr4UjhtixgM2UF3BQ0rsllodI3xOM37SWMoTpb7+bNRfGU4QEbNso= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997700; c=relaxed/simple; bh=912DhBbNZi7td2eyvaGCgvKiyTa/PfJmPgJRBuo1gJ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SE0hCLlzLo8ngp4pyW949wm2b4fCnkTUmqHob7n9fsNpedEHZt2NFua2sSgxHFXVsL9RTTmoMhabGPMgUSlIkqF7L4941Xw7n7M9vBlXO6J9pJznrDkh+Grh0ysB80/OxfbynlSx1dcMm0Ie5FxzYz28F1tFZ5HQmHpOHDgmaV4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Uqra2S+F; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uqra2S+F" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39ee5ac4321so1835766f8f.1 for ; Fri, 18 Apr 2025 10:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744997696; x=1745602496; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E+FOcgEbgZOR6HUZYr+EJt4u9kEg2pRhCKDSCtJHjy4=; b=Uqra2S+FaS0YdWHJjYsXsAAOvJF3ww0z1IbUetOcv6ItTU5EU1KLmuGLYth0EuRapM qoj/PFwaBlBj8QImoH+Hwo9xz72Kj/m6bmCi1nsGRAgdRh0HvN9VtMYcRqHjiHVEBshw iw7tNSpA1b1KA1MKWtbCGz9+NsBAnGhqcgZSfu1XuED4u6Tg2t5nv5+AsG9x2RQHlMMB hAvEsNsnRcWUI5cRN73e93C2BVzy3tGWrCKWG7mjQ8CMitc4R1Or1A6gRASBIGLu+B1O PImXVA6yeCDClsTaXaIOZ5DT2z83d/nhrT4EGI9w+gf76tkDgGdOyu7rWk75u4dKzWYh 8tWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744997696; x=1745602496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E+FOcgEbgZOR6HUZYr+EJt4u9kEg2pRhCKDSCtJHjy4=; b=XgVjCmWhmlVL6JicI2BEBjPEHoZZo+qcuhY0MHpVxaq0M4GhKESPvgnhd2Rd1N8k+T NB3dgiadeTcKuDxSXSpvjCdqhQC8yyl8svX+f5wp8LCl8vaWxOwKf1smZV/7jPWA8JXm RX9yvBxYguw9rXsdXql2nupwAGAwXYJw2E8ffzdbD21f9/h++1kvPe0gpG2miO7YY881 J6PEDXAeX9B+iZjfWkXmmJTD8j6JfXjea2Vtiqk0MD0EopSUfLQhwDSb32RO2w+Sc1J/ gs/GcRA61123dwj+VOF0TR6ThkCYkwsV4czhPCEW6vRazCZntAYwgJ+5zi8ApLweE2w6 pvrQ== X-Forwarded-Encrypted: i=1; AJvYcCXjGqLQQFv9YaA2aTjCfqqarLmv3qQ1HwbAZoiV0EW0QBx9XmO6Sc1IOt40Pk7ZeQr35Xe0JKTo+GrzWlo=@vger.kernel.org X-Gm-Message-State: AOJu0YyhC7m0guikrAtpmr3DOSIBoJ5fvwPlsjMJVZxJtk66NjTB4aTQ hqbhh/NiGuk7fiONGm8TYH2rZINrzY+AOdNyK8Wy5wBHVxNliJpw X-Gm-Gg: ASbGncsV9Zq4XomAFZpQAbRQzVlBnviGGHkQZCIfI8OR9IvopAcvoaZ2AMWeCuqFPVp t2xk/K5p3CZf5sbK7wyrfi8r18WZZ56ym+LdQ8d0/0ozT+7XezhTjg4h9P0+LRa+vSPF7T7mEBH fWgBarf7jYBrE9YIXfMgtC2uObvQ8EibsuI2Sexwb88qEAukY+Tb21GSLzhRrmqgnbSHCMU/bki gmcKlNr66THYnar8ENSFqYcOjyuARW0FcEVrOPIiO96zzj9nPcPKjXNtZhRU5TXpV3iuVYdV944 B+RyTLHg877joOhZEbDG7M24/HUdb+OX4o06M8AHpUltHiGsBiSJLPXjfx+YQ49nzQsIDl14ZmJ p X-Google-Smtp-Source: AGHT+IGb8/57K9ai+Ha6SyUvyBZ3Kwj0AjmdglALiUn63qt13/kokBa+B6jbxML43drs8/ss8E7FNA== X-Received: by 2002:a5d:5987:0:b0:39e:e438:8e4b with SMTP id ffacd0b85a97d-39efbaf6e96mr2691275f8f.50.1744997696571; Fri, 18 Apr 2025 10:34:56 -0700 (PDT) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4332f8sm3287320f8f.40.2025.04.18.10.34.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 10:34:56 -0700 (PDT) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: marcello.carla@gmx.com, Dave Penkler Subject: [PATCH 2/8] staging: gpib: Fix setting controller-in-charge Date: Fri, 18 Apr 2025 19:34:28 +0200 Message-ID: <20250418173434.2892-3-dpenkler@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418173434.2892-1-dpenkler@gmail.com> References: <20250418173434.2892-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The gpio board can only act as system controller. By the IEEE488.1 standard a system controller becomes controller-in-charge when it asserts the interface-clear control line. Remove the setting of controller-in-charge from bb_take_control and move it to bb_interface_clear. Fixes: 4cd654f84769 ("staging: gpib: Add gpio bitbang GPIB driver") Tested-by: Dave Penkler Signed-off-by: Dave Penkler --- drivers/staging/gpib/gpio/gpib_bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index 29aab72c1f0f..a92c4eda99a0 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -872,7 +872,6 @@ static int bb_take_control(struct gpib_board *board, in= t synchronous) { dbg_printk(2, "%d\n", synchronous); set_atn(board, 1); - set_bit(CIC_NUM, &board->status); return 0; } =20 @@ -908,6 +907,7 @@ static void bb_interface_clear(struct gpib_board *board= , int assert) gpiod_direction_output(IFC, 0); priv->talker_state =3D talker_idle; priv->listener_state =3D listener_idle; + set_bit(CIC_NUM, &board->status); } else { gpiod_direction_output(IFC, 1); } --=20 2.49.0 From nobody Sun Dec 14 12:08:21 2025 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E165A21B9CD for ; Fri, 18 Apr 2025 17:34:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997701; cv=none; b=Pmy27maYU22wmET96LsZUVZLwTP8tSD+ozy5tA+JOuRgkF0ShHE64NCi49Y3SvBi21Wgj8LtbgDH9aUSnCPhOOchvnLNx72UiBQP4VP0u+EUoDQ/DyxwXRG2XSuay6lKHoue7mgePJl3Ietx0oYSGNinCAnirpB26r48rvMuxm8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997701; c=relaxed/simple; bh=Y6+jh/N20q5vgDZ+rUTiFEYPLOfUfkLSliU92OGQsrk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GjAVKPYnyFOlVtxnPzdqDVhFiJAjkAgN2F5PE1MFdeG1piunxMn7BFp/yh52nTSkbA8+eNT8hpCmG7BnTV3Tb36HJgFzRpTW9MITuuzhGFdAEAu/cCObyFSdbA5/wYPMb/L4KFYfA4ULQRr/vGh4OJXSDVC25jhKxQiTxuH2Otk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Spra1xXU; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Spra1xXU" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-39c31e4c3e5so1421651f8f.0 for ; Fri, 18 Apr 2025 10:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744997698; x=1745602498; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IzATcEFy4yD0nb8pE+dCXra4c1CFrIcpPdFq8ieoLC4=; b=Spra1xXUGFGUnfxipZ8cUFMB8kyNNTXOFrQAQuuq8RA12zy6DPpibjLAibw7DWhIip CzF2yWbY+0xqAALDfBE7dwvM4YPhaz/xpPxa/eXSELGuYq41PrUdOoJ66SOYyz3yM1px uyeuKexZsSsQcENpMZ2EOpW+kA7OOvPJIe1yz9MhmweyNT8fr+wtTHEKkwU1ka6s0bn1 hGlD46dptzOuo+hjrEO67HwtdUK3/ZcSTMuWozt9C+07M/+sP7FVfasFXQ/bvs5fWFtt JCTIiJZGNMTJ3Q3do0CIMUZINk6WL/OE8XiI/YGpbnP7UaLadU8hnxqEWMKIA/SFW4Wm iuDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744997698; x=1745602498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IzATcEFy4yD0nb8pE+dCXra4c1CFrIcpPdFq8ieoLC4=; b=JIQCZIi0uixKyMmHbz2M8m5YWr+64fzIUIlPqTAbF5hTFfgpfgQSZMfFdXVTGRvbSQ TbVqlqEEtP24a9rXD/f/70g/IdIiLAi1mEtNa47vCPcuez+n3T1vjDucHA/Er6XDLHIH MS58qbeocC89+xK1B+K5hOm/oOsXBdgx12nUyRVXK9oR8Sxgb7y+PK2BYH6v3JxS3tEV wP9xfjKIP4vA+I6ybNAG2rtT/7VfNdH/yu28ch5FkIrb6ke6nzkjhGJk/VN7dL2bhcnU r85xfI0wmbpQXkNa7DTjr2cFX8vpQMSze3q8mPo3zKtDdWmLu8CPEIM5YuCGT5kdQ+do txUA== X-Forwarded-Encrypted: i=1; AJvYcCUjO6QAyUCUmpZWd7LMhpotj6FD8sTbOAjkQVAumRJF7RA04wlnm/MpI+kiVb8hQqM2VI9lPxSTIqwV1hg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxedzhyx4GRDElBl9tS3Tw96BauL/hqrJs4lxPJoUsrkKu3ykMc WBMeXukppF+WPCPkTHVlp84zMFAWDA90RmxyxdUHkvg39G6YFEDw X-Gm-Gg: ASbGncv7knjlpaOA13jzhzwGMuZjSG88Le5HPbdL8K4uu4LV1Dd2nSsrHvSDWIR7JjP QBhqSV+8u8sP42u2TdB+etdChY6PFwaoQndAYol3As2lLhLzCXk8A17zCYQv0vJ10hXWxuA3KzT TrRLJqV1564gxgQHsLTzQJh1ioQ72SXn0aiXwn+IgPAJQPo6N/SAqLIFzFoP78j8QHaJcN5R8PY VwUE0nl1B/bwWteqVNdiFlSOP8RWFgn1Rs8UbguhTnuswzPu3Ofn/iOyotU4sgs1dmCNTFf9rpS jsjG4283avuzkqnH3DxOORRJDOyd/Xd6g5JMcAV1pyFn4llquw0Xs9CFBHc/d2XF4t5Z7OGmMIX 4 X-Google-Smtp-Source: AGHT+IEZf1ha1txArdhgWM8acBtGgyt+WHvJBGwchmFEH5kJ9VtYLcai8G/K+Zp0NjdzZjrfpODs4g== X-Received: by 2002:a5d:6d87:0:b0:390:fb37:1ca with SMTP id ffacd0b85a97d-39efbb095eamr3057655f8f.53.1744997697904; Fri, 18 Apr 2025 10:34:57 -0700 (PDT) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4332f8sm3287320f8f.40.2025.04.18.10.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 10:34:57 -0700 (PDT) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: marcello.carla@gmx.com, Dave Penkler Subject: [PATCH 3/8] staging: gpib: Enable SRQ irq on request_system_control Date: Fri, 18 Apr 2025 19:34:29 +0200 Message-ID: <20250418173434.2892-4-dpenkler@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418173434.2892-1-dpenkler@gmail.com> References: <20250418173434.2892-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The SRQ irq was being enabled on attach but the board is not set up to handle it until it becomes system controller. Move the enabling of the SRQ irq to bb_request_system_control. Fixes: 4cd654f84769 ("staging: gpib: Add gpio bitbang GPIB driver") Tested-by: Dave Penkler Signed-off-by: Dave Penkler --- drivers/staging/gpib/gpio/gpib_bitbang.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index a92c4eda99a0..ac9ecb6e0aad 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -884,6 +884,8 @@ static int bb_go_to_standby(struct gpib_board *board) =20 static int bb_request_system_control(struct gpib_board *board, int request= _control) { + struct bb_priv *priv =3D board->private_data; + dbg_printk(2, "%d\n", request_control); if (!request_control) return -EINVAL; @@ -895,6 +897,8 @@ static int bb_request_system_control(struct gpib_board = *board, int request_contr =20 gpiod_direction_input(SRQ); =20 + ENABLE_IRQ(priv->irq_SRQ, IRQ_TYPE_EDGE_FALLING); + return 0; } =20 @@ -1299,8 +1303,6 @@ static int bb_attach(struct gpib_board *board, const = struct gpib_board_config *c IRQF_TRIGGER_NONE)) goto bb_attach_fail_r; =20 - ENABLE_IRQ(priv->irq_SRQ, IRQ_TYPE_EDGE_FALLING); - dbg_printk(0, "attached board %d\n", board->minor); goto bb_attach_out; =20 --=20 2.49.0 From nobody Sun Dec 14 12:08:21 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5234421C9E4 for ; Fri, 18 Apr 2025 17:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997703; cv=none; b=AJKqww7HETbcmlP3P0SRUQMFqPXFGorwbzZwN9VS4blR+9ywD5bIHv5KKisgE6fLMgfWNr89kPHoYSOR9Iq6iwFJuBNJIGqOnmH63yHFoFtm2UNdtYDcNmtJ8bSdzJBzpMrlWYbg85l/6PK6CpYlHD90APFibP0Hn8+auli50jk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997703; c=relaxed/simple; bh=+WmW+6HPnaBorUvAq2/XnG6ifzmTnOmW9gIoOcNOA1M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UKePbcRfmyiB1P6OI4IZQah3g5l3wN+SJ+o5iwSxKz6wxvASUIjDLwhnOg8NSXfBXCumuRk6TbPVYEbVhtkg4PsqCNRhO4Q4fQ/e1S9FEexbFO2fMOkUiXVRbA7mYI5h4oXb5kkKhfHuaPavvEq9ji9IrUX0oY3ROUSJ0znd1m4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XepX7aXy; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XepX7aXy" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43cf628cb14so23761705e9.1 for ; Fri, 18 Apr 2025 10:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744997700; x=1745602500; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5ZEqkL8XJqU+TI/zwsYZcQCUdyQHjs1e4Dkw85FOadI=; b=XepX7aXy+v4mfv8AW4kTHq5+cg50JFwEDKg9FvGoFjRTiGb3bNBuQZKdLRZEZVmxH2 IPM2FxIjyTlCuOMwPNYY+Tmg+oXEZfLENmBYag9Wd8iJExKvO2WqBlIrCVWCw0+3Tn5d IrykyefhVxsAsk5RY62vqpwarF2+VTD8aqhZiG9L9x+98OEmhBB2E85Rk6VXTR8bt2vh ozCU2LdBfSZsoUccW7fPignLWwe4xM8MKKBx9h6LT2EapzMyjhgVJjVHV+aIIxF+imZN 7thGQ4coQBTieJCNqUC2jh1855vl/7k20tzYANkdwOnqz1/oehkk8jjkh73L8499FgQX Udjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744997700; x=1745602500; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5ZEqkL8XJqU+TI/zwsYZcQCUdyQHjs1e4Dkw85FOadI=; b=LRinjkvmpSJwlXtEUVgNr/jSw0BgKwSyFNSfwK54fyXlxE2bmc2bF4THgP86kuLlYg q4ExNhLXAutoVhjw6uQMe/QMPu+isjw3rSG4r7tKxhdITFTOFd1J7sd0GwEbWcFJxwYq tpSh0Z0AgzDQk+8GWLrFJ2ipQ3mrbM9PoJ82FXW0UNP/J/fGaqFU0Im/oGmE9k8vDJNo EXJ9PR3BYIExQwtlW4/dz/skdBNNP+PcUqiNPjXNmZtaKjQ3AmJnAXASFjW/aOXDMDds HFLtNT1DX2gkPQi9rePXRqNo6bUHWpEIssmpJgaNHOCVDemSXMeURnyr6go6IgeYxqPK y4QA== X-Forwarded-Encrypted: i=1; AJvYcCV6eJbQUAY1PSGwc28IaWtNz2eZhpxJBxv1ZAH5ZPwkBcXlAO+l1EnZqq4MJntI91kB8+gfu+FIIKAld/Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwARtLqkzm9b7SDe+v6vJzVedfzxcfUo9ZSw6v6xzvGugh+eini vSZV2/o/o6AkItseL0Mx+lgPFypPu1RUjZ6kEQUsHMIK249Zq78RTSj9ZQCe X-Gm-Gg: ASbGnculkDWl17Y8p5uQCOLWt1a+Ex79yqT2/54G//EujWNtU77Ix5s4qIN6O9WdxTK 3mxpZ2KSe/wjAWx7YmMLac4Os5fsx1uFujXRF0pw4+WJ6XRfhpGlFt1uyNExn1keHn+BSD+f4cD LjT/7bAlNWM0pDqSLCs2mGmOr3q4L9ePR7kPh92ll0XIb6khR0wW0dsIB89JuQfpVLh/wkY/lMo kYJDLAjgBXeNp6Cr7X+loqBgsHZl4JCx3NUKUarSL0epAVo6dEwkXiRQNjVstVipt3aMbmL0x2j cTUHNJN+ram1P67vXzxkRvrBumgPLSMQOFWKoAhBG0sDozYkUE8i7cSnCrTAJn18BqBW4aBvg9C a X-Google-Smtp-Source: AGHT+IFSe4AzT6s51bwigohequdK5BUemML8iVqbH7ehZkk5hrV4pgmN0v+Fey9j138PiYxkJ/eRCA== X-Received: by 2002:a05:6000:1449:b0:390:f116:d220 with SMTP id ffacd0b85a97d-39efbd6a39dmr2452869f8f.17.1744997699538; Fri, 18 Apr 2025 10:34:59 -0700 (PDT) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4332f8sm3287320f8f.40.2025.04.18.10.34.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 10:34:58 -0700 (PDT) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: marcello.carla@gmx.com, Dave Penkler Subject: [PATCH 4/8] staging: gpib: Remove dependency on LED subsystem Date: Fri, 18 Apr 2025 19:34:30 +0200 Message-ID: <20250418173434.2892-5-dpenkler@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418173434.2892-1-dpenkler@gmail.com> References: <20250418173434.2892-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The yoga pin map is compatible with the others so that its led can be used as the activity led. Using the LED subsytem required adding a dtoverlay to the boot config as well as setting up the activity led via sysfs. To simplify the setup we remove the dependency on the LED subsystem and use the on board led as for the other pin maps. Tested-by: Dave Penkler Signed-off-by: Dave Penkler --- drivers/staging/gpib/gpio/gpib_bitbang.c | 23 ++++++----------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index ac9ecb6e0aad..caa8361da696 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -66,7 +66,6 @@ #include #include #include -#include =20 static int sn7516x_used =3D 1, sn7516x; module_param(sn7516x_used, int, 0660); @@ -136,19 +135,14 @@ enum lines_t { #define SN7516X_PINS 4 #define NUM_PINS (GPIB_PINS + SN7516X_PINS) =20 -DEFINE_LED_TRIGGER(ledtrig_gpib); -#define ACT_LED_ON do { \ +#define ACT_LED_ON do { \ if (ACT_LED) \ - gpiod_direction_output(ACT_LED, 1); \ - else \ - led_trigger_event(ledtrig_gpib, LED_FULL); } \ - while (0) -#define ACT_LED_OFF do { \ + gpiod_direction_output(ACT_LED, 1); \ + } while (0) +#define ACT_LED_OFF do { \ if (ACT_LED) \ - gpiod_direction_output(ACT_LED, 0); \ - else \ - led_trigger_event(ledtrig_gpib, LED_OFF); } \ - while (0) + gpiod_direction_output(ACT_LED, 0); \ + } while (0) =20 static struct gpio_desc *all_descriptors[GPIB_PINS + SN7516X_PINS]; =20 @@ -1180,8 +1174,6 @@ static int allocate_gpios(struct gpib_board *board) } if (lookup_table) gpiod_remove_lookup_table(lookup_table); - // Initialize LED trigger - led_trigger_register_simple("gpib", &ledtrig_gpib); return retval; } =20 @@ -1193,8 +1185,6 @@ static void bb_detach(struct gpib_board *board) if (!board->private_data) return; =20 - led_trigger_unregister_simple(ledtrig_gpib); - bb_free_irq(board, &priv->irq_DAV, NAME "_DAV"); bb_free_irq(board, &priv->irq_NRFD, NAME "_NRFD"); bb_free_irq(board, &priv->irq_NDAC, NAME "_NDAC"); @@ -1254,7 +1244,6 @@ static int bb_attach(struct gpib_board *board, const = struct gpib_board_config *c gpios_vector[&(D06) - &all_descriptors[0]] =3D YOGA_D06_pin_nr; gpios_vector[&(PE) - &all_descriptors[0]] =3D -1; gpios_vector[&(DC) - &all_descriptors[0]] =3D -1; - gpios_vector[&(ACT_LED) - &all_descriptors[0]] =3D -1; } else { dev_err(board->gpib_dev, "Unrecognized pin map %s\n", pin_map); goto bb_attach_fail; --=20 2.49.0 From nobody Sun Dec 14 12:08:21 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7EBD21CFEA for ; Fri, 18 Apr 2025 17:35:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997704; cv=none; b=uGIx2gZdVDLHtIsnO5gMKDjJDWWiAYWj3kJmxMqjC9NwB6gkE52ceY91q6jj1hv26bDLGc2qtPr+7DFkp2QXViPH2T4NTpdb75E9TcwKkbC0ArPrAEd17LajR5iKAr1CmPfJmbYH16zBocKusOdqGOttfewjI8N1G5yA0FTEqaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997704; c=relaxed/simple; bh=zbdvaSiXX2oUTDa7WIbY958t9msSvAmj2Lshi5nbldg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P07KGOFieJ8g2s3H00nBBMfgnzQv1NAruGANAlvErc8HPKx9mxU5oDzxwhPUe+CY+AAge0FJdUbD9g0/7i4W7CVFdlF2Uu+YDblP+RYNJnQV3OIEJlIEKKNVLUvOsLmylHm317NvJdYRwbk2NSv3vU6qAI89KASAoZ01MOcycds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aXiCQE4c; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aXiCQE4c" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43cf848528aso16078045e9.2 for ; Fri, 18 Apr 2025 10:35:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744997701; x=1745602501; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2lo8NK9cb9305tOCf3KZaXzeHg3jD7BCaFh2Dh35qq4=; b=aXiCQE4cLVHQBhOIYdDOOmq4NtyFXNixM9ikyhPvVv3+e6mXDY316DhAHdCAO3keY1 xX41g3dsvdvzz/vmQ5kQUQAw0XHE7hl/EpqU6dx3SBEtvR6CghaZRPGXbsfDN2BhW00O +hjKHKOaMeL3Nf97U3gmeD8+/Y9KwqjfIAGz9Lt46YupNcV5b/FfLdIQVQKEi+mSBx8K 4rNkKmrIdw2JE0lVIG5ElBdRS6Le3n9Zw7lG18AmkJFZJJN6P9NXiSnq4C93gg21HjwY jNz2r3qCfbqzreCWzZZWqayJdUVDQVLT2A0UjNi5MtelXC9Ne1IXTx0aN4A16xEi73Mf sXMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744997701; x=1745602501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2lo8NK9cb9305tOCf3KZaXzeHg3jD7BCaFh2Dh35qq4=; b=CgzCRh1jziRMKqSKnO1uHBXuV61G7PJtnOqDm0N8NjkM+SmagfbsVe5hIZXMV3QJhF 9JMlHzw9fcYT25MdRAHq8FHWag94BYl1Uc8BsFdriTjSmzFzs1Es75dnmqX0wI+rxDqS C4oQs7l/FOnKK6/9MyUAACi0OzMuTZqIa+I42a9gHUI+E/8WAmhtLZiEgNycNMSeCyMI GoCbMdQWTlt1FUelsy5vT359N8RQLNRsBiodsZUGjZT+fwh2+BSnDPuQEscMvCbyNNRI gI6Mu/ajjEGNnuYsqZjOajsbzp1uw0JO7Y3cdFIaBobFopUmV9JQls2szTZDfVox4bBO z4XQ== X-Forwarded-Encrypted: i=1; AJvYcCXDWg6b7pk13inwNQyGIS7XaREjuTuPwh3ny4QxypktqBqCXrlH3kUn9IW04VUZFdFJW8mA0M3Kbn7MxZg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5+AWx0iaIMjmLs8tW246C1TEQn9KdS+RRRZK507z593GZJBA+ z/nmz2p6uQYHR79gGvZcPsKrsHlORDu8uRGN0XnK3fHEbCYhKPmH X-Gm-Gg: ASbGncvMVw42QaYF0C+IY3BPP1QtriqxRdM/S0yJyftTTKoQ5IIz0nnlcHG1QKhk4nR 6yoS1ZMlBrt5Kde/SgQfZbYck14/e0jwHiuyU2ji2ir4u20BU+KpwNLHZGdgtPQLujp5H9yYuja 9BOLimapPqQo4uXQyNOz0Loofhz6s4FakZuw0/u9pdybMxkXi4rP7tW3RVekLBRrvGUaA8rL1qD eRpRkw7946K1FqtpYQM/ltLx/ZiHX8xOHkJq0cm30KX5OfYlIBXEV551xSegZr/Vq9s10+VIEZg TTr9qa7utj+Gd62erBM4PsPwhCc2QfErqV6gFWk07/faXM6VEDuRuBf8JKOATM80tu/MnKSoqxN W X-Google-Smtp-Source: AGHT+IGycw6PG3LhA4R9z4UXQhejlyXvLsQYTBzDufjRPf307pnkU7s+bMube8/17mGSZ9ymhrWU5A== X-Received: by 2002:a5d:64e4:0:b0:390:f9d0:5df with SMTP id ffacd0b85a97d-39efbaf141amr2577524f8f.52.1744997701027; Fri, 18 Apr 2025 10:35:01 -0700 (PDT) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4332f8sm3287320f8f.40.2025.04.18.10.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 10:35:00 -0700 (PDT) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: marcello.carla@gmx.com, Dave Penkler Subject: [PATCH 5/8] staging: gpib: Remove atn_asserted global variable Date: Fri, 18 Apr 2025 19:34:31 +0200 Message-ID: <20250418173434.2892-6-dpenkler@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418173434.2892-1-dpenkler@gmail.com> References: <20250418173434.2892-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" atn_asserted was introduced to deal with an issue where certain models of the Raspberry Pi would lose interrupts under heavy load. Using a combination of edge and level interrupts the problem was resolved so the work-around is no longer needed. This patch removes the work-around. Tested-by: Dave Penkler Signed-off-by: Dave Penkler --- drivers/staging/gpib/gpio/gpib_bitbang.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index caa8361da696..1d650cb57cd2 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -306,7 +306,6 @@ struct bb_priv { int dav_seq; long all_irqs; int dav_idle; - int atn_asserted; =20 enum talker_function_state talker_state; enum listener_function_state listener_state; @@ -614,7 +613,8 @@ static irqreturn_t bb_NRFD_interrupt(int irq, void *arg) goto nrfd_exit; } =20 - if (priv->atn_asserted && priv->w_cnt >=3D priv->length) { // test for en= d of transfer + if (priv->w_cnt >=3D priv->length) { // test for missed NDAC end of trans= fer + dev_err(board->gpib_dev, "Unexpected NRFD exit\n"); priv->write_done =3D 1; priv->w_busy =3D 0; wake_up_interruptible(&board->wait); @@ -686,14 +686,14 @@ static irqreturn_t bb_NDAC_interrupt(int irq, void *a= rg) =20 dbg_printk(3, "accepted %zu\n", priv->w_cnt - 1); =20 - if (!priv->atn_asserted && priv->w_cnt >=3D priv->length) { // test for e= nd of transfer + gpiod_set_value(DAV, 1); // Data not available + priv->dav_tx =3D 1; + priv->phase =3D 510; + + if (priv->w_cnt >=3D priv->length) { // test for end of transfer priv->write_done =3D 1; priv->w_busy =3D 0; wake_up_interruptible(&board->wait); - } else { - gpiod_set_value(DAV, 1); // Data not available - priv->dav_tx =3D 1; - priv->phase =3D 510; } =20 ndac_exit: @@ -850,6 +850,7 @@ static void set_atn(struct gpib_board *board, int atn_a= sserted) priv->listener_state =3D listener_addressed; if (priv->talker_state =3D=3D talker_active) priv->talker_state =3D talker_addressed; + SET_DIR_WRITE(priv); // need to be able to read bus NRFD/NDAC } else { if (priv->listener_state =3D=3D listener_addressed) { priv->listener_state =3D listener_active; @@ -859,7 +860,6 @@ static void set_atn(struct gpib_board *board, int atn_a= sserted) priv->talker_state =3D talker_active; } gpiod_direction_output(_ATN, !atn_asserted); - priv->atn_asserted =3D atn_asserted; } =20 static int bb_take_control(struct gpib_board *board, int synchronous) --=20 2.49.0 From nobody Sun Dec 14 12:08:21 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C7F321E098 for ; Fri, 18 Apr 2025 17:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997705; cv=none; b=IddjFQhxLdMY4qA0TAJQjBSrNWy8AXiJBozaW3x7dOwCJbQFHapyD+Gxqg7Vl28b3qghovv+4t6ey9K6qjjmdHB1s9xOAwbR5QfBe/8dlLAfUHkVv/ddwZup6SSQzp9+eUGWpDUhzITBcvW4PsoFd67CLXmrq/TpJU8/BN9AMxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997705; c=relaxed/simple; bh=4iQseaUFTpcev9Eu6hppJkJqT6uexmzYNKQtB62Erp4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fU8G3skcn+J/TOLE6pbHlgRoxO/Ggt0dnFmfAFpRGow24WU0PknUD+43CMhDhXm8JqI5vRyQqJQcu26wlCyPyhaeHnvOvQXdIaIoZ3mBgk+5gJJKJLa3B58XThQIY8zGLKNY8Ic9247cLFfTtSiwylhX5s1H7+5O4tyKzGkwfOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KmTiJoo5; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KmTiJoo5" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-39ac8e7688aso1213551f8f.2 for ; Fri, 18 Apr 2025 10:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744997702; x=1745602502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OnBmFXSxRbz0DmRCSR8jCc12+Aku4V6y/rAuR5Mgcos=; b=KmTiJoo5uaGIiMd04IgnutH6RVTihO/VR1ROrIfV7RR6/V+j21tVyPe6ve3qc+17PX 4GzE7i6p3J4eg5ElBjalFhTcnv8jDJeQhOb1oXIaH4m9gMNXD9hBpzmIB0CtPBsJzWd+ fY92VfIPFkyUJBmFCi411pDcFXq7JtM4MgexIYzSwPCD2vwe3zHgFvY1fnXixHtD2Ovg apQ1wX3hrzMlhjJBgk6h5jjAIEPia0Blw8O9xqmXQ1YUQk/6unKeHpILlfx1/6bwP5nK ln0VAFy9/UUrDUJ2BF2W8Hh07/g0lFQ2rJM5/j0ZLtFxogYS/71soMrdygMrov+qyKh1 HXDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744997702; x=1745602502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OnBmFXSxRbz0DmRCSR8jCc12+Aku4V6y/rAuR5Mgcos=; b=MKbr42X1obVzHbfNLswM5roHnh/dP5rbO0hNKJJQXbTtR8Mf3Tj7BzPDczBFUSAImk H64R4Sg9GXZ2ZRi55468MIeJ2SzDgMBNqQ7deTQWgC0LCofEpmC0NxQuFZqqfdt32uc4 T4Nrbgi+V087lTZJPmKmCkvXBpaWloEAZYXybSNre/IHuBH7tzGhwMtUKNyhlbbxsMP1 pwXZPht0liLhin/tuhq34D8u4PfWeu5sz7YPDqkdKgC2BWGkIpnw0ZZrsMIXkL/bbgyF TYjjWovIpIvcmG2cGqTosNkltGDPOpJtkHvqDHCc760PKnEPEVmaus8IkM7PP1Nx+B24 AUTg== X-Forwarded-Encrypted: i=1; AJvYcCV2I643fLh8G6I3UblIBIbW/hYsvm3E3en5MxCU/royeNcDtsZkVlyPBpZUmyH0XOv+MskQDJznluJn/Wo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsev8nXhDggoziM58gCFSFJObSQFdPCJC3dL8GHPDHzo+do8pQ 7H0gI3iFT2FLN15MFMH3MLw2oPi72hKN7CtBDdAf9R1UB5KczkRV X-Gm-Gg: ASbGncst4pHaD9DR2hply0K2SDgAetEpQfCj2WVTfCT+pp/cOCXIKmIyZlPyPs/lSyt EeZBm3fzIuQY6vdf2RIe08ZoK30JwOB9eILNUjznf30SitLzoDBAd6dFc3yxUn65NZQwvDzZU9c 9vdEQZaLdPSxkFnLGexP+qyvy71+36fpGWkN4mC7NMPaeElQYS6NVXb7bjsDuRZkWRRUigP8gGK cqy3FC7F6exKtiFQX9XYgFWZsr9EewsJ8R3x8G3/DyOF6Ig61ZABPS7mlYnG+QLi9DZJxe7+bE/ xu/91vzbGIDrY9/rJ4WUlsLdXmKTIMo9ulDG8+6bzZJLCGQuUOB/vRS9N/vVqWg2JwaIpgvoqXv m X-Google-Smtp-Source: AGHT+IGARWePzoNyOWwMYXMMy4aIxfc8BB0KzJuF4hy3VaEJfNzI0IEJ/V9IylH7RJ+z9tUcrQEI8g== X-Received: by 2002:a05:6000:2503:b0:39c:30d8:a80 with SMTP id ffacd0b85a97d-39efba3c88dmr2523714f8f.19.1744997702450; Fri, 18 Apr 2025 10:35:02 -0700 (PDT) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4332f8sm3287320f8f.40.2025.04.18.10.35.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 10:35:01 -0700 (PDT) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: marcello.carla@gmx.com, Dave Penkler Subject: [PATCH 6/8] staging: gpib: Change error code for no listener Date: Fri, 18 Apr 2025 19:34:32 +0200 Message-ID: <20250418173434.2892-7-dpenkler@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418173434.2892-1-dpenkler@gmail.com> References: <20250418173434.2892-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When doing a write a test is made to see whether there are any listeners. The code was returning ENODEV which is incorrect. The user library translates ENOTCONN to a user level no listener error code. Change the error code to ENOTCONN. Fixes: 4cd654f84769 ("staging: gpib: Add gpio bitbang GPIB driver") Tested-by: Dave Penkler Signed-off-by: Dave Penkler --- drivers/staging/gpib/gpio/gpib_bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index 1d650cb57cd2..86b98eb1ce69 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -516,7 +516,7 @@ static int bb_write(struct gpib_board *board, u8 *buffe= r, size_t length, gpiod_get_value(NRFD), gpiod_get_value(NDAC)); =20 if (gpiod_get_value(NRFD) && gpiod_get_value(NDAC)) { /* check for listen= er */ - retval =3D -ENODEV; + retval =3D -ENOTCONN; goto write_end; } =20 --=20 2.49.0 From nobody Sun Dec 14 12:08:21 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B58C221727 for ; Fri, 18 Apr 2025 17:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997707; cv=none; b=LG5EfRxzof7JYHUwgZO++yeDxnuC+cZSTzlzo35JcUj6F8lsZxdBo+oEzPxmotr/RgDKGBCc5T+IR1zLPeUPPJl7VHbOL4rDk5x3q2+rkHkMWYnTu32GqBR7appBI/UaZ76Uo83UiJDUoV81wqnxmLa3ZDul8984C8d64Wwo23I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997707; c=relaxed/simple; bh=m6buCUOBnFMRhDlhSjM4/c7jl04g5VpMz1TxvjXuR8w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=exeO0S19wxTPkZma4+ApR8OFbxHa1ANtNVJmyfqxXlmaR1ndzUyLhp7X1jIhMc9qH08azI78n7OtpZJ2eJsP20xTWhUH2OT95Kzkt/9OTJp2OKMeoPN/XNlc6QFxPS5xBCSKCRkM66eynHo9Tke+d2vPAysg6HpjivvsbswnA08= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QAZWe376; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QAZWe376" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-39c0dfba946so1316632f8f.3 for ; Fri, 18 Apr 2025 10:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744997704; x=1745602504; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eJILlUmxlNOkJz/bn/NxCrCFwA3F1U2EoPAh/Z2tm+8=; b=QAZWe376xTLkORZLj4RAKkIERw0owcqylJL112xUxkcflp9SNaTIsGvmXSphRDOhzz Puu9sBF26Rr8LKG+4YON4KSdweDOH35qefHfOilv2ePK48doDR++RT6JUn2xUdAFTXZz +6MoGWlAj/L4tw8ZeHU3wBOHd9ckGS120AZHfzOg9I+zlT0E9aqndGeKNlhcVuJhO5as MuggV7nH8vSZQSsfHYGwPUNWBogLDGOlPgFOy4INj1bz/jNZLooDqiDNuMgdXtMLb/aG kh5iSjt2gBg4Xm0a7SDSB9JdW4Gk+P3ahr9K587mwGQgCY+d13MC9BaZlhP40m7sZXqG 5k8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744997704; x=1745602504; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eJILlUmxlNOkJz/bn/NxCrCFwA3F1U2EoPAh/Z2tm+8=; b=CoOAx6X3Ve6kkH1HnQWd1zLyxu809OpBtwGiL0SoylHN5Lm3GLEMC4VbgJrKZoiADe op9qYVFoykj739yPhecvPmqnreVxV0P37NuK4VyXhbPclo5/iUD/0Y9/l2KLCFpsxkkt ciuF519BREwo1dOaf9g0Yz+Rs8q4k1UVWosZ72J2oIw2whGUwiVfYuZ8+/aRcaPzBTPv ZoM6o3guXDdnDShe5znL2ZKrljJeFpHbrNP8GmwFrKOtQtlB55Fm2gmZSzi/+6kQvmhJ OVRLcppxEdDphGfBvxsV9DTC+0NaaY1EqgvWzTQWdQe0nq6CLY/TsfHZyJlfXU2Aizrl y7Yg== X-Forwarded-Encrypted: i=1; AJvYcCWeYupxYlwFtxnoH14CPNAzGisIYhninYs50uEcnaHPL7UY8eJjeQLxa8cy0c7jgl9nvsf1uoOcJaX9LEE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+kIn83pQ+HwYT9ERzoZm9XnorSJYxlW0i0r37Jwwfy7RS0Y7m oUGHr8gUpQeqKb9Zavr1GtBJP9bC1O4IvpHqrX6q/BhsR2zNl0OM X-Gm-Gg: ASbGncvkRKOTsceitr+J/Bg64ApszvcNzcjqqXeQZjlBcdut0RxvHBCrgRqIPOq77If 41dJQLd6liugfG6F/5RzPmyEeG0dC1QJVPp6NsN+JiCUyN+p5Pq+zyFs/+kwLSld4Ft0VLGTwIB 8Qrja8HnNc+AbCRDerDIY3HCFlG0d2QdRTq8iGjE3t8u9AwXVO4pO65EVSX6q9fI7qlxwZ4n/DR xAgsfEEqtOOc3Az/ya6TytwRSdGARX8sPj/0Dj2mOadrP5HBmvG3xQOOAS/0+tUzvO8UzMg+ANB agYaD00JbCBAL2Phg7qGFhzpl/yuA1rTQtV4wakv0zwrabOKjhKNp28hZHwXZhw0W96wgZ0Jtxx 0 X-Google-Smtp-Source: AGHT+IGm6D7XQQYbJ3aBE5vZYxL8XaPOdXvawSEdeCq9wxVhJrXnyxNQy/H/R9umb2uWWhdcsZdjSw== X-Received: by 2002:a05:6000:2913:b0:39e:f641:c43 with SMTP id ffacd0b85a97d-39efbaf689bmr2763694f8f.53.1744997703672; Fri, 18 Apr 2025 10:35:03 -0700 (PDT) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4332f8sm3287320f8f.40.2025.04.18.10.35.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 10:35:03 -0700 (PDT) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: marcello.carla@gmx.com, Dave Penkler Subject: [PATCH 7/8] staging: gpib: Cleanup allocate_gpios code Date: Fri, 18 Apr 2025 19:34:33 +0200 Message-ID: <20250418173434.2892-8-dpenkler@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418173434.2892-1-dpenkler@gmail.com> References: <20250418173434.2892-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function was using unnecessary variables error and retval. Simplify the code by testing for failure first and remove the redundant variables. Tested-by: Dave Penkler Signed-off-by: Dave Penkler --- drivers/staging/gpib/gpio/gpib_bitbang.c | 39 +++++++++++------------- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index 86b98eb1ce69..5c134cfb6d61 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -1123,8 +1123,7 @@ static void release_gpios(void) =20 static int allocate_gpios(struct gpib_board *board) { - int j, retval =3D 0; - bool error =3D false; + int j; int table_index =3D 0; char name[256]; struct gpio_desc *desc; @@ -1135,8 +1134,8 @@ static int allocate_gpios(struct gpib_board *board) return -ENOENT; } =20 - lookup_table =3D lookup_tables[0]; - lookup_table->dev_id =3D dev_name(board->gpib_dev); + lookup_table =3D lookup_tables[table_index]; + lookup_table->dev_id =3D dev_name(board->gpib_dev); gpiod_add_lookup_table(lookup_table); dbg_printk(1, "Allocating gpios using table index %d\n", table_index); =20 @@ -1153,28 +1152,26 @@ static int allocate_gpios(struct gpib_board *board) gpiod_remove_lookup_table(lookup_table); table_index++; lookup_table =3D lookup_tables[table_index]; - if (lookup_table) { - dbg_printk(1, "Allocation failed, now using table_index %d\n", - table_index); - lookup_table->dev_id =3D dev_name(board->gpib_dev); - gpiod_add_lookup_table(lookup_table); - goto try_again; + if (!lookup_table) { + dev_err(board->gpib_dev, "Unable to obtain gpio descriptor for pin %d = error %ld\n", + gpios_vector[j], PTR_ERR(desc)); + goto alloc_gpios_fail; } - dev_err(board->gpib_dev, "Unable to obtain gpio descriptor for pin %d e= rror %ld\n", - gpios_vector[j], PTR_ERR(desc)); - error =3D true; - break; + dbg_printk(1, "Allocation failed, now using table_index %d\n", table_in= dex); + lookup_table->dev_id =3D dev_name(board->gpib_dev); + gpiod_add_lookup_table(lookup_table); + goto try_again; } all_descriptors[j] =3D desc; } =20 - if (error) { /* undo what already done */ - release_gpios(); - retval =3D -1; - } - if (lookup_table) - gpiod_remove_lookup_table(lookup_table); - return retval; + gpiod_remove_lookup_table(lookup_table); + + return 0; + +alloc_gpios_fail: + release_gpios(); + return -1; } =20 static void bb_detach(struct gpib_board *board) --=20 2.49.0 From nobody Sun Dec 14 12:08:21 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5116F22259B for ; Fri, 18 Apr 2025 17:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997712; cv=none; b=P+oCmzH+9ijhjWBvqFPeOdcNEXXaEQrvfC9293IeURmI6PQsb2JMvgpOAkNt8gL7+C2ghxD3pum5c59RHAapptfixxmWZyoe1jEo3axsKwvFHjAlg1j4y7SpJb07y81EwBagpRqQmp13WK3zamFE+O8GWGpL15DIGUpPqpcg7Jw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744997712; c=relaxed/simple; bh=LDThIiFsWtW7LNFAZQNVxUPP1fREV6zlJNSL4JVrM5Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uH7aFH2Dgbmq8MuqcmPfIOVkXipm49CtddlpTvCTGd6JzNp0GXMhm83ZGyzlN/jEdj5NxkSoGN1T8u4ORck6bzrbf/Wykt2OG058c1y/kZjB3nJtwTq/XiOpTUbYcc0y0Z7ZOJyeXnCnIthr4O5dRubAZKFjE50m8gtpcdU76rM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GvTyJ/hW; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GvTyJ/hW" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-39c1efc457bso1241628f8f.2 for ; Fri, 18 Apr 2025 10:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744997706; x=1745602506; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=csArHKuBMKX8dfUeq28zUks4GtsX2v0W8y/LTpEF+/U=; b=GvTyJ/hWzeBpp/eXoFUc0zro8z+66tsKXBQn87NoZnq2IgHYP8E0r9Xfn/hCdVyRz1 zW/m0ILmMDZcFLAYsAyLsiMF0tR1Ss3hxIogEuH13JyboXU0Dn7CFJYBdAUSjmbSdDqn RHTLH+YIpZm0BC8xOj4rdWXDKyUNX3yEZYsimuVm9hQoBhCudaSY8FbShSQYjl4by8Pw YqTLew41IpU+3xmmMTGAwOqP3Bd0S7OXA6hKg3IcSwGZk2v1X5SaGn312wfolFOJLJzC EYgHb7TMRE++lADCS4V1MgQQNXb+FO72O3K2CtQw7HiJVXQavqKfD1mrRc6lX9ErCpIQ wRVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744997706; x=1745602506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=csArHKuBMKX8dfUeq28zUks4GtsX2v0W8y/LTpEF+/U=; b=rB0YABhf+h5D3KpIUjbXrUVgHTC8Ozth1nyjfXoyrlLOnTT6d49aEzYov2ZDYP6tTX H7ToVhs+8RuLIYkh/hlD38NKu36ny2llDdqPLRbDS5EuXyk2xPr+LE9Obh3tAEFt8E0a HEATT1ewZxoQnqPVdqZx/RMToc2/JGbRb80NCLKsueE9LOHULNjr+zEudTwVmdTQ30u8 jkjVcKnyO01ulLGJtJYsT/WotQB/Qp1fGN8XEzkY5+ZJh72okhJLczSuMCXp48p/mCW6 vcYnml5uzZ3IdXYCenqOwdp+SyFUQblljEEaKD2J9gR4ypDZtEtWYDVyyHaXi3NSGu/F /HmA== X-Forwarded-Encrypted: i=1; AJvYcCUeF3gNeLfl6nnOIPgfC1NoMXtppEU/IT0VpoqpsB/5Pn4o1aiimucTap0oELVQXRPpKzCfgodEc5xorTI=@vger.kernel.org X-Gm-Message-State: AOJu0YxlgdlLtXYBq/ZGhuw0aF2xzW3kYjWZnuljLGkSOe4gclmZEBFq W3ZbuCKrgPkNfzwvZGPwUJIrjE3LIGDcJgR73yubn63y/7zwTDdP X-Gm-Gg: ASbGncuXBXGqhA4jJQ0VbpcQuRO6fX7QEgQ/R7+lbsuvd/hnStbGz39jEO3PT3ntdj+ pC2g97hOOQ78mfzz4LfhVO1asHQIvkPW56A9fYONL4KHK1vOz3fmfxvMJQLzG1RM7MP8ENNbbX/ CVrDUbl8+b/EtSlLgrJ1ZqQAg5JlYIuxqvjWnYGrcH6GJCeOf1BKmp2dLsw2qkOiyg/liaSWt5b 5CF+3SqZbxzOAK8rGJirsUwUzLMsaYtkDlWbRoA9ILir3Lw7rXGl8Rgl1F6JIwJlo1JZsUje7u1 BFDtLYn7cMxy0FORJCSkOOhD8ITtPzPJy+AUW6VOeiioYZoIT7wUvuQj4R1NtN4OPS3SKFBWfRQ 3 X-Google-Smtp-Source: AGHT+IGthIenlsGwjtshWXOrozso53tzfubQVslTvO6z3gNHpw83s4dbK5+maUlUJ6SvkuAZFIAF4w== X-Received: by 2002:a05:6000:2913:b0:39e:f641:c43 with SMTP id ffacd0b85a97d-39efbaf689bmr2763752f8f.53.1744997705477; Fri, 18 Apr 2025 10:35:05 -0700 (PDT) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4332f8sm3287320f8f.40.2025.04.18.10.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 10:35:05 -0700 (PDT) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: marcello.carla@gmx.com, Dave Penkler Subject: [PATCH 8/8] staging: gpib: Set control lines in attach Date: Fri, 18 Apr 2025 19:34:34 +0200 Message-ID: <20250418173434.2892-9-dpenkler@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418173434.2892-1-dpenkler@gmail.com> References: <20250418173434.2892-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When the driver is attached the state of the main control lines is not defined and can lead to hangs. Set the control lines to a known state (logic false). Fixes: 4cd654f84769 ("staging: gpib: Add gpio bitbang GPIB driver") Tested-by: Dave Penkler Signed-off-by: Dave Penkler --- drivers/staging/gpib/gpio/gpib_bitbang.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index 5c134cfb6d61..625fef24a0bf 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -1262,6 +1262,10 @@ static int bb_attach(struct gpib_board *board, const= struct gpib_board_config *c gpiod_direction_output(TE, 1); gpiod_direction_output(PE, 1); } +/* Set main control lines to a known state */ + gpiod_direction_output(IFC, 1); + gpiod_direction_output(REN, 1); + gpiod_direction_output(_ATN, 1); =20 if (strcmp(PINMAP_2, pin_map) =3D=3D 0) { /* YOGA: enable level shifters = */ gpiod_direction_output(YOGA_ENABLE, 1); --=20 2.49.0