From nobody Sun Feb 8 12:31:46 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010033.outbound.protection.outlook.com [52.101.193.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 174C41A7045; Fri, 18 Apr 2025 14:31:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744986677; cv=fail; b=aCuLOvBE3McImQQm1FeRKSFD4eW2UUKt7/fmd7+Hs/HFnrJsqas3Uw1h5VaxnzJKGqP0T8R1EuBEnGzWWoVLHmUkU4ubqqzTiKH/oEvAcMXZ8640sT7E5pGR7aCReHp+aduwYgB8POVzLmRMenXuW3wmP9E+KrXcBd19sRSvrFc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744986677; c=relaxed/simple; bh=hpNi6IAusLCuw7QSvzI5UUpOKNV0binGCRTmxL2Yn8Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=juh82VTGtL97GTCIHL0kzzI6BYdLiIBaQJo2L6TrahpBa2f/Q7TJJx6oJMDqtBpfn+K5efUnDgABf5OxwEAEuXHyeQctswITE8gjmXV2zOvxLRGB6rAZ0g4yaPkRg+kLRlgdLV6L1mNXWn7fbiczGx2tvFHQtRzrKu8yR4ACBcU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=asT7WIC3; arc=fail smtp.client-ip=52.101.193.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="asT7WIC3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UkTFu8zN8xA7dDbLBQpOvh6IlYJKoDe7eblSM/EvsitsNtf9tDmiblQF/ynpgUxKspLiPvvrYUrQvCyfyFc58EqSNJhKIeLwcch6SswdMj767hbt5vJGu8WaTm53uI50M1j6w6zErKkcDdJfwoHsdpHtZoDrUJcvc44ZRbjOkJZ90q0diremzdlAO3uOv6cX5NCpp15v4zoejde8uO59QHfxztb9um9hheXJNCkb98v5rLfT0vUXVH+yMKIfyFwtbOk2N/mGPOaT9LLpI3T02iLsZJldhYG7zkz9zbbvQJLVMjdxN0VO3VaxJP4bEdHEM9aB+m8ALuHWRor4s9ACpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=13l7FWwrwXiCf4K/P2oMalPKe72HNXJNB4jM5iUXLH4=; b=W+KKvzBjvmf5ln62HiQdj4U1gkVco/klt046tD+AlptCr5xZqmBMv1bUmUWW/FM4beEnUjWMriH7WZU9M+3mWUV/XU0Botx2x0Ul/M67kh1+g63wVe3PqCERcQSobhSZXGMDkGGrDZfHYxNTV1q7YnNr9ztIY2DJJQlhLxSPVqtJc2k+ggzCaljlczA2m1jWgSsXNzUC3QPXqwaRd9JVkltKEHEy0FUoJS5NObNDN+8x4849EGQqvkzyUxa4M/plAbNEpew/4wGldrH+Z4HMESWdBWy55AUuEpQTtuxvjRwHNWG/ImjNV++kxcS9Dk52r7e4QVBu0y9bXcpYahzM6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=13l7FWwrwXiCf4K/P2oMalPKe72HNXJNB4jM5iUXLH4=; b=asT7WIC3v4eh5uN6aVn3K8Nch1mnO8HneB3kcbP7bwZ1OAuvBmOXcbBj5IjYPZ55ONPc379HTkxpkxbpomDCN05rEk0qnHISggiGddqxQVxI4wUjMk67ddvCMhEQXT3MJa5xQlC7mkOCXoDe2M9crHWnYb0nabXNLLkobA0vV06l/sjbzn2RP0egNE11LeqbZ0bB/xf9xmrnic+m83uTZQ4+yfwe9BnMKO/+1uXQyq4gqvys/khazDsiUeIlP5mzay51EoxQ1NjI7NwuEq1onNFpcMbUxf7RkDE5Aihu5Q4k7F5usIJeMUM6+UBghll7hSyqKztmWNyXp0z4ErKe4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from BYAPR03MB3461.namprd03.prod.outlook.com (2603:10b6:a02:b4::23) by SJ0PR03MB6674.namprd03.prod.outlook.com (2603:10b6:a03:396::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.27; Fri, 18 Apr 2025 14:31:07 +0000 Received: from BYAPR03MB3461.namprd03.prod.outlook.com ([fe80::706b:dd15:bc81:313c]) by BYAPR03MB3461.namprd03.prod.outlook.com ([fe80::706b:dd15:bc81:313c%2]) with mapi id 15.20.8655.022; Fri, 18 Apr 2025 14:31:06 +0000 From: Matthew Gerlach To: dinguyen@kernel.org, bp@alien8.de, tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Niravkumar L Rabara , Matthew Gerlach Subject: [PATCH 1/2] EDAC/altera: fix cut and paste error Date: Fri, 18 Apr 2025 07:30:51 -0700 Message-Id: <20250418143052.38593-2-matthew.gerlach@altera.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20250418143052.38593-1-matthew.gerlach@altera.com> References: <20250418143052.38593-1-matthew.gerlach@altera.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR05CA0033.namprd05.prod.outlook.com (2603:10b6:a03:39b::8) To BYAPR03MB3461.namprd03.prod.outlook.com (2603:10b6:a02:b4::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3461:EE_|SJ0PR03MB6674:EE_ X-MS-Office365-Filtering-Correlation-Id: 2aca4868-4ee0-4b6f-2085-08dd7e85a6e3 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?CkBRqjfQkGoF5nsojvrTaTsoKuPrmmyQ7lcd0Z5vEZcYIUQ0ROKM23uIuCO4?= =?us-ascii?Q?r2kTYrZ/9QHAyEmTkkvfjXqhT4DmBHmpxPwW1nMddEsdnqvrg9yYcfCl1Qso?= =?us-ascii?Q?eMQnjnwYN8ctcFQ3fs+2m8c4V7gv2fje3IM+21D4CY0iV6oAadyaJmZNkA9J?= =?us-ascii?Q?dd2cFXZ5fSz69toZl0tGV/5Mvqbaj+d+7KYNdak6Jwm/zEt32R4iPH9fGlZz?= =?us-ascii?Q?VruJVFAc5Fc+uUG2btWy2f80eLFP8xLcZfq9eG8mfIm+fQc2kjKqEyGmjls1?= =?us-ascii?Q?sEz6SNpDQ8jJt+bNNcDAdNkgzQhJqUm+oI8xbDpZpgqkieolOtewBf4hcrCy?= =?us-ascii?Q?K/nn0JCHPPtJYUqZuGWN4lJijCt09g5P+GjnnnIStcpMFYDhOaBMH6QALcDy?= =?us-ascii?Q?IkUnmluNzL2da6Pm/HMQuQPof4whLxhCN/7nBel7QVP1F8dhS1Z0ynK3l7BV?= =?us-ascii?Q?J6jWmNilmDL/ehVNIuUOgiZombdKGRM+bccwqMsMmM4HHiqlhFbYnzcsKpBI?= =?us-ascii?Q?qrMYYpgIMgwtUaKyMJi/ulUdVQ8Xr7OfgunzYiCRhKS+2i1HlhswgXRXLnxm?= =?us-ascii?Q?2nRZVPdIcPqUyG2cM7vzxb6VS4F4IM9e3jjWF/cJ0MaUu8PfSRvm4bHrx5LQ?= =?us-ascii?Q?lj7PfqilCD/iUTN77chw9U01jgoPDTpfO4cwRYQyteLTb6Cz3QQmZVw0/pn0?= =?us-ascii?Q?LPRRqcL5N/Dp2fhvjjbU+uthMmokl+s1jBZkkUNWdh89T109fPFlWcHAF1f2?= =?us-ascii?Q?gA2QOTbQHzGKtRPmHqBDebY8hXltOeEBQyzzsYuFZ/NN5RmSJUpcY74ISwnw?= =?us-ascii?Q?DnWtOwIDN7VGEMeI9qWxw8FQjxhSk5xVOKYldbWDcVVrxK+0/+//+mkaL5uQ?= =?us-ascii?Q?QQ5KXipwPpxFJOvwVipJeMPi6EOjTaIRY5rXNDCot00JWv7+i6+IexNeWQXL?= =?us-ascii?Q?gNiNS2DsqS1v3nWUn7/clufe0i3v5tMzobloBNvzEbL4ebT1MtnrykEdMGDM?= =?us-ascii?Q?U8HnftCIKwwElyVMgLGC9c6zFKPn7DlDQXpFafy02aPh5S7DxETB122+vp7w?= =?us-ascii?Q?LlIdIktjjc6fybTCJLJpdyO2s7c6KoycVerrcc/NGbWkM6vO5bFGfyffqjYU?= =?us-ascii?Q?PStGG2T+7GwZJ0cfH3/d6SipByWbn1WERDXaFC33IRZJEGDDju9zIIRNXQfO?= =?us-ascii?Q?nBz2y4X0rTpJhHxoSQwXr3wBIkzBT3M9ngp3cSUacoWob0aAF1n3fSSfRXmM?= =?us-ascii?Q?x4N5g4+ebiAHENGozmTecyZpvfpQVaU/9nghcmu796T9Eglnj2x6Pd4DFmau?= =?us-ascii?Q?HNhkH1/jWayW0r0dCzlmiKOOf+UyBFgpTRNDmahUM+pC982H6HCrX8mBlyfu?= =?us-ascii?Q?rOUzU/jo73qC/xJwlSuVoogS20qrjE7nHLNV4gCkWRiw/XRrbwp82CpLWL7q?= =?us-ascii?Q?xArMdxNYP1I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3461.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RsqoDDtk6FhaM1SjTlpkHqkBTJYV603IYAp1QItcKh709qhluoPvVcskI0AR?= =?us-ascii?Q?oF1N81RhN0rxmETDeB0V48Dhsa8L0l8f2v7RAN7LKY3vBU1XSPwyx/JH9eJ1?= =?us-ascii?Q?gsP076PYBAShWPnLQNfcarFkfYnVttbikPSX4JkV8uEvjp7T5B5Ok3lL6cFm?= =?us-ascii?Q?xS+W7tygcpaC3T6MkD6/JCeb1B6Mjto0VEaqCBY5YVN1m/izU1NscHhO4JYc?= =?us-ascii?Q?hNd3gHtL2oSkJ3uZBX8LOpToVIbY2NJQUhQK4tccdiq038r2S+BViLh6zdBg?= =?us-ascii?Q?Mzk4yQGgZH3W26RvJ4Q695bbdJr4BorqHszVdeoWHyeI5Q7PSgSkrBTJm0+e?= =?us-ascii?Q?gALDfKZcpO1WAbjCLPSchOoUeVQFoeOH7rPjAveGfVTebC9+utGfnGIYR5it?= =?us-ascii?Q?7CB9opI4cGr7++6DeJBkf/2C9l+z7KCZjap37GOB9OUCk/KGR79RdrGPpMAO?= =?us-ascii?Q?VDJwhYfnarDJpDjCZZo/ffxtpt5U9+861h0zMS4bJf5KpsPr8oW8/IveKoGj?= =?us-ascii?Q?BiMuFyBUf1tEjjxrzrg1ZSZGJ0Jq+JZlCsCSjLHf5YAbzT+tYYd8yNg3sOYl?= =?us-ascii?Q?IzSgiZCDW1x8BUgibEUm803PzfRpT8xZFzWGqscImz3ijpAFsfrIy8Rnt+y8?= =?us-ascii?Q?eOhCy/G8tHClbbgimwB5FDOeAZxjVtRvYZ6Pah4Yw91rRcgik47uhwKaG/bS?= =?us-ascii?Q?r5QppX3nLxGMgZpQsuPlUYp6by+H/uS4MhqjDeGyrZ9ua92TVTVFeZAIibg3?= =?us-ascii?Q?JBe5PeV/sn4oLdTTaHEECjD9lXstC8MTs+qkj4hpwfxXWOJEyY6BfqRWjHdR?= =?us-ascii?Q?uKnliKKGgrzSaYOZv5vQtYfjnuSoCU69agtQ7K6R8NQcdpEzTVEh/iOvRKFl?= =?us-ascii?Q?iUcpaY66X15VB0T3rrFu6jmYxh71tGesD1ZPacfvioFf05aCNJ/5r8J+ncpI?= =?us-ascii?Q?OehF3DEZg7YSOOwwI/hEwtCujdNl3rpaYSydz2WWkYehJxpwEWJqF+SKTfUz?= =?us-ascii?Q?ahIMfO19kWWZMDLVYhBENvFIIz3v0Thbo5KS7eOkH/GGTzwoYycSnRomEkR0?= =?us-ascii?Q?kDOdlb0j2PphPeDYGEhCWdOaYPlHbNFtpzAbF6SK7hQjXkcc2n7oaEYuhhAD?= =?us-ascii?Q?QQUVHL/JKGocWCM4SsIDp4m8Ju8btYZNv2fw/fhchIlAv8QHxdEu9rOtasxN?= =?us-ascii?Q?M0elY0N9Cr099u4Fv0+IE7fHEZh0890hBu/vzmIty1yKnUfMY5KtnJg6Z8Nx?= =?us-ascii?Q?wway1il6KgnoKYqY9CSoE9GCEzPosDyPGwwNqTSeX5SDa2qvhpnksEUPUq9O?= =?us-ascii?Q?46G6oJ8faCSt3O4GVoC/1bDXz7VzFzevKhbL5yQbP4u8tcPqsBhfWC+20gNU?= =?us-ascii?Q?VK6QE4rfhWkZcoIkWMXambgIN6RCshchOAY/8iDrUKrAQqoXyU4epD2BZHVs?= =?us-ascii?Q?h0Byi/6tnRetipUEORkD81HPK0ackC0/Go737iYKAvNE7MC3ffz0sckABART?= =?us-ascii?Q?5oXGbJg0Qm3sdzFb1bTUSNtiYP/FF0u83AA98wNQjwhrpkLGVqTB9hV6XNJO?= =?us-ascii?Q?moXzoqdoSzHeRC3tN488ebZXCTfwN97QPXPhrBUEsF+OD40w2ua2iDKwJ8d0?= =?us-ascii?Q?rw=3D=3D?= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2aca4868-4ee0-4b6f-2085-08dd7e85a6e3 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3461.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2025 14:31:05.4291 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RG+gxouUuEVYe6807DJazu/BBOMFgi+nycsSUrBmSKzeTj5YkIwFLY3Tt4vRxqG05WnhjjgEdL17SxHsWk7UxWcaFP6Tbp1eSrjfnufZ0Q0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6674 Content-Type: text/plain; charset="utf-8" From: Niravkumar L Rabara Fix bug testing the wrong structure member, ecc_uecnt_offset, before using ecc_cecnt_offset. Signed-off-by: Niravkumar L Rabara Signed-off-by: Matthew Gerlach --- drivers/edac/altera_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 3e971f902363..88d9d2f458ee 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -99,7 +99,7 @@ static irqreturn_t altr_sdram_mc_err_handler(int irq, voi= d *dev_id) if (status & priv->ecc_stat_ce_mask) { regmap_read(drvdata->mc_vbase, priv->ecc_saddr_offset, &err_addr); - if (priv->ecc_uecnt_offset) + if (priv->ecc_cecnt_offset) regmap_read(drvdata->mc_vbase, priv->ecc_cecnt_offset, &err_count); edac_mc_handle_error(HW_EVENT_ERR_CORRECTED, mci, err_count, --=20 2.35.3 From nobody Sun Feb 8 12:31:46 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010033.outbound.protection.outlook.com [52.101.193.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3378013D8B1; Fri, 18 Apr 2025 14:31:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744986675; cv=fail; b=bL/dx+D2j5147wN/CJfnjvDwe+66YXY38F1x4FP3+ZFM0VWlWUzkhwDMDxxFnge7clRVVjJgjQz5QMsq7gD5zszP4STGHN6fx2js8XYSzkAmK9W8nbfMVKwcl4wQ9yo9yXSHx0vPJjMQJahRbmXhM7cHBaq13zflsyxeRlM7aQ4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744986675; c=relaxed/simple; bh=36Aw5ZXLA+/2KycsFcSoMWxs29XOhdMP950nUhX6lw8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=KEt6tNa4pFjikEH6nFhcPMQ3ngtosvqD8cM4UtBDsYipkUdjA5qSuW92najb0+Z9vEe1zH+ZVJouZQxlFv41eEPjvOvccGKNGuCDomWqxbRLGMZXYhZfK6537bdwG7v4HrCcV6/isv8pOfUc4zZ8vkcb8St32iOSdf+16ADJe2g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=IOUlx3g4; arc=fail smtp.client-ip=52.101.193.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="IOUlx3g4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QZE3+n5Hiw585BTJYbgG1aavYzM9f9RGF3dzsL57/+3LLA4d+8xIRs5u+sfaLqbvMgoB9TKdBqAhli2BOw1vCUlBN2qDTtJIlwVB2XSEzQbu6KFzyVJtxEvnXh44xF1+GcR1jgSzKwxziIZD0UPf5ozHz8s0hYIpiBbdaWCVbIVmK549P1lQki4pnE1vgenOl2IGMJIdvWCU53+Am71L11ANx6Gaen7KSRuV86i3BIcja3Np62d73i+BZzEcXI3gOFwiuFByLIX76b46sKFQ+G6KN6Drk21I4hpSnRWSsMTiGamkBPSGYpK6YkxpjeWzETMtktCyvGJal6bwmRgWDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gaj+SXbPw0X29ht951pfeDodyXcwBFXH/SrrHlel0+I=; b=DsIEShol4obhQywISR99XLRn8N8UznTvgE/9T87zx75umk7Om027jtMXufmwWw3JqGBajUOgYITJL7uUGR9LDMrexxZAD0E0TRNy3HeFa6sbxtd3/FDSZK8JN1Mfb2dO3gz6CZoqpAEixGav/rXYGd/AslI3cBJWoS0QmlYaPY4gJXrMUwXuqNltgXNT4Nd5rGoOFHngJFQBMzjnwQT86FjsmAoaC1++T+xmG0QtAZcz9EgK9EC1l01VDw+tR6tItz+pZR1cX3u1tcFogy0oXd+MdRFkeKfahVndBYRRicQmlP6NgGj+60xknJSgXTzRlkqi695PAqLEcu1d15JXOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gaj+SXbPw0X29ht951pfeDodyXcwBFXH/SrrHlel0+I=; b=IOUlx3g4ijqrLcuD0PhOeWUeT0eAgeXn/G0BRHRjYqidxmCyuvkiBx/CYroE2tD5g5pijUaYLeEHUciSr9JpGDhBbOTTT9TW9L2PcArbnv1ydhVzpAZxf1J1TO9DSfbo4IlNiGBjUEDToRF0DsFf8f3Bgu2CLtBGlnI4PIpeiit0ILkiUG05FrkPD92Xd7AUIS86GkCM/yGCkvm+UH+NAVGFm8RwJmfYkMS+3+ezsGswzF49CCMskeJSxuCVLQLMC6F5Q6cOvMiBq47TGWWmpKXrSvcwmJ+o/fYcjX+KWVFih/6jZlngOForE1i9Jm5aYvD2fKRapkJ4NoDHNdP7tQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from BYAPR03MB3461.namprd03.prod.outlook.com (2603:10b6:a02:b4::23) by SJ0PR03MB6674.namprd03.prod.outlook.com (2603:10b6:a03:396::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.27; Fri, 18 Apr 2025 14:31:07 +0000 Received: from BYAPR03MB3461.namprd03.prod.outlook.com ([fe80::706b:dd15:bc81:313c]) by BYAPR03MB3461.namprd03.prod.outlook.com ([fe80::706b:dd15:bc81:313c%2]) with mapi id 15.20.8655.022; Fri, 18 Apr 2025 14:31:07 +0000 From: Matthew Gerlach To: dinguyen@kernel.org, bp@alien8.de, tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Niravkumar L Rabara , Matthew Gerlach Subject: [PATCH 2/2] EDAC/altera: Set DDR and SDMMC interrupt mask before registration Date: Fri, 18 Apr 2025 07:30:52 -0700 Message-Id: <20250418143052.38593-3-matthew.gerlach@altera.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20250418143052.38593-1-matthew.gerlach@altera.com> References: <20250418143052.38593-1-matthew.gerlach@altera.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR05CA0033.namprd05.prod.outlook.com (2603:10b6:a03:39b::8) To BYAPR03MB3461.namprd03.prod.outlook.com (2603:10b6:a02:b4::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3461:EE_|SJ0PR03MB6674:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d54747c-fa1e-41ab-6284-08dd7e85a726 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?jBsJLdXplvx2R5x+GBjUIXZD/UZIE6C88L51PKrz9mynHcu4oxg7DOasLiug?= =?us-ascii?Q?+7PEUrw9ulIp9zksuoNcQhB4QRQNMH9Mg20W32LCtZ0rJnMiqf1mUbYhrMF9?= =?us-ascii?Q?b9xAVGKOSLd3KlLZZZncGNKZ0wBXjDVwvYjd/LkvOY7B29HJDsMuW9e7adQg?= =?us-ascii?Q?5sFBwCDvHoSrYRYwSYDwSHLjKP++B1/cTzvSNRtLk2z1fpTh/S7t635WjHge?= =?us-ascii?Q?IHIC0BhbLRJ9oZP57R7DRFysK/Gon2mIO0rljBPGB75kwhl2N/y4r+J4025U?= =?us-ascii?Q?Dmmq644gMoeBOwQA5N30wqRSx3JbiWaa116ff0C2BVvjZ9VUThgs3fXq432A?= =?us-ascii?Q?D+5vja11Be313de41TqN2c4fVXhqPycHJPaFL9aZh9PUQd/xAc64UWWjfuvy?= =?us-ascii?Q?ik2zfmCC7u/d5nkfC06+EZutJtavD1JDkxiV+pLYlLF73m4gD1n9N1kXv/D5?= =?us-ascii?Q?HpQsKuNSr340wQ7pKvmS91A/yb9HGfQ/6aLMXN6Vdvy71whhsCBEYnQoRJ80?= =?us-ascii?Q?DZ23FP1bIWi3SZV2WNJ9CcI5TWzMCnKb6jpZyt4PMKoJKGeuuh8vrvhnYa0x?= =?us-ascii?Q?vAmqnjrv1A4h1FqFKALJUUyBUdyh2AKp8Rx7z90quBnIjErqwRHcAs3ZWDgE?= =?us-ascii?Q?dQyDGj3aedINE2hV0GnLMtJGdFiHs+p5KB/S4XTFSG1uETSBsCTH+M8btuKS?= =?us-ascii?Q?hdfS3D5OD/4SgN5/GXMV2gDqSOK6i36JcraPWFEOVGAjMj+QEOt6qkNg/XXT?= =?us-ascii?Q?qTf79GUIH8h5ZhtRvm7THFXadwwNNOXR/O8nZHSPb86FrcJbLw2ikJXKxhh7?= =?us-ascii?Q?KeWKnriS6AZjz30tSNrPqTrBow1xmSIhAldamiuyV6L4Csm2GZtGHqCj6FlW?= =?us-ascii?Q?/WdrCofgcUBMKpuqgP+KzN8/FvkA2jqVNXmNUDkFTMRFJD3c1nxTUE43T9yS?= =?us-ascii?Q?h0POtY7RkeEyX+wgS5BMtsW+VNBwhSZGufcexJUiitabFceylZe9l8eUfTKI?= =?us-ascii?Q?BLZZKGWvHC06eWVY/SisX6778+K6WHYnfFO17XrzepFzjnXek3H5AmJIztr3?= =?us-ascii?Q?Q9PDVQfCXk10OyPzlTd+2SWWYEvWFVOBkRfOzyW1+YR7XbT8kbvsXYVp70zI?= =?us-ascii?Q?k37kRbrzuT+HZQNVjM1zB2QdbaiwRunl5oRkROZ5fC14t6Kme833ygotSpfr?= =?us-ascii?Q?crJTQFs/cYm55fpwPkFnLr+Fbvm68hICNeCDMlbu4yRJgK6NYbdugAMp3j2u?= =?us-ascii?Q?nqqw49AikcvVc5QgbGTBNMSzWei/QVd8+WhEsAoqRt36OVamigoPCFbHfSQO?= =?us-ascii?Q?JKTzGA9Ob1IGjzZ/TkcKLMcw1ftgsQwccBjRYr5UIstr6hwB+e/NjlaRMuFZ?= =?us-ascii?Q?3b1UVip1/LVhrej3/jbN6+ixBaTOQ7K6sL8F5No7NuZkOQ1mChzFOOz+yVhh?= =?us-ascii?Q?Nk+9BsOSn0w=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3461.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SMr35D6WVElNYfXCD+HPsv7/gFGEoPXT/rAyg1qzwpf5nNmjQp+V+pDwkjFf?= =?us-ascii?Q?eNbNPqUY+GwLmzFTg8ETX9c7QYBDldIMqJ2Ao7IFMN4A5f7RdMWyl/5coXM1?= =?us-ascii?Q?WjWivRLL09ncf9cAiSaMlA2ipb3bcJMb9jpewEbMy3G+504D4EGke3zd+8Ky?= =?us-ascii?Q?OtH244CxSFH/AMy1+gS6vc2V5FZPJJbFNyo4aRJ2bVfuQuQ0dVOXlK2LtiGk?= =?us-ascii?Q?/aSsXaASootQ3edJ7LP09pOSg/SPmhALlri+/RBMENLRdjNWKxz+CJD6XSZq?= =?us-ascii?Q?1om8vw19CtG9CqLAkSwbgjcMsY4R80BLKdxiEzz0nP0zuUO5BA5V1drbTmYP?= =?us-ascii?Q?mKpNxqsLWZer09JbppqpA+6ZSX++QzCj+Ocgy7Ckp7vgN8h34Px3lVto0aU8?= =?us-ascii?Q?6zJjyZnF+9JhYwMNun9g4rSW5bM6HhiWvh1dp0jOS7yvJwQIMBqvDOq05G74?= =?us-ascii?Q?mhWsAUotGEWlelw4YuAI6JF11kI3fwmfsugEENtC7Dl56uNn4zQsgVTMd5Iy?= =?us-ascii?Q?vAnWyQIuT1P5er7EkMV6CurdK5EL9yLTdSFN6U7uc+j8GLwPYf0Y1xTvdBGR?= =?us-ascii?Q?8eM7fSmQUUhsYcJ5BMlHwlZQeEzMtESc1n+InXWqMwBa+GHRGeua80dybZ9h?= =?us-ascii?Q?hSILwa1Sl3z2OZLq9hIo9/Z3HxfttYVKphVZHAsugVJjaJ9yICr52nS1LR9H?= =?us-ascii?Q?SJOr7bW5EuVz8ZyeeRtWcOvoqNY798QeG5IjBNJSug1qI5sZk0vQomtSg0d7?= =?us-ascii?Q?G7SpdUSJnVcCYeXls1Z/RSF2nhfz5rQmPkcWvO3+6c1jnJvBKD3x0PY/kVGc?= =?us-ascii?Q?h/e/l5niDzPFgVWiR8WGiM37X9TXoPSYn4XGeyxAAYT94OFSIQTrIIJvqhRM?= =?us-ascii?Q?8/T6TqKQp/UaEIOEv8QxSB60zFRBNOJGKI/VTFZqdWhyI1Iw8/Bp1cyaBah3?= =?us-ascii?Q?6uQezscbxKBvf2ftN9Ky4Z97204KefVeFFtWla3W69ytYI7HzTW6rsWVvptF?= =?us-ascii?Q?pPYllnBZo8lY4NRp70fwt62HHgxEvPToonTMJ9aUgd0uSA0FaByUT1kpvSUQ?= =?us-ascii?Q?I0KnQ5YEnd/QKTRdTI8x7UBBwqup7obnlVyuG8Tt5AhbCaU2HObV52chdxqm?= =?us-ascii?Q?A5UDTHk5xx0xI0nH/EYTPlEm9v17RxIFLjhrGFbNDDaaIHUse69b8G0iXVj3?= =?us-ascii?Q?L14hTZz8PmQidbruJr+oYphGzsRd+vhPOei9V7DuSfdysAyRoJ2WS4p/puMl?= =?us-ascii?Q?6KepTSTnDVnrOjOiOsHSrvqjFVTwLlHQ4h/mQG356iZCX6NXLGnfMuRY+6Zm?= =?us-ascii?Q?CDFZfB5L0CZAF4nJtN/aCMnngmgkRUReU6aXmHNhk5EhUi2ahYDb0LHOnANV?= =?us-ascii?Q?Hsq6w7MuqwtTNKnXGMtcezMI1MI8UYpE9ML2qi2tvc0Y0Orbplu5CRrwkJgC?= =?us-ascii?Q?ETk5N6AYbtGhZ7TPiDDQx8caY5ml9YWdLlitX5XUPEpGR8e6/iNJW3im5xbG?= =?us-ascii?Q?XPpCqemcILDpfQSJjy782OUAadsjA4LbR+Mr3uKv0jhk8qmlQL+TK3BoQ26J?= =?us-ascii?Q?i8z+8NhvL9/T8sbvZOB+T5t7TwWSAa7daN8m3v62j6V4Opm/ZEm69fN0KtmW?= =?us-ascii?Q?Xg=3D=3D?= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d54747c-fa1e-41ab-6284-08dd7e85a726 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3461.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2025 14:31:05.7954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vZBSivwwzRnwiLft5klmxNLapvBEc2OUAL3sjyvOX1OF5cGD9rNFeVIXn0YoaLmsxnuRsu4g+DD1GkCgufBMVuJibn11Cnkpovc26eb0U6A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6674 Content-Type: text/plain; charset="utf-8" From: Niravkumar L Rabara Mask DDR and SDMMC in probe function to avoid spurious irq before registration. Removed invalid register write to system manager. Signed-off-by: Niravkumar L Rabara Signed-off-by: Matthew Gerlach --- drivers/edac/altera_edac.c | 7 ++++--- drivers/edac/altera_edac.h | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 88d9d2f458ee..dcd7008fe06b 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -1005,9 +1005,6 @@ altr_init_a10_ecc_block(struct device_node *np, u32 i= rq_mask, } } =20 - /* Interrupt mode set to every SBERR */ - regmap_write(ecc_mgr_map, ALTR_A10_ECC_INTMODE_OFST, - ALTR_A10_ECC_INTMODE); /* Enable ECC */ ecc_set_bits(ecc_ctrl_en_mask, (ecc_block_base + ALTR_A10_ECC_CTRL_OFST)); @@ -2127,6 +2124,10 @@ static int altr_edac_a10_probe(struct platform_devic= e *pdev) return PTR_ERR(edac->ecc_mgr_map); } =20 + /* Set irq mask for DDR SBE to avoid any pending irq before registration = */ + regmap_write(edac->ecc_mgr_map, A10_SYSMGR_ECC_INTMASK_SET_OFST, + (A10_SYSMGR_ECC_INTMASK_SDMMCB | A10_SYSMGR_ECC_INTMASK_DDR0)); + edac->irq_chip.name =3D pdev->dev.of_node->name; edac->irq_chip.irq_mask =3D a10_eccmgr_irq_mask; edac->irq_chip.irq_unmask =3D a10_eccmgr_irq_unmask; diff --git a/drivers/edac/altera_edac.h b/drivers/edac/altera_edac.h index 3727e72c8c2e..7248d24c4908 100644 --- a/drivers/edac/altera_edac.h +++ b/drivers/edac/altera_edac.h @@ -249,6 +249,8 @@ struct altr_sdram_mc_data { #define A10_SYSMGR_ECC_INTMASK_SET_OFST 0x94 #define A10_SYSMGR_ECC_INTMASK_CLR_OFST 0x98 #define A10_SYSMGR_ECC_INTMASK_OCRAM BIT(1) +#define A10_SYSMGR_ECC_INTMASK_SDMMCB BIT(16) +#define A10_SYSMGR_ECC_INTMASK_DDR0 BIT(17) =20 #define A10_SYSMGR_ECC_INTSTAT_SERR_OFST 0x9C #define A10_SYSMGR_ECC_INTSTAT_DERR_OFST 0xA0 --=20 2.35.3