From nobody Sun Dec 14 12:12:41 2025 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE30AAD23; Fri, 18 Apr 2025 02:30:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744943422; cv=none; b=QxkNRTe5Tm8XkP0fQtGSBAMawb05RSefR9rBnTlNd+N+4ZlYRrnYQDlvP7sGP4YKtnx395whLYDWNTitY7/EepwrYmGnHZwhstwQSaLDqD43PoTCnZD+gqvpodL2L+WKDWG14br3qQuvkz70WJTLvuJWW8Nbj0fRCOXWQKgcknU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744943422; c=relaxed/simple; bh=EF/mLJTv6gNbHMAQsAe4x40aedzcnFG52dclCJs95zI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RWimksGegiC2h1xJxQ0YXpCkXTkdnd7v82eG9OhEOQkwutTO55S0Rz0dY/Eiusad7GyCbjTfEBft++ZZzwN9LsYsD4CAn3caxtDqIX66+OSSZmhpzbl8VqrAO/zttblOVRHQ/Q+bwsDx7yTiT7SNu//Wdssy0peCZjZ9PrGPrQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f5Swf0hX; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f5Swf0hX" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-af6a315b491so1133398a12.1; Thu, 17 Apr 2025 19:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744943420; x=1745548220; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Di4XiSgh+BQAH0MOm1AlDsADVyTkQM6H/o91uhBRMnI=; b=f5Swf0hXRJIYqEWW+NTybvCvhlnF+cmDZGQ81NZy6+gXTHHRGtq8gMW49wsfADBkR7 f03To5QxB2ZCK5YZqtABXNy0wCgiDimz3wI50Bx9qcDpHy1VY9l24YfeIrlVZ2HS+uDt AK4kZNSVLjGgiBaGa1m0cIfT3sRHVVAySi5nDOD5ZAKfrsT7a3c0W7ZPVhiBd0FgRHgd iF1t3XGoD2oTEX87PED8eIMefobWwXpzOxO3vEhLqj29J+P3PG7f1R6nXptj6NsPga2o mpcOj/05ofDMudiFcUXDhkIBci2cqd07IebBBR00Yi7LdRdP2BB5FoYcy018niGo9msP fjjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744943420; x=1745548220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Di4XiSgh+BQAH0MOm1AlDsADVyTkQM6H/o91uhBRMnI=; b=G2u7aK6fB5La97HRg0TidNtF336n2MDkpLyzxiRQK+sZKypI7C7Tt9td2WZazb2TLg X1xyqENntoaiCwFWWZDTQ8VsZPHe0Uivui8RQCRSqxc/bAfGpuwjJ99CIYhzYRnW7FeB nb7aiRq/nOGlJMniJ1TTai22xxh50whVy87WMu3VhxPw7xaXI5z+5jGW4DjmshY3KziB RJhwloejgdEIuhwcNHN+Rz0VKgGA/1NW6PvtayEHMv7EgepJPIMl2FP4P11FCnTkFa0a G9mQsI5Tlu1wqAXJIbnuJerHiABWx9+cLeuoxG+sULpK/oomRvWLrCpdF+ycu7ADG0Af ffwg== X-Forwarded-Encrypted: i=1; AJvYcCUIMD2louMN6AhgwuIq2SiFZgJLaxvQm1RJcCnDxbeRDk/FS0OblZu7T2NIXjpITCJoqV8kz7wrk2v0Beo1@vger.kernel.org, AJvYcCVtlLLp9xJcmEKBT6h0LRcJ6iE0LKQxyW2HIhv43QQw1L9SiuxKsg5+kQgrYpc97waRWHhXq1IwEAht@vger.kernel.org, AJvYcCXtDDYS3Kbr9Ld1bSRckKMRpcXXKmraAZr4FzOfd/BpSE3t3vFFCQmTkv3C6SU3etr08vn5t5VHpkaf@vger.kernel.org X-Gm-Message-State: AOJu0Yz0H7E/5nH/LX+Q2FYit39KV+ro3zC8aidf4MRvpPXaY4P4U28j 9DwramdSpfKZKgziLG0zxBbze7/Hl7sZ/+EZl/g2ESidMpn/q6yP X-Gm-Gg: ASbGnctCHhT5XZeJ8uin+q8CvSWA7GIsXo16jt7i42BV3rEZtlmpp7K59yCglmpYsLo oOutuQ3bf4OaOmunusgM2z+6IZ49C2KAu1lEGhpNCf0wzwXgZnS4vaH9mlyVT+aI/V7zfq+76kY nTD3wx2mOP3XsJ9aXTGouz9UVEzbgFWb3+UQIBre7w2cCxHBbqBayBDyA12+GQ6jJ5L6J1rT+i2 r56ec5Dl8kWWCpHuQYEQSQu4sBsLC0TAPMpAKuAyKeHi+ECDL3utUUEZLgWddfmkAWR1701m/Je WVw31BUiSlJhtvgXucvrPrtU8m3E9F+hoCE= X-Google-Smtp-Source: AGHT+IHfuBCji2IgYL4qWKeIl+Mf4ci+4eN0PNXn0HQ2ZC/Ai+XLtuBn5UkQyieYdRDC8QxP4CcQ/Q== X-Received: by 2002:a17:90b:51c7:b0:301:1c11:aa83 with SMTP id 98e67ed59e1d1-3087bbad714mr1651155a91.28.1744943420171; Thu, 17 Apr 2025 19:30:20 -0700 (PDT) Received: from cu.. ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3087df0c14esm182185a91.19.2025.04.17.19.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 19:30:19 -0700 (PDT) From: Longbin Li To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: Longbin Li , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH v2 1/3] dt-bindings: pwm: sophgo: add pwm controller for SG2044 Date: Fri, 18 Apr 2025 10:29:44 +0800 Message-ID: <20250418022948.22853-2-looong.bin@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418022948.22853-1-looong.bin@gmail.com> References: <20250418022948.22853-1-looong.bin@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add compatible string for PWM controller on SG2044. Signed-off-by: Longbin Li Acked-by: Rob Herring (Arm) --- Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml b= /Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml index bbb6326d47d7..e0e91aa237ec 100644 --- a/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml @@ -17,7 +17,9 @@ allOf: properties: compatible: - const: sophgo,sg2042-pwm + enum: + - sophgo,sg2042-pwm + - sophgo,sg2044-pwm reg: maxItems: 1 -- 2.49.0 From nobody Sun Dec 14 12:12:41 2025 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A94524B26; Fri, 18 Apr 2025 02:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744943433; cv=none; b=EbvDa75dzf/P1baOhO/4RUfOspfA/TQ/hcXkz9hcqf1Uyy2tZPHShlvH3KU27F0gu8G1C9bxYTTALagIaZrK5IDQa/ObAnNESmQhUFVjthqLug90KijX/upcsLNaBr5KZPSjSDD5R+PujQpyX+kdiQXdpUNP+fo4ne6TWnmBKZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744943433; c=relaxed/simple; bh=tMjTIJgmJCvCZE08QgjAay18aUqAwDfxjinPV3iZzg4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ndV5UtA4/QSVnzs2O5BC60yEuoby3wUIA+l4XeTLY3r8Az/oZ+p1TjgizTWoTLfyRsi6vmNQGP1IwTY3XkTl5ir+cumTTgNfxFpJz+s2hMM65YnbypUMTKeyFzeh326JAnW7y2aD1vMpyKbwQ6riOSI+jrTXvTUwxMlPINI/TCw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bvZ9DQsZ; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bvZ9DQsZ" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-af5139ad9a2so943453a12.1; Thu, 17 Apr 2025 19:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744943431; x=1745548231; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w7xED7gAs7WHbJVjZWFN0lIu8Nx3/HGwmoPo1V9lNaU=; b=bvZ9DQsZ1+s8V18+1Z3MjKWJtz625zRJ6OHOf/XbECJ+/nQquLAU6S8FjNGzzPADOB bSgvufq1RbO9a/LO35knRQZ/u713/tkvv7CSS1GDsz9cW4aMZzV4SR+YN65HgkZc1sj3 CLRx8ZBFOkE9l6BDd49B/e45U2hSdoAVwK9qTAE5q2d+UJ2QBA4Ci5aoqytGSvSoGHNx asUGUrbsBEZ4UwmFF7mQcYO+2HIhnmA2EtTJnfPzvImfVUnRpXYuJy0mGau0fYnhEmq6 2xSLAG8/htpcq2IBIvLZ5BWeLWAuytAi9rTVN8f4W/ZwS5BfGOMYFvoRU5hjUw0Zb9tj Jozw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744943431; x=1745548231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w7xED7gAs7WHbJVjZWFN0lIu8Nx3/HGwmoPo1V9lNaU=; b=pArkp6feXn9QNapIo4WL8rVGapERAcRl1vvTYgfXiKpWVbpsdX42hEiPWeDpzQ2M6+ 0yZ8IYVUJuqdCtpph9kcitq3E6U/D2UM93VgQEDZz6uvpECBSQy5ejtcyRtkWvLAFtBc 6N9dPJ+F7JXkp0KCF40J4ZXKUxQlWEmBAq0xF98icz3wx5/iWPcKvv2R6kViy+l0K/GH 4GP06jkwdGoye5xUTWossJ/iCCc5JsoUENHCbwQ453b//rHYKbx8PFIbL6dWlTAFSMGO EkG7xl4qw2AtM6Az+UjsqctHbx2wWFbdd6INSPkOOqcsFfJq9c0rGZm/cWK9uqGgBF0b cNSQ== X-Forwarded-Encrypted: i=1; AJvYcCU+r7EQFDqbu7+HFeY7Yad/8paRNwb4Zc7qWIOI56uTVRJu6svO23iiZCB/ENavPK+GJ44LmjOlqTRQ@vger.kernel.org, AJvYcCU3UA2WZe3qK76ewKYw3LfZMXBoNr6V318GwAoz2oferFtedEeQGkQReasqpVur/GjWALlLwhzacQ16p3Zg@vger.kernel.org, AJvYcCXqppr8g95mRjUTdYKN5mS49NNoWccnUWeWQ9vvO+wjhdigXjyi8IvLx8J4MEc7/TIP37i1E36A87DD@vger.kernel.org X-Gm-Message-State: AOJu0Yy2xeFoU7GrMBXZ3BpjeYm3N5fZIgNpG4CXdKJ064TU66LgL+Fo 4LZnxbk2RNezUXK85VZ64kPlV/VPZiA6Oy17Ie7N7OERbxGCLJ+Q X-Gm-Gg: ASbGncsZS8LKrNuvoHZ8ZnKyTQQl/MxFgORiKaebipqUR+fLVk8rncpT7aPZxlrqxvI Ozbw6Mq8G1X3Ecm/Ga4WKpfX98dP7P9CpT/Qyxd0OOgPH8qyXqSJ+9icEqBtInkNxFX+Yqeh9fj DE6lVglNryMmpVB7AnGnX8gSiWhTf3TMDEiL40DzW0M7HypJM6oNNiTFSqw3L5NB2zpegScaCbj AbNKf1MN/R7hz2UeHuxPYOl0SUOqDUp6NH1VEyv4X6MIZIUfOfBkK2PJexF8WesGVIG09Ar9x9j 05SKy2TwE/8JV2zUHwdYX8xrDAgsRKXla+M= X-Google-Smtp-Source: AGHT+IH2LAsstNAG96JKkITo4BRlLrgS5Kv05TbZGffG83M6Np6d/MhABgYIJd/eYaTcTtT6FUSpMw== X-Received: by 2002:a17:90a:d64f:b0:306:b78a:e22d with SMTP id 98e67ed59e1d1-3087bb6a6c7mr1594737a91.20.1744943431248; Thu, 17 Apr 2025 19:30:31 -0700 (PDT) Received: from cu.. ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3087df0c14esm182185a91.19.2025.04.17.19.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 19:30:30 -0700 (PDT) From: Longbin Li To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: Longbin Li , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH v2 2/3] pwm: sophgo: reorganize the code structure Date: Fri, 18 Apr 2025 10:29:45 +0800 Message-ID: <20250418022948.22853-3-looong.bin@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418022948.22853-1-looong.bin@gmail.com> References: <20250418022948.22853-1-looong.bin@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As the driver logic can be used in both SG2042 and SG2044, it will be better to reorganize the code structure. Signed-off-by: Longbin Li --- drivers/pwm/pwm-sophgo-sg2042.c | 62 +++++++++++++++++++-------------- 1 file changed, 35 insertions(+), 27 deletions(-) diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-sg204= 2.c index ff4639d849ce..23a83843ba53 100644 --- a/drivers/pwm/pwm-sophgo-sg2042.c +++ b/drivers/pwm/pwm-sophgo-sg2042.c @@ -26,18 +26,6 @@ #include #include -/* - * Offset RegisterName - * 0x0000 HLPERIOD0 - * 0x0004 PERIOD0 - * 0x0008 HLPERIOD1 - * 0x000C PERIOD1 - * 0x0010 HLPERIOD2 - * 0x0014 PERIOD2 - * 0x0018 HLPERIOD3 - * 0x001C PERIOD3 - * Four groups and every group is composed of HLPERIOD & PERIOD - */ #define SG2042_PWM_HLPERIOD(chan) ((chan) * 8 + 0) #define SG2042_PWM_PERIOD(chan) ((chan) * 8 + 4) @@ -53,6 +41,10 @@ struct sg2042_pwm_ddata { unsigned long clk_rate_hz; }; +struct sg2042_chip_data { + const struct pwm_ops ops; +}; + /* * period_ticks: PERIOD * hlperiod_ticks: HLPERIOD @@ -66,21 +58,13 @@ static void pwm_sg2042_config(struct sg2042_pwm_ddata *= ddata, unsigned int chan, writel(hlperiod_ticks, base + SG2042_PWM_HLPERIOD(chan)); } -static int pwm_sg2042_apply(struct pwm_chip *chip, struct pwm_device *pwm, - const struct pwm_state *state) +static void pwm_set_dutycycle(struct pwm_chip *chip, struct pwm_device *pw= m, + const struct pwm_state *state) { struct sg2042_pwm_ddata *ddata =3D pwmchip_get_drvdata(chip); u32 hlperiod_ticks; u32 period_ticks; - if (state->polarity =3D=3D PWM_POLARITY_INVERSED) - return -EINVAL; - - if (!state->enabled) { - pwm_sg2042_config(ddata, pwm->hwpwm, 0, 0); - return 0; - } - /* * Duration of High level (duty_cycle) =3D HLPERIOD x Period_of_input_clk * Duration of One Cycle (period) =3D PERIOD x Period_of_input_clk @@ -92,6 +76,22 @@ static int pwm_sg2042_apply(struct pwm_chip *chip, struc= t pwm_device *pwm, pwm->hwpwm, period_ticks, hlperiod_ticks); pwm_sg2042_config(ddata, pwm->hwpwm, period_ticks, hlperiod_ticks); +} + +static int pwm_sg2042_apply(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) +{ + struct sg2042_pwm_ddata *ddata =3D pwmchip_get_drvdata(chip); + + if (state->polarity =3D=3D PWM_POLARITY_INVERSED) + return -EINVAL; + + if (!state->enabled) { + pwm_sg2042_config(ddata, pwm->hwpwm, 0, 0); + return 0; + } + + pwm_set_dutycycle(chip, pwm, state); return 0; } @@ -123,13 +123,16 @@ static int pwm_sg2042_get_state(struct pwm_chip *chip= , struct pwm_device *pwm, return 0; } -static const struct pwm_ops pwm_sg2042_ops =3D { - .apply =3D pwm_sg2042_apply, - .get_state =3D pwm_sg2042_get_state, +static const struct sg2042_chip_data sg2042_chip_data =3D { + .ops =3D { + .apply =3D pwm_sg2042_apply, + .get_state =3D pwm_sg2042_get_state, + } }; static const struct of_device_id sg2042_pwm_ids[] =3D { - { .compatible =3D "sophgo,sg2042-pwm" }, + { .compatible =3D "sophgo,sg2042-pwm", + .data =3D &sg2042_chip_data }, { } }; MODULE_DEVICE_TABLE(of, sg2042_pwm_ids); @@ -137,12 +140,17 @@ MODULE_DEVICE_TABLE(of, sg2042_pwm_ids); static int pwm_sg2042_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; + const struct sg2042_chip_data *chip_data; struct sg2042_pwm_ddata *ddata; struct reset_control *rst; struct pwm_chip *chip; struct clk *clk; int ret; + chip_data =3D device_get_match_data(dev); + if (!chip_data) + return -ENODEV; + chip =3D devm_pwmchip_alloc(dev, SG2042_PWM_CHANNELNUM, sizeof(*ddata)); if (IS_ERR(chip)) return PTR_ERR(chip); @@ -170,7 +178,7 @@ static int pwm_sg2042_probe(struct platform_device *pde= v) if (IS_ERR(rst)) return dev_err_probe(dev, PTR_ERR(rst), "Failed to get reset\n"); - chip->ops =3D &pwm_sg2042_ops; + chip->ops =3D &chip_data->ops; chip->atomic =3D true; ret =3D devm_pwmchip_add(dev, chip); -- 2.49.0 From nobody Sun Dec 14 12:12:41 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EC54268686; Fri, 18 Apr 2025 02:30:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744943441; cv=none; b=GzhBYGXfiIQ0Xg6hjhD35kxaCaoMjZ4qz7cccKcTj96aSajNeWFLyIH+VHSgxUyKedt5YmCMtNLdHUk6P7bYexhjVP86D0oNROSX0L4I4av1Fra449Qufem4vzhIs58OUCgHMlGc2p/gKIsjgmY8tbuE+938NV9cJ/78tms5atg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744943441; c=relaxed/simple; bh=F5wTWiuzfh8Tt2PQ9yfbi0SFEuZODRRM9Iglxqr2MVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZrtG6yJYUcwUuhTRUZ8MFhb4cQoF+4cj3D3krMzNRQc9g/NQUqXLchcvL8ZQW3GCzmVLFtL3EIJCBzNGG7ESV70GWBvHOmP0tvkAsp+uG8ZqbVizc5WO/INdQ1TFwLE/7HhrHk87RQPJBtrZyyqovMpK2pljBsXgLxU3mg98JFo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HTwNAO7N; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HTwNAO7N" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-22c33e5013aso18502815ad.0; Thu, 17 Apr 2025 19:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744943438; x=1745548238; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zhyHi9uQpRULTwQZULLja3qU3XsixSmtudhV3coPhWg=; b=HTwNAO7NaTjT9Do17YoR4JmtGIHtX0pPMtq9kLQMjkxOuWcuMfE/2uEQztHOhrF2nz +hifLZnwLWO0atnTdxFSGBZCTTWA06wTCMVxr9gWCIj0DV1DXlDzkkoL0G2yvub2JeNL ExcUiVWUr0rQTDeHU+Py/rIEyb43u5fQ+Qc8zCnwaY61BOTVZwHibug4HX089Dhku5nR hW7TlKDnr4x5a6cB/22OGTozQUjTA9E5T2jrrK9ChD8G3dFGevCFtF2KNv1TmRWQlufH 15aoqRuBKj3/254twwk5bOEQMnbAv05a/FuuxLuX+W6NYUA5L0TekizCAf/qh//q8I3y Zn/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744943438; x=1745548238; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zhyHi9uQpRULTwQZULLja3qU3XsixSmtudhV3coPhWg=; b=p2P7U/Imy9XV7y1ngHfBLqmS9CaQ6OwtHzVA7HVRkD6LiROs9AmIIMgEmsHv4T4+Q8 aDlGTg1zLDmnjQv2KSU8cFH6bAdILn/R+AlcQrG3tfB7hjsVRvtMFOjhD6GlqQ90vQeo njcm91dUCJQBWfglEltfcc7v1x7Jj+W6yfx5MglffV9tc+/KZQsKHRkoI24mia1El7nd FKQjbndIKwUErw+vwQVD41SlqR8TfyDpgTcPFIc3TUUj/cHrDehJkP1wUsdDFrJlkwfr s3vzvnmMXdaIXTDpLH9LkazioLazE6flDryBX4ifrnNviplI23vuR9ZPiqRIG0yqMyx4 2rjw== X-Forwarded-Encrypted: i=1; AJvYcCUhBYh++Ha4tWi5cBT/QBJSnuWy49GU0bx0FwAyN0/ihvrZg1J3H8vFPYhTPeLeDYWJUHWDWZfzP/hC@vger.kernel.org, AJvYcCVi3ZrA3v3X4cbCLN/Bc7/t1osNIWWILIcHg0UQ6T65NynN+frXKCjNfUdYys8pf1n5VWi2r1e3BCet@vger.kernel.org, AJvYcCXAaToS86btlKTDYuin7r+trZGOROdUuBwEEUTGsIqLdjDq2JrrhBiXc+pF7ockSee6iNvM80sCtFdOIBeT@vger.kernel.org X-Gm-Message-State: AOJu0Yzqm2tq9cDlSjlbhmq7Fx0ZqmpgZrd8LCbYzfkzufXPNbaDYCu+ BIQQKyN9jNjoeX2HBlAyYeNfHhF/mlxIgAg+GEijTYyZaaplOH33 X-Gm-Gg: ASbGnctxN7KeY7tEx3AQPPZpAfL83/k8PcLQr/QuPLazXnwaARizAAtMCjLHH2Slnqe 3uddyAcp/nylMYlI2mYERa/FXer1A0cdAPsauFBxkwSeMsdjVwqpIhmR1WTu0XKI4t+U4kHa12a UMTI+oPN0ClnH9ohXKE7M9sYKAIbUks3EriptXJLakBXWgV0qVF5Zifk2SazsFVEsWVG8hsF9XQ Z3E7159s35HiGGZopR647lN2Dalci9Qsi6BMrynEu4BNY/cri0SQA1bu2Af8qIzK9XUIipcUNaK +vTWYzYGlpX2spDfbhnK5GfgcVQXvL7S2fY= X-Google-Smtp-Source: AGHT+IHo/o4KQhGB66PuErDoqro0sabaeHOL40TB7KoY2oAF3V05eK3U8JRd5gLiVCzL4LU7JUlRpw== X-Received: by 2002:a17:903:41c7:b0:215:b1a3:4701 with SMTP id d9443c01a7336-22c5359b5damr16046695ad.13.1744943438447; Thu, 17 Apr 2025 19:30:38 -0700 (PDT) Received: from cu.. ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3087df0c14esm182185a91.19.2025.04.17.19.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 19:30:37 -0700 (PDT) From: Longbin Li To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: Longbin Li , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH v2 3/3] pwm: sophgo: add driver for SG2044 Date: Fri, 18 Apr 2025 10:29:46 +0800 Message-ID: <20250418022948.22853-4-looong.bin@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418022948.22853-1-looong.bin@gmail.com> References: <20250418022948.22853-1-looong.bin@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add PWM controller for SG2044 on base of SG2042. Signed-off-by: Longbin Li --- drivers/pwm/pwm-sophgo-sg2042.c | 89 ++++++++++++++++++++++++++++++++- 1 file changed, 87 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-sg204= 2.c index 23a83843ba53..26147ec596c9 100644 --- a/drivers/pwm/pwm-sophgo-sg2042.c +++ b/drivers/pwm/pwm-sophgo-sg2042.c @@ -13,6 +13,9 @@ * the running period. * - When PERIOD and HLPERIOD is set to 0, the PWM wave output will * be stopped and the output is pulled to high. + * - SG2044 support polarity while SG2042 does not. When PWMSTART is + * false, POLARITY being NORMAL will make output being low, + * POLARITY being INVERSED will make output being high. * See the datasheet [1] for more details. * [1]:https://github.com/sophgo/sophgo-doc/tree/main/SG2042/TRM */ @@ -26,6 +29,10 @@ #include #include +#define SG2044_REG_POLARITY 0x40 +#define SG2044_REG_PWMSTART 0x44 +#define SG2044_REG_PWM_OE 0xD0 + #define SG2042_PWM_HLPERIOD(chan) ((chan) * 8 + 0) #define SG2042_PWM_PERIOD(chan) ((chan) * 8 + 4) @@ -72,8 +79,8 @@ static void pwm_set_dutycycle(struct pwm_chip *chip, stru= ct pwm_device *pwm, period_ticks =3D min(mul_u64_u64_div_u64(ddata->clk_rate_hz, state->perio= d, NSEC_PER_SEC), U32_MAX); hlperiod_ticks =3D min(mul_u64_u64_div_u64(ddata->clk_rate_hz, state->dut= y_cycle, NSEC_PER_SEC), U32_MAX); - dev_dbg(pwmchip_parent(chip), "chan[%u]: PERIOD=3D%u, HLPERIOD=3D%u\n", - pwm->hwpwm, period_ticks, hlperiod_ticks); + dev_dbg(pwmchip_parent(chip), "chan[%u]: ENABLE=3D%u, PERIOD=3D%u, HLPERI= OD=3D%u, POLARITY=3D%u\n", + pwm->hwpwm, state->enabled, period_ticks, hlperiod_ticks, state->polarit= y); pwm_sg2042_config(ddata, pwm->hwpwm, period_ticks, hlperiod_ticks); } @@ -123,6 +130,74 @@ static int pwm_sg2042_get_state(struct pwm_chip *chip,= struct pwm_device *pwm, return 0; } +static void pwm_sg2044_set_start(struct sg2042_pwm_ddata *ddata, struct pw= m_device *pwm, + bool enabled) +{ + u32 pwm_value; + + pwm_value =3D readl(ddata->base + SG2044_REG_PWMSTART); + + if (enabled) + pwm_value |=3D BIT(pwm->hwpwm); + else + pwm_value &=3D ~BIT(pwm->hwpwm); + + writel(pwm_value, ddata->base + SG2044_REG_PWMSTART); +} + +static void pwm_sg2044_set_outputdir(struct sg2042_pwm_ddata *ddata, struc= t pwm_device *pwm, + bool enabled) +{ + u32 pwm_value; + + pwm_value =3D readl(ddata->base + SG2044_REG_PWM_OE); + + if (enabled) + pwm_value |=3D BIT(pwm->hwpwm); + else + pwm_value &=3D ~BIT(pwm->hwpwm); + + writel(pwm_value, ddata->base + SG2044_REG_PWM_OE); +} + +static void pwm_sg2044_set_polarity(struct sg2042_pwm_ddata *ddata, struct= pwm_device *pwm, + const struct pwm_state *state) +{ + u32 pwm_value; + + pwm_value =3D readl(ddata->base + SG2044_REG_POLARITY); + + if (state->polarity =3D=3D PWM_POLARITY_NORMAL) + pwm_value &=3D ~BIT(pwm->hwpwm); + else + pwm_value |=3D BIT(pwm->hwpwm); + + writel(pwm_value, ddata->base + SG2044_REG_POLARITY); +} + +static int pwm_sg2044_apply(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) +{ + struct sg2042_pwm_ddata *ddata =3D pwmchip_get_drvdata(chip); + + pwm_sg2044_set_polarity(ddata, pwm, state); + + pwm_set_dutycycle(chip, pwm, state); + + /* + * re-enable PWMSTART to refresh the register period + */ + pwm_sg2044_set_start(ddata, pwm, false); + + if (!state->enabled) + return 0; + + pwm_sg2044_set_outputdir(ddata, pwm, true); + pwm_sg2044_set_start(ddata, pwm, true); + + return 0; +} + static const struct sg2042_chip_data sg2042_chip_data =3D { .ops =3D { .apply =3D pwm_sg2042_apply, @@ -130,9 +205,18 @@ static const struct sg2042_chip_data sg2042_chip_data = =3D { } }; +static const struct sg2042_chip_data sg2044_chip_data =3D { + .ops =3D { + .apply =3D pwm_sg2044_apply, + .get_state =3D pwm_sg2042_get_state, + } +}; + static const struct of_device_id sg2042_pwm_ids[] =3D { { .compatible =3D "sophgo,sg2042-pwm", .data =3D &sg2042_chip_data }, + { .compatible =3D "sophgo,sg2044-pwm", + .data =3D &sg2044_chip_data }, { } }; MODULE_DEVICE_TABLE(of, sg2042_pwm_ids); @@ -198,5 +282,6 @@ static struct platform_driver pwm_sg2042_driver =3D { module_platform_driver(pwm_sg2042_driver); MODULE_AUTHOR("Chen Wang"); +MODULE_AUTHOR("Longbin Li "); MODULE_DESCRIPTION("Sophgo SG2042 PWM driver"); MODULE_LICENSE("GPL"); -- 2.49.0