From nobody Sun Dec 14 12:05:34 2025 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0792D171D2 for ; Fri, 18 Apr 2025 00:21:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744935690; cv=none; b=htDsjda8TDTV6sVBW1RdJte3surwzS2vBwPGDt6wkyn7g5J78nE92vEBdAhYRXsl8f9fKxNE0DVq2eR4jxuUpp+i7jz7MBy9X8to4sfChNWyL2ok8R7Wvo1+Ky6P9dAVMBpmfL0N1UTl3yuDkDEnvUqNyz4A5uufTO+PGLu0BzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744935690; c=relaxed/simple; bh=0Wpx4d2+yZiKkA9tDn0IJZm1Vft/zF3+F2AVmsrW4rk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UQ+0/gyBE4sRXX46OFnXptctF4ZgK00reQ/bcvgTuCoMaORUdAQHw6QbKoMbhwyxa9fk63JfItwfFKmo6ZUa7BjJl6tDvmJKBZqAh09LUB8z0/7NRyNPAS5OmEqcCUpTcOwZSnVmT8aVschGB5o7fzfh0kBHlrq0YIy+oH4JUz0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=ogchH08G; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="ogchH08G" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=n5RAqA3OL5SQ+Vv2m3AsajeMYO7tR1OhXLpj2nJvWfQ=; b=ogchH08GG7S6jGFs zZSPUt012HvnLilKm0IUmbyVAHlKlq/QbrIj6J+RV9iTovW/Ujkz6xkgbt3RsZzY7JzPzbVKw1LLZ zBGOxVZRuYfRok0OMg6qe7BysWO1K1JuY+hAdrHCyyiQfYcUOUMOVOnG6Mdq4C0jW0GYpQ84Ovbgj i3MoWUM+/vcGu/l09CiGMf2D3pN1I1zOHNxdaZoXCjZoroOIQA1UpCw/DLKM0yfpt8NYcSEAQ98hj cb9hoAJ7MdDlqfB41n14xDEwmwgdsW/Hy9HRyYjOZ5hkAjnQ1vrrBO0g/UIHZlwf8acaeoC6E+Gpg ucVqeS6KKdO4QgM/dQ==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u5ZTr-00CPl8-02; Fri, 18 Apr 2025 00:21:19 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com, christian.koenig@amd.com Cc: airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 1/4] drm/radeon/radeon_audio: Remove unused r600_hdmi_audio_workaround Date: Fri, 18 Apr 2025 01:21:14 +0100 Message-ID: <20250418002117.130612-2-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418002117.130612-1-linux@treblig.org> References: <20250418002117.130612-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" The last use of r600_hdmi_audio_workaround() was removed by 2014's commit 6e72376dcc66 ("radeon/audio: consolidate audio_mode_set() functions") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/radeon/r600_hdmi.c | 22 ---------------------- drivers/gpu/drm/radeon/radeon_asic.h | 1 - 2 files changed, 23 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r6= 00_hdmi.c index 661f374f5f27..9758f3a9df75 100644 --- a/drivers/gpu/drm/radeon/r600_hdmi.c +++ b/drivers/gpu/drm/radeon/r600_hdmi.c @@ -290,28 +290,6 @@ int r600_hdmi_buffer_status_changed(struct drm_encoder= *encoder) return result; } =20 -/* - * write the audio workaround status to the hardware - */ -void r600_hdmi_audio_workaround(struct drm_encoder *encoder) -{ - struct drm_device *dev =3D encoder->dev; - struct radeon_device *rdev =3D dev->dev_private; - struct radeon_encoder *radeon_encoder =3D to_radeon_encoder(encoder); - struct radeon_encoder_atom_dig *dig =3D radeon_encoder->enc_priv; - uint32_t offset =3D dig->afmt->offset; - bool hdmi_audio_workaround =3D false; /* FIXME */ - u32 value; - - if (!hdmi_audio_workaround || - r600_hdmi_is_audio_buffer_filled(encoder)) - value =3D 0; /* disable workaround */ - else - value =3D HDMI0_AUDIO_TEST_EN; /* enable workaround */ - WREG32_P(HDMI0_AUDIO_PACKET_CONTROL + offset, - value, ~HDMI0_AUDIO_TEST_EN); -} - void r600_hdmi_audio_set_dto(struct radeon_device *rdev, struct radeon_crtc *crtc, unsigned int clock) { diff --git a/drivers/gpu/drm/radeon/radeon_asic.h b/drivers/gpu/drm/radeon/= radeon_asic.h index 8f5e07834fcc..9e697f10f9ca 100644 --- a/drivers/gpu/drm/radeon/radeon_asic.h +++ b/drivers/gpu/drm/radeon/radeon_asic.h @@ -401,7 +401,6 @@ void r600_audio_set_dto(struct drm_encoder *encoder, u3= 2 clock); void r600_hdmi_update_avi_infoframe(struct drm_encoder *encoder, void *buf= fer, size_t size); void r600_hdmi_update_ACR(struct drm_encoder *encoder, uint32_t clock); -void r600_hdmi_audio_workaround(struct drm_encoder *encoder); int r600_hdmi_buffer_status_changed(struct drm_encoder *encoder); void r600_hdmi_update_audio_settings(struct drm_encoder *encoder); u32 r600_get_xclk(struct radeon_device *rdev); --=20 2.49.0 From nobody Sun Dec 14 12:05:34 2025 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D82D32AE8C for ; Fri, 18 Apr 2025 00:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744935703; cv=none; b=m59yoavRELpI+itBsnkHycF82rPGT3mITku4jWF0VQ15kLHbZc6yhi5y7JIxwgXVTdcRFCri6nUMc/OoKhG8j27gRIKyG2X+f9HFhMBVI7LE4C7hPUpXFNQ1SszKJsEor8FDF4a1R6a+X1OpBlBL+opYLmh2oDhBAZpl5GEWnBw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744935703; c=relaxed/simple; bh=C2kRiwkEeu4BLqFa68kaIY/QetWcXO/Y3PcQtWojE3A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MsISuQGCMH/C1AdNcVLYmIqdWP7E0kEd6B7fWtTt8sP89CWtYNmyIsuve6MI1ceXOULi/7zxSafwvE5Wpujz6v3djfk8S8mSGn4uUhmRAD5wqv+XY/Bk/fOc1/8h+uW7b2+gfkc6dOKyJbbbjV0YhQDHjL6IPcvcB2H8a6PnE7s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=Dy8FXPLU; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="Dy8FXPLU" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=c0zCwIR2YZCux8Gj1g6mDQzfRIobFooUknXOTVAhgoI=; b=Dy8FXPLUVmqWDYyu /cQtnjJXJ0JfNFYUIqbMvJGtkIZf9JCUh2s5z5qTlZWiDq0OBp65djrJVqxKercS1E0iJP7j1CnK/ YBfXi8/Kp2GYw57z1KnJL5csSHnFt8hHiZmqDX0ESiqLfdSv39Tk1uxPW+aanNEtfrQUXFuotFvL5 xV5h4Q4N9ijypOpChsF/dfMo9O9k2dTE12XIlT6as7X+Fwj75lzeUE+aWLDgVtb3QJ8cyM39Rn5AP DlbVIWEz/8dGpF3jyy6h1HHHD8u/iOy/AyU/mMgm4KNpyCQBd5f+k1jatBilhUOiQQpOjo8B2iOq7 EnOiiQxqKnFHwAA5fg==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u5ZTr-00CPl8-1r; Fri, 18 Apr 2025 00:21:19 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com, christian.koenig@amd.com Cc: airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free Date: Fri, 18 Apr 2025 01:21:15 +0100 Message-ID: <20250418002117.130612-3-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418002117.130612-1-linux@treblig.org> References: <20250418002117.130612-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" radeon_doorbell_free() was added in 2013 by commit 75efdee11b5d ("drm/radeon: implement simple doorbell page allocator") but never used. Remove it. Signed-off-by: Dr. David Alan Gilbert Suggested-by: Christophe JAILLET --- drivers/gpu/drm/radeon/radeon.h | 1 - drivers/gpu/drm/radeon/radeon_device.c | 14 -------------- 2 files changed, 15 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeo= n.h index 8605c074d9f7..58111fdf520d 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -686,7 +686,6 @@ struct radeon_doorbell { }; =20 int radeon_doorbell_get(struct radeon_device *rdev, u32 *page); -void radeon_doorbell_free(struct radeon_device *rdev, u32 doorbell); =20 /* * IRQS. diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeo= n/radeon_device.c index bbd39348a7ab..4127ffb4bb6f 100644 --- a/drivers/gpu/drm/radeon/radeon_device.c +++ b/drivers/gpu/drm/radeon/radeon_device.c @@ -392,20 +392,6 @@ int radeon_doorbell_get(struct radeon_device *rdev, u3= 2 *doorbell) } } =20 -/** - * radeon_doorbell_free - Free a doorbell entry - * - * @rdev: radeon_device pointer - * @doorbell: doorbell index - * - * Free a doorbell allocated for use by the driver (all asics) - */ -void radeon_doorbell_free(struct radeon_device *rdev, u32 doorbell) -{ - if (doorbell < rdev->doorbell.num_doorbells) - __clear_bit(doorbell, rdev->doorbell.used); -} - /* * radeon_wb_*() * Writeback is the method by which the GPU updates special pages --=20 2.49.0 From nobody Sun Dec 14 12:05:34 2025 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078FD111AD for ; Fri, 18 Apr 2025 00:21:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744935691; cv=none; b=I6/2Btc0B1RDqKDAfqXlbdrntT0ipOIGR/+rZUPqnSo9SJrRoc267Y4cZQ2I0473Q43Untm4VJyNMCD7iiZ7wk4yEYLlSPY10YC1+NG0WUz3N9KEKCaZ+P4cRgAWdxJxj1WG7XKb8zPbAiUdckxb1U/JG1s4qbxD+Xy9UkbvSwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744935691; c=relaxed/simple; bh=0sROsm3KVeR8i200Dj3W33GKwp/PGaioQ5a58mawwcA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pAy3OKFx1XKkDvd2+UzQgZ86GSWDGWOKsFXwAGs5Cq2DRxzl9tTpbW1CY6InZEW/A57hjPh8edzakQ2tEGp1vUGuP6czjqIuGLvMMETk4notqbLBjTOY5Tfq1dRhQYYIxuflYzpdAxFHO60+4XfyjLxk+eF2PY9lesXE15+GRZo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=Cfl1PH6V; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="Cfl1PH6V" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=BecQJkrNlQ3akqTLtmWZkyczre6xMs/aCGibLOPB01w=; b=Cfl1PH6VxrumXzxO FIJ7mklfUDbioGEtV/c74t5Kh0ODglK+4khCKmzxcSRuQgejcLuwvef8X8JbH+UOEbMr5ETgBxATX kXYwbx4QiNiFtIXbFa/TOAFxT7Z9EiYeYvaC8ru/4vyMPof/wHsB1+Ha8VXow+Fv27I6areuggdrw tsYYmnA6tTnPEJUHG0lfzaYf9QVIMumpQjqz5ampkkbcDVI/qJoY22Y4PV6G59sTY0Ha7jlufCRhw RI6zwZi6KqP2/Nt6LvRQmh4fcuz/Hkb/tQarPZvxdjdhAhzi7x5H9TaqPN5bm1XSCiTuTu79nJ98Q 26rQzRn9klPVN058HQ==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u5ZTs-00CPl8-0H; Fri, 18 Apr 2025 00:21:20 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com, christian.koenig@amd.com Cc: airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 3/4] drm/radeon: Remove unused radeon_fence_wait_any Date: Fri, 18 Apr 2025 01:21:16 +0100 Message-ID: <20250418002117.130612-4-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418002117.130612-1-linux@treblig.org> References: <20250418002117.130612-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" radeon_fence_wait_any() last use was removed in 2023's commit 254986e324ad ("drm/radeon: Use the drm suballocation manager implementation.") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/radeon/radeon.h | 3 -- drivers/gpu/drm/radeon/radeon_fence.c | 42 --------------------------- 2 files changed, 45 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeo= n.h index 58111fdf520d..53f6378b6db6 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -394,9 +394,6 @@ long radeon_fence_wait_timeout(struct radeon_fence *fen= ce, bool interruptible, l int radeon_fence_wait(struct radeon_fence *fence, bool interruptible); int radeon_fence_wait_next(struct radeon_device *rdev, int ring); int radeon_fence_wait_empty(struct radeon_device *rdev, int ring); -int radeon_fence_wait_any(struct radeon_device *rdev, - struct radeon_fence **fences, - bool intr); struct radeon_fence *radeon_fence_ref(struct radeon_fence *fence); void radeon_fence_unref(struct radeon_fence **fence); unsigned radeon_fence_count_emitted(struct radeon_device *rdev, int ring); diff --git a/drivers/gpu/drm/radeon/radeon_fence.c b/drivers/gpu/drm/radeon= /radeon_fence.c index 8ff4f18b51a9..5b5b54e876d4 100644 --- a/drivers/gpu/drm/radeon/radeon_fence.c +++ b/drivers/gpu/drm/radeon/radeon_fence.c @@ -574,48 +574,6 @@ int radeon_fence_wait(struct radeon_fence *fence, bool= intr) return r; } =20 -/** - * radeon_fence_wait_any - wait for a fence to signal on any ring - * - * @rdev: radeon device pointer - * @fences: radeon fence object(s) - * @intr: use interruptable sleep - * - * Wait for any requested fence to signal (all asics). Fence - * array is indexed by ring id. @intr selects whether to use - * interruptable (true) or non-interruptable (false) sleep when - * waiting for the fences. Used by the suballocator. - * Returns 0 if any fence has passed, error for all other cases. - */ -int radeon_fence_wait_any(struct radeon_device *rdev, - struct radeon_fence **fences, - bool intr) -{ - uint64_t seq[RADEON_NUM_RINGS]; - unsigned int i, num_rings =3D 0; - long r; - - for (i =3D 0; i < RADEON_NUM_RINGS; ++i) { - seq[i] =3D 0; - - if (!fences[i]) - continue; - - seq[i] =3D fences[i]->seq; - ++num_rings; - } - - /* nothing to wait for ? */ - if (num_rings =3D=3D 0) - return -ENOENT; - - r =3D radeon_fence_wait_seq_timeout(rdev, seq, intr, MAX_SCHEDULE_TIMEOUT= ); - if (r < 0) - return r; - - return 0; -} - /** * radeon_fence_wait_next - wait for the next fence to signal * --=20 2.49.0 From nobody Sun Dec 14 12:05:34 2025 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FF5D1C683 for ; Fri, 18 Apr 2025 00:21:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744935690; cv=none; b=NhBbjXj55wB7kJJ18PDBrr/zy+biNbs5I9JBUPJG+NCNoM4scq71DQy8GGNgb8lbWu2XOQH9Ed2yT+CjPa3ncMIUgWDTFUpub1rNc1kfE7SECpM+zdC4aNARXyJBj1x3KVCX1EibmuxG8qb6K4OfW7OKr77vbES0mkyoAeLN1/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744935690; c=relaxed/simple; bh=gnnIfdiwHlkKcaUwXxH/tTmPzWY6vMempO+KOJemrpo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DBmm74g8Xv6HlerLaHjVHMn2XdEcicsCOOmDl7IUVquO01wwSYnMps7yZw6mCJnJA/zk/jR5+MxfIjB2cMVeXwYo7cn2lsoo+z0zrunWaQlrTN9wC9jtOaRqIcTE5hq4jh2sG4+G7vrEGl2P8g9YxB6hFu/H/TE920dqdB6JOEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=V+mlFev/; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="V+mlFev/" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=JWaJuUILM6oT7h2bYPl+DblVz8tBnX1vWlKCjgjjAiI=; b=V+mlFev/tQR08iOt l4CHM4vKVEMrkXqOh2LgHoGlWXhrsa9FG8dwd8w50J8XFH+v8EecLBppSTSdX3UNf8Cp0tEK6yf0e 1j/3UsGTJQ1A04qYIHloInUmqAP2npzINkVUf815D+dTxtf5coLSoo1FnmBNBeR+LjUbnLzYh/3l5 Ls51VlQ/FHZh/7hUApoiXS9pnbekLxXzuaRMkKbSbqavvtC4DJ1906AWpN/pJgsTOnCB8sYNPWWJu leSkJsX6a/dxNn9yszezGavztYO6LfLwY7Mp2ZhLtzI2NMp0SUQ0uKZwskcCOzTHrvBg1ZS+STVxS T+1Kk2T381FUQM68tA==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u5ZTs-00CPl8-20; Fri, 18 Apr 2025 00:21:20 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com, christian.koenig@amd.com Cc: airlied@gmail.com, simona@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 4/4] drm/amd/display: Remove unused *vbios_smu_set_dprefclk Date: Fri, 18 Apr 2025 01:21:17 +0100 Message-ID: <20250418002117.130612-5-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418002117.130612-1-linux@treblig.org> References: <20250418002117.130612-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" rn_vbios_smu_set_dprefclk() was added in 2019 by commit 4edb6fc91878 ("drm/amd/display: Add Renoir clock manager") rv1_vbios_smu_set_dprefclk() was also added in 2019 by commit dc88b4a684d2 ("drm/amd/display: make clk mgr soc specific") neither have been used. Remove them. Signed-off-by: Dr. David Alan Gilbert --- .../dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c | 14 -------------- .../dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.h | 1 - .../dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c | 14 -------------- .../dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.h | 1 - 4 files changed, 30 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios= _smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu= .c index 19897fa52e7e..d82a52319088 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c @@ -142,17 +142,3 @@ int rv1_vbios_smu_set_dispclk(struct clk_mgr_internal = *clk_mgr, int requested_di =20 return actual_dispclk_set_mhz * 1000; } - -int rv1_vbios_smu_set_dprefclk(struct clk_mgr_internal *clk_mgr) -{ - int actual_dprefclk_set_mhz =3D -1; - - actual_dprefclk_set_mhz =3D rv1_vbios_smu_send_msg_with_param( - clk_mgr, - VBIOSSMC_MSG_SetDprefclkFreq, - khz_to_mhz_ceil(clk_mgr->base.dprefclk_khz)); - - /* TODO: add code for programing DP DTO, currently this is down by comman= d table */ - - return actual_dprefclk_set_mhz * 1000; -} diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios= _smu.h b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu= .h index 083cb3158859..81d7c912549c 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.h +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.h @@ -27,6 +27,5 @@ #define DAL_DC_DCN10_RV1_CLK_MGR_VBIOS_SMU_H_ =20 int rv1_vbios_smu_set_dispclk(struct clk_mgr_internal *clk_mgr, int reques= ted_dispclk_khz); -int rv1_vbios_smu_set_dprefclk(struct clk_mgr_internal *clk_mgr); =20 #endif /* DAL_DC_DCN10_RV1_CLK_MGR_VBIOS_SMU_H_ */ diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_= smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c index 23b390245b5d..5a633333dbb5 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c @@ -164,20 +164,6 @@ int rn_vbios_smu_set_dispclk(struct clk_mgr_internal *= clk_mgr, int requested_dis return actual_dispclk_set_mhz * 1000; } =20 -int rn_vbios_smu_set_dprefclk(struct clk_mgr_internal *clk_mgr) -{ - int actual_dprefclk_set_mhz =3D -1; - - actual_dprefclk_set_mhz =3D rn_vbios_smu_send_msg_with_param( - clk_mgr, - VBIOSSMC_MSG_SetDprefclkFreq, - khz_to_mhz_ceil(clk_mgr->base.dprefclk_khz)); - - /* TODO: add code for programing DP DTO, currently this is down by comman= d table */ - - return actual_dprefclk_set_mhz * 1000; -} - int rn_vbios_smu_set_hard_min_dcfclk(struct clk_mgr_internal *clk_mgr, int= requested_dcfclk_khz) { int actual_dcfclk_set_mhz =3D -1; diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_= smu.h b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.h index 1ce19d875358..f76fad87f0e1 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.h +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.h @@ -30,7 +30,6 @@ enum dcn_pwr_state; =20 int rn_vbios_smu_get_smu_version(struct clk_mgr_internal *clk_mgr); int rn_vbios_smu_set_dispclk(struct clk_mgr_internal *clk_mgr, int request= ed_dispclk_khz); -int rn_vbios_smu_set_dprefclk(struct clk_mgr_internal *clk_mgr); int rn_vbios_smu_set_hard_min_dcfclk(struct clk_mgr_internal *clk_mgr, int= requested_dcfclk_khz); int rn_vbios_smu_set_min_deep_sleep_dcfclk(struct clk_mgr_internal *clk_mg= r, int requested_min_ds_dcfclk_khz); void rn_vbios_smu_set_phyclk(struct clk_mgr_internal *clk_mgr, int request= ed_phyclk_khz); --=20 2.49.0