From nobody Sun Dec 14 19:34:37 2025 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2046.outbound.protection.outlook.com [40.107.236.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66D17227B9F; Thu, 17 Apr 2025 09:31:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744882313; cv=fail; b=tUNbpAMKaEMQ3gpSxe395s0nH2LStIi1K3jrofzDquVkM9ZKt2iLX6pdoj+6W0USqjz/RIK4G/C1c6xJtxizT+l9wjrrxn35Wit7fEBCiSHBk6tltlPMUspiLBjZJnjh1zAleEudAOlGlhl5TmQ4m8+lOvo3aupMMf8mYXoDe6A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744882313; c=relaxed/simple; bh=BP51ViC1bD50nt8v9h33KXrDqK2nJxIqH3zJTiN6L3M=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pp0SUxKcg4vfTgtqpeO4PDKNAlu7v+tcSJMoe47MI1bm9YNNnIbcEuay/OEG/Myd8QFOw6qy5QTsPK9QlIlSeE5SMja2f1+T9UEiPcvahPArTgF9+IfDbreTqWLseab7Ixo/0tn1FEoQZBo18pklsOhIw0wv5d82CsADkzTEnYE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Q2Xe8TVe; arc=fail smtp.client-ip=40.107.236.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Q2Xe8TVe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dlTwxbcHL3nV279URatqvrrPgF1gA+VvmuzAyhxy3S+w8Fo8VY8gr/4E2pEGYfXtz7Diau1qqrmhUDdTMpSElsRnDwVQh907ZOKLB1q5ALp6hZEmFB/mdSNZlBILhcqGnpug6A5wSnuETlcCqR3pi2vM2gjbPTdP0fDOoxkC3mXmHWNHPoCRe9usE42nzWMMHvRNzeXqujTSIQBZ+kopkx3Dv1PFzlip0WpZBXEhvB5UPw1QRlAUYqgrf8/ia6Hw4l0i8vEFbznF4IquZYrNKrwVjIYYaFSEMUKVKji9sTSjY7+FXBI0+E1UDaAHXL0GIbilEyILJzHAt+eea2l38w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uylIS/TL1JsJPqEnaYIRyaa5f28yxZdHl868qrc3SQ4=; b=BMgVp6sc75yqjJd6edx7otMITirF4FY4eYJnJobNCNbKDx+pn8nr3tLAUzkwPxcHj0XxYojDvvdLyxJW79KsdkQz32cwOtsPa3pfHfuqMx/u1/53U/PpBpL/wFrwlvQ6dbquS/qzlxOYqnDS4tW/RBU7luYvt9VzF4C90ya9MlaDVkqJFUX4/2H1aY2vkR7rvVXDPkLXhRX4TIwkP43X7SPf0toauaLZlNwscn8rO3RPm6opSXEa3QnNNjLft/uMj6hPDs5JJoZoxnzhsgsig5g6JbEFJAgv3Tx6aMt1w80pMVB7MVsfyQujOoJzh6UjwcxwibmMMkLtNGuIZNDoYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uylIS/TL1JsJPqEnaYIRyaa5f28yxZdHl868qrc3SQ4=; b=Q2Xe8TVeezdHB7bCX+c1a96zgDgkH617WubELdlc5UyOAep0bpD+wGkl/e7AZJ0hk7EUK7IqYqtF1aGbxWOYoA/3Vw9dy2fQHj/mOKvXd/zxzqr4sMZQXYTnV0B27NLC3DNhJ6PD9OEJXHo1ycLUldb80+UGEDg3A3Lme4f2GTnacW5dZE2ftBQv0F3ezHChwmwu5McUG4j7uPGhdkIpmcyolSppStZf3Zh7DCrml+7tdPm3v/SJpZ40zs1o2OAM1RI6PCBlNj9WfrQp14XnZHlWLnE092VkXAZfC4+WOQ3uNk8ij66kRd/dyp/wdYEbTuDMrKE4jgx6uWkAXaQuQw== Received: from PH8PR07CA0001.namprd07.prod.outlook.com (2603:10b6:510:2cd::26) by DS7PR12MB5910.namprd12.prod.outlook.com (2603:10b6:8:7b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.32; Thu, 17 Apr 2025 09:31:45 +0000 Received: from SN1PEPF0002529F.namprd05.prod.outlook.com (2603:10b6:510:2cd:cafe::fa) by PH8PR07CA0001.outlook.office365.com (2603:10b6:510:2cd::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8655.15 via Frontend Transport; Thu, 17 Apr 2025 09:31:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF0002529F.mail.protection.outlook.com (10.167.242.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.12 via Frontend Transport; Thu, 17 Apr 2025 09:31:44 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 17 Apr 2025 02:31:29 -0700 Received: from robelin-Precision-3660.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 17 Apr 2025 02:31:27 -0700 From: Robert Lin To: , , , , CC: , , , Robert Lin Subject: [PATCH v4 1/3] clocksource/drivers/timer-tegra186: add WDIOC_GETTIMELEFT support Date: Thu, 17 Apr 2025 17:31:08 +0800 Message-ID: <20250417093110.2751877-2-robelin@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250417093110.2751877-1-robelin@nvidia.com> References: <20250417093110.2751877-1-robelin@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002529F:EE_|DS7PR12MB5910:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d7a7764-3872-449b-ddae-08dd7d92ab65 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?o+t4HZGwkmuAtSw9k2HkR9PDdCsN4SiV6C8JkZdRPJkrbVDUlHMqRWH2VwOF?= =?us-ascii?Q?IUND03gfOT/ki0UrB3lbXpPClqIIyZIXgI19enjgAgJORysdTKkvjn9OVvy7?= =?us-ascii?Q?nkyRGC5q5fkYP0U33CwGE3C4UtoZb9TlwKX+w5TcWPUMOYsfjCmQwSQ+xK+n?= =?us-ascii?Q?EVykDF6re/G51YW1jp94pYDrCEQ/1Jpc4GJ3AGChlcZ+JBAsSJ1v/wssS+5B?= =?us-ascii?Q?Fs5qwq2X7FHxUFP6G3aC+2IzE46iMMweVyXq5+c+LhdoJSWl4KuOaLdI0ajI?= =?us-ascii?Q?taMcJOaiWxRmbSD+J6vXGfnEWkKX8g0/lGrmw4gRdU7EvIFSfZL8y064Reyc?= =?us-ascii?Q?b6ARBvyZj2RIV8wVuCvwP9DCWhfhVYRGwp8RKI2z+MtVVgTqpn6eugxoSuii?= =?us-ascii?Q?6rBfsxLvaopCriuvQaCttMM5/Z8OvSy7zX/RhtoRqGLPQ7y7eXu9ZdWfdxX6?= =?us-ascii?Q?jSG5K01EFI8RqysiWizZcWB8GDLTbt3r4intYCRAzGVLEs4uhCAfwo7SVRnw?= =?us-ascii?Q?4poe62+pOH7jJKaBJr+/S5Tds7ZIrJ3O3gTNmdPGd8fzgF59R1x1hk1rI4rl?= =?us-ascii?Q?XecF8Fa7x+lDnK5UHPAJks+z3pELrHNpGnTKY4obHRwLOJTxtlVK9xHAHhWL?= =?us-ascii?Q?0Ka+I0iQffsGhgsTJuq3C6LwJCJhpfiYnWjjBj5tU1eYBN9du3m0XADeF7ZD?= =?us-ascii?Q?gt+EOhZE1z1NEiVXgKB8aSwYYB/sZlWZbFu1OZ74lfA/jzoDODq3rebLUKe+?= =?us-ascii?Q?0FQIDbytP0YEnqPn41kNlLOqNm9KRmnSo9NIExItJFOa9+PYiVGNxJATwnPD?= =?us-ascii?Q?QZsmy5YKvWADpNWXdAd+wzUaMMF6S6H2IQLizxLNYvsJGVzEc6CHfJubvruj?= =?us-ascii?Q?dK0PiO1aXj1CSH/4bDDsQDb1jFjm6KgygPCtE4ea+F4UI5tVW1y0/K9DyadP?= =?us-ascii?Q?ay2HaxqTyg4EhM9aTtVm2dR+iNTXQv/ftub7vR5HSCrmMatIN/cfiJEv572y?= =?us-ascii?Q?qNTQh1WcbaMJ9R8KKDyAgmiWhgFWyPBuHAFu0bY/MmPPhqNFSnasfdBkxu5J?= =?us-ascii?Q?foEbsk3r6377YRfFgPukQp7vmQBLQK9QrXRAz12x0yydI/FnYt9MGwWkJ5oT?= =?us-ascii?Q?Ho/ag/tMxxUO8CRY4MPvCAQ7fjWPdvJ8hT+lE83kb/tV5uuQpiR+PwLYOsQz?= =?us-ascii?Q?q0fAQtqlyAFK96ErC6MdmfR8iNDonZhqmqnarEQIjJLksAxfGvJGRaEe6dTm?= =?us-ascii?Q?qcxW7A5xqepmdgfDIC1aLzd83WHxuVbUXw3PU3rjsQzdFKEf+Ef9zx3t5Y/I?= =?us-ascii?Q?6Bhkf1BfgFBN/l5CtZ/V+E8imiu5EOZM3nmZOI5ym53kzsd5Pz+FFVR7CC/n?= =?us-ascii?Q?vFliVn499ARkVsk4sJ4O7VRxaZrkMf84l6SydBZDEBZNtNt5vZYT06/2vZaa?= =?us-ascii?Q?X/Qo6FpymRfeByuKwH3LWoOTujTz6H5aeRuPj8WsJAsSDA6tqQehRr2Di/TS?= =?us-ascii?Q?PplBcJQdO2sF7bjHiMSbs1qqseAK9x95m/DF?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2025 09:31:44.9349 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d7a7764-3872-449b-ddae-08dd7d92ab65 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002529F.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5910 Content-Type: text/plain; charset="utf-8" From: Pohsun Su This change adds support for WDIOC_GETTIMELEFT so userspace programs can get the number of seconds before system reset by the watchdog timer via ioctl. Signed-off-by: Pohsun Su Signed-off-by: Robert Lin --- drivers/clocksource/timer-tegra186.c | 56 +++++++++++++++++++++++++++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/tim= er-tegra186.c index ea742889ee06..201b24ca59f4 100644 --- a/drivers/clocksource/timer-tegra186.c +++ b/drivers/clocksource/timer-tegra186.c @@ -1,8 +1,9 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * Copyright (c) 2019-2020 NVIDIA Corporation. All rights reserved. + * Copyright (c) 2019-2025 NVIDIA Corporation. All rights reserved. */ =20 +#include #include #include #include @@ -30,6 +31,7 @@ =20 #define TMRSR 0x004 #define TMRSR_INTR_CLR BIT(30) +#define TMRSR_PCV GENMASK(28, 0) =20 #define TMRCSSR 0x008 #define TMRCSSR_SRC_USEC (0 << 0) @@ -46,6 +48,9 @@ #define WDTCR_TIMER_SOURCE_MASK 0xf #define WDTCR_TIMER_SOURCE(x) ((x) & 0xf) =20 +#define WDTSR 0x004 +#define WDTSR_CURRENT_EXPIRATION_COUNT GENMASK(14, 12) + #define WDTCMDR 0x008 #define WDTCMDR_DISABLE_COUNTER BIT(1) #define WDTCMDR_START_COUNTER BIT(0) @@ -235,12 +240,61 @@ static int tegra186_wdt_set_timeout(struct watchdog_d= evice *wdd, return 0; } =20 +static unsigned int tegra186_wdt_get_timeleft(struct watchdog_device *wdd) +{ + struct tegra186_wdt *wdt =3D to_tegra186_wdt(wdd); + u32 timeleft, expiration, val; + + if (!watchdog_active(&wdt->base)) { + /* return zero if the watchdog timer is not activated. */ + return 0; + } + + /* + * Reset occurs on the fifth expiration of the + * watchdog timer and so when the watchdog timer is configured, + * the actual value programmed into the counter is 1/5 of the + * timeout value. Once the counter reaches 0, expiration count + * will be increased by 1 and the down counter restarts. + * Hence to get the time left before system reset we must + * combine 2 parts: + * 1. value of the current down counter + * 2. (number of counter expirations remaining) * (timeout/5) + */ + + /* Get the current number of counter expirations. Should be a + * value between 0 and 4 + */ + val =3D readl_relaxed(wdt->regs + WDTSR); + expiration =3D FIELD_GET(WDTSR_CURRENT_EXPIRATION_COUNT, val); + + /* Get the current counter value in microsecond. + */ + val =3D readl_relaxed(wdt->tmr->regs + TMRSR); + timeleft =3D FIELD_GET(TMRSR_PCV, val); + + /* + * Calculate the time remaining by adding the time for the + * counter value to the time of the counter expirations that + * remain. Do the multiplication first on purpose just to keep + * the precision due to the integer division. + */ + timeleft +=3D wdt->base.timeout * (4 - expiration) / 5; + /* + * Convert the current counter value to seconds, + * rounding up to the nearest second. + */ + timeleft =3D (timeleft + USEC_PER_SEC / 2) / USEC_PER_SEC; + return timeleft; +} + static const struct watchdog_ops tegra186_wdt_ops =3D { .owner =3D THIS_MODULE, .start =3D tegra186_wdt_start, .stop =3D tegra186_wdt_stop, .ping =3D tegra186_wdt_ping, .set_timeout =3D tegra186_wdt_set_timeout, + .get_timeleft =3D tegra186_wdt_get_timeleft, }; =20 static struct tegra186_wdt *tegra186_wdt_create(struct tegra186_timer *teg= ra, --=20 2.34.1 From nobody Sun Dec 14 19:34:37 2025 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2044.outbound.protection.outlook.com [40.107.101.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75AFB22758F; Thu, 17 Apr 2025 09:31:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.101.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744882312; cv=fail; b=QEcT30OsW/P0cLVni4iDIOLYUwOUz6DkLTlUEgYS3CuHtlM2LO8Du2m4XBc2uH9x8F0RF/xkXk6DEtBWhdO8T0WOzwexviD5gQH50qHD0+tL5EH6q60fpnNQBsVg9iGhaZTXTFtuWpxH8jvWMvW1VjuDoqjivAtLA29SCRFIMUM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744882312; c=relaxed/simple; bh=xZfz5FAwK66wEUeYCsxbiBimCpTD369bxTfjwf6/mow=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pflCgnAvf7BnniffEJSmEoryZJGV1gkVVzDvRKiX2g92qVxL4lADmMQf+36QDnxdupjMYZXDRA1TlePOupkstdIj12UojvEfsVuhci6JQBAAcRQ0LFoLCZ80jT7xGE1osyhI69L6JXqFJYsjpG2/7T/BWHzSwjxDqD7Uai5wf4U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=AC7FIsgm; arc=fail smtp.client-ip=40.107.101.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="AC7FIsgm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iW12oxUVQyajP6oDEEcZIfhhCLsBl52dzTIP+BvQqLo4aF3RCO1+tIlAWuRwJcP+yT4EArvVGn5rxQBuD5VDxcNeUP3DessPwAXAPx26he/+DYH439ieeH5GANqZLFQmtmybyGnal1OqTkDawxSqL54cuTZP9iNvUsGUODBdjw9TAZ7cW1QmqfaP5ANRg0HX93bXXJWpY2Zd0ASlP5KWUjq05iHLGkp2bCmd1ngRiqCl7d+vzK5HpogT/1HCaBkKFpI4XeFNbgcD0gcf6UMlGR/5kYvz2IIBjoAbf2MAUhJfGQ1ZXZosg/GPhsbgiGEM05OBzG4IpH0MKG3ZfZhQ2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BppeThm+uNCh3mivB476OHi5m4/YPuG0/1YOsR/ypVU=; b=xTM8/yJcDFGr6dBiKI228vBc592dL2jL6hvPEOuteJeotR6Yz0lW6TuRvux9n1ZqXRsloBETL2GfW5aoOcqY4/4C7E8dqkudF9s4x8Kpor65XKceJtQQUuSbE2q4GPVddEziJxOZmRLDGj6PG17ijJyaySqSS1OBtW00x7fI1tHfYHK02J3dM7fm3qLRRn+TD1GR9VktLnO2+T+JSGSURQ6TlbHJ1LhONqsuGIsBbliuy3GLHoDiBHdyKSlOa8ZUrvSxoesJMptfdV2EBwsaz17fFqfe12HBFNmcv64u9pVDFjnzfkRSH2xqY4Sgi50ANj9/UvUxDkeA5xYlp4/cWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BppeThm+uNCh3mivB476OHi5m4/YPuG0/1YOsR/ypVU=; b=AC7FIsgm5w3H7HszuLNjUX2RyesDolnLEcs5j49ncmugHQ7PR2r97kM/PweE82c/g7vkxM7cVv/G66wk/CYJO4is6jb8pwPvuXhlNobcPda/jP87XBQoNL29rZRXILTQRp4afHlGyEf2JpOkRRxM6hkKC1ZyIhXnFrR6VyeGMx5DeqijtmPpusAVZ4gBxrER9/TiDuO/kwIFQAemn/JfFXHFGCBnvxUrW6VFN2hBXgQfDUJsQlY9sxghEs7fipr0XOtlAiqq7dUEdwb/15NCoNczAnz3v/dF0a1pGGgS2PtU41gTX4QESuqXB3WQP3CkuNbZxRdIaeOHiyRwJ1rSQA== Received: from SN6PR16CA0041.namprd16.prod.outlook.com (2603:10b6:805:ca::18) by DS7PR12MB8275.namprd12.prod.outlook.com (2603:10b6:8:ec::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.33; Thu, 17 Apr 2025 09:31:47 +0000 Received: from SN1PEPF000252A3.namprd05.prod.outlook.com (2603:10b6:805:ca:cafe::dc) by SN6PR16CA0041.outlook.office365.com (2603:10b6:805:ca::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8632.34 via Frontend Transport; Thu, 17 Apr 2025 09:31:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF000252A3.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.12 via Frontend Transport; Thu, 17 Apr 2025 09:31:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 17 Apr 2025 02:31:31 -0700 Received: from robelin-Precision-3660.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 17 Apr 2025 02:31:29 -0700 From: Robert Lin To: , , , , CC: , , , Robert Lin Subject: [PATCH v4 2/3] clocksource/drivers/timer-tegra186: fix watchdog self-pinging Date: Thu, 17 Apr 2025 17:31:09 +0800 Message-ID: <20250417093110.2751877-3-robelin@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250417093110.2751877-1-robelin@nvidia.com> References: <20250417093110.2751877-1-robelin@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000252A3:EE_|DS7PR12MB8275:EE_ X-MS-Office365-Filtering-Correlation-Id: e7110b2c-9c6d-4dc0-1c36-08dd7d92ac65 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?btcqsjDCMQouFafsyhxaKKvw5K/oi2qAH4S0LONDMEKZvuMhGxJkMehkpouz?= =?us-ascii?Q?JAnAqRBFpjHX5KQesrLiA2EMBwMDsQHGjot+GfWG5bJb3InMWpV71N+wczyo?= =?us-ascii?Q?Nz0N2NDwM9Qqbyh1xIaqYtoZzlMaTzrJQtcUyOZeennLt6jkIY+hNVVEBCN/?= =?us-ascii?Q?FqJP6eakAmZHcg3TXJOR1GBaWWxpBal8h1JcF8OxvgFMls750nHpDOeMj6RV?= =?us-ascii?Q?aWJpGz8xUzR0ZcxjmUhPCsSmjPJSFmxGkJ9amIvF+RLitlfqezzU2foKkfFi?= =?us-ascii?Q?P/rzyD/H+++CLX1Ecpx0ZLpB86d2p6Y4IGo0jxYbTXVyHCow/q5aCUrfbtDb?= =?us-ascii?Q?WKLvaWzn7TPMuOzUXJrNkkWEn4My0gdtcSmHbV9kEutXNQS7agOKI2xgQQoh?= =?us-ascii?Q?g3FDfRAZok1NRCO7/CVWyvxZ8rNTU0iQoIAmwRgwTg/66w+ZM0ep6Y7FSQ2B?= =?us-ascii?Q?oj7kH/bVCj9fgYZfK48ASQbcxGSCpDCdfTrXLZCnSBRm1bGUBJoFauP/MYcu?= =?us-ascii?Q?HGvBqNXSKWu6CJX6rpOLmNwm7+UjH/RuRVdUbv3JWVJlJjgrXZ+wAQYfjZoc?= =?us-ascii?Q?7bsCsNuvw/I9qp3kzht4gSOEy/POGodxJnGrWF6Z9OIIg9hEuCgQTi2ce1qn?= =?us-ascii?Q?SPdXtPI5SM39r3aB1BG9IaWVExEcknts8iSqlB5XEcf1IHTkAqrRQ5V2Px/c?= =?us-ascii?Q?1vn3pWkfqP/XSvdMZIsz9hOWq+EVPmTHWlaNtjFjMMT/txLqntClNtJ44IME?= =?us-ascii?Q?4KD+MMyt4zDAiSy0A8OUXIvTiN+nQDNTQc9oZScPSZWUPfG0dCydW5fyieTp?= =?us-ascii?Q?rlqrnCe9+6GXztjj/58HOaYyEQ3ydicJ5+hW8rfeLv79pTawahLy4q0CmSrE?= =?us-ascii?Q?feqFLZjixpKDVYVAkhYS41Ii8cPL1rhBTBitoA0LpSNp1IptGXfDxZL4JJbg?= =?us-ascii?Q?pWcc0vjWz5zSQS3/75VqIph1B2iRmBIQSbPMtdIzvQWAlN9X+nccvojWkxoB?= =?us-ascii?Q?qMrc+Hkm5kKqh5rid2jhTPH3/p0CrMPMWIV5dGdn19BqAWqzjgrnl00VZXOl?= =?us-ascii?Q?u/JHRRAH2RcUyN9ZHz9lRCzP8EmEHYq+VNNNOLGNyeaOzrk99kBQaCjvxn/o?= =?us-ascii?Q?I8Sfvv7CmmcyLj9qTh+gn5/0PxS9jY+SR1xUCJUYPyAKFpzrvjceLIfjxFus?= =?us-ascii?Q?NEMczQQwLCLnb7G3ToxSNlxMGz5rA/M2nuh87htqDW3pKEdHdAf+3qGasSOp?= =?us-ascii?Q?dJV2sB6pg2fjR/lcg1kLgNhOJCLQFePcReYVSzT5u0i1x53ip+UTlkXz5lXO?= =?us-ascii?Q?a9uGSextYFU1PohgUe/jUxQtkkiET5wW2DPv3SySocc5vaMjlguaS+xia2Tj?= =?us-ascii?Q?l/ci02A/2hwVvo7/GauNTz7tuvj2AaduYk1KkowBVrhmhZXOs2dju9iAvL4W?= =?us-ascii?Q?Z5i+H6KMGS764esNEt17GdXyzXt/AyZtXEpQ8MNKWiUmP05asVAa4SVzkcq4?= =?us-ascii?Q?d3abPLthR5eSXAz+YCFvDUycQ1T6LMjDuXUl?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2025 09:31:46.6076 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e7110b2c-9c6d-4dc0-1c36-08dd7d92ac65 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000252A3.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8275 Content-Type: text/plain; charset="utf-8" From: Pohsun Su This change removes watchdog self-pinging behavior. The timer irq handler is triggered due to the 1st expiration, the handler disables and enables watchdog but also implicitly clears the expiration count so the count can only be 0 or 1. Since this watchdog supports opened, configured, or pinged by systemd, We remove this behavior or the watchdog may not bark when systemd crashes since the 5th expiration never comes. Signed-off-by: Pohsun Su Signed-off-by: Robert Lin --- drivers/clocksource/timer-tegra186.c | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/tim= er-tegra186.c index 201b24ca59f4..708d9f8682ea 100644 --- a/drivers/clocksource/timer-tegra186.c +++ b/drivers/clocksource/timer-tegra186.c @@ -175,9 +175,6 @@ static void tegra186_wdt_enable(struct tegra186_wdt *wd= t) value &=3D ~WDTCR_PERIOD_MASK; value |=3D WDTCR_PERIOD(1); =20 - /* enable local interrupt for WDT petting */ - value |=3D WDTCR_LOCAL_INT_ENABLE; - /* enable local FIQ and remote interrupt for debug dump */ if (0) value |=3D WDTCR_REMOTE_INT_ENABLE | @@ -420,23 +417,10 @@ static int tegra186_timer_usec_init(struct tegra186_t= imer *tegra) return clocksource_register_hz(&tegra->usec, USEC_PER_SEC); } =20 -static irqreturn_t tegra186_timer_irq(int irq, void *data) -{ - struct tegra186_timer *tegra =3D data; - - if (watchdog_active(&tegra->wdt->base)) { - tegra186_wdt_disable(tegra->wdt); - tegra186_wdt_enable(tegra->wdt); - } - - return IRQ_HANDLED; -} - static int tegra186_timer_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct tegra186_timer *tegra; - unsigned int irq; int err; =20 tegra =3D devm_kzalloc(dev, sizeof(*tegra), GFP_KERNEL); @@ -455,8 +439,6 @@ static int tegra186_timer_probe(struct platform_device = *pdev) if (err < 0) return err; =20 - irq =3D err; - /* create a watchdog using a preconfigured timer */ tegra->wdt =3D tegra186_wdt_create(tegra, 0); if (IS_ERR(tegra->wdt)) { @@ -483,17 +465,8 @@ static int tegra186_timer_probe(struct platform_device= *pdev) goto unregister_osc; } =20 - err =3D devm_request_irq(dev, irq, tegra186_timer_irq, 0, - "tegra186-timer", tegra); - if (err < 0) { - dev_err(dev, "failed to request IRQ#%u: %d\n", irq, err); - goto unregister_usec; - } - return 0; =20 -unregister_usec: - clocksource_unregister(&tegra->usec); unregister_osc: clocksource_unregister(&tegra->osc); unregister_tsc: --=20 2.34.1 From nobody Sun Dec 14 19:34:37 2025 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2077.outbound.protection.outlook.com [40.107.92.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B5822A7ED; Thu, 17 Apr 2025 09:31:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744882316; cv=fail; b=AapiWR4C8TojKPo2Kzn4vC8kHn9jxpALWqM1awIMhh3482uXNBDLpuSL2ZP9ASJpSfzYW2YNoz7D9y7M6JJZHQxSNa4LgRQTrW0X+v5YSqfSe8gAqHWxkiJuu+siMwE92zoiZGCPjxcQXKBGXu5tIX98zIopVtOGpT1Oc0ye4xY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744882316; c=relaxed/simple; bh=8wODaiLMYPBK6J65EJWHa/0sK9fxUXBZItHBLW+DLV8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GBbYJEo2d2/7BY8cz6yW/BtkKSQm94YFlwPvK+gDKyYJFxwHNOMgS41GIcUjk8jdfeLv6rjao+ksu+jXqKj6B/bZ+Q3ShRPzstRy9C14MDUqBI6RkuJ1MGqcRzsRp4hFAUnkVLWTbH/dGb0K4YdiA8+yUK2p5k3o1ziYJLWlmgw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=n/zrVRoG; arc=fail smtp.client-ip=40.107.92.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="n/zrVRoG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PnBV825+wRTnyqsD+ALkGHY//eV7NoMd5SggaqIdTFNNlLqCC2/b35PCGfQYHbTlPb65XUi0eT0fMsYUu6vIpcoTqXIZuZxoJX7gwkS2hCGkMo91Mbn0CEpHSMO+JPk6QzjUicHhQiIqjqt92f3nR7aJBZM0LvVBv8sTV4Ivm1bzcUQHGEoqkVZBF82QYzj9A74Q0WXjQL19e9hdjsqy+gfRs86w5frVvPrnByReOjCjO46osB6CsUTv4kc48qKllaYKlRidTVsob4NLLP7eUW3gRGPWeGT2MwovDTBUijHkA8lsmnLJoXaNcK1oN/fnrZeeRQdwz0Auc7fDOYXUww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZsKDdRv+yPN5oywjRmMj9hbVlV6R0jvxAKmUgubQwGw=; b=M/uapIB5j9G0woJ4lENOTS8jVlVrTH8Hj2qa+Bz1Mvlt5zTPXZiQOrqGKWygXwKDqsa/SaD1fCnFM7SqEH0o8cgAr76qDGZDQzo0C6gx6rQ74D/yXmim9X2XmkvVeSmfDF79ZbQSyU3Z/nsr3XTEjk6duAch1uRhLMbnqUqXF8xxxyRTQv5YUkXrtZzOJrmpKrrHbHT2K8OcCvYCJZn6d67TS2IIs8CrWMcCTY3IYLGxuROXEMTHUF071tXdh3ZgSplcqrX546bxtnwoFLmN44vpF+omcE98glY7+fIe4ZlvLPI1xZzwOBOhJu6zApCsobUGsRkNMrp1Vzjfc91NeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZsKDdRv+yPN5oywjRmMj9hbVlV6R0jvxAKmUgubQwGw=; b=n/zrVRoG8jGjZvblc6XsAulCmTH62Cs4RkogtwuuOZIX8v1eQEg6oMcfP+MnpHrD9hj/9wGv4pccORbGhrKT9Zn60oN4/GOrwX7YpPXWKZJafl/yyPH99h42Mzy7+1VnbsxummbIJY71fIPUQts9pOuiJdyvd0KCjlXbKcHGMoGUnV0oWG2NuegfLenvl+C5A34NmjJ79z47l+AWa8sPHuomwLibBKfQOBU20aY5I0rrj6msPH+dZ3MiMfnJKCe/plCMJfiYuGBT+U1+151hc2BnN1LusuInx21G0jKUgcZiCQ1m2070PMRwr04NdTasvJcu6qiV4Q2eN8P9rul5Xw== Received: from PH3PEPF0000409C.namprd05.prod.outlook.com (2603:10b6:518:1::48) by MW3PR12MB4410.namprd12.prod.outlook.com (2603:10b6:303:5b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.35; Thu, 17 Apr 2025 09:31:49 +0000 Received: from SN1PEPF000252A1.namprd05.prod.outlook.com (2a01:111:f403:f90e::4) by PH3PEPF0000409C.outlook.office365.com (2603:1036:903:49::3) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8655.15 via Frontend Transport; Thu, 17 Apr 2025 09:31:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF000252A1.mail.protection.outlook.com (10.167.242.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.12 via Frontend Transport; Thu, 17 Apr 2025 09:31:49 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 17 Apr 2025 02:31:34 -0700 Received: from robelin-Precision-3660.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 17 Apr 2025 02:31:32 -0700 From: Robert Lin To: , , , , CC: , , , robelin Subject: [PATCH v4 3/3] clocksource/drivers/timer-tegra186: Remove unused bits Date: Thu, 17 Apr 2025 17:31:10 +0800 Message-ID: <20250417093110.2751877-4-robelin@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250417093110.2751877-1-robelin@nvidia.com> References: <20250417093110.2751877-1-robelin@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000252A1:EE_|MW3PR12MB4410:EE_ X-MS-Office365-Filtering-Correlation-Id: 8176a29c-4ca1-458f-4212-08dd7d92ae06 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?fRt3YowmtnNMDFsg0z124Mtuvmau03ygdyE/El3yQB0YykoRrrbpvS9dqcUa?= =?us-ascii?Q?DKrVNLgaBpxRP05SSaYl4NbStlKWLN7U7W71RzbmQJCrFlrSdfNDB3otSoNv?= =?us-ascii?Q?vfcnxG8NVIrPcagg02rq/x+BThfCA6nLE41+Ql0szJ/RuTGIYJxn1MRapRpr?= =?us-ascii?Q?8c3spBdhfy371dkawXAK5Cv3C83gIvIkk5yk9caiBFuwLbpb9ZIJudKrmWOk?= =?us-ascii?Q?CBLOrc8cOXiZslrwfVa7aZi6jgvZxWCA5ttRct+sHRnjUmrFRJDwm3eNvcXK?= =?us-ascii?Q?sA+2+6zzszl/qfalYoZmTOspY1g7fjHxtMAFkcHGQpCXnDrpyVn/5YFIo9je?= =?us-ascii?Q?v/qzz+D3W9lnpDCYnK1Oz2GXDzLnvl5CJQVdFyVrfBFf0J2+Ra7ws9KDd4CC?= =?us-ascii?Q?OMSWV+z8i0ri+uGUoPbQoMdTyIoCbXH0Oqf3oFfpniNZyvK7AbCBZ9yl1Ovq?= =?us-ascii?Q?fbmWkiildwdT23fZco9u0MOanAS8P4zv9ZTitX9yXP1Zmc5sJIo2ZkQAfzLX?= =?us-ascii?Q?jP2vfuPzWSyi7HOI9Ux/v/Xob8W+F11JgZcNBNt7Y8lxwP73pkNYk5xiSzsB?= =?us-ascii?Q?bfwbbyHP4C4ZeTBFiQFgwvHLAi3SDSImjTPmyRhpWke5abmy1KUzg0KUVPOX?= =?us-ascii?Q?FjobeB5Z2K4bP+wSii/DQWCyj1bnfWsFddEcIck29kBZ96PNc1cLKT5F46tH?= =?us-ascii?Q?YRM4E9TADSOcWV2iwpGu5BdMGej0lgb8njXQQjJKcVqXlFLoEeS4xsWg8hV3?= =?us-ascii?Q?8H2Y9bpTggZcprW3cAIvsKG3qpBzydE+GFvvAnTdPWVy5vl9TBvqGvQM1Bn7?= =?us-ascii?Q?gyfQqVvwpO1uc0pAC66NOjJDfxVh2VqNwAmFSvYFGO3OeZqSnWk1iObwOTu0?= =?us-ascii?Q?uTuPhAN1XIjKlNhH0kxog5oIlB69yt4PsXVQwUzcPcWoqJbRn3MsPGiPs8Zt?= =?us-ascii?Q?i7Eew6Ur2ou4Mdvju9gQ9hO5WAkBnGbwvfcFxJPi2a/d+NzqbCs4ZUQqljJG?= =?us-ascii?Q?ZYEKNOz3Am6A4QFYcAmZ7e6tycf2V3UT0sDKQ5CR1Jj1+US5me3OLelAt8WW?= =?us-ascii?Q?X/ikq/DkTFrzpHEZXQngIKxbH4L21lIIndgQN3+1gFvTQ/4H1kKqE9hJNSvd?= =?us-ascii?Q?h58jp3p18rqbaWvYYEnOIPlB22SlpRl5CTjeZcESBYVxE+KFi3lhmhiGO/rc?= =?us-ascii?Q?FADKLt7JdsFCcbfE5oS0Zy9dPZseqj8964ouEAbC3lka3qzm8AQzW2qh0k5D?= =?us-ascii?Q?kD8JYTfEAp9O3eAJhtshuFdTJtmwvpe79EK5vWbklVZPHqXyjWt93wWY2w4j?= =?us-ascii?Q?NRB2Dm0Xwsm0VAZ+u5lPo11tjiKuSMz2jJmDgx4MkX7P7iEfZGlpcPzcfWjg?= =?us-ascii?Q?00k/7lrrOjxVVwNNoedujWN4fSm9uicSkd5HweNr/eVnXxyS4xtrgnnir7hv?= =?us-ascii?Q?cwHThKaMXnf98SZR50mOJ1JugBtMjtagY1QTee5yVbmkPnTEEKczbl5KqkV2?= =?us-ascii?Q?YyXItC6MW7910NCQhjo44WHNye0uBVyiTnxw?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2025 09:31:49.3415 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8176a29c-4ca1-458f-4212-08dd7d92ae06 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000252A1.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4410 Content-Type: text/plain; charset="utf-8" From: robelin The intention to keep the unsed if(0) block is gone now. Remove them for clean codes. Signed-off-by: robelin --- drivers/clocksource/timer-tegra186.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/tim= er-tegra186.c index 708d9f8682ea..a52b11b05934 100644 --- a/drivers/clocksource/timer-tegra186.c +++ b/drivers/clocksource/timer-tegra186.c @@ -175,15 +175,6 @@ static void tegra186_wdt_enable(struct tegra186_wdt *w= dt) value &=3D ~WDTCR_PERIOD_MASK; value |=3D WDTCR_PERIOD(1); =20 - /* enable local FIQ and remote interrupt for debug dump */ - if (0) - value |=3D WDTCR_REMOTE_INT_ENABLE | - WDTCR_LOCAL_FIQ_ENABLE; - - /* enable system debug reset (doesn't properly reboot) */ - if (0) - value |=3D WDTCR_SYSTEM_DEBUG_RESET_ENABLE; - /* enable system POR reset */ value |=3D WDTCR_SYSTEM_POR_RESET_ENABLE; =20 --=20 2.34.1