From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC39F145323 for ; Thu, 17 Apr 2025 00:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849972; cv=none; b=oH8S1TQNw1B8jnC+kc6kUmvDd3fgh1So0Yqs2N9znWChGwuQq3bcpf7nRWDag2saBt2vHp7xtLMGiv5InIZVrxyKB/umZJqk8jcVG9ZAxcWbpYvxOt7ar1VvviY+w58gjbSSOwi1/uft6mbtZkGc+TO+lr5zlg6EqVQSkbaQRTU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849972; c=relaxed/simple; bh=uEoHmC4tV4NU9qt0IQ4+gbKy6BRGh5IjnM1E3Q6wo9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kyL7GmCBH+pPADpar6/ivr+8VUJc2buCkhV9ohb3QPZwfQUpznB3UoNYDhQ+pdu3cwTQjPhiAsoEPZzaH8cMkDjU7CcYGWD4O4jwMyPrCTgiwQ7xSbVYsAABB+DVH+9IxEp3fQBpJHR6EsDUYSWVgOqsxugR6J7B+lvLf5LlIWY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=HVWv5iug; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="HVWv5iug" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-306bf444ba2so141868a91.1 for ; Wed, 16 Apr 2025 17:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849970; x=1745454770; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2n8F0kDNjcDIJbaag40zmW3Ovg/wUOWV+XY1ifN82lo=; b=HVWv5iugzJho2QDSqlhtj7PmrCzLhiwFNeoNp3m902KsawQs3sfz0WgA2c7h3KUztd pgHO5ceTTZ+kaATSAcz3dbNa1eX9o4nBifPKlFbzXqYrqhcZ5/4DVWTdgriyDWAIdiZR hp6sXoMeewlcUbYIMjepnPa59Oh3sb7Z4pekE4ZsrFJQTA3LnnPNCyZkmwM9cFfKO+S2 BZxQjC6X6JuSMQOLfFhPVuGzclfGzlw+Cx7eJTSRPyE5LGZTpJJ1hpH9KKC0idqr6r0I 4jB3XTlPZQI5RbXX+GQPI2ZSkvlTBLMXmEJgCotVwl5N06G+QUYKJzdkmQcHWJvSuivg GmcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849970; x=1745454770; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2n8F0kDNjcDIJbaag40zmW3Ovg/wUOWV+XY1ifN82lo=; b=Ri6oLDyyH9acagMIlrF27moKT1ct/XLsbJ75vi7xmScBtMjr+9sV9r4UiJO8JH0qeB Ga71fD8ckZOqHGjBV0rzH3GMoOO2ozNCM4qfPYh3KL7G7PeZuCrZD1dGp7AFxN+WctoM vpgvJa24SpoYt+nGGAejpRzjuflWBudXfDN+gnfMvd+//JEqrkIUMJSb5a+Mx73/Pf9B IBtjrE8ftsSr0lgRjL/UuEH7gVk2XlijETJVorOAEE1/0u71j2QmrU+lH7jo1uRe4tVq IsHVgTRkrR4px0e133ekuxgrxqGzerFwC9iE/YKrRhAzcmyEY3xKqA83CcwzvsVgKJk+ vj6g== X-Forwarded-Encrypted: i=1; AJvYcCV1zoumSMud3BSNeKMdQRVV7HvUddj4pE/JmlN/liDkT7mvXPOuteqzIh3suPsWw5MX+eqRaNUSeeuX6yo=@vger.kernel.org X-Gm-Message-State: AOJu0YwndUiW1tTQI3vYbDSje4kkaWlcrM4+2OiuSPcDW89Gjk8Oam4K lxL22b1sce3jhB/ilkkctaQiIdc/fbn/6Wz5CzzqwYKK7y6pcQZfUPixLuSTp+FKtw1VlLnDD2E = X-Gm-Gg: ASbGncuqEFYMGxhBIYqS6PIRcb/cocuIzOl9y2mqhVX1huZYLdTGtQXyJSJ4qfgbp7O ZuiA3zzU4+kt734/GnQn+xPtBLtIdhJuCzCO2/vWzuT8Xw70u3BDS3BPCdxrcFPbAXiN49xOD6f 7bkGJsZq/OKndNE2MogwkGIPJgo06tcPR0i+CXYy5xjVIs0jcXj5obSJXZyGFmshivzmXTOeTOD dzI7w4KfCCElWZVQ52WB+rWntkMTFL5ZDwwOBy1De5YHWFmWu6tnkkYT+3cjFX6ytexEibvwJ95 +opls4BqPvFwN1ihCGk6FGFnyRx5gfEvIER08QgdynQ9X9NBQ3OTWpucicpDNshw2LYjdC5dyn1 5U4Xd/g== X-Google-Smtp-Source: AGHT+IHQX2aEg8gBZ1hKj7ZpuoyTuAr8dI4SZEWszwz0A4CFXYXv6Te0FytWNllT9h8Uj82vv40iOw== X-Received: by 2002:a17:90b:1f8b:b0:2ee:c04a:4276 with SMTP id 98e67ed59e1d1-30863d1fdbamr5387736a91.5.1744849969912; Wed, 16 Apr 2025 17:32:49 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b0b220cb76fsm1564801a12.30.2025.04.16.17.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:32:49 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 01/18] staging: gpib: struct typing for gpib_interface Date: Thu, 17 Apr 2025 00:32:29 +0000 Message-ID: <20250417003246.84445-2-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" "Having the word "_struct" in the name of the struct doesn't add any information so rename "struct gpib_interface_struct" to "struct gpib_interface". Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpib_types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gp= ib/include/gpib_types.h index 2d8c05d1fd4a..712987ca139f 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -22,7 +22,7 @@ #include #include =20 -typedef struct gpib_interface_struct gpib_interface_t; +typedef struct gpib_interface gpib_interface_t; struct gpib_board; =20 /* config parameters that are only used by driver attach functions */ @@ -51,7 +51,7 @@ struct gpib_board_config { char *serial_number; }; =20 -struct gpib_interface_struct { +struct gpib_interface { /* name of board */ char *name; /* attach() initializes board and allocates resources */ --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0CE3192D83 for ; Thu, 17 Apr 2025 00:32:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849973; cv=none; b=cqyzlaQmH2e3qXtOvGOo1wCTTYBroEdQOkH57BKwgbIRcJv7Jzd4EROkxx0QlEtWQ3i+WHp8uacgemKMqus7pTMeR4V264IVXZ8B2XmojnEj5INjVl2BO81xbawveYUaLx9TY/Onah9bHfPhP31oMlLlsP0vo/NhLlC1JhdrbEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849973; c=relaxed/simple; bh=TRUv0Lx9qIYRkHYXYiephf2tTbsRuyIpmQ7XTHKKyrU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W+UIpJz1HY3pIgeTYlKengC2ogYLj3QBEGtlc0BvESAL2qpyRDxH8A1s2mipBQLaCXdiLAoveqGUFy6E38P3f3qWhrR2wZEVDoK+iEiN2eD/AZJXLrphcSX84N9yb/4jP9Z2IFRTlBQNiD/ltp/uY04ii9RreI9h7voKcufCRXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=AVgQWXU7; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="AVgQWXU7" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7376dd56eccso197678b3a.0 for ; Wed, 16 Apr 2025 17:32:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849971; x=1745454771; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dsbToqR2eAba/23hpGloCvJcl86xogM+KUwP2i6K5Dw=; b=AVgQWXU7xuJ/p5gFQklt96uPyfY7F4aSCebvtni59O6LIEbNyrbT5An6r1WXW0mVx/ qwQOkjTtXO4FjMm3PfjjdLEPDCOIN0z6KB/YxIoxnRFbHJEoTPh5amX2kaVMHabmPClb Z0lpM+fw3iF7OZBdQkDT8GbHqJOKl5xU4+ImsyOzEIGAUAuSXXbgduyAoLWFB1uUMTAS sj8sEZb1F1FF5TYdsnyCMnu7mV6nMaJUrVn8avNul7fEk7NqnELbTuRX75y6+Tp6vCAr 0cmQOSF1yb8XWc45pp9/BP3UdYvhmBJ1qj8uiknEN7Yroujc2ksPReQ5YHThkaRmR8h0 AkNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849971; x=1745454771; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dsbToqR2eAba/23hpGloCvJcl86xogM+KUwP2i6K5Dw=; b=IV8o0Pm5fnp0orCS0IjXxQjdTYsmkiGsPSYxfKb/+7MXCxAVbCGYQqcE5SHJO5lQru SN/U6YaHmu1GsQ3+Y5ZQiz1jZ85ZD0ZuBaN1hh3axK+lF56TKpIAWbEs1Jj+8YYidAJj GuN+sheSG6Hg7WjTfpPNZjyeo7bXp6KZ+btwJjAIpX8XhWgyI+BJZjYEz4HTtE/I9mwL J87CR7reGSxv+TcbofPTf7W+E+p/t8PthExYprehm9MUlFkzEnelmW0IHlZBYG68lDQK zq7dni48lpjUgCDTY8Cy7H87kI4nNvM7SHdLDU+ffeZlNZpsGBdwjPy46Y7V/oHTqwCh xcbQ== X-Forwarded-Encrypted: i=1; AJvYcCV+uAbb4KxnXv/p4Ib9mN/Rl1VLaa7UjWtx/QnT62KtC8IG6IR7C2Lco9LrwPbBh9ogJhknHDEcGlvKEk0=@vger.kernel.org X-Gm-Message-State: AOJu0YwO2ACMxiu4x6/VcffmzaP5eVn7JR/e3tyeVt/UAeNL6IqH9xYZ 4eOG/3YLBEXOmzY72yqYANK2pC6A2TSUvyh9hHrwpUpKc44LhDTJ46AGxF5y6CQmsm+UjVBFen4 = X-Gm-Gg: ASbGncsbjXr3eAE5AYwRQ4D3EzYFrKGBQeQ7eH1wQn3E60zWO8RWWs+yfOXq4QNpNgK s+BHsHPhHRonfX0enTiSVXAs/7WkCl/uxydGbb07hS6RkcBeUUx5znoqKGlWNEpOwbGuAnyrymG ZtKZrfa4yxifAvr8hshq6cqHN9iE/zmNSZd+FFOJJvv15a5y45nWgLQSbXHmC2biMX/xECHMyYW RujnG1MZM28ewljlx5xSnDgjJtI9yDyv3zpU0EOUF4Dw/TZybS+7ec4Pu3sM/TSg7ACIyjMvoQo MqFlOLXbpgEfUHI0tUaS2f/t/DnhsdJrXQ6SiQrB9lcgb1ibEScaklK6ztgVhnBG3u6dJy+PmWF SypM8rA== X-Google-Smtp-Source: AGHT+IEzGyc78qt3I2Ea9h/ua6Bmt+3aTG77DQd6AZy/bfiPA5+q0GqkntNar2iof23jKJEGMNEiZw== X-Received: by 2002:a05:6a00:aa8d:b0:736:5dc6:a14f with SMTP id d2e1a72fcca58-73c267f5570mr5754297b3a.23.1744849971084; Wed, 16 Apr 2025 17:32:51 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b0b2221f01fsm1875561a12.74.2025.04.16.17.32.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:32:50 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 02/18] staging: gpib: agilent_82350b: gpib_interface Date: Thu, 17 Apr 2025 00:32:30 +0000 Message-ID: <20250417003246.84445-3-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 97717afbb214..901f7182502b 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -773,7 +773,7 @@ static void agilent_82350b_detach(struct gpib_board *bo= ard) agilent_82350b_free_private(board); } =20 -static gpib_interface_t agilent_82350b_unaccel_interface =3D { +static struct gpib_interface agilent_82350b_unaccel_interface =3D { .name =3D "agilent_82350b_unaccel", .attach =3D agilent_82350b_unaccel_attach, .detach =3D agilent_82350b_detach, @@ -801,7 +801,7 @@ static gpib_interface_t agilent_82350b_unaccel_interfac= e =3D { .return_to_local =3D agilent_82350b_return_to_local, }; =20 -static gpib_interface_t agilent_82350b_interface =3D { +static struct gpib_interface agilent_82350b_interface =3D { .name =3D "agilent_82350b", .attach =3D agilent_82350b_accel_attach, .detach =3D agilent_82350b_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0554619D08F for ; Thu, 17 Apr 2025 00:32:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849974; cv=none; b=TEnVqu3VmHugDvAtDSuD01g2LLDF1z63qg6xmddf1bYbCng2Sd0UeAR9/kBByVvRW3AJybAdJgQWpbcJ4B/rdclTDzWREDABFyAEAAcOb9cXPDZ4AU/kror/E98fGDFXK4KkQrGStWbWGh7zCXDLLMamtaAph9BoxzjeJ1Qz4gA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849974; c=relaxed/simple; bh=9qC6SADjVBvrGdZqgD61dD4ij9DtU63SWTFy4hBsTVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RH34aLCLtLbraqnakqE3jDM0cIYwMrxEPKkfQ0jnzohOLSWKhp//ufcAPkooKldLVb+2+QzvmBQflPJ8VuIBk1LQq58Tp0H3QFuGC+YAMycN+v+PaQYfxs8iQBGa9JQlwGw6Y2K9zUi1NhrazGW6WARtNGmpbk0181iAs/gq8ck= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=EwXy6fRM; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="EwXy6fRM" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7376dd56f8fso216834b3a.2 for ; Wed, 16 Apr 2025 17:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849972; x=1745454772; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WSCp68TzSTwAIQNUn8peisTtRZqQcqQfdhU/AvOcNRM=; b=EwXy6fRMh62avihKCO4W3+4YpZ8NSEYfPwkrB7A5ktvTtZustKNDTQJ43Ufs3wJIEF 986PnsFH0TmDpqG1Qav1jH+UqsCiTbhclfxL4iLlyfoal7NA3MwWmpwRwmGH4cWqB0g9 V+X3gyXryPYmt+wHE5mr3wSXW9FbHbqYEOpmE2Rd9L9RrgVCnwmf7jX/knNHCx2CGIRE 7BJGdSctm2/Ik2PTww3k8eJahjI18sa9KQEpCsyz3vLEeyPiG+aJ0WzNLAReO1zFrMsF mj09kEmTzr4BImS4eTcc+5XmcVTycyBBxR7JetWuMx+7E0D/mllc+4CP+Z9rypZwESpi jGwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849972; x=1745454772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WSCp68TzSTwAIQNUn8peisTtRZqQcqQfdhU/AvOcNRM=; b=ccZ9MXAAobIOJjvL8CNSgX0UQ/DEJ7XnxytyCG02DZgAenbZwedvRXQlaQ12lAamDV lWr9fuoC/MUiQNkWVwPRGz613bfv+gd1VLXLlI9JJYK1hDWYTZAbuEXQzX4dyRvXDD15 1pioKR6xn7c5oE1BCpVLbRfyT8Kk66HUnUZ/FJM+thcAh7K6rDBl+XkXAyjjOTO88WOP v2L6WqhkZKy3PmSQS/emYCXQWIF+ZswGNKkzYG+Xp+OJfgzaBlxmQvdE4GGJhkztQJrY jYGTs2Sxy0n1ipwfehOJCrNaVR18MS/hGlqiIauJ7sNKXCz0bt5aSTigcqws7m4CjCU8 I8zA== X-Forwarded-Encrypted: i=1; AJvYcCVmlqBfstN++bGThhXiFaopfOPO5/bAXwk27HvZr9priEXGnkdU7DKAy0QnYIvCBs27xNLQlVI2TTf3dho=@vger.kernel.org X-Gm-Message-State: AOJu0YyCNWaYXG2VJNpFmhU0+6N72SQ9yQoZ+Zuykr5gAO0JNoZuseIG SdJlvgKInCueUYAiQ7+F1zPz3CaUVCaNWtxRSSV5+q+UMWasBR4o1q+7JjzEow== X-Gm-Gg: ASbGncvYEwTNpR3ln22la3DkO7AppGmzo74ti7nGvI9kFPKpF4vj9RbioPnuDDttBAg d/HsCKcfFcDbHTbF9p+nrDxfJYo7j5StVDTixuJlUF9nB2C+sukbqnCMzKU+zdSeNN+nqQehy0S 86NUXI81SNrhMg0vEwStgy0flCukztlCX8jR/DhH8QHEtsTbhLbcOASYQ2djuMpIOMtRvgy3LqN FXHYDbN27QtlyMQTVQSzku9MVmIalzfsFDSXvJrpnBnTDNjQbOaFXtdHFn6BeoFYfQDZCXoFR7G u658iWsQJYDBGFvZgzoCPWiqFRQ4d34digPkxhscLg+aYX/jYrQJB+4qZFF48PtSKKTxqVl2J8z 4T0NZrg== X-Google-Smtp-Source: AGHT+IHj2i15EYTCpVnq8XJ+QWcgY36lBAVDCzPpKYIxC0Qq4MKiJiwczINEofcKe1ulTXvKThGFfw== X-Received: by 2002:a05:6a00:710d:b0:73c:3116:cf10 with SMTP id d2e1a72fcca58-73c3116d5f5mr2140061b3a.23.1744849972222; Wed, 16 Apr 2025 17:32:52 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd21c4e69sm11430781b3a.53.2025.04.16.17.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:32:52 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 03/18] staging: gpib: agilent_82357a: gpib_interface Date: Thu, 17 Apr 2025 00:32:31 +0000 Message-ID: <20250417003246.84445-4-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers= /staging/gpib/agilent_82357a/agilent_82357a.c index 7076e9f57d69..9e41fe611264 100644 --- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c @@ -1434,7 +1434,7 @@ static void agilent_82357a_detach(struct gpib_board *= board) mutex_unlock(&agilent_82357a_hotplug_lock); } =20 -static gpib_interface_t agilent_82357a_gpib_interface =3D { +static struct gpib_interface agilent_82357a_gpib_interface =3D { .name =3D "agilent_82357a", .attach =3D agilent_82357a_attach, .detach =3D agilent_82357a_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1770F1A7249 for ; Thu, 17 Apr 2025 00:32:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849975; cv=none; b=sR/p8vHj/vosSO0X0NKQqZs2ObFRxLdcbmd9GyBPGhsHMxwvHv/BAdVUuT4oUqNjiquLxVlpr9XlReXr4m9+Dnl5X4URtcbewFiQ8xBcBiVM5nC5bv9aZvDmmhsbMpcLH+VPZf4OCtYayrAJyhtoRaWD88d7aR10+qICPDsdZz8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849975; c=relaxed/simple; bh=8okjKapEXL0pq/38EBFIL8OiF3bafOD9XDda7A5fthI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ho7clJ+5REVBpJfcGHBioUdh4/eqLhAryt0OlaeQ2Vi1H2tkptiI9IzgHZVLjdPTNtGEBGoRGmjn9Ny0Rw1AELRQGHLVUwdLTty5XC+GXG8oHBeoa5UE5RuSmJgjVszXhcwIzPWv4I4w5KmwXdf4EtknRM9NWbODUKH0+X03KRQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=RCYS43Nq; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="RCYS43Nq" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-22c3407a87aso3486265ad.3 for ; Wed, 16 Apr 2025 17:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849973; x=1745454773; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aieSX3scPJoA/XHoJW1shS4zGjo6f5zSBOJN+BqU2pE=; b=RCYS43NqzumfZ1KxzN5OGbHMzW0nxnEbuIG+yX9QA0xJg010DqLWyO+3byiPId4QnR XTsn9iJ1PSB8GXmbddij4L4p3JUyCzAlSPkGvoXaHX42oZty4Ci8os7vLXa0HwdyHSj9 u3L+JAxaMCda61aZL4tQZfiiNHt7SvMyjWN/7ZuI5SM8z5FRSe6T0LYlNie/S4aIqhZh Zh6lofdELK+agbBv4sQYpVhO/gP0smIfORSkTgTjA9KGsSgjPlDvOqwW5nfgVMIwxFMD lGFUuZRNSJ4yuhUYqmeBEBFy2UHEmpiQcBG1SghmIa+pMav/CExYlF8UYGxldCF1/190 Vgvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849973; x=1745454773; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aieSX3scPJoA/XHoJW1shS4zGjo6f5zSBOJN+BqU2pE=; b=SHoM3muGlXorTOcjG2cEvgZfRwCI4VMDVmvbqNBzbi1HLewiM6qOvWxMuyUUDY3dZX Ph6kwV8uEKL+bSE87xp/K0VK34ZLHv7Ey20BYIh5lFdMPE60BJ4P487RRaUdHIVQfrOn 1N+0kt1zxq2I/NBqU7F4/knwnwOyu/Jsz6DIKmQfchyclJEntbeQ0Yw0GyJUCLSTer8r ++38ZBw+jR1mcuGfk9JqJggrC6PSWQuSZGaijiHxEGFkbvMPc2NWgcaCXO1brc2yhd7C gWZk8huW+lcI/OTPeYAXNlOVkjrKbIJyx7203vSYKwz14smE36UXuTSMIz+oQ0oNvGja /bmw== X-Forwarded-Encrypted: i=1; AJvYcCXBHuAQAB2BFPE0OBw8ezr9JBrTYGxaCfYh63tTmFs7NWS1BLnEkI5NbcqXj7U6sRGyemz7e03UPTnt9jQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8IMgsWSAAe+/FEEQFOL2x9cFNqe4AasD4sOUXoDb5OToPA1Vs fvCEWNKBM0pbhnQeUN4R06LHpp1EMmJpMkc61k2gSdYLY5g9MJ3vnC63fmF1EA== X-Gm-Gg: ASbGnctiIRrQTQ6cmQxypEPN0NFmfb3cIAahc0dp4KbGlXn0YwMBpslUzJYmrHz/AkM 5ro/4BYpPc9r581X+wTVVGhIqRDsnD3Ry3wm2XaCQTg6tB1U8TiDfnQcmXbxF1erz+lKhd2z3WW EHLaQsjMklHLG1lOurhuaCrIo4afJQhAxrUcGcJd3+iO+BdmEQpvDdiN+yM4vgHCayXPNG2Zqjo kzB6slE+8S35FN7WTRVGozGsrPz9Pz6VNjivsOdFuXu+d0zX8pp9D8qxPtrshsyoyv7eLM4tUfg MIEvqpLnweKHK+n6BzpQFben+w4Q7ZMaea/g5zQ/Np0CGhFUJYY6OUAXiCDfEDYxreD/CRl8/n6 8UAhrxI5W4NcCPwAu X-Google-Smtp-Source: AGHT+IHkqC8KVVYFFKRBRSh3k2qVgnhji73OjHXWe1evH3Cwzt+CMaEhigvo0U455wmM1IN8eaY0hQ== X-Received: by 2002:a17:902:cf0f:b0:224:376:7a21 with SMTP id d9443c01a7336-22c359742c4mr62912015ad.42.1744849973376; Wed, 16 Apr 2025 17:32:53 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33fc43d5sm20865225ad.162.2025.04.16.17.32.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:32:53 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 04/18] staging: gpib: cb7210: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:32 +0000 Message-ID: <20250417003246.84445-5-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/cb7210/cb7210.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb= 7210/cb7210.c index 9e26fea43fb9..08a50d1428ab 100644 --- a/drivers/staging/gpib/cb7210/cb7210.c +++ b/drivers/staging/gpib/cb7210/cb7210.c @@ -686,7 +686,7 @@ static void cb7210_return_to_local(struct gpib_board *b= oard) write_byte(nec_priv, AUX_RTL, AUXMR); } =20 -static gpib_interface_t cb_pci_unaccel_interface =3D { +static struct gpib_interface cb_pci_unaccel_interface =3D { .name =3D "cbi_pci_unaccel", .attach =3D cb_pci_attach, .detach =3D cb_pci_detach, @@ -714,7 +714,7 @@ static gpib_interface_t cb_pci_unaccel_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pci_accel_interface =3D { +static struct gpib_interface cb_pci_accel_interface =3D { .name =3D "cbi_pci_accel", .attach =3D cb_pci_attach, .detach =3D cb_pci_detach, @@ -742,7 +742,7 @@ static gpib_interface_t cb_pci_accel_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pci_interface =3D { +static struct gpib_interface cb_pci_interface =3D { .name =3D "cbi_pci", .attach =3D cb_pci_attach, .detach =3D cb_pci_detach, @@ -769,7 +769,7 @@ static gpib_interface_t cb_pci_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_isa_unaccel_interface =3D { +static struct gpib_interface cb_isa_unaccel_interface =3D { .name =3D "cbi_isa_unaccel", .attach =3D cb_isa_attach, .detach =3D cb_isa_detach, @@ -797,7 +797,7 @@ static gpib_interface_t cb_isa_unaccel_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_isa_interface =3D { +static struct gpib_interface cb_isa_interface =3D { .name =3D "cbi_isa", .attach =3D cb_isa_attach, .detach =3D cb_isa_detach, @@ -824,7 +824,7 @@ static gpib_interface_t cb_isa_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_isa_accel_interface =3D { +static struct gpib_interface cb_isa_accel_interface =3D { .name =3D "cbi_isa_accel", .attach =3D cb_isa_attach, .detach =3D cb_isa_detach, @@ -1334,7 +1334,7 @@ static void cb_pcmcia_cleanup_module(void) pcmcia_unregister_driver(&cb_gpib_cs_driver); } =20 -static gpib_interface_t cb_pcmcia_unaccel_interface =3D { +static struct gpib_interface cb_pcmcia_unaccel_interface =3D { .name =3D "cbi_pcmcia_unaccel", .attach =3D cb_pcmcia_attach, .detach =3D cb_pcmcia_detach, @@ -1362,7 +1362,7 @@ static gpib_interface_t cb_pcmcia_unaccel_interface = =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pcmcia_interface =3D { +static struct gpib_interface cb_pcmcia_interface =3D { .name =3D "cbi_pcmcia", .attach =3D cb_pcmcia_attach, .detach =3D cb_pcmcia_detach, @@ -1390,7 +1390,7 @@ static gpib_interface_t cb_pcmcia_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pcmcia_accel_interface =3D { +static struct gpib_interface cb_pcmcia_accel_interface =3D { .name =3D "cbi_pcmcia_accel", .attach =3D cb_pcmcia_attach, .detach =3D cb_pcmcia_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46A8D1B414A for ; Thu, 17 Apr 2025 00:32:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849976; cv=none; b=XeziAma1yepV100PfUAQ4IDTL886rMf7oaSieOU3Km/2n4moBjbwB2CNqkAPKLjlyZBNhm6QaHm6kZL9lKWnt6JbExnw03rzJex5bgEgnbvlkXjT0b6LsX/GwLXN1LBctLNxbSmRyZ7HbAhFCmg35NWDUwOUgQ4iWyJ49ya/gz4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849976; c=relaxed/simple; bh=QaMlya95zkc4MjQsjQDNT36UA9lQmCeo4nFFSkNr0Jc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gggBpvTxxEM5U1ORWBwvVuRqXplCbrUpdOxrj+TsMSsaynppsvnEAQDOr3R7iCxCOEtCHwE00VB3yztWu2wqtIhYgiwCSFbN0OC6IQzo/VP0YHAulhFMvpWFOzKoY4FwwRa4/DVlkAzR9ov5dCXGnXs3ysDc9IHEakE5nIeMd0o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=MDe7e2jp; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="MDe7e2jp" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-224341bbc1dso2383835ad.3 for ; Wed, 16 Apr 2025 17:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849974; x=1745454774; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GAwcN61khauGEX7eRicTPKijk8SHQIgYsxBV6pw5EIA=; b=MDe7e2jpOajKBfcsgCRj83QDcCyVSBn1N3gDp7jbeEH844ZprD+cPRR/R0Fwe75G4A v2aidd7a29ElXmnrKiHpL30soUHim8vUnD+OT5Gbk4MYXf/l5cku4s+45R3o1U4q34hS gQEhxnrfLN6MpffOYyIBRLKE1Hvm4gf9pVLi18QcequB2JD1sWA3HOTg4bPAcDiecLe8 5NXDIEp0y8XI+6q0/qfN1K279yPDXjFslqFxdHR2TVyZYaOPqxyx6HibHE/FrvLJfaSS BkJAwJdHhYBHRejWNz0mi2MAz78Hq53/GC25J9xxQwLkJJsIyA95MyMS0A+yyd8xJ+G5 IyCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849974; x=1745454774; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GAwcN61khauGEX7eRicTPKijk8SHQIgYsxBV6pw5EIA=; b=w751JHudqEvmjJhqMfKFPTJQfAGQPjTcHnIBtRPDtPzPwKR0WhNC2iWTlpDf0ChGpa 0OMysSjarT+tBwqHao8mwUCH/a4DAXtPQjfVJaKesYPjofwctDyTIT17f5lq8rQWTWy+ xx9OADBiILzgtyGVfNf6FEQNbiLFbZz2Ct9r/Gt35ABjKK90dkkffYPGAJIsvXdDfZ8b F21FP+cPOUa/K6TQJoSt1aDjFJW5x3A4AfWq6C6cFzIuf+LFy5qIahtO1M0dZIuUy2p6 3z9kYIh32vUMMDEXbppUa2QTs3FQPTcSeHgzWhAG9SRP+eQXETOFFt38guFqWSq+0vO6 EumQ== X-Forwarded-Encrypted: i=1; AJvYcCXu9nBPMA5tPo6kvOcoEz+wH7ynhggzkd8nynP/CqqzgSNVMtFbOADyVL+hIlu/s2mggDb/0LzBZLcJgc4=@vger.kernel.org X-Gm-Message-State: AOJu0YxUn6AiAX9KHb33yt0OZ1JXenkuRkmOtFyKCYRx5D9k36c7ThRJ tg6UvVoBCAiakriuzOgzidw6kqCKT9dugA/JSnlTURXevRb2hNlEa5nB5bsSSWonlyqfSNKZqJM = X-Gm-Gg: ASbGnct4VtqxIA8fW9JRiU8UgF+Ry3NezPFpNwmwRNTvtzVefYUC3fuwBAfoEj4DFlH zphwsMRPrHWvI+xMRd7q9RrARA87qLv/66GOcULvsMiV26b327m+6PmYHT9CHylm8ZXQOgNUCou c9xC/1AOJQLopG7V5hqS8vzv0tzyiuQQLrjqiTAq6HOmsvvQ+kLskxSeWjvmUhiNTMBcZXYBydo BtVv4faoedhWCWuBBD0HKjQv6UW3yeb7gmY3x204cr4hRtrBEWQj2ssbmJFC2z8+DHdBILJo30W pXErzFZth9r+bryNdeFMH1XnEmJYMBr0tlAMF1yW1ffbaQXcVllD7Iiy011IB7xmBRVI4/9OX9c jScLHzg== X-Google-Smtp-Source: AGHT+IEvcFXIV6AshDKyBigtNhPkXzrIDw6+YPe/hpr+Z76eAm80FDheS6S3vY4+u1qqd/DLPTNabA== X-Received: by 2002:a17:902:f684:b0:224:1220:7f40 with SMTP id d9443c01a7336-22c358c2996mr47815755ad.3.1744849974515; Wed, 16 Apr 2025 17:32:54 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd230e310sm11414103b3a.149.2025.04.16.17.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:32:54 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 05/18] staging: gpib: cec: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:33 +0000 Message-ID: <20250417003246.84445-6-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/cec/cec_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/cec/cec_gpib.c b/drivers/staging/gpib/cec= /cec_gpib.c index 03d5b6c4fd8c..1b02222881b9 100644 --- a/drivers/staging/gpib/cec/cec_gpib.c +++ b/drivers/staging/gpib/cec/cec_gpib.c @@ -188,7 +188,7 @@ static void cec_return_to_local(struct gpib_board *boar= d) nec7210_return_to_local(board, &priv->nec7210_priv); } =20 -static gpib_interface_t cec_pci_interface =3D { +static struct gpib_interface cec_pci_interface =3D { .name =3D "cec_pci", .attach =3D cec_pci_attach, .detach =3D cec_pci_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F49E1D5142 for ; Thu, 17 Apr 2025 00:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849978; cv=none; b=vFi8ea5+SEIkIdqcKiAU1b8e4bsdxS2RNTkFG5QSDVZ49gV7sqrLV37A8q9H4jYWFnBlQJzWXRhFCDqCaoDYI2GaHsCashPa1kO0F88+bq8fXalOvu86zOaORR1N/6QQ9hRTZX1X2npNscxkcfs8v8ab1Pr2C0C5QUREySprPRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849978; c=relaxed/simple; bh=RSie0nXMjQWozJafxINypzZFt8eO2DZf7eBuhaP0m3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YVV+Oa4BnCvWMrGFnNa+fEu39JK1SCM7Xbe8VUCNaG8uokBRXUrVk2X2Rbw5ZCzJQPmJ7AxavnaQMZFk/fkPfWgR4GEVISCsXMiLrMa5x6i2cJJOCzyNrYdJBE0m/ztnjKY+GhxXi7fEut/qhtFBkU6ivtd4G46z1apJI0+sS1U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=V2re7tv5; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="V2re7tv5" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-225df540edcso14762865ad.0 for ; Wed, 16 Apr 2025 17:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849976; x=1745454776; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4KbTAU01u2d1Fyhrvlbrvk8qe32/1uE4Mm7IabxHd+o=; b=V2re7tv5MW+Xpytwro54VFKHa2AGbXsLTnyDDFyhVxSoRDUT+Jva4tbNBp8pVITrbq M4Lq8daObpSLq1U38KVWAg7t4HtAlxlQd9Xdq7/OAfWLKevmlT6oWpHb08ejJAV4LFOx hOixttscSX3MYH6P36GHo5HEHWc5edcPhdll0rkm3FQ6A/Qbzl+uGoEsEa5lajGld5KF Jwn0jlNC6ux/PN/gI7TeJFx15TXznph4Os8B6dqp5JrTQG23kShDPGSuHHShzR9FWEJs 5gHCcWSJfKkrdPC0RzbSarj3v3sNoVdIf/+SCDyosWEMfTZQsoZv8/lzPuIx/QWi0Onf DEHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849976; x=1745454776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4KbTAU01u2d1Fyhrvlbrvk8qe32/1uE4Mm7IabxHd+o=; b=d/X0ZpTaTGhxFzTanHs+Hkbcxc+LXvmrVMFvx4oYYrpLzkAMShp/yod5LWBW8OBf8v Q1VbSTVNgcI24wgaLhzGjo3Nxo1hQLx2ONRp6eNzdtIoJI2+f/Fg1WSk9vzZ4k93eeUi iuXFmGYnLd6jNsVPd7UGUEp9hfvm6HNFhK4aDJ0u/Pgi6m84JzVxc5jprJDz24Ur43aY o6RXBwmc8UpHnzVRk3AWejYbz/sKRrf1BjwOzMN51egeqt+Dq9DEL010lcYyCIdAxnbL SYxmlkMA1k0OtF9+Fq8jpqQ7yZwqtSXKECUohm5LSKkJmUGydJT3jceQtsQ933DimzJJ S7dA== X-Forwarded-Encrypted: i=1; AJvYcCUAhCMDUGaVZ8Ef4+FhcZTJVDPXeXzkDs2MHlYaMwVItYRBGwE46W/H918jOan+agMDvqXwD3QuHyWYH7M=@vger.kernel.org X-Gm-Message-State: AOJu0YwLPFSEYAcfUluhJNQmnUR6boKh6iHnnSXgPCSaHfJYsODNob03 MsiNk8jMnPt7A8nMcaxwmDe4hSz3ovSt+D4xS46vLF1KeDYxiC+953g6dm5P0g== X-Gm-Gg: ASbGnctVdx5kJk5AqqPy+wUWO8hHCMuwfALKwEPdpPvTc5q4/69ddJQ2J+tyMRk5rCF 25MzFuPB84xesCDxJ+xXGFeVV/2NdkvMrhMnXD6gfwMK/ILv3bmbmkvYALHIL2wJ9XUMZHaybc1 YBwA4vvIFpJOdxSKEOAtU0jeDtyWKFa+dOUiJEP/oYBy+23KKdfCf3Gqz4l8gCce6JX/66ZtSaJ +0Ydic64Alc4XggoZzMBqa7oHLTBPfQV7Xqa50nwSFJu23zB2ao6TXcRozM1xpoaL6A6vom8g+8 b7tOee8LkAQjQZHdsRVViRVa1psMykB6dsFuH9iHVsUWb7xAcrV43wKRN9ptDD3GSvY0/reGlp4 J9WQ5ow== X-Google-Smtp-Source: AGHT+IEcWsjwkmEqreAgK2pRvl/J7AlkiLFzOj18jVxrfcqpZ/SNiQIRA61+XUt96JpZw8TvxC8aAQ== X-Received: by 2002:a17:903:1aa4:b0:223:3eed:f680 with SMTP id d9443c01a7336-22c41a3f4d3mr12051875ad.18.1744849975707; Wed, 16 Apr 2025 17:32:55 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b0b220cb76fsm1564843a12.30.2025.04.16.17.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:32:55 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 06/18] staging: gpib: common: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:34 +0000 Message-ID: <20250417003246.84445-7-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 029590f95fd3..87329d35ca47 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -2038,7 +2038,7 @@ void init_gpib_descriptor(struct gpib_descriptor *des= c) atomic_set(&desc->io_in_progress, 0); } =20 -int gpib_register_driver(gpib_interface_t *interface, struct module *provi= der_module) +int gpib_register_driver(struct gpib_interface *interface, struct module *= provider_module) { struct gpib_interface_list *entry; =20 @@ -2054,7 +2054,7 @@ int gpib_register_driver(gpib_interface_t *interface,= struct module *provider_mo } EXPORT_SYMBOL(gpib_register_driver); =20 -void gpib_unregister_driver(gpib_interface_t *interface) +void gpib_unregister_driver(struct gpib_interface *interface) { int i; struct list_head *list_ptr; --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D0C11D63E2 for ; Thu, 17 Apr 2025 00:32:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849979; cv=none; b=fy/uAMh9f4TnsqxPi1MNIshS+amWFVUJV7AcO7Tav/MhTCUGdCB2vUz76bIWmWCYEFTzHuehJ96A1b0IzSjczskDmOtqcifig5qmkrsJnAnUflsP17Zf06IwPtb+fcqFyhmSXSspC46mjQ6Bhrx2y72wvxwDPiab94hYmlCCOKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849979; c=relaxed/simple; bh=KQ+QquYMBIqqRibT0ze5+kVkj49lKLUsMiQ1kpVHVo8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Bxiqn7XCyVi2cW6Zz3peruNRj3w6/J4AzfP0gff0HfB4AkFJhnZ5zyjm7GVZdwPLdaXuyKJx/kjQ0fdEpn7+C7z5SU1Vl1P7TVDLS3ZjekCmJS4M48N1p2DFwM+0darWqIJTawpHHW+P2R7XuJ+8t9hxa6vRS8uYEfZbpSVyoLI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=SBgZh6X+; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="SBgZh6X+" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-224100e9a5cso2612005ad.2 for ; Wed, 16 Apr 2025 17:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849977; x=1745454777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J13uXJRWM0moEsklwKwSqEYQ8UWHeXvw7Ls9WCbeq70=; b=SBgZh6X+8frX7vhbd38J1HDiImME+eL7Jv43AfDCsscKN12xbrZLiWo7s/FIdABdDi KSUQcZBjaUQCQqXhu8Bs8BTh+RLTcSWGpbwDEMubULNxFCpJWwblgpC504MToFg2Y/2o D1N1WjWKYRdX0AbpOGUccPNUis7omVU6Ov433yNurXXVsyWb/7sdDDCocexM7ULtwLCY r8c552Qt+FfN3kmXTwVOp2ZcK+plSjHfKGaCcGhjkpXFGiYpZGbbfr+YbEbPauNtATYB X2xmfQEL696cGgtiMR57b+BX4KWnJkr1y056+ZQ/FwZu/Rz1WpB/JO2y9R02PZ4qKBOQ es0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849977; x=1745454777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J13uXJRWM0moEsklwKwSqEYQ8UWHeXvw7Ls9WCbeq70=; b=FQqcczfU9Jk5mFk2Zhxyxs7pCBmFWZ5cwp7zzrCvZuVY5V8faKYyi3QWEW1f0nVgq2 y9B2ha5rse49KNs9p9wODFdM3rcNrBd6+D91sordWDlgN5Gif1unyWhRIP9RAvRCJgFl sAibJFELybtU+vBquMUUgVLpQl1j8DclZL+UM3rywyL6lo9L4skF9PtNBlcERilL+cAP LNC6zy+xX9fM9KVi13ooT01VINRYcYvmhAhuhdsJswHUV0jfRw+t43tFt6a+2y/sgTGN YkptINOw7pH8+fAGuW4NNvpq6GzZhZDLauC83yheID217AD/zd37fA/onOir6MDRfkiK Ilug== X-Forwarded-Encrypted: i=1; AJvYcCXK3eIV4gBiK8w45P3bA7I8JO2NGVt/NC8bvV2eSQ+aEpES48zNerOTMoxKSEk1f+jiuWlPKetIOKm2IrA=@vger.kernel.org X-Gm-Message-State: AOJu0YwX4CXtekr4GVtOaN35wAtlyzGc/EGgI6ZT4YW+igU+fYX+IAjp yIO0lxnV5G+IDN8rXvZ1oTcDAq/0dwqNgCykqkvJWXuMTPSpDWYCQ8Q08pp1Dw== X-Gm-Gg: ASbGncsvo12hFTx3y0elQdWdBVEbGtdJl32/Q3f8ptO4nAacenOl3EC+PQ/7J4aY7UY 3QDV8OzzN8Hie4e5IhMwH1DzKcLyAPJTqUUU3WI162mCLPTn8QLiHKKnHCKjrGn97pDT36BTvkG DXtl0qvGOhJ7/eOLU21jtn5SSb7Ugf15G0RRuyQ3PjQ4Q0+0KFgUqo92tFjmYOjJluXaVG21RCJ HkXAVEyxdf88CuFtQ3eVfPGWE6UHHOtc9bch6pcMpU3ujcRfGzEdEeh1+G0uqpSKZosoLd814t7 rJYYCxT3ukFnLwsF5MecUL48ltwiHKI41EzOuYLGdG05999mJF4gDvjtWNUKzavEhGLVbmlmo8q PxzoYzA== X-Google-Smtp-Source: AGHT+IELXGI5nfNb1JGGFd0TXtfxoydnNvgxQFjdrUy7B4TmFWpVuVQZuyyGeKtBcECtNET7gjACFA== X-Received: by 2002:a17:902:d4c1:b0:223:4816:3e9e with SMTP id d9443c01a7336-22c358d7039mr47655315ad.13.1744849976841; Wed, 16 Apr 2025 17:32:56 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33fc451fsm20855325ad.159.2025.04.16.17.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:32:56 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 07/18] staging: gpib: fluke: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:35 +0000 Message-ID: <20250417003246.84445-8-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/eastwood/fluke_gpib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/g= pib/eastwood/fluke_gpib.c index bca3bb8a3d28..a45befcf003d 100644 --- a/drivers/staging/gpib/eastwood/fluke_gpib.c +++ b/drivers/staging/gpib/eastwood/fluke_gpib.c @@ -712,7 +712,7 @@ static int fluke_accel_read(struct gpib_board *board, u= int8_t *buffer, size_t le return retval; } =20 -static gpib_interface_t fluke_unaccel_interface =3D { +static struct gpib_interface fluke_unaccel_interface =3D { .name =3D "fluke_unaccel", .attach =3D fluke_attach_holdoff_all, .detach =3D fluke_detach, @@ -748,7 +748,7 @@ static gpib_interface_t fluke_unaccel_interface =3D { * register just as the dma controller is also doing a read. */ =20 -static gpib_interface_t fluke_hybrid_interface =3D { +static struct gpib_interface fluke_hybrid_interface =3D { .name =3D "fluke_hybrid", .attach =3D fluke_attach_holdoff_all, .detach =3D fluke_detach, @@ -775,7 +775,7 @@ static gpib_interface_t fluke_hybrid_interface =3D { .return_to_local =3D fluke_return_to_local, }; =20 -static gpib_interface_t fluke_interface =3D { +static struct gpib_interface fluke_interface =3D { .name =3D "fluke", .attach =3D fluke_attach_holdoff_end, .detach =3D fluke_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAEC91DDA39 for ; Thu, 17 Apr 2025 00:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849980; cv=none; b=FPzfrScSDi2iECEY5J9qLONV+o0v49XodWUrTqUGwTc5qPoon/6oxIJ39ueNOOOiywlw+Po3vH48FCvCr6/iRaSYqXO2gSbnJUuEiQE9kCasvho0KUDLVGnpkfL+H40rzS6xhyn9Tij0VkjO3DYJ8lQNF3z/DEyLSKANt6xBSRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849980; c=relaxed/simple; bh=mCsspTE3UaGQ8nT6EDevPiUOVoXq56LZJPwAiRcCzV8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZhaM+nHG/iJ1/03kQCTpshsGHvqKEnGgMsAOhHi91PwZ+AosK8bYm0GrYf60/xH+zleHbqxQBdeFYDtrCdzSkWuUf3U9YzmLaCzL633sb8LDMMiu08n+BK23jrWiFRbQQRCbvsugztpxVBJV7ZhgWa8QW6uGnIwbeHigiwRiEDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Jl6+TSKB; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Jl6+TSKB" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-73bb647eb23so150260b3a.0 for ; Wed, 16 Apr 2025 17:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849978; x=1745454778; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5Em25zRDyXTzVtfIF//c+VGrQ1J4twC/n9eclwcMlRg=; b=Jl6+TSKBOHorIzC1LTloxKSe8q4/qbMEDaHZg2uM2f+IAsc6Jb6xkr8kzSSFExoMi5 p9BnEhcyWPAWLCZ3Lr3duBrDI3uhqNiwbC0pcywHbWRjLbMbqGFuhGXk00xFyJ38f92U qC9agmQBUB8c5E+KJKKVMnLCh6YqqYwysqLhBFnL/Eo91rfoJ5eWn3RdDd9RoJLxUbtA 89fA7t3pjr2DCsWbqpesr2lk9uKr3r/xRBa6wa5YQAGTuB+8IjcdFCRciUCwv3ayTgaW 4PB8/2r3w5/ZIWCnzmwWoToi3YSSIct9e+lbYUhvSF/2MIDVhAEA1wvP7c9i0qJxr4Md 4OvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849978; x=1745454778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Em25zRDyXTzVtfIF//c+VGrQ1J4twC/n9eclwcMlRg=; b=f74/HbrwopsobN5ENT5Xp5OIvAV6WOHT1iAnkyysQz+gWlwSO9TyWAS+RbZjJ5Yird i0AiiiANW3YXEbVbzOtnMFQGi3K6/OGrQ673NlYEyVA9EePS7I2O04zdl2o5h9cfu4xN 8cDZnO19nrEeMncDCRk1YJCR6ovn24d6DWb8RKbkkBsnsHEa+L5UDz9gg83Np2cpCQ9f 9vp5hJbnF3RCW2FtDVJgHbG3uo0ENEEhsgGJxYE2NMay+CPCL3DAs6vmkzW88k9PlIhJ gCN3+f/DXo+v/p8plx2hBNILOYs19MTSe1HsC0UIjzrtApLNKo5tvQ/rfBt6FpuiEjtc 5kNw== X-Forwarded-Encrypted: i=1; AJvYcCXTfIi8F6ADR1ouD40wOaHVTtV5hRLDZiQ78zwjNJtN7Fz4e6db0WudtPFb+d7FIspoG6JbZ6W9ZLr4IsE=@vger.kernel.org X-Gm-Message-State: AOJu0YyHpHdgpmGPf22H2JV1bMJCfeuXT7e21RGLCJmspl5VIKs8j5vA phmm6erkpQ7P1ronlEDPBZnX64DG6NhP7bZWRrx4mMhCd+PuXQMVtQnIatJkrA== X-Gm-Gg: ASbGncsHFvacm/X19BAJ9b8JMMdMt04n7dmGMvE5z5Fxmiaz4dqUeUAn9IVq33wFUPB Aq5xusfQAnLbfuCodX1a69Kw+rvBmFeVkY0J+JBPhX6L71SmeKe0uIhhAnsCm7Y9ZudxF2l8Slu 1WVd09wyVtq9cFIakV4o7CUQlgShp7EncNlLSM22bl4y5J1eC+hAVFmKfxSk1lgMRMIq4Q7VGNZ hn90l3ZfQblJwrk/YKbc5RASHiVLGXFnBJlxQQM3PkkYpeVErGpjkO1gDbJg9BIalu2A9DZU34O C4eqc9pBAPlNcBedmNNv8EFYJkzLxAHn0C0mykiJNe5VF64LV6QtJ8CcWgNUexRYkq2wbgoN12c 2eN5+QA== X-Google-Smtp-Source: AGHT+IG6v8HH85HUkI2gNJcFwtsUXGFErr/79Ygu9DBV38QGm0Q0z030T8jpk4t+wzZOOcp1rgp8mw== X-Received: by 2002:a17:90b:4ed0:b0:305:2d27:7cb0 with SMTP id 98e67ed59e1d1-3086402814cmr5665354a91.21.1744849978064; Wed, 16 Apr 2025 17:32:58 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3086104a0ffsm2314150a91.0.2025.04.16.17.32.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:32:57 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 08/18] staging: gpib: fmh: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:36 +0000 Message-ID: <20250417003246.84445-9-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpi= b/fmh_gpib/fmh_gpib.c index f86d3f90bbff..992e6f7c035c 100644 --- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c +++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c @@ -1031,7 +1031,7 @@ static int fmh_gpib_fifo_read(struct gpib_board *boar= d, uint8_t *buffer, size_t return retval; } =20 -static gpib_interface_t fmh_gpib_unaccel_interface =3D { +static struct gpib_interface fmh_gpib_unaccel_interface =3D { .name =3D "fmh_gpib_unaccel", .attach =3D fmh_gpib_attach_holdoff_all, .detach =3D fmh_gpib_detach, @@ -1059,7 +1059,7 @@ static gpib_interface_t fmh_gpib_unaccel_interface = =3D { .return_to_local =3D fmh_gpib_return_to_local, }; =20 -static gpib_interface_t fmh_gpib_interface =3D { +static struct gpib_interface fmh_gpib_interface =3D { .name =3D "fmh_gpib", .attach =3D fmh_gpib_attach_holdoff_end, .detach =3D fmh_gpib_detach, @@ -1087,7 +1087,7 @@ static gpib_interface_t fmh_gpib_interface =3D { .return_to_local =3D fmh_gpib_return_to_local, }; =20 -static gpib_interface_t fmh_gpib_pci_interface =3D { +static struct gpib_interface fmh_gpib_pci_interface =3D { .name =3D "fmh_gpib_pci", .attach =3D fmh_gpib_pci_attach_holdoff_end, .detach =3D fmh_gpib_pci_detach, @@ -1115,7 +1115,7 @@ static gpib_interface_t fmh_gpib_pci_interface =3D { .return_to_local =3D fmh_gpib_return_to_local, }; =20 -static gpib_interface_t fmh_gpib_pci_unaccel_interface =3D { +static struct gpib_interface fmh_gpib_pci_unaccel_interface =3D { .name =3D "fmh_gpib_pci_unaccel", .attach =3D fmh_gpib_pci_attach_holdoff_all, .detach =3D fmh_gpib_pci_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F27981DE8B9 for ; Thu, 17 Apr 2025 00:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849981; cv=none; b=pSDrZC3elpQ4nIxpM75pgW0eek5NiQJz9f5UxYl+e/M6V/bXExSLy1nb1t1cyVpl22ZbLiByzyanD4kwWWrmNeFb6Rjc+I0vu1k1ZUpjEDRtBgEBG8I8LplGYijgriBxkAdFF+54fMPAGBIIpK+w1/+KPzdL8V4MFnPHeGvGfHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849981; c=relaxed/simple; bh=oZv9J6EAs+La9Yoz4jWDKoBjoVKNXoiy6YS2fSQlpKg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZFVPT4OdwDpX0j2dO8IfyEM8/xuauq3cfBYYRf1Q95sFG8EGs6yHoWMBBPVyREsJ6EMKqx9EI1p8rhzaIiO5Mn93T9R/u9ciBF6lkKFck584KU8kW8hHllqAZpyAtSPdaSpVx5HV4pHcgZXoJdhGisovKDmm1CflUX9Lcy7MQh0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Bh0OLOvS; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Bh0OLOvS" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-73712952e1cso139278b3a.1 for ; Wed, 16 Apr 2025 17:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849979; x=1745454779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OaGk/ulT5DmrCZA9B/47jOByqfYQN8rvXLp/mrP0bU0=; b=Bh0OLOvSEe+swoqYIA5sAa18d8j4LBRbM9fvl6WSn+Bdf4EAKHsx+5UOBLpNnOjyoI HoMfpnyvv/41DuN0MKvKlC6JiLREkpFXJf5ZVdFkY+XC45F1b21FJ3hzFWpXwt3MTRul I52qaI6kvQ16TGH4rOcSODEAn7i+yd9P5Imc/gwylZosE488LIPhdulncuLdVXMKQE9S w6dmVC5fqkAjAYBcDoZIAqbWeDx7FYnvM5mvAYa+gT7cCy/ydmbzCi9YfF6V+LhyiHef 3UXa5y+WAHUOyPHMqNPU8CrsqRIh9uTen+Bxws2UBPUXEqKym73kK55JrYaSFN4tN+qZ LpjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849979; x=1745454779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OaGk/ulT5DmrCZA9B/47jOByqfYQN8rvXLp/mrP0bU0=; b=cNldRPfVuYqqosueqOtxarhphgGX5wvVbovhF4Vn/LF6tVgnIrpOxRXuBqPIssDK1w e0NLw0j5CZmipOZp0lC21crT3FsqV2PGf0eqkcpQBNfD98hWYo/aygkvO/g2B9laE5S3 Ye48oZVNZtGpn0tQGYHDmFckNUD/SRavtA7RxGVPdUP1MTa4UPufqh/0XmrHr5/FiNHH fXTl3C74re0gQ+tFsarLebovpHvl432X22jDejFWEgykqEohxB/HPSkPa6KGCXMu+rn+ fuQU78J6jFct9q4yIzaE8gTZu/69IJoAqv+7FKXDrtgtqbHMCgzycZ0mpppe7grjmfy+ wGTg== X-Forwarded-Encrypted: i=1; AJvYcCXmCA54pKy9v5+jaTal4bQBbmOuBhgAjkgKywL78ekxagy38Q3sKUK4fw7hvcf7VZAwGelwFqOjRfRMpns=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6b/50ub2OSeygY1bX8FAA6cPuq1ix7OqbLCqPJG8d6vG1QZ1I 1FfQKHVxL82fcoMiwS96ry8nmWFgvJzRnr9GIP59Ebw4GhT+K/kNU7w6FrZi/w== X-Gm-Gg: ASbGncvGV9Y3hh9O40zRdX9KUrDjUKAw+b+R4V3sZNj/DzFsOB80c5SngP9U33HHNvk WcU9P14K5wMYvYM9+Qsr9ZdPTIat9+ys4coc8VBVwqgP09T69GYWqhRzgg45eua/ta8XEAFbIJM 7LlqFu/5oYUoagk397zoEZkVBBSds6eeWRv+/kpRV9RZ2auI9qT10ZW4u0FeCbksWwg7giQr0gP JKlTMXibxvLTC7i7NRdjt2opVh7lgoc2iD13aJ5P6ksImvjIW0+NKJNvhnlulg8xKypWXa5Yx12 MaTj6EyIoP9YsttAdSYHEOW0yQrGA+XVHH26yfZVVzgS3jse5AMo5yo7Mpcg0nfaC9te//iYYnk cG7SAJQ== X-Google-Smtp-Source: AGHT+IHZ74Gy3mFf0si5N56++CDIea8yCXo2gljGHNPnJQwNQOT0xFDB9iIxO3BakfxEu0PW/JmimA== X-Received: by 2002:aa7:9301:0:b0:736:6ac4:d204 with SMTP id d2e1a72fcca58-73c26722b44mr5134846b3a.11.1744849979201; Wed, 16 Apr 2025 17:32:59 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b0b220fc3b3sm1580948a12.43.2025.04.16.17.32.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:32:59 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 09/18] staging: gpib: gpio: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:37 +0000 Message-ID: <20250417003246.84445-10-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/gpio/gpib_bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index 87622ee841c7..443d739c7edf 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -1308,7 +1308,7 @@ static int bb_attach(struct gpib_board *board, const = struct gpib_board_config *c return retval; } =20 -static gpib_interface_t bb_interface =3D { +static struct gpib_interface bb_interface =3D { .name =3D NAME, .attach =3D bb_attach, .detach =3D bb_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14B551DFD86 for ; Thu, 17 Apr 2025 00:33:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849982; cv=none; b=KmgDZ1gBQxZhhLCgEFPNWqpF24XXeqlJJMq8bRHh5nVkeKDGQ+aQDNrogjtONVFbrtpOt895L9xrbEQC8IUDk3PLqLW/Z9OwEAMBlA/vV+ye14QLCoZz6NC3X0ZmwFOPEvqejxuGDuscngl7YjXdiF47uB9kh7zlqBRWWMbD/TU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849982; c=relaxed/simple; bh=sm89KN7M+N+cjb4kBf0tDv/avTft4wb53ORjh52ocFY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nzODEJleV5kb5kYbOjvP6xtaxbBUKYLzmANairKFDqsmva0S5w1IF+P0ynJJQqzjOXv0nSvkdcBYoxintFd73sGur7NOwbVvEBRBYQpY28qE+DEBEvZ1KHZe2QU3HATBNf2k1aSynIkMpPD7gTyyKy051QgWKUrp7ZFhnCmJwlM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=SZFYKNOm; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="SZFYKNOm" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-224019ad9edso3827285ad.1 for ; Wed, 16 Apr 2025 17:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849980; x=1745454780; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vov0toR1t8IP8gbJNzk0Bz9HIkssufBqsXHpZDgzbTg=; b=SZFYKNOmJl6gyZczjHl2dxnxnkRvw4FLHKb+i2RPZ7mDU0AJeEthja7bvMEl2Uoon8 2Gp5LllHJ0Hf2vjTB95OhxJ2Kj9/IiCJe5rdfoPw6RJZ1vrDOEy7wBUuyotMChYk84Bh E1+70Euw3Tw7Y9Nc1HmMDZ10JACj2lDVBu7Q8TV2rQ2+6LFC/X213OKD+BXt9UQsQo0U ktzbUR2OilG9uDu3EFw14Bpyr4l72yGpn5VoxwpunxZsFF46CmmPqtvx/Ouj3vACyiVy 8payntzyZhCx+tx5/dvM8rF1YvIfswWzQlibSMUGf5jeNFDGcPOXVbONrFZIacRqD2pV YZwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849980; x=1745454780; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vov0toR1t8IP8gbJNzk0Bz9HIkssufBqsXHpZDgzbTg=; b=vtqc+SZHgqu3qn22Qr1EKDpm2bfzSvtR1/nbhRCyjcsv47QfZYnWWsO9xZuTUh8R0+ yq9pIQJl2nrC7fg76lw3Kb/dGW0ZoOT+319f4ABrRZmkRwkhvreQXDlpeoqozGSXpCCc 39QgZASzlwdgoIteZwGDshLMJnjZKn2i4f6zN+RkAqaN99/rEm+GEtouKJhk0pP4s6QN qQ905z1zRj6ljxZRJeX2u/K6Bh/Pk8LR4zo8DmiwV1zvsdUXovFodUKb5V5yz/MtLiBV 2L8saz16AQH+11Y/1r8zcr5MxO6Cazw0P6qyBrOp28VEDnuT6SvP2d+mFpUAChyUHfVF +F9Q== X-Forwarded-Encrypted: i=1; AJvYcCVvkuZ74XJ6Z6W8AsRa9QWw/dyizX0FXcuMgj8AP/I/PuwdoHmmDL2CBm1+ygcVprTLpyGr3/MthY7Dlzw=@vger.kernel.org X-Gm-Message-State: AOJu0YyKGB8ZfAbUvpV6nR+U8/dC4cxU5ymkfpDRy33Xwieh3GQjE4zg OWJZsVtnvdDIf53hLdw1ddA+o28lEqgG1nk5jzM8D7N03/C/5qz2tcaO/FyKag== X-Gm-Gg: ASbGncuhRPR0JnqHY59fmdfwrPz90tHdUPHPpzSkSqW7CbV/LX+l9QQEpQ6YSDYecmb R7PVCVypBZJFwRPfeDvyvFWeqleSR2as2XlU+Uv+ohTXVKuxbbgvO1Kj2LRjBlnjmvm0/ux0XWz eUWCZJpfXpuzv2t39ekGSZgiHYPpntn49FPyuMP3AdVH+XQG6+kCCNowTv5GhQfyQxbUusJT8q5 YPmP7rtjyTjP7ew5brJOCoOU/BQwICNOd2H6FvZjYKUTAIyOb2K7+ldhqd1Gghqau2bTMoQiGlf Ml/g1Loz/ikVjYmlRHmAOedaG+BnwO9Vtetn8hd7//lI5IDICDg6fqgbokicyBPpTtKWCzwmo7K QMipNpA== X-Google-Smtp-Source: AGHT+IHkdp8wFb8X5ghxYt1BgBUGd+xhpS4xA2g6f4odxtiLr8qfFM+odDvBRmuWhMfWb6VoY3cBNg== X-Received: by 2002:a17:903:41cd:b0:220:d078:eb33 with SMTP id d9443c01a7336-22c3596f812mr53036595ad.36.1744849980355; Wed, 16 Apr 2025 17:33:00 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33fe8dd2sm20829485ad.246.2025.04.16.17.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:33:00 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 10/18] staging: gpib: hp_82335: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:38 +0000 Message-ID: <20250417003246.84445-11-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/hp_82335/hp82335.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib= /hp_82335/hp82335.c index 319b7f6e35ec..7f14ecb46026 100644 --- a/drivers/staging/gpib/hp_82335/hp82335.c +++ b/drivers/staging/gpib/hp_82335/hp82335.c @@ -180,7 +180,7 @@ static void hp82335_return_to_local(struct gpib_board *= board) tms9914_return_to_local(board, &priv->tms9914_priv); } =20 -static gpib_interface_t hp82335_interface =3D { +static struct gpib_interface hp82335_interface =3D { .name =3D "hp82335", .attach =3D hp82335_attach, .detach =3D hp82335_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62EEA1E7C38 for ; Thu, 17 Apr 2025 00:33:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849983; cv=none; b=Od3Nv7o97k3oY4OqdBUJnQuYR0g9gI2JwRj9eEYV4HHMRrJplduEzrDGtP/kKe7JgTq5VunKNQC4dlON+WtgWWc28dpfqET7WG4qRxGD/Pkt0LRRg6CE9eS9MAIYcaR4VeuR7DNScAEfMFzw5rYgWemfy0MZFgctR8/HHmEkZP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849983; c=relaxed/simple; bh=qXuKC8wKMseybKQRKVoj0KYHcQgg1A92iFP+uea8iuA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SX3fZUqQwaThPdsElQ86gttLZSs91yItwCXlV1S99xex98I5T2j9pMmtOS2VEE27OtmNTiclPgydJ1vtz3uUY2lLCrZ96+eqM+OBQU1Mg+MULFu/VQSzUO9Xn1T6VBXURr3EDuMaGDjjLsiO4jyWK2funr/VX2uuNnAiFovPOYo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Cfq0cwh5; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Cfq0cwh5" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-736b98acaadso161256b3a.1 for ; Wed, 16 Apr 2025 17:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849981; x=1745454781; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cTuxdgSBH9onldJ0zjeMMUuM1GqYJzLHWyE75BJvR2I=; b=Cfq0cwh5v58J/7Yu+3kcsSB9/5q6pazjAgPnjiLRZKwXqQUGrk6k/J9MkFMWV29ka0 7Vu6QEbCC1iZOOg7aImOWbPeCQmaj87PWufZBQdm3GDahbC8PBpFhHsVCtf9qYGSfVL9 rGd7fz1PmMF8ESXww2c5+B6tXdV9Kud5Q2sSvSvAXFmxEfWaxvGo8D9CfzLwxbYKkGNh 2jAZdj/PoKrPIQlJGs5mBp9o3mRezOnfx4im18JPd6/ULwVHXYRKqIngFo2Io0zOv/C9 Muh883rcX2REK8ZIJdcj7CEow92UXKV/32yFan0rs/97VOY57ib3vNT1163DSXVBya4/ S9zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849981; x=1745454781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cTuxdgSBH9onldJ0zjeMMUuM1GqYJzLHWyE75BJvR2I=; b=UmPnYd2kipAc4vvbkVjKVeDgwLysYZfnzOc84vB5gHTAhbFb3DZAydSLUJuzMF3TA/ IjUfqGUhG72ihsi/xgo7rJgbj7v/Zs+WywDRn1lAmjXHEAAY/fLenlvFhQo8tp7cyvui +N16FuDS2nC6rIagjupS221U1MXca2AuMDtG4WIVxmuDcetxSYcLQOQyBlkuIBEao3TB qVMZq7WNxVrVGXEI5BjAJQnstdUkl/IXGa91XLAPPgSc0tabdCNF/+4XAoOAyGyoAUmu 04NMgK7Wi/l6K8tH69yl0tnrkEz8zaub2EPS8NzcU2LGRCGcyz00uIYN4YJm0uvYb/yy 9eGQ== X-Forwarded-Encrypted: i=1; AJvYcCXn/5SupmnHQhEDsjqmg2DaanNfr7ZqtD71eeoAOo7tHvHnN7wdJzK187Y9KzbueJdhnBghrpa1nIoYcqM=@vger.kernel.org X-Gm-Message-State: AOJu0YxdlpjEQIVzNV6zHostMFf2tcGrMqqBOq9HZQ77Fr2+pOjCZB03 njAwN46nhb5TafGsZuX5cNOW9YD5Wr9QIjVnpZYA/uyr7FTLxWj6ZZVQYEhzNw== X-Gm-Gg: ASbGncuJb+ayLO1NSDXhBDjtE/JeqL9BTRueJvlANb7d0H16PDmJvKW9yGuVUtZRa8N nCsauGR5F82BVs+i61EzvTecEpBBufhAaAjL25lbERBHYzz7GhxTr0KoZwxpC9VliOveXhZoJGO VXti+JDg27bThJvYJ0hU5VIVgKXkck8c+6xL6wxoCnvvMSoD+BhbsTiVYgVnV/uja1v2hE7arVu KWVpJ5hG/uEB84kwQ9xhbDvkarHpSR2U/+G8UdCpEmi2vobl4mXVAGSHeM9SpPIwZvPlNZZ8San PwMs2+3lL6ZK4FDJ7UZpVWVJBtg2qE1oL82Uqv7St2lM+uSMwBZ3lRUpCpwXjggf5gLsv4dDxTF xfBC3JA== X-Google-Smtp-Source: AGHT+IHrKH4GUhouJYD9RBko6R371BDH5NugueM0IYjVJ3b2sL/HyvhyTxhHGmohZ5+Ooym7fHDTgw== X-Received: by 2002:a17:90a:e187:b0:2fe:8902:9ecd with SMTP id 98e67ed59e1d1-30863d1d97emr5761415a91.1.1744849981572; Wed, 16 Apr 2025 17:33:01 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-308511d1046sm2909585a91.0.2025.04.16.17.33.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:33:01 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 11/18] staging: gpib: hp2341: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:39 +0000 Message-ID: <20250417003246.84445-12-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/hp_82341/hp_82341.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/hp_82341/hp_82341.c b/drivers/staging/gpi= b/hp_82341/hp_82341.c index 5ca0bd2f1a08..1a32a2cc421e 100644 --- a/drivers/staging/gpib/hp_82341/hp_82341.c +++ b/drivers/staging/gpib/hp_82341/hp_82341.c @@ -411,7 +411,7 @@ static void hp_82341_return_to_local(struct gpib_board = *board) tms9914_return_to_local(board, &priv->tms9914_priv); } =20 -static gpib_interface_t hp_82341_unaccel_interface =3D { +static struct gpib_interface hp_82341_unaccel_interface =3D { .name =3D "hp_82341_unaccel", .attach =3D hp_82341_attach, .detach =3D hp_82341_detach, @@ -439,7 +439,7 @@ static gpib_interface_t hp_82341_unaccel_interface =3D { .return_to_local =3D hp_82341_return_to_local, }; =20 -static gpib_interface_t hp_82341_interface =3D { +static struct gpib_interface hp_82341_interface =3D { .name =3D "hp_82341", .attach =3D hp_82341_attach, .detach =3D hp_82341_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E8BE1F582C for ; Thu, 17 Apr 2025 00:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849985; cv=none; b=Yjyog8YSUduNStH3ynl+zPXNiRN36mzj3UoD46N9iWRpLwDNYRP/YiNyX+QvdN4eDh8IUMrdTblU/HZklQF8qN8B523/DKS+EfldFaVOjvUEY4Yqp+zRIZ+uCjBA2fOZvBQiHTM9R6C0pDqRE7qW1Y3UXQvhmxa9jY0A4R6kODQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849985; c=relaxed/simple; bh=WAFOP7FyG+vCwxVgewc75RXOWLLjybT3cMXA9lWbBzc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bwcY5prgHOF151h0lHaqNU40Cz6bsz1rxoiiPYj9QQG0LW4Pvpvn0kkCRUgeoRMNbuH/z1Gxd2Ajn3ezqsCQ7TGwvu9XJc53kbvYRja6ZozDs55t2yFg/3X7dJB/w9psv8v3MGq7Vfhjvq755/YQChppfl4acSOjYpwWzYflRSU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=OHq65ZH0; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="OHq65ZH0" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7399838db7fso240639b3a.0 for ; Wed, 16 Apr 2025 17:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849983; x=1745454783; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kcINWBx+JwvnujHkG7lIpftC3Iv5jwrdue9kd5WGFkA=; b=OHq65ZH0QTHdlaEKF5i8oVxmE9d7ehGKwDoM8B1g3tAO4CUNLrZs0fR98rtICeAswq gAN2GYj/h7sJOO9ga3cXbZKzL3tdfJ3iqHYSLJPBvWENVXKJerNA+47LuwLL095nlL6e bipb7oKtTlgybSnBCtPUxLtJvwtjRDU84hpv+tZXduaOQTR9Jzys+H0TDVQYpc/xjW9f 5XvBZgm+v3HGxvovMnpikWP0CLkyuvk3r1UMIyzztBxpPbOV38cP5yqkwI+QqxCezQ+x vhLQnJhbeiRvGxkIzPJDYnkHfDvaQXElM6gYcu+lEMrQTMqFWgSKNjRQtigK2EZ2zKHz Vrsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849983; x=1745454783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kcINWBx+JwvnujHkG7lIpftC3Iv5jwrdue9kd5WGFkA=; b=laSwkxqw1trIbSd09NqUblNCgBZ2EmKmHG5shaoIHRqWeThLPeXaeXogJeJWpoTphR cvH+hzs44O0HGPGrJP2BXttRACZJSW4TWEocaIkX0w2XKty/C0V5u9VDveyCurPIdmfM HTaPzaCVu3CZCWQXNWHHfkjWv6tnqDghO27+3QBcl1UhL3Cl9PD/BeUeuOfirDDnpUMY 7Kws6QJ3E8gV60Vwf6h6H3g4cTOY/EdOuzbCIslCJuSwv6wdcEXVIHL/N1e2JqqP41Hx rtsKcrhI1u3HtLYE0rK3um6LG8fHriWViN1Y5es3HFwtE7wS3X1IuzIxSeTKC6hCYRhh zRNw== X-Forwarded-Encrypted: i=1; AJvYcCU/gwyIyHoGmmoMGlhMp4f0V30dIX8CWlfxS9joOS7OYgYKYwNtSWU3+HripLDKfLd5UjPEUeR1865ixPg=@vger.kernel.org X-Gm-Message-State: AOJu0YxLcb6V1zndXYoLTK4FwW3roG4ytdkrAD18SmRzP5ib+mfPTf7Y Q2E3eX+glPYW4EFoPAqF00p1niJ7hTh1B1UKpYdsZMHOiPh6YbwQgu7tQs3wYw== X-Gm-Gg: ASbGncsAzDeaFDRWFk9tFo8k/3H7G3Ibx/ytVQGhFiCf2VsT/syDFKdkbUBRrXOuxfy IfSg7lth7Ty5Skt80S70vIb/f9a3iJLGApHig6n5vKLMikP84yRhf8wTp14NaW3WrNnBna2iav9 TFm0Gz5mkloIAzzdYt9SidK9qXCQTSUE0/nAicKMrnnW82hWKWV/cXZrIm8ppbpVu4IOp8IoUgc IbvpMfHkZfM0InZpRAsnNyUeKOKMoMEu6lUv7HHZW49HrWe2HuaSk3DMfMTifGdtYH9jwuW3/by jzOQmCH86GACDb50nx7hBd76iUbsxvXLb+QKAUCH6e1+fgMexcvXy47Q41oJAM3E/9pTNgORexT FWi1DQQ== X-Google-Smtp-Source: AGHT+IETqPQKTuoHKPU4diTn2V4OLI8GtL8u97Jm+3G8+M29+dG0rIaU6tVcrb5wpmPS8S0aopOucg== X-Received: by 2002:a05:6a00:2e9d:b0:736:3ea8:4813 with SMTP id d2e1a72fcca58-73cf28f5917mr1082328b3a.2.1744849982712; Wed, 16 Apr 2025 17:33:02 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd230dd71sm11050075b3a.128.2025.04.16.17.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:33:02 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 12/18] staging: gpib: gpibP: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:40 +0000 Message-ID: <20250417003246.84445-13-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpibP.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/include/gpibP.h b/drivers/staging/gpib/in= clude/gpibP.h index 3e21bb1a4297..6461b330a3c3 100644 --- a/drivers/staging/gpib/include/gpibP.h +++ b/drivers/staging/gpib/include/gpibP.h @@ -18,8 +18,8 @@ #include #include =20 -int gpib_register_driver(gpib_interface_t *interface, struct module *mod); -void gpib_unregister_driver(gpib_interface_t *interface); +int gpib_register_driver(struct gpib_interface *interface, struct module *= mod); +void gpib_unregister_driver(struct gpib_interface *interface); struct pci_dev *gpib_pci_get_device(const struct gpib_board_config *config= , unsigned int vendor_id, unsigned int device_id, struct pci_dev *from); struct pci_dev *gpib_pci_get_subsys(const struct gpib_board_config *config= , unsigned int vendor_id, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1978201013 for ; Thu, 17 Apr 2025 00:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849986; cv=none; b=D3YMv8mSkr/3HBLBsBc3UKrZjxz4huomf6wOZz+5JVDvIJ/O0KG/W8QcS5PrUFZgz8+aTETgMKl6Ebgc0lrJLxi7Ti/KIXfuPDGZ8axWCP/1KABXXJl86yTVaSGSdpt9G2V1Xbtg/ffH6ktW8IBwimBa8QaZ/Oqh5yVnCIlobaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849986; c=relaxed/simple; bh=daIUt5m30GbThrgpN2UiMbj827gJGKnXfrI3FUsQ42Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ee8fcTjSYtAJtYsayqu/b+c7hxp0AzVaNWMihaKv/6th7DdAM49jqK6YwDCzW7OoQcQ+nY6iC9rJeuk/l87hHruqIiWInX2bEdE5W4I0nhkAxRuFQCQIjJHrU71GnzLWat1ZhN0JPx9ozCYVnjJV7+lD5LYtpZSjwpp1C1M2+9E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Zt570pRK; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Zt570pRK" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2295d78b45cso3744055ad.0 for ; Wed, 16 Apr 2025 17:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849984; x=1745454784; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FHxSFc8bv3pUp3i2Yf563NFMSxUhbD3DiyJ7WfN7PZ8=; b=Zt570pRKpypYo/KaA6zE2VGh2c+u37YmzdAoTL9bJGMJV8JRiWbgfyxcCWcJTQqXCD VFyC8SJL7Lik4JGcwpdySU04fRjqQfgEwy8wm7bH6wapODSZOtR0fixv5Pfl64JT2UiS 3yy8XkKIQ1PBkp6VwXEYAN9vRbyleWNxNXlTOEWgpb/vOjEyMekNVDiqFrZeNAukhsIL ojWaOvKfhA4t+OmcGknhyAIh6CCJRAFDoelmAIcq+Mx7qh7qktYq2Bf9yZckO3ymme8A qqdXXNpyQNjZoYgurncg/sZbIB2akGvK1rhLPfOEtqUfAmKjXtJrexp4e9t/2xmufM2z rfMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849984; x=1745454784; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FHxSFc8bv3pUp3i2Yf563NFMSxUhbD3DiyJ7WfN7PZ8=; b=tLP4Se+Pi6gcWwZBPpa6MO+oz7echrseHHSpHM//v75DCs0kHuGyzxI29evGmKVcn4 VXSLsVMowT8qTv/9Sxt+g+lJI0CWLXaIj1uRlLkwsuBoyVvYtQwHiCUcf8PNjUUFZOWR dCiFaXnmDT4qbVFptMDgFDf3pLFY07/o9lM34BBIMagvXGnLP4Dx0uRRRZZno92Qnkad xxqTIkz0elxs9oL0aakzt6bfO40SR6Z9NINX3t2CZZSxgU+xgPdLCa1THWg8jjdnB90A 5ylHLCVqwGLSMLxcopQwSp7TaSPmLyVZtLR9Qv+qQLZ5a8/OoGBf7fYcQxXMSKXJ1rTp 19nA== X-Forwarded-Encrypted: i=1; AJvYcCVkOnTYQol9HuK11k9DGrE/teEeaiJ7tHqZZhqevQOF/wKuQo9LZ/Yf9Atwu9/zhtgUJgMTiTdW5Iz4nug=@vger.kernel.org X-Gm-Message-State: AOJu0YxEO6RD7bcv8KcelLybjPq9nNqoPcCRN3guTpTLbxrsq9+KPqsE dKnNhxAesFYJq4aLtA2CXoJ3SakChf//3fa/mAazQOsdRcMSRRWqBtZB4N9Gzg== X-Gm-Gg: ASbGncs3Ip/EMefP4z7EFEAOulTFvxJh6jMejwlMSeaWzRfRHNYcGK1UWikd49kG5Tg ymiwixZ9+L+fnah8Vx9FZz6juSY3hRnc/Ov9a05J5Kf92dRElu8r43jK+aNbXJ0Id3vuS+j29za x71DA/8s6WNhgPSntuQQZjOtLWCIw3XkKhQqT1uVUmhMFr7GxD4dH4HVfwoRTSxqOWHAOENyWXZ BCpDlX9UzIFXc67fOoGNLSUtLoC5rPybxnVVlu+ivVPp1LQ0fDmyx+OEpIF76gZqQ/1vmz3pu84 9zJmFhvmwjqS6rB7cU8SoTNRv+MQRXjXkFoNPOWWsIoIGtKd33mU9uo08HOa4t2PicVvQQEcESQ C6lsnOQ4qqBqyKwCT X-Google-Smtp-Source: AGHT+IE5J2dfQGuH+x3zeXEOqnTUrZZd8qUQtq7cXkVwrM2vWCpStLEsoHCoYf6uJID2hYkfseB/4A== X-Received: by 2002:a17:903:2411:b0:21f:7a8b:d675 with SMTP id d9443c01a7336-22c358c5597mr64753925ad.4.1744849983910; Wed, 16 Apr 2025 17:33:03 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33ef11b1sm20910345ad.18.2025.04.16.17.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:33:03 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 13/18] staging: gpib: ines: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:41 +0000 Message-ID: <20250417003246.84445-14-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/ines/ines_gpib.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/gpib/ines/ines_gpib.c b/drivers/staging/gpib/i= nes/ines_gpib.c index 17a14cb66e63..6cac26a3ae0b 100644 --- a/drivers/staging/gpib/ines/ines_gpib.c +++ b/drivers/staging/gpib/ines/ines_gpib.c @@ -539,7 +539,7 @@ void ines_return_to_local(struct gpib_board *board) nec7210_return_to_local(board, &priv->nec7210_priv); } =20 -static gpib_interface_t ines_pci_unaccel_interface =3D { +static struct gpib_interface ines_pci_unaccel_interface =3D { .name =3D "ines_pci_unaccel", .attach =3D ines_pci_attach, .detach =3D ines_pci_detach, @@ -567,7 +567,7 @@ static gpib_interface_t ines_pci_unaccel_interface =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pci_interface =3D { +static struct gpib_interface ines_pci_interface =3D { .name =3D "ines_pci", .attach =3D ines_pci_accel_attach, .detach =3D ines_pci_detach, @@ -595,7 +595,7 @@ static gpib_interface_t ines_pci_interface =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pci_accel_interface =3D { +static struct gpib_interface ines_pci_accel_interface =3D { .name =3D "ines_pci_accel", .attach =3D ines_pci_accel_attach, .detach =3D ines_pci_detach, @@ -623,7 +623,7 @@ static gpib_interface_t ines_pci_accel_interface =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_isa_interface =3D { +static struct gpib_interface ines_isa_interface =3D { .name =3D "ines_isa", .attach =3D ines_isa_attach, .detach =3D ines_isa_detach, @@ -1218,7 +1218,7 @@ void ines_pcmcia_cleanup_module(void) pcmcia_unregister_driver(&ines_gpib_cs_driver); } =20 -static gpib_interface_t ines_pcmcia_unaccel_interface =3D { +static struct gpib_interface ines_pcmcia_unaccel_interface =3D { .name =3D "ines_pcmcia_unaccel", .attach =3D ines_pcmcia_attach, .detach =3D ines_pcmcia_detach, @@ -1246,7 +1246,7 @@ static gpib_interface_t ines_pcmcia_unaccel_interface= =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pcmcia_accel_interface =3D { +static struct gpib_interface ines_pcmcia_accel_interface =3D { .name =3D "ines_pcmcia_accel", .attach =3D ines_pcmcia_accel_attach, .detach =3D ines_pcmcia_detach, @@ -1274,7 +1274,7 @@ static gpib_interface_t ines_pcmcia_accel_interface = =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pcmcia_interface =3D { +static struct gpib_interface ines_pcmcia_interface =3D { .name =3D "ines_pcmcia", .attach =3D ines_pcmcia_accel_attach, .detach =3D ines_pcmcia_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B78392063D3 for ; Thu, 17 Apr 2025 00:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849987; cv=none; b=tlXD0Z8yLV6EQAbB6X1n69em2pyfCJFs47BxCE8fC4f4ODPP3JkbP5l1HM7SE28oM8HGemfmn9/CdvsZQckz/aMYonsXQk4BqO1v5HBsglCNDa24I6meO4QFI4EIMDl0zUmNW74cyPO3CMc6uP4nvZ3+2zK8gK1Akm0Z2/ipnUE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849987; c=relaxed/simple; bh=7nOnj/t3IWRKRJuUCHCZoJzmMsnxpf6ffPgcSoWr688=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nSXgIapogPnMjyltiOltVp7doF37lpRLh0UY7gfhkQnDPTUDw/ZDYVJ53bvEseStM/UlSgIuEib7qXxJZzVbeORBAX3jdeQwKBO0Eu2BLm1kXskZsJCRxG5wqcI9lVsTcQAZoH1yomoGnu8EqGFuTIFIU1G8HYcNis98IGv9n3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=lJtOLWCM; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="lJtOLWCM" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2243803b776so3807765ad.0 for ; Wed, 16 Apr 2025 17:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849985; x=1745454785; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=akTpKyJqwtY/MzR6JYTv6U/YQl7Z23JU2ZL/gi1Jfw0=; b=lJtOLWCMdH5XIAtOsZPge5KVIGJ96A0N6JSFtTZ7nRl2VIjN1mtDaWuBTCkHjunVcF 6V4/FQlrFZ2Ywgbie8QXzRntzaH2pVLSWwOvVLYm6jtcQvOzG+SE01pBHuQBhFHknpck 1iKmfRKNsAiFwFWPQhR4SocHbFtsOXFHlcOj29gcZrFLRiHaQYZAyyT92hhXEbavq48b c4N71LVgO5wpoSUN9AsOnBZYqqFzd6sRxTug4w2W3nHnLj8zqxIS8hNbirnNfWbj+SAu z1aRSMWtgPvg78DigG5EUsTw3xUeAh1kcGjhncChLYCFkpba2vd1E9P34uuXRx2OdZHQ 5wqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849985; x=1745454785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=akTpKyJqwtY/MzR6JYTv6U/YQl7Z23JU2ZL/gi1Jfw0=; b=C/ALt7TV6SRQBb4F60OBjKbsPBewFYZbovfmCsifDC4fR1/VBodOIVi44Gf7MebcQG dil3uVxEyQpOZmsMrouIadNtRLx+RVsD4da8/hQgvGhkx+6Xd4L9ojEMvsuE/wYAERlB cYOMmXiu1awja/l3FKvNyG+FCrI5+OzeeFcDCcxZfiCigW9vsaJP6+Vt6tDDCRLbnJ9e eTmvlv6AsdSWzxVw44B5CN35BfXnciKi1afvE0Nt3IvvYlIouGRMAeL4r4mX3KjUyzTL 4+KjhzzZ45s/NFLmn/mXt1qkctlZa5WedQ2jth+7qb4kaZZwVA9iDNZZuokZQkl7JbZR KqGQ== X-Forwarded-Encrypted: i=1; AJvYcCWdSvMGY33Yv1lX12+xuksP9VSxCWxdl7DFV1q8IfA66I/1XuEzMDVvxlAKkn5S0XektdGBAE+Yx2cxAgQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9vxMMlQtp0lmezNGCSArlu7bRcjxU37nXptNP+WfZnlg4oMQ8 KaKgcJw0+t/BBsRtoeA3mkAp2zop8/BOJJke8hV9FINP0VN0NtZWVb5SimX4gQ== X-Gm-Gg: ASbGncvPihSq8WourB+E3PKMbGpwjg9sadNhigEn3z0OEIO1jn1d2yfs8RJ5nchTlwM /Jr0XRjNCSZHIaNEP+b6WwikKA74PDjtVXC12Tb8xaITNeTtCbb/mvTsBdL1BGOVtGFK655Hjxr VfhXGjv49jWJ1zr5bx45ue5S7bl5Z8udLRw1I27Z5cxcQviWLvu0KNmNeZHyS0rFoFRKcVT1/dI U+TF6XhLrhBt8eEzvPrUmp2rL8fnReOQC5LVfwBND/jxtrPR8nAdQREFmPxHTMGZYhNX42hDjqO 81n3v0yNXK0CmYs4TD7Vga7OdqZys0q/FDkdJJ2FZ4Fw9OIdVseDsVJ2iQI4ljTcQtiCNnYj0BK rruY3JQ== X-Google-Smtp-Source: AGHT+IGYB5rRMTCrYcBvWx1oyo91M+PvsefiAz/0PmFW3/rXiYio3aV9UdJnictE+VBfEQe0SmaEQQ== X-Received: by 2002:a17:903:2a8e:b0:21f:b483:2ad5 with SMTP id d9443c01a7336-22c358db5edmr51881165ad.20.1744849985214; Wed, 16 Apr 2025 17:33:05 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33fe7219sm20767075ad.245.2025.04.16.17.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:33:04 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 14/18] staging: gpib: lpvo_usb: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:42 +0000 Message-ID: <20250417003246.84445-15-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 47f56fea28a6..494cfa21b938 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -1055,7 +1055,7 @@ static int usb_gpib_t1_delay(struct gpib_board *board= , unsigned int nano_sec) * *** module dispatch table and init/exit functions *** */ =20 -static gpib_interface_t usb_gpib_interface =3D { +static struct gpib_interface usb_gpib_interface =3D { .name =3D NAME, .attach =3D usb_gpib_attach, .detach =3D usb_gpib_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 148D22080D5 for ; Thu, 17 Apr 2025 00:33:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849988; cv=none; b=Rmqu06+6V/hyM6QaOZo+GB0Jpo7y/OkML+w5A855ZcPFoopOoeXTWvQR5dCQHfBDzE4Fiq2hBqrJ4xtFsknA9T++lr7SaRxLUk41zM59Mn8sM9EnQUdrI6YGHsZDlN2ZN0N8TGq+B0AtCEo5gDRG15sGSk96qP82RsF/vheeak4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849988; c=relaxed/simple; bh=7oIHWBBjQ7BlH6IvMzYiszexZSDJnBmjz47kdnIC5NU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DPmMyYpvqJ9s3/psaTmGfXBreo/1Ks7BMxE+O+ozcrGlsKlpuYbB/yok/FHqlcgHG+1VmVA2HlCeVgviQ34cL7iRurPNghBETVNjl47Tjy8/xW/snqk95gCMLL3T/Lb6OtanZElL96rRowxhN1cKCRzcjYRro+DqXE/bcshyQP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=FeuFyqdr; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="FeuFyqdr" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-308702998fbso136413a91.1 for ; Wed, 16 Apr 2025 17:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849986; x=1745454786; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9Pdr3HWigL6Ku7LuE0NhaS5q7GdvsPzI86/WAfJAJfQ=; b=FeuFyqdrI3ZQgm3QrBFLgieyNNi2ZGEoy9i1YrhMPQrRKmHKVcF4Lv39zsyPeWjyWy eyOxj+VddBGBHzgaI38L+5euzrCVIQxCo+DpHsCrfo45XuGKRsGFmOwxsPQ4V280G/+W Pycm9vCAixKOGzRkyKQ0NpOJmNxgmGKav4m9bsWH5BBsF1TVyreV3HZ8oBvunyr45vNA kyYaiTuiBMIykPx7/6QYZvC7JlA7gaxi1zMNlD5BJgSslHjHAUMsTJ9MPqFLDi4zrqxJ D6FMukfkDWqJaGdo2vdt7s7O206KvUykRzTddaX5O2TcxElwwqbASQ/LmFgoUqaQH5cD m3hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849986; x=1745454786; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Pdr3HWigL6Ku7LuE0NhaS5q7GdvsPzI86/WAfJAJfQ=; b=AdIxsogfBDMT4ve49Z+iIpBvNeqJGMDJka8eqbwLaueobVPKlwV8TDe6Iq3H8/sJf7 JkfHE3Z01qfaG6KmCATfU3GVpLY8/jtEsgBUOAXkuZma2ZiFQ9AmBswZ8PoU5URBvJ88 NixQFDbU6F2xM/K+olx9tuAE8UDnwE7ZQ0Gzj80eGlC+fZw2qFXGenJAwY6kPUYEWbKm a0URxZapP/HoOUz04zesLY2I/bwlhqFfTrzyIsE6Ecd+HjumAsazJJBcNW4JStrQBovN 7dNCSuuMu2Yi65cmlYfQIEhl+Yc93LeDIEZi82JJYFS9tjcM6w2okotcYH+U2WdJtns0 DR3g== X-Forwarded-Encrypted: i=1; AJvYcCVkcjf891iGr+u67SX5SdMFXpPNW25KWbLwM3dCeEjsKEKyEtKyQCfnHMXBBDAYmmQ2uXjSuWSztl7i2mY=@vger.kernel.org X-Gm-Message-State: AOJu0YzchFluo+vXXXv0VOwTs2bG3puDVtuLR7qiufZhtJlgEbXlFsvz A9uENxtO0El6HEvUXntCmn9rujccJUGz5QZg7OOYa2HR42nsvQfjq6Hc2TgO48dHRFh4efi/muU = X-Gm-Gg: ASbGncvnIbiwW62OaU5tovuo5M3AK1aBdAhmvcZ7BmGDWiM84yS2oPYyqGK1Dfd5wxn LSzTdwZwG2PREi3gGfp8JJC/7VvGkRAnS3iJnW4kiuHKKzV7lzncrU0ynH0YWnsH/uHg+bU6bc5 o+GGiSMfosqrOh0EeckMrUe/mpoV2vrGqonSqd94VolRPk66+U/7eOCO1EHeHEOg+dwyK22M1An eBTzoTndedRsw2h8CbcRqON0C+UNkVxaVNq/6/FTGVxUyCJPOZzHPTAbaMmqz5cVGysLbth/ipp Hl7RgG0M5jANre4f1awyYrCVQQFHgn0gLYB8Cue6ec4f9e7nxWbs4KkKyW7qqnlor/Ras3kTJR+ vts+52A== X-Google-Smtp-Source: AGHT+IHAAu3OCGORh5WH1jCPQPqg3DTc9VvsY9VBR4t/IMQrhq5vUJbG3m2+2QvDaJKMxQk3vqB7lg== X-Received: by 2002:a17:90b:2b50:b0:301:1bce:c26f with SMTP id 98e67ed59e1d1-30863d1de1cmr5619673a91.3.1744849986388; Wed, 16 Apr 2025 17:33:06 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33fcab8dsm20787265ad.190.2025.04.16.17.33.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:33:06 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 15/18] staging: gpib: ni_usb: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:43 +0000 Message-ID: <20250417003246.84445-16-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gp= ib/ni_usb/ni_usb_gpib.c index 00f788a59dcc..a3d517efca08 100644 --- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c @@ -2373,7 +2373,7 @@ static void ni_usb_detach(struct gpib_board *board) mutex_unlock(&ni_usb_hotplug_lock); } =20 -static gpib_interface_t ni_usb_gpib_interface =3D { +static struct gpib_interface ni_usb_gpib_interface =3D { .name =3D "ni_usb_b", .attach =3D ni_usb_attach, .detach =3D ni_usb_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3403D20CCFF for ; Thu, 17 Apr 2025 00:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849989; cv=none; b=RqkBV3v8zS9UVK00IoP7Crlr0b2BMVqGrMRZxHv77K2FuvhCKXHpTf9upw9zIrKBCTXNmFJICKQrWl6IjFHyKKg3Gi7ttNpqCucdnbyFMi5RcP44Pxkk+HRP7LukyPkUaG379QFyfX2ePdUD2tfW6bV9jXeL/gO7sLYCtVU38bU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849989; c=relaxed/simple; bh=r9FE5GpaFdBdPdJ/Zrxc1eYMAW56Ux07mT3KRwmjw48=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S5I75gsTbQx72CSQ+Gw10m8mtk2DiCO7pWcWqoeED4jx5c5+z5rvXkywEE/WGQA9VoxOWhreKAymaOeztaZYJRLLLH3tZAvTe4xGjFu9GCrqra+NTs/x5yoDUKN/0ZaJvGamLLdrfgFff+8HoNwU5/63Xpxz/x5UvW6z0VPNYf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=TLLEa4NW; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="TLLEa4NW" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-22c3407a87aso3488155ad.3 for ; Wed, 16 Apr 2025 17:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849987; x=1745454787; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a8yDc+KkTQrj/aA1tqJ3BKYXbav1Fvp+NFLeH1to/I8=; b=TLLEa4NWkpXDNUEzHB7wT0KPLcdn+LnaVGXKhTDPxYdrh++52Y0PNyxMo7esHiCddg leVwI9Ionzf20gbP2PlXAhCFZ4V1Vo2tFn1AVEdwKk3zFnRpzfw/r5JGRh33cBs50z0t 3L/OXNq7vcvW6+gOBjd7qS7U3Puk2YFpHDmoKZQ3AiakxscYuHWd7Qe4nvg0D2h1Q/8e rZKmN9V6m7HHS4If2Dr6+zmPSXEH7D+arq00d76YXzqfZTL1kgR8Kq+4F/hYfafP1WdB NfjagXnFgUavhWGN1UnVUtvZuRoxDFpXeU8UCEuVjTLRHO5A/QJVMuA4imEIfpxFwcXD 7phw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849987; x=1745454787; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a8yDc+KkTQrj/aA1tqJ3BKYXbav1Fvp+NFLeH1to/I8=; b=HUrw3u4o75dltMDr9Ozqg/9/OjjThLy+2kf4xmEZ2Xdsb2vrqYByJOBhOG0FufpQ7s Y1e7tUyJkeRKOz2+hLeXn60HLarF9XeJzvsCo2zkfdQkEF6lLMs31sSzu5notAQW06qW ftowdYpIO0mH6+FjQp5LXTeF947VAKSYR/934GFBDon4x9KOUJF9gs4b2YtoaBg1ff1x k17wJaHF0DuEWD7zFTh29xdR32DCd5PywxOaS55MRxT4cuSKeC6zYzALx3nLN0hrehhn F7OkmNXnnXd5+3Irp4eKoyZL/Q3/ObkccqzlcpIx3c75RjxcWm+VTchUzw5b8uwsaw+X zTkw== X-Forwarded-Encrypted: i=1; AJvYcCUgkorK8FpGBRAOeEy71fNpU5/0xkQfnFJJty60lBJJw96oJIErvo9iU6QU02EqYUyQh04QE7YztmJapqY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyh+LfujudNiZESZCxhThp6jGXGN0hutEnfv2pUXSHL8Fkfgk3C Vm7neTgOrrCFofzofafguNB7CBCatgZDL+mei/Q8KR7B94YRS61Bggn4PFi5Rw== X-Gm-Gg: ASbGncvEHcR4Zx0o5PJxnaxhKLGWJg/wCVN5mFJ9yqkRr8TN1Kniuw3vaGqW8OUzmRd ryRsbmBhtrpmOiVLmyXjlKBcKLRVJtUDhme0TkAnRkmf71rddIqSOH8gDfC3RO9YYcKvs483jYo GbwT3q3IJG6Q7W0Ij+vNPuQqDCa8OdpXrQF98jAQoRZdoNjcBJ4pBCdztP3tEofZMICPtK5KoWL rUWm0S05s2yJrZAidHGZYlwGA3YaUngXp1EQl/PVEE5EZz7iWwGcH5Dh+REzDxuOsfW9V0xjFQj nZEYeFVtAYaqEIr1hnD0VmEk/qCzVzfMMiRrTseMtn6YoHybFmxSDLpm6enlLqasRwKpczlZwzA f45n/Ww== X-Google-Smtp-Source: AGHT+IF22f9NKWSjaengdB/H/u7QwubeplY3S/KRzPgdZlcz0HAybXmkX0hNLsh3Kbn2Y+8KnSHX3Q== X-Received: by 2002:a17:903:2c9:b0:224:194c:6942 with SMTP id d9443c01a7336-22c35973f06mr69024895ad.34.1744849987568; Wed, 16 Apr 2025 17:33:07 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33ef0e83sm20768425ad.35.2025.04.16.17.33.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:33:07 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 16/18] staging: gpib: pc2: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:44 +0000 Message-ID: <20250417003246.84445-17-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/pc2/pc2_gpib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/pc2/pc2_gpib.c b/drivers/staging/gpib/pc2= /pc2_gpib.c index ee4ea1f32dfc..ae265e2eb46a 100644 --- a/drivers/staging/gpib/pc2/pc2_gpib.c +++ b/drivers/staging/gpib/pc2/pc2_gpib.c @@ -519,7 +519,7 @@ static void pc2_2a_detach(struct gpib_board *board) pc2a_common_detach(board, pc2_2a_iosize); } =20 -static gpib_interface_t pc2_interface =3D { +static struct gpib_interface pc2_interface =3D { .name =3D "pcII", .attach =3D pc2_attach, .detach =3D pc2_detach, @@ -547,7 +547,7 @@ static gpib_interface_t pc2_interface =3D { .return_to_local =3D pc2_return_to_local, }; =20 -static gpib_interface_t pc2a_interface =3D { +static struct gpib_interface pc2a_interface =3D { .name =3D "pcIIa", .attach =3D pc2a_attach, .detach =3D pc2a_detach, @@ -575,7 +575,7 @@ static gpib_interface_t pc2a_interface =3D { .return_to_local =3D pc2_return_to_local, }; =20 -static gpib_interface_t pc2a_cb7210_interface =3D { +static struct gpib_interface pc2a_cb7210_interface =3D { .name =3D "pcIIa_cb7210", .attach =3D pc2a_cb7210_attach, .detach =3D pc2a_detach, @@ -603,7 +603,7 @@ static gpib_interface_t pc2a_cb7210_interface =3D { .return_to_local =3D pc2_return_to_local, }; =20 -static gpib_interface_t pc2_2a_interface =3D { +static struct gpib_interface pc2_2a_interface =3D { .name =3D "pcII_IIa", .attach =3D pc2_2a_attach, .detach =3D pc2_2a_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AAE220898C for ; Thu, 17 Apr 2025 00:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849991; cv=none; b=G4ei90Py4dbqtWGymM8Nr2YqmfgV3SiRghZJO90LPl54NxzoyoyGF11HdWk4JC6OS0c+9dvku3sbW8S39AzEUnYyNEk82h+yC0KuI3S2sab/AuZkY1guXwxaFUUvq8hiGkP4kaFELLd9rk6WxWv8tfhn1ra8eK9F8NwIqhzhDFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849991; c=relaxed/simple; bh=1+tRRy/nL01MPl0+5FS05H/L2lfuD8Vmz0fi46Q1xuA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kg3Y1ai0xiPimKUl17XKWeAoNg7T87oFlNX1MpyXV9YDjyg3pKbcU2JhRSg3cv1Jr7SsBQyfvyh74tuMjM6LlPR+c3P3IrnS785fZtWycxZhwsXUOns+qN6P/pPAfu2D2Dm0DV/EL4Ff9yGCCYffhsk7ZwnRm+7EP/K7WPtMi8s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=hsWsdgd+; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="hsWsdgd+" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-22c33e5013aso2961675ad.0 for ; Wed, 16 Apr 2025 17:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849989; x=1745454789; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TjTAiMO1GxG/PObrFdD9u5YrnCsI7HGevSexjRmDxRA=; b=hsWsdgd+uvmhrRvfrppRU+0q6HLeRrNitTw/VR5PSENdr36945yO69xJSIO0F+nG/O DXf5AsN1NrhV0WcZl+cGBjWQht9qKV5etxXxNOdxu+Y/jTKKp3Po+JrxP3LP8NPCfTVT 8ivkJUqkZZe52iuGtfohOQlitGEpIAtvh78HxSOFsTH23xMJQYPnasMQZrKbrsUt2JpE DDD7c/R5KRxXuhPBwbH5C3ogX+KEA5Jg3nSFc5ziMiXfbY07sDqbg7z4e3YlPP+mcnw7 OJ1GOWScayZv3ctXML5GC7reFX2LL/6oHn/QlqkS17SABrNbqRXxMvedFR+MwEu920F+ vY+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849989; x=1745454789; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TjTAiMO1GxG/PObrFdD9u5YrnCsI7HGevSexjRmDxRA=; b=TEwXt4KSIRl5zU1pbNiYmWBRPcau0QMFWmLVfz3fT/c7zgKgnusRTgmKMDxIGhSwIn BxSijiRT4K6OI/uuGvGa0uEPVLqMFqUbmacWaZvF1mjQp+qaVR/sQjfR9N5NKXEXFkrP n+ghonFcRRUhAzZwgn7lQYJNukhdeFh3x3w4LuvGQ/yuFlj0p5zc2s6G8HeRtjo+xUDm kVRUV+Vb71JMFX1z2hJ0cVsHOFQpN+QoS+RW+KWLlj517yCSLhYlcKaPBCYfzcRPqC9m RRNFRPeMA4NbvpYX/x+LeVzrhZqlpgT2dHUtS00+GDSZs0XcR6GGcegKBzmtckFZOnuu cMBQ== X-Forwarded-Encrypted: i=1; AJvYcCXXftC6K5M89p8gaA+l+VzNIMo1xyIxOxRFxDwwvlNxHIyW3QuLpOmZkqinfngQVqT6Uf+sLzpgrQGRFQI=@vger.kernel.org X-Gm-Message-State: AOJu0YxVcyZ+uW7+Zp42UwwFlENNZYZEIx1JpOzCfh3cPPYx6HHsIWdr /NKgGDtO8pC2ERdep6YJCKH9871y4Z61FZDpHBLwTETSImsmKH21x9/26MQ3XA== X-Gm-Gg: ASbGncvcc0t3ac+DponFZXWypFQwtbArAnJ05vgz0SoFrTdWk2i5LfFVj6J0frfibML frsN8vbXtMpaWWHpUMSQgJSamzHxasprnFmqQ2VukdDMycWtvWxkiiY6XjLa2iSHYPI7AFV6zV9 jbNL4uFPB9J1hU4yeguVcicXAYCoDeO/6QT87ffZtsznktHolGm4lwNsMTTj15juMBeNBEoDaED fJBya8OujxbHvzvaYgxQPcGAKGGT3owcgPQhfO1tm0hoprrv8DTQN0jkDoDh0WyAXq9zxF/Ghjw T5qyxUyZVD4zLGjfHbHaM/weDsXhkgWeOqR5iHIr3qIB5/YHmWscgmU9YUo/gF+jgKH3rLUIjie 1wE/T9g== X-Google-Smtp-Source: AGHT+IGtattHZ09c4gb6nvSUWNpyqJF6hIUIld7H8Mz7/Cjzoa1xoA2Pz5AmbuZO8KzC1cpc2DXyyg== X-Received: by 2002:a17:902:e743:b0:21b:d2b6:ca7f with SMTP id d9443c01a7336-22c3596bbc6mr54055505ad.32.1744849988737; Wed, 16 Apr 2025 17:33:08 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33ef0fbasm20797095ad.19.2025.04.16.17.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:33:08 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 17/18] staging: gpib: tnt4882: struct gpib_interface Date: Thu, 17 Apr 2025 00:32:45 +0000 Message-ID: <20250417003246.84445-18-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 24 ++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c b/drivers/staging/= gpib/tnt4882/tnt4882_gpib.c index da13d11c20bd..d26a388912c9 100644 --- a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c +++ b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c @@ -1122,7 +1122,7 @@ static int tnt4882_pci_probe(struct pci_dev *dev, con= st struct pci_device_id *id return 0; } =20 -static gpib_interface_t ni_pci_interface =3D { +static struct gpib_interface ni_pci_interface =3D { .name =3D "ni_pci", .attach =3D ni_pci_attach, .detach =3D ni_pci_detach, @@ -1150,7 +1150,7 @@ static gpib_interface_t ni_pci_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_pci_accel_interface =3D { +static struct gpib_interface ni_pci_accel_interface =3D { .name =3D "ni_pci_accel", .attach =3D ni_pci_attach, .detach =3D ni_pci_detach, @@ -1178,7 +1178,7 @@ static gpib_interface_t ni_pci_accel_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_isa_interface =3D { +static struct gpib_interface ni_isa_interface =3D { .name =3D "ni_isa", .attach =3D ni_tnt_isa_attach, .detach =3D ni_isa_detach, @@ -1206,7 +1206,7 @@ static gpib_interface_t ni_isa_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nat4882_isa_interface =3D { +static struct gpib_interface ni_nat4882_isa_interface =3D { .name =3D "ni_nat4882_isa", .attach =3D ni_nat4882_isa_attach, .detach =3D ni_isa_detach, @@ -1234,7 +1234,7 @@ static gpib_interface_t ni_nat4882_isa_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nec_isa_interface =3D { +static struct gpib_interface ni_nec_isa_interface =3D { .name =3D "ni_nec_isa", .attach =3D ni_nec_isa_attach, .detach =3D ni_isa_detach, @@ -1262,7 +1262,7 @@ static gpib_interface_t ni_nec_isa_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_isa_accel_interface =3D { +static struct gpib_interface ni_isa_accel_interface =3D { .name =3D "ni_isa_accel", .attach =3D ni_tnt_isa_attach, .detach =3D ni_isa_detach, @@ -1290,7 +1290,7 @@ static gpib_interface_t ni_isa_accel_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nat4882_isa_accel_interface =3D { +static struct gpib_interface ni_nat4882_isa_accel_interface =3D { .name =3D "ni_nat4882_isa_accel", .attach =3D ni_nat4882_isa_attach, .detach =3D ni_isa_detach, @@ -1318,7 +1318,7 @@ static gpib_interface_t ni_nat4882_isa_accel_interfac= e =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nec_isa_accel_interface =3D { +static struct gpib_interface ni_nec_isa_accel_interface =3D { .name =3D "ni_nec_isa_accel", .attach =3D ni_nec_isa_attach, .detach =3D ni_isa_detach, @@ -1377,8 +1377,8 @@ MODULE_DEVICE_TABLE(pnp, tnt4882_pnp_table); #endif =20 #ifdef CONFIG_GPIB_PCMCIA -static gpib_interface_t ni_pcmcia_interface; -static gpib_interface_t ni_pcmcia_accel_interface; +static struct gpib_interface ni_pcmcia_interface; +static struct gpib_interface ni_pcmcia_accel_interface; static int __init init_ni_gpib_cs(void); static void __exit exit_ni_gpib_cs(void); #endif @@ -1775,7 +1775,7 @@ static void ni_pcmcia_detach(struct gpib_board *board) tnt4882_free_private(board); } =20 -static gpib_interface_t ni_pcmcia_interface =3D { +static struct gpib_interface ni_pcmcia_interface =3D { .name =3D "ni_pcmcia", .attach =3D ni_pcmcia_attach, .detach =3D ni_pcmcia_detach, @@ -1803,7 +1803,7 @@ static gpib_interface_t ni_pcmcia_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_pcmcia_accel_interface =3D { +static struct gpib_interface ni_pcmcia_accel_interface =3D { .name =3D "ni_pcmcia_accel", .attach =3D ni_pcmcia_attach, .detach =3D ni_pcmcia_detach, --=20 2.43.0 From nobody Sat Feb 7 23:37:20 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97131216E30 for ; Thu, 17 Apr 2025 00:33:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849993; cv=none; b=tBc1uxsDus+OYinVspV55bY5N0O+lRwfboYS6Ax8xnB/1LvrJ46U2zIibDQN6RhxP1Kd4VgcU4/xdLwzN0y8ULKB16SfI2XGHiGJ0hMtgGhrFoX0Xn7SBiQ+PtBpFWLx5nRjjib8HIGw5aXYt94MZdcJwfFB4ZEc3GjMFS2PisQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744849993; c=relaxed/simple; bh=1yv5YY4t0Wi3X/jvcxjgbarzHO5IICMFfCZkUFOWK6w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MIEkuMPANzDV+44NFsQnAvvsg3clIHC736FlPBV2bLVmpFWG3PF9pS3bNa0+Qw1MFcB8BRzs80reMBn6uHXkZGP6SVKgDTatGhcqF+k6omcZDZlWVb90Hrb1PbMr9DFZ+ZVNgcVZsd2anEcmKCuojChsDPyLW/3usN59/7sZJAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=jsMxdm1U; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="jsMxdm1U" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-224100e9a5cso2613185ad.2 for ; Wed, 16 Apr 2025 17:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744849990; x=1745454790; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mNJv0lcmYb9f27nCiWvpiCIAVgYIbFQyGmxFaNMZD0I=; b=jsMxdm1Ukn6hsC+94BPnFfE0p0y3iljCjlWOwAoFOpFfwnTUN8IsGVVSx4sN8xYnLB 2p9w6WdNRDHJrAbswzPtAexHx2V7u1ZizI3WgnPY4oF7pDxnxeFoap4Bw+uwzwCSTX0F nrc+u8ORWzbceWR/oZGCoFzduOddZIpH85CmnAsYznnm3iDSl1LGTMI4tKHNBtQgBWr8 Un15y+LOoWRr+8JQLOYmsLHgF4+vXrbyBlv3pQv1XZHRfV2Sy7NdJqH9lvZ/xQ0m4eBx O00MCefTALhzyxKS11Z13Xw/E2uE62eYNTTAV16oSUZxt3aHAMEflKUhI1fbCxbQtEtq XQRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744849990; x=1745454790; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mNJv0lcmYb9f27nCiWvpiCIAVgYIbFQyGmxFaNMZD0I=; b=eL/aaNCVTCvjDR0O+/kCr4wnoZmNlY2hJHZAr99DWPOKfNCJAW2C/J/EUvEgmlxldg JLdmaaMG0I/oJ+lJXkbkbMGS7EXv6xLYg8A1yRrGbZgn27CijyyHGze5KzCJ2Y1svmHC HPLUga86UNcrQB7Ap3iUrzrC1LunTnj0D5g7ty2pjl+MytXoaXdK/whFYeyQToHCFH/I ZF3iyBhMCKqF+9VVPEjuJXAbHFj8qiHX7r05p+UWvUJWPwJ5icmlsfqCzOpkVvge3fq9 c/rLVduTTLQDqjB246Z2HOgNu3He6idJNpkdYhqzOlTPef0q80AAnZKvN03MT+CeJvSG QjHg== X-Forwarded-Encrypted: i=1; AJvYcCXeLYuBJB5tbXaXjapNdPTGbea6dwyWttBZJK3Iz+j/GRJtt01/sedMead4NLnYMVN8FnWu3YDO1sRypUs=@vger.kernel.org X-Gm-Message-State: AOJu0YyvqDOfhUxSGTeCL6ltWRcGL9vLqqfvaIi1SbVKx54buOrQc9Lq ZLeYWJr11Wb2tqZrE5/xwcy2mTPt+9bN5wCE6FgNgf618p7ROYqzyQgMDk5msA== X-Gm-Gg: ASbGncsP5YkSurNvqHFkGMIYgbkAxqvOHDaXDHE9k/sKgPxY29PI/aP26Epoxmdpn6c ISRH4EXw+Pi89ZL0Ea4KCTqNKCyo9uHfO2BQcndfpqvrNABaO32ohR/5tbpd+tDe8im4mznhV4C 5ov7f+LZUPiD+4dAmDPG4m5rzAKjsJeBxcrasGb/BTCYVCxfN3F3nDrgVVr99x8bRhnSqitK06T s5Cqx3+vmHo4JyHMLRkm0WfG6zHg9agl9IiU2kEnVBdyk4PQS5FmDcFdY3iSGJBUQwHHH7VgsvL ZuaapjUbafKU6RH3TgKhQXbg/YxMd/PmZCzcYLnh+HkQCs2H3gY39QHgpWj0u9xUJ3M41RoQagK 6a+6PEw== X-Google-Smtp-Source: AGHT+IFt5YbjpyD8D2gQOKv05BlHP4z3woA0O9Kc4hWd9HjFvBJUKUheFmrQ3NAFaHH4nieVN2A+aw== X-Received: by 2002:a17:902:ecc6:b0:224:2715:bf44 with SMTP id d9443c01a7336-22c358d710amr58076925ad.19.1744849989906; Wed, 16 Apr 2025 17:33:09 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33ef0e6dsm20876565ad.52.2025.04.16.17.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 17:33:09 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v3 18/18] staging: gpib: Removing typedef gpib_interface_t Date: Thu, 17 Apr 2025 00:32:46 +0000 Message-ID: <20250417003246.84445-19-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org> References: <20250417003246.84445-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Removing gpib_interface_t to adhere to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpib_types.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gp= ib/include/gpib_types.h index 712987ca139f..0dbe45894884 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -8,7 +8,7 @@ #define _GPIB_TYPES_H =20 #ifdef __KERNEL__ -/* gpib_interface_t defines the interface +/* gpib_interface defines the interface * between the board-specific details dealt with in the drivers * and generic interface provided by gpib-common. * This really should be in a different header file. @@ -22,7 +22,6 @@ #include #include =20 -typedef struct gpib_interface gpib_interface_t; struct gpib_board; =20 /* config parameters that are only used by driver attach functions */ @@ -212,7 +211,7 @@ static inline void init_gpib_pseudo_irq(struct gpib_pse= udo_irq *pseudo_irq) /* list so we can make a linked list of drivers */ struct gpib_interface_list { struct list_head list; - gpib_interface_t *interface; + struct gpib_interface *interface; struct module *module; }; =20 @@ -222,7 +221,7 @@ struct gpib_interface_list { */ struct gpib_board { /* functions used by this board */ - gpib_interface_t *interface; + struct gpib_interface *interface; /* Pointer to module whose use count we should increment when * interface is in use */ --=20 2.43.0