From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81495229B3C for ; Wed, 16 Apr 2025 20:42:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836130; cv=none; b=PD3/S+cv15dylpJQMba+JFnWgjhSbQ00CC8VUTMLQY979awyHK9TbHJMGCAEkpn2WjXdeT8+JJnYzwm53LqW5eyLYPty1GCp33Cz3UzEsbJbxAfHP6d+xqutojeohBTJI0RZzQ2hdsARbUtoGED/MiYlGneJgTUAoZDPjgiXj+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836130; c=relaxed/simple; bh=jG1VelJdYtxDypcUuL37BKnVeljiwv8UHZSTxXIdltA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lM3Hk8Mm9r95vibSxA1hHoQ6zG7ozlEzC5fAz2Q0tXv78kfeTNy9TZs5Ep91WSsvMvAjCYjZxXeEYmz76jNk3RR/KxikIvlmATbcDU/XYQ8ziaKjA56evj7QrN3qqbsAbrbFadkT4V2jfd8l2h1wQ4w+xFJ6N4rM1bcFffQ6+ao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=WZsJ6E2G; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="WZsJ6E2G" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7399838db7fso114173b3a.0 for ; Wed, 16 Apr 2025 13:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836129; x=1745440929; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TcFNiziR7pgxmZ4Nao78oOa5IfNUpz+8UeC5Li23vnw=; b=WZsJ6E2GhWw3LCY5q6gCIOUYPW0Y7KFtL/EgnzXmehdiIqAi7m+z0MmbomBmgIoCWc hJiDK2aUU7Pl+f5MUxqMT1TWTLiSx5QZhujTuOYIw2Q/xVcnIhpI/OcjJvBNmFAuuCMN 2FmF+3vKJtbre6bL2jE+B28OO0c2BWDnWtQSIYhawWimVEjaXMuvfkAOHLOI9f19Vslw d9loprKP0q1Q3PPdGj9yqUd6fD7+GsgJtZXqBvVQnDJ1PI6LuJ0UFhlXZjXMB3ZnCd0N 3A8+5vJMG9nvGSSZ/eiYL2BUXH90iheU89z7eqhZatHDZlHYKGiBZWeKmRYnrZdHGAZL ksxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836129; x=1745440929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TcFNiziR7pgxmZ4Nao78oOa5IfNUpz+8UeC5Li23vnw=; b=daemz7/iBSFlccrm+aHWT01466Gndm18aNJu94j+t1rURvQbtK8XdcuPllcuwNqTP5 6PNXPncMkYmjJUWQfognG/uHRgPwYwR+xiqH6yMG/vtXSv7B3zFaZtCRTEwLfLrZh5Tv xjTyvy0Dq28WvPkBxlXRWnO78famwA83bFGnXQOXvIHj52fIdizJ+LvkFB2+xKblXhCT V5EEbGuKrklALp0/HKfr/84t7+Ifu4qWZrhGOkHVhkp6FfG2AjJCvlvLfYzn7iSBEteW XYunfnOfbQpI41YqRCzyhWKpAcsfqHRFh7XNQAgTuZ3xBqsxHFQ/a1YMB70+N4EEVhA/ gRdQ== X-Forwarded-Encrypted: i=1; AJvYcCV57G6RFB+luxA/t226Mw/bCSzJar62FXf9JlUbMulqM+2XtbUEbAcjqMohJ2dkFvs8EvsFMK59ptIOphc=@vger.kernel.org X-Gm-Message-State: AOJu0YwfXG7f8v2UAEuS9CEhHTAOepDHKdE3SvpWErfKgwdNbgBYeFaJ V/apOGpzg97xBlQHDBcY45DkiLOFx6UpeaX+cjBApR7+sTP7wgO3UOMuegbPfA== X-Gm-Gg: ASbGncvQT87kmHwLGESwh1U4VMRDg92MVvpnD+sLfOZcDsZ9I38bqXid2H8zScf/7rA aUwIerGClNwLbePBQCYWFdaNruLyNXHG54sWqPQepSJFh4kHTprWzuC00WUEAhcxH3vBBbFssVP hAQHjlDJKaljuI6FM3ccdxBpwGTQNTq/gq+WRnt26oTEgI5k6jZBgZ42d364jgOloHwHPq2VLgd X+CUgyIeiz46etKfWeGp9uhHUuvAqBIgRslNAG26YMWzIMZ6XMt2SDWDhiNabEk6L5M51xAyi44 TRbXP0/gDLp2WQhEX9l7aPKlRifRHjub2W2232DvWX33vqNRohsEamX39OVAbAmdGGbwMarDf0y pfP6LRg== X-Google-Smtp-Source: AGHT+IGEAC+9Fx62N9LnXooYFVA84nS16E6az2pmB1QBovtDSpEiRCS3qzu8aY6+MCPzNSZttazrsg== X-Received: by 2002:a62:b405:0:b0:725:4a1b:38ec with SMTP id d2e1a72fcca58-73cdbef5484mr445038b3a.3.1744836128662; Wed, 16 Apr 2025 13:42:08 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd230da87sm10880120b3a.127.2025.04.16.13.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:08 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 01/18] staging: gpib: struct typing for gpib_interface Date: Wed, 16 Apr 2025 20:41:47 +0000 Message-ID: <20250416204204.8009-2-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" "Having the word "_struct" in the name of the struct doesn't add any information so rename "struct gpib_interface_struct" to "struct gpib_interface". Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpib_types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gp= ib/include/gpib_types.h index 71af9e808a76..16aaade310fd 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -22,7 +22,7 @@ #include #include =20 -typedef struct gpib_interface_struct gpib_interface_t; +typedef struct gpib_interface gpib_interface_t; struct gpib_board; =20 /* config parameters that are only used by driver attach functions */ @@ -51,7 +51,7 @@ struct gpib_board_config { char *serial_number; }; =20 -struct gpib_interface_struct { +struct gpib_interface { /* name of board */ char *name; /* attach() initializes board and allocates resources */ --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F5C3232787 for ; Wed, 16 Apr 2025 20:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836131; cv=none; b=G4d/7SkXgvgKSxxssYBqqivBh9a+08OL8/ozPHfaOh0AKx8kZtNuVp+tZIjhaX4QHuRJQ8uoHaOIGSK2rB/hLZXF9bzN2KxOANug9zHeBN0lDkoYA/t4hCZOeywwdgum7KdSQlVRiwq2qN/Yc6a/cObxTW+SuwveA/Wg4CeFfcc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836131; c=relaxed/simple; bh=TRUv0Lx9qIYRkHYXYiephf2tTbsRuyIpmQ7XTHKKyrU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aH4eXrGuilNS/hlpUE43ExZBKTB2z31zjfoo+PInSFFXpYcULa///9B2du8W1rSKubWzW4GpKqQizvmBPbb1qwegKf9pf9AU3nbancKyyb8nN7wOuPHSD+GlB3FzUrUBHUgPEtwi1hWuRIBIr4ZOV1KMHGi8YV4BU3nCMVef1HA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=IZx0PLmB; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="IZx0PLmB" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-22c33e5013aso1357015ad.0 for ; Wed, 16 Apr 2025 13:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836130; x=1745440930; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dsbToqR2eAba/23hpGloCvJcl86xogM+KUwP2i6K5Dw=; b=IZx0PLmBetz8GlPZdVFH3GcSev0udJos7OWui/7ZYwgMzvDvvE23ntkHKGdhtusnU4 zjFnRnRJvHJnf4I5Bb2Ut3U9RDaZkdhiEfwxq6i1kUGMKaHInAR6RQQVe2XHylgoHt1j Ar3Lcw8NDJE9ZFZFmsOwScnQ3025hzHZPpuD4TIKtdXiuE0KHFggh9vU/m72sLFHab/X 6WaesRNl8rBov5VDGysrn9mu4uwVbuwjhKWiIbmddctmj0W8YYv1bzkz7O3PbeVuewUa skBQNMld+DGY7Lm/q4xhI6qTWsDL11OCEHkPtVv1SoNzKUOTsEEo5PydFYccHfdC45Ik T7iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836130; x=1745440930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dsbToqR2eAba/23hpGloCvJcl86xogM+KUwP2i6K5Dw=; b=J03GCey/vJ2zfJG8n1RYayv3QymK3RFlYw9+XRKlqX7Xm2PGic739kWXney8LTLsW7 z7UyqLJxeTQSmmTm1CZhne6JGGUQ5dGUyj1srlvaLZY+EEJvaA61cVl1PYLuEGCkhF1i J/r0T3tRCQzrgpXC5Twa+5SE1ZAI/6XiBIVoIduxpVkhWNBe7a/e+t+J4yaFZyPOYn5y qOU80i9RQs0Yio5SYct3M2mie+w520kCXP+/UUZ3We/o9caJUSOoerQ8nu3A2JsRb7QB YKG4Yy7xpJgE0SEKjVuK4xt9n5O3IlEvZN1xSyfXKUzOWgZ6uy5dQe9M4NxJquWqEpTF A6HA== X-Forwarded-Encrypted: i=1; AJvYcCWkwmtjU6sYb3g+joPTt0bCkmCsmPf38Z4WgxKZzyHIuTFtPge+hp+nXyO45CUemP/a8uz1nn5wlP4zRx0=@vger.kernel.org X-Gm-Message-State: AOJu0YyEHDMr1dM7FpxNBGd6KH9rLxN2khvPd1rn/hq/9vPVQAYDo22R pONZEuqOFGUNjByYAX0yUzFO7k0OaBckumfJDBLyKeLLVPb0nN4RVJ8ESwdt6g== X-Gm-Gg: ASbGnct7On1k/UCRZOKk84uwex0lXyiwvkUlbWbVT/roF9LxGdljkb0X+f4q8DQbIbu Fgywf2k900YOSr2m+39X22DlqdZx9nv6/p2uqV6vrwiiej7p5leNYFOzQ2sO8douHpgiQX6GqE7 fOzMyrqrQ7ab4aRY/AQirA8WHu38Y4eCy75kQEem5gko8h8dbYShCh9J/WqoENguuqHMUpcdNP3 0TOGNyrwrxcb694qED3COw66wGd0FOWtWLxZBNiNyUZIHgRD/PKYja7jt7BnXzAD74CnRNvLbAa qwQ3c2pncPaw4uYU2r51WFS6FscETFQW9jwl4m1J5tjWsOueJj9m/1bzBp+qGm4Y/Pd0ud2e/3G RZOzJ8Q== X-Google-Smtp-Source: AGHT+IFchMugIT2n9/0iO9Fu/n4Z213xFLKHBSZJPWGuKhQ/ZsCoXn/li8GCNELI2QxNen8CwXI5Ag== X-Received: by 2002:a17:902:cec5:b0:21f:61a9:be7d with SMTP id d9443c01a7336-22c35983aa0mr41389005ad.49.1744836129830; Wed, 16 Apr 2025 13:42:09 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd219894bsm10934022b3a.34.2025.04.16.13.42.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:09 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 02/18] staging: gpib: agilent_82350b: gpib_interface Date: Wed, 16 Apr 2025 20:41:48 +0000 Message-ID: <20250416204204.8009-3-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 97717afbb214..901f7182502b 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -773,7 +773,7 @@ static void agilent_82350b_detach(struct gpib_board *bo= ard) agilent_82350b_free_private(board); } =20 -static gpib_interface_t agilent_82350b_unaccel_interface =3D { +static struct gpib_interface agilent_82350b_unaccel_interface =3D { .name =3D "agilent_82350b_unaccel", .attach =3D agilent_82350b_unaccel_attach, .detach =3D agilent_82350b_detach, @@ -801,7 +801,7 @@ static gpib_interface_t agilent_82350b_unaccel_interfac= e =3D { .return_to_local =3D agilent_82350b_return_to_local, }; =20 -static gpib_interface_t agilent_82350b_interface =3D { +static struct gpib_interface agilent_82350b_interface =3D { .name =3D "agilent_82350b", .attach =3D agilent_82350b_accel_attach, .detach =3D agilent_82350b_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF8AC2356B7 for ; Wed, 16 Apr 2025 20:42:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836133; cv=none; b=uIYm5SDPpwSstZqeCqJB0wJamty8/qMxVIZi3Gp7Ax6zelHMZKbVKUnI8WtN7B7Cmbr0jUPxnm9nivL+K5UAmQJR3zlhuFjgNTf3hGt+IJy+lBsGfWLDusMZB1kz3pp1KPAhpK6+aRxEQFunqYGoCXhcr0qjhMBfb1hQWVqYhVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836133; c=relaxed/simple; bh=9qC6SADjVBvrGdZqgD61dD4ij9DtU63SWTFy4hBsTVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bNowL53Ii/1DDzRuu3vBz6Gwr0PtvoYxEoINPUfsHqyTNrbr/M7843frj5BkppuVebTpsBZGHjrnE7VwVQzjciOpm7AptGwS0mvZCdiIvsJPZKogBrkWkMPGfVGQVDJGqx1kv3p6xRzQpDRoM+woQK2kFZLoFR57yRkYiDwuccE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=NQYQY5Nn; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="NQYQY5Nn" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2ff799d99dcso18341a91.1 for ; Wed, 16 Apr 2025 13:42:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836131; x=1745440931; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WSCp68TzSTwAIQNUn8peisTtRZqQcqQfdhU/AvOcNRM=; b=NQYQY5NnxUv3NvF/QbfXpq5uTBhIpwJpeZLWVHI944XlRrZfY/4sy+nFOV3fx3g4qr P48C46lWLJOleUt9RjT9gfql/MfJ5IiPj1C4cboOGRbOWLclwPARpaSkmeyzzVMfLxvV WstT+sL2GDi5jRZc5r+sIz0X18VtNsqyMhn/bm/RJZxLFqOjOiLKwFk+/aaX4XMEe9US sQpoWKTEMKKoCDzp6S/vGpCvARbuYlVaelU34rHKo6um6CtBrCTHxt2nA96MyfBJpWnl K0+d5oTdEelY+I8GKt3RktyqhyrF2H3FidQw1XqXOfyUR/srvU8QMQH0Y4IurBmg+fAH njLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836131; x=1745440931; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WSCp68TzSTwAIQNUn8peisTtRZqQcqQfdhU/AvOcNRM=; b=L42/0Zy3KmU51BYGLpnhMJvA1iLgHWNsGBdJSZgpFBhIwHApX6lLUnCV46Mzw2D5CP 1F29NSB6sZlRcaewj+NTuv1GNGyv7vKMvSB868cF4Hc+630IR5GuDbb2nMNYrqD06z85 BWg0we65vICbIeJGRRg2joXOUTMzGbACZiaJ4Rj/ioiwbi6Gy+0EyIrhqWXzvbW87bTZ z1W4VD+bwvD5sEn2DYO4x8iypnZR7xvXlG40XAucCtuZSdszIcGVEhQhBVu5Qh1kvS9f bMii8B3Wp9MpSH5EJ94i77sEeBSWQLZ/v9Dwq5KOa8m7sQiKU8SCcf5Ho2pbWpABiIg/ mAcA== X-Forwarded-Encrypted: i=1; AJvYcCVKGP7qbsRFhci4DRC12tpppje64XblWPXMv/3+9ZttcQq4SX0qNRiRPjCo6vPmiligVoWAOz0wczW+eFg=@vger.kernel.org X-Gm-Message-State: AOJu0YxniI8VWWfJzMeZ0y7hxmPAFy1Zqp7j85Sxl6KZgDgacvoR57I+ 8KjePtVWpgDZzto1yGFJqdOWMQ/8ogoPsL0bhFysMl43qzkfFprh9bq7GcMHhRSxq/SB8oXZLpM = X-Gm-Gg: ASbGnctcwe6fLJ1Ev7rXyhf98nuckPqs6x+05/GGLznCcYp4b5ObUE3yy3jl+ASQm2h RIdT4wMQYRomNU4YhbhTOsk78t6KjeLVWGOHeBawWLdiuLrlbemN8eCalLvC9ASanVlD3G0EFef MYTHdDR1lWXOEw2vzOuygQklwruisIt7WU/A/cSo4ouZVf3+8JMB9Oq0MjsT0o9o/oaTxrSalaM e0R1DyZSevVkfsb3RU9CfXEad6viK6K4+RfnWq97EXTYvssBmt9ErpED6iPUsHp6jlGZB/l3Taw ylMUVkkXB0w0RwfNnfcaiXM8hFRw77rovacsdPqC2fCT4Zsnl21cs9G6DbZQAO4C+3CmZuZg3OJ qxdM3YA== X-Google-Smtp-Source: AGHT+IFUJCXUb8UliTOdXtwXcqyxAlTjdp3qL3EnJlnAZaSnWvHEsplxd3fYc7soqNPAW70n8SA9Tw== X-Received: by 2002:a17:90b:53cc:b0:2ee:45fd:34f2 with SMTP id 98e67ed59e1d1-30863d25d6bmr4360821a91.6.1744836130996; Wed, 16 Apr 2025 13:42:10 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-308613cb07esm2088367a91.44.2025.04.16.13.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:10 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 03/18] staging: gpib: agilent_82357a: gpib_interface Date: Wed, 16 Apr 2025 20:41:49 +0000 Message-ID: <20250416204204.8009-4-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers= /staging/gpib/agilent_82357a/agilent_82357a.c index 7076e9f57d69..9e41fe611264 100644 --- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c @@ -1434,7 +1434,7 @@ static void agilent_82357a_detach(struct gpib_board *= board) mutex_unlock(&agilent_82357a_hotplug_lock); } =20 -static gpib_interface_t agilent_82357a_gpib_interface =3D { +static struct gpib_interface agilent_82357a_gpib_interface =3D { .name =3D "agilent_82357a", .attach =3D agilent_82357a_attach, .detach =3D agilent_82357a_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFD1B238D5B for ; Wed, 16 Apr 2025 20:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836134; cv=none; b=N+nLECuSdNHxpIacaS7hNJ4l1lDiZsWLVQUWbNE0dY7t1xTQVgOUZ3+sVKNL1wYwu6hBUbbxZm8gWhPsvK4EDLmPkBnRvXSFKvOGtmfr1E3oo9s/CQYg6LUXNEqLvodVbHB2uq28heSy7wnCb1+WicnS/tX7YTSPCth7sf+/S5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836134; c=relaxed/simple; bh=pZUC4ylofhNxwo4hjzJ3ORj5g9m8tUYOPnTEG2mtgeo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NSUit58RygWE8jzQdBoLhwOQuUk4KVKup+xD5YuHjL7DtDvAu4Sdl/SQWfSDEpZWKGUdb8b6a0x/xX0l13uoVcGuQqBH3yWr91a/3TtPjr0yfl7UcoqAkEuxWlGvx8IdvMIQtTgyem+C8ApbTBQcIY+Ggt1m3/Fy80FEOi200xk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=PHelqR9x; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="PHelqR9x" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-22c33e5013aso1357325ad.0 for ; Wed, 16 Apr 2025 13:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836132; x=1745440932; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4oZK0xozCaFDbvJQEqimY0ELWSNsTb2XtNTRfDwp9c0=; b=PHelqR9xOVYEYIec6QOpi3ZOekQhqDGqVv28D34BfQHOX6+mPOAPFWLzT1kn0J7YUl peVV/GL1v7ebVZIMFohJqBS/Ff1XHZSLwNWeEil6uVpfV90uiZ4+D7juXmmUgtDK+b5f RhsOmh8qWSirGq28Eax0PY6R7vahoNcY0mLv0SAiBhwacFKlR/DDn62kziNaQAxL1L20 H4Z2ApFDRiw+baapBjfZF/HBHrOqeeoku6IcAZfR4Uh/H+I5w2K5JOpRA2sGc+AjMBHU rUBkUeImDmRfRXV9f/yCkde0c5O50ATKfmfEqnjXEcBS4MD2Zo3m6D4CMm6QhZur7Uqa Tl8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836132; x=1745440932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4oZK0xozCaFDbvJQEqimY0ELWSNsTb2XtNTRfDwp9c0=; b=Lxt/gwzabGodABjIldRza10Z/Tsdjw8wlZ/XdiF+TkNSfWPJXa9zIlVe7CEULyMvf9 sHvsu2GTzZ//qH5Yk8Kk1dn7+KRfjP1cf91lLvxOsiKrINJ5v/jgdlpCwWJxUo6H9LdE +14efsZhWUlJranKDSyk8HK1zW4Dg8XRXHxbtXKf+kQ7uZ7zoaAJNCCMLPMeUkUeCf8I 4iseYHbC0tTGYroHdTuH0CtVov4ht2g1fHMbqpF3KeK+kdnwXjrsHc7Oar8DFYK4xD4m wio4EpoercheUnvysEC9jEF3vPmiirDzapGlSBkEWcWwEWm0Qj7v+1yj++eOGiTZjL75 hRYw== X-Forwarded-Encrypted: i=1; AJvYcCXVwyQLLyW7Sx/uZGRgtzWAw0DQtQ3r8yQiVHb8tjx7qfgUT0pKvGzRKZ7BCiBGqesHmZr1JOpLRP4dA4s=@vger.kernel.org X-Gm-Message-State: AOJu0YzywLwbbeV41lFVsikN1tRaOTt3ZQKWstqJPzxDrePLGH34qYLv +QDCVw8vEF/st6sjYt6wy/3MnMjMRRC9cDs/I/1JsFzbHSera2eqOCrHMhj4IA== X-Gm-Gg: ASbGncsfLMm9qx/lpYzeV0Rv3IgtiEAKGsulKLwW9WbYiErwB/J32aF4ezWW3oKrOgg mHcNYJex97xmMuhqPKXUnCr6UKVuWNY24AcrJSgTEBm1AvHlZCpZUWqKbrAbY3EI5Ds6nYBbYUR xjykgQp4Lp5jlWOIqpxhsnNQxqIBt/FlwFwYCa7auzsb8vD1KPye4L3LBPNKXU/TQ6nWJC6xNp2 T8fRZWLDdgdBaN89MupBmghzi+leQxpm4V9i3ztcwUE+Hy3HSxLNv+SGN2bgKxmONzkO9azuF5b 4jh1aYoEgw5H/z90GQ9IFC1DVbFsnju9POHVTl6m2AJRxZEqnN+t623AiOk6Ddpg+ax+fJ0QEfD qrXn8lQ== X-Google-Smtp-Source: AGHT+IH2QjEiF8BA9vRwv8cVExSmGxjUbazbC7L/d/yd17lt7vit8Gv45ZGPWCg39eE4HwM6SNwDSQ== X-Received: by 2002:a17:903:3202:b0:21f:988d:5756 with SMTP id d9443c01a7336-22c3596b8d1mr54714755ad.42.1744836132166; Wed, 16 Apr 2025 13:42:12 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33fe6894sm18836745ad.215.2025.04.16.13.42.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:11 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 04/18] staging: gpib: cb7210: struct gpib_interface Date: Wed, 16 Apr 2025 20:41:50 +0000 Message-ID: <20250416204204.8009-5-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/cb7210/cb7210.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb= 7210/cb7210.c index b15ffc777c39..54c037aabc26 100644 --- a/drivers/staging/gpib/cb7210/cb7210.c +++ b/drivers/staging/gpib/cb7210/cb7210.c @@ -686,7 +686,7 @@ static void cb7210_return_to_local(struct gpib_board *b= oard) write_byte(nec_priv, AUX_RTL, AUXMR); } =20 -static gpib_interface_t cb_pci_unaccel_interface =3D { +static struct gpib_interface cb_pci_unaccel_interface =3D { .name =3D "cbi_pci_unaccel", .attach =3D cb_pci_attach, .detach =3D cb_pci_detach, @@ -714,7 +714,7 @@ static gpib_interface_t cb_pci_unaccel_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pci_accel_interface =3D { +static struct gpib_interface cb_pci_accel_interface =3D { .name =3D "cbi_pci_accel", .attach =3D cb_pci_attach, .detach =3D cb_pci_detach, @@ -742,7 +742,7 @@ static gpib_interface_t cb_pci_accel_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pci_interface =3D { +static struct gpib_interface cb_pci_interface =3D { .name =3D "cbi_pci", .attach =3D cb_pci_attach, .detach =3D cb_pci_detach, @@ -769,7 +769,7 @@ static gpib_interface_t cb_pci_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_isa_unaccel_interface =3D { +static struct gpib_interface cb_isa_unaccel_interface =3D { .name =3D "cbi_isa_unaccel", .attach =3D cb_isa_attach, .detach =3D cb_isa_detach, @@ -797,7 +797,7 @@ static gpib_interface_t cb_isa_unaccel_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_isa_interface =3D { +static struct gpib_interface cb_isa_interface =3D { .name =3D "cbi_isa", .attach =3D cb_isa_attach, .detach =3D cb_isa_detach, @@ -824,7 +824,7 @@ static gpib_interface_t cb_isa_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_isa_accel_interface =3D { +static struct gpib_interface cb_isa_accel_interface =3D { .name =3D "cbi_isa_accel", .attach =3D cb_isa_attach, .detach =3D cb_isa_detach, @@ -1334,7 +1334,7 @@ static void cb_pcmcia_cleanup_module(void) pcmcia_unregister_driver(&cb_gpib_cs_driver); } =20 -static gpib_interface_t cb_pcmcia_unaccel_interface =3D { +static struct gpib_interface cb_pcmcia_unaccel_interface =3D { .name =3D "cbi_pcmcia_unaccel", .attach =3D cb_pcmcia_attach, .detach =3D cb_pcmcia_detach, @@ -1362,7 +1362,7 @@ static gpib_interface_t cb_pcmcia_unaccel_interface = =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pcmcia_interface =3D { +static struct gpib_interface cb_pcmcia_interface =3D { .name =3D "cbi_pcmcia", .attach =3D cb_pcmcia_attach, .detach =3D cb_pcmcia_detach, @@ -1390,7 +1390,7 @@ static gpib_interface_t cb_pcmcia_interface =3D { .return_to_local =3D cb7210_return_to_local, }; =20 -static gpib_interface_t cb_pcmcia_accel_interface =3D { +static struct gpib_interface cb_pcmcia_accel_interface =3D { .name =3D "cbi_pcmcia_accel", .attach =3D cb_pcmcia_attach, .detach =3D cb_pcmcia_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05CA3241139 for ; Wed, 16 Apr 2025 20:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836135; cv=none; b=ndkSh3tOnqIw5Dw4ijGneKWByatmeO8fa+2H7IaqkzMW+vTrNpbxM6SFceVS/7TbQl+W48NwAKrmlhCNigxYCTi30QcQ3SMtZE00LZzMjprK3XSxawu0pbIzPwSPkZBvcsc5fYC8igiBtlwRIVFd6M/0ea/GhsG73JyDdvdcMxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836135; c=relaxed/simple; bh=QaMlya95zkc4MjQsjQDNT36UA9lQmCeo4nFFSkNr0Jc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LtIEeROpt44fS93iEzN/PQMauixqdwaBY24TQ2ou1C6Lt9soQKT8XlQFJ7n7MyVxLveg5U4Rrfq5rrvEoLygTLc9Y3aaMfj4LJyI9d6iLOhidE7Cg86N/yYKYG5aXXihCAQkzD+QGkV7OhJdAIG6sj9uEClvfEsHU6xr1sGhRXw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Y/ArH2mA; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Y/ArH2mA" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-3085f827538so40539a91.0 for ; Wed, 16 Apr 2025 13:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836133; x=1745440933; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GAwcN61khauGEX7eRicTPKijk8SHQIgYsxBV6pw5EIA=; b=Y/ArH2mAcO/P+h8tIIGJBuuvOwzHNdEDExzBbuWWuT0YuUyg57viWTnwNdDv9sE+u/ M6MYy/5ChaE/oBJSfRyGqN9VZZWPVuffqKUCnsr91rPfVXckMykAkVsM68aak+a5Ihtq jD1MdAr1Zyb89+vyE93jv8ZxS9ann9/Vndn6lX3nEWFxMK2CaHiAwxShAHOJYaLLKKTf +ofVE9URsO7AfOtML+v/LQbFC4bESBDCTvTIFAvM/+0Bccmmrdh9+JvfA2u+NYNm2yYD 7y4EgeHWREYA4mp0xZLpw75E5SulfmJ56ztaVWC9zu6lg27TWig3wFS129XBDx33QVK+ c9bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836133; x=1745440933; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GAwcN61khauGEX7eRicTPKijk8SHQIgYsxBV6pw5EIA=; b=UozOmhGDZwT2EOL5k9dBPRJQH1D8nhMELw8nxu4Edjhr2HVq2b5qAQWZe7WGPuVn7Y 0NnS8ZJiMGOb7KKRXJKLdLwyxYFAqZlrLDuG+2C1GNuAooIvgAq2lLcAV3DF3k1DJfWK q3b8YOOAY063KMp59XNGTXCdRWFXtPHx3sBlHmC1rfho1ZP5ZCMsif5gHtNj6FSWj2+x Fgo4qzwjLAmnd7SQocU20t9HUMjUCe3smQFa2SO8C8Ed59ZvtUDfO/j4Q9Dr2pZeZFgq A1qeAVExFVq3/WJxWDtzgvI6SvI2FA51TzoXwN0eMututbCK4EpeYdIeXOKR+l+7KuuU mrBA== X-Forwarded-Encrypted: i=1; AJvYcCWV3ZnjNYj/gQSFUexi1up9a59m00PAbmc3ZMildyH9Fk0ymenIBrakSvfYU3fWq6Bhh137VoFiLGXh7bI=@vger.kernel.org X-Gm-Message-State: AOJu0YyVzhe3Q4YKexW+W3NIFRIrrvinnOQs1n3GXkJcYu5kcS3TbzF/ R3t3eCvThBqKQoh+4gsmSMLt+CPe0JTwIYpliHeFf+FPkQfZu6oDirKTtGWgxg== X-Gm-Gg: ASbGncvM+C3lzqj6Md2KbgexNkQIcBb3T/sjXRllJlpKj0zFTv6Ou3eDuk/PLATX0vZ Gp3tcFk5+BR63seuuTi0nbv9Kw8d5JIjSL8pZbBKbuubbCC/YW1AAXyXnmqd1jPaPyLwXaJMCer KNMWCdrcTerI1Oc44vrQZUG8sswAbzuBaYShkZAwRGmzhFa2YwmW9pZOqQweQXaMZQz6Ec7CA5W k4KN6D+gsnLaRg+s3DPjj2R5jYvXyLjchZDIYaOcEYOIZw8ZVFVDK5QmkHsV526t1+4GN9Z25i8 cpU7bbfr+gADayJ+tlV6k6vcYg7V1Xs+b9QDk+5yKHuo8bjzRtm7AZTW0dIzuB4JTxQc18uNB8H QHPG0nnWp1W8Yuygs X-Google-Smtp-Source: AGHT+IEjTfZ/5+JWlyAL1MHSwYwfgw7tSppO+oNmQAkpsLIDlm3RVaShuEtrcoqhprEETHkbtgEhzQ== X-Received: by 2002:a17:90b:570f:b0:2ff:6f88:b04a with SMTP id 98e67ed59e1d1-30863f2e213mr5180030a91.15.1744836133347; Wed, 16 Apr 2025 13:42:13 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33fa5e92sm18911465ad.118.2025.04.16.13.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:13 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 05/18] staging: gpib: cec: struct gpib_interface Date: Wed, 16 Apr 2025 20:41:51 +0000 Message-ID: <20250416204204.8009-6-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/cec/cec_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/cec/cec_gpib.c b/drivers/staging/gpib/cec= /cec_gpib.c index 03d5b6c4fd8c..1b02222881b9 100644 --- a/drivers/staging/gpib/cec/cec_gpib.c +++ b/drivers/staging/gpib/cec/cec_gpib.c @@ -188,7 +188,7 @@ static void cec_return_to_local(struct gpib_board *boar= d) nec7210_return_to_local(board, &priv->nec7210_priv); } =20 -static gpib_interface_t cec_pci_interface =3D { +static struct gpib_interface cec_pci_interface =3D { .name =3D "cec_pci", .attach =3D cec_pci_attach, .detach =3D cec_pci_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 223B2247298 for ; Wed, 16 Apr 2025 20:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836136; cv=none; b=fzhB0F3TwCKRxh6Ojlrr0JUgSdJjljwMC3SfXTmS+6OpYGKj45XrBPwGDal5TlvzI/UQrQMccDDeBPvlkhkgqS8QY2ypwRP7BhtVGBPRfanCawa0pHqvAADCL4AL0oK8yjzw5fA8lEILfEG5NwLP/31m0Ige+GL4Tcag/Cqx3Lo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836136; c=relaxed/simple; bh=RSie0nXMjQWozJafxINypzZFt8eO2DZf7eBuhaP0m3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iIC59rYMfJlByjAdi0VXykgP3Y6DHa4pfEPmUVdTUhbnjomJCKG2yzd9QqDLts7xHVbw0xG76+imB7gY/nGF7BN811eqNVvY+b6HFiohh9AqChEEhPlN2TZpJr9vRrB0DXEeIO0LINsHdV/II0XTqduI5SffX3NsScU1eCMf0C0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=f4w8cv1i; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="f4w8cv1i" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-22c33677183so1177265ad.2 for ; Wed, 16 Apr 2025 13:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836134; x=1745440934; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4KbTAU01u2d1Fyhrvlbrvk8qe32/1uE4Mm7IabxHd+o=; b=f4w8cv1iNYgSH4G7MnPZvKjx6MUPMqPQNDeVzvyLmri2HLH3qzhjCtXym10g2UYXA5 mgEl0DBBwMoMbeM03bGKtvhM35erMsowAvXsDGGPYcLClnTNgrtPyEr4EbHv8jUBq4Jg lRraE+vTA6X43QJdEuD1V5d2nsanIcxcYO9B6L/1vYwzCbGNFeIh+yIU4qFlPIB2bpZX msphQy/kkZ38a8HGlR0RSzmKwqOhHJbe06utgurO6qXoefwe7zH7YtUan0qqRnF2nqwT dVIpur3PSGlCiju26XyivoSmdmLcOzI1vf4njF9GyIkQNQqkt2ZD9p56aS94LeO2/VCE 6mjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836134; x=1745440934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4KbTAU01u2d1Fyhrvlbrvk8qe32/1uE4Mm7IabxHd+o=; b=u2ZXOKssmN3o8HqR+qKiuUVnRl216cN2Bzji3VBuCoCqeZ6tMBpfBNgu1V3/LpYYWl +tVG62Ii4S+mVqUzmy7A4I/5ZMDfIYklOKBO2MviS3HTCiQwIMS99/IDuI1GLCW4Wrj/ fAGXf9TNdYfS8J/o+Jx/kRFY3tw3qvvUSrE8/VFamMvdl6/XeV0UaF/8FteZOxFUdpKo toA04UMpOW43D9oqQzlloNS7C6QjQSQcezyBIITHqDpoYRWZNzU1nMEraXrPugFtS+pv ArLc67i+DFnv+LCCBGoUJVJw8nzNBMgL8dpw96Tk0JYxegSy9Jo7BX5Oqfp08skKJkpm t+jA== X-Forwarded-Encrypted: i=1; AJvYcCV+acur+qDx2Scvc5zMuGvCeKuWHeIgaUolt0y2hgLIa7ijkuEohZRw/JMvCWAKUwqswQSNvGKufIvb2i0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4FxU2RK52Gy+ble7befWftqIHku3OTbyKCdhfcMJJ+EIn7LSr JRNW2tKn5kh5AJ96Wbv04uGHIB4/HASN3juTScMTuCGu27n7h2z8j+JCD2c9/g== X-Gm-Gg: ASbGncthNdaL7+XsYph6CzKSy2DpFxwWfODk9AvpDTPg/dTge+NvD0jQs3bI29p8DoI /+UHxkzW4ARNwRh3yWk8D1D0LxNhsJRsVsXoUIejaSZioPDX3AAejzT2dN1wVFI85BqRGNUUtWo RXyIjSNUV0KoqZA7ZJismt/OFwuOxpJwYIj6i/IoW9DXFRZI90cR0Cxvp5PgnfHVzQjrh5chVyu 4Ic0DXmv6JY13YTQH+tIFcvaCgNxs1uSFDUEgRtUAuMqVRHz8+f83emehlecJsGfycG/RVI+mTS n/AUQGBvsuA3Kx5NpOYkuaV8dvf0n3mABCELnrfB0JiVvg2CnKIQ5HaIROi0n+jS4wWMDGR+kaH LcTeNeA== X-Google-Smtp-Source: AGHT+IHfRTGtXW8empc1D2cBf7UaxyTiL8sP58xBhsmEUtXUYv0rcmyWAyhT9pSwnf8mtCyytUgfRA== X-Received: by 2002:a17:902:e541:b0:224:912:153 with SMTP id d9443c01a7336-22c358c4083mr50959125ad.5.1744836134534; Wed, 16 Apr 2025 13:42:14 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33fc4c49sm18858855ad.168.2025.04.16.13.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:14 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 06/18] staging: gpib: common: struct gpib_interface Date: Wed, 16 Apr 2025 20:41:52 +0000 Message-ID: <20250416204204.8009-7-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 029590f95fd3..87329d35ca47 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -2038,7 +2038,7 @@ void init_gpib_descriptor(struct gpib_descriptor *des= c) atomic_set(&desc->io_in_progress, 0); } =20 -int gpib_register_driver(gpib_interface_t *interface, struct module *provi= der_module) +int gpib_register_driver(struct gpib_interface *interface, struct module *= provider_module) { struct gpib_interface_list *entry; =20 @@ -2054,7 +2054,7 @@ int gpib_register_driver(gpib_interface_t *interface,= struct module *provider_mo } EXPORT_SYMBOL(gpib_register_driver); =20 -void gpib_unregister_driver(gpib_interface_t *interface) +void gpib_unregister_driver(struct gpib_interface *interface) { int i; struct list_head *list_ptr; --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 913B0233713 for ; Wed, 16 Apr 2025 20:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836138; cv=none; b=PEr/Ft62aRrFgcBfuRmcVe44/8UN1+qqf9Y+v45LYTHFTdFdo+/2/HZEQVaXK0Fc1oByta2POyLSTJZ0JYWNbH/a2VOQoJvpT6Gh9rustEg2zag9sT+QDZm31WOsiA+lNeDpmrdRA7FVZPd1hurDjQMMU5uaejis6JEjusGfBUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836138; c=relaxed/simple; bh=NquVVOzUvVHc51NXGJbazouN1NI1DYful7g9CbAi9qg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M2OJ7k6BbPw/WMI4MS6AZFx3RAExYc2PMPw0GrRjtWBEj5xG8oWCSH1ChbftL/L3k+uAbunhF3AbAQpbW1lbWuUf2jFWpoXlZ7hil52CRCHSH4Cyr9Gky8ah7vN3SNv1gnTbh5v9DtaSKVwNxANatFnQSYq8zofsTlA3KyWSnZg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=kwwP30NH; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="kwwP30NH" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-736b98acaadso24433b3a.1 for ; Wed, 16 Apr 2025 13:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836136; x=1745440936; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eVKJYjCi6cfX5sAdrJ/2R7IvJcF8PtgZtR8+tQIsnkA=; b=kwwP30NHvbolfSbn6ED1xdsSkUu7S1PlCKDYx6kZf9XMKeO+nXQz6Kh1wIKAZ1o7gu PTBCXHLvcj02EYD24Zk3czbqj7B68q5WZymSqS+bGHxexeY2RYynLliogT0ZRXcDSJ7C CBqsvdw4utFDPpvjqqR8LQi0mFuU4qYQj3+JyKWiJ9cum8/eDHPo9QLSz7bMZWIgEk3d 3vhRy/hrMDZN+C5yPImNTVhFmDvmDPxVmRRCthcjiNwV03hUtGFNBCBoCfHLsR7XaEdE ip1zAI1tdsuJg0ZS+o5ivFLquzSTl0RVhAl3h2pLrkO78wYdkb5Br745M84E2Bv9nZEZ 37iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836136; x=1745440936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eVKJYjCi6cfX5sAdrJ/2R7IvJcF8PtgZtR8+tQIsnkA=; b=YkbJL6ROZ0qVBMpMtu8vlPGzqKq/bl6zTCvW94sxbv3dJwsQEZeYEX7cFTJkCpsHVa udCFVfyp7w3awJbJ0MChK6aJ90GyGU1HSj1GvdXkVYvoOyKjMDv9zw+GToMWM20H2gup x0vt8pW6pnQ1AP2zvA4QAWzPGQXtn/yvsAbuSblGcV1FYv1PJmAD4BvOQEin7YPS9gCQ dLGM8mbwhc3atEUuCpbgHB2aSqk/wbaRLXL2LAVeTC5xLkSWHTsaktnpgSDjHLgrTAiw gn0aeulkBrjau8OLpCTsLKPuHf4TS8MF3DQhNISzrAuO9qQ+MJnpiz/fSo8glA5hStzn ft8g== X-Forwarded-Encrypted: i=1; AJvYcCW+AG8jxhMzFEt6m55lzQ2LK1swOKq+Nt5QLMtVX5cetOrUe/9APziFkhFkDyyxiKiW8/5mhW2XwEQMoFY=@vger.kernel.org X-Gm-Message-State: AOJu0YwZqEg1+opbHUfGM7rnSw4/fQtCa4zLYiR0VCgDt7/YBhN+Hmm9 zIXpQsKW0oxqTax8r5NN1taUEQc3DVfGkzQip2cKfZMc7O4lE8jnMZCK53Cz8w== X-Gm-Gg: ASbGncvINB2JIFyfHgv20W70JmWepWMPa6dhDM4GHxI27qx4O1JRdxrLSl8Ai6UM9+a E+JrTjCF8Oe+uxd4fCsCycKfn+z8BkIO95sxZixbmLXc+DseNAYB8arzDDhOOK87NCEMFQv9LrD mrDntVexuujZ2cu6Jauc4x/NC669COd//MYrCiEMh4NJkOM95yohVgCOa0z2IHSmkNNK+kfJKcU VpS45ugB0vr12MUrNjEdOt/7HkeoZ2lgjVYUxun0dX52VMOLoagGrhpzkkjI4eJMJfTd2H2xGUN VTtfqWmPBIZJkdmXNBAR1GZGnmFmQk//N1FKGCErENS910rqNWluDXFRLDMhvTQ2m+15AdQJhm1 6nKbG9A== X-Google-Smtp-Source: AGHT+IHSetnTFl57LONs/SJ5/0CznpYL8ILM+j90Q/9oEZtSLp0hQIylnIjaySAUtnyXjyoLO1PT1w== X-Received: by 2002:a05:6a00:2e24:b0:736:8c0f:774f with SMTP id d2e1a72fcca58-73c267ee1bbmr5002832b3a.22.1744836135750; Wed, 16 Apr 2025 13:42:15 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd230da87sm10880220b3a.127.2025.04.16.13.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:15 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 07/18] staging: gpib: fluke: struct gpib_interface Date: Wed, 16 Apr 2025 20:41:53 +0000 Message-ID: <20250416204204.8009-8-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/eastwood/fluke_gpib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/g= pib/eastwood/fluke_gpib.c index 396524901f12..f6a84200e3a1 100644 --- a/drivers/staging/gpib/eastwood/fluke_gpib.c +++ b/drivers/staging/gpib/eastwood/fluke_gpib.c @@ -712,7 +712,7 @@ static int fluke_accel_read(struct gpib_board *board, u= 8 *buffer, size_t length, return retval; } =20 -static gpib_interface_t fluke_unaccel_interface =3D { +static struct gpib_interface fluke_unaccel_interface =3D { .name =3D "fluke_unaccel", .attach =3D fluke_attach_holdoff_all, .detach =3D fluke_detach, @@ -748,7 +748,7 @@ static gpib_interface_t fluke_unaccel_interface =3D { * register just as the dma controller is also doing a read. */ =20 -static gpib_interface_t fluke_hybrid_interface =3D { +static struct gpib_interface fluke_hybrid_interface =3D { .name =3D "fluke_hybrid", .attach =3D fluke_attach_holdoff_all, .detach =3D fluke_detach, @@ -775,7 +775,7 @@ static gpib_interface_t fluke_hybrid_interface =3D { .return_to_local =3D fluke_return_to_local, }; =20 -static gpib_interface_t fluke_interface =3D { +static struct gpib_interface fluke_interface =3D { .name =3D "fluke", .attach =3D fluke_attach_holdoff_end, .detach =3D fluke_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87A3924A057 for ; Wed, 16 Apr 2025 20:42:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836139; cv=none; b=SbQ95wXRWhViKa5Q36xa9beXpaiVTwsTbRggmARzLZxxGgwP1zx+SeWw0hNo9QNP7fs7WpyzgzJI/kbvwvKHMK3+HtiPWgQvUdpoT9cTWii70qeyF55A05vXYyjwvGRcr5sjBqM5XmI7La2sIhhoBal0VCVD0DzLHk+cTgfxaVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836139; c=relaxed/simple; bh=Hs92UuHoYvzQoi8J9GCbjuZUp+OKv64K/u74xz89GFE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K8G3G/7zWRJ9UjoEXJIsrRReuF1uO7d0k7hBBlbFqTtANifMieovD1k4ro/7OTZyvhIAjRX50oKlppNwwKnvgkwSgibh3lvFTWw8DyB8Fxx0ksPaw9e1mV5lTWpNJUnChp9+H3fEOgAa1cfMtUw19mlzSF0Q6FuinFsgeK4ZUyM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=atJTLUfU; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="atJTLUfU" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-af50f56b862so40089a12.1 for ; Wed, 16 Apr 2025 13:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836137; x=1745440937; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/PC19z9s7DGRWg7r1KoqgXBtiHi+mWDJPXbJcIe1syY=; b=atJTLUfUYwwetaawmrJcP7D8yojZhNxh5g4iuju4NBxe9NjUzibfnKedSeK1HKB8Q9 iydcTbOpwEDmOXR96Y4DTlYmaIGvoElJqOIqnT92aVw+F6d9qhEXPDa0os0cTxMxKpye 9wvkTH+0/yqzQGqM5N8UviBMvDyGx1bYHJOTW4ZelAzj0S5GZqUQTyNBcHi53llnmra0 7ar6VwBQ7L2C291Uruz2bN5Mu0gGzImfpH4/oY9l6fIZ28Rp+YVjQT5fs7p4kBBXYhXv K4Ex1Iif9oETSYQ5p85o1Q5G2ONBgeY972vRJMFyOIA6IMPGmLKzX4ebT+cUg4J72MhE /4bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836137; x=1745440937; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/PC19z9s7DGRWg7r1KoqgXBtiHi+mWDJPXbJcIe1syY=; b=CdotMGnw+/kB8tqOmt3KSJ1NTZPZoykScz3NHhqjMm4OgVtjlcwM1xG3PzmUvgp8Or ScvXC1CU8DDRp0iMmSQjflXM1Deqo8rEz4NwsK7YS1Sdv497DYfue4ejOZWmvh/VvAcK GR84EbTZkmZpZT9hVjUKFJ2Ul6FonhFg6iDcy9G5z2d8sKTerfRFlO8cJRIJPDJVYC55 +EbWf0Xo1Xdb/TQlVxn/YQSGBKyl4CgTAHOGHSCHSQXPD+Dr2uZfEAcDBXlq9ZW2T0E8 mxKJbdIuDBbBRRx5saHHWCwvtrwC348quV6DSgXJ4HJN9Rsg5HHHipRclY4kpojHbCDR 6UIw== X-Forwarded-Encrypted: i=1; AJvYcCX4/D4+C4PhPRcc2ziK81u+MxnyeZxVkC4FeYIFIu8T/zBdz9C9BgJZAyoRIJCuAUQ2kYa4wzlFVVdK86A=@vger.kernel.org X-Gm-Message-State: AOJu0YyouePenkee7DPyHu2yj5IRjT7nz6uuGmatyyajiM0+PNP76Mlj 7GKePpj0tZqefEoaQwqhXDYrPrSX+UXshpjXtpxd8TjowDNlP2qcZUxCe7o1mg== X-Gm-Gg: ASbGnctAFfxCrgRDymDt81OSbPffFXxtO90jwxBllbffc7iMyoKPD+Yw7khDBadhvlz Qqx8ifSdlDA4TMnKtmeQ1gdTkNsbHQIwzelMUDnEx6AxoxePT2nLifNt5/1DLK79BJCYYoJeIeE J1qrVHbLKHCC+nFVdp4/u14wG8MKoK+0HiAKtpQhKvaYAKPT54PmqObtC2WrJe9hLAJANbpsXNX IJOP5ZBW4qfbIMAGlNicNSfvaQQkOG/Vt+oPqrXWedNHJcfyTmXD3NEYbz76ASg3TwulmIkYtdL CY4kXD7a87phI7RY0NL4P6tDEFLCOj89yFZtJL1w6ijQKbI77qBWgFB5kfOjcZL8MhBW4L2hQTh Y2Sai8P0jQMNuxl2y X-Google-Smtp-Source: AGHT+IHBteJH2v20V1lmTQzL8B1zGnM5GZM9eoxGCjBQbuzUCZysUXj11FDjtxFQ/yxjkH5moF7Phg== X-Received: by 2002:a17:90b:2549:b0:2ff:64c3:3bd9 with SMTP id 98e67ed59e1d1-30864167fb0mr4020279a91.23.1744836136888; Wed, 16 Apr 2025 13:42:16 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-308613b383csm2319913a91.37.2025.04.16.13.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:16 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 08/18] staging: gpib: fmh: struct gpib_interface Date: Wed, 16 Apr 2025 20:41:54 +0000 Message-ID: <20250416204204.8009-9-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpi= b/fmh_gpib/fmh_gpib.c index a7be878bd3e4..ca07e6ecb0a8 100644 --- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c +++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c @@ -1031,7 +1031,7 @@ static int fmh_gpib_fifo_read(struct gpib_board *boar= d, u8 *buffer, size_t lengt return retval; } =20 -static gpib_interface_t fmh_gpib_unaccel_interface =3D { +static struct gpib_interface fmh_gpib_unaccel_interface =3D { .name =3D "fmh_gpib_unaccel", .attach =3D fmh_gpib_attach_holdoff_all, .detach =3D fmh_gpib_detach, @@ -1059,7 +1059,7 @@ static gpib_interface_t fmh_gpib_unaccel_interface = =3D { .return_to_local =3D fmh_gpib_return_to_local, }; =20 -static gpib_interface_t fmh_gpib_interface =3D { +static struct gpib_interface fmh_gpib_interface =3D { .name =3D "fmh_gpib", .attach =3D fmh_gpib_attach_holdoff_end, .detach =3D fmh_gpib_detach, @@ -1087,7 +1087,7 @@ static gpib_interface_t fmh_gpib_interface =3D { .return_to_local =3D fmh_gpib_return_to_local, }; =20 -static gpib_interface_t fmh_gpib_pci_interface =3D { +static struct gpib_interface fmh_gpib_pci_interface =3D { .name =3D "fmh_gpib_pci", .attach =3D fmh_gpib_pci_attach_holdoff_end, .detach =3D fmh_gpib_pci_detach, @@ -1115,7 +1115,7 @@ static gpib_interface_t fmh_gpib_pci_interface =3D { .return_to_local =3D fmh_gpib_return_to_local, }; =20 -static gpib_interface_t fmh_gpib_pci_unaccel_interface =3D { +static struct gpib_interface fmh_gpib_pci_unaccel_interface =3D { .name =3D "fmh_gpib_pci_unaccel", .attach =3D fmh_gpib_pci_attach_holdoff_all, .detach =3D fmh_gpib_pci_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9CD24A079 for ; Wed, 16 Apr 2025 20:42:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836140; cv=none; b=G2gdw9U7Ix7wmK5YuSeEm4CyzB7YYrFZ1EHwvWqn2POh02TDfS0Car05ET9nafaQrC863hNTo+WtrHfs6rpswV6l7hLnFzV6s5lC7iD2Iqdz0hS5Rj1egbDjtHqgZ4dBvmiml+3luQdEyvFzxGNo6njUmuteXudBnUr4l4CMYsQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836140; c=relaxed/simple; bh=oZv9J6EAs+La9Yoz4jWDKoBjoVKNXoiy6YS2fSQlpKg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aNaAOU+qOMKjKRcyf5cyqh7fVNw5efRO8Z0VM2N4OtIKl6Hg3zugbxF+Y8HjsXkhKLUntPlb0IUSaYiznVAjnX0/6i9CcHgjIygmOvLbP8EaqnxLNS8Yxjg1boQQ7ZkDchW6ZAffJ6L6/B86XX4wuWYKtph0x24B5pLADr5x8/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=nC517zMK; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="nC517zMK" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-224341bbc1dso1036015ad.3 for ; Wed, 16 Apr 2025 13:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836138; x=1745440938; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OaGk/ulT5DmrCZA9B/47jOByqfYQN8rvXLp/mrP0bU0=; b=nC517zMK+f9SHMl9V1jsUwgzuzBezfGmjeX4rVP/GiW5R8sDEUkfJHNqkqZyFM4Are 7+/adAmAZ+BHnLbOwQRJ27NwPWY/V94R8uU97FTD/3D1ybnLXFxSbkqeePHxiaePfwj3 vUKKM7ve7+KTZ+mfjnIauL7HhPokWshA3iW2fKe7cInTRZBN785zFDd3lGlaOo1rFf/P 1SIKRtcHfUsxvkml3ukxNcxddjfpUfvIbUsFi4WcPEXt9Clv/mxQCr6mH3ld323Ae1Jt a48+/h9rjV0gjKAH94GVp0Vr1DkC6I+gdnn9ecSC2c+Yxbmwtg6fAEe0FrxuaMEcYRD2 lahg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836138; x=1745440938; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OaGk/ulT5DmrCZA9B/47jOByqfYQN8rvXLp/mrP0bU0=; b=FSAcLS8Igwmx9a+0F/eYCYPSSuijQFbkA58CptXSnqPMYD4+/VVXrpoTOJC+SK0cLD FYxWMy6asdFGa1Ze8sj1kWLWh+91qV4hFVxmOMKnYkN8WBmenXSbCH3HQ5rv6sH/0E1+ DIQFmlWP8qI6k6rJSyp2vIvBJhYm7KH3RekwF4dvTkkjFd+sO/fltFOTfO7G8H2EmGUY WorWa+ZOVgFIG4LpicT8//VPZucj4/NDY8zSK2LkbocgbchuZjnkNvx8ijcVscXhLrGU hIqtKQlWjR33PAYmwPT1vKOT/SirJkjW6ATHkwZtk3nIV4zk6xbwSKLDYN60uXBjnUu4 yQgQ== X-Forwarded-Encrypted: i=1; AJvYcCXDCHkczYBOM9s9fNQoAold4dJ1ter1LFMn92bdHTbYUKr6ODFyBT2SckNWvywntbX8Q4CCpFRiqZuM+4A=@vger.kernel.org X-Gm-Message-State: AOJu0Yyqqck/8+Vr19DBxR1pb1dlfrrVon0TusZp6cVahb7/chSNr/lQ tIzGBwkJxWpgLm0lvdeJsUaMJexJnBJsfxksiKAHSuf0U1jLePPuNaATb9TqzQ== X-Gm-Gg: ASbGnctOPYLFOvgBWiBHT8lp42VKoW9/k5qeOzrqpFOtsPLkQPYsky4Y8pRlNzD7QNc l4e3td64FFNr2rjCVRtYc8roK+Q60GGRrA7argEHYcO4N2PHXPI9H+vEphsu2ElZaKXPfTY1ONQ GJIauZRZaV4eA9Jt+q8s5JnS3Jq/S/8ffcoAx2vQ6m5xe/5gBjnNF5knQzaLDZO8AHQTujSX1vL 4jL5pdyqYjZcRyT08gGEGMNXnyZ81MleLz4zmiQewKuT72maLFPr4kGlIhmiTs3pE0nUYUyEjmT laFbkJCjtbXqBPJbKVJ0j3EgokAfdZjkhBUSd16IOmLLNciMSRXozI7Tn3lf0iIJN/APn28VNKj wEUDK4w== X-Google-Smtp-Source: AGHT+IF0xLStOVVrog4mqNhmnW4YOlgEC/0TphCbwZqL8gsXZoUG+2xj/8FpaIJKuy1Jt0V4UFA0/w== X-Received: by 2002:a17:902:ccc8:b0:22c:2492:b96b with SMTP id d9443c01a7336-22c358d9c65mr56564125ad.15.1744836138067; Wed, 16 Apr 2025 13:42:18 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33fc4b96sm18797775ad.174.2025.04.16.13.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:17 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 09/18] staging: gpib: gpio: struct gpib_interface Date: Wed, 16 Apr 2025 20:41:55 +0000 Message-ID: <20250416204204.8009-10-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/gpio/gpib_bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index 87622ee841c7..443d739c7edf 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -1308,7 +1308,7 @@ static int bb_attach(struct gpib_board *board, const = struct gpib_board_config *c return retval; } =20 -static gpib_interface_t bb_interface =3D { +static struct gpib_interface bb_interface =3D { .name =3D NAME, .attach =3D bb_attach, .detach =3D bb_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06C5C2356C8 for ; Wed, 16 Apr 2025 20:42:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836141; cv=none; b=nMR+9KwlsehJ389vN18bY2I7IxTjBp0eptoJdri8Pmx3z21FOZFveN1pt85BvP0gY7MPpmF4Thn7oZ74v1mV5XPITzWOQ0cJASWSGFxCA6szy5zRSE+OTBTFF/bADUDf9lLdABI8FCrDT3JqW/whQSihAgC7PCZxjLOVW68Xd44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836141; c=relaxed/simple; bh=sm89KN7M+N+cjb4kBf0tDv/avTft4wb53ORjh52ocFY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KOkkUnAhCgaoY4o+R1YkIlF9PqPcGfuIkqKypo7ajhPHmCuuyYg30uCuPaex0KUtiPvjSKpRDeilUK2qwYjnTeuBbPqOLrGEs7Zl0LRF98j0swbTIWs5A/jLLA7VufnEDTLR2+ysUCiFZsJOiWqIVzuIZ1h+TVR+myr7poPxDiM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=BSd/pluP; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="BSd/pluP" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-224171d6826so1472185ad.3 for ; Wed, 16 Apr 2025 13:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836139; x=1745440939; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vov0toR1t8IP8gbJNzk0Bz9HIkssufBqsXHpZDgzbTg=; b=BSd/pluPrqFLFfD82CK3D07YSH+S2MFIZ+2b9KVlWh3FrtYFZTnIRZv6Pszc8l3Xw5 yLiNJDCryKP2qLMJJLmYkYKEHUOCXgJ/5RFBYlS6G/yVRz40eI8hhlL0dmBpeytUnRO8 vpJc3iJty20Zxw8t3apRIOtYNhmuwx6Le7hDW1/Q1SelE55VIR1CfUbUFuxjI0XA5tCf Gj3lDPFqw/Ddtqf+Qaq87E7WWk/fpkC0DyxqWHUTJDE2TrE0jlJ9Lh7CoQGUN4ElX6xQ /3sppG+VI6T8wSsikCmaf5Su4wjOlpIvXBvuNL3OckUM8CSyHf7vizMaT+kNRFweGVig ZhqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836139; x=1745440939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vov0toR1t8IP8gbJNzk0Bz9HIkssufBqsXHpZDgzbTg=; b=cEowGjcBFjluSjtDrECLh32EWUMKaQQeBTg77UfX7P0H8L+lLA9EXS8EBrre9EwzYw 53Ecq+YgF8rgYRcuW7Lk94aYWEQlC15p8B/Cn0XwHzlWLz1SSvrlnrkqALXyFfdEQ9fk jjps61UZMPdYvk7epq3rY5eY9O2kVzzLIoj5/17y6iXgwic8X0G8/h/koTbO/jO+Yuiq XM/2EdVLOnlZnz2q73usv5J9HjbD6DP0gz8Xouct+nP0iPqKFvt2yReLVZK5p5HwnV1o 43PwZvlS3wOr0G8T6dEJURtVdOsqYrEI1n3h7IW7yvftHlXeHkZG+mLmuMXRqNtg4lE9 Kn5g== X-Forwarded-Encrypted: i=1; AJvYcCVREOBZtQyl9d8e7Y38gng6ydCsE4T+AEx9Ye2/KOo8vFdOWVK+2Zt4a7xH+LXmC9XLRCV4YrOUvHRDP9E=@vger.kernel.org X-Gm-Message-State: AOJu0YxLrZMmDDg9cHV3FVjKN+zOoFKo8LSA/NsbR/PiyBoBARNrWIzG whe77IuA500Eh76Tn2jDDG+4DSAe2BB/ix0YCmv+NunRxgNtG0lMehZUJNwFTw== X-Gm-Gg: ASbGncvARDHbT6mRPJtk5qsUfX8P00T1IutgKRQ6MZ/whAa68YNxDnHn+LTIQXseBfZ rJWGoIelvaRhP/biZdisVVTVhZxCNwXlYKab3Ew49XecqCMSjgH0yzJrBL+BmR/jii63RpDlThq NbVQMyJQ8b3NhnIuvGYnKhfmCkSVnA5Q5jldaWxLI9k57rUXwqURpTb588zy68MqhvFsyfGLb7G Ptwv/9dz2kdJPJ7tQ8lce4RO9CU8p+uQN7ScBtOtcxoyWBQgQaBfZPDt5dQxWpixNMsKXosR0TC yfiREkRGo8TPxt5ebuOG5D/cVbQQsx5nDvRG4uFz8x0KODgmfvyFnZvHjRdKpIXM/2jy7IQWlIX cf+dQBg== X-Google-Smtp-Source: AGHT+IEC1UkYosCEAC/j7pcT9vJEGJ6m1/2mfcIOPpw/u+A+HsK9Ra6AWSZTeSi34DA/3N/4QvxGwQ== X-Received: by 2002:a17:902:ce91:b0:224:1ce1:a3f4 with SMTP id d9443c01a7336-22c358c543amr44393225ad.1.1744836139287; Wed, 16 Apr 2025 13:42:19 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33faac7asm18797245ad.137.2025.04.16.13.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:19 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 10/18] staging: gpib: hp_82335: struct gpib_interface Date: Wed, 16 Apr 2025 20:41:56 +0000 Message-ID: <20250416204204.8009-11-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/hp_82335/hp82335.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib= /hp_82335/hp82335.c index 319b7f6e35ec..7f14ecb46026 100644 --- a/drivers/staging/gpib/hp_82335/hp82335.c +++ b/drivers/staging/gpib/hp_82335/hp82335.c @@ -180,7 +180,7 @@ static void hp82335_return_to_local(struct gpib_board *= board) tms9914_return_to_local(board, &priv->tms9914_priv); } =20 -static gpib_interface_t hp82335_interface =3D { +static struct gpib_interface hp82335_interface =3D { .name =3D "hp82335", .attach =3D hp82335_attach, .detach =3D hp82335_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F7D424BD1A for ; Wed, 16 Apr 2025 20:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836142; cv=none; b=hdp8j6aaachDHWCBqChoTVZv18L2txWVDZWbAswpouJp2hpx8khKp7Gb/FGfdnnQ1uVZ3J3j9h8Uv1HgeSgDKrF/dM1b7Ng9IZAKKhKIvSU9+vh9i5MIFuHBkJ/vYgoZ19nNh+KyKFK1g1jnfs2laHA4HbMYH0iCq5y3Zfb15HY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836142; c=relaxed/simple; bh=qXuKC8wKMseybKQRKVoj0KYHcQgg1A92iFP+uea8iuA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N29aUIeKDLMHnie6dlH68eXqoflFELvdu7BhXC5blgvfNFbO4A/Ru2McWwjvfRMKjALes4ffrZSqm0O5sSdHss13KBbw05zK/uOrg4GqSRKWOWrExhaPThhihdw0IQ7w7US/xJvCQlt/dGhirEPUF4FqzKSkrgqTENindCZdwWg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=eoPmunxM; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="eoPmunxM" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7399838db7fso114303b3a.0 for ; Wed, 16 Apr 2025 13:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836140; x=1745440940; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cTuxdgSBH9onldJ0zjeMMUuM1GqYJzLHWyE75BJvR2I=; b=eoPmunxMwBc0Y9FI47VdOcZ0hnahpmGIpHXnuJLwvSgvNhsLOANjlUa7dJa8aE1xw9 SIk0vDCG0zsMt2cwlzZ6skrFawjl96Tk7JmpCN1wWSCxRiMjaBFxQCAdJjlcQr3TvRmR FBzC39oMkP7pqGmqD6o/yCmOWEc6hfDRX0I1VGuXMTJMGeJ3K/sQZwCzeM0hqtUGUoA9 47N/jPezROJGkE57vQblL85ICYXsJgnvO9POy46WyboVJ5jdhHPBCKiC1v4RDT3mQIOK iW4yPWO+Y0Tl2XmY+BOGpdyRSXxoMmsfH/hq08LW6miTCOiGOqRyo56ibO5L+gFpNW86 rBTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836140; x=1745440940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cTuxdgSBH9onldJ0zjeMMUuM1GqYJzLHWyE75BJvR2I=; b=mNe6iITz6ndRHcR0YuBHKsORP5TPQAxbO199xwEaQ694x0l1/KroiWy0mdNaQ3lQPF gQ87Ma6Bv0REelf9Dj2FKpJyO8/fgtUEC+j4KxBWFIPJDWxUaqKVb3abz8TDSQcqYrvP 0pmxPPT9HU8t+YukFgiHK8c2MWBOI+2wM+qubUJCBrcP4O2Atpg7hbdDcDMvx2f9KGIw TLJKMBxtsCbAA4X4/nOUMZpWhNlTw9oB3HXA3pEa603zqjCZoMDOKeAeN6GEQrg9BE/N iuc8yFFfuIaseBWoycArc7X9Z+5GBPcW4iXT1snHBCS/6KBI9IyfTXIwZ993BwzoTonS P5wQ== X-Forwarded-Encrypted: i=1; AJvYcCWjg16W0MLqdjuMZXAKKROZyYmplGVzxCB+QRW1Fgjut6eyMwWUTkaeSbuN4pzBJtAVMYCTwxTTGTY03kg=@vger.kernel.org X-Gm-Message-State: AOJu0YzxP3XU8dEJ+xBBL0ogkCixEQMtcdSeBRaqawsXfvG9lUadKRCn tGVKX5oeexmSWqG2AqRHrXuBpoiqVreQqjVdcIbIl/4D6YJw6ITbOYwRSJ9saw== X-Gm-Gg: ASbGncsY5xa5o/XXYbGVAZ2QweBWRg0X+hoVp9n7oXKNOXNS6qK+sz/gfJYhVwbrqSC ysRqEcYfUXql0YZGd75keEJyT01VnLQmR3JsJh1Y+2451SO7jsMIK8dV/R8JbpVzasCHbZ2o0HA uPAFg8nrPp+XlEcL9jDWWcdp7WeS6gHCxfPaAOrA4E7LKyXF/WV/rFtyhhiUEAjJNd8hAVa25FL pnC4yrj298nLe7OroekN0UOn5ISdz5t4pDWf7yudFbekWgU8sreDJS22VzjQEtrt8zdMUPXfrR6 5sZeX6GzvTR8N26r+3HcEa1Np4aXeMhNNIbSgER/zDhf+o+T0ABHDzkyIViMvFk8i8yWPutgeyS T+/IPdw== X-Google-Smtp-Source: AGHT+IGRy1yX3/hgyibQ51xQgGHxSxovAxyZtRPcAb1wo6YzYcR8ITRaS0eVJ6jgzVzyKvovKr4gXw== X-Received: by 2002:a62:be0d:0:b0:732:56a7:a935 with SMTP id d2e1a72fcca58-73ce5544dedmr380527b3a.12.1744836140526; Wed, 16 Apr 2025 13:42:20 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd21e02fasm10803980b3a.81.2025.04.16.13.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:20 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 11/18] staging: gpib: hp2341: struct gpib_interface Date: Wed, 16 Apr 2025 20:41:57 +0000 Message-ID: <20250416204204.8009-12-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/hp_82341/hp_82341.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/hp_82341/hp_82341.c b/drivers/staging/gpi= b/hp_82341/hp_82341.c index 5ca0bd2f1a08..1a32a2cc421e 100644 --- a/drivers/staging/gpib/hp_82341/hp_82341.c +++ b/drivers/staging/gpib/hp_82341/hp_82341.c @@ -411,7 +411,7 @@ static void hp_82341_return_to_local(struct gpib_board = *board) tms9914_return_to_local(board, &priv->tms9914_priv); } =20 -static gpib_interface_t hp_82341_unaccel_interface =3D { +static struct gpib_interface hp_82341_unaccel_interface =3D { .name =3D "hp_82341_unaccel", .attach =3D hp_82341_attach, .detach =3D hp_82341_detach, @@ -439,7 +439,7 @@ static gpib_interface_t hp_82341_unaccel_interface =3D { .return_to_local =3D hp_82341_return_to_local, }; =20 -static gpib_interface_t hp_82341_interface =3D { +static struct gpib_interface hp_82341_interface =3D { .name =3D "hp_82341", .attach =3D hp_82341_attach, .detach =3D hp_82341_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44CF924C073 for ; Wed, 16 Apr 2025 20:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836143; cv=none; b=SRYmUeSw8UAK0ddbpTXn6V7Kq28Rhrp7JXN5ll4ogA8Be3qnVs2vyw7AsChNymnnX4UccetJdVgrTvnMaVKLthUSyetTEBa8hG8MMCpNZqqhOIAc4xAJ8elrpb4f79/aUBwzLkiiRIsoR/kTbAh7+ihryhM5V+hRXF/8CKL6/H4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836143; c=relaxed/simple; bh=vpnZ+9dRThyOfcFKpNcoiQtRcM2q8nmnRlwHdTw3Zrw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LoD+C9npNgglCDZxOPqlv+LxuW4AQb3hsobtP2nvyWIQtc7eBD73bE29VTrlErkgTj2h3x8vWUA/ADE2+1RxBkovvQtdzKqTsryHkoTC9NhXuwGVDqNoHZJHy7lDMn4C6ExjyIj3Xv3fB5hCOGOgDKWfQ/BF4kM4E63SWYCSRAM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=DSHAMLPn; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="DSHAMLPn" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-736b34a71a1so40579b3a.0 for ; Wed, 16 Apr 2025 13:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836141; x=1745440941; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H+0BcBKraYAKcBr0ytrcRqedIgRXL4U/FszO6yDuzCw=; b=DSHAMLPnYIy1CKYPJMkP66bOZtNh7Wu771brezbLGhe7HTvp2NQf5s6fLXDio3l8G3 yxTW9l/fYOBHqHpVAwUVwri6wduER+8N0EvhrLCYdgmcQffAveTJ/O0vb2RfpqNv2yjt rAGq44ORWVeSyA8HN3jQiCMDh5KRPTn3arCn622fjL++BJZTCl/SRqb/SEj+sr9ndhd7 lnGqrmzvExVNpotF33OAe2YtOTXdvFU08UBTFXJB8RwDh3NEG+00T9CLzF52awJaY3/D vrJA6DxVsC/vVGtsX4xuqhk1M1WAca9twAirv3XUGmC5dDEUhjxUklN1OkgfL2ec25QJ acYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836141; x=1745440941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H+0BcBKraYAKcBr0ytrcRqedIgRXL4U/FszO6yDuzCw=; b=Czd19g9PJxsoSruneYbHfUbniApo+CUFRAtANATNEDit+LiNlZlDTDIdwc51EjPQ+z GBwY+/B9BnctEiOJL9PfR0dkrztgynrf5kI7vnxOvbu6WWehYe/kVX9y6UDreIwqRrfx E53CbYuuRxTvyHv/IKuYHQ68Eu75Rg1pFiOB1s0HWd+mKber4zbibrD4ypSxr4bQyjuY WSIVQ1WyKyZ1pouSxr8kpDdx85s1dbiIfE6durcisIO7gnrKwWjKAL3PfKAVTyUbFnYF EY2ly9U2Ao5TXN6pPZQS8vMAzU19dHcD0b3xV4U3DujzzW4EPWV17INA+sdd2KOEV+1Q +thg== X-Forwarded-Encrypted: i=1; AJvYcCW0I6mFC962nlNVDzGjm6sFSdDuxRv01NfEoPkDk1CqptarmgJPGM8AXdlcYxKYVNBDZ8id+stK0gwj8yA=@vger.kernel.org X-Gm-Message-State: AOJu0YyiPpb8MWjFOEm5CEizQsrfP7yippfdvXTd6xcowKkgWrqo7f5e Ziso+ek3V4XMNSjXK4F2SoqdFETtrOXjmtWKK8oMxyOLYmoRasAX3ntfgP4v/FCYb4vxGxeE6PY = X-Gm-Gg: ASbGncu4W1u9V0zVk/x1gsOqA596xZHhuZkAFxOIH6NCIFoHmm7y6fcAAFOnw/G7j9X 4rnQ5C9rJ0k8kGbNQErUo6mGi0bmmj6MJ45BBmeNUg+e/VTH7DukBJmOAIUpk75BfGlPWlrym6M aSHoIrAdCfD04A6JTWB46p2HlusTq/iQbkKJRXZPb/I6FX+rgf8EAIRhPGpTn/SZwirwENclSF+ 4ymR7pyuKR23kd9XfRo0wt0YPdeG5OszV5JFhvLyPDdzrPmYDcY/BfwwzTX9Tky90HINebcxt0G A9HSGvFx8fqC5qAV26y+0kDr6a4VlCiW9NmNg4bWcYwW94ZzpsqQC9cLeYBkQA6POHmKk3p9e2B IZbF6BQ== X-Google-Smtp-Source: AGHT+IGVHaELi/ymBqdRjMjhCHOzlwZfRpH38TtbAdlJ/JymhlbtOLQHLDNlAtUP22sRedK9eA2XLw== X-Received: by 2002:a05:6a21:9209:b0:1f5:5b2a:f629 with SMTP id adf61e73a8af0-203b3fd5e27mr5244835637.30.1744836141677; Wed, 16 Apr 2025 13:42:21 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd21c3870sm10767839b3a.48.2025.04.16.13.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:21 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 12/18] staging: gpib: gpibP: struct gpib_interface Date: Wed, 16 Apr 2025 20:41:58 +0000 Message-ID: <20250416204204.8009-13-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpibP.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/include/gpibP.h b/drivers/staging/gpib/in= clude/gpibP.h index 3e21bb1a4297..bb3c4fd5ea03 100644 --- a/drivers/staging/gpib/include/gpibP.h +++ b/drivers/staging/gpib/include/gpibP.h @@ -18,9 +18,9 @@ #include #include =20 -int gpib_register_driver(gpib_interface_t *interface, struct module *mod); -void gpib_unregister_driver(gpib_interface_t *interface); -struct pci_dev *gpib_pci_get_device(const struct gpib_board_config *config= , unsigned int vendor_id, +int gpib_register_driver(struct gpib_interface *interface, struct module *= mod); +void gpib_unregister_driver(struct gpib_interface *interface); +struct pci_dev *gpib_pci_get_device(const gpib_board_config_t *config, uns= igned int vendor_id, unsigned int device_id, struct pci_dev *from); struct pci_dev *gpib_pci_get_subsys(const struct gpib_board_config *config= , unsigned int vendor_id, unsigned int device_id, unsigned int ss_vendor, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C32F24C098 for ; Wed, 16 Apr 2025 20:42:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836145; cv=none; b=Cg/egEXBpUhhCOMoWiUpVNLfqDMtQKfumkQsXDzt92XaPM+IJ6Cff2tVNmjH4/bhkgiLpTBpPPHjuVx9hG2PVUkWFcwo5fOGAe61ZBBxGt48/3Q8ZAw++W5u32WfvOD6KpbqPP6NA8cRdTt3EfFnOXEOPwEXGwWs930je4Bx2N0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836145; c=relaxed/simple; bh=Dsmp5RsheRWvvCg8XuqH/IOyChdJsfIjOoakpD6hyQE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e/MlNuVleIwRPaADSla6lAY1+CYyfsjjKGhoNNbSYZvkmvrVXjmZ0ePfrxIU9Ege2N1KpkPWHq9Xv8CK5bJJuiACBPQrCHFsGFrYZm97PSdBKPGWD2zPRHgxO2Z80YoZd71j5X63ZnOA4C4Ka2HmgNyl6uL8jvg5ksiA7XUu18I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=E6ixjvP3; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="E6ixjvP3" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-af50f56b862so40146a12.1 for ; Wed, 16 Apr 2025 13:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836143; x=1745440943; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=41DhzRK3ONBBmT2sJGJwKrMcn46yaTakFIeFswWFnds=; b=E6ixjvP34Qys8o+5y8IJKVebJb3mnDGIAVa74h0DvDPUZteWT5s9Wqibwir8QwL4Qt bR9ZBUro2Evu24pPaft5dd8nZ/tfuFSym+O0AhzWDAcJczkGxqWHQFVcKG6BjDMDJWyH yKzx2pE8sPsbZDBF1d4L7/Tw6azkyyrYZ2RlRaBy4KmfTeHR4Sz2Q1r8rWg8pSAAfdx+ 54+r+7AmfGAfKVffc87JDsQ7qCh0ytfZSR4S1GQamziylv8m9R294Z5XdPzpFo7UwNwg V75EfoYoyu4toVvZhXtRsQMR64fX9ZSHos6Q55WCtsvuw9FS8eDJ1o0xrIjECKIvFtsr GA8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836143; x=1745440943; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=41DhzRK3ONBBmT2sJGJwKrMcn46yaTakFIeFswWFnds=; b=M8Q6kdTXUkH34Fa/ZV3GLIl3ufL6PlqW6U6/6p74x2IrF3X6nOfd4BFOla4CKmtlvZ Fq8nDCwSHLm50CIGQ6KMqFnNcn3trbuRJca2vj/AOiUZIHJXaKPGDdx9tTATtOYpA/yI XexQJaFZtgR5M2R/jCOZEZ80b2LzIfTrmVUbmbfYnSBwQZbA0TrFUFGgGy+Jc4Lxe8Wa 0PPiGL/LjL8ISLAlnvvPW6gCaC1xCHaXpq0m5Olmm0yeScywCuaVhZvP6f+Z6FAx9B/u ktqg0VOrrwmxPC637nOaLDUH5c517su/gxuCJy72oZ+AAuDs+rR0NvuYtOQmTAuGhp4k J4RQ== X-Forwarded-Encrypted: i=1; AJvYcCUqU89k7YCRBzfPnacqOXXPUj7PZ2icaVPlFAhASFaymbUqdRUMR66b2769Ul0icVZtDG389PPsCcIlKrY=@vger.kernel.org X-Gm-Message-State: AOJu0YymtbZnshceJK+1iwUmMj1+wBge8BKAqJUWvY4+/tjmtFAAZzGT mSSF5T5KEgKhzxeCj+6cte8UmnuALTNiG0lHIcL4gYlEizeANy0VrQSyJujTdQ== X-Gm-Gg: ASbGnct5N4sQWsjOo+pyd1Lx2bthw4zd4Yp0PlPARR9l6lKsbvXA1SS4GqfCYwRlYNj 5v+JVmGmvaoe0uCJc+5s80R6xst/jSFUPauhyGTZhbepgyfLfRBh86Bf1BROg+n1Rs+Jvy05vKM RpopDpZgXAtixz3pEcHaPG+D1fHsJhrMA3bXu+1nUHcsVb7NlwjFJ65rLQR0kgi8s3vTddBaFN4 gsMWvQb0ZRt8t+7GhtK18RFm7jtnFa0HaVZdfEYL3+YQx9lUQKdmXTNbZrr/SqrsfeowB0nm/nH NccPeTnDuxdy0LaS6LDXH+gpA96R2KyXNR9tOnQDhjbnO5WTkvnd1KiQXcC2pGFdBHM1aS7yKpY Qgb267w== X-Google-Smtp-Source: AGHT+IFXDX7qzzgAc+ruTnxmUO6FrKtnEQRt0vgqXwdJF79eAqjrLA9y3UAj94msFcZ2u+zXUxCwNw== X-Received: by 2002:a17:90b:514c:b0:301:cba1:7ada with SMTP id 98e67ed59e1d1-30863d257f2mr5314960a91.1.1744836142895; Wed, 16 Apr 2025 13:42:22 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-308613b2ff9sm2093453a91.30.2025.04.16.13.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:22 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 13/18] staging: gpib: ines: struct gpib_interface Date: Wed, 16 Apr 2025 20:41:59 +0000 Message-ID: <20250416204204.8009-14-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/ines/ines_gpib.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/gpib/ines/ines_gpib.c b/drivers/staging/gpib/i= nes/ines_gpib.c index 2d98c571a4b1..bf830defcad3 100644 --- a/drivers/staging/gpib/ines/ines_gpib.c +++ b/drivers/staging/gpib/ines/ines_gpib.c @@ -539,7 +539,7 @@ void ines_return_to_local(struct gpib_board *board) nec7210_return_to_local(board, &priv->nec7210_priv); } =20 -static gpib_interface_t ines_pci_unaccel_interface =3D { +static struct gpib_interface ines_pci_unaccel_interface =3D { .name =3D "ines_pci_unaccel", .attach =3D ines_pci_attach, .detach =3D ines_pci_detach, @@ -567,7 +567,7 @@ static gpib_interface_t ines_pci_unaccel_interface =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pci_interface =3D { +static struct gpib_interface ines_pci_interface =3D { .name =3D "ines_pci", .attach =3D ines_pci_accel_attach, .detach =3D ines_pci_detach, @@ -595,7 +595,7 @@ static gpib_interface_t ines_pci_interface =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pci_accel_interface =3D { +static struct gpib_interface ines_pci_accel_interface =3D { .name =3D "ines_pci_accel", .attach =3D ines_pci_accel_attach, .detach =3D ines_pci_detach, @@ -623,7 +623,7 @@ static gpib_interface_t ines_pci_accel_interface =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_isa_interface =3D { +static struct gpib_interface ines_isa_interface =3D { .name =3D "ines_isa", .attach =3D ines_isa_attach, .detach =3D ines_isa_detach, @@ -1218,7 +1218,7 @@ void ines_pcmcia_cleanup_module(void) pcmcia_unregister_driver(&ines_gpib_cs_driver); } =20 -static gpib_interface_t ines_pcmcia_unaccel_interface =3D { +static struct gpib_interface ines_pcmcia_unaccel_interface =3D { .name =3D "ines_pcmcia_unaccel", .attach =3D ines_pcmcia_attach, .detach =3D ines_pcmcia_detach, @@ -1246,7 +1246,7 @@ static gpib_interface_t ines_pcmcia_unaccel_interface= =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pcmcia_accel_interface =3D { +static struct gpib_interface ines_pcmcia_accel_interface =3D { .name =3D "ines_pcmcia_accel", .attach =3D ines_pcmcia_accel_attach, .detach =3D ines_pcmcia_detach, @@ -1274,7 +1274,7 @@ static gpib_interface_t ines_pcmcia_accel_interface = =3D { .return_to_local =3D ines_return_to_local, }; =20 -static gpib_interface_t ines_pcmcia_interface =3D { +static struct gpib_interface ines_pcmcia_interface =3D { .name =3D "ines_pcmcia", .attach =3D ines_pcmcia_accel_attach, .detach =3D ines_pcmcia_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1B6324CEEB for ; Wed, 16 Apr 2025 20:42:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836146; cv=none; b=e7gYBMxg+wNsiHQ37Tr6l6X5X9hvmOilCKiND/1htvbrNwxzQGEpJYgrSPfvJkWtr+i1x/AoqYNPsnjqEd+pQw+L8aH8CP7P14WZnSjrzHHch2EMyYPM85kez4h4qdpKjzudeGGCdkbgyey0rh0VwFF9WNGnBzJ0vWWOWxbWoDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836146; c=relaxed/simple; bh=7nOnj/t3IWRKRJuUCHCZoJzmMsnxpf6ffPgcSoWr688=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RiPsWWoAwTYdhTPsk8Y979H2kKVzTPHLvp4hZ6HdaPeigsaQYJkzuaEKYvb6YKxRDHqqt0MnE8K1KcIA0fDb+HmQ0I8mMww2mRnl8Jl1iTC98jQNtrtb+HfLTAPUydyeWGOKfu6WpoecJMuPj0J9xiGf0nbeSoqgMr3hqmFkxVo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=BXCmwlF3; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="BXCmwlF3" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-306b78ae2d1so11280a91.3 for ; Wed, 16 Apr 2025 13:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836144; x=1745440944; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=akTpKyJqwtY/MzR6JYTv6U/YQl7Z23JU2ZL/gi1Jfw0=; b=BXCmwlF3ghiq/vq97YA02lboCNCKxXsjjaYSOdVMtK8WPb8xVxT+Yk2ejGvS6y2Od+ XLRlR6fzM3yIbcfjAdmjVVYddmafyJWXhQDe27Ixc6NzzKMrRRxjVdcTNW9yD6KJq1EZ M/VuhouNim4d5XywC+QeWzWIViHSoJKrfCf+v0qDqJNxt/JpTiraHT4RFfQXSsGOe6vZ X8hYsWndn9jb159VjWnoJ7hghEVRhlVMzJecrIqxFLDPJ18tb8nL4UiL75OcFe7z+5pE eMVnkvgFZnInWQWaZwTUIxfUVWucek7OaphIAb628H/VQkvWFSoufLo05O4KWvGIrhET i1xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836144; x=1745440944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=akTpKyJqwtY/MzR6JYTv6U/YQl7Z23JU2ZL/gi1Jfw0=; b=pIOtCJ7Liq7H0jIaYMHTiIj9R1Gdsfo0/fSU1mhpcE4Ppfxrzu+MKkWbGpryj6eTb4 1eBk6iYhiMc5FDsITXHWgvGWEuKlAiolP/xQZdvlQxiXmrnWQW4NCFz7mwe4+a3L3WB8 /BO4m7NJKsI/R15o3L+e1c4hcCCcGrYq2OGsTE4rF0SEfXKlYc2IYktJ63PmQiK/aiwa PIZlrQ+TgZLgqQ4xEa6JMD6J4j3rde+7F+6sDPkll8A6WoR/yfbPPvY5N0QsSQQoD6fP 5IYMBg5K6g+eHoSkUd4kdM0+OOGYqzGC5wWbH7tMrOIe/m6cuG6SMEqdNHaLzjusmW48 rDBg== X-Forwarded-Encrypted: i=1; AJvYcCXoloSPoYx2Ma7GfpeNrv/bnS/FmxPO2C0YbfjabS5AZJypzo10WkZTHXY+I+LYXJR4NWm0062OWoN50l8=@vger.kernel.org X-Gm-Message-State: AOJu0YziUaqHisopk/Sj/Q0/nPtUk7o+gM+UJMGFf5kS0XThwvE3wphl /djHBd+9olPvdBXofT7ovvU6I/F0OTPle2GB2+c2dp5yEfwFfe9SCBYNbd4PMQ== X-Gm-Gg: ASbGncuPY8egQjekG4KYClSyWAgVulj+AZc/yfvTL/yfwPeiQnWWpgBVEnzvioPQtXX u65TsiWJHGD3JGkQ1uBkHUUr9Sj5ZwZjQHTkDxMD2/yHcmMTE0bmEtlE6Xnw1Wqanqu3aN97TaE C8iP8HIy2hcCwDmCHrRG57PpkO9npBc7pWm/pIa2ryjLtzBOZTh2tgSR1KiR4Hk3MWLG+uxPs2B LVG9vBywsona3wh21rgKGxeE33XyGxnirZDx3LB7hiVcsXkAn6RA367htOTb3Amblq0YjS81wm5 57BEWUP/5YAFcEi8jgjC8VM7HKOxlwvWixHBmZYg0EOR+zkNehx9X+7L2CST8fJ9W5qNMDo5rFv XmBbnDg== X-Google-Smtp-Source: AGHT+IEahXeFFjWp0p2qul0O2oupUGo/5kKivWmtqB61asyg9Eiq7M16/a86vLVksRu/6PZ7myUDpg== X-Received: by 2002:a17:90b:2b50:b0:301:1bce:c26f with SMTP id 98e67ed59e1d1-30863d1de1cmr4820746a91.3.1744836144196; Wed, 16 Apr 2025 13:42:24 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-308545a257esm2151852a91.2.2025.04.16.13.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:23 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 14/18] staging: gpib: lpvo_usb: struct gpib_interface Date: Wed, 16 Apr 2025 20:42:00 +0000 Message-ID: <20250416204204.8009-15-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 47f56fea28a6..494cfa21b938 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -1055,7 +1055,7 @@ static int usb_gpib_t1_delay(struct gpib_board *board= , unsigned int nano_sec) * *** module dispatch table and init/exit functions *** */ =20 -static gpib_interface_t usb_gpib_interface =3D { +static struct gpib_interface usb_gpib_interface =3D { .name =3D NAME, .attach =3D usb_gpib_attach, .detach =3D usb_gpib_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA20824DFE9 for ; Wed, 16 Apr 2025 20:42:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836147; cv=none; b=D5Fqc5QoGd81uPZ8DIXrz9CxtibILen8uvA9fXKLxI+k/Lx8mAde750iZmJa+LzN2ZVXZxTXd5c2SqS4gLbVum0MJlWAQ2/vlK1EKr2JhjWzlartlDaBi7EKixWJD6ERPmH0Ax9lfm+8ZVMglemwOW/O8/gydciMgSmst6LvhYY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836147; c=relaxed/simple; bh=7oIHWBBjQ7BlH6IvMzYiszexZSDJnBmjz47kdnIC5NU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UCPAp1HsAarJ0ef53zmynze4UtyVzKCTnuwLxdDPOZW0tsUkaUlx7hDsPYv0sF1alrdr/0F6pAPfbIN/DgdBXgodrHsSkcDZMfRRNHQEzdGomNnZyr9xOqZZViJucPUKl6D2m6PSKESYcxraJURaQh+8oTK6pXtjigPZp+VZrFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=N/QBXhYr; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="N/QBXhYr" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2295d78b433so1041165ad.2 for ; Wed, 16 Apr 2025 13:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836145; x=1745440945; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9Pdr3HWigL6Ku7LuE0NhaS5q7GdvsPzI86/WAfJAJfQ=; b=N/QBXhYr/+djcMpQJ1tRCCXT4onW8r++z4ikP/RcajKYHrcPbk1hoMx6j/QxtzxTFu FsC8y5M4jJJwYyQPcryjSXU8HK53xLKHiJjveJbfFKWjw5+t07whF3AS2uX1JRrMxCl0 lq/j9c5gLxztPlx2VFSIIYM9Bws+5id4ZYe9AQL5LhNqG8NQK/hUVmuW6K88ryiFxEQf 5u7coMcQylTFUg5AAGvUSRrSeQpGNm1zZGsqSxlE9AuK5dCDi04LIUJnw9P3sNDjAS7q D+ID71od/qXwTsXEKNvwgQUEa40C8TIMsfS6Y5sffiSrr83KZE/q8pnyJqIFEnCeHGV3 SAvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836145; x=1745440945; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Pdr3HWigL6Ku7LuE0NhaS5q7GdvsPzI86/WAfJAJfQ=; b=aICF8pVmvNxjv4L8DaPY3z7vgLaWjhRYPx/tuZ2bPrLm0Z0NHfIxLtV4aRgfMY01np 8Ic4mDwkSewsRbirrJ0cUSkSAGrZBe3u4uS9e14dfGB4lLDPPVGPHBuQ313Fo37S2UGy IniBnQEfu0gSIZy5GrjRW4J33Bmr8S79RV9IU1GfL35Z5QfeXwlG3U+ytdi2XyXr2u0N FY0iqogVx60s0F29hhrOK6neEg/G58UKauiH4CMFU3SEi0pIX9CDGbHQBRhK425C0zZX ToEsCwOVtXFlJLoBCjaao9/gTsBj4Ys6eLNbBYjPhpXNJQOx9ST2SwHdBIncVYtbEYQ1 mjEg== X-Forwarded-Encrypted: i=1; AJvYcCVaQCc3KmwqgcEVQKyqTAtfy5rhAusEbcIizDdL6S1Et0pKDNY11ozkQleU0fjZrrVukcDLDcFSPFSFdtQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1QXmkFhvINosPWRKR3q7q68vyafld8zRfk7HgS1gPSLmQd991 ViNsf+QLwHvO+4y9wOfT2nf2cQZXIdgmp92qZveH7yNM/PwTmWuNwjpSWId2lw== X-Gm-Gg: ASbGnct0zsuRl9EQTNbKpH32Ax3mtVvxVA4+4hqXQf1HNMzkNku0Ty+YdyNUd0UZ+do 5X+UKn89Fbj+qzf7401cz5oHS6ptRTBoDM3xvcxNN6GfBRpc8CrfZ8pEXAzNTUE8l1KtFgbqAOQ vWm4QubALdoQBQjy5QxK3U0meZVcs/C3RBrWRHY1KsVnGMWdkoWHCapnvvYMKV+zinDOsOkNLaS BEiuoBBDgkLM1UzmVuGkXl2q1EE02BnC48FmBKOhub+etEIEi5tW5bPSwQuSUcP8dsADnrwieOY HZ9SQVs4sLXqjRiUcih5XVXcTY29+GoChOlFVRiARkzr58vBepwuuJpPhgU1moSpWpHA3k/fa7j qJLCH6LDYdGS4RJXq X-Google-Smtp-Source: AGHT+IFgGXbC8NUaBhucm1SllpfE8LnJo42AjeHbg+eXJhZJkPIsWniUDEnSNOIKzZO0pM812bXo7A== X-Received: by 2002:a17:903:234a:b0:21f:7880:8472 with SMTP id d9443c01a7336-22c3597480fmr64364245ad.35.1744836145370; Wed, 16 Apr 2025 13:42:25 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33fe97ecsm18901965ad.255.2025.04.16.13.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:25 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 15/18] staging: gpib: ni_usb: struct gpib_interface Date: Wed, 16 Apr 2025 20:42:01 +0000 Message-ID: <20250416204204.8009-16-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gp= ib/ni_usb/ni_usb_gpib.c index 00f788a59dcc..a3d517efca08 100644 --- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c @@ -2373,7 +2373,7 @@ static void ni_usb_detach(struct gpib_board *board) mutex_unlock(&ni_usb_hotplug_lock); } =20 -static gpib_interface_t ni_usb_gpib_interface =3D { +static struct gpib_interface ni_usb_gpib_interface =3D { .name =3D "ni_usb_b", .attach =3D ni_usb_attach, .detach =3D ni_usb_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34C2724E008 for ; Wed, 16 Apr 2025 20:42:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836148; cv=none; b=iYeN/BBFOMch9X7d3+n+POxHi4TAAE9mjBZ4K+GgkCDV4Huu7f72CWxLCEcRB/Eml3nwJHuiuNTZpqMpZIAPVsJq4lgXr+03TNW5STqawo8EF2ZtCGkgnV02ruTYGndF61rsAaVe4GqiukDNTGgPoPespW3f10D6oKWVCcHaKG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836148; c=relaxed/simple; bh=r9FE5GpaFdBdPdJ/Zrxc1eYMAW56Ux07mT3KRwmjw48=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SU5YF8tNE0ylmlH/Z9ORdYFqlNz6TcIlKC7zXNcKtjlMI6tQVkSZ+7Uicx2kZ5dSrkQJHNF85wgei11CYFvkO10O33P/GgdimtKSinmiSpKk0NKLTCpFNtUPPFo9BF8PM4sLTso+TflRPcXLOm99M4lM4parUegbbO9T1hpqS2k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=NDKGSEvG; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="NDKGSEvG" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-22c33677183so1179215ad.2 for ; Wed, 16 Apr 2025 13:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836146; x=1745440946; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a8yDc+KkTQrj/aA1tqJ3BKYXbav1Fvp+NFLeH1to/I8=; b=NDKGSEvG8Bny7iUAZEaxVFbMfow3pHgbhsx+/puvzDF4HBlpG/bmDYzqxw9WbOQMNN ylgPbmjOhSf4ZCB40xtJcCsj8xk94Y+OWQ0ahgoPtjgDwsYHGtAtS9Fc1stzHa98HE0m ViQr/cQ5OkEuem+cqc3hdT6C3M+vOtu1ConKlCVLCxBYmEMJsD1hmDClcyvahDGksrkZ PTaSb0QLJOqUDUmLPApuGuGZobhms8Qte2EHqjxlEZF24y75ZA0TWzaI4v9zU8BlrUF9 ROeuIa9WwtyYqrRy8CK1krstvB+Jv03kNxl4Vyu82L2gQE41Utoena2Ey9M2gSNC9yDB wsIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836146; x=1745440946; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a8yDc+KkTQrj/aA1tqJ3BKYXbav1Fvp+NFLeH1to/I8=; b=j1nlUDOZpVb3c1BgxU8DYuUVRn2xyx44qWNELQqMLO/OiQEUP5bPFJUVDEIWh4vnFB v0l46y65UXUoeuo6JfdQPTb1kqVv2ahCBktRke6ZCbMlMUp8oEO4LaBzyec7joAddnxl VxJLmRnwZUdXCl5ZKZQ7o7JutZ7Z7GaL6T98lwEEhTg8l89nRxL7IczAzmIVNoRg2eX5 HHtYpV6g3qQP905Z27DLce4aUHdxv+b4L3hpmi0kMU7sgEgnEEEZJ7rPr9m1a0iqMdsP ExVeH+LkmTobiqzQtwWPIJouN7B2NSgBLADv7IkkGLLgwVXFSBc/49zvYtKriLfwuCFh tnUg== X-Forwarded-Encrypted: i=1; AJvYcCWeBTI8IdIMLLd1eUBXp7GUWH/cH+ojxnlUL1UfLv5z6tby2dn7OlA2Gx48ex1/Rs8WShthUXFo1Ui3GLM=@vger.kernel.org X-Gm-Message-State: AOJu0YxwJBnap2uYmoI3a2gz6kAGWRwLoUx+/zz72Nq9j3slzofBw4z1 dMW0u0K/f8iucUSZN6BVMqqgZqDb7Owiee3VtMI047kaa4DB43kZSzZmau/l9g== X-Gm-Gg: ASbGncsr7ykw6820tH+4QBsc027tSxvBraWtg16mYIgCr5FvNrAxLX3xvGLlTmyDIo6 LtNyHZWvNTUPjVPsUR2BCbOBwNvWpP/fZa2UMoG42PDSGWeE4wkVKyYA44FSWTf4hDSME6NJ/Q7 CL6MCywLonambVBhhaXJBaZUZ5chlScMxdqS++GylV5+usnZOY8Wbmz4XGlG+tZLbpnAnDuZ8QU UDRVnzqBLP6b0pdI4X8vT1HX5/hOpWEowZ4XobyvVi0hrU13aLXakJuBjbt8Vq2r579MC+b6Fh9 oOCj3CHfWIKio5MU5/1Co9cwoknk+LduyqLLXHa6QRLPcaaZCKm77ECAJIRka2+NRQI3zXBSMLN 06G6TbA== X-Google-Smtp-Source: AGHT+IHaYCE1yo3wywCZz1WcKGDv4E5arxZTfISVirWVGIKPHGaGjoxMurBeZllSADoTUT314yzFZw== X-Received: by 2002:a17:902:e544:b0:224:1eab:97b2 with SMTP id d9443c01a7336-22c359844b4mr53603915ad.53.1744836146538; Wed, 16 Apr 2025 13:42:26 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33fc47e0sm18808655ad.167.2025.04.16.13.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:26 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 16/18] staging: gpib: pc2: struct gpib_interface Date: Wed, 16 Apr 2025 20:42:02 +0000 Message-ID: <20250416204204.8009-17-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/pc2/pc2_gpib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/pc2/pc2_gpib.c b/drivers/staging/gpib/pc2= /pc2_gpib.c index ee4ea1f32dfc..ae265e2eb46a 100644 --- a/drivers/staging/gpib/pc2/pc2_gpib.c +++ b/drivers/staging/gpib/pc2/pc2_gpib.c @@ -519,7 +519,7 @@ static void pc2_2a_detach(struct gpib_board *board) pc2a_common_detach(board, pc2_2a_iosize); } =20 -static gpib_interface_t pc2_interface =3D { +static struct gpib_interface pc2_interface =3D { .name =3D "pcII", .attach =3D pc2_attach, .detach =3D pc2_detach, @@ -547,7 +547,7 @@ static gpib_interface_t pc2_interface =3D { .return_to_local =3D pc2_return_to_local, }; =20 -static gpib_interface_t pc2a_interface =3D { +static struct gpib_interface pc2a_interface =3D { .name =3D "pcIIa", .attach =3D pc2a_attach, .detach =3D pc2a_detach, @@ -575,7 +575,7 @@ static gpib_interface_t pc2a_interface =3D { .return_to_local =3D pc2_return_to_local, }; =20 -static gpib_interface_t pc2a_cb7210_interface =3D { +static struct gpib_interface pc2a_cb7210_interface =3D { .name =3D "pcIIa_cb7210", .attach =3D pc2a_cb7210_attach, .detach =3D pc2a_detach, @@ -603,7 +603,7 @@ static gpib_interface_t pc2a_cb7210_interface =3D { .return_to_local =3D pc2_return_to_local, }; =20 -static gpib_interface_t pc2_2a_interface =3D { +static struct gpib_interface pc2_2a_interface =3D { .name =3D "pcII_IIa", .attach =3D pc2_2a_attach, .detach =3D pc2_2a_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82E9624E4A9 for ; Wed, 16 Apr 2025 20:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836150; cv=none; b=cUkcs4MTDLYnwhjdcqFft59+KmqDWvvFnXdHl574xY0MhvmJQYAKjvs68cwJPdlHYLXqssqTOv0jv5RCX7drNLoej3MTICzPk5j16oXLYlXbA9C178U1FouMShqw/+zX4Kpv981MgI7koPubmGYFKorpz8gGodEVbHye8Qmhwmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836150; c=relaxed/simple; bh=1+tRRy/nL01MPl0+5FS05H/L2lfuD8Vmz0fi46Q1xuA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gnFL40LeHqK9R4bs4Wfkr9DmfQtTyiWAjVRZYohLB/L+s+RGHgi7t54aZhuS46oQzmIAiFKOPd8ekr2pYCJovfyK5xR7iUV85JgSJweGlTUSuPYbxOSdcNrGoh0zKlXE4fIXt8KrUf6c1jYOeblikGM0k6ehuKHthsXmM4qEY84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Ap9GVbsW; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Ap9GVbsW" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-73bf1cef6ceso33631b3a.0 for ; Wed, 16 Apr 2025 13:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836148; x=1745440948; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TjTAiMO1GxG/PObrFdD9u5YrnCsI7HGevSexjRmDxRA=; b=Ap9GVbsWVbEwMm0Sgi8qI6MEiKXrdUUqyX+t2M8HmHTD93+khDB9pi9FtkycY+X4+m PwY9c4GzGBuS2X7kkmUapSK01zLGyDXgVlIpWjqlGM9a3FttFWfq/5hXUTuYONXGuBGi VDLh2tfthNrFZtzqdPB6BrKUR8WyWcvImrHeT2RecTv7Lc2IKUpHAyUjE2f8DnRq4TEy mia5mh+0TlvdkxI+K5knujm+CVw93UaOAFu6mULPf/vvjNel4cxG7MGWv134iKovPxgp 7kynVG3fcKQ0ReGXvKS/gooXrws72eAgSCsR0JKNg9l/NIBvYHzovReFJrI1mut+euIt dqRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836148; x=1745440948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TjTAiMO1GxG/PObrFdD9u5YrnCsI7HGevSexjRmDxRA=; b=RS559CUH+s8t3MftRRRH4OOGVcqEsNkphHWNg49Dntz5kjxZKcX/0Ztb2mWGx5jrqf /xGJQpou2sawQdeFfoKmJUf03LRakXyWpSgTBurd0SgMS+DPm+o7SBFuoVJRF+ncLCc2 xbIzWeoJ28JibpHyX+/YxMcuz8mhUWToLOR1EXjujXnIY+I6iynZfePboWkAIEgBPS7o P7hBpXKL6HBILCO5FQKdrZAjQ2Fg4WEmXG5YLJJ8J5orladtBDUWEKOX0t9s2DhiZAbr qMr/UWdrzvymIFkN3Rs+5k/UqJJDKTl3SD6XuSXCIKxUzTbGFgtrq3N8rp2VCBj2lVLI X21g== X-Forwarded-Encrypted: i=1; AJvYcCU2wIODyVwyFRFe2F5K2oQtpJTimLCX4XBltSHjZivcuA3yGoHc2z+y58Q/c6hc5Ygcjw2rpCAqB79TbcQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwAIa33or4rUUGGtI0BnsTXXSF0O+Z+z0n4gpHc33MABuOsXcuT JGfj/gI8shfQDgvQm8oJCTs1dZiG4dnGjml0t4sbs5tu4SFHRqLedfiVduIwNg== X-Gm-Gg: ASbGncsRCzVru64pF4b9XqwvNtkslzNEIp3th1tw04jrMBQe0SCZzos/U2ECUDg+A01 GDo6eAfTkEK5KGw0Lvh0z/kl+7uI8ZzYqFFY5IjmzpQAqawE51peNxrGAAbHJ3ibKc/sVPRgcBW uHdnpwFqkg4NvZsk0t2KoV+jycYkU7rUDyc9dYnIFt2JzmDwb7vMne6/l0usZfJDYqRSrwzuDOL tPYyB1fMSl299fyQG6ovdO4DVt5T876+sLEEyxcP63Jt82mil21jcdVtCyAyuFQtXHuyXzmUExb m9ooS/BEXYpuBXg1WkFGIxD5fHGnu07J+xLLGEmkRqc0gFQY7bml+ja8rl0XGZge+WnfiNZi4/u 49ZikWC+ii8UaNWC5 X-Google-Smtp-Source: AGHT+IHpNWh/TvCbMhLIoPioSeKOQ3n/NrD1YbIxs/DRLH0xJAqpSQFycneeGM0Ao3h91UMlT6xyXg== X-Received: by 2002:a05:6a00:3920:b0:736:3c77:31fd with SMTP id d2e1a72fcca58-73c267ecd0bmr4332352b3a.23.1744836147688; Wed, 16 Apr 2025 13:42:27 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd21c2119sm10778264b3a.40.2025.04.16.13.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:27 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 17/18] staging: gpib: tnt4882: struct gpib_interface Date: Wed, 16 Apr 2025 20:42:03 +0000 Message-ID: <20250416204204.8009-18-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 24 ++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c b/drivers/staging/= gpib/tnt4882/tnt4882_gpib.c index da13d11c20bd..d26a388912c9 100644 --- a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c +++ b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c @@ -1122,7 +1122,7 @@ static int tnt4882_pci_probe(struct pci_dev *dev, con= st struct pci_device_id *id return 0; } =20 -static gpib_interface_t ni_pci_interface =3D { +static struct gpib_interface ni_pci_interface =3D { .name =3D "ni_pci", .attach =3D ni_pci_attach, .detach =3D ni_pci_detach, @@ -1150,7 +1150,7 @@ static gpib_interface_t ni_pci_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_pci_accel_interface =3D { +static struct gpib_interface ni_pci_accel_interface =3D { .name =3D "ni_pci_accel", .attach =3D ni_pci_attach, .detach =3D ni_pci_detach, @@ -1178,7 +1178,7 @@ static gpib_interface_t ni_pci_accel_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_isa_interface =3D { +static struct gpib_interface ni_isa_interface =3D { .name =3D "ni_isa", .attach =3D ni_tnt_isa_attach, .detach =3D ni_isa_detach, @@ -1206,7 +1206,7 @@ static gpib_interface_t ni_isa_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nat4882_isa_interface =3D { +static struct gpib_interface ni_nat4882_isa_interface =3D { .name =3D "ni_nat4882_isa", .attach =3D ni_nat4882_isa_attach, .detach =3D ni_isa_detach, @@ -1234,7 +1234,7 @@ static gpib_interface_t ni_nat4882_isa_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nec_isa_interface =3D { +static struct gpib_interface ni_nec_isa_interface =3D { .name =3D "ni_nec_isa", .attach =3D ni_nec_isa_attach, .detach =3D ni_isa_detach, @@ -1262,7 +1262,7 @@ static gpib_interface_t ni_nec_isa_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_isa_accel_interface =3D { +static struct gpib_interface ni_isa_accel_interface =3D { .name =3D "ni_isa_accel", .attach =3D ni_tnt_isa_attach, .detach =3D ni_isa_detach, @@ -1290,7 +1290,7 @@ static gpib_interface_t ni_isa_accel_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nat4882_isa_accel_interface =3D { +static struct gpib_interface ni_nat4882_isa_accel_interface =3D { .name =3D "ni_nat4882_isa_accel", .attach =3D ni_nat4882_isa_attach, .detach =3D ni_isa_detach, @@ -1318,7 +1318,7 @@ static gpib_interface_t ni_nat4882_isa_accel_interfac= e =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_nec_isa_accel_interface =3D { +static struct gpib_interface ni_nec_isa_accel_interface =3D { .name =3D "ni_nec_isa_accel", .attach =3D ni_nec_isa_attach, .detach =3D ni_isa_detach, @@ -1377,8 +1377,8 @@ MODULE_DEVICE_TABLE(pnp, tnt4882_pnp_table); #endif =20 #ifdef CONFIG_GPIB_PCMCIA -static gpib_interface_t ni_pcmcia_interface; -static gpib_interface_t ni_pcmcia_accel_interface; +static struct gpib_interface ni_pcmcia_interface; +static struct gpib_interface ni_pcmcia_accel_interface; static int __init init_ni_gpib_cs(void); static void __exit exit_ni_gpib_cs(void); #endif @@ -1775,7 +1775,7 @@ static void ni_pcmcia_detach(struct gpib_board *board) tnt4882_free_private(board); } =20 -static gpib_interface_t ni_pcmcia_interface =3D { +static struct gpib_interface ni_pcmcia_interface =3D { .name =3D "ni_pcmcia", .attach =3D ni_pcmcia_attach, .detach =3D ni_pcmcia_detach, @@ -1803,7 +1803,7 @@ static gpib_interface_t ni_pcmcia_interface =3D { .return_to_local =3D tnt4882_return_to_local, }; =20 -static gpib_interface_t ni_pcmcia_accel_interface =3D { +static struct gpib_interface ni_pcmcia_accel_interface =3D { .name =3D "ni_pcmcia_accel", .attach =3D ni_pcmcia_attach, .detach =3D ni_pcmcia_detach, --=20 2.43.0 From nobody Wed Dec 17 05:48:42 2025 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B06A024CEEB for ; Wed, 16 Apr 2025 20:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836151; cv=none; b=BxS569a48jiGpIZhArzhEs4UoRWJTK6VOESwYVW9YlWlWETlUtPohM3qqDVA0/VVXtd3i8bFQomChqJy8NcB7MQqnz8/e4PzjhJkmCGnLEtSP4M8A3nqi4DaWUpqA78BSDJIcOO4aj1xN2TzPjP7j7xCbAIVcmya3pvIe/UNbSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744836151; c=relaxed/simple; bh=W7NKhnTpUeOCGlpiS2roAP2cc1f4BGRsQOUiHrDOA1M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Iroivun+4wMOTN0/tdyqLD8hQjKaaLtmXWM+6DiZXccn4bRwakSyLqIOAWOfwtZleT7OnVMhNfzc3AIHdTNdq+W8m4MaINfuvI4xnkzpfqo4xc/+91/GNbm5SrVstrsaqKOUiJmvgd37yx8fDKkh7CAbA9UM6HTF3deGvAbnpPI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=k29uOiZ6; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="k29uOiZ6" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-736ad42dfd6so14810b3a.3 for ; Wed, 16 Apr 2025 13:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744836149; x=1745440949; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HUDIvKIBsD4gxpULDKxinqYIlQSnX87hM/ddYNKNziQ=; b=k29uOiZ6VyaBVQiDDXpUkrNvF7xIL5114BEmfbsky1VnvzTgRpgNt5cd7+VZgS1gDW n4tUo55naND8mkOdXxkpcfJc2l+k8EmyWy30YJ5PEpBxtDlB5ZqYfqOfz807/NxXp0kg xJTGiVCjeVb4U9wxf47d7Cm+fEo4Cz0euo2vEsGz0aI8S+aKlrDk28tdm6XlL9FKgtqP ZTQWp9AL6ic//be8bN7yC7FSEvWj/UE2LO4eF0CjXCNJ5p33+Lvtk8qBL4nHD2GxqkK6 rpOzHI3QThoZwc7OuZtPUhoP8E3B74hd6vNP9BJk7Ts/GCKJJQsFfIqmHsWZoDvD9+aV HVoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744836149; x=1745440949; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HUDIvKIBsD4gxpULDKxinqYIlQSnX87hM/ddYNKNziQ=; b=bhtArdkF+rmq5uxZj7iyjYxXuQaREweiBT2A2qUi72pzp/0dRkL0JlAED9iYH/wvQY /2DGVCCEFqwsHDjCyfh12dLXZl41eNlelPp0T/P7WHAFHezgqpkn0YMFziEEJByz2ovP OH/Jxe0AVSHD3yZj6EgzEyH9Jm+JybLSvA16FpE4fdi5uxyq54qif5uUPFGWPMyPiKe2 zoJrRvNBJPLT7iqp7jBLlEEvi1XV4QAy/CAcm6oyUgJZxfnYeZONfm+w+Q5rVSGhrcm0 y2TgUfmcQx0GZwKIEv8XoZybwFBoLCBr1+hpAEEihX9F5DdWdxcZPS8fsvhoL475vuXz o7KQ== X-Forwarded-Encrypted: i=1; AJvYcCWReo6TOpJh81bACS5O5omVQeCt+TbClXVlsOz9xJZ1z/dZorBpEzFmGG6Oxf6rnvCw0SK80DnVVJ/XRT0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl+JIwlSuS44RZDGK2zVnBfyFFNKQLI3aa4y0PnqSqBx8pGxSd LusDGZ8bi4ZwvtlyNmE2vxif1/VhEj7hDv8rQabW0MVDdv7yMmRHwZ8iWQsJOHCL4Hjr662Gv34 = X-Gm-Gg: ASbGncuP6oxjS4w49TE0mamIE6mgYlkzL0n9Z7mtFMTLaQQ7DND+LTWOqnBfzWNm1Nl Iw4PdrKsbD2gtreuF9ClZAgLfDX2iLZ7gXvdCpS7uqtSGohJPI9HGN027TwdPLeLQAaopisrDCP wQ2L+a3ApqavJTLsicHoG1BbVvknHfmrfQ9mEfOkhVFywUqiKr13nJNlUcrVt03yuxY+buh8UGW PxztzPoPKM5pr0nZ0ps5h5BGKOBe0IPM6GBr/34u0/ZqjQ0WrvHRbmYouPiNlNAPha1Sgxl8HWI E7OVc3VL2BFpOII0nAaMPoJt+Y5xgGDY+cDb6A3rKFnAAK3mg8OIRhGidtP1Ih+OnKW50VJ4xSK TBpvDEA== X-Google-Smtp-Source: AGHT+IEX4eXsP44VjunXaWcttdOrgPWfZ/OAkwqbXiSZcKyF1PkjkyDAsrb9kEIF5F6lmw4jiz197Q== X-Received: by 2002:aa7:888d:0:b0:736:476b:fcd3 with SMTP id d2e1a72fcca58-73c267f174dmr5267257b3a.24.1744836148828; Wed, 16 Apr 2025 13:42:28 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd22f0fc5sm11202994b3a.91.2025.04.16.13.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 13:42:28 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [PATCH v2 18/18] staging: gpib: Removing typedef gpib_interface_t Date: Wed, 16 Apr 2025 20:42:04 +0000 Message-ID: <20250416204204.8009-19-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250416204204.8009-1-matchstick@neverthere.org> References: <20250416204204.8009-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Removing gpib_interface_t to adhere to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/include/gpib_types.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gp= ib/include/gpib_types.h index 16aaade310fd..62ce174add85 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -8,7 +8,7 @@ #define _GPIB_TYPES_H =20 #ifdef __KERNEL__ -/* gpib_interface_t defines the interface +/* gpib_interface defines the interface * between the board-specific details dealt with in the drivers * and generic interface provided by gpib-common. * This really should be in a different header file. @@ -22,7 +22,6 @@ #include #include =20 -typedef struct gpib_interface gpib_interface_t; struct gpib_board; =20 /* config parameters that are only used by driver attach functions */ @@ -212,7 +211,7 @@ static inline void init_gpib_pseudo_irq(struct gpib_pse= udo_irq *pseudo_irq) /* list so we can make a linked list of drivers */ struct gpib_interface_list { struct list_head list; - gpib_interface_t *interface; + struct gpib_interface *interface; struct module *module; }; =20 @@ -222,7 +221,7 @@ struct gpib_interface_list { */ struct gpib_board { /* functions used by this board */ - gpib_interface_t *interface; + struct gpib_interface *interface; /* Pointer to module whose use count we should increment when * interface is in use */ --=20 2.43.0