From nobody Fri Dec 19 19:21:22 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B5928F53E; Tue, 15 Apr 2025 10:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744713819; cv=none; b=rqLnY9xsUr0aX39v9Vhty0YtMZtPOVmegYI22nb/UeE1txOcloV1gtokOnmvL3CSmxJQ2clTucwErYutd17sAD6OGDNOuI52XlWsAPthcILYGwR3mkv67Lnp9Dr71cc7rQY7l60lTwzXG1m0HiHa+aAvJJRn5m2CGNB9ImpdUM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744713819; c=relaxed/simple; bh=Jj6J0Wp3BLe1Iu7KLkRvyL7L+U+C0SEmlBy2KW1i5N4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R93Qx4GgfOz72DJNX088pcmyYxt6PWDCTVaxBH8kmmabSVAJrW/s5Y3xlf+U+Eud62snW5imiyC7PGbjyvqLlAop5dFWJMo14YlgE8Zfk8mQXTc3Xms8shDKUt5eGXDyj1FtDyu6P3ohaaYrx+5DTm4plGbn64ycX21WDTPWx5I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=WxGb9Qf3; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="WxGb9Qf3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1744713816; bh=Jj6J0Wp3BLe1Iu7KLkRvyL7L+U+C0SEmlBy2KW1i5N4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WxGb9Qf3bxsLrQVMAGY+GXK6b90Qh5rMsiCmNifwSDZEKWWCOgtQmAs1HdWkMYw0S 53G7bq25DRWFaOViGM4NaBkbRxeh2O4FmpCcw0byeigoo+LZTKiV5/gfDfDXED5R/L MYEe6s9prsLX8YIR8QXoYW500kZXrEWomSSeZjx/Y9BTDDn4BL7dr2KHXbXkCgxhhY kZhtlqPURIPXpJwnYSEq0bDbdJIR9xsCY5V9Nj9Y37k6Uzi3w0xz7NXhl8JMU3wRXD oVHVHT5jJG2U0U57Q/SmlH1FtfnjimWy/8X5PD+pr5GSSBDmI8d13t7Bj8J4H9WUDS 7nRvYCwiBj/4g== Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 799A317E35EB; Tue, 15 Apr 2025 12:43:34 +0200 (CEST) From: AngeloGioacchino Del Regno To: chunkuang.hu@kernel.org Cc: p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, ck.hu@mediatek.com, jitao.shi@mediatek.com, jie.qiu@mediatek.com, junzhi.zhao@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, dmitry.baryshkov@linaro.org, lewis.liao@mediatek.com, ives.chenjh@mediatek.com, tommyyl.chen@mediatek.com, jason-jh.lin@mediatek.com, Alexandre Mergnat Subject: [PATCH v9 04/23] drm/mediatek: mtk_cec: Switch to register as module_platform_driver Date: Tue, 15 Apr 2025 12:43:02 +0200 Message-ID: <20250415104321.51149-5-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250415104321.51149-1-angelogioacchino.delregno@collabora.com> References: <20250415104321.51149-1-angelogioacchino.delregno@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for adding a driver for the new HDMIv2 IP, and before splitting out the common bits from the HDMI driver, change the mtk_cec driver from being registered from the mtk_hdmi driver itself to be a module_platform_driver of its own. Besides being a cleanup, this also allows build flexibility by allowing to compile the CECv1 driver only when needed (for example, this is not needed nor used in HDMIv2 configurations). Reviewed-by: Alexandre Mergnat Reviewed-by: CK Hu Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/Makefile | 4 ++-- drivers/gpu/drm/mediatek/mtk_cec.c | 7 ++++++- drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +- drivers/gpu/drm/mediatek/mtk_hdmi.h | 1 - 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/M= akefile index 2930d8d42a95..4330866522da 100644 --- a/drivers/gpu/drm/mediatek/Makefile +++ b/drivers/gpu/drm/mediatek/Makefile @@ -23,10 +23,10 @@ mediatek-drm-y :=3D mtk_crtc.o \ =20 obj-$(CONFIG_DRM_MEDIATEK) +=3D mediatek-drm.o =20 -mediatek-drm-hdmi-objs :=3D mtk_cec.o \ - mtk_hdmi.o \ +mediatek-drm-hdmi-objs :=3D mtk_hdmi.o \ mtk_hdmi_ddc.o =20 +obj-$(CONFIG_DRM_MEDIATEK_HDMI) +=3D mtk_cec.o obj-$(CONFIG_DRM_MEDIATEK_HDMI) +=3D mediatek-drm-hdmi.o =20 obj-$(CONFIG_DRM_MEDIATEK_DP) +=3D mtk_dp.o diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/= mtk_cec.c index b42c0d87eba3..c7be530ca041 100644 --- a/drivers/gpu/drm/mediatek/mtk_cec.c +++ b/drivers/gpu/drm/mediatek/mtk_cec.c @@ -12,7 +12,6 @@ #include =20 #include "mtk_cec.h" -#include "mtk_hdmi.h" #include "mtk_drm_drv.h" =20 #define TR_CONFIG 0x00 @@ -102,6 +101,7 @@ void mtk_cec_set_hpd_event(struct device *dev, cec->hpd_event =3D hpd_event; spin_unlock_irqrestore(&cec->lock, flags); } +EXPORT_SYMBOL_NS_GPL(mtk_cec_set_hpd_event, "DRM_MTK_HDMI_V1"); =20 bool mtk_cec_hpd_high(struct device *dev) { @@ -112,6 +112,7 @@ bool mtk_cec_hpd_high(struct device *dev) =20 return (status & (HDMI_PORD | HDMI_HTPLG)) =3D=3D (HDMI_PORD | HDMI_HTPLG= ); } +EXPORT_SYMBOL_NS_GPL(mtk_cec_hpd_high, "DRM_MTK_HDMI_V1"); =20 static void mtk_cec_htplg_irq_init(struct mtk_cec *cec) { @@ -247,3 +248,7 @@ struct platform_driver mtk_cec_driver =3D { .of_match_table =3D mtk_cec_of_ids, }, }; +module_platform_driver(mtk_cec_driver); + +MODULE_DESCRIPTION("MediaTek HDMI CEC Driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek= /mtk_hdmi.c index 1358a5095fde..f4476a12055b 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1788,7 +1788,6 @@ static struct platform_driver mtk_hdmi_driver =3D { =20 static struct platform_driver * const mtk_hdmi_drivers[] =3D { &mtk_hdmi_ddc_driver, - &mtk_cec_driver, &mtk_hdmi_driver, }; =20 @@ -1810,3 +1809,4 @@ module_exit(mtk_hdmitx_exit); MODULE_AUTHOR("Jie Qiu "); MODULE_DESCRIPTION("MediaTek HDMI Driver"); MODULE_LICENSE("GPL v2"); +MODULE_IMPORT_NS("DRM_MTK_HDMI_V1"); diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.h b/drivers/gpu/drm/mediatek= /mtk_hdmi.h index 472bf141c92b..e40bc4651995 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.h +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.h @@ -8,7 +8,6 @@ =20 struct platform_driver; =20 -extern struct platform_driver mtk_cec_driver; extern struct platform_driver mtk_hdmi_ddc_driver; =20 #endif /* _MTK_HDMI_CTRL_H */ --=20 2.49.0