From nobody Tue Dec 16 14:34:24 2025 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A62DB1B0439 for ; Mon, 14 Apr 2025 20:54:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744664080; cv=none; b=kxSo0WZy33ZUPr/48JbqJbB74OPcgj6F/nXlW8MtqXsoIgsSlm0zNqKlLnUfoHWhFhP1Z6AUMXQzXF2w96Gkyk+yGn8JTZR2c2MrAEs+B5mYL8FGBPPa6ZdViPy/kJiWAR/u/vkUh+cDd6WGhBffC0EuVSglED5M5PmBl7WHCqg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744664080; c=relaxed/simple; bh=IVbscjkg/t7tmXG342QUVsKw+0b4TEyy9/kLcTms0sA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bipYrZSUCzCMeyHfU88GAGvDiP7zf6NZ58tJjOA4rwt50+W3k1ynv7XxrGy8+T3KqiaFsPqhvOTownDkcpzz7h+fHTUTkEMpU6+chogFukEW40wO33PKWCBJDtutWnlecUsaTPlbjQM2b1sxRKRIvUXJQk0STP8LM/AsH3NJKLM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=BKd1LOnm; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="BKd1LOnm" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744664065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=TR7dEj56cb1DCkyT7kzwEfs2jUXxT36dtnwHb+IVk6g=; b=BKd1LOnmEWr3oflhSfJvvNzpG75JcMTHlSEIPWwjWDX/mWzFhoWeTnObkVGl8ngRsjaku0 OXfbYtjrxeXR/+pgSpGuoX4AoHmZTFXcVSTwCx5uzCh7FHz53Gy4g1OupA5DWK64q2x5AS RBfZ9X/E5SzEy5PBuQ55Zf8KXhot8So= From: Thorsten Blum To: Miklos Szeredi , Amir Goldstein Cc: Thorsten Blum , linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH] ovl: Use str_on_off() helper in ovl_show_options() Date: Mon, 14 Apr 2025 22:54:08 +0200 Message-ID: <20250414205408.1504-1-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Remove hard-coded strings by using the str_on_off() helper function. Acked-by: Amir Goldstein Signed-off-by: Thorsten Blum --- fs/overlayfs/params.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c index 6759f7d040c8..259ef21f3d08 100644 --- a/fs/overlayfs/params.c +++ b/fs/overlayfs/params.c @@ -1078,17 +1078,16 @@ int ovl_show_options(struct seq_file *m, struct den= try *dentry) seq_printf(m, ",redirect_dir=3D%s", ovl_redirect_mode(&ofs->config)); if (ofs->config.index !=3D ovl_index_def) - seq_printf(m, ",index=3D%s", ofs->config.index ? "on" : "off"); + seq_printf(m, ",index=3D%s", str_on_off(ofs->config.index)); if (ofs->config.uuid !=3D ovl_uuid_def()) seq_printf(m, ",uuid=3D%s", ovl_uuid_mode(&ofs->config)); if (ofs->config.nfs_export !=3D ovl_nfs_export_def) - seq_printf(m, ",nfs_export=3D%s", ofs->config.nfs_export ? - "on" : "off"); + seq_printf(m, ",nfs_export=3D%s", + str_on_off(ofs->config.nfs_export)); if (ofs->config.xino !=3D ovl_xino_def() && !ovl_same_fs(ofs)) seq_printf(m, ",xino=3D%s", ovl_xino_mode(&ofs->config)); if (ofs->config.metacopy !=3D ovl_metacopy_def) - seq_printf(m, ",metacopy=3D%s", - ofs->config.metacopy ? "on" : "off"); + seq_printf(m, ",metacopy=3D%s", str_on_off(ofs->config.metacopy)); if (ofs->config.ovl_volatile) seq_puts(m, ",volatile"); if (ofs->config.userxattr) --=20 2.49.0