From nobody Fri Dec 19 12:30:00 2025 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEA148F66; Mon, 14 Apr 2025 00:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744591995; cv=none; b=X7fO8FRYeGCUx1fDY1FJq5nGlNSXFtY8zzbbqlj2UCsDOiXLhKvbm1NC8wYlOrxGTis4lBcQ0ZkSr5YHOVwdwbyXQC4LDKFyxNGzah1otwE4P6NeiGAPETqC6URb5BGKpInJx2hw25rF4Sjj9rb7pEQ219aFpWwdRyYu9syEHmg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744591995; c=relaxed/simple; bh=+5WPSOKOJAuhqeY5OauOEQzIL7JOqS8n+v93p05JEN8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dwprvaiPEjVNNTmvtXSJhH9Dwkqc4coOn7oaH7/H27dK7/PYLQ9avAYjBlMV2viTW2KJELA/ckPmH5+Qn8i/RtZj9uweSGu6lKlwmxvIIE6dmV6Lr7HD6S/HWMxAZ5+HIK+y4IvyBo2Zx9Ql7o6rZtqAzFbshVwJSiPQoAKwcHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=arqgkP8G; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="arqgkP8G" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=nnRMCG9EM/ZVIQjUHE38dkH+p4UxD53w3hZZ34V5yDk=; b=arqgkP8GSmokLyTn fX0tq6cVFBcOEaxDgcn+8++BmkCDqt5hVvHcDs2I7Tigy2IhmEErQDUBIDAUb3R2pwNwWYDlQDOmb TnEo7M2Sr+kNXNbLZl50sj2UMFWdqjfCEgDxJSUW1/uFggvA3EXaE3yAIP2g4bPh7q5ZABLyaHFfp VapJf6Nnt3ytwq9xjRtbys5rnnH8RUFb7t2l2BYNjBwIDLsHZkbCYaE2e5R3/lxUSZVpY8hZxRrQY 4SbRCpbYfWnqeTGjJIOrMfxJIoOKhQvsLZv0nQfIzZ7IRJsZuyCnq32rKq+1gAQoS6Xo65ON36oYJ lpWn72TTucrLiAtxCw==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u484R-00B6OC-05; Mon, 14 Apr 2025 00:53:07 +0000 From: linux@treblig.org To: manishc@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH net-next 1/5] qed: Remove unused qed_memset_*ctx functions Date: Mon, 14 Apr 2025 01:52:43 +0100 Message-ID: <20250414005247.341243-2-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250414005247.341243-1-linux@treblig.org> References: <20250414005247.341243-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" qed_memset_session_ctx() and qed_memset_task_ctx() were added in 2017 as part of commit da09091732ae ("qed*: Utilize FW 8.33.1.0") but have not been used. Remove them. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 24 ------------ .../ethernet/qlogic/qed/qed_init_fw_funcs.c | 38 ------------------- 2 files changed, 62 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_hsi.h b/drivers/net/ethern= et/qlogic/qed/qed_hsi.h index ed1a84542ad2..3181fed1274e 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_hsi.h +++ b/drivers/net/ethernet/qlogic/qed/qed_hsi.h @@ -2694,30 +2694,6 @@ void qed_calc_session_ctx_validation(void *p_ctx_mem, void qed_calc_task_ctx_validation(void *p_ctx_mem, u16 ctx_size, u8 ctx_type, u32 tid); =20 -/** - * qed_memset_session_ctx(): Memset session context to 0 while - * preserving validation bytes. - * - * @p_ctx_mem: Pointer to context memory. - * @ctx_size: Size to initialzie. - * @ctx_type: Context type. - * - * Return: Void. - */ -void qed_memset_session_ctx(void *p_ctx_mem, u32 ctx_size, u8 ctx_type); - -/** - * qed_memset_task_ctx(): Memset task context to 0 while preserving - * validation bytes. - * - * @p_ctx_mem: Pointer to context memory. - * @ctx_size: size to initialzie. - * @ctx_type: context type. - * - * Return: Void. - */ -void qed_memset_task_ctx(void *p_ctx_mem, u32 ctx_size, u8 ctx_type); - #define NUM_STORMS 6 =20 /** diff --git a/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c b/drivers/= net/ethernet/qlogic/qed/qed_init_fw_funcs.c index 407029a36fa1..4b9128c08ad3 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c +++ b/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c @@ -1666,44 +1666,6 @@ void qed_calc_task_ctx_validation(void *p_ctx_mem, *region1_val_ptr =3D qed_calc_cdu_validation_byte(ctx_type, 1, tid); } =20 -/* Memset session context to 0 while preserving validation bytes */ -void qed_memset_session_ctx(void *p_ctx_mem, u32 ctx_size, u8 ctx_type) -{ - u8 *x_val_ptr, *t_val_ptr, *u_val_ptr, *p_ctx; - u8 x_val, t_val, u_val; - - p_ctx =3D (u8 * const)p_ctx_mem; - x_val_ptr =3D &p_ctx[con_region_offsets[0][ctx_type]]; - t_val_ptr =3D &p_ctx[con_region_offsets[1][ctx_type]]; - u_val_ptr =3D &p_ctx[con_region_offsets[2][ctx_type]]; - - x_val =3D *x_val_ptr; - t_val =3D *t_val_ptr; - u_val =3D *u_val_ptr; - - memset(p_ctx, 0, ctx_size); - - *x_val_ptr =3D x_val; - *t_val_ptr =3D t_val; - *u_val_ptr =3D u_val; -} - -/* Memset task context to 0 while preserving validation bytes */ -void qed_memset_task_ctx(void *p_ctx_mem, u32 ctx_size, u8 ctx_type) -{ - u8 *p_ctx, *region1_val_ptr; - u8 region1_val; - - p_ctx =3D (u8 * const)p_ctx_mem; - region1_val_ptr =3D &p_ctx[task_region_offsets[0][ctx_type]]; - - region1_val =3D *region1_val_ptr; - - memset(p_ctx, 0, ctx_size); - - *region1_val_ptr =3D region1_val; -} - /* Enable and configure context validation */ void qed_enable_context_validation(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt) --=20 2.49.0 From nobody Fri Dec 19 12:30:00 2025 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4B9914B07A; Mon, 14 Apr 2025 00:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744592002; cv=none; b=AcZrBqMXC30qq8GBXqRdbhP7o64ns3z3EJxT6S8zDZ8hxSQL2EP61CGjl2sruuR2l01AM7Y+w0p4puYED9i71x/OJrgpy3CADsV2wANiSnpEHAKuYnwl5qMzJ+TJ7RsfuGco0FlwaV8/AW9xbokSH1gBdARUy86/yseBtmUx0rw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744592002; c=relaxed/simple; bh=pr/yPxQHKZ5KHK6oqGF78AqmNyHBYY9Hga61WU9PcBA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XpM+BYVBNULXkqdoIe8I4jVP2pWwOb3bMRqLQMLqNdTk6LKgUiW6xBXIKQDUqClg17ALRitvvLO2iToDTGMSHmP8zI5z2iITPoMTCV1I1YVg5V5VEcn75RH/A12xg6Sq+U1LoYl/N3TJ+aA3DcQZNcEr9r5FyDJZ2yseuajuatY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=l4HqNPD0; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="l4HqNPD0" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=Ec9EXE3QNJBExnlVHquaSThfwEN1yWp7OFB+KWM4m2o=; b=l4HqNPD00UBCO+8d UC/rEyWfR4w3I8muAK1YVGSNVTRwdK5Ag5YIB32bDINvjUgo3iqM1k9bBNx7S/UKSPYR4s+hwFHrG 6OEIsz7NFWYWVxoLuVoJ7f9tojygf8hjxBdo9NU30ng6pvRd7N9VsNJwsqTJgV4geVCEiQVXvKf4S VhIrnFyHZzobcnEtF1UYtv87e4gMZ5r9Y62wa682J9ypBCu9m5sh5QfztjugzDpWTth2NZqnprjve ImlzsBEYlIp2h48xIFWZyYtmH9KMpITIgub/VwCHic78jIFO+xgDQdzHS1UpG0nLbhLNenSP/aCjS qcW+r4jUA/mlz73VWA==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u484X-00B6OC-07; Mon, 14 Apr 2025 00:53:13 +0000 From: linux@treblig.org To: manishc@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH net-next 2/5] qed: Remove unused qed_calc_*_ctx_validation functions Date: Mon, 14 Apr 2025 01:52:44 +0100 Message-ID: <20250414005247.341243-3-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250414005247.341243-1-linux@treblig.org> References: <20250414005247.341243-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" qed_calc_session_ctx_validation() and qed_calc_task_ctx_validation() were added as part of 2017's commit da09091732ae ("qed*: Utilize FW 8.33.1.0") but have remained unused. Remove them. This leaves; con_region_offsets[], task_region_offsets[], cdu_crc8_table and qed_calc_cdu_validation_byte() unused. Remove them. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 28 ----- .../ethernet/qlogic/qed/qed_init_fw_funcs.c | 100 ------------------ 2 files changed, 128 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_hsi.h b/drivers/net/ethern= et/qlogic/qed/qed_hsi.h index 3181fed1274e..10e355397cee 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_hsi.h +++ b/drivers/net/ethernet/qlogic/qed/qed_hsi.h @@ -2666,34 +2666,6 @@ void qed_gft_config(struct qed_hwfn *p_hwfn, void qed_enable_context_validation(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt); =20 -/** - * qed_calc_session_ctx_validation(): Calcualte validation byte for - * session context. - * - * @p_ctx_mem: Pointer to context memory. - * @ctx_size: Context size. - * @ctx_type: Context type. - * @cid: Context cid. - * - * Return: Void. - */ -void qed_calc_session_ctx_validation(void *p_ctx_mem, - u16 ctx_size, u8 ctx_type, u32 cid); - -/** - * qed_calc_task_ctx_validation(): Calcualte validation byte for task - * context. - * - * @p_ctx_mem: Pointer to context memory. - * @ctx_size: Context size. - * @ctx_type: Context type. - * @tid: Context tid. - * - * Return: Void. - */ -void qed_calc_task_ctx_validation(void *p_ctx_mem, - u16 ctx_size, u8 ctx_type, u32 tid); - #define NUM_STORMS 6 =20 /** diff --git a/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c b/drivers/= net/ethernet/qlogic/qed/qed_init_fw_funcs.c index 4b9128c08ad3..aa20bb8caa9a 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c +++ b/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c @@ -18,16 +18,6 @@ =20 #define CDU_VALIDATION_DEFAULT_CFG CDU_CONTEXT_VALIDATION_DEFAULT_CFG =20 -static u16 con_region_offsets[3][NUM_OF_CONNECTION_TYPES] =3D { - {400, 336, 352, 368, 304, 384, 416, 352}, /* region 3 offsets */ - {528, 496, 416, 512, 448, 512, 544, 480}, /* region 4 offsets */ - {608, 544, 496, 576, 576, 592, 624, 560} /* region 5 offsets */ -}; - -static u16 task_region_offsets[1][NUM_OF_CONNECTION_TYPES] =3D { - {240, 240, 112, 0, 0, 0, 0, 96} /* region 1 offsets */ -}; - /* General constants */ #define QM_PQ_MEM_4KB(pq_size) (pq_size ? DIV_ROUND_UP((pq_size + 1) * \ QM_PQ_ELEMENT_SIZE, \ @@ -1576,96 +1566,6 @@ void qed_gft_config(struct qed_hwfn *p_hwfn, qed_wr(p_hwfn, p_ptt, PRS_REG_SEARCH_GFT, 1); } =20 -DECLARE_CRC8_TABLE(cdu_crc8_table); - -/* Calculate and return CDU validation byte per connection type/region/cid= */ -static u8 qed_calc_cdu_validation_byte(u8 conn_type, u8 region, u32 cid) -{ - const u8 validation_cfg =3D CDU_VALIDATION_DEFAULT_CFG; - u8 crc, validation_byte =3D 0; - static u8 crc8_table_valid; /* automatically initialized to 0 */ - u32 validation_string =3D 0; - __be32 data_to_crc; - - if (!crc8_table_valid) { - crc8_populate_msb(cdu_crc8_table, 0x07); - crc8_table_valid =3D 1; - } - - /* The CRC is calculated on the String-to-compress: - * [31:8] =3D {CID[31:20],CID[11:0]} - * [7:4] =3D Region - * [3:0] =3D Type - */ - if ((validation_cfg >> CDU_CONTEXT_VALIDATION_CFG_USE_CID) & 1) - validation_string |=3D (cid & 0xFFF00000) | ((cid & 0xFFF) << 8); - - if ((validation_cfg >> CDU_CONTEXT_VALIDATION_CFG_USE_REGION) & 1) - validation_string |=3D ((region & 0xF) << 4); - - if ((validation_cfg >> CDU_CONTEXT_VALIDATION_CFG_USE_TYPE) & 1) - validation_string |=3D (conn_type & 0xF); - - /* Convert to big-endian and calculate CRC8 */ - data_to_crc =3D cpu_to_be32(validation_string); - crc =3D crc8(cdu_crc8_table, (u8 *)&data_to_crc, sizeof(data_to_crc), - CRC8_INIT_VALUE); - - /* The validation byte [7:0] is composed: - * for type A validation - * [7] =3D active configuration bit - * [6:0] =3D crc[6:0] - * - * for type B validation - * [7] =3D active configuration bit - * [6:3] =3D connection_type[3:0] - * [2:0] =3D crc[2:0] - */ - validation_byte |=3D - ((validation_cfg >> - CDU_CONTEXT_VALIDATION_CFG_USE_ACTIVE) & 1) << 7; - - if ((validation_cfg >> - CDU_CONTEXT_VALIDATION_CFG_VALIDATION_TYPE_SHIFT) & 1) - validation_byte |=3D ((conn_type & 0xF) << 3) | (crc & 0x7); - else - validation_byte |=3D crc & 0x7F; - - return validation_byte; -} - -/* Calcualte and set validation bytes for session context */ -void qed_calc_session_ctx_validation(void *p_ctx_mem, - u16 ctx_size, u8 ctx_type, u32 cid) -{ - u8 *x_val_ptr, *t_val_ptr, *u_val_ptr, *p_ctx; - - p_ctx =3D (u8 * const)p_ctx_mem; - x_val_ptr =3D &p_ctx[con_region_offsets[0][ctx_type]]; - t_val_ptr =3D &p_ctx[con_region_offsets[1][ctx_type]]; - u_val_ptr =3D &p_ctx[con_region_offsets[2][ctx_type]]; - - memset(p_ctx, 0, ctx_size); - - *x_val_ptr =3D qed_calc_cdu_validation_byte(ctx_type, 3, cid); - *t_val_ptr =3D qed_calc_cdu_validation_byte(ctx_type, 4, cid); - *u_val_ptr =3D qed_calc_cdu_validation_byte(ctx_type, 5, cid); -} - -/* Calcualte and set validation bytes for task context */ -void qed_calc_task_ctx_validation(void *p_ctx_mem, - u16 ctx_size, u8 ctx_type, u32 tid) -{ - u8 *p_ctx, *region1_val_ptr; - - p_ctx =3D (u8 * const)p_ctx_mem; - region1_val_ptr =3D &p_ctx[task_region_offsets[0][ctx_type]]; - - memset(p_ctx, 0, ctx_size); - - *region1_val_ptr =3D qed_calc_cdu_validation_byte(ctx_type, 1, tid); -} - /* Enable and configure context validation */ void qed_enable_context_validation(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt) --=20 2.49.0 From nobody Fri Dec 19 12:30:00 2025 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 120F743151; Mon, 14 Apr 2025 00:53:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744592009; cv=none; b=lknntkvpIRy2IndguZXRW9Sss4jIKd2zw+B5jSp0BjkhwHtII/+71RhANDNnWy33fRxY/80Wgwb/PBK6hHxgHWbQspaXMeW1LNPwKCeWWugOGukRPZp6bUnMorpz3+AL5FqksZoi/+/1dvevISYocdt2Hyf0OZEXhtFGXKmo014= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744592009; c=relaxed/simple; bh=aCj8JqX/4cv0NRJgoZbH5rGUNTJaBLRzzQHov4BFfn8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KsuuSin4/ugMhk2nnIqCxCLTB/MZ7Qqh5EguJBzSf1QVh7jrH8vaZMs4ArfwazyKAZ4xqD4EO8sLZWRFU1Cm37LlBDuczAAlX+aSo2dSLp6ST0UmaJVEf2kQ16GqPveq2rvjdXUcNE0UaWX28Li0o6PX44PxSOsUFrouBXCVOn4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=Uucgo6y0; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="Uucgo6y0" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=9ysz9tg4GbGM8KCco0QGfv3y00KLcOekLNUM3KT5ywc=; b=Uucgo6y0ISNqLZ+F wFc+VsaWuSGrtE+jXe5HSvMfsdZhAP4VQvBaEUSfjnTljlciFjGcDmD/jdev1+prUZe3GO9Qed4HA Db91CExcrABiegcWLsCN+EmskTK8qvrAv4Oi/0hC9nCfly5Mxl5gKybafhDVFpOCF555IMYZrjsdS zLYzGyuC511hsNJ4JXpQzsKirlIZcre85fbrvnNCosMheI67bvBiXUGdU7Ki+UUlwGIgkJEBPF0I0 1eCHyvO5f7qgOsCJzkQm9L+Lyj0cSn+Lua3Pum9KqL3/LBMhFNLr1W4QsqATqNn/d+GMACSBX3NGL If5Jfgz96LAGICLLwg==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u484e-00B6OC-07; Mon, 14 Apr 2025 00:53:20 +0000 From: linux@treblig.org To: manishc@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH net-next 3/5] qed: Remove unused qed_ptt_invalidate Date: Mon, 14 Apr 2025 01:52:45 +0100 Message-ID: <20250414005247.341243-4-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250414005247.341243-1-linux@treblig.org> References: <20250414005247.341243-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" qed_ptt_invalidate() was added in 2015 as part of commit fe56b9e6a8d9 ("qed: Add module with basic common support") but has remained unused. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/qlogic/qed/qed_hw.c | 11 ----------- drivers/net/ethernet/qlogic/qed/qed_hw.h | 9 --------- 2 files changed, 20 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_hw.c b/drivers/net/etherne= t/qlogic/qed/qed_hw.c index 9e5f0dbc8a07..9907973399dc 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_hw.c +++ b/drivers/net/ethernet/qlogic/qed/qed_hw.c @@ -69,17 +69,6 @@ int qed_ptt_pool_alloc(struct qed_hwfn *p_hwfn) return 0; } =20 -void qed_ptt_invalidate(struct qed_hwfn *p_hwfn) -{ - struct qed_ptt *p_ptt; - int i; - - for (i =3D 0; i < PXP_EXTERNAL_BAR_PF_WINDOW_NUM; i++) { - p_ptt =3D &p_hwfn->p_ptt_pool->ptts[i]; - p_ptt->pxp.offset =3D QED_BAR_INVALID_OFFSET; - } -} - void qed_ptt_pool_free(struct qed_hwfn *p_hwfn) { kfree(p_hwfn->p_ptt_pool); diff --git a/drivers/net/ethernet/qlogic/qed/qed_hw.h b/drivers/net/etherne= t/qlogic/qed/qed_hw.h index e535983ce21b..3c98f58a184f 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_hw.h +++ b/drivers/net/ethernet/qlogic/qed/qed_hw.h @@ -61,15 +61,6 @@ enum _dmae_cmd_crc_mask { */ void qed_gtt_init(struct qed_hwfn *p_hwfn); =20 -/** - * qed_ptt_invalidate(): Forces all ptt entries to be re-configured - * - * @p_hwfn: HW device data. - * - * Return: Void. - */ -void qed_ptt_invalidate(struct qed_hwfn *p_hwfn); - /** * qed_ptt_pool_alloc(): Allocate and initialize PTT pool. * --=20 2.49.0 From nobody Fri Dec 19 12:30:00 2025 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E17F43151; Mon, 14 Apr 2025 00:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744592014; cv=none; b=PpXTlRVybzfnd9sOu8OOTmFAgd5yvVPmMxHnbYvfAHonVSokwuZ9Eu7sQOd2ZhnRpx2MGeMobVDqduXQJ/S3Z7wL1yNsKbsRmo6dMFqxjzTg+K8i3Y0lfZRDPUoKZtd/yefZDIIKWKQWIsjod/t0iTq3QCZbPN5G19xVQKzYwvA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744592014; c=relaxed/simple; bh=0dJx6qQvfNfojFk9k0f2kBRjXKUDS5dJir18HdeA+f4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aHOEXaRpxzLl+JXFlDRPzYXB7IiRWRTBSGg+66nsjGpxs1+qCdsNbkAvVkBNH10Xg2UDXgR1BiJ2I3afUxUJke7yRDdXQdRpvGRrWsoduFCs3wAErmGaYHIXGkhTjUjBwDdAOTuS2pijYG4GLG4EvwFrk3nQa+ezzW+MlQo/3xk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=AwjNVKmR; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="AwjNVKmR" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=ujec2vqyglbO8Jqq7vIM4fTyJ4h9Dn2I/69u+5A4eWE=; b=AwjNVKmRkbYiphu2 boT0z7OygsP+cRUo7vYGKSIlMeoHm1iznE3GqiE6KIEAoV1CjCaf1osPYCbMVboQPZjqQF3iWlzob OiefUUB2zeTaH/gVQ5HB7lSpYdmucqJIVSMAg75hC/oUKgsUMypnuLyrY0355g3OjmtcwwVAAq+KY WXGGTbU+SYu2m6KEVl+z+91c3FRmNf/bt/1WPYy+ztxSEEh1nLQLBhlVvWbQzKzEug3Ct5jFA8fTA E7BNDCmL2JQQQ1JQCiswcKgX5v1pL4Q4kq+W35EJKWB6SfUCPTyCX0P6QTA6kG8Bxks3mp0gS4fb7 WeGEaT9Jo4uGginpoA==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u484k-00B6OC-0v; Mon, 14 Apr 2025 00:53:26 +0000 From: linux@treblig.org To: manishc@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH net-next 4/5] qed: Remove unused qed_print_mcp_trace_* Date: Mon, 14 Apr 2025 01:52:46 +0100 Message-ID: <20250414005247.341243-5-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250414005247.341243-1-linux@treblig.org> References: <20250414005247.341243-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" While most of the trace code is reachable by other routes (I think mostly via the qed_features_lookup[] array), there are a couple of unused wrappers. qed_print_mcp_trace_line() and qed_print_mcp_trace_results_cont() were added in 2018 as part of commit a3f723079df8 ("qed*: Utilize FW 8.37.7.0") but have remained unused. Remove them. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/qlogic/qed/qed_dbg_hsi.h | 31 ------------------- drivers/net/ethernet/qlogic/qed/qed_debug.c | 25 --------------- 2 files changed, 56 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_dbg_hsi.h b/drivers/net/et= hernet/qlogic/qed/qed_dbg_hsi.h index f6cd1b3efdfd..27e91d0d39f8 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_dbg_hsi.h +++ b/drivers/net/ethernet/qlogic/qed/qed_dbg_hsi.h @@ -1304,37 +1304,6 @@ enum dbg_status qed_print_mcp_trace_results(struct q= ed_hwfn *p_hwfn, u32 num_dumped_dwords, char *results_buf); =20 -/** - * qed_print_mcp_trace_results_cont(): Prints MCP Trace results, and - * keeps the MCP trace meta data allocated, to support continuous MCP Trace - * parsing. After the continuous parsing ends, mcp_trace_free_meta_data sh= ould - * be called to free the meta data. - * - * @p_hwfn: HW device data. - * @dump_buf: MVP trace dump buffer, starting from the header. - * @results_buf: Buffer for printing the mcp trace results. - * - * Return: Error if the parsing fails, ok otherwise. - */ -enum dbg_status qed_print_mcp_trace_results_cont(struct qed_hwfn *p_hwfn, - u32 *dump_buf, - char *results_buf); - -/** - * qed_print_mcp_trace_line(): Prints MCP Trace results for a single line - * - * @p_hwfn: HW device data. - * @dump_buf: MCP trace dump buffer, starting from the header. - * @num_dumped_bytes: Number of bytes that were dumped. - * @results_buf: Buffer for printing the mcp trace results. - * - * Return: Error if the parsing fails, ok otherwise. - */ -enum dbg_status qed_print_mcp_trace_line(struct qed_hwfn *p_hwfn, - u8 *dump_buf, - u32 num_dumped_bytes, - char *results_buf); - /** * qed_mcp_trace_free_meta_data(): Frees the MCP Trace meta data. * Should be called after continuous MCP Trace parsing. diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethe= rnet/qlogic/qed/qed_debug.c index 464a72afb758..9c3d3dd2f847 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c @@ -7614,31 +7614,6 @@ enum dbg_status qed_print_mcp_trace_results(struct q= ed_hwfn *p_hwfn, results_buf, &parsed_buf_size, true); } =20 -enum dbg_status qed_print_mcp_trace_results_cont(struct qed_hwfn *p_hwfn, - u32 *dump_buf, - char *results_buf) -{ - u32 parsed_buf_size; - - return qed_parse_mcp_trace_dump(p_hwfn, dump_buf, results_buf, - &parsed_buf_size, false); -} - -enum dbg_status qed_print_mcp_trace_line(struct qed_hwfn *p_hwfn, - u8 *dump_buf, - u32 num_dumped_bytes, - char *results_buf) -{ - u32 parsed_results_bytes; - - return qed_parse_mcp_trace_buf(p_hwfn, - dump_buf, - num_dumped_bytes, - 0, - num_dumped_bytes, - results_buf, &parsed_results_bytes); -} - /* Frees the specified MCP Trace meta data */ void qed_mcp_trace_free_meta_data(struct qed_hwfn *p_hwfn) { --=20 2.49.0 From nobody Fri Dec 19 12:30:00 2025 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7BA77483; Mon, 14 Apr 2025 00:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744592025; cv=none; b=rk6rLT7LP9tfM/P2EOHf/2M67ZYPH458iKjiy+8eJKrTNED+c70Bvu+0+2CnN2cfgYDBRMJUBZnhq0xHKuboLz2Xf4f3k7Dnzjnv/9aKsXU4LtWLnB7GrfbXuonn0/H+zgeTujjsPCWAj66XSVLMZ2em5v+yuyqEK9rxdVDv3xI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744592025; c=relaxed/simple; bh=5LgjGmbeAbyuA2oxz2CuckC0PL4cwfnn4oCcCSDAWbU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cfIDfjNyrcEbJCwBCo8zLNwQ6Jh8K9S4SB/0geRpZLO/ZXqSmnPtEihlfTtltoWSR/z0mpgNx0eeJVu1TbnCxukRD+Hc2Dvj0/FtvUF+2Qj1RtTFhqN+Tl2SfF4zG21YgYu0PHgtOVuLafoaP4qGO2EpkqmtON5vvWa1saN6cl4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=QaCb4klh; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="QaCb4klh" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=mszcztkCsSN4S8dihwOkYEm86zUy3fblRN6AQg5iZjc=; b=QaCb4klhndz5FV7G 1pIlPPczQCCeSw2dygHuHhKZwde2vrH+tflAJXmvQsO0NtgEuRuUreicjxdCR0AtzKmHtP0bd3FB/ aOI2S9Tq9AHAhulRVthZ0YkXgRw0p4nIt8/wGlS05cBWahJyWXDfvn3iedzuNlrCMxrYuhkwKUXBo dsjwF1C+VyvEuyLK+L22QCj0BG+EglMJEx9mpo4mGf4vafI9jLjYU5fD4yuty04UjhfhlB3QX1BMg GX3UcS98+WTAjJDMzSavQHk4+9CUgJmDE8JerjNJCevVcaLQaxqQd9V45h+rkeVl3GOODRLw/u+pH im4b45DzDWiRsgyCHw==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1u484u-00B6OC-2j; Mon, 14 Apr 2025 00:53:36 +0000 From: linux@treblig.org To: manishc@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH net-next 5/5] qed: Remove unused qed_db_recovery_dp Date: Mon, 14 Apr 2025 01:52:47 +0100 Message-ID: <20250414005247.341243-6-linux@treblig.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250414005247.341243-1-linux@treblig.org> References: <20250414005247.341243-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" qed_db_recovery_dp() was added in 2018 as part of commit 36907cd5cd72 ("qed: Add doorbell overflow recovery mechanism") but has remained unused. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/qlogic/qed/qed.h | 1 - drivers/net/ethernet/qlogic/qed/qed_dev.c | 19 ------------------- 2 files changed, 20 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed.h b/drivers/net/ethernet/q= logic/qed/qed.h index b7def3b54937..016b575861b9 100644 --- a/drivers/net/ethernet/qlogic/qed/qed.h +++ b/drivers/net/ethernet/qlogic/qed/qed.h @@ -939,7 +939,6 @@ u16 qed_get_cm_pq_idx_ofld_mtc(struct qed_hwfn *p_hwfn,= u8 tc); u16 qed_get_cm_pq_idx_llt_mtc(struct qed_hwfn *p_hwfn, u8 tc); =20 /* doorbell recovery mechanism */ -void qed_db_recovery_dp(struct qed_hwfn *p_hwfn); void qed_db_recovery_execute(struct qed_hwfn *p_hwfn); bool qed_edpm_enabled(struct qed_hwfn *p_hwfn); =20 diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethern= et/qlogic/qed/qed_dev.c index 86a93cac2647..9659ce5b0712 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_dev.c +++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c @@ -255,25 +255,6 @@ static void qed_db_recovery_teardown(struct qed_hwfn *= p_hwfn) p_hwfn->db_recovery_info.db_recovery_counter =3D 0; } =20 -/* Print the content of the doorbell recovery mechanism */ -void qed_db_recovery_dp(struct qed_hwfn *p_hwfn) -{ - struct qed_db_recovery_entry *db_entry =3D NULL; - - DP_NOTICE(p_hwfn, - "Displaying doorbell recovery database. Counter was %d\n", - p_hwfn->db_recovery_info.db_recovery_counter); - - /* Protect the list */ - spin_lock_bh(&p_hwfn->db_recovery_info.lock); - list_for_each_entry(db_entry, - &p_hwfn->db_recovery_info.list, list_entry) { - qed_db_recovery_dp_entry(p_hwfn, db_entry, "Printing"); - } - - spin_unlock_bh(&p_hwfn->db_recovery_info.lock); -} - /* Ring the doorbell of a single doorbell recovery entry */ static void qed_db_recovery_ring(struct qed_hwfn *p_hwfn, struct qed_db_recovery_entry *db_entry) --=20 2.49.0