From nobody Tue Dec 16 16:20:47 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F167F18A6BA for ; Sun, 13 Apr 2025 16:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744561988; cv=none; b=Ers2Y3YaE47FAWwuUaifUYacwa6evtyYi87JEjLD18701Dbxf4NizAhusTTPhy5+7pS6rVfRnDosIQcsfOx4TQe6guM23HKI57QkAtU1+U52jKNJMZPfkdE01iFY5P16voykfuxoiW4XN/MkkXR/eKPcd4zeQs5DSkughqPEmXw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744561988; c=relaxed/simple; bh=q2TV3za2YMsS1/tN81KHJ6sYde0HsrTUt/tA1uoSM5c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cenzhiyNLQ9mteEJJzB9HtrHCXNKAmt/ix+FfnRTQGKPe+3AImzTEqF3KGWlgPUH7F4SGvX//bB+HaP6k84EiRieXAOvqMrJ8MEIIfbOouB2wTeyKMBKze2MLKQNSVVP8WNI/tr446JcLUYHZd1Nyc5Q+h7Lk/pTyu2Hu8giz4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Dou7qtQP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Dou7qtQP" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53DFjZPW007978 for ; Sun, 13 Apr 2025 16:33:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +lOfrQC97itnkemnTsDOXPlft8YCdkPBpyMvVoCbScU=; b=Dou7qtQPuTJQmifs fyIyU+hJUAibYcI5ro0nRZw4LRrRd5NhwOV2Vcw0Zm8pw9MAYTEvzL0XdbLdam1S Qz/iP8TFggdcpNcDo4A+h5VXdvOITcsZsKjYgho8W+8lYs6NMzHuWBQJTGbTv4rl QgyNQLDV0acWRD72r6+/GvWiP6nHvvwwJvntm+MJz9V0vJnEFzkGlrSqG2cZk5UY HtJGfi7imiRLwlcsPl07Uai92ubEnfWVryN7aAgQy1+FHSE6o66jCT8A6kx+I7yG Lzfz70ITzjwawtK4OzaT8i4f9qQOFoKkpDjqR4c1oIxZou5kcoZRC1AKHkvM0SDz kuXVTw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45yhfct8px-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 13 Apr 2025 16:33:04 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c793d573b2so671556085a.1 for ; Sun, 13 Apr 2025 09:33:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744561983; x=1745166783; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+lOfrQC97itnkemnTsDOXPlft8YCdkPBpyMvVoCbScU=; b=bA+zH4S0ZXYtxOq4pnPUt1krGZh898o2ytBeaWRRVc0QBEefyGKjGxSUSLAuhPUA2y JqWFrU0NxI9QGXFOi//3VVW8gGffAVkO7NiOBhTi5VLFZa7ker1Cm4u8+fJHxh81uojA Oxq+71eSl702DOGC1HtuCqgmaVbsiUczEsxTpmpJrmUs9aMy9InNolWWpYKKKydQxsY7 N2OM8wHg1kPxJEtT0/dteUBS6z7f2aa4TrftefiljqQ9CN/lg1qWOuNCbxex2oq6i6Yc loBIMFpmW/8pfMQpRrK0BW3GNpuS+4f/kIOlgedDuiyRzFNueZdnVvfQjeYmBI2cJRHH tvWg== X-Forwarded-Encrypted: i=1; AJvYcCXY/GAi/cSoc8bJIngAMR+sJeNP8ItVrYuDpl1l1c9CQC0EJTZ3yVjW/jpBgkDKtUcxeD49llHGNnv6Y8g=@vger.kernel.org X-Gm-Message-State: AOJu0YwvBCM2tDplPayemMzZoUwBBOgtjTuuzCTD1Rb8lf7sgXLlzW44 rt5Mo108EXvSeCozSNsyDAEJ1HOGuZX6cyUPpYUQv558WHNYqWGAsEsZiLCClcjZ6xk2VAUVG9E XQyg51/p9mcq8pXEBFGh3bsDxOlq7XN8AGLmPpT/RPyNuJLw7W3rKEVfPT3mOfew= X-Gm-Gg: ASbGncuB3dcaXgfB5mroeMycHQ2LmvtnXh1R1Tj1eB9wh3jyUm9ryA1HNJEnueWtbdk Fh7q0j+IFvFQs7DR+reMjH5npDdNnuksuY1Ecfe5/OOvuUIMLqLxqKbnEjGZxdoCSWMfRASP7CA 5FZZFL2pqsCswOxwFQdPx7/azhjVYlsvN9oUfjRk4R/mKsLrdY45aDWDydRD0mujfPGOl5O6FfX 2c6sTDq8NjVsf1ZvlQ6zCA8k4ePgn/zg5wH+m3OZksubISCNQCx1W2ZW5FKpOy8BzdW2Yx0BY2s puBdakEd8Mir5ayGxFscVFg1Vc4mrBWYMAj7kW2M0/wzBhOC/vv/K04USvvWel46aNd31NGUZYK oiloKxGs2Wm+Kji62FTUyow5W X-Received: by 2002:a05:620a:24c1:b0:7c5:9788:1762 with SMTP id af79cd13be357-7c7af115a88mr1553671085a.45.1744561983367; Sun, 13 Apr 2025 09:33:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGoYxRLeLUP8wwMv47f5bvT970+5SGoyAUvtb70jI/1SHBFVXLdrQfg1QuWdHYnMb2Kidxnlg== X-Received: by 2002:a05:620a:24c1:b0:7c5:9788:1762 with SMTP id af79cd13be357-7c7af115a88mr1553667185a.45.1744561982876; Sun, 13 Apr 2025 09:33:02 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30f464e9812sm13345431fa.49.2025.04.13.09.33.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Apr 2025 09:33:01 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 13 Apr 2025 19:32:56 +0300 Subject: [PATCH 2/7] drm/msm: move helper calls to msm_kms.c Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250413-msm-gpu-split-v1-2-1132f4b616c7@oss.qualcomm.com> References: <20250413-msm-gpu-split-v1-0-1132f4b616c7@oss.qualcomm.com> In-Reply-To: <20250413-msm-gpu-split-v1-0-1132f4b616c7@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3462; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=q2TV3za2YMsS1/tN81KHJ6sYde0HsrTUt/tA1uoSM5c=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBn++c514hgycc6s0hl5iJqgNWSan8fYW0TqNOeE In8GBkJzWaJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ/vnOQAKCRCLPIo+Aiko 1R+sB/4xQ14DFSepN3Pc/dbRTGNkwhgiKH0xD3kf8gzdciIq/WiOkRHnv74I0gKlgWOluGtINBd kJZzB7nhyLthcwogNvGAFbuNK8c1pUImkP+KZbO4YTfNXvcsMq54NO6G9CDEKfaI2XjGMbcQmBd rDRSAjk2H+FTk599L8VZnHpYvggAOf8Gvj1qBIPYSNVXLkS5DG5m388FtcQjA3TTD3S74Oi+Dhs k2umJR9C8JNvDB/7m/QVEAReT5xjXU8rUjErbWERr+cFD/6Ot0oiQjjWMDi/f2AG4bbeFFVzJso dK/XWFH5cnmw9z4QIAcNhuSiuuuMZ5WTHWRwVzkANkKmr88V X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=CfUI5Krl c=1 sm=1 tr=0 ts=67fbe740 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=5yuRF9vT8A_X6ws8YtoA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: N5RjcFoR_LVk-Hgr08Fod6XC1SxvmGTP X-Proofpoint-ORIG-GUID: N5RjcFoR_LVk-Hgr08Fod6XC1SxvmGTP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-13_08,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 malwarescore=0 impostorscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 clxscore=1015 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504130127 Extract two more KMS-related codepieces to msm_kms.c, removing last pieces of KMS code from msm_drv.c. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_drv.c | 9 +++------ drivers/gpu/drm/msm/msm_kms.c | 20 ++++++++++++++++++++ drivers/gpu/drm/msm/msm_kms.h | 2 ++ 3 files changed, 25 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 02beb40eb9146941aa43862d07a6d82ae21c965e..b296d1315aa249638e073d08d43= e8d41a4354f3b 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -11,7 +11,6 @@ #include #include =20 -#include #include #include #include @@ -79,7 +78,7 @@ static int msm_drm_uninit(struct device *dev) if (ddev->registered) { drm_dev_unregister(ddev); if (priv->kms) - drm_atomic_helper_shutdown(ddev); + msm_drm_kms_unregister(dev); } =20 msm_gem_shrinker_cleanup(ddev); @@ -275,10 +274,8 @@ static int msm_drm_init(struct device *dev, const stru= ct drm_driver *drv) if (ret) goto err_msm_uninit; =20 - if (priv->kms_init) { - drm_kms_helper_poll_init(ddev); - drm_client_setup(ddev, NULL); - } + if (priv->kms_init) + msm_drm_kms_post_init(dev); =20 return 0; =20 diff --git a/drivers/gpu/drm/msm/msm_kms.c b/drivers/gpu/drm/msm/msm_kms.c index 821f0b9f968fc3d448e612bfae04639ceb770353..fdb22c41bdc1a772b45c6940dda= 787dd96879bc2 100644 --- a/drivers/gpu/drm/msm/msm_kms.c +++ b/drivers/gpu/drm/msm/msm_kms.c @@ -13,6 +13,7 @@ #include #include #include +#include =20 #include "disp/msm_disp_snapshot.h" #include "msm_drv.h" @@ -217,6 +218,15 @@ struct msm_gem_address_space *msm_kms_init_aspace(stru= ct drm_device *dev) return aspace; } =20 +void msm_drm_kms_unregister(struct device *dev) +{ + struct platform_device *pdev =3D to_platform_device(dev); + struct msm_drm_private *priv =3D platform_get_drvdata(pdev); + struct drm_device *ddev =3D priv->dev; + + drm_atomic_helper_shutdown(ddev); +} + void msm_drm_kms_uninit(struct device *dev) { struct platform_device *pdev =3D to_platform_device(dev); @@ -373,3 +383,13 @@ void msm_kms_shutdown(struct platform_device *pdev) if (drm && drm->registered && priv->kms) drm_atomic_helper_shutdown(drm); } + +void msm_drm_kms_post_init(struct device *dev) +{ + struct platform_device *pdev =3D to_platform_device(dev); + struct msm_drm_private *priv =3D platform_get_drvdata(pdev); + struct drm_device *ddev =3D priv->dev; + + drm_kms_helper_poll_init(ddev); + drm_client_setup(ddev, NULL); +} diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h index 43b58d052ee6aae0ce34d09c88e1e1c34f9c52ef..057b20367724a4ca60f2d60c038= 077dbcc1c7abc 100644 --- a/drivers/gpu/drm/msm/msm_kms.h +++ b/drivers/gpu/drm/msm/msm_kms.h @@ -192,6 +192,8 @@ static inline void msm_kms_destroy(struct msm_kms *kms) for_each_if (drm_crtc_mask(crtc) & (crtc_mask)) =20 int msm_drm_kms_init(struct device *dev, const struct drm_driver *drv); +void msm_drm_kms_post_init(struct device *dev); +void msm_drm_kms_unregister(struct device *dev); void msm_drm_kms_uninit(struct device *dev); =20 #endif /* __MSM_KMS_H__ */ --=20 2.39.5