From nobody Wed Dec 17 08:58:30 2025 Received: from mx0b-000eb902.pphosted.com (mx0b-000eb902.pphosted.com [205.220.177.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8026211713; Fri, 11 Apr 2025 15:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.212 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744383902; cv=fail; b=GL6lxVuxNg+QqAo4r6IbshNPa8h/Ef/Rw60CSVLKQFGXGM5gZyN/25vH482nmPz6CoUVVMqDaNaChNPfNd1Vsq3oZGUo+GMGvamuXHKVuXe6shCZQYZ1N1sxfsgLi/uYQaD7ZdsBzBgvWEwMRFSL9rYMcA6QQ7wrXFUUjfLiwYk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744383902; c=relaxed/simple; bh=8eOaF6qeuqRJ9Tp498jjpNMnDdUc7mdguYhhH8Cnbro=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tw/zUW061XZHvsVE/GzaUNyThhRLGs9pUWuovHM4CEEX8bAFellQfaQFHVfb+fuHGOBtUN3OUY/zXhjJ33IvxGLUd+J2MCcGPBLRGyTGEmBdwV0PgOGsRUo9fpixNmFV3Vhwm1fXKolA9zBCL/tt++z/KIJOV8NgIJ99n6VFJBM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com; spf=pass smtp.mailfrom=garmin.com; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=N4JKOr6a; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=BZULEIfp; arc=fail smtp.client-ip=205.220.177.212 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=garmin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="N4JKOr6a"; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="BZULEIfp" Received: from pps.filterd (m0220297.ppops.net [127.0.0.1]) by mx0a-000eb902.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53BAodYa020079; Fri, 11 Apr 2025 10:04:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps1; bh=6P3dc QHYLhvZ9lkTin4ugOR7tPvwhl1NEwiH2IpHxnU=; b=N4JKOr6aZBb8A7jdX+Irc XNtxEZ2iDliVe7KHeQRaHWOzg2lnGtii4yLKcWE55sB/JO4yImKAamPTlv9Hqs1m aHeoj6mNi44Yx9gua4j+MLTxcU6JeOr6UMXrgmZDZTqfkgzjebddvDVxnf13B3Lj 2rNBiziBkJ9yytrWUFx0Was4jBduWUb41mPxqhfSvkPY2izCKNlGGaXL5Z6vIC+e 4AssUsTmEKbgHSkVpH1P6aHH0NhIbNsNz180azxx789lPSeJH/iIC4gioJkiFV20 rx5C6oIRg2eCHcqEdzL422gAkog+FZoUGcfTRJXQnxyCXsown3LOO+C3nC3OdOkX w== Received: from cy4pr05cu001.outbound.protection.outlook.com (mail-westcentralusazlp17010002.outbound.protection.outlook.com [40.93.6.2]) by mx0a-000eb902.pphosted.com (PPS) with ESMTPS id 45y1nr0efq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Apr 2025 10:04:31 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CStxoY5z2yzUjxrFe+p4paJkOSHxixIO1h1kbEAhedR4XVcgqlnveaUD7D9OBRZJsLLKRWH4V2QcOFlZoqBZaakXDY1xtTY8H2SlxLCREzLvKmPUPcnIaL3E8peG7ekXxSfWELt913YdtFHLO57EthtqaO6hmBziNqCnBFA6ZIlCq8GuS/n9RhHuX0BGsJFZU+hIqcxs5WcqXxCoIjTWILLgUIxUo5FaPOdwFcSHluKLCCPW84ndXOPSrjc4tZF+mJaWYskwhD/Gbac6YShkkwy8lvXWUNAdk8qbwCuDUX2vGH+ZBIJqNRwMogYiKb5aj6OhuklP2AbEzyNsRGzjDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6P3dcQHYLhvZ9lkTin4ugOR7tPvwhl1NEwiH2IpHxnU=; b=SVvs/oYdyp5GVHKx5Fx6ZE0u/H9V5SASbOtMbhgazv3c89Hl2AV5KN6Y9t489KTBvL4Cw7vDhV4OxJu2tW9bNMSPl7NfBc2ustNGpVHQ3An8Zpub+Cpd8kPKryLWSOHP9kUfC5K2MBn5udiAtTpHzT9gpVdRoDogf9rsOX/B/SXJbVJZLVsRbo1wYMD3480kjZTjNWYmNzQ4h5yK6PfDuOeh9VVRorghYWwvwWWV5nZZKkdqPaOnXftwU0NtAO8QlS7YjAgQnrEfizpwdzz69/l0Y01YGUJi7xOxn/PuBLCBU5MA5eYbnh4zypee+uvJ9y78TMZn4MYLmkVnus2lJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 204.77.163.244) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=garmin.com; dmarc=pass (p=reject sp=quarantine pct=100) action=none header.from=garmin.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6P3dcQHYLhvZ9lkTin4ugOR7tPvwhl1NEwiH2IpHxnU=; b=BZULEIfp0UnmTwEERuKJ27XSVwWrntZjGHBh203fWgKqFN5kwmiitFFCGmsBytcDIuQRAfE62dIea9nioCQf4HEfoh78npx5A9XHJJLTavrjcsp7SkOet+51WXem2Mpcdgroak+8sv9iYPqm8AoLGn4Ib7mxKG1BPDoxdR2NJ+C/lSH9neszuzIvq+oNl0MeehpNJ4w2GWoZbp9/3YgJqTr+fGLKct8SyS11geAiBYiGmH3whePrMKk8qxyb6gPtG+mZxw+4soMSzkaTCPyALAaSNRzuFy4BPxLFHthsmN0zt2NP4a2CkHQE/fSodh9pUP9SweLUIgw/zUeqRWBfPA== Received: from MW4PR04CA0312.namprd04.prod.outlook.com (2603:10b6:303:82::17) by CH2PR04MB7110.namprd04.prod.outlook.com (2603:10b6:610:98::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Fri, 11 Apr 2025 15:04:29 +0000 Received: from CO1PEPF000066E8.namprd05.prod.outlook.com (2603:10b6:303:82:cafe::12) by MW4PR04CA0312.outlook.office365.com (2603:10b6:303:82::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8632.26 via Frontend Transport; Fri, 11 Apr 2025 15:04:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 204.77.163.244) smtp.mailfrom=garmin.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=garmin.com; Received-SPF: Pass (protection.outlook.com: domain of garmin.com designates 204.77.163.244 as permitted sender) receiver=protection.outlook.com; client-ip=204.77.163.244; helo=edgetransport.garmin.com; pr=C Received: from edgetransport.garmin.com (204.77.163.244) by CO1PEPF000066E8.mail.protection.outlook.com (10.167.249.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.13 via Frontend Transport; Fri, 11 Apr 2025 15:04:29 +0000 Received: from kc3wpa-exmb7.ad.garmin.com (10.65.32.87) by cv1wpa-edge1 (10.60.4.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 11 Apr 2025 10:04:19 -0500 Received: from cv1wpa-exmb3.ad.garmin.com (10.5.144.73) by kc3wpa-exmb7.ad.garmin.com (10.65.32.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Fri, 11 Apr 2025 10:04:20 -0500 Received: from cv1wpa-exmb1.ad.garmin.com (10.5.144.71) by cv1wpa-exmb3.ad.garmin.com (10.5.144.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 11 Apr 2025 10:04:19 -0500 Received: from CAR-4RCMR33.ad.garmin.com (10.5.209.17) by smtp.garmin.com (10.5.144.71) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Fri, 11 Apr 2025 10:04:19 -0500 From: Joseph Huang To: CC: Joseph Huang , Joseph Huang , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Roopa Prabhu , Nikolay Aleksandrov , Simon Horman , , Subject: [Patch v5 net-next 1/3] net: bridge: mcast: Add offload failed mdb flag Date: Fri, 11 Apr 2025 11:03:16 -0400 Message-ID: <20250411150323.1117797-2-Joseph.Huang@garmin.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250411150323.1117797-1-Joseph.Huang@garmin.com> References: <20250411150323.1117797-1-Joseph.Huang@garmin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066E8:EE_|CH2PR04MB7110:EE_ X-MS-Office365-Filtering-Correlation-Id: ed2f83e5-839f-45b2-8abe-08dd790a28c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?daaL+vIAWQxmyNh8id0feKg0O1xiarjge4VAS6ZiENIUGTVvb+81k5GOMV1O?= =?us-ascii?Q?eo/5PKPR2IqLAe71jskWfIkHP2T6J58ej0SBfIxSj1zzt/EljgyKmNU9oLfo?= =?us-ascii?Q?ngQhYwlIr0KQTt+aE4K4wPSzTGGpkaFqNRQHVcjfoNifCmgqqbFv+i9znGQb?= =?us-ascii?Q?/DulC6u4JxIfPHB7qYOeHy5MZF+yP3o67iZWn7efBOZH89veyLsAJm0E3Y6v?= =?us-ascii?Q?yWJaOBFPCuo0LqmOk0VfeKv46sS3Z0BSmdAuLTAq9E1gZP7tbWz8ufDooQ3p?= =?us-ascii?Q?Cfe0k98JLrNgaHw+hlqe+20yEkcjQkDJc3UpnW9Bd8TTRkuGxl0fCHyvce7U?= =?us-ascii?Q?61WGwCc6+2e5BzW0C1b7XBXIvrWtlqbdw3iqisCdd/MsnN3vlRx2thmSMx/6?= =?us-ascii?Q?QpaqhqiuD0bN3sWj340vU6JqjcNQdw/yGDCIfTh4qEo+xbxL7kiqeY8NF//H?= =?us-ascii?Q?jRI23OI/QGjbUrJTfquwEwSIIo/9WDJJ1pjiMeuqxWJcupRq0ihqescLhtwO?= =?us-ascii?Q?aq+ONcoAjj2bOQvOrCt5LfLBGCnJyPHjJAuyKjxWxhWUjksGrl2/kFvcYGGp?= =?us-ascii?Q?W2bImzMf/Ygb3FKC9dYkAxBOvUf2tqedes+dfh8ePdSPRSLV7hPoum8xK2U9?= =?us-ascii?Q?qisC/uTsZ9SoI0eY8EGCCHLlIqN9MLehrj3LAHBB+z12buEadTt5+aE+nBsJ?= =?us-ascii?Q?UbS1oa2zTkfeqdd//sYtTIyxw/PCXQipPwRkUVFbjj03wfuLc9v5qxaNeh1U?= =?us-ascii?Q?aGiGFBWziSY5HfO4uc/j4PSQWtzLR1x09TmzWOKDFrmnnDTMO5/FBcgQbRDJ?= =?us-ascii?Q?WHM2v2Rpl/2oGgQRIzypFIVoBCVhpbpTYp4VkI43jUPccvZgEeDDLOmpY1C3?= =?us-ascii?Q?BHVt4MYfzJqkGqDZLePIZE+pwTw0sK20neA88cQn+MPjTJdT/iFBCdfAjc0Q?= =?us-ascii?Q?mEs3j/XpRE3nZ6jNO8BzTN6YnE8EMTga+1hNmbwOz7AHGgy91NZy4UZAkEPf?= =?us-ascii?Q?tjUCCNn6/iB7mTRL+w5Q2rWlAfX080nlY7qNs88Wbodyf/F3bJQopsXAVDj0?= =?us-ascii?Q?FHlmRevOfMU7klbbpGAXL6IKFbDj6qXFa/HFPYpVhqRFxdMyV6sTa8ZbKGn7?= =?us-ascii?Q?J2bijXUj/0cUb/0J4k5Y2Nkg7GlrbbwMHegS0WA9iRuLjbuV+AwL1Z8g3k/B?= =?us-ascii?Q?2d88frpu8czd7+YVAr+gP+pGGJ++Rb8XVCT//cr1iSMMzyo5HdvPcm6ilrSm?= =?us-ascii?Q?l/IRdPgSDasWa+LfvR52ct1qUOZLVVw3z3lmEwlUKkyqwGcL1AmJXwgoM4wI?= =?us-ascii?Q?s58WWJokfYCNJzO/jfn+QLXLZk0MrL2iEbaXdP9pL3tSg528QzWigLKYGNdY?= =?us-ascii?Q?3PLLxHQvtS5JB3a+8iGHM7OJIRQc/FytjOx9loi0i6tSN6FnQJZVoNMGcbNo?= =?us-ascii?Q?/4tooc+9hNMMnt/n56bw3WuX9TPW9WI6cmuWaClBS54BN6ixFm27nEaTGRbt?= =?us-ascii?Q?iqRmUzU9QAF9Q7cLALugpBEL/xksZ1aIxja5?= X-Forefront-Antispam-Report: CIP:204.77.163.244;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:edgetransport.garmin.com;PTR:extedge.garmin.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014)(7416014);DIR:OUT;SFP:1102; X-OriginatorOrg: garmin.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2025 15:04:29.5937 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed2f83e5-839f-45b2-8abe-08dd790a28c8 X-MS-Exchange-CrossTenant-Id: 38d0d425-ba52-4c0a-a03e-2a65c8e82e2d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38d0d425-ba52-4c0a-a03e-2a65c8e82e2d;Ip=[204.77.163.244];Helo=[edgetransport.garmin.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066E8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR04MB7110 X-Proofpoint-GUID: cWxsosEibt09JpexgD0F-kCWSFx714Ha X-Authority-Analysis: v=2.4 cv=K7giHzWI c=1 sm=1 tr=0 ts=67f92f7f cx=c_pps a=joY0rRILPjs92yFVhGOM/w==:117 a=YA0UzX50FYCGjWi3QxTvkg==:17 a=h8e1o3o8w34MuCiiGQrqVE4VwXA=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=XR8D0OoHHMoA:10 a=qm69fr9Wx_0A:10 a=NbHB2C0EAAAA:8 a=5MufqnWcH8VpvfedoaMA:9 cc=ntf X-Proofpoint-ORIG-GUID: cWxsosEibt09JpexgD0F-kCWSFx714Ha X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-11_05,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxlogscore=991 adultscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc=notification route=outbound adjust=0 reason=mlx scancount=1 engine=8.21.0-2502280000 definitions=main-2504110095 Content-Type: text/plain; charset="utf-8" Add MDB_FLAGS_OFFLOAD_FAILED and MDB_PG_FLAGS_OFFLOAD_FAILED to indicate that an attempt to offload the MDB entry to switchdev has failed. Signed-off-by: Joseph Huang Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_bridge.h | 9 +++++---- net/bridge/br_mdb.c | 2 ++ net/bridge/br_private.h | 20 +++++++++++++++----- net/bridge/br_switchdev.c | 9 +++++---- 4 files changed, 27 insertions(+), 13 deletions(-) diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h index a5b743a2f775..f2a6de424f3f 100644 --- a/include/uapi/linux/if_bridge.h +++ b/include/uapi/linux/if_bridge.h @@ -699,10 +699,11 @@ struct br_mdb_entry { #define MDB_TEMPORARY 0 #define MDB_PERMANENT 1 __u8 state; -#define MDB_FLAGS_OFFLOAD (1 << 0) -#define MDB_FLAGS_FAST_LEAVE (1 << 1) -#define MDB_FLAGS_STAR_EXCL (1 << 2) -#define MDB_FLAGS_BLOCKED (1 << 3) +#define MDB_FLAGS_OFFLOAD (1 << 0) +#define MDB_FLAGS_FAST_LEAVE (1 << 1) +#define MDB_FLAGS_STAR_EXCL (1 << 2) +#define MDB_FLAGS_BLOCKED (1 << 3) +#define MDB_FLAGS_OFFLOAD_FAILED (1 << 4) __u8 flags; __u16 vid; struct { diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index 1a52a0bca086..0639691cd19b 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -144,6 +144,8 @@ static void __mdb_entry_fill_flags(struct br_mdb_entry = *e, unsigned char flags) e->flags |=3D MDB_FLAGS_STAR_EXCL; if (flags & MDB_PG_FLAGS_BLOCKED) e->flags |=3D MDB_FLAGS_BLOCKED; + if (flags & MDB_PG_FLAGS_OFFLOAD_FAILED) + e->flags |=3D MDB_FLAGS_OFFLOAD_FAILED; } =20 static void __mdb_entry_to_br_ip(struct br_mdb_entry *entry, struct br_ip = *ip, diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h index 1054b8a88edc..5f9d6075017e 100644 --- a/net/bridge/br_private.h +++ b/net/bridge/br_private.h @@ -306,11 +306,12 @@ struct net_bridge_fdb_flush_desc { u16 vlan_id; }; =20 -#define MDB_PG_FLAGS_PERMANENT BIT(0) -#define MDB_PG_FLAGS_OFFLOAD BIT(1) -#define MDB_PG_FLAGS_FAST_LEAVE BIT(2) -#define MDB_PG_FLAGS_STAR_EXCL BIT(3) -#define MDB_PG_FLAGS_BLOCKED BIT(4) +#define MDB_PG_FLAGS_PERMANENT BIT(0) +#define MDB_PG_FLAGS_OFFLOAD BIT(1) +#define MDB_PG_FLAGS_FAST_LEAVE BIT(2) +#define MDB_PG_FLAGS_STAR_EXCL BIT(3) +#define MDB_PG_FLAGS_BLOCKED BIT(4) +#define MDB_PG_FLAGS_OFFLOAD_FAILED BIT(5) =20 #define PG_SRC_ENT_LIMIT 32 =20 @@ -1343,6 +1344,15 @@ br_multicast_ctx_matches_vlan_snooping(const struct = net_bridge_mcast *brmctx) =20 return !!(vlan_snooping_enabled =3D=3D br_multicast_ctx_is_vlan(brmctx)); } + +static inline void +br_multicast_set_pg_offload_flags(struct net_bridge_port_group *p, + bool offloaded) +{ + p->flags &=3D ~(MDB_PG_FLAGS_OFFLOAD | MDB_PG_FLAGS_OFFLOAD_FAILED); + p->flags |=3D (offloaded ? MDB_PG_FLAGS_OFFLOAD : + MDB_PG_FLAGS_OFFLOAD_FAILED); +} #else static inline int br_multicast_rcv(struct net_bridge_mcast **brmctx, struct net_bridge_mcast_port **pmctx, diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c index 7b41ee8740cb..2d769ef3cb8a 100644 --- a/net/bridge/br_switchdev.c +++ b/net/bridge/br_switchdev.c @@ -505,8 +505,8 @@ static void br_switchdev_mdb_complete(struct net_device= *dev, int err, void *pri struct net_bridge_port *port =3D data->port; struct net_bridge *br =3D port->br; =20 - if (err) - goto err; + if (err =3D=3D -EOPNOTSUPP) + goto out_free; =20 spin_lock_bh(&br->multicast_lock); mp =3D br_mdb_ip_get(br, &data->ip); @@ -516,11 +516,12 @@ static void br_switchdev_mdb_complete(struct net_devi= ce *dev, int err, void *pri pp =3D &p->next) { if (p->key.port !=3D port) continue; - p->flags |=3D MDB_PG_FLAGS_OFFLOAD; + + br_multicast_set_pg_offload_flags(p, !err); } out: spin_unlock_bh(&br->multicast_lock); -err: +out_free: kfree(priv); } =20 --=20 2.49.0 From nobody Wed Dec 17 08:58:30 2025 Received: from mx0a-000eb902.pphosted.com (mx0a-000eb902.pphosted.com [205.220.165.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0BF91FBCBE; Fri, 11 Apr 2025 15:04:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.212 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744383894; cv=fail; b=jWidfYYYZcQ126EPjK0oWPHoi0P37dFaQ9f+9sBZkQ9OQaVsUGYjDOfs/smspNeVF0DDW7mm8xNiz914qEBlC1NCCsVbvgDNLW+cZC4FPMUL4Vs6WIHuIpjGs3Q/p901w4o6v4BJwWachiMhUv7oe1TZLoL6wu/42ShPJkNcbkk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744383894; c=relaxed/simple; bh=BVVBpa3x9tins8KUWLlm6NrkQieYoD0NB2b3BdTxNpA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e8cNg7U3FSWMCvL/nKmepej5EF+dufIjIhImIXfgZ1fHMdMJhogzRDqoHeAzE4cyscIQlH56AEASr8ZnmHXE/Hrfr5ZEUhynnOIUvg9nkwAmQL0SvlW1pNUJe6yW39EsXD9TVPpMHrp5fpqJIupQn0wsYBnK6BraFBnpmGFRixo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com; spf=pass smtp.mailfrom=garmin.com; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=AocUT/WW; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=ZgBVEZbf; arc=fail smtp.client-ip=205.220.165.212 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=garmin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="AocUT/WW"; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="ZgBVEZbf" Received: from pps.filterd (m0220296.ppops.net [127.0.0.1]) by mx0a-000eb902.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53BDrvrg032137; Fri, 11 Apr 2025 10:04:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps1; bh=LAPdk 4IKWbWVNG4e99TR1bO0ub4bMqDP88F7DcxUx/4=; b=AocUT/WWV+cc9q+Eoj1HI Brfe3MEtSDP9TMVDgIiZtWPeZQ1YXd3ZPK771/O/lx4Pz+NkDwLYQtkpRmqrdvPC MunL1RumLRCtSxt9DOxOirtwlH5z+HRk4CQX4ZrIpqU3BJkNT36lqQE0ei/KDSTd 3ayeH9lK+52/aJbwq+E7LoKAIVUW6BEM4EH1DeBEvV0mhfpGFI2O3KyYaI1jCVgU ctnFJweFgTssX2z3CIcFTy8WuRveIuli6TPUIWq5Q+VBtfnkGdjX7yZqaje55Vf4 5wcTTAp3q20WP52vQFvF5p+VE8KwV++zIffg+5awRPB4p83G3Ms952aNs1JL0lhl w== Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazlp17010003.outbound.protection.outlook.com [40.93.1.3]) by mx0a-000eb902.pphosted.com (PPS) with ESMTPS id 45y4bn047y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Apr 2025 10:04:38 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HaejWiL7ontO6LyscnhtyrEOKxRfB5VyJ0g4/w1GTjhomc6/3BLX7AUuHwv/ydgpdBwWrUUvxLFcwjLjgcorX7r17hTdrD9e+DYZ1X8CiZMPNiZnLYfRBcoSoXs+PjG49YQuAbbxaW+3a+7exvw8wrBgVGjMPRq5Y+MN4UCQalHNur5CrU+ohWh6esB92AGuDJxSjHhWRFmB3ggVqRRIPxhg3T+e+6AoT6IpXmIo22sptQMCwpO290rI98rdGOHFErWvFPMigl7x3mSI1cHxUQScHF2G5vzAO0ch/1Cm6AzB0fDewLE9e3Y4Pn/QWCrh1KzPRuwr12wg4WXFaZDZkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LAPdk4IKWbWVNG4e99TR1bO0ub4bMqDP88F7DcxUx/4=; b=JKZMs40HpHOMa4lqAHH93gM4HN+feoXMy7F6K4f43Gw9+beIPWFk8pGdOTS0recjE34kpSczxWMSkSdfmDnJbiELH/ZyV9f6HOSAz+sNZhtxv5wq7iq7rMrC1/njxTTiGG5eWOPQxLzag2MUVngD0aUvD4jZY6p2zOOhhgMuTnA8vU5CRfq72erB4jkrHhg0+ZQ1UDnOohNHqmQ70dQpTTtNqfSNNr6+0bl7yjrI3LuF1C7h8ID47ttf5Z2NYLK+SppPmtiuCbOzq782CcoLATTyu4ycXEW6jEAraQSLjca68BsDAMRAFYtPFKmmaMqjDuiqkOEpEyP3xI+YgMexEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 204.77.163.244) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=garmin.com; dmarc=pass (p=reject sp=quarantine pct=100) action=none header.from=garmin.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LAPdk4IKWbWVNG4e99TR1bO0ub4bMqDP88F7DcxUx/4=; b=ZgBVEZbfu6W238NGqDjIgxfo6njSpTT8V0gztu3hjacyGirgJWq1KPRNCV5f+mNY4GHj4OEkk17x+Nx5ANcubwQ/wOOiCA9XFk05Xvn7P0NLZ60HLixVDan9oM0NCHiX0I3XxMu9BOdop/ZpwENSWJlKwECsmMiMMe+yyVEzf+h/XIGcL6zFKptAtsQMI7UXA7bOzXF5mcVxCUkrUxZEfkr9pNwO1+e9M6gsz6gKBS8r6t2bQcy83CzNDm/JiQQtYgD6SFZWrolepulBhKemna7bJm7Bddk/S0L//dRqy9cAVfzHDSAnXccrgZO76Tk7oD6tm0ldmekd64pvSB3/Xw== Received: from MW4PR04CA0322.namprd04.prod.outlook.com (2603:10b6:303:82::27) by IA3PR04MB9111.namprd04.prod.outlook.com (2603:10b6:208:525::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Fri, 11 Apr 2025 15:04:36 +0000 Received: from CO1PEPF000066E8.namprd05.prod.outlook.com (2603:10b6:303:82:cafe::1f) by MW4PR04CA0322.outlook.office365.com (2603:10b6:303:82::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8632.26 via Frontend Transport; Fri, 11 Apr 2025 15:04:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 204.77.163.244) smtp.mailfrom=garmin.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=garmin.com; Received-SPF: Pass (protection.outlook.com: domain of garmin.com designates 204.77.163.244 as permitted sender) receiver=protection.outlook.com; client-ip=204.77.163.244; helo=edgetransport.garmin.com; pr=C Received: from edgetransport.garmin.com (204.77.163.244) by CO1PEPF000066E8.mail.protection.outlook.com (10.167.249.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.13 via Frontend Transport; Fri, 11 Apr 2025 15:04:36 +0000 Received: from OLAWPA-EXMB13.ad.garmin.com (10.5.144.17) by cv1wpa-edge1 (10.60.4.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 11 Apr 2025 10:04:25 -0500 Received: from cv1wpa-exmb3.ad.garmin.com (10.5.144.73) by OLAWPA-EXMB13.ad.garmin.com (10.5.144.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.34; Fri, 11 Apr 2025 10:04:26 -0500 Received: from cv1wpa-exmb1.ad.garmin.com (10.5.144.71) by cv1wpa-exmb3.ad.garmin.com (10.5.144.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 11 Apr 2025 10:04:26 -0500 Received: from CAR-4RCMR33.ad.garmin.com (10.5.209.17) by smtp.garmin.com (10.5.144.71) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Fri, 11 Apr 2025 10:04:25 -0500 From: Joseph Huang To: CC: Joseph Huang , Joseph Huang , Nikolay Aleksandrov , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" , Roopa Prabhu , Simon Horman , , Subject: [Patch v5 net-next 2/3] net: bridge: Add offload_fail_notification bopt Date: Fri, 11 Apr 2025 11:03:17 -0400 Message-ID: <20250411150323.1117797-3-Joseph.Huang@garmin.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250411150323.1117797-1-Joseph.Huang@garmin.com> References: <20250411150323.1117797-1-Joseph.Huang@garmin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066E8:EE_|IA3PR04MB9111:EE_ X-MS-Office365-Filtering-Correlation-Id: 19231ea7-b40e-49c1-4e6c-08dd790a2cd3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?oeQ5cw6Z5T9+scVRMgWgtzaQ+GK8ppUTSdp+bkJliY/kBS4VOzHcvZm4P9RM?= =?us-ascii?Q?WRmFPDJk+fA3RsW/95Ym0Q2Cd7IP/hnfoBye0d2UCN2GPwHuFyrybTSTlFUh?= =?us-ascii?Q?VL607/A4ZUOpMWnBjXp/U7WU55K0IlOP6BxklG4Ci/P9ic0eDscDKcyinNtD?= =?us-ascii?Q?/WtiJGhk/5gjvX30ocIG06epXVJt5Y0MYqkHTd02hMAGkD8f3dAEOCw8uR8s?= =?us-ascii?Q?fniLwJD8wJvCB+HtR5+X7rEp0xGzVPyK4tCBUzNCSM8pFK4uRS2rQbT57R9v?= =?us-ascii?Q?OfUX+2judcFCTv2KfpMqrrq2WemW6luRadpilK1l6+OtifrDgNFVs8mXjvvO?= =?us-ascii?Q?gIt4zX0mxXKkze0laRP9BbeVpEsCVkEsA7ov2VCF+Ni6/tFj3/dTeylPm8Fq?= =?us-ascii?Q?gqRHIjNAva6MWpwaRcgOnkcncXOGZ3wCZ8vQTAInRz3I1dMx+HL2Vi+GDSK6?= =?us-ascii?Q?9EQTZvsNmxWsmOHeAkDC75n/t31HhC50BEvz64XNRsaoL8m5WpzOCZyGcTTk?= =?us-ascii?Q?dT2Pjog81VGr3RARpgE+Bf4hzrpq2z5uzAtnpu0H3+CGsDQPNDmi5ZPEG0EZ?= =?us-ascii?Q?ALOF/uwgPQ1WAQS8KkhDmmalcSr4GweEpXJBzfNNXlqC7z8oKfXHTpkhbWK4?= =?us-ascii?Q?/AES40kU+9ce33tX9O6/+O+p6tWSFisw3cxqMMIiD0/tqK15ij1isHaoyxCe?= =?us-ascii?Q?mxo6Vjges+c2/ih2ZKeq4zTDMhl0JKUbOdUDHoVOvJ+8cjngNbD6Xyh17yH6?= =?us-ascii?Q?ba4+DIQX2oQd5HZb+e33mrLF6rEtSc0b3ZPuqI8a6zp50aPRl4ZC+6k8V7jF?= =?us-ascii?Q?QOcWZVaHE5bS3FU7K0Fbz0N+55bPouIzEl9y44JbJZfx23AIWQ9iTmBpK316?= =?us-ascii?Q?oMnRx+Y0xx4vBcxZD8pHrmUYAu3wiUzvTZswnkvjyGjmLZ5pw8Z7drlfkCoM?= =?us-ascii?Q?CZYNhiwv+X/azLMO98TthzRzB+9V/72Dms+C1Y8658FBB+6esG1V97qtIkR/?= =?us-ascii?Q?t5DSrR/sCIx7bjI1BqnbdR3itHHyihelHuC/7HmSAWK29rYTt5yUXnycaHML?= =?us-ascii?Q?Wf0xorNSchptuFw0eVycY1kT7inSY8YoqNmKznluAUOLfE/Khke2tKpvfdeE?= =?us-ascii?Q?CVnCayRTbAnCOa5pF8ggFUjw1aq6tHNpndvQh+QVNAQ39ImdiHAmNvZ67w/6?= =?us-ascii?Q?icoZuDMytbG0eXW+SPoyEJ59XQEd0iFkyKogR2+aeOvcu3U2CRDxpdgHJhag?= =?us-ascii?Q?Ypxld/4FsTk+YjAmrdli7OHdYPbtlSMlj4yITrbDvuTBuTMK2UcQYH9dHviy?= =?us-ascii?Q?Lp1n9x+MlcdR0FG7ThPFradA0VgYiLFwiQ5odSbQtRUzIQfIw/xBISJQ0uXQ?= =?us-ascii?Q?ZEJuXH9zJEt8lj+QCROOfhxXW2EOR2c/0FpCcevZ0QZUY37XVjMkbGNFXQta?= =?us-ascii?Q?NVxWhW5QH6KzLWoqYLhI6pokwPTi/i2TbBIhaWTE9HZmtyeJn1JyIyP7+O2c?= =?us-ascii?Q?bdfOQ0z0hDRlLjlDJg2nQXn0j5X4kpz8FTdj?= X-Forefront-Antispam-Report: CIP:204.77.163.244;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:edgetransport.garmin.com;PTR:extedge.garmin.com;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: garmin.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2025 15:04:36.3750 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19231ea7-b40e-49c1-4e6c-08dd790a2cd3 X-MS-Exchange-CrossTenant-Id: 38d0d425-ba52-4c0a-a03e-2a65c8e82e2d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38d0d425-ba52-4c0a-a03e-2a65c8e82e2d;Ip=[204.77.163.244];Helo=[edgetransport.garmin.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066E8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR04MB9111 X-Proofpoint-GUID: DAetZAIIjGld1DowAj5LaS7UwKctruga X-Proofpoint-ORIG-GUID: DAetZAIIjGld1DowAj5LaS7UwKctruga X-Authority-Analysis: v=2.4 cv=AuDu3P9P c=1 sm=1 tr=0 ts=67f92f86 cx=c_pps a=X0MiYUndXFlT04tAhnTHEA==:117 a=YA0UzX50FYCGjWi3QxTvkg==:17 a=h8e1o3o8w34MuCiiGQrqVE4VwXA=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=XR8D0OoHHMoA:10 a=qm69fr9Wx_0A:10 a=NbHB2C0EAAAA:8 a=vr0dFHqqAAAA:8 a=KDSQBeb26tfA5DPfL6IA:9 a=P4ufCv4SAa-DfooDzxyN:22 cc=ntf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-11_05,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 malwarescore=0 mlxlogscore=859 lowpriorityscore=0 adultscore=0 spamscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc=notification route=outbound adjust=0 reason=mlx scancount=1 engine=8.21.0-2502280000 definitions=main-2504110095 Content-Type: text/plain; charset="utf-8" Add BR_BOOLOPT_MDB_OFFLOAD_FAIL_NOTIFICATION bool option. Signed-off-by: Joseph Huang Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_bridge.h | 1 + net/bridge/br.c | 5 +++++ net/bridge/br_private.h | 1 + 3 files changed, 7 insertions(+) diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h index f2a6de424f3f..73876c0e2bba 100644 --- a/include/uapi/linux/if_bridge.h +++ b/include/uapi/linux/if_bridge.h @@ -831,6 +831,7 @@ enum br_boolopt_id { BR_BOOLOPT_NO_LL_LEARN, BR_BOOLOPT_MCAST_VLAN_SNOOPING, BR_BOOLOPT_MST_ENABLE, + BR_BOOLOPT_MDB_OFFLOAD_FAIL_NOTIFICATION, BR_BOOLOPT_MAX }; =20 diff --git a/net/bridge/br.c b/net/bridge/br.c index 183fcb362f9e..25dda554ca5b 100644 --- a/net/bridge/br.c +++ b/net/bridge/br.c @@ -284,6 +284,9 @@ int br_boolopt_toggle(struct net_bridge *br, enum br_bo= olopt_id opt, bool on, case BR_BOOLOPT_MST_ENABLE: err =3D br_mst_set_enabled(br, on, extack); break; + case BR_BOOLOPT_MDB_OFFLOAD_FAIL_NOTIFICATION: + br_opt_toggle(br, BROPT_MDB_OFFLOAD_FAIL_NOTIFICATION, on); + break; default: /* shouldn't be called with unsupported options */ WARN_ON(1); @@ -302,6 +305,8 @@ int br_boolopt_get(const struct net_bridge *br, enum br= _boolopt_id opt) return br_opt_get(br, BROPT_MCAST_VLAN_SNOOPING_ENABLED); case BR_BOOLOPT_MST_ENABLE: return br_opt_get(br, BROPT_MST_ENABLED); + case BR_BOOLOPT_MDB_OFFLOAD_FAIL_NOTIFICATION: + return br_opt_get(br, BROPT_MDB_OFFLOAD_FAIL_NOTIFICATION); default: /* shouldn't be called with unsupported options */ WARN_ON(1); diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h index 5f9d6075017e..02188b7ff8e6 100644 --- a/net/bridge/br_private.h +++ b/net/bridge/br_private.h @@ -484,6 +484,7 @@ enum net_bridge_opts { BROPT_VLAN_BRIDGE_BINDING, BROPT_MCAST_VLAN_SNOOPING_ENABLED, BROPT_MST_ENABLED, + BROPT_MDB_OFFLOAD_FAIL_NOTIFICATION, }; =20 struct net_bridge { --=20 2.49.0 From nobody Wed Dec 17 08:58:30 2025 Received: from mx0b-000eb902.pphosted.com (mx0b-000eb902.pphosted.com [205.220.177.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8306520C480; Fri, 11 Apr 2025 15:05:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.212 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744383905; cv=fail; b=gwYCM41OZv7A+zLjSS3r0cva4vjYgtTp6w8/5mJJPHQUgCDFBn+31JxcCV1dIb6f1GSJMfS3wEuZrHXkzGAhoC6qQ0EJc6QXQyyMeyBGnAHOvOvgdbdpIQPFTkD359dAE9UT6Co3QARO3qCXQJtiUfGgR8oy72OGqp4qmutPWwU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744383905; c=relaxed/simple; bh=D4y4BB8xV73hP8OwQgHrdUjSLomI1Ygyp8e7qNytYhU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GkWiAuuvjVWzZq0EWObRnmcKtgNCvqoIGdWcaZLvd4sBSJiIFiIh+CA4/uIulYzRajOHBYqsYLFLRzI8gOmO+Qz+PQ3pxNZeDLj+5OFfQoJHl3psp+jkWWltodNCAq6p5Fu0JkD4xtPYFzVjTGF007rbJfSjG1ZtGYLQxAxX108= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com; spf=pass smtp.mailfrom=garmin.com; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=rUzv5Z+j; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b=HT+/EKu4; arc=fail smtp.client-ip=205.220.177.212 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=garmin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=garmin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="rUzv5Z+j"; dkim=pass (2048-bit key) header.d=garmin.com header.i=@garmin.com header.b="HT+/EKu4" Received: from pps.filterd (m0220297.ppops.net [127.0.0.1]) by mx0a-000eb902.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53BAq3SS023499; Fri, 11 Apr 2025 10:04:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps1; bh=Lb2Tw M/gevKvyXsj1jQgH14jD27m9yYXBg8xFk/nR+E=; b=rUzv5Z+jECVgxR5O1mSud gT8CcbSg6RxV8YjtZUOJVFImSLGR28kILpq+RK/p6wilx+e122XhJAbu06Nm0L2K pwG5M0AKnQIWUAdn6LbypNVytJWWdueITeZ/j5NAeLtFqBUgXpl8L7jy2oYVSc2F 8jaByOVerjPg03V5cj/1zhTV68nonzh+eXBquMClznkt5O4gwo6oz/ikw3dje4Gj L/53CQY+DYUECm4ptcXtkDBrTBI2zHILlQDTht1WwgEaD49LImtyXpezKuLPjV32 pNgqYQ7plcUI3r+klZTaPuVA+SHl4hi33bzrKqNJT41ZZF4ZlKqAAcafMuR/tvnq w== Received: from sn4pr2101cu001.outbound.protection.outlook.com (mail-southcentralusazlp17012012.outbound.protection.outlook.com [40.93.14.12]) by mx0a-000eb902.pphosted.com (PPS) with ESMTPS id 45y1nr0egv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Apr 2025 10:04:48 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Dc8ZPcX/HnFfpyanOG0sShf+Y1hVLzMdR4NJMcMH/29a5Hn9EXyoEIZW9TlYohFZUSP3iRAJYpTJQx5AM3EeU5wSTD2MTmLQWH8vGAAmMTNmOQJAA6wl1oB4kte/SPHuG0mmVAYrragCFeXrbQNe3DqmfHcFG4SRti8xzaZm5bk2Y5i8sXsYCfwSiuAUo+f4Pm1BP7u83nUFnlS6Oh6Kq6j7ukpnPS7wu4cSOJZ1Q6sKIuthl04l0XKx/iLksW+pDFiuSTLbYmNLIp8NbDF2Ih8oy9hKeBaB6B5L1Gpo5Rtt+CIAawWoIPPtbWb4x5WxjO0lY07EdVW/+WOK3CKE3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lb2TwM/gevKvyXsj1jQgH14jD27m9yYXBg8xFk/nR+E=; b=x0EXkw7W0xWZmTXG4vBtgA3hOQgRSYMEPzQIu0+tNVzeo1vc59kxYAeAqx+/n8Ysbe4ogs2ibgy85+O/YsDlkzQYSRBAaOLKWRH9AkipqgUXCHOa1ZHMdGtlh2BmPfttYjFdXx7fVaCCJF0yIBW5SPA0teYchwAi5Bvnr0hFjz62nmfD/HeeUxk6N9e2u77lILfbE7oWnbleEHcMRn7kixLSttZHXH3aL9FowGtaVvyqvZIpwYBHEKKWK7VS/RhI1N8Sgm5RInyvUmsYBlZw/G5zWpkc1Yt8kiaqZ/GKkjVek57UjXUNEEyO6RXcrIeUbOElZAyhiSDPMBVaXVgoKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 204.77.163.244) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=garmin.com; dmarc=pass (p=reject sp=quarantine pct=100) action=none header.from=garmin.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garmin.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lb2TwM/gevKvyXsj1jQgH14jD27m9yYXBg8xFk/nR+E=; b=HT+/EKu4e7fGzrQRiMUEAg17gylWJIJ1G/6MaYZBbHfprd5kHGsMxJEg/l9nnPs6mBJE2fEUrf7Eo6DJI15hek7hUg052ejf6/W5UKrPB9i1LMsBMuEFl8CfSKKinBoER+vLYJ3WDuJCB8MAEyn2bbCCoew8/uveGdJLWyoXM0zY7spUzhc8Vrb/Hse3hyfVr4wDFE3aBX90EKbC1otxyDzJTt3QnOxnlANAyL+qdm1Xc3ZjGhNmf+eTejVe6kPYJ60fbGDsa9Jrajp5Zzjt/dBEgesOzQsbkYDYPePS+AjvT+dYhU6y2iUQq2MQ7aIFHVUK+3F3tsPwTFKL57R7hw== Received: from SJ0PR03CA0148.namprd03.prod.outlook.com (2603:10b6:a03:33c::33) by CYYPR04MB9030.namprd04.prod.outlook.com (2603:10b6:930:bd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Fri, 11 Apr 2025 15:04:45 +0000 Received: from SJ5PEPF00000209.namprd05.prod.outlook.com (2603:10b6:a03:33c:cafe::fc) by SJ0PR03CA0148.outlook.office365.com (2603:10b6:a03:33c::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8632.26 via Frontend Transport; Fri, 11 Apr 2025 15:04:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 204.77.163.244) smtp.mailfrom=garmin.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=garmin.com; Received-SPF: Pass (protection.outlook.com: domain of garmin.com designates 204.77.163.244 as permitted sender) receiver=protection.outlook.com; client-ip=204.77.163.244; helo=edgetransport.garmin.com; pr=C Received: from edgetransport.garmin.com (204.77.163.244) by SJ5PEPF00000209.mail.protection.outlook.com (10.167.244.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.13 via Frontend Transport; Fri, 11 Apr 2025 15:04:44 +0000 Received: from kc3wpa-exmb7.ad.garmin.com (10.65.32.87) by cv1wpa-edge1 (10.60.4.254) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 11 Apr 2025 10:04:29 -0500 Received: from cv1wpa-exmb3.ad.garmin.com (10.5.144.73) by kc3wpa-exmb7.ad.garmin.com (10.65.32.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Fri, 11 Apr 2025 10:04:30 -0500 Received: from cv1wpa-exmb1.ad.garmin.com (10.5.144.71) by cv1wpa-exmb3.ad.garmin.com (10.5.144.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 11 Apr 2025 10:04:29 -0500 Received: from CAR-4RCMR33.ad.garmin.com (10.5.209.17) by smtp.garmin.com (10.5.144.71) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Fri, 11 Apr 2025 10:04:29 -0500 From: Joseph Huang To: CC: Joseph Huang , Joseph Huang , Nikolay Aleksandrov , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" , Roopa Prabhu , Simon Horman , , Subject: [Patch v5 net-next 3/3] net: bridge: mcast: Notify on mdb offload failure Date: Fri, 11 Apr 2025 11:03:18 -0400 Message-ID: <20250411150323.1117797-4-Joseph.Huang@garmin.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250411150323.1117797-1-Joseph.Huang@garmin.com> References: <20250411150323.1117797-1-Joseph.Huang@garmin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000209:EE_|CYYPR04MB9030:EE_ X-MS-Office365-Filtering-Correlation-Id: 21bde208-49b9-4342-8581-08dd790a31f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?pGibd1Vh0AE2im/wpO3fY7AazbvrA8iE0ngewhT6WEUrUCktlv3pYauDY4/F?= =?us-ascii?Q?1aIGydSU7n9jpy8f7RqrY65lmy093kB15+bK1JOdBCEa/RBLPRXNI8UmtTHN?= =?us-ascii?Q?hQZxSDEe4wP9uO/npURd0HtEQ5MOf8fEQcJyjud106YtIVMoXQZGhUs/srwd?= =?us-ascii?Q?4fa1sZwb4K3emn/oLoOl0JHuUfNqef4PBRtOd6lZubROZj0iP1+1/GfLniCh?= =?us-ascii?Q?RtMAgH3RFNZP/tRn+lCJ9zqpZ7iK7trTzzdnpsDeukqqwuZBcRQfySMEMx2S?= =?us-ascii?Q?/Uypu8KAJvFt1DCaBwWA5XRzJI3ac1zgcHfNdwLhM5PaK6Lq+Aj33iL/IX3l?= =?us-ascii?Q?F5LFPeyKhVbKMKT7F+aIM/ku0Yrtv8fVas/E3pbzPcpUJk3EcjzJiVGkf+wR?= =?us-ascii?Q?vFJCC38vw8jX4UKL5Yjl4ffho2DTwHWyVgbimg5GA8069NzU/3OLMKOty/or?= =?us-ascii?Q?U/CxaDWedfYNQIazIuL+cd+uEQqS3DTjyFAKzWXCs4FeGsdD5oWT7liVFOvR?= =?us-ascii?Q?RMfRfHYFiOkyNWMZRsdI8vh88Z4dDvdAQDPUXI568Z8Cx89OINlvYXxWREGT?= =?us-ascii?Q?Jy0vcXYLRCQzRwaPPUj24fNH49/6EDRShWhiQQSo4jyOFoUYy4N6syZqWoEn?= =?us-ascii?Q?3f7/b6y/Gxp4GQmpMGUBNFo3CCkiqmVAjCKhhb1CU3tv4r5Fz0YnQQz/0bxX?= =?us-ascii?Q?f9H305bSx/UaZggOYJT2jagP9TYy7/zghOMGOacXsTNjr7duy94zgNDJdt4E?= =?us-ascii?Q?d5IM1hkCobiaaLgrl+lFV8kBv0sAklpK/fiZOlfwBiUND6QYtSsxdbILwv4X?= =?us-ascii?Q?fG4pwSXhXuHgy99RmDjuq7RsAIkqueCNpOyw68fNAvu5IxzkuePmV9gDoVsn?= =?us-ascii?Q?jeep4a6WfJzOFOXLXK75psLvwDcPOPkPdJN2hCUO/5DaLy+a1oIJ+KJmoSSl?= =?us-ascii?Q?PZ2vP5W/5GwK+h48UXhlVYRcNPv8+UImeOOXAwXRIDSDk1omQ8h/pI1KKzsi?= =?us-ascii?Q?HaYLokDBRoOvI2wuYbifq545Ge7vYwpiktYDEUw4eEp2d2e5D+eDgmRtAf2e?= =?us-ascii?Q?x//ocljKmkepvk9Iam06aa+2L43ruS4STo8XxQt0SInLumMxk46sfFZKjgK3?= =?us-ascii?Q?v3TGDc1xMWDSWA2CjRS4aAwWkeZY5eNaOU16CpYnKAvp8/GNbJKqFoWxV0sa?= =?us-ascii?Q?lcDar5Fp11dre+JDW8fwkwIhQh62zKnWaD5plTZLgbi+tMBqEpUkJFnDGE+X?= =?us-ascii?Q?SfY/zt4cpC2XiYqpDK5/Vlq3htUYzBg472YUFbmn8hX5sZV5idhYfdlvoMtd?= =?us-ascii?Q?j3eaSvlW85Cv1iX7Ombruj7rFu0QOHVeeV9mz74txlxWbmIU7rN+eIxsM3kw?= =?us-ascii?Q?W8naTztS4vJZgx7QH6xbFYoYjRIiF+hu38PZ+CCYSEZoYf4IJ79SwJnwRMgV?= =?us-ascii?Q?KpDwj63zabjLrmZuZGj7SR7y/PCpcu9UonnEvqDhep1Wl9R3M8V3soIKAFVb?= =?us-ascii?Q?IFUShgGtXGnvZ4pggEotu9L3e4ItgbGqZ1jE?= X-Forefront-Antispam-Report: CIP:204.77.163.244;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:edgetransport.garmin.com;PTR:extedge.garmin.com;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(376014)(7416014)(1800799024);DIR:OUT;SFP:1102; X-OriginatorOrg: garmin.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2025 15:04:44.9814 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21bde208-49b9-4342-8581-08dd790a31f4 X-MS-Exchange-CrossTenant-Id: 38d0d425-ba52-4c0a-a03e-2a65c8e82e2d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38d0d425-ba52-4c0a-a03e-2a65c8e82e2d;Ip=[204.77.163.244];Helo=[edgetransport.garmin.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000209.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR04MB9030 X-Proofpoint-GUID: HRIvPzKVfDFfbmSfw6gq8nPaF4CFYq8X X-Authority-Analysis: v=2.4 cv=K7giHzWI c=1 sm=1 tr=0 ts=67f92f90 cx=c_pps a=rJOuE113HAlAKDwVaFkQAw==:117 a=YA0UzX50FYCGjWi3QxTvkg==:17 a=h8e1o3o8w34MuCiiGQrqVE4VwXA=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=XR8D0OoHHMoA:10 a=qm69fr9Wx_0A:10 a=NbHB2C0EAAAA:8 a=vr0dFHqqAAAA:8 a=LF5D9LMcPqa3_lnOtKMA:9 a=P4ufCv4SAa-DfooDzxyN:22 cc=ntf X-Proofpoint-ORIG-GUID: HRIvPzKVfDFfbmSfw6gq8nPaF4CFYq8X X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-11_05,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc=notification route=outbound adjust=0 reason=mlx scancount=1 engine=8.21.0-2502280000 definitions=main-2504110095 Content-Type: text/plain; charset="utf-8" Notify user space on mdb offload failure if mdb_offload_fail_notification is enabled. Signed-off-by: Joseph Huang Acked-by: Nikolay Aleksandrov --- net/bridge/br_mdb.c | 26 +++++++++++++++++++++----- net/bridge/br_private.h | 9 +++++++++ net/bridge/br_switchdev.c | 4 ++++ 3 files changed, 34 insertions(+), 5 deletions(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index 0639691cd19b..5f53f387d251 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -519,16 +519,17 @@ static size_t rtnl_mdb_nlmsg_size(const struct net_br= idge_port_group *pg) rtnl_mdb_nlmsg_pg_size(pg); } =20 -void br_mdb_notify(struct net_device *dev, - struct net_bridge_mdb_entry *mp, - struct net_bridge_port_group *pg, - int type) +static void __br_mdb_notify(struct net_device *dev, + struct net_bridge_mdb_entry *mp, + struct net_bridge_port_group *pg, + int type, bool notify_switchdev) { struct net *net =3D dev_net(dev); struct sk_buff *skb; int err =3D -ENOBUFS; =20 - br_switchdev_mdb_notify(dev, mp, pg, type); + if (notify_switchdev) + br_switchdev_mdb_notify(dev, mp, pg, type); =20 skb =3D nlmsg_new(rtnl_mdb_nlmsg_size(pg), GFP_ATOMIC); if (!skb) @@ -546,6 +547,21 @@ void br_mdb_notify(struct net_device *dev, rtnl_set_sk_err(net, RTNLGRP_MDB, err); } =20 +void br_mdb_notify(struct net_device *dev, + struct net_bridge_mdb_entry *mp, + struct net_bridge_port_group *pg, + int type) +{ + __br_mdb_notify(dev, mp, pg, type, true); +} + +void br_mdb_flag_change_notify(struct net_device *dev, + struct net_bridge_mdb_entry *mp, + struct net_bridge_port_group *pg) +{ + __br_mdb_notify(dev, mp, pg, RTM_NEWMDB, false); +} + static int nlmsg_populate_rtr_fill(struct sk_buff *skb, struct net_device *dev, int ifindex, u16 vid, u32 pid, diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h index 02188b7ff8e6..fc43ccc06ccb 100644 --- a/net/bridge/br_private.h +++ b/net/bridge/br_private.h @@ -1005,6 +1005,8 @@ int br_mdb_hash_init(struct net_bridge *br); void br_mdb_hash_fini(struct net_bridge *br); void br_mdb_notify(struct net_device *dev, struct net_bridge_mdb_entry *mp, struct net_bridge_port_group *pg, int type); +void br_mdb_flag_change_notify(struct net_device *dev, struct net_bridge_m= db_entry *mp, + struct net_bridge_port_group *pg); void br_rtr_notify(struct net_device *dev, struct net_bridge_mcast_port *p= mctx, int type); void br_multicast_del_pg(struct net_bridge_mdb_entry *mp, @@ -1354,6 +1356,13 @@ br_multicast_set_pg_offload_flags(struct net_bridge_= port_group *p, p->flags |=3D (offloaded ? MDB_PG_FLAGS_OFFLOAD : MDB_PG_FLAGS_OFFLOAD_FAILED); } + +static inline bool +br_mdb_should_notify(const struct net_bridge *br, u8 changed_flags) +{ + return br_opt_get(br, BROPT_MDB_OFFLOAD_FAIL_NOTIFICATION) && + (changed_flags & MDB_PG_FLAGS_OFFLOAD_FAILED); +} #else static inline int br_multicast_rcv(struct net_bridge_mcast **brmctx, struct net_bridge_mcast_port **pmctx, diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c index 2d769ef3cb8a..95d7355a0407 100644 --- a/net/bridge/br_switchdev.c +++ b/net/bridge/br_switchdev.c @@ -504,6 +504,7 @@ static void br_switchdev_mdb_complete(struct net_device= *dev, int err, void *pri struct net_bridge_mdb_entry *mp; struct net_bridge_port *port =3D data->port; struct net_bridge *br =3D port->br; + u8 old_flags; =20 if (err =3D=3D -EOPNOTSUPP) goto out_free; @@ -517,7 +518,10 @@ static void br_switchdev_mdb_complete(struct net_devic= e *dev, int err, void *pri if (p->key.port !=3D port) continue; =20 + old_flags =3D p->flags; br_multicast_set_pg_offload_flags(p, !err); + if (br_mdb_should_notify(br, old_flags ^ p->flags)) + br_mdb_flag_change_notify(br->dev, mp, p); } out: spin_unlock_bh(&br->multicast_lock); --=20 2.49.0