From nobody Tue Feb 10 04:18:43 2026 Received: from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 524D22367C3 for ; Fri, 11 Apr 2025 13:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.86.78 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744376796; cv=none; b=d7Vg3YDtDBIjzHWLRNuMGZ7pJSn6ljieSQh9SlxG7iC3fNIsWNANph0WxkSFejyZzKYf6kBD9KhcJIh0mRuK5dcHLebedXrPy3ig5/qfwKaU7NYYqRmmaz37E5TN0wnmKVhdzAupOHoOeQyCxCRSWlKUZs78kr43wrPjS/y6RNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744376796; c=relaxed/simple; bh=pI7lWvnf5Gc0raspsQhtAK6TAnRr7EXkekDltWsfqV0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=NfdHxam42xJq8tzTX/wo1ojYVkscZiFtV2hCZqYuG7xdVjpgIO2w4o0u80p0OdYKTKjtJXSxM6xLv6CFOU1djr52u81D5VnAAWwizw2zm3Q1HpryRy36UVSQcxhG3KosjC+LLd3oe8vATUzl34d0rqPq9VFwCBJsCEXmvmh9znA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b=leIo0Cl/; arc=none smtp.client-ip=173.37.86.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b="leIo0Cl/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=2102; q=dns/txt; s=iport01; t=1744376794; x=1745586394; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=NNevI5c7bUcc5if4XkYhDFr7yVELYRPdbyKO8NXMmWo=; b=leIo0Cl/QLf+5O3oVNxwbSYwqBNzbMztDhUTTcyfGF/g2LyWVylBf6e7 Q9gBNnIqqe8RsDxKHybVjvehvV+cHXzifEZt8FKvVpYI0qVfdqpneIAKp 8HXwKZ0hoW7Z/syRCQAZspX9cFkd0HV/BXC0QsrandY9+MwppoIF5LOiM 9O+2WXsZTTOXfV4YjQoMVtR4gCeNMsL7pghNMfFFXb/J/+kuXe/at7lbR P8+eo3AJDFKRL4+KmMppXOrZTIbVjQo9qvyIBddUOedhmf9jjl5XayNO7 bouzIUarXo/y5ArZnzaEwetFLrBXUQrtStB5upb8WduQpOqeqvqktkHUe w==; X-CSE-ConnectionGUID: 5FVlY0jCQOi3+Wfc0q5DxA== X-CSE-MsgGUID: 0SLNDZzjTnWF6tpAibQDIg== X-IPAS-Result: =?us-ascii?q?A0AJAACFEvln/5H/Ja1aGQEBAQEBAQEBAQEBAQEBAQEBA?= =?us-ascii?q?RIBAQEBAQEBAQEBAQGCAQIBAQEBAQsBgkqBT0NIojySIIElA1YPAQEBD0QEA?= =?us-ascii?q?QGFB4sqAiY2Bw4BAgQBAQEBAwIDAQEBAQEBAQEBAQELAQEFAQEBAgEHBYEOE?= =?us-ascii?q?4YIhl0rCwFGKWMxARKDAoJlA69pgXkzgQHeNIFugUgBjUyFZycbgUlEglCCL?= =?us-ascii?q?YsHBINEg0oYLYIgmmpIgSEDWSwBVRMNCgsHBYE5MwMgCgsMCxIcFQIUMg8cN?= =?us-ascii?q?R2BfINygjBPdAKBQYIRcIEUiRmEVy1PhDkDQUADCxgNSBEsNwYOGwY+bgeXE?= =?us-ascii?q?YQNB4EOfMhDhCWhSBozqlYBkyaFWCKkKYRogW4GL4FZcBWDIlIZD45Zy3NGM?= =?us-ascii?q?jwCBwsBAQMJkWUBAQ?= IronPort-Data: A9a23:D+UfJKu3vgx7nhhc4V1QP/b1WOfnVF9fMUV32f8akzHdYApBsoF/q tZmKWiEb/vYNjbzfowlbYy1ox4P65WAn99nGwQ9rCxgRSNGgMeUXt7xwmUckM+xwmwvaGo9s q3yv/GZdJhcokf0/0nrav656yEhjclkf5KkYMbcICd9WAR4fykojBNnioYRj5Vh6TSDK1vlV eja/YuGZTdJ5xYuajhJs/7a8Us01BjPkGpwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 47r0LGj82rFyAwmA9Wjn6yTWhVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0NS+7vw60c+VZk 72hg3AfpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn3bEm51T4E8K0YIwp8hJBVAW9 9chDzFWLS+NjLqvnZ6rY7w57igjBJGD0II3oHpsy3TdSP0hW52GG/WM7t5D1zB2jcdLdRrcT 5NGMnw0M1KaPkAJYwtKYH49tL/Aan3XeSJRt0iHtKwf6GnIxws327/oWDbQUofXH50EwBfI/ woq+UyhOTU8GO6NywaDzVzymvfmnCnCdKMdQejQGvlCxQf7KnYoIB4XTlu8p9G6h1S4VtYZL FYbkgIwrq8v8GSoQ8P7Uhn+p2SL1jYYWtxNA6gi6BClzqvP/x3fB24KVDdNZdUq8sgsSlQC0 l6PgsOsBjF1trCRYWyS+63Srj6oPyURa2gYakc5oRAt+dLvpsQ3yxnIVNsmSP7zhdzuEja2y DePxMQju4guYQcw//3T1Tj6b/iE//AlkiZdCt3rY1+Y IronPort-HdrOrdr: A9a23:tNCjnKhjCfvKgdDkfpuGCsjVlHBQXtEji2hC6mlwRA09TyVXra +TdZMgpHrJYVkqOU3I9ersBEDiewK/yXcK2+ks1N6ZNWGM0ldAR7sN0WKN+VHd8lXFh41gPW MKSdkYNDU2ZmIK6frH3A== X-Talos-CUID: =?us-ascii?q?9a23=3AbB7iJmvai0SBq+syNN33PzEh6It4XEPZ/S/SCHa?= =?us-ascii?q?fCD0qd7OeEUbN1LNNxp8=3D?= X-Talos-MUID: 9a23:rRShlwYioKeoueBT7wTIoh1QJsVU5ZuAVlwVuJQMguWlOnkl X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.15,205,1739836800"; d="scan'208";a="352096981" Received: from rcdn-l-core-08.cisco.com ([173.37.255.145]) by rcdn-iport-7.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 11 Apr 2025 13:05:25 +0000 Received: from sjc-ads-7158.cisco.com (sjc-ads-7158.cisco.com [10.30.217.233]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-08.cisco.com (Postfix) with ESMTPS id 701C41800058A; Fri, 11 Apr 2025 13:05:25 +0000 (GMT) Received: by sjc-ads-7158.cisco.com (Postfix, from userid 1776881) id 07810CC1280; Fri, 11 Apr 2025 06:05:25 -0700 (PDT) From: Bartosz Wawrzyniak To: Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Cc: xe-linux-external@cisco.com, Daniel Walker , Bartosz Stania , Bartosz Wawrzyniak Subject: [PATCH RESEND] phy: cadence: Sierra: Add multilink SGMII + SGMII register configuration Date: Fri, 11 Apr 2025 13:05:06 +0000 Message-Id: <20250411130509.982422-1-bwawrzyn@cisco.com> X-Mailer: git-send-email 2.28.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Outbound-SMTP-Client: 10.30.217.233, sjc-ads-7158.cisco.com X-Outbound-Node: rcdn-l-core-08.cisco.com Content-Type: text/plain; charset="utf-8" Add multilink SGMII + SGMII register configuration (no SSC) for the cdns,sierra-phy-t0 compatibility string. In the case of multilink, when two links are of the same type,=20 do not enable PLL LC1. Use PLL LC for both links. Signed-off-by: Bartosz Wawrzyniak --- drivers/phy/cadence/phy-cadence-sierra.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence= /phy-cadence-sierra.c index aeec6eb6be23..c606b281da39 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -1262,12 +1262,18 @@ static int cdns_sierra_phy_configure_multilink(stru= ct cdns_sierra_phy *sp) clk_set_rate(sp->input_clks[CMN_REFCLK_DIG_DIV], 25000000); clk_set_rate(sp->input_clks[CMN_REFCLK1_DIG_DIV], 25000000); =20 - /* PHY configured to use both PLL LC and LC1 */ - regmap_field_write(sp->phy_pll_cfg_1, 0x1); - phy_t1 =3D sp->phys[0].phy_type; phy_t2 =3D sp->phys[1].phy_type; =20 + + /* + * Configure both PLL LC and LC1 when link types are different. + * If both links are of the same type, there is no need to use + * a second PLL. + */ + if (phy_t1 !=3D phy_t2) + regmap_field_write(sp->phy_pll_cfg_1, 0x1); + /* * PHY configuration for multi-link operation is done in two steps. * e.g. Consider a case for a 4 lane PHY with PCIe using 2 lanes and QSGM= II other 2 lanes. @@ -2541,6 +2547,9 @@ static const struct cdns_sierra_data cdns_map_sierra = =3D { [TYPE_NONE] =3D { [NO_SSC] =3D &sgmii_cmn_vals, }, + [TYPE_SGMII] =3D { + [NO_SSC] =3D &sgmii_cmn_vals, + }, [TYPE_PCIE] =3D { [NO_SSC] =3D &sgmii_100_no_ssc_plllc1_opt3_cmn_vals, [EXTERNAL_SSC] =3D &sgmii_100_no_ssc_plllc1_opt3_cmn_vals, @@ -2582,6 +2591,9 @@ static const struct cdns_sierra_data cdns_map_sierra = =3D { [TYPE_NONE] =3D { [NO_SSC] =3D &sgmii_pma_ln_vals, }, + [TYPE_SGMII] =3D { + [NO_SSC] =3D &sgmii_pma_ln_vals, + }, [TYPE_PCIE] =3D { [NO_SSC] =3D &sgmii_100_no_ssc_plllc1_opt3_ln_vals, [EXTERNAL_SSC] =3D &sgmii_100_no_ssc_plllc1_opt3_ln_vals, --=20 2.28.0