From nobody Fri Dec 19 09:44:12 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011049.outbound.protection.outlook.com [52.101.65.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F5AD190468 for ; Fri, 11 Apr 2025 13:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377354; cv=fail; b=ZtSyV/Yb8ndSV5LOL6ATdSXIo8VHC38EptpavqDiRfsScTvn5l7aLXNmVOe6Lnoso/hX8kikjlGnp0JsSojXjvj6l0T9L+2ufVAIlLqOflinRoJtqf/1diH/oiEfZRkN/U97ArwoQcZ28dENii3n5UaeNgKEeObibMbdSy06X9Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377354; c=relaxed/simple; bh=BIRZR5Wlafyct0TOxL8OjGOopa0MtgGY+OOdkywuX48=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=GWgosW/EoNMJd34ebaGDAhg0Jaq+xBslgIQT1SBToU4teTRznxdO1pWoPIAkLHlnKkSdVNgOYPFt+3vjtlOoigEmw0pOQZduNZyYGr5sBushp6XLwaeV99vP06hn7IVWE/zQnjaMV7enPo/+pZNVMmT4kIvmnq3+UZUaA3NvmWM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=KYvhmySh; arc=fail smtp.client-ip=52.101.65.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="KYvhmySh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tSYJzwRf/WsIvh8p+zIfVqiI9hQC9WnIJ5FJ4AVyjiO+fCGlxIKEG8/sz1bkfNfdRRKNOF0VwciUdOE0v9gQXfX68td/+0u+41Ah36RllD9jWe7x3vcUbVRKYUbfV2LBGC/scWxAHTMytLRNj+v9dhbKrMGvvNy8YBcZZek2thmS9tYRpnmUH2rObWAHPfQ7/p+lLvcS8syX75aQcnCQO2OB5yQUvDbj10QnoYsDTHIVPxqRGoH2VVIorMZWH+bO8ExaV0qfW9kUXMs4Xx/e5lZaA6yVBhC911VaHjOhq+YPcq9oX9fsHC0EJILOpTabD/0JtIa46taEhCM3s+m8Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4vNAVQZKpOqwecYw022SLgvDYOJSFIESQHQkB310uEY=; b=POT6xhyqL2tNHX7x8GjjIicOdGg1+YSZ/q37xAyW/HEOX8WUhxgDNdDbf+0Gqx6z6pss0Ldi0/K7HZAFv2p9uQrzl97V+tPHI8YHF3XJ6z1R1LG07ouMVobo7jgTjciX83Mnf+Gh27DZeq0NzKj6Vtg8ZIhX/ubYyUzk4S4sSCXe9t2LE0251OcBNzP1Y6XsbYbmdqcHhAMc4dk1UN3vyB7zfDgPE1QI6lp0P8yWONnBI4FAaF3Zb3VNTKfEDwHO/ib5IGp7TA3DBWH1X3CtAIvvMNE5OUiHPRynAGFjcDh3GTZgOBVwDT56vR0JLCpljysaWgzUwRux2Y4kdSwN4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4vNAVQZKpOqwecYw022SLgvDYOJSFIESQHQkB310uEY=; b=KYvhmyShXMYKLlpyncOySZ63zjHxD+nDyS7XFV3eIhlmrGTyYJwbRTNEB6iyjBIKuKX4ouYikc/bsyd1iNK6jqfD98lID66obpMUPKuxAKuYbHksPvrFUE0NNrlvKCtie8cQrF2ue+y5FKXq16bwnIPP8qBdLIkjnPaTiN6YVttUXhugnsrH+upSpEm5NAryhQLA0RbXCgggkIFNemi/zmXgszzZ62jAhy4WeBhpckki5wYRij3QseQx7wspt7sjIM62zQ6yDLC5wfc+LRVU9efpwwcUCxodkINrtxWNfzOlo7jy71XVZKlqEUaKrNG/HDomu2vtJWhdade3Fwo99g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM9PR04MB8682.eurprd04.prod.outlook.com (2603:10a6:20b:43d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.27; Fri, 11 Apr 2025 13:15:47 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8632.025; Fri, 11 Apr 2025 13:15:46 +0000 From: "Peng Fan (OSS)" Date: Fri, 11 Apr 2025 21:14:09 +0800 Subject: [PATCH 1/6] mailbox: Use dev_err when there is error Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250411-mailbox-cleanup-v1-1-8db541394dc2@nxp.com> References: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> In-Reply-To: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> To: Jassi Brar Cc: Tudor Ambarus , Elliot Berman , Thierry Reding , Sudeep Holla , linux-kernel@vger.kernel.org, mailbox@lists.linux.dev, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1744377279; l=1144; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=qJHxtFMnLRC1tugmjXIXBnPYrnsNcoEt82sSV+RqtVo=; b=NM81FDtInnXYaln66ueCZPZCrh1UbeI+utgmWOceKgoxvZ9cFjmqTbjZcKiGdg7YET3x+gsBt pW1UGRjxUk6BOCHSwY+0KKj+hy5+4GZUnzAxszCJFmZEVMa+BmUFMcl X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: MAXPR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::22) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM9PR04MB8682:EE_ X-MS-Office365-Filtering-Correlation-Id: 6428f929-cc0b-4dba-55c7-08dd78faf87b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eHI2Vk1sRGF0cXZzU2lsMVVqSmVlNVlhMkVtdXBFcDhPczBQdExNVUVCWktk?= =?utf-8?B?UDIxYzFTbHRseUdQb3hpK2dtVHFpOGtJd2UzMlBTSktGcGdqM3poODRiSnNL?= =?utf-8?B?eXVZVzlGTEFtQWVIT2NoZFJYaEltWXZkWHVUVVc5SHdmejAxSHJHSm9yY3Za?= =?utf-8?B?b3ByRlR0cGpUSHV4WkZZQVZmcnc2b0ZSUXNlZlRIVmxlLy94dTFXZUZWQzNS?= =?utf-8?B?dzJTcXpZa0hSTzVxOExJdUwzOXpJNWdSYkNrR0g3L2N5c3VwM2lSaDhPMHB3?= =?utf-8?B?eVBIY2FSU05MZTdrNWIybk8yMXJWNkpRd05LYUVlNWlBNFV5MWxteGJBdVUy?= =?utf-8?B?YmtwcVl0ajZJT3RBMmIrNVFqeEUvOTJsTVBSTWRsR29ZV0tFa0U4MkJoc0FG?= =?utf-8?B?cTA2MzJYWHFzVFhxRUlOaE5pRDVhM3ZjekJJcXBxOVlaZFRuZ2ozWkgwN0hZ?= =?utf-8?B?MmthcnVzTGV3c09aTWVhdU41SHNhQ0VCcWs0dVJkQjhmbCtjdGZDOWl4eTNK?= =?utf-8?B?S3dYQzlxRnJZaGkzK0h4QXoxUWhMVmhnN1krV0tJTUprQ1lPNE5uVjQ4RUlZ?= =?utf-8?B?TjEwOHlDZ2JHM0dZMDRxSmxmMXNOTHQxbWRaMksyUkdJVmhqSER4L1ArcmhZ?= =?utf-8?B?VE1sajZ6ZWtZL1hHdTlPUE12TWJXdDkvNm5wdDR2dmFJOE54amh2L0VEL29W?= =?utf-8?B?SERrZFBEaHorbXhsTGh4Y3huQjh3dDlhSU9KWkJuVi9nM0VDZStGamJDaFZ2?= =?utf-8?B?Z1VVVmYwYnlteDgzT0grRjhaYktFQmZadk1CZEFzTG1TNDYvb01USnBOUm9D?= =?utf-8?B?UWJ3VmpBdGVnMDhjY3M4b3VZV01VeDIvKzZtL1hyZHA1dDZ2ZzZpbGxhN0Ny?= =?utf-8?B?ZDRuci9hZW9IaFBkWHFMWVdxQ3lIcFU4K3VpMmdwNUhENFZrQ3ZWSUZreDJv?= =?utf-8?B?ay96ZjBSdmhzeDJkb1hWNVJnNFIrWG9rVDIzTEFqckVpaTVyZFNBSWdvODRs?= =?utf-8?B?cW1UUk1jcTgvWDNDMmFLV1p2SzZ6dlNiSWZTaVNSOVdnMTRtZGtVZWxpVFFl?= =?utf-8?B?WGg0b3VnN2NHYStsb3pYZ3FTanpkQmxIK25jSC8wYnc2RzZ2TyttV0wwQTEw?= =?utf-8?B?aGRsQjkrRWdHcnVLYlg3eHJnaG9DdkZBWC9uU3dYTExhZ3B1eU9MRTJGZnZs?= =?utf-8?B?M3FPTkVBYWZxZ25lYkt4N09vK3RYL0xzb1MrQjBGOUtUZDIwMTRidXBoTjky?= =?utf-8?B?dXloN0xMREZaRVlWQ3g3eldsU0lLWFpqdk9tRTU2Ull5YWlJelpyUHlTeWF2?= =?utf-8?B?OFhQTjNUQ3QzeG1oeDNvU0hibjB5ZG5QRjBncTV5WlhrYnZPNVcweUtjdCs5?= =?utf-8?B?TnNaV2hHdW9FRFdZZG03b25CckF6dW01OUZZdGFna3ppeG5xcXRpenVQYWZR?= =?utf-8?B?cTZRM1hudWlTZFp4bm96SFU4bmJ2QzVzL3FQeHQyNzEwWnRtQkd0V2k3enp0?= =?utf-8?B?MkE1YlJqV1Q4eGJrcS80bXRNSXFleW5iK0xZellqNms5UDhqYkdXT2x0Tmds?= =?utf-8?B?UyszZjZsY2lBV0FDZ25EajdqbmhHdEhYSkcxZDl3MlJCNlphUGJmU2hIVFhI?= =?utf-8?B?RHRLVW1KellOZTR4NThmZDNhbnRLRHlkdG9UcGZuMGxqM2JPY1BseU1jTnk5?= =?utf-8?B?RDBlUDZkUVcvR0ZzYTlkVzhPZno1eHFhMXE0bVdTQk9JR0NOeW9jc3FJM3J4?= =?utf-8?B?TjlSR2FMN1UwNmg5SVByWE9FZ3R0Z1QyU0l0L3MyZFpBRHFsNzl4WlpOYkxL?= =?utf-8?B?YVZ6R00vdUYyOFVDUzhqSDI3UGVmbEJCa3dPeHJrdHJmVXhIQzRSSGdPcjhi?= =?utf-8?B?OUJoZmNWS21tK2NVM1cxOE5PVEhYQnMxNGIyUDRDSTJjdmRCR2JWdWlOTVov?= =?utf-8?B?Z0RaNWFBTy9DakE3cUJCSzg1WmF6eXg2bUpQMWJqU0dYb2NvM3BSYTNWQXRO?= =?utf-8?Q?IP/AA91AiDSnGfBGQ3PzppxlJeFIfM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MElCMDZQUVVpcGZCbnBlaXF0SmZNUTV4WlpoTVlOT2lic3VJQnFiMWsrVUJo?= =?utf-8?B?RHdSdld3NTFhY3NqdEpGYldHSjJLQnRzNnNrM25VakM5cjZ4ZGFzSm1yOXdt?= =?utf-8?B?cnI4UnUzV3FoenZBZlIzUFJOejFOcVVaclk0OVZ2bUJDWDVtckNvZzRaeWlm?= =?utf-8?B?UzBWOGhUN3liNnREOGx0UGFDMmZwRS9JWUk4RTEzaUprcWtTTEsyckt1RnIx?= =?utf-8?B?Y2Z2SzRLcy9rbXRZeG9ZbmV1Z1Q1NVdlQkN4djlCMU9nMkQwVUx3d2lQTktz?= =?utf-8?B?bFVVZmNLWVdpWlpzd1Jnc291YzJhbjJISTFia2dIemZGdHk3R2w0ZGtCajho?= =?utf-8?B?ZFRQSmd0dis4QTRCV3c2eTVsNkNoZlJKTzdmR2NPS3piV3cyQmFJaTdOMXNI?= =?utf-8?B?cDhhYkRFMUptS1NJSzM0SXdvT1ozb1paRFRpNW1sY2ZwQ20ySXNiOGxWMnFB?= =?utf-8?B?ZFlOejJjUklCQ3RmUEQ5eU9CWVVhZEROL09yQWRnR1lYMldYSXExWkovNkRt?= =?utf-8?B?Vkc1L2xuQW1zd0FHNDVwT2swZ2FMUEZWMys2K1BoS0EyT25ISm45b1RGcE15?= =?utf-8?B?SnU0eXhrSUw5WU9CNEFVQXgydWpFelgzZlJHUmlSd3gxUW56YXRsM01Ta0RI?= =?utf-8?B?bFQxWHM1M1Q4czExSVdBNkd4K0RkdWFpWmZJS1k0NnJlUTVWM0J1TkFCcnpL?= =?utf-8?B?ZG1GQk82S2NEUEtLVmhRZjl2dldTb2Yzc3p3WUxXV25kQ1VxaXAvdkx4clp5?= =?utf-8?B?QWZPOUg5OUYyVlJ3OUVObU1aOXBuUERvUzdxeTZISmljRThEZk4yTzJWL200?= =?utf-8?B?TjNyQXJHNHUxQkRsQ0orVUZtSk5aQ1B5TUduLzhMUWV1bUNURjl5QURJaDJm?= =?utf-8?B?RW1QNWx4TzBqa3NJK01xOXhMZ1Z3RDFvaWtVK2xhYkl4eDFEMDNtOHZOdTBi?= =?utf-8?B?TFJsWkhvMXAxNTNMMEl6MFR4QkZNQVFSV1ZPQk9jR3JiRk9nY3VYcnkzWjhl?= =?utf-8?B?SE1hdldKOXNIUVdJdEVBWmdkd2ZxbE5KWHd1U1Z0QjI4WnlISjdmSSsvZ015?= =?utf-8?B?d01YZUtGeWt5SkJZSkdEZVQ0ejdrUE1wMW45WHhub243emlBZTlYUGJCQXdz?= =?utf-8?B?elU1NE5wSVprajVVTVlrOGNMS2piTU5qT0lITXphTlVKWCtJYTJEYktXYk9T?= =?utf-8?B?Y3AzbUt0L0lDQno5UGl2cjgzLzRaZlpmdXY4T2NYU1JaU2JOcUQ3TVAwTzQv?= =?utf-8?B?RXBIOTRsd1NBbk84TG9PVHVUZXNvUzk3YUpGREZDVjZkdDFTT1krNElQNmZj?= =?utf-8?B?NlJQcC9TZzBXQm00ZHdUbVZFSG5xaldXcjAvaTNMK0F1UzZxcWVCZlJNTWZN?= =?utf-8?B?OWVZaldxcGEvQUgxVG1qN0M3YVJnQSs2cE1uNytuaG9PTUd5V014QVJXbzZi?= =?utf-8?B?SzRCeTJNUnQ1L2JpK2UvOFEyQnRza0dJN1o4am9jd1JCZENlUThjQ3dacFo5?= =?utf-8?B?cjVubHR5dXc5cDY0NXhRS3hKRXlneXB0VzJjaFppM2ZkbGlpUzBnSjBqMG5Y?= =?utf-8?B?MHk3Ui9wSWx0K0draGx6a1hXditnVlVpaFova2ltb3d5Zjh6U3VoVmk4SmJZ?= =?utf-8?B?MFNkTzJxekFIRlRpZE5GVUg5Y25HWWI4UlZUbnM4d05TcE8zblQwWVNHaUlq?= =?utf-8?B?cGtGTE1OVThlMTgrKzE5bWMzeHBTWXpGLzcxdERvZnJwbkoydyt2VXozWng1?= =?utf-8?B?OGN0ZHp1S3RsVG8wQlcyeEZTZms4RlNNOFo1ZTlVTEZjZldiRHZJMnZtMlg3?= =?utf-8?B?d2dLQklJUUNRREVLMHFNcjkvTnZSdkJUcExpbmE5d2wzU2VLdFpWbDQvam1X?= =?utf-8?B?VTZjM2JLbW5XanRXMldDeFYxYitGdC8rRk4zMkN3WVlZbHlzU3J3cTN0dGoy?= =?utf-8?B?UDNzTDRCY2c0U2YxK0Zldk9ueTg3R2ZUTENYSnQ1K2VQMXRyS3pDMzMrd3g0?= =?utf-8?B?eVRnOUMzYWF2ZW1zdC9GL0RYb3lHRUlNc3VUNEtkR3VLV2lIakpac0dvTWMr?= =?utf-8?B?ZnpmVXFsTFNORVlrR0c2anBpNXF3Z0oxMEJiSHRZbnFUeG03L2ZVeW96amxk?= =?utf-8?Q?rP35YMjzd3hoBROyBqQXDD6KU?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6428f929-cc0b-4dba-55c7-08dd78faf87b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2025 13:15:46.3704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OZEa+b8s1wQvzTK9jT8kmmiqgYrY5LJXTjDLUjf4thjXH2Urgm8TIFzAPKFnRLne7SjqWW+5qQxrrc8SLdFTSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8682 From: Peng Fan Use dev_err to show the error log instead of using dev_dbg. Signed-off-by: Peng Fan --- drivers/mailbox/mailbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 0593b4d036859570ff47d8bcc1e5c75955612392..e5e2a66355a712e71a92e4ad339= e99d7ff8e34be 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -322,7 +322,7 @@ static int __mbox_bind_client(struct mbox_chan *chan, s= truct mbox_client *cl) int ret; =20 if (chan->cl || !try_module_get(chan->mbox->dev->driver->owner)) { - dev_dbg(dev, "%s: mailbox not free\n", __func__); + dev_err(dev, "%s: mailbox not free\n", __func__); return -EBUSY; } =20 @@ -413,7 +413,7 @@ struct mbox_chan *mbox_request_channel(struct mbox_clie= nt *cl, int index) ret =3D of_parse_phandle_with_args(dev->of_node, "mboxes", "#mbox-cells", index, &spec); if (ret) { - dev_dbg(dev, "%s: can't parse \"mboxes\" property\n", __func__); + dev_err(dev, "%s: can't parse \"mboxes\" property\n", __func__); return ERR_PTR(ret); } =20 --=20 2.37.1 From nobody Fri Dec 19 09:44:12 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011049.outbound.protection.outlook.com [52.101.65.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 574211AAE17 for ; Fri, 11 Apr 2025 13:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377356; cv=fail; b=FAkO5aHfngSDetMWWgMaC141MrTIakFizGjP/P0rr5kzuz0ZJ9vXlI47syA6eDXxpkdPMW6RYD8rvWtOb4jJLvq0omDFGjKDvmxo93DReeTGzIzwIu82Vw6RsyWq911Odsu9nu+3Pc2VH/9M15N0C2wn722d2SVuEXu8DnADthk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377356; c=relaxed/simple; bh=62N9Hf1pLtId20wyAem1DOQE1WqhH8PsEu2ds8C8GRc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=J99bmlL/H+SCe8p+A+BpepDY9IAZCmKT/0rcjg5ceGEgBd7zuaGdUsDH19DF339FR7+pcESLefNMAf75juANBGJThidZW4Wpo54WL/RfUcWa/I4hFttzR2ldGKooJ5GoRFPukV/MI3S2CQZ51L0BDFBpEee6VI7oej/s+p3cX5E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=PkJF8FXb; arc=fail smtp.client-ip=52.101.65.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="PkJF8FXb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=djCR61LmGU5yfVhVZ8vno9zbyv/iMva9ixjTe4ffw6iQosrSuy/fGZgObcoMd7DCQUxZBFZk/vbnJYZvuI3yZrRFCVMRrhM9bMi76798RDr6i5/p0qIkAKgayVz0TgxzNMwJRGpZnxbKDVN3CbTsMGOLM6GWtTiKJsaRFuO3v6O379aRUfURWb3x2nW38SgTGLqpgx6X+9R0gIBFdfwvnfTW9YdTTFLfjLlkO1tcuK78zLHDW9vgZLNEMYaMKkkFHKz38I7hMwCA/GYRtlIyS/ankt5kk2mHsNEYQCLrq19kjJIbyy/gLD0xzheCPtGvouDICzrjHs7PRtqsNiDheg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eErvUzkRXKgVUOWqvzVCfFz52PYjXaJbppG9t9DCIjU=; b=tp8x384zZZG6D5H7NS1Ugj7rIfuQUXOuhQpN8hqwV52H9b7JiuvKCz6pzMdaUdxk8tDTsy3L/R2bnfVk1SIAueGBlnL3zb0yCf0VdwXU5c8Q3EjfvaKmCOqBwKf3Fe0HBwgC4yfMO6KD/hrdOn0Xo+z0RVVGUNlS2yuh5ld5Ivr24sA7L1oLJAuSXZRL6c6XSwdzsbEn9ReCuT0SOUyPGYQ6xp5IEP9SUO7CFiFyF58Y7EQWhTyEv8QU48l3pw92KPvvYMg9Ae64OsJmd++OsrTycOZ0NtBP3aUiYr74RwCEfsiTSOVtQ5w+IYgD9nv0wPJg2XtXrp6kUVCME+ekeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eErvUzkRXKgVUOWqvzVCfFz52PYjXaJbppG9t9DCIjU=; b=PkJF8FXbHvpZ2AnMbJFEBUNAnb3nS5pi9ToYNgw5Lvt1FgANK/TizKffcfVHMDhwj9oXtJ3Rch+8o777XFLWSGLCYQPtynMZse4dw8TSg78Vpfk3iOD3g1ZV/SakDjWb2sGa2BbtUDnGCO0eCtxIZ8GoGLEup6hlcPEZGfXUfj6lxtPtBNv82o9wAQoCnMLS/MrYh/tS0/TrwhwoF91F28GvBQEditoM3jk7DfzfMEcLCVze58jzfaZJlImYdesN0Qs/1QJEIFf+a3h4xVaTxVjlKItSvQeBmdr0yGY8/lJ4zA6oTC+YD4Ty6XUOLGckMuG/rxYwAV623wUbUTZ0lA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM9PR04MB8682.eurprd04.prod.outlook.com (2603:10a6:20b:43d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.27; Fri, 11 Apr 2025 13:15:49 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8632.025; Fri, 11 Apr 2025 13:15:49 +0000 From: "Peng Fan (OSS)" Date: Fri, 11 Apr 2025 21:14:10 +0800 Subject: [PATCH 2/6] mailbox: Not protect module_put with spin_lock_irqsave Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250411-mailbox-cleanup-v1-2-8db541394dc2@nxp.com> References: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> In-Reply-To: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> To: Jassi Brar Cc: Tudor Ambarus , Elliot Berman , Thierry Reding , Sudeep Holla , linux-kernel@vger.kernel.org, mailbox@lists.linux.dev, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1744377279; l=918; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=1h/hYGrZ9fi5AKuo3qMhUJI1JmurJT+n9QKZo/i0UWk=; b=PXL0okxKjMhmJSz8kYLaEnt96xVK8vVRJs6CfvxgPtozgmiMAH53pWbdK2F8yJWlg5f9aDf4D Dtt8uf0B/tBCtUqtllA28Yb53oLDdFSOTbvNSDI1Gr7GCRcg6YV98Wd X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: MAXPR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::22) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM9PR04MB8682:EE_ X-MS-Office365-Filtering-Correlation-Id: 365df2e7-98b3-4c18-d8ad-08dd78fafa45 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VXBiYWQ2WmVxUkQwT0hXQkM5MlJHSTlkSnQrOHV6VSt5Qk5EcXJkR3lJYU5k?= =?utf-8?B?dnBvTU9wZjc4S0tJZFVxc3N0VDk4T3BHVldUMlo5Z29mNTZtVUZTb1hLYXZ2?= =?utf-8?B?STVhRW5WNFNkV3locjFDcHg4bjUwNll5TGNuRzRoMjFwZCtyZmFxbTV1KzBI?= =?utf-8?B?aGZVN1lrUjBNSEJMZENMS2pWSDl5c1Z2cU56aUZtQTNldlNhR1d5SGM3dm4r?= =?utf-8?B?UEhhSjk2d3VCcFEySTY5MXROOHpVWDQwNGh1NmJJbFRXM2pMclExZ0NwN01T?= =?utf-8?B?eFlvdTV2MXpRQStNU1NRTGtHeG5XanB6ZlVsNWhTVy9YVlFJZWQvMW4vV1lW?= =?utf-8?B?akhHQ2dKNVJ5ekc4OEE4aXgrUEtLdXhDVTNwRk5XZ2FzQUlqTElMWWVHRVNl?= =?utf-8?B?U3ZKQ3FOUEZwSWwvY0pKR0wwOGM4TjhYdWJhTlBxbndNOHFJMG1vNklJTnN2?= =?utf-8?B?R1pNSEpZcGxSNzdkZWpzL2xXTXFyMzAxY1hCTVNLbWs5RkVRd1pJNTVYdkZl?= =?utf-8?B?aGhOZ1hsSEF2N0RMRlo3M2VoZGRaN3JBdDgxZ0JrQjF2ejRGczVRTlVlcGIx?= =?utf-8?B?SXVNaHJaVVVJSy9NR1JrWVVLcm0xTndiUHQ3K2REdjdhR0lvRlBKUkpQZ2tU?= =?utf-8?B?TVhSK1NyUHBTTk5ibDNjOEdYZCtTbG1UM0RkK0N4YmRoWVdMRUtxcHJnajFL?= =?utf-8?B?WGhuaUF2dmZac0VoRWVrcS9aRnAxWUxpNFFiM3ZMcng5bzhCT0h3czR6ajBs?= =?utf-8?B?QmEwZ3hoR1VaRTY1d0s0MFNneGxTS3pzajJwRThXeGxnbUdzVHc2ZnI0eXEw?= =?utf-8?B?dUNQLzVkN1NZUGdKS1gwcGdNQjYxNlM3eXZGM01VN1FzMUZxMXZ5YlZHOTc1?= =?utf-8?B?YUM3ZTFJOERnbmgxZXJ6amlYSHhDOXJ3c1hIcXBiUktUdlN5dlR0TEh0SDJD?= =?utf-8?B?WVdmRTkvRXhuNXlYRTBCUFFkTTlMdUVidE5uUTE4bGxaTVR4cUtFWmZ4Rklr?= =?utf-8?B?c2xYUHkyT0hRSzNTdG8vYWF5L2xreTV2VGhpYkdQYlVicUQyTE5YRFk2Mzdt?= =?utf-8?B?VmNyVElMK2NEd09kdFl0QVdXb1pML242TVRqdlpSZjBHYzZna3BBWlpmcWdH?= =?utf-8?B?MGZrQm4yZkNRVkV2cCtqRytSck1IeVhQU2lkWFB6V1ByYVJ0NHRnMzkxQ2lN?= =?utf-8?B?RDZTNnRFZGpIbU1MdWJjNTNOL29QQ3VkdXM5bXF2NGZ6cXZvV3NzK3NaSWc4?= =?utf-8?B?SHBNZE9wQkwvUXA1TzZ1cGhFK3JzcTl4bGhSQ2lqTFpwOFE2NzkwNW42Y3BH?= =?utf-8?B?emF6TVorQ000MERBaW03RnNlQ251VTRJT2tYSmZnS1dBcG5PbDVqMUhIcVpk?= =?utf-8?B?YkQ3bHAyZSt1ci9scUlFeXBaNVVPUE14TG5zSUxoWjEwRmg1SFNlQ3RXUTIr?= =?utf-8?B?RnhzR0toWmtIeXgvTGRRVWV2RklTbWZheEtCTXlqWHU1d2lUNzFZYTg2VWxD?= =?utf-8?B?VCtLYWszTjk1RHNQM3pITjdGZmhEaGpueTlNbGRxVUZNMjU4S2M5UjBkWjR3?= =?utf-8?B?WGRwLzhBRXFrMUFVc3llN08vTE92SzBPU2o5OUFESmREWEZrejJQMEpWNHVp?= =?utf-8?B?SDJOaC9MQ1BSU1lMTkJOb25PMnQvUGJ6QUhDaExuNUU5TUpUQ0F4aDhGaHJ4?= =?utf-8?B?bUIzNUtXbEl4RURXWklYeVJzRFFyYVg3VXUrTUFSNXR5QS80bDVETGM1WTlV?= =?utf-8?B?NmgzQndKSkp3YjJOTmZVczA1dDhLRXV4d1kvRW5QMklPTE0veVAyMUFxZnZG?= =?utf-8?B?NXI5T0JuMkJ5MDM2ODBBUFJqQVVkN1NEWjFVbVk2U2dxVFd4cHozMWlpck5P?= =?utf-8?B?b2NNNjBOeGZPZVVaZnRubUxtOTMwZmFqTWI4OVVFMFBSanhXQnl3YVFrd2pQ?= =?utf-8?B?RS9XMFNjSlRpTVczeUw2dVQ1Z25LQ290dHJFVG9jNVljMEY3aE5XRUZnQVFT?= =?utf-8?Q?TK62QB6TaTvlhtyGMJbNZSd8GnkIrY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmkyYnFpQmtjRG5OdVBNREpBNzFOOGxBejRYT0NCTXd4MVROQjdJNHZXMjlW?= =?utf-8?B?UFdrYlBndjI0cTZKQUNvTGNKejM2Nm9qNEZ2aUxoUHR0K21qNU9VN2I2S1VD?= =?utf-8?B?a2U4MEMxc3l0d25NK3B6c3E3eDIvRDdqSm1TaWVjSWpGYUpUOGc0RFRrZkd5?= =?utf-8?B?K3NxUTdJOERjOEpUQ09KMU1QTHdKeWhERHcrYjN2V2RJM3M0L013WklicDlF?= =?utf-8?B?VGZEbTJDd3FDSzJQMzVlSXdUemhWVEh4dm9YWGx2TFVjUWpsRnY2RGlxdlNF?= =?utf-8?B?RTFCU29LU2xPU2poY3VLS1RmNVJZL1FLUG85dGxXWFVEdXVER3g2MGhkQXkv?= =?utf-8?B?ajJsZXdTUUQ2L0hnUTNRTWFuVE1NWFVVcTN4S3RhOUM5K3ArUjMxaVpsZDlN?= =?utf-8?B?emFIc05UNmFrZ2JyY2VBL1BhOE5QL2pZRis4eUdzaHN2QVJ0Ylp6K29RZmE0?= =?utf-8?B?NU5vU0ErUE9XMGM5Nm9Hell6Q28vM1VtMEFFcEZNRG40bys2WHk3a3dFMHl3?= =?utf-8?B?bFkwdFQwYlJJenA1M3h3SU1DQU1KcFhtSXdBcjhSMVIrajFVcjk2TkhBSldr?= =?utf-8?B?WEFXMzFWUStsN29xRWg5RHp0VUlVMFFVUGZzc243TXpUSFQwMnFGR3dvaURO?= =?utf-8?B?Rkt0b0ZJUWgvY2YyeHNKUGZrcFBUSVRwam5oRmtpUWFxRm1YdG5VUCt5NGRv?= =?utf-8?B?OFRoZzBrY0JDNU5KWVlGcTNmL3cwTDFuYzROZUt3WXNydUd6a3VRdU1idldv?= =?utf-8?B?cTYwZHRwRkM0Nkt3aW5mUUxsb1VWN2RYeUNYWkNWSXN5cUVuRGF5Q0lZZFJs?= =?utf-8?B?aWt0eXVZTlBSOGxlb09CT1VOdVJoZDB5UEZDMGhvMGVCRzVScStEY1RZaENB?= =?utf-8?B?RUNDWDczeE1yU29XWElGZHp6RDQ2T2ZZai90WDk4U0wvQTBSV2JOT1ZPdS9Y?= =?utf-8?B?b1l0VTFnZGhpbS9YZGFoaEZkQllaaHVjci9hRDZBb0dIOGN5ODFWZU4wWGpE?= =?utf-8?B?bzdTVVN0eXpDZVo5QU1zcXNINExYeFdQdXdZeUNZNGFSL0tZM01QZUYrb0pM?= =?utf-8?B?MEdmdFF1eDVEeStDT0g4eWM4SVlWWHFRM3lCYklhcWRZWmNiRllteWlmam54?= =?utf-8?B?TGZXK1ltRHpjckRIL3ZYUFloNHQrRWNxNkU4TGpsTmtSZUpBYTdaNWFROTl0?= =?utf-8?B?S1BHcFdjejQ2U2VHdjlnRmhURFdyeTFPVXZSRGNJd0Z5YURnYkZYMGNhOXVk?= =?utf-8?B?cm5wSUdOVmFBZGFwUUdpcDZLcDNxaDVZRE5hTWpLbGMwcFJGRUtCazVJOFNQ?= =?utf-8?B?dDVJUGI4NktLajNwN1pNbjdaQUtCRS9YNzNQSFNtZmhueWx0ZGIyY1V5Q3VX?= =?utf-8?B?MmpGVitaaHlpRStrdC9kbDNETjYwUTB4S3p6cmNUZTBOampmREIyZW9WMWJW?= =?utf-8?B?UHJKZ1ptSVBvVXlqbktPRTB4djIwbUdNcUxCZzhKekZTYW1wYW1lSVNoeGo2?= =?utf-8?B?QmtzS3hrckRBWjJGZjEySVUzN05aaE1SdUJPdkwrSldkV3lTVmpSWkc3WXFD?= =?utf-8?B?d2pCQzhwdjFjL1ZidkRaT1VWeDZrVXdrU3p0UmVSUjFWZ0hhcisrNUhXS2xP?= =?utf-8?B?OXAvMlM1Mi9YTkRwN3NqYzJWVk9hK21yVitkR3ExdmlKRjFmUzJ0V1dYYk1p?= =?utf-8?B?bjFON012VkRnblpBVytycEJQUjRJc3djZDhRQk9uMXpReUcxenVxYnNrSHNl?= =?utf-8?B?eWNPNWJVYmVLaGNnZ0pvUzVmeTZaZ3docC9UaEUyeVQ1VDhxQjRXK3F2T05q?= =?utf-8?B?ck94Uzd4WCs5QTBlc1p0R3dQTHB0TThMNHZubitYZzNZVk5PSFcrdEs5UjVa?= =?utf-8?B?WTBENE9lWi94R3ZZMUI4ZGFyMm45ZzlvM0MySzc1NWk0UjFpTXZPaC90bTMz?= =?utf-8?B?NFowdFp3SXgvaGl6blgxU08xYWdIT1lWUWlpQ1JXd2hYSjUxVGhpc0tFeWxL?= =?utf-8?B?K3ZQQllMSSs3YW9MT2JNUkZob0NvTUpBVjR0UWNBL0pTaUNBaE4rVjdyVVIr?= =?utf-8?B?K2VYM0FuWnFXZVhxSk0veEdweVhtT28rTXg2WGlWdUluejBiNGJ0QmdzblBq?= =?utf-8?Q?5Y5A2e5OK3YmbQuSBamtFvZtx?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 365df2e7-98b3-4c18-d8ad-08dd78fafa45 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2025 13:15:49.4717 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TOeVAYDbyXR0kdJRzxVZHky/D+mUz2bf4cdilmzkxjK+6BWXiLrfrOek4wbhDHnGudlyPWWy4AGlTmmaLOQfPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8682 From: Peng Fan &chan->lock is not supposed to protect 'chan->mbox'. And in __mbox_bind_client, try_module_get is also not protected by &chan->lock. So move module_put out of the lock protected region. Signed-off-by: Peng Fan --- drivers/mailbox/mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index e5e2a66355a712e71a92e4ad339e99d7ff8e34be..3ecf92a580fef031d8add5e4c2e= 4df494a34010a 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -486,8 +486,8 @@ void mbox_free_channel(struct mbox_chan *chan) if (chan->txdone_method =3D=3D TXDONE_BY_ACK) chan->txdone_method =3D TXDONE_BY_POLL; =20 - module_put(chan->mbox->dev->driver->owner); spin_unlock_irqrestore(&chan->lock, flags); + module_put(chan->mbox->dev->driver->owner); } EXPORT_SYMBOL_GPL(mbox_free_channel); =20 --=20 2.37.1 From nobody Fri Dec 19 09:44:12 2025 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2074.outbound.protection.outlook.com [40.107.21.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24A871C8629 for ; Fri, 11 Apr 2025 13:15:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.74 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377358; cv=fail; b=CR7Ahwxzj/LNRiYApKZTmBkIW5gRn7AvoUhMPBvDakBO4nrhnTfQZXr7Iq3C2dRfJaGVvoeGlnZsEcUNEcqE/iO/lb1enYbvk5PH0pUYaJakBFw00flFhfPvxidODQ6qLmliSkH2tnW29jtE0YG1/6wiw+HivjeoK/Ap7ZizWDw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377358; c=relaxed/simple; bh=Fk++fHqkrShI0LskVt87YFOlB9TJVuI4wVwgxOH5+s4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=lc7G7+RIFwzc///TOewoSGZu3E4dtE4MIttw28Z1rf6t2VNG4UyCBnNW1oFFX2pcxDru45kV2nlXAiW5qGR6XT0zR2U1Yy9OqYTcIzYUDE7k6vDlSits1vcFsbw9bsKfYWImF95lq9N+czCSF6ORq0hLL7QBMpyqys2CvubZ5js= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=ffuUoZUb; arc=fail smtp.client-ip=40.107.21.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="ffuUoZUb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p0Z6gBEydAcs5yqUVelc0asmHCxrBz6CGS4hgoPnaPa1rvnLU0EkV0ABi9E+KYvg/hbN+6d7iUyCR0hqE2qENMAZOWu+Ak1TRfzeQe4cAe+BPZSYflCPC7S9+Og7HBUizfJ5BNHTkyzf4xC5whyxqp4arwscQP5UsqJJLrFLHcHtA+ktUwzNFHQsXXTXJ+Gn8kK1PCVbi/CJCeTCeHJOWQrHaU7HBL+h0fOeRDF+fJEeSn6DmqepVcM0SSIB8WJ8qFX+K2aBmgpQMztPc4MYoJEY2crfyy98dYy4QnNAvsUGsXvOjEyFJ61CcgomXYFsX+Uvp+fKPXdBEnXPtICpjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FLKJZgDifmFu8LqPNN/gds1Lhy9QXXnXqE/mxi9AZJg=; b=i2VqJe3CEKkwZKu0wA5mHklPiJHk+ZVhzqVaZVV/lCWdQhbW1iT9760OLNgwt1PNniUZdLgi1JpjLwXd4sC0yLqzLH2V1aYtgbz2LWPr6rHQEbBX7ac1qbsJxgfKvtAeC5cF+/2IkCk4kw7x8K63ay8zvFm4TPs7mVrRjmaHOvksSMTHniEp820S8eX6sj4bLjMyudCpPxIXYRLbDm9T7BDoBZzQbBN/89y9jWRFGekmm2lIPuyaGWMFzH3N5hbczJCyc6Zh7nJBZOu2n7hRJynglF667qgdHBaEOru732Nt3pafbxkETeOroX6ZG7FRyT+3biTyTZfAADZCY7pP/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FLKJZgDifmFu8LqPNN/gds1Lhy9QXXnXqE/mxi9AZJg=; b=ffuUoZUbnnqHvSC75+1odq24RNN87s0KcnXhLTwgF4C06zZd0LqCYrItwb+2Bc9LMNafFQodv0ZO4tbjQdCdWnviXUerSsY9Hy3f5wD78j+JsRG03q9e5qmQCdeGhy+E8elOz6VC2pRKJ90yPM/ULvTE8FIYvM2Lbm51knz9s8sQoeum2ek5okb2ueoyv9E3k9EnnYp+Wqk8u60EcN3cSUcB0OQoZt5GQoJZZkhqLytXoIE2+4EBhHjJ3J+DXhM3cB4bUFKc12CHOqF0XVBMtAAqPiLNDmV01YAN5fjcxop6M9F/6PAvHUJac4S0eZ9JY/R1odgLUuJn7dPRzaGqDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA1PR04MB10674.eurprd04.prod.outlook.com (2603:10a6:102:483::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.28; Fri, 11 Apr 2025 13:15:52 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8632.025; Fri, 11 Apr 2025 13:15:52 +0000 From: "Peng Fan (OSS)" Date: Fri, 11 Apr 2025 21:14:11 +0800 Subject: [PATCH 3/6] mailbox: Propagate correct error return value Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250411-mailbox-cleanup-v1-3-8db541394dc2@nxp.com> References: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> In-Reply-To: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> To: Jassi Brar Cc: Tudor Ambarus , Elliot Berman , Thierry Reding , Sudeep Holla , linux-kernel@vger.kernel.org, mailbox@lists.linux.dev, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1744377279; l=833; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=kH4IpEQ9iZW8gePYNZciV4MQJ5zUzNHcIZREQLu2Q28=; b=Tnsak9jDyuUwEWWS2Bj9uMUSM4zavkCQOk1Mes2STYpLuAjEFdz/uLgOd5nvzeI/atrHEczGN ERXUgVP53+wBw6lOXl0ie+KTeYJo26BWd35ZBNh66tVfisdvz7GNjUA X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: MAXPR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::22) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA1PR04MB10674:EE_ X-MS-Office365-Filtering-Correlation-Id: fd53dd24-599c-4b64-d4a5-08dd78fafc31 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WHZvdGI1bEc3SUVrcUM2bEQrc3dGbk0vbS9hUkRERHcwVTFGZGR2WlBxeU9L?= =?utf-8?B?SDFzNTFVbEVnK050SXUybUNhNVFadzRjeEJBMnRNVTNqV0NISW9KS3lGdGFy?= =?utf-8?B?WmREN2pLWjg4TUdqZm1ocGsyaldRai9rY0xOZzhVdGs3cEZrMUVna29udGFo?= =?utf-8?B?VGRsQXdPL3dzci83Q0JzckU2TUNsQUlKalUxZi9KamxMd09qNlZqSXUwMzlO?= =?utf-8?B?UGNzaXF4cEV3NDhKSGFzenVkNTNkVFk0eFk5M0JYU3FsZGhmSVUyR2dmSTFB?= =?utf-8?B?MDR1eUJESGVTbWJyUGk1MU5wT2NrbElyMm4rTjc0YXJITFJuMGlqazVrZGZU?= =?utf-8?B?WU5DZ1hKdmFVTXhWQ1J5L0JmcDZ5RUYxUlVCbE0wRTQ2dncySGJwb05WYVlS?= =?utf-8?B?cG5RZDVEQVhiTHFnL2t2c3p0UFZqY3VDR080a1dXTWc4bGJxc1lFQkE4ckZ5?= =?utf-8?B?M3NEcWt6ZEcrRFUwRnhLeUkycXNNczduMC90RGdJbURBSU01ZFY4bkFFV0h6?= =?utf-8?B?TWxkWkQ5RFQvUlUzM3NrQ1FwYzdGeGVsUDBwU0pRY1NiTHdHSm9qdjkzWXYw?= =?utf-8?B?Zkx3emdCL3A3ZVRMMDhWU1FsdDNJMHBUbWt3Wnpsd1VncWQzcjc2MGVuSlp5?= =?utf-8?B?OHd0ZXNsZGJ1c2dkMk5PWDNRZEVSR2JuN0RjRGQ3dFovN3lnU0c2bE44bkhC?= =?utf-8?B?S2VPMWlYbVM1R2ZWamM3ekxtUDNHT1NSTFI1UkM3ZHRsUnE0ZlQzQVhkOFQz?= =?utf-8?B?UE5KdS9yNUZUQ0ZzVi9MZGJpTlFZNUhCTDhRZ0FmVzNFRXZYdWxLK1g3cW1h?= =?utf-8?B?RHdlclZwR0NIUFBiTVd3S2ZVOXBtczNObWpYdlI4eWJTcXRyN3FPV1IrRWlw?= =?utf-8?B?Q2lUTlhFWUlDL2FMZVppcys0bEFzd0lIZ08wMk5YelhMK3BoQksrbjljUjBW?= =?utf-8?B?K1NxVGV1K2VCU08xMmQ2NDkzc0VDZE84eU5BZmRMWStEazVNZ1duMENuR25B?= =?utf-8?B?a1ZLb3dUcUU0YTY5WEp1akx2emJEODNpYUxsY09aZGt2Y0lkZVFQMkJpVmV2?= =?utf-8?B?ZVRDM2ZLSWpjRHFrZDRML3UrNWxwZmxpS1hiL3ZPdU9GVHdZUkphOFpFc1o4?= =?utf-8?B?bktVRkhMZ2hWTmFrRFRRV2tGWlJiUWpLVU1OUWRMNk9WRE5tRi9hanlxVUJL?= =?utf-8?B?czUwVTZTNm4vQWlON3RYdURrYkg3U0Jnd0l4T0VhQ3JYcEQ2bk1PVnU4TVRZ?= =?utf-8?B?VHQ5aGt6SjI0bDBOWmhqQnhjRVdzSjBHY3pYM2o2OEJYQnhmcThjY2kwK0pV?= =?utf-8?B?ck9vR3VVUlF6aWRlZDkvWEhOOUZQejNuY3ZXalFYM0ROdFdzbWRMZDlsaGJD?= =?utf-8?B?ams0enBTWXM3NUlxY2JBY1ErZXJHU0NJOG14WHVZR0VZbXFldlliVmdtVjNh?= =?utf-8?B?bm1TemhwZ3VjMDNMR3A1cEtVRFgyemJ6NStiWnNKbUwzTms3cFRTM0pVc3FK?= =?utf-8?B?M3doYWc0YWJKUU1SV1l2SFlvbWRIeGNUNzExZGVITlhIalRBTEhRZWFmMHhl?= =?utf-8?B?QjJpTDVkckFYMTNCb3pmcTJCR0Vna1A4akx3TGU0eTFTTXdHSGpjYTM3TW0y?= =?utf-8?B?RUx6MjVKZXpGYUFUOUNJN2lPY1JXZTVSWFlFdGlQYlhXQnNveEZ3L1FvcGZO?= =?utf-8?B?S0Q4c2RqbUVkYllBeGZvbnd2TnZQWVdWNk9ZUW1YWUt6MzY4bnBxTnREVmJV?= =?utf-8?B?TzRxcE9QeTdxaWlPYWRiUTNLcnFhdkNuSjVEekVOdW9GeTdyOHdBK2d5c2t1?= =?utf-8?B?TUJIZVh0ZzVvSkNuanYvMm9TQVhhNy8zUXNnc3lhaXZmbXMzUzNnTllQbGVS?= =?utf-8?B?TnloUFRwT2ZkalovVHFQaEhib2xZNTBzeFVEZHNFeVZ6aTNVaHhyQUJ0cjdO?= =?utf-8?B?OVJGRE5ZS3FjQVp2OXBzWlIyOHBhNFczWk1TUHI2dG5CN0g4V25TYVJaenI0?= =?utf-8?B?YjE2VVpSWjhRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nm1XV2ZaVlRqR0crVEE1Y08wd3VYaHVBVjJrVkduamtDa1k5TC9CcldSWExX?= =?utf-8?B?QUEvS1NIbGZQUkFKcnpDbE5yME1wazZ6U3NPT29MNWJBREFEYWplNUNhZmFN?= =?utf-8?B?SDQzZE1NVk9seWZtcTAyelV1WDVqT1lVQ1lsUFVtNzdjRWp3SU9SNldzQzFw?= =?utf-8?B?UGN3N1FYbDMvdlRuaTlVUFZ0b0Y4bWp5VUY4RXh0TktuTmNhaS83VFdLbzh2?= =?utf-8?B?NWdtQkFHMllYS3lEU1BzbVVlMEUyK3QwODM1TUZKMUJ2c0Z5VjBmVFpjTjZG?= =?utf-8?B?N1FkanNXMVBPclNRUHVGUXVaM1VIdGRFbVR0b1lKQ3pmc0lWN1VsdTNIUGFH?= =?utf-8?B?ZitjZW5odkFaeHB5THJRTDFrWTUxaGdiWm9LSVR4THoweUNmUld0N1JnRW1y?= =?utf-8?B?QUpwWWt4Y1VQZXZvWVpGZ2lOeCtBYzVHWUNucUc3Z01lSy9wWkRHS0hLK2RS?= =?utf-8?B?aEVubkUzd2Evcmc0TWd1bUVMM0taMm4wTUxwblpsZnhrNTYwazR2U1MrOFRa?= =?utf-8?B?WXU4L2I2ajdhV3lML2sxM3pDQmZXbTNSS1VrWVVXbXQ1aU4veHF5bG9zc0dY?= =?utf-8?B?NFhZamhSc2NEQkhxQitscjh1ZEFYQ1lCWUtLV0FEOFk3bmxnQURJUUEwZFF1?= =?utf-8?B?Z0xUWE5tdi9iM25VK0EwT0NpZjB1TVNnUHJjUmNJTU1sQWpzbDN0ZWNOcHV5?= =?utf-8?B?MXFpbVQrVUJLWUZZaHdjTmt6bUtSc2dFVFNUb251WGJLZkhCMm9CajFOSjFu?= =?utf-8?B?L1VHR3k2NEE2Nlphc2pTaC9BY3dWY1RhcTVVa1VFRFpTTnpTMFkzbVUwTUxn?= =?utf-8?B?YjF2RWUrM0J2azFWTGozVVdWdFNYSDJjVWZvaEpLd3pnVWkxSkFCVndQdGVa?= =?utf-8?B?cmM3VjVETC93dkJkc0ZhZzNPaFl2YTNOTldjUm8ydTQ1djA1NlNua3RHZldC?= =?utf-8?B?aHlKQnhma3J5Vld2NXRLdFRLTjJIa2FQQmZHbnZHTVZXQ3JCYnVJVzNMODJn?= =?utf-8?B?L2IrTitRc0hURzdZM01Za3dJZFcxbjYzSEJmdEtQVFg4bk5VQkllWjZYaWpu?= =?utf-8?B?YjFaSVpNYlljekhnUVZSaVRnRU16bUx0OUJSamtub2tYb1RyTVRtQ0xoZTlh?= =?utf-8?B?bEVvVHlwWjJQR2VlQmhwS2M0K3F4NGJldSthMGtNVkdNcU1qUFR2a2QwSnFE?= =?utf-8?B?OUJjTURUcXRZSWoxUWlzOVBHMDR3LzVDRHpHMHMrTGczVEIyU2lhUnhNZzRq?= =?utf-8?B?UUZSZExON1RNOVIvNzJCVE9Qa0kyOStOZVcwQ2U4ZGw1R3RQclBTelhZWmdq?= =?utf-8?B?a1hjQU1veEFocUU4QmtZTElkZU1YT3BDajJBVkpPU3A3T251OUN1ajBBZUJW?= =?utf-8?B?RnBjVEFxcTViY3daYW4wS3hRMUcrMnBFWUhLZUo5aFNieUx5TkVDZHZMMFk0?= =?utf-8?B?TjVOOElPQ0c5djNVUUwyVVExNzZrMUtXeVVDaXJ2SUdtODN2YW9Kb3BDTlBQ?= =?utf-8?B?Wk5nanV3SlZSWDg3V0JhV29YZ0U1Qm9EVWpGRWpIQURmL0Z4L1JVY0hWOUhI?= =?utf-8?B?QTc2QW4yL2RwaUVVeXliTzVIWjJSYVJjcDgxTk41aysyRDJuQS9sRS94SjR6?= =?utf-8?B?bFZXS1RNb2NoZE9rZWVpckhoTnJCb1BnOENMQWw5bmVzSkZMdTczSTVCTm9q?= =?utf-8?B?NjNqWHJpQ3BlWElod0hvK0dGVTdVSEhaRmVZNUoxWXFxYjZMbmJTcVZsNUZl?= =?utf-8?B?MHJzSEJDdjZtUnBOdXY5a0llVjhxMmxtamhUbG1UejUyaXNjdG9IMjlDY1ZT?= =?utf-8?B?VVg0UzVvV0U0ZlNGV3RCT1VmVTZVc0c1dW1CbU15OUkwbFZVK3gxNXpEalY3?= =?utf-8?B?dnNnc29POExaWU5GTHJjd1lOM0pnMjBSZEZsZEFpQVVSNEZvS1Y3ZDN3b2k4?= =?utf-8?B?YnN5bVlRZTNxcWtWQzdKZFhZcVdpT3pWOGhOQ1RRQ3gxb1ljOU1adTFDK080?= =?utf-8?B?d0RJSDcyVE0wTWQrelhFcmIrcWNUcGNBYlIwVVdFMjE1aDhUamhDMld6Y3V6?= =?utf-8?B?QXhMVi9RT2JZK2VrQWxTM253UnBtd053dmR2VlBDNC9ZOVRXZzNUSWowSGtJ?= =?utf-8?Q?IUHPfk9tHeBhL2zzJ11/595AL?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd53dd24-599c-4b64-d4a5-08dd78fafc31 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2025 13:15:52.6488 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Th1H3lJe1lJ1pyQLRJKFfdOcttn5SXvGye8pqMmSoT67XrC2Qn0NsKp6sMbftQYsmmi5l43YyTPiuqXBgFA27Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10674 From: Peng Fan In case of_property_match_string fails, it makes more sense to return its error value to caller, not force the value to ERR_PTR(-EINVAL). Signed-off-by: Peng Fan --- drivers/mailbox/mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 3ecf92a580fef031d8add5e4c2e4df494a34010a..3a58dc56f015b0bf0ebc7551713= af38c16439e11 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -458,7 +458,7 @@ struct mbox_chan *mbox_request_channel_byname(struct mb= ox_client *cl, if (index < 0) { dev_err(cl->dev, "%s() could not locate channel named \"%s\"\n", __func__, name); - return ERR_PTR(-EINVAL); + return ERR_PTR(index); } return mbox_request_channel(cl, index); } --=20 2.37.1 From nobody Fri Dec 19 09:44:12 2025 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2074.outbound.protection.outlook.com [40.107.21.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FD6C1DB546 for ; Fri, 11 Apr 2025 13:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.74 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377360; cv=fail; b=UylwANMCk/6YbMripbNYkUuZuMOVxWz/vw39F5DetuEi3hWfywg/fyi3ib0D5Vc3NvdF5hQ0dbHW6HWYRsJAi1u+0dN5VFL1+OhYU92KaIcnFJ/Xwg5VFT3oWONgl1J1XFamU01r5lyhdFjXU/u3Hu1gwqGeGZR/oZn5fxz3xLo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377360; c=relaxed/simple; bh=Bz08zFquicGFTPgoFwsIJ5cJrT3TuvXiW1PgzqKh48c=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ROCX6hmuz3jaQFjGNlL4zdkcc0Mf/36wuaEmHQu4cl8b9YfOQDyU1OgvjTBNfmyMyNjb5wjxsnASJ9aEqQjaSAuPOETQhZAUrMCf2hSCKd2KWytBtJLRLdf2/t9DOkCj0UDIVmp85H5Bq/8pnFNTB8jJmvoXi9s11nHNPzdVxdU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=aPVr3HuH; arc=fail smtp.client-ip=40.107.21.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="aPVr3HuH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YhJiufF7b+SG9aqyRPf2UDzNgRQZUi53gepGMcdiI4ITtEipRpM0CjRRkDe6nN1kcy1ItLISM7aU+MZVoi/R/P6fdzwXCdWfQdPKmUNyZ3vIDa+ApURPG1CsBWNixSZIAJwD+AOpVmDM3i/GyUK1GXHBR07AjZ29MTFpUApkNZEF8ZHbsQTAb1+5A6ymLbj3d4CbXQgQ0VfmQtnENJFH2upsyMYAZHfle6o1Y43cwnBcZl5gdRXjgDe6pShMF3DOB6NCqmRowCJWy5/d7ZoGIMhLzjYSSaR28XDj/0W2SffPg/NeGLzUlcej4MIhhSrWXByLaSMlvzMEgfcHNEZuaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kTHV2qgU1prfpwBDa963H3u8WNnRC6Z+uZ/cfEsZAvA=; b=KCklGYOND7TIE0WE6myJcb6nsx0PgyJNfRLZNMN6/TvdxWqtDUi5EXi6AUZ3HHohr//1+szTaVamMgwMFWSMOhl/NqwE+MhV3x9/o+eUuTQFVJVLqKd7L/SCZBtQ2Rv/bhunbbeQpEsJndfwKI+Kl0VcHeSzFiKRbZa95W+L/kOvCybOBsTmGy9pvKzcrHeGEdcx2HIXT/972xJBv2zFNPJzcrDyS2eO1pj0L0sFKj6pip6TywurEgnLSJoKymfECMote5Qn3eJo/4IUv+mBGdRpZEYws9sFcsSM8L7J4SX1Wg+57xlD3OZ/UXnu1EDOzCL8RijgFrfFhP2y9jkx7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kTHV2qgU1prfpwBDa963H3u8WNnRC6Z+uZ/cfEsZAvA=; b=aPVr3HuHx9InmZ34VBNBZJe4skszjli7ZQZU46VYMySqsOV/EftfoLYYXYKrV6b9etf++dVxDkBoBqzA5SciAMuzIWIAw8nvJEJ/YdDCfa4N+9qYTMlBRxRFSgg3gVM/rD3OuYWydDegl1h+OWgll9OB78xZjKUoZuZQFdzMfOd6jQqD0ESyt/j3XXUUvxHc49YBqflnJzTVkfAhAG9t1PL3395gBv/zZEgnf/WON2krr7otZf5rYbUzDsayfQqCQxR7S/KhzWqKwg8AHwnN1riaCsq/B962tETc1L+OH6WPWR+rDRL+61vZoeF4F7QU2lGHU/NcuGG7pf7A0Uo6Mw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA1PR04MB10674.eurprd04.prod.outlook.com (2603:10a6:102:483::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.28; Fri, 11 Apr 2025 13:15:55 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8632.025; Fri, 11 Apr 2025 13:15:55 +0000 From: "Peng Fan (OSS)" Date: Fri, 11 Apr 2025 21:14:12 +0800 Subject: [PATCH 4/6] mailbox: Remove devm_mbox_controller_unregister Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250411-mailbox-cleanup-v1-4-8db541394dc2@nxp.com> References: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> In-Reply-To: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> To: Jassi Brar Cc: Tudor Ambarus , Elliot Berman , Thierry Reding , Sudeep Holla , linux-kernel@vger.kernel.org, mailbox@lists.linux.dev, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1744377279; l=2656; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=qTUZX6uQuNoQ4SfjQO/8uSs1vqq9cmt7z8wr+U8spb4=; b=sg1UOIQUU9oiWSI4OznC8vBAKJhl3GWinLnLDik2qzbP7ctvh4tw9w/+7KV94Bzewt5SCMLLa SkdjJ+w9e8GCfN4EJTNhJJXFkdv6sUoMsOsZF1qqdou3lrU5kKZiSvW X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: MAXPR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::22) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA1PR04MB10674:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b5d2892-ed3d-4fe6-d94c-08dd78fafe08 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VWNrSXlOZjZsc2lFUnFjTE5kWFQwSFhKM0IzSThWVmdDRHpsQ1BYbStBZFNM?= =?utf-8?B?TzQyVHZEKzFiR3FDQzNPTXNxWk4xc1E3WlJnRlo1MFFlR2x1Z1l0dHpJVk1H?= =?utf-8?B?SEVCMmxqWEh6ZklzT2Ewb0tHU0RneTVJSmdWWFlGNkxwNks3TWxBM00wSlFC?= =?utf-8?B?a1BVV2RtclM4SDFFdS95L1ZvWE02a1ZSc0ZTMFJ4QkJ5OUZWazBrRkI5eURl?= =?utf-8?B?THVwY3Vocit5cGI2bXlxOVdxbXh1d3piNkRoMUREaWtlSkNsV0dWV0hMYldh?= =?utf-8?B?bmtPY3Ywb0NYbXFYQ3FYeTNaUzY2QllMd1lIUCtHREpIa0VjL0QySytzNHV3?= =?utf-8?B?ZUtNQWxPcGVhM21YNVpPMDVFclZNWC9SOE5DQVk2L3ZrZTFreUZMb240a3U5?= =?utf-8?B?N2xuRDJiWmFZc0JwdWFSN1Zwd3NFOGhOMyt4MURCN1Yyb2pMRld3Wi9nbFRw?= =?utf-8?B?SzdUcUFyRHJjWlhrWmVoOWdiZmRUK3dodXNTTTdONHRGUEkvamVMZWJNa1FZ?= =?utf-8?B?WkRYVXRaOXJWcjRnWGlKTjQrU2xjdHVSSTZLYmsvcnNnb01pMDZ4WW9heXRS?= =?utf-8?B?a0w2a3ZMRmdHNVg1VXN6ZTZQZVIxNEZYYjBsSExvWHFBU3NLUXVyNjdNSkQ4?= =?utf-8?B?UXpLZEpUT3Z5aXE3L0NIdXVyQ1VyNjdWQWZNWHdYazV5bVJtMWtrTzhXQWlN?= =?utf-8?B?TjhjTGFSb1FrZVdZU2xOWDhzM3ZvVzVaalhFZVlNbkxuNWRhVVpRR0haSmVV?= =?utf-8?B?b1NNcHFiZDVyb3JBZDMvZFoxeDE4UTg0cEd5MlBwcWUzTjd0eWIzazVQbUF6?= =?utf-8?B?cEM1N201VkV4R3F1bXlWMVpmRnNlak1meGdZb0VpWjhXa1dzRG0xRUZyU1Jh?= =?utf-8?B?b1Evdy9xQjFSaWRkeURCa2RrQkJzM3ZwVWxyTjhwQiswejVxbC9lai9wVXJw?= =?utf-8?B?NVQrRmdSL2RxbnNPeWVrdnZLSHErK1ZNTEJkanFEVFVTcTlnZTN0S0dZZ1JM?= =?utf-8?B?V28wUit2WTJ6ZDhvaUNzaklqamFjalhnTWVqNnBBUit6SlpYVWZqaERiQ3ky?= =?utf-8?B?MUgySUpLQ2cyakp0L1RQTXljK3pveW5ZclNmRUZrUEY4NWJJSDloSHJJZWlG?= =?utf-8?B?NTQ5dURhRkRTZHFYaCtzUTkwRG9xQnNnQWxjeHpTWHhYRmYrQ0oxbVVxdUNI?= =?utf-8?B?eGx4Yy8xTG81bXRZSVNDR2JEdkQzY2loSFd2Z2pZckNOaHJxWUhUVUVRalk0?= =?utf-8?B?QXVwcG1zTDQ3UEJXUmI4bFFlOU5rNnRLZWg3clFDZnRaOGJTREhCdmJvYzA3?= =?utf-8?B?QmpQV2I2YktrNm8wejB5MmEwM1U5UnFkeWdoK1ErdGNJdDBLRW1WNjhrbnlq?= =?utf-8?B?aEhrRllJSUpLNFk5cS9VMmlDbVN0dTIydmtrTWlDVzI0b0hMbWJ5TEh0b2Fx?= =?utf-8?B?WEtRVEhURzRKRytwK241MmZlV2tVa3gwekxpY2ZPT01OaXlCZWJ5REROamNx?= =?utf-8?B?Q3FTTWdLMEhqVHdpbExxaUVkQ00zSWdCVXlaVk1CdGZQKzBidFpETjVDL0RD?= =?utf-8?B?Vkc0V1YyeUhWNFcwMStvZVJlQmVoWnZKNU5Za3o1MTh2RTdod0NkOFQ1cTdu?= =?utf-8?B?dXAvVVQyQml1dFVqeTZNYXZqQjhmMWpuQ3FxUFpBdlR0UnZsdVVJaG04YlM2?= =?utf-8?B?Z3Aya1hhVjJhYitlR3lzMHM1T0FOa1NVY3d2M1ZQVzIzTFIzRU1TZlNpdDBC?= =?utf-8?B?aE1GZUU3MTRXcmJKOWdaVDVkeEw4ZHBDWUcxTEpPUnpObUtsTU5jbEdEY2ZL?= =?utf-8?B?ajJENUJja1RrTk5SeTRvT0ZpREhLQ3dvWDVKTDMxeFd5UVhIM2U4blJZUFly?= =?utf-8?B?QlJTcmpYcllMdmFkc2VsRXJDT21iMTQ3M2xZeEk4TEpyUS9VUUlsRnJxWHZa?= =?utf-8?B?N1JDRWlpYzhYNml1bHh2eWlBTDllQzM2UUxobkNoZUZ2bDBIKzdxSEY0eWNR?= =?utf-8?B?Y3lCdkRsYVJ3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWRYd2xsM2NlZ2loVzNDL2g3cFJQZjlxSGtVaDdDMmY3L1hROXAzMEw3MkNE?= =?utf-8?B?NXhmU29Mb0lqWG5reThTVnJOSjlIOWxGUkFMajEzMWJIajlZc0ttbjFnZ0o3?= =?utf-8?B?UnRYajk2U3VJZGhxT05leXJGZEpuSy9YaUJFNVNVUW1NOUNvZTd5a1dDSWMy?= =?utf-8?B?NjFGRjh6MllES1FEczIzdjlyeHJuQmNjVXN2Y3AyV2FuQXErRDZGZWpEd2J1?= =?utf-8?B?RDNaOWlTelRwTGZsbHpHUXlrek5aVEppVGY4QzdPSWxoTTltY3pWWEtxTUxk?= =?utf-8?B?dEtodlFJRWJybFgvUkNZdnFUa2VlNktSV09kMDViL3hlcU9OeForcWhIRkds?= =?utf-8?B?eFhuOG9xWmhwUDlPejhSdHZQSUhpWWFpbC8vNUZrMmxjWHh1YlJLTXh1YTlM?= =?utf-8?B?dGo0d1pTRW5SWEJvRHFuUTg4MlRQM0V1WXptVUtKSXpZTW54RmJkamNTKzNw?= =?utf-8?B?a3V1dFliQjlNUmVzN2svRTFDYjlZVTNmRmtYVGFDOWU3MWt1L1N6cG12T1k1?= =?utf-8?B?bitnOUhsU3ozVGxiYXVWL3ZpV0FLeWlXdFRsRUNXdzB0RlY5RG1pY3FHUkc1?= =?utf-8?B?ek45MnRiaXorTFVjcE1pTjdzb1dIUFJUZ0YyVnVyRy9zalArWk5tYkl1RE53?= =?utf-8?B?Y1JGNFlmV29VVG9qL3pCZjE5RUZkZ28yNHZkTXlUN2hwaHdsd21zNVRmV1A4?= =?utf-8?B?WGg5NVFkOWQvUzNwRk91cmxCT3N0Y1EyVUNhOFNpTENaRjJpbEk1Q1JEdC95?= =?utf-8?B?N2htK2FPbE5jNmhqZHlWSFJzdTdLalk2cE1GYnBTK2hGS1VTbW9xSlJwQmsz?= =?utf-8?B?dXFkNXRaNGlHYy9jZUVyRHZxeCtmMDZkU0RlYVZaNmZxTVhEeDY3SVRZNDh3?= =?utf-8?B?MDNqR01qRWZoNC9FVnplYlBaaTIyMnllZkkxc1gybGgzMm9FaFpmQVY5U0hM?= =?utf-8?B?TEFrSkFqVnpaclVqUkNhbTFkQ2Y3ME9qWE8yWENYZmlYS09HOFN0WXM4Mnds?= =?utf-8?B?RndDMEY4UEc3b0xFR0JQYndrUzZuTDN0a3dPbStBM0doVlIrVExZcWRodkMy?= =?utf-8?B?eUhiVjU3VkR4Q0JhTHAySG9wMS8wYms2MnN0cUduL3F6UERnV1VJSlVsWWF4?= =?utf-8?B?UGw4bzBZT3ZEaTJ2N1oyZVp0azhOTUU0VUNHT1ZvcUxKdFFZUzZpVjNxV2xJ?= =?utf-8?B?dmt6akl6amhSTExMTFFaQ2I3N2d2TjVQUS9ETXcyZDhnSzEvWUxaY1V3aGJI?= =?utf-8?B?eFh6aXN2MW01OURaV0hOWldhTVVGZGlSd3FJdlYwR0ZYek5jKzZ4RFF3ZjZa?= =?utf-8?B?a05rd0ZHVEJCVS9jL25jS0FNSVUrTzZROUZ4b0ZzZlE5cGNnQ2xjVDhQOGVT?= =?utf-8?B?Z0o2QzVZMVo5bkRNNlN4c3lzdlNHakw2MVFKdmdnMENFVDBSTjdDNEZyR0dW?= =?utf-8?B?S1JzRDVERGwvOU1nZG9haTYwUHZLaVAvQzR3M3NxQ3Ftem5vYklpK2hTQnoz?= =?utf-8?B?eUNnZHlUbFBKdUljaWRCK0pOald5bm5RYW5uSngwRUt5VlFsalp0MTRqWHpE?= =?utf-8?B?K0U5TVdJUEkzTmdVUHVtQVlnSHFFRUk2SHpES1lZSzdsNnhaQVNRQzRPbEpm?= =?utf-8?B?dmd2NkE5TTdmYTQ2S01oZS9QTVkyTU9xNEE1THlKMWpBRmQ1RXlvenpYV2pl?= =?utf-8?B?WXF2MHV4UldDc3J2MGZNL2dlTHpwVnl4N05uYlVRWXdhMVVUMVJCcG82TTlW?= =?utf-8?B?S0NBdHJCY3BKVlFkSm5jV09ncHQ1Rkw5R1FIVVlDc1FNbTJ0dzJIOHVlUXZP?= =?utf-8?B?Y0lKRnJCWXZvYk4zZDZMTHlNWTVCR3hrZjlWa2hncGdwZGlRUVZhNG5QZGJD?= =?utf-8?B?RFdnYlI2MWpVUXNaMzhWcDVpZGpGeklHRml4dUF1a1A5QWp5TTB3ajhsT0JD?= =?utf-8?B?R2VJbXRqeGUzakN2Mi9XL0kwZ0ZiMDVGamxkVmh4WWNFQjNqV2RyeS9hNWNS?= =?utf-8?B?cmZnL2h5aE1UNzh5SWdLMlk4T0FFYzF2ZytQV1hQY2FNL3BKdTRVVDdub1lJ?= =?utf-8?B?RFRWcndxYk4yOFRmNitvZzdzeU0vcHFianZKODRVZzgrcUFmM3dsVzZadUY3?= =?utf-8?Q?fyGyMkicKxkFc/zZLz0SmKFdL?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b5d2892-ed3d-4fe6-d94c-08dd78fafe08 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2025 13:15:55.7212 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U6U1VcGH5/cZXonEUCK91H+aW5kmzIO/GQXQgeE9FDO0bR5vftgAKdZXzdCc/E9NvhubGIiWRc46faEyudnvJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10674 From: Peng Fan Commit e898d9cdd3a9("mailbox: Add device-managed registration functions") introduced device-managed API for mailbox, but in the past 7 years, there is no user for devm_mbox_controller_unregister. So remove it. Signed-off-by: Peng Fan --- drivers/mailbox/mailbox.c | 27 --------------------------- include/linux/mailbox_controller.h | 3 --- 2 files changed, 30 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 3a58dc56f015b0bf0ebc7551713af38c16439e11..3c3bdf278b8e729f494b0e61c00= 8b63dbc4f9344 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -587,16 +587,6 @@ static void __devm_mbox_controller_unregister(struct d= evice *dev, void *res) mbox_controller_unregister(*mbox); } =20 -static int devm_mbox_controller_match(struct device *dev, void *res, void = *data) -{ - struct mbox_controller **mbox =3D res; - - if (WARN_ON(!mbox || !*mbox)) - return 0; - - return *mbox =3D=3D data; -} - /** * devm_mbox_controller_register() - managed mbox_controller_register() * @dev: device owning the mailbox controller being registered @@ -632,20 +622,3 @@ int devm_mbox_controller_register(struct device *dev, return 0; } EXPORT_SYMBOL_GPL(devm_mbox_controller_register); - -/** - * devm_mbox_controller_unregister() - managed mbox_controller_unregister() - * @dev: device owning the mailbox controller being unregistered - * @mbox: mailbox controller being unregistered - * - * This function unregisters the mailbox controller and removes the device- - * managed resource that was set up to automatically unregister the mailbox - * controller on driver probe failure or driver removal. It's typically not - * necessary to call this function. - */ -void devm_mbox_controller_unregister(struct device *dev, struct mbox_contr= oller *mbox) -{ - WARN_ON(devres_release(dev, __devm_mbox_controller_unregister, - devm_mbox_controller_match, mbox)); -} -EXPORT_SYMBOL_GPL(devm_mbox_controller_unregister); diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_con= troller.h index 5fb0b65f45a2c2ea987bc307758af1e6601767d5..ad01c4082358648c4ba51a7f735= 54bc1bbf80c78 100644 --- a/include/linux/mailbox_controller.h +++ b/include/linux/mailbox_controller.h @@ -134,7 +134,4 @@ void mbox_chan_txdone(struct mbox_chan *chan, int r); /= * atomic */ =20 int devm_mbox_controller_register(struct device *dev, struct mbox_controller *mbox); -void devm_mbox_controller_unregister(struct device *dev, - struct mbox_controller *mbox); - #endif /* __MAILBOX_CONTROLLER_H */ --=20 2.37.1 From nobody Fri Dec 19 09:44:12 2025 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2074.outbound.protection.outlook.com [40.107.21.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FBC91DEFE1 for ; Fri, 11 Apr 2025 13:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.74 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377363; cv=fail; b=rm2EwW14AEgZfJa81txp17dliVjGq9G4FZGJFSieYeQfAsdQvXgJm+xfqmksCNQDrK+I+doRgGdwwBZyhbgYFWQRyMJ85CNUhjRkVtJ6OnzLB5s8F5paczM/X/dKz660Hj2qDUex8CSvWDeJRVc4J+rlyYdlRUwQ0RyVWVsavg0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377363; c=relaxed/simple; bh=qE0clyk1dzQxtO0OQ1Wy1u9YSda03bJ+9FPAgTj8aL8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=brIVP9klfRM2NYFWOab2w3tVeGq39KwW19Ij+ERHFP7BV8bb88cbghQKE1SrDauh5uKH7r52eJ77vnwlqMbHJ/tdVQw6385nvchHkhim+XfJIfGf/npSkF9pwrpwGS7tDxYtWM9kC0MMo71yDthNswyrpJydZE0HyVvL+T2cDmc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=aUKIM0Xk; arc=fail smtp.client-ip=40.107.21.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="aUKIM0Xk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jGRqiFRkG5zyEim5036j2EtErz+Psz3G4BSdUkal1fvjzJm1CndZ2evZTQrKs6whLdK5f/6avDSHCoDlWGFt630sW/dk/Ds3G+y8pk9dsiy5hVlqGgQVB8tUdxOyWFTeGbqbGehM1EtKMjQl6jCPuPf8CgVYhNWvbnGcNrqQJRh7n+zisx+9LHGaS48cOXfoVFF8covytH5QuLndz+7XdnCzguFX2afpro2qhRjIzDVNouFi5JWWxR8SQua26688F7uD5eNdoSXNCxX6FVFgkBK6qMWMSC+BpXqVUbwioErHoxDz6O8ib7GRMMCTM6Gb4O4Pd3XwMV8eeyD8ps/1lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Ek9PlQL3L7F/GT5aHQ9Ql/XYFXtYwJ848RD7txB0GQ=; b=L+U7jUep8xJ573lStgyyvvaZ5XvEJmcz5L4h3XpVBx/jwqdRf+8jna0e47zrJvJX9VJDsJq9oQyRynLnNypjkrNhAkkOJ6W6qzKC7BopRJSUaKPgv2KDTMshP7AqNHuljR/Mkvho/m4xqT9YE4VghUsu/nDo4JPTwWqCFO8I+S/TywvowwkVFoDeEe+YRZrZWqBBaGoeZkSnwjq3xfzu9iZ5M0fCUc0aXi9Isuoq5eIPkejWvadSuZMbIiCWqKankMUwhsuSerK1ORQwxaR7lBz4hgIEiT9VoB8+Fe0A5bpKA6RGqZMumX7uRbzDdUWa4wEf35ya7q0zXMvYZFUX/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Ek9PlQL3L7F/GT5aHQ9Ql/XYFXtYwJ848RD7txB0GQ=; b=aUKIM0XkQGxW67Xo0SzER0R63ZwG0c1x+XL4fBW0Ff+e2UslhkKnE61VfXcZVHv+olHf5Y1IM2xBgTESFU1M8QybUf6Q6iiioCL2iV5olEOcIfqetwzvQyd1x48c7rZLe77HmHT5V8FDr0lntIu2ISv/LfJKo7oCRt7jRFYZCYs+J6D4FJiFKlo1KFUzKrTxEtq/9uEmPsMTOUXBPCpRDWcq1A2IomUHZojmQXa838uD/yoCQ5j7xaQj9+hrtwicSV+yarALO56L/eWKnZ5d/f9s9ZevQ7fGpNb4alItSIEFLxz6CYKlgMhzzkYQKJ/RNE3sQ/1YiMfv2l0b94mvRQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA1PR04MB10674.eurprd04.prod.outlook.com (2603:10a6:102:483::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.28; Fri, 11 Apr 2025 13:15:58 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8632.025; Fri, 11 Apr 2025 13:15:58 +0000 From: "Peng Fan (OSS)" Date: Fri, 11 Apr 2025 21:14:13 +0800 Subject: [PATCH 5/6] mailbox: Use guard/scoped_guard for con_mutex Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250411-mailbox-cleanup-v1-5-8db541394dc2@nxp.com> References: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> In-Reply-To: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> To: Jassi Brar Cc: Tudor Ambarus , Elliot Berman , Thierry Reding , Sudeep Holla , linux-kernel@vger.kernel.org, mailbox@lists.linux.dev, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1744377279; l=3115; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=r0VYGdsKbpTESeFSS5JyC7sEdaPJ+c5WRhpXb4zBr/I=; b=sUx1TVg/qmjp6O85mjCi88OAfDTekjeAlVQJKgULHJmvQfOMXN0nzR8WvcanRw3xzbpabBFp6 wkNXSne9OYhB5Wg6SK8qIiJYR5I+WpD3pwh+rtl8tqS6ZJZTiIC4rWK X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: MAXPR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::22) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA1PR04MB10674:EE_ X-MS-Office365-Filtering-Correlation-Id: fd5ec770-8899-4e9c-fd65-08dd78faffd1 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Tm83Q1VqeFd5NmdqNlZwNVFyS1c2WDloNlYvRjRDRWEyTmc0WnNpTDZBSHJs?= =?utf-8?B?OU4zc1lPeHgzK0ZvVndkbDRLZEdpd3hydHdjcForbE5Ta2l4aVdIL2lYaVJ2?= =?utf-8?B?cWE1NkIvV0k3RVV1MGFZV2xCcUxEOTFRWlY4U2hFM010RlhHWm5rZE03d1hS?= =?utf-8?B?MmdEd3hjWnVIK3F3VlhEOXJZRjVta1hiU0J4dUtSZTcwUzkyQ0ZkSHU5QU8x?= =?utf-8?B?K1phNkR1cWVFbnZHeXFSNkhUVmdEMWliaVRiWXdoMWxyWmxLdDdabmU5TnNH?= =?utf-8?B?cmdDMFRBb1JZRkllaTVoWnE3S2c2QnZjeTFEd3ZLWTIxZXU2VytrWVZ4anY4?= =?utf-8?B?ZWY3MnFkbTVveXlORjZlR1lqa0JxWTh6Q2VtQW9LOTNSSjBLNXJMVHNvaWQ2?= =?utf-8?B?ejV0UkcrSkpKcEFJTzd6MlNBMjRhUFhOYjdDYmtXTDBHTXBuc1ZBRHNjVkFs?= =?utf-8?B?dmRSandWMlQ0V0FzeHgyVlpDVjVzSlh0VldDaW9aQytyTUc0Z3NZZlR5SENS?= =?utf-8?B?eGpvU2lybjV1bmRFNnkwazNSYzFBclJteDZCaWZPMHRRdWgybGhhVlpLRVBv?= =?utf-8?B?U0xudzhMZjhlMXFvR3BvMkpBdW1nZGl1VmJ4d05UNzU3dGhmQU5RdHpxQ2gz?= =?utf-8?B?Y1ByTFN2V0RobVI2K21YQys5b29uN1hJaFZTL0J0S1dZc0JrUDVkUjRmMlpm?= =?utf-8?B?bW9kZnNGVmlpVkJBKzQ3QU4zL3FSQUIrOERVd01RQjVhT3RMQ2hvMlBadnAr?= =?utf-8?B?STZBL0t2YWJmOVBEdjlUQVhWaWp2cnYxYVlxL3RLZTdqOThjRmJVOWd0N0g5?= =?utf-8?B?NHlob2ZoRjBkTjc1ajc3VEt2eUhrdWUzcXROd3NsYmFrQk9JdzNYOTcycGtV?= =?utf-8?B?N2JLVkZDcEFnZG5kMzhrK1ZyaHJ5RFlBWnJrUXVOcGpQaEpPMXJtMmVlTFdz?= =?utf-8?B?LzFQdnZZUUZCNDFUVVExTTJVTmFIZEsyVDlOK2FJNy8ycjBjQXdKV2pOMEdp?= =?utf-8?B?OXZGbGxCek95N0ZjSVVJVTJybXUrMkdQNi9IVzZpakl3S0pXaEtiUUpFLytV?= =?utf-8?B?cFhNSkxQOFJrNG42cmJGYUo2N3NObTJWRDdmUEQxRVJ2RU40M2RhTzJpSEZC?= =?utf-8?B?WWh4Sm9UdVYzMWx2aDIxbkVrcEJWRjJTNXBvV2F5dW8xendsY2UvYjdPRlJH?= =?utf-8?B?bThOY1JvNWpOM3ZFem04U3BkNWh5R3ZDc2tjaTltUGFuVC8yM2NJMW84a2d2?= =?utf-8?B?a3FxQTZneUQ5WU43Qi9td3NWVzAzOVVzSDN2R2FFYXc2TWpPSzV4bjVMVENq?= =?utf-8?B?T3pITHZvSm5TK3NZRFZVclFuRVhYV0cyWWRuOWdmMDcvYWUxT2lyQUFPYWxj?= =?utf-8?B?blF3MTFzNk9KMFA3UVFETkJwcUxVcGhKVGZNc3pCWDI0R0JVeTNBOE91U3B2?= =?utf-8?B?K2JhRjhHYnpCK2pXQlJMblNmTytBcWVWalN3WkJNS0lTY3hHVldTOU12WGgw?= =?utf-8?B?ZkNnenN4WERweHB2aGRzdXM4Y3E5M2xHYllkRlMwT2l5ZEF2N3EyYlNOZHUr?= =?utf-8?B?cVhoV0QxVkJPY21EVTZkaENjN3d3SkwvU3dzSy9nMk42VHBiSzliTVBaZGpM?= =?utf-8?B?dXJxTkdCb2JhczNkQ1Z6dzNXR3paM2paZGs2VzhLWUlTY1VNOVNQNzlPaWly?= =?utf-8?B?OUt0cnpjNDZ4S0hkbnNBaGw3NUZQdyt1Z0ZHMFNIaCtaK1M4M2lJNjlkaEJj?= =?utf-8?B?M3FCNnNUdytiSnQwcjI1ZDlaTm9HSXBERnFORys0T2N3TzJkUGV0NTBibmtN?= =?utf-8?B?c1lpaDFUOWloOU8yUER1NlVqM29reXFFcGlnWVRSVHNFNk1ISGw3ZS81djh6?= =?utf-8?B?czVPbjN1NjdlQVdkTVJsQXVXSGw0Q0I5OE1KOTh2Y3B2QkRKZ1MwNkh5R0M4?= =?utf-8?B?WlpzTVBLam92djJHaU1jbndCdXYyS3ovM2lhZnd5YzYyeFlNbWk3NDU3dXNR?= =?utf-8?B?NjNmYzl6TjV3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(7053199007)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWQxQlN2NEhkckc0QlpwN1JKMGxzZlYvYmxQS2RzSllTcDZoaDZXSTdQd29I?= =?utf-8?B?U0lGUVNTc1dCdEhsTkxkUHRCYW92REF5c3dyL0Zra2hwNk9ZV2pKNnFRaTAv?= =?utf-8?B?eG0vOW56T0tKeXJSdnhTUTczaUI1MGJJRHpZbitMbTh4bWc1SFhZMERpZzJ1?= =?utf-8?B?RTRESThCM1dYSHQxSks5RjlHNXd3bDM5NTZaZWFROHQzK3ZqWUhSWitVUjg2?= =?utf-8?B?VHRNNVl2b3NTc3JJNWlmVGNITWZzbkxWUlRseklucXVJQmJNMmRvbThQbVhk?= =?utf-8?B?R3FiSzV3UC9pNTJFdHZqai9PZlRnZkVtVGRPa3dkUyt1V3QxNWliVk40VE1p?= =?utf-8?B?Uk1DUXBVSmJsVFA5a1RBeFRKVkd1d3NNZUVGVXIxSThuUUo5d3ROc1FOSUtW?= =?utf-8?B?OFZYTVZxUTNCNERORkZ5dFVEM1diQmNWSCtaQmRlVUZObmR0L1d3MzdnWTgr?= =?utf-8?B?NGZDaGlRQmRCaTJqRE1Sb2NRK2NOY3h0TS8wRzJqNDViUDVRTlhZKzM4L2pt?= =?utf-8?B?Q0ZUdHNqaFQvdThHcXhGZmZ4UVBmWUlZOEJocUZ3OERwUHZlWnExZzZiQVNh?= =?utf-8?B?UnFKaWVQQXNmam43c1FieVVKNk1mbmdQMVltT2RTUkhHSlFHZVE2VmtndDdL?= =?utf-8?B?STZtRVkzdUFMTnFKTmxxWXliTXR1Q3ZzSnZTcHpZRlRjSGkvSjdESnZZY3pS?= =?utf-8?B?LzRoRTV4QjNMVUEyUkNUYnV5MzRCUjRuMmRTTzNNcFIwSVI1Q0dRTGxZS0Ni?= =?utf-8?B?L2JhOU82RkFVb3N5eTV0YXZaZjZxSnE2b1Y3aUwveitCUDY5NnlsMGdhaVZK?= =?utf-8?B?cXM4UnBhcHJjazd5N2p5amVKRlVBeTJzOCt3cndSc2JFcXh6MktBOUVhWGRQ?= =?utf-8?B?RG5sY2wvTDlmd3NQZmg0STRXWHZXZFA0cklRRFl4MWdQckNmQWtTUFl5Nkkz?= =?utf-8?B?NlhKUXVSekwrSzFGOHNjcTcyU2NrZUVJck5HOFBERjgrN2NLbEV2UmZ5ZE1U?= =?utf-8?B?ZjdBeXVLNGtwOGNIRm4ydXhKRUc4NVdOajRxTy9BYjRuZDR2VmdmMXJ3M0hS?= =?utf-8?B?ZDhsckhibmtIWDNBM2txcjh4ekZXVWVlbGhYRjdDQW5ZWGk5MStsY0M2VWJk?= =?utf-8?B?WUdzb0c1TzF1bGNDNjlxTDZWeFROdFNLWjZMaktlMGRuODBDUGdvWTBrQkJG?= =?utf-8?B?QlRoM0xkQUJVczFVRlJ5MWJ2SGsrSXdIdmZBOXZ0S1J5QU5NemRqK00xWUlI?= =?utf-8?B?a1JYcGY2WUdyZUJCdkRlcXJFL2ttZjlVL3E4T0tPbjdORHdUUkhqQU8rdnU4?= =?utf-8?B?WXE2R0NqaUhPbmZxQmhZSW1kbzZ0WUh5am84Mis1QmlOTXdFdDVFU0M2REZa?= =?utf-8?B?NkI2c2YrV05UWlBnb01ZbGhlSm54dGVYM0xwU3RFMDhiN2JSelRLTTRVU3Nh?= =?utf-8?B?djh2aUtTREFoYlFrWjBlVnBIbUVsSWJzZmYwYnpia2xVQXhlcW5kNjJJb1Rn?= =?utf-8?B?eVNJak0wVHEvVmtEcWNCQWJpdTBYZXFBUWtaS01GMXBnczZIQUU3S2FRK0wr?= =?utf-8?B?dlpPQ2k5blRSbURvdXFPWkxpbjlsVW9DekhkQ01xODlvL01RbmlEd3NNLzR3?= =?utf-8?B?amJFdDRRQmtCQnhRbUIyWDlvUFJRTlV3emk2Y2VqdXBCSTlKZE9pNlM4SC9k?= =?utf-8?B?ck1TV2p6V3Y4TllqUkdHUEZaTGtFT3ZuMEpMNWU4d1FLNjB3VlJqVFYwdWtV?= =?utf-8?B?RmVhTDlRTDdhb0xpbUozN0JnOGdQTzlJTDVVS2I4TVlpOERRZmRlZGdxMWk4?= =?utf-8?B?UlZTRFZvZzJiRS9zQjBDT1dnVE5tSmRMblRJVk5wL3NDYkI5bGxWNUtrNVdh?= =?utf-8?B?NGZxMENLTklLbHgya0NGbXF2amhzMnQ2cHFJejJGY2RXQ1JJMWVIR2FadlNS?= =?utf-8?B?d1hMYW5zZUIyYldHNEMxYUNmazVHbDJETkplTFFOMXJYL0hUSFk2N1gveWNQ?= =?utf-8?B?UGVxbWM0cVhyYWNlMktHeVRWbFhJSjFYL244Si9sM0pqRXdDSlF3VGsvaEpU?= =?utf-8?B?Tmh6Y1NVcjd4QnZVcURCK0lYSFdsZUszYjV6dFBXa1Fpb3l2T0pGVDZxUEVD?= =?utf-8?Q?QBlxPnHj3LHModZhNs1LZZ66q?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd5ec770-8899-4e9c-fd65-08dd78faffd1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2025 13:15:58.6586 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D7VWpeqKzw6sSGLzi5ZJtzPSieusahxx4kYEBIoN+vUUx1tiUGjHnBrFUPcFKY2vEJCwVuInsTxLZEKristNyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10674 From: Peng Fan Use guard and scoped_guard for con_mutex to simplify code. Signed-off-by: Peng Fan --- drivers/mailbox/mailbox.c | 61 ++++++++++++++++++++-----------------------= ---- 1 file changed, 26 insertions(+), 35 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 3c3bdf278b8e729f494b0e61c008b63dbc4f9344..0d2f3ab79189731974a58bf7b90= a60c972f7261f 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -6,6 +6,7 @@ * Author: Jassi Brar */ =20 +#include #include #include #include @@ -370,13 +371,9 @@ static int __mbox_bind_client(struct mbox_chan *chan, = struct mbox_client *cl) */ int mbox_bind_client(struct mbox_chan *chan, struct mbox_client *cl) { - int ret; - - mutex_lock(&con_mutex); - ret =3D __mbox_bind_client(chan, cl); - mutex_unlock(&con_mutex); + guard(mutex)(&con_mutex); =20 - return ret; + return __mbox_bind_client(chan, cl); } EXPORT_SYMBOL_GPL(mbox_bind_client); =20 @@ -417,28 +414,25 @@ struct mbox_chan *mbox_request_channel(struct mbox_cl= ient *cl, int index) return ERR_PTR(ret); } =20 - mutex_lock(&con_mutex); + scoped_guard(mutex, &con_mutex) { + chan =3D ERR_PTR(-EPROBE_DEFER); + list_for_each_entry(mbox, &mbox_cons, node) + if (mbox->dev->of_node =3D=3D spec.np) { + chan =3D mbox->of_xlate(mbox, &spec); + if (!IS_ERR(chan)) + break; + } =20 - chan =3D ERR_PTR(-EPROBE_DEFER); - list_for_each_entry(mbox, &mbox_cons, node) - if (mbox->dev->of_node =3D=3D spec.np) { - chan =3D mbox->of_xlate(mbox, &spec); - if (!IS_ERR(chan)) - break; - } + of_node_put(spec.np); =20 - of_node_put(spec.np); + if (IS_ERR(chan)) + return chan; =20 - if (IS_ERR(chan)) { - mutex_unlock(&con_mutex); - return chan; + ret =3D __mbox_bind_client(chan, cl); + if (ret) + chan =3D ERR_PTR(ret); } =20 - ret =3D __mbox_bind_client(chan, cl); - if (ret) - chan =3D ERR_PTR(ret); - - mutex_unlock(&con_mutex); return chan; } EXPORT_SYMBOL_GPL(mbox_request_channel); @@ -547,9 +541,8 @@ int mbox_controller_register(struct mbox_controller *mb= ox) if (!mbox->of_xlate) mbox->of_xlate =3D of_mbox_index_xlate; =20 - mutex_lock(&con_mutex); - list_add_tail(&mbox->node, &mbox_cons); - mutex_unlock(&con_mutex); + scoped_guard(mutex, &con_mutex) + list_add_tail(&mbox->node, &mbox_cons); =20 return 0; } @@ -566,17 +559,15 @@ void mbox_controller_unregister(struct mbox_controlle= r *mbox) if (!mbox) return; =20 - mutex_lock(&con_mutex); - - list_del(&mbox->node); + scoped_guard(mutex, &con_mutex) { + list_del(&mbox->node); =20 - for (i =3D 0; i < mbox->num_chans; i++) - mbox_free_channel(&mbox->chans[i]); + for (i =3D 0; i < mbox->num_chans; i++) + mbox_free_channel(&mbox->chans[i]); =20 - if (mbox->txdone_poll) - hrtimer_cancel(&mbox->poll_hrt); - - mutex_unlock(&con_mutex); + if (mbox->txdone_poll) + hrtimer_cancel(&mbox->poll_hrt); + } } EXPORT_SYMBOL_GPL(mbox_controller_unregister); =20 --=20 2.37.1 From nobody Fri Dec 19 09:44:12 2025 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2082.outbound.protection.outlook.com [40.107.20.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 948611E7C08 for ; Fri, 11 Apr 2025 13:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377367; cv=fail; b=ZGe4PhcJ9NM4KnIVRcOiWjgOVjgognQ+mmiH+8wiriuXQi2SfAM9XsePVpj2tru1xWEqkXTHOlas5FIcawcIRmVGT6N3qwD/AOpDGqQiaexkiIkpcuYTC/LcmBuXItdTLKkrTU39dv3UcaAfM94sd1eGdUt/UyIt6ZEHF/YDHhU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377367; c=relaxed/simple; bh=tB6iSBGZiF63nIiVyRGSQuvfN41tfpM+9wL6Ef0ZfzE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=PjRBTXIwgchSTeYnaho61lJUaIiW9EsuVSa6xi2YBwLre+4W1loja9yQxvOOF0vM2RuHTb60XBSVhH2FRNswbhzIlDpWDdA1u4rPdnCX0xF+Njwyri1V+6VHdj+VNrVzWQKrsPyveXMMHpRv/Vpz9kxvqSAUuPMRb0sYdMtUUiE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=FfXtJ/ej; arc=fail smtp.client-ip=40.107.20.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="FfXtJ/ej" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MxPAR/TLL6kaapZgO5PMAWTHJr737F/jRmnpkzCzjuFHSY8G5BqwESmGppAZk+atcI9M4UfU5TkuEZSkCGWatsj3p/kl9VGHzTE/l109eT9MtH16nKSYNqBTcp0NnazpUfrRgzim3Fv/x4JMTuHquAvUlsG/+d9ecNUX+S5F5MCgsl1p41eCiP3SyK0LHkH8pKyUDfoa394jVN48nALTAcXPybfqXJ7+OyEbs3BVxMBS6QwbkG7/9ZfQiD8Y/bJa+K1V8jSh86GMZWlbbOrF9Gtk2zTz4NvbrE1OApBSKLZkl8+lVFWCPeKSexhM1tlBs+4eCtexDVXfGs4ozi1Kfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HD09oivLfvdNuojahoEGBAwwYWMNe0UeItD+V0jZxRI=; b=pAk+SN5vQTFii6GiXMyCzAzpCyZ+e6EPtWUSetML2lJ4V+c9edw1mimSvqvPnJvTJtSCoR/Ef8kgEqcxsIZ/NXOlpmVP2Fm3FYTAma7XT6Po/5FAoUOtGE0nyt4L3oCAUcxPp5lOXr+XYjhy1qesWJW1f8vIqU9XqEOl0G6lSDaMwuyil/XzraWHAF4RPIWDebEu68OAXIc3jgC7tSZetjEhotL/AESZLWVStjHNLo8/3sq1wavFaI/Oi1AjgXuEPZfJK9YQXXMH2QfARGTbVGAhGueUolJhlXnKGlvaufZ0VrH22MSxv8ZJmp0avhr41Ju5af5j8CRhUhC3rDr4pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HD09oivLfvdNuojahoEGBAwwYWMNe0UeItD+V0jZxRI=; b=FfXtJ/ej+xQkoJO5KTrJXYu5SFK2fq7xlGlBcGMWhWSRGnyvGKeV5Ofu6a1oGKZVxhu5kyeAhnTej5z4I3qB3/EIttXU/+8GVSDpbDZoloY1336hW/vCgSsoccUViRagHy1BqQ0z2T13G6sKP7kSbReqQRpDYO1mWtZ/RcnyGnedeED4xd7UklOl5yPng7ksR2Mz+iYvza3g/6aZh9wb/WsUZa4ku73bXjbipl5dq+A2aEX19lUNsKG3grSv6ZwA2FzPA80sU25ZKFzlBEDC0Y62kwBEhot0DzuGE5Wbb1suzfFmrXtaEBaiEGcavsRjCXXd27k8WTD7bxmuGZMfIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA1PR04MB10674.eurprd04.prod.outlook.com (2603:10a6:102:483::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.28; Fri, 11 Apr 2025 13:16:02 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8632.025; Fri, 11 Apr 2025 13:16:01 +0000 From: "Peng Fan (OSS)" Date: Fri, 11 Apr 2025 21:14:14 +0800 Subject: [PATCH 6/6] mailbox: Use guard/scoped_guard for spinlock Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250411-mailbox-cleanup-v1-6-8db541394dc2@nxp.com> References: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> In-Reply-To: <20250411-mailbox-cleanup-v1-0-8db541394dc2@nxp.com> To: Jassi Brar Cc: Tudor Ambarus , Elliot Berman , Thierry Reding , Sudeep Holla , linux-kernel@vger.kernel.org, mailbox@lists.linux.dev, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1744377279; l=6191; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=qlG+zbz/B1FXajQC7uiagd0R0C3Qdz5zwok/2kHgxjQ=; b=ywbfjVGdcN9+Uy1tA4QxnEhleZsyLsVcih2nj9Goui9Se6BO2C9UWtWLNrX/5+wBn/s7BDkur cUl+MvmSmuNDtWsa8Tvn2iUvq5YlKIi5iraMNKq4phcAN89mfFAQIbb X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: MAXPR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::22) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA1PR04MB10674:EE_ X-MS-Office365-Filtering-Correlation-Id: 82b83301-a7c7-4533-e4f8-08dd78fb0193 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aElVNnNPeGlyVHk4aEhEZnVaWUxCRjhCYkdPVmxFYy9zU0tnVU5rd2hYQzRw?= =?utf-8?B?ZFNoMU53Wnk2aGI0WmQ1MlFpNzF1eG5ZQ1NMYVZreTFUb3pwRTU1RTZKRnRU?= =?utf-8?B?WG9RVWhFSzFENHpsTlhmc2ppRllXNlRKOG5DZ1dOTmQ3RmxKcnNGWnJuL0RQ?= =?utf-8?B?UnhxYUN1ZllGUm81S0JHbXhhcnBtWGljVjBtOXBDNlJ3WGVwN2VkaEVIV3B3?= =?utf-8?B?aWcraExnbWluMWpsWW1uZGNsSGZScVYyK1NOTFNTWVJqSWp5amZRbFpmdlhN?= =?utf-8?B?QzVFZHF1dHJlTklkWVJxampEc3lPaGtMaGhpYmdlSVpFd25EcnpNN2ZaZld3?= =?utf-8?B?ZVhCSmR0b1BnM3JOdkpKRHIvNjRTL2ttejdmbExrRVk2UEdqZGZ4aXFHMk4x?= =?utf-8?B?N2paSWo2QmlJRUhGVGdjM09yVnNSSHQycm54VkdRVzgyUWloZ0JwY1JsT045?= =?utf-8?B?cGw1dFpVN0xkaFZwYnVodUZNUHBWRFhqNHYvaWpSN2hac3liWFFSYUdCbUlz?= =?utf-8?B?TGpaSnlHYTl0SjZld3VBVzJzUjRBczAvS2U3SytXRnlDYlBTSmhMRjZaUTlW?= =?utf-8?B?emR2eG0vaUlQQTV3UDUzL2RuU25JYWlMSlRGdG5oOTZsb2g4Y1JHcDlsbUlr?= =?utf-8?B?MTFYNEFmL3ROdEN2ZjdtVVMwL0VpK0hSK005bTcrVnpOcFVMYnRmVlgzNG9l?= =?utf-8?B?STBJZmxNMlpxQXRBZzZYandlWjdQOStZVHVqcGhrQW9Cd2ZuU0YxVW5kWHNW?= =?utf-8?B?bElJL2FHMmxhZ1RCcXlBWEM0Mzlua1krc0Fpc21IMmxFeDk1OTZrQ1BCV1NZ?= =?utf-8?B?MnNuaUJwZDJ3dGxFcFc5VGZtaENvcXhFd1J3RCtmdFovd2JmaUt3d0pOZjZ5?= =?utf-8?B?VFJRbmQ0a2s0Q0Q4QS92elRrdmxabU5EbzhSd1pnUk04bWdZbU9LR0FpNnZ2?= =?utf-8?B?aDNhekdyLzJXcVJsbUVtdk1hRjF1aGhsWHhMWGIyUTNFZGpGYmhRVzMrWjFM?= =?utf-8?B?cm0yeFN2VnBESjMvd3VKUTRhVkF4NkdxQ2hMQ2NvcUtxQ3pKKzhMcndOcmIw?= =?utf-8?B?aVBsT1d5RGRNT3A1d3lHY0RlTnBkenBaK2Y0bjFaVUlCQlQ3L3N4NTRpSjR3?= =?utf-8?B?amNkdzc3L0l1VStmK3hqTHBHNG84YmJYbzVSMXBBNytzMlJPSWV2VXJZYXhq?= =?utf-8?B?bm84eGtxcnYxK2tYdTc4aHdzV1l6b29MM09zVHlDNlY2dVFlckJNVVVJeXp3?= =?utf-8?B?eWRiNm5LVlVLd2Q0ZThJVmVQd2RFc0V6WTFuY3YrQklYOHNSZHpIeEJDbldP?= =?utf-8?B?T0NuczVWM0xucjZPanE1d01RcEN4eDViaHd0b0paQzVoSjhWd2F5ekVXUnZT?= =?utf-8?B?dXJXOHhGNnZyeTZ0Mmo3OTdaZTVoVCsraWNtS00rNHR2eW1zV2RhZERJZ3JM?= =?utf-8?B?aGhUczMxQW0wZngxaXE2QkVENDdpMDRISks2dW5qaklhTFQwZVdMc0wwakdr?= =?utf-8?B?bXJVYVJaR2ZEaHJwd05sOWVxWWxrUjdwRHZOWFdpM29iUy9oQmpQR1NaS1lD?= =?utf-8?B?Q3NyNG01NkhxRkhuL0NFS2hrRDE0bWxxRUl4d1JETWdaUlhBdUtQSXNzYVZp?= =?utf-8?B?TVF1TmxZYWdHNFVHOXIzNFhSR0J1dEw0NXFyNXExVXpONUFPMlBWbU1za09L?= =?utf-8?B?bnpmS1hMelJHdk5NMVJhc0xXOXE5dXN3WVRUVFN2ZmFKaFA2R0hOazVhK3lG?= =?utf-8?B?b2lnbWo4V1FBVUk5aERER09IelptNUkvVFBiVWhyOEtQTldNcFE5YlpnNzdK?= =?utf-8?B?aGVXb0E1QmkvclhNb2lYV3MwNExjWUNUNVhsYnhaUXVBS3ROYXk5T2s0a3dm?= =?utf-8?B?ZmwvZlV3WWtZMHVuQWtweXJVbWQrekZmeFk4N0w4T3B5eEJvVHFQb09DejdE?= =?utf-8?B?TXlvVC9hUDhxeHRvRFJ3T0VIejJTcUc3QXB0RFVYaldSRUoyRmR0T0YrSHZq?= =?utf-8?Q?WCy+ifj1PfOlelCVcJEbel+4YFhZ0Y=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEt3ZXVqTk1DbXg0QU51UjhMYjNnR1RFZ1pOYnVKMW12dDNwZmdLTFZmMGlU?= =?utf-8?B?eklQa21BVTRoU2xtdXNNS0F1Njd0WjNUdUFwdFdMN0V1OHlJNGltZ2NsTldy?= =?utf-8?B?U1MwNXlJd3hYejNOSFArVTJrbHJYdnE1bEQ5anp4b1p0WHhoNG94dk5mbmRx?= =?utf-8?B?T3dBeFlUVWhxQzIxcVhNR09SREN2bWhaSGR3M1V0bzE4REttcDNweEM4SG9a?= =?utf-8?B?U3B2TWVOMnYwd1RDZ2FDb0xFVzQ0NWZPaDJ2NFpiNmNaNHNic0tLWk5pWDJp?= =?utf-8?B?Uys2L1VoMXR5N3JvL1UzZVA1ZnpWVlZSdStxc3g2VEZna2tTZk1iZ0JDRzJ3?= =?utf-8?B?ZHFyVkVGSndEMHVtcEFMQkFrL3J1QWlCYkhNeW9BUURlaUxxVlVvZTBNUGZu?= =?utf-8?B?aC8yVzk3NDUwYWt4T3NyMkUyd0l2YUI0QzFONUZhRmcrb3pwRDhyVHVnOFIr?= =?utf-8?B?Q3FBeXUxTGtLNjAyb0RTbDBQTnhDOEdQdzdGSW5CVHZ5RVA1aUQ5dGZkaitu?= =?utf-8?B?UUhJeG85bDRiNURsam9RdGZLemk4Unc1QWlEd0xkVUQ3aHlGY2Z3N3JHMW9Y?= =?utf-8?B?TCs4TlJLL0FUTTMxTDdPb1MrT3pWMnFUMzZ6VWlzN0tJVi8yWVY3WkxkZzBF?= =?utf-8?B?YjJyVkd0b1pNTEtKK1lGTVpjM1pSUFBYQ3dqdkVxRHcwT0ZSZ0dubmJsd0ti?= =?utf-8?B?OWdQTEs5ZG55M1FHQStNTUpOS0lwUkVybnFpcWp6bG1RWDhDYXcxdWhKUkdC?= =?utf-8?B?VWpORmxzck1pMzE3Wmh5NVpEa0U4dUpwd0owTy9nV1lzelI2YzA2KytyOEFR?= =?utf-8?B?Y3pKbys5bmVHTFBHWkF1cnZqS0pJRXZhR1ZvanhQbUcrRER3TEx3bjc4Y2o1?= =?utf-8?B?ejcrYTJneUFBYzNpWWZPV205Sk5tcForMnhGYjdJUDJIV0RvbFRkT0wrNFhO?= =?utf-8?B?cms1THBYcFp5VjVmRUplZ0Q3VlZhaVRCbzFOWUJuZHlvdEhzd3NQK1pqajVw?= =?utf-8?B?ektUbm5TNUpWSk5qOVR0ZHpIeEVBVmVBK2tseis2dnUyalBsdGlSTmhZdUVT?= =?utf-8?B?c3ZDaCtZZUZkQU16NTBQakhyZ2FMQTJ0MnYrTnpNMUVHVGx2OGg5Mm03SVdk?= =?utf-8?B?cUxuSEV2Qlg4cStpZ1dVOC9OaVFldlRXbnhhTW9rUjdWWXdoSkVLYjhPMVRR?= =?utf-8?B?ZjNNV0NUWFBRMUlNeHU2a3hDSEpHMTlsS3hWTmFKbU9kS2hSbjExSyt0YXd1?= =?utf-8?B?MDlqWDEvb3J2UmdlNjBkblVReE50U2JMK0l1UDkxRG9YWmxRdk0wVnJEWEJX?= =?utf-8?B?bHBtU2Z1d0F1SVdsT1ptSjZRMktoM3BTSlQ1Z0lmYTRQUzdTMS9yM2RyZ29j?= =?utf-8?B?ZjNuQS9nL0dDKytUZmVwZUo3Tk1SY1h0SDVNcnVKQ01zcjZUbUdkMDlLQldW?= =?utf-8?B?TXN0ekMrU1dXUzhaQ1BHSTh1VlFqUUQvbVdqUTd3ODZwSFFEdkZGMHdBNTQr?= =?utf-8?B?bmtndUJvMm9pU3R2RzRneGpUNmQ3aWZMVStjWm12SVdMcE8vQWJJVk5TWWZ0?= =?utf-8?B?c2JnU29Ra2lKZzk1TDZPTjNRMmFTZUg0MFJ4Tit4OFFqUGg3WVh1MlErNXlm?= =?utf-8?B?SU1lV3dEdFliOU9OZGpkTlMvMEFyTjBCSzVzVEpocEVGNk4rQTJlNklncEVF?= =?utf-8?B?bi9mMlo5cnhlOXRyM0JJMTBwak1PL0s4UmtDa2RTSzlEWllDUWdXM20rb0Ey?= =?utf-8?B?Z0V5L2w3VnkxbElnS1J3Q1hybUZOZFhnMDJqTWFxd1lqNmZvZ1Y5OWxFdzBj?= =?utf-8?B?WXpiWWRkTmc3MmNxMWJxT3pzTjJiZEtwYjZ2L0w1OXhHeFk3cXlYaXczMS9V?= =?utf-8?B?ZDhWMkE4bmQyQXE4UmZ3UmEwLzI2bVArWkpvRnFIa1lmT215RzRXblFma2o5?= =?utf-8?B?K2pWbjZGUHNVRmV1TXNmQmNMNmhXRUhoNHpadGdFQWJFZ2kzRVBQUWdmZGpP?= =?utf-8?B?a25VczBLOVp3Q1Z2MlQxK0gyaDJMOTYwY2xmWTRXYU8renRZcnNUckFHdmRK?= =?utf-8?B?T1JYNnZNb3V2R2tRRXBJN0hDMGk5TElmTG13Unh3RGJxT1VvNFo4ODdJVWx6?= =?utf-8?Q?SAsVyS2c8APHclKNYnxBXGPtP?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82b83301-a7c7-4533-e4f8-08dd78fb0193 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2025 13:16:01.6165 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0hkUoQFFhOtoFnYlrfSRzWKwsq4VMW/KBlADSc4uFleiV4lRVdt35dSSptgkjDHaen0dtqxM0D0lI3+I0DALyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10674 From: Peng Fan Use guard and scoped_guard for chan->lock and mbox->poll_hrt_lock to simplify code. Signed-off-by: Peng Fan --- drivers/mailbox/mailbox.c | 105 ++++++++++++++++++++----------------------= ---- 1 file changed, 45 insertions(+), 60 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 0d2f3ab79189731974a58bf7b90a60c972f7261f..5cd8ae22207309fadbe8fe7f6fd= 8b4bc2c345cfd 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -25,15 +25,12 @@ static DEFINE_MUTEX(con_mutex); static int add_to_rbuf(struct mbox_chan *chan, void *mssg) { int idx; - unsigned long flags; =20 - spin_lock_irqsave(&chan->lock, flags); + guard(spinlock_irqsave)(&chan->lock); =20 /* See if there is any space left */ - if (chan->msg_count =3D=3D MBOX_TX_QUEUE_LEN) { - spin_unlock_irqrestore(&chan->lock, flags); + if (chan->msg_count =3D=3D MBOX_TX_QUEUE_LEN) return -ENOBUFS; - } =20 idx =3D chan->msg_free; chan->msg_data[idx] =3D mssg; @@ -44,60 +41,53 @@ static int add_to_rbuf(struct mbox_chan *chan, void *ms= sg) else chan->msg_free++; =20 - spin_unlock_irqrestore(&chan->lock, flags); - return idx; } =20 static void msg_submit(struct mbox_chan *chan) { unsigned count, idx; - unsigned long flags; void *data; int err =3D -EBUSY; =20 - spin_lock_irqsave(&chan->lock, flags); + scoped_guard(spinlock_irqsave, &chan->lock) { + if (!chan->msg_count || chan->active_req) + break; =20 - if (!chan->msg_count || chan->active_req) - goto exit; - - count =3D chan->msg_count; - idx =3D chan->msg_free; - if (idx >=3D count) - idx -=3D count; - else - idx +=3D MBOX_TX_QUEUE_LEN - count; + count =3D chan->msg_count; + idx =3D chan->msg_free; + if (idx >=3D count) + idx -=3D count; + else + idx +=3D MBOX_TX_QUEUE_LEN - count; =20 - data =3D chan->msg_data[idx]; + data =3D chan->msg_data[idx]; =20 - if (chan->cl->tx_prepare) - chan->cl->tx_prepare(chan->cl, data); - /* Try to submit a message to the MBOX controller */ - err =3D chan->mbox->ops->send_data(chan, data); - if (!err) { - chan->active_req =3D data; - chan->msg_count--; + if (chan->cl->tx_prepare) + chan->cl->tx_prepare(chan->cl, data); + /* Try to submit a message to the MBOX controller */ + err =3D chan->mbox->ops->send_data(chan, data); + if (!err) { + chan->active_req =3D data; + chan->msg_count--; + } } -exit: - spin_unlock_irqrestore(&chan->lock, flags); =20 if (!err && (chan->txdone_method & TXDONE_BY_POLL)) { /* kick start the timer immediately to avoid delays */ - spin_lock_irqsave(&chan->mbox->poll_hrt_lock, flags); - hrtimer_start(&chan->mbox->poll_hrt, 0, HRTIMER_MODE_REL); - spin_unlock_irqrestore(&chan->mbox->poll_hrt_lock, flags); + scoped_guard(spinlock_irqsave, &chan->mbox->poll_hrt_lock) + hrtimer_start(&chan->mbox->poll_hrt, 0, HRTIMER_MODE_REL); } } =20 static void tx_tick(struct mbox_chan *chan, int r) { - unsigned long flags; void *mssg; =20 - spin_lock_irqsave(&chan->lock, flags); - mssg =3D chan->active_req; - chan->active_req =3D NULL; - spin_unlock_irqrestore(&chan->lock, flags); + scoped_guard(spinlock_irqsave, &chan->lock) { + mssg =3D chan->active_req; + chan->active_req =3D NULL; + } =20 /* Submit next message */ msg_submit(chan); @@ -119,7 +109,6 @@ static enum hrtimer_restart txdone_hrtimer(struct hrtim= er *hrtimer) container_of(hrtimer, struct mbox_controller, poll_hrt); bool txdone, resched =3D false; int i; - unsigned long flags; =20 for (i =3D 0; i < mbox->num_chans; i++) { struct mbox_chan *chan =3D &mbox->chans[i]; @@ -134,10 +123,10 @@ static enum hrtimer_restart txdone_hrtimer(struct hrt= imer *hrtimer) } =20 if (resched) { - spin_lock_irqsave(&mbox->poll_hrt_lock, flags); - if (!hrtimer_is_queued(hrtimer)) - hrtimer_forward_now(hrtimer, ms_to_ktime(mbox->txpoll_period)); - spin_unlock_irqrestore(&mbox->poll_hrt_lock, flags); + scoped_guard(spinlock_irqsave, &mbox->poll_hrt_lock) { + if (!hrtimer_is_queued(hrtimer)) + hrtimer_forward_now(hrtimer, ms_to_ktime(mbox->txpoll_period)); + } =20 return HRTIMER_RESTART; } @@ -319,7 +308,6 @@ EXPORT_SYMBOL_GPL(mbox_flush); static int __mbox_bind_client(struct mbox_chan *chan, struct mbox_client *= cl) { struct device *dev =3D cl->dev; - unsigned long flags; int ret; =20 if (chan->cl || !try_module_get(chan->mbox->dev->driver->owner)) { @@ -327,17 +315,16 @@ static int __mbox_bind_client(struct mbox_chan *chan,= struct mbox_client *cl) return -EBUSY; } =20 - spin_lock_irqsave(&chan->lock, flags); - chan->msg_free =3D 0; - chan->msg_count =3D 0; - chan->active_req =3D NULL; - chan->cl =3D cl; - init_completion(&chan->tx_complete); - - if (chan->txdone_method =3D=3D TXDONE_BY_POLL && cl->knows_txdone) - chan->txdone_method =3D TXDONE_BY_ACK; + scoped_guard(spinlock_irqsave, &chan->lock) { + chan->msg_free =3D 0; + chan->msg_count =3D 0; + chan->active_req =3D NULL; + chan->cl =3D cl; + init_completion(&chan->tx_complete); =20 - spin_unlock_irqrestore(&chan->lock, flags); + if (chan->txdone_method =3D=3D TXDONE_BY_POLL && cl->knows_txdone) + chan->txdone_method =3D TXDONE_BY_ACK; + } =20 if (chan->mbox->ops->startup) { ret =3D chan->mbox->ops->startup(chan); @@ -465,8 +452,6 @@ EXPORT_SYMBOL_GPL(mbox_request_channel_byname); */ void mbox_free_channel(struct mbox_chan *chan) { - unsigned long flags; - if (!chan || !chan->cl) return; =20 @@ -474,13 +459,13 @@ void mbox_free_channel(struct mbox_chan *chan) chan->mbox->ops->shutdown(chan); =20 /* The queued TX requests are simply aborted, no callbacks are made */ - spin_lock_irqsave(&chan->lock, flags); - chan->cl =3D NULL; - chan->active_req =3D NULL; - if (chan->txdone_method =3D=3D TXDONE_BY_ACK) - chan->txdone_method =3D TXDONE_BY_POLL; + scoped_guard(spinlock_irqsave, &chan->lock) { + chan->cl =3D NULL; + chan->active_req =3D NULL; + if (chan->txdone_method =3D=3D TXDONE_BY_ACK) + chan->txdone_method =3D TXDONE_BY_POLL; + } =20 - spin_unlock_irqrestore(&chan->lock, flags); module_put(chan->mbox->dev->driver->owner); } EXPORT_SYMBOL_GPL(mbox_free_channel); --=20 2.37.1