From nobody Thu Dec 18 19:29:41 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E9A528FFD6; Thu, 10 Apr 2025 20:23:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744316620; cv=none; b=YbOlQtVkf2tvttR86qxycKoaYR6ySKPcLCu3ReyROtXekav5YrSmNNS9gxunqa/X1SP8YNsVslMxZsHmvz8BWNduiSWifEaCwAZFZwZnu/SWpGvgvSdR3hQOjry6EdkbNZa2jBbQTHyxW5Hkb3K85yr7p+g1vQO3TJIfNAzVOj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744316620; c=relaxed/simple; bh=EFcvE9OnnqxAq31Z+Vbsja4i2NAYZxzu4waUY0tYvPE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dc5+Es+xh4yW+adjdjN8fgRE2K8JhCtP9rUIChmUD9B7qQ2ttdYGqr10ASnVKLhzKZOV9vEfyZmOyvanHYmmtc/Wjd45V0HxZdbXSkunnJQC5PBdyAakX9zfyoqH7wKvGugCBz2OKO0pJglGUQgAPLEh2c4x2zRUNm8DbkihJUg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bHPWI8O2; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bHPWI8O2" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43cfe574976so9643065e9.1; Thu, 10 Apr 2025 13:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744316616; x=1744921416; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HVkZqr5sfAAS0KFulfZirHfw18lNq9awB17Z0Rl5Qrc=; b=bHPWI8O2k1RgmLbWw9dhqkGZm0X/uGP/FvFHTKLZCpY5RnTBPJ1AVWjISp0cxDTKXD iZkg6m5oxn+RxE1FBZVB/RWnkY6xi+gwwiewl/37So04fkyAkKiui+Jqdn67XK2cmDlB 0Y3xOmBeZhegDtq8IOo2/k6SUb+ZvJNVJUdD7XJGYH8F9PmhEMJN1f+Kvo6bPBtX6+gw NYZU0edxRj448GP3HJ4hLjj/8UWv+eWfrTUp/1KniO78cefyaKI6qRmLNj8AxhzLQzwq CNGfV+7yS6yrh+PNdJuOfJSLmrhbRzUOTUriEF0oNJf85iYYtDT17ww5NxmizhaCec9F QIGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744316616; x=1744921416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HVkZqr5sfAAS0KFulfZirHfw18lNq9awB17Z0Rl5Qrc=; b=rIb9L8EzDfJLk2mCqjvZ96T8wWFqY/c26JRh2wwW19kpTM5ypTZztPO41u/hbAXUX1 ebmBTbZfp+Vx3rEoKykDjjkkUiyqcBet2a4MYn1CCWbuDmzVpMBG2a2TQ8QLo5au9dn9 E9Wy8UK9BCEACmSmAxcnNXhCnb5KRrHk0QEwSW99ioh+Xd8KLLfeLSEjd+GwDDeESyk6 z3xjY6JHD+uvNMrYiuIiPTR7+SfWlbAJoJhW1z6ZMh4mii5NFCDz46yG0Jt630buRq4h GxaMmqRVXj1wdB82yFpKz37Y6mLMsVJzj63ON3c4BRS658n5EklCtIBl2P1JdLYFkRkv 4dMA== X-Forwarded-Encrypted: i=1; AJvYcCUwhf8f/2uUEj1KHQN/Kz2gAAGLnitmiFwvyoQd2PAXinpbWR98h8N64Pir6lSE65XUa6Prq1nx+bqz@vger.kernel.org, AJvYcCXSyO2ff+zGttHKPIMECvmOfcILaCbJj3F33L4Jzt6JEMWnBjk3o0r9D3CLnvLkQs1hnTNPgLE3VZHng282@vger.kernel.org X-Gm-Message-State: AOJu0YwxMOl8F7pLQQLNeNYKT377JeD6qk/dpFMxahMPE/xa05XaaRXz 6lblv1vYCRusPfXafVNsI9K6j6m7usUY1oDbCf12CbhvwxFze7bP X-Gm-Gg: ASbGncvwkADjRaDprzS7m4wMZ7GmjIsDaTK1uMVm6V95fZJjD8IxqBWvQDHs5mCIROJ oKsm0gzlt+3tGbJmhL373NIeyWFaGHZWWMw0u0juwzfIyzQP5YceQNQnykUZ9XQgidyqp4lwi7e T8azC9L4JMkM6PWfi5/2M7GdaQj29ZaWcOYay286G10Dgp/nR64FLUFY1xRAmf1r4zbMF3P8dZD 8fQmQ51y/0z0S+A+Ujav6LhUQXu8TG5mKDBUtS6QTQhU1rdrt83czbZW/Yq+ItX0rq7jkpxvKNo ztpgtKWW/gBCx4K7s/a5GhsTLFk5Gomypvoiba4JpFMY1VbDJKfT4IVB5Q== X-Google-Smtp-Source: AGHT+IHABr63CqW3iOsNq+ClUsuI/qOHF/xCXmWEb443YmrfuT5UCxJw5AfiAVj/FQ3biykFVi6H9w== X-Received: by 2002:a05:600c:34c1:b0:43c:fa24:8721 with SMTP id 5b1f17b1804b1-43f2d7cea60mr49467175e9.17.1744316616496; Thu, 10 Apr 2025 13:23:36 -0700 (PDT) Received: from localhost.localdomain ([78.211.153.93]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f233c817dsm60998745e9.23.2025.04.10.13.23.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 13:23:35 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org, alexander.stein@ew.tq-group.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Antoni Pokusinski Subject: [PATCH v3 1/3] dt-bindings: rtc: pcf85063: add binding for RV8063 Date: Thu, 10 Apr 2025 22:23:15 +0200 Message-Id: <20250410202317.25873-2-apokusinski01@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250410202317.25873-1-apokusinski01@gmail.com> References: <20250410202317.25873-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Microcrystal RV8063 is a real-time clock module with SPI interface. Signed-off-by: Antoni Pokusinski Reviewed-by: Rob Herring (Arm) --- .../devicetree/bindings/rtc/nxp,pcf85063.yaml | 33 ++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml b/Docu= mentation/devicetree/bindings/rtc/nxp,pcf85063.yaml index 2f892f8640d1..86ac9c626144 100644 --- a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml @@ -12,6 +12,7 @@ maintainers: properties: compatible: enum: + - microcrystal,rv8063 - microcrystal,rv8263 - nxp,pcf85063 - nxp,pcf85063a @@ -44,13 +45,19 @@ properties: =20 wakeup-source: true =20 + spi-cs-high: true + + spi-3wire: true + allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# - $ref: rtc.yaml# - if: properties: compatible: contains: enum: + - microcrystal,rv8063 - microcrystal,rv8263 then: properties: @@ -65,12 +72,23 @@ allOf: properties: quartz-load-femtofarads: const: 7000 + - if: + properties: + compatible: + not: + contains: + enum: + - microcrystal,rv8063 + then: + properties: + spi-cs-high: false + spi-3wire: false =20 required: - compatible - reg =20 -additionalProperties: false +unevaluatedProperties: false =20 examples: - | @@ -90,3 +108,16 @@ examples: }; }; }; + + - | + spi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + rtc@0 { + compatible =3D "microcrystal,rv8063"; + reg =3D <0>; + spi-cs-high; + spi-3wire; + }; + }; --=20 2.25.1 From nobody Thu Dec 18 19:29:41 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 773B8290BCC; Thu, 10 Apr 2025 20:23:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744316624; cv=none; b=uXMCrcRYQa5Rbm2ML92XGqWV6xT7fCotK/qnQyPMrB8fwf9llobIsGzoWG1vF9iAzDwpPAPTcb8aH4PF7EzYlmf8UsJPMowW2cIsFVYVfsAvPhqQUPLIMq2yVwPrNUhmHs+OLsDY8/4J2QOCxw4ofs+WruuYopVc74kxIywGO+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744316624; c=relaxed/simple; bh=jwsoeajWLSOPJcvIZix/A6b+favE2I6KfWiuZwzI3kE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=GcbbmsP/fHzMGv4s5vxrUyKkAbPvsqMBx2jyKiHjXISTOPrFiHeroK0zZDzshkLIatzZDWN7R7XwqWO+qLRJzs3NGaHDCyopqun1MQ8KIYIhUzPQPVueiBEclql4/YW9uIaFp1rKbAMPzUyvKTsByHA0kdV7erqClBa/ndZS0MQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O3UNx1xi; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O3UNx1xi" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43edecbfb46so9937905e9.0; Thu, 10 Apr 2025 13:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744316621; x=1744921421; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EL5d6O3loKPdrSygpYmikEvuM6mYmpkHUhAOsZ8Nu3Q=; b=O3UNx1xiUfUAjhkD9aHo+tt+ot3erIlL19rxWKeox7SPQg8ojU5wa2+F4y7fpyl23C qX+fUbWit3etR5Xr3JcQybG1va/tv0fcj90x3BJ4FJ4Be9aY21JoHDI3vZ/RU3tHlATf sEJqmY0JhvF/zzEa3QkWu0omrOH5+5s5LT3jGAwHMfnwfQuNu99BPL1Hag1RzE/G3kKW k/w5wPk2K5rkBAM0dNykY9JLXZP1lC0B4925i20efO3uqt3b2HczHpfdjQXFayFtsS80 v9+D25BxWhKKUnzo6rPZuRQXOEZMJqKNUVislw7IhKxT037XzTei791FYEjN5su5qnX+ 21aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744316621; x=1744921421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EL5d6O3loKPdrSygpYmikEvuM6mYmpkHUhAOsZ8Nu3Q=; b=q2APH4El4hxSQAEmf1GCRD0IduwilbzPGD6G+EIdfhrwPgns1b1/SYsYkxxcuKZ/5O ksvUXdFBc0y8o5LWR52jckJ3meYKUYnE9dQGLe5p87fn/XROc8BYVHxJgxIP2TOY2XzN bIEc1pzP4FTGr4E7e0zZTG4zAtAJ+LYxHY951TEAKbzv/Cv50DRciHoNTWxzvV+X/qrO iWoSetprGTdGGtgRzQ+hb7/bt6M9Lsk3T/AEv4en+9VE3inevtbp1/86OyrPmTsHqYIX D+kq86gPUjmQ6Z/HRKm3IUHAHkDVleRc4pJbwl//KfA0K8GNC9QLNm+oEfudNpMgvIXv aWpw== X-Forwarded-Encrypted: i=1; AJvYcCWofVjfj1cj39x4/PckH/uz/F1CXG1F3ocndAY3mqsSa6FE/uIueKK1N4KzBWLwZcHaM9Gjc/4xIq7I@vger.kernel.org, AJvYcCXpUk+J4P6TOQUjQxddiByQ61kozrAndKw91X3VexxR1K0Tp+mzsiUuLnxNoqIyxfwSQrzhfvfyWTyWl93N@vger.kernel.org X-Gm-Message-State: AOJu0YzrmOBSJiiDxLpRRJzsWkXqCrta+S0NTr9DArPIyFW0cML3sJbp 5gflRgnwymFU6+vTM/XAGAHZSwvhfZOjmutbO99OF1H6ZzdXef0H X-Gm-Gg: ASbGncvqpz7Ryj/kdwds8SLlHo68pXVXaLTBwUbjwQp5SYy2Ell4duSKoaRjuVzY5XJ uNDTL+NAiij/wJ1okpYL7k7DP1B4rOEfC3x1qnjjeRAI+eRiY/761QYmk/vWKsr8wvA0ZHS8gYP IYF9LvJBNFA3c6oF6+huJ0EkBpTEOOi2YIzJC8IHjc/fW7TDWz9SbzGl3XcYy4RRoi3Qnr0gzQ1 yxA4/HutO2BPeaBzndDatpHIpE14RcJT7fVKTs+KsgamNr4HllQcEk3m9sobIo993nsMHIhiE9f 4YqeZwEmwnfmzDcLNY4Lxw9PXjsc5Tchde6smnxWvyUyuYDiZWi9TJ6ng1cDRutU3rPh X-Google-Smtp-Source: AGHT+IHKzorIQwvbdwENPMOUXlPpZT+hyhlsb54T92JVT6PukD3k96kNEOMErT7knvpmesYY1PxYwg== X-Received: by 2002:a5d:64e3:0:b0:390:f6aa:4e72 with SMTP id ffacd0b85a97d-39ea5200a39mr52497f8f.18.1744316620540; Thu, 10 Apr 2025 13:23:40 -0700 (PDT) Received: from localhost.localdomain ([78.211.153.93]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f233c817dsm60998745e9.23.2025.04.10.13.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 13:23:39 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org, alexander.stein@ew.tq-group.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Antoni Pokusinski Subject: [PATCH v3 2/3] rtc: pcf85063: create pcf85063_i2c_probe Date: Thu, 10 Apr 2025 22:23:16 +0200 Message-Id: <20250410202317.25873-3-apokusinski01@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250410202317.25873-1-apokusinski01@gmail.com> References: <20250410202317.25873-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Move the i2c-specific code from pcf85063_probe to the newly created function. This is a preparation for introducing the support for RV8063 real-time clock with SPI interface. Signed-off-by: Antoni Pokusinski --- drivers/rtc/rtc-pcf85063.c | 97 +++++++++++++++++++++++++++----------- 1 file changed, 70 insertions(+), 27 deletions(-) diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index 4fa5c4ecdd5a..03dfc58f4cd7 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -559,12 +559,12 @@ static const struct pcf85063_config config_rv8263 =3D= { .force_cap_7000 =3D 1, }; =20 -static int pcf85063_probe(struct i2c_client *client) +static int pcf85063_probe(struct device *dev, struct regmap *regmap, int i= rq, + const struct pcf85063_config *config) { struct pcf85063 *pcf85063; unsigned int tmp; int err; - const struct pcf85063_config *config; struct nvmem_config nvmem_cfg =3D { .name =3D "pcf85063_nvram", .reg_read =3D pcf85063_nvmem_read, @@ -573,28 +573,22 @@ static int pcf85063_probe(struct i2c_client *client) .size =3D 1, }; =20 - dev_dbg(&client->dev, "%s\n", __func__); + dev_dbg(dev, "%s\n", __func__); =20 - pcf85063 =3D devm_kzalloc(&client->dev, sizeof(struct pcf85063), + pcf85063 =3D devm_kzalloc(dev, sizeof(struct pcf85063), GFP_KERNEL); if (!pcf85063) return -ENOMEM; =20 - config =3D i2c_get_match_data(client); - if (!config) - return -ENODEV; - - pcf85063->regmap =3D devm_regmap_init_i2c(client, &config->regmap); - if (IS_ERR(pcf85063->regmap)) - return PTR_ERR(pcf85063->regmap); + pcf85063->regmap =3D regmap; =20 - i2c_set_clientdata(client, pcf85063); + dev_set_drvdata(dev, pcf85063); =20 err =3D regmap_read(pcf85063->regmap, PCF85063_REG_SC, &tmp); if (err) - return dev_err_probe(&client->dev, err, "RTC chip is not present\n"); + return dev_err_probe(dev, err, "RTC chip is not present\n"); =20 - pcf85063->rtc =3D devm_rtc_allocate_device(&client->dev); + pcf85063->rtc =3D devm_rtc_allocate_device(dev); if (IS_ERR(pcf85063->rtc)) return PTR_ERR(pcf85063->rtc); =20 @@ -605,19 +599,17 @@ static int pcf85063_probe(struct i2c_client *client) * of the registers after the automatic power-on reset... */ if (tmp & PCF85063_REG_SC_OS) { - dev_warn(&client->dev, - "POR issue detected, sending a SW reset\n"); + dev_warn(dev, "POR issue detected, sending a SW reset\n"); err =3D regmap_write(pcf85063->regmap, PCF85063_REG_CTRL1, PCF85063_REG_CTRL1_SWR); if (err < 0) - dev_warn(&client->dev, - "SW reset failed, trying to continue\n"); + dev_warn(dev, "SW reset failed, trying to continue\n"); } =20 - err =3D pcf85063_load_capacitance(pcf85063, client->dev.of_node, + err =3D pcf85063_load_capacitance(pcf85063, dev->of_node, config->force_cap_7000 ? 7000 : 0); if (err < 0) - dev_warn(&client->dev, "failed to set xtal load capacitance: %d", + dev_warn(dev, "failed to set xtal load capacitance: %d", err); =20 pcf85063->rtc->ops =3D &pcf85063_rtc_ops; @@ -627,13 +619,13 @@ static int pcf85063_probe(struct i2c_client *client) clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, pcf85063->rtc->features); clear_bit(RTC_FEATURE_ALARM, pcf85063->rtc->features); =20 - if (config->has_alarms && client->irq > 0) { + if (config->has_alarms && irq > 0) { unsigned long irqflags =3D IRQF_TRIGGER_LOW; =20 - if (dev_fwnode(&client->dev)) + if (dev_fwnode(dev)) irqflags =3D 0; =20 - err =3D devm_request_threaded_irq(&client->dev, client->irq, + err =3D devm_request_threaded_irq(dev, irq, NULL, pcf85063_rtc_handle_irq, irqflags | IRQF_ONESHOT, "pcf85063", pcf85063); @@ -642,8 +634,8 @@ static int pcf85063_probe(struct i2c_client *client) "unable to request IRQ, alarms disabled\n"); } else { set_bit(RTC_FEATURE_ALARM, pcf85063->rtc->features); - device_init_wakeup(&client->dev, true); - err =3D dev_pm_set_wake_irq(&client->dev, client->irq); + device_init_wakeup(dev, true); + err =3D dev_pm_set_wake_irq(dev, irq); if (err) dev_err(&pcf85063->rtc->dev, "failed to enable irq wake\n"); @@ -661,6 +653,8 @@ static int pcf85063_probe(struct i2c_client *client) return devm_rtc_register_device(pcf85063->rtc); } =20 +#if IS_ENABLED(CONFIG_I2C) + static const struct i2c_device_id pcf85063_ids[] =3D { { "pca85073a", .driver_data =3D (kernel_ulong_t)&config_pcf85063a }, { "pcf85063", .driver_data =3D (kernel_ulong_t)&config_pcf85063 }, @@ -683,16 +677,65 @@ static const struct of_device_id pcf85063_of_match[] = =3D { MODULE_DEVICE_TABLE(of, pcf85063_of_match); #endif =20 +static int pcf85063_i2c_probe(struct i2c_client *client) +{ + const struct pcf85063_config *config; + struct regmap *regmap; + + config =3D i2c_get_match_data(client); + if (!config) + return -ENODEV; + + regmap =3D devm_regmap_init_i2c(client, &config->regmap); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + + return pcf85063_probe(&client->dev, regmap, client->irq, config); +} + static struct i2c_driver pcf85063_driver =3D { .driver =3D { .name =3D "rtc-pcf85063", .of_match_table =3D of_match_ptr(pcf85063_of_match), }, - .probe =3D pcf85063_probe, + .probe =3D pcf85063_i2c_probe, .id_table =3D pcf85063_ids, }; =20 -module_i2c_driver(pcf85063_driver); +static int pcf85063_register_driver(void) +{ + return i2c_add_driver(&pcf85063_driver); +} + +static void pcf85063_unregister_driver(void) +{ + i2c_del_driver(&pcf85063_driver); +} + +#else + +static int pcf85063_register_driver(void) +{ + return 0; +} + +static void pcf85063_unregister_driver(void) +{ +} + +#endif /* IS_ENABLED(CONFIG_I2C) */ + +static int __init pcf85063_init(void) +{ + return pcf85063_register_driver(); +} +module_init(pcf85063_init); + +static void __exit pcf85063_exit(void) +{ + pcf85063_unregister_driver(); +} +module_exit(pcf85063_exit); =20 MODULE_AUTHOR("S=C3=B8ren Andersen "); MODULE_DESCRIPTION("PCF85063 RTC driver"); --=20 2.25.1 From nobody Thu Dec 18 19:29:41 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91B13290BDE; Thu, 10 Apr 2025 20:23:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744316628; cv=none; b=XGVGPlvEIgRE5/fLKEXCH27G0TfVwVBD28q6h8rzcTp5So59sFT6PgHnETrOdIR2D/U1qfCVzlL2h9rUfGrHEu4jsFsxJFdawNi70j5nRcueFuC54rkq4eSZxMJ3ultp3J95smoN+w9GjZB7Uk79rWhp31UAa70ssQDk3nxEFVo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744316628; c=relaxed/simple; bh=29MwE5bOHbzihqKS98mIQfYlP2+1BKDsSNDg2G+7wwg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=ORwyFyIwmAx9IJwcrv7UHFTJQNCfvOk1gfeRODPo/+racSZC1YG5LEN9W8Td1DXqNLQePaErRDR85uNCMB6jFxXE++fH3vTQf9/f0DCt0k4hLeodX5CpTYcS222+UW/OeYKGlHlIzfxSoAGGNKGGYFbIDrtW6VkbzZ5HG4NQXxU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ghOgjhDj; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ghOgjhDj" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4394a823036so12763825e9.0; Thu, 10 Apr 2025 13:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744316625; x=1744921425; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2aB27vvwT7DSR/rq1zNxpJ8AqSNFk9AHof2SWw8w5sY=; b=ghOgjhDjOHsbk8gXbu4yg6Rt/YfCI4yan/8daA/Nck06gCnQsOMXg1eFxtDsb+Ijl/ hm+xYp+Zoa2R4IKjKA9qaVxwhjGHRZlofj/F9SBCPE47jwxTPH+EV5BnVqLXTtw56/Pd r5FOyhpE+2R/hO28lzQzw3YWxs2iJ1kvIm1IJBh8gILR4Ah47nbFF+pvRc4L/EGIkJxP IMZnnFIk+5zhBnEtTuApMz0oajmvYdldRNSqsnECWJpocVzlnWid5FOKMtfXXpE8kh8m +qiA8IxFJqKu+qnPOD02cUZ5r518WotL7k6x7/cf2gNln3Fp62kKq9D1eXqbuquz1Xan 57QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744316625; x=1744921425; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2aB27vvwT7DSR/rq1zNxpJ8AqSNFk9AHof2SWw8w5sY=; b=HDo1YAhkmMOiHKT3cZrHlXRu0oPn0piK+u97bjLgUab++wn16fJOKdxDzpQ5otFlVm kqbd8QRfCF174IWqOyJjgwV/r1aAxIhe5yTXBC48K8YmB+OwBCM8Yziv1CmQ3UL06Yjk nnBUZpHc78qxrlFpFI7zkOpq6tzajmrt92Vk/5ew24255o0FMQ+50aiETiLXl9M/b01z BSWCEeytnvzAUf1yowQfU0vMhCOD98RZ6uxjyb6rGZwGh/zBLOE1t2dJVyymREoIUGRB ciBV0TqSq0MwyeeYrf811cW5CJRgfi+j0YXbjsGddWJyrCBFnm8ZU4yP9WQ3g0Xcq7iF iDbw== X-Forwarded-Encrypted: i=1; AJvYcCUDanyQ/+MDNWFF7ksV6wdk8avovhhs/m5cvzzBs59hBrOgHyd4UB558ipOvNcrvOLf560VGhjJ1vQ9@vger.kernel.org, AJvYcCVrKnegaS8E3tDylLTOjPLLsPsp0UFt7HhbdzJeJfyRjZ7kPjZnmT9AZ5fhUibvlCWS3JXLSNMwxbWWYCb/@vger.kernel.org X-Gm-Message-State: AOJu0Yw3zO+N1stVjsh8EOo/l6HQk/AKuOsOZk/XHgVAYu94g3LFfPjZ 1OKmePSMB6s7n5Kw5mt3DcKPKPLLZviZMPBAv/etiQVB03AQyUM6 X-Gm-Gg: ASbGncvd3FezRPNmg1Z61qYaVgJPmFnPUf0xtjScKVExKqUx3SKKq/ZpxDIgZ4s6Xvi IY9PqlV/3QSNdbLjpnxyI8dHOVO2AelHBkbzKWfHMbU+YXts72pVKYDT7V1TESjvS6eFr4g+1fh nmBmg5N0QnwUODmz8P2m/9etAuLyMa4+U49j6IBf/cL5Ey6Pbpf+8H0yfPKBBJE60ltKvASrME6 imdELiqNKW/70jsKoQ0cJ2wxmfgi5KaPdce9+U8ezLVSh0bq4OeKREvmw+hXuzJbNegTedn+IK5 d4/3+Cjjz/IWR1+fHDW0MhTyg86fsgZz4eLF5S/3vO5uzYC9JrNfF78PlfQNUhQokSpH X-Google-Smtp-Source: AGHT+IG8eRmwUe7uP4Lvrhjpc6E+6izutYZJF8iXl4m/cVd72XyLQ5YRD0EFjcKouL//mH6R1h45qQ== X-Received: by 2002:a05:600c:83c4:b0:43c:fb8e:aec0 with SMTP id 5b1f17b1804b1-43f3a925ademr26335e9.1.1744316624488; Thu, 10 Apr 2025 13:23:44 -0700 (PDT) Received: from localhost.localdomain ([78.211.153.93]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f233c817dsm60998745e9.23.2025.04.10.13.23.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 13:23:43 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org, alexander.stein@ew.tq-group.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Antoni Pokusinski Subject: [PATCH v3 3/3] rtc: pcf85063: add support for RV8063 Date: Thu, 10 Apr 2025 22:23:17 +0200 Message-Id: <20250410202317.25873-4-apokusinski01@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250410202317.25873-1-apokusinski01@gmail.com> References: <20250410202317.25873-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Microcrystal RV8063 is a real-time clock with SPI interface. Its functionality is very similar to the RV8263 rtc. Signed-off-by: Antoni Pokusinski --- drivers/rtc/Kconfig | 21 +++++----- drivers/rtc/rtc-pcf85063.c | 80 +++++++++++++++++++++++++++++++++++++- 2 files changed, 91 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 838bdc138ffe..1b9be96faa13 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -483,15 +483,6 @@ config RTC_DRV_PCF8523 This driver can also be built as a module. If so, the module will be called rtc-pcf8523. =20 -config RTC_DRV_PCF85063 - tristate "NXP PCF85063" - select REGMAP_I2C - help - If you say yes here you get support for the PCF85063 RTC chip - - This driver can also be built as a module. If so, the module - will be called rtc-pcf85063. - config RTC_DRV_PCF85363 tristate "NXP PCF85363" select REGMAP_I2C @@ -971,6 +962,18 @@ config RTC_DRV_PCF2127 This driver can also be built as a module. If so, the module will be called rtc-pcf2127. =20 +config RTC_DRV_PCF85063 + tristate "NXP PCF85063" + depends on RTC_I2C_AND_SPI + select REGMAP_I2C if I2C + select REGMAP_SPI if SPI_MASTER + help + If you say yes here you get support for the PCF85063 and RV8063 + RTC chips. + + This driver can also be built as a module. If so, the module + will be called rtc-pcf85063. + config RTC_DRV_RV3029C2 tristate "Micro Crystal RV3029/3049" depends on RTC_I2C_AND_SPI diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index 03dfc58f4cd7..bcfefe823044 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -17,6 +17,7 @@ #include #include #include +#include =20 /* * Information for this driver was pulled from the following datasheets. @@ -29,6 +30,9 @@ * * https://www.microcrystal.com/fileadmin/Media/Products/RTC/App.Manual/R= V-8263-C7_App-Manual.pdf * RV8263 -- Rev. 1.0 =E2=80=94 January 2019 + * + * https://www.microcrystal.com/fileadmin/Media/Products/RTC/App.Manual/R= V-8063-C7_App-Manual.pdf + * RV8063 -- Rev. 1.1 - October 2018 */ =20 #define PCF85063_REG_CTRL1 0x00 /* status */ @@ -559,6 +563,18 @@ static const struct pcf85063_config config_rv8263 =3D { .force_cap_7000 =3D 1, }; =20 +static const struct pcf85063_config config_rv8063 =3D { + .regmap =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .max_register =3D 0x11, + .read_flag_mask =3D BIT(7) | BIT(5), + .write_flag_mask =3D BIT(5), + }, + .has_alarms =3D 1, + .force_cap_7000 =3D 1, +}; + static int pcf85063_probe(struct device *dev, struct regmap *regmap, int i= rq, const struct pcf85063_config *config) { @@ -725,14 +741,76 @@ static void pcf85063_unregister_driver(void) =20 #endif /* IS_ENABLED(CONFIG_I2C) */ =20 +#if IS_ENABLED(CONFIG_SPI_MASTER) + +static const struct spi_device_id rv8063_id[] =3D { + { "rv8063" }, + {} +}; +MODULE_DEVICE_TABLE(spi, rv8063_id); + +static int rv8063_probe(struct spi_device *spi) +{ + const struct pcf85063_config *config =3D &config_rv8063; + struct regmap *regmap; + + regmap =3D devm_regmap_init_spi(spi, &config->regmap); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + + return pcf85063_probe(&spi->dev, regmap, spi->irq, config); +} + +static struct spi_driver rv8063_driver =3D { + .driver =3D { + .name =3D "rv8063", + }, + .probe =3D rv8063_probe, + .id_table =3D rv8063_id, +}; + +static int __init rv8063_register_driver(void) +{ + return spi_register_driver(&rv8063_driver); +} + +static void __exit rv8063_unregister_driver(void) +{ + spi_unregister_driver(&rv8063_driver); +} + +#else + +static int __init rv8063_register_driver(void) +{ + return 0; +} + +static void __exit rv8063_unregister_driver(void) +{ +} + +#endif /* IS_ENABLED(CONFIG_SPI_MASTER) */ + static int __init pcf85063_init(void) { - return pcf85063_register_driver(); + int ret; + + ret =3D pcf85063_register_driver(); + if (ret) + return ret; + + ret =3D rv8063_register_driver(); + if (ret) + pcf85063_unregister_driver(); + + return ret; } module_init(pcf85063_init); =20 static void __exit pcf85063_exit(void) { + rv8063_unregister_driver(); pcf85063_unregister_driver(); } module_exit(pcf85063_exit); --=20 2.25.1