From nobody Mon Feb 9 05:38:49 2026 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B95F2857C6 for ; Thu, 10 Apr 2025 13:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292822; cv=none; b=nYsCzpQUOjF4EaXkqs0xbvgdZzUihTBoOPzrSfCqkMLYYPRwMPXbhf4xdkXk5JFv+lBDfUm7dd4l1HD1ZvtJ7Iv6Y0lWgna/7zlaz+ufc5ygGRG/k6aEBNLt1FC6ticH7mR4an+0eNCblZmocwtQdlzd7UHX8k91G8hvwsRJnWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292822; c=relaxed/simple; bh=VXM3Bp81TeEOJMxbuPZArd6QtcZLtq2N2qBUJQd7HSQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=YgZvzmMAqVu9oR5ORTf5PpO6ICSnUL0ai0XzYkBD/FNcbPXifeU+Zz043GDG6MPcvH26If3VqK2NUJmA9c4IBHArvwAGEArh4I9AK7rxiC30Ova+4xSShq5j47TDIA7PAlw8beJo6xz+BhRdfpv1GIUdMR+NyET4sfsoOMcVUds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=MuJzTWES; arc=none smtp.client-ip=95.215.58.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="MuJzTWES" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744292815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=9sV6wlfSmOh5YEp7VbnkVuFrtxB09pKQGnH8Qxs4uvg=; b=MuJzTWESEnuSB8kpGsHa4VdOoCykSX/G14hg93u1BC7GeUoEmikdDwGzNK+fpyK6hbkDqO A3H4IWStD9oQixIuuVNCuIZFZtQLfIw3H5c2bGk0Wc+prb/PiLdXr/qw9ZtAgspLJQOAFW o+/C84aliusmeiRC78ZHFAjxkqVhhaU= From: Aradhya Bhatia To: Tomi Valkeinen , Dmitry Baryshkov , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: DRI Development List , Linux Kernel List , Devarsh Thakkar , Aradhya Bhatia Subject: [PATCH] drm/bridge: cdns-dsi: Fix the _atomic_check() Date: Thu, 10 Apr 2025 19:16:46 +0530 Message-Id: <20250410134646.96811-1-aradhya.bhatia@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Use the "adjusted_mode" for the dsi configuration check, as that is the more appropriate display_mode for validation, and later bridge enable. Also, fix the mode_valid_check parameter from false to true, as the dsi configuration check is taking place during the check-phase, and the crtc_* mode values are not expected to be populated yet. Fixes: a53d987756ea ("drm/bridge: cdns-dsi: Move DSI mode check to _atomic_= check()") Signed-off-by: Aradhya Bhatia Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/d= rm/bridge/cadence/cdns-dsi-core.c index b022dd6e6b6e..1c3fefce5fd2 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c @@ -989,10 +989,10 @@ static int cdns_dsi_bridge_atomic_check(struct drm_br= idge *bridge, struct cdns_dsi_input *input =3D bridge_to_cdns_dsi_input(bridge); struct cdns_dsi *dsi =3D input_to_dsi(input); struct cdns_dsi_bridge_state *dsi_state =3D to_cdns_dsi_bridge_state(brid= ge_state); - const struct drm_display_mode *mode =3D &crtc_state->mode; + const struct drm_display_mode *adjusted_mode =3D &crtc_state->adjusted_mo= de; struct cdns_dsi_cfg *dsi_cfg =3D &dsi_state->dsi_cfg; =20 - return cdns_dsi_check_conf(dsi, mode, dsi_cfg, false); + return cdns_dsi_check_conf(dsi, adjusted_mode, dsi_cfg, true); } =20 static struct drm_bridge_state * base-commit: 0ac7ad5e352dcf18a4d42a4671f7cda69847712b --=20 2.34.1