From nobody Tue Feb 10 04:23:41 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 064CE28A408 for ; Thu, 10 Apr 2025 13:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292035; cv=none; b=Ph9W524zPnBzN27HCueyRBECoXCdqdxU94slq+uh8tzPcaoNnZ5sFkRUIjwNaWDdSIm9Twwkc1SetTIAGilE4PQ579LR/q5JEZKTsx5HxpciP2H4AUe9LjWgN3smymyZeso/Efsun0yymiE1xLlcWQouFPX2HT+HRxrUhn6FVmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292035; c=relaxed/simple; bh=rdXMxe9MlhtGiGrgNonK4THtQrdCLGpl7emzvcpnyoQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VL2ejV1+ZG3GdUdXuwbAlRtOxVoy43HNgmwF4E3TAA6Fic9BMoasTE4kwqs2EBA6Yr80d8XBVPk/GOE4Xyf6hEfuXeoG5sBaenYDnQUcQZJR2A/07T9SPR4PyyMMHLEcN4NZDmYyrMEQPftPa+p/++RVIXne+drgyD/Os9+zSSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ls/OebOw; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ls/OebOw" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2254e0b4b79so10488525ad.2 for ; Thu, 10 Apr 2025 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292033; x=1744896833; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nh0VanLTR8k7JGV4ABz+/PnmlXleZHArR9ROXTfckbg=; b=ls/OebOw6P4RDf6gw/517J5cbesAcDraLMJmZ+nd/B2lZoxjlNXbXDiY6rp/pOnJfW paJqi6hJAUfAwRAWkVNO9ygFw5BvTD0m7cWaixIcm3FOifOojsCQXprdnOlNSntANi2v y3Jm7sgTxXIKMwnDk2A2tTPeXh7wAIqT6dYuNqbz9xnSf/IfqvjAVjJlt81vWgy9JwnC twumPvwXb2RYjfXOMMdcKeVZ2dRi2fB2l5OJkZBqYbCeAVkoLqdSPU90I4L27qB3n+ME YHsTDwOEMAcik6AWnz9lqS6j8Um4xhF/djFZ/ifeAsflIpJMSOBtd5SZOHceu890cfR2 RJxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292033; x=1744896833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nh0VanLTR8k7JGV4ABz+/PnmlXleZHArR9ROXTfckbg=; b=YhRkqXo9ThExUWaoK8Z1BqVQtqJ91FnPEN80mDqMOdDWiFSAGOemtwNYsoEWk/XcGN n0GF+zs0rudLLMdtND8BWs1XJTGl0hrAckTxpYwtm9jZ0vOnRTnCKEyvEMMbinVDCulJ Kq05ux2/JNMIfBzxozmzA+HMyX9qjZGEOfdh2Nb9ucJFAJpY+woYHGCBk4M8IdGVY+WU yiSea55P4otRqPl/HwjbmTD6AnKKs8qnJtGBgXyU6N75W0++9SgzJ9Bjh5QuWmso+5OI FTpf5H1KReRukENwhNfP1BasSSbKhY9FiIpl0Wuu9JBJW4oTVATO77psECZxxpb4m0/M 9Xzw== X-Forwarded-Encrypted: i=1; AJvYcCUeTp1/loruQlw2pO49A8wU4OP6pdd48u/duXLwB3nrvaO4KlX+ACfHPZoHkRF5aUlsEgf2byTN6GpTLlo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy17OQPBq8S+BopePBPIA0c/S3Z6jvyYWXxBjvZAR+pBiLQkDB+ L1O61iRPnxNtBTbYQ/7rYWTzShyGTwzhpEuNOIHNbZlh20FRdnGo X-Gm-Gg: ASbGncuxfmFRZPIK8o6iIRWFLcEqsfvz665gpSW8W6LSBIcmJUV2+sJyvVFljBIDw/W Wy5wqQhwdLp0szVVs7tj2eMYiH5gtM+Nz4vBp18KPFAgy95JrKvbMzEtgkCzGHMFKM1bl4RM6Yo HpV8sxu9WiTF9nRF81OBgtvOa/Htz/65CH5j4ysQ9tS3zM9cZfVPDcF33hH5GN4vOMWQ8owRzPp m27Sv6kDwSTJ5ci2oYjomEicP55tZLGg/vaeSoTkwNWLya/dJvXQSsmEA0BcheeMUL+KYt71jcB aMhHbIHfghx3lSHkUYEOuKv2tfkjdusAmLKAtnDkvqpBArbCU8bHkWA= X-Google-Smtp-Source: AGHT+IEhJosZc1PPq47EzJpgLKAV0sW8OUksWP/T0By+TlgLPTsHhEsBRkYklsNnL3vMaEPTFuyMZg== X-Received: by 2002:a17:902:f686:b0:220:e655:d77 with SMTP id d9443c01a7336-22be03cf8d3mr28766255ad.36.1744292033274; Thu, 10 Apr 2025 06:33:53 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:33:52 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 1/6] phy: amlogic: phy-meson-gxl-usb2: Simplify error handling with dev_err_probe() Date: Thu, 10 Apr 2025 19:03:16 +0530 Message-ID: <20250410133332.294556-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-gxl-usb2.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-gxl-usb2.c b/drivers/phy/amlogic= /phy-meson-gxl-usb2.c index 14ea89927ab14..6b390304f723c 100644 --- a/drivers/phy/amlogic/phy-meson-gxl-usb2.c +++ b/drivers/phy/amlogic/phy-meson-gxl-usb2.c @@ -237,7 +237,6 @@ static int phy_meson_gxl_usb2_probe(struct platform_dev= ice *pdev) struct phy_meson_gxl_usb2_priv *priv; struct phy *phy; void __iomem *base; - int ret; =20 priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -266,13 +265,9 @@ static int phy_meson_gxl_usb2_probe(struct platform_de= vice *pdev) return PTR_ERR(priv->reset); =20 phy =3D devm_phy_create(dev, NULL, &phy_meson_gxl_usb2_ops); - if (IS_ERR(phy)) { - ret =3D PTR_ERR(phy); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to create PHY\n"); - - return ret; - } + if (IS_ERR(phy)) + return dev_err_probe(dev, PTR_ERR(phy), + "failed to create PHY\n"); =20 phy_set_drvdata(phy, priv); =20 --=20 2.49.0 From nobody Tue Feb 10 04:23:41 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CF968635B for ; Thu, 10 Apr 2025 13:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292041; cv=none; b=Yn4noHUYbvJSFxdlz7nSGGqNoNUtqzjzFFgxmG+smLTs2xMD1MPGlJaXnDXwG+fNCrpGBZ7vD3E0nbbPKwy7Y1WcrxtgOj6qcFi6s+fb70kquRVni5ChwIEz/VKbGFhqimqIsh5nc0GqdIlzN9/96hjkxwMoBS+zC6gthxKXpWA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292041; c=relaxed/simple; bh=P+UQu2wMMTTQfmICTnasM5H76CMpVO5irmZ+6VVgnUg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gIAMRnD9LRFV1NftsgyChuADRBvEEffoAjfaWnoXW3AeHG1FHvLkTYSdY5jE7FonYQQRglfBXivz6sMRynEBjT6Gq2MJBBNXqpyoDEP7OY5q3+EcL1ztCQi0I8DV97DLYmHgptqRckzpY5wa8uUahL0aJrG/0KsVwrwGpy11PWk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e6KyaLLa; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e6KyaLLa" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-22580c9ee0aso8012265ad.2 for ; Thu, 10 Apr 2025 06:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292039; x=1744896839; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t7/MnhQ+XPTlJRR1H/JsR3WjkkF0jznVuDOQtTNzl7E=; b=e6KyaLLaLBPbo5pG9t8IkpliJK70IClriwc/4bvvGDcXXYQ1Jyw4EEleiPjEpe9UVq YNjxKJjA0OLfB6EH4DYSzdI1BgFaBHGhxV3P4ZaLhetcP8pjl8K17yWp7Aixpxwjoud8 DNsjGGa8NpUfNyK2CtkcctNTSS+MVpHh3nfJlczKTrN7ZId51hMBUqteiRxwWaQDZEK3 QX+nfTne9zReBe3lAW6Ti0lq30H15IG5FSmIX3IWv+ajKuOv7z+mUDTqXVEaTUcGTF1i h8cebOdqgMQcHVfBauZlCnLrrZceXyrWn3WZJaOulMAxEZDbBtBwOBOa4ZR2LrTTMeu/ wmAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292039; x=1744896839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t7/MnhQ+XPTlJRR1H/JsR3WjkkF0jznVuDOQtTNzl7E=; b=h25am2px6wcEZNa7V0Kzg8avRvptMKUxDXEH3jVZm0BBih1GghivgrfB3RaOS83Oej vBh8CdHV1pAD5+UK+IomkrAvaoSy7wA21f6TPxyCNHK5LifI4awPgGBcxQY9yyAQEAgw 4PJy9qncSLCRbkTDM6FP8uZ+aVGLESWV2cIJ3mQe5k2Frmve6aa6z9I+j4nlfCmC9di6 EJE/0Q9MgCuRnbwwVpnlC2ZT4QedtZ0qXVg7mcdvHs3fSpubBnBBIC+ukYWoxvyOCbwe HkhC3NIa4M8375BRUM7soJKnnVX1gmSHpLOdjWjiABdr7n0jmmXg/mwTSBFyZbkyvAgW +VbA== X-Forwarded-Encrypted: i=1; AJvYcCUfmTsd/WJDZipHudYVf9Bh8YVfVEoOdeB2SXq2Yow61gnSGSkUxf9g+RTpPuPS1fRHkGTpNGTPwol5wDA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy99hMe9+MCdAyWV+OJT2B6nqzrzxHht54PMnBHb/Vpu2LxdVM4 H9lp+7AtRU2dadhdVh64pB9FQCqG5E977Yqc0n+Q/nvZgLB3X8uI X-Gm-Gg: ASbGncueRBspTPDfD0fKR7VoVFdGZcPXYIhmZDaJwufT5WTd8GMsKx11xjwBAr1yKdj i/wThSlR3ySDnE4A6W+/ol7257AdYlelt75g0RYDH8ZLoUiBb4Gix+383vStomhbK7fk6Vaqt2G QmBfY3gkpGeh6jHZMmHHYqk2wQx1EUbKw/IG6tma4Dp7rVsTt7uxma2+f3zez9rgvspsswxs3pK cpeaCAoXU9MhE2xBpN1cE9WG8R+G5R1U+2CbW/WYIATQsG9Sa/+Ijsk0wpSbSYROhIdVqU6MFeC K/VCD6I4p0UWIoFlDcQcSA8CQ2QizXmn2S0KWlxYRj3BUCMZVICxWJg= X-Google-Smtp-Source: AGHT+IG1oHEnhJcJPMpJXFVc2lblDNzFL0NCm1/z6pryHmDc/E60Sjg2zPGvf+IjlruZt6r44yNjmg== X-Received: by 2002:a17:903:46cb:b0:224:a74:28cd with SMTP id d9443c01a7336-22be03167bamr34974705ad.31.1744292038682; Thu, 10 Apr 2025 06:33:58 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:33:58 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 2/6] phy: amlogic: phy-meson-g12a-usb2: Simplify error handling with dev_err_probe() Date: Thu, 10 Apr 2025 19:03:17 +0530 Message-ID: <20250410133332.294556-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-g12a-usb2.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogi= c/phy-meson-g12a-usb2.c index 0e0b5c00b676f..66bf0b7ef8ed3 100644 --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c @@ -339,13 +339,9 @@ static int phy_meson_g12a_usb2_probe(struct platform_d= evice *pdev) return ret; =20 phy =3D devm_phy_create(dev, NULL, &phy_meson_g12a_usb2_ops); - if (IS_ERR(phy)) { - ret =3D PTR_ERR(phy); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to create PHY\n"); - - return ret; - } + if (IS_ERR(phy)) + return dev_err_probe(dev, PTR_ERR(phy), + "failed to create PHY\n"); =20 phy_set_bus_width(phy, 8); phy_set_drvdata(phy, priv); --=20 2.49.0 From nobody Tue Feb 10 04:23:41 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B7F228A40D for ; Thu, 10 Apr 2025 13:34:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292046; cv=none; b=fhxPbwAJrdFibcH2aTXuUGAtN9tLJP3ZUzg/1xQ4naRqlwhGaOITNjlS+EQKAPw0u8GboclMjmF5GVpWaanJu93YGgapPCbyv1M3m9xYckTNPY5ip56KNn6tpU2u/x6w29xHxGqx+oKRsx/8NQtX3NKTwHW3SCOD00X/UVPfq4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292046; c=relaxed/simple; bh=+iwC96jwlb8lQZDN7MMp+YNgpicBSru9Wsh/4/g8qp8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qh9KHJJ6/eo0Bs0URWFc3CiZ3qL/9shmgcxy3cM/Y+4qHpLxvt2ZZzVw17A9TwQX8QiY6NhHobka90qhDc59p/dvLU5hXCtwUcvItQBTQSGpGD4frEK46Ia1baDpmXFCKTF69AzQYLngfN2IawYloxdXZAyvRWRMgEM1JTwSWsQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QCI2dtvH; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QCI2dtvH" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2279915e06eso7896415ad.1 for ; Thu, 10 Apr 2025 06:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292044; x=1744896844; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ppfroywA/WF+8dvpxb3LW0A1l9sdjedjaaEGMEvs0rQ=; b=QCI2dtvH/nq379Qp86jvridWaTC1NVecQL1lHoLzlxyL0QSJHu9r3o5QEqYuiU8Kdy 2jEXxKafoFGmIhaYN669h2uKabsT2Uf95Ag4DXVrmIAOXEooOVaAu5zX3YMPykQwZGO4 8Gf3FxKTzOC/pKLBfCIatnZYzdZuYVMJpSduTxPk4kn8/z7AdNInem8+0nUYhhUnodjr NqKHYBzTkn/fTK38o/9s9BDtd7s9QP5eh7KKtOF4FfNEVp0JlmRgUDQFcYWKRw3DILlz IyUgYxlXH431pRt94nN0AFB3otVEFjFPqqT6zLUvcCcKjFlcRj6+sajec4nEgguk8h8n IW1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292044; x=1744896844; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ppfroywA/WF+8dvpxb3LW0A1l9sdjedjaaEGMEvs0rQ=; b=lBNMfseKxwcx6A/Rq4i2X3yEemNHhjfvpX4mdy2lSHncBhSQcaiIsN6mldfvpPxPKv UgU4H/fnaKoJK0KSjIJV1ijayKNUqYnAuGdDrw4r9qjfNtsDNELESZjAISIkecw1NwJ6 zWMmrHsj/GEGekRBgfLBjzyi7C7cMZXYeISaZ4lGRGegKTcmSQ7zKtbtSiv1GbBuGxBf +AiSVRJN9BtJDwjICGGL4NCpPU/A6m7zM1f5QrvFiKzKocOn4deFIMDsq2mwzEXzm0tZ WtqbpySjxCGurAAex8eaZDqWJszGf1DoEcEDxl61S2ZOOZBJoZqLkx/1EyJyyE0xLWXM o/sQ== X-Forwarded-Encrypted: i=1; AJvYcCUjPBE4n9/9aK5BopO+HS3S6OdKNmtVj4kt65u9ToLipYDJAgoozYvpwni85ypWA8M9WI2S5HvTPaqX5A0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz41/8O+aB8ZLRD42CTNffk1ypl9gY7PUDVwqiCheMWSOEvXM4/ 5HApmEfd70UF9FV13uMh1t+hBjWkOgcL8N0cFzWPAgIsrLUey5Bh X-Gm-Gg: ASbGncs6ih3WdCNiJaA90CowbWqtPkG8zLanSBCDuaItAzl0erTHTwLwjqCiCfrx7WG 5vb8yMsVk/JQaK/D5lzWTaPDEigLYcVtU9FB1xngiY28QQIxjd2N+QG3GjUc/YbPCn+GqpVgABA S3njRNPE7AA2NLCeihdsje3PgohA6zNFnRt/e0ijQ6uutFuSWw+vmti3pRCEFKgBsW72wvM8b+K szWVyesinDUGBgvuEXzkILeZMH0RRRbwMjg9p8N8idZvQxBKSpQS8qP5p9jMYltdTrh3EQOJ5Z0 gB5AmyPlPSGNjSO88018RF8xKfhZEpXudRAhzhdwLf/WgNQpKccI9BU= X-Google-Smtp-Source: AGHT+IEx7fjFPOwJFBqQcxYwcNEjjXqC0n7A40gc7RBPd72Er1kad1UbyK8eNmLCNZzCP+fmYv0iMg== X-Received: by 2002:a17:902:db01:b0:216:53fa:634f with SMTP id d9443c01a7336-22b42c44052mr47156885ad.48.1744292044230; Thu, 10 Apr 2025 06:34:04 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:34:03 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 3/6] phy: amlogic: phy-meson-axg-mipi-pcie-analog: Simplify error handling with dev_err_probe() Date: Thu, 10 Apr 2025 19:03:18 +0530 Message-ID: <20250410133332.294556-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c b/drivers= /phy/amlogic/phy-meson-axg-mipi-pcie-analog.c index ae898f93f97b2..c0ba2852dbb8e 100644 --- a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c +++ b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c @@ -200,7 +200,6 @@ static int phy_axg_mipi_pcie_analog_probe(struct platfo= rm_device *pdev) struct phy_axg_mipi_pcie_analog_priv *priv; struct device_node *np =3D dev->of_node, *parent_np; struct regmap *map; - int ret; =20 priv =3D devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -219,12 +218,9 @@ static int phy_axg_mipi_pcie_analog_probe(struct platf= orm_device *pdev) priv->regmap =3D map; =20 priv->phy =3D devm_phy_create(dev, np, &phy_axg_mipi_pcie_analog_ops); - if (IS_ERR(priv->phy)) { - ret =3D PTR_ERR(priv->phy); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to create PHY\n"); - return ret; - } + if (IS_ERR(priv->phy)) + return dev_err_probe(dev, PTR_ERR(priv->phy), + "failed to create PHY\n"); =20 phy_set_drvdata(priv->phy, priv); dev_set_drvdata(dev, priv); --=20 2.49.0 From nobody Tue Feb 10 04:23:41 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA6E5257AEE for ; Thu, 10 Apr 2025 13:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292052; cv=none; b=gQqgivYjfdryCukwgs15+Gwi1qJyttGjXOi6WnYF0pZRdBWBfMhZxj3SJkW1EQJ8Lh+ALgdmCqhKjdfuihwyuO9Tdlh1S851YvzaVxx9OaQ49B5hMQBqY4CYTuxMSLnSzk1kPTCP84Rb0JHKlM8mpK5E+hMzo0CQs5kjXgjEtv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292052; c=relaxed/simple; bh=c5zYOZZjjF1uCMgMgn0by0b3LS+K42JKxaRgPU5T4mE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fBMiKaRtd5Wwdi9xMCcg5rHrKh44wEf0PEFiC01dBvkcFaPd37sRIRenzjUVF5UxuvwM+LiRdjWCC4biapOZzOFM5TjfkQawdn0oNWCXEZvoEMb4TWV3kB6XE20TG+hvUZjRsEKyqGkAixwuAzCqpTXfH29f2/voFErobTenKks= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TGLk62FV; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TGLk62FV" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-227b828de00so7129405ad.1 for ; Thu, 10 Apr 2025 06:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292050; x=1744896850; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ie2WYSBT3Vb3/RLr/kVYn30UdEBVb+2bXcwDKP51ids=; b=TGLk62FVlCkDP7L8Qm8pIaqRjyCj8M0JBZ6W3siETkmkHaq3tFZpUH5stAiNzH89Ez OY2vAz/YZ1EUpoCajPuOLsxCccE5L4qfVvWu70ai/lwn9EMM8Ln0nPqLC3gCniQ/hcw3 eiQyh38V8e9DFq6AmLXJs3KegWEvpC8W5S5ls04glRIhZfsU/pxoCo20z1emWsHdZn8i wfiaLQCSdhoSPMk0/2lYYM7NFPEVVaEbTpCnRbsN64eNhguSmUx/EvvBR/6WOQ1T2pf7 7iu31FMoOR2oLVp9ETpeeUe1BRiU1ICiHzupEL5894+c4958S1v94PQLY8GYcsfvnI1E 0qWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292050; x=1744896850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ie2WYSBT3Vb3/RLr/kVYn30UdEBVb+2bXcwDKP51ids=; b=Jp7rHbNMjSqIzHYdUc4PTviHt2prGiOGL25ISi8JCRuMyA6VNJtbIzdi3Lr0UZ1HRS QyC07RsHltHjBe9Kidaf09Fw9KJh7yUdzP0n2uVgGbfp8gVOt+uIFHpmNhTm/UTT4Z1q dDNEi2gWCazZMXEJemgz33iP6xVLsi0qpTpGmISKG/6Apf3fC9ND7uDhGHfCDoqtRXLf B5/+qSHhsJ7m7lSpXOwnwyUKOMyx0ljwcOUD6PhKnHBx0P2c9/aKpM9TI2nbnqax5WrO OF4WWfzjubFPuMviTf8j3gh4NWPVyJ/HQsvd8FqdlZIXcXz5XWb0P9GMDxzeK5N9iZpA HfCw== X-Forwarded-Encrypted: i=1; AJvYcCVLnhDY8YBzc2e/QvS+JEe76Xel76EEOj64jB2lQgzXce1rJs81E6JYo4h+x3DDMLO5lJj+0kkvmKTUQCo=@vger.kernel.org X-Gm-Message-State: AOJu0Yyn1+hHnRfQCqGIZVliwGfV2dJCd7H72eSQ585gRfmhSe1FB3m8 BlUm/dRW2TDn8Oz6DhV4RRO2bUeu02yOmIh2p/DS7a9dAkv3nSAahia/Rg== X-Gm-Gg: ASbGncs++r+zt0JU7uOMUoD8gh0XGgJ3dTbCcanMSl1qFetR+3XwQBJBECN9BSZD9d1 cG2ZwiuMpUnWyixBSm2jJMDpMqRKIwvLg9U3BdZGGuvSf3uuuOZQNvTcE+AdiD83pfMXuvqNkdY Nvhno/2MUDnb0SKUvGuTCr3pO4yBSsODI9Sfc/WalSo5xvybFASLkxMayAFTa6E/9yjc2as6Mnr iM54ixickKQ2XllePIQdlijqD24yRvqlW0JkdefhHLXhe0o/+8imly5wV6LWWM+/3m5gHuJh77S /wQT/ST30qMqplYXAGqt58pb8FsHgPZIoKE+nQ9Hgtiq4jhqeW2klWQ= X-Google-Smtp-Source: AGHT+IFebE9GR8x4kSqiJ5cenp/8FxgShjyDitPJ8W8qx7xYFtufybCnsYQR0VTIIrJFw2c46H3Qfg== X-Received: by 2002:a17:902:d2ca:b0:224:c46:d167 with SMTP id d9443c01a7336-22b2edceda8mr42616955ad.16.1744292049826; Thu, 10 Apr 2025 06:34:09 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:34:09 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 4/6] phy: amlogic: phy-meson-axg-mipi-dphy: Simplify error handling with dev_err_probe() Date: Thu, 10 Apr 2025 19:03:19 +0530 Message-ID: <20250410133332.294556-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c b/drivers/phy/am= logic/phy-meson-axg-mipi-dphy.c index 08a86962d9492..c4a56b9d32897 100644 --- a/drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c +++ b/drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c @@ -377,13 +377,9 @@ static int phy_meson_axg_mipi_dphy_probe(struct platfo= rm_device *pdev) return ret; =20 phy =3D devm_phy_create(dev, NULL, &phy_meson_axg_mipi_dphy_ops); - if (IS_ERR(phy)) { - ret =3D PTR_ERR(phy); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to create PHY\n"); - - return ret; - } + if (IS_ERR(phy)) + return dev_err_probe(dev, PTR_ERR(phy), + "failed to create PHY\n"); =20 phy_set_drvdata(phy, priv); =20 --=20 2.49.0 From nobody Tue Feb 10 04:23:41 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1864F1372 for ; Thu, 10 Apr 2025 13:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292058; cv=none; b=DdVmxk44pBl49PpmOK89bjbN6BHa0HtC7CIi6KjhMk2iIPZrq2B+t11ZU7QDPIXb4R73wNaQsWcF+ArGnBYvhAy1xE5LR/OekxCqWl8vHk1o79mgx2ujKI5rBQV4PtzGu7cV91+NN8grQ3l4lxH/d7I8LuVoLL8/GSSXqaYQbZ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292058; c=relaxed/simple; bh=aUEvH8sTZK70D0w9K8q+BNCLK9IRIEnnqv5/uRVHSt0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rt/KYrT9cFEb/4VAtlEuuzQpq7z61BOsD2kqZNaODpr/VzwYmQ4rJ+IYXNGiIZM0RFbUZwL3pMlCMembE61O+kTgvVHG61VPNEKJggv7IrC6DvbMe3LaAlhHM4nhE7vQKkc3BvwNtQIbrXD8dlENTUR48Ze6YmD4kYbbz+pN1J8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aoBxWfjH; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aoBxWfjH" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-22401f4d35aso8932465ad.2 for ; Thu, 10 Apr 2025 06:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292055; x=1744896855; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DxeSbPIzszjGnSvrpOvcwkfeAlvfBRAjswzSiZSoXzQ=; b=aoBxWfjHnafyxNyfkBa0lPcpdKQvFvju+jYXtQshVXMkzLj3W0Oxy6A60AzBxL8Z6Y oRHKsTJs9GT8U0CrxvPB/R1sgGrAHx3G9I7qsrfQTGc0KkId+NILUL/9XSD6edsC9rcQ fJCYgZTBQwfxsk/qiifw7f/0nOwXp2qiVg7mMEy3twNfSlAYrhpKBA799jNgKdgid9l+ uZcTjvCuIKiBurcf+zVJ+3Z95Bi8VfOdqFljRxreaysDiyw1NfiTj1DrOR0CVThY8GZY p7dTBLtCagN0UIAaHRl+Fh24kshl5rueejfbbbnvEY3UMdVBxDn/EvCnNtKHgnAMHTLg TzuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292055; x=1744896855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DxeSbPIzszjGnSvrpOvcwkfeAlvfBRAjswzSiZSoXzQ=; b=r+10d9D0hI5XM28CVrC/x/eMhndBk+uOe3OCehjoJWMcmPpE43o5BDJb54ua9sAy1y +ZsVraWsGKnuLFMnoS4QaBOHSv/dvdNRYqUlsSMLC2xV2O4DD4wLd664/yzlBtz+GaKD 8EOaqj44tx4QP33dtPqCLYiMOQbiYEvdHnNSYs6ilcYmT50SLMvi6wcyYjT1xJtNul35 Ay7/PJLYXTh04kwR62/Jn4GsN9ZMaG5L4wSYdiVwLk6UQ9VcK7KIdIlMKL3NrH56N0Qu 9xJnXdUPOvsUY6N5jtvWsQQUVQ4VuK2DqxaxEcgwQJlmdARlTQhjFV8zXj3w3rI23YjS 1Lfw== X-Forwarded-Encrypted: i=1; AJvYcCUkBbiHx7aJEzC40aapu5/xw9zPOApJZrxyW/I82/UnbtOeWj+xbDaZdg4Vj6Gmm+FixweuYXIcvQjsOa8=@vger.kernel.org X-Gm-Message-State: AOJu0YwZHw8NqYIpRlr+ZuKBf2d2JzX9S8Fucyjo1Xq1OO6YS40+0DjG XaxQgT8gzry/vWSknSR3RWSJUJ/nAbz38WLliHUaKQBF9k5mupZq X-Gm-Gg: ASbGncu27DmGMb5flM9I2rp2BVkCNvO7P9/OeoxAsRy6BvPc3254j/v4I6XyEwPCzcj CYGF59bqdQIXpaZNRlosUlleUAOT2pb1ZAntGno8+jOzICGt7wLRZ5G3gEts+Tee29uvnp7OhMk +wdtvTU+MQDE+ZLxbnQw+/n2USmDbSRqBVwP/+vplkRQF1cDExYOTGw2GxzDSlUYWhfSCNRD0RE SDLj5oKutoSzF9Jmzw3DCWHu4Z6jZVvQt2a0As64J+g9azKwMwoVRbIJJLZ57AHlXAcvZRbc6P/ syNU+nA2cMdR46no8NV8RIR5UV/4qKaXEosxa7P2qJspUvpG5EFFIhg= X-Google-Smtp-Source: AGHT+IFfGKT+CjmFhjdjDFWm//5beQJ4RbUV7i3qqJwAHO8GX2iN4WUrgtrevE+4mbbu/BuXURpkQw== X-Received: by 2002:a17:902:ccc8:b0:223:3396:15e8 with SMTP id d9443c01a7336-22b2edd1cb9mr51008155ad.22.1744292055287; Thu, 10 Apr 2025 06:34:15 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:34:14 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 5/6] phy: amlogic: phy-meson-axg-pcie: Simplify error handling with dev_err_probe() Date: Thu, 10 Apr 2025 19:03:20 +0530 Message-ID: <20250410133332.294556-6-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-axg-pcie.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic= /phy-meson-axg-pcie.c index 60be5cdc600b3..54baf7b8930e1 100644 --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c @@ -131,19 +131,15 @@ static int phy_axg_pcie_probe(struct platform_device = *pdev) struct phy_axg_pcie_priv *priv; struct device_node *np =3D dev->of_node; void __iomem *base; - int ret; =20 priv =3D devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; =20 priv->phy =3D devm_phy_create(dev, np, &phy_axg_pcie_ops); - if (IS_ERR(priv->phy)) { - ret =3D PTR_ERR(priv->phy); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to create PHY\n"); - return ret; - } + if (IS_ERR(priv->phy)) + return dev_err_probe(dev, PTR_ERR(priv->phy), + "failed to create PHY\n"); =20 base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) --=20 2.49.0 From nobody Tue Feb 10 04:23:41 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BCF828C5D8 for ; Thu, 10 Apr 2025 13:34:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292062; cv=none; b=QmQm2O5ihvA41UrNStOz4sZlA9BU76VD58pJobM0QOe9jQhMX42arrjhw+XUX/OIwLpZRHscbtrJSVhb/Y4pSPM3uZyV3vXc/r7hIiTkxCqTHJ27oN9VKiRl0AKOU+NL66SResE4Ewkdur7aorcJDjZi1GeamAKM1IstlrEVReQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292062; c=relaxed/simple; bh=H2/UX7n+Kzz47tTU6RvNuKVCWo3ZBMBdtcTOcUn9WSM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mYUKhjR67zuWv+IgWW2+Wf4Uc23mXYGjwz8uJwuTEAFZueWWEJoLTPy8lfYwk+GWZwaJqM3rvtVKCOJjca969TIVCpuTbdGRarS5JVHZy7IVrr5A57WD5BE3NvX4A2gnOfM0TTWFanpjXAF8n3V1PS8EoryNFSC3PCqpA4FTe00= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DU6gh5rU; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DU6gh5rU" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-22409077c06so10880575ad.1 for ; Thu, 10 Apr 2025 06:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292061; x=1744896861; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=snDm+R9HSu34qLr874FxLnOvyHahTzryBYCxyI70mec=; b=DU6gh5rU5lG9r/QDIdiLanZDdMBbO3W9iStDKbojfhCuxnfI3rH2Tq49rum9j6rSWo 3npQbaTqbpiwhPNYgf8gakf9OCIh9Hr0d/ASAOz2Ou3La6qp7ygH2aWSwT1whEMJbgmc ernraw/jND0enOPe/SQa/VVzW4DeTB9Mn8hUrVTmGxMQTnquTn2XaWA4WWX8pkV83tiS kdGHPkATVRn3HhlflOYMOCwsss1tNN947sbvNfN6iHbODH7rRlas8pX0L9f+vTPDFQ6k gpJSA6vQ6XKNR1PMc0SYfDCvwU41+Zx79y8kkLa162uCaaI+H1KnDO7uTtaVqN1bNHJC FloA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292061; x=1744896861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=snDm+R9HSu34qLr874FxLnOvyHahTzryBYCxyI70mec=; b=BAEVwYyRVKocI4iXxdNYnQTljkSS4oC0bz/MaYDm0GjPdU+mtHiwml/W3CPjXhYP8M K+lTKeMIugtYA19KreICaon+kWVZ7uSfIV/rIB7e0pVngrIUGVJX+/JTNN8iXiTAx4Kv 4ek+Bg/RCWzjBBzEnbTLE46cZDYNAlTEf50syqkfNhptxT4n5b86WOGaAWSKOy5Xt8jh 46OpdNZwJ8lRRp9IrCcvy1DzEfSQa68sekfVPTiHv8u8X495SYbAMtCNKHfDCM2fxkha avYP/viEmTHaRe3M4rn31ti/4a903H6q/T1YwE7HB4uAVXF4qixiJ4hVNiSBYqn+N7Q1 d1XQ== X-Forwarded-Encrypted: i=1; AJvYcCUpGp1n6YuH8x7DIUUubW/GaSSwVJOhvF9jUeJDfpfsNa/fZnYoF1i/Ys8KiH1uIbAmwKUo0geT/AtJO9g=@vger.kernel.org X-Gm-Message-State: AOJu0Yxtx+0Y8DBmUnD63SJV+MCj900vM2gyNaOrfQXE0cx4D//b3bfP +oqyNS3inGOG9MhmLcZ2RjvIvAnUUJYwzBBzG5ETaShLBeW9oP/d X-Gm-Gg: ASbGnctZUy7I+oUB0bjmXx0QmGayMQh5t3s77/Fby5gh+rIOBdEUfshNCsDMi8vtQGQ p4LNMVodk/L7ly/gsSczF0POnhON0Yc0cpyAZqMl/K+vlwg3A1bNzYGYg7lyC/0COdsmWiKT2CP KQHBXTRxIRBTUOTwVEyab1no8zwA99hcQkgHdflldSBdeHlfByQ7+326gf/ksFkPnHKRf57qftu MDhp6FdTrIh0G8dpd8WWcjZu5ILN0UqLedSMId+jiwS/MRCPdls2XlAv00MJZN0yfo0RbD1Yxt8 hLMhokH3ouovoF575o9FiaAjbOt0lnfawi0uG95IVbJrfUtNCv07OZc= X-Google-Smtp-Source: AGHT+IG8FTT4kfyWPBOyAb7OIrEAVZZGG4LdxWb3S85G2ZZGHkha/cC8RTwaJM0VFBFY0ZFSfbmjFw== X-Received: by 2002:a17:902:e748:b0:229:1cef:4c83 with SMTP id d9443c01a7336-22be02d9318mr30954625ad.4.1744292060733; Thu, 10 Apr 2025 06:34:20 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.34.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:34:20 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 6/6] phy: amlogic: phy-meson-axg-pcie: Fix PHY creation order in axg-pcie probe Date: Thu, 10 Apr 2025 19:03:21 +0530 Message-ID: <20250410133332.294556-7-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reorder the PHY creation in the axg-pcie probe function to ensure all the resource is mapped before creating the PHY. This change addresses the issue where the PHY creation was attempted before mapping the necessary resources, potentially causing failures. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-axg-pcie.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic= /phy-meson-axg-pcie.c index 54baf7b8930e1..14dee73f9cb57 100644 --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c @@ -136,11 +136,6 @@ static int phy_axg_pcie_probe(struct platform_device *= pdev) if (!priv) return -ENOMEM; =20 - priv->phy =3D devm_phy_create(dev, np, &phy_axg_pcie_ops); - if (IS_ERR(priv->phy)) - return dev_err_probe(dev, PTR_ERR(priv->phy), - "failed to create PHY\n"); - base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) return PTR_ERR(base); @@ -158,6 +153,11 @@ static int phy_axg_pcie_probe(struct platform_device *= pdev) if (IS_ERR(priv->analog)) return PTR_ERR(priv->analog); =20 + priv->phy =3D devm_phy_create(dev, np, &phy_axg_pcie_ops); + if (IS_ERR(priv->phy)) + return dev_err_probe(dev, PTR_ERR(priv->phy), + "failed to create PHY\n"); + phy_set_drvdata(priv->phy, priv); dev_set_drvdata(dev, priv); pphy =3D devm_of_phy_provider_register(dev, of_phy_simple_xlate); --=20 2.49.0