From nobody Fri Dec 19 08:25:21 2025 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 504CE20E032; Thu, 10 Apr 2025 07:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269498; cv=none; b=e9qjxIl4vFFg1wk4amLLv0rFgS70Y156utj5NRP/ULgJo60Vf4ccYtEmPrNjIXXpSUaz8/N/xCZOn21rXQAQOer+EyAtRt8lsJx8cde9NgX90jUPrpPbDaaceVCHjgF/p1/UruoLgdR1fjftc7HJnk2YdPaLfmWPgHEaeoSIuAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269498; c=relaxed/simple; bh=6SgfvwQv5FBg8s1TO9Ad3KQChhb5Himk1suKQuXSsA0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YY2iRb7jHUZTtMIt/E9+Z0R0+zOuTHcItf/wIMcJUJ7wE7l/CNSm1GqDk4Lr4qI7w11D8cSW6knlZx1ObKIyV+W5PrEaRI2qAHZi0ryZ4Q/HgYLXm2+iMVrCAbsrEfRv68OvZZ3pYm7IjtvCIA87O0+gVecj0uurmngnB8lpckc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=ZvLY403D; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="ZvLY403D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269483; x=1744874283; i=ps.report@gmx.net; bh=6SgfvwQv5FBg8s1TO9Ad3KQChhb5Himk1suKQuXSsA0=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=ZvLY403DgddwcknCOyJGWlNqfdrx6OwgOtte8l61OU0lj4Gfg/8haGUmqtT4EFc8 wGHngCmjOPr/i2hiaEmnajk4IMpzEFQfew5K2p04SXU1LLe6BX07GbqDHgDUCWUsM 4c/b65zK4MtqRckNnhRvFy/VhL6z1LlUkgSf0z8XVzH98Xl9WS2madpcu78Cyo3aq aoE4VAjBYdGCSobacR6O+tXQ22VmWlf0uY/dcBuTS3pYTpnAx8XCN420uKHqDK9MW hAqYDJaIsHpaklowTov+rRYvW6CzMugsKgdzUKf674Rs7yz79KhfMvsF1JsW1vcdV Cvy3/kiG5Bva9CI36w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M42jQ-1u2mAk3n1M-000D2w; Thu, 10 Apr 2025 09:18:02 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 06/11] net: pktgen: fix code style (WARNING: Block comments) Date: Thu, 10 Apr 2025 09:17:43 +0200 Message-ID: <20250410071749.30505-7-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:hJxJH/bnaxYOV77W11U2dX4DhVtAXzYuTXigP/eZM7tnL2bWhcc tC/CnmZ+P5BfUB4RTRxdBbCl5MATmeTYdESFetOfUE8Uix6wjkq7LEE6zRy8z7MWsPcbgzT AyUM5r2U+CJxnj6y0oqrP7tm4YTwd6QcONvtEd7cSx8ZuNBhim9uyqxWnvthR6ikxbgMi1w RAT1XqssbcNgEdbCuTBhA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:hy9D6/AtdAs=;U3H9Fx89zC3+C3He3LJk8QPXoS7 lIcbi5KpBJ9jw5h/Ww7JhzNhAvIg5mRMuBr9yGbL/eNyirwO9uOGSeTd2E1o9H4k4IOeJL+hA tPiei1f3ywnQnnDMbjTL0VMMqjWBTOOiQpAXxxzM6m13MP7oJlhdE/Esf3dX5vL9sC1OBdcm7 ZbV4p+YqsKG1A1QYPUGwdUZ/m8XLlLY+jPk/Nit1KEFeriDWGpkyG6AR78+YS2E99jD2s9Tht DJmyJ7ASvrLgBErT1F5AX6ho3GTEOwNfFgaoaYPWPAimVCldlSKxMH0UUvwhGLF/zoO8pP85Z U2887h8bVTaF7uVk9lka0SoG0YU9m0O/oYaFg3xX7fm1Z3Ky9IvHUy/bwrz0AhQYgpgg8PnuF 7HLCsB18J6ddIubHayAkRcO6dEMWQiSaofT3nLI5oIL/ZemugkxO95UibR20tXIhAZJgJN9rk tD6AcXYaLSZotCUnKAhx8MbbS7HA9O1jgJBOXDUYt1lTiKAPthBFs3u/8w0LHuyt4tAgOtUIy KI/l7syGZod9QP5EQZk40kJE6r50pqHzNOXWL7zepRH1QxUdEN7FDJkYZw0nqHo3cn5wuRIx6 S5QD5CTFD05yX9j9LNNDMitOvG5Y3mwATEMZVY2aMp/kyHxvvRzhWZ9O+FkIlxWtuqDpwNwh7 5rIvM1fUewEZzFK7lIsWF93W8dc2VJehKrN/ejVpHOFROC7EBVxRWr+OCoFkqBlFmOus1YlKR Z+738fbh3WdKr5FXBSOVJ9FxdfYuU8bDY7xLn/eMYJBn6kum6U+i4VY1jCrZ/WPqMSkoPUsYW 2HMZ6u6r8VUT/YlsGVuamry7gE3glc1+xLzhwFuWh3TeCfdB8ouOeEtEoAiZvUWh+gH1YQN7i Ez6RY2KTHQXq4UmgmuP4Gz+T9+0rYiCH1melCDO85UUXiYMt0hAg4pteiOEk/C7R6z6uEiPwC cTO1AC+D6QyOwgUVnT4LbD9vjKQUxIy/uA4W2dwgi73iAigE+5vM2MHlcgkylhGrFUXS8284M eKVAdetcoQuIyOaupfSfrxxWHvE/IRuw08iKGeu5VvCkWfb/Cp7Pgi4gywFhCRVZ1wsZxOq5O sa5cLHB/id/2qtGNtrjmRG3uBTxL7qrnzHX5jf5fts18Ghf+q47qhfR/Vfp/axLzrq8X6L+da eP00i87gjy/lUcPfb6UWslHn+x/4ZHPOCJJUbJfRZJ0B+m4SqPNOMgjAEqvp8vRnnj8shjfnr xghGT4D8Zq6IyFBc1DvcMHofI/Mb1YAX/iRiAyXwTagGPXOg07hNASHxVlVk+YLcKcDuouwkb x3JYk0U3jIDg3aEgyzP1ccMcoCwjfegcwVP9FcUpKNKxcA1emfzIf48AFFcdUsmqgZccdYpzJ lgaBgMSvPXZg5x/mTEQfyQfvlJUugVp7LUuycVbVQEma/kO8lnU3LIil9vuDilg+uusGEGv7Q kqDOzcMoi/k98pSTzJ/iVkAzJRac= Content-Type: text/plain; charset="utf-8" Fix checkpatch code style warnings: WARNING: Block comments use a trailing */ on a separate line + * removal by worker thread */ WARNING: Block comments use * on subsequent lines + __u8 tos; /* six MSB of (former) IPv4 TOS + are for dscp codepoint */ WARNING: Block comments use a trailing */ on a separate line + are for dscp codepoint */ WARNING: Block comments use * on subsequent lines + __u8 traffic_class; /* ditto for the (former) Traffic Class in I= Pv6 + (see RFC 3260, sec. 4) */ WARNING: Block comments use a trailing */ on a separate line + (see RFC 3260, sec. 4) */ WARNING: Block comments use * on subsequent lines + /* =3D { + 0x00, 0x80, 0xC8, 0x79, 0xB3, 0xCB, WARNING: Block comments use * on subsequent lines + /* Field for thread to receive "posted" events terminate, + stop ifs etc. */ WARNING: Block comments use a trailing */ on a separate line + stop ifs etc. */ WARNING: Block comments should align the * on each line + * we go look for it ... +*/ WARNING: Block comments use a trailing */ on a separate line + * we resolve the dst issue */ WARNING: Block comments use a trailing */ on a separate line + * with proc_create_data() */ Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 39 +++++++++++++++++++++++---------------- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index c7caaf68ffee..6d2bf1ae5eb9 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -283,7 +283,8 @@ struct pktgen_dev { int pkt_overhead; /* overhead for MPLS, VLANs, IPSEC etc */ int nfrags; int removal_mark; /* non-zero =3D> the device is marked for - * removal by worker thread */ + * removal by worker thread + */ =20 struct page *page; u64 delay; /* nano-seconds */ @@ -346,10 +347,12 @@ struct pktgen_dev { __u16 udp_dst_max; /* exclusive, dest UDP port */ =20 /* DSCP + ECN */ - __u8 tos; /* six MSB of (former) IPv4 TOS - are for dscp codepoint */ - __u8 traffic_class; /* ditto for the (former) Traffic Class in IPv6 - (see RFC 3260, sec. 4) */ + __u8 tos; /* six MSB of (former) IPv4 TOS + * are for dscp codepoint + */ + __u8 traffic_class; /* ditto for the (former) Traffic Class in IPv6 + * (see RFC 3260, sec. 4) + */ =20 /* IMIX */ unsigned int n_imix_entries; @@ -389,12 +392,12 @@ struct pktgen_dev { =20 __u8 hh[14]; /* =3D { - 0x00, 0x80, 0xC8, 0x79, 0xB3, 0xCB, - - We fill in SRC address later - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x08, 0x00 - }; + * 0x00, 0x80, 0xC8, 0x79, 0xB3, 0xCB, + * + * We fill in SRC address later + * 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + * 0x08, 0x00 + * }; */ __u16 pad; /* pad out the hh struct to an even 16 bytes */ =20 @@ -458,7 +461,8 @@ struct pktgen_thread { char result[512]; =20 /* Field for thread to receive "posted" events terminate, - stop ifs etc. */ + * stop ifs etc. + */ =20 u32 control; int cpu; @@ -2396,7 +2400,7 @@ static inline int f_pick(struct pktgen_dev *pkt_dev) =20 /* If there was already an IPSEC SA, we keep it as is, else * we go look for it ... -*/ + */ #define DUMMY_MARK 0 static void get_ipsec_sa(struct pktgen_dev *pkt_dev, int flow) { @@ -2693,7 +2697,8 @@ static int pktgen_output_ipsec(struct sk_buff *skb, s= truct pktgen_dev *pkt_dev) if (!x) return 0; /* XXX: we dont support tunnel mode for now until - * we resolve the dst issue */ + * we resolve the dst issue + */ if ((x->props.mode !=3D XFRM_MODE_TRANSPORT) && (pkt_dev->spi =3D=3D 0)) return 0; =20 @@ -3787,7 +3792,8 @@ static int add_dev_to_thread(struct pktgen_thread *t, * userspace on another CPU than the kthread. The if_lock() * is used here to sync with concurrent instances of * _rem_dev_from_if_list() invoked via kthread, which is also - * updating the if_list */ + * updating the if_list + */ if_lock(t); =20 if (pkt_dev->pg_thread) { @@ -3982,7 +3988,8 @@ static int pktgen_remove_device(struct pktgen_thread = *t, =20 /* Remove proc before if_list entry, because add_device uses * list to determine if interface already exist, avoid race - * with proc_create_data() */ + * with proc_create_data() + */ proc_remove(pkt_dev->entry); =20 /* And update the thread if_list */ --=20 2.49.0