From nobody Mon Feb 9 10:27:22 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 161DE284B5E for ; Thu, 10 Apr 2025 11:41:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744285284; cv=none; b=TxYjNUu1tzDJ8AM92jhWneV9Y9rzcUrdQeYEcmlk9PTQKQSwdeEvvw16aCtuWuvbQwLuEkJ+K3T8wTgnrLEk6bDcfsAeYTW0VEWv5WHUKckwN42B8I/qFgslXqTxWtCJBZnhSeWp/+SXlh+w6frpDht73uqW9++PvkkTCQ8/vXw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744285284; c=relaxed/simple; bh=EWB/sYzoB8CsG9hgCZR+RFlRMAyDx5p/cXloDsy+UNE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FebLPOsz9vnEN8YOxizZjLJNkUEhXE5YQK4QHD1KjDdP+oT459A2W0pWpSG1VVXDhTFxbRIm5LofSSj2jdREHyv3cUE5aVOTnjWlmxxmbAWpBuI8v76Ee53fAup3Xo3EPlTJkOxwb/jjut6vH0L7pxHaWk4oxorlfSoyzfuiJwY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JPUZt9RS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JPUZt9RS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37028C4CEDD; Thu, 10 Apr 2025 11:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744285283; bh=EWB/sYzoB8CsG9hgCZR+RFlRMAyDx5p/cXloDsy+UNE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JPUZt9RSeiO/4YQ+MT8jIdFJcRgt7qA0dP1SZOktGtqhvXqAISDEIbq6F9H+FNjYK BPER5HUO1SHEV23d3JJJXIcejJuZMYL+AEi7+XNrdc3vpATcgOBSgdB0AAB7pvBpg5 qEFm3brS/PLSabgWffWrZD4H9nmdupYyXGbOfl+q/8/So3wJgptnWdGl4h9b1DCBv5 kMMF8Z6inz4Z9PSJ6Pb4JLV816MmwYD07c0v4IUiwimX+FPlIPQodC21sH4hhgtW3X KkVbGAH3zDiQOjqk4bDAVSzQkBmRCbqJYKW/MmDcl79nUPGhZP9ctmbPCadd+ungjH 7gV5MvrXbtA2Q== From: Daniel Wagner Date: Thu, 10 Apr 2025 13:41:08 +0200 Subject: [PATCH v4 05/14] nvmet-fcloop: update refs on tfcp_req Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250410-nvmet-fcloop-v4-5-7e5c42b7b2cb@kernel.org> References: <20250410-nvmet-fcloop-v4-0-7e5c42b7b2cb@kernel.org> In-Reply-To: <20250410-nvmet-fcloop-v4-0-7e5c42b7b2cb@kernel.org> To: James Smart , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: Hannes Reinecke , Keith Busch , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Wagner X-Mailer: b4 0.14.2 Track the lifetime of the in-flight tfcp_req to ensure the object is not freed too early. Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Signed-off-by: Daniel Wagner --- drivers/nvme/target/fcloop.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c index 1a8ae33c1699be3b7a2a7170dff77e324c127ebb..b54467b285181d6909c6592eb16= 6cf4fe6fbe54c 100644 --- a/drivers/nvme/target/fcloop.c +++ b/drivers/nvme/target/fcloop.c @@ -566,7 +566,8 @@ fcloop_call_host_done(struct nvmefc_fcp_req *fcpreq, } =20 /* release original io reference on tgt struct */ - fcloop_tfcp_req_put(tfcp_req); + if (tfcp_req) + fcloop_tfcp_req_put(tfcp_req); } =20 static bool drop_fabric_opcode; @@ -671,6 +672,7 @@ fcloop_fcp_abort_recv_work(struct work_struct *work) break; default: spin_unlock_irqrestore(&tfcp_req->reqlock, flags); + fcloop_tfcp_req_put(tfcp_req); WARN_ON(1); return; } @@ -958,8 +960,10 @@ fcloop_fcp_abort(struct nvme_fc_local_port *localport, =20 spin_lock(&inireq->inilock); tfcp_req =3D inireq->tfcp_req; - if (tfcp_req) - fcloop_tfcp_req_get(tfcp_req); + if (tfcp_req) { + if (!fcloop_tfcp_req_get(tfcp_req)) + tfcp_req =3D NULL; + } spin_unlock(&inireq->inilock); =20 if (!tfcp_req) --=20 2.49.0