From nobody Mon Feb 9 09:23:04 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3301725E83C for ; Thu, 10 Apr 2025 09:35:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277705; cv=none; b=e0vA98dt1deGAzQHYmZY3Ql0o1iaP/hPCb10yuAqVaBvS+IkNHeliLOdcdfAmys7cv5jkuL0so2lCFbsGA/fh8iRuqbsSLkVxcny7JZhvwlbm3ZDQ0ziA/cW2xPUSNJ4B55A+H63uBbuPNoY4eE+gvfbsMCeE36MNA5wCNtv5A8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277705; c=relaxed/simple; bh=DZ/xb93rJ3XNbgASkJ7xfZpeXZhU7bMWq3R9qJtV1u0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Uo8DC3XoHPxzLLdbmu2X0Y3O/iJQJpS2+cHJelITcIcHm9t/AETwCmT9cnK54e/qmqMxrssO+wnqt5cvsQXzZkEp9e673sLgCiWh8VCb0OQfAXAdmS6YxeGagL7da5oXyB22UDuZRzR4ssrtN/FQjyZJ/gs18hRJbqSpK1IbPPg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=d8TeUlbU; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="d8TeUlbU" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3913d129c1aso425127f8f.0 for ; Thu, 10 Apr 2025 02:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744277702; x=1744882502; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vKc4ni2bYp396pJgjc+ApP+2GPXywPdKnppMH0GYZOE=; b=d8TeUlbULOYZG0iOzWv4jpBu6k+lOYUtC16FIxGD5KjE3IPxI9UbathgToemTK1U4A BwXIV6ANYgRKXackzZkB3YUoPhcH3BiCXAyGYiL70hhXtoWYjVsurh7IdqG7PhK1WhZE vLG3fqlseXjn5ZROSavFBbDwE8qCSwOT9SS8ZP8Jxn6zJBO4IbzIEFY1VvyTlkEWbIfM yl1hAA6Xyx6fvf1UHy7A944H+HOzlZ8h8pnB5gFRugdlIeV8ZGdCYUr6l9G2d9X/OJoh 5QKomVNdFGFGY9fN/ndkr3y8uNuDqWwxAe7HyJ1/zZh0t0VGYk/RcyFSGf5i+cMlq0UF xnQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744277702; x=1744882502; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vKc4ni2bYp396pJgjc+ApP+2GPXywPdKnppMH0GYZOE=; b=v/xEClwMaG/ZdZ1ZMcfNCaYmg+alRt05l5HXuE77lE1+Hoii//hqvd9m9QWLoW4QaY CErvo0RL0QgW9jMdN3gMC6dqXRix4XyN4KG/afIcxqEa+F3B1aGibU3US1yHCpYbIrBW kGdbx4TwARJaFjuU/wGLQRxI7G1tP6qRCFqODKeya1B1QweMILWJMXiTjXz2tDek0IvO WA54RO/KPrw8hkYaa8GvT9hQPQMaSQfeepzML67Z9rlpapoowszkEF8d3X+HJn9weozS ypRCe3saHjZAmaa4/mL2gr0rndsT1SmmBezipKMPNtEzJ8spKvld1H/zahFcWTXkLtRR q1Rg== X-Forwarded-Encrypted: i=1; AJvYcCX0HNY0dXTvQfbAQF3OmtxE1oiXrI2ifWh8g9HD8VVy6d7/LcFMhLbR7qRLd+SczSffznaTHK/FMUsEAOg=@vger.kernel.org X-Gm-Message-State: AOJu0YwdYwOMHX8wBuRFl4Ux1ZzoERsG8zpKFU5xy5yyx71U4Ssp8+eN VMxizcRCNPG9LfwD4+a3Et/oENobaEpJDebqyaoindC8PbBkQXxuM2EBLfNhbYw= X-Gm-Gg: ASbGncvjZ0JadHl1XFXO49Yh+tKn7Fwo90zMLP5vUziuVh/wPMWgbJF3X1a92klu/cg G4DivVDFQ91DnHr/FfUBqbQrwwjm50txi7pFj+nyitOo3i3T0vGsXKd8Eaz5Sc+fjt+KoeyjEhz z0mCORwxQ7NzELW8mTh3wvJEAl4bUie4vBO+moFZ9Qjh9RhncOX6JuNW2SSupNM80ztcLTbP+Oa 1upiP+a/yScPJT+jvYKieodatrPsbBly/6VOBjzgS17kKorYDhr9hVmTfwv6i3AvwTjMs7EJOKx QGCmAj36QHIGhP/A7Fg8k58kh2Sc+m1n5w== X-Google-Smtp-Source: AGHT+IF9CCOYu0sZ4EtoBET0PxviFQ0BAKr/anVSOO4WNE5lPQ4fauspuBSv5FegePef7LtmJ26IhA== X-Received: by 2002:a05:6000:1acb:b0:39c:12ce:1112 with SMTP id ffacd0b85a97d-39d8f4c9638mr1721576f8f.21.1744277702477; Thu, 10 Apr 2025 02:35:02 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:7c4f:f9d1:94e0:53f8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm49698435e9.9.2025.04.10.02.35.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 02:35:01 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 10 Apr 2025 11:34:43 +0200 Subject: [PATCH 1/6] pinctrl: qcom: lpass-lpi: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-1-6a6891338aae@linaro.org> References: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> In-Reply-To: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> To: Bjorn Andersson , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1522; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=8O4bilVXxN82WosLGq1PiA2eweBBlC7Bp7cOdXvJsAE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn95DDStxdfGuVBR3XOsSKVkN/z/7yJgXF4ro6N rUvBcL81jqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/eQwwAKCRARpy6gFHHX cpQWD/4884nUwImCE01ziWTugyxvx/Vel3SSsEo6GAKVf87PvRQRixhIciKdlPSk709Pm06Ue2R E2ochgWHNoV7YW3VWQJ0hgv3zrRfKGEcVZ37X/xeknxR/K2lB14J1bRunyB331PR5P0djPtadT7 Wb2MTOdSYuFSUtMLJnHEXNRvtKEcrFjLi6B/zuNR2wH0pg3d3t2mpz/vTaS5jOAX0bDbI934NeS 6KnhGwGiE0PUFjyN5O5nRpClZI5kQMMRrZxNRX/OTxwctPMrDDT+EZt6Fqv2inHVpR4QXfokDKL MS2ns96W1qJ2uByniuqRFyQekqckQxA3nxEa4nFRdh58jmIP4va5ZBhtyISewo0kbBDCyKQ3ELV jsOvDx+UbRA8kVGTxuK/iKAveJ45RcDUAv+l/Yv/BdFeIob4Nx9XbmvoKIXPFIZO4vLQromhvRU UFpR1p/AQSGwgiLtpY5rXobnwRi5FwunR/Qn06NE0em83JNQyS28DomKMEw+YdcnvoWImzcidt7 0PHyxr/4ZaU5LlJ2zxyFau7N5o1gy4/REdwz4G6ivNgpmh4pKokNm0gREPsy0eTey2UmJu+fH4g F2JDIOPZC5+eyjVoJHPRhcEdP9hllwUNcsBFjwKsMzbXikINeZMqvtzqMOTeYNJ1gc1dRY2vhgW ReVgBFqFT1kNL0A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Dmitry Baryshkov --- drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qco= m/pinctrl-lpass-lpi.c index 7366aba5a199..57fefeb603f0 100644 --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c @@ -327,14 +327,14 @@ static int lpi_gpio_get(struct gpio_chip *chip, unsig= ned int pin) LPI_GPIO_VALUE_IN_MASK; } =20 -static void lpi_gpio_set(struct gpio_chip *chip, unsigned int pin, int val= ue) +static int lpi_gpio_set(struct gpio_chip *chip, unsigned int pin, int valu= e) { struct lpi_pinctrl *state =3D gpiochip_get_data(chip); unsigned long config; =20 config =3D pinconf_to_config_packed(PIN_CONFIG_OUTPUT, value); =20 - lpi_config_set(state->ctrl, pin, &config, 1); + return lpi_config_set(state->ctrl, pin, &config, 1); } =20 #ifdef CONFIG_DEBUG_FS @@ -398,7 +398,7 @@ static const struct gpio_chip lpi_gpio_template =3D { .direction_input =3D lpi_gpio_direction_input, .direction_output =3D lpi_gpio_direction_output, .get =3D lpi_gpio_get, - .set =3D lpi_gpio_set, + .set_rv =3D lpi_gpio_set, .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, .dbg_show =3D lpi_gpio_dbg_show, --=20 2.45.2 From nobody Mon Feb 9 09:23:04 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43D63268684 for ; Thu, 10 Apr 2025 09:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277708; cv=none; b=t67FWJn9uCq+A01fynK2yDeUjwjW2U+xezam7VwXTHw0AU0Jz7uOf8UnF2UE3iq39WjTSo7PMeMqD0duUgzOpOe9kfWlVvoXNvOFZ/xf9lKfQYXDXhKlHUAIfjQSCARFce/hXh2j0bkBHY43kpXXQXiy0OB7bA1zULebw5BfbaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277708; c=relaxed/simple; bh=DoFdNFWoCcdwBqgFx7axqjS23MMKsUrQ/U/HOonOanY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gKOr5uMmyJ+JZqcZm2MIAryyJ18R/eyMGT4I8RZumQknJmbg8D9g1gFY/6V2+iPDkdLtpEzJ/GKgFZN6qZ336DEa3uA0U4stEe0jeTyrDzH+bzRXibfCWv4SgkYyz+P9sgGzovo9vqbP1esHxNuha6ySs4h3Q4kBub4qwLVT2pM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Zaa6PS6d; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Zaa6PS6d" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so6831495e9.2 for ; Thu, 10 Apr 2025 02:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744277703; x=1744882503; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=c8Y49U7vyylV9HBlgThwXQyGyZVwK1RahyBl6+GUslY=; b=Zaa6PS6dNq8J8uH6qJYt4wIAT6ofYXV7gX/A1Yc20ga7kfOqRsALlQGRi49/1idFnF hILVamUUo7JkFwlkeiPlgpvGE00nSlRzX+05XzvYTP9G+TxRNmMKQ0nEeNvALBSI3IhZ 4l8p5uXcV37p8C67gadzYQFIvYEbLawMxfmwx00+p8EC6KHk3+sO4RPDFeiEeu8s170E 3HfEhGKjlYFYeqAue6iw7jaRNROWFUfPfAMn4CcuqNIDzxM74hzia/U+JLv1qk4SlWYX 3PaQj1prWSBHrj/JWyo/zkKODnN8Lq2LlXrCr0+oEN6NstQSpSnD8JDNpU3JwSEB54V9 WIiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744277703; x=1744882503; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c8Y49U7vyylV9HBlgThwXQyGyZVwK1RahyBl6+GUslY=; b=CGztKaU6aOu37b0Epyudf/QMAJRVieU1+REMrZoKEBtUTbPCckIrPu0/CHJtSOFteL eL54NYJH6dd4D1fDhCWNvw4W3JgwleCmmnjX87swEiZWuR+P7VZjk5m6ux1KWunKk5vT GrwD2279Cn/3NIO8jCgQUuWX24A54dvBLDNAj6eQGV09kggEUYmZdvhT7NLMjYdMTWys ln8RirVdZsG61Lo0WcvS6+j/XvOqCH2v0v8xqOqrFykZBt2+cie7f+I4NyRxacuAx9yc FOnHPWHpM1XHpRAVk/jK2l+vXoySeqAdRR6ZWsY11tfMOGonMOYZYqzav8+/9fANsg1l wSzw== X-Forwarded-Encrypted: i=1; AJvYcCVZRK42cL1d8NgvErfDLwdchFqcQdfz+0EFsgxgvMipF5/f8MvEy5y7wTZHlpLmmyaSivcbqi8jsd8BVIo=@vger.kernel.org X-Gm-Message-State: AOJu0YzgAmnLCEvvztiMr+xFfqu3vkE5ltOh1dP3y5nknNRAy8qa7BMs qNadcdUij+WnMXlYEuzTT4cUiU+Eh/G9bXl/FfTtqw/o2Lcb8vKNH41xBxN8mFs= X-Gm-Gg: ASbGncvN6YLKH6EuTIYEnPWxZrcifyGTLIBk469vAPMCmhHp7yDHRWue4FC43AynrWm YtJ3zbUmlZJKl6EvwomxcB+k/G6bxYHPsvjyGs8R0MtrrbNx2qo3qBEwJtxW8ApJfPgJ55NCtXo fUApqApDSFAnOhTw9K3uCtJ/XlLXRZvdEmif/r3TF0csZx4I31koqc4GI+e774HKSH/gZjRCXf+ slZq+vfjrPeegv9HE2h+PoYVROVpEyr+inesdwbfgk7gCNEx2OXOzPQ7J5+pe2kNaEE3uipgB0b 0YBRLLmZGRh/3B+dgfTSz9pN3mWnOuloEg== X-Google-Smtp-Source: AGHT+IFO/7yb5gwVk+EjcAiXS674jHL4dkOWAIJi2cH5g/WNiQpu8cbZDAfyXKFMDWcxeA32KO35qg== X-Received: by 2002:a05:600c:a05:b0:439:643a:c8d5 with SMTP id 5b1f17b1804b1-43f2fd29c65mr18806345e9.0.1744277703398; Thu, 10 Apr 2025 02:35:03 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:7c4f:f9d1:94e0:53f8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm49698435e9.9.2025.04.10.02.35.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 02:35:02 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 10 Apr 2025 11:34:44 +0200 Subject: [PATCH 2/6] pinctrl: qcom: msm: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-2-6a6891338aae@linaro.org> References: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> In-Reply-To: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> To: Bjorn Andersson , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1588; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=usX00XKi8pnUCUTjAeiAi0APuP7ga/Kkn40N9cscMzg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn95DDa/89BnXHtA4+4Ni8Mh9nKIEx8RLUu6TiL 7c/JWsquH+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/eQwwAKCRARpy6gFHHX csL2D/9v1+J7NExhtOLP7S+W7lAyKvwFupRyUslizgwMatXixYiYi+QieSXSPPKQPM4VTj1KIWN n0FBazRjFNa3MaBdENT984m9UNUnwFOhviyywDuswR1ZU9fE/qZG73efOY2xo2gc9Ddb/kzDdHd 9Y0W2naMHv+Mw7/A77hWpAHVpNq3DzKfqGiZXHZxCWrU0bISk2Yov9g9IlHzpIGHhglJKT9ujAn uDnf0lhqQhtHIFvojPpLEwzKQ0KztXkUu6+EuL3bThCO7oy01OeGDO5XnwiKm52aHPYqki3+Gy0 P4I7OyFoVEgx4cW0RtMHLezTk0WekAwzt/xLjkhKeG3b74ceX11Cloa5fJofuwkA4ylLgBqwrv1 59QxWmyWLxGR5ctwp3mdTdjpz0EJn9wWGQAdzhG5jM2iV9bPosMsKZm0u0TOUzJ9+6KnTf7GEBk NTJ6tMYgmFIEmF060FKrEsnjnt17Dc44lVjY2BHZqo4WHcTKycJzZrlh1M2QoD+Tu5zQ+BpAeV8 uTsy7DQ3Zx7tbNX3DG6pW4NvOuxLS3l9pddMEgJI+p/zCsUXeQgSmgDNoom09iBJ7bvF7OUUO6H Cs6ZlNM1tb5SvmhkROfMQAkSPC7k0MmRkKbAqhaKMFxf2QP1kuZRNsL6pjELKXiQDbzjNUVFfvZ 0relZsbl8+PJkAw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Dmitry Baryshkov --- drivers/pinctrl/qcom/pinctrl-msm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinc= trl-msm.c index 82f0cc43bbf4..9ec15ae4a104 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++ b/drivers/pinctrl/qcom/pinctrl-msm.c @@ -637,7 +637,7 @@ static int msm_gpio_get(struct gpio_chip *chip, unsigne= d offset) return !!(val & BIT(g->in_bit)); } =20 -static void msm_gpio_set(struct gpio_chip *chip, unsigned offset, int valu= e) +static int msm_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { const struct msm_pingroup *g; struct msm_pinctrl *pctrl =3D gpiochip_get_data(chip); @@ -656,6 +656,8 @@ static void msm_gpio_set(struct gpio_chip *chip, unsign= ed offset, int value) msm_writel_io(val, pctrl, g); =20 raw_spin_unlock_irqrestore(&pctrl->lock, flags); + + return 0; } =20 #ifdef CONFIG_DEBUG_FS @@ -792,7 +794,7 @@ static const struct gpio_chip msm_gpio_template =3D { .direction_output =3D msm_gpio_direction_output, .get_direction =3D msm_gpio_get_direction, .get =3D msm_gpio_get, - .set =3D msm_gpio_set, + .set_rv =3D msm_gpio_set, .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, .dbg_show =3D msm_gpio_dbg_show, --=20 2.45.2 From nobody Mon Feb 9 09:23:04 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43BA725E823 for ; Thu, 10 Apr 2025 09:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277708; cv=none; b=R3N1Kv327RLUElgjPJvmUNYlMvYluxmSKktebmtmd3mcmuv5iRH1cx+CbLVAqfIeulLq2wNJr+dPzLJoF6iADpwEn+Gx2jvHgljESczXI5JtbGQJ12pQxiXc2ti5jhhoFVi5R1QcMbd6TpFm82JXOTDKVaIhwX5eWCWqC+c5WOw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277708; c=relaxed/simple; bh=pZm8XfpBohQqucxLsOo63q2iDqswy0IMvoIBqy7sFfI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ERRYT2KNKuNQqWs5iS6oxvKBLQdK3FgfhWzz5qcwvX59QsKC5MX216fhM3nO07A4jXK5BlJScsKWLUCHuAT75jwg1mS09GEX34bp284kdIV92F6f6AKsxeqEZLM1KoC/LCdn2C/6tjbOUSKtcunuz8z9x7F3vrcEcnS9/1ElUj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=ZGzcC0pG; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="ZGzcC0pG" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43cfa7e7f54so3869585e9.1 for ; Thu, 10 Apr 2025 02:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744277704; x=1744882504; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=x6/qCzJfkhK1AyRDQMfBlEcsjj/vCOHFZrU5RVmRNZI=; b=ZGzcC0pGXCcGhpX2vXncRB8NjGaJgRmkzLDxTzvWJgXufanucu9XypftVAc4WhOXdT TDKy92KWYwItDIrLlxFmYoT+PL7+vUwgsHYpvSgoZa4m1CgB+7L5uABS/C033kPOwbJK /itgQke6BK46kMkEE5v7OGrXpchEjsDjSOj62d1jZW4sJ2teLpNm4EPkQStran5maB8g 3o4ri/c8D1DuHpJKrxdV4D1o/5HkASnyrSaVrZBo9mtGd5wptN8Cp3FO/zHhLM3Wqq28 sjxOWaE1aVQZwja/Codpwx5MPh7jx2jMd6x2gKNEChJLm472eYvkdlFN4si/RmSR+qVw R29w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744277704; x=1744882504; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x6/qCzJfkhK1AyRDQMfBlEcsjj/vCOHFZrU5RVmRNZI=; b=iWMfK9tQD7NFgxAVr9HzW4LFIhyArZsjpDj4wAzKVIOUSYUZdl3sFnaHzJ3ZePZcGL FgUvElCuwpFpIiBZ3EJwUbV32S0qnDgFWdtFmXs5j+SaHuiSczmYpsv3AKp6CEGZ9gOP jPJWfQMpr0LfE8KyI2so9J6ULVbYl681wSv92eqOoz3CAgTR0Fh/+F4RdWYnCaSVP0vt crgADxFtkcG67/wTJ/3EL+fOGQV1mgiBfldryLKP7hJkMXL9tT265oK/lRl1z/ojivhZ crWtYwO9K8p/OD79LvBfW1aRePV6CJ7uUnNbDa4HpJuH7LQRG3S+huniyXoz1JGUs5ib TNyw== X-Forwarded-Encrypted: i=1; AJvYcCWHzCWwpBf63q92OZvPllknUWd5fC0W3vC8xzpE7hp1OeS69iM1nkeWTKayUCNnDXypUiBZo7dUMlEY1Sg=@vger.kernel.org X-Gm-Message-State: AOJu0YziqBBSeHfnCICMRYVc+CU76zRZn6xVA7d5/GH6IzeiuogMWQOz +pQ6ruHTMiWbuEKieBuqTIjfwI71V/QKMcs+N/XF4nWd8HIHVbtuFWcFkQjGCS0= X-Gm-Gg: ASbGncuuzUK33vha7wNCR2vGZjhyZ/rIOu0HMtpjgBYqErEvl2ShaCmYkPmrw5sYpHn 6w7ZoO8JLfOZog/hKNY55a0mDcdpYMGxXsy+1kc+kjYwEORbnmxQCrc2ysguOujuyTKE+qEGDbb LvhILBksmXWHzC+GO9YI8ppW95dAaC6tG7+HIXNkgNuAq6SUnwvJuka9fIeP4+CglP73Y43Mi/h Iwckp5VAIRV+bheoSRU3pC+6ZhsWOgcOTfMX8wOY1dsEO6cOK0Z69HLcC0sjQCeN8DudrrST3qt iTHRN2U4Yrv96c9DOSx6yxetI5WnyS98Og== X-Google-Smtp-Source: AGHT+IEKy+AKjEgaOW59U2J7LBEe92Qmbz4NdALMApP6IVJjySswECPtBU9vc6YfLAn5Hd8BsecWmA== X-Received: by 2002:a05:600c:1c02:b0:439:8878:5029 with SMTP id 5b1f17b1804b1-43f2efe1e29mr13000485e9.2.1744277704324; Thu, 10 Apr 2025 02:35:04 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:7c4f:f9d1:94e0:53f8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm49698435e9.9.2025.04.10.02.35.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 02:35:03 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 10 Apr 2025 11:34:45 +0200 Subject: [PATCH 3/6] pinctrl: qcom: spmi-gpio: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-3-6a6891338aae@linaro.org> References: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> In-Reply-To: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> To: Bjorn Andersson , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1576; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=U1FUBgmKuTLMmd16tW+SzFaBbmdCVgvjNRZj2H52KGA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn95DEmkUSYXcqzH9VWXANzroVJ/djI8M0ETQLm XX64LWyZmKJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/eQxAAKCRARpy6gFHHX ch2dEACtKGJIwqQln8m3ZPUdXTkvHFJSITR1itgfYhv/wPO644hYyQIU7bV+rEhoHlUJ/G8DAMT Qn8bJs5TEDZhn3RcTuf+ELMsUFjGOqQnHwwnTjxSV4jxi0AG3SILi/LS96YpuuNB1spcJTlfQi6 l9lswrXXpQY0dSUecHvIEkHBEp54UcI+mHVEZywO9Fa9NaM1fpEaIuVkYjef0dk9LfkZxrAzRgk Xyx3GAFy02eCRHjYxOlLik9L5V2KG4k1zSAhuhR817CJCYV/uHhqkydL2irzg41/ag4rJjSAb3D aiJtwnjGv9xWzB9RqeIT2vRa2F2R6LPNePeRz01n/EXQ6dxES1JtLE3KGYo2lOEXtD5UZt0lk+V LTjxZl48C+3Ie40sxXTZo5CbMY1doMcXxWBYtOnoeQuP85RSvP34TNfc+rbUKLqdfMP3JN+Snyh OeM8Bdb8biR9GmSKpaJ2GGiLJognEUoaSH0Qjm1Q5YtuCSX0Pd8Mz1ip2wtDrPL2XRnOFjYtll7 VxGPrPMrVklbQLhPNPIp5kWFm9smuIrkW0KfP8BFFKkW88HQ8ShBHdruPnAo/I/jgi+pEo9qmIK ABnJtYQSTBP7MX/ITIDQ6IfYy3VQBdNSwPGYLFwD5mwT7kjTusmA2Z0XPuEdeOxlWBUDvPieYju dOcNHL3diHVBwUQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Dmitry Baryshkov --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qco= m/pinctrl-spmi-gpio.c index c8ce61066070..bc082bfb52ef 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -764,14 +764,14 @@ static int pmic_gpio_get(struct gpio_chip *chip, unsi= gned pin) return !!pad->out_value; } =20 -static void pmic_gpio_set(struct gpio_chip *chip, unsigned pin, int value) +static int pmic_gpio_set(struct gpio_chip *chip, unsigned int pin, int val= ue) { struct pmic_gpio_state *state =3D gpiochip_get_data(chip); unsigned long config; =20 config =3D pinconf_to_config_packed(PIN_CONFIG_OUTPUT, value); =20 - pmic_gpio_config_set(state->ctrl, pin, &config, 1); + return pmic_gpio_config_set(state->ctrl, pin, &config, 1); } =20 static int pmic_gpio_of_xlate(struct gpio_chip *chip, @@ -802,7 +802,7 @@ static const struct gpio_chip pmic_gpio_gpio_template = =3D { .direction_input =3D pmic_gpio_direction_input, .direction_output =3D pmic_gpio_direction_output, .get =3D pmic_gpio_get, - .set =3D pmic_gpio_set, + .set_rv =3D pmic_gpio_set, .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, .of_xlate =3D pmic_gpio_of_xlate, --=20 2.45.2 From nobody Mon Feb 9 09:23:04 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C90F6267B86 for ; Thu, 10 Apr 2025 09:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277708; cv=none; b=JFohLiDf6fuCkeLosDNQ/Ju7qKHG3SPnS58Ug9Wge62/ib1sOa8cX71LADwBN52HJT5umPJR4QNkFaKV3pEwSAo8TKOr7btrr5Iov67DA2SUAiezH1VcICOUeHkRjqGX26yfX/1Er7kP4UXTA3b03n0mSLziQTHzrh87UOcGyIM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277708; c=relaxed/simple; bh=zFunwlPY75c5O2YN8hwBDuNKH7oOIClUtknUohNLaUk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DO0UrAKswxas0PcJSmyXvZKFvfHLwzVTcqWKR0GK4fQX9xBotg2pU54VQihVMz0aFe2/XhQGWVT7HS4HtQJ8oOlLk86qldk9gq4/7dupN3YWxbMRuw0BB6jhPbHxlXkEUGtqqkcEkaUEqgXB6HrKkxKLUk/1TPzOQj9iBTPRgVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=W9qccO3b; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="W9qccO3b" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43cfa7e7f54so3869655e9.1 for ; Thu, 10 Apr 2025 02:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744277705; x=1744882505; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7uVB7is+yptYnkVSs1mCx+BRG/1hovP9Bmmev11MiCo=; b=W9qccO3bs6lgYt4fi704JjP9iyOQAk5T5Yzw7Q3EMnJTWiRfETqJN553LTikUogc12 UMDEqCss5a7Du3E1qkDheSgTa+5xrcEUHygNJ+B043UAww3hNtcXfrIwx/DNPAOuEpgC ZzeaQSneb87FqCI1b88K/SEqi0KRPGGY+N9WE5M76i8o7kgowsrUcTBlPPvNgD0qbZEk tLNeJkRA0r1GYOtcvCK6wd7nExfWMAtmpp8AYB+eikAl/2jD7vYwec7AdNBfK8nMgokg g3VmnxN+UgL6B4cZy/C7UVcOWdt9CLkpbOHs4TzDRTjkt/5Y7qWs2aBOkz5rR011QRzt 3zdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744277705; x=1744882505; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7uVB7is+yptYnkVSs1mCx+BRG/1hovP9Bmmev11MiCo=; b=tMrtNvP7QjSMQA20VXgMjWJdyyQNTTNAMWvGqva+WH9zyPsQEa+aCFzMOdgW1iWQ2B 3Wdjc/oeYkoJvAti4FUKoZ6INHNxPMeWoBHi8KRI1ZoHBBwVEHIOfpcNwh2dkXp6Tou/ 0sbJjlIpfC1Ig+hSjFE/TgSOVqaGJ4eAGSj+J7ACKwSc+x7PIGw+hmohntWyaiGT8cif V0tmdvVDuHUVY00g/vP0+FvGzV2mNb8qqyqF3ZcGu+YZpZovygHgefMyPKR794L3pcak jkrjRzquQ72ltR0Xj5agAIi3TszGx6K1UntPavNuJsGRwKtsRnr+9AHxD6bvv9Uj7JJt eKuQ== X-Forwarded-Encrypted: i=1; AJvYcCWBzrQ/c8Tkqf51kW8QcgtcPJ8NRveYFtwBeHiRZ4mSYoBLJ2gMI+enlwxCmUJu4qvJnvVKJlTZ94urMLM=@vger.kernel.org X-Gm-Message-State: AOJu0YzU1AUA5tpBPeO3JR/3u/g2L/FHRBoJ2B1Yx3FfgHiqjQsBRFk7 J6xsLf3qPdT0X9Q7RF5Gjm0ilRbD01oaFogStjDM+oaqdmVQ3DqUvBd/8Vte9L5LLcytt8omU7D zGf0= X-Gm-Gg: ASbGncvNZhpQ+X0QtArPjYZ2gcjOG3dLVvn6f9865VgVTHa/xwesmM2yyXjSicTA2pR 4rtYvkrXOB5cbKnbMnvfev0jnpseT53Bax4BxEteaHawwfqG53oCNwS19M2xBa3y0tAfrfAvI94 HMashlpm8iLrbndhy6+PcXzuAmiROpUJTh5meaM198m6LBzwXZ0yITiuEiIZeqjdKcEqJ9PGAxA p5VTX4Y29T9sVh4nl82D+I/vtMCckjKsxbP6YHe3Dhi2QNxNr3v7xhnGwslUricnc58zA9jYJ2e JtzzLyLTZnIErZxQjnT39yQ70PBqSIWQyg== X-Google-Smtp-Source: AGHT+IEsH6d2SUTQWewRxYYD+N3HJJN6aM4+/YoTK55TGBszabn39T4iPSfWmelp16bXe8GM+S+YwQ== X-Received: by 2002:a05:600c:4e0a:b0:43d:16a0:d98d with SMTP id 5b1f17b1804b1-43f2f0c349amr18244775e9.15.1744277705059; Thu, 10 Apr 2025 02:35:05 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:7c4f:f9d1:94e0:53f8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm49698435e9.9.2025.04.10.02.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 02:35:04 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 10 Apr 2025 11:34:46 +0200 Subject: [PATCH 4/6] pinctrl: qcom: spmi-mpp: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-4-6a6891338aae@linaro.org> References: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> In-Reply-To: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> To: Bjorn Andersson , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1557; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=9gNF/FLINe1nNmHXmNH1kL01vFkFUIR6jrZxXCXKbZ0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn95DE5FqnvJL/um7huD4ErzXNAW7u8g/dlwnTw dLrHURMowCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/eQxAAKCRARpy6gFHHX chTBEAC8mk8y+lhvKtCWUlvQJPn1B51EsVtS0ErSHQtK0p5t0NMlaF9XIIrqdvw4YymzXsR5/s2 76727nalRQ1q/0JLios8Nu1JFo3h6YdLDLaTxULAjVLBr7LzCqOlBbyM5tp9Mjb6bSKPCEcsm5i gnouiHU6XyJurOVvtAlRG4iTYeFB4uOxdGLd8pkACDPYiLWIphPksFUTTSl/4Rx+y+bBLAKUrcG k4UgkWvWq8sz83McVXnvNBjhqNSTnawWDq4w1THUwBLoIaYDwzbP4iRayuf54LBRkCwWl06PU+d JcIJswT0zpWROJpfl6u9Yr/uNRwB5E44zj/dYaRqsgaY/dOlFVqJ1vGZWAm17kAuT6VJ3gD4XV8 s5/e8nt0q0uMJUHQU1J1KYdssC7qbLCOlrjvFhqTiAw42xVCdOjgOiMbukQlIPw45W+SAvXuTKR FsLhnFNyTQBgxfUeHerTOhltmyLZULBwnfvnpeqB4iqYxTh1yuOqnvOgJFSSOltygjvrdithFll 6fiTVuBWpVpjl6jEghdO67qqqL9dQWlGa1gDX3H4/ixZSOSMWyCIGHOCSXhHfLY1qmVcgri0xGs 5ubxcdHDcPgTgd6dh7kQQZ6XCfJNUVbS33Tp17xiHrFFRuhY/CI4oHIYcZG94M277M6f7UZGjSe TrcNy1YdiTQT02g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Dmitry Baryshkov --- drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom= /pinctrl-spmi-mpp.c index 7b28c5fb2402..ba9084978f90 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c @@ -600,14 +600,14 @@ static int pmic_mpp_get(struct gpio_chip *chip, unsig= ned pin) return !!pad->out_value; } =20 -static void pmic_mpp_set(struct gpio_chip *chip, unsigned pin, int value) +static int pmic_mpp_set(struct gpio_chip *chip, unsigned int pin, int valu= e) { struct pmic_mpp_state *state =3D gpiochip_get_data(chip); unsigned long config; =20 config =3D pinconf_to_config_packed(PIN_CONFIG_OUTPUT, value); =20 - pmic_mpp_config_set(state->ctrl, pin, &config, 1); + return pmic_mpp_config_set(state->ctrl, pin, &config, 1); } =20 static int pmic_mpp_of_xlate(struct gpio_chip *chip, @@ -638,7 +638,7 @@ static const struct gpio_chip pmic_mpp_gpio_template = =3D { .direction_input =3D pmic_mpp_direction_input, .direction_output =3D pmic_mpp_direction_output, .get =3D pmic_mpp_get, - .set =3D pmic_mpp_set, + .set_rv =3D pmic_mpp_set, .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, .of_xlate =3D pmic_mpp_of_xlate, --=20 2.45.2 From nobody Mon Feb 9 09:23:04 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6ABE26A0D9 for ; Thu, 10 Apr 2025 09:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277709; cv=none; b=dp5dG5f/hUMm0MZxVj2lXaBdC9nwKwWg5uJuVaCTKAYvFlAr9YAu/K74lWqMDaBddWWWQDyp1Z52infvDGYeVrPzZDK6CR4CGBZGDhVDJdPKJblYMWGUaI4NmCzW5QvEhcL/vPRgSIwkQ3OxdWwM+wtGJBpjhKKwl1zoZqRCH9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277709; c=relaxed/simple; bh=CBNSk3yrCFCOlbMgCfYWRT8QGkYmxOkTlZAWAhHftYU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Cfp2rYX4ZnHx3CqYlchrQenM1fanQaEqJBfOZzXa4yEF54L6QAatArusnbeD2xNom0rVmSkc8WePFLOjC/yqq0Gz2/L3oVtMU+56P2SoM86UKwc5cF1XM+/CJ5I0XV9hi22ET8czQnwJW1rUlND2r0tQeonFt7AheXAsmSIqnho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=0cs86pYG; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="0cs86pYG" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43d0359b1fcso3869135e9.0 for ; Thu, 10 Apr 2025 02:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744277706; x=1744882506; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9gEo2m/viZuy0Hum07/62VQBUfloVHDkw2x/xR0+XyA=; b=0cs86pYGm70abco9fjhM56Qmym0LhpLkpUrxLBo0/CFg8TLRyz3qmKXaW0FjHK6XuX nIElyWL4LjpT8RKtNo9LEkamYipdLZTg/xNwSjOALmuNb6YOn92is+IhkdO3zomOeTOk lZkT6Tidf5NKh7NZFqz+QL1CtaBEsoD5kzcZvADFYEtD0Mk57dHw8UC50RObtE8CadsC jV83lIgOzaC1f2+zL723m1zwLv9QKs7RNfS8CUu0ME2ejzue5Zx22jK734ypgRyeYESf 91rgJardeEFqDH1qyauFKubcem07r3kpli/FPiSA54LX6YUnQwTAcviKkt8OHeG9vuRx uMGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744277706; x=1744882506; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9gEo2m/viZuy0Hum07/62VQBUfloVHDkw2x/xR0+XyA=; b=XFzEXkPzGXMeTiZnxqF2GlegoLWmR/7QKRT7Qm987C6zamcGEfDXKmT1tb0PqCh+rI UJFuBEpgbcUM8UmehVC8u11VgFxqPxpZXEQCPTdrUJq913axTxUOOY6kGgp37SyJGBtY /SW3/p3z1qf3e2ldVf8yTvG9VYBC8XNWdUSf4EwjZox3whmwIW8fuTWTRxXPll+q/AC7 5diBfBZaO1Ai58VztlVkj5XSIi+xAXGPkK/mz4A5Ur1d6PY46MF/I3K4H1SJJcxqZQgJ YgvxHP5ziTWp0QnoyIMKtjlvdY58f8rAxtsnVsf4NbF0Mv/5xJicgDB8O1pXbVm82QDr gJQA== X-Forwarded-Encrypted: i=1; AJvYcCUvG2I8ErUKCklKYxJTTq/2MmGjFVhTY/erXxOtBtwbtGNCNVYzqnWvBkUBEzw3dMamE61SojP3tJkLVqk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2qsHeTDgOL3r301Ba56jpcZvaewnmcU8Sa1bIw5vmnkAtjpWZ znYk26R77nPfG2foRKBKoJ5Tvj3/3Fa6yGq6Ezx8tAIJf2qAFaLBf3okVUG+u7o= X-Gm-Gg: ASbGncs0D5CPxkwqy+TmSVWKTcTyjBg71rxZ2x3CrqErb8/kOF8XdXCwdZP7227wKOd lD1Z6o8WwfKPFChjLjl8OwLX5zUrUe6G1X5E9e0bMW2ZkPCz5f+DCt90PaR7N5igLgao/OxYKLz xxTtcJkvBwShB02paVeia0WE3XKZL0LQLbstMcFQhV2P2UYSc4k92Jdl/0bK+wd4IISGpI8vz6s UnxnGuFvjYKnRW8y2UM1sy7pOqJ2s28DtL0FHzeErMqBRFn8+ccvcY+DC1EQjLNKj2/P8sGma4D stqYZA+os97Fld17G8ZcFO9gJyadRkgkiQ== X-Google-Smtp-Source: AGHT+IGQMtxSsq5/DE95xt49hSnwg6XZGyLcP+OE0baBUHtuUXr/MHr9x/DHvH7LZH95Mxedo/aa/w== X-Received: by 2002:a05:600c:3c84:b0:439:91c7:895a with SMTP id 5b1f17b1804b1-43f2ea651bcmr18434155e9.7.1744277705965; Thu, 10 Apr 2025 02:35:05 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:7c4f:f9d1:94e0:53f8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm49698435e9.9.2025.04.10.02.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 02:35:05 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 10 Apr 2025 11:34:47 +0200 Subject: [PATCH 5/6] pinctrl: qcom: ssbi-gpio: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-5-6a6891338aae@linaro.org> References: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> In-Reply-To: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> To: Bjorn Andersson , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1682; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=xuF564c737gHGSAxOu3BnJZRQm091DpG8CWSw+xr7mk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn95DEb1OYPZ+ZieVXFnz0F0FKQSWFLy4/qEKp3 g9UkQaGDgeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/eQxAAKCRARpy6gFHHX cpUREADdsULQgfyLf1FD3y7lCUngOFoOXSIwIrnRGGnV6dhK2OgKaj39Tls94XN8rhXJmaB5sEN rzMQlgx6LPSQmtDp3ommBKAl6XXJmVpcoV+IbFwGUfl22YKcbbYMoPV6DscGqmrjKaW319adR5c oITO9oitlqJKv/8mcI1DYGLzU6BeDnerRTsXk/KeggzCt8PHTfe2u06NBU652qYoH9gl50FOehT bP1RiE6bSPO7cyTx7fuuvlLVkOuRF+Bbou+htvyVRuDsaLKpRXTBosXDte3QcUEFeR58J4NdaMV KhIPuDKTV8Al9aDT1BIlBPkn3G3xXKMJXsACgD7Mc0jROrFdGghF2TLUxBvuJEGnGCjwmBnWrDP mZxKw5fQTPfiq0EvVd+5O6IyGGhL+KZoqDXCZ+HxXL7jS4W3iWaGHRg6tljnKsAwm4IZ0xpFDOG vIP4jDPnhkKX9P1I9qtGFMruUE+CX9/A4Ksy7mfu7VoMhlcxFCXrJsgEQvEwwY6xJLc7A3tJnsw O3z42DNFTPwz7VizVvVx6HlZ5uf0m7yjLAOf9y1t+0tzsAUbx5q5Py7RTmNDdVnzS5EzPC8J8Z4 kyUOaRLi3fLnVWpy1pJYrBV4LfiR5e3PVrjgUTipIcVv4eDFpE4vgppvYdY/fM2Ovn9Vfv8Y8zY g1bUBeQJ08MT9sQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Dmitry Baryshkov --- drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qco= m/pinctrl-ssbi-gpio.c index 82679417e25f..3a8014ebf064 100644 --- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c @@ -507,7 +507,8 @@ static int pm8xxx_gpio_get(struct gpio_chip *chip, unsi= gned offset) return ret; } =20 -static void pm8xxx_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int pm8xxx_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct pm8xxx_gpio *pctrl =3D gpiochip_get_data(chip); struct pm8xxx_pin_data *pin =3D pctrl->desc.pins[offset].drv_data; @@ -519,7 +520,7 @@ static void pm8xxx_gpio_set(struct gpio_chip *chip, uns= igned offset, int value) val |=3D pin->open_drain << 1; val |=3D pin->output_value; =20 - pm8xxx_write_bank(pctrl, pin, 1, val); + return pm8xxx_write_bank(pctrl, pin, 1, val); } =20 static int pm8xxx_gpio_of_xlate(struct gpio_chip *chip, @@ -596,7 +597,7 @@ static const struct gpio_chip pm8xxx_gpio_template =3D { .direction_input =3D pm8xxx_gpio_direction_input, .direction_output =3D pm8xxx_gpio_direction_output, .get =3D pm8xxx_gpio_get, - .set =3D pm8xxx_gpio_set, + .set_rv =3D pm8xxx_gpio_set, .of_xlate =3D pm8xxx_gpio_of_xlate, .dbg_show =3D pm8xxx_gpio_dbg_show, .owner =3D THIS_MODULE, --=20 2.45.2 From nobody Mon Feb 9 09:23:04 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B290D26A1BB for ; Thu, 10 Apr 2025 09:35:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277710; cv=none; b=Lf7vo1lIrTrgoU7MOtSXzQ8KUdOrUnYAv8Z2JAPNTk84/hFoMcH07gRiyzIoIcm1pFoGLoUj3nis1lZ7rhvZIccqFk1W/AnB3DpME5fCyfWacZBGpBXbyIKffD1IcOghJ22t7j05PP7ogD/FF5NtSoc4bCLElm13j8gmerKCC6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277710; c=relaxed/simple; bh=eVo2TmgtlN2R2X3Zf9Lol8n9FuUHnBY+y4wdcdE50E0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=c/fZOi3+AqbRlHyTuyfCpztad0q6bQpTFsbmZVKbHOzJY20Fkxhx3lNv5lBSWJCqfnOlNIpDPD7TZei/LlegPxJRkdoFm2OTZ6Ioy6+KV/ifD9tu0t9jZmZn5RormSvuWx3dkxJnrd/HS4vTwsuVhxDxVZC6d3exzXLbl8oDCxw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=COQDoNwG; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="COQDoNwG" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43edecbfb46so4922885e9.0 for ; Thu, 10 Apr 2025 02:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744277707; x=1744882507; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9wnrmZrdHGq/Ptu9FCMC7eVlEpQiRVau7cfrJW7kOec=; b=COQDoNwGdlffzA3xauBKXcvWNWKHAmwSy/n5dICwNAj4Zu+S7Yh6sGF/Nv1zwsVoji iWLbfw6sdMb0kuBPgwlEfunA89MJ3wm3xFbw9p5pzpMMQy3/uRtA4R/5tPYfdbogU/fL 0wzBg50cIfBTwGqegKbG8H+5qoUhk0bIzDQ0f1FLUbmO0NOK5HNUXPftrUH6ZMNUz9ns NfLgMJI16TjTB+g5MCCaKtKq/kASz8g4rdaLkyMBz1vNJipE9hfO5fB4Ax8+GNB/wQUO SaoUK0mpqOC6taPkkbc/NOKpChKBOb3JCPlfNvQuvWFAKxSNDTB5Nwr9U/GBhx1lEImD Z2Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744277707; x=1744882507; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9wnrmZrdHGq/Ptu9FCMC7eVlEpQiRVau7cfrJW7kOec=; b=TnsngFr4dXZ4feXNof9PymO1mKMRHE3+CM1q7oLvV/5VNPD9C9bGMyuj0ZUfcpccm6 Zz7VQEiaHi1UIytTzQYOIMmkIo7h8A4+F3ADOG6/k86bCJSKUMlRG9MvtiTwe7dqnuaw LyuqWZE5BNfP5lD8cInnQtQQvqpe1WNjdaWdALFs5SoAOnwRoBAYT3OhLEnQHAxeuiPL WTdP+1GOF04zkwQnKtlkky0MRl+Y25a0EON5Y3RceGCq3zilXtht1ebgAU928AodDx6z EPfAjzHDEsSqTFfVtWf8GCYdwz/lkzGOJSSslGak3TfXdT+05U1qTXe7kes622UVRvfh sG8g== X-Forwarded-Encrypted: i=1; AJvYcCURetK3Q3bxvTfveqF10Fw4zeT/BfJVKyA0VbBlJvBrCA8c2Edi+xQ5rKvKqZvb7QacqeIBHgKRa6dJoTw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2UCl+6JZCy99Ylfi3EyeixWiGNOEoNIEl0mtIUf7oAe0gnBX+ cw1AyMIeemNyjUpnvDLwrgZ71yjp8CYXHDbbuWP3Ylq/6h9t+rprZiBzUAtt0Qo= X-Gm-Gg: ASbGncs4lUaHBD2k8Nj4ZsFA4g0zkJfgkBo2lajvAAOr8R2rSSwTXBQprAqcV+8OOuq BGe5+3WdF1flKSXuraP4giO94dvB0mj36pfRNhT6ovd/wmNQlbu/8gWILdkM5lM9/bPtjqHKhux wA/yXfYXksO5lCHgvkP8GmafT+/aUtnliVz0Nb2KAd8IIqq8zjdnMcDrD/LfMgUmVhap44UumMX bed+rlF23axxHyOTQzPRJGK7Ah8tb2WbN5pu3wRKbqXtSTenrAdU1fJd4pk3YDCsuBNHdfQ2v8s y2VvbIQlsl3n3cm87tWLbDNHbMys91i3xA== X-Google-Smtp-Source: AGHT+IGakQPRYAPoJeyW7V5nBHKcFb/A/w0K9tmVzuwevmUfE7eHObjlPjw7A8Ij+9x62tILpo5Brg== X-Received: by 2002:a05:600c:138a:b0:43d:4e9:27ff with SMTP id 5b1f17b1804b1-43f2d7af1cdmr21099305e9.7.1744277706886; Thu, 10 Apr 2025 02:35:06 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:7c4f:f9d1:94e0:53f8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm49698435e9.9.2025.04.10.02.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 02:35:06 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 10 Apr 2025 11:34:48 +0200 Subject: [PATCH 6/6] pinctrl: qcom: ssbi-mpp: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-6-6a6891338aae@linaro.org> References: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> In-Reply-To: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> To: Bjorn Andersson , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1522; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=tLV0wE3qzspwnGpVRf4xL5olQ7zvo+pba8sfw+/Sleg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn95DEzBrkMLJs75LETQ44j8nkxaxMY86Ykysn0 smsHuuKeWyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/eQxAAKCRARpy6gFHHX cqkMEADblPn6aOx+OrtpJrETH6MXqe+xcAyk6YzC7QkHT1ed7muXekwa5z/ns4vdBg+vjdYe5cA nI6MYeBI00QuCAulcPLG1PaDhiWlQVGCoKo72gVtvrQ7WWX3KYEO2h3KolApV6VO9vBzxRmlNNp oXeEVu4yntXxVjgQW9IwqNNdA9yby+74CIgFnZW3oPm80l40U+u2KrmkPG6WI0l27I4CaBm7wvj 6upPOcO7XcL3U2AHw2W6oiy1NBYz1pdVBA0xnaZOp+jwG4GbC51HZDq/xZXA1/0UgAckLRIHBsS YDwKFv+kmvXMkik7EFFktVOnfHlpTsl6/pZvru5GoW6RW3DEX4wcdHxTAIBIe071BtRqUzbvdGd hSpEteSq3knJDiqMuizmpSIPpHkHjNJrT5uqTABHeWDWYMC1rlO9AvxoDA6/Q/eZkGzDhx006YE gfTwRTW2CAL4hZ9ZftY8v6DMu+WVoJyw8aBf2ICV5BetJDvlOoIHWJ/bF9GGAgpGddTRz9AMpJY VBkvNZQTn+iztj94eQY8Il+YZUpeQ764BhVBFOjBGfrowahfLBn5DRwThWHV0ZK6/Y7+Uh9zgFp XgWwQcDrFTpcHyvNfHR7eaL93gK1K/L3Iohr3pHj1bnBK+aGxihS3zWsWOoEcg/ENxTZZeA3dxR O06WXteu3SoaDMg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Dmitry Baryshkov --- drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c b/drivers/pinctrl/qcom= /pinctrl-ssbi-mpp.c index 4841bbfe4864..087c37d304fc 100644 --- a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c @@ -511,14 +511,15 @@ static int pm8xxx_mpp_get(struct gpio_chip *chip, uns= igned offset) return ret; } =20 -static void pm8xxx_mpp_set(struct gpio_chip *chip, unsigned offset, int va= lue) +static int pm8xxx_mpp_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct pm8xxx_mpp *pctrl =3D gpiochip_get_data(chip); struct pm8xxx_pin_data *pin =3D pctrl->desc.pins[offset].drv_data; =20 pin->output_value =3D !!value; =20 - pm8xxx_mpp_update(pctrl, pin); + return pm8xxx_mpp_update(pctrl, pin); } =20 static int pm8xxx_mpp_of_xlate(struct gpio_chip *chip, @@ -633,7 +634,7 @@ static const struct gpio_chip pm8xxx_mpp_template =3D { .direction_input =3D pm8xxx_mpp_direction_input, .direction_output =3D pm8xxx_mpp_direction_output, .get =3D pm8xxx_mpp_get, - .set =3D pm8xxx_mpp_set, + .set_rv =3D pm8xxx_mpp_set, .of_xlate =3D pm8xxx_mpp_of_xlate, .dbg_show =3D pm8xxx_mpp_dbg_show, .owner =3D THIS_MODULE, --=20 2.45.2