From nobody Sat Feb 7 06:22:09 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18DB9268690 for ; Wed, 9 Apr 2025 14:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744209803; cv=none; b=nv329oqQ/qy60CGtyHR0PKzE4qSWAzvGc+0ywPBjgu2IY17wdEKbpkacrSL7TlvsQf3Xku40GCgnQPcPPrfRtsYAhi9ziXp4mKAggc0m0CSnrEd+lxHBlPET+1pJU2qaOfdoxy41hRGhgae6YwGBNJaE61eP86fPuRnhxEsYJcI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744209803; c=relaxed/simple; bh=cyVWJiESR6+ddF3hk2p72+BYjghIjU6b3CLJ4+lQg0c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RRLNxfUbtCWFPfs7e2q0q+h82RtKQ9M1KQzUysyj6sdzpHWJ32pTSdZQKKhxmzmLAjCSXijhBGvzBn47EJB/Z6NZmc2t/lW5cYKnTHJDMzMfZIdr+VxSAf6XVMHFO3+Q//gczqw2adcoNv+Dy5ZTGmt+i+u1ibxIvkM5eZrDxj8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JwCMS+qB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JwCMS+qB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744209800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aPfUA5BWs8R/De+l5pzd9CJqVt44oZhdUA/jGokvVSs=; b=JwCMS+qBkZpPddaXMzJntVn08lc8cqAAu/FFztvROkMnhNOEvmJW+/rOsbXl+A4VjOwhfG CcN9mIRe7OukespY2z4WeLydQAaFe6xjYPzJ/QiJUQ8nsfwcFkbnX+KKwpgTVDjU6EbPKp YRFc4WBpu2kmEp6zGqda6RhUA/x5IIw= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-K9GxGEO2NAudOrSY5XnXcw-1; Wed, 09 Apr 2025 10:43:18 -0400 X-MC-Unique: K9GxGEO2NAudOrSY5XnXcw-1 X-Mimecast-MFC-AGG-ID: K9GxGEO2NAudOrSY5XnXcw_1744209796 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8CFC419560B8; Wed, 9 Apr 2025 14:43:16 +0000 (UTC) Received: from p16v.luc.cera.cz (unknown [10.44.32.72]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6606918009BC; Wed, 9 Apr 2025 14:43:12 +0000 (UTC) From: Ivan Vecera To: netdev@vger.kernel.org Cc: Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , Lee Jones , Kees Cook , Andy Shevchenko , Andrew Morton , Michal Schmidt , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH v2 04/14] mfd: zl3073x: Register itself as devlink device Date: Wed, 9 Apr 2025 16:42:40 +0200 Message-ID: <20250409144250.206590-5-ivecera@redhat.com> In-Reply-To: <20250409144250.206590-1-ivecera@redhat.com> References: <20250409144250.206590-1-ivecera@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Content-Type: text/plain; charset="utf-8" Use devlink_alloc() to alloc zl3073x_dev structure and register the device as a devlink device. Follow-up patches add support for devlink device info reporting and devlink flash interface will be later used for flashing firmware and configuration. Signed-off-by: Ivan Vecera --- v1->v2: - dependency on NET moved to MFD_ZL3073X_CORE in Kconfig - devlink register managed way --- drivers/mfd/Kconfig | 2 ++ drivers/mfd/zl3073x-core.c | 35 +++++++++++++++++++++++++++++++++-- 2 files changed, 35 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 30b36e3ee8f7f..3c54b9e2b8003 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -2424,6 +2424,8 @@ config MFD_UPBOARD_FPGA =20 config MFD_ZL3073X_CORE tristate + depends on NET + select NET_DEVLINK select MFD_CORE =20 config MFD_ZL3073X_I2C diff --git a/drivers/mfd/zl3073x-core.c b/drivers/mfd/zl3073x-core.c index ccb6987d04a20..116c6dd9eebc7 100644 --- a/drivers/mfd/zl3073x-core.c +++ b/drivers/mfd/zl3073x-core.c @@ -8,6 +8,7 @@ #include #include #include +#include #include "zl3073x.h" =20 /* @@ -58,6 +59,14 @@ const struct regmap_config *zl3073x_get_regmap_config(vo= id) } EXPORT_SYMBOL_NS_GPL(zl3073x_get_regmap_config, "ZL3073X"); =20 +static const struct devlink_ops zl3073x_devlink_ops =3D { +}; + +static void zl3073x_devlink_free(void *ptr) +{ + devlink_free(ptr); +} + /** * zl3073x_devm_alloc - allocates zl3073x device structure * @dev: pointer to device structure @@ -68,12 +77,25 @@ EXPORT_SYMBOL_NS_GPL(zl3073x_get_regmap_config, "ZL3073= X"); */ struct zl3073x_dev *zl3073x_devm_alloc(struct device *dev) { - struct zl3073x_dev *zldev; + struct devlink *devlink; + + devlink =3D devlink_alloc(&zl3073x_devlink_ops, + sizeof(struct zl3073x_dev), dev); + if (!devlink) + return NULL; + + if (devm_add_action_or_reset(dev, zl3073x_devlink_free, devlink)) + return NULL; =20 - return devm_kzalloc(dev, sizeof(*zldev), GFP_KERNEL); + return devlink_priv(devlink); } EXPORT_SYMBOL_NS_GPL(zl3073x_devm_alloc, "ZL3073X"); =20 +static void zl3073x_devlink_unregister(void *ptr) +{ + devlink_unregister(ptr); +} + /** * zl3073x_dev_init - initialize zl3073x device * @zldev: pointer to zl3073x device @@ -84,6 +106,7 @@ EXPORT_SYMBOL_NS_GPL(zl3073x_devm_alloc, "ZL3073X"); */ int zl3073x_dev_init(struct zl3073x_dev *zldev) { + struct devlink *devlink; int rc; =20 rc =3D devm_mutex_init(zldev->dev, &zldev->lock); @@ -92,6 +115,14 @@ int zl3073x_dev_init(struct zl3073x_dev *zldev) return rc; } =20 + devlink =3D priv_to_devlink(zldev); + devlink_register(devlink); + + rc =3D devm_add_action_or_reset(zldev->dev, zl3073x_devlink_unregister, + devlink); + if (rc) + return rc; + return 0; } EXPORT_SYMBOL_NS_GPL(zl3073x_dev_init, "ZL3073X"); --=20 2.48.1