From nobody Mon Feb 9 00:54:25 2026 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52DD61E1A33 for ; Wed, 9 Apr 2025 06:08:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178885; cv=none; b=W1OzEFFc+o1tknll/LYKhfrdul0lkFz1WImS8mWzsdOyLDe0bNrBUUV/HhBIiXEy+QFV1ElFjRgP/0fulLfoJre5nZnbz5AWyZHlk2LKgxIjxlMI1YmlPTBIUFW8jAQxsbe0LHoqBZkJhaAVJY8Ny2EfsRW56nMMWjIhF3Xi5Ws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178885; c=relaxed/simple; bh=yUglDtEpwZVjaGPveMCOEFvdP87AB0tTSBss9c6TB98=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=mBMA6nCmTyxsdKwXzwAXYVv/pLz2SzxYRp/SES9FXyQWq4LudOlb7O4icWRv5/Wy80ERnJ51yVn1ergu7JYSlsYXqdBRMMLnHMe9E+exXI21PBMF5a1NbzUVnkZabfF0KeRNdgbpEyjKL9PF5C+v6TRrxiBonJVQzIOsouhF36g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qr8bX68B; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qr8bX68B" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-22aa75e6653so24983695ad.0 for ; Tue, 08 Apr 2025 23:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744178883; x=1744783683; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=XafRrptC07unstJw1HreG0n5lBFJ2gSj/BsZTF4fwvk=; b=qr8bX68BwTUh/ECQry1/KbYxJTyru54XR2XAXetp88viomUnzuo58iImTshths1CHT G68t76duWFIydoCx9PhgqI1KOp6rNfiO7Ob7GsyLOWLFey/bLCIM/EVYi9sS4BRZWabX d/kH4Qe+x/iAHVH718BphjrbU36xlyXJA2YLN4iX7SQC6lU7iil4NQlCM+6qCfErRR6W DAwKA727vV1d01zHSI6DQ3Qze57WXRGVadbShwTqFqcdoymt8048q2rT0w8O+ZEUnJ1l GFbIRiP13EEBKah5MOLObOR8/ZpvNOcEJKf5Ka2Y+ELwIhou9MsyjiclSHO/D9Cjwb3J s8nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178883; x=1744783683; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XafRrptC07unstJw1HreG0n5lBFJ2gSj/BsZTF4fwvk=; b=Ec+vpHqZMEPvIQJ4rtaHewFWj5+e7JLrFIbSGHG5fgXmUkcX//OoreLioiRkF0dOTq tAArLYFsPLBAXpyk3L8v/5GSZX6vbb2Fu1/37qu8JAuYT3i2m/jY/H3tD/P3/b0BPSdv ynNwyXNXP+TKvtD95WvJ1chcZRtvke6Gn6cJ9n5hp2CZKjFwUWwvYrgKoNHG+d3Abn/+ o5b5CyIjHykaIweV69Ey+VXu0bBEPHx/XcV8eW97I8r3HM4V/weaOBhloClsL5Z9PT2s Rch7tqHmyJ9yF0bP1WuISN3C7TeW57CLKtjyZC8m70U6iKyAY+NwWUIff+IqtG5BZf3b kd/Q== X-Forwarded-Encrypted: i=1; AJvYcCW+FGi4JZPuKUsgVBPjMJ+9C26Ci8stmu+lLsZdcwu9mKNxrb/Ixu/78ImBj5ix30sy4LGSU/SzhulkfDg=@vger.kernel.org X-Gm-Message-State: AOJu0YxekWx8y04133s6t8R/n5cPYUqgoLAesvWsmBkH80+9fWjrmPM6 Zg1pHgEoFxVEKz1GQEd/VmOU2qUVwAGutc2zvC9jRxg/+KLKuxepT6hZWfUmBhqUgxjhzG/EH8A VcGcdwg== X-Google-Smtp-Source: AGHT+IG1t5cGUkVzWEt5u7hTXXjvZhkM2WZpchTlIgJSc1XitOD5BysYz1RHQBjDDP1/1goEacQRAxREI2SB X-Received: from play12.prod.google.com ([2002:a17:902:e18c:b0:227:e9e8:7153]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:124c:b0:224:1781:a950 with SMTP id d9443c01a7336-22ac29916demr27017675ad.14.1744178883586; Tue, 08 Apr 2025 23:08:03 -0700 (PDT) Date: Tue, 8 Apr 2025 23:07:32 -0700 In-Reply-To: <20250409060744.698511-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250409060744.698511-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.504.g3bcea36a83-goog Message-ID: <20250409060744.698511-6-irogers@google.com> Subject: [PATCH v4 05/16] perf intel-tpebs: Move cpumap_buf out of evsel__tpebs_open From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Weilin Wang , James Clark , Xu Yang , John Garry , Howard Chu , Levi Yun , Dominique Martinet , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The buffer holds the cpumap to pass to the perf record command, so move it down to the perf record function. Make this function an evsel function given the need for the evsel for the cpumap. Signed-off-by: Ian Rogers --- tools/perf/util/intel-tpebs.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/intel-tpebs.c b/tools/perf/util/intel-tpebs.c index 2186818b2c9b..2b04deaf66ff 100644 --- a/tools/perf/util/intel-tpebs.c +++ b/tools/perf/util/intel-tpebs.c @@ -83,12 +83,15 @@ static int get_perf_record_args(const char **record_arg= v, char buf[], return 0; } =20 -static int start_perf_record(int control_fd[], int ack_fd[], - const char *cpumap_buf) +static int evsel__tpebs_start_perf_record(struct evsel *evsel, int control= _fd[], int ack_fd[]) { const char **record_argv; int ret; char buf[32]; + char cpumap_buf[50]; + + cpu_map__snprint(evsel->evlist->core.user_requested_cpus, cpumap_buf, + sizeof(cpumap_buf)); =20 scnprintf(buf, sizeof(buf), "--control=3Dfd:%d,%d", control_fd[0], ack_fd= [1]); =20 @@ -287,8 +290,6 @@ int evsel__tpebs_open(struct evsel *evsel) return ret; =20 if (tpebs_event_size > 0) { - struct evlist *evsel_list =3D evsel->evlist; - char cpumap_buf[50]; struct pollfd pollfd =3D { .events =3D POLLIN, }; int control_fd[2], ack_fd[2], len; char ack_buf[8]; @@ -305,10 +306,7 @@ int evsel__tpebs_open(struct evsel *evsel) goto out; } =20 - cpu_map__snprint(evsel_list->core.user_requested_cpus, cpumap_buf, - sizeof(cpumap_buf)); - - ret =3D start_perf_record(control_fd, ack_fd, cpumap_buf); + ret =3D evsel__tpebs_start_perf_record(evsel, control_fd, ack_fd); if (ret) goto out; =20 --=20 2.49.0.504.g3bcea36a83-goog