From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9CD1D86DC for ; Wed, 9 Apr 2025 05:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178349; cv=none; b=KoCyOvhF4jKBwwiaQ5/gOkY/zm5Pg61raJPyqeKydWNryc4B6RztWVAwOg7cr+azHyQe9CEBtkMqDhRL0ua4G2fT3wTpG6SOHXvj+VgTBxNSWF/dZWncYhSi9C0+BbNsmpFuGNFHJb78BI4dazsOjYc2Z6ZaEnlGhf0FmYcnm5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178349; c=relaxed/simple; bh=nmZxXpYGtNpYNOhj5UOGoXLASWCzFprIfKCP3NbhVDQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QBRM1jhSfqllhdXEdUdJ2Scrn8fSol5CytTyYEAlwbLK4YlFIVFQxhKxbqjhGUhVY1fjj1vQjODmESxux7JsCX37XsUJuIpt0dFAgHuDb2ZdjtBz5Yav8StEXr3S9P9TEbV55oSAtm0EeMHOx9xoQ3XtVJhXiU7D6WbFKaTDXg8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=USFF2+XP; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="USFF2+XP" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2295d78b433so63345205ad.2 for ; Tue, 08 Apr 2025 22:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178347; x=1744783147; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C29l0P6mM8oN5IR0sSrgm0hjHh5+2F3vS6hbJExkJEA=; b=USFF2+XP4qA6B/a/1pBCA7gl8X/5PiIVDTeZ2OkP6tCRkdkcLqHJO8DICqdBLLLryr +x2U8k4PgO8gMulQ3K+Nf7Igr30k1xpYG41vP+lzIC8Ye1BcMUvoK2W04T/LameguydL XEmCgJxfsNE+QvpIAyw1yoTKahVjNFkZz7Ai5Y7sY5erwbCdz1/rkiZjMHH3SmD2Rtoo 4Ag9LoeEwQXPdtStxpYh0x8urxLEicrzwY9t8u9iXsMsJw7nUPQf76+JTTkrziGl2Ypx NeVeUgC6cgiFXAd6Ps2poy6sLL7QhUGXW944fSzLpWcMXLudEG049xDailqHoED7XpcF tJAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178347; x=1744783147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C29l0P6mM8oN5IR0sSrgm0hjHh5+2F3vS6hbJExkJEA=; b=SZUaKQWHfpN7GwLBEFjvQaWQt5LpjkcHAMu4FXM9yv+FhIpGD7tEQzzYQwgD3uIfy4 0JLcYYp7vAuqxiWxN9SPbqs6/JIGqBHR9Ytdwj60CFnCcZL90QtrQ3vsTjdJxXEQvXE/ 5SRC4ITu8jwpfD3c6QpjqTyAfGrto/0qD2pG+yhY9aDYQ+KrAWX571FYyAMX4M82TCeR h7PGC1I8qyD7uvDH0cmTZU/HwJ8zLDPDWdtdSdvuJxLepB0qINoZs59licEK6lPGrELw MTA2ygnYXdfxmNAoiBwD0YfyGpXk/rWzsM37hhfYSImOkyzOt8Qbjc44A55ZUTal43O7 Kv4A== X-Forwarded-Encrypted: i=1; AJvYcCX3LRYVMddq3NG9LFfwZzsBIEf9Y5SxAGPIjz6OkBG+dT9gozpY3klsGrzN5IDvTDzf8vxURaLF28hou8w=@vger.kernel.org X-Gm-Message-State: AOJu0YynXLHoxU93hnBuzUbl7077C8b5YDCjk+pUPQ7Qu3Njlef1YQIJ JQBaxCRjeEw/H6elTPsraFLMJaWSFyR/LJ/F4b7zAGGNx1S2SGZ5ayR1RyMv1g== X-Gm-Gg: ASbGncuLmbdW0xsvS7dFWV3nUyDn8+otMCvtUxd5CqD/oWp7JPDVCVntTZ8BTYaqYxv 0ZD+5GqpofFrYolCBefPho5xxcnfGYfIWqTt+XxqmRANom7aFG7OMCuT6mwhlayhC1kdfTgddpq TZgWKJfRJX3ZlogUDigZcvUtNE5QlQwq9L9FWdFpXEubSpo1RitAbROewxEcCSLPcA7Ju+WoTUx KynhsjojckcMOhre8FaBDzDLrSmzGQ55qwGoIHdcLFVkxj0CZjbvfKcbPA3tOSjyIb8rIO1XRNZ 63gII7SACsB/cLot8SeeoI+8P3rkklSClCY4iS57sRG1Ldowiq7m8PFFRc0cMZ6SbTZwLC86/gz Y4c8yBQ== X-Google-Smtp-Source: AGHT+IHo6HMz82o6Ejey7aqKjvSwU8H+RJ9gcTvRcf1DGffCn2lIbToSTUUZE8jzXuEnGFk881+JlQ== X-Received: by 2002:a17:902:f552:b0:224:c47:cb7 with SMTP id d9443c01a7336-22ac3e0ff99mr18324395ad.0.1744178347245; Tue, 08 Apr 2025 22:59:07 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7b90d99sm3461165ad.99.2025.04.08.22.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:07 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 01/21] staging: gpib: Using struct gpib_board_type_ioctl Date: Wed, 9 Apr 2025 05:58:43 +0000 Message-ID: <20250409055903.321438-2-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_board_type_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 5 +++-- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index a1992a2b06a0..e12a9e56d808 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -813,7 +813,7 @@ static int board_type_ioctl(struct gpib_file_private *f= ile_priv, struct gpib_board *board, unsigned long arg) { struct list_head *list_ptr; - board_type_ioctl_t cmd; + struct gpib_board_type_ioctl cmd; int retval; =20 if (!capable(CAP_SYS_ADMIN)) @@ -821,7 +821,8 @@ static int board_type_ioctl(struct gpib_file_private *f= ile_priv, if (board->online) return -EBUSY; =20 - retval =3D copy_from_user(&cmd, (void __user *)arg, sizeof(board_type_ioc= tl_t)); + retval =3D copy_from_user(&cmd, (void __user *)arg, + sizeof(struct gpib_board_type_ioctl)); if (retval) return retval; =20 diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 6202865278ea..4ddcbc2a81b0 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -12,9 +12,9 @@ =20 #define GPIB_CODE 160 =20 -typedef struct { +struct gpib_board_type_ioctl { char name[100]; -} board_type_ioctl_t; +}; =20 /* argument for read/write/command ioctls */ typedef struct { @@ -143,7 +143,7 @@ enum gpib_ioctl { CFCBASE =3D _IOW(GPIB_CODE, 21, uint64_t), CFCIRQ =3D _IOW(GPIB_CODE, 22, unsigned int), CFCDMA =3D _IOW(GPIB_CODE, 23, unsigned int), - CFCBOARDTYPE =3D _IOW(GPIB_CODE, 24, board_type_ioctl_t), + CFCBOARDTYPE =3D _IOW(GPIB_CODE, 24, struct gpib_board_type_ioctl), =20 IBMUTEX =3D _IOW(GPIB_CODE, 26, int), IBSPOLL_BYTES =3D _IOWR(GPIB_CODE, 27, spoll_bytes_ioctl_t), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F22D1DC994 for ; Wed, 9 Apr 2025 05:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178351; cv=none; b=V1IhnbdvKVuoscA5Bq2PcL2ZprHiAaBeWZzm7mQOhy2LbPXSnPU1C48H3B6f1AdHp/qcRgZBErohQKNxM62ZBJPzCwnDlDpbh8COoe6fekcHyWAF46i0Yv5g8HAbiQ6B0WMn2p3u//Vvrw0uNmQ/fwH1kmL5QdRlc2m4KLoXBR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178351; c=relaxed/simple; bh=2uVTnlkfRmi7jviGiaYvu7bTwwElCVFfDlGVzZ9llzA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q9jrW9c2S0bH3AudpOVB7nKDIQMOTpeMTFUWpIq7pzk8dRX66xksR7hxqV+iym/iUYUemKWUYBJJLHnta/2oACk0RaSl0RHSNn4Yg9ZWHalAZ8MQgqQ9kne0KSdFyphViwgrpZbfhz02K3HeJAq/+tQfindbRl7ayaH4I40BP+4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=ju8f4ds7; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="ju8f4ds7" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-af5a4cd980dso4550261a12.1 for ; Tue, 08 Apr 2025 22:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178348; x=1744783148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wceHmgn6IqtL2iSeZHYJ/lyHWDm317e8g7Wc7VP6PSY=; b=ju8f4ds7G0i0H7kEU1VKzaTdRiE/XJzn7GJweHwzGIuqoVPel4/UXEZvuR6jz0eKiZ tq/3MpUtJnaKaw7KtXKgR4pEWPgYOgyxQTXOLx7X60NfOSRJnKA+CWpP2HWrLiBia0NX YuGK8qttMITR9JflvTc8kLcbfeJntT9sGCdw/fS+b7WZN2SMF+GtAOVaIOdqOyJy6MmZ 5ZI6c9pP8BgIv3P1jC2DEQ4aIVTlvTDFbM5yfbJFcV7kyMiCW5sClkUVAgsmwUwWTYs7 F24TvRSC1Rm2ILs5aPniNr3COp0T3hNaIUW6Hwncbra9uFBTFiL3JnCeCzw5Vea75Twz VnJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178348; x=1744783148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wceHmgn6IqtL2iSeZHYJ/lyHWDm317e8g7Wc7VP6PSY=; b=ogrQaSUgUwD29oOzK4kFxe6ARg3+EWWDZD+6ar2+xEuH1vfjwjTMHxXUsZirwppYSc mn9BTKSUWoYvIWyEIb6mGeEOR0yIDtwlYLk1Bc5aobM2nNCV8jNAOqo/g7tOLGtbRnao 9Sk1+Qnn+3kBIYz9YRsmKk9HjVRV2C4TH5cZN86QoA58fNbGNkCGBXvCAbBmS+3JDOPT PdibnX/6LLYguSrF9TzKalmS1kOW0zD0Yrbk8Qg6LgTrVB15MWK8drQVS0kQHl2Aiqoi nRiI3KH0DY7p6QIqX1Bm4nxWzidri92nfJI0iORm/nKq2eLyKxjVlp/3weht+LIx3HDu rcng== X-Forwarded-Encrypted: i=1; AJvYcCXRP7KJkMin0YnQmBuBF6+dhjyc5tT1uwvW+5F/xMdILDhHUuzcEMbMICuQvFXT1v50OsgT4TwJeAwcm1Q=@vger.kernel.org X-Gm-Message-State: AOJu0YztGWBzHSbcRR552x0BdpWcKAmUNuqw2EmIfMalCTqeI8EjHiEp wIf8ScWimnRExcf27F0Uxc71RCPp7zcyGcAzLul3oQNOzMU2bHdT049U19JhP1Y5JcW9mvKqzj8 = X-Gm-Gg: ASbGncv/7B6GGaNPj/NHaKUy6J2A1EdiBa0nHhpsWqEKVS60XngVH+jFqITiKlxg1jm 8FLyb6OeD2pcRxvzYvJYKcBnANLESCNlxVNov8kAyCVXQCYvgxQ8a468TCGP8OGq8IoGz4YhZf1 /MoiLS77zgT9YxoDaKS2+r6p/ZZNhum+I6YqGJiC3QGJE34qzq7/DnM9rGrbrNu7eebtm2OOKi/ KJyIVzLdgx7F8ufv7K1YjHXlRYz+baMgwCaKHohXD62jUKGloP9lwhPhBNGJbwx1xIEeuEbv+4v An+cwoiGVyeCp444opeKO4KGkzatWtedfI/YyrQxOYyUnwMRcJwdOivetccJKqPYc2s5Auedw82 4URahtg== X-Google-Smtp-Source: AGHT+IFIhXnuW04WLdiWT4GUokoi4V5x2Z+gh4XvDhUkaTS4AbtEARWJsMxnN3G1skpWl9beNEtZbQ== X-Received: by 2002:a17:90b:2e4e:b0:2ff:6e72:b8e2 with SMTP id 98e67ed59e1d1-306dbc2e945mr2581540a91.31.1744178348479; Tue, 08 Apr 2025 22:59:08 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd10c40dsm664351a91.5.2025.04.08.22.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:08 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 02/21] staging: gpib: Using struct gpib_read_write_ioctl Date: Wed, 9 Apr 2025 05:58:44 +0000 Message-ID: <20250409055903.321438-3-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_read_write_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 6 +++--- drivers/staging/gpib/uapi/gpib_ioctl.h | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index e12a9e56d808..02ead46453a7 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -865,7 +865,7 @@ static int board_type_ioctl(struct gpib_file_private *f= ile_priv, static int read_ioctl(struct gpib_file_private *file_priv, struct gpib_boa= rd *board, unsigned long arg) { - read_write_ioctl_t read_cmd; + struct gpib_read_write_ioctl read_cmd; u8 __user *userbuf; unsigned long remain; int end_flag =3D 0; @@ -940,7 +940,7 @@ static int read_ioctl(struct gpib_file_private *file_pr= iv, struct gpib_board *bo static int command_ioctl(struct gpib_file_private *file_priv, struct gpib_board *board, unsigned long arg) { - read_write_ioctl_t cmd; + struct gpib_read_write_ioctl cmd; u8 __user *userbuf; unsigned long remain; int retval; @@ -1024,7 +1024,7 @@ static int command_ioctl(struct gpib_file_private *fi= le_priv, static int write_ioctl(struct gpib_file_private *file_priv, struct gpib_bo= ard *board, unsigned long arg) { - read_write_ioctl_t write_cmd; + struct gpib_read_write_ioctl write_cmd; u8 __user *userbuf; unsigned long remain; int retval =3D 0; diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 4ddcbc2a81b0..15c924efe5bc 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -17,13 +17,13 @@ struct gpib_board_type_ioctl { }; =20 /* argument for read/write/command ioctls */ -typedef struct { +struct gpib_read_write_ioctl { uint64_t buffer_ptr; unsigned int requested_transfer_count; unsigned int completed_transfer_count; int end; /* end flag return for reads, end io suppression request for cmd= */ int handle; -} read_write_ioctl_t; +}; =20 typedef struct { unsigned int handle; @@ -121,9 +121,9 @@ typedef struct { =20 /* Standard functions. */ enum gpib_ioctl { - IBRD =3D _IOWR(GPIB_CODE, 100, read_write_ioctl_t), - IBWRT =3D _IOWR(GPIB_CODE, 101, read_write_ioctl_t), - IBCMD =3D _IOWR(GPIB_CODE, 102, read_write_ioctl_t), + IBRD =3D _IOWR(GPIB_CODE, 100, struct gpib_read_write_ioctl), + IBWRT =3D _IOWR(GPIB_CODE, 101, struct gpib_read_write_ioctl), + IBCMD =3D _IOWR(GPIB_CODE, 102, struct gpib_read_write_ioctl), IBOPENDEV =3D _IOWR(GPIB_CODE, 3, open_dev_ioctl_t), IBCLOSEDEV =3D _IOW(GPIB_CODE, 4, close_dev_ioctl_t), IBWAIT =3D _IOWR(GPIB_CODE, 5, wait_ioctl_t), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 955E91DDC2A for ; Wed, 9 Apr 2025 05:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178352; cv=none; b=Bjw8cpYzcr8YpSDD4ku/HxyADoP3of9f9xE8IeuXHwUk9bWbHRdv7cMw6hpw4cRRagAFoNIclSSELBoG8wNA6yTii6dRrNfjFVwoEI8otnmIn5PdHp5nHF7oWqCSigV+RNnaAwAcQzdv6hN6oqhTrwnRAekVXCNJUABp+wIr3Uo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178352; c=relaxed/simple; bh=crlTt5LU1J49vfYmzoVPDTcSILX4v7GG6DqyuW6vonQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bUwzjZI1CjAJsWGSpnpnBsqBSKklfDGjeKzR6C0tLfG3kR4nLQRs8xSz9L0fSlT6pJdUFYSpN2KPmuBOmOcpCUO+3nQ7MSYyqTmNgETuAqX9vjy00QeE335gpCk2HAOYG/xz6MnhA7rF6jg1AjC13qFjV5Ip6F3uSeBaWzfAdas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=SoQnUKU2; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="SoQnUKU2" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-301a4d5156aso6057728a91.1 for ; Tue, 08 Apr 2025 22:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178350; x=1744783150; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=469FFknBTj9ufpYfSZ5FRLvMehCRuA2KGyvdskryrK8=; b=SoQnUKU2a57l6cirxHWg3H1sxIX1mvDuM9//XOKCb8hDcb6murDU7pi/x4SbD1m5I/ 0SjhzxlTHIUfZU6pQOMfylW8dFVqIV84RolUlb8+b2sWkG30SynNSwZru7i3mjhUVrel c5Ta1+BopGZ4xcl/8JNv6N4UqdQRh6FLZOZPB84BdrbUZmbpSjSmq126J57+4n4dFkZN PdJovHQ1im/KOOCOTOC/bmSv862tVpKEifILKIpDS6b+MBKe2zhej1ToBQ0G6xZ1//uc KbtF58bxen6CCm7QTfJdJmocxQtlgkS4JP37PEaV/umZ5RvuGHai8+tkNQpnf4YcJJL3 Xe+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178350; x=1744783150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=469FFknBTj9ufpYfSZ5FRLvMehCRuA2KGyvdskryrK8=; b=RC3ynnUemMn20p/brGkSuOdPXIj22JaOaScgBMIrV33kBz3RDCIA/1ucVxUpXLm9SY v0CfZDsTu5cXHo5yov/klMiS7GPg6QbAbqXJyQx5SK5V+zocb5MM0aaSy4AYPyGoWKyr EzZxW2Uer+SF8bo0xW/Kfps//wlTlRE5/rvtTUqUBFsO3RZV4Kcy3aTVxIClONa+3tv2 u+e16RiDD1U6oWtuW7dK7fAeEZrQ9mcVOHOzId1lu6yZMY7kVCfYl9tzxzm2fpyk/hA5 TTYKq3IHEa/jhdKAoMraIBtgbALjT0ee4I1mDU1IHC7v/iO6/JEW8Cgrg2vn+qlmUU1N IVKw== X-Forwarded-Encrypted: i=1; AJvYcCWTjTPvtRzvyIXEv4TQSVWh+rLhIyOOkEfcuiyHOTWJYaQJ5rUHFySpUfXmAIiv/nwSe92SxBKK+Qo7fnU=@vger.kernel.org X-Gm-Message-State: AOJu0YzFNkxboCLQi7RYFh5cKxP1fMUl7psa/Dv9i0AAbS58eUh2PnLs 3Ig0+Ek6MTQcy+cO7CZ3/pM1llotu6cuPFRfICRlOoEgWt/cB06cr4MkF7SDBxQbWaXy6SrrpKU = X-Gm-Gg: ASbGncuRU1Mc7iFReisZYavcpsp2vhuQiYzslaqY8Y80sOKIi2nUv8awF4Q5sEIYPPH ls3rND9AcTd8f+d3YVzRGVUvJBbILSdabui9CAAf5MCuI8hf+WvqOHw6v0ow0PcN07JlAv1ayaB Q+2h8hMIMV5V7BGznTSHJwawMM4lGkpTs7dwvrG372DeVdg8Avl1dsJniteUq8g0eaU6b8BzSYp RVXgX0MXu8wgJM8xDr6x/SWqe8ri4k850e9eQNBTCrHC9QCgBHbvOAqUROmgPKHtCYusTvDIwN4 4wfc1TFDk7ih86RspnoOkBmlPhCn9IWocp5pK7mGFJu3wFQ/NObreNSNbwz1fOpkxzR7gU9vCSF 3zeKFww== X-Google-Smtp-Source: AGHT+IGgVQ40tGIrqgt8p23D+8Gt/EeKU6rvZEXcJhU00ZZEv/+dWc3pppXF+JFOK+wLiH6VGvN95Q== X-Received: by 2002:a17:90b:5744:b0:2fa:17dd:6afa with SMTP id 98e67ed59e1d1-306dbbc26ecmr3028343a91.17.1744178349856; Tue, 08 Apr 2025 22:59:09 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306df07caafsm497471a91.11.2025.04.08.22.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:09 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 03/21] staging: gpib: Using struct gpib_open_dev_ioctl Date: Wed, 9 Apr 2025 05:58:45 +0000 Message-ID: <20250409055903.321438-4-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_open_dev_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 02ead46453a7..a0a9a07dab5d 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1212,7 +1212,7 @@ static int cleanup_open_devices(struct gpib_file_priv= ate *file_priv, struct gpib =20 static int open_dev_ioctl(struct file *filep, struct gpib_board *board, un= signed long arg) { - open_dev_ioctl_t open_dev_cmd; + struct gpib_open_dev_ioctl open_dev_cmd; int retval; struct gpib_file_private *file_priv =3D filep->private_data; int i; diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 15c924efe5bc..cfd1afb36e4f 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -25,12 +25,12 @@ struct gpib_read_write_ioctl { int handle; }; =20 -typedef struct { +struct gpib_open_dev_ioctl { unsigned int handle; unsigned int pad; int sad; unsigned is_board : 1; -} open_dev_ioctl_t; +}; =20 typedef struct { unsigned int handle; @@ -124,7 +124,7 @@ enum gpib_ioctl { IBRD =3D _IOWR(GPIB_CODE, 100, struct gpib_read_write_ioctl), IBWRT =3D _IOWR(GPIB_CODE, 101, struct gpib_read_write_ioctl), IBCMD =3D _IOWR(GPIB_CODE, 102, struct gpib_read_write_ioctl), - IBOPENDEV =3D _IOWR(GPIB_CODE, 3, open_dev_ioctl_t), + IBOPENDEV =3D _IOWR(GPIB_CODE, 3, struct gpib_open_dev_ioctl), IBCLOSEDEV =3D _IOW(GPIB_CODE, 4, close_dev_ioctl_t), IBWAIT =3D _IOWR(GPIB_CODE, 5, wait_ioctl_t), IBRPP =3D _IOWR(GPIB_CODE, 6, uint8_t), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E28911DE8AD for ; Wed, 9 Apr 2025 05:59:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178354; cv=none; b=Wo2Ig0k/YdSK9NT1KxQUEM3Lu0Ud8QTfZPGftzeUvyoCV1MIz3lff4EN6Ce05Kyf0x0XOCRDhEupJGCDEbqMGti2r2qM6Y6ymCyE6qptvAYdtzFVPUJYa3YcHQjATd2H5kFA1b0eZC/iNqO0wMTBkm89cXI4rPN/5CXAD0oky+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178354; c=relaxed/simple; bh=rYU9rxDJJ2uDKTInwUMU9me+tIhO5gmqoCpSL5Svm1Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UNEfqVAgFsuxd6u3gvvCndkvw9DLKMI7D5+cBi/D6Yim266FOOoy4R3n2WZSnhVcXQNveWnc4XPtbzoME2r/iMjwDLzdAtZBAxvaI8DP1yF/8k3uDdIq4/wkVqLRYDdXzauZuqfz0nKk2ESv6f4dk94R8AZcTVQXgtJ2l86Z7Nw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=J2z3VHlZ; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="J2z3VHlZ" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-736b350a22cso5688974b3a.1 for ; Tue, 08 Apr 2025 22:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178351; x=1744783151; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2mAQ8kl+cTK2tRaTYd6zwbiiWMnl/2y5YjUtdkyYstI=; b=J2z3VHlZvby21wVER4ex3bQy/hy52bRJ/UTilupLyeH2nX7eFnQTBH3EOpXwuoHZXN DqTIg7W/OWFQbPxTcgiCCDZR5+MOMTVbHV7dzU7qjyoAw2yUXYZh6eYrbr/Cbmv7bKAm ylZzb4TU2zFeNXDFoB1hSkNL7GKgupAm3rM8zjT1EGXljGwLsAeEsHDfyn/pIDagoDW0 wZDAT4A6CzXUP1fn0KpZLXPJNs3wluOueochhP+t0b7Z9GG2160/pHDS4gCEIpzPF49l +HWi6nyXE1xLCp+iUezcUIQgx7d0BPzDcjavwYyMk7y6lnqeyimKk+mH8WvUCfteIHM7 AI5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178351; x=1744783151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2mAQ8kl+cTK2tRaTYd6zwbiiWMnl/2y5YjUtdkyYstI=; b=TMwq5rTQa8w+TdhmVBSgzd6VRHj6RRijK3aj70ypXbD3TmqkFNsJH91QEnvbfefJYM w+wq2Ilja9EQQBdvcV1wvxxzXuhCxN+/1BOhxVb6zL8xU6uerK4O6F7kN5Q0NSNk2cgl BdkIzL1lA3Z4/nSLrztsu24zGGoQGJwXvSUHiJboJnXeWzXhADhjm+qgG725aewm1fgq b29ckKW0hWb8xSjjVc8xYUeyLBqVub3CERO7fhyORJviWH4hG/CkfMQOrJ645qI5hFx7 3WlAHUhlihlJK8mP4VBjwW5TtlDyt4FgfYrlK0w/aX9G3GMiyNm5W9PkvwET3vwsIOeK fsjA== X-Forwarded-Encrypted: i=1; AJvYcCXB6XWnzw44qL14UKyfsoNmvG8UJM7kVYJy14Acgt5k0glbeijW+GmzRcHzB+FMEk+v4DtukG7KBr6oasc=@vger.kernel.org X-Gm-Message-State: AOJu0YxgOabez23NSJBq7wp32dFR5OEx6wIlwRSrU16plF/SQN+KX1td cv+1pV1pYQHQKKHHV3TLub9Q+tbPTXoqPZKZtiD23c9TlPheHNuq96qPWhSvEQ== X-Gm-Gg: ASbGnct7isWliE4nMzAmPS50v2Sx9PNPA1fuWy2Z0pLTELSE52EKaE60r12GjfozO7x VbWvBN+ZFJkndbrxA3mf3+BQAxYpyfyD/Ia8huBNYjTlv3k9wiFSEs4YGhurKOxm3i6Cun9RFAY FJFNWH+PkNRkG0eSeBm5/D7u3n8+RuCPb0RZFDIlNMvfSgSs9Zmk8iRj1qxqRCq1QDBmcGRUE97 p3K+/l2kO+F5bzwulvd5NrDQUe06OGw7XXhisOD0DdRQoi6KOLhec011Qa1sKt+Uc0aXXt6CM6w j2tHG5FAImT0XB/Q5AnTcoSzKVA3wV1XScaeNEYeRyk5OcjgwR+w6xjujb2mAB2GTSPa0oo7zgj tsIwiSA== X-Google-Smtp-Source: AGHT+IE2RtAw3/qX0PW4HvonMFrMBAZYWdvOPoyJKwwxRUxSdjdRh3JQUX+7LZy+KpAlhCuSeBtkBw== X-Received: by 2002:a05:6a00:ace:b0:736:5725:59b9 with SMTP id d2e1a72fcca58-73bae495740mr2220686b3a.2.1744178351063; Tue, 08 Apr 2025 22:59:11 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bb1e3833asm421408b3a.85.2025.04.08.22.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:10 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 04/21] staging: gpib: Using struct gpib_close_dev_ioctl Date: Wed, 9 Apr 2025 05:58:46 +0000 Message-ID: <20250409055903.321438-5-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_close_dev_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index a0a9a07dab5d..4d105db18447 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1262,7 +1262,7 @@ static int open_dev_ioctl(struct file *filep, struct = gpib_board *board, unsigned =20 static int close_dev_ioctl(struct file *filep, struct gpib_board *board, u= nsigned long arg) { - close_dev_ioctl_t cmd; + struct gpib_close_dev_ioctl cmd; struct gpib_file_private *file_priv =3D filep->private_data; int retval; =20 diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index cfd1afb36e4f..6ea6114ae78a 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -32,9 +32,9 @@ struct gpib_open_dev_ioctl { unsigned is_board : 1; }; =20 -typedef struct { +struct gpib_close_dev_ioctl { unsigned int handle; -} close_dev_ioctl_t; +}; =20 typedef struct { unsigned int pad; @@ -125,7 +125,7 @@ enum gpib_ioctl { IBWRT =3D _IOWR(GPIB_CODE, 101, struct gpib_read_write_ioctl), IBCMD =3D _IOWR(GPIB_CODE, 102, struct gpib_read_write_ioctl), IBOPENDEV =3D _IOWR(GPIB_CODE, 3, struct gpib_open_dev_ioctl), - IBCLOSEDEV =3D _IOW(GPIB_CODE, 4, close_dev_ioctl_t), + IBCLOSEDEV =3D _IOW(GPIB_CODE, 4, struct gpib_close_dev_ioctl), IBWAIT =3D _IOWR(GPIB_CODE, 5, wait_ioctl_t), IBRPP =3D _IOWR(GPIB_CODE, 6, uint8_t), =20 --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F3501DF735 for ; Wed, 9 Apr 2025 05:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178354; cv=none; b=VR7FOpTqQeeSQZQlTv27m7CoPban8MaKjj9KXrTkyF9ISCCnn7khSxACtY0fo7vpMCE3Df7CMwfgfo9ancdWd796Jlxp8yf7Cpidbzx/yIo3FCk5xFc4YKU1/cPgNzEG8195ZdOp9eQQG6qBk6+ptVLZU2qQ7qcmQF3Jwo8A48U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178354; c=relaxed/simple; bh=6/tEDWkyWZGqddA6x5CupLdQkjAI7dTnTj5CqszFug8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ciw4emQYIbnNHzmqfv+V3S11NwbUVmO4b2BBurQzwXTFa7H5/CZxziSHyUdVgxgqE5njhgSTRfeNpYWUoQXRFaFbhg1UEutU8m1fnamZiRtBcEHBPG4tEaCBN0EHeFclB8/UW4r2BWRgHRvn5yVnMOWRJtH3fbkHf7MbSoOONlc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=I7UEFODs; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="I7UEFODs" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-72d3b48d2ffso6812600b3a.2 for ; Tue, 08 Apr 2025 22:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178352; x=1744783152; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NCoGYMLxCvRlHFRAlGxTbIygW8BXsW2zasxHkdR12QM=; b=I7UEFODsYh63E0H98CZrKBzRE/QwCY4PsOeSipn/gg7J4MwndQsOOJo5ZoOjSOfeAT 4M2r082NIUm8GKFoPx5nUFPraxAxv9T7ZF0QCkuCGOT9p4ZOpKbgckHj6MOIBQZp/XfN aOkP7jtQ9bdXiBCwJqmMNSfJkrX8RqPt6SvXV5VIc9eeRYSiAU5GhGxsCUebeSLUqQsC CCw93EGO+FY2k9aOOqtgBd7luXvwwbHWBmnDZbOp/trpApmc+7lNpBSMBdQjn/sjv6SU Jh+FQO6W3Bc67r92vC92t7Uyuww0QFClDcdJoSdqDp/lqFOF/io86GkSYAttCKymn9oQ PhOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178352; x=1744783152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NCoGYMLxCvRlHFRAlGxTbIygW8BXsW2zasxHkdR12QM=; b=QUL24xeBDQJC7or+y6hOrLHXdyeDkRR3bh7xPsL2xHnzPmV7bBpQQ+Iy0CDbvlzyzF akoDKObRk/+cPfu1ZyA7FeBK2Sik1HCFr0Au1A1fmlMJTLxIQrXhSdBA7t6gDYHx+wiR eeizS9RdOgvCHuvjHyPCbVWUsdJ9wFrrL6Pf4YBeBosZB/5sgLlqDUUhVE4YIgUz8pKk +4/url/neSpuMMumkwEuiFeeyg6G0/tHNUzkyozmPvxHgo9RRbyhhW7c4QrDcOFTfVPZ XFScsRSagi5sLSHwWVHYStw3wRsdBuKPK/yi0x8K3vkRobKTs4UeAOzUvBGWKL7QeGVC NGEA== X-Forwarded-Encrypted: i=1; AJvYcCVbpRzFNXDTD2O7HzcqcW8Lauqv5GMnwk6I0EBpKYQLA9ngK17Spr6V3hvNAvaSGIOrStyCNOhOK4gPInU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxv7A6hDyU8gB35Me07Fu/pxdEdl5PYFrqLG0E+08LxjX7KcVWG NxazIkieMQ8/palpcbzm6N2JEa5BjLlYPKi7Q2PHKOO2GwLjdxdySnw6ns3yFNX2tNc9TwADWs4 = X-Gm-Gg: ASbGncv2rOhy4auOWsn6wg2yq9nZpuJgrNXX28gUAeCor5m4NaSEApK4ZO0EXRCmX0F 8wyIKSa+QFCZvyuQKhLERnKlyo9RrGrGNrXz1cg6jN+Nc5FLAjWw+O4qMqUGNJweCMtfpCRs0ip QGqROS9dSxxVWuES05UhrrkbAlpdz876uCOHtes1z98b1ZK3LhvDafF7CFMuehfyHpZiIUB57jZ hMXr7AVeXpnmylam+YO5gUKezi1R7E6NkRHR/R0ZDcf18VQ8cQVDESbazcD72s5bE8pVerUgGL4 u4vM/HA2BCzb1TVxF2lOU24JCyfJM/P2rwyx7oyh3BKngdSZueUF+XYq0kJd439T7q3m7n5ndt+ OwJkKlw== X-Google-Smtp-Source: AGHT+IEnYb8oUAhH5Iqij3FjwEcu3Mi3oVa9qSFtB0jvgdjmC/mi3UyvnvAsRRmXp6OoQ75awHMGDQ== X-Received: by 2002:a05:6a00:ad6:b0:736:7a00:e522 with SMTP id d2e1a72fcca58-73bafbc6364mr1740723b3a.2.1744178352232; Tue, 08 Apr 2025 22:59:12 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bb1d4945asm441176b3a.68.2025.04.08.22.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:12 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 05/21] staging: gpib: Using struct gpib_serial_poll_ioctl Date: Wed, 9 Apr 2025 05:58:47 +0000 Message-ID: <20250409055903.321438-6-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_serial_poll_ioctl' to remove typede= f. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 4d105db18447..9f7becb09e60 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1289,7 +1289,7 @@ static int close_dev_ioctl(struct file *filep, struct= gpib_board *board, unsigne =20 static int serial_poll_ioctl(struct gpib_board *board, unsigned long arg) { - serial_poll_ioctl_t serial_cmd; + struct gpib_serial_poll_ioctl serial_cmd; int retval; =20 retval =3D copy_from_user(&serial_cmd, (void __user *)arg, sizeof(serial_= cmd)); diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 6ea6114ae78a..9be3262271c5 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -36,11 +36,11 @@ struct gpib_close_dev_ioctl { unsigned int handle; }; =20 -typedef struct { +struct gpib_serial_poll_ioctl { unsigned int pad; int sad; uint8_t status_byte; -} serial_poll_ioctl_t; +}; =20 typedef struct { int eos; @@ -137,7 +137,7 @@ enum gpib_ioctl { IBPAD =3D _IOW(GPIB_CODE, 15, pad_ioctl_t), IBSAD =3D _IOW(GPIB_CODE, 16, sad_ioctl_t), IBTMO =3D _IOW(GPIB_CODE, 17, unsigned int), - IBRSP =3D _IOWR(GPIB_CODE, 18, serial_poll_ioctl_t), + IBRSP =3D _IOWR(GPIB_CODE, 18, struct gpib_serial_poll_ioctl), IBEOS =3D _IOW(GPIB_CODE, 19, eos_ioctl_t), IBRSV =3D _IOW(GPIB_CODE, 20, uint8_t), CFCBASE =3D _IOW(GPIB_CODE, 21, uint64_t), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 379271DF98B for ; Wed, 9 Apr 2025 05:59:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178355; cv=none; b=ozldFfVQtYeg2mDJcrPd5dDWDtqtn6JCYnc27m/ajOMmkq7mohFM5t5JJLhOcrfc+uVqG9qYXjpZPy4KnzwDydbmoLBCik2AF0wIc5Ahjuldd4YaT0COHr/b1Qn0CZTzJPBqObPXmh8vmEzCJ9B78KDIwTDtfqHpymZBCYgSwmU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178355; c=relaxed/simple; bh=GCAMB7IyTb297JpowGEBrQLbjSUPow2wpDfCSxuGjf0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VAAOvEqJcXLMKxbw/UWebziCki2ndIQaaNvToggZNcz+DgbIzLltqPY34bMLZUqFDDtmaeUb5/VVxKQbmlBA9J3mL/8Q6Y3GTcD1W5ltG7xEmUIL8aTSRaA8bXcBPUUWt9/HzOGfJV/DkHWzpqg9Mlh/6K5Ahi4udD/o/knZklg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=D/7tAaUS; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="D/7tAaUS" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2241053582dso81683625ad.1 for ; Tue, 08 Apr 2025 22:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178353; x=1744783153; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2v/NOtquRdRwOPT8OcPE89pweXS9CADmxhep3BQdI6I=; b=D/7tAaUSjNAqp8QxAosHGe1BzYpSucNQjkmXw1Om1b6HYy/luad0MEeMSn0ZkwfC8Z NuqVcpPXzSqGrrtoMh9deRhtOTCCZUzadPyS1ttmKls1T5wLbDC5DCRQDzYFGnarjS9B LmB0Q0Jb902NL6GxxTM9okJe3Im0HvCZwq6FPski9/8EWGACc7cPlzbFuc9j8Lw2L6ot NXOkTRRyUeeHpdreFadEPwLfl/tYip3a+P0x/Xo/NnFuECGhyllSIsLOnMr4zJWVpQrg OmmVjlCi6Im8/iFEc9dyOr+53vvQmwrqN84S5mDgW3Hekyuy2yhA2XqWEbYacJxJXdKY Vz9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178353; x=1744783153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2v/NOtquRdRwOPT8OcPE89pweXS9CADmxhep3BQdI6I=; b=XZp6SbgDKqOVjg1Z7Sr4I5tfdfJYfaqgaLmHYm0LQZwM6VE8zlezAF7333VzgrBas1 zZgG3UoIYaWOUfYaCx0Zs8+3jMKrpoMRPuarNyfCkCUznVKRD2dp/79aKu5pPIppAdpD m0RPxR2Wj9O3Aa+XWdutJOZ3jBvuQUBsY/K006EdhJhQw5EE0tGhj4qYxQDORUI1xDJV zL+fLvmT+UG4OfREy9Vuy8+AU2RNzCFVuQgDgiok1+B+DWkoPjyNciHJ0CzuG78V/OlK huTe/O8eT4O42g/VT6AvveokElWZs5ATJFvLIjfdvQwe0Ie6mwzkRFOl6vl9SBINcvjH Tp0Q== X-Forwarded-Encrypted: i=1; AJvYcCXT5imDza3GeA59xAPRTlfdCgfRStg6wzEGR2WLjakx1PZrMrEFM2qG7fu6CkQPyKL9vXhpZvvnSBmHqLw=@vger.kernel.org X-Gm-Message-State: AOJu0YxmQtZDZzQfePtnD0hZkpDFUZi1KXdQk0Yy9/g7BnqXH9yHUbM0 7ziz5CBFOU2zbhGz1QMUWvbSTJOk9XJ7EzJ49uROisP4SwauYoilNer9SPtKLg== X-Gm-Gg: ASbGncubEuinHo1G8CUYAn+I9Y96VWNd7hv8XxVEH3GaNXGa6MEveiNDOKuVbSnhuJH P11/AH8Ga7E5lz2L15ZiokyTpkWo293xbcX9oeDbG7iDv88eIIE8VtAWr097aRFiwMZlMDcaFc/ rfd6WvAX1GObYMydwK9//C6pcORvh6YDUTWxqKEmnd71z8ddxK798K8tzwzkQoRY/AWuoQCoA0n fqHYBp3WR2e5iQVkjGW7Qn/JRJbQQg2VEdAS6gaJAvpWvTDknXD4F2doKclDqejl0tK68nkHZVG Q7wKIC/9gKcJXY/3Vz1rcqIJhkCRo7SeVstXHYUOyHTjfK99H0s5d602DgGtM8iP9Ybz2urBWUN mlY93wA== X-Google-Smtp-Source: AGHT+IGyQSwzezThuhQv4lKEAvpv0AlE+n8nH1TjmcTKbI2mn0DR+loA/oAzlkmtKflBXNhFmW9+Fw== X-Received: by 2002:a17:903:2292:b0:215:7421:262 with SMTP id d9443c01a7336-22ac3f6e7e9mr18111295ad.12.1744178353406; Tue, 08 Apr 2025 22:59:13 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7b8af2dsm3477515ad.69.2025.04.08.22.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:13 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 06/21] staging: gpib: Using struct gpib_eos_ioctl Date: Wed, 9 Apr 2025 05:58:48 +0000 Message-ID: <20250409055903.321438-7-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_eos_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 9f7becb09e60..bbf8a60978d1 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1508,7 +1508,7 @@ static int sad_ioctl(struct gpib_board *board, struct= gpib_file_private *file_pr =20 static int eos_ioctl(struct gpib_board *board, unsigned long arg) { - eos_ioctl_t eos_cmd; + struct gpib_eos_ioctl eos_cmd; int retval; =20 retval =3D copy_from_user(&eos_cmd, (void __user *)arg, sizeof(eos_cmd)); diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 9be3262271c5..3f32eceaca93 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -42,10 +42,10 @@ struct gpib_serial_poll_ioctl { uint8_t status_byte; }; =20 -typedef struct { +struct gpib_eos_ioctl { int eos; int eos_flags; -} eos_ioctl_t; +}; =20 typedef struct { int handle; @@ -138,7 +138,7 @@ enum gpib_ioctl { IBSAD =3D _IOW(GPIB_CODE, 16, sad_ioctl_t), IBTMO =3D _IOW(GPIB_CODE, 17, unsigned int), IBRSP =3D _IOWR(GPIB_CODE, 18, struct gpib_serial_poll_ioctl), - IBEOS =3D _IOW(GPIB_CODE, 19, eos_ioctl_t), + IBEOS =3D _IOW(GPIB_CODE, 19, struct gpib_eos_ioctl), IBRSV =3D _IOW(GPIB_CODE, 20, uint8_t), CFCBASE =3D _IOW(GPIB_CODE, 21, uint64_t), CFCIRQ =3D _IOW(GPIB_CODE, 22, unsigned int), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AE8E1E0E00 for ; Wed, 9 Apr 2025 05:59:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178356; cv=none; b=P5QtfnL6L6l8IhEfeaWBgERxvc4d7J3QUINIPWCrXdwLk95aoXWTuluDYOF7rC5cdlEtzDd4e57eYhJPZyPS8eLcJrLkJpqARSATCu6rGZOpXW5qD//h9ab52l+539InDa/HirDgcitCH48Ao62PduVLPmR/VvobCRuF3MFiCzw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178356; c=relaxed/simple; bh=lTlngZeohT9fdDdZ+I8MYc+JvGejyLtyZin/uCn499c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YguxmAKMTfiHmRAxqcazScbA1SsLCshcnT63ertyj373zs7MOAV24umxW+0Gy5n3Y8JnGYHzYj318/N4/ShwRqSrsbAk1Ow7w6xHVEmTZ6m+ucaIEy6miLpCeu/I2UGFh2/5LdAWrGFua4dXiOynJfyLaI5LOXz38gy2FHUy7g8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=RYmMrv6A; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="RYmMrv6A" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-af5cdf4a2f8so4692491a12.3 for ; Tue, 08 Apr 2025 22:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178354; x=1744783154; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CgVArUjmqQF/mOeS/jCzJyhUSciVAhmS6WARTC27SMs=; b=RYmMrv6Ajxs9CNVWJaW3/qPPnNU7d2b9HP3QBQqpSqSWJrW+7q7eOVV5Ou5TihV9/N MlpsdDvO4PKsLSccSNR8tbYM5Wu/NDiUaPlHfDNIHstREnc1NmK7pYduoBLUdACEe371 rAlDaJxqLjiGKC1TeGsVmD55IAOVMOUUZXmE2TD+krLDpwkUd/vardzte4B0BTfuVAwo M/JWkUInWP5Q6FiNQJX3T9VWtWySzOHGZ+6UULLppdKBGukeAt+lTfbHpeidaa2/xY7d TxiNw5ZnZeQCxEaJuwGBKZibeVIhiqjbrs5MdAAixw0lZqEKsTMRIeLzGAijCc+zsPo3 oxMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178354; x=1744783154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CgVArUjmqQF/mOeS/jCzJyhUSciVAhmS6WARTC27SMs=; b=XcnUUSVFulMc+x9Av8bL6wICVCRt9/3zGdlpTfRHPL7bDYfE2/45qmMbKUrjPjYeIP OHBcP9u2TI3i/XU0iqklX9dOiNvai0fsUOmf/+b3C1rC1HTrfsBnn54Mv4ilYK8IstpD /t5pJ2nlzRCEOusHHBHIZiQQ5tJVNcvVB0AA8Lz4jpumQ8Vt1wShhSA0tmQ6U3odGp90 +N5M1HEaskEg7ISYvbupL1/j++GZOmYiEhP1VJpw2puYbp0Ien+nWEpArV39US1FZB+F ziYbUQmzt5bPsorzBeGFow53VeNO6hDXW4d7my8IJq13wM+7eLJ6GhmnNltMEi9SFbYI P3Ig== X-Forwarded-Encrypted: i=1; AJvYcCV7C4HrXCBCWIlq7mYGy1SNAH70PgIrspQjhCK17N+wr8OoSC4c6HWbY5k7LTeY85gONLu511H1wQdggOo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2jgEWpKK4RHacOSotQBjSb7BAVD0rVLI2H7Llm59yPDOPoRRR OQ6KQ4lMQUr8M6N7ORFzvUzDh/LaT/ULtKCSQKjMxXSzxnhVAzs4sQC+XuEq3g== X-Gm-Gg: ASbGnctSxx3gU5L/GzZIJ1dfHdd7fX/Q0T7fNQb3rFYEAtmUllyufUjEZwPeFofWNgI taodDItSFvL0HFrGKN0jaTKLFoLEo17UZMh1od7GbBAaFwlxkAr+LQPgri6uZYJ9xe6q1NLatMA BWfik9MYFvsy3EA+Chm17hzthFveOdeNEJ0fXjrjE96p+yO4R9/4fy3E4lyX/Hep1vbVeUHQQJ/ TprlPZolRNnORFgO4mRXU1fh7MczP2lJmFBYztzFr6QRh/9am0yAnn0/6C9jgEeQdemFHmTwDHD JcSPQISeJvJmpJuJL6Fx/UDb9bdzjRZHt3dggYa7P/v15/qbS47B8b8sXWYddDHf4TIG1mZ1zRz bcMyrHg== X-Google-Smtp-Source: AGHT+IHd+pzcdkjTbsAfnivLAC2JMI7PBA0a2cy6NXjGw1Py+x15ZQXxHq3GPkADOewRWkCU3EGd8w== X-Received: by 2002:a05:6a21:2d05:b0:1ee:b8bc:3d2e with SMTP id adf61e73a8af0-2015915587emr2657905637.8.1744178354603; Tue, 08 Apr 2025 22:59:14 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bb1e68059sm419768b3a.161.2025.04.08.22.59.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:14 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 07/21] staging: gpib: Using struct gpib_wait_ioctl Date: Wed, 9 Apr 2025 05:58:49 +0000 Message-ID: <20250409055903.321438-8-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_wait_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index bbf8a60978d1..6d0191c9f730 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1311,7 +1311,7 @@ static int serial_poll_ioctl(struct gpib_board *board= , unsigned long arg) static int wait_ioctl(struct gpib_file_private *file_priv, struct gpib_boa= rd *board, unsigned long arg) { - wait_ioctl_t wait_cmd; + struct gpib_wait_ioctl wait_cmd; int retval; struct gpib_descriptor *desc; =20 diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 3f32eceaca93..71c5e3d020bb 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -47,7 +47,7 @@ struct gpib_eos_ioctl { int eos_flags; }; =20 -typedef struct { +struct gpib_wait_ioctl { int handle; int wait_mask; int clear_mask; @@ -56,7 +56,7 @@ typedef struct { int pad; int sad; unsigned int usec_timeout; -} wait_ioctl_t; +}; =20 typedef struct { uint64_t init_data_ptr; @@ -126,7 +126,7 @@ enum gpib_ioctl { IBCMD =3D _IOWR(GPIB_CODE, 102, struct gpib_read_write_ioctl), IBOPENDEV =3D _IOWR(GPIB_CODE, 3, struct gpib_open_dev_ioctl), IBCLOSEDEV =3D _IOW(GPIB_CODE, 4, struct gpib_close_dev_ioctl), - IBWAIT =3D _IOWR(GPIB_CODE, 5, wait_ioctl_t), + IBWAIT =3D _IOWR(GPIB_CODE, 5, struct gpib_wait_ioctl), IBRPP =3D _IOWR(GPIB_CODE, 6, uint8_t), =20 IBSIC =3D _IOW(GPIB_CODE, 9, unsigned int), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610E71E1E0C for ; Wed, 9 Apr 2025 05:59:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178357; cv=none; b=Xd5mBUw4s/6VFtYJK+2NmsXa4rEdKn5g5lBED6t+azKbVKCMOgm3FhEv+MFk8Cl1QQR/R9spNSGsLBJoC2jy7On3t5XS5GgWTPNup/0++ZdSDtdOkG5kUOpdHLLl1n3APIgLcs1o6UEouOc+QSTMFm+ERZxmvX4my2pVNnCh1dg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178357; c=relaxed/simple; bh=/bZHTaMP6qZNG+6B+h6xZLBEPyyqDzKN3WknItrbwz4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iv1BhTcc31Fps6rcj0finjyfNYq5uxdYZka8c3fJ8dV0qjn8vTNce4FLhUvAe1wzccqL3Ptos3vnDq63+6FG9szbbzvjXhvF7H0DwoL+UysrL8d8MwozuB4x/oxw81myq/Cn155xx/kV2kJYWwIz+gcr2/EpldsSPUMSLrLmR0s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=ftQFsny0; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="ftQFsny0" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7370a2d1981so5444316b3a.2 for ; Tue, 08 Apr 2025 22:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178356; x=1744783156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SgSCc/CZI/7pOuwGbarGcJIHW5TIhb+Lwu6y3er4SkQ=; b=ftQFsny0UfwiNDRbSj6VYATJ28tLn2gwSQyWNHsVjvHWmH5nxzbAoCZ39LRAzK1qT9 oDzkhG6AQPadmYBn5W6UR/6mxs+ZJ/Yt89K+kh4hU+nP6lin8ariatpNqxliqKBwDa0m 2tV7TXlyxlFeBy7ZZ3aNZdliBuZgCR+ALvvguSSwl54xAET71tORPxaNr+BjD5o0LWhk yStezAuOy6wUAJj7BLmO9eaQ0ZbSGgITT7o5iLoJ+B92zVAkdok5dDAOPJ3FayTR4ULW XbI0zuuk5LZCwsmezbj0Ao9W8pb6FlnK/dLIOu9mr0P7jVmFrnPpzIsN5gDg5DPIjLOl ipwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178356; x=1744783156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SgSCc/CZI/7pOuwGbarGcJIHW5TIhb+Lwu6y3er4SkQ=; b=FVBoDLwRdBdInXyUJ9vUl1P1p7r3/vy2Hj8ndpOrmvKksgP+Js8CmfwI2rGdZRIS3D brgM2fkkVo5HkMbiYfhthdBoAnfl0Y1zoc3GrST/lmL/cnRUrK8GdEAM29rUllASaB/v txcqJbhOIWnePRH2Cr8og4/X0vXRIiDlbAqGfdE6i2OV7CfX3LFgnjDMp3PCAof0UF+B 8z4LWolUq5OT4SzpSVnRDmxyKXfv3lNkmYI3y/v7NdSSEYrqUtC5AWYuOV1VVde24wZT KJq9NcIEwq1AVhv6pPNfwAXo8wUQvO0KEf6j9839WSbQW6XJaluINa99gifC2flhrgSJ fV/A== X-Forwarded-Encrypted: i=1; AJvYcCVTPHlneMu2pqUhmt5FnnJTkfDf1h8EniyhOt3LMGr2q8V5BkUWfbvzGy2ghxpRDLdumsZho/jw/RhkjFQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxCk0txrF/jDdkIZ0UI4Oln2kUdDroKcw3gQArxUk65Wps2nCfS 2q9M0zyozYolWTfhcC+H3PfZPNypXZNPgxJcvhcQu59fKFogxzyegUS7PSZvmg== X-Gm-Gg: ASbGncstAJl11ZQKtphfuLUcfe4oQ/IfK6EPlQWF3OAKEJamlCOTPj5Uz2HGu/Dp4KD +Yg8RuzC6p/HheumKoNSxjxMDnE7VFe91jCW9efvnrukVkavXD+ZnHDwKfzjlBGE+eDA8jrpP+r lpkkTqtUXk3Hx6goP9tXGjlAcNX5VOSC6pl6pVl93vJ7QvhHZCNIwUU1BMXoNpskEF91E6JnKGt kldCjVZHia8JC93XzUHTl/kqfKOOrSY7VsWXkKbsKgZHTiYeJ4qbqYnSI+0YTgF6t2zeIF58w4K 8Fas2dxGK7PcZA0Z0kYD+BURGvSyPQ+KE9bNiyShIHeKxQU2S1nwjBr4FenH8AR1PR1VBxOaAtZ oOVJovw== X-Google-Smtp-Source: AGHT+IHDsKQzq+kRdRhtw0xx+ABY5gFAKYBsxmbvMxvH7JNhzPz2aoKQbOSByQbidAktAYZGHjSkpQ== X-Received: by 2002:a05:6a21:3943:b0:1f5:55b7:1bb2 with SMTP id adf61e73a8af0-2015ae8f9c7mr1881092637.6.1744178355797; Tue, 08 Apr 2025 22:59:15 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bb1e5171dsm419092b3a.153.2025.04.08.22.59.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:15 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 08/21] staging: gpib: Using struct gpib_online_ioctl Date: Wed, 9 Apr 2025 05:58:50 +0000 Message-ID: <20250409055903.321438-9-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_online_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 6d0191c9f730..b215521d0ee5 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1353,7 +1353,7 @@ static int parallel_poll_ioctl(struct gpib_board *boa= rd, unsigned long arg) =20 static int online_ioctl(struct gpib_board *board, unsigned long arg) { - online_ioctl_t online_cmd; + struct gpib_online_ioctl online_cmd; int retval; void __user *init_data =3D NULL; =20 diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 71c5e3d020bb..dab170b09764 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -58,11 +58,11 @@ struct gpib_wait_ioctl { unsigned int usec_timeout; }; =20 -typedef struct { +struct gpib_online_ioctl { uint64_t init_data_ptr; int init_data_length; int online; -} online_ioctl_t; +}; =20 typedef struct { unsigned int num_bytes; @@ -158,7 +158,7 @@ enum gpib_ioctl { IBLOC =3D _IO(GPIB_CODE, 36), =20 IBAUTOSPOLL =3D _IOW(GPIB_CODE, 38, autospoll_ioctl_t), - IBONL =3D _IOW(GPIB_CODE, 39, online_ioctl_t), + IBONL =3D _IOW(GPIB_CODE, 39, struct gpib_online_ioctl), IBPP2_SET =3D _IOW(GPIB_CODE, 40, local_ppoll_mode_ioctl_t), IBPP2_GET =3D _IOR(GPIB_CODE, 41, local_ppoll_mode_ioctl_t), IBSELECT_DEVICE_PATH =3D _IOW(GPIB_CODE, 43, select_device_path_ioctl_t), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1E121E32C3 for ; Wed, 9 Apr 2025 05:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178359; cv=none; b=J6iAchOeaZjkOezdHpL5x5HOoH4z90HLB9pWhdnJx+/my6/rshuLEieZ+zV2/L5eJIyrj20fWYgmDYEShdONtRKIvnUYTc9ajwcNRPehwcbXuVNTA8S0P29LfNia5z1ybDjSTbE5tSJ5rbvoOk+bz+/UFT3SP8VTx2sedk25bqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178359; c=relaxed/simple; bh=G//LPV9b621xoonNk0r3Ck2b0Kc5aACTPzI1fI5q8So=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=atClGnTBI0zXUPuLKFlPwt0MPFZ50SxXloUHgt1qK6Y7NqI2dvuNip/Tc+KzyIlfIVmE9K0uMbDVE1lbyCkAK3jJo2ZgquszIR9Igxg86wbQMTw4n4Jj3jyD3IGOt95dGsm6PV6aBNJnwZxfYbYBtVNNrQws7OQe4yoDYKC4op8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=hNUEpXE2; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="hNUEpXE2" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2264aefc45dso81542305ad.0 for ; Tue, 08 Apr 2025 22:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178357; x=1744783157; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P60THtcSeaGNumoR/WgRt7uMK8QmiNv+dXppLkYeWAw=; b=hNUEpXE2orXiuRzx5pbXxSmFcrUJHTLc2cK9E+3kYee2z41lw18V8NZDACl9Z13K0U RmX87dgb8UfHKBqzi3N2vOmx/Jp1UAdJ7yBsMR/XioTxwli+x177ppOt7iLtOYehCPbh v7mgGZjYHcOLHWVMNZGtjzIgnuq9+6rPQudemJmjds7uIP64jiRshOqC7jb83I6AiNid l1zmCJiNL9gaBbrMAFCV+ldjLSqal8QvAviD4XfCWQ8PTi7qOBpFnulbxIw19SHOZaF2 ouZBl9EnM2YpCcSthkhfty3IVT0DgJMMCilKhP3iZP7nB8Ze6Zy1B1YFelbNdceDAaD/ 9sXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178357; x=1744783157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P60THtcSeaGNumoR/WgRt7uMK8QmiNv+dXppLkYeWAw=; b=lUflRhTL1z3PU/qY/kgkOKb7qwjYQycPpJJj++hg1NH9ZO1YLEGaJyB/qQUuSmlXDi yiyzZ1z1Ne+17YMPT6Lj2HFE8rAJAi1aH+k5TozkVSmz3JS25ZR+J368L+YaALRV4jzz aKr/S85zVHG2ernXt5QGxLmc2QPnalAE81MuRVKqKVUP6xUecW5W6Z8ZjZzxq0R2OA+H bpa9tun5nMZM6+UD96aHongBH/XVCYcVjbTCUGgt6n0aYQQoDGRldHoVYZcV2BwyTI4p 9Z11HSmox//nMKRIEBFptM2gOj4YI/ee4XOwHO5D7mYZc8C6Za86yiE7QTfQaG2x/2o9 FjcA== X-Forwarded-Encrypted: i=1; AJvYcCW5PoFHmuMtBVpr4+ChbqiIERGHT5Iqw2lL8Ws4yX2nMSwtzDwif1MYdDHu9SkdQqIK0EByw13rI+mPOgw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywx9YqHfVk7JEIyTUOgyE+XzSP6X9eBys1Gc+1m/kC+BuAkIXlH lmvlyJPXp25birghWJ0rf+yApcJVzQcLWzHyzw/D0OgPlFXIlmzG81hnCXdvqw== X-Gm-Gg: ASbGncvt2+C+po7auIbEOHf4T3yZNzCLTj/+A5yc7qfoQTCxnXbgxIsyyQx0FOn9jFq TA4kincxb/1hrmhfZW+vyy1HTA1/ax8Deyiwktu+0qAavampO6pmD9vcly3VUdx1WNxufezwly7 zgzHLmqiWZ4LLvjIvVCyk0cLKf14NcuKcTIGQKMIFaH4ZDJb4gHcII7GSznydeIxjeGexuLnF9J H4TiSUVqb0Jbdjv0/VPKd7qjJs0G4yO4GXQM/K46YsSN1AS4igCwytY9Rs3MEXgAIZImZgvbCLK C0Q9ZVXePs9sb6TR13DsofxixP8OunZ0vlJHDzserTZ4sOno0v0GoF6g+XPhSYcrVKjZj+jhxiP nnT2MZA== X-Google-Smtp-Source: AGHT+IEF/2kPq1wv9EJxYW7WVhtKcroqWFkghJEsnel/AwtMyAxBLF4pJtI9onzFXLY+6m8dyuZG2w== X-Received: by 2002:a17:903:2310:b0:227:e709:f71 with SMTP id d9443c01a7336-22ac29b41d7mr30253455ad.29.1744178357023; Tue, 08 Apr 2025 22:59:17 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bb1d2b951sm431735b3a.33.2025.04.08.22.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:16 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 09/21] staging: gpib: Using struct gpib_spoll_bytes_ioctl Date: Wed, 9 Apr 2025 05:58:51 +0000 Message-ID: <20250409055903.321438-10-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_spoll_bytes_ioctl' to remove typede= f. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index b215521d0ee5..79806cc51749 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1095,7 +1095,7 @@ static int write_ioctl(struct gpib_file_private *file= _priv, struct gpib_board *b static int status_bytes_ioctl(struct gpib_board *board, unsigned long arg) { struct gpib_status_queue *device; - spoll_bytes_ioctl_t cmd; + struct gpib_spoll_bytes_ioctl cmd; int retval; =20 retval =3D copy_from_user(&cmd, (void __user *)arg, sizeof(cmd)); diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index dab170b09764..e3d167edfd69 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -64,11 +64,11 @@ struct gpib_online_ioctl { int online; }; =20 -typedef struct { +struct gpib_spoll_bytes_ioctl { unsigned int num_bytes; unsigned int pad; int sad; -} spoll_bytes_ioctl_t; +}; =20 typedef struct { unsigned int pad; @@ -146,7 +146,7 @@ enum gpib_ioctl { CFCBOARDTYPE =3D _IOW(GPIB_CODE, 24, struct gpib_board_type_ioctl), =20 IBMUTEX =3D _IOW(GPIB_CODE, 26, int), - IBSPOLL_BYTES =3D _IOWR(GPIB_CODE, 27, spoll_bytes_ioctl_t), + IBSPOLL_BYTES =3D _IOWR(GPIB_CODE, 27, struct gpib_spoll_bytes_ioctl), IBPPC =3D _IOW(GPIB_CODE, 28, ppoll_config_ioctl_t), IBBOARD_INFO =3D _IOR(GPIB_CODE, 29, board_info_ioctl_t), =20 --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07F471E3DFC for ; Wed, 9 Apr 2025 05:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178360; cv=none; b=Cz6juMV1hqmpLgPmw/LrT3Ky6agk3Z/pUptUUxIsdLzXH7Rto9O1D2nmtGwpNvQ+bamS5wEPDT9kUnA53fyHN/yErxEK2RIFxzD1EXoMiQ5gCbmt61TkKc3lCnjBDJKXLa4m7ciqv19az15cCUfw0iGMaSom3GqezLYngpaCOVY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178360; c=relaxed/simple; bh=7aUo0KhKx/lj9hQdUFehzcFFLyGs18webMfQ6kgeJlI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JKxrekeqgLo6pa2xBVKPBrMY38WlCUDmfCmRtc5vm5nCUoojjMSa98oACwaNqovmiS2FGCf/kMJQsO1yVktEmSjmdbp/OMUSatozzQPk5+sIaCvxP7o09EKplpkDDQE3sRiEJcOmRD3wZQ/dWr1jm5ieyja5zJZPQJJcE127FCw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=Jucs/wLX; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="Jucs/wLX" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-225df540edcso3663275ad.0 for ; Tue, 08 Apr 2025 22:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178358; x=1744783158; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RareA3N57SvH7MDKApFVFMHTInpOTvcT8TY3C4zHwbU=; b=Jucs/wLXjlA68voqN+wXJerngG9iymEzPBp/4CnXzEhA3QDm988/RKpJstd5YmnzL9 vQcHXXgaDBWuNuQJRL97Wtv6MH5/KPEniCiuJrOW0OijQvdPV4sWslsmMWptl3HLLW7s zfsOzLSqe9rQXgDjbG9ECaK/S1JuD9pkLa2PHx26TD+yeHRlNG6kUP8k00YxwNGgYBRN Af7KqEaZ0Da85Qce13Rq8QZydb9QpRhVncJrEU6NNNEREz17O4/mDSJxGoRio1TdPQ0q 7z9BfxbcXxc55QQX+qvzdQOIh6+tY0kO754kMFeDOBla4lCD6PArKkiJxxs9JCHlkcDf e3zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178358; x=1744783158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RareA3N57SvH7MDKApFVFMHTInpOTvcT8TY3C4zHwbU=; b=BB06mY6kNx4qJUzLo6DkzFndg+Ewm20DKzRqPhDpFUga6raUaaD+lgoXMZVuWMUfSV OdbDyfbG1SCEc87uKNYc7+Z4aNghaigy/nU/rbwqZ1U9y2ncqGnwevwuPUDIJ3+obAEu m55rqhqh9klfO7PcoWX7xd8ooNl+JOuufZeP5AOzqAjHMEQGNY/IonMIp5rz5J7ElUhI fiCE3ybsJgHELpCaQ6/Kbto3P3GdyCFjT+RcT6Otp47Gjsm/gDLoUHbXyW9ankOlYqV1 0G1HNc1am2ll3tp6C/rWQtQUr0wZ6yH+W4Jxi1HKyerkuA0PdZ2yUuV7o6ifBQpRBjXn rzMQ== X-Forwarded-Encrypted: i=1; AJvYcCUWkyuGNqdJOzrxpl6dvp2NFnixjR5Q4JmHXKBpn8qboiDPkNaK3cV3OfVFCnWTOGKyaHwcuVluiU7VMxk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8R1wTmipN/YTmT340Yg1wVsIbDmbBa0sEhVrWUQrFdjZfdzqL oqwCW76nGqura4WcDEMSktKk2R2R9lSMU9s3eJGGAOgx5fRpWnQ4vcg96LPhBwtYLmuqyS4DhV0 = X-Gm-Gg: ASbGncuYYQmrubWNurOYdp3/3l4tvaujzP6iwzmm72fNqW9webskusMNwo/k85hj4Y2 9ApjiLUC/ZOd1k4rdE9fEhkNq7XpF39w8AePBamotZ7xogu8IGF0YG7Txli3p7NbykI9WWtsWtj 7UgNhlIP3bov/ogYO6V+k5O4RkgpcEjCNXL1xTL0peyJJupAVVRvjxPl2vcFQH4qLB3HtvIOnx4 ztvnRkr4FOdEGbWdlgRZv64+Ipfr0x3bX08HjR3hz+kxyXLd28XFiT54SWRqVsR5mlsy6Hd6caV qRPqidntS+DvByk9HXHjP9sfN2vm6jIH/giwKNGqGuJL7SkJOCnSUjn9w0MgOoA+q+29eVZyCX1 SYwLmVw== X-Google-Smtp-Source: AGHT+IEdhTpQH/+n1RLDXKwfyEPqdPj9JmJb0P3ZdJfY61MukXtzqaTMbOo+jvqDBDEbouUoZPu3Tw== X-Received: by 2002:a17:903:3c6b:b0:215:44fe:163d with SMTP id d9443c01a7336-22ac32b61c6mr27344485ad.17.1744178358276; Tue, 08 Apr 2025 22:59:18 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7c93addsm3361865ad.152.2025.04.08.22.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:18 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 10/21] staging: gpib: Using struct gpib_board_info_ioctl Date: Wed, 9 Apr 2025 05:58:52 +0000 Message-ID: <20250409055903.321438-11-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_board_info_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 79806cc51749..ce2184c5de03 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1762,7 +1762,7 @@ static int query_board_rsv_ioctl(struct gpib_board *b= oard, unsigned long arg) =20 static int board_info_ioctl(const struct gpib_board *board, unsigned long = arg) { - board_info_ioctl_t info; + struct gpib_board_info_ioctl info; int retval; =20 info.pad =3D board->pad; diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index e3d167edfd69..041b0a1593e9 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -70,7 +70,7 @@ struct gpib_spoll_bytes_ioctl { int sad; }; =20 -typedef struct { +struct gpib_board_info_ioctl { unsigned int pad; int sad; int parallel_poll_configuration; @@ -79,7 +79,7 @@ typedef struct { unsigned int t1_delay; unsigned ist : 1; unsigned no_7_bit_eos : 1; -} board_info_ioctl_t; +}; =20 typedef struct { int pci_bus; @@ -148,7 +148,7 @@ enum gpib_ioctl { IBMUTEX =3D _IOW(GPIB_CODE, 26, int), IBSPOLL_BYTES =3D _IOWR(GPIB_CODE, 27, struct gpib_spoll_bytes_ioctl), IBPPC =3D _IOW(GPIB_CODE, 28, ppoll_config_ioctl_t), - IBBOARD_INFO =3D _IOR(GPIB_CODE, 29, board_info_ioctl_t), + IBBOARD_INFO =3D _IOR(GPIB_CODE, 29, struct gpib_board_info_ioctl), =20 IBQUERY_BOARD_RSV =3D _IOR(GPIB_CODE, 31, int), IBSELECT_PCI =3D _IOWR(GPIB_CODE, 32, select_pci_ioctl_t), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3715D1E51FF for ; Wed, 9 Apr 2025 05:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178361; cv=none; b=ClJbU4WpXQw8CeeX3KFnd82n74ggW1BWSVVkTOZH+pkLo4lQ54e21BsoI0gZbv27KpAuNDP2WslZo12SAt7wh46iGTjTdx/uxjWWleWqKi7IIiqqlE4mftnMiMtJQFzO9VaPQ9ipTY79kM8tbwq2nronQrjdFE47SJOmRfxkFyw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178361; c=relaxed/simple; bh=ZYocG4WpW2v0G18PypaL/RWNtd0f+kY6Gh7yo5tCZXc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VXGGfGKc8TgLEgY9CH8x8tTf6S5TdTBwgmFu8BCGER4Ub4YMW/baBkCuMPpFNuGJ73wNLHTyq/0GhJffmlLIoYfIC/Typd/Ij0VhwrTxbr8QexYQEZKVvQ8oXbZzZJU6eIgmD0XvqVVMhOt1PpQWOswX1fkia4VD7Ju2wIhOCpU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=HTxeoGCf; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="HTxeoGCf" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-306b78ae2d1so3490558a91.3 for ; Tue, 08 Apr 2025 22:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178359; x=1744783159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qsHO17LnKKqQLTT7VMA/aJzN4PsTAXWxtYSCZZAyv7Y=; b=HTxeoGCfe3ncEA0sunyzaGr8Vk44SRciT21UQ7YnaqK/6JzWKhN+vTT14yQv6aCOAz 3C49zWVSqKHAuClwfO4BO8+rJnTUg4/7Evub6mJMUVZuxruVCiLBhMq+uY8YU5SuqYw1 aCvaSFTsy01Gp4km5bBZ24rYsHnzsXdWJ3awBSONDhXhqIBc8+ORDh9Mrouw9O9rVM/O e56PJ9gS/UZbrUVhFHbjruEFBIi9ugnkY55BdQNCBogW9+txliSjEs6r29Z5qoGbBYJ0 EvoUid03cuYUxLneRMzLdUVobfAjdzalK3/63cY/8V1wARDMeims5E8iDDLvsM85ohd7 4/AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178359; x=1744783159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qsHO17LnKKqQLTT7VMA/aJzN4PsTAXWxtYSCZZAyv7Y=; b=eoQhWsxYoxA1T3hzdQwrx/cNJI5cGgLvKlZCjejQ7R8xRWJKgc5pSb7paMxnFq1fsD DkcBs1XPNv/6WkmRnvb2WMAGKXdxcPl7WenGonUMA7Ot3Yoj9PKmO/Dt74wsLhkH8SiJ /gq2xedlEoHPFQnFBYr/R0xBa05hhV6OePE4MgOYwwkX8jhR7YwsyIz7ayzwvU6m7Wtg z5zxCv5vEsziaCBiXEvBkZuvhzVIGhTPXsFj2tLusbEGThWCfWldLfiFsUCgeLI3jETz sG7m1oUHTKrmMliq7eEt0ro3kDEbGkKY7cR+ifjIr+FKcw31OMaEpWlohas2fBAgHWKH sm5g== X-Forwarded-Encrypted: i=1; AJvYcCXCn3QR+En9hha+OqMV1YUs1LVDPq6+F7abmOYJZvxd+VGO1SracwAJUPeQVLD7bjdgxHtRtoNxKRy2YWs=@vger.kernel.org X-Gm-Message-State: AOJu0YwCNB/5dt9Yy1S4Qp/107Gw4XUVkMBeoV5NECeHxapp6bKIgVaL Cau4qq5B45moBMtD/SQYUn3PP+JoEmNnh4h9T0tmI2NkJY03Kb2Vm3pguKBAXw== X-Gm-Gg: ASbGnctiEvI7s19CVqg6iYrGOTlsp5gnuQgRZ172pB+iqgoIBBIhyt/0Ynf/9SgmORf SGGcTTxnnqpJUSerKNdqj01/JCDid0rUsLNpiJHOrsFYYikPJoxNhZnsREjT2Pnm9ysPfj3Yh8C KZImYfJ6bMfuJJxFJAophr/d+SHczzrtm8rFxTGndnSmA4r2KrCx+V62JY8FqDkbPNztGWhAfo5 6lW3y1fuG2lIZzZB7xhP9kX2tgXvKwCznsjqZQkJnNNVawbuh7G3A+JD01FR2Zof/wD1sJpcRix 7+Kzt2GZ428EZRkTl1SedAFoz1AbNHLsuLNBjgdGJrB68V/pRXWBx+R8oKwigi31vfU2ySuniXL AShARRQ== X-Google-Smtp-Source: AGHT+IGxInF1tlWAEb5ecTeN3SbQ4ysc4Fo+Y8D2nJkd/pWinm4Tv/gquLdEGrWGnjCy7RBPBMLM+A== X-Received: by 2002:a17:90b:528e:b0:2f1:3355:4a8f with SMTP id 98e67ed59e1d1-306dd3247camr1986546a91.4.1744178359515; Tue, 08 Apr 2025 22:59:19 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306df2fb171sm493574a91.34.2025.04.08.22.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:19 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 11/21] staging: gpib: Using struct gpib_select_pci_ioctl Date: Wed, 9 Apr 2025 05:58:53 +0000 Message-ID: <20250409055903.321438-12-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_select_pci_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index ce2184c5de03..5cf425fdcd89 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1797,7 +1797,7 @@ static int interface_clear_ioctl(struct gpib_board *b= oard, unsigned long arg) =20 static int select_pci_ioctl(struct gpib_board_config *config, unsigned lon= g arg) { - select_pci_ioctl_t selection; + struct gpib_select_pci_ioctl selection; int retval; =20 if (!capable(CAP_SYS_ADMIN)) diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 041b0a1593e9..5681a66483a8 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -81,10 +81,10 @@ struct gpib_board_info_ioctl { unsigned no_7_bit_eos : 1; }; =20 -typedef struct { +struct gpib_select_pci_ioctl { int pci_bus; int pci_slot; -} select_pci_ioctl_t; +}; =20 typedef struct { uint8_t config; @@ -151,7 +151,7 @@ enum gpib_ioctl { IBBOARD_INFO =3D _IOR(GPIB_CODE, 29, struct gpib_board_info_ioctl), =20 IBQUERY_BOARD_RSV =3D _IOR(GPIB_CODE, 31, int), - IBSELECT_PCI =3D _IOWR(GPIB_CODE, 32, select_pci_ioctl_t), + IBSELECT_PCI =3D _IOWR(GPIB_CODE, 32, struct gpib_select_pci_ioctl), IBEVENT =3D _IOR(GPIB_CODE, 33, event_ioctl_t), IBRSC =3D _IOW(GPIB_CODE, 34, rsc_ioctl_t), IB_T1_DELAY =3D _IOW(GPIB_CODE, 35, t1_delay_ioctl_t), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 735861E5718 for ; Wed, 9 Apr 2025 05:59:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178362; cv=none; b=bqCXrbsWWCJOaZ97V5UA0mrlq4qiKcJbsMbiFeIzTJFb+zYYwRL/C7nTV0Uf81HNjsIm1hG15XdWWRbNw19lHfvEfEknfKhxWSF/buoPAdy+K8QSlRaLVDsoHdFuasNkUg6cJw0mMWu+sNmwRJqRhMGx64lUSj3y92qXPSRT/Fs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178362; c=relaxed/simple; bh=VhGRDqY449KRQVE2h/g/Djcp/iR0bi4t4g+O7wKSgRM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eox7pIwOS0nmG3eTgXF0Hsc7iX53fzkbYdDL3O5An+STNTo6imfxjfSVvkGIZkgLFkwpEQSkC61wRg9AedVZb/yt0H0XfWXC+JHHJU9dyP9Gc1SdSDmWNU4micJchDfMi0EV98sYoB4OzNi3n/xpRTDODzj067UDYV5+ytC3RzU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=D5B9dDJz; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="D5B9dDJz" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-301e05b90caso6078143a91.2 for ; Tue, 08 Apr 2025 22:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178360; x=1744783160; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WR47q75TB8WlKStVt6RaeaJCRBW1DtpNGupRPZBuw0E=; b=D5B9dDJzqaCQOzi7MYRL5p9qO963LyWD7xtJMT/G+6oPRvI5sS1XcS87nrBsfWioZ2 MOWCd4bpaeGZRO5MInsG7RFB3fJ+57pJVWVXDxa5nn4RGXkkvZC5FP6pPSMp6pW46B1k M8QTe5qbmXWmQMkcc4X9Gw9u8ww1QBjnlzTMTawpdpic88JXA4h8LETcHUKawR4iIDRz LbE3z/VQKD5yzO/NB+TF85grfBYcfKNTGPTE+QGY45x4Qe0YNsFB+dkhsa2Oelu+y2DY +A9Q+oQw2j84TvKvThhU6XEADKVXXw2t4kw8yTPvGDXeoCjCcG7rxhbn5/h6uIeONdZ8 8Ntw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178360; x=1744783160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WR47q75TB8WlKStVt6RaeaJCRBW1DtpNGupRPZBuw0E=; b=wJKc/nCx9MTed3Wz3NhLBeSHFn3Tee6Jl2/Ahs0Y6TsK/JLmMpWwPmt8ju7fuZ20Jg jy4741CI10C/ZB6pwrKUpPBxcuQP09gf0aQGSAyZdIvJKZcacl4etltmhawVOVmfxN9n BzU3kx3WHcDzCo+tfqkcFfd3n3eMnmqojrKCEkxAGG2uKSGthssKVVfHkJ/rats3u5ji ZTPBV5l7876EwxwJoT8PKYeeoTErraTIETV12Z6XVMWG6IHkfRLvqUX5oIRGc7REerQk qru6rapE6ndiSn7XE7RmfTTnjVj3z68lVmN33uZLz+bN7sJGfT5+J3ra20yeHLncVWEk mClw== X-Forwarded-Encrypted: i=1; AJvYcCVudcyrOpS/TNqEitzz6fPyXm1Z/eMVBCZAqPTqkk2+e650yz6BiONW0IrQeRJ2Qzk4t60K3PCQxGW7t1E=@vger.kernel.org X-Gm-Message-State: AOJu0Ywqkcarb//99iaNTR+Np+vsYwPZ5i9yEt6TiRTCtlt8Nh9rdACL H2wIZseDXF0ek73meWsj38jPOYmFop7kweiFEjwJOVz1DrbePaKMYptPPjCw4w== X-Gm-Gg: ASbGncuG3SIOxf9kGxA7CIiXYahBta5AJSrrNnU6XD+7KtQn3CV5df5U1FDSk/OLSnv rpRPlmDfVx90CXJamDpziCqDJc3u/Ci8oz5XF72jNSzh3ATNPxD9l1jgSoeHUX0DTcbYebyqUr0 loV8TMnROX95bVNLGaXsAoSVxxOYJXlSPdn0R+oWu3olsKi8uLgjZUKqxLPkUmRoSbV5BK6XdBu VVChP0D+nny6wILkpvAsAQfhNIJ87tOG5DguvLy1vM9OjJiOc4CAVbkADvGYA5Lew1AOF5OshEL fJDogrQPEpDGiXB8N2anw3iJWeyo5X0AoYFtwouF72pufKLdDjB7Gw3u0mmu6z8hdwA/iGK3lmQ 8yWszNkxmKwfyfumU X-Google-Smtp-Source: AGHT+IExEWskvgtiKO9mBzNMlc2ICB2I1FMAJdgV+rMkRicDN2Cj9J8GNUfQCE7IF563bsAAsa7e/A== X-Received: by 2002:a17:90b:2748:b0:2ff:6a5f:9b39 with SMTP id 98e67ed59e1d1-306dd529aadmr2409545a91.18.1744178360746; Tue, 08 Apr 2025 22:59:20 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306def4e800sm511348a91.0.2025.04.08.22.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:20 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 12/21] staging: gpib: Using struct gpib_ppoll_config_ioctl` Date: Wed, 9 Apr 2025 05:58:54 +0000 Message-ID: <20250409055903.321438-13-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_ppoll_config_ioctl' to remove typed= ef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 5cf425fdcd89..3939c85fb533 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1692,7 +1692,7 @@ static int timeout_ioctl(struct gpib_board *board, un= signed long arg) =20 static int ppc_ioctl(struct gpib_board *board, unsigned long arg) { - ppoll_config_ioctl_t cmd; + struct gpib_ppoll_config_ioctl cmd; int retval; =20 retval =3D copy_from_user(&cmd, (void __user *)arg, sizeof(cmd)); diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 5681a66483a8..df428899ba3f 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -86,11 +86,11 @@ struct gpib_select_pci_ioctl { int pci_slot; }; =20 -typedef struct { +struct gpib_ppoll_config_ioctl { uint8_t config; unsigned set_ist : 1; unsigned clear_ist : 1; -} ppoll_config_ioctl_t; +}; =20 typedef struct { unsigned int handle; @@ -147,7 +147,7 @@ enum gpib_ioctl { =20 IBMUTEX =3D _IOW(GPIB_CODE, 26, int), IBSPOLL_BYTES =3D _IOWR(GPIB_CODE, 27, struct gpib_spoll_bytes_ioctl), - IBPPC =3D _IOW(GPIB_CODE, 28, ppoll_config_ioctl_t), + IBPPC =3D _IOW(GPIB_CODE, 28, struct gpib_ppoll_config_ioctl), IBBOARD_INFO =3D _IOR(GPIB_CODE, 29, struct gpib_board_info_ioctl), =20 IBQUERY_BOARD_RSV =3D _IOR(GPIB_CODE, 31, int), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17BAD1E833F for ; Wed, 9 Apr 2025 05:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178364; cv=none; b=E7R6U3/GHvh7Sdb3zkTSrEqOCiuqy26dnOY+DQyGRhbqWqaeYEJho/LQCZ5LxtwSgWjPJrOCXjhpf78OBZcYQ9vrUZ7mKPcfvvr5KiG0K1/94tFB83gkWBBnZxclpxH1T78euIAmkogG+126UnCxkv6XTfDjHnwvTPQSWTWyLcs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178364; c=relaxed/simple; bh=DyFt2+uyue0P+cm4YTjmTcgXbSDc0WT/k4eV/cY4q0c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fyMC3W905XXDRbmGgoJgNmlHLgGrFvRW32lCBBZMTDFIzzP8tpJZzhON0fga/L70A8WOBdfRzrErOp9gf2Bqo9Jujihbs5wAkCH84BWQOCgXwnQW1dF4fXGv5MG2crnfbB5bHpOhUMsFMIrIwxafmxfysUAw4MZP6P01OoIFE+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=BUJQjNyG; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="BUJQjNyG" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-af6b02d9e5eso4395833a12.0 for ; Tue, 08 Apr 2025 22:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178362; x=1744783162; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H/nJaV/Y7GI363GYCtXUAn1aXn1N+OacFtZoTBjJ5uU=; b=BUJQjNyGassQTuP5NFpju3GRgNY+T3/ZWXwSy9G3n3onB4n/vFSaAJoYEBojcBdoQ2 vBJFPbNA0sqq3eO0LGPGBQYg2jTYuW+xldcY8h4udlSaCh9ZvD8IjtUL1wPSLzaNX0fG h73tN1OIKKtzsUp6v7Xv/mKJeUmZvHW3ydoHnGmrdxRk0hXdO4pWIcPslTG5PF6tr1XG 5A4YMG1xoiIMvlX0pFwEaUfF0E0Lhuwu0kpoe8+3/kR14UpPYJ9aQs+YnRljVUZS//8w 0s4RSfWTY7HK6tGLcM3MoZ4vO/5eBiH/neZxfUjHdXBIvf3R9JLcn4rxf+i2O79hbRUl 9FLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178362; x=1744783162; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H/nJaV/Y7GI363GYCtXUAn1aXn1N+OacFtZoTBjJ5uU=; b=xGDSQ++ZHImE0bPUEgpLaeAQ3pEdqihyGkYpsBlpDT4mJLMfdrIhYAdTdQdNrDfuUH wPTce0YeUfVJtQCELlHpysiaMzDt7I32Xcx/fo9uUTFuonFPZhwcFPriYGcAtT/wrxm4 BuzDavwbQmEONRre/49sF1cjuugDds2AXRzVFK6wMCEYlAB/4Y+ERXY7giUGzjflSeZE gmuXx0AQJAI65mVsl8BwnQe3iOQMGwQq9PVNM2F19X5TS7odxoJfQumCV5Iem6hWWNg5 WPAlwXb/EJW33RJIu2aEaokxK7+/6cVD9oO2TbbJ826mXo29n+YNupNDi6HuEFzyQlOM ASXg== X-Forwarded-Encrypted: i=1; AJvYcCWvE2+BbxOK1d0dMrcRUR0iTAOmWj6olI757d1yVdj9mh9w8pvhKhh/sFhTFXoyVV5XxAFAWYTbjf/WdHA=@vger.kernel.org X-Gm-Message-State: AOJu0YxoVk3ZC/wzFjrgrExMAQAk7/X7iuEnAeJOnGP2Yl4NTSNbrwop A4caebELt/UMNEP5CkGNGbrk5S49jDv+ow+MA6Se6c4jjc07q/iwLvMYaVL9hfsw9S5qqoMAAPM = X-Gm-Gg: ASbGncv5bSSDjDo+IqU1clQPgeupm9+/HmnmLq/SmigVc8AkKsYQ+4b/dWq5IPGz3dv yRzUjoq7+1kQA9Z6Df0QqGsP3sEU1DqUQsu8almrNlUSBA/EJ63sqoWC3W+feGNladsA8mlnloo Lyz0arjgBW4t402f7R0y6x9AJJDtLrbpC74fQ+1giMvONcRwjxVg6dGfWKR1sPUgt4+Oey5roq3 djPjQdo86vPAX2rwb0zqfSR2ReX1jEeWZZSHSrZRtR1GtiPopwTsJutxq0JgL5KIbl9BMRIkp30 Pili5FIUziqokbYNP6GTiSZsyx72fGhEF2jCHSWt52tSi3tjNvBlAZU5G+MpPHZZtwJKjaF4IDL EOrFAPA== X-Google-Smtp-Source: AGHT+IGTSYyhxmuxAeXj1ewKl8XgTsU3tZLEhbSXU6xsRIIdS6DmWr47BGlO2BCBnc9TSU/AyWnBKQ== X-Received: by 2002:a05:6a20:d04e:b0:1f5:9208:3ac7 with SMTP id adf61e73a8af0-2015b00f7b4mr2059829637.41.1744178361921; Tue, 08 Apr 2025 22:59:21 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b02a2d3a2b8sm396075a12.58.2025.04.08.22.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:21 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 13/21] staging: gpib: Using struct gpib_pad_ioctl Date: Wed, 9 Apr 2025 05:58:55 +0000 Message-ID: <20250409055903.321438-14-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_pad_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 3939c85fb533..2fc93a3c4b00 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1438,7 +1438,7 @@ static int line_status_ioctl(struct gpib_board *board= , unsigned long arg) static int pad_ioctl(struct gpib_board *board, struct gpib_file_private *f= ile_priv, unsigned long arg) { - pad_ioctl_t cmd; + struct gpib_pad_ioctl cmd; int retval; struct gpib_descriptor *desc; =20 diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index df428899ba3f..7cb09cac6cd0 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -92,10 +92,10 @@ struct gpib_ppoll_config_ioctl { unsigned clear_ist : 1; }; =20 -typedef struct { +struct gpib_pad_ioctl { unsigned int handle; unsigned int pad; -} pad_ioctl_t; +}; =20 typedef struct { unsigned int handle; @@ -134,7 +134,7 @@ enum gpib_ioctl { IBGTS =3D _IO(GPIB_CODE, 11), IBCAC =3D _IOW(GPIB_CODE, 12, int), IBLINES =3D _IOR(GPIB_CODE, 14, short), - IBPAD =3D _IOW(GPIB_CODE, 15, pad_ioctl_t), + IBPAD =3D _IOW(GPIB_CODE, 15, struct gpib_pad_ioctl), IBSAD =3D _IOW(GPIB_CODE, 16, sad_ioctl_t), IBTMO =3D _IOW(GPIB_CODE, 17, unsigned int), IBRSP =3D _IOWR(GPIB_CODE, 18, struct gpib_serial_poll_ioctl), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD19F1EB18A for ; Wed, 9 Apr 2025 05:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178365; cv=none; b=aq0wIN/j4yzUFmKNf7ozXyXL1fccokLfiun0MQmLvb9A8R4rep/CStbrnJXX7QPZGSJGsfVtReq55w5tCt0ZyWeh1yADf0aDQY7+DiNRceobsOfAE8vSFxdpHzIGlXxTKdKanwRSbRGo4dIg08z+7KXYCKKgky+UzyB38q4BhUs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178365; c=relaxed/simple; bh=ZmzFQ/xDAYCtwqpaLt+46DJGxSnTDxWoxUjN5RavIDc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ny55L2SlwTljjMipELm1bb91E6K8CHn+sNknB59pO8mh9RpeAuCAuLbLEsVNP79/P/ziJCXworkForLC2K6YqpPgF89QObXgkfYrxoxgEuLsnE8S/rGjE0mkCHkH13BXUpbwxjv5hPCLDhFxbOby7o4LQwZRmogCWh9GpzAgNEY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=IpGX6D2w; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="IpGX6D2w" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-af51596da56so5203262a12.0 for ; Tue, 08 Apr 2025 22:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178363; x=1744783163; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5h5ovOyfAn7yPEFX4yOHA/j00T0uqSAm1ZLyzSebNBQ=; b=IpGX6D2wg1YCy9LbSz4MayygYxD9UuwhzaL7fKiFCOY+ijy75ghYrH30ZktyI4w4xI 8hEQtlJrUAB8OID5hZXVtHJVbd3l0LkyrDsR4gfQmgCkPqY6tMFN6TUEIDX0LQ68Ira4 kQefTlxo5jW2Ace7ERuP7O7+1s+Jm1ok2+fFJdkFDPecW+BHzJDlbkL/lgqzmB1omv6F CL7dzNx29OA1RWcd3wKh7kvnzW/LxYfD1Io7mDK0QSSL2TmO6Qa8ad5ZXrSs+XqLqAbW xRpdbot8AajXupKuqNb9KEibt+gx5TWO5I8bnRnRxt6kqrwEvwI2pwDSqhf4f2dLq1H0 /0Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178363; x=1744783163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5h5ovOyfAn7yPEFX4yOHA/j00T0uqSAm1ZLyzSebNBQ=; b=Is0EY+2OYVMPveQqi4i1JFFYbUJWH/bzM3N0almq7lFPVWUDzuxvgIs9qNCOqmyXNb 1l5/czy3dzo/W5VM4xiOCl+bCiS6EBGZQUxpDO9Xpoa85PlhmnPqo+sXUqaAlk/SnjBa QF8eiC6H0Mv0y5s/rc7ly2Hl+cO09LDKWTZFRJaHJerxM5GJJVCYJWkJ4Ij6alvDFbZu Dgda/4YQRXqnTQXaVNH+ggGJyKDyXuMUUKX3yUrA2NVQOUcygvQUehdangyDBsmePf+B i7Vj2Nm9z1lvl7Vvr3DwYDkjdKA85cHgJwmiJwx5dE8vSeieKI0lLib/hB/jyQqfmNYV GzrQ== X-Forwarded-Encrypted: i=1; AJvYcCXUmD5fCSWSa/MUrPc6VGdpVseRh29FpYydKnXGEBHXQVupnBCjTGxnwnEndYvGcjMDWFmC4goG2DtHyH4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9wgQdniQwk19HQHN478ZI/YplyUC8N4rb3pbdNYlcJqAYPB8W 17mifsu2FZ/9x98lo8jDgqRuQJOV/mTygOQvFQpq/a619VPrdTBiXAqNJZ+8rA== X-Gm-Gg: ASbGncseCm7IUBDU+6pM00s6DevpxLnSR+EHdefqdfzktLwIsSpeX7bFrTWp/pR57qR nP/iMO+TwnopFN9vwvOfOO0DiYKh5bVOwQuGTro1xVhgcbictHLLcG9vd8nhJf8En5m6gv1dqbt MIENK1JoUGOdu3jy1e4M4huC1Iu3d1SlM7eC1yePFTYYFRThTzR6/6ouorqccDSaga7HNqRMXgZ R7D4o7F5AIAHQWmb35Mw83Ppe1vFUmqkNCeVTGz+ve/iAQ4Fuq/V41uoCVzx/W9doPWBxA4gYIA kPW/ozViODYDNkPQm+cMu3oX5BBrWSklgP14GO4jtQweYa2it4vxf1OV0qxTpl5+I/ffbyOFH2I 22mKFSw== X-Google-Smtp-Source: AGHT+IHc7Q1kV8Kaz6yYTOBNqLkhj3FRON/2uBgtut0lF8Myn3iTAsf49vRKnNZyYcvyzb+7zZyJWw== X-Received: by 2002:a17:902:e750:b0:224:256e:5e4e with SMTP id d9443c01a7336-22ac2991b3dmr21506375ad.16.1744178363105; Tue, 08 Apr 2025 22:59:23 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7b8b2absm3486745ad.83.2025.04.08.22.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:22 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 14/21] staging: gpib: Using struct gpib_sad_ioctl Date: Wed, 9 Apr 2025 05:58:56 +0000 Message-ID: <20250409055903.321438-15-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_sad_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 2fc93a3c4b00..8febd683fe0b 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1474,7 +1474,7 @@ static int pad_ioctl(struct gpib_board *board, struct= gpib_file_private *file_pr static int sad_ioctl(struct gpib_board *board, struct gpib_file_private *f= ile_priv, unsigned long arg) { - sad_ioctl_t cmd; + struct gpib_sad_ioctl cmd; int retval; struct gpib_descriptor *desc; =20 diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 7cb09cac6cd0..a0fbc660ab99 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -97,10 +97,10 @@ struct gpib_pad_ioctl { unsigned int pad; }; =20 -typedef struct { +struct gpib_sad_ioctl { unsigned int handle; int sad; -} sad_ioctl_t; +}; =20 // select a piece of hardware to attach by its sysfs device path typedef struct { @@ -135,7 +135,7 @@ enum gpib_ioctl { IBCAC =3D _IOW(GPIB_CODE, 12, int), IBLINES =3D _IOR(GPIB_CODE, 14, short), IBPAD =3D _IOW(GPIB_CODE, 15, struct gpib_pad_ioctl), - IBSAD =3D _IOW(GPIB_CODE, 16, sad_ioctl_t), + IBSAD =3D _IOW(GPIB_CODE, 16, struct gpib_sad_ioctl), IBTMO =3D _IOW(GPIB_CODE, 17, unsigned int), IBRSP =3D _IOWR(GPIB_CODE, 18, struct gpib_serial_poll_ioctl), IBEOS =3D _IOW(GPIB_CODE, 19, struct gpib_eos_ioctl), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E85061EF091 for ; Wed, 9 Apr 2025 05:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178367; cv=none; b=qP4xAKRqyfrnfj8YYeJDCRxc1nPT0U2NevI1L70pJS0w/7HBR3qp8J9T3fuF9E7jMsVe/2J4U0TNpJG/NcB9wCNj18oY4hhWWqD9LtSkzN5+h1LDM5p8qMDOEzDjLlFRVk8ULG/EKM/qM4lr/Pjz8cjCCO71rwNCir37Mcd/MM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178367; c=relaxed/simple; bh=VInhgwSIIXvZJ1g/htalPQyTH0iq5W6bLI7iHQ9bc7M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kxVe6H2Bh3y7i6S9GN0F3sUwCiSZSB1bVgxGZyQByMWrF5pItnd+66+wmfvtTzx/G4x8Zdu6RFFIgCc31W5SQpTitASSPwgCZuC+EPMvPTekLACFzqhjPMwok0UYRG5GZVvJGBNol6evcWClIMog/4SZCc/Xld604tOJbTnN+qQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=miFzhEI5; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="miFzhEI5" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-226185948ffso66087445ad.0 for ; Tue, 08 Apr 2025 22:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178364; x=1744783164; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+U6T7r+NCcsX4bcxp+7IePUhvD/0xAqz8Z5Y+CnNL0s=; b=miFzhEI5OT5dFSzl4BlqMwNye/CYAndcADlg++bK2mfXzaM5OHnFCQOIPaCP62KUKA Ndk1U/KWct+tDWvZrgRB6u6tte9ThPK7Ld44g3SOL1YsN0kp0kLNlbGSvMqYuccizsBp Bb7sGwlIfghDBGYGMzGt96YZZt6z3vCLf+nneZkVfKrqT9+PI/4arhSS0JApWlOkZwn3 xfKaGc/RggDyNksWPYgBIA7u9FdL+iwXuadNPzleTmvvS6eGsBhRtM1cvZOcgkI3rq4p o3NN5jCugyKv1r3LXwSDrk9l+f9moOYGXMRv6zROhmY60eRRN/3SiHgzTu4G19W0dh1k md0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178364; x=1744783164; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+U6T7r+NCcsX4bcxp+7IePUhvD/0xAqz8Z5Y+CnNL0s=; b=l1bFGBiVwhhUQFqWtSmUY6feiB38daVy5YLgoFK/U+wS4Dt027j9wRwG7suAZBjLbX jJoWF57WUlxQQn3Pjm0PoVLAMPla5GgndlA09qEGQ/n+IF4QZ45ClBDWj9cmwjZxpK+g 098II/s4D3/CLHLFtlbK/wiOlhsh6GbANh8Xi+8pYFQGCcypxzgDMnYdoks84E6GMIFR 0BUGWPo7gLTLInAoRX6L9o+pYTaWwv6mzbNqQh5l0fhG6WL5PHaI+kELshd9TEAw6vl9 ogNXoBy/Wer9HrMlJNGOAZY/j/dfxpaRqxm19lP5Z/rRUkg2n9qDwjyIKotARj6z4rgA qRTg== X-Forwarded-Encrypted: i=1; AJvYcCXNj7bUn5xJVCSGolYtI1+Te/ZY/B4XTKwk3wssDWAVqmm5vZAVZn4MlUnFze7VMz8fyQryWV6NwezsA0c=@vger.kernel.org X-Gm-Message-State: AOJu0YwDvvOX6NhvLaYIF9w2K2X27ZXE3qH/AS9zT1FOcpHJ712omwFV IZz5jIgcy//nRPYWBQPzU/SV85Uiki35CylEy0RkoSNSHgLi4y44qw2dv5YHqw== X-Gm-Gg: ASbGncuSOYyUv5Mn8QQj0CTO9n4Jcl/I31wPX6C8/3vsZNm1j3Dnq7Q2CwOE+TPhk9q hger5RNZs2N+BWyAdUxYQR8qzyvBl/ADgPEjMirkN8LwhDF3Pax8F/rQNX9yTB6bhqoDBDAMAc9 Ha4eSzhVMc2bxAzuGjQ7JvANExbRg7frG+jzxO5o72EHKOIQmpWEH69BMaEEQ8U5fgfcYthZSAn jah2P4SjH+QvBL+1AqiL3NC1KrkxQJ4KyJk12gf/Q41zXvU63jCv8KkdeUynedjaAsfXbxp3xwU j9ztbFaXf2u+102Pm25D/82ka6qy8eNPZvq6bCL4gZJzaIgFBQbj25Io/YpFY1hd8ktwmjMBw03 rEgi1lQ== X-Google-Smtp-Source: AGHT+IH93XidxFXNNSKdlUql5hI1Si+EXEyliC+5Rxu0PP/O+JUUJzvGhlEACOHeIGCrXW2hJjfzHw== X-Received: by 2002:a17:902:e80f:b0:220:ff3f:6cc0 with SMTP id d9443c01a7336-22ac2a1df0bmr28550885ad.38.1744178364315; Tue, 08 Apr 2025 22:59:24 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7b642besm3481435ad.46.2025.04.08.22.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:24 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 15/21] staging: gpib: Using gpib_select_device_path_ioctl Date: Wed, 9 Apr 2025 05:58:57 +0000 Message-ID: <20250409055903.321438-16-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_select_device_path_ioctl' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 7 ++++--- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 8febd683fe0b..71c379c22be0 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1815,17 +1815,18 @@ static int select_pci_ioctl(struct gpib_board_confi= g *config, unsigned long arg) =20 static int select_device_path_ioctl(struct gpib_board_config *config, unsi= gned long arg) { - select_device_path_ioctl_t *selection; + struct gpib_select_device_path_ioctl *selection; int retval; =20 if (!capable(CAP_SYS_ADMIN)) return -EPERM; =20 - selection =3D vmalloc(sizeof(select_device_path_ioctl_t)); + selection =3D vmalloc(sizeof(struct gpib_select_device_path_ioctl)); if (!selection) return -ENOMEM; =20 - retval =3D copy_from_user(selection, (void __user *)arg, sizeof(select_de= vice_path_ioctl_t)); + retval =3D copy_from_user(selection, (void __user *)arg, + sizeof(struct gpib_select_device_path_ioctl)); if (retval) { vfree(selection); return -EFAULT; diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index a0fbc660ab99..473b09d4efaa 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -103,9 +103,9 @@ struct gpib_sad_ioctl { }; =20 // select a piece of hardware to attach by its sysfs device path -typedef struct { +struct gpib_select_device_path_ioctl { char device_path[0x1000]; -} select_device_path_ioctl_t; +}; =20 typedef short event_ioctl_t; typedef int rsc_ioctl_t; @@ -161,7 +161,7 @@ enum gpib_ioctl { IBONL =3D _IOW(GPIB_CODE, 39, struct gpib_online_ioctl), IBPP2_SET =3D _IOW(GPIB_CODE, 40, local_ppoll_mode_ioctl_t), IBPP2_GET =3D _IOR(GPIB_CODE, 41, local_ppoll_mode_ioctl_t), - IBSELECT_DEVICE_PATH =3D _IOW(GPIB_CODE, 43, select_device_path_ioctl_t), + IBSELECT_DEVICE_PATH =3D _IOW(GPIB_CODE, 43, struct gpib_select_device_pa= th_ioctl), // 44 was IBSELECT_SERIAL_NUMBER IBRSV2 =3D _IOW(GPIB_CODE, 45, request_service2_t) }; --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45C921F8743 for ; Wed, 9 Apr 2025 05:59:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178367; cv=none; b=L6chrJyB01cF4oOp5VIPtmOYRKFEHmQPUJNZ8M6H7DzGj4QzHrY6ThhQnHA2jsutnHwgLsiHmu2wI+Ob9hFp1AC5kx1X+wOKcZ/IZmtONjmcgwq9mk2N6Meoh0WxZgAEA5czgUtAlDBEaK9E+mre5eh2t+igO1g+qui25FN3b8s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178367; c=relaxed/simple; bh=7fDnNZyWVelA2uVBKDQ3RFhfWQv6oGCEmBupTouNOMg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kyjx0l9zbWV3BEqa+TXfNhD79h4MWdiY1qlciEhkjTrJHjqVBZuEd86fwT6M44BM/otLru3ccP/vFs8S/Gv6OPHcDNLFhkiCnES70fJ0u5+J80vlxbC3y4b6VRqpXk0qb+8+jpKSrLNrjQx2SjV6QnZjzJevn5V23oO98ajhf0M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=lUjpOFEH; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="lUjpOFEH" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-af19b9f4c8cso4237005a12.2 for ; Tue, 08 Apr 2025 22:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178365; x=1744783165; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qxE4gWwYLPsvJrRpHDQz1czRhA/+OUvd2xG6gTlogF0=; b=lUjpOFEHssXrV0I89T6XBSMrSl2XP82r9ByQaGUF5iiLQ7/bwnSBcgFiHmnL9mXXzD mk0Uvitx3GBNCd6AQGmGxrZqwgan00anQE1xjCYR2SBXnCdX1T18TWs2EA53ztx1/Ye/ eRejMSWSe6N4UQ165ptkbx2EMRT+IY5mFzE6jYAk9wCqFoAlbZn7vPlE5uw7deSKKoYP qhxB8rzE3wnsIBFz5z+Bo3wlm8Vd1LmY+K6uwcO7+hUzFtlkpHbnd7wO3FhU35IX7Tpm 91wOrpmkKcZZYE7w4H9XZm1YjqF2WbOn0tUFrJyMpJPDVxEiO5uSgL8p3AArbQiY6SpX LXOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178365; x=1744783165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qxE4gWwYLPsvJrRpHDQz1czRhA/+OUvd2xG6gTlogF0=; b=T4l7icbgdl2Hn5kB40USvkdc4tgcTkBJGQJUI7HCnt0cGXJ87/YkMVskcMeKmIlDdr urCGeVT54gxRiuWkyxlnvSWegqfl1eeYwaXZCDCbAEHrE8tlIX75DkAHrG+gF0KfPLIt uMTNKs+I3Deq9c6zBB90ggKcKkkVHU1SQNMtkJuazSgR/hLizIs8hMC1wohXdnf9Zfts jr4DVBukJX9r03FBvDzAZ5iTm2gIgty2FPqt4oeAacee/zGcxq77uthDg955+mXCZDP9 Gbx5eYiA0bmuItK3LD6UgL+IrJ0FQLkIL3L3E1QMRokC7C2I3oObXgUxP+GzwKyJTbHI t/9Q== X-Forwarded-Encrypted: i=1; AJvYcCWx5jYlRXh/EkOxSrQDkaGhoVZ/sn2D8P2M85BIzQpNUHQ1Xfc3bWN/mgRoMm5TSEAlnxHlIzTrPCO6LWk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyr9NZfaRNqx7uBeJfuQ2FYgun2RgR9EfKmT4bmT3Am2Bezstxh LDQUICXK2cuD3D5yTGeBmXM69T1/yR7a9Mb2IJ0uRG1bMShNkTL+Q1XU+ba7KA== X-Gm-Gg: ASbGncu82hnq6U76m07RD8nW5ZJfHZTSJhEKfCzShSmZaLB/ognHPYwTF1mP0nBFEFw SqNBGRZBpodOj+ztQ1dAhhrOP4CPMmPKo4D4ywK+oY754bhZ2IrrfSZP7gpOIOaREb9doi5w99Y 6awIiefUAyvfXH//Wndg2IoN2n4uH4si2KGg9dQkxovd+5azr2inUOB6qlSbWF8OcFyd3e+jYYL o4FVdPDSKmooLLOUucSCOrakinwqS9yfoGggqQlc48vkRaZ+3U/2Fc9kSdw2B7bCHAAmkne/15l S5Bx3pUWzEYxShU/BH2XKhjgBIAckZyhjMUp5x8JPhQkNxosc/PDKr+AU0ENPOsar98ZodjXF7Q fQfdQkw== X-Google-Smtp-Source: AGHT+IEaAD7oH8MI6x/a+Fqozx/FFggtmkkKHuw2dYqZ2L3Em4TjIRajw7UDOLoU6kxqquxnH2IbkQ== X-Received: by 2002:a17:902:c40e:b0:220:c34c:5760 with SMTP id d9443c01a7336-22ac2c36606mr22391615ad.51.1744178365469; Tue, 08 Apr 2025 22:59:25 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7b8b158sm3476475ad.84.2025.04.08.22.59.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:25 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 16/21] staging: gpib: Using struct gpib_request_service2 Date: Wed, 9 Apr 2025 05:58:58 +0000 Message-ID: <20250409055903.321438-17-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style for 'struct gpib_request_service2' to remove typedef. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 4 ++-- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 71c379c22be0..446827701399 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1532,11 +1532,11 @@ static int request_service_ioctl(struct gpib_board = *board, unsigned long arg) =20 static int request_service2_ioctl(struct gpib_board *board, unsigned long = arg) { - request_service2_t request_service2_cmd; + struct gpib_request_service2 request_service2_cmd; int retval; =20 retval =3D copy_from_user(&request_service2_cmd, (void __user *)arg, - sizeof(request_service2_t)); + sizeof(struct gpib_request_service2)); if (retval) return -EFAULT; =20 diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 473b09d4efaa..eea169a0ba40 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -114,10 +114,10 @@ typedef short autospoll_ioctl_t; typedef short local_ppoll_mode_ioctl_t; =20 // update status byte and request service -typedef struct { +struct gpib_request_service2 { uint8_t status_byte; int new_reason_for_service; -} request_service2_t; +}; =20 /* Standard functions. */ enum gpib_ioctl { @@ -163,7 +163,7 @@ enum gpib_ioctl { IBPP2_GET =3D _IOR(GPIB_CODE, 41, local_ppoll_mode_ioctl_t), IBSELECT_DEVICE_PATH =3D _IOW(GPIB_CODE, 43, struct gpib_select_device_pa= th_ioctl), // 44 was IBSELECT_SERIAL_NUMBER - IBRSV2 =3D _IOW(GPIB_CODE, 45, request_service2_t) + IBRSV2 =3D _IOW(GPIB_CODE, 45, struct gpib_request_service2) }; =20 #endif /* _GPIB_IOCTL_H */ --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C83020298A for ; Wed, 9 Apr 2025 05:59:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178368; cv=none; b=UNYFWcD5d439YU75KxYJScYRvgErv2wYoI9GR+gfcNsW3rzpR4CqSsOTjNSYEy3HKdJQHfEpq3XOl56g0MpfTPnARnyWKVJIaE/0YqL927/eQyixe2aoYef4AwslKoyKkaEm8yNf2rh9bi5eGjzBsltkPBqbpod1B4YT9WjUer0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178368; c=relaxed/simple; bh=ccn7QRhDw+EYEW/P1wa8yWPi9uhOx/Hha/iN87ywVSc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Aai9FMc1c1y1f5UMQ7UiGpUkuyLWxDyVJgY8kGSoIfCBl8gph8h0udsALQjh7S1qgzozWzJ1p+fL9WoxWNJ7kFzYUV1voxw+LsVsGycKsmQrUbgxUM2DktGKCElXTNwHs8nvFWhHTy2Zb1JwZenvayWvpCnokA+LTLBRQ3ihgyM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=ZsjdCE7O; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="ZsjdCE7O" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2279915e06eso61096355ad.1 for ; Tue, 08 Apr 2025 22:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178366; x=1744783166; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y6aph6kY1Q0JnGg/8+NqO1BgZ3KPQfNwkBZFJNtVp08=; b=ZsjdCE7OLV9Ta1+do2r9iU/2KlTCy0/rzC5/tJF6h2xSBG9Pz3uVJrJ4SBk6zKTYuE fJrimjwS8aOV/FOy7KqJIV9cShxJESVBOB/eONNV+tUPV90dx60hw9jJZ21pO6L6o9xg i1YBLEL7AWsmNgetoh3B8N8oHZvUIl+zhpDrHNq3X+9R62vW0clVP8jto5Ccl3Z3LVcX 7qQkxkkFdBZ9qpRBhs/c37jggnA/2Qqk6DRQlp5yKJIHPBuCGdR8DkRpyGEX7nuV2jKu 1agrRN9Z9JitGy8v/PKMuchp/WdsqSUc/hVEiQypd8SAqSsE2fkOgd7bBSygC2wVFbUF sV9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178366; x=1744783166; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y6aph6kY1Q0JnGg/8+NqO1BgZ3KPQfNwkBZFJNtVp08=; b=AMXGd3dcYELsqFugKjI2AK+ysHoVF6AauzEPG3UKO0cIiqt2rQ993a0ybnFKUh8qTd cesgqc4IGLn3B2rusKQc0Csds0E5HHJMTS9v/iV9iQgf+Tyg98nAte2aqKqzrjXHArpg w158jYi7Fqu4IJwkLdZoU2/gwG9GZFmjLkDr3dDrYZbyDezMVGU7AgVqidAPDu1dKxOJ CiAPf9BI7eE03clQfMO7K/rrN8MYQQslWa1vcH3nFeSaULu0k/airitSMtdlCLXyiNf4 6eP3hGOyTpu0GfFtAHmTV8xMF+aS0EJVgS9/5ce8CHB4dExSyqDr6G21SO6Lg+oRdsB0 mFxg== X-Forwarded-Encrypted: i=1; AJvYcCWdIuhKZ6e9pWrEhQBttsMoauVIV3sw+1zJAhdkjQPEiNl7znVpQNvk0O2fT1If9vivYeelC9GP+89/Vog=@vger.kernel.org X-Gm-Message-State: AOJu0YwoQIxC2E/wEBT1Be3o0RC/XgVWHw97TYX49kVzwIG9dTHarnRc eZcXooZiibH0ETRwijEAp+B4wm6+3I4gKCCfY0gdMAfFP/TIE37UUVtsfTzhsw== X-Gm-Gg: ASbGncvbwwjwfAzS8RQ/xx0zZ8hQrf7Ci7CoQjBB25jeH0iEuicNCF4wwKoRt+VdqTH IJ/4w0cWWB4WVR8BFqMkL0vHwVVvDgKD7sgymyL3Y6QgCIJpawdgJH+IhFLSB4UpWobSggGtwAE hTF5xsgT3bQRX7ri6JLuYMV/BsJV73j8WN947b3L5ki1OJjvDYgNf5lwr3CUhYAdtFjqHKeFUwX qVGX5n62ADWgqEbjPOwKC7cnLGUpTHPO4wJ7Nq72pmHhNCtsSwk89zmFZMGccYSWGKERKV63LnH ktS2zaJNYe0cnCIsvDr1TzHmTBZY5FnE1fgmItS2KWpFNRyW40uhXKGDl7Vu4OrJa/CNmcJNz6w jDhXvHsKd+2JW43y7 X-Google-Smtp-Source: AGHT+IGGch8yL1pVWBFhHfO0hEOL9qHn2F0AElXSWwJ2Ijm2w1ytVe0bvHcbM1ZTM3Yu+6dAMy4qwg== X-Received: by 2002:a17:902:fc4f:b0:21f:68ae:56e3 with SMTP id d9443c01a7336-22ac3fee048mr21606935ad.39.1744178366661; Tue, 08 Apr 2025 22:59:26 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7ccafa4sm3372725ad.235.2025.04.08.22.59.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:26 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 17/21] staging: gpib: event_ioctl_t now short Date: Wed, 9 Apr 2025 05:58:59 +0000 Message-ID: <20250409055903.321438-18-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style to replace typedef event_ioctl_t with type short. Adhering to Linux code style. Reported by checkpatch.pl WARNING: do not add new typedefs Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 446827701399..72a9b660f124 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1951,7 +1951,7 @@ int pop_gpib_event(struct gpib_board *board, struct g= pib_event_queue *queue, sho =20 static int event_ioctl(struct gpib_board *board, unsigned long arg) { - event_ioctl_t user_event; + short user_event; int retval; short event; =20 diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index eea169a0ba40..e9baa6724fb4 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -107,7 +107,6 @@ struct gpib_select_device_path_ioctl { char device_path[0x1000]; }; =20 -typedef short event_ioctl_t; typedef int rsc_ioctl_t; typedef unsigned int t1_delay_ioctl_t; typedef short autospoll_ioctl_t; @@ -152,7 +151,7 @@ enum gpib_ioctl { =20 IBQUERY_BOARD_RSV =3D _IOR(GPIB_CODE, 31, int), IBSELECT_PCI =3D _IOWR(GPIB_CODE, 32, struct gpib_select_pci_ioctl), - IBEVENT =3D _IOR(GPIB_CODE, 33, event_ioctl_t), + IBEVENT =3D _IOR(GPIB_CODE, 33, short), IBRSC =3D _IOW(GPIB_CODE, 34, rsc_ioctl_t), IB_T1_DELAY =3D _IOW(GPIB_CODE, 35, t1_delay_ioctl_t), IBLOC =3D _IO(GPIB_CODE, 36), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D79D20FA83 for ; Wed, 9 Apr 2025 05:59:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178370; cv=none; b=T3RW5BKovdm6s6iLyQSZmv6sVzM2nXtzVf8CN/TXYkekVswaAKp2A/g9gpRVVU9qBcyIv1O2kEYS7ehTz91vdkOhugYJ47RR1r9q5PrOE6T8GP8WTxJiGf9/i3CLmu2eABoXxjrU3Cf1LccAuCi7LSA0PCNmvfM5nM2LRjZPCps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178370; c=relaxed/simple; bh=bnOEpAgszHqV183TiTZpNDLiDy5SjR9NqKMUBuyXQPA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mA6HexfHT8eqAIkg8o2LDBibfgshrr/BdxA6pC5k4EmLC3Y03QNu4glpOMryaCEot/0d5rutYsxMV5b62Eb527hw6dYiWkGkoszkHEx6IuLMsjxYXDFChDk9OTBDlX5GrJg+PsSF9NHGaC4KjE9gae6PXWkejNwRb7WMwqqkDfQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=kBLULcdR; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="kBLULcdR" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3054ef26da3so5092670a91.3 for ; Tue, 08 Apr 2025 22:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178368; x=1744783168; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kYW2NNA+2M0Vl0ws9Jg30Dh88lZBV/bMfWO6aX463XQ=; b=kBLULcdRuGY9W9Mqm08HxNFciVzEnqNQUibQ4It0Hs0KuEbkSQyFif4PphhEMqociN +iyD6xudWjCYRcBXv6mpyMRyHdaPboq9b2uK/Nt7Bu2mRUA6278oyCCo7hLcY8Q9Amsr oGstf5s6pZwfBaVyyKbs4zjnsPrr/LTV0HUAcb0iVbFFp1rQfjAE7/n8PwHu03wGZUQ7 djLaljKPhDpVbPiNKqEW8u4TOlpiVivyouTKgry8Dv13wJ0Z5gZcSmiFIXpj1Ap5zm6c uvS38a+peIfm051O/jmKCTkIFGMfMhQTSba5F9/EUI8YYz9J/4P7ILyqD3RxvEIoBSdg L72w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178368; x=1744783168; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kYW2NNA+2M0Vl0ws9Jg30Dh88lZBV/bMfWO6aX463XQ=; b=qM2k15ZOsLbyBeU4K+TUPCGuFhxoZOOdf9V8miD9TqwMVjf5xM8MPoqGD7MjBz2s6t cRLyj/IBTY5et7DH9gDruG72y64NyylDkR97cv99pKbISa8X5EKE7Z9wX90bFsxbyNY3 C+C5fSOM7Z0xr8IXzNipSdqWh78rHi5kn5tUemEMfPsMAPvqzO1bwjfCiTTbvBHzI0yM KGPLjKl3lhNSQJbeu3o9oQFWU0D3WdHJLzJ0q4i7bJbmYcMmUAgBTtnSOFFGn/5J4Puf dDnJi9Np4bOloBl8UmMy2yPv4ZpoHO4WY1SHaG+/xj/lG26V9JG83zNjm9RTNfpWFpNm kvRw== X-Forwarded-Encrypted: i=1; AJvYcCV3JC9eluvRPMZ4hQ4uR0NBba0pmgb2Y1WM6Jiq1bNNceKrqitUqeXIc0tkuQXc+Q1IdYx7QFCS1uFKmIc=@vger.kernel.org X-Gm-Message-State: AOJu0YwvDEiX89gqzsk0nAeOnro8hkPR0caxaozi/uy6GIBRxg17Mo0s DrxFOu545TwQ+fX05oJ6hjwFBTe26PZvHLB1ZUW/uNh/umUTmieoJS0DXYNS9g== X-Gm-Gg: ASbGncsm41nS1UPxJQRHWoCS8GCxQQrww+y+1AiA/P8a+sFaMz59xAMHsgCSes0tDX3 3+eAvduE9J0PaO5WkU6HOthUtIIRXeeXoHqJiycyP6kUzmmdg+lRLCW7UrhdOI+J9aTaKXeRz/x yCerU7vhaI7jVaeOWcgIrKa2enY/27F7avEexvh0TZvvGnp1jcTQMfvyWH54u9rX4xgwlibjMWl CISLxRyz1ZIgy8P/RLuLS9JORVv3sEF5/hg/euEDX6j8F9WR6Q4CDlP+Zjp5XXJn4n3GBZSk52l oxrNoq58T4IHyKbPdz/Cf+a0Aa2q1ZVees/intgCSVJnMGRCBq1tSF3vrcdKMtYgJxczT32hpSu 0CFm46ZwFctF1FqJy X-Google-Smtp-Source: AGHT+IH5y8Af0uSTY1F5xbiHQYDz87apb78KZQCQ9yxl1j2FzAb0ftWhM1s5X6lHV87g+rmitKGgBA== X-Received: by 2002:a17:90b:5344:b0:2fc:3264:3666 with SMTP id 98e67ed59e1d1-306dbc3e090mr2359719a91.30.1744178367850; Tue, 08 Apr 2025 22:59:27 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd12b599sm661785a91.23.2025.04.08.22.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:27 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 18/21] staging: gpib: rsc_ioctl_t now int Date: Wed, 9 Apr 2025 05:59:00 +0000 Message-ID: <20250409055903.321438-19-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style to replace typedef rsc_ioctl_t with type int. Adhering to Linux code style. Reported by checkpatch.pl WARNING: do not add new typedefs Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 72a9b660f124..6a2ceb7b0b59 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1970,7 +1970,7 @@ static int event_ioctl(struct gpib_board *board, unsi= gned long arg) =20 static int request_system_control_ioctl(struct gpib_board *board, unsigned= long arg) { - rsc_ioctl_t request_control; + int request_control; int retval; =20 retval =3D copy_from_user(&request_control, (void __user *)arg, sizeof(re= quest_control)); diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index e9baa6724fb4..c3d82b627210 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -107,7 +107,6 @@ struct gpib_select_device_path_ioctl { char device_path[0x1000]; }; =20 -typedef int rsc_ioctl_t; typedef unsigned int t1_delay_ioctl_t; typedef short autospoll_ioctl_t; typedef short local_ppoll_mode_ioctl_t; @@ -152,7 +151,7 @@ enum gpib_ioctl { IBQUERY_BOARD_RSV =3D _IOR(GPIB_CODE, 31, int), IBSELECT_PCI =3D _IOWR(GPIB_CODE, 32, struct gpib_select_pci_ioctl), IBEVENT =3D _IOR(GPIB_CODE, 33, short), - IBRSC =3D _IOW(GPIB_CODE, 34, rsc_ioctl_t), + IBRSC =3D _IOW(GPIB_CODE, 34, int), IB_T1_DELAY =3D _IOW(GPIB_CODE, 35, t1_delay_ioctl_t), IBLOC =3D _IO(GPIB_CODE, 36), =20 --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B201D211474 for ; Wed, 9 Apr 2025 05:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178371; cv=none; b=WfwuH7bamtUA2D+2VcbcEq7igY2i8FwGBcSYTQ3yZNwkmqjE3JO0Ta3rOJ3lA6mQrDRNjf12EjPLFElEsArmJqTSPaKqjR8LyLN6brMS7f6W1lyB0lN99+ydet3Wq/JQPlPQQj1mOzvqNTTaXZ1mGCqoMeEX4QmVVtbkWC8yXdw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178371; c=relaxed/simple; bh=6f9bCFgv3OgziEcu2USnaorTdNY1Gp/dioA6Ikmn/zk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q3cD3OUz/pLh3VYhXXX5/PIf2kKr+pVMy10amH6g8NqSv0Xv3x5T3f/i33Ke4tVLOqa8h1+DOGHDZWQ2pfI/1m7z4kulvXo2lAT9JyMdkETLSGOJtyLZUu/15UaX0rPe8pKHk8uyToC7W+PLahTVirS6RunqtSf4kIYO3/cwkYM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=mZXzloY/; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="mZXzloY/" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-227aaa82fafso54708115ad.2 for ; Tue, 08 Apr 2025 22:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178369; x=1744783169; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rp1Mnr/Ppbq5hd9yNv+1/H1q/VZaXkXrpCMjU4yauo4=; b=mZXzloY/0arKsKUTLKvO/rn2NfvZ7EdyA4o/c7GkQfg0eUCQqFUjXFh486rYdQ4MKf Jt+eBP/NTn/ir0bJxp4XAVHxtrJ2WqqlJCFDdWV84wkrrmOnD6YwipCyb512l90qzn4k 4HB5t1xznpTDH3ez6jPq6h/zgQkgltKQpYcTiIAPYP8n4GsEiswR4WKbpNmKQDpUp8Kt K8WoJsDIyKdnLqI6C11570N/WycqUW2B0VlIJu6xotbCVzr3qgFUTr6NW0BnGhmP4c0l KjEuKWDwtq92nIIbwoqixC3oeSTD15JKun+tJ9Aq1ALI5mnYiJXpU7ZMFU3uKQdFs6F/ xJSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178369; x=1744783169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rp1Mnr/Ppbq5hd9yNv+1/H1q/VZaXkXrpCMjU4yauo4=; b=ZcH3uPbYCJ71/B6qXfDB0Mc2XqWmj22Q0T3/ZQZ3AqWDwN21edY6WalbsBYyQoF06S 3EZ5Fc71Jf1Uoqe2WJleoLw5ql+mE8Cd0OZTrEpvc0qgNQshPgSYUPHFQomzoY0n2swo VRsPf0ZGaEo3a9SLMtt60EOZ6OC8HyqCbdrnoTHQ6KhYhRPIIXnTCm/zzcPB3U9Q+rMz 3Fb6Bj2JhU2v5be61mcRZOn9rz9atlMIHRGKh6Az1pUOwNhMDGhl4dsHT+VEnnDTulIJ k0L/dm/1RZCxL5P5O5/gZyc4bEQ1tLnoC+dij/LypXhW780EcG/IGu9FjryZUJ5e5MeE uk+g== X-Forwarded-Encrypted: i=1; AJvYcCWxVv9tY93VlyiGybxFpGDkeMdJ42133y+BnTL3jLcq/ZbWy95aI9FKzQ0jYYq3NxTdSNF7NR5A56zkKDY=@vger.kernel.org X-Gm-Message-State: AOJu0YxVX3scwQ32vhV1SGJIRlvVHK5dv9fUlyf1nzrH/ZLWC4oUfQaU CgxG1QWgU6eqdJGfdMx74OkYzmnbG/8PXH7G9dw6nlafTO1fFlRkLqjQHDSxnQ== X-Gm-Gg: ASbGncsG5kd/RCMIlp2SPqFX4UZljXyTx24HMmnwVhvZBwX4QxbSIrlytuJCTjt+mmB YfuG+abqoYlnmUCT+REZPH0rVC2HuubjLL8XlZi5HANh+I+xD2Dsi+DozCIZqd7Pbl7KDssi6FD F4fsqiw3EcWtrapLr/z6eK3HyDEIepNGwHTZQvveJnVPjj9yMG4C+MIKcHeyVTZi5I+8sfOLnZx lXXBTyF20aamTdDIbFpnlycfWD+G9LSocPFfuMOawWhI4nW2S8ALjLs6oQ9TAVRLVmxdkMJ8ncr PY09qTBHC3NSsyVfdh+QIeybW4WhjS3E/8jlKCglqsDnooHHSxF0MZsGfj6/0rrH4ZKGV9VJ1E3 XzytHVQ== X-Google-Smtp-Source: AGHT+IE/ChE6ZmnKHJDN/gdBW7rtlyY8iE7c889RlAKDvJomQgnBVhLKQ9OiwQiY0oUYePyahmH/IQ== X-Received: by 2002:a17:902:ccc8:b0:227:e7c7:d451 with SMTP id d9443c01a7336-22ac3f9a8fcmr25005435ad.29.1744178369126; Tue, 08 Apr 2025 22:59:29 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306df400ab7sm488012a91.47.2025.04.08.22.59.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:28 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 19/21] staging: gpib: t1_delay_ioctl_t now unsigned int Date: Wed, 9 Apr 2025 05:59:01 +0000 Message-ID: <20250409055903.321438-20-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style to replace typedef t1_delay_ioctl_t with type unsigned int. Adhering to Linux code style. Reported by checkpatch.pl WARNING: do not add new typedefs Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 6a2ceb7b0b59..d32f39ddea28 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1984,7 +1984,7 @@ static int request_system_control_ioctl(struct gpib_b= oard *board, unsigned long =20 static int t1_delay_ioctl(struct gpib_board *board, unsigned long arg) { - t1_delay_ioctl_t cmd; + unsigned int cmd; unsigned int delay; int retval; =20 diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index c3d82b627210..0403e285eed4 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -107,7 +107,6 @@ struct gpib_select_device_path_ioctl { char device_path[0x1000]; }; =20 -typedef unsigned int t1_delay_ioctl_t; typedef short autospoll_ioctl_t; typedef short local_ppoll_mode_ioctl_t; =20 @@ -152,7 +151,7 @@ enum gpib_ioctl { IBSELECT_PCI =3D _IOWR(GPIB_CODE, 32, struct gpib_select_pci_ioctl), IBEVENT =3D _IOR(GPIB_CODE, 33, short), IBRSC =3D _IOW(GPIB_CODE, 34, int), - IB_T1_DELAY =3D _IOW(GPIB_CODE, 35, t1_delay_ioctl_t), + IB_T1_DELAY =3D _IOW(GPIB_CODE, 35, unsigned int), IBLOC =3D _IO(GPIB_CODE, 36), =20 IBAUTOSPOLL =3D _IOW(GPIB_CODE, 38, autospoll_ioctl_t), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16FAB212FA3 for ; Wed, 9 Apr 2025 05:59:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178372; cv=none; b=HLe4F9vLHo5c0EOgrWxWNMWV7O7OVarrfnNgxrPeqqcWixkyKQNZwZNWWL3OOULncv/MvwWdfzdyu31Ia/NKxDRIz9JXsiu7mDzeuDh8pXUnLxZmOUCspr+LxysjKVBsuqqVzKuUaTpb3IyhQURSmaj28EX36vIURz2ly+z/ZXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178372; c=relaxed/simple; bh=WQs83mOR7EB3n9PAfy3Yp+mv+W8nVFvV2LX+bdPbIUU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JF7U0i5aUCxrEGFVH3D1d0JhGxl2RO8D5lc/T36P4i6S4av3wf5RbBf5bwbUdePBGDtHcbCzVNPE60S942VTyUiiEwi62RARQ1GX/SpBG4WFlu43Lg7nmaNv8DTCD4QUdHJ4/Tl8I1Lml0qtDKuyPyCf097u9XAWDzM3XbPsSRs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=fncHbIl/; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="fncHbIl/" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-736ab1c43c4so6185684b3a.1 for ; Tue, 08 Apr 2025 22:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178370; x=1744783170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5Hsam7wws3fV5478xYdqXaQim59fVQl8gj8lLUlEFKc=; b=fncHbIl/lNoOsvAfx8SCPT26xhLujZ7/2wJl9GCgH1SxRZBprhWgHsKk7HUiDOu/HA Dyd4P4PyjnXKcVCrcljFP17uVfRPahdFaLbyCphytveKI0m505ukx7QtyTiPhm00ZaSq EK/Tn6AsaIG9yWqHp6NSTC1dd5RRiCm1EmfPGpgLjQBOgYWDoP6Jg2T8CCSUyMzGBYjW gRMMrq5wEs74MJhCrnaHsitH7AbTSMSH/Uy5MmW7h+Aupwh6BgiRNY+gyWr4DqG2swSf k2uRqNv61EKANkGtCYdUUTnZHg+37fLUBhwnuhQDkIkkrzLSVeIAJ8bl1541iPTE16UU 58Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178370; x=1744783170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Hsam7wws3fV5478xYdqXaQim59fVQl8gj8lLUlEFKc=; b=OT5Sauchk78osamxvyJ1FF13QSfYe+6kXVA8fIg0WsFOr7e/MN8asO7qjOvl+lIA85 /t5R1+GprmNQnUroozgDZx89WbJg0H1P5DKcJy2nAOTbkfzS2NGRaLNRVH57+szzsKZ7 SxzxFwpiZh4+agVcSRtPShqPq3LNLXlRjnkGyGlCO3Ak9+TKGczcdpaafxyYSwKeOmNO lIQzJnrYmgD/U98oV0z0a9U1kYFQIxDwK3z4D9kZDG7oGOrB62ph6YW2mmFrQOCTvsMy +UplPq8e+ilxpkDy+0oJy/2ft/co0ELf6RX4hjllYcg2jH4Zhf52SKH5RVmHrHc80S5v Z9Tg== X-Forwarded-Encrypted: i=1; AJvYcCXaCO37MswEVTWcO/I3cNTPlrOsUwo9QoO2inNQpINc1qRuuEfTO4A5apGm6bi85pb648Hvdn3yLgA48v0=@vger.kernel.org X-Gm-Message-State: AOJu0YxJv4tyTM8wLK9wr8yFw/snFDrP7TA3cbLbhslkHMFbdxLCl/OA UmaLzUsM1TABeROHws7N9hidPzrlzJjl3X+yDhDYK2jBMUYTH7ONovl11mMoYA== X-Gm-Gg: ASbGncvXvGtZ2fStJ0sUy+C5ObqvkZnwecb6oCXGFdMW9JO37zPIiecqHwg6Ep1/I7G p7RRXLrIedb5U9idYYZUe/Pg8D/H5m1LFgiHhYaCVQ+f5G0LSFz+wqTramNd7+nMZQvnU/VBYs4 cj2uRYEADzthLOkwyg6S1Zwvzw0dJ/zQKKV6Ju6uvZ5VCPelWiw/8hnNB/mum9FD18nplnoQM1s payZ11fVe278PbplSVHBijTNiHocbPiglCQghebpe89BXjRluSKyh5SEQyaH8h4z75UGO/YWQ9r WG9E6aU6DoknLo4q3SF7377knNqhOGimkpoR3BGcQUlI/EQ7Yg4bZkuocr2XQLwraOtbwf6lFj0 i1riv5g== X-Google-Smtp-Source: AGHT+IH75nrpakEktCpqo3/kYdEUc7RDyJJvYvb0XEQUXDTdVYRKf7nF4TeIuxZn+th+xO8qRQFpCA== X-Received: by 2002:a05:6a00:10d0:b0:73b:9be4:e64a with SMTP id d2e1a72fcca58-73bafd6d5e4mr1628393b3a.23.1744178370326; Tue, 08 Apr 2025 22:59:30 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bb1d2a840sm430456b3a.7.2025.04.08.22.59.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:30 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 20/21] staging: gpib: autospoll_ioctl_t now short Date: Wed, 9 Apr 2025 05:59:02 +0000 Message-ID: <20250409055903.321438-21-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style to replace typedef autospoll_ioctl_t with type short. Adhering to Linux code style. Reported by checkpatch.pl WARNING: do not add new typedefs Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 2 +- drivers/staging/gpib/uapi/gpib_ioctl.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index d32f39ddea28..6a92562ae39c 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1600,7 +1600,7 @@ static int dma_ioctl(struct gpib_board_config *config= , unsigned long arg) static int autospoll_ioctl(struct gpib_board *board, struct gpib_file_priv= ate *file_priv, unsigned long arg) { - autospoll_ioctl_t enable; + short enable; int retval; struct gpib_descriptor *desc; =20 diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index 0403e285eed4..c66b8d59a46b 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -107,7 +107,6 @@ struct gpib_select_device_path_ioctl { char device_path[0x1000]; }; =20 -typedef short autospoll_ioctl_t; typedef short local_ppoll_mode_ioctl_t; =20 // update status byte and request service @@ -154,7 +153,7 @@ enum gpib_ioctl { IB_T1_DELAY =3D _IOW(GPIB_CODE, 35, unsigned int), IBLOC =3D _IO(GPIB_CODE, 36), =20 - IBAUTOSPOLL =3D _IOW(GPIB_CODE, 38, autospoll_ioctl_t), + IBAUTOSPOLL =3D _IOW(GPIB_CODE, 38, short), IBONL =3D _IOW(GPIB_CODE, 39, struct gpib_online_ioctl), IBPP2_SET =3D _IOW(GPIB_CODE, 40, local_ppoll_mode_ioctl_t), IBPP2_GET =3D _IOR(GPIB_CODE, 41, local_ppoll_mode_ioctl_t), --=20 2.43.0 From nobody Sun Feb 8 05:35:47 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45D3F2139B6 for ; Wed, 9 Apr 2025 05:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178373; cv=none; b=c9ygceQCN/bcbUq+I2x8EaaY8JePmnbD5PouzC9fNptAz3cV+q4RCxN5kRludvRzqRLwctlm1arxsXgpBM8RXWv5wk7rCALpmRnFvddYH8uRRFjEYF2AdL1bwJjHw5TWWJ/VS5L5BfZCyR960SWXEs7uw4yN/Yab06otzL5KT98= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744178373; c=relaxed/simple; bh=aXPhtRhaMr1ilREq00flcnfwj9TVbFWLuAjTzeOl85U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h088orupGJO3NZeuwy6yaNy2NmhwuUdh6QDkff9ww+v/Zpx6kQv2E/V1/O8rI8Z0bzMaLxk4J46LT2uoIo0Tepe4GamGbczGKGRcrv/FI0mJaS6Zekb6cUg2+HttGL18Rp6p+tI1HG5fSbEJf6eYDwjpfScPlVTv8MtRveVPD1I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org; spf=pass smtp.mailfrom=neverthere.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b=YPemqJjM; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=neverthere.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=neverthere.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=neverthere.org header.i=@neverthere.org header.b="YPemqJjM" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-736b350a22cso5689165b3a.1 for ; Tue, 08 Apr 2025 22:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neverthere.org; s=google; t=1744178372; x=1744783172; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RIu1dXNTYwl5r+9cV5uhg1+tHlwwvRGyoned6m5udoo=; b=YPemqJjMqb2Kn2T3HK+Wkw7bMyhQQxFH5TupOzPFQTX0v5mEyMkyqAixw/avzdurTH Uyantcv/wnQBJiA/3goJifIxOReZjS766R9RvqljjtV+dlGSqJVjhIJ/Bl4eVEr4K6Lc NB/6DmaKQf5sQQbRJ0EZUBL/9HvU6mOtZ6Qe42WfHb63EtSuXtrMWmok+dHtnk+GnWT/ VS1wKD/0vrNQiRGOLHEk0RX3N+ua3mprMXoQt8S6ME0TgybY1rZrrCHxMcWD5OA56LaZ bx8k+t7+H/hSEmVfcq1R5uFFsHEYpVdED9TM60Ce4Vok9Bci3o7OGnwnq+5uL9HxC96V nMHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744178372; x=1744783172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RIu1dXNTYwl5r+9cV5uhg1+tHlwwvRGyoned6m5udoo=; b=moUXptgc8FdDcJc+9C2OGpDngR8FexYndIt7o6OsOfJJE8bescWzn5U7KyI9CFm2Mn 6Z1edpqKqceBVqewaqP9KUyn1Ep8xr55b1EEmfjUqLmuYX9R0TVsxwYP5qxVEKMNyIPO j1qL3S6x5YbXVBA2NbOJw1Cm2O7XYhDLoAl3ctMkBOhQJCTK6n3Juz8i0rsH0ifkSf4a 2tgfAKDo8FlTBQo59iQxG52q/tTntHK2W/Yq3AlkDXE+KN1R5KNSsfWAitTX836tcPoa SCNBYmOf1P1fIPnKkBOMW67Ogj1+xi1mhqsH9qs0JJoGzqb6u8IR/V6AhqfsIehX8bRf EKYA== X-Forwarded-Encrypted: i=1; AJvYcCU7EvTDfR1zkknHHdmzPupsHw3c1bvTjc/frdbQIHkP5q6LSaenPLtxKK/UUR8CYNIKdXQnHuy137GOfgE=@vger.kernel.org X-Gm-Message-State: AOJu0YziplLtfxUZOM8UHWsyEbQ35gL5ODwydSHDzIgT4ce2LFWUgjGQ wvHBtpCp5WEzfNz75cMMMBUJyLi45wq3Zg1fcks0ucp76lBUn3wUcRFNLYcxGPzCxDm8h2oE/OE = X-Gm-Gg: ASbGnctIv4EVYEplWGhasJPSoRNPJG5mVwAun1Bye7tFE6rg5IYjoQUYi0VvxnOp7GJ GY2THIWVc9XPPM903W50YdLuJnayVX9XTJed84vRfLUfJO7egmCQAl9naGSOfWGPo7A7lCiqgTT E3LX0VzjyjUo8tjB06aaq0TiW92oAgtRhx9OWeZUHEaVJUvVPBalnmBDkVad4/OZMpm3EAznISz 4561tSAtUAJuXJhuwhtdiioT/CygWU9maUz4jcuu8e9SsncVpC8WDEidaZzEHu9hABPe/TudFFS SfikwoDCKNzi2C3eWEw1SYmzGkiUhx94u3hqn3J2h6JqSz6N+l7u3yzGX9isgDt34hv0AD8Htuv pPkhdTw== X-Google-Smtp-Source: AGHT+IEo/rej9w7R9G6fsBL4lZri+tY36Xc58KKxG1xuULe4YRg62fI+jLm3m+YZ4Z6XWF9E9BAf/g== X-Received: by 2002:a05:6a00:39aa:b0:736:5753:12f7 with SMTP id d2e1a72fcca58-73bae49574bmr2559782b3a.3.1744178371587; Tue, 08 Apr 2025 22:59:31 -0700 (PDT) Received: from tiamat (c-69-181-214-135.hsd1.ca.comcast.net. [69.181.214.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bb1d516e9sm430158b3a.44.2025.04.08.22.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 22:59:31 -0700 (PDT) From: Michael Rubin To: gregkh@linuxfoundation.org, dpenkler@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Rubin Subject: [Patch v1 21/21] staging: gpib: local_ppoll_mode_ioctl_t now short Date: Wed, 9 Apr 2025 05:59:03 +0000 Message-ID: <20250409055903.321438-22-matchstick@neverthere.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409055903.321438-1-matchstick@neverthere.org> References: <20250409055903.321438-1-matchstick@neverthere.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using Linux code style to replace typedef local_ppoll_mode_ioctl_t with type short. Adhering to Linux code style. Reported by checkpatch.pl WARNING: do not add new typedefs Signed-off-by: Michael Rubin --- drivers/staging/gpib/common/gpib_os.c | 4 ++-- drivers/staging/gpib/uapi/gpib_ioctl.h | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 6a92562ae39c..7d0c03ebe624 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -1718,7 +1718,7 @@ static int ppc_ioctl(struct gpib_board *board, unsign= ed long arg) =20 static int set_local_ppoll_mode_ioctl(struct gpib_board *board, unsigned l= ong arg) { - local_ppoll_mode_ioctl_t cmd; + short cmd; int retval; =20 retval =3D copy_from_user(&cmd, (void __user *)arg, sizeof(cmd)); @@ -1735,7 +1735,7 @@ static int set_local_ppoll_mode_ioctl(struct gpib_boa= rd *board, unsigned long ar =20 static int get_local_ppoll_mode_ioctl(struct gpib_board *board, unsigned l= ong arg) { - local_ppoll_mode_ioctl_t cmd; + short cmd; int retval; =20 cmd =3D board->local_ppoll_mode; diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/= uapi/gpib_ioctl.h index c66b8d59a46b..e903ec1fe274 100644 --- a/drivers/staging/gpib/uapi/gpib_ioctl.h +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h @@ -107,8 +107,6 @@ struct gpib_select_device_path_ioctl { char device_path[0x1000]; }; =20 -typedef short local_ppoll_mode_ioctl_t; - // update status byte and request service struct gpib_request_service2 { uint8_t status_byte; @@ -155,8 +153,8 @@ enum gpib_ioctl { =20 IBAUTOSPOLL =3D _IOW(GPIB_CODE, 38, short), IBONL =3D _IOW(GPIB_CODE, 39, struct gpib_online_ioctl), - IBPP2_SET =3D _IOW(GPIB_CODE, 40, local_ppoll_mode_ioctl_t), - IBPP2_GET =3D _IOR(GPIB_CODE, 41, local_ppoll_mode_ioctl_t), + IBPP2_SET =3D _IOW(GPIB_CODE, 40, short), + IBPP2_GET =3D _IOR(GPIB_CODE, 41, short), IBSELECT_DEVICE_PATH =3D _IOW(GPIB_CODE, 43, struct gpib_select_device_pa= th_ioctl), // 44 was IBSELECT_SERIAL_NUMBER IBRSV2 =3D _IOW(GPIB_CODE, 45, struct gpib_request_service2) --=20 2.43.0