From nobody Sun Feb 8 04:33:44 2026 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2054.outbound.protection.outlook.com [40.107.94.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1EC71DE8BE; Wed, 9 Apr 2025 05:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176932; cv=fail; b=u2fzCLfydbw4pnaxO2RNEzxxNKef+qkMxPVkDYRsN2LI/E/10VGhrVw1Aol6dl9K57H017cHb6spfEwskiYqE69PdHWTgNCAvBqIgEjeXGYt5imDxNl4sYSj5Rc3YwAlRc42Oi8lYJqwHnvWtdiEfN1GkQuolBzp9SPozVLrawg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176932; c=relaxed/simple; bh=KoCzauALSNFlQV0QLANKavLjEfqdOa/anecedhSeu24=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QnAPNAdQ/mVmgOvANxINbmo9CqlbyPnj84+kzQDGnbqXN9Eh3LDnsJcx2EMtj6RjHs05HpUoC9kkiGEkQ0At7A7MsPYZjrHXwJ1D5r3qpD/t/r8GnPnkLvsnUdNstSU3RvLjHOa/1jcM25rGRxh7A3vR/W8EtkdJj5/Ks5PjTVE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Oo4g/yqc; arc=fail smtp.client-ip=40.107.94.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Oo4g/yqc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hukLKAOCXnGo32Si7xFno+YEtv9PltTeleIm1zgM0+hV/1ljK+0EV3UNXrEy/47MGmdfYxS082oA15PC++eE0dsmMYOIZZZP/Qa+G5qIul9FdyDfixiuiFVwbFON5vHJKl+h9cFUfWs8lbzjeX8Dfzy81IfS9TjHJtrUhLadbAKSF20kP3NGAmxg2IdenJckMGW3XUcuKpteBtB9+4/ypd93NRi2/pf+mkgXfQTisPyg7cE7vl/ywSbbij2QBkAxUDKOtiWsnHTZp6GpIy859A6xim/hs7/TnAS1uO5br3/gE2HyZPIaj3Cm5fcHA5jwE3lKeu1DVvZay+7Uaj061w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Z5IuqlIlYFiC4oC0vmVqbtKJHcRr0/edZ+MJUI6tUg=; b=PZ2JK5gbAi27y4SFFXZFiEtVnJuvMukHNv4MPKKrVjUZTTrWabUFaWBeQpR9cxAGdghQ93Eci8zQRaepuRGh3D5IAplWjiskAxIihFVIKzIbsU4RIymrNfaBdd4Jr8UvokwIe27mo1/jN9ZaIkSKLqJsOCWMzsLpbLTCKN7sjBGcR3+wPtdz3wIK9boRt7WU+yoGftVh6eGBk67nAjX6r0YZwMSPhtd7Yud6uN8/E3ulCzwLiToSbllWiUlupjoELzItriw4zZCpinJbLbVNA270Lni4UvwZlNsG93ov8nbGGGbOAxDizVZWjNW/WmOC4dsaI0ePamvHPwGrUO9Zxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Z5IuqlIlYFiC4oC0vmVqbtKJHcRr0/edZ+MJUI6tUg=; b=Oo4g/yqcO+JvmgKObUe+QS0X2zp/stsgp/iNRjY//Kl+8AY2nBRGh3ZswKo2Q2t7n7zRwJ11WIiRzO3iQ6x1/XATwhIg4BKvJwb3CNUKZNQSQ3WzL3mVqvB/XDzBoEiCx/7NJ2VicqiMt6voeC9AhX3ECmJ/jZic8LBrAElc8YQ= Received: from SJ0PR03CA0215.namprd03.prod.outlook.com (2603:10b6:a03:39f::10) by CY5PR12MB6551.namprd12.prod.outlook.com (2603:10b6:930:41::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.29; Wed, 9 Apr 2025 05:35:26 +0000 Received: from CO1PEPF000044F4.namprd05.prod.outlook.com (2603:10b6:a03:39f:cafe::a0) by SJ0PR03CA0215.outlook.office365.com (2603:10b6:a03:39f::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.35 via Frontend Transport; Wed, 9 Apr 2025 05:35:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F4.mail.protection.outlook.com (10.167.241.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8632.13 via Frontend Transport; Wed, 9 Apr 2025 05:35:26 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 9 Apr 2025 00:35:19 -0500 From: K Prateek Nayak To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , "Gautham R. Shenoy" , Mario Limonciello , "Rafael J. Wysocki" , Viresh Kumar , , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Swapnil Sapkal , "Dhananjay Ugwekar" , Huang Rui , "Perry Yuan" , K Prateek Nayak Subject: [PATCH v2 1/4] sched/fair: Use READ_ONCE() to read sg->asym_prefer_cpu Date: Wed, 9 Apr 2025 05:34:43 +0000 Message-ID: <20250409053446.23367-2-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409053446.23367-1-kprateek.nayak@amd.com> References: <20250409053446.23367-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F4:EE_|CY5PR12MB6551:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a8ec31d-1216-465d-31ef-08dd772854d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|82310400026|36860700013|1800799024|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Qtve5uUpTzzFv9yp2sppvnaCTS5iu9KYrcmPeFM55prxG/pL+PK+zg9NRFgV?= =?us-ascii?Q?vUFCVu0uPkqYpoh9LDE692Diaj4iJXwCqY/CVQRFfK0F2SY2GL8+gpje/XwD?= =?us-ascii?Q?Y5LAKTGYANA4wE5Q/ILBM9DM1bzGOcHozd0YVkaEu2lSDzAkQSx4dohVj1j7?= =?us-ascii?Q?WcCL4c8tGcr/jHMalBEJNbBhI5aTnLf1F1xrMtI+a/Zt6tjXirg8ppBuYOtk?= =?us-ascii?Q?LeLydFuWp2A/X2f7wWhVgbIvucdLUKmfQ9x3dMWvqROhGNv3WsnWQmYobT+g?= =?us-ascii?Q?xmj6cQyZmxpX1U1oATAiLRt0klpzzNejfQfEt/FyhIglPtVmb7nifMslQ/5/?= =?us-ascii?Q?Iplc13IiCpBlAnJC/4kOLhjxT8W19hiu3HBN7YztuX5JXudLOyTWeTlVhp6Q?= =?us-ascii?Q?ZF+xBMQuQ6RTw2inakhhD51/mrHPYqX9heYeGeW3bxxDbDOSx0ewGsodaj1h?= =?us-ascii?Q?GcClv1MkiuVyc2AoX308SOc7lwuWhG0qg7R6WZHkRR+IetJHokKGm7Ekd8lj?= =?us-ascii?Q?vizYYRnlcgr/m+RNkZdCtDwvRMXJP54fgTPHSYACb5qwjWZvP8tAim2i1d0c?= =?us-ascii?Q?2jGF1Bz/A5bUEDT/9d25RL+9M0Qgl3QBkqk4YPIUfTknFiKd32c9kLXu4bMl?= =?us-ascii?Q?mmRuIZTpKgfZnV0h/wHChY47zGQx4w6uNoJRQxabMEHmF23I/9ocu72VpFBN?= =?us-ascii?Q?zI4UJiiJsVWoEHCxjjuS2RchI4z0Q8dhJY8FDOCJ+ZesrnNMIYc3ffMFLGsx?= =?us-ascii?Q?NYOSMoXHtRqjR6P8B+TNBfeLrA7PNi7D3IW/dL0Meb9vC/KCCdvC/7zDtA6r?= =?us-ascii?Q?cFvm35Xvje+A5QS624puC84NtaKIyiP9bE5MylgrTXoqu+E0vhIULGk6an46?= =?us-ascii?Q?1mCgkH0WPvMDnaQwKkvCZiCzNcwgpUZyCn+Dt7ndowntEQipEGbmUBVMalhe?= =?us-ascii?Q?D/30cuZXau8lsfNBplhNZFiNk7FApB7XoEjh8xZ5eWWCkLawqBvMRK9YIwVq?= =?us-ascii?Q?GoP/IakjcL3PT2w3U0eDopB2lZW3ELr3a35XQISeEGnx+6qOv/m1+mf28ez5?= =?us-ascii?Q?b/c7vZIi5aD0ORAiWVx1WpMjb6ToSH3MAf9J+jkbISq8+AldFDzm1BwDy38d?= =?us-ascii?Q?ONPxtTk9XiTnybxRuy89w/bbm9WLbp9hpQ1CaGOKh96iqgJ/JDdk0wyXTRN5?= =?us-ascii?Q?unwreWS2aZicr2QhQHWGL0ds6XK5VUgr70iA0uGVSAQ3RFTvyOSdQycKu/XL?= =?us-ascii?Q?qocveTNjUopZTJmOkajqOc3KUvH0FSsI7tHOSYMoukVIomnGKfPsT4g6wKol?= =?us-ascii?Q?b2sg7kgFCVvr2AB3QScHMc+G9fN6yjkDvPKEK+VcXMhvlT9f8YmdRcIenNgb?= =?us-ascii?Q?gKPr51nHOeDytneuWc/xS9GN0vO8SVv0X+Aym+6FjdAMTzbmuaTtTAfcrxuV?= =?us-ascii?Q?xcxxJNWgGa5h1Q6eRe1zKh/rLmUODsUY1xePT0eYtU8Q1YX65mRuakg2UKv6?= =?us-ascii?Q?C2vU7g6Ym2u3T24=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(82310400026)(36860700013)(1800799024)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2025 05:35:26.0924 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6a8ec31d-1216-465d-31ef-08dd772854d8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6551 Content-Type: text/plain; charset="utf-8" Subsequent commits add the support to dynamically update the sched_group struct's "asym_prefer_cpu" member from a remote CPU. Use READ_ONCE() when reading the "sg->asym_prefer_cpu" to ensure load balancer always reads the latest value. Signed-off-by: K Prateek Nayak --- kernel/sched/fair.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 0c19459c8042..5e1bd9e8464c 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10251,7 +10251,7 @@ sched_group_asym(struct lb_env *env, struct sg_lb_s= tats *sgs, struct sched_group (sgs->group_weight - sgs->idle_cpus !=3D 1)) return false; =20 - return sched_asym(env->sd, env->dst_cpu, group->asym_prefer_cpu); + return sched_asym(env->sd, env->dst_cpu, READ_ONCE(group->asym_prefer_cpu= )); } =20 /* One group has more than one SMT CPU while the other group does not */ @@ -10488,7 +10488,8 @@ static bool update_sd_pick_busiest(struct lb_env *e= nv, =20 case group_asym_packing: /* Prefer to move from lowest priority CPU's work */ - return sched_asym_prefer(sds->busiest->asym_prefer_cpu, sg->asym_prefer_= cpu); + return sched_asym_prefer(READ_ONCE(sds->busiest->asym_prefer_cpu), + READ_ONCE(sg->asym_prefer_cpu)); =20 case group_misfit_task: /* --=20 2.34.1 From nobody Sun Feb 8 04:33:44 2026 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2070.outbound.protection.outlook.com [40.107.223.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C76EC1DA31D; Wed, 9 Apr 2025 05:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176952; cv=fail; b=ukSMC+jG3QJxNtOr+UAET7rMi021U2v2ehgOFBv8mKDsKZ6BFeQw1W6Zik/UscDkIHyKmNJ1FLtKv3hxZxf/MJOTRq/qsuPliQdKEwnuvR1UTES7Ae+NJ4CgPU050JXgVfzFZe2Q2g9sArLkY6xOLa4MdoGKFCDTifq5joDTW/Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176952; c=relaxed/simple; bh=ch2OO2uTFB++vKi2+f1AmC4xBJXbFwWRLby8k++DEiU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=d342Mmc+wKq4lHa+wKcwGhbpe8j9de6wwyNl/oCAuWodGwziOVb592PW1otUDo5DdPcpXmYOCk74LOa2yfSeqI00saSLkzb36I9o7oat1qG63MqQuhDkw7bxd+oYa0+kANQAVdISienqGeNB5l48nAxnYagTrTP0WSloyV1/oVE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=KAp9ECwL; arc=fail smtp.client-ip=40.107.223.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="KAp9ECwL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PiLYbBsIImWNERnKOKH69jIla+kTktNKt7HKWpQAn84TeYwTtqJwlglFsjWWO+usrCmX70CzsRIX87jD13w9AfZAJUZTo5j4DGCq5k4LmxWluntxFSGdXjnug93XMWcx/YEVdkEFTuByGjmB8vgHClRV8X9U4eTnNsSlyZsp8AUkxrdcU5a767DqDzYwhCN/DLugJiRtBt7qxzuzznDCNpyyemCzmaMZY3cOx9sUrsKO2N/12Z372+0VPCAwtkzJ2ljhZIZwVwdm++gqNgZZ2RdyblRvIliox9OypiTp3WrI1WYIdChTdSTakfKffEzXG6Hq7cScp/5pE3FE/g4kTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ILSpoY+KJ7iz7AV48G5OaYYYNNxC1jjMGxxokpXzcuI=; b=YDhBgmz9vTOuZfJG78iyBYwz7J9wpLCPR9aXvMbDqAsELD48U6ZaUD+5dKUOf3WmM0yHieQhgDh8hBZDvUxE7l1KieMcfjQ9NxoBogafsjCDgX355vhdpSQBAaWZ2GQFtkt0VrLXs/b+yNQeBnbbNqN46dO86scVzkQ/MvBwsxiNfnkCqOdPz8Ke0E5zVOKbYlosnJSLWBCYHxTTAreakpjBCvEacsSM3/pBaxX0Cf06qXEWJXZrecYVf/xE5FnCyxfmf4pYamD735ypJFFFmmrzgR8PEV8Ka+4tTNWxDwlseSuiM3s6zeA4D8tHRCk2vG7t2HQu2hZHlaAtf4zYCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ILSpoY+KJ7iz7AV48G5OaYYYNNxC1jjMGxxokpXzcuI=; b=KAp9ECwLFn/n0bAPEwjcN21meoXO+AnNFgHuaCnDMssqqlc3toja/nWIc8nAOMSXU8hJXVxiG6ldhISK9tkIrHRiMFcaVJF5yog7WT2QClyxNqlVCXthui1ob9g3lRgtUjv7I+3xUOaSRBZscmX1z+jJfNx2iH1bJYhdcSQ1e3k= Received: from DM5PR08CA0039.namprd08.prod.outlook.com (2603:10b6:4:60::28) by LV8PR12MB9418.namprd12.prod.outlook.com (2603:10b6:408:202::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.20; Wed, 9 Apr 2025 05:35:47 +0000 Received: from DS1PEPF00017096.namprd05.prod.outlook.com (2603:10b6:4:60:cafe::7e) by DM5PR08CA0039.outlook.office365.com (2603:10b6:4:60::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.28 via Frontend Transport; Wed, 9 Apr 2025 05:35:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017096.mail.protection.outlook.com (10.167.18.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8632.13 via Frontend Transport; Wed, 9 Apr 2025 05:35:45 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 9 Apr 2025 00:35:38 -0500 From: K Prateek Nayak To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , "Gautham R. Shenoy" , Mario Limonciello , "Rafael J. Wysocki" , Viresh Kumar , , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Swapnil Sapkal , "Dhananjay Ugwekar" , Huang Rui , "Perry Yuan" , K Prateek Nayak Subject: [PATCH v2 2/4] sched/topology: Introduce sched_update_asym_prefer_cpu() Date: Wed, 9 Apr 2025 05:34:44 +0000 Message-ID: <20250409053446.23367-3-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409053446.23367-1-kprateek.nayak@amd.com> References: <20250409053446.23367-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017096:EE_|LV8PR12MB9418:EE_ X-MS-Office365-Filtering-Correlation-Id: 334b92e8-d2ff-4fb2-d10a-08dd77286047 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?c/jkuA3i9ySLKpNiWc9C1wUmKGtpq57QX7N93VZ0iYGGNspcLcJFqNb8Fnju?= =?us-ascii?Q?01fVagu2mXFOKUmxcENDkNGkxc3fsCPBlYhPHyt2+vZNJt+GAoHts6+ZhIRM?= =?us-ascii?Q?Eod3bvHzmJikuMMzHqdG+rBtC3pa8/BVYKPnwyQX7wrmdvnp5ngloT1wGgVy?= =?us-ascii?Q?oUUcL5jhLLrpjGXH1trSkJmurAi21aYzIpQ+XSUjyA1At0UiIoTTPmCNb7UN?= =?us-ascii?Q?rygJMtiFgItZxIORT68mOl6olHOO0I+UMTTJnzt7/rwSWXe4ozcrkzSQxaaF?= =?us-ascii?Q?XUUZNafTfFgV/0PCF55oqpR8nlTlr8WsIYmDHyG3pRCB5iUTpBPCF6QDFJRZ?= =?us-ascii?Q?im9EG2SDc3uiKzLYSnXmsEROcEpCFfKPeguah7p/L+P6eDDMzVfxu+FtYRXr?= =?us-ascii?Q?1i0KGL9d5b7S35lZHjnJWqfu/AsORla+S6ZS00rtby7TVPDxk823dTMNLekL?= =?us-ascii?Q?xVnvXifWJfoWX5rS2QM0fgIn/feZ8bb5GvbxwHmstpLzIKkTFKhjhP+D0lmm?= =?us-ascii?Q?yYpUqwY/D11uRdR0px6b49RPao4a2IPFFod/KmHWi4CzvBZUVxbwSmbU8hmY?= =?us-ascii?Q?b77/JWWGzMb7buE+Xgz63BMEtAALfk0Zg+cRCcknUs0/Q8IG8KkBVtEG1Beq?= =?us-ascii?Q?eiEQIjCAoYU/HyQdx0/gRAgKRPethfGlv2fkHp6iYeit8XskV5KjkFYSzAz6?= =?us-ascii?Q?StdizHBjGwSeaLlIr27Gm5lON11+YA7kQMQzD6k7Tr3pAchsF7p7c22YuVd1?= =?us-ascii?Q?qUbXKPhVKdn5OXDbgSlhmrF0YM95cdU/6V7V7A1gN+oEpKPXSfF+WPjKYpi8?= =?us-ascii?Q?S0ygGvGWTurozk6vWHqGL1XXFnRahZ9JidMtafRzUNOWxLEUmOYlGtyi1oT8?= =?us-ascii?Q?XCZ3ZzeVwJ9ERBUGN+mMpoUrIivWG37LW15AxeSks63tP+jDK2JwKaGUTyY6?= =?us-ascii?Q?CRZHOOCV3dBYk8FCownd81BgcOtxCE0A0QLLWrMqX0QfPvawCkqB00e2TwYA?= =?us-ascii?Q?78ZknisWaOUJHFk0wIef49bsD3euS+NdnZGkH2/Pp1f4XXezzeeD584bdNqP?= =?us-ascii?Q?4ig2et/VXNDGR6XRUK6rLyWy6n78h3iYhOKxiU82OOth+HU4sGLaup+siNEK?= =?us-ascii?Q?2jBH6p8i+nN+FnjpP1oRNV17aHaVjsnesG8EnYsqVoJnv4CTN6odY+5jvFcU?= =?us-ascii?Q?0jvPmZTHivgS0CC3vclZj9FQfElmK6OkbrGyIU5L3Kb8NEK6afy9+/Z8/JvV?= =?us-ascii?Q?T+QWe7qlpD73GURIDvd340bQAEwgvWLt0ff9bR/z370dGupff5jWhBZcqllO?= =?us-ascii?Q?05QPU7VuT9zlThZqO8sekJY9g1E+k1TGNUNPZqylt4jz/SfKovNDxB4XOAJJ?= =?us-ascii?Q?lknSA8gsknnU1jnPrifun5sfL+oObQK0w8qyAHRnDoZEsuddhNbUhbCHjsP8?= =?us-ascii?Q?OxcDHloqJbXx0nvGaIMKhD22EU001RKeksp5APzjbD1w8Oy4bZg/UGj4vL0T?= =?us-ascii?Q?yR5JlKRX4SzosZZBFY+q5s3pVFIqgHKfX2ziDvYFALSaT6ZOks8BzhM6hg?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2025 05:35:45.3257 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 334b92e8-d2ff-4fb2-d10a-08dd77286047 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017096.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9418 Content-Type: text/plain; charset="utf-8" A subset of AMD Processors supporting Preferred Core Rankings also feature the ability to dynamically switch these rankings at runtime to bias load balancing towards or away from the LLC domain with larger cache. To support dynamically updating "sg->asym_prefer_cpu" without needing to rebuild the sched domain, introduce sched_update_asym_prefer_cpu() which recomutes the "asym_prefer_cpu" when the core-ranking of a CPU changes. sched_update_asym_prefer_cpu() swaps the "sg->asym_prefer_cpu" with the CPU whose ranking has changed if the new ranking is greater than that of the "asym_prefer_cpu". If CPU whose ranking has changed is the current "asym_prefer_cpu", it scans the CPUs of the sched groups to find the new "asym_prefer_cpu" and sets it accordingly. get_group() for non-overlapping sched domains returns the sched group for the first CPU in the sched_group_span() which ensures all CPUs in the group see the updated value of "asym_prefer_cpu". Overlapping groups are allocated differently and will require moving the "asym_prefer_cpu" to "sg->sgc" but since the current implementations do not set "SD_ASYM_PACKING" at NUMA domains, skip additional indirection and place a SCHED_WARN_ON() to alert any future users. Signed-off-by: K Prateek Nayak --- include/linux/sched/topology.h | 6 ++++ kernel/sched/topology.c | 58 ++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+) diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 7b4301b7235f..198bb5cc1774 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -195,6 +195,8 @@ struct sched_domain_topology_level { }; =20 extern void __init set_sched_topology(struct sched_domain_topology_level *= tl); +extern void sched_update_asym_prefer_cpu(int cpu, int old_prio, int new_pr= io); + =20 # define SD_INIT_NAME(type) .name =3D #type =20 @@ -223,6 +225,10 @@ static inline bool cpus_share_resources(int this_cpu, = int that_cpu) return true; } =20 +static inline void sched_update_asym_prefer_cpu(int cpu, int old_prio, int= new_prio) +{ +} + #endif /* !CONFIG_SMP */ =20 #if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index bbc2fc2c7c22..a2a38e1b6f18 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1333,6 +1333,64 @@ static void init_sched_groups_capacity(int cpu, stru= ct sched_domain *sd) update_group_capacity(sd, cpu); } =20 +#ifdef CONFIG_SMP + +/* Update the "asym_prefer_cpu" when arch_asym_cpu_priority() changes. */ +void sched_update_asym_prefer_cpu(int cpu, int old_prio, int new_prio) +{ + int asym_prefer_cpu =3D cpu; + struct sched_domain *sd; + + guard(rcu)(); + + for_each_domain(cpu, sd) { + struct sched_group *sg; + int group_cpu; + + if (!(sd->flags & SD_ASYM_PACKING)) + continue; + + /* + * Groups of overlapping domain are replicated per NUMA + * node and will require updating "asym_prefer_cpu" on + * each local copy. + * + * If you are hitting this warning, consider moving + * "sg->asym_prefer_cpu" to "sg->sgc->asym_prefer_cpu" + * which is shared by all the overlapping groups. + */ + WARN_ON_ONCE(sd->flags & SD_OVERLAP); + + sg =3D sd->groups; + if (cpu !=3D sg->asym_prefer_cpu) { + /* + * Since the parent is a superset of the current group, + * if the cpu is not the "asym_prefer_cpu" at the + * current level, it cannot be the preferred CPU at a + * higher levels either. + */ + if (!sched_asym_prefer(cpu, sg->asym_prefer_cpu)) + return; + + WRITE_ONCE(sg->asym_prefer_cpu, cpu); + continue; + } + + /* Ranking has improved; CPU is still the preferred one. */ + if (new_prio >=3D old_prio) + continue; + + for_each_cpu(group_cpu, sched_group_span(sg)) { + if (sched_asym_prefer(group_cpu, asym_prefer_cpu)) + asym_prefer_cpu =3D group_cpu; + } + + WRITE_ONCE(sg->asym_prefer_cpu, asym_prefer_cpu); + } +} + +#endif /* CONFIG_SMP */ + /* * Set of available CPUs grouped by their corresponding capacities * Each list entry contains a CPU mask reflecting CPUs that share the same --=20 2.34.1 From nobody Sun Feb 8 04:33:44 2026 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2046.outbound.protection.outlook.com [40.107.237.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82DEE1DC997; Wed, 9 Apr 2025 05:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176970; cv=fail; b=LhJrR+uLhsJ9ptPZefEPRzMnouZCWdrDccfr2NKKcL/+dyG5a+XxJYVbsGeuf3J/5mJgEAo6uCBx9azc0u/at+QRhuXFR7iCvlgNw0j/a8QOUNoEjXmnG+W42XIjtuIg+Xcmhaigy9LhVZA70nZKNvJa8moMf3ZT0SWVY855lSw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176970; c=relaxed/simple; bh=y+sJw537O8n3vIrVlJl69hNI1eBuTPGxEljugiuRmQ0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I078SEKZ/In1kIPNX+TzCHqmRPWF/DFDBKZGhnekO06YZjqLn8m0wwJUot5hBU4cyepNiNTRL0FU2+lYXE4sZoPPO8OSVDFIWVux3cnn0spRJUJK3i/qrEsUX2KQKiGnIgOp5b1UrvLHm7NkfZJEOyKDBK5SLVgPSHkMG94XUhI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Lm+afrUU; arc=fail smtp.client-ip=40.107.237.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Lm+afrUU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k2ytAyneDZzV9p+MRhIosviEQ2Up3sT3hAqNyQrdBzM0HABr2ixgh/59vF93KzviSlh1GRyqETLQ3Mu/hd5eFXjp+5jHM1eqhwRm11sX0Lld7uukdZ2i0htpWmykoroFQM98q+h11Lkoj/95Sri3Ba26/9uBZMBXlZylXe48YTxNeEaumdTzG3aqdmVEtrmrobWlJBbbg4AJ6omId2HKsOBp/whmdGTE3mAIzhLIQDmDkEbr7wdw1MmMHz/N6ORJb5gTq3Oa/FGEr1DutKQuXVjun1tnXt4PIogG6R0SHxncf2QND0EMWBd3ru+ONpWLnJwxU5aRplVrlPG4UvxG9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ttk1oyF3cF9zozJAhbovrdjff2WZS52rLspuN3uMrrU=; b=eOcMkl+TAInYUX1cGKq4BQWnZU/ECcLT2RC0dv/kYtLvyDMBE+Hyeu2DzluKrcmMdjjK4ABl5/f/NIP5+lZVKDFJApZsIBhzO2gpQp8I4n9+Km/P0Z/q0ygLgQkciMUONh81SqSKvmuse5P1JqPhWtHB6nHcpvVAXVGaYNNSvmcNFKBGxlge/TG7D7WJntaMbCXUAd6ZHFBWGDAY5HLzIb4DfBaAi4bIUvvdQ31Kbkh3YPQqt2geETTyJI2KSAupcMJvZ09gKwfk5ASrFTjTbj2nfgwiR80XyH3paw6rFjDG+XsxnrlaajrrV0Qn/HK8DU+Gb53fdg89gqndO5thQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ttk1oyF3cF9zozJAhbovrdjff2WZS52rLspuN3uMrrU=; b=Lm+afrUUR3q2r+3nKL1Bwnl98rDy/HZRQw0yXcNdmTZexs+bUkYMNykNzInZmd1cZXYT9RpgE7yzn1N3sVffTBw+eMMMRfdQPsTjVPcmWEc233plPLrhxsNpgXFh90qGaT8KgprMDDk2fgByzB/wQIGdq3JfGZedmC06n1clwCM= Received: from DS7PR03CA0201.namprd03.prod.outlook.com (2603:10b6:5:3b6::26) by CH2PR12MB9543.namprd12.prod.outlook.com (2603:10b6:610:27f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.21; Wed, 9 Apr 2025 05:36:04 +0000 Received: from DS1PEPF0001709A.namprd05.prod.outlook.com (2603:10b6:5:3b6:cafe::1a) by DS7PR03CA0201.outlook.office365.com (2603:10b6:5:3b6::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.35 via Frontend Transport; Wed, 9 Apr 2025 05:36:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0001709A.mail.protection.outlook.com (10.167.18.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8632.13 via Frontend Transport; Wed, 9 Apr 2025 05:36:03 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 9 Apr 2025 00:35:57 -0500 From: K Prateek Nayak To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , "Gautham R. Shenoy" , Mario Limonciello , "Rafael J. Wysocki" , Viresh Kumar , , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Swapnil Sapkal , "Dhananjay Ugwekar" , Huang Rui , "Perry Yuan" , K Prateek Nayak Subject: [PATCH v2 3/4] cpufreq/amd-pstate: Update asym_prefer_cpu when core rankings change Date: Wed, 9 Apr 2025 05:34:45 +0000 Message-ID: <20250409053446.23367-4-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409053446.23367-1-kprateek.nayak@amd.com> References: <20250409053446.23367-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709A:EE_|CH2PR12MB9543:EE_ X-MS-Office365-Filtering-Correlation-Id: 730df8ca-95eb-4dc6-9aa5-08dd77286b56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|36860700013|1800799024|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?SRv4Q2Og9IEUJCeF2DMMk4GYofTgFN45QlYiZBUWyBWn0QA37xRhtTOlFxQZ?= =?us-ascii?Q?pzWEp/VFNQ5wow+r1rcRj1l+r6iMfmanuWEoEe13nKlcrz59slhNU1TFq1Dl?= =?us-ascii?Q?1Iru9hdCcnmjSv4Npiq1Zz5u3b7MHu9e6RXkQW10Gwv3Vc9d6nXeZEyTV//f?= =?us-ascii?Q?5MejInWsHAp7TXW74Rb2enGDhyCe2zSM9HCIFF65fTwX6jgxZlAjefUi43k/?= =?us-ascii?Q?OREQS/rOxdk8UMJw72wXSf2xCWBHIUQM4wYWjKUFwuFZoyV2xXbRip/XWZaY?= =?us-ascii?Q?a43Hsb6r4ckOHc108ZddfSeeCbMT+QqL+RKGn4dWu4cJiNKuafL22jp0jUwZ?= =?us-ascii?Q?g9sOr9axzGpd+A++tIIDk5p2+DaurW4NZpH8nRxQlFF5xChEgnr8Cj21+Ndh?= =?us-ascii?Q?A2/UGvJuCdFXeBAzq1OLNxpW8yjkKYqcxX5QN7QMrELKGpcvphijkanf2KFN?= =?us-ascii?Q?4Wn7c+8gp1Nh2Z0opICoYQo78ygi7biNk5HIoxCjcs5NW+MO4OVdV8yjhK7h?= =?us-ascii?Q?h4kAjTg1uFCi1AAKdhiIwwDGJOt7MxY/94uICvu36jIKYGId8L3g1LFTsVz7?= =?us-ascii?Q?Rjmog56Vl3oL/iV63UZb3QbhFnjsHrOB2PbkL01yWITSloAn9DVwyNSYOqen?= =?us-ascii?Q?NyKadE+0iRKLxH/oN/BE+4uaCL4PJnxo6ySsfteOGK75BvNnjQS04Y7Dvono?= =?us-ascii?Q?I+iD5bVLCF3M9bol1iyGMdAa2FH8yHaZ+QiTcEXCC7njYFEBXd5PLevuisgf?= =?us-ascii?Q?ARmqIc9Rhi+p4GQhIGG3+kCKpcprM6G6iqEUD+sOZJpqtFoj9QzIF0rn98nu?= =?us-ascii?Q?rRihi3RTrukYAKSikPDVvgQAT8UBTX9b7gY6nKjf/GDz2+mW/bdJovgsGish?= =?us-ascii?Q?c6I3+WPMBJUpIgpGfrNfvwxHHGOxUuzHYgt7cAFSe8Y97mglmV6TIMEwVcKe?= =?us-ascii?Q?doRDUWcWo5DeEXdjtUNKGSu6ldBxWIn4g+zN7yBidV+Ehb8fEfugF/+NB/fs?= =?us-ascii?Q?qL7Dccvc/x6WbgA986Np0jQ9DHIgvMA5N8gYVf1LpsZOpXWAoBE/JGc7z54v?= =?us-ascii?Q?XK0CmTkusAZSfdiD0rufnC4TmeOOyRhtg96K323FyGlfxckuWzVkISjFmnu3?= =?us-ascii?Q?j0AUymX7qDJG11FG2ceNEtiEj0pOznx5Rb9pR/VA/jmW0GQLDWtw6vRTc4WU?= =?us-ascii?Q?hAsDDYJnYLsR9h9Z63MSJPJIXJXkRgaloY+2BK2EQdVbsHcW4YbXl6Zpozfo?= =?us-ascii?Q?LpGiIC06MBHbO6vhoO7PZugoaX8ACoS/pU4QhvtqkhkTCuB+a8aqIgDbZWBg?= =?us-ascii?Q?hCxIFTnIX+dxWAo9mBQW3PivxAEOGnYfvWjU+fCM2UwYjQQMv0mWzzBLwDqk?= =?us-ascii?Q?7G8f/m3Gjb4ku4F5AR6jM20XeK0hyH1qnw2dpyLS4bZxrJYc9YJmZyyi9pob?= =?us-ascii?Q?AmmN5Ndycl7nEMLTzEVlz7QRhCzySTH3SK9t8e3FQqXe9Wy2ntmt9mmfBTUP?= =?us-ascii?Q?WgX2/JodwmvdXvc=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(36860700013)(1800799024)(82310400026)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2025 05:36:03.8932 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 730df8ca-95eb-4dc6-9aa5-08dd77286b56 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709A.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB9543 Content-Type: text/plain; charset="utf-8" A subset of AMD systems supporting Preferred Core rankings can have their rankings changed dynamically at runtime. Update the "sg->asym_prefer_cpu" across the local hierarchy of CPU when the preferred core ranking changes. Signed-off-by: K Prateek Nayak Acked-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 6789eed1bb5b..8796217ccc60 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -844,8 +844,10 @@ static void amd_pstate_update_limits(unsigned int cpu) if (highest_perf_changed) { WRITE_ONCE(cpudata->prefcore_ranking, cur_high); =20 - if (cur_high < CPPC_MAX_PERF) + if (cur_high < CPPC_MAX_PERF) { sched_set_itmt_core_prio((int)cur_high, cpu); + sched_update_asym_prefer_cpu(cpu, prev_high, cur_high); + } } } =20 --=20 2.34.1 From nobody Sun Feb 8 04:33:44 2026 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2064.outbound.protection.outlook.com [40.107.236.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83D5F1DF247; Wed, 9 Apr 2025 05:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176988; cv=fail; b=gLEeATBPITGYuzbWsOQ/1TyfQU53BYTAviorHnvk/wZ6Lr/ipnNlculWJMtQwssHA0BvVnnnUt3K6k6IfO1bHF3LRkuLzmygxCarM3WS2SvE//HOjdQHlrHAnNbKvzP4f7buvp5neg0O39ma/zwwhRwuL8LqT9j5UiFGtj3NEfE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176988; c=relaxed/simple; bh=DVBe/TEGUI7mOGHYw6uyfB9gT4CiC7o3ljDY1foNWPU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pW3v+qxkHtn4+htJR301hwH/IZzu9b/FVdpW6RvTRD2QofMr9HKNIaMhlTk5cGCdJMNjRePA0xgpb/rpVQj25i+JzLaeuHItAQhcSEkiFgvGE7RlDGileVKYB9he4/uhxu6+1mexx1UOGYnehSkX+CX7cg8zwgjqq+YEzH/sBZA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=0IxJauRm; arc=fail smtp.client-ip=40.107.236.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="0IxJauRm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JoVtvH1RwK/qHht7NHJ/a7jF55ejkiF+vL9zxnj6ysN8NIZA1pBMiXC8V6W6Y68he+k5WMjksBMihtur+1nQn0WUiyKSUlmw3bUduLPznh+oN80fIp5EzDStYgwAY7xFyysKmYYWT8avNK+iRdY3yfbStsVGG0KExRsAMnPOtKbve7Y1488q34sZ+tUsAj3+o/wRjqzFkhBuAIFs/q3+T0pKAP76gD3Opjikof5I5me+VgvQ2rBxrJvVNHyALAb5GJN3c6t9MTLDY9Ki+QoKYqkeCAmMqkeFkxuAAz6xd6pdbgHBQ6gVTVaUNp8Pg+GSPzWE3ogsgZuw7/L5cMLGcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HyhI86zUUpoVdaaGUWJureedRCIR+v50GLCqgAHDC9k=; b=taRyZ+hF7V83/6V9Oq32klAgXZby2WrhDp4S6SE/AEZGb+c48VfgG3ejpnoKNHXCeC9TisVBWAfvNpdDBwR/rfM01kpELKKt7uwIrNAucf8gcsBusVhhf1k6MparTfe6sBQlfRzeUCFVj3cuFzY7gVnkfsp2zgT2im74D1/vIGr+ZRy+y2dARGIzXDSP23Sf5wj2ZLOe8e8Y/bG0gcoHCzoHBYHgEw6DFbMe5+7iGH8ZTyEfiUuFCFpeTA5c+oNPPtlne5ER5MAxo21dxiYDsOqqxtFEEXLQJw+v8Kg8Y6/BGXEoidr8iG9Qspa6r4CkLTufCUzSrNUcRlBCk+yG1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HyhI86zUUpoVdaaGUWJureedRCIR+v50GLCqgAHDC9k=; b=0IxJauRmmyjTMxqtlEDblv8nyvqsgMIuhZyyglKijgvrY39b/3kCaJ1UjGwlBxL2+pjYse9mJZa0JL+tv5/j/vBz4fM/m8E2LbJ3g7DksBWCmqtPc7jmDw7Ncz2U9aoYmn/8Y2QbDJrWTqRQhBmnuSTBZdAqPlRbbD1aVPSJDY8= Received: from DM6PR03CA0062.namprd03.prod.outlook.com (2603:10b6:5:100::39) by IA0PPFDDA81179A.namprd12.prod.outlook.com (2603:10b6:20f:fc04::be9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.20; Wed, 9 Apr 2025 05:36:23 +0000 Received: from DS1PEPF0001709C.namprd05.prod.outlook.com (2603:10b6:5:100:cafe::c5) by DM6PR03CA0062.outlook.office365.com (2603:10b6:5:100::39) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.36 via Frontend Transport; Wed, 9 Apr 2025 05:36:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0001709C.mail.protection.outlook.com (10.167.18.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8632.13 via Frontend Transport; Wed, 9 Apr 2025 05:36:22 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 9 Apr 2025 00:36:16 -0500 From: K Prateek Nayak To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , "Gautham R. Shenoy" , Mario Limonciello , "Rafael J. Wysocki" , Viresh Kumar , , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Swapnil Sapkal , "Dhananjay Ugwekar" , Huang Rui , "Perry Yuan" , K Prateek Nayak Subject: [PATCH v2 4/4] sched/debug: Print the local group's asym_prefer_cpu Date: Wed, 9 Apr 2025 05:34:46 +0000 Message-ID: <20250409053446.23367-5-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409053446.23367-1-kprateek.nayak@amd.com> References: <20250409053446.23367-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709C:EE_|IA0PPFDDA81179A:EE_ X-MS-Office365-Filtering-Correlation-Id: bdcdebaa-67c5-4675-7b3e-08dd772876a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|82310400026|36860700013|1800799024|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VSPpnPRFXhbYqWRmEgkGR1CLp0ZcGU310meUHFU9Pym+xacWfcXV9VmKn1YM?= =?us-ascii?Q?kXYmYNxXyVRJBQo27PVXkf3s6X1GYqDowhozQor5LkWQF6g+ylWrFicnxOqQ?= =?us-ascii?Q?QpFXPYfPSXVyMDFw2p22Vm5fd0WHZDVSFgM05K9Jlm2i24A+0qWbLwbkHZV7?= =?us-ascii?Q?UwGT5OololYCbZO3gmCqjNzTfC1t0UnhCnfUQwcYjpS/Unx8QswTr+LMNtlz?= =?us-ascii?Q?BhAcZDnScletzHDest7uwtRM3eDdvzpJ7iyiBJaYy6clJXKN/IjN0p4H8itB?= =?us-ascii?Q?zU+ln08/6Z+Uz0GLDDAmzoGUQWMcNEug2NMUfux98e5ExyW0R+aofBuXNZsv?= =?us-ascii?Q?v1vrEuOgqLK7aO+J3OiY0q5EoQSOODuZncDgjQTnv0RCkWEaaHkRX0EnDPWA?= =?us-ascii?Q?aRTB0GiMRoTjlg2hLHoDneOfAOFG/gpTnf9o2isO9SUae6XgtGwy6GgDNOb8?= =?us-ascii?Q?vLRjpXsdLM62e+FTQaOjAzUHMPAOKMRwS3apyHXr6FpvHqBReeOXyprAZTnw?= =?us-ascii?Q?Wos2szKGXU6BZre437WcjheheUW9ShFFDFVeZzt7scZNLCQBLiDjHiP1DfbK?= =?us-ascii?Q?qgany5pfxiMXKqMc/8ag84SUoCQBKfMMMimsIsTcFIVtIwPKues/JPXGhNmB?= =?us-ascii?Q?qpP+YdGQ8ROdE7QGTS0y+Q9NRm/rSNWpTwOmGK6/EdoP6JOIjh8g0tpBnncp?= =?us-ascii?Q?i4WpgVojNLmrVe2IRMwIf9PR+v1GbD9JB2rmTPxViNSk7YsvkJ/cOMIFKrrB?= =?us-ascii?Q?EtmcfuY+SVOomgwaHqG8eE87ahZ1M1WDwDsl0xFIj/2u34+F2GBWyGbeCKu6?= =?us-ascii?Q?d3MDqSiZSb/pC8297VNuzJd3c5jRsR8pqT5iMznHNFgXc4RBYacUmi0r93dA?= =?us-ascii?Q?gApdqzOSgBXdTagdSWWazpjwxxBwtYJmqj5PlvTt5mGdth8U8YtkZDYg8kje?= =?us-ascii?Q?iL+tQBbxPTv6Om5qSzbh8Rr0PlN/iJBKcIBvUjbN+9V8mqvmDfeebJnJOhS0?= =?us-ascii?Q?o/8dbOBCZaCRWcp7Sa/eMIV6MpT68RMGELWkA3NDOUzZ8YfVPBlOWRSPb03G?= =?us-ascii?Q?xELvuGOEbNg0+OG3PeaKbxFELuH5DqDhM2BlSGHq6B1qi1a5+4oWiWg7EwE1?= =?us-ascii?Q?i+sJ64ITpHzgJjGbFmvwn+dFh0OKYvmJjDglkdBi8+/q49W/WMWNgNlnSJ4c?= =?us-ascii?Q?uSciESlUHv+2ciZGxbuQ4ycgtxYI/KnvrmbBVJXBs20j66xE7Bl7htiP7im2?= =?us-ascii?Q?jLOl6dqF2d11YT/pWjr8fTQkrfKmevll4aLiTg2uKw0C+UnHFNSwJqqu2Ei7?= =?us-ascii?Q?S4K0F6pGcYA+XWOnjHwRy4t4VGNKKV3uW1eA30in7eeC8Jt3fehbFyCTK2S3?= =?us-ascii?Q?ePKW3CzxgBCdYyyY+QXJMfXc4VW2cZVS7sHDNd/TPWxA3pI8YE96KhWsUWkP?= =?us-ascii?Q?5rkp8sVxbEXb4sVAYgmU1KItSB7nwj0LAWxIcYnX2fkyfuxhVjFJEj7SSsD7?= =?us-ascii?Q?Lmy2eV1EPJTys8OvhFSgbbaOuEB5vPbOEqRets2XrbO1tB4u6tO3l+x+Kw?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(82310400026)(36860700013)(1800799024)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2025 05:36:22.8560 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bdcdebaa-67c5-4675-7b3e-08dd772876a6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709C.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PPFDDA81179A Content-Type: text/plain; charset="utf-8" Add a file to read local group's "asym_prefer_cpu" from debugfs. This information was useful when debugging issues where "asym_prefer_cpu" was incorrectly set to a CPU with a lower asym priority. Signed-off-by: K Prateek Nayak --- kernel/sched/debug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 56ae54e0ce6a..557246880a7e 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -588,6 +588,10 @@ static void register_sd(struct sched_domain *sd, struc= t dentry *parent) debugfs_create_file("flags", 0444, parent, &sd->flags, &sd_flags_fops); debugfs_create_file("groups_flags", 0444, parent, &sd->groups->flags, &sd= _flags_fops); debugfs_create_u32("level", 0444, parent, (u32 *)&sd->level); + + if (sd->flags & SD_ASYM_PACKING) + debugfs_create_u32("group_asym_prefer_cpu", 0444, parent, + (u32 *)&sd->groups->asym_prefer_cpu); } =20 void update_sched_domain_debugfs(void) --=20 2.34.1