From nobody Fri Dec 19 20:31:45 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2683C277805 for ; Wed, 9 Apr 2025 18:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744223872; cv=none; b=YXNsTBHf1T8Yx2Ri1arXURQ1UwUcNosnUpRxL9RjLDvcX6ByqEMRg6onnvkJR4OKygyUTxFUzF7/0hB08yHNSzXTjkCiHMR0VoUTmX7eyLqwy93Gn/fNf9tlc1LPVvZQRsOYOEbBH+2xZbEtYI8ZcKnyJ9LL4QyF4kxXbpazi2M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744223872; c=relaxed/simple; bh=uaSn6MwlcUjmKtZsVLaWOQsSsxy2zH+ZMA/NJ+Ecw1I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ni4UA4bFg4uAgXVXuOIPX2v9qS4csvQHTEm8fdPBa8AvvYntp9AqvAy4Ci3SlMrQoDCDJOgAIfgvr/K5FwLuEXgZPjd1Yck4Pel+3ZCnIc5ablGXnDIjLwxfPNg07RycKw7ZNCkSqCalMgpEk95YmicWqN9bHWhwcrbHYR1Qfg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=KirKT0OS; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="KirKT0OS" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-39c2688619bso4486326f8f.1 for ; Wed, 09 Apr 2025 11:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1744223868; x=1744828668; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5TWjREkBL8GjTju5ZPe7ZnjIycMK9O4uTTIH3dx3mcg=; b=KirKT0OSs6BzC8KRfTi+9CJxcLlGB6wlpXhYoPmmIgbdJn1ItQR6d0MTUaxP20SLoG ATye1h3NI1PUrxPvqaJFSbvTt2aeDeW5r9ircgRQzkKIeiUrUiM4oSlV7Ee8afgzZsig 4WAP1tkgTBQT51OLlUVr091OEYgkGSAIoq1fLTapCSVIq84fAkk3dI6RDF/AfCs7oInN BPfeWUvodTA5UG0wWwLdztiu0RPQ3PO7tvD84by4HIExKX2YP/TMe1ztjXvSSiUrfDva 1JsS1ASC4RVFeWqSiBb9reUGn1TWoPklVmaPhlUIA6WPWQaB0uyQCuCC8otMs0W6EKQ9 TwKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744223868; x=1744828668; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5TWjREkBL8GjTju5ZPe7ZnjIycMK9O4uTTIH3dx3mcg=; b=tjMbJ3PAkB+ijHBhCkQ+xaO6sgfE9SXxRtSxicag6NlZxOySg1lWY2mDqUXfUKGTlq RL1dK4P8Kwii0MopiMv7KupX+JEceA1NiMa+4E8isL/kWvhmaN/cwLGAuzI67AQLhvd+ JBWZEsm9WT/NDNRffGPfstbw2Xdhfn1YSVz8wiqyELWziaYUdO3TQsJiP1t0ekp1Ylij 8mCXnoOTEmwbkFMkZfuCiIx/wJaYhzsFYOJHYef/tiyXwDvgSpUkKJhwmDfSthJo0k3F vK8Hz/jc3ZWwOeOhipb4nxIFG23kHxXj0YF+vweKAqvXtnn4fV3zkrmwFwEbiorOBhn5 shPg== X-Forwarded-Encrypted: i=1; AJvYcCV4SQDugZHbGPjFTQRcxE2iQ/9z32iSBx80Slczpkf0xolIXV3OFxE9fBK3Z5T9sikj3kB3P8BaBoqjYCc=@vger.kernel.org X-Gm-Message-State: AOJu0YxmMaYySQtKGBLr0WfyJ8iB+700iPRnFWN6GbtWh45yLGz3fDdR 00gNsjBMwwIMzhkUM+Yw49y2MBD+8UuN6j6Whn7Iv2ugO0piY3tjKk3+7BCePJw= X-Gm-Gg: ASbGncvpXll4wgiT3pW6DzEzAZOpvS+5k8/aq0fp99zuPyZHUEWXF2sqKPz7LSse0SC XRlYFGIYFnx47S+xQ8BqKdTt7STOYea/wz6ttE91asdpcCkk8cvHWEg2FJr3kDSfcoHqEjOUmIs T4nxQM6Nbq+d3wX1ysWAYUXcV3lowp2VZ8pTIoCm9DJcZ1qrSNj9Dkpn5BK/X9dmVGvAf+74r+D mFl4nP693j9DmKrVtQYCdtg8wbFjKYXT7aPp3jgJbZYri++AKTQkOdUNM4HotldCkID9ypg/PfJ keC2xhKZRSZW/1ZChquHTmI5zqYqWirsAcKvenDUsEt82PxvmRkK1TguLMKJQDQJBnmbzF41Dq+ 72eFqvvpC2I0gXab4qQ== X-Google-Smtp-Source: AGHT+IHiD6DpDsPdWzofgt2e9mV3mId0ez7Jbo755xSenrxr4s0bEDbqHojT24paLUJ9xvA562w07g== X-Received: by 2002:a05:6000:381:b0:397:3900:ef8c with SMTP id ffacd0b85a97d-39d87adcb11mr4182487f8f.35.1744223868292; Wed, 09 Apr 2025 11:37:48 -0700 (PDT) Received: from [192.168.0.2] (host-87-15-70-119.retail.telecomitalia.it. [87.15.70.119]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d8938a808sm2380893f8f.53.2025.04.09.11.37.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 11:37:47 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Wed, 09 Apr 2025 20:36:28 +0200 Subject: [PATCH v5 1/5] iio: dac: adi-axi-dac: add cntrl chan check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250409-wip-bl-ad3552r-fixes-v5-1-fb429c3a6515@baylibre.com> References: <20250409-wip-bl-ad3552r-fixes-v5-0-fb429c3a6515@baylibre.com> In-Reply-To: <20250409-wip-bl-ad3552r-fixes-v5-0-fb429c3a6515@baylibre.com> To: =?utf-8?q?Nuno_S=C3=A1?= , Jonathan Cameron , Lars-Peter Clausen , Jonathan Corbet , Olivier Moysan , Michael Hennerich , David Lechner , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3092; i=adureghello@baylibre.com; h=from:subject:message-id; bh=UoS9PVUrR5VQ2Mqe4V6ZiAxOY0YtQJ30vm21lXMXNAw=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYkj/tk+3t3nK51dS9hPe71q8REPG88i90ug5DPnLHCdO2 JnXrG6/oaOUhUGMi0FWTJGlLjHCJPR2qJTyAsbZMHNYmUCGMHBxCsBE3s1nZPj2lefg1JNLai5O OfSB98DdyAXpwnyNrAYT5veFXmdtUjJn+O8gLu3NmuQWc3e2y+vIraWV8fMkOaoE+VTXaVg9YMq U4AMA X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello Add validity check on CNTRL_X channels (valid as 0 to 15). Reviewed-by: Nuno S=C3=A1 Signed-off-by: Angelo Dureghello --- drivers/iio/dac/adi-axi-dac.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.c index 892d770aec69c4259de777058801c9ab33c79923..f86acb98b0cffb09bf4d4626f93= 2bf1edc911e2b 100644 --- a/drivers/iio/dac/adi-axi-dac.c +++ b/drivers/iio/dac/adi-axi-dac.c @@ -84,6 +84,7 @@ #define AXI_DAC_CHAN_CNTRL_7_REG(c) (0x0418 + (c) * 0x40) #define AXI_DAC_CHAN_CNTRL_7_DATA_SEL GENMASK(3, 0) =20 +#define AXI_DAC_CHAN_CNTRL_MAX 15 #define AXI_DAC_RD_ADDR(x) (BIT(7) | (x)) =20 /* 360 degrees in rad */ @@ -186,6 +187,9 @@ static int __axi_dac_frequency_get(struct axi_dac_state= *st, unsigned int chan, u32 reg, raw; int ret; =20 + if (chan > AXI_DAC_CHAN_CNTRL_MAX) + return -EINVAL; + if (!st->dac_clk) { dev_err(st->dev, "Sampling rate is 0...\n"); return -EINVAL; @@ -230,6 +234,9 @@ static int axi_dac_scale_get(struct axi_dac_state *st, int ret, vals[2]; u32 reg, raw; =20 + if (chan->channel > AXI_DAC_CHAN_CNTRL_MAX) + return -EINVAL; + if (tone_2) reg =3D AXI_DAC_CHAN_CNTRL_3_REG(chan->channel); else @@ -264,6 +271,9 @@ static int axi_dac_phase_get(struct axi_dac_state *st, u32 reg, raw, phase; int ret, vals[2]; =20 + if (chan->channel > AXI_DAC_CHAN_CNTRL_MAX) + return -EINVAL; + if (tone_2) reg =3D AXI_DAC_CHAN_CNTRL_4_REG(chan->channel); else @@ -291,6 +301,9 @@ static int __axi_dac_frequency_set(struct axi_dac_state= *st, unsigned int chan, u16 raw; int ret; =20 + if (chan > AXI_DAC_CHAN_CNTRL_MAX) + return -EINVAL; + if (!sample_rate || freq > sample_rate / 2) { dev_err(st->dev, "Invalid frequency(%u) dac_clk(%llu)\n", freq, sample_rate); @@ -342,6 +355,9 @@ static int axi_dac_scale_set(struct axi_dac_state *st, u32 raw =3D 0, reg; int ret; =20 + if (chan->channel > AXI_DAC_CHAN_CNTRL_MAX) + return -EINVAL; + ret =3D iio_str_to_fixpoint(buf, 100000, &integer, &frac); if (ret) return ret; @@ -385,6 +401,9 @@ static int axi_dac_phase_set(struct axi_dac_state *st, u32 raw, reg; int ret; =20 + if (chan->channel > AXI_DAC_CHAN_CNTRL_MAX) + return -EINVAL; + ret =3D iio_str_to_fixpoint(buf, 100000, &integer, &frac); if (ret) return ret; @@ -493,6 +512,9 @@ static int axi_dac_data_source_set(struct iio_backend *= back, unsigned int chan, { struct axi_dac_state *st =3D iio_backend_get_priv(back); =20 + if (chan > AXI_DAC_CHAN_CNTRL_MAX) + return -EINVAL; + switch (data) { case IIO_BACKEND_INTERNAL_CONTINUOUS_WAVE: return regmap_update_bits(st->regmap, @@ -521,6 +543,8 @@ static int axi_dac_set_sample_rate(struct iio_backend *= back, unsigned int chan, unsigned int freq; int ret, tone; =20 + if (chan > AXI_DAC_CHAN_CNTRL_MAX) + return -EINVAL; if (!sample_rate) return -EINVAL; if (st->reg_config & AXI_DAC_CONFIG_DDS_DISABLE) --=20 2.49.0 From nobody Fri Dec 19 20:31:45 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4EFB278167 for ; Wed, 9 Apr 2025 18:37:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744223874; cv=none; b=GpI8pBJXfiRXOirynykMK4+vF7UiTeDBMSnLVTXwGmpt5eM2Y31+eAEbUXXLeDIdvg2Xgr5eNBc6ydXKT0lJf2lY2xMRhqiGDdRZuu4OQuIYLJSTTFcIw2edpU0p4Ug0K1SUWJa4qqIiWNgORoG9NDX1Bdj/Swdp76NzRIwricQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744223874; c=relaxed/simple; bh=op+FNBneI6h3+sV2ZZlwMqV5lcQPl5VA3Pzvyo21FgU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lcr5W8mbXeENoi2XwStCgV/b+QGufewF+vSS+nhEwyUmKJJ0biinCtiB4s1Yvt68fatch3AHp6GIO1YQXI4ZLGKsd1FyWPVftKl8OCd919d2zsUToADbeVm7tnyf/NzwfBspJkKAACa7SGA+FcYM2tr4A4J39BjQ+UmRJOQE1gw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ho8IeVwn; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ho8IeVwn" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-39c266c2dd5so6197424f8f.3 for ; Wed, 09 Apr 2025 11:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1744223870; x=1744828670; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=L7RQvOK6fXK41dO5HhHuRssJ1eoHSZj31eOEcLWUU5k=; b=ho8IeVwnAUCM0Ul+b1oOSQfoEDx58zPkEwM2Sfdy/nkJJFuydesxXqlbPwQQ1nT5fo h2BaJcusTFDcI54slJFAQ0SH4zVBgQFKAxGldx7yjn/OxKgs061iR2/jrm8j1P9s6sDn Jgqjty6sZ13WA87wwVYuquW/RN7GKVF9AeSRM7fjxaj50n4K7mrxgNvjGtBKG6/SF3fl 22X0cBdwv1vB+5xk9aQDcvhZX8G8nam2Vk+Gug3eg79VHNsj1QPTsgnQIaa7h/sNVQTb 5fl3eI5wT01chWO38kD1XWLUKd9Z0IxT4tbfra5+NjNu/vYfmbApClXVq8zdnCVrSp2U VS9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744223870; x=1744828670; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L7RQvOK6fXK41dO5HhHuRssJ1eoHSZj31eOEcLWUU5k=; b=Va1y49H33c64piVEaqu910x+bQhTueDHBxPXED6rs787TTkDSJS4PcVSonQ7SJhQJD oY4tl2nf6bo0ZVkjTt6rPlRDCa1dPDW9zAgdPN7k3d0b4jR2R9foepWOvXVldMoUw/ko eJuYZSQcf3Jdkv6ZVUaOcTXaDaTX050poqDwDgvFWxa5RKw5/h0TK+5D3IhUnHtBHiOC aXJ7an1pRa9qjPrH4APNyMEUMhNVpC4/37XNSJvwDUPTkv9xiiqdaH00tm4tyqyClp/t A0hTmI5z7gyZrpeKXoQyDsF1A4RN/MRA6vAnr3E7hFX1Zorr7SiIe1tyduolf9mKKffU DQxg== X-Forwarded-Encrypted: i=1; AJvYcCUxORijlWrdo5FyuTpRKzIm2hVXvyfblUxwvNP93HQF/tYiw4R43CYyjMGDQP9s3Qr4YNoIpLnhl895klY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5740em/9DC47SvZd8OZNd8ts9qKbm2cN8WxZfnE78JW3REYpO xl9HR4Nq9xrkNncIBk7tT3c5SX4Ub0lgUp+VACv7aRqUgLA/DMqhSXDAHen+hDA= X-Gm-Gg: ASbGncvK52zQtUGx+VKFWmQxb5RI62Sdb5HkJvtSyUoceklo+LFnnUD5BvEQ0ixWMpq ja8ZFvkewDC3NInVfEtlwi56ZIwLw/C/qYMabCRm6XyJB0qYWFVz5OmPwJegMZ1ccFcIrgCTOfr dlD2tEqdJ2XEw1JZIxSwexpISw/x1afDohUkAN6o6J+nmgtnulI7aEOqJYCKWeGMS0GgoCsisD3 haC811pWYhqUMUN+0v/k+cLEETlF7usy6payqRRio08K447g/wgpXdRURphDQzDSVaBx0xM+oI0 EpdSh6XIb0qiRcQJWCPR0Ojs1dOuYQd7ZWYCqEjLH2a0d8f1BPpR2RAvoqd71AnDFPX0sN4ilB8 49CqZEISxYSil2gXUyA== X-Google-Smtp-Source: AGHT+IEDHPm4LxkKIHaWsV3VkEh4vV7MWqjrpEXZp3f0HFZRY0uLOfZ60I6tOqq7efsrIH+dDqaIww== X-Received: by 2002:a5d:64e6:0:b0:391:1923:5a91 with SMTP id ffacd0b85a97d-39d87cde0b9mr3769040f8f.55.1744223869782; Wed, 09 Apr 2025 11:37:49 -0700 (PDT) Received: from [192.168.0.2] (host-87-15-70-119.retail.telecomitalia.it. [87.15.70.119]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d8938a808sm2380893f8f.53.2025.04.09.11.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 11:37:49 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Wed, 09 Apr 2025 20:36:29 +0200 Subject: [PATCH v5 2/5] docs: iio: add documentation for ad3552r driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250409-wip-bl-ad3552r-fixes-v5-2-fb429c3a6515@baylibre.com> References: <20250409-wip-bl-ad3552r-fixes-v5-0-fb429c3a6515@baylibre.com> In-Reply-To: <20250409-wip-bl-ad3552r-fixes-v5-0-fb429c3a6515@baylibre.com> To: =?utf-8?q?Nuno_S=C3=A1?= , Jonathan Cameron , Lars-Peter Clausen , Jonathan Corbet , Olivier Moysan , Michael Hennerich , David Lechner , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4317; i=adureghello@baylibre.com; h=from:subject:message-id; bh=8WrNMaaQ2xgbRizjN22pSBO+RAVh+prIiloygvq6/kQ=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYkj/tk+X+8602+/US/O41hwzOpblEdNTWrf8rUAg3wf2T X9r91fN6ChlYRDjYpAVU2SpS4wwCb0dKqW8gHE2zBxWJpAhDFycAjCR0gSGfxpLGL2vmAQJ9eQF P5/wJrH5he3m0OoM6ffcd1WXM3NKT2T4n1C6kj92s4W67I6+ramztt2f8OAmc+jrkx95ivrjJ/5 qYAcA X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello Add documentation for ad3552r driver, needed to describe the high-speed driver debugfs attributes and shows how the user may use them. Signed-off-by: Angelo Dureghello --- Documentation/iio/ad3552r.rst | 73 +++++++++++++++++++++++++++++++++++++++= ++++ Documentation/iio/index.rst | 1 + MAINTAINERS | 1 + 3 files changed, 75 insertions(+) diff --git a/Documentation/iio/ad3552r.rst b/Documentation/iio/ad3552r.rst new file mode 100644 index 0000000000000000000000000000000000000000..1539c2096ed9f9344da2e5d018e= 77a0524792270 --- /dev/null +++ b/Documentation/iio/ad3552r.rst @@ -0,0 +1,73 @@ +.. SPDX-License-Identifier: GPL-2.0-only + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D +AD3552R driver +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +Device driver for Analog Devices Inc. AD35XXR series of DACs. The module n= ame +is ``ad3552r``. +With the same module name, two different driver variants are available, the +``generic spi`` variant, to be used with any classic SPI controllers, and = the +``hs`` (high speed) variant, for an ADI ``axi-dac`` (IP core) based contro= ller +that allows to reach the maximum sample rate supported from the DACs, usin= g the +DMA transfer and all the SPI lines available (D/QDSPI).. +The high speed driver variant is intended to be used with the ``adi-axi-da= c`` +backend support enabled, that is enabled by default when the driver is sel= ected. + +Supported devices +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +* `AD3541R `_ +* `AD3542R `_ +* `AD3551R `_ +* `AD3552R `_ + +Wiring connections +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +Generic SPI +----------- +Use the classic SPI S_CLK/CS/SDO/SDI connection. + +High speed (using axi-dac backend) +---------------------------------- + +:: + + .-----------------. .-------. + | |--- D/QSPI -----| | + | DAC IP CORE |--- SPI S_CLK --| DAC | + | |--- SPI CS -----| | + | |--- LDAC -------| | + | |--- RESET ------| | + |_________________| |_______| + + +High speed features +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +Device attributes +----------------- + +The following table shows the ad35xxr related device debug files, found in= the +specific debugfs path ``/sys/kernel/debug/iio/iio:deviceX``. + ++-----------------------+-------------------------------------------------= -----+ +| Debugfs device files | Description = | ++-----------------------+-------------------------------------------------= -----+ +| data_source | The used data source, as = | +| | ``normal``, ``ramp-16bit``, etc. = | ++-----------------------+-------------------------------------------------= -----+ +| data_source_available | The available data sources. = | ++-----------------------+-------------------------------------------------= -----+ + +Usage examples +-------------- + +. code-block:: bash + root:/sys/bus/iio/devices/iio:device0# cat data_source + normal + root:/sys/bus/iio/devices/iio:device0# echo -n ramp-16bit > data_source + root:/sys/bus/iio/devices/iio:device0# cat data_source + ramp-16bit + diff --git a/Documentation/iio/index.rst b/Documentation/iio/index.rst index bbb2edce8272e7483acca500d1a757bbcc11c1e0..2d6afc5a8ed54a90cd8d5723f0d= c5212b8593d16 100644 --- a/Documentation/iio/index.rst +++ b/Documentation/iio/index.rst @@ -19,6 +19,7 @@ Industrial I/O Kernel Drivers .. toctree:: :maxdepth: 1 =20 + ad3552r ad4000 ad4030 ad4695 diff --git a/MAINTAINERS b/MAINTAINERS index 030d90d383411bbfe949cfff4f5bce27e3dd37c4..52d73ba42d8600632d00b7a25df= 9ed5bea84fa3d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1306,6 +1306,7 @@ L: linux-iio@vger.kernel.org S: Supported W: https://ez.analog.com/linux-software-drivers F: Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml +F: Documentation/iio/ad3552r.rst F: drivers/iio/dac/ad3552r.c =20 ANALOG DEVICES INC AD4000 DRIVER --=20 2.49.0 From nobody Fri Dec 19 20:31:45 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3EEF278179 for ; Wed, 9 Apr 2025 18:37:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744223875; cv=none; b=IG+CY6WErArH/14eYQO70wmpIj8MVJVm0ExMhJ5jNOoQNRKYtxVx+JynpKpL4YqvXwr2TdWSo6GmBYOfJ4pMNlOE9vMrnFOZd9bi2EMw5TxGu5zX6ksEv0UJVZRp9JBsCf2jBAaFWGlG6FkRFX+Z4/j/D7405lnS7fqYYjhqGgY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744223875; c=relaxed/simple; bh=lgsAI1C4GJ9f/lxYOr2FZ5rkqth02XBYIH8GiAkKCgM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DtTuzldi4sqE5h9QpL4PZYtByoRHfJr9DeSRRQQn8HN3/fMPno6UqnhneC+j55k0FmW3epPCN7jd7+PdOQsPFmb47a3GS6Q6jWS2VSlZV0iVjdv4aVxMZlUSzDEYgcGeTTiLlB6yhHaWGd/4lBWQnrNo4/z1yLen9EXtI5+DyIM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=kaMHHd33; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="kaMHHd33" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so363635e9.1 for ; Wed, 09 Apr 2025 11:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1744223871; x=1744828671; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QYLrYCRZJaz3Q9z9V56+5pPJKQA4s8QRrtBGVRh2868=; b=kaMHHd33wLPmKvgOjLsCi27pViHjgYO+lgezOxkOQ+MPM3sPx7RawFdlTFLMK/6iqw DkyLZDnuh+8hsVb/f/yP3LCHpugIpgweMzFXchfX3cu9wEAYKTO24l7tuFE1F87X3GzO mRgssJbzD7gqXC51mSQIDiu59R2PbBgsLktNabJ9DHr5yLVrtB6Pk0s9HbP8mPJ7+x2K nqEQO0l0M6/vg8o6U5QhW9iidV4D8FfQ84ByfvdNqaXjVx+1QVRv5fq0+m74igPaXOHo sAObKKAsehPstuXdO3VaL0dD5aivCopPSbLDN0MOoTu3i6O+RX6ntfKFUvxmGApQMhhX GTDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744223871; x=1744828671; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QYLrYCRZJaz3Q9z9V56+5pPJKQA4s8QRrtBGVRh2868=; b=RGIij7weV0QLkG+NwUeNJpRQSxQsdB1PkG8v5uv3K3/IzCuxP7wRvneadeEFtvRD1p F+W7isgt9ZnMNk0zoaaZ+/w+lXFcg9SA4ivFCGMS+dGI2kEPu/aomiFAGIbUQjTMjaF2 uRvuAIgX+ObZxJk8VhcCXItIi4apeMUDq2IEmClL0fhHxCbZnkMaLIme+inG04cfwaun hY7K0zY6DqBohzG06XIhL22bd24Qf0EXcR1ZtR3JXFCpHRIzcEabShf/JYnaiFlAsre8 bRnIAtnrjmk+qBRbAhxcSd2t9BbDHuU8mkvat385mfHZLHUMqooOPO3A6GIoBvRrzEIc JUAw== X-Forwarded-Encrypted: i=1; AJvYcCU0M9GVMbIMKO9yqW797uv0v/PdlTbYuWugFfoZctGX0YFJu8S2mZ8F07BQ4MzEKRAcs1F06qZtsptKqik=@vger.kernel.org X-Gm-Message-State: AOJu0YynwUtSZ3CDL+wsW6m0RJHR5CTBMepvtQGNZtdLjZtdrXSgqnyq LFlOjnrvdv+mX6ekUZ7H0UjwWGYxThCbO+qqHDyoEz4tPAmbn5tre0eo/MxdrNE= X-Gm-Gg: ASbGnctSCyXBCMw/hGCHH3y1ZjXKfNqAaMoJLXc+XECmlhrq6voYIxbTYFElXQA36kx NTlaxB3MLX5dw87uwfKKCtwFQLbOdc4Wrtj51FIuQqrMM3olG/Uzay+a9On5bh5RsHKdx3XJdip 21ruNaGKifiJKn8D+MWR74scTNXvoiIcqOcZk0xYOe4odNBdJYexrN7haYXxwWGBDX00CJVRQ1O SfWfuP3qLiMerlSUkLc3FEGkLFsTQplpYBs4N1tZYr2ysZpk3Vc8SYT8YmHKxzPJggs2oM8bp3l 5ASOlXTiN+rGkVxFJOy24asNYrNlSeupVSwkFhcl91eIAfkzX3zVxr80E4iUR5s+/H89a8YQ4qc UwxCkwMkbZwpijYM6gQ== X-Google-Smtp-Source: AGHT+IE/ANstT3msY29/I9nmhGxxk90Rx7ljncJfbkIER2ZUBChCz7EMdmqplF2DeEMhtxHiY8pz/A== X-Received: by 2002:a05:600c:4e4a:b0:43c:ed61:2c26 with SMTP id 5b1f17b1804b1-43f2d7d6f30mr1299565e9.17.1744223871230; Wed, 09 Apr 2025 11:37:51 -0700 (PDT) Received: from [192.168.0.2] (host-87-15-70-119.retail.telecomitalia.it. [87.15.70.119]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d8938a808sm2380893f8f.53.2025.04.09.11.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 11:37:50 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Wed, 09 Apr 2025 20:36:30 +0200 Subject: [PATCH v5 3/5] iio: backend: add support for data source get Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250409-wip-bl-ad3552r-fixes-v5-3-fb429c3a6515@baylibre.com> References: <20250409-wip-bl-ad3552r-fixes-v5-0-fb429c3a6515@baylibre.com> In-Reply-To: <20250409-wip-bl-ad3552r-fixes-v5-0-fb429c3a6515@baylibre.com> To: =?utf-8?q?Nuno_S=C3=A1?= , Jonathan Cameron , Lars-Peter Clausen , Jonathan Corbet , Olivier Moysan , Michael Hennerich , David Lechner , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3533; i=adureghello@baylibre.com; h=from:subject:message-id; bh=2lP6oKpb0hmzBUffbG/vd1ZR0rWtSFsiZRG8+MHxxuM=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYkj/tk93yjw1c9OwfQI/5UzdXZKj53dde5ln+Z7ZfXVn2 sxFc283d5SyMIhxMciKKbLUJUaYhN4OlVJewDgbZg4rE8gQBi5OAZhIkisjwykGWw2JpcG3n9iW VLDm3qzwjOf0/f5SIOL/o513C/pD9zP8U3bIXJnKfYDjXOPG3GIHP6bPPeeDLSemvjJ69/vaG0s vBgA= X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello Add backend support for getting the data source used. The ad3552r HDL implements an internal ramp generator, so adding the getter to allow data source get/set by debugfs. Reviewed-by: Nuno S=C3=A1 Signed-off-by: Angelo Dureghello --- drivers/iio/industrialio-backend.c | 28 ++++++++++++++++++++++++++++ include/linux/iio/backend.h | 5 +++++ 2 files changed, 33 insertions(+) diff --git a/drivers/iio/industrialio-backend.c b/drivers/iio/industrialio-= backend.c index a43c8d1bb3d0f4dda4277cac94b0ea9232c071e4..c1eb9ef9db08aec8437d0d00cf7= 7914ad6611b72 100644 --- a/drivers/iio/industrialio-backend.c +++ b/drivers/iio/industrialio-backend.c @@ -380,6 +380,34 @@ int iio_backend_data_source_set(struct iio_backend *ba= ck, unsigned int chan, } EXPORT_SYMBOL_NS_GPL(iio_backend_data_source_set, "IIO_BACKEND"); =20 +/** + * iio_backend_data_source_get - Get current data source + * @back: Backend device + * @chan: Channel number + * @data: Pointer to receive the current source value + * + * A given backend may have different sources to stream/sync data. This al= lows + * to know what source is in use. + * + * RETURNS: + * 0 on success, negative error number on failure. + */ +int iio_backend_data_source_get(struct iio_backend *back, unsigned int cha= n, + enum iio_backend_data_source *data) +{ + int ret; + + ret =3D iio_backend_op_call(back, data_source_get, chan, data); + if (ret) + return ret; + + if (*data >=3D IIO_BACKEND_DATA_SOURCE_MAX) + return -EINVAL; + + return 0; +} +EXPORT_SYMBOL_NS_GPL(iio_backend_data_source_get, "IIO_BACKEND"); + /** * iio_backend_set_sampling_freq - Set channel sampling rate * @back: Backend device diff --git a/include/linux/iio/backend.h b/include/linux/iio/backend.h index e45b7dfbec35c094942a3034fc6057a7960b9772..e59d909cb65924b4872cadd4b7e= 5e894c13c189f 100644 --- a/include/linux/iio/backend.h +++ b/include/linux/iio/backend.h @@ -84,6 +84,7 @@ enum iio_backend_interface_type { * @chan_disable: Disable one channel. * @data_format_set: Configure the data format for a specific channel. * @data_source_set: Configure the data source for a specific channel. + * @data_source_get: Data source getter for a specific channel. * @set_sample_rate: Configure the sampling rate for a specific channel. * @test_pattern_set: Configure a test pattern. * @chan_status: Get the channel status. @@ -115,6 +116,8 @@ struct iio_backend_ops { const struct iio_backend_data_fmt *data); int (*data_source_set)(struct iio_backend *back, unsigned int chan, enum iio_backend_data_source data); + int (*data_source_get)(struct iio_backend *back, unsigned int chan, + enum iio_backend_data_source *data); int (*set_sample_rate)(struct iio_backend *back, unsigned int chan, u64 sample_rate_hz); int (*test_pattern_set)(struct iio_backend *back, @@ -176,6 +179,8 @@ int iio_backend_data_format_set(struct iio_backend *bac= k, unsigned int chan, const struct iio_backend_data_fmt *data); int iio_backend_data_source_set(struct iio_backend *back, unsigned int cha= n, enum iio_backend_data_source data); +int iio_backend_data_source_get(struct iio_backend *back, unsigned int cha= n, + enum iio_backend_data_source *data); int iio_backend_set_sampling_freq(struct iio_backend *back, unsigned int c= han, u64 sample_rate_hz); int iio_backend_test_pattern_set(struct iio_backend *back, --=20 2.49.0 From nobody Fri Dec 19 20:31:45 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72C5D279331 for ; Wed, 9 Apr 2025 18:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744223876; cv=none; b=mULLU/sx/i4b/4RfhlGfk4t6Xr62o0DOz1IVc1VBdkkr+M60ZELmOpSegnrC74fLJ/RJdEaHBRQYVbgkWsbiFVtH6bxrkG2O4H7jse/Fxc3PpF/I81yf5kfU1ehmpV/doB4dUcJqVyVotnDn3ZDRbWVNbzLzDFPpJMBepoMhz20= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744223876; c=relaxed/simple; bh=4KSeXmCw6z9Bh/u/zmCWqVRpCXcjpLPI9k+ZizbF7YE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Usq+LnfNOOPJFCZce3u/I8mvWtlPMiuNNfZLpvvDN4wYwlgoeTnM1j4LMzTFeuITuh1quPmfnqBmLbu1KC1dynRw6lex8lDK7Wy23XNDxUE0MiPyRWZxADeu4J0fQAjkjd5W18ZZBWtWc+x+jWOliN9P1bNTZ+9wH6R7KfZDG7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=KEax1Vtj; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="KEax1Vtj" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43cf3192f3bso412335e9.1 for ; Wed, 09 Apr 2025 11:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1744223873; x=1744828673; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wgEWndJtLeto4lW/nFUn4b5LOfScisxB+yrfREee8i4=; b=KEax1Vtj+O82sy4sLlKZeSmrfxtwjSF2mkERa1E8p4m4Oq97OEYCEgCqfWTR9hglCI v8sfyowHdNyz2rwBA9/z3P6QHRIdW4iPrqVxjkZzbsp3/WkVJd957l2mziZd8Xom84/d T6XZgSQQg+i6MX1e9n/XeKu71qSdd1gGv6zqFzkJS7c4Jef0UTknNFE7BB+TL3QUqp2g NVS0p1fFTISNkqyPRjihs3ECxvfwpBTLKLnjTsezMRRfsbbl5SfhonkIjkTPF7eoLEmL KJCWq2D06szItJm9A6CA0g9u+vyNaJ1d2bvmo5ByUE9VR49Y5atHF5JmVnycBKBlBBu7 /n5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744223873; x=1744828673; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wgEWndJtLeto4lW/nFUn4b5LOfScisxB+yrfREee8i4=; b=eupANyV4Ys1b0PRDMc3JspJYE/EqFGen4H+N8K/rubg15HMOQEt/AULNkyfAzQOKWn FJBkmE9cE6PVCwP+Kw2S1NPBww/5skyhkgbE296QTxXX5fwTWGM8SMO7V/1L2hcOTG71 FWEnM2HIHpPTXOav9d/0kDvHsl+ZYtdkPFib7HS90bBOSQQL8Cc4PqJrQmVOtJAwVQUQ gNavUMvSWmME9BlnOYuFP66YtIAfGfSRQP1p4upKdpWUHCuB+Rf5av6QDXDFVvSCQ7RS +IDUjqYEAeGUsV9EshavDzuwHrbO87MBwIQE2PJ6Z0E5KL/RH5teJqaZ0+eDEjRsVG5+ wXwQ== X-Forwarded-Encrypted: i=1; AJvYcCX2TZi2E+iB0PUzXmudrCgsYKuCdLvtBzPgOi3aJrEmOn8yisPtDLQYWqtmOHcVZYy44J95E+4+3Fyxhd8=@vger.kernel.org X-Gm-Message-State: AOJu0YzfsvS02zPFK0eppc6BfJSzY456/NtBK0nPwltfR6ThoFHBgVhA UQ/z6+F6F2oC69pf+RF9Lta5XBy47gQ6NmI0ERDsT621Ioeg42abzDOsSZj7qPo= X-Gm-Gg: ASbGncs+dfhIu+Y/uUxsB+9czNgGjXZokgDX6piuG1KnCCbjnOzvnFC9lDE0bcxL1ou /3Dulh79t/J4UfmyLaoDJfKlUbYX76HtfNl3+qluYH1LbHtDjrmOHsHDq/i6KK7j4duFuAMOZAy dMuClgZ9A/tjZtwduh2vtS/BV/ffhvXHCqXwNI4qH7cg0v81kaHSVk+//T/JPrVQMNDsh2cX+pM 0+CCrWHSV7n9CiEsBvlNzftJSQyy7SfdYvLZEO+vaAGjw0Y/nFcn6ybcOe0gQzBiBja6CI4Bxfq StWmARnUSGf7c2AM8btTTT35X6w2G2+Nu5+QAvApKP0BQt25GBprxZnsK66HwFwnWNi8MtOB22o b4aPw4pxbkdbXC1ivbg== X-Google-Smtp-Source: AGHT+IGhnjsUYIKak18vf2AjiqrVr6PTz+TdAb+bfMFgpDd2yhja/tIUWo0cL35H9SHSSBFxnRJAzQ== X-Received: by 2002:a05:600c:1388:b0:43c:f44c:72a6 with SMTP id 5b1f17b1804b1-43f2d7aef33mr1285935e9.2.1744223872642; Wed, 09 Apr 2025 11:37:52 -0700 (PDT) Received: from [192.168.0.2] (host-87-15-70-119.retail.telecomitalia.it. [87.15.70.119]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d8938a808sm2380893f8f.53.2025.04.09.11.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 11:37:52 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Wed, 09 Apr 2025 20:36:31 +0200 Subject: [PATCH v5 4/5] iio: dac: adi-axi-dac: add data source get Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250409-wip-bl-ad3552r-fixes-v5-4-fb429c3a6515@baylibre.com> References: <20250409-wip-bl-ad3552r-fixes-v5-0-fb429c3a6515@baylibre.com> In-Reply-To: <20250409-wip-bl-ad3552r-fixes-v5-0-fb429c3a6515@baylibre.com> To: =?utf-8?q?Nuno_S=C3=A1?= , Jonathan Cameron , Lars-Peter Clausen , Jonathan Corbet , Olivier Moysan , Michael Hennerich , David Lechner , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1828; i=adureghello@baylibre.com; h=from:subject:message-id; bh=FaVSbpu5wfHy4/JtVk4ww5/ACGVgPb27AkggQGWKjsw=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYkj/tk/3/TTjX4oeLMf3P5ylUecaw+L66o758/xnZiKX7 CTTntxj7yhlYRDjYpAVU2SpS4wwCb0dKqW8gHE2zBxWJpAhDFycAjCR5ewM/x0Lbt54fu90np9E QMjB+qCmtXf6fB7mHigweBx+9ZHMgvmMDD8lq265S5v33cq3Pbrh95neud4CWmJ22s9PH5qxIWr qQV4A X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello Add data source getter. Reviewed-by: Nuno S=C3=A1 Signed-off-by: Angelo Dureghello --- drivers/iio/dac/adi-axi-dac.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.c index f86acb98b0cffb09bf4d4626f932bf1edc911e2b..8ed5ad1fa24cef649056bc5f4ca= 80abbf28b9323 100644 --- a/drivers/iio/dac/adi-axi-dac.c +++ b/drivers/iio/dac/adi-axi-dac.c @@ -536,6 +536,35 @@ static int axi_dac_data_source_set(struct iio_backend = *back, unsigned int chan, } } =20 +static int axi_dac_data_source_get(struct iio_backend *back, unsigned int = chan, + enum iio_backend_data_source *data) +{ + struct axi_dac_state *st =3D iio_backend_get_priv(back); + int ret; + u32 val; + + if (chan > AXI_DAC_CHAN_CNTRL_MAX) + return -EINVAL; + + ret =3D regmap_read(st->regmap, AXI_DAC_CHAN_CNTRL_7_REG(chan), &val); + if (ret) + return ret; + + switch (val) { + case AXI_DAC_DATA_INTERNAL_TONE: + *data =3D IIO_BACKEND_INTERNAL_CONTINUOUS_WAVE; + return 0; + case AXI_DAC_DATA_DMA: + *data =3D IIO_BACKEND_EXTERNAL; + return 0; + case AXI_DAC_DATA_INTERNAL_RAMP_16BIT: + *data =3D IIO_BACKEND_INTERNAL_RAMP_16BIT; + return 0; + default: + return -EIO; + } +} + static int axi_dac_set_sample_rate(struct iio_backend *back, unsigned int = chan, u64 sample_rate) { @@ -818,6 +847,7 @@ static const struct iio_backend_ops axi_ad3552r_ops =3D= { .request_buffer =3D axi_dac_request_buffer, .free_buffer =3D axi_dac_free_buffer, .data_source_set =3D axi_dac_data_source_set, + .data_source_get =3D axi_dac_data_source_get, .ddr_enable =3D axi_dac_ddr_enable, .ddr_disable =3D axi_dac_ddr_disable, .data_stream_enable =3D axi_dac_data_stream_enable, --=20 2.49.0 From nobody Fri Dec 19 20:31:45 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C16702777F3 for ; Wed, 9 Apr 2025 18:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744223877; cv=none; b=gUoObGw25h1JdCwM34E7gk2Xqh6VqUTxdf8o9v4NLGh9u3kNmldiR5d/+Fhwq+VKsCEtrjVySWqxmVK0KbEkUjs2+YVSvFHkR/F5+fTsMW8MkBxuRD/IYePDM4RKncHTz6MoJQwBA+Oi1jnaq8DZOREjn7P7GC9OO3qa/eFPmwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744223877; c=relaxed/simple; bh=yUszYyKId2jMHliG8dEQoAHpckhzLYeakl04OcdUtHE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hie9V4DjjCKcNBDBa7PNh2/2wBw/rix0uG7k9r2nQhAxFTtx/PUFCfrD/V9LJYd7J8g3ydIXzCmkRD+bFFdN+mgF58kE3qDSPrUy0iFfi08D/IEF7JvSC1aT+7sB5a+8vpcI1AhoWV0gP/6/4KnXk+yEF+5Q7z/QFnpJQZG1Ud4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=i4vpogBl; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="i4vpogBl" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cf034d4abso322525e9.3 for ; Wed, 09 Apr 2025 11:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1744223874; x=1744828674; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FBY5l+PixCp4ufP2Qw107Vu8CITzsN6iXMKODMyTjH4=; b=i4vpogBl+KjhiJPXX49msagxiFOS1k7Z3/c2Rp4FBrIsitfnWKe7Y3rHjxOuZljdhc f/j8hUsu3/LVvSliJxx5iDZsFnieOyS1Iru80Lf5L1d19RvUdVGEwNPCQA2jsHeVtq3c Py/B+f2G1AX7ELIJDUmBkO/Y/r/zeqin+Te08epjxmccic6yReQDOAyxXyvTc/MeipkG ptosfmH4t/Eyno1rqY3gPD2uFartzjl99czaCupkHihloFZhh0R0SAfBSgZTMdeW/li5 qIEQEJuPNW8xW9vSikm6e2fKL1LwumI/gBMLKxzsah3QFlO+rILMzxhtQ0WCULYGoO9Z eSsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744223874; x=1744828674; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FBY5l+PixCp4ufP2Qw107Vu8CITzsN6iXMKODMyTjH4=; b=UmW916ZkY5rxTRG/ly+/qmfRViR5/u9WrMJryjjVMZJRRL5o4GyuIinexZO6ezWC92 YOCTSnIhFiLig2olVXLrZco0iLybv3V/gF/pEoKP6H3q8fCFhWvNrp/TQUDhQTBu91hM 8tXmgTo2sugndJC2xsgtT86KeetjuPK0pA93+W0Z4rhXvyvho7xczTlKfsnuj2LCHpuG jsSJ47htUekhmerjkRvX2aDGwL+GGNLdZVxYTxvcNsiIw6bjWIwTJf5VYCX7tVr2A4Pf me+R3bkiw0ZMsGjQl9qLLSx8qIg8wgcsWx8FBkCPVSFW/3i22Rr45HP+EprzVv4SCtfH Chog== X-Forwarded-Encrypted: i=1; AJvYcCWbgYKDP52A5g9o7WlNvaYlI2eerHIRNYtSncvAIdXNqzNR+dxAVhQI58xdx3MA95e8jNtPXcCk7oSKXX8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyz2f13sI7qb1W0/z6yieDby8JJD70vusCoI5rZ4Qs+RnULAOhQ OS4rlm4WQ1X9DwZrBQQN9sACO7QcY8OzZ2jb71fZ2A5erPhHgevoawTO1ddVi9I= X-Gm-Gg: ASbGnctbsyTzlEYju9kRLRoutv4CvCYtsMEw/tz86Q7xcVkrxcMs10MQ1veUpQ0oEIF vLAuNnnYYPFgVzYVzeZim6i1xciJMx5DRTLN1dnqPkfNsJX5bJaT8V3DYl26bECt4lnP1re/Boz +smtUNuo4vXLSH4/fcm/MQ9m3Ag7b6vs3cKYmUg3XaJiHLJMMFLbwdQmYMGfiKKF4cjgE4aDgUb KBwaQ6LDKs6f6Qqs4pp2arbzSuKniJEchd5wGVX3Ey0WgZpdQZLUuLjbusPLYC4MK97Z0Bx+1Ev 41sk+qdmcUq3MeHy9kgaaX/uYo1NziaNHoY4d66tpC5/IeTQwtCrvkJYGhIVAp3DUYedZodxi0C sLQCon+6dPy+TyUGpPQ== X-Google-Smtp-Source: AGHT+IFAKC1xQ+SvFIBAdWECoN8vWGtjTzlgIUSPfh1SZkL4Rn9KgapuDRcRLhk3lTM3F4qh4/7TRA== X-Received: by 2002:a05:600c:1d15:b0:43c:e7a7:aea0 with SMTP id 5b1f17b1804b1-43f2d95298emr706915e9.26.1744223874070; Wed, 09 Apr 2025 11:37:54 -0700 (PDT) Received: from [192.168.0.2] (host-87-15-70-119.retail.telecomitalia.it. [87.15.70.119]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d8938a808sm2380893f8f.53.2025.04.09.11.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 11:37:53 -0700 (PDT) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Wed, 09 Apr 2025 20:36:32 +0200 Subject: [PATCH v5 5/5] iio: dac: ad3552r-hs: add support for internal ramp Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250409-wip-bl-ad3552r-fixes-v5-5-fb429c3a6515@baylibre.com> References: <20250409-wip-bl-ad3552r-fixes-v5-0-fb429c3a6515@baylibre.com> In-Reply-To: <20250409-wip-bl-ad3552r-fixes-v5-0-fb429c3a6515@baylibre.com> To: =?utf-8?q?Nuno_S=C3=A1?= , Jonathan Cameron , Lars-Peter Clausen , Jonathan Corbet , Olivier Moysan , Michael Hennerich , David Lechner , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=6257; i=adureghello@baylibre.com; h=from:subject:message-id; bh=T5gEGbn9x5iyN8FJ+4Cc7jt+UgcnAHYwk2vPwTx/Tms=; b=owGbwMvMwCXGf3bn1e/btlsznlZLYkj/tk+P+ZJCb7rSPJ8PDz1++XIKz0/crbhZWywt9npGU XT5zeagjlIWBjEuBlkxRZa6xAiT0NuhUsoLGGfDzGFlAhnCwMUpABMJ3MvwP3Fa6/zdG9/93m9i ++qQ9msvjWVTEhZs5J12eM2uv7f6Z05m+MMb/vDQhs8nDp/lti645DvZPPpunOTzfREvXNpn3kt uOM8GAA== X-Developer-Key: i=adureghello@baylibre.com; a=openpgp; fpr=703CDFAD8B573EB00850E38366D1CB9419AF3953 From: Angelo Dureghello The ad3552r can be feeded from the HDL controller by an internally generated 16bit ramp, useful for debug pourposes. Add debugfs a file to enable or disable it. Signed-off-by: Angelo Dureghello --- drivers/iio/dac/ad3552r-hs.c | 162 +++++++++++++++++++++++++++++++++++++++= ++-- 1 file changed, 156 insertions(+), 6 deletions(-) diff --git a/drivers/iio/dac/ad3552r-hs.c b/drivers/iio/dac/ad3552r-hs.c index 37397e188f225a8099745ec03f7c604da76960b1..41b96b48ba98b6009723c6a7c0c= 39071083852f8 100644 --- a/drivers/iio/dac/ad3552r-hs.c +++ b/drivers/iio/dac/ad3552r-hs.c @@ -7,6 +7,7 @@ */ =20 #include +#include #include #include #include @@ -54,6 +55,18 @@ struct ad3552r_hs_state { struct ad3552r_hs_platform_data *data; /* INTERFACE_CONFIG_D register cache, in DDR we cannot read values. */ u32 config_d; + /* Protects backend I/O operations from concurrent accesses. */ + struct mutex lock; +}; + +enum ad3552r_sources { + AD3552R_SRC_NORMAL, + AD3552R_SRC_RAMP_16BIT, +}; + +static const char * const dbgfs_attr_source[] =3D { + [AD3552R_SRC_NORMAL] =3D "normal", + [AD3552R_SRC_RAMP_16BIT] =3D "ramp-16bit", }; =20 static int ad3552r_hs_reg_read(struct ad3552r_hs_state *st, u32 reg, u32 *= val, @@ -65,6 +78,20 @@ static int ad3552r_hs_reg_read(struct ad3552r_hs_state *= st, u32 reg, u32 *val, return st->data->bus_reg_read(st->back, reg, val, xfer_size); } =20 +static int ad3552r_hs_set_data_source(struct ad3552r_hs_state *st, + enum iio_backend_data_source type) +{ + int i, ret; + + for (i =3D 0; i < st->model_data->num_hw_channels; ++i) { + ret =3D iio_backend_data_source_set(st->back, i, type); + if (ret) + return ret; + } + + return 0; +} + static int ad3552r_hs_update_reg_bits(struct ad3552r_hs_state *st, u32 reg, u32 mask, u32 val, size_t xfer_size) { @@ -483,6 +510,103 @@ static int ad3552r_hs_reg_access(struct iio_dev *indi= o_dev, unsigned int reg, return st->data->bus_reg_write(st->back, reg, writeval, 1); } =20 +static ssize_t ad3552r_hs_show_data_source(struct file *f, char __user *us= erbuf, + size_t count, loff_t *ppos) +{ + struct ad3552r_hs_state *st =3D file_inode(f)->i_private; + enum iio_backend_data_source type; + int idx, ret; + + guard(mutex)(&st->lock); + + ret =3D iio_backend_data_source_get(st->back, 0, &type); + if (ret) + return ret; + + switch (type) { + case IIO_BACKEND_INTERNAL_RAMP_16BIT: + idx =3D AD3552R_SRC_RAMP_16BIT; + break; + case IIO_BACKEND_EXTERNAL: + idx =3D AD3552R_SRC_NORMAL; + break; + default: + return -EINVAL; + } + + return simple_read_from_buffer(userbuf, count, ppos, + dbgfs_attr_source[idx], + strlen(dbgfs_attr_source[idx])); +} + +static ssize_t ad3552r_hs_write_data_source(struct file *f, + const char __user *userbuf, + size_t count, loff_t *ppos) +{ + struct ad3552r_hs_state *st =3D file_inode(f)->i_private; + char buf[64]; + int ret, source; + + guard(mutex)(&st->lock); + + ret =3D simple_write_to_buffer(buf, sizeof(buf) - 1, ppos, userbuf, + count); + if (ret < 0) + return ret; + + buf[count] =3D '\0'; + + ret =3D match_string(dbgfs_attr_source, ARRAY_SIZE(dbgfs_attr_source), + buf); + if (ret < 0) + return ret; + + switch (ret) { + case AD3552R_SRC_RAMP_16BIT: + source =3D IIO_BACKEND_INTERNAL_RAMP_16BIT; + break; + case AD3552R_SRC_NORMAL: + source =3D IIO_BACKEND_EXTERNAL; + break; + default: + return -EINVAL; + } + + ret =3D ad3552r_hs_set_data_source(st, source); + if (ret) + return ret; + + return count; +} + +static ssize_t ad3552r_hs_show_data_source_avail(struct file *f, + char __user *userbuf, + size_t count, loff_t *ppos) +{ + ssize_t len =3D 0; + char buf[128]; + int i; + + for (i =3D 0; i < ARRAY_SIZE(dbgfs_attr_source); i++) { + len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s ", + dbgfs_attr_source[i]); + } + buf[len - 1] =3D '\n'; + + return simple_read_from_buffer(userbuf, count, ppos, buf, len); +} + +static const struct file_operations ad3552r_hs_data_source_fops =3D { + .owner =3D THIS_MODULE, + .write =3D ad3552r_hs_write_data_source, + .read =3D ad3552r_hs_show_data_source, +}; + +static const struct file_operations ad3552r_hs_data_source_avail_fops =3D { + .owner =3D THIS_MODULE, + .read =3D ad3552r_hs_show_data_source_avail, +}; + static int ad3552r_hs_setup(struct ad3552r_hs_state *st) { u16 id; @@ -550,11 +674,7 @@ static int ad3552r_hs_setup(struct ad3552r_hs_state *s= t) if (ret) return ret; =20 - ret =3D iio_backend_data_source_set(st->back, 0, IIO_BACKEND_EXTERNAL); - if (ret) - return ret; - - ret =3D iio_backend_data_source_set(st->back, 1, IIO_BACKEND_EXTERNAL); + ret =3D ad3552r_hs_set_data_source(st, IIO_BACKEND_EXTERNAL); if (ret) return ret; =20 @@ -661,6 +781,26 @@ static const struct iio_info ad3552r_hs_info =3D { .debugfs_reg_access =3D &ad3552r_hs_reg_access, }; =20 +static void ad3552r_hs_debugfs_init(struct iio_dev *indio_dev) +{ + struct ad3552r_hs_state *st =3D iio_priv(indio_dev); + struct dentry *d =3D iio_get_debugfs_dentry(indio_dev); + + if (!IS_ENABLED(CONFIG_DEBUG_FS)) + return; + + d =3D iio_get_debugfs_dentry(indio_dev); + if (!d) { + dev_warn(st->dev, "can't set debugfs in driver dir\n"); + return; + } + + debugfs_create_file("data_source", 0600, d, st, + &ad3552r_hs_data_source_fops); + debugfs_create_file("data_source_available", 0600, d, st, + &ad3552r_hs_data_source_avail_fops); +} + static int ad3552r_hs_probe(struct platform_device *pdev) { struct ad3552r_hs_state *st; @@ -705,7 +845,17 @@ static int ad3552r_hs_probe(struct platform_device *pd= ev) if (ret) return ret; =20 - return devm_iio_device_register(&pdev->dev, indio_dev); + ret =3D devm_iio_device_register(&pdev->dev, indio_dev); + if (ret) + return ret; + + ret =3D devm_mutex_init(&pdev->dev, &st->lock); + if (ret) + return ret; + + ad3552r_hs_debugfs_init(indio_dev); + + return ret; } =20 static const struct of_device_id ad3552r_hs_of_id[] =3D { --=20 2.49.0